[12:33] <frankban> uiteam: I need two reviews and (possibly) two QAs for https://codereview.appspot.com/174790043 (quickstart/python). This is a long diff (sorry) with some interesting changes, including dropping support for juju < 1.18. Any help really appreciated. Thanks!
[13:26] <rick_h_> frankban: rgr
[13:28] <frankban> rick_h_: thanks
[14:20] <hatch> morning all
[14:25] <hatch> kadams54-away: can we push the call 5mins?
[14:33] <hatch> rick_h_: they are calling winter here now a 'polar vortex'
[14:33] <hatch> nearly spit my coffee out when I read that
[14:37] <hatch> kadams54-away: ping when you return and we can start on that AS chat
[14:48] <kadams54> hatch: back
[14:49] <hatch> welcome
[14:49] <hatch> my coffee is almost cold
[14:49] <hatch> I think I need a heated cup
[14:50] <kadams54> I just figured everything in the Canadian prairie lands was heated.
[14:50] <kadams54> Engine heaters, heated sidewalks, heated gutters, heated cups…
[14:52] <rick_h_> hatch: yea, pretty much
[14:52] <hatch> haha - heated sidewalks, where do you think I live? In the rich area?
[14:53] <kadams54> hatch: FYI, I'm in themeeting room.
[14:54] <hatch> oh ok, joining
[14:54] <hatch> maybe...
[15:05] <kadams54> hatch: freakin' google
[15:05] <hatch> lol
[15:05] <kadams54> hatch: multiuser randomly decided to time out on my canonical login
[15:05] <hatch> ohh yeah that happens and always during a call lol
[15:06] <kadams54> Well, probably not randomly, but I hit my "keep me logged in" timeout
[15:40] <whit> 502 https://jujucharms.com/docs/
[15:41] <whit> Bad bad gateway
[15:42] <rick_h_> whit: yea, it's not there
[15:42] <rick_h_> whit: bad link, fixed in trunk and will try to release
[15:42] <whit> gotcha
[15:43] <whit> cool, glad it's know
[15:43] <whit> n
[15:52] <hatch> kadams54: I'll create the cards right now
[15:52] <kadams54> Excellent
[15:55] <hatch> kadams54: ok the three steps are done
[15:55] <hatch> I think splitting it up into these three will make them 1 day/card
[15:55] <hatch> ish
[15:55] <kadams54> +1
[15:56] <hatch> Makyo: lol nice T
[15:56] <Makyo> It was the most delightfully strange thing, I had to get it.
[15:57] <Makyo> uiteam call in 3
[15:57] <rick_h_> or 3 on Makyo's watch
[15:58] <kadams54> I'm in the room, but it says no one else is there?
[15:58] <hatch> kadams54: odd it said you were in there but when I joined there was noone else
[15:58] <hatch> lol
[15:58] <hatch> we have crossed dimensions it seams
[15:58] <hatch> same place at different times@
[15:58] <kadams54> Now rick_h_ is here with me, but no one else.
[16:49] <hatch> 3000 line test file.....now where is the test I need to modify....
[16:49] <hatch> :)
[16:51] <hatch> rick_h_: I'm going to be done this card fairly soon so just giving you some heads up so we can chat about the next step
[17:12] <rick_h_> hatch: ok
[17:22] <hatch> uiteam lf reviews and qa on https://github.com/juju/juju-gui/pull/650
[17:26] <kadams54> uiteam: anyone know a way to consistently reproduce an error notification in a local sandbox env?
[17:26] <hatch> kadams54: yeah just add it from the console
[17:26] <hatch> app.db.notifications.add({ ... })
[17:27] <rick_h_> yep, there's a type flag on there for errors
[17:28] <hatch> yeah like Makyo said in the call - level: error
[17:28] <hatch> rick_h_: I'm ready to chat about what's next whenever you have a moment
[17:28] <rick_h_> hatch: k, joining
[17:29] <kadams54> hatch: thanks
[17:55] <hatch> kadams54: that work for you?
[17:55] <kadams54> Yup.
[17:56] <hatch> great
[17:56] <kadams54> Fixed the problem, writing the test now.
[17:56] <hatch> awesome
[17:56] <hatch> notifications has been on the docket to be refactored for 2 years
[17:56] <hatch> lol
[18:02] <kadams54> not it
[18:03] <kadams54> Before I submit this PR, I want assurances that my status as "having touched it last" does not constitute de facto ownership.
[18:03] <rick_h_> lol
[18:03] <rick_h_> I can make no such promises :P
[18:03] <kadams54> Why did that "lol" sound evil in my head?
[18:03] <kadams54> ;-)
[18:04] <rick_h_> "git blame...it's Kyle! come on down. You're the next contenstant!"
[18:04] <rick_h_> ent
[18:04] <hatch> hahaha
[18:04] <kadams54> "The price is *wrong* Bob."
[18:05] <kadams54> Oh sorry… "The price is *wrong*, bitch."
[18:10] <hatch> lol
[18:15] <kadams54> uiteam: need reviews and QA on https://github.com/juju/juju-gui/pull/651
[18:16] <kadams54> hatch: Looking at 650
[18:24] <hatch> on it
[18:25] <hatch> kadams54: can you re-run the tests on this one
[18:26] <hatch> it looks like a spurious error - but you are also working in notifications
[18:26] <kadams54> Yeah, let me finish QAing yours.
[18:26] <hatch> cool
[18:26] <hatch> also we can
[18:27] <hatch> t clear notifications anymore I guess
[18:27] <hatch> probably should create a bug for that kadams54 ^
[18:32] <kadams54> hatch: just got a chance to look at the CI failure. Still gonna re-run tests, but I'm even more sure now that it's spurious. I added a test to test-notifications.js and the failure was in test-notifier.js, so not even the same file.
[18:41] <hatch> yeah for sure - just want to be sure :)
[18:50] <hatch> uiteam still looking for one more review https://github.com/juju/juju-gui/pull/650
[18:50] <rick_h_> hatch: working my way there
[18:52] <hatch> thank yas
[19:24] <hatch> lunching
[19:44] <hatch> because there is a juju-gui user and project on LP is very confusing
[19:51] <hatch> lets see if this time I can download the charm properly :)
[19:51] <rick_h_> hah
[19:52] <hatch> 138850kB   617kB/s | Fetching revisions:Inserting stream:Estimate 3486/12174
[19:52] <hatch> I'm pretty sure I'm already over
[19:52] <hatch> rick_h_: you said it was 120MB?
[19:52] <rick_h_> something like that
[19:53] <hatch> yeah wth
[19:53] <hatch> bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk/ develop-trunk
[19:53] <hatch> this is what I am running
[19:54] <hatch> yeah I'm over 200 now
[19:55] <hatch> rick_h_: is lp being auto sync'd to our GH repo?
[19:56] <rick_h_> hatch: no, it's manual
[19:56] <hatch> https://code.launchpad.net/~juju-gui/juju-gui/develop
[19:56] <rick_h_> and huh?
[19:56] <hatch> that has commits from last week
[19:56] <hatch> looks like from the bot
[19:56] <rick_h_> hmm, no idea
[19:56] <rick_h_> I thought we setup a bit MOVED file
[19:57] <rick_h_> hmm, looks like it
[19:57] <hatch> heh crazy
[19:57] <rick_h_> didn't realize it was importing
[19:57] <hatch> lol neither did I
[19:58] <hatch> I'm trying to branch the repo again without the trailing /
[19:59] <hatch> maybe that'll make it faster
[19:59] <hatch> rick_h_: when you downloaded it did you have a cobzr setup?
[19:59] <rick_h_> hatch: no, I do that after the fact if I want to hack on it
[19:59] <hatch> hmm ok and you ran the same command that I had above?
[20:00] <rick_h_> bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk/ develop-trunk
[20:00] <rick_h_> for instance
[20:00] <hatch> ok I have that running right now without the trailing slash - will see where it goes to
[20:03] <hatch> guess I'll just let this thing run
[20:03] <hatch> hmph I have no idea what's going on
[20:05] <hatch> uiteam anyone else able to do me a favour and try and branch the guicharm to see how big it is?
[20:10] <hatch> abentley: hey when bzr is branching, do you know where it puts the files before it's finished?
[20:14] <abentley> hatch: I believe a temp dir inside the directory with a name starting with 'bzr-limbo-'.
[20:15] <hatch> I'm trying to branch the gui charm and here is where I'm at so far
[20:15] <hatch> 571695kB   616kB/s / Fetching revisions:Inserting stream:Estimate 3710/12174
[20:15] <hatch> but the folder is only 56K
[20:15] <hatch> abentley:  so I am trying to figure out if it's even downloading anything
[20:16] <hatch> here is the command I ran bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk develop-trunk
[20:16] <abentley> hatch: At that point it's creating the branch, and there are no files.
[20:16] <hatch> 580MB downloaded with no files?
[20:16] <abentley> Once it finishes creating the branch, it updates the working tree, and that's when it creates the files.
[20:17] <abentley> hatch: Well, it depends what files you mean.  I expect there's plenty of data in .bzr.
[20:18] <hatch> right but shouldn't a du -ha show more than 56K?
[20:19] <abentley> hatch: That depends.  Are you using a shared repository?  That's where the bulk of the data goes.
[20:20] <hatch> abentley: I just created a new folder and ran that branch command
[20:21] <abentley> hatch: That doesn't tell me whether you're using a shared repository.  What does "bzr info" say about the directory or its parent directory?
[20:21] <hatch> Unshared repository with trees (format: 2a)
[20:21] <hatch> Location:
[20:21] <hatch>   repository: .
[20:22] <hatch> so no, not shared :)
[20:24] <abentley> Well, I suppose it's possible that the data's all in memory.  Is the bzr process really huge?
[20:25] <hatch> not really
[20:25] <hatch> 100MB
[20:25] <hatch> ish
[20:25] <hatch> it's over a GB now
[20:25] <hatch> heh
[20:26] <hatch> abentley: how about this - can you get the repo size without downloading it?
[20:27] <abentley> hatch: no, not really, but I think I have a copy here....
[20:27] <hatch> rick_h_: recently downloaded it and it was only 120MB for him hah
[20:28] <abentley> hatch: Yeah, 98M for me.  Probably a bit stale.
[20:28] <hatch> *sigh*
[20:28] <hatch> so any ideas on what's happening now or how I may debug this?
[20:29] <hatch> 1068064kB   618kB/s - Fetching revisions:Inserting stream:Estimate 3969/12174
[20:29] <hatch> much bigger than 120MB :)
[20:29] <hatch> and by the looks of that estimate there is a long way to go
[20:29] <hatch> :)
[20:33] <abentley> Not really.  Sorry.  jam might know, but I never worked on that repo-fetching code.
[20:33] <hatch> alright np thanks for the help :)
[20:38] <hatch> abentley: rick_h_ I figured out a 'fix' for my issue
[20:38] <rick_h_> you quit doing it wrong? :P
[20:38] <hatch> I needed to launchpad-login then it worked?!?!?!
[20:38] <hatch>  30105kB   612kB/s - Fetching revisions:Inserting stream:Estimate 283/968
[20:39] <hatch> note the estimate size
[20:39] <hatch> wth?!? This seams like an lp bug
[20:39] <hatch> now we'll see if it actually stops at 120 haha
[20:40] <abentley> hatch: Without your lp login, "bzr branch lp:" will not use SSH, so it will use bzr's http support.  It should have printed a warning about how that is slower.
[20:40] <hatch> abentley: it wasn't slower - it was downloading at the same rate
[20:41] <hatch> du -ah is now showing 100+MB
[20:41] <hatch> definitely a bug there somewhere
[20:41] <abentley> hatch: Yes, but it's not as efficient using http, so the same amount of data does not get you a branch as quickly.
[20:42] <hatch> but is it orders of magnitute higher?
[20:42] <hatch> and done
[20:42] <hatch> wow....that was painless
[20:42] <hatch> 139MB toal
[20:42] <hatch> total
[20:42] <abentley> hatch: Can be, depending on what kind of junk is in the repo.
[20:42] <hatch> before it was well over 1.5GB with du showing 56K
[20:43] <hatch> yikes
[20:48] <hatch> rick_h_:  updated process docs :) https://github.com/juju/juju-gui/pull/652
[20:49] <rick_h_> noted :P
[20:51] <hatch> oops thanks :)
[20:51] <hatch> shipped
[20:57] <hatch> what's this code in this charm....no curlies, no semicolons
[21:04] <hatch> https://twitter.com/github/status/531914601248882689
[21:04] <hatch> hmmmm
[21:04] <rick_h_> heh, /me runs away scared
[21:05]  * hatch pulls down fresh versions of all his git repos....just incase
[21:05] <rick_h_> lol
[21:07] <rick_h_> hatch: lol your branch was rejected
[21:08] <hatch> baqhahaha
[21:08] <hatch> damnit
[21:08] <hatch> fixing
[21:08] <rick_h_> :P nothing but trouble
[21:09] <hatch> wait what....it says my indentation is incorrect
[21:09] <hatch> ohh I didn't have a line between them
[21:10] <hatch> trying again :)
[21:39] <rick_h_> uiteam night, I'm out.
[21:46] <hatch> I'm pretty sure I do not like the large hook file instead of having multiple smaller ones
[21:50] <jcsackett> hatch: +1.


[19:12] <Signum> Hint… https://help.launchpad.net/BadgeKit seems to be broken.
[19:13] <Signum> In other news… I'd like to add Ubuntu single-sign-on to screenshots.debian.net (aka screenshots.ubuntu.com) and I wonder if there is an SVG of the Launchpad logo or a ready "Login with Ubuntu Launchpad" logo.
[19:14] <Signum> Also I'd like to know whether SSO against Ubuntu One or Ubuntu Launchpad makes more sense. I'm a bit confused which of the two systems is recommended.
[19:14] <dobey> they are the same system
[19:15] <Signum> Oh, good, so I can use OAuth against the launchpad then.
[19:15] <dobey> OpenID is probably what you want
[19:16] <Signum> Recommended over oauth?
[19:17] <Signum> screenshots.debian.net runs on Ruby-on-Rails which uses the "omniauth" library. That's what the Ruby "omniauth-launchpad" module seems to use. And so far it works.
[19:17] <dobey> login.ubuntu.com (login.launchpad.net) doesn't do oauth
[19:17] <dobey> launchpad itself has oauth for talking to the launchpad api
[19:18] <dobey> OpenID is what all the other external sites that allow logging in via launchpad use (ie stackexchange, ubuntu forums, and such)
[19:19] <Signum> I think the module uses api.ubuntu.com  according to https://github.com/joaopapereira/omniauth-launchpad/blob/master/lib/omniauth/strategies/launchpad.rb
[19:20] <Signum> If that's okay I'd leave it like that because it seems to be working. :)
[19:20] <dobey> that is using launchpad oauth ye
[19:20] <dobey> yes
[19:21] <Signum> Do you happen to know if there are fancy templates that help me create "Login with Launchpad" buttons? I have just taken the PNG logo from launchpad.net but perhaps there's a styleguide.
[19:22] <dobey> not afaik, no
[19:23] <dobey> but that's not exactly "log in with launchpad" either. it's more "grant access to your launchpad account to this site" (which is what oauth is for). openid is "log in with launchpad"
[19:23] <dobey> but eh
[19:23] <cjwatson> lib/canonical/launchpad/images/src/launchpad-gem.svg in the Launchpad source tree has the logo in various permutations and could perhaps be cut down.  I'm sure there must be a better source somewhere
[19:24] <cjwatson> Yeah, screenshots.debian.net really should not be using that oauth strategy.
[19:25] <cjwatson> It's far too much privilege for Launchpad users to grant to a third-party site.
[19:25] <Signum> cjwatson: I see. It keeps asking what kind of access the Launchpad should grant for the site anyway. I assume that with OpenID that's more like authenticate-and-go.
[19:26] <cjwatson> As dobey says, you should be using OpenID against SSO, not OAuth against Launchpad.
[19:26] <Signum> Will do.
[19:27] <cjwatson> We normally prefer language like "Sign in with Ubuntu SSO" (or in some places "Sign in with Ubuntu One", though that's a bit weird IMO since that's otherwise an obsolete brand) for third-party sites.  Launchpad is (at least in theory) just another SSO consumer.
[19:27] <cjwatson> Only in theory because it actually occupies a somewhat special position due to SSO's history, but still.
[19:28] <Signum> To use OpenID I'd have to ask the user what Launchpad nickname they have, right?
[19:28] <cjwatson> OpenID normally works by redirecting the user to login.ubuntu.com with a pile of special query parameters, which will cause login.u.c to ask them for email address and password (and maybe two-factor auth).
[19:29] <cjwatson> When that process is done, it redirects back to your site by way of one of those query parameters.
[19:30] <cjwatson> (Of course you should find an existing library for this rather than rolling it yourself.)
[19:31] <cjwatson> Try going to e.g. https://myapps.developer.ubuntu.com/ and signing in there to see the flow.
[19:40] <Signum> cjwatson: What is the OpenID identifier for Ubuntu?
[19:40] <Signum> aka URL
[19:51] <cjwatson> Signum: You mean the endpoint URL?  https://login.ubuntu.com/
[19:51] <Signum> Great, thanks. I'll try that.