[00:41] <SpamapS> just FYI, the permission issue was the problem..
[00:41] <SpamapS> Perhaps notifications when local failures spike would be nice.
[01:41] <facundobatista> Chipaca, I wrote the review karni mentioned... he wrote the other one that says that file synchronization from the desktop is blazing fast
[01:41] <karni> :D
[02:05] <ralsina> it is blazing! My computer is overheating since I added ~/Pictures as aUDF! ;-)
[02:09] <karni> ralsina: hahah :D
[02:09] <karni> Night guys o/
[02:09] <ralsina> karni: night!
[09:07] <mandel> morning all!
[09:21] <czajkowski> morning
[09:31] <JamesTait> Happy St David's Day, everyone!  I'm not about to attempt to type Welsh.... :D
[09:33] <czajkowski> JamesTait: just bang the keyboard hit space everyonce in a while
[09:33] <JamesTait> I was going to say something like that, but I didn't want to offend anyone.  I don't know what is wrong with my brain/spelling
[12:13] <mandel> ralsina, did you test if the widget are not showing the correct palette due to the fact that qt uses gtk2?
[12:13] <ralsina> mandel: QPalette and gtk simply have different ideas about colors
[12:14] <ralsina> mandel: for example, QPalette has no separate toolbar color
[12:14] <ralsina> mandel: so it's more a matter of stylesheets
[12:15] <mandel> ralsina, the style is going to be crazily hardcoded, as in, it wont change if I change the theme..
[12:15] <mandel> we can have that I suppose
[12:15] <ralsina> mandel: you can reference palette roles in the stylesheet, I think
[12:15] <ralsina> mandel: so, if the toolbar color is there for some other role, we can use that as "variables"
[12:16] <mandel> ralsina, that would be awesome!
[12:16] <ralsina> mandel: let me check if that's possible
[12:18] <ralsina> mandel: yes, any color in a qss can be defined as a PaletteRole
[12:18] <ralsina> mandel: so, you canuse things like http://developer.qt.nokia.com/doc/qt-4.8/stylesheet-reference.html#paletterole
[12:19] <mandel> ralsina, that sounds like the next step for the style
[12:20] <ralsina> mandel: yes, but still I have to see if the colors we want are there, and the stupid designer doesn't show hex colors
[12:21] <mandel> ralsina, well, at least we know we can..
[12:21] <mandel> ralsina, by the way, alecu is working today, right?
[12:24] <ralsina> mandel: I would have to check canonicaladmin
[12:24] <ralsina> mandel: and it's not working for me
[12:24] <mandel> ralsina, I suppose that;s a yes :)
[12:25] <ralsina> damn, the closest color in the palette is text and that is 3c3c3c
[12:32] <ralsina> gatox: you have to talk to HR
[12:32] <jml> I've just installed a new laptop with precise
[12:32] <ralsina> gatox: you filed carnaval as "Holiday" instead of "National Holiday". Not the same thing!
[12:32] <jml> U1 errors out every time I try to log in
[12:33] <gatox> ralsina, ahhhhh... too late to change that?
[12:33] <jml> The main window goes grey, and a blank dialog appears with the title "Ubuntu One experienced an error"
[12:33] <ralsina> gatox: and the 27th swap you filed as holiday too!
[12:33] <gatox> :S
[12:33] <ralsina> gatox: perhaps you don't want to have holidays this year :-)
[12:33] <gatox> ralsina, i want....
[12:33] <ralsina> gatox: I already approved them because I am stupid.
[12:34] <ralsina> gatox: so, ping #hr about it
[12:34] <gatox> ralsina, ok, thanks
[12:34] <mandel> jml, can you ask rye to give you a hand?
[12:34] <rye> reading
[12:35] <rye> jml, do you have ubuntuone-control-panel-qt or ubuntuone-control-panel-gtk installed?
[12:36] <jml> rye, both.
[12:37] <rye> jml, mmm, ok, if you shut the control panel down and run ubuntuone-control-panel-qt in the terminal - does it print anything looking like a Traceback?
[12:37] <rye> jml, also, what is the version of the -qt one?
[12:37] <jml> rye, which I assume is what happens in the default system installation, since I haven't explicitly installed any U1 stuff in the last two hours
[12:37] <jml> rye, and I only installed Ubuntu itself 2 hours ago :)
[12:37] <rye> dobey, ^ do we have both control panels on the cd now?
[12:38] <jml> rye, no traceback.
[12:38] <rye> jml, ok, i have an idea
[12:38] <rye> testing
[12:39] <jml> strace says it's blocked on:
[12:39] <jml> futex(0x2dbfa14, FUTEX_WAIT_PRIVATE, 1, NULL
[12:40] <rye> jml, did it prompt you to add the account? In a window with a weird padding?
[12:40] <jml> rye, It says "Sign in to Ubuntu One"
[12:41] <jml> rye, If I had to guess, I'd say it's an HTML widget embedded in a window
[12:41] <rye> jml, http://ubuntuone.com/3uRI1uTtMVDIptRloDsz6V ?
[12:41] <jml> mostly because the background around most of the stuff is white
[12:41] <jml> rye, that's the badger.
[12:41] <rye> jml, ok, when does the error happen?
[12:41] <jml> rye, when I enter my email address and password
[12:41] <rye> jml, sweet, reproduced
[12:41] <rye> awesome
[12:42] <jml> rye, hey, I guess that's something :)
[12:42] <rye> jml, you can try using the -gtk control panel for now, digging into the details now
[12:43] <rye> ralsina, http://paste.ubuntu.com/863345/
[12:43] <jml> rye, gtk seems to work
[12:43] <jml> rye, fwiw, I was entering an incorrect password
[12:45] <rye> jml, hm, me too :)
[12:46] <rye> ralsina, qt control panel gets completely stuck if user enters invalid password now - http://ubuntuone.com/4Ub05bg6sJtIrOvr87xGUr
[12:46] <ralsina> rye: yes, there was a bug in the last release when entering a wrong password
[12:46] <ralsina> rye: does it still happen on nightlies?
[12:46] <rye> ralsina, no, that's what in the archives
[12:46] <ralsina> rye: let me check nightlies, I think it's fixed
[12:47] <ralsina> rye: still there
[12:47] <ralsina> rye: but nessita is doing a lot of work on the auth pages of u1cp-qt so it will be fixed soonish
[12:48] <rye> ralsina, also, why doesn't it shut down on Ctrl+C when it is stuck this way? Same reason why u1sdtool does that?
[12:48] <ralsina> rye: yes
[12:48] <nessita> rye: yes
[12:48] <rye> boo
[12:48]  * rye likes Ctrl+C
[12:48] <ralsina> rye: but if you close the window it dies :-)
[12:49] <rye> ralsina, nope
[12:49] <rye> ralsina, you can't close the foreground window
[12:49] <ralsina> rye: let me double-check
[12:50] <ralsina> rye: right, it's unclosable
[12:54] <mandel> you have to kill the process.. is a PITa
[12:59] <karni> czajkowski: Happy to surprize :)
[13:00] <czajkowski> karni: it;s really cool!
[13:01] <karni> czajkowski: It's about to get even better :) (low level details :) )
[13:01] <karni> czajkowski: Thanks!
[13:01] <duanedesign> o/
[13:03] <duanedesign> karni: your everywhere this morning ;)
[13:03] <karni> duanedesign: It's magic
[13:03] <duanedesign> :d
[13:03] <duanedesign> :D
[13:03] <karni> duanedesign: I tent to limit myself to web-and-mobile, so I'm back on being everywhere
[13:03]  * czajkowski stabs aq
[13:04] <duanedesign> karni: yeah i need to try and hang here more. Try and hook any users looking for help >.>   <.<
[13:04] <duanedesign> that way d_obey does not have to always ping me :)
[13:08] <mandel> ralsina, I'm off to have an early lunch sine I'm a little blocked until alecu is back
[13:09] <ralsina> mandel: ack, buen provecho!
[13:16] <duanedesign> C/5
[13:29] <karni> ralsina: Very cool article you've e-mailed yesterday. The Joel test site link within the article takes you to an even more interesting site full of interesting articles. I've read somein the night.
[13:30] <karni> ralsina: I am totally for that degree of automation, and I strive to work in that direction.
[13:30] <karni> ralsina: re: "Here's an apk" - I often do that. When there's a bug report, and I fix it, I often post a link to an apk so that the person can see if it fixes the problem :)
[13:31] <karni> ralsina: The build of U1F is to ant commands (ant setup; ant release) - one too much ;) I'll write a script that downloads that stuff, and builds it :)
[13:37] <ralsina> karni: thanks! one interesting thing about jenkins is the artifacts archive. So, suppose you want to see if something was broken in revno xyz, you jut go to that build, get the  artifact (the apk in your case) and there you go
[13:37] <ralsina> karni: imagine doing bisection IRL by trying a few apks toseewhere you broke something ;-)
[13:45] <alecu> mandel, ralsina: I'm around, but the repair guys arrived 30 minutes ago and they are reassembling a working air conditioner in my living room.
[13:45] <alecu> mandel, I'll be back in 15 minutes or so.
[13:47] <ralsina> alecu: ok!
[13:48] <karni> ralsina: Yeah, the artifact archive is great. I can't wait to start using that stuff. The java lib I wrote will be the first one to use that, I think.
[13:57] <dobey> rye: i think neither are on the CD now. -gtk was, and should be removed now. -qt is installed by the installer
[13:59] <dobey> rye, nessita, ralsina: also, the ubuntuone-control-panel-qt ^C issue is not the same as u1sdtool.
[13:59] <nessita> dobey: what's the difference?
[14:00] <dobey> nessita: the qt panel is just ignoring the KeyboardInterrupt inside the loading event handler thing
[14:01] <nessita> it is? hum
[14:01] <nessita> gatox: does that ring any bell? ^
[14:01] <dobey> nessita: run it in a terminal, hit ^C, and look at what gets printed :)
[14:02] <gatox> nessita, dobey is running using qtreactor?
[14:02] <nessita> gatox: nopes, plain qt mainloop
[14:02] <gatox> the qt loop by default ignore that....
[14:02] <nessita> why? :-/
[14:02] <gatox> when we have it using qtreactor, it allows keyboard interrupt
[14:03] <dobey> it's an easy fix either way; unlike the twisted+glib issue
[14:03] <dobey> which also seems to happen with glib2reactor, not just gireactor
[14:04] <Chipaca> davidcalle: hi there
[14:04] <davidcalle> Hi Chipaca
[14:05] <ralsina> dobey, nessita, gatox: turns out PyQt apps ignore ^C by default
[14:05] <dobey> ralsina: yes, gatox just said that :)
[14:06] <Chipaca> davidcalle: yesterday I added a source, and the scope picked it up, but the lens (in unity 2d) did not update the labels. Is there a reason you're using strings of numeric ids for the labels ids? I'm presuming it doesn't update the label of a filter it already "has"
[14:06] <ralsina> dobey: hey, I am reading the backlog top-down ;-)
[14:07] <davidcalle> Chipaca, are you sure it's not a Unity-2D-not-updating-labels-at-all issue?
[14:07] <Chipaca> davidcalle: so, before the new source was added there were [foo] [bar] [baz] source filters; then I added quux after foo, and the lens displayed [foo] [bar] [baz] [baz]
[14:07] <ralsina> nessita: the "why" is really "it's a bug in PyQt that is not trivial to fix, and has been there since ever"
[14:07] <Chipaca> and [bar] was actually quux, the first [baz] was bar, and the second [baz] was baz
[14:08] <nessita> ralsina: booooo :-)
[14:08] <gatox> ralsina, nessita it's a way to "fix" that it seems.... but both are really hackish
[14:08] <nessita> gatox: no worries
[14:08] <ralsina> gatox: using signal.signal?
[14:08] <Chipaca> davidcalle: I'll debug later to see if using numerical ids is indeed the problem; I wanted to check with you if there was a reason to not use just the source name as the id
[14:08] <davidcalle> Chipace, can we test it now? I'd like to check if it happens on 3D. Can you add a fake source in 5 min?
[14:09] <Chipaca> davidcalle: but that would by lying!
[14:09] <Chipaca> davidcalle: <grins evily>
[14:09] <gatox> ralsina, that's one..... but you have to use another key combination...... because ^C can be valid for the ui
[14:09] <davidcalle> Chipaca,  :D
[14:09] <Chipaca> davidcalle: tell me when to add it, and it will be added
[14:09] <ralsina> gatox: but ctrl-c on the UI won't be caught by signal.signal
[14:09] <ralsina> gatox: only ctrl-c on the terminal
[14:09] <davidcalle> Chipaca, ok, I'm raising the frequency of source updates.
[14:09] <Chipaca> davidcalle: removing from the middle of the list probably presents the same problem
[14:10] <gatox> ralsina, really?? so that would be ok
[14:11] <ralsina> gatox: just import signal, signal.signal(signal.SIGINT, signal.SIG_DFL) should do it
[14:11] <pedronis> aquarius: in a meeting? ping me when you can
[14:11] <ralsina> gatox: the way Ctrl-C works, is the terminal gets the keycode, and sends the signal to its foreground job
[14:11] <nessita> ralsina: stop distracting gatox with fun stuff! :-D
[14:11] <nessita> ralsina: wanna propose a branch with that? :-)
[14:11] <davidcalle> Chipaca, I'm ready, mess with the sources when you want :)
[14:11] <ralsina> nessita: then assign me the bug :-D
[14:12] <nessita> rye: then file me the bug :-P
[14:12] <gatox> ralsina, great... i'll try it later :P
[14:12] <nessita> gatox: you mean after 5pm? :-D
[14:12] <gatox> nessita, of course! ninja has the same problem
[14:12] <gatox> jejeje
[14:12] <ralsina> gatox: hands off, I will fix it ;-)
[14:12]  * nessita is on mode bitch on
[14:12] <gatox> ralsina, :P
[14:12]  * ralsina uses evil manager power to steal easy bugs
[14:12] <nessita> careful crowd, PMS is knocking at the door
[14:13] <nessita> dobey: any ring bells in the test failure here? https://code.launchpad.net/~dobey/ubuntuone-client/installer-not-panel/+merge/95237
[14:13] <Chipaca> davidcalle: there
[14:13] <Chipaca> davidcalle: added one at the beginning
[14:13] <rye> ummm
[14:14] <davidcalle> Chipaca, I've seen Fake appearing, without issue.
[14:14] <Chipaca> davidcalle: at the beginning, or at the end?
[14:14] <davidcalle> Chipaca, end
[14:14] <Chipaca> i added it at the end, then realized it wouldn't demonstrate the problem, moved it to the beginning
[14:15] <Chipaca> so it's now at the beginning
[14:15] <alecu> mandel, I'm back, let me know when I can be of help.
[14:15] <davidcalle> Chipaca, ok, you were right, my sources/results don't match.
[14:15] <Chipaca> davidcalle: so if it's updated the list of sources since I said "added one at the beginning", and it's still at the end, you're seeing the issue. Test it out by trying to click the first remote source.
[14:16] <Chipaca> there ya go :)
[14:16] <ralsina> rye: I added bug 944012
[14:16] <ralsina> rye: I added bug #944012
[14:16] <dobey> nessita: didn't you open a bug for that already?
[14:16] <ralsina> rye: for the ctrl+c thingie
[14:16] <Chipaca> davidcalle: so, now my question is, can't we use the source name as the id?
[14:16] <nessita> dobey: as far as I recall... no
[14:16] <Chipaca> davidcalle: if the bug is what I think it is, it should fix it :)
[14:16]  * Chipaca removes the fake source
[14:18] <davidcalle> Chipaca, I'm not sure it if will work, as I've only seen filter option ids being very simple. But I'm trying it.
[14:18] <aquarius> pedronis, pong
[14:19] <dobey> nessita: https://bugs.launchpad.net/ubuntuone-client/+bug/935568 i guess?
[14:19] <Chipaca> davidcalle: note source names are unicode
[14:19] <Chipaca> davidcalle: so, encode
[14:19] <Chipaca> davidcalle: (or not; maybe it's fine with them being unicode too :) )
[14:19] <Chipaca> davidcalle: test test test :)
[14:19] <davidcalle> Chipaca, I'm not forgetting it :)
[14:20] <nessita> dobey: ah yes, is a "different" error (FailTest vs DirtyReactorAggregateError), but may be caused by the same bug in the test
[14:20] <nessita> dobey: approving
[14:20] <Chipaca> davidcalle: changing code here too, to test on 2d
[14:25] <mandel> alecu, can you give me a hand with the ssl tests, I'm getting a cancelation error from libsoup
[14:25] <mandel> alecu, I might have a very stupid error..
[14:26] <davidcalle> Chipaca, looks fine, but we need to test again with a fake source.
[14:26] <Chipaca> davidcalle: right now?
[14:26] <davidcalle> Chipaca, When you are ready.
[14:26] <alecu> mandel, sure thing
[14:27] <nessita> mandel: comments added to https://code.launchpad.net/~mandel/ubuntu-sso-client/ssl-dialog/+merge/94012, please read then when you have a minute before globally approving
[14:27] <mandel> nessita, looking
[14:27] <mandel> alecu, let me give you the lp branch
[14:28] <mandel> alecu, here it is: lp:~mandel/ubuntu-sso-client/add-ssl-support
[14:28] <nessita> dobey: saw my review in https://code.launchpad.net/~dobey/ubuntuone-control-panel/remove-gtk/+merge/95252 ?
[14:28] <mandel> nessita, changing the tests and cleaning accordingly right now so I don't forget
[14:28] <nessita> mandel: awesome!
[14:29] <dobey> nessita: yeah. just trying to do<PHONE_NUMBER> things at the same time, so haven't come back to it yet :)
[14:29] <alecu> mandel, looking
[14:30] <nessita> dobey: great, just wanted to know you where aware (no rush on this end)
[14:30] <alecu> mandel, what does "cancelation" mean for libsoup?
[14:31] <mandel> alecu, let me get you the exact error from the docs
[14:32] <mandel> alecu, I'm getting an error code of 1l which is SOUP_STATUS_CANCELLED
[14:34] <alecu> mandel, probably that's libsoup way of telling you that the ssl certificate was invalid... right?
[14:35] <mandel> alecu, hm.. good point, might be realted to this: http://developer.gnome.org/libsoup/stable/SoupSession.html#SoupSession--ssl-strict
[14:36] <alecu> mandel, can you look at the "reason-phrase" in the message?
[14:36] <alecu> http://developer.gnome.org/libsoup/stable/SoupMessage.html#SoupMessage--reason-phrase
[14:36] <mandel> alecu, will do, gime me 10 mins to fix what nessita pointed out in her review and I'll do it
[14:36] <alecu> mandel, right, ssl-strict seems to be the cause.
[14:37] <alecu> mandel, in any case our code *should* be using ssl-strict=True
[14:37] <alecu> mandel, and we should be setting "ssl-ca-file" to U1 certificates.
[14:37] <mandel> alecu, hm.. should it? then we have an issue since we will get a cancel error.. and the pinned certificate will be ignored
[14:37] <alecu> mandel, (or to the fake certificates for the tests)
[14:38] <alecu> mandel, what's a "pinned certificate"?
[14:38] <mandel> alecu, ssl-ca-file should be for the proxy one
[14:38] <alecu> mandel, oh, right.
[14:39] <alecu> mandel, in that case we have a serious issue!
[14:39] <mandel> alecu, a pinned certificate is that one that has been accepted by the user but is not validated by the trust tree
[14:39] <mandel> alecu, yes, we do..
[14:39] <pmatulis> hello.  i am witnessing the loss of executable permissions on sync'd files.  known issue?
[14:39] <alecu> mandel, we want to be able to bypass strict certificate checking for the proxy, but not for the remote servers!
[14:40] <alecu> pmatulis, Ubuntu One does not synchronize file permissions
[14:40] <mandel> alecu, I've been cahting with upstream about http://developer.gnome.org/gcr/unstable/gcr-Trust-Storage-and-Lookups.html but is not stable yet (good because we can help with the design)
[14:40] <pmatulis> alecu: good to know.  i wonder what is removing my permissions?
[14:40] <alecu> mandel, cool about the pinned certificates.
[14:40] <mandel> pmatulis, those permissions don't make sense if you are supporting more than one platform
[14:41] <mandel> pmatulis, there is not way to 'match' the windows and linux ones..
[14:41] <pmatulis> mandel: makes sense
[14:41] <mandel> pmatulis, also, if you sync with a Fat32 partitions they are ignored :)
[14:41] <karni> joshuahoover: duanedesign: In case a user has problems signing into the U1Music app for Android, please direct them at this bug report. Users are reporting setting proper device time resolves the issue, and it's a recurring bug report, that pops-up whenever I close it. https://bugs.launchpad.net/ubuntuone-android-music/+bug/909597
[14:42] <pmatulis> mandel: i just noticed that the other sync'd computer has not lost these permissions.  how would you explain that?
[14:43] <Chipaca> davidcalle: fake added
[14:43] <davidcalle> Chipaca, hmm, still at the end.
[14:44] <davidcalle> Chipaca, but filters are not confused anymore...
[14:44] <Chipaca> davidcalle: and adding it at the end is ~fine
[14:44] <Chipaca> it's weird, but ok :)
[14:44] <alecu> pmatulis, perhaps those files were added to the U1 folder on that other computer
[14:44] <davidcalle> Chipaca, yeah :)
[14:45] <alecu> pmatulis, U1 should not be removing permissions on purpose, but it will definitely won't be syncing them
[14:45] <pmatulis> alecu: i don't follow, they are the same files
[14:45] <alecu> pmatulis, I mean... you copied those files into the U1 folder into the other computer.
[14:45] <dobey> pmatulis: u1 doesn't sync the executable bit
[14:46] <pmatulis> alecu: i've been using these scripts for a while now.  those permissions were set and working on both computers
[14:46] <alecu> pmatulis, oh, I see.
[14:46] <dobey> but shouldn't be unsetting it locally, either
[14:47] <alecu> pmatulis, did you modify the file in any of the computers?
[14:48] <alecu> pmatulis, in that case the permissions would be lost in the other, since u1 would download the file as a new temporary-file (without the execute bit), and then rename it into the proper filename.
[14:49] <pmatulis> alecu: no, this entire directory is actually called 'oldscripts' and i don't use them much.  there are about 2 dozen shell scripts that have lost permissions, including a subdirectory and it's contents
[14:50] <pmatulis> alecu: but i did not that 2 scripts in another directory that i do use much more often had lost permissions.  i just redid them and moved on, but now this...
[14:51] <pmatulis> alecu: although the sub-directory did not lose permissions
[14:53] <mandel> nessita, changes made, is it save to approve? I mean, no FF exceptions issues or anything like that, right?
[14:53] <pmatulis> alecu: fwiw, i also noticed that i got u1conflict files for an entirely separate file, my ~/.vimrc file that i was changing quite quickly last night (but all seems good now, on both computers).  not sure if this can be related
[14:53] <nessita> mandel: well, I assume you already have a UIFe for this?
[14:53] <mandel> nessita, yes, but I'll double check with josh
[14:54] <alecu> pmatulis, yup, it's annoying that permissions are not being handled in a consistent way. But AFAIK "not handling permissions" was an design constraint for the current syncdaemon, so probably there's no easy bug to fix for this.
[14:54] <alecu> pmatulis, but if it starts getting annoying for many users like in your case we should definitely revisit this decision.
[14:55] <alecu> pmatulis, do you have .vimrc symlinked into your U1 folder?
[14:55] <mandel> pmatulis, I would file a bugs, worst case scenario, is hard and we tell you :)
[14:55] <pmatulis> alecu: yes, how else would i get u1conflicts?
[14:55] <gatox> team meeting in 5?
[14:56] <ralsina> gatox: oh, yes, team meeting
[14:57] <pmatulis> alecu, mandel: so far, i learned here that it's expected to lose permissions when modifying a file (that is hard to accept).  but like i said, i didn't modify any of the affected files so this is quite nasty.  i'll open a bug
[14:57] <mandel> ralsina, mumble, right?
[14:57] <alecu> pmatulis, so... it's ok in that case to get .u1conflicts if you were modifying the file in both computers before it was replicated, but it should not affect the permission on other files
[14:58] <ralsina> mandel: yes
[14:58] <nessita> yes, mumble, be there in 2 minutes
[14:58] <pmatulis> alecu: no, i was only modifying it on one computer
[14:58] <mandel> ralsina, you were a sysadmin in another life, right?
[14:58] <ralsina> mandel: yes
[14:58] <Chipaca> davidcalle: so, you fix, or i fix? :)
[14:59] <mandel> ralsina, could you give me reasons why using proxies is so common in a corporate env, I need some use cases for the certificates conversations with gnome
[14:59] <mandel> ralsina, and the ones I come up with sound like bullshit :P
[14:59] <ralsina> mandel: corporate control freakness and surveillance of thepeons
[14:59] <ralsina> mandel: I can write it nicer, of course ;-)
[15:00] <mandel> ralsina, I was expecting something more serious, I already mentioned facebook and porn hehe
[15:00] <alecu> pmatulis, on what computer did the u1conflict showed up? on the one were the modifications took place or on the other?
[15:00] <mandel> ralsina, please do, I'd really appreciate it, I'll also ping other people I know to see if they can give me some real examples :)
[15:00] <pmatulis> alecu: on the one the mods took place
[15:00] <ralsina> mandel: there are basically 3 reasons: 1) easier intranet access (using custom DNS resolvers, etc)
[15:01] <ralsina> 2) access control to pages that are not good in a working environment (example, a computer with porn on its screen opens a company to liability by anyone who sees it)
[15:01] <alecu> pmatulis, *that* sounds like a serious bug
[15:01] <pmatulis> alecu: and i lost permissions on the other computer.  again, not sure if this is related seeing that the files are not the same at all
[15:01] <ralsina> 3) control over resource usage (who uses a lot of bandwidth, etc)
[15:01] <ralsina> mandel: those are the 3 things I used to sell proxys at least :-)
[15:01] <pmatulis> alecu: couldn't the conflicts be due to quickly-chaning file but a slow internet connection?
[15:02] <dobey> oh meh
[15:02] <pmatulis> *changing
[15:03] <mandel> ralsina, sweet I'll jot that down
[15:03] <pmatulis> alecu: but again, the conflicts have resolved themselves on their own.  just permissions problem persists
[15:03] <ralsina> thisfred, joshuahoover: weekly desktop call and you are invited!
[15:03] <briancurtin> urbanape^
[15:03] <urbanape> omw
[15:03] <joshuahoover> ralsina: yep, getting my headset fixed here...one min.
[15:10] <davidcalle> Chipaca, sorry was getting a coffee. I've submitted a merge for you to review. As you've touched the sources code, I don't want to miss a change.
[15:10] <Chipaca> davidcalle: ah :)
[15:12] <gatox> if someone can read this.... everything crash..... brb
[15:13] <Chipaca> davidcalle: +1'ed
[15:14] <davidcalle> Chipaca, ok, merging
[15:20] <mandel> alecu, send be the lp urls and I'll review them!
[15:23] <alecu>  REVIEWS NEEDED:
[15:23] <alecu>  * https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-server/+merge/95075
[15:23] <alecu>  * https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-client/+merge/95077
[15:25] <mandel> alecu, looking
[15:25] <mandel> dobey, updated: https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-credentials-text/+merge/94016
[15:25] <mandel> alecu, may I have a review for https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-credentials-text/+merge/94016
[15:25] <mandel> alecu, very very easy
[15:25] <alecu> https://wiki.ubuntu.com/PrecisePangolin/ReleaseSchedule
[15:26] <dobey> mandel: nessita needs to review that
[15:26] <mandel> dobey, oh.. dammed, ok :)
[15:26] <mandel> nessita, please: https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-credentials-text/+merge/94016
[15:26] <nessita> mandel: sure!
[15:26] <dobey> mandel: well, she claimed a review and it's pending :)
[15:26] <alecu> mandel, sure. There was another branch from last week that you did and I needed to review... right?
[15:27] <mandel> alecu, yes, let me find it for you
[15:28] <mandel> alecu, here it is: https://code.launchpad.net/~mandel/ubuntu-sso-client/webclient-use-dialog/+merge/94416
[15:30] <nessita> mandel, dobey: approved
[15:30] <mandel> nessita, super, thx!
[15:42] <pmatulis> alecu, mandel: i'm about done in reporting the bug but i cannot remember how i set up my sync directory.  right now i am using ~/Data/U1 .  where is that configured?
[15:43] <mandel> pmatulis, that is a udf
[15:43] <mandel> pmatulis, just state it, I think is enough
[15:43] <pmatulis> mandel: beg your pardon?  a udf?
[15:44] <mandel> pmatulis, a udf is a User Define Foder that is outside the ~/Ubuntu One folder
[15:44] <mandel> pmatulis, sorry, internal jargon
[15:44] <pmatulis> mandel: regardless if it's irrelevant, i would personally like to document it for my own
[15:44] <dobey> 'cloud folder'
[15:44] <pmatulis> reasons
[15:45] <mandel> pmatulis, you probably added it via the control panel of ubuntu, right?
[15:45] <pmatulis> mandel: i'm actually using lubuntu
[15:46] <mandel> pmatulis, uh, cool.. ask rye he might know
[15:46] <pmatulis> mandel: but the other 'puter is running ubuntu.  i prolly used the same (manual?) method there
[15:47] <mandel> pmatulis, well, I'd say you used u1sdtool to do it
[15:47] <pmatulis> mandel: ah, that sounds familiar
[15:48] <mandel> pmatulis, u1sdtool --create-folder=PATH
[15:48] <pmatulis> mandel: yeah, that too.  does that end up somewhere in a config file?
[15:49] <mandel> pmatulis, I think that goes server side, right rye, alecu ?
[15:50] <alecu> pmatulis, u1sdtool --list-folders
[15:51] <pmatulis> alecu: yes, it shows up but is there any other trace of that config somewheres?
[15:52] <mandel> thisfred, lol
[15:52] <pmatulis> alecu: and is the "id" that shows up in that output of a sensitive nature (include in bug)?
[15:54] <ralsina> alecu: want to do the 1-1?
[15:56] <briancurtin> ralsina: i'm due for a 1-1 at some point as well
[15:57] <ralsina> briancurtin: indeed. You first!
[15:57] <briancurtin> logging back in
[15:57] <rye> pmatulis, the subscribed folders do not end up in config file, but in metadata only, not easily visible by the user, and we usually interact with it via syncdaemon only
[15:58] <pmatulis> rye: roger
[15:58] <rye> pmatulis, the UUID you are seeing is not sensitive since it is not possible to attach another user's volume using the UUID (only via shares, but shares have their own UUID space)
[15:59] <alecu> pmatulis, I think it's not sensitive, but no need to include it in the bug report unless the sync guys request it.
[15:59]  * gatox lunch
[15:59] <alecu> ralsina, let me know when and we'll have the 1-1
[16:00] <pmatulis> sounds like you guys need to sync up, *wink*
[16:00] <mandel> alecu, so getting back to the ssl issue, I'll think that ssl-strict is a problem.. I'm going to try with it being false and ets see how far I get
[16:01] <mandel> dobey, can I have a super easy +1 for this: https://code.launchpad.net/~mandel/ubuntu-sso-client/fix-credentials-text/+merge/94016
[16:01] <mandel> dobey, I want to forget about this :)
[16:02] <nessita> ralsina: you busy to help me debug an annoying thing in qt?
[16:03] <ralsina> nessita: in 5'?
[16:03] <nessita> sure
[16:04] <dobey> mandel: i added another comment which needs fixing. the grammar for "Please provide login details." is wrong.
[16:04] <dobey> mandel: should be either "Please provide the proxy login details." or "Please provide your login details."
[16:04] <mandel> dobey, ah, but I did not write that!
[16:05] <mandel> dobey, that is the design/ux people
[16:05] <dobey> mandel: they don't know english very well?
[16:05] <mandel> dobey, they are British ;)
[16:05] <ralsina> nessita: shoot
[16:05] <dobey> well, 1 of them is british
[16:05] <mandel> dobey, don't look at me, I know I make spelling mistakes so I don't argue with them
[16:06] <nessita> ralsina: could you please branch: lp:~nataliabidart/ubuntuone-control-panel/fix-933576
[16:06] <mandel> dobey, robert, roberta are the ones that did it, aren't they native speakers?
[16:06] <nessita> ralsina: and, having your U1 credential removed, please run inside it:
[16:06] <nessita> ralsina:  ./setup.py clean build; U1_DEBUG=True PYTHONPATH=. bin/ubuntuone-control-panel-qt
[16:07] <dobey> mandel: oh, roberta isn't on design team. lisettte is dutch and i don't remember where patricia is from. but she definitely hasn't got a british accent :)
[16:07] <nessita> ralsina: you should get the screen I've been emailing to robert. Please confirm that you get a single default button, but when changing focus to other app, and the to the cp again, you get 2 default buttons
[16:07] <mandel> dobey, true, well, I'm telling them to look at the bug
[16:07] <nessita> mandel, dobey: please ping roberta in u1-internal instead of arguing :-)
[16:08] <mandel> nessita, doing that :P
[16:08] <nessita> or rtgrant, they should be in synced
[16:08] <dobey> arguing?
[16:08] <nessita> dobey: typo?
[16:08] <ralsina> nessita: ok, got it,reproduced it
[16:08] <nessita> ralsina: WTF? :-)
[16:08] <ralsina> nessita: give me 2' to see what's happening
[16:08] <nessita> ralsina: is a qwizard bug?
[16:08] <ralsina> nessita: no, it's something else, I think
[16:08] <nessita> ralsina: sure, a pointer: go to ubuntuone/controlpanel/gui/qt/wizard.py
[16:08] <mandel> nessita, arguing is to strong in eng, discussing/chatting is more appropriate
[16:09] <mandel> nessita, also waisting time ;)
[16:09] <nessita> mandel: ah, ok, I mean arguing as "discutir"
[16:09] <mandel> nessita, yes, I make the same mistake
[16:09] <ralsina> nessita: which one is the mutant button?
[16:09] <mandel> nessita, is more like 'pelear', stupid lang :)
[16:10] <nessita> ralsina: the wizard cancel button, see line 47 in that file I pointed out eariler
[16:10] <ralsina> ok
[16:10] <nessita> ralsina: I'm setting the mutant button to: self.setButtonText(self.CancelButton, CLOSE_AND_SETUP_LATER), and then self.setOption(self.NoDefaultButton, True)
[16:10] <ralsina> nessita: ack
[16:13] <mandel> alecu, with the ssl-strict to false i get an IO error, I might have set up the twited server wrong, can you take a look, I'm not used to the twisted.application package
[16:14] <dobey> mandel: eh, change it and we can ask for forgiveness later
[16:14] <pmatulis> mandel, alecu: fyi, https://bugs.launchpad.net/ubuntuone-client/+bug/944110
[16:14] <ralsina> nessita: got it
[16:14] <mandel> dobey, thx :)
[16:14] <nessita> ralsina: you did? wow
[16:14] <nessita> ralsina: tell me!
[16:14] <ralsina> nessita: that is not a default button, it's a focused button. Press tab :-)
[16:14] <mandel> dobey, we should start adding the default str in spanish hehe
[16:14] <dobey> mandel: the string in that branch anyway.
[16:14] <ralsina> nessita: you can set the button to NoFocus and that may get fixed
[16:14] <dobey> mandel: all the strings would be "joder puta!" if you wrote them
[16:15] <mandel> dobey, would be lovely hehe
[16:15] <ralsina> nessita: or, we need to change the stylesheet so that focused buttons that are not default are not orange
[16:15] <ralsina> nessita: my qt-fu is strong!
[16:16] <nessita> ralsina: stylesheet already has that
[16:16] <ralsina> nessita: if it does, it's not working because when the button loses focus it returns to grey
[16:17] <nessita> ralsina: is gets worse... if you click on the "first" default button, you will get the Qt sso dialog, if you close it, that button "looses" the fault coloring
[16:17] <ralsina> nessita: self.button(self.CancelButton).setFocusPolicy(QtCore.Qt.NoFocus) fixes it
[16:17] <mandel> dobey, can you give me a hand with libsoup, I'm getting a 'Connection terminated unexpectedly' do you know how I can get more info?
[16:17] <nessita> ralsina: can you reproduce that last bit?
[16:18] <ralsina> nessita: again, that is not a default button, it seems.
[16:18] <nessita> ralsina: it is!
[16:18] <ralsina> nessita: let me re-check
[16:18] <nessita> ralsina: put an assert in there
[16:19] <nessita> ralsina: I added this to the wizard __init__: assert self.signin_page.panel.ui.login_button.isDefault()
[16:19] <nessita> and is not failing
[16:19] <alecu> mandel, can you give me the link to the branch again?
[16:19] <ralsina> nessita: ok, yes it is a default button. It seems that when it's losing the style. That one I don't understand yet :-)
[16:19] <mandel> alecu, certainly, I'll be doing your reviews
[16:19] <nessita> ralsina: weird thing is that we're not "changing" the style at runtime... so no idea how it gets lost
[16:20] <mandel> alecu, lp:~mandel/ubuntu-sso-client/add-ssl-support
[16:20] <nessita> ralsina: also added this assert: assert not self.button(self.CancelButton).isDefault() and is not failing (as expected)
[16:20] <dobey> mandel: no idea. a closed connection is a closed connection. not sure you can get an answer about why it's getting closed
[16:21] <mandel> dobey, thx
[16:21]  * mandel starts debugging
[16:21] <ralsina> nessita: can we mumble 1'? That should be easier
[16:22] <nessita> ralsina: sure!
[16:22] <mandel> alecu, at some point we need to move the SaveHTTPChannel and SaveSite to ubuntuone dev tools, seems stupid to re-write it all the time :)
[16:22] <mandel> alecu, not now of course!
[16:22] <mandel> alecu, I'll file a bug for the next release :)
[16:23] <alecu> mandel, yup, I agree with you on that :-)
[16:27] <alecu> mandel, I don't see any "ssl-strict" in the branch I've just merged...
[16:28] <alecu> mandel, re: SSL_DOMAIN_HELP = _('the domain whose ssl certificate we are going to show.')
[16:28] <alecu> and SSL_DETAILS_HELP = _('the details ssl certificate we are going to show.')
[16:29] <alecu> ^^^ what's with that error messages?
[16:29] <mandel> alecu, I did not push that
[16:29] <alecu> mandel, oh, you mean ssl-strict
[16:29] <mandel> alecu, yes, the ssl-strict
[16:29] <alecu> mandel, I'm asking about those messages because I don't understand when they are supposed to be shown.
[16:29] <dobey> ok, really need to go get some lunch
[16:29] <dobey> bbiab
[16:29] <mandel> alecu, also, the SSL_DETAILS are the translations of the command like of the ssl dialog
[16:31] <alecu> mandel, that sounds a bit like "internal" help, not help that should be shown to the user and translated... right?
[16:32] <mandel> alecu, can be removed, not a huge issue
[16:32] <mandel> alecu, I can even remove the help
[16:32] <alecu> mandel, sure, it's not an issue at all...
[16:32] <alecu> mandel, I'll open a bug, we can deal with this after the freezes are done.
[16:33] <mandel> alecu, cool
[16:34] <mandel> alecu, bug 944125 for after the release of P
[16:35] <alecu> mandel, cool!
[16:35] <mandel> alecu, added the u1proxy tag so that we remember to clean up
[16:36] <ralsina> nessita: the "focused-buttons-are-orange" is not us, it's the gtk style
[16:36] <nessita> ralsina: ah... may be!
[16:36] <ralsina> nessita: just noticed it when closing mumble :-)
[16:36] <nessita> ralsina: so, the "orange" from the gtk style is different from ours, can you tell if there are 2 different oranges?
[16:37] <mandel> I have the impression that no one reads my emails..
[16:37] <alecu> mandel, I was about to create a bug for the ssl dialog help strings, but I reconsidered and decided we should keep them, since the dialog might be reusable from other places.
[16:37] <nessita> ralsina: and I just tried this:
[16:37] <nessita>      85 QPushButton:focus {
[16:37] <nessita>      86     background: red;
[16:37] <nessita>      87     color: green;
[16:37] <nessita>      88     border-color: white;
[16:37] <nessita>      89 }
[16:37] <ralsina> nessita: didn't notice differences. But here's how to see it. Close mumble, see the "close/disconnect" dialog, and press tab
[16:37] <mandel> ralsina, nessita its a bug, selected buttons don't stand up, it was in my verbal diarrhea  in the mainling list
[16:37] <nessita> ralsina: and on focus change no button was red with green letters in it
[16:37] <ralsina> nessita: right, the gtk style is stepping over the stylesheet
[16:38] <ralsina> nessita: using hardcoded colors instead of reading the qss
[16:38] <nessita> mandel: can you please expand?
[16:38] <ralsina> nessita: try that using -style=windows
[16:38] <nessita> ralsina: what if I put the focus mandatory on the "login_button"?
[16:38] <mandel> nessita, so, the problem is that our orange bottons are stronger so when you have a button selected you won't know
[16:39] <nessita> ralsina: it happens the same
[16:39] <mandel> nessita, so, lets use tab as an example, in the grey ones it works great, on the oranges ones..
[16:39] <ralsina> nessita: another idea: change the tab order. Put the "login" button first on the tab order, then when switching back to the window, it gets the focus
[16:39] <nessita> ralsina: nice
[16:39] <mandel> nessita, is a design problem, nothing wrong with the code perse
[16:40] <nessita> mandel: I see, but I think our case is a bit different... :focus properties are not being taken into account
[16:40] <nessita> ralsina: any API to do that?
[16:40] <ralsina> and then if the user tabs... well, it acts "reasonably"
[16:40] <ralsina> nessita: Widget.setTabOrder
[16:40] <ralsina> nessita: let me find the doc
[16:40] <nessita> ralsina: ack, thanks!
[16:40] <nessita> ralsina: no need
[16:41] <ralsina> nessita: you may need to do that after the page is shown, though
[16:43] <mandel> alecu, in https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-server/+merge/95075 I see that a number of the setups of the tests are very similar, maybe making a base test case is a good idea, what do you think?
[16:44] <mandel> alecu, mock web server, tunnel web server, etc.. are always there
[16:44] <ralsina> amazing. If I type "mumbl" the dash finds mumble. If I type "mumble", it doesn't.
[16:44] <alecu> mandel, sure, I'll take a look at merging those.
[16:45] <mandel> alecu, great :)
[16:46] <mandel> alecu, I love the use of unicode to explain the tunnel server! lol
[16:47] <mandel> I think that if you pass an empty username and empty password to QNetworkProxy you will have problems, I remember having to None or not passing them at all
[16:49] <gatox> nessita, ping
[16:49] <nessita> gatox: pong
[16:50] <gatox> nessita, i'm going to upload what i have in the errors branch now... the only thing remaining is the space between the email and password, please take a look at it and let me know what you think..... uploading....
[16:50] <nessita> gatox: did you make the separation between those to be 20 px?
[16:51] <gatox> nessita, no, that the thing remaining.... because if i do that, we have another problems..... i'm uploading what i have now, before start to test some things about that
[16:51] <nessita> gatox: ack
[17:15] <mandel> alecu, partial review done: https://code.launchpad.net/~alecu/ubuntuone-client/proxy-tunnel-server/+merge/95075
[17:17] <mandel> dobey, can you approve the string mp, got a green light from design
[17:32] <dobey> mandel: no, but i'll abstain
[17:32] <mandel> dobey, fair enough :)
[17:33] <dobey> i can't approve things that violate POSIX
[17:33] <mandel> meh, I'm more pragmatic :P
[17:34] <dobey> or at least, that knowingly violate POSIX.
[17:34] <dobey> mandel: you're not pragmatic, you just don't care :)
[17:35] <mandel> dobey, I care, but I won't argue if it not my call
[17:38] <gatox> is nessita around?
[17:45] <mandel> EOD for me, laters all!
[17:47] <ralsina> bye mandel!
[17:48] <nessita> gatox: I was having lunch
[17:48] <nessita> here I am!
[17:49] <gatox> nessita, ok..... let me know about the branch.... maybe we can talk about the padding there are some spaces that we can not remove
[17:49] <nessita> gatox: which spaces?
[17:50] <briancurtin> running SSO tests on mac and getting "ImportError: cannot import name loadingoverlay_ui" -- i think i saw this before on win32 but can't remember what fixed it
[17:50] <gatox> nessita, the password part is going to be more expanded because of the password_assistance...... i tried to reduce it the most i can..... let me know if it is ok like this or we can talk some options}
[17:51] <ralsina> dobey, nessita, gatox, alecu: very very very trivial branch: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/control-c-means-quit/+merge/95424
[17:51] <gatox> ralsina, on it! :P
[17:51] <ralsina> briancurtin: python setup.py build
[17:51] <ralsina> briancurtin: and/or setting PYTHONPATH to .
[17:52] <briancurtin> hm, i thought that was a part of run-tests (it is in run-tests.bat)...and that worked. thanks!
[17:52] <briancurtin> or at least it got us further :)
[17:53] <ralsina> briancurtin: step by step :)
[17:53] <nessita> gatox: I will take a look, thanks. Though I still don't understand why vertical padding will affect the password assistance which is  on the side, and not above or below
[17:53] <gatox> nessita, if you look at the .ui you will understand
[17:55] <nessita> gatox: I will
[18:08] <gatox> nessita, all the conflicts has been resolved in both branches
[18:08] <nessita> ack!
[18:12] <gatox> i will start with the internal server error now
[18:13] <nessita> gatox: ack
[18:16] <alecu> ralsina, ping.
[18:16] <alecu> ralsina, I've met with facundobatista, we found a solution to the bug that looks clean
[18:16] <facundobatista> ralsina, the bug looks clean, the solution is a bloody mess
[18:17] <alecu> ralsina, we found other issues on the progressbar shown btw :-(
[18:17] <alecu> ralsina, the solution looks like this: http://pastebin.ubuntu.com/863839/
[18:18] <alecu> facundobatista, why a bloody mess? it's adding a new event, and changing the way two commands are created
[18:21] <alecu> and some logic in the aggregator, too...
[18:21] <alecu> so, yes, it's a bit of a mess. But it surely it's not bloody!
[18:22] <dobey> my spanish isn't that good
[18:24] <facundobatista> alecu, it was a "words game"
[18:27] <dobey> also, google translate can be dumb sometimes; moving words around
[18:28] <dobey> A o B -> or A B
[18:28] <dobey> fail.
[18:33] <ralsina> alecu: looking...
[18:33] <dobey> sigh; so i can't seem to run rhythmbox under valgrind
[18:34] <dobey> and chasing mem corruption in just gdb is a bit trying :(
[18:35] <dobey> and by trying, i mean nigh impossible :(
[18:36] <dobey> every time it crashes, the bt is subtly different, and i have to install another dbg package
[18:36] <alecu> ralsina, so, basically, it's a bunch of stuff to be done inside syncdaemon. I'm not sure I'll have time to work on that before beta 2, but I may be able to guide somebody working on that.
[18:38] <alecu> ralsina, what we found out, going thru the code with facundo is that the values shown by the progressbar will most likely be wrong (the progressbar in the U1 unity launcher)
[18:38] <alecu> ralsina, and that's because we don't have the size of the file in the case of uploads at the moment we are storing it (it comes as None and we ignore it)
[18:40] <ralsina> alecu: ok, so, we need to find time to fix this. If we think we can find the time to do it before, say, final freeze, we do nothing now
[18:40] <alecu> ralsina, this is a different issue, but probably related to this changes.
[18:40] <ralsina> alecu: if we won't be able to fix it this cycle, then we change the strings
[18:47] <alecu> ralsina, I think we should add the new strings for "many more files uploading/downloading", and after that try to fix the root issue as a bugfix.
[18:51] <ralsina> alecu: but then we may have to undo the string change
[18:52] <ralsina> alecu: I do prefer accurate reports instead of "many more" :-)
[18:52] <ralsina> dobey: should I still hold my branch about making indicate optional?
[18:52] <alecu> ralsina, we should set a limit for the cutoff value (I was thinking 100). If we need to revert it we could increase it to say, 1000.
[18:53] <ralsina> alecu: I meant, to change to "and many more files" we need a UIFe. To go back to "and XYZ files" we need another.
[18:55] <dobey> ralsina: sorry, no. mine is also proposed, whichever lands first, the other can resolve the conflict easily enough :)
[18:56] <ralsina> dobey: I'd rather wait for yours and get no conflicts, no rush for me :-)
[18:56] <gatox> ralsina, +1
[18:57] <dobey> ralsina: well, there will be a conflict, because you add a call to logger.something() and i remove the logger import :)
[18:57] <ralsina> gatox: cool, thx
[18:57] <ralsina> dobey: hahaha, it's ok, I will redo it from scratch probably
[18:57] <urbanape> briancurtin: back
[18:57] <dobey> ralsina: actually i think your branch is pretty much fine except for that logger call :)
[18:58] <ralsina> dobey: have a better but slightly more intrusive change in mind. Show_message should not return anything
[18:58] <ralsina> dobey: my branch makes show_message dangerously inconsistent
[18:58] <alecu> ralsina, hmmm...  :P
[19:02] <ralsina> alecu: ok, so it's adding a string. Good!
[19:02] <ralsina> dobey: haha, sure!
[19:02] <ralsina> dobey: mumble?
[19:02] <dobey> irc?
[19:02] <ralsina> dobey: irc is cool
[19:17] <urbanape> woohoo, loads of tests passing.
[19:17] <urbanape> -ish
[19:22] <urbanape> with a hard-coded "Yes, we've got network, just get on with it." we've got 1 failure and 1 error in ubuntu-sso
[19:22] <ralsina> urbanape: that's pretty impressive!
[19:23] <urbanape> we're skipping quite a bit (not sure if we need to or even should)
[19:24] <urbanape> and as a spike, we're not testing the new platform bits yet.
[19:32] <nessita> ralsina: can I query a qwizard button layout somehow?
[19:33] <ralsina> nessita: sure
[19:33] <ralsina> nessita: let me check the exact method
[19:33] <nessita> ralsina: sure? I'm intrigued, been looking for 15 minutes
[19:33] <nessita> (want to avoid patching)
[19:33] <ralsina> nessita: or maybe you can't ;-)
[19:34] <ralsina> nessita: you can see what buttons are visible, by iterating on button() (yeeech)
[19:34] <ralsina> nessita: but you can't see where the stretches are
[19:35] <nessita> ralsina: how can I iterate on button()?
[19:35] <nessita> asking for each known button?
[19:35] <urbanape> and run the tests enough times, that one error flips around and goes away
[19:35] <ralsina> nessita: for b in range(9): wizard.button()  (yeech)
[19:35] <urbanape> so, one failure, in test_window_size for the Wizard.
[19:35]  * nessita throws up a little
[19:36] <nessita> ralsina: same question for tabOrder :-D
[19:36] <ralsina> nessita: of course you can use QWizard.BackButton instead of 0 and so on
[19:36] <nessita> yes, of course
[19:37] <dobey> so why does ^C work fine on syncdaemon; but doesn't on sdtool
[19:38] <nessita> dobey: I think syncdaemon  has a signal handler somewhere
[19:39] <ralsina> nessita: amazingly, looks like you cannot get the tab order
[19:39] <nessita> ralsina: why 9? I count 10:     52         buttons = ['BackButton', 'CancelButton', 'CommitButton',
[19:39] <nessita>      53                    'CustomButton1', 'CustomButton2', 'CustomButton3',
[19:39] <nessita>      54                    'FinishButton', 'HelpButton', 'NextButton', 'WizardButton'
[19:39] <nessita>      55         ]
[19:39] <ralsina> nessita: https://qt-project.org/doc/qt-4.8/qwizard.html#WizardButton-enum
[19:40] <ralsina> nessita: there is no WizardButton, AFAICS
[19:41] <nessita> ack
[19:43] <ralsina> nessita: +1 on login-not-register
[19:43] <nessita> thanks!
[19:43] <ralsina> nessita: and "trivialish" so maybe just merge it
[19:44] <nessita> ack
[19:55] <dobey> hrmm; fixed one bug, though not the bug i'm looking for
[20:05] <briancurtin> ralsina: did you have a bug # for that windows admin/root thing?
[20:07] <ralsina> briancurtin: yes, let me find it
[20:08] <ralsina> briancurtin: bug #930398 and similars
[20:09] <briancurtin> ralsina: thanks, assigned to me
[20:15] <nessita> dobey: BTW, CTRL+C does not work on syncdaemon
[20:15] <nessita> dobey: I just CTRL-C it, and is hanging
[20:15] <nessita> just got this printed:
[20:15] <nessita> ^C2012-03-01 17:15:11,282 - ubuntuone.SyncDaemon - DEBUG - Signal received 2
[20:15] <nessita> ah, it ended eventually
[20:16] <nessita> 20 seconds later :-.
[20:16] <dobey> nessita: it does end. it just takes a little bit, depending on where it is in the syncdaemon process
[20:16] <nessita> dobey: my syncdaemon was IDLE... so is weird, "before" it ended immediately if it was IDLE
[20:17] <dobey> nessita: yes, i think some event has to happen for it to get through
[20:18] <dobey> it's quite odd indeed
[20:18] <urbanape> briancurtin: you kinda went silent.
[20:19] <briancurtin> dumb mute button
[20:31] <ralsina> I'm gonna take a short break. Will be back later
[20:48] <gatox> EOD for me!
[20:48] <gatox> see you tomorrow people!
[21:00] <dobey> debugging is hard.
[21:15] <cjohnston> awesomeness
[21:15] <cjohnston> uggh
[21:43] <dobey> cjohnston: what's up?
[21:43] <cjohnston> typing in the wrong window
[22:09] <nessita> ok, I'm gone
[22:09] <nessita> bye all!
[22:30] <dobey> later all


[13:39] <brobostigon> good afternoon everyone.
[22:34] <brobostigon> good night everyone, sleep well.


[09:47] <allenap> henninge: Fancy an easy one to start?
[09:47] <allenap> https://code.edge.launchpad.net/~allenap/launchpad/remove-propertycache-adapters-bug-628762/+merge/39249
[09:47] <henninge> allenap: sure! ;)
[09:47] <allenap> henninge: Thanks :)
[09:47] <henninge> allenap: He! 872 lines ...
[09:47] <henninge> ;-)
[09:47] <allenap> henninge: It's nearly 900 lines, but almost all of it is search-n-replace.
[09:48] <allenap> henninge: The interesting files are propertycache.py and propertycache.txt.
[09:48] <henninge> allenap: np, I'll be fine
[09:55] <henninge> allenap: You are the native speaker but is the "in" not misplaced here:
[09:55] <henninge> 557	+The property cache for an object can be cleared by passing in the
[09:55] <henninge> 558	+object to `clear_property_cache()`.
[09:55] <henninge> "by passing the object into ..."
[09:56] <henninge> ?
[09:56] <allenap> henninge: I think both work, but your suggestion is better.
[09:56] <henninge> allenap: Also, I first thought this was the same test twice.
[09:57] <allenap> henninge: I think I can trim it to make it look a little different.
[09:57] <henninge> allenap: or just make it clearer in the narrative that this is an alternative use of the same function.
[09:57] <allenap> henninge: Okay.
[10:00] <henninge> Wow, the new code looks much simpler. Good job!
[10:01] <allenap> henninge: Cheers :) I should have done it this way from the start. Never mind, I learnt a lot... the hard way.
[10:02] <henninge> allenap: that really was an easy one. Thanks! r=me
[10:02] <allenap> henninge: Cool, thanks
[11:44] <bac> hi henninge
[11:44] <henninge> Hey bac! ;)
[11:45] <bac> henninge: hey we're in testfix mode and i wonder if you'd sanity check this patch: http://pastebin.ubuntu.com/519603/
[11:45] <bac> normally i'd think the geo data has changed out from under us.  but best i can tell it hasn't, as we're getting the GeoIP Lite data from our PPA
[11:46] <bac> henninge: so, do you think the approach here of accepting both until we sort it out is sane?
[11:46]  * henninge looks at the failure
[11:47] <henninge> bac: oh yes, I think that is sane.
[11:47] <bac> ok, well i'll just land it rs=bac then and not implicate you
[11:48] <henninge> bac: I have never worked with geopip before.
[11:48] <bac> only minimal for me
[11:48] <henninge> but if you say "I know we may get one of these two values and we have yet to figure out why", I say your patch is a good way to get us going again.
[11:49] <henninge> bac: r=me in that case.
[11:50] <bac> henninge: that is what i'm saying
[11:50] <bac> thanks
[11:55] <bac> hi jtv.
[11:55] <jtv> hi bac!
[11:55] <jtv> happy end-of-buddhist-lent day
[12:09] <henninge> Hi jtv!
[12:10] <jtv> Hi henninge.  I'm not here.
[14:25] <lifeless> henninge: https://code.edge.launchpad.net/~lifeless/launchpad/edge/+merge/39233
[14:25]  * henninge looks
[14:27] <henninge> 186	-On launchpad.net, the version and revision numbers are presented only in an
[14:27] <henninge> 187	-HTML comment.
[14:28] <henninge> lifeless: How is that handled now? Are they always visible?
[14:28] <henninge> I don't mind, just curious.
[14:28] <lifeless> they are in a <-- section
[14:28] <lifeless> hit ctrl-U on launchpad.net
[14:29] <lifeless> down the bottom
[14:29] <lifeless> but also I've put the revno on prod after chatting with mpt
[14:29] <lifeless> (by taking it outside a tal:condition)
[14:31] <henninge> Ok, I knew that. I just thought it had changed because the test is deleted. But now that I looked closer at it, the test is not about them being in a comment but about them *not* being displayed.
[14:31] <henninge> So that's ok. ;)
[14:35] <henninge> lifeless: thanks for removing the "bleeding edge" ... ;-)
[14:35] <lifeless> I haven't done a full test run yet, this may have some breakage, but shoud be minor
[14:36] <henninge> lifeless: this still mentions edge. Is that OK?
[14:36] <henninge> 921	-         - is_edge/is_lpnet etc (thunks through to the config)
[14:36] <henninge> 922	+         - server.is_edge/is_lpnet etc (thunks through to the config)
[14:37] <lifeless> bah, I missed that; thanks
[14:37] <lifeless> it should be server.lpnet
[14:37] <lifeless> IIRC
[14:38] <henninge> lifeless: also, you seem to have removed all references to "staging" from the on-edge script but left edge in there.
[14:39] <henninge> I think that script needs a complete renaming now.
[14:40] <lifeless> henninge: I filed a bug about it
[14:40] <lifeless> uhm, I think you're reading the hunks wrongly
[14:40] <henninge> ah, cool ;)
[14:40] <lifeless> We should, i think, delete the script entirely
[14:40] <henninge> possibly
[14:40] <henninge> why am I reading them wrongly?
[14:41] <henninge> or rather "how"
[14:41] <lifeless> it still calls staging_revision = on_staging()
[14:41] <lifeless> its just that theres no longer a use case for 'just edge'
[14:41] <lifeless> because edge is approximately gone
[14:42] <lifeless> + staging_revision = get_staging_revision()
[14:42] <henninge> yes, I saw that but the command line option for staging is still there.
[14:43] <lifeless> - '--staging-only', action='store_true',
[14:43] <lifeless> 1022	- help="Only show revisions not on staging. Do not consult edge.")
[14:43] <lifeless> its gone :)
[14:43] <henninge> 1023	+        '--edge', action='store_true',
[14:43] <henninge> 1024	+        help="Show revisions on edge.")
[14:43] <lifeless> thats for edge
[14:43] <henninge> While we still have it?
[14:44] <lifeless> right
[14:44] <henninge> ah!
[14:44] <lifeless> first we remove all the differences
[14:44] <lifeless> then we put a redirect in place
[14:44] <lifeless> and a that point we need qa stuff to move from edge to qastaging
[14:44] <lifeless> so theres future tweaks to do here
[14:45] <henninge> So, this script was just about easily figuring out how far you revision had propgated through the various branches.
[14:45] <lifeless> yeah
[14:45] <henninge> that may not be needed anymore now.
[14:45] <lifeless> so devel -> stable -> deploy qastaging -> qa'd -> lpnet
[14:45] <lifeless> and db-devel -> db-stable -> staging -> ??? -> monthly release
[14:46] <henninge> Speaking of which: I just created a draft for the 2011 release calendar (see your mail). We will still be having monthly releases, right?
[14:47] <lifeless> yes
[14:47] <lifeless> until we get db flexability in place
[14:49] <henninge> ok
[14:49] <henninge> lifeless: r=me
[14:50] <lifeless> thank you
[15:25] <allenap> henninge: Do you fancy another easy one?
[15:29] <henninge> allenap: please! ;)
[15:29] <allenap> henninge: https://code.edge.launchpad.net/~allenap/launchpad/ditch-get-bug-notifications-recipients-bug-659085-devel/+merge/39277
[15:29] <allenap> henninge: It's big... at first glance.
[15:29] <allenap> henninge: But it's actually almost all reviewed. Just a little diff (in the description) to review.
[15:36] <henninge> allenap: I have never seen a doc test import from a unit test. Is that a good(tm) practice?
[15:38] <allenap> henninge: I don't think it's a problem, but it is a bit odd. Certainly BugTaskSearchBugsElsewhereTest.__init__() smells bad.
[15:40] <allenap> henninge: Arguable those helper methods should have been put in a mixin or just a separate class, but as it is it's reasonably easy to figure out what's going on. I don't think there's much harm in it.
[15:40] <henninge> Argh! Now I get what that is doing.
[15:41] <henninge> allenap: Luckily it's not part of this review ... ;-)
[15:41] <allenap> henninge: Yes, that's what I thought :)
[15:42] <henninge> allenap: could you call the result "naked_bugtasks" here?
[15:42] <henninge> +        bugtasks = [removeSecurityProxy(bugtask) for bugtask in bugtasks]
[15:42] <allenap> henninge: Sure.
[15:43] <henninge> I think there was an agreement to clearly mark naked entities as such ...
[15:44] <henninge> allenap: r=me for the handy diff. ;-)
[15:46] <allenap> henninge: Thanks :)
[16:13] <rockstar> henninge, abentley, can I send a review to one of you?
[16:14] <henninge> rockstar: I am almost done. Sorry.
[16:14] <henninge> In fact, I am done ... ;)
[16:14] <rockstar> henninge, it's VERY short.  :)
[16:14] <henninge> rockstar: sure
[16:14] <henninge> ;-)
[16:14] <henninge> short & fun - always!
[16:18] <leonardr> abentley, pretty easy branch for your consideration: https://code.edge.launchpad.net/~leonardr/lazr.restful/fix-unicode-error/+merge/39279
[16:19] <abentley> leonardr: Okay.
[16:20] <abentley> leonardr: you have conflicts.
[16:20] <rockstar> abentley, can you also review my branch?
[16:20] <rockstar> abentley, https://code.edge.launchpad.net/~rockstar/launchpad/fix-queue-permissions/+merge/39278 plz.
[16:20] <abentley> rockstar: Sure.  I thought henninge was looking at it.
[16:20] <henninge> rockstar, abentley: I am!
[16:21] <rockstar> henninge, oh!  I thought you were being sarcastic.  :)
[16:21] <henninge> rockstar: not my nature ... :)
[16:22] <leonardr> abentley: argh, coordinating with benji
[16:24] <abentley> leonardr: I am a bit confused by line 187; shouldn't that have a unicode escape, not \xc3\xa7?
[16:25] <henninge> rockstar: Have you started your own Canonical spin-off? A bit obvious, don't you think?
[16:25] <henninge> 136	-# Copyright 2009-2010 Canonical Ltd.  This software is licensed under the
[16:25] <henninge> 137	+# Copyright 2009-2010 aanonical Ltd.  This software is licensed under the
[16:25] <henninge> ;-)
[16:25] <rockstar> henninge, huh.  I'll fix that...
[16:25] <leonardr> abentley: no, because the test suite (i think, benji might know better) decodes the unicode string
[16:27] <abentley> leonardr: Did you consider making this a unit test?
[16:27] <benji> actually it's the other way around; it doesn't attempt to decode the string, so you just get the bytes
[16:27] <henninge> rockstar: r=me ;-)
[16:27] <rockstar> henninge, thank you sir!
[16:28] <abentley> benji: so that's a platform-specific value, then?
[16:29] <leonardr> abentley, that's a huge pain, but i'll try
[16:30] <abentley> benji: looks like utf-8 to me, not utf-16, which AIUI is the internal representation on Ubuntu python.
[16:31] <benji> abentley: theoretically it could vary, but practically shouldn't
[16:32] <abentley> benji: I don't think pretty sure it's the plain bytes of the unicode string, because on Ubuntu, the internal representation is utf-16, and that's utf-8.
[16:32] <abentley> benji: I think it's more likely that it was encoded as utf-8.
[16:33] <leonardr> if i'm able to make it a unit test i should also be able to control the encoding
[16:33] <allenap> salgado: Are you available to do UI reviews? It's not urgent.
[16:33] <abentley> leonardr: true, but as a unit test, you can just compare against a unicode string.
[16:33] <benji> abentley: I forget the exact details, but Python doesn't use utf-8 or -16 internally, it uses 16 or 32-bits per character (depending on how it was compiled)
[16:34] <salgado> allenap, not really, I'm attending some UDS sessions remotely while I wait for my flight to the US
[16:34] <allenap> salgado: Okay, thanks anyway. Have a good trip :)
[16:35] <salgado> thanks. :)
[16:36] <abentley> benji: In this bug report, Adam Olsen asserts that it uses utf-16, not UCS2: http://bugs.python.org/issue3297
[16:37] <benji> abentley: yep I was thinking of UCS-2/UCS-4, but it does indeed use UTF-16/UTF-32
[16:41] <abentley> leonardr: I'm not saying you have to use a unit test, but in Launchpad, the policy is that doctests should be testable documentation.
[16:48] <gary_poster> abentley: five-line-diff version-bump review when you have a moment: https://code.edge.launchpad.net/~gary/launchpad/storm-0.18/+merge/39286
[16:49] <abentley> gary_poster: r=me
[16:49] <gary_poster> thanks abentley
[17:31] <leonardr> abentley: behold: http://pastebin.ubuntu.com/519760/
[17:34] <abentley> leonardr: r=me.
[20:38] <leonardr> benji: i named launchpadlib 1.7.0 in anticipation of your kwallet branch. you don't need to call this branch 1.8.0
[20:40] <leonardr> we usually do 'import cStringIO as StringIO'
[20:45] <benji> leonardr: (assuming that comment was for me) ewww  :)
[20:46] <leonardr> benji: actually, we do 'from cStringIO import StringIO', if that makes you feel better
[20:46] <benji> much better
[20:49] <leonardr> benji, why do you have callback_called as a list instead of a boolean? i imagine it has something to do with the possibility that the callback might be called multiple times?
[20:49] <leonardr> but if so, wouldn't you check the list to make sure it was only called once?
[20:50] <benji> leonardr: nope, it's because I can't rebind callback_called, just mutate it
[20:50] <leonardr> ah, ok
[20:51] <benji> perhaps a note to that effect is warrented
[20:51] <leonardr> benji: the code is weird. bool([False]) is True
[20:51] <leonardr> i think you should check that the list is [True]
[20:52] <benji> mmm, yeah that sounds like a bug
[20:52] <leonardr> bool([]) is False, but your use of booleans _inside_ the list strongly implies that you are checking those values
[20:53] <leonardr> you could have the callback append object() to the list, and make sure the list was nonempty
[20:53] <benji> leonardr: oh, well it's not a bug per se; I'm signaling truth by there being something lin the list
[20:53] <benji> yeah, I'd say appending None would be the most straight-forward
[20:53] <leonardr> +1
[21:05] <leonardr> benji: can you run this code in bin/py on your kwallet branch and see if it works for you? i get an error but it might be a version mismatch
[21:05] <leonardr> >>> from launchpadlib.launchpad import Launchpad
[21:05] <leonardr> >>> f = Launchpad.login_with("bar baz", "edge")
[21:05] <benji> sure
[21:06] <benji> leonardr: I get this: TypeError: __init__() takes at most 5 arguments (6 given)
[21:06] <benji> I'll dig into it.
[21:06] <leonardr> ok, cool
[21:10] <leonardr> benji, review sent. i'm very glad that you were able to fix keyring so that we could use it
[21:11] <benji> leonardr: oh, I meant to mention that I was able to do away with the Qt widget bit (I still had to create a Qt "application" but that's not too bad)
[21:11] <leonardr> benji: and that's in keyring, not in our code, right?
[21:11] <benji> right
[21:12] <benji> I expect Tarek to make a release of keyring this week that includes my changes.
[21:12] <leonardr> great, where's it coming from now?
[21:12] <leonardr> ie. if i didn't get that TypeError would i be using your code?
[21:12] <leonardr> or what would happen?
[21:18] <leonardr> benji -^
[21:20] <benji> leonardr: you'd be using the version before my changes (because that's what buildout gets from PyPI), which probably couldn't build the GNOME bits, and it probably couldn't build the encyption bits, so more than likely you'll just be using a file
[21:22] <leonardr> benji: ok, sometime tomorrow i'd like to get the whole thing running with your code so i can do an end-to-end test
[21:22] <benji> sounds good
[21:23] <jcsackett> abentley: have time for a review?
[21:23] <jcsackett> https://code.edge.launchpad.net/~jcsackett/launchpad/hidden-project-configuration-636000/+merge/39306
[21:40] <abentley> jcsackett: Prolly not.
[21:41] <jcsackett> abentley: fair. i wouldn't be able to get in to merge today anyway.
[22:27] <StevenK> abentley: ^ If you have time
[22:27] <abentley> StevenK: Sorry, I've EODed.
[22:28] <StevenK> No fair dropping me from the queue
[22:29] <abentley> StevenK: It's an on-call review queue.  No one has agreed to review you, so you can't be in the queue.
[22:32] <thumper> StevenK: paste the link
[22:33] <StevenK> thumper: https://code.edge.launchpad.net/~stevenk/launchpad/cronscript-idsjob-testfix/+merge/39321


[03:09] <StevenK> wgrant: Hmm, I thought we already had a script to clean up failed translations imports? Ref bug 576822
[03:09] <_mup_> Bug #576822: Add an option to clean up after a failed run of copy-translations-from-parent.py <lp-translations> <tech-debt> <Launchpad itself:Triaged> < https://launchpad.net/bugs/576822 >
[03:12] <wgrant> StevenK: I think there was a one-off script for precise
[03:34] <StevenK> 450282.22s  OOPS-674539797ca55814a0c0894007b34498  Unknown
[03:34] <StevenK> BLINK
[03:35] <StevenK> 5 days, 5 hours
[03:35] <lifeless> thats some request
[03:36] <wgrant> oooooh
[03:36] <wgrant> checkwatches unhung
[03:36] <wgrant> That explains a lot of the other OOPSes
[03:37] <StevenK> Right
[03:37] <StevenK> I just loaded that OOPS
[03:37] <wgrant> So
[03:37] <wgrant> Next step
[03:38] <wgrant> Work out what bugwatch 57103 is
[03:38] <wgrant> bugzilla.filesystems.org #632
[03:39] <wgrant> The host responds, but doesn't look much like a bugzilla at all really
[03:39] <lifeless> honeypot?
[03:39] <wgrant> Ah, on https there's a bugzilla with a bad cert
[03:40] <StevenK> But 5 days 5 hours? Surely we should timeout much quicker
[03:40] <wgrant> Certainly
[03:40] <wgrant> But should and do are different
[03:40] <wgrant> Particularly when it comes to checkwatches
[03:40] <StevenK> Indeed
[03:41] <wgrant> That's the only bugwatch from that tracker
[03:45] <StevenK> wgrant: You've commented on bug 758258 about a migration
[03:45] <_mup_> Bug #758258: buildfarmjob schema is inefficient for reporting <critical-analysis> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/758258 >
[03:46] <wgrant> That's a reasonably big effort still, so it remains suspended until we run out of low-hanging fruit
[03:46]  * StevenK has been looking to no avail for low-hanging fruit
[03:47] <wgrant> There's a lot of fairly easy timeouts and OOPSes left
[03:48] <wgrant> 2012-10-17 10:39:23 INFO    Updating 1 watches for 1 bugs on https://bugzilla.filesystems.org
[03:48] <wgrant> 2012-10-22 15:44:03 INFO    An exception was raised when updating https://bugzilla.filesystems.org/ (OOPS-674539797ca55814a0c0894007b34498)
[03:55] <wgrant> 2012-09-24 07:11:24 INFO    Updating 1 watches for 1 bugs on https://bugzilla.filesystems.org
[03:56] <wgrant> That same bugtracker caused the earlier hang
[04:04] <wgrant> 2012-10-23 04:03:58 INFO    Updating 1 watches for 1 bugs on https://bugzilla.filesystems.org
[04:04] <wgrant> and now we wait..
[04:04] <wgrant> :(
[04:04] <wgrant> 2012-10-23 04:04:10 INFO    Error updating https://bugzilla.filesystems.org/: Failed to parse XML description for https://bugzilla.filesystems.org bugs [u'632']: mismatched tag: line 101, column 4
[04:04] <wgrant> It worked
[04:04] <StevenK> What did you changed?
[04:04] <wgrant> This was locally
[04:05] <StevenK> Sure, but did you change anything
[04:05] <wgrant> No
[04:05] <StevenK> Ah
[04:06] <StevenK> Maybe bugzilla.filesystems.org is blocking loganberry?
[04:08] <wgrant> It even works via squid.internal
[04:08] <StevenK> Bleh, are there no webservice tests for DSDs?
[04:09] <wgrant> Not even under registry?
[04:09] <StevenK> Not that I can see
[04:09] <StevenK> I suspect it's a lazr.restful bug anyway
[04:33] <StevenK> wgrant: I am disappoint. You didn't rip out contrib.glock in disgust while I was on holidays.
[04:39] <wgrant> Indeed.
[04:43] <StevenK> wallyworld_, wgrant: https://code.launchpad.net/~stevenk/lazr.restful/lazr.restful-choice-marshaller-none/+merge/130932
[04:47] <wallyworld_> StevenK: looks ok, but i don't know enough about the semantics of the code to be able to offer a considered opinion
[04:49] <wgrant> StevenK: Is this circumstance actually valid?
[04:50] <StevenK> wgrant: Bug 924291
[04:50] <_mup_> Bug #924291: AttributeError: 'NoneType' object has no attribute 'title' on package differences page <derivation> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/924291 >
[04:51] <wgrant> StevenK: It can happen, but is it valid?
[04:51] <StevenK> parent_package_diff_status is a Choice of PackageDiffStatus, but the property returns None if the DSD's parent_package_diff is None
[04:52] <wgrant> I thought it would usually escape earlier if the value was None
[04:53] <StevenK> wgrant: Like I say in the description, unmarshall_to_closeup will return the entire vocab in any case.
[04:53] <StevenK> I can change LP to just return PackageDiffStatus.PENDING and never-mind this lazr.restful branch
[04:53] <wgrant> Ah, I see now reading the code that your argument makes sense
[04:55] <wgrant> r=me
[04:57] <StevenK> wgrant: Thanks
[06:00] <wgrant> lifeless: Was lazr.postgresql intended for just schema migration stuff? There's some long lock/transaction tools that I need to find somewhere to put
[06:07] <lifeless> wgrant: it was intended to pull out everything postgresql specific that doesn't rightfully belong in storm.
[06:07] <lifeless> wgrant: or in LP itself.
[06:07] <wgrant> Right
[06:07] <wgrant> Thanks
[06:07] <lifeless> and isn't pgbouncer specific
[06:07] <wgrant> That's what I thought, but wanted to check
[06:07] <lifeless> :)
[09:15] <cjwatson> wgrant: So, early this month you fixed a packagediff generation bug that happened when we deleted things from -proposed a bit too early and then tried to copy the orphaned binary resulting from a build
[09:15] <cjwatson> wgrant: packagediff generation is pretty late in the copy process; does that mean that this kind of situation should now completely work without us having to do weird copy dances?
[09:16] <cjwatson> Archive.copyPackage and PCJ.attemptCopy don't seem to care about the publication status of the origin SPPH
[09:17] <cjwatson> So they ought to be able to copy from a deleted SPPH that's had some binaries added to it later ... I think
[09:19] <cjwatson> wgrant: Also, did you forget to close bugs following the recent NDT, possibly?  I'd have expected e.g. bug 1068616 to be closed
[09:19] <_mup_> Bug #1068616: Archive.copyPackages hardcodes RELEASE pocket <package-copies> <qa-ok> <releases> <Launchpad itself:Fix Committed by cjwatson> < https://launchpad.net/bugs/1068616 >
[09:21] <wgrant> cjwatson: Um, I was probably accidentally on the critical list, so missed non-criticals
[09:21] <wgrant> As for the orphaned binary copy, yes, I believe it should all work now
[09:21] <wgrant> But there's a catch
[09:21] <cjwatson> Also bug 1014641 (critical)
[09:21] <wgrant> There's no way to specify the source pocket today
[09:21] <_mup_> Bug #1014641: +vouchers times out <bad-commit-16172> <qa-ok> <salesforce> <timeout> <Launchpad itself:Fix Committed by wallyworld> < https://launchpad.net/bugs/1014641 >
[09:21] <wgrant> cjwatson: That's not deployed yet
[09:21] <cjwatson> Oh, sorry, that's still on the report
[09:21] <cjwatson> Confusing, it was in the LPS dump
[09:22] <wgrant> cjwatson: Ah, yeah, it was landed and then reverted, and then landed again
[09:22] <cjwatson> Oh, the ambiguous pocket thing - right, that sounds pretty easy to fix
[09:22] <wgrant> The first two bits are deployed
[09:22] <wgrant> Indeed
[09:22] <wgrant> But reviving orphaned binaries should work fine now, if you copy back to -proposed first
[09:22] <wgrant> Or if you fix the API to allow an explicit pocket
[09:22] <cjwatson> Right, so I'm conscious that there are some situations where britney is going to create this kind of thing
[09:23] <cjwatson> e.g. 1.0-1 ftbfs on powerpc, 1.0-2 initially does as well, britney sees it's no worse than before and copies, then somebody retries 1.0-2/powerpc and it works
[09:23] <wgrant> Note that we haven't tested it, but packagediff generation is so close to the end of the process that it surely has to
[09:23] <wgrant> work, that is
[09:24] <cjwatson> I was contemplating beefing up test_incremental_binary_copies a bit
[09:24] <wgrant> That might be handy
[09:24] <cjwatson> It tests about 80% of this
[09:24] <wgrant> While you're there it may also be worth sorting out the random override issue
[09:24] <wgrant> Since that's a matter of a .order_by(BPPH.id) and a test
[09:24] <cjwatson> Oh god this is a horrible ancestry nightmare isn't it?
[09:24] <cjwatson> No?
[09:24] <wgrant> I don't think so
[09:25] <wgrant> It's not a total nightmare
[09:25] <cjwatson> Last night I found vague allusions to a lot of this stuff in IRC logs from earlier in the month, but there wasn't enough to track them down to things I could fix on the spot
[09:25] <wgrant> I don't think it'll do the override dance for an intra-archive copy, will it?
[09:25] <wgrant> It'll just use whatever getBuiltBinaries returns
[09:26] <wgrant> The problem with that method is that it doesn't guarantee which publication will be returned if there are multiple BPPHs for a BPR
[09:26] <wgrant> So, if you try to copy an upload that's had its overrides changed, you're going to get a random assortment of overrides
[09:26] <cjwatson> .order_by doesn't sound like a complete fix, then
[09:27] <cjwatson> There won't be a BPPH until the build happens; and we probably want to pick up the overrides from some other architecture that's already built
[09:27] <wgrant> getBuiltBinaries iterates through the entire set of binary publications, and IIRC uses the first one it finds for each BPR
[09:27] <wgrant> So an order_by should fix it
[09:27] <wgrant> Hmm?
[09:27] <wgrant> The build will upload and do normal ancestry calculation, which is correct.
[09:27] <wgrant> It's only copies that use getBuiltBinaries' arbitrary chooser
[09:27] <cjwatson> Otherwise you change 1.0-2 to component: main for all the architectures that already exist, and then when 1.0-2/powerpc appears it'll flip back to whatever 1.0-1/powerpc was?
[09:28] <wgrant> Well, yes, but that's an ancient bug
[09:28] <cjwatson> Oh, right, I understand now
[09:28] <wgrant> From early 2006
[09:28] <wgrant> Which we've lived with for nearly 7 years :)
[09:28] <wgrant> https://bugs.launchpad.net/launchpad/+bug/180218
[09:28] <_mup_> Bug #180218: override mismatch race needs to be fixed <boobytrap> <lp-soyuz> <soyuz-publish> <soyuz-upload> <Launchpad itself:Triaged> < https://launchpad.net/bugs/180218 >
[09:28] <wgrant> There was an older one, once upon a time
[09:28] <cjwatson> Yeah, not fixing that this week
[09:28] <wgrant> But that's the current one about the situation you describe
[09:28] <wgrant> Mine is perhaps more insidious and easier to fix
[09:29] <cjwatson> Wrong overrides are a relatively minor problem in the development series; we have a report for them
[09:29] <cjwatson> (i.e. override mismatches between architectures)
[09:29] <wgrant> Sure
[09:29] <cjwatson> And it's empty most of the time
[09:32] <cjwatson> But yeah, I'm a small handful of LP commits away from having britney allegedly fully working, so just trying to think of ways it might unintentionally explodify the archive in advance ...
[09:33] <cjwatson> I've been able to run it over nearly-trivial cases in raring-proposed in production and have it copy stuff successfully
[09:33] <wgrant> As long as we have robust binary revival copies it should all be recoverable
[10:25] <cjwatson> wgrant: could you have a look at https://code.launchpad.net/~cjwatson/launchpad/db-redirect-release-uploads/+merge/130857 ?
[13:43] <wallyworld_> sinzui: lines 236-241 of the diff add the extra Related Projects link to the person index page
[13:45] <sinzui> i suck. sorry wallyworld_
[13:46] <wallyworld_> np, merely an oversight
[13:46] <wallyworld_> easy to miss
[13:46] <wallyworld_> the rest we can discuss tomorrow, you raise good points, i wasn't sure what to remove and what to keep
[13:47]  * wallyworld_ off to bed
[13:48] <sinzui> wallyworld_, oversight? I knew exactly where the change had to be, and I read the diff, and I looked over the diff for the very file you did change, then told you you needed to make the change that is clearly in the diff
[13:48] <wallyworld_> don't worry, i'm not :-)
[15:33] <cjwatson> wgrant: Can you see why debootstrap/1.0.42ubuntu1 and apparmor/2.8.0-0ubuntu6 didn't get announcement mails when they were accepted into raring-proposed?  I didn't think PROPOSED was special here.  I think I used the API to accept the former; not sure how the latter was done.
[16:13] <czajkowski> cr3: your ml request should get done today
[16:25] <cr3> czajkowski: sweet, thanks so much!
[16:26] <czajkowski> cr3: well we're still checking it but updates will be on the question
[17:45] <cjwatson> wgrant: So, this random overrides thing - I'm having a hard time seeing how to trigger it, since getBuiltBinaries requires the BPPHs it returns to match the distroseries and pocket of the SPPH.  How could there ever be more than one per BPN/architecturetag?
[17:47] <cjwatson> Oh, changeOverride would create a new BPPH, wouldn't it, duh
[21:54] <wgrant> cjwatson: It doesn't require that they're published, and changeOverride creates a new BPPH, indeed
[21:56] <wgrant> cjwatson: Did you find out what happened to the debootstrap and apparmor announcements?
[21:56] <cjwatson> No
[21:56] <wgrant> k, will investigate
[21:56] <cjwatson> Couldn't figure out where useful logs would be
[21:59] <wgrant> You tell funny jokes
[22:51] <wallyworld_> wgrant: StevenK: sinzui: http://askubuntu.com/questions/202677/nvidia-driver-doesnt-work-in-12-10
[23:25] <sinzui> wgrant, I forgot to ask you to take a look at Colin's db branch in reviews
[23:31] <wgrant> sinzui: It's already on my list after he pinged me about it last night :)


[09:38] <davidcalle> Chipaca, ping
[12:50] <JOY062> Hi
[12:50] <JOY062> I want to learn English
[13:00] <karni> JOY062: You are in the right place!
[13:03] <JOY062> ^^
[13:04] <karni> JOY062: And enjoy, you fooled me there for a second ;)
[21:55] <mwhudson> is there some way of seeing all the files in a large directory in the web interface?
[21:56] <karni> mwhudson: what do you mean by seeing all the files?
[21:57] <karni> mwhudson: once you view a directory, you should see all files in it listed in the web interafce
[21:57] <mwhudson> ah, i think i was looking in the wrong place
[21:57] <karni> mwhudson: ah okey then :)
[21:57]  * karni disappears