payload: {"action":"opened","number":206,"pull_request":{"url":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/206","id":252815818,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyODE1ODE4","html_url":"https://github.com/UAVCAN/libuavcan/pull/206","diff_url":"https://github.com/UAVCAN/libuavcan/pull/206.diff","patch_url":"https://github.com/UAVCAN/libuavcan/pull/206.patch","issue_url":"https://api.github.com/repos/UAVCAN/libuavcan/issues/206","number":206,"state":"open","locked":false,"title":"Many fixes to CMakeLists and dsdl compiler","user":{"login":"thirtytwobits","id":19180861,"node_id":"MDQ6VXNlcjE5MTgwODYx","avatar_url":"https://avatars2.githubusercontent.com/u/19180861?v=4","gravatar_id":"","url":"https://api.github.com/users/thirtytwobits","html_url":"https://github.com/thirtytwobits","followers_url":"https://api.github.com/users/thirtytwobits/followers","following_url":"https://api.github.com/users/thirtytwobits/following{/other_user}","gists_url":"https://api.github.com/users/thirtytwobits/gists{/gist_id}","starred_url":"https://api.github.com/users/thirtytwobits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirtytwobits/subscriptions","organizations_url":"https://api.github.com/users/thirtytwobits/orgs","repos_url":"https://api.github.com/users/thirtytwobits/repos","events_url":"https://api.github.com/users/thirtytwobits/events{/privacy}","received_events_url":"https://api.github.com/users/thirtytwobits/received_events","type":"User","site_admin":false},"body":"Modenizing the build script and making the dsdl compiler more flexible.\r\n\r\nSwitching to pydsdl for code generation\r\n\r\nThis is a partial fix. The generator is junk now and needs a complete\r\nrewrite. This change does prove out the makefile and interface to the\r\ngenerator.\r\n\r\nWhat's important is to agree on, without question, my decisions about submodule, commons, and virtualenv. Dissent will not be tolerated.\r\n\r\nI wouldn't spend any time reviewing libuavcan_dsdl_compiler/__init__.py. I hacked it to simply spew .hpp files whether they were valid C++ or not. I have a change to rewrite dsdlc (I'm calling mine dsdl2cpp) in the works so this code is about to be deleted.\r\n\r\nSome concepts introduced in libuavcan_dsdlc with this change will carry forward in dsdl2cpp:\r\n\r\n1. --dry-run will allow the build system to enumerate outputs obviating the need for a \"stamp\" file.\r\n2. template code will be located along side the cpp source under libuavcan/. This is because the template must remain in-sync with the source but the generator has some flexibility in how it can change without necessarily breaking the templates.\r\n3. the generator will not try to detect rebuilds (it will always generate). Build systems like make do this for us and are better at it.\r\n\r\nI'm also considering a switch to jinja2 for a template language. I have more experience with jinja2 and I find the templates more readable. But this is a debate for my next code review!","created_at":"2019-02-13T19:19:54Z","updated_at":"2019-02-13T19:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/206/commits","review_comments_url":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/206/comments","review_comment_url":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UAVCAN/libuavcan/issues/206/comments","statuses_url":"https://api.github.com/repos/UAVCAN/libuavcan/statuses/7ed14816f3714aa743c25bbd95ae12da007e40ef","head":{"label":"thirtytwobits:feature/v1-cmake-progress","ref":"feature/v1-cmake-progress","sha":"7ed14816f3714aa743c25bbd95ae12da007e40ef","user":{"login":"thirtytwobits","id":19180861,"node_id":"MDQ6VXNlcjE5MTgwODYx","avatar_url":"https://avatars2.githubusercontent.com/u/19180861?v=4","gravatar_id":"","url":"https://api.github.com/users/thirtytwobits","html_url":"https://github.com/thirtytwobits","followers_url":"https://api.github.com/users/thirtytwobits/followers","following_url":"https://api.github.com/users/thirtytwobits/following{/other_user}","gists_url":"https://api.github.com/users/thirtytwobits/gists{/gist_id}","starred_url":"https://api.github.com/users/thirtytwobits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirtytwobits/subscriptions","organizations_url":"https://api.github.com/users/thirtytwobits/orgs","repos_url":"https://api.github.com/users/thirtytwobits/repos","events_url":"https://api.github.com/users/thirtytwobits/events{/privacy}","received_events_url":"https://api.github.com/users/thirtytwobits/received_events","type":"User","site_admin":false},"repo":{"id":126653018,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY2NTMwMTg=","name":"libuavcan","full_name":"thirtytwobits/libuavcan","private":false,"owner":{"login":"thirtytwobits","id":19180861,"node_id":"MDQ6VXNlcjE5MTgwODYx","avatar_url":"https://avatars2.githubusercontent.com/u/19180861?v=4","gravatar_id":"","url":"https://api.github.com/users/thirtytwobits","html_url":"https://github.com/thirtytwobits","followers_url":"https://api.github.com/users/thirtytwobits/followers","following_url":"https://api.github.com/users/thirtytwobits/following{/other_user}","gists_url":"https://api.github.com/users/thirtytwobits/gists{/gist_id}","starred_url":"https://api.github.com/users/thirtytwobits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirtytwobits/subscriptions","organizations_url":"https://api.github.com/users/thirtytwobits/orgs","repos_url":"https://api.github.com/users/thirtytwobits/repos","events_url":"https://api.github.com/users/thirtytwobits/events{/privacy}","received_events_url":"https://api.github.com/users/thirtytwobits/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thirtytwobits/libuavcan","description":"Portable reference implementation of the UAVCAN protocol stack in C++ for embedded systems and Linux.","fork":true,"url":"https://api.github.com/repos/thirtytwobits/libuavcan","forks_url":"https://api.github.com/repos/thirtytwobits/libuavcan/forks","keys_url":"https://api.github.com/repos/thirtytwobits/libuavcan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thirtytwobits/libuavcan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thirtytwobits/libuavcan/teams","hooks_url":"https://api.github.com/repos/thirtytwobits/libuavcan/hooks","issue_events_url":"https://api.github.com/repos/thirtytwobits/libuavcan/issues/events{/number}","events_url":"https://api.github.com/repos/thirtytwobits/libuavcan/events","assignees_url":"https://api.github.com/repos/thirtytwobits/libuavcan/assignees{/user}","branches_url":"https://api.github.com/repos/thirtytwobits/libuavcan/branches{/branch}","tags_url":"https://api.github.com/repos/thirtytwobits/libuavcan/tags","blobs_url":"https://api.github.com/repos/thirtytwobits/libuavcan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thirtytwobits/libuavcan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thirtytwobits/libuavcan/git/refs{/sha}","trees_url":"https://api.github.com/repos/thirtytwobits/libuavcan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thirtytwobits/libuavcan/statuses/{sha}","languages_url":"https://api.github.com/repos/thirtytwobits/libuavcan/languages","stargazers_url":"https://api.github.com/repos/thirtytwobits/libuavcan/stargazers","contributors_url":"https://api.github.com/repos/thirtytwobits/libuavcan/contributors","subscribers_url":"https://api.github.com/repos/thirtytwobits/libuavcan/subscribers","subscription_url":"https://api.github.com/repos/thirtytwobits/libuavcan/subscription","commits_url":"https://api.github.com/repos/thirtytwobits/libuavcan/commits{/sha}","git_commits_url":"https://api.github.com/repos/thirtytwobits/libuavcan/git/commits{/sha}","comments_url":"https://api.github.com/repos/thirtytwobits/libuavcan/comments{/number}","issue_comment_url":"https://api.github.com/repos/thirtytwobits/libuavcan/issues/comments{/number}","contents_url":"https://api.github.com/repos/thirtytwobits/libuavcan/contents/{+path}","compare_url":"https://api.github.com/repos/thirtytwobits/libuavcan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thirtytwobits/libuavcan/merges","archive_url":"https://api.github.com/repos/thirtytwobits/libuavcan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thirtytwobits/libuavcan/downloads","issues_url":"https://api.github.com/repos/thirtytwobits/libuavcan/issues{/number}","pulls_url":"https://api.github.com/repos/thirtytwobits/libuavcan/pulls{/number}","milestones_url":"https://api.github.com/repos/thirtytwobits/libuavcan/milestones{/number}","notifications_url":"https://api.github.com/repos/thirtytwobits/libuavcan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thirtytwobits/libuavcan/labels{/name}","releases_url":"https://api.github.com/repos/thirtytwobits/libuavcan/releases{/id}","deployments_url":"https://api.github.com/repos/thirtytwobits/libuavcan/deployments","created_at":"2018-03-25T00:57:39Z","updated_at":"2019-02-03T03:54:27Z","pushed_at":"2019-02-13T19:10:05Z","git_url":"git://github.com/thirtytwobits/libuavcan.git","ssh_url":"git@github.com:thirtytwobits/libuavcan.git","clone_url":"https://github.com/thirtytwobits/libuavcan.git","svn_url":"https://github.com/thirtytwobits/libuavcan","homepage":"http://uavcan.org","size":2934,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UAVCAN:uavcan-v1.0-bluesky","ref":"uavcan-v1.0-bluesky","sha":"8ee2326d56027364e6c3cc893542e7707daa37ae","user":{"login":"UAVCAN","id":10167381,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTY3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/10167381?v=4","gravatar_id":"","url":"https://api.github.com/users/UAVCAN","html_url":"https://github.com/UAVCAN","followers_url":"https://api.github.com/users/UAVCAN/followers","following_url":"https://api.github.com/users/UAVCAN/following{/other_user}","gists_url":"https://api.github.com/users/UAVCAN/gists{/gist_id}","starred_url":"https://api.github.com/users/UAVCAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UAVCAN/subscriptions","organizations_url":"https://api.github.com/users/UAVCAN/orgs","repos_url":"https://api.github.com/users/UAVCAN/repos","events_url":"https://api.github.com/users/UAVCAN/events{/privacy}","received_events_url":"https://api.github.com/users/UAVCAN/received_events","type":"Organization","site_admin":false},"repo":{"id":16183388,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4MzM4OA==","name":"libuavcan","full_name":"UAVCAN/libuavcan","private":false,"owner":{"login":"UAVCAN","id":10167381,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTY3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/10167381?v=4","gravatar_id":"","url":"https://api.github.com/users/UAVCAN","html_url":"https://github.com/UAVCAN","followers_url":"https://api.github.com/users/UAVCAN/followers","following_url":"https://api.github.com/users/UAVCAN/following{/other_user}","gists_url":"https://api.github.com/users/UAVCAN/gists{/gist_id}","starred_url":"https://api.github.com/users/UAVCAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UAVCAN/subscriptions","organizations_url":"https://api.github.com/users/UAVCAN/orgs","repos_url":"https://api.github.com/users/UAVCAN/repos","events_url":"https://api.github.com/users/UAVCAN/events{/privacy}","received_events_url":"https://api.github.com/users/UAVCAN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UAVCAN/libuavcan","description":"Portable reference implementation of the UAVCAN protocol stack in C++ for embedded systems and Linux.","fork":false,"url":"https://api.github.com/repos/UAVCAN/libuavcan","forks_url":"https://api.github.com/repos/UAVCAN/libuavcan/forks","keys_url":"https://api.github.com/repos/UAVCAN/libuavcan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UAVCAN/libuavcan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UAVCAN/libuavcan/teams","hooks_url":"https://api.github.com/repos/UAVCAN/libuavcan/hooks","issue_events_url":"https://api.github.com/repos/UAVCAN/libuavcan/issues/events{/number}","events_url":"https://api.github.com/repos/UAVCAN/libuavcan/events","assignees_url":"https://api.github.com/repos/UAVCAN/libuavcan/assignees{/user}","branches_url":"https://api.github.com/repos/UAVCAN/libuavcan/branches{/branch}","tags_url":"https://api.github.com/repos/UAVCAN/libuavcan/tags","blobs_url":"https://api.github.com/repos/UAVCAN/libuavcan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UAVCAN/libuavcan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UAVCAN/libuavcan/git/refs{/sha}","trees_url":"https://api.github.com/repos/UAVCAN/libuavcan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UAVCAN/libuavcan/statuses/{sha}","languages_url":"https://api.github.com/repos/UAVCAN/libuavcan/languages","stargazers_url":"https://api.github.com/repos/UAVCAN/libuavcan/stargazers","contributors_url":"https://api.github.com/repos/UAVCAN/libuavcan/contributors","subscribers_url":"https://api.github.com/repos/UAVCAN/libuavcan/subscribers","subscription_url":"https://api.github.com/repos/UAVCAN/libuavcan/subscription","commits_url":"https://api.github.com/repos/UAVCAN/libuavcan/commits{/sha}","git_commits_url":"https://api.github.com/repos/UAVCAN/libuavcan/git/commits{/sha}","comments_url":"https://api.github.com/repos/UAVCAN/libuavcan/comments{/number}","issue_comment_url":"https://api.github.com/repos/UAVCAN/libuavcan/issues/comments{/number}","contents_url":"https://api.github.com/repos/UAVCAN/libuavcan/contents/{+path}","compare_url":"https://api.github.com/repos/UAVCAN/libuavcan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UAVCAN/libuavcan/merges","archive_url":"https://api.github.com/repos/UAVCAN/libuavcan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UAVCAN/libuavcan/downloads","issues_url":"https://api.github.com/repos/UAVCAN/libuavcan/issues{/number}","pulls_url":"https://api.github.com/repos/UAVCAN/libuavcan/pulls{/number}","milestones_url":"https://api.github.com/repos/UAVCAN/libuavcan/milestones{/number}","notifications_url":"https://api.github.com/repos/UAVCAN/libuavcan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UAVCAN/libuavcan/labels{/name}","releases_url":"https://api.github.com/repos/UAVCAN/libuavcan/releases{/id}","deployments_url":"https://api.github.com/repos/UAVCAN/libuavcan/deployments","created_at":"2014-01-23T19:41:25Z","updated_at":"2019-02-08T19:24:06Z","pushed_at":"2019-02-05T18:20:48Z","git_url":"git://github.com/UAVCAN/libuavcan.git","ssh_url":"git@github.com:UAVCAN/libuavcan.git","clone_url":"https://github.com/UAVCAN/libuavcan.git","svn_url":"https://github.com/UAVCAN/libuavcan","homepage":"http://uavcan.org","size":2903,"stargazers_count":141,"watchers_count":141,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":366,"open_issues":31,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/206"},"html":{"href":"https://github.com/UAVCAN/libuavcan/pull/206"},"issue":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/issues/206"},"comments":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/UAVCAN/libuavcan/statuses/7ed14816f3714aa743c25bbd95ae12da007e40ef"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2480,"deletions":13,"changed_files":18}}
other: {"actor":{"display_login":"thirtytwobits"}}