payload: {"action":"created","issue":{"url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/issues/8","repository_url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian","labels_url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/issues/8/comments","events_url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/issues/8/events","html_url":"https://github.com/greizgh/bitwarden_rs-debian/pull/8","id":531137835,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3NjMyMzE4","number":8,"title":"Added support for different Debian versions","user":{"login":"tmeckel","id":14177833,"node_id":"MDQ6VXNlcjE0MTc3ODMz","avatar_url":"https://avatars2.githubusercontent.com/u/14177833?v=4","gravatar_id":"","url":"https://api.github.com/users/tmeckel","html_url":"https://github.com/tmeckel","followers_url":"https://api.github.com/users/tmeckel/followers","following_url":"https://api.github.com/users/tmeckel/following{/other_user}","gists_url":"https://api.github.com/users/tmeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeckel/subscriptions","organizations_url":"https://api.github.com/users/tmeckel/orgs","repos_url":"https://api.github.com/users/tmeckel/repos","events_url":"https://api.github.com/users/tmeckel/events{/privacy}","received_events_url":"https://api.github.com/users/tmeckel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-12-02T13:45:03Z","updated_at":"2019-12-02T20:01:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/pulls/8","html_url":"https://github.com/greizgh/bitwarden_rs-debian/pull/8","diff_url":"https://github.com/greizgh/bitwarden_rs-debian/pull/8.diff","patch_url":"https://github.com/greizgh/bitwarden_rs-debian/pull/8.patch"},"body":"When  I compiled the new 1.13 version I noticed that the bitwarden_rs binary crashes on my Debian server with the following error\r\n\r\n```\r\n/usr/local/bin/bitwarden_rs: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /usr/local/bin/bitwarden_rs)\r\n```\r\nThe issue here is that since @dani-garcia upgraded the Rust version in the Dockerfile to 1.39 the underlying Debian version of the Docker image is changed to _Buster_, whereas my server is still running with _Stretch_. Debian _Strech_ still uses GLIBC 2.14 and there's is no backport of GLIBC 2.28.\r\n\r\nTherefor I changed the build.sh file to support building bitwarden_rs for a specific target platform.\r\nTwo major changes were introduced:\r\n\r\n1. you can specifiy the release of Bitwarden_rs via the `-r` option and the Debian target by the `-o` option. If the `-o` option is not specified the current version of Debian is determined by using `lsb_release -c -s`\r\n2. Two new inplace `sed` commands adjust the `Dockerfile` for the selected Debian version. Luckily the Rust guys aligned their Docker image names to the Debian versions. So this was not a great hassle.\r\n\r\nAfter that I was able to compile Bitwarden_Rs for different Debian versions, including for _Strech_ running on my server.\r\n\r\nI changed the `README.md` file accordingly to the changes applied to `build.sh`"},"comment":{"url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/issues/comments/560557210","html_url":"https://github.com/greizgh/bitwarden_rs-debian/pull/8#issuecomment-560557210","issue_url":"https://api.github.com/repos/greizgh/bitwarden_rs-debian/issues/8","id":560557210,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MDU1NzIxMA==","user":{"login":"tmeckel","id":14177833,"node_id":"MDQ6VXNlcjE0MTc3ODMz","avatar_url":"https://avatars2.githubusercontent.com/u/14177833?v=4","gravatar_id":"","url":"https://api.github.com/users/tmeckel","html_url":"https://github.com/tmeckel","followers_url":"https://api.github.com/users/tmeckel/followers","following_url":"https://api.github.com/users/tmeckel/following{/other_user}","gists_url":"https://api.github.com/users/tmeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeckel/subscriptions","organizations_url":"https://api.github.com/users/tmeckel/orgs","repos_url":"https://api.github.com/users/tmeckel/repos","events_url":"https://api.github.com/users/tmeckel/events{/privacy}","received_events_url":"https://api.github.com/users/tmeckel/received_events","type":"User","site_admin":false},"created_at":"2019-12-02T20:01:13Z","updated_at":"2019-12-02T20:01:13Z","author_association":"NONE","body":"> I have one doubt though on the fallback on current debian version: I would prefer fall-backing on a default version (let's say buster as it's the stable release) rather than relying on the host system.\r\n> My two main reasons:\r\n> \r\n>     * I do not run Debian on my dev box (hence the use of docker to create a package);\r\n> \r\n>     * I sometimes have to run this script on mac;\r\n> \r\n> \r\n\r\n@greizgh good point! I hadn't considered that. Then let's go for using `buster` as default version, as proposed by you. This is a quick fix ...  \r\n"}}
other: {"actor":{"display_login":"tmeckel"}}