payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/comments/311663191","pull_request_review_id":272102925,"id":311663191,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTY2MzE5MQ==","diff_hunk":"@@ -10,12 +10,14 @@\n \n import numpy as np\n import yaml\n-from simtk import unit, openmm\n+from simtk import openmm, unit as simtk_unit\n from simtk.openmm import app\n \n+from propertyestimator import unit\n from propertyestimator.thermodynamics import ThermodynamicState, Ensemble\n from propertyestimator.utils.exceptions import PropertyEstimatorException\n-from propertyestimator.utils.openmm import setup_platform_with_resources\n+from propertyestimator.utils.openmm import setup_platform_with_resources, openmm_quantity_to_pint,\\","path":"propertyestimator/protocols/simulation.py","position":12,"original_position":12,"commit_id":"d30e0a8f3292ed527c18e8f47bbe188fd3e40b43","original_commit_id":"d30e0a8f3292ed527c18e8f47bbe188fd3e40b43","user":{"login":"SimonBoothroyd","id":22272126,"node_id":"MDQ6VXNlcjIyMjcyMTI2","avatar_url":"https://avatars0.githubusercontent.com/u/22272126?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonBoothroyd","html_url":"https://github.com/SimonBoothroyd","followers_url":"https://api.github.com/users/SimonBoothroyd/followers","following_url":"https://api.github.com/users/SimonBoothroyd/following{/other_user}","gists_url":"https://api.github.com/users/SimonBoothroyd/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonBoothroyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonBoothroyd/subscriptions","organizations_url":"https://api.github.com/users/SimonBoothroyd/orgs","repos_url":"https://api.github.com/users/SimonBoothroyd/repos","events_url":"https://api.github.com/users/SimonBoothroyd/events{/privacy}","received_events_url":"https://api.github.com/users/SimonBoothroyd/received_events","type":"User","site_admin":false},"body":"Agree - will keep this for now as it's consistent, and open a PR to fix this across the codebase in the future","created_at":"2019-08-07T17:04:23Z","updated_at":"2019-08-07T17:04:23Z","html_url":"https://github.com/openforcefield/propertyestimator/pull/66#discussion_r311663191","pull_request_url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/comments/311663191"},"html":{"href":"https://github.com/openforcefield/propertyestimator/pull/66#discussion_r311663191"},"pull_request":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66"}},"in_reply_to_id":311646918},"pull_request":{"url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66","id":304507486,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0NTA3NDg2","html_url":"https://github.com/openforcefield/propertyestimator/pull/66","diff_url":"https://github.com/openforcefield/propertyestimator/pull/66.diff","patch_url":"https://github.com/openforcefield/propertyestimator/pull/66.patch","issue_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues/66","number":66,"state":"open","locked":false,"title":"Switch to Pint Units","user":{"login":"SimonBoothroyd","id":22272126,"node_id":"MDQ6VXNlcjIyMjcyMTI2","avatar_url":"https://avatars0.githubusercontent.com/u/22272126?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonBoothroyd","html_url":"https://github.com/SimonBoothroyd","followers_url":"https://api.github.com/users/SimonBoothroyd/followers","following_url":"https://api.github.com/users/SimonBoothroyd/following{/other_user}","gists_url":"https://api.github.com/users/SimonBoothroyd/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonBoothroyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonBoothroyd/subscriptions","organizations_url":"https://api.github.com/users/SimonBoothroyd/orgs","repos_url":"https://api.github.com/users/SimonBoothroyd/repos","events_url":"https://api.github.com/users/SimonBoothroyd/events{/privacy}","received_events_url":"https://api.github.com/users/SimonBoothroyd/received_events","type":"User","site_admin":false},"body":"## Description\r\nThe aim of this PR is to switch over to using `pint` units. The goal is to remove a number of awkward behaviors, including\r\n\r\n  - a `dimensionless` quantity losing its unit after scalar multiplication.\r\n  - handle cases such as `(x * simtk.unit.joule) / (y * simtk.unit.calorie)` being dimensionless.\r\n\r\n## Todos\r\nNotable points that this PR has either accomplished or will accomplish.\r\n  - [x] Add conversions between `simtk.unit.X` <-> `pint.X`\r\n  - [x] Add lots of tests for the conversions.\r\n  - [x] Replace most instances of simtk.unit\r\n  - [x] Run regression tests.\r\n\r\n## Status\r\n- [x] Ready to go","created_at":"2019-08-06T00:52:09Z","updated_at":"2019-08-07T17:04:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3979a14571f09159618323b94e42a78c885d8e9f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrrizzi","id":1682142,"node_id":"MDQ6VXNlcjE2ODIxNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1682142?v=4","gravatar_id":"","url":"https://api.github.com/users/andrrizzi","html_url":"https://github.com/andrrizzi","followers_url":"https://api.github.com/users/andrrizzi/followers","following_url":"https://api.github.com/users/andrrizzi/following{/other_user}","gists_url":"https://api.github.com/users/andrrizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/andrrizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrrizzi/subscriptions","organizations_url":"https://api.github.com/users/andrrizzi/orgs","repos_url":"https://api.github.com/users/andrrizzi/repos","events_url":"https://api.github.com/users/andrrizzi/events{/privacy}","received_events_url":"https://api.github.com/users/andrrizzi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66/commits","review_comments_url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66/comments","review_comment_url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues/66/comments","statuses_url":"https://api.github.com/repos/openforcefield/propertyestimator/statuses/d30e0a8f3292ed527c18e8f47bbe188fd3e40b43","head":{"label":"openforcefield:pint_units","ref":"pint_units","sha":"d30e0a8f3292ed527c18e8f47bbe188fd3e40b43","user":{"login":"openforcefield","id":18539698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTM5Njk4","avatar_url":"https://avatars3.githubusercontent.com/u/18539698?v=4","gravatar_id":"","url":"https://api.github.com/users/openforcefield","html_url":"https://github.com/openforcefield","followers_url":"https://api.github.com/users/openforcefield/followers","following_url":"https://api.github.com/users/openforcefield/following{/other_user}","gists_url":"https://api.github.com/users/openforcefield/gists{/gist_id}","starred_url":"https://api.github.com/users/openforcefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openforcefield/subscriptions","organizations_url":"https://api.github.com/users/openforcefield/orgs","repos_url":"https://api.github.com/users/openforcefield/repos","events_url":"https://api.github.com/users/openforcefield/events{/privacy}","received_events_url":"https://api.github.com/users/openforcefield/received_events","type":"Organization","site_admin":false},"repo":{"id":168579807,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg1Nzk4MDc=","name":"propertyestimator","full_name":"openforcefield/propertyestimator","private":false,"owner":{"login":"openforcefield","id":18539698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTM5Njk4","avatar_url":"https://avatars3.githubusercontent.com/u/18539698?v=4","gravatar_id":"","url":"https://api.github.com/users/openforcefield","html_url":"https://github.com/openforcefield","followers_url":"https://api.github.com/users/openforcefield/followers","following_url":"https://api.github.com/users/openforcefield/following{/other_user}","gists_url":"https://api.github.com/users/openforcefield/gists{/gist_id}","starred_url":"https://api.github.com/users/openforcefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openforcefield/subscriptions","organizations_url":"https://api.github.com/users/openforcefield/orgs","repos_url":"https://api.github.com/users/openforcefield/repos","events_url":"https://api.github.com/users/openforcefield/events{/privacy}","received_events_url":"https://api.github.com/users/openforcefield/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openforcefield/propertyestimator","description":"Property estimation toolkit from the Open Forcefield Consortium.","fork":false,"url":"https://api.github.com/repos/openforcefield/propertyestimator","forks_url":"https://api.github.com/repos/openforcefield/propertyestimator/forks","keys_url":"https://api.github.com/repos/openforcefield/propertyestimator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openforcefield/propertyestimator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openforcefield/propertyestimator/teams","hooks_url":"https://api.github.com/repos/openforcefield/propertyestimator/hooks","issue_events_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues/events{/number}","events_url":"https://api.github.com/repos/openforcefield/propertyestimator/events","assignees_url":"https://api.github.com/repos/openforcefield/propertyestimator/assignees{/user}","branches_url":"https://api.github.com/repos/openforcefield/propertyestimator/branches{/branch}","tags_url":"https://api.github.com/repos/openforcefield/propertyestimator/tags","blobs_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openforcefield/propertyestimator/statuses/{sha}","languages_url":"https://api.github.com/repos/openforcefield/propertyestimator/languages","stargazers_url":"https://api.github.com/repos/openforcefield/propertyestimator/stargazers","contributors_url":"https://api.github.com/repos/openforcefield/propertyestimator/contributors","subscribers_url":"https://api.github.com/repos/openforcefield/propertyestimator/subscribers","subscription_url":"https://api.github.com/repos/openforcefield/propertyestimator/subscription","commits_url":"https://api.github.com/repos/openforcefield/propertyestimator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openforcefield/propertyestimator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openforcefield/propertyestimator/contents/{+path}","compare_url":"https://api.github.com/repos/openforcefield/propertyestimator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openforcefield/propertyestimator/merges","archive_url":"https://api.github.com/repos/openforcefield/propertyestimator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openforcefield/propertyestimator/downloads","issues_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues{/number}","pulls_url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls{/number}","milestones_url":"https://api.github.com/repos/openforcefield/propertyestimator/milestones{/number}","notifications_url":"https://api.github.com/repos/openforcefield/propertyestimator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openforcefield/propertyestimator/labels{/name}","releases_url":"https://api.github.com/repos/openforcefield/propertyestimator/releases{/id}","deployments_url":"https://api.github.com/repos/openforcefield/propertyestimator/deployments","created_at":"2019-01-31T19:02:46Z","updated_at":"2019-08-06T23:11:39Z","pushed_at":"2019-08-07T16:14:43Z","git_url":"git://github.com/openforcefield/propertyestimator.git","ssh_url":"git@github.com:openforcefield/propertyestimator.git","clone_url":"https://github.com/openforcefield/propertyestimator.git","svn_url":"https://github.com/openforcefield/propertyestimator","homepage":"http://openforcefield.org","size":1085,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":5,"watchers":11,"default_branch":"master"}},"base":{"label":"openforcefield:master","ref":"master","sha":"fca218e9299e8a2ef30e6661e5900926ea3deb7e","user":{"login":"openforcefield","id":18539698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTM5Njk4","avatar_url":"https://avatars3.githubusercontent.com/u/18539698?v=4","gravatar_id":"","url":"https://api.github.com/users/openforcefield","html_url":"https://github.com/openforcefield","followers_url":"https://api.github.com/users/openforcefield/followers","following_url":"https://api.github.com/users/openforcefield/following{/other_user}","gists_url":"https://api.github.com/users/openforcefield/gists{/gist_id}","starred_url":"https://api.github.com/users/openforcefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openforcefield/subscriptions","organizations_url":"https://api.github.com/users/openforcefield/orgs","repos_url":"https://api.github.com/users/openforcefield/repos","events_url":"https://api.github.com/users/openforcefield/events{/privacy}","received_events_url":"https://api.github.com/users/openforcefield/received_events","type":"Organization","site_admin":false},"repo":{"id":168579807,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg1Nzk4MDc=","name":"propertyestimator","full_name":"openforcefield/propertyestimator","private":false,"owner":{"login":"openforcefield","id":18539698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTM5Njk4","avatar_url":"https://avatars3.githubusercontent.com/u/18539698?v=4","gravatar_id":"","url":"https://api.github.com/users/openforcefield","html_url":"https://github.com/openforcefield","followers_url":"https://api.github.com/users/openforcefield/followers","following_url":"https://api.github.com/users/openforcefield/following{/other_user}","gists_url":"https://api.github.com/users/openforcefield/gists{/gist_id}","starred_url":"https://api.github.com/users/openforcefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openforcefield/subscriptions","organizations_url":"https://api.github.com/users/openforcefield/orgs","repos_url":"https://api.github.com/users/openforcefield/repos","events_url":"https://api.github.com/users/openforcefield/events{/privacy}","received_events_url":"https://api.github.com/users/openforcefield/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openforcefield/propertyestimator","description":"Property estimation toolkit from the Open Forcefield Consortium.","fork":false,"url":"https://api.github.com/repos/openforcefield/propertyestimator","forks_url":"https://api.github.com/repos/openforcefield/propertyestimator/forks","keys_url":"https://api.github.com/repos/openforcefield/propertyestimator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openforcefield/propertyestimator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openforcefield/propertyestimator/teams","hooks_url":"https://api.github.com/repos/openforcefield/propertyestimator/hooks","issue_events_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues/events{/number}","events_url":"https://api.github.com/repos/openforcefield/propertyestimator/events","assignees_url":"https://api.github.com/repos/openforcefield/propertyestimator/assignees{/user}","branches_url":"https://api.github.com/repos/openforcefield/propertyestimator/branches{/branch}","tags_url":"https://api.github.com/repos/openforcefield/propertyestimator/tags","blobs_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openforcefield/propertyestimator/statuses/{sha}","languages_url":"https://api.github.com/repos/openforcefield/propertyestimator/languages","stargazers_url":"https://api.github.com/repos/openforcefield/propertyestimator/stargazers","contributors_url":"https://api.github.com/repos/openforcefield/propertyestimator/contributors","subscribers_url":"https://api.github.com/repos/openforcefield/propertyestimator/subscribers","subscription_url":"https://api.github.com/repos/openforcefield/propertyestimator/subscription","commits_url":"https://api.github.com/repos/openforcefield/propertyestimator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openforcefield/propertyestimator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openforcefield/propertyestimator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openforcefield/propertyestimator/contents/{+path}","compare_url":"https://api.github.com/repos/openforcefield/propertyestimator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openforcefield/propertyestimator/merges","archive_url":"https://api.github.com/repos/openforcefield/propertyestimator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openforcefield/propertyestimator/downloads","issues_url":"https://api.github.com/repos/openforcefield/propertyestimator/issues{/number}","pulls_url":"https://api.github.com/repos/openforcefield/propertyestimator/pulls{/number}","milestones_url":"https://api.github.com/repos/openforcefield/propertyestimator/milestones{/number}","notifications_url":"https://api.github.com/repos/openforcefield/propertyestimator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openforcefield/propertyestimator/labels{/name}","releases_url":"https://api.github.com/repos/openforcefield/propertyestimator/releases{/id}","deployments_url":"https://api.github.com/repos/openforcefield/propertyestimator/deployments","created_at":"2019-01-31T19:02:46Z","updated_at":"2019-08-06T23:11:39Z","pushed_at":"2019-08-07T16:14:43Z","git_url":"git://github.com/openforcefield/propertyestimator.git","ssh_url":"git@github.com:openforcefield/propertyestimator.git","clone_url":"https://github.com/openforcefield/propertyestimator.git","svn_url":"https://github.com/openforcefield/propertyestimator","homepage":"http://openforcefield.org","size":1085,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66"},"html":{"href":"https://github.com/openforcefield/propertyestimator/pull/66"},"issue":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/issues/66"},"comments":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/openforcefield/propertyestimator/statuses/d30e0a8f3292ed527c18e8f47bbe188fd3e40b43"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"SimonBoothroyd"}}