payload: {"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/22043","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/22043/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/22043/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/22043/events","html_url":"https://github.com/magento/magento2/issues/22043","id":427064871,"node_id":"MDU6SXNzdWU0MjcwNjQ4NzE=","number":22043,"title":"Payment methods source model is broken again","user":{"login":"mam08ixo","id":1771622,"node_id":"MDQ6VXNlcjE3NzE2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1771622?v=4","gravatar_id":"","url":"https://api.github.com/users/mam08ixo","html_url":"https://github.com/mam08ixo","followers_url":"https://api.github.com/users/mam08ixo/followers","following_url":"https://api.github.com/users/mam08ixo/following{/other_user}","gists_url":"https://api.github.com/users/mam08ixo/gists{/gist_id}","starred_url":"https://api.github.com/users/mam08ixo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mam08ixo/subscriptions","organizations_url":"https://api.github.com/users/mam08ixo/orgs","repos_url":"https://api.github.com/users/mam08ixo/repos","events_url":"https://api.github.com/users/mam08ixo/events{/privacy}","received_events_url":"https://api.github.com/users/mam08ixo/received_events","type":"User","site_admin":false},"labels":[{"id":374017037,"node_id":"MDU6TGFiZWwzNzQwMTcwMzc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Payment","name":"Component: Payment","color":"7fb703","default":false},{"id":686420665,"node_id":"MDU6TGFiZWw2ODY0MjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Clear%20Description","name":"Issue: Clear Description","color":"0e8a16","default":false},{"id":686476746,"node_id":"MDU6TGFiZWw2ODY0NzY3NDY=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Confirmed","name":"Issue: Confirmed","color":"0e8a16","default":false},{"id":688811200,"node_id":"MDU6TGFiZWw2ODg4MTEyMDA=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Format%20is%20valid","name":"Issue: Format is valid","color":"0e8a16","default":false},{"id":21716835,"node_id":"MDU6TGFiZWwyMTcxNjgzNQ==","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Ready%20for%20Work","name":"Issue: Ready for Work","color":"0e8a16","default":false},{"id":686477126,"node_id":"MDU6TGFiZWw2ODY0NzcxMjY=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.2.x","name":"Reproduced on 2.2.x","color":"e99695","default":false},{"id":686477167,"node_id":"MDU6TGFiZWw2ODY0NzcxNjc=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.3.x","name":"Reproduced on 2.3.x","color":"7d6ed1","default":false},{"id":718639553,"node_id":"MDU6TGFiZWw3MTg2Mzk1NTM=","url":"https://api.github.com/repos/magento/magento2/labels/good%20first%20issue","name":"good first issue","color":"ba56d8","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-03-29T16:11:49Z","updated_at":"2019-08-20T06:56:41Z","closed_at":null,"author_association":"NONE","body":"### Preconditions\r\n1. Magento 2.3.1\r\n\r\n### Steps to reproduce\r\n1. Go to _Marketing → Cart Price Rules_.\r\n2. Edit/Open a rule.\r\n3. Under _Conditions_, add the _Cart Attribute_ condition _Payment Method_.\r\n4. Wait for the possible options to load.\r\n\r\n### Expected result\r\n1. I see a list of either all or at least the activated payment methods.\r\n\r\n### Actual result\r\n1. I see a list with only the payment methods active per *config defaults* (i.e. `checkmo`, `free` and `paypal_billing_agreement`, plus some payment group names).\r\n\r\n![payment_method_cart_attribute_options](https://user-images.githubusercontent.com/1771622/55245359-4119b100-5243-11e9-973e-085febfc9616.png)\r\n\r\n### Additional Information\r\nThe bug was introduced in 28c86be by testing the `active` flag of payment methods in [`\\Magento\\Payment\\Helper\\Data::getPaymentMethodList`](https://github.com/magento/magento2/blame/2.3.1/app/code/Magento/Payment/Helper/Data.php#L264) (where `\\Magento\\Payment\\Model\\Config\\Source\\Allmethods::toOptionArray` forwards to).\r\n\r\nhttps://github.com/magento/magento2/blob/28c86bed310311247604caa6c5c3b6c165fbd4f3/app/code/Magento/Payment/Helper/Data.php#L264-L271\r\n\r\nBecause the source of the data is the default payment method configuration of a plain vanilla installation, no config setting changes (=activating additional methods) are taken into account.\r\n\r\nThis issue does not only affect the cart price rules. Every extension developer building upon this source model is affected:\r\n\r\n#### Source model in Magento 2.3.1\r\n![payment_methods_231](https://user-images.githubusercontent.com/1771622/55246441-80e19800-5245-11e9-8413-1f74939c19d8.png)\r\n\r\n#### Source model in Magento 2.3.0\r\n![payment_methods_230](https://user-images.githubusercontent.com/1771622/55246453-850db580-5245-11e9-881f-879cb11c66a7.png)"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/522881390","html_url":"https://github.com/magento/magento2/issues/22043#issuecomment-522881390","issue_url":"https://api.github.com/repos/magento/magento2/issues/22043","id":522881390,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMjg4MTM5MA==","user":{"login":"ihor-sviziev","id":1873745,"node_id":"MDQ6VXNlcjE4NzM3NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"created_at":"2019-08-20T06:56:41Z","updated_at":"2019-08-20T06:56:41Z","author_association":"CONTRIBUTOR","body":"Hi,\r\n\r\nLooks like this issue was fixed in `2.3-develop` branch using following commits:\r\n- https://github.com/magento/magento2/commit/da0c7374e5dcae81735552bdd685ee5e646b8486\r\n- https://github.com/magento/magento2/commit/4344cc9bc34fbda80dc798ebafcf80c516788442\r\n\r\n@engcom-backlog-nazar could you re-check if this issue is reproducing?\r\n\r\nThank you!"}}
other: {"actor":{"display_login":"ihor-sviziev"}}