payload: {"action":"created","issue":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/2094","repository_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons","labels_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/2094/labels{/name}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/2094/comments","events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/2094/events","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2094","id":518488400,"node_id":"MDU6SXNzdWU1MTg0ODg0MDA=","number":2094,"title":"Remove c.a.a.c.remoteAssets.RemoteAssetsConfig from public API","user":{"login":"joerghoh","id":337870,"node_id":"MDQ6VXNlcjMzNzg3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/337870?v=4","gravatar_id":"","url":"https://api.github.com/users/joerghoh","html_url":"https://github.com/joerghoh","followers_url":"https://api.github.com/users/joerghoh/followers","following_url":"https://api.github.com/users/joerghoh/following{/other_user}","gists_url":"https://api.github.com/users/joerghoh/gists{/gist_id}","starred_url":"https://api.github.com/users/joerghoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerghoh/subscriptions","organizations_url":"https://api.github.com/users/joerghoh/orgs","repos_url":"https://api.github.com/users/joerghoh/repos","events_url":"https://api.github.com/users/joerghoh/events{/privacy}","received_events_url":"https://api.github.com/users/joerghoh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-11-06T13:56:24Z","updated_at":"2019-11-07T07:52:31Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently the interface RemoteAssetsConfig is publicly exposed, although \r\n\r\n1) it should not be exposed because it's an interface only implemented by the non-exported RemoteAssetsConfigImpl, and details about the OSGI config are not required to be exposed here.\r\n2) It cannot be used from externally (implementing it does not make sense)\r\n\r\nThus we should remove it from the exports for the ACS AEM Commons bundle.\r\n\r\n(Then its use is getting questionable, because it is only used within the remoteAssets feature. Instead of referencing the RemoteAssetsConfig class, other class could reference directly the RemoteAssetsConfigImpl class, and the internal interface would not be necessarry.)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/comments/550965073","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2094#issuecomment-550965073","issue_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/2094","id":550965073,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MDk2NTA3Mw==","user":{"login":"joerghoh","id":337870,"node_id":"MDQ6VXNlcjMzNzg3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/337870?v=4","gravatar_id":"","url":"https://api.github.com/users/joerghoh","html_url":"https://github.com/joerghoh","followers_url":"https://api.github.com/users/joerghoh/followers","following_url":"https://api.github.com/users/joerghoh/following{/other_user}","gists_url":"https://api.github.com/users/joerghoh/gists{/gist_id}","starred_url":"https://api.github.com/users/joerghoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerghoh/subscriptions","organizations_url":"https://api.github.com/users/joerghoh/orgs","repos_url":"https://api.github.com/users/joerghoh/repos","events_url":"https://api.github.com/users/joerghoh/events{/privacy}","received_events_url":"https://api.github.com/users/joerghoh/received_events","type":"User","site_admin":false},"created_at":"2019-11-07T07:52:31Z","updated_at":"2019-11-07T07:52:31Z","author_association":"CONTRIBUTOR","body":"@HitmanInWis The rule of thumb is: \"You open it, you close it\". If you open a ResourceResolver, you just close the ResourceResolver. The fact, that internally a JCR Sesesion might be opened, is an implementation detail, and the implementation takes care of closing the session when the ResourceResolver is closed.\r\n\r\nThis behavior is consistent. If you use an already existing session to create a new wrapping ResourceResolver (see [1] for an example how to do that), then you must close both. You opened both the session and the resourceresolver explicitly.\r\n\r\n[1] https://github.com/Adobe-Consulting-Services/acs-aem-samples/blob/master/bundle/src/main/java/com/adobe/acs/samples/workflow/impl/SampleWrappingWorkflowProcess.java#L161"}}
other: {"actor":{"display_login":"joerghoh"}}