payload: {"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/msbuild/pulls/comments/342785383","pull_request_review_id":312026169,"id":342785383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0Mjc4NTM4Mw==","diff_hunk":"@@ -655,7 +655,9 @@ internal static void Trace(int nodeId, string format, params object[] args)\n         /// <returns>Base Handshake</returns>\n         private static long GetBaseHandshakeForContext(TaskHostContext hostContext)\n         {\n-            string salt = Environment.GetEnvironmentVariable(\"MSBUILDNODEHANDSHAKESALT\");\n+            string salt = Environment.GetEnvironmentVariable(\"MSBUILDNODEHANDSHAKESALT\") +\n+                Environment.GetEnvironmentVariable(\"DOTNET_HOST_PATH\") +\n+                Environment.GetEnvironmentVariable(\"DOTNET_ROOT\");","path":"src/Shared/CommunicationsUtilities.cs","position":7,"original_position":7,"commit_id":"534ec56d4980960d0c6dd23a0e6655a8f2a5131b","original_commit_id":"534ec56d4980960d0c6dd23a0e6655a8f2a5131b","user":{"login":"rainersigwald","id":3347530,"node_id":"MDQ6VXNlcjMzNDc1MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3347530?v=4","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"body":"We shouldn't require user intervention to set these. I believe `dotnet build` and `dotnet msbuild` both set them for the child MSBuild process. Can you confirm that? If they both do, using the env var is probably enough.\r\n\r\n@dsplaisted do you have an opinion on this?","created_at":"2019-11-05T20:38:02Z","updated_at":"2019-11-05T20:38:03Z","html_url":"https://github.com/microsoft/msbuild/pull/4888#discussion_r342785383","pull_request_url":"https://api.github.com/repos/microsoft/msbuild/pulls/4888","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/msbuild/pulls/comments/342785383"},"html":{"href":"https://github.com/microsoft/msbuild/pull/4888#discussion_r342785383"},"pull_request":{"href":"https://api.github.com/repos/microsoft/msbuild/pulls/4888"}},"in_reply_to_id":342760684},"pull_request":{"url":"https://api.github.com/repos/microsoft/msbuild/pulls/4888","id":336950775,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2OTUwNzc1","html_url":"https://github.com/microsoft/msbuild/pull/4888","diff_url":"https://github.com/microsoft/msbuild/pull/4888.diff","patch_url":"https://github.com/microsoft/msbuild/pull/4888.patch","issue_url":"https://api.github.com/repos/microsoft/msbuild/issues/4888","number":4888,"state":"open","locked":false,"title":"Change the salt","user":{"login":"Forgind","id":12969783,"node_id":"MDQ6VXNlcjEyOTY5Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/12969783?v=4","gravatar_id":"","url":"https://api.github.com/users/Forgind","html_url":"https://github.com/Forgind","followers_url":"https://api.github.com/users/Forgind/followers","following_url":"https://api.github.com/users/Forgind/following{/other_user}","gists_url":"https://api.github.com/users/Forgind/gists{/gist_id}","starred_url":"https://api.github.com/users/Forgind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Forgind/subscriptions","organizations_url":"https://api.github.com/users/Forgind/orgs","repos_url":"https://api.github.com/users/Forgind/repos","events_url":"https://api.github.com/users/Forgind/events{/privacy}","received_events_url":"https://api.github.com/users/Forgind/received_events","type":"User","site_admin":false},"body":"Prevent unwanted node reuse.\r\n\r\nFixes #3137.","created_at":"2019-11-05T19:36:58Z","updated_at":"2019-11-05T20:38:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4372b36749fa74b9603273eebcbf7d760ad6b977","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BenVillalobos","id":4691428,"node_id":"MDQ6VXNlcjQ2OTE0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4691428?v=4","gravatar_id":"","url":"https://api.github.com/users/BenVillalobos","html_url":"https://github.com/BenVillalobos","followers_url":"https://api.github.com/users/BenVillalobos/followers","following_url":"https://api.github.com/users/BenVillalobos/following{/other_user}","gists_url":"https://api.github.com/users/BenVillalobos/gists{/gist_id}","starred_url":"https://api.github.com/users/BenVillalobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenVillalobos/subscriptions","organizations_url":"https://api.github.com/users/BenVillalobos/orgs","repos_url":"https://api.github.com/users/BenVillalobos/repos","events_url":"https://api.github.com/users/BenVillalobos/events{/privacy}","received_events_url":"https://api.github.com/users/BenVillalobos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/msbuild/pulls/4888/commits","review_comments_url":"https://api.github.com/repos/microsoft/msbuild/pulls/4888/comments","review_comment_url":"https://api.github.com/repos/microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/msbuild/issues/4888/comments","statuses_url":"https://api.github.com/repos/microsoft/msbuild/statuses/534ec56d4980960d0c6dd23a0e6655a8f2a5131b","head":{"label":"Forgind:complex-node-handshake","ref":"complex-node-handshake","sha":"534ec56d4980960d0c6dd23a0e6655a8f2a5131b","user":{"login":"Forgind","id":12969783,"node_id":"MDQ6VXNlcjEyOTY5Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/12969783?v=4","gravatar_id":"","url":"https://api.github.com/users/Forgind","html_url":"https://github.com/Forgind","followers_url":"https://api.github.com/users/Forgind/followers","following_url":"https://api.github.com/users/Forgind/following{/other_user}","gists_url":"https://api.github.com/users/Forgind/gists{/gist_id}","starred_url":"https://api.github.com/users/Forgind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Forgind/subscriptions","organizations_url":"https://api.github.com/users/Forgind/orgs","repos_url":"https://api.github.com/users/Forgind/repos","events_url":"https://api.github.com/users/Forgind/events{/privacy}","received_events_url":"https://api.github.com/users/Forgind/received_events","type":"User","site_admin":false},"repo":{"id":205042606,"node_id":"MDEwOlJlcG9zaXRvcnkyMDUwNDI2MDY=","name":"msbuild","full_name":"Forgind/msbuild","private":false,"owner":{"login":"Forgind","id":12969783,"node_id":"MDQ6VXNlcjEyOTY5Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/12969783?v=4","gravatar_id":"","url":"https://api.github.com/users/Forgind","html_url":"https://github.com/Forgind","followers_url":"https://api.github.com/users/Forgind/followers","following_url":"https://api.github.com/users/Forgind/following{/other_user}","gists_url":"https://api.github.com/users/Forgind/gists{/gist_id}","starred_url":"https://api.github.com/users/Forgind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Forgind/subscriptions","organizations_url":"https://api.github.com/users/Forgind/orgs","repos_url":"https://api.github.com/users/Forgind/repos","events_url":"https://api.github.com/users/Forgind/events{/privacy}","received_events_url":"https://api.github.com/users/Forgind/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Forgind/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/Forgind/msbuild","forks_url":"https://api.github.com/repos/Forgind/msbuild/forks","keys_url":"https://api.github.com/repos/Forgind/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Forgind/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Forgind/msbuild/teams","hooks_url":"https://api.github.com/repos/Forgind/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Forgind/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Forgind/msbuild/events","assignees_url":"https://api.github.com/repos/Forgind/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Forgind/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Forgind/msbuild/tags","blobs_url":"https://api.github.com/repos/Forgind/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Forgind/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Forgind/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Forgind/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Forgind/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Forgind/msbuild/languages","stargazers_url":"https://api.github.com/repos/Forgind/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Forgind/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Forgind/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Forgind/msbuild/subscription","commits_url":"https://api.github.com/repos/Forgind/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Forgind/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Forgind/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Forgind/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Forgind/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Forgind/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Forgind/msbuild/merges","archive_url":"https://api.github.com/repos/Forgind/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Forgind/msbuild/downloads","issues_url":"https://api.github.com/repos/Forgind/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Forgind/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Forgind/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Forgind/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Forgind/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Forgind/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Forgind/msbuild/deployments","created_at":"2019-08-28T23:44:38Z","updated_at":"2019-10-28T18:01:56Z","pushed_at":"2019-11-05T19:35:57Z","git_url":"git://github.com/Forgind/msbuild.git","ssh_url":"git@github.com:Forgind/msbuild.git","clone_url":"https://github.com/Forgind/msbuild.git","svn_url":"https://github.com/Forgind/msbuild","homepage":null,"size":45701,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"d6c92f91b6453c4f409ee9b345b780775a545d62","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"node_id":"MDEwOlJlcG9zaXRvcnkzMjA1MTg5MA==","name":"msbuild","full_name":"microsoft/msbuild","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/microsoft/msbuild","forks_url":"https://api.github.com/repos/microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2019-11-05T05:58:50Z","pushed_at":"2019-11-05T19:36:59Z","git_url":"git://github.com/microsoft/msbuild.git","ssh_url":"git@github.com:microsoft/msbuild.git","clone_url":"https://github.com/microsoft/msbuild.git","svn_url":"https://github.com/microsoft/msbuild","homepage":null,"size":46583,"stargazers_count":4057,"watchers_count":4057,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":970,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1025,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":970,"open_issues":1025,"watchers":4057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/msbuild/pulls/4888"},"html":{"href":"https://github.com/microsoft/msbuild/pull/4888"},"issue":{"href":"https://api.github.com/repos/microsoft/msbuild/issues/4888"},"comments":{"href":"https://api.github.com/repos/microsoft/msbuild/issues/4888/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/msbuild/pulls/4888/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/msbuild/pulls/4888/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/msbuild/statuses/534ec56d4980960d0c6dd23a0e6655a8f2a5131b"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"rainersigwald"}}