payload: {"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/gentoo/genkernel/pulls/8","id":242414270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDE0Mjcw","html_url":"https://github.com/gentoo/genkernel/pull/8","diff_url":"https://github.com/gentoo/genkernel/pull/8.diff","patch_url":"https://github.com/gentoo/genkernel/pull/8.patch","issue_url":"https://api.github.com/repos/gentoo/genkernel/issues/8","number":8,"state":"closed","locked":false,"title":"Fix and improve remote LUKS decryption","user":{"login":"sbraz","id":4833332,"node_id":"MDQ6VXNlcjQ4MzMzMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4833332?v=4","gravatar_id":"","url":"https://api.github.com/users/sbraz","html_url":"https://github.com/sbraz","followers_url":"https://api.github.com/users/sbraz/followers","following_url":"https://api.github.com/users/sbraz/following{/other_user}","gists_url":"https://api.github.com/users/sbraz/gists{/gist_id}","starred_url":"https://api.github.com/users/sbraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbraz/subscriptions","organizations_url":"https://api.github.com/users/sbraz/orgs","repos_url":"https://api.github.com/users/sbraz/repos","events_url":"https://api.github.com/users/sbraz/events{/privacy}","received_events_url":"https://api.github.com/users/sbraz/received_events","type":"User","site_admin":false},"body":"Hello,\r\nCurrently, the SSH parameter more or less works and allows genkernel to run dropbear at boot.\r\nIt was introduced in https://github.com/gentoo/genkernel/commit/11a3470508a6475a5fee00f26ccbd7a98b4f9e01 (initially submitted [here](https://bugs.gentoo.org/440126#c2)).\r\n\r\nHowever, using it means following a rather complex procedure which is not documented anywhere:\r\n* first, you need to SSH into the server, sending it the `post root` or `post swap` command and writing the passphrase to stdin, this means that it may be printed on the terminal\r\n * then you need to SSH a second time without calling any command, the device will then be decrypted by the login script\r\n\r\nThe problem is that even once the device has been decrypted, the boot process is still hanging because cryptsetup from init is running! I guess that the timeout which is present here:\r\nhttps://github.com/gentoo/genkernel/blob/febc1b12b5b393e918da94b9f1c029f2adcea215/defaults/initrd.scripts#L865\r\nwas added to avoid this but it serves no purpose as cryptsetup itself never times out.\r\nOnce the device has been opened, it's not even possible to open a shell via SSH as the login-remote.sh script returns immediately, which means that we are now locked out…\r\n\r\n\r\n\r\nI've become quite frustrated with the current state of things so I attempted to fix the blocking problem by killing all cryptsetup processes (I hope this is a clean enough solution) and adding an option to simply pass the key to cryptsetup's stdin when SSH'ing into the server.  This is what [dracut-crypt-ssh](https://github.com/dracut-crypt-ssh/dracut-crypt-ssh) does and what most users want to do anyway.\r\n\r\nI've split the changes into many commits, some of which are cosmetic fixes. I haven't touched the documentation, which could be a good thing since `Add SSH support` is not very verbose.","created_at":"2019-01-05T02:21:31Z","updated_at":"2019-03-01T06:01:16Z","closed_at":"2019-03-01T06:01:16Z","merged_at":null,"merge_commit_sha":"bae567b01ab95d892ddc1cf6378fc42591a28159","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/genkernel/pulls/8/commits","review_comments_url":"https://api.github.com/repos/gentoo/genkernel/pulls/8/comments","review_comment_url":"https://api.github.com/repos/gentoo/genkernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/genkernel/issues/8/comments","statuses_url":"https://api.github.com/repos/gentoo/genkernel/statuses/c466e59ca66671e96ce57f0a877ab3638f941b45","head":{"label":"sbraz:loginremote","ref":"loginremote","sha":"c466e59ca66671e96ce57f0a877ab3638f941b45","user":{"login":"sbraz","id":4833332,"node_id":"MDQ6VXNlcjQ4MzMzMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4833332?v=4","gravatar_id":"","url":"https://api.github.com/users/sbraz","html_url":"https://github.com/sbraz","followers_url":"https://api.github.com/users/sbraz/followers","following_url":"https://api.github.com/users/sbraz/following{/other_user}","gists_url":"https://api.github.com/users/sbraz/gists{/gist_id}","starred_url":"https://api.github.com/users/sbraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbraz/subscriptions","organizations_url":"https://api.github.com/users/sbraz/orgs","repos_url":"https://api.github.com/users/sbraz/repos","events_url":"https://api.github.com/users/sbraz/events{/privacy}","received_events_url":"https://api.github.com/users/sbraz/received_events","type":"User","site_admin":false},"repo":{"id":160815001,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4MTUwMDE=","name":"genkernel","full_name":"sbraz/genkernel","private":false,"owner":{"login":"sbraz","id":4833332,"node_id":"MDQ6VXNlcjQ4MzMzMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4833332?v=4","gravatar_id":"","url":"https://api.github.com/users/sbraz","html_url":"https://github.com/sbraz","followers_url":"https://api.github.com/users/sbraz/followers","following_url":"https://api.github.com/users/sbraz/following{/other_user}","gists_url":"https://api.github.com/users/sbraz/gists{/gist_id}","starred_url":"https://api.github.com/users/sbraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbraz/subscriptions","organizations_url":"https://api.github.com/users/sbraz/orgs","repos_url":"https://api.github.com/users/sbraz/repos","events_url":"https://api.github.com/users/sbraz/events{/privacy}","received_events_url":"https://api.github.com/users/sbraz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sbraz/genkernel","description":"Working copy of genkernel tree to receive pull requests","fork":true,"url":"https://api.github.com/repos/sbraz/genkernel","forks_url":"https://api.github.com/repos/sbraz/genkernel/forks","keys_url":"https://api.github.com/repos/sbraz/genkernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbraz/genkernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbraz/genkernel/teams","hooks_url":"https://api.github.com/repos/sbraz/genkernel/hooks","issue_events_url":"https://api.github.com/repos/sbraz/genkernel/issues/events{/number}","events_url":"https://api.github.com/repos/sbraz/genkernel/events","assignees_url":"https://api.github.com/repos/sbraz/genkernel/assignees{/user}","branches_url":"https://api.github.com/repos/sbraz/genkernel/branches{/branch}","tags_url":"https://api.github.com/repos/sbraz/genkernel/tags","blobs_url":"https://api.github.com/repos/sbraz/genkernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbraz/genkernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbraz/genkernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbraz/genkernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbraz/genkernel/statuses/{sha}","languages_url":"https://api.github.com/repos/sbraz/genkernel/languages","stargazers_url":"https://api.github.com/repos/sbraz/genkernel/stargazers","contributors_url":"https://api.github.com/repos/sbraz/genkernel/contributors","subscribers_url":"https://api.github.com/repos/sbraz/genkernel/subscribers","subscription_url":"https://api.github.com/repos/sbraz/genkernel/subscription","commits_url":"https://api.github.com/repos/sbraz/genkernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbraz/genkernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbraz/genkernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbraz/genkernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbraz/genkernel/contents/{+path}","compare_url":"https://api.github.com/repos/sbraz/genkernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbraz/genkernel/merges","archive_url":"https://api.github.com/repos/sbraz/genkernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbraz/genkernel/downloads","issues_url":"https://api.github.com/repos/sbraz/genkernel/issues{/number}","pulls_url":"https://api.github.com/repos/sbraz/genkernel/pulls{/number}","milestones_url":"https://api.github.com/repos/sbraz/genkernel/milestones{/number}","notifications_url":"https://api.github.com/repos/sbraz/genkernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbraz/genkernel/labels{/name}","releases_url":"https://api.github.com/repos/sbraz/genkernel/releases{/id}","deployments_url":"https://api.github.com/repos/sbraz/genkernel/deployments","created_at":"2018-12-07T11:27:49Z","updated_at":"2018-12-07T11:27:51Z","pushed_at":"2019-01-05T02:26:45Z","git_url":"git://github.com/sbraz/genkernel.git","ssh_url":"git@github.com:sbraz/genkernel.git","clone_url":"https://github.com/sbraz/genkernel.git","svn_url":"https://github.com/sbraz/genkernel","homepage":null,"size":25710,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"febc1b12b5b393e918da94b9f1c029f2adcea215","user":{"login":"gentoo","id":52242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":34823747,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgyMzc0Nw==","name":"genkernel","full_name":"gentoo/genkernel","private":false,"owner":{"login":"gentoo","id":52242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gentoo/genkernel","description":"Working copy of genkernel tree to receive pull requests","fork":true,"url":"https://api.github.com/repos/gentoo/genkernel","forks_url":"https://api.github.com/repos/gentoo/genkernel/forks","keys_url":"https://api.github.com/repos/gentoo/genkernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/genkernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/genkernel/teams","hooks_url":"https://api.github.com/repos/gentoo/genkernel/hooks","issue_events_url":"https://api.github.com/repos/gentoo/genkernel/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/genkernel/events","assignees_url":"https://api.github.com/repos/gentoo/genkernel/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/genkernel/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/genkernel/tags","blobs_url":"https://api.github.com/repos/gentoo/genkernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/genkernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/genkernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/genkernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/genkernel/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/genkernel/languages","stargazers_url":"https://api.github.com/repos/gentoo/genkernel/stargazers","contributors_url":"https://api.github.com/repos/gentoo/genkernel/contributors","subscribers_url":"https://api.github.com/repos/gentoo/genkernel/subscribers","subscription_url":"https://api.github.com/repos/gentoo/genkernel/subscription","commits_url":"https://api.github.com/repos/gentoo/genkernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/genkernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/genkernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/genkernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/genkernel/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/genkernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/genkernel/merges","archive_url":"https://api.github.com/repos/gentoo/genkernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/genkernel/downloads","issues_url":"https://api.github.com/repos/gentoo/genkernel/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/genkernel/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/genkernel/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/genkernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/genkernel/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/genkernel/releases{/id}","deployments_url":"https://api.github.com/repos/gentoo/genkernel/deployments","created_at":"2015-04-29T23:31:26Z","updated_at":"2019-02-09T05:44:54Z","pushed_at":"2019-03-01T06:01:15Z","git_url":"git://github.com/gentoo/genkernel.git","ssh_url":"git@github.com:gentoo/genkernel.git","clone_url":"https://github.com/gentoo/genkernel.git","svn_url":"https://github.com/gentoo/genkernel","homepage":null,"size":25702,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":12,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/genkernel/pulls/8"},"html":{"href":"https://github.com/gentoo/genkernel/pull/8"},"issue":{"href":"https://api.github.com/repos/gentoo/genkernel/issues/8"},"comments":{"href":"https://api.github.com/repos/gentoo/genkernel/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/genkernel/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/genkernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/genkernel/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/genkernel/statuses/c466e59ca66671e96ce57f0a877ab3638f941b45"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":33,"deletions":24,"changed_files":3}}
other: {"actor":{"display_login":"robbat2"}}