payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rapidsai/ucx-py/pulls/comments/332890460","pull_request_review_id":299249616,"id":332890460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjg5MDQ2MA==","diff_hunk":"@@ -289,6 +293,13 @@ cdef class ApplicationContext:\n         return self.config\n \n \n+cdef struct Tags:\n+    uint64_t send_tag\n+    uint64_t recv_tag\n+    uint64_t ctrl_send_tag\n+    uint64_t ctrl_recv_tag","path":"ucp/_libs/core.pyx","position":78,"original_position":60,"commit_id":"4dd8cbdf2c97719a7f95f1e1f8668acf5660d039","original_commit_id":"31187a7cfa505624c1090cfbeb0e3486bfa173a7","user":{"login":"madsbk","id":1041088,"node_id":"MDQ6VXNlcjEwNDEwODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1041088?v=4","gravatar_id":"","url":"https://api.github.com/users/madsbk","html_url":"https://github.com/madsbk","followers_url":"https://api.github.com/users/madsbk/followers","following_url":"https://api.github.com/users/madsbk/following{/other_user}","gists_url":"https://api.github.com/users/madsbk/gists{/gist_id}","starred_url":"https://api.github.com/users/madsbk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madsbk/subscriptions","organizations_url":"https://api.github.com/users/madsbk/orgs","repos_url":"https://api.github.com/users/madsbk/repos","events_url":"https://api.github.com/users/madsbk/events{/privacy}","received_events_url":"https://api.github.com/users/madsbk/received_events","type":"User","site_admin":false},"body":"@MattBBaker, I don't think that we need separate send and receive tags anymore but they are nice to have in the log messages (making it easy to follow the communication flow).\r\nIf we use the pointer address of Endpoints as IDs in the log instead, which is the same UCX does, we can combine the send/recv tags and still have a nice log.\r\n\r\nBut I think we should merge this PR and make another PR that combines the send/recv tags.\r\n\r\n\r\n\r\n","created_at":"2019-10-09T08:35:10Z","updated_at":"2019-10-09T08:35:11Z","html_url":"https://github.com/rapidsai/ucx-py/pull/215#discussion_r332890460","pull_request_url":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rapidsai/ucx-py/pulls/comments/332890460"},"html":{"href":"https://github.com/rapidsai/ucx-py/pull/215#discussion_r332890460"},"pull_request":{"href":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215"}},"in_reply_to_id":332703801},"pull_request":{"url":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215","id":324201932,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MjAxOTMy","html_url":"https://github.com/rapidsai/ucx-py/pull/215","diff_url":"https://github.com/rapidsai/ucx-py/pull/215.diff","patch_url":"https://github.com/rapidsai/ucx-py/pull/215.patch","issue_url":"https://api.github.com/repos/rapidsai/ucx-py/issues/215","number":215,"state":"open","locked":false,"title":"Use struct tags","user":{"login":"jakirkham","id":3019665,"node_id":"MDQ6VXNlcjMwMTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/rapidsai/ucx-py/issues/210\r\nFixes https://github.com/rapidsai/ucx-py/issues/223\r\nMerges https://github.com/rapidsai/ucx-py/pull/228\r\nCloses https://github.com/rapidsai/ucx-py/pull/230\r\n\r\nCreates a `struct` called `Tags` to hold the different tag values when sending or receiving them. Should make it easier to follow which tag is being used where.","created_at":"2019-10-03T12:52:20Z","updated_at":"2019-10-09T08:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22664efd8f12b2e0d59620df9165fa871fc36ff6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215/commits","review_comments_url":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215/comments","review_comment_url":"https://api.github.com/repos/rapidsai/ucx-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapidsai/ucx-py/issues/215/comments","statuses_url":"https://api.github.com/repos/rapidsai/ucx-py/statuses/4dd8cbdf2c97719a7f95f1e1f8668acf5660d039","head":{"label":"jakirkham:use_struct_tags","ref":"use_struct_tags","sha":"4dd8cbdf2c97719a7f95f1e1f8668acf5660d039","user":{"login":"jakirkham","id":3019665,"node_id":"MDQ6VXNlcjMwMTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"repo":{"id":179355801,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzNTU4MDE=","name":"ucx-py","full_name":"jakirkham/ucx-py","private":false,"owner":{"login":"jakirkham","id":3019665,"node_id":"MDQ6VXNlcjMwMTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jakirkham/ucx-py","description":"Python bindings for UCX ","fork":true,"url":"https://api.github.com/repos/jakirkham/ucx-py","forks_url":"https://api.github.com/repos/jakirkham/ucx-py/forks","keys_url":"https://api.github.com/repos/jakirkham/ucx-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakirkham/ucx-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakirkham/ucx-py/teams","hooks_url":"https://api.github.com/repos/jakirkham/ucx-py/hooks","issue_events_url":"https://api.github.com/repos/jakirkham/ucx-py/issues/events{/number}","events_url":"https://api.github.com/repos/jakirkham/ucx-py/events","assignees_url":"https://api.github.com/repos/jakirkham/ucx-py/assignees{/user}","branches_url":"https://api.github.com/repos/jakirkham/ucx-py/branches{/branch}","tags_url":"https://api.github.com/repos/jakirkham/ucx-py/tags","blobs_url":"https://api.github.com/repos/jakirkham/ucx-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakirkham/ucx-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakirkham/ucx-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakirkham/ucx-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakirkham/ucx-py/statuses/{sha}","languages_url":"https://api.github.com/repos/jakirkham/ucx-py/languages","stargazers_url":"https://api.github.com/repos/jakirkham/ucx-py/stargazers","contributors_url":"https://api.github.com/repos/jakirkham/ucx-py/contributors","subscribers_url":"https://api.github.com/repos/jakirkham/ucx-py/subscribers","subscription_url":"https://api.github.com/repos/jakirkham/ucx-py/subscription","commits_url":"https://api.github.com/repos/jakirkham/ucx-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakirkham/ucx-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakirkham/ucx-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakirkham/ucx-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakirkham/ucx-py/contents/{+path}","compare_url":"https://api.github.com/repos/jakirkham/ucx-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakirkham/ucx-py/merges","archive_url":"https://api.github.com/repos/jakirkham/ucx-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakirkham/ucx-py/downloads","issues_url":"https://api.github.com/repos/jakirkham/ucx-py/issues{/number}","pulls_url":"https://api.github.com/repos/jakirkham/ucx-py/pulls{/number}","milestones_url":"https://api.github.com/repos/jakirkham/ucx-py/milestones{/number}","notifications_url":"https://api.github.com/repos/jakirkham/ucx-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakirkham/ucx-py/labels{/name}","releases_url":"https://api.github.com/repos/jakirkham/ucx-py/releases{/id}","deployments_url":"https://api.github.com/repos/jakirkham/ucx-py/deployments","created_at":"2019-04-03T19:24:19Z","updated_at":"2019-10-03T11:20:23Z","pushed_at":"2019-10-08T23:38:10Z","git_url":"git://github.com/jakirkham/ucx-py.git","ssh_url":"git@github.com:jakirkham/ucx-py.git","clone_url":"https://github.com/jakirkham/ucx-py.git","svn_url":"https://github.com/jakirkham/ucx-py","homepage":null,"size":506,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"rapidsai:branch-0.10","ref":"branch-0.10","sha":"741c03b2b5d8ba6869da9b87f2652ecd6a417e0d","user":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"repo":{"id":149822197,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk4MjIxOTc=","name":"ucx-py","full_name":"rapidsai/ucx-py","private":false,"owner":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapidsai/ucx-py","description":"Python bindings for UCX ","fork":false,"url":"https://api.github.com/repos/rapidsai/ucx-py","forks_url":"https://api.github.com/repos/rapidsai/ucx-py/forks","keys_url":"https://api.github.com/repos/rapidsai/ucx-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapidsai/ucx-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapidsai/ucx-py/teams","hooks_url":"https://api.github.com/repos/rapidsai/ucx-py/hooks","issue_events_url":"https://api.github.com/repos/rapidsai/ucx-py/issues/events{/number}","events_url":"https://api.github.com/repos/rapidsai/ucx-py/events","assignees_url":"https://api.github.com/repos/rapidsai/ucx-py/assignees{/user}","branches_url":"https://api.github.com/repos/rapidsai/ucx-py/branches{/branch}","tags_url":"https://api.github.com/repos/rapidsai/ucx-py/tags","blobs_url":"https://api.github.com/repos/rapidsai/ucx-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapidsai/ucx-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapidsai/ucx-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapidsai/ucx-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapidsai/ucx-py/statuses/{sha}","languages_url":"https://api.github.com/repos/rapidsai/ucx-py/languages","stargazers_url":"https://api.github.com/repos/rapidsai/ucx-py/stargazers","contributors_url":"https://api.github.com/repos/rapidsai/ucx-py/contributors","subscribers_url":"https://api.github.com/repos/rapidsai/ucx-py/subscribers","subscription_url":"https://api.github.com/repos/rapidsai/ucx-py/subscription","commits_url":"https://api.github.com/repos/rapidsai/ucx-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapidsai/ucx-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapidsai/ucx-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapidsai/ucx-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapidsai/ucx-py/contents/{+path}","compare_url":"https://api.github.com/repos/rapidsai/ucx-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapidsai/ucx-py/merges","archive_url":"https://api.github.com/repos/rapidsai/ucx-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapidsai/ucx-py/downloads","issues_url":"https://api.github.com/repos/rapidsai/ucx-py/issues{/number}","pulls_url":"https://api.github.com/repos/rapidsai/ucx-py/pulls{/number}","milestones_url":"https://api.github.com/repos/rapidsai/ucx-py/milestones{/number}","notifications_url":"https://api.github.com/repos/rapidsai/ucx-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapidsai/ucx-py/labels{/name}","releases_url":"https://api.github.com/repos/rapidsai/ucx-py/releases{/id}","deployments_url":"https://api.github.com/repos/rapidsai/ucx-py/deployments","created_at":"2018-09-21T21:53:38Z","updated_at":"2019-10-08T21:45:05Z","pushed_at":"2019-10-09T03:25:28Z","git_url":"git://github.com/rapidsai/ucx-py.git","ssh_url":"git@github.com:rapidsai/ucx-py.git","clone_url":"https://github.com/rapidsai/ucx-py.git","svn_url":"https://github.com/rapidsai/ucx-py","homepage":null,"size":502,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":47,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":9,"open_issues":47,"watchers":12,"default_branch":"branch-0.10"}},"_links":{"self":{"href":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215"},"html":{"href":"https://github.com/rapidsai/ucx-py/pull/215"},"issue":{"href":"https://api.github.com/repos/rapidsai/ucx-py/issues/215"},"comments":{"href":"https://api.github.com/repos/rapidsai/ucx-py/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/rapidsai/ucx-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapidsai/ucx-py/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/rapidsai/ucx-py/statuses/4dd8cbdf2c97719a7f95f1e1f8668acf5660d039"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"madsbk"}}