payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/313324633","pull_request_review_id":274191193,"id":313324633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzMyNDYzMw==","diff_hunk":"@@ -92,6 +92,8 @@ public function getAttributes(): array\n \n     /**\n      * {@inheritdoc}\n+     *\n+     * @return object","path":"src/Symfony/Component/WebLink/Link.php","position":null,"original_position":5,"commit_id":"f2354eecce86108006056b29c8be8d1b6402be28","original_commit_id":"75937543cb72c0bb53ceb8b63f94c60dec5ce4da","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"Good catch, I actually missed propagating the original annotation, now fixed.\r\nThis means we now have `Node[]` instead of `array` also.","created_at":"2019-08-13T10:26:59Z","updated_at":"2019-08-13T10:26:59Z","html_url":"https://github.com/symfony/symfony/pull/30323#discussion_r313324633","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/30323","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/313324633"},"html":{"href":"https://github.com/symfony/symfony/pull/30323#discussion_r313324633"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/30323"}},"in_reply_to_id":313258592},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/30323","id":254737006,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NzM3MDA2","html_url":"https://github.com/symfony/symfony/pull/30323","diff_url":"https://github.com/symfony/symfony/pull/30323.diff","patch_url":"https://github.com/symfony/symfony/pull/30323.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/30323","number":30323,"state":"open","locked":false,"title":"[ErrorHandler] trigger deprecation in DebugClassLoader when child class misses a return type","user":{"login":"fancyweb","id":3658119,"node_id":"MDQ6VXNlcjM2NTgxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3658119?v=4","gravatar_id":"","url":"https://api.github.com/users/fancyweb","html_url":"https://github.com/fancyweb","followers_url":"https://api.github.com/users/fancyweb/followers","following_url":"https://api.github.com/users/fancyweb/following{/other_user}","gists_url":"https://api.github.com/users/fancyweb/gists{/gist_id}","starred_url":"https://api.github.com/users/fancyweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fancyweb/subscriptions","organizations_url":"https://api.github.com/users/fancyweb/orgs","repos_url":"https://api.github.com/users/fancyweb/repos","events_url":"https://api.github.com/users/fancyweb/events{/privacy}","received_events_url":"https://api.github.com/users/fancyweb/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 4.4\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | https://github.com/symfony/symfony/issues/30123\r\n| License       | MIT\r\n| Doc PR        | TODO\r\n\r\nI wanted to push something to show the advancement and get feedback.\r\n\r\nI pushed two versions : one with dedicated functions for code clarity (DebugClassLoader.php) and one withtout (DebugClassLoader___.php). It would be nice if some people with Blackfire could compare the performances.\r\n\r\nSo let's be clear, we are never gonna be able to cover all cases! We can however cover the vast majority.\r\n\r\nCurrent non covered cases and problems : \r\n- We assume that if there is more than 2 returned types, we cannot do anything. Even if it could technically be possible.\r\n- We assume that any returned type that doesn't fit our \"returnable\" types list is a class. We don't check at all if this class actualy exists.\r\n- We don't handle spaces in types. The types stop at the first space.\r\n- That means we don't handle (yet) the callable type with spaces (cf https://github.com/symfony/symfony/issues/29969)\r\n- Vendor code extending other vendor core triggers the deprecations 😕 ","created_at":"2019-02-20T17:58:40Z","updated_at":"2019-08-13T10:26:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9637919652267566befbae8c15bf71d68839561","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dunglas","id":57224,"node_id":"MDQ6VXNlcjU3MjI0","avatar_url":"https://avatars2.githubusercontent.com/u/57224?v=4","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},{"login":"lyrixx","id":408368,"node_id":"MDQ6VXNlcjQwODM2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/408368?v=4","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},{"login":"xabbuh","id":1957048,"node_id":"MDQ6VXNlcjE5NTcwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1957048?v=4","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":49125875,"node_id":"MDU6TGFiZWw0OTEyNTg3NQ==","url":"https://api.github.com/repos/symfony/symfony/labels/Debug","name":"Debug","color":"DDDDDD","default":false},{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237550465,"node_id":"MDU6TGFiZWwyMzc1NTA0NjU=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.4#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":163,"closed_issues":345,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2019-08-13T07:17:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/30323/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/30323/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/30323/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/f2354eecce86108006056b29c8be8d1b6402be28","head":{"label":"fancyweb:handle-return-types","ref":"handle-return-types","sha":"f2354eecce86108006056b29c8be8d1b6402be28","user":{"login":"fancyweb","id":3658119,"node_id":"MDQ6VXNlcjM2NTgxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3658119?v=4","gravatar_id":"","url":"https://api.github.com/users/fancyweb","html_url":"https://github.com/fancyweb","followers_url":"https://api.github.com/users/fancyweb/followers","following_url":"https://api.github.com/users/fancyweb/following{/other_user}","gists_url":"https://api.github.com/users/fancyweb/gists{/gist_id}","starred_url":"https://api.github.com/users/fancyweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fancyweb/subscriptions","organizations_url":"https://api.github.com/users/fancyweb/orgs","repos_url":"https://api.github.com/users/fancyweb/repos","events_url":"https://api.github.com/users/fancyweb/events{/privacy}","received_events_url":"https://api.github.com/users/fancyweb/received_events","type":"User","site_admin":false},"repo":{"id":72099020,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA5OTAyMA==","name":"symfony","full_name":"fancyweb/symfony","private":false,"owner":{"login":"fancyweb","id":3658119,"node_id":"MDQ6VXNlcjM2NTgxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3658119?v=4","gravatar_id":"","url":"https://api.github.com/users/fancyweb","html_url":"https://github.com/fancyweb","followers_url":"https://api.github.com/users/fancyweb/followers","following_url":"https://api.github.com/users/fancyweb/following{/other_user}","gists_url":"https://api.github.com/users/fancyweb/gists{/gist_id}","starred_url":"https://api.github.com/users/fancyweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fancyweb/subscriptions","organizations_url":"https://api.github.com/users/fancyweb/orgs","repos_url":"https://api.github.com/users/fancyweb/repos","events_url":"https://api.github.com/users/fancyweb/events{/privacy}","received_events_url":"https://api.github.com/users/fancyweb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fancyweb/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/fancyweb/symfony","forks_url":"https://api.github.com/repos/fancyweb/symfony/forks","keys_url":"https://api.github.com/repos/fancyweb/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fancyweb/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fancyweb/symfony/teams","hooks_url":"https://api.github.com/repos/fancyweb/symfony/hooks","issue_events_url":"https://api.github.com/repos/fancyweb/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/fancyweb/symfony/events","assignees_url":"https://api.github.com/repos/fancyweb/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/fancyweb/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/fancyweb/symfony/tags","blobs_url":"https://api.github.com/repos/fancyweb/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fancyweb/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fancyweb/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/fancyweb/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fancyweb/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/fancyweb/symfony/languages","stargazers_url":"https://api.github.com/repos/fancyweb/symfony/stargazers","contributors_url":"https://api.github.com/repos/fancyweb/symfony/contributors","subscribers_url":"https://api.github.com/repos/fancyweb/symfony/subscribers","subscription_url":"https://api.github.com/repos/fancyweb/symfony/subscription","commits_url":"https://api.github.com/repos/fancyweb/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/fancyweb/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/fancyweb/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/fancyweb/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/fancyweb/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/fancyweb/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fancyweb/symfony/merges","archive_url":"https://api.github.com/repos/fancyweb/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fancyweb/symfony/downloads","issues_url":"https://api.github.com/repos/fancyweb/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/fancyweb/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/fancyweb/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/fancyweb/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fancyweb/symfony/labels{/name}","releases_url":"https://api.github.com/repos/fancyweb/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/fancyweb/symfony/deployments","created_at":"2016-10-27T10:49:12Z","updated_at":"2018-07-15T14:10:46Z","pushed_at":"2019-08-13T10:21:45Z","git_url":"git://github.com/fancyweb/symfony.git","ssh_url":"git@github.com:fancyweb/symfony.git","clone_url":"https://github.com/fancyweb/symfony.git","svn_url":"https://github.com/fancyweb/symfony","homepage":"symfony.com","size":142201,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:4.4","ref":"4.4","sha":"d6773bc547a7ec7eeed9f6b4f1df8da1fc7aa775","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2019-08-13T09:53:08Z","pushed_at":"2019-08-13T10:21:52Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":148203,"stargazers_count":21380,"watchers_count":21380,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7102,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":831,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7102,"open_issues":831,"watchers":21380,"default_branch":"4.4"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/30323"},"html":{"href":"https://github.com/symfony/symfony/pull/30323"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/30323"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/30323/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/30323/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/30323/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/f2354eecce86108006056b29c8be8d1b6402be28"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"nicolas-grekas"}}