payload: {"action":"created","issue":{"url":"https://api.github.com/repos/alfert/propcheck/issues/143","repository_url":"https://api.github.com/repos/alfert/propcheck","labels_url":"https://api.github.com/repos/alfert/propcheck/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/alfert/propcheck/issues/143/comments","events_url":"https://api.github.com/repos/alfert/propcheck/issues/143/events","html_url":"https://github.com/alfert/propcheck/pull/143","id":547648805,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxMDk5MTM2","number":143,"title":"Credo + Dialyzer fixes","user":{"login":"rodrigues","id":128147,"node_id":"MDQ6VXNlcjEyODE0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/128147?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigues","html_url":"https://github.com/rodrigues","followers_url":"https://api.github.com/users/rodrigues/followers","following_url":"https://api.github.com/users/rodrigues/following{/other_user}","gists_url":"https://api.github.com/users/rodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigues/subscriptions","organizations_url":"https://api.github.com/users/rodrigues/orgs","repos_url":"https://api.github.com/users/rodrigues/repos","events_url":"https://api.github.com/users/rodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigues/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2020-01-09T18:34:41Z","updated_at":"2020-01-11T16:09:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alfert/propcheck/pulls/143","html_url":"https://github.com/alfert/propcheck/pull/143","diff_url":"https://github.com/alfert/propcheck/pull/143.diff","patch_url":"https://github.com/alfert/propcheck/pull/143.patch"},"body":"Hi @alfert 👋 opening this PR for your appreciation 🙂\r\n\r\n- Updates credo, dialyzer and other dev/test deps\r\n- Fixes issues pointed out by credo and dialyzer\r\n- Adds dialyzer to CI (credo already was)\r\n\r\nThere are still three dialyzer warnings remaining, I'm not sure if these should be fixed or ignored, please tell me what you think about that, or anything else.\r\n\r\nThanks!\r\n\r\n```elixir\r\nlib/statem_dsl.ex:476:invalid_contract\r\nThe @spec for the function does not match the success typing of the function.\r\n\r\nFunction:\r\nPropCheck.StateM.DSL.execute_cmd/2\r\n\r\nSuccess typing:\r\n@spec execute_cmd(\r\n  {:set, {:var, _}, {:call, _, _, _}},\r\n  atom() | %{:env => %{{:var, pos_integer()} => _}, :state => _, _ => _}\r\n) ::\r\n  {_, {:call, atom(), atom(), [any()]},\r\n   {{:var, _}, {:exception, _} | {:ok, _} | {:post_condition, _} | {:pre_condition, _}}}\r\n\r\n________________________________________________________________________________\r\ntest/support/sequential_cache.ex:53:race_condition\r\nThe call :ets, insert(PropCheck.Test.Cache, [{1, {_, _}} | {:count, 1, _}, ...]) might have an unintended effect due to a possible race condition caused by its combination with the ets:lookup('Elixir.PropCheck.Test.Cache','count') call in sequential_cache.ex on line 44.\r\n________________________________________________________________________________\r\ntest/support/sequential_cache.ex:63:race_condition\r\nThe call :ets, insert(PropCheck.Test.Cache, {:count, 0, _}) might have an unintended effect due to a possible race condition caused by its combination with the ets:lookup('Elixir.PropCheck.Test.Cache','count') call in sequential_cache.ex on line 61.\r\n```"},"comment":{"url":"https://api.github.com/repos/alfert/propcheck/issues/comments/573329936","html_url":"https://github.com/alfert/propcheck/pull/143#issuecomment-573329936","issue_url":"https://api.github.com/repos/alfert/propcheck/issues/143","id":573329936,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MzMyOTkzNg==","user":{"login":"alfert","id":1159524,"node_id":"MDQ6VXNlcjExNTk1MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1159524?v=4","gravatar_id":"","url":"https://api.github.com/users/alfert","html_url":"https://github.com/alfert","followers_url":"https://api.github.com/users/alfert/followers","following_url":"https://api.github.com/users/alfert/following{/other_user}","gists_url":"https://api.github.com/users/alfert/gists{/gist_id}","starred_url":"https://api.github.com/users/alfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfert/subscriptions","organizations_url":"https://api.github.com/users/alfert/orgs","repos_url":"https://api.github.com/users/alfert/repos","events_url":"https://api.github.com/users/alfert/events{/privacy}","received_events_url":"https://api.github.com/users/alfert/received_events","type":"User","site_admin":false},"created_at":"2020-01-11T16:09:35Z","updated_at":"2020-01-11T16:09:35Z","author_association":"OWNER","body":"> ensure auto-formatting\r\n\r\n@rodrigues, I won't go for auto-formatting until there is a real case for, which I don't see at the moment. I will take care for this tiny bit later. "}}
other: {"actor":{"display_login":"alfert"}}