payload: {"action":"created","issue":{"url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint/issues/725","repository_url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint","labels_url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint/issues/725/comments","events_url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint/issues/725/events","html_url":"https://github.com/aws-cloudformation/cfn-python-lint/issues/725","id":420996142,"node_id":"MDU6SXNzdWU0MjA5OTYxNDI=","number":725,"title":"E3031 CidrIp contains invalid characters fails when Fn::Sub is present","user":{"login":"seporaitis","id":141768,"node_id":"MDQ6VXNlcjE0MTc2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/141768?v=4","gravatar_id":"","url":"https://api.github.com/users/seporaitis","html_url":"https://github.com/seporaitis","followers_url":"https://api.github.com/users/seporaitis/followers","following_url":"https://api.github.com/users/seporaitis/following{/other_user}","gists_url":"https://api.github.com/users/seporaitis/gists{/gist_id}","starred_url":"https://api.github.com/users/seporaitis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seporaitis/subscriptions","organizations_url":"https://api.github.com/users/seporaitis/orgs","repos_url":"https://api.github.com/users/seporaitis/repos","events_url":"https://api.github.com/users/seporaitis/events{/privacy}","received_events_url":"https://api.github.com/users/seporaitis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-14T12:41:14Z","updated_at":"2019-03-14T14:31:42Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"*cfn-lint version: (`cfn-lint --version`)*\r\n\r\n`cfn-lint 0.16.0`\r\n\r\n*Description of issue.*\r\n\r\nWhen `CidrIp` value is `!Sub`ed from `Parameters` - E3031 lint error is raised. Sample template:\r\n\r\n```lang=yaml\r\nAWSTemplateFormatVersion: 2010-09-09\r\n\r\nDescription: AMI Builder Stack\r\n\r\nParameters:\r\n\r\n  BuilderCidr:\r\n    Type: String\r\n\r\nResources:\r\n\r\n  SecurityGroup:\r\n    Type: AWS::EC2::SecurityGroup\r\n    Properties:\r\n      GroupDescription: Description\r\n      VpcId: vpc-id\r\n      SecurityGroupIngress:\r\n      - IpProtocol: tcp\r\n        FromPort: 1\r\n        ToPort: 65535\r\n        CidrIp: !Sub ${BuilderCidr}\r\n```\r\n\r\nExpected output: successful lint\r\nActual output:\r\n\r\n```\r\nE3031 CidrIp contains invalid characters (Pattern: x.x.x.x/y) at Resources/SecurityGroup/Properties/SecurityGroupIngress/0/CidrIp/Fn::Sub\r\n```\r\n\r\n> Cfn-lint uses the [CloudFormation Resource Specifications](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html) as the base to do validation. These files are included as part of the application version. Please update to the latest version of `cfn-lint` or update the spec files manually (`cfn-lint -u`)\r\n\r\nThe problem still persists after running `cfn-lint -u`"},"comment":{"url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint/issues/comments/472886505","html_url":"https://github.com/aws-cloudformation/cfn-python-lint/issues/725#issuecomment-472886505","issue_url":"https://api.github.com/repos/aws-cloudformation/cfn-python-lint/issues/725","id":472886505,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3Mjg4NjUwNQ==","user":{"login":"fatbasstard","id":35613489,"node_id":"MDQ6VXNlcjM1NjEzNDg5","avatar_url":"https://avatars2.githubusercontent.com/u/35613489?v=4","gravatar_id":"","url":"https://api.github.com/users/fatbasstard","html_url":"https://github.com/fatbasstard","followers_url":"https://api.github.com/users/fatbasstard/followers","following_url":"https://api.github.com/users/fatbasstard/following{/other_user}","gists_url":"https://api.github.com/users/fatbasstard/gists{/gist_id}","starred_url":"https://api.github.com/users/fatbasstard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatbasstard/subscriptions","organizations_url":"https://api.github.com/users/fatbasstard/orgs","repos_url":"https://api.github.com/users/fatbasstard/repos","events_url":"https://api.github.com/users/fatbasstard/events{/privacy}","received_events_url":"https://api.github.com/users/fatbasstard/received_events","type":"User","site_admin":false},"created_at":"2019-03-14T14:31:42Z","updated_at":"2019-03-14T14:31:42Z","author_association":"CONTRIBUTOR","body":"Variables are replaced with \"\"... In this case a `!Ref` would be more \"logical\" btw, but the rule should not break ofcourse"}}
other: {"actor":{"display_login":"fatbasstard"}}