payload: {"action":"opened","number":4482,"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/4482","id":352314547,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMzE0NTQ3","html_url":"https://github.com/rook/rook/pull/4482","diff_url":"https://github.com/rook/rook/pull/4482.diff","patch_url":"https://github.com/rook/rook/pull/4482.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/4482","number":4482,"state":"open","locked":false,"title":"ceph: increase gateway liveness timeout","user":{"login":"ashangit","id":6404013,"node_id":"MDQ6VXNlcjY0MDQwMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6404013?v=4","gravatar_id":"","url":"https://api.github.com/users/ashangit","html_url":"https://github.com/ashangit","followers_url":"https://api.github.com/users/ashangit/followers","following_url":"https://api.github.com/users/ashangit/following{/other_user}","gists_url":"https://api.github.com/users/ashangit/gists{/gist_id}","starred_url":"https://api.github.com/users/ashangit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashangit/subscriptions","organizations_url":"https://api.github.com/users/ashangit/orgs","repos_url":"https://api.github.com/users/ashangit/repos","events_url":"https://api.github.com/users/ashangit/events{/privacy}","received_events_url":"https://api.github.com/users/ashangit/received_events","type":"User","site_admin":false},"body":"<!-- Please take a look at our [Contributing](https://rook.io/docs/rook/master/development-flow.html)\r\ndocumentation before submitting a Pull Request!\r\nThank you for contributing to Rook! -->\r\n\r\n**Description of your changes:**\r\nIncrease the default timeout from 1s to 10s of the gateways liveness check.\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves below issue:\r\nRunning a Load test, distcp from hadoop to S3 of 45To with 200 mappers running in //, on our Ceph/S3 platform based on rook 1.1.7 I observed lots of restart of the gateway components.\r\nA first issue was due to a bug in ceph v14.2.4 corrected in v14.2.5 (https://github.com/ceph/ceph/pull/29559).\r\nBut most of the restart are due to the liveness probe timeout which is based on the default setting of 1s.\r\nIn case of big loads the health checks takes more than a second to be treated and leads to the gateway beeing restarted even if it still responds to queries.\r\nSince I've increased the timeout to 10s this issue doesn't happen anymore and the service is stable.\r\n\r\n**Checklist:**\r\n\r\n- [ ] Reviewed the developer guide on [Submitting a Pull Request](https://rook.io/docs/rook/master/development-flow.html#submitting-a-pull-request)\r\n- [ ] Documentation has been updated, if necessary.\r\n- [ ] Unit tests have been added, if necessary.\r\n- [ ] Integration tests have been added, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [ ] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [ ] Comments have been added or updated based on the standards set in [CONTRIBUTING.md](https://github.com/rook/rook/blob/master/CONTRIBUTING.md#comments)\r\n- [ ] Add the flag for skipping the CI if this PR does not require a build. See [here](https://github.com/rook/rook/blob/master/INSTALL.md#skip-ci) for more details.\r\n","created_at":"2019-12-12T09:32:16Z","updated_at":"2019-12-12T09:32:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/4482/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/4482/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/4482/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/ac18796493eaa6b8731f3f481372223f07a49d41","head":{"label":"ashangit:timeout_liveness_probe_gateway","ref":"timeout_liveness_probe_gateway","sha":"ac18796493eaa6b8731f3f481372223f07a49d41","user":{"login":"ashangit","id":6404013,"node_id":"MDQ6VXNlcjY0MDQwMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6404013?v=4","gravatar_id":"","url":"https://api.github.com/users/ashangit","html_url":"https://github.com/ashangit","followers_url":"https://api.github.com/users/ashangit/followers","following_url":"https://api.github.com/users/ashangit/following{/other_user}","gists_url":"https://api.github.com/users/ashangit/gists{/gist_id}","starred_url":"https://api.github.com/users/ashangit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashangit/subscriptions","organizations_url":"https://api.github.com/users/ashangit/orgs","repos_url":"https://api.github.com/users/ashangit/repos","events_url":"https://api.github.com/users/ashangit/events{/privacy}","received_events_url":"https://api.github.com/users/ashangit/received_events","type":"User","site_admin":false},"repo":{"id":226298523,"node_id":"MDEwOlJlcG9zaXRvcnkyMjYyOTg1MjM=","name":"rook","full_name":"ashangit/rook","private":false,"owner":{"login":"ashangit","id":6404013,"node_id":"MDQ6VXNlcjY0MDQwMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6404013?v=4","gravatar_id":"","url":"https://api.github.com/users/ashangit","html_url":"https://github.com/ashangit","followers_url":"https://api.github.com/users/ashangit/followers","following_url":"https://api.github.com/users/ashangit/following{/other_user}","gists_url":"https://api.github.com/users/ashangit/gists{/gist_id}","starred_url":"https://api.github.com/users/ashangit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashangit/subscriptions","organizations_url":"https://api.github.com/users/ashangit/orgs","repos_url":"https://api.github.com/users/ashangit/repos","events_url":"https://api.github.com/users/ashangit/events{/privacy}","received_events_url":"https://api.github.com/users/ashangit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ashangit/rook","description":"Storage Orchestration for Kubernetes","fork":true,"url":"https://api.github.com/repos/ashangit/rook","forks_url":"https://api.github.com/repos/ashangit/rook/forks","keys_url":"https://api.github.com/repos/ashangit/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashangit/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashangit/rook/teams","hooks_url":"https://api.github.com/repos/ashangit/rook/hooks","issue_events_url":"https://api.github.com/repos/ashangit/rook/issues/events{/number}","events_url":"https://api.github.com/repos/ashangit/rook/events","assignees_url":"https://api.github.com/repos/ashangit/rook/assignees{/user}","branches_url":"https://api.github.com/repos/ashangit/rook/branches{/branch}","tags_url":"https://api.github.com/repos/ashangit/rook/tags","blobs_url":"https://api.github.com/repos/ashangit/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashangit/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashangit/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashangit/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashangit/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/ashangit/rook/languages","stargazers_url":"https://api.github.com/repos/ashangit/rook/stargazers","contributors_url":"https://api.github.com/repos/ashangit/rook/contributors","subscribers_url":"https://api.github.com/repos/ashangit/rook/subscribers","subscription_url":"https://api.github.com/repos/ashangit/rook/subscription","commits_url":"https://api.github.com/repos/ashangit/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashangit/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashangit/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashangit/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashangit/rook/contents/{+path}","compare_url":"https://api.github.com/repos/ashangit/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashangit/rook/merges","archive_url":"https://api.github.com/repos/ashangit/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashangit/rook/downloads","issues_url":"https://api.github.com/repos/ashangit/rook/issues{/number}","pulls_url":"https://api.github.com/repos/ashangit/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/ashangit/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/ashangit/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashangit/rook/labels{/name}","releases_url":"https://api.github.com/repos/ashangit/rook/releases{/id}","deployments_url":"https://api.github.com/repos/ashangit/rook/deployments","created_at":"2019-12-06T10:00:18Z","updated_at":"2019-12-09T10:14:19Z","pushed_at":"2019-12-12T09:31:27Z","git_url":"git://github.com/ashangit/rook.git","ssh_url":"git@github.com:ashangit/rook.git","clone_url":"https://github.com/ashangit/rook.git","svn_url":"https://github.com/ashangit/rook","homepage":"https://rook.io","size":14327,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"695412acd888c24bdb947a2bd96c1be33cc1c4a3","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","private":false,"owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2019-12-12T07:59:36Z","pushed_at":"2019-12-12T09:22:50Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":14350,"stargazers_count":6515,"watchers_count":6515,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1212,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":305,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1212,"open_issues":305,"watchers":6515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/4482"},"html":{"href":"https://github.com/rook/rook/pull/4482"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/4482"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/4482/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/4482/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/4482/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/ac18796493eaa6b8731f3f481372223f07a49d41"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":0,"changed_files":2}}
other: {"actor":{"display_login":"ashangit"}}