payload: {"action":"created","issue":{"url":"https://api.github.com/repos/openwrt/openwrt/issues/1883","repository_url":"https://api.github.com/repos/openwrt/openwrt","labels_url":"https://api.github.com/repos/openwrt/openwrt/issues/1883/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/openwrt/issues/1883/comments","events_url":"https://api.github.com/repos/openwrt/openwrt/issues/1883/events","html_url":"https://github.com/openwrt/openwrt/pull/1883","id":416388254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NjU5NTcx","number":1883,"title":"U-Boot: Add support to board ARV7519RW aka Livebox 2.1","user":{"login":"Mandrake-Lee","id":29834513,"node_id":"MDQ6VXNlcjI5ODM0NTEz","avatar_url":"https://avatars3.githubusercontent.com/u/29834513?v=4","gravatar_id":"","url":"https://api.github.com/users/Mandrake-Lee","html_url":"https://github.com/Mandrake-Lee","followers_url":"https://api.github.com/users/Mandrake-Lee/followers","following_url":"https://api.github.com/users/Mandrake-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Mandrake-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Mandrake-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mandrake-Lee/subscriptions","organizations_url":"https://api.github.com/users/Mandrake-Lee/orgs","repos_url":"https://api.github.com/users/Mandrake-Lee/repos","events_url":"https://api.github.com/users/Mandrake-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Mandrake-Lee/received_events","type":"User","site_admin":false},"labels":[{"id":793818473,"node_id":"MDU6TGFiZWw3OTM4MTg0NzM=","url":"https://api.github.com/repos/openwrt/openwrt/labels/target/lantiq","name":"target/lantiq","color":"0043e4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-03-02T11:34:07Z","updated_at":"2019-03-05T21:30:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/1883","html_url":"https://github.com/openwrt/openwrt/pull/1883","diff_url":"https://github.com/openwrt/openwrt/pull/1883.diff","patch_url":"https://github.com/openwrt/openwrt/pull/1883.patch"},"body":"Package uboot-lantiq; added support for board ARV7519RW22-A-LT aka Livebox 2.1\r\n\r\nThe sources have been taken from https://github.com/danielschwierzeck/u-boot-lantiq with original author kept in the patch file.\r\n\r\nA couple of important changes:\r\n\r\n- Comment variable CONFIG_SYS_DRAM_PROBE in file \"arv4579rw.h\"; otherwise only half of the memory of the board will be detected.\r\n\r\n- Variable CONFIG_SYS_BOOTM_LEN has been redefined to 16Mb. This was leading to crash with the latest initramfs images of Openwrt, which is a real inconvenient during development\r\n\r\nThe resulting binaries, both .bin an .asc (for uart boot) have been tested with success.\r\n"},"comment":{"url":"https://api.github.com/repos/openwrt/openwrt/issues/comments/469864939","html_url":"https://github.com/openwrt/openwrt/pull/1883#issuecomment-469864939","issue_url":"https://api.github.com/repos/openwrt/openwrt/issues/1883","id":469864939,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2OTg2NDkzOQ==","user":{"login":"Mandrake-Lee","id":29834513,"node_id":"MDQ6VXNlcjI5ODM0NTEz","avatar_url":"https://avatars3.githubusercontent.com/u/29834513?v=4","gravatar_id":"","url":"https://api.github.com/users/Mandrake-Lee","html_url":"https://github.com/Mandrake-Lee","followers_url":"https://api.github.com/users/Mandrake-Lee/followers","following_url":"https://api.github.com/users/Mandrake-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Mandrake-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Mandrake-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mandrake-Lee/subscriptions","organizations_url":"https://api.github.com/users/Mandrake-Lee/orgs","repos_url":"https://api.github.com/users/Mandrake-Lee/repos","events_url":"https://api.github.com/users/Mandrake-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Mandrake-Lee/received_events","type":"User","site_admin":false},"created_at":"2019-03-05T21:30:16Z","updated_at":"2019-03-05T21:30:16Z","author_association":"CONTRIBUTOR","body":"> \r\n> \r\n> I have to go but, for now I see just three appointments:\r\n> In ddr_config:\r\n> \r\n> > +#define\tMC_CCR41_VALUE\t0x141b42\r\n> > +#define\tMC_CCR42_VALUE\t0x141b42\r\n> \r\n> capitalize the b\r\n> \r\n> ```\r\n> +#define\tMC_CCR41_VALUE\t0x141B42\r\n> +#define\tMC_CCR42_VALUE\t0x141B42\r\n> ```\r\n> \r\n> In general: To be consistent with the naming rename ARV7519RW and arv7519rw to ARV7519RW22 and arv7519rw22. Filenames and strings in code.\r\n> \r\n> In u-boot variables: There are no definition about the kernel_addr variable that should be 0xB0080000 to work with actual images but have to check if it could be necessary or not, but I think it should be defined in /include/configs/arv7519rw(22).h just after:\r\n> \r\n> ```\r\n> \tCONFIG_ENV_UPDATE_UBOOT_NOR\t\\\r\n> \t\"kernel_addr=0xB0080000\\0\"\r\n> ```\r\n\r\nI'm doing this couple of amendmendts, no real problem.\r\n\r\nHowever the \"kernel_addr\" definition is redundant. It must be declared somewhere else because it is already in the first uboot that I could compile.\r\n\r\nDo you really want to redefine it? It's not a big issue but sounds strange to me."}}
other: {"actor":{"display_login":"Mandrake-Lee"}}