payload: {"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/29","id":293161797,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzMTYxNzk3","html_url":"https://github.com/Eve-of-Darkness/eve-of-darkness/pull/29","diff_url":"https://github.com/Eve-of-Darkness/eve-of-darkness/pull/29.diff","patch_url":"https://github.com/Eve-of-Darkness/eve-of-darkness/pull/29.patch","issue_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/29","number":29,"state":"closed","locked":false,"title":"Refactor EOD.Server to be a Supervisor","user":{"login":"benfalk","id":2657901,"node_id":"MDQ6VXNlcjI2NTc5MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2657901?v=4","gravatar_id":"","url":"https://api.github.com/users/benfalk","html_url":"https://github.com/benfalk","followers_url":"https://api.github.com/users/benfalk/followers","following_url":"https://api.github.com/users/benfalk/following{/other_user}","gists_url":"https://api.github.com/users/benfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/benfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfalk/subscriptions","organizations_url":"https://api.github.com/users/benfalk/orgs","repos_url":"https://api.github.com/users/benfalk/repos","events_url":"https://api.github.com/users/benfalk/events{/privacy}","received_events_url":"https://api.github.com/users/benfalk/received_events","type":"User","site_admin":false},"body":"This refactor cleans up some of the application supervision and\r\nfurther removes direct interaction responsibility of the \"server\"\r\nby changing it from a GenServer to a Supervisor.\r\n\r\nNow in stead of a GenServer that starts up other workers, which\r\nfelt a bit off to me to begin with, it is now a supervisor that\r\nstarts the same workers and gives them names that are registered\r\nunder the server name provided or pid.\r\n\r\nThis work required further work to some of the other workers to\r\nensure they can be started with names - but it wasn't as bad as\r\nI thought it would be.\r\n\r\nThis also removes the `ref` option for the server and you can now\r\nonly \"disable\" the connection manager from starting; which is all\r\nI was doing in the tests anyway.","created_at":"2019-07-01T03:00:15Z","updated_at":"2019-07-01T03:15:15Z","closed_at":"2019-07-01T03:15:15Z","merged_at":"2019-07-01T03:15:15Z","merge_commit_sha":"6391db3395857516cbc24d4214338a12a8fa3b5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/29/comments","statuses_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/statuses/43169bf844defbd09fc0d523fd324da5fe6453f2","head":{"label":"Eve-of-Darkness:refactor","ref":"refactor","sha":"43169bf844defbd09fc0d523fd324da5fe6453f2","user":{"login":"Eve-of-Darkness","id":32642559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjQyNTU5","avatar_url":"https://avatars2.githubusercontent.com/u/32642559?v=4","gravatar_id":"","url":"https://api.github.com/users/Eve-of-Darkness","html_url":"https://github.com/Eve-of-Darkness","followers_url":"https://api.github.com/users/Eve-of-Darkness/followers","following_url":"https://api.github.com/users/Eve-of-Darkness/following{/other_user}","gists_url":"https://api.github.com/users/Eve-of-Darkness/gists{/gist_id}","starred_url":"https://api.github.com/users/Eve-of-Darkness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eve-of-Darkness/subscriptions","organizations_url":"https://api.github.com/users/Eve-of-Darkness/orgs","repos_url":"https://api.github.com/users/Eve-of-Darkness/repos","events_url":"https://api.github.com/users/Eve-of-Darkness/events{/privacy}","received_events_url":"https://api.github.com/users/Eve-of-Darkness/received_events","type":"Organization","site_admin":false},"repo":{"id":111628365,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2MjgzNjU=","name":"eve-of-darkness","full_name":"Eve-of-Darkness/eve-of-darkness","private":false,"owner":{"login":"Eve-of-Darkness","id":32642559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjQyNTU5","avatar_url":"https://avatars2.githubusercontent.com/u/32642559?v=4","gravatar_id":"","url":"https://api.github.com/users/Eve-of-Darkness","html_url":"https://github.com/Eve-of-Darkness","followers_url":"https://api.github.com/users/Eve-of-Darkness/followers","following_url":"https://api.github.com/users/Eve-of-Darkness/following{/other_user}","gists_url":"https://api.github.com/users/Eve-of-Darkness/gists{/gist_id}","starred_url":"https://api.github.com/users/Eve-of-Darkness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eve-of-Darkness/subscriptions","organizations_url":"https://api.github.com/users/Eve-of-Darkness/orgs","repos_url":"https://api.github.com/users/Eve-of-Darkness/repos","events_url":"https://api.github.com/users/Eve-of-Darkness/events{/privacy}","received_events_url":"https://api.github.com/users/Eve-of-Darkness/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Eve-of-Darkness/eve-of-darkness","description":"Dark Age of Camelot Server","fork":false,"url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness","forks_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/forks","keys_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/teams","hooks_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/hooks","issue_events_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/events{/number}","events_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/events","assignees_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/assignees{/user}","branches_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/branches{/branch}","tags_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/tags","blobs_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/statuses/{sha}","languages_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/languages","stargazers_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/stargazers","contributors_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/contributors","subscribers_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/subscribers","subscription_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/subscription","commits_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/contents/{+path}","compare_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/merges","archive_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/downloads","issues_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues{/number}","pulls_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls{/number}","milestones_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/milestones{/number}","notifications_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/labels{/name}","releases_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/releases{/id}","deployments_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/deployments","created_at":"2017-11-22T02:49:25Z","updated_at":"2019-06-30T00:00:06Z","pushed_at":"2019-07-01T03:15:15Z","git_url":"git://github.com/Eve-of-Darkness/eve-of-darkness.git","ssh_url":"git@github.com:Eve-of-Darkness/eve-of-darkness.git","clone_url":"https://github.com/Eve-of-Darkness/eve-of-darkness.git","svn_url":"https://github.com/Eve-of-Darkness/eve-of-darkness","homepage":"http://www.eveofdarkness.org/","size":621,"stargazers_count":9,"watchers_count":9,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":4,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"Eve-of-Darkness:master","ref":"master","sha":"597059e36972861519a9803e1af8b39bb4ceb0be","user":{"login":"Eve-of-Darkness","id":32642559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjQyNTU5","avatar_url":"https://avatars2.githubusercontent.com/u/32642559?v=4","gravatar_id":"","url":"https://api.github.com/users/Eve-of-Darkness","html_url":"https://github.com/Eve-of-Darkness","followers_url":"https://api.github.com/users/Eve-of-Darkness/followers","following_url":"https://api.github.com/users/Eve-of-Darkness/following{/other_user}","gists_url":"https://api.github.com/users/Eve-of-Darkness/gists{/gist_id}","starred_url":"https://api.github.com/users/Eve-of-Darkness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eve-of-Darkness/subscriptions","organizations_url":"https://api.github.com/users/Eve-of-Darkness/orgs","repos_url":"https://api.github.com/users/Eve-of-Darkness/repos","events_url":"https://api.github.com/users/Eve-of-Darkness/events{/privacy}","received_events_url":"https://api.github.com/users/Eve-of-Darkness/received_events","type":"Organization","site_admin":false},"repo":{"id":111628365,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2MjgzNjU=","name":"eve-of-darkness","full_name":"Eve-of-Darkness/eve-of-darkness","private":false,"owner":{"login":"Eve-of-Darkness","id":32642559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjQyNTU5","avatar_url":"https://avatars2.githubusercontent.com/u/32642559?v=4","gravatar_id":"","url":"https://api.github.com/users/Eve-of-Darkness","html_url":"https://github.com/Eve-of-Darkness","followers_url":"https://api.github.com/users/Eve-of-Darkness/followers","following_url":"https://api.github.com/users/Eve-of-Darkness/following{/other_user}","gists_url":"https://api.github.com/users/Eve-of-Darkness/gists{/gist_id}","starred_url":"https://api.github.com/users/Eve-of-Darkness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eve-of-Darkness/subscriptions","organizations_url":"https://api.github.com/users/Eve-of-Darkness/orgs","repos_url":"https://api.github.com/users/Eve-of-Darkness/repos","events_url":"https://api.github.com/users/Eve-of-Darkness/events{/privacy}","received_events_url":"https://api.github.com/users/Eve-of-Darkness/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Eve-of-Darkness/eve-of-darkness","description":"Dark Age of Camelot Server","fork":false,"url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness","forks_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/forks","keys_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/teams","hooks_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/hooks","issue_events_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/events{/number}","events_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/events","assignees_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/assignees{/user}","branches_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/branches{/branch}","tags_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/tags","blobs_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/statuses/{sha}","languages_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/languages","stargazers_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/stargazers","contributors_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/contributors","subscribers_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/subscribers","subscription_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/subscription","commits_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/contents/{+path}","compare_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/merges","archive_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/downloads","issues_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues{/number}","pulls_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls{/number}","milestones_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/milestones{/number}","notifications_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/labels{/name}","releases_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/releases{/id}","deployments_url":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/deployments","created_at":"2017-11-22T02:49:25Z","updated_at":"2019-06-30T00:00:06Z","pushed_at":"2019-07-01T03:15:15Z","git_url":"git://github.com/Eve-of-Darkness/eve-of-darkness.git","ssh_url":"git@github.com:Eve-of-Darkness/eve-of-darkness.git","clone_url":"https://github.com/Eve-of-Darkness/eve-of-darkness.git","svn_url":"https://github.com/Eve-of-Darkness/eve-of-darkness","homepage":"http://www.eveofdarkness.org/","size":621,"stargazers_count":9,"watchers_count":9,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":4,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/29"},"html":{"href":"https://github.com/Eve-of-Darkness/eve-of-darkness/pull/29"},"issue":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/29"},"comments":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Eve-of-Darkness/eve-of-darkness/statuses/43169bf844defbd09fc0d523fd324da5fe6453f2"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"benfalk","id":2657901,"node_id":"MDQ6VXNlcjI2NTc5MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2657901?v=4","gravatar_id":"","url":"https://api.github.com/users/benfalk","html_url":"https://github.com/benfalk","followers_url":"https://api.github.com/users/benfalk/followers","following_url":"https://api.github.com/users/benfalk/following{/other_user}","gists_url":"https://api.github.com/users/benfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/benfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfalk/subscriptions","organizations_url":"https://api.github.com/users/benfalk/orgs","repos_url":"https://api.github.com/users/benfalk/repos","events_url":"https://api.github.com/users/benfalk/events{/privacy}","received_events_url":"https://api.github.com/users/benfalk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":123,"deletions":110,"changed_files":9}}
other: {"actor":{"display_login":"benfalk"}}