payload: {"action":"closed","number":3501,"pull_request":{"url":"https://api.github.com/repos/GafferHQ/gaffer/pulls/3501","id":349883822,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5ODgzODIy","html_url":"https://github.com/GafferHQ/gaffer/pull/3501","diff_url":"https://github.com/GafferHQ/gaffer/pull/3501.diff","patch_url":"https://github.com/GafferHQ/gaffer/pull/3501.patch","issue_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/3501","number":3501,"state":"closed","locked":false,"title":"Set : Deprecate `paths` plug","user":{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"body":"The original version of the Set node didn't have a `filter` plug, so the only way of specifying locations was to enter them as paths. This had very good performance, but allowed users to accidentally enter invalid locations, which could have unintended consequences downstream.\r\n\r\nLater on, we added the `filter` plug to provide a more flexible way of specifying locations. This method guarantees that only valid locations are used, but came with an overhead in performance. We documented that users should prefer the `paths` plug where possible.\r\n\r\nIn practice, users are just confused about which option to use and when. We've also substantially improved the performance of the `filter` option since its introduction, to the point where there is negligible overhead in replacing `paths` plug usage with `PathFilter` usage. So, we wish to rip out the `paths` plug to remove confusion and guarantee that sets can never contain invalid paths.\r\n\r\nHere we're merely deprecating the `paths` plug and hiding it from the UI unless it is already in use (has a non-default value or current input). In a later version we'll remove it fully, at which point we'll deal with\r\nthe problem of auto-converting old `paths` usage into PathFilters.\r\n\r\nImprovements\r\n------------\r\n\r\n- Set : Hid unused `paths` plugs from the UI, in preparation for eventual\r\n  removal of the plug itself. The `filter` plug should now always be used\r\n  in preference to the `paths` plug.\r\n","created_at":"2019-12-06T10:56:30Z","updated_at":"2019-12-10T15:26:57Z","closed_at":"2019-12-10T15:26:57Z","merged_at":"2019-12-10T15:26:56Z","merge_commit_sha":"ce982473e50d8872193d45c9f1916540b393753f","assignee":{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andrewkaufman","id":3979682,"node_id":"MDQ6VXNlcjM5Nzk2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},{"login":"danieldresser-ie","id":27969079,"node_id":"MDQ6VXNlcjI3OTY5MDc5","avatar_url":"https://avatars2.githubusercontent.com/u/27969079?v=4","gravatar_id":"","url":"https://api.github.com/users/danieldresser-ie","html_url":"https://github.com/danieldresser-ie","followers_url":"https://api.github.com/users/danieldresser-ie/followers","following_url":"https://api.github.com/users/danieldresser-ie/following{/other_user}","gists_url":"https://api.github.com/users/danieldresser-ie/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldresser-ie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldresser-ie/subscriptions","organizations_url":"https://api.github.com/users/danieldresser-ie/orgs","repos_url":"https://api.github.com/users/danieldresser-ie/repos","events_url":"https://api.github.com/users/danieldresser-ie/events{/privacy}","received_events_url":"https://api.github.com/users/danieldresser-ie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GafferHQ/gaffer/pulls/3501/commits","review_comments_url":"https://api.github.com/repos/GafferHQ/gaffer/pulls/3501/comments","review_comment_url":"https://api.github.com/repos/GafferHQ/gaffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/3501/comments","statuses_url":"https://api.github.com/repos/GafferHQ/gaffer/statuses/f12ee3a4ca993a4e8f2d4b7aa303b05ece5fa076","head":{"label":"johnhaddon:hideSetPaths","ref":"hideSetPaths","sha":"f12ee3a4ca993a4e8f2d4b7aa303b05ece5fa076","user":{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"repo":{"id":9043150,"node_id":"MDEwOlJlcG9zaXRvcnk5MDQzMTUw","name":"gaffer","full_name":"johnhaddon/gaffer","private":false,"owner":{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnhaddon/gaffer","description":"My day-to-day development","fork":true,"url":"https://api.github.com/repos/johnhaddon/gaffer","forks_url":"https://api.github.com/repos/johnhaddon/gaffer/forks","keys_url":"https://api.github.com/repos/johnhaddon/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnhaddon/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnhaddon/gaffer/teams","hooks_url":"https://api.github.com/repos/johnhaddon/gaffer/hooks","issue_events_url":"https://api.github.com/repos/johnhaddon/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/johnhaddon/gaffer/events","assignees_url":"https://api.github.com/repos/johnhaddon/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/johnhaddon/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/johnhaddon/gaffer/tags","blobs_url":"https://api.github.com/repos/johnhaddon/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnhaddon/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnhaddon/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnhaddon/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnhaddon/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/johnhaddon/gaffer/languages","stargazers_url":"https://api.github.com/repos/johnhaddon/gaffer/stargazers","contributors_url":"https://api.github.com/repos/johnhaddon/gaffer/contributors","subscribers_url":"https://api.github.com/repos/johnhaddon/gaffer/subscribers","subscription_url":"https://api.github.com/repos/johnhaddon/gaffer/subscription","commits_url":"https://api.github.com/repos/johnhaddon/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnhaddon/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnhaddon/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnhaddon/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnhaddon/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/johnhaddon/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnhaddon/gaffer/merges","archive_url":"https://api.github.com/repos/johnhaddon/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnhaddon/gaffer/downloads","issues_url":"https://api.github.com/repos/johnhaddon/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/johnhaddon/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/johnhaddon/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/johnhaddon/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnhaddon/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/johnhaddon/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/johnhaddon/gaffer/deployments","created_at":"2013-03-27T00:06:40Z","updated_at":"2019-12-03T15:31:14Z","pushed_at":"2019-12-10T13:18:19Z","git_url":"git://github.com/johnhaddon/gaffer.git","ssh_url":"git@github.com:johnhaddon/gaffer.git","clone_url":"https://github.com/johnhaddon/gaffer.git","svn_url":"https://github.com/johnhaddon/gaffer","homepage":"","size":51228,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GafferHQ:master","ref":"master","sha":"1fc556be0ecf99aef541a1510d633f5acb9b09b7","user":{"login":"GafferHQ","id":20556043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTU2MDQz","avatar_url":"https://avatars1.githubusercontent.com/u/20556043?v=4","gravatar_id":"","url":"https://api.github.com/users/GafferHQ","html_url":"https://github.com/GafferHQ","followers_url":"https://api.github.com/users/GafferHQ/followers","following_url":"https://api.github.com/users/GafferHQ/following{/other_user}","gists_url":"https://api.github.com/users/GafferHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/GafferHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GafferHQ/subscriptions","organizations_url":"https://api.github.com/users/GafferHQ/orgs","repos_url":"https://api.github.com/users/GafferHQ/repos","events_url":"https://api.github.com/users/GafferHQ/events{/privacy}","received_events_url":"https://api.github.com/users/GafferHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":9043124,"node_id":"MDEwOlJlcG9zaXRvcnk5MDQzMTI0","name":"gaffer","full_name":"GafferHQ/gaffer","private":false,"owner":{"login":"GafferHQ","id":20556043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTU2MDQz","avatar_url":"https://avatars1.githubusercontent.com/u/20556043?v=4","gravatar_id":"","url":"https://api.github.com/users/GafferHQ","html_url":"https://github.com/GafferHQ","followers_url":"https://api.github.com/users/GafferHQ/followers","following_url":"https://api.github.com/users/GafferHQ/following{/other_user}","gists_url":"https://api.github.com/users/GafferHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/GafferHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GafferHQ/subscriptions","organizations_url":"https://api.github.com/users/GafferHQ/orgs","repos_url":"https://api.github.com/users/GafferHQ/repos","events_url":"https://api.github.com/users/GafferHQ/events{/privacy}","received_events_url":"https://api.github.com/users/GafferHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GafferHQ/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":false,"url":"https://api.github.com/repos/GafferHQ/gaffer","forks_url":"https://api.github.com/repos/GafferHQ/gaffer/forks","keys_url":"https://api.github.com/repos/GafferHQ/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GafferHQ/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GafferHQ/gaffer/teams","hooks_url":"https://api.github.com/repos/GafferHQ/gaffer/hooks","issue_events_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/GafferHQ/gaffer/events","assignees_url":"https://api.github.com/repos/GafferHQ/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/GafferHQ/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/GafferHQ/gaffer/tags","blobs_url":"https://api.github.com/repos/GafferHQ/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GafferHQ/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GafferHQ/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/GafferHQ/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GafferHQ/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/GafferHQ/gaffer/languages","stargazers_url":"https://api.github.com/repos/GafferHQ/gaffer/stargazers","contributors_url":"https://api.github.com/repos/GafferHQ/gaffer/contributors","subscribers_url":"https://api.github.com/repos/GafferHQ/gaffer/subscribers","subscription_url":"https://api.github.com/repos/GafferHQ/gaffer/subscription","commits_url":"https://api.github.com/repos/GafferHQ/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/GafferHQ/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/GafferHQ/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/GafferHQ/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/GafferHQ/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GafferHQ/gaffer/merges","archive_url":"https://api.github.com/repos/GafferHQ/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GafferHQ/gaffer/downloads","issues_url":"https://api.github.com/repos/GafferHQ/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/GafferHQ/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/GafferHQ/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/GafferHQ/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GafferHQ/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/GafferHQ/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/GafferHQ/gaffer/deployments","created_at":"2013-03-27T00:04:53Z","updated_at":"2019-12-10T10:19:08Z","pushed_at":"2019-12-10T15:26:56Z","git_url":"git://github.com/GafferHQ/gaffer.git","ssh_url":"git@github.com:GafferHQ/gaffer.git","clone_url":"https://github.com/GafferHQ/gaffer.git","svn_url":"https://github.com/GafferHQ/gaffer","homepage":"http://www.gafferhq.org","size":52137,"stargazers_count":542,"watchers_count":542,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":287,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":145,"open_issues":287,"watchers":542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GafferHQ/gaffer/pulls/3501"},"html":{"href":"https://github.com/GafferHQ/gaffer/pull/3501"},"issue":{"href":"https://api.github.com/repos/GafferHQ/gaffer/issues/3501"},"comments":{"href":"https://api.github.com/repos/GafferHQ/gaffer/issues/3501/comments"},"review_comments":{"href":"https://api.github.com/repos/GafferHQ/gaffer/pulls/3501/comments"},"review_comment":{"href":"https://api.github.com/repos/GafferHQ/gaffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GafferHQ/gaffer/pulls/3501/commits"},"statuses":{"href":"https://api.github.com/repos/GafferHQ/gaffer/statuses/f12ee3a4ca993a4e8f2d4b7aa303b05ece5fa076"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewkaufman","id":3979682,"node_id":"MDQ6VXNlcjM5Nzk2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":10,"changed_files":2}}
other: {"actor":{"display_login":"andrewkaufman"}}