payload: {"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/314995362","pull_request_review_id":276288537,"id":314995362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDk5NTM2Mg==","diff_hunk":"@@ -573,3 +575,24 @@ func setTargetsScheme(rs *v1alpha1.RouteStatus, dnsNames []string, scheme string\n \t\t}\n \t}\n }\n+\n+func buildIngressSplitsForChallenges(domains []string, challenges []netv1alpha1.HTTP01Challenge) []netv1alpha1.IngressRule {\n+\tsplits := []netv1alpha1.IngressRule{}\n+\tfor _, challenge := range challenges {\n+\t\tsplits = append(splits, *resources.MakeIngressRuleWithPath(\n+\t\t\tdomains,\n+\t\t\tchallenge.ServiceNamespace,\n+\t\t\tfalse,\n+\t\t\t[]netv1alpha1.IngressBackendSplit{{\n+\t\t\t\tIngressBackend: netv1alpha1.IngressBackend{\n+\t\t\t\t\tServiceNamespace: challenge.ServiceNamespace,\n+\t\t\t\t\tServiceName:      challenge.ServiceName,\n+\t\t\t\t\tServicePort:      challenge.ServicePort,\n+\t\t\t\t},\n+\t\t\t\tPercent: 100,","path":"pkg/reconciler/route/route.go","position":99,"original_position":99,"commit_id":"d339077348d7e00740cc59bc17f0baf0f9e3f992","original_commit_id":"d339077348d7e00740cc59bc17f0baf0f9e3f992","user":{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},"body":"If we're going over splits, and you're assigning 100% to all of them, will this validate?","created_at":"2019-08-18T17:44:08Z","updated_at":"2019-08-18T17:45:24Z","html_url":"https://github.com/knative/serving/pull/5186#discussion_r314995362","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/5186","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/314995362"},"html":{"href":"https://github.com/knative/serving/pull/5186#discussion_r314995362"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/5186"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/5186","id":308235559,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MjM1NTU5","html_url":"https://github.com/knative/serving/pull/5186","diff_url":"https://github.com/knative/serving/pull/5186.diff","patch_url":"https://github.com/knative/serving/pull/5186.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/5186","number":5186,"state":"open","locked":false,"title":"Add support for auto TLS HTTP01 challenges","user":{"login":"rmoe","id":26524,"node_id":"MDQ6VXNlcjI2NTI0","avatar_url":"https://avatars3.githubusercontent.com/u/26524?v=4","gravatar_id":"","url":"https://api.github.com/users/rmoe","html_url":"https://github.com/rmoe","followers_url":"https://api.github.com/users/rmoe/followers","following_url":"https://api.github.com/users/rmoe/following{/other_user}","gists_url":"https://api.github.com/users/rmoe/gists{/gist_id}","starred_url":"https://api.github.com/users/rmoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmoe/subscriptions","organizations_url":"https://api.github.com/users/rmoe/orgs","repos_url":"https://api.github.com/users/rmoe/repos","events_url":"https://api.github.com/users/rmoe/events{/privacy}","received_events_url":"https://api.github.com/users/rmoe/received_events","type":"User","site_admin":false},"body":"## Proposed Changes\r\n\r\nWhen cert-manager creates a solver service the Knative\r\ncertificate reconciler will populate `Status.HTTP01Challenges`\r\nof the corresponding Knative certificate. This challenge information\r\nis used to create an IngressRule to route traffic from Let's Encrypt\r\nto the solver service.\r\n\r\nFixes: #4100\r\nCo-Authored-By: Mike Petersen <mpetason@gmail.com>\r\n\r\n<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\n**Release Note**\r\n\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n\r\n```release-note\r\nNONE\r\n```","created_at":"2019-08-16T22:22:20Z","updated_at":"2019-08-18T17:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada328d62073b7191f8494f5019a04161e1dacbc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dprotaso","id":18562,"node_id":"MDQ6VXNlcjE4NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/18562?v=4","gravatar_id":"","url":"https://api.github.com/users/dprotaso","html_url":"https://github.com/dprotaso","followers_url":"https://api.github.com/users/dprotaso/followers","following_url":"https://api.github.com/users/dprotaso/following{/other_user}","gists_url":"https://api.github.com/users/dprotaso/gists{/gist_id}","starred_url":"https://api.github.com/users/dprotaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dprotaso/subscriptions","organizations_url":"https://api.github.com/users/dprotaso/orgs","repos_url":"https://api.github.com/users/dprotaso/repos","events_url":"https://api.github.com/users/dprotaso/events{/privacy}","received_events_url":"https://api.github.com/users/dprotaso/received_events","type":"User","site_admin":false},{"login":"mdemirhan","id":4033879,"node_id":"MDQ6VXNlcjQwMzM4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4033879?v=4","gravatar_id":"","url":"https://api.github.com/users/mdemirhan","html_url":"https://github.com/mdemirhan","followers_url":"https://api.github.com/users/mdemirhan/followers","following_url":"https://api.github.com/users/mdemirhan/following{/other_user}","gists_url":"https://api.github.com/users/mdemirhan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdemirhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdemirhan/subscriptions","organizations_url":"https://api.github.com/users/mdemirhan/orgs","repos_url":"https://api.github.com/users/mdemirhan/repos","events_url":"https://api.github.com/users/mdemirhan/events{/privacy}","received_events_url":"https://api.github.com/users/mdemirhan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":825408057,"node_id":"MDU6TGFiZWw4MjU0MDgwNTc=","url":"https://api.github.com/repos/knative/serving/labels/area/API","name":"area/API","color":"0052cc","default":false},{"id":868660931,"node_id":"MDU6TGFiZWw4Njg2NjA5MzE=","url":"https://api.github.com/repos/knative/serving/labels/area/networking","name":"area/networking","color":"e59cc2","default":false},{"id":1294350052,"node_id":"MDU6TGFiZWwxMjk0MzUwMDUy","url":"https://api.github.com/repos/knative/serving/labels/cla:%20no","name":"cla: no","color":"ededed","default":false},{"id":1323020605,"node_id":"MDU6TGFiZWwxMzIzMDIwNjA1","url":"https://api.github.com/repos/knative/serving/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false},{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/5186/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/5186/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/5186/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/d339077348d7e00740cc59bc17f0baf0f9e3f992","head":{"label":"rmoe:http-challenge","ref":"http-challenge","sha":"d339077348d7e00740cc59bc17f0baf0f9e3f992","user":{"login":"rmoe","id":26524,"node_id":"MDQ6VXNlcjI2NTI0","avatar_url":"https://avatars3.githubusercontent.com/u/26524?v=4","gravatar_id":"","url":"https://api.github.com/users/rmoe","html_url":"https://github.com/rmoe","followers_url":"https://api.github.com/users/rmoe/followers","following_url":"https://api.github.com/users/rmoe/following{/other_user}","gists_url":"https://api.github.com/users/rmoe/gists{/gist_id}","starred_url":"https://api.github.com/users/rmoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmoe/subscriptions","organizations_url":"https://api.github.com/users/rmoe/orgs","repos_url":"https://api.github.com/users/rmoe/repos","events_url":"https://api.github.com/users/rmoe/events{/privacy}","received_events_url":"https://api.github.com/users/rmoe/received_events","type":"User","site_admin":false},"repo":{"id":179720404,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk3MjA0MDQ=","name":"serving","full_name":"rmoe/serving","private":false,"owner":{"login":"rmoe","id":26524,"node_id":"MDQ6VXNlcjI2NTI0","avatar_url":"https://avatars3.githubusercontent.com/u/26524?v=4","gravatar_id":"","url":"https://api.github.com/users/rmoe","html_url":"https://github.com/rmoe","followers_url":"https://api.github.com/users/rmoe/followers","following_url":"https://api.github.com/users/rmoe/following{/other_user}","gists_url":"https://api.github.com/users/rmoe/gists{/gist_id}","starred_url":"https://api.github.com/users/rmoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmoe/subscriptions","organizations_url":"https://api.github.com/users/rmoe/orgs","repos_url":"https://api.github.com/users/rmoe/repos","events_url":"https://api.github.com/users/rmoe/events{/privacy}","received_events_url":"https://api.github.com/users/rmoe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rmoe/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/rmoe/serving","forks_url":"https://api.github.com/repos/rmoe/serving/forks","keys_url":"https://api.github.com/repos/rmoe/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmoe/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmoe/serving/teams","hooks_url":"https://api.github.com/repos/rmoe/serving/hooks","issue_events_url":"https://api.github.com/repos/rmoe/serving/issues/events{/number}","events_url":"https://api.github.com/repos/rmoe/serving/events","assignees_url":"https://api.github.com/repos/rmoe/serving/assignees{/user}","branches_url":"https://api.github.com/repos/rmoe/serving/branches{/branch}","tags_url":"https://api.github.com/repos/rmoe/serving/tags","blobs_url":"https://api.github.com/repos/rmoe/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmoe/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmoe/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmoe/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmoe/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/rmoe/serving/languages","stargazers_url":"https://api.github.com/repos/rmoe/serving/stargazers","contributors_url":"https://api.github.com/repos/rmoe/serving/contributors","subscribers_url":"https://api.github.com/repos/rmoe/serving/subscribers","subscription_url":"https://api.github.com/repos/rmoe/serving/subscription","commits_url":"https://api.github.com/repos/rmoe/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmoe/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmoe/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmoe/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmoe/serving/contents/{+path}","compare_url":"https://api.github.com/repos/rmoe/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmoe/serving/merges","archive_url":"https://api.github.com/repos/rmoe/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmoe/serving/downloads","issues_url":"https://api.github.com/repos/rmoe/serving/issues{/number}","pulls_url":"https://api.github.com/repos/rmoe/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/rmoe/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/rmoe/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmoe/serving/labels{/name}","releases_url":"https://api.github.com/repos/rmoe/serving/releases{/id}","deployments_url":"https://api.github.com/repos/rmoe/serving/deployments","created_at":"2019-04-05T16:48:18Z","updated_at":"2019-07-15T19:24:39Z","pushed_at":"2019-08-16T22:12:37Z","git_url":"git://github.com/rmoe/serving.git","ssh_url":"git@github.com:rmoe/serving.git","clone_url":"https://github.com/rmoe/serving.git","svn_url":"https://github.com/rmoe/serving","homepage":"","size":39057,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"c59f073ee7423bbc05bbfe06f7408b2e66315e1d","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2019-08-18T15:02:47Z","pushed_at":"2019-08-18T15:02:45Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"https://knative.dev/docs/serving/","size":39090,"stargazers_count":2165,"watchers_count":2165,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":418,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":291,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":418,"open_issues":291,"watchers":2165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/5186"},"html":{"href":"https://github.com/knative/serving/pull/5186"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/5186"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/5186/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/5186/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/5186/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/d339077348d7e00740cc59bc17f0baf0f9e3f992"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"vagababov"}}