payload: {"action":"closed","number":7947,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/7947","id":355415515,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1NDE1NTE1","html_url":"https://github.com/snapcore/snapd/pull/7947","diff_url":"https://github.com/snapcore/snapd/pull/7947.diff","patch_url":"https://github.com/snapcore/snapd/pull/7947.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/7947","number":7947,"state":"closed","locked":false,"title":"boot,bootloader: support new UC20 style kernel extraction","user":{"login":"anonymouse64","id":6006573,"node_id":"MDQ6VXNlcjYwMDY1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6006573?v=4","gravatar_id":"","url":"https://api.github.com/users/anonymouse64","html_url":"https://github.com/anonymouse64","followers_url":"https://api.github.com/users/anonymouse64/followers","following_url":"https://api.github.com/users/anonymouse64/following{/other_user}","gists_url":"https://api.github.com/users/anonymouse64/gists{/gist_id}","starred_url":"https://api.github.com/users/anonymouse64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anonymouse64/subscriptions","organizations_url":"https://api.github.com/users/anonymouse64/orgs","repos_url":"https://api.github.com/users/anonymouse64/repos","events_url":"https://api.github.com/users/anonymouse64/events{/privacy}","received_events_url":"https://api.github.com/users/anonymouse64/received_events","type":"User","site_admin":false},"body":"* We change ExtractKernelAssets to specify what assets should be extracted, so we can extract kernel.efi for UC20 and kernel.img, initrd.img and dtbs/* on other platforms. If the assets is empty, it defaults to the latter list.\r\n* We also set kernel_status in ubuntu-boot grubenv to empty initially when running makeBootable20RunMode as this is the new boot variable.\r\n* The grub bootloader implementation now uses a KernelExtractionDir option to specify where the kernel should be extracted to, again defaulting to the old behavior if unset, but allowing us to use the ubuntu-boot partition root directory for UC20.\r\n\r\nThis was roughly based on @mvo5's patches at https://github.com/snapcore/snapd/pull/7913\r\n\r\nAlso note if you want to try this in a real UC20 machine, you need to try this with the grub.cfg changes in https://github.com/snapcore/pc-amd64-gadget/pull/31.","created_at":"2019-12-19T23:12:04Z","updated_at":"2020-01-13T20:48:27Z","closed_at":"2020-01-13T20:48:27Z","merged_at":null,"merge_commit_sha":"58f13637f0fe2e6a2ca5a5c9e625dbed608ea34d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1697301979,"node_id":"MDU6TGFiZWwxNjk3MzAxOTc5","url":"https://api.github.com/repos/snapcore/snapd/labels/UC20","name":"UC20","color":"bfdadc","default":false,"description":"Required for the Ubuntu Core 20 work"},{"id":378322797,"node_id":"MDU6TGFiZWwzNzgzMjI3OTc=","url":"https://api.github.com/repos/snapcore/snapd/labels/%E2%9B%94%20Blocked","name":"⛔ Blocked","color":"d93f0b","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/7947/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/7947/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/7947/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/041696f073842495b2341f40baa1701d412f57d3","head":{"label":"anonymouse64:feature/uc20-kernel-extract","ref":"feature/uc20-kernel-extract","sha":"041696f073842495b2341f40baa1701d412f57d3","user":{"login":"anonymouse64","id":6006573,"node_id":"MDQ6VXNlcjYwMDY1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6006573?v=4","gravatar_id":"","url":"https://api.github.com/users/anonymouse64","html_url":"https://github.com/anonymouse64","followers_url":"https://api.github.com/users/anonymouse64/followers","following_url":"https://api.github.com/users/anonymouse64/following{/other_user}","gists_url":"https://api.github.com/users/anonymouse64/gists{/gist_id}","starred_url":"https://api.github.com/users/anonymouse64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anonymouse64/subscriptions","organizations_url":"https://api.github.com/users/anonymouse64/orgs","repos_url":"https://api.github.com/users/anonymouse64/repos","events_url":"https://api.github.com/users/anonymouse64/events{/privacy}","received_events_url":"https://api.github.com/users/anonymouse64/received_events","type":"User","site_admin":false},"repo":{"id":131676874,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2NzY4NzQ=","name":"snapd","full_name":"anonymouse64/snapd","private":false,"owner":{"login":"anonymouse64","id":6006573,"node_id":"MDQ6VXNlcjYwMDY1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6006573?v=4","gravatar_id":"","url":"https://api.github.com/users/anonymouse64","html_url":"https://github.com/anonymouse64","followers_url":"https://api.github.com/users/anonymouse64/followers","following_url":"https://api.github.com/users/anonymouse64/following{/other_user}","gists_url":"https://api.github.com/users/anonymouse64/gists{/gist_id}","starred_url":"https://api.github.com/users/anonymouse64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anonymouse64/subscriptions","organizations_url":"https://api.github.com/users/anonymouse64/orgs","repos_url":"https://api.github.com/users/anonymouse64/repos","events_url":"https://api.github.com/users/anonymouse64/events{/privacy}","received_events_url":"https://api.github.com/users/anonymouse64/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anonymouse64/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/anonymouse64/snapd","forks_url":"https://api.github.com/repos/anonymouse64/snapd/forks","keys_url":"https://api.github.com/repos/anonymouse64/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anonymouse64/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anonymouse64/snapd/teams","hooks_url":"https://api.github.com/repos/anonymouse64/snapd/hooks","issue_events_url":"https://api.github.com/repos/anonymouse64/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/anonymouse64/snapd/events","assignees_url":"https://api.github.com/repos/anonymouse64/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/anonymouse64/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/anonymouse64/snapd/tags","blobs_url":"https://api.github.com/repos/anonymouse64/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anonymouse64/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anonymouse64/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/anonymouse64/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anonymouse64/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/anonymouse64/snapd/languages","stargazers_url":"https://api.github.com/repos/anonymouse64/snapd/stargazers","contributors_url":"https://api.github.com/repos/anonymouse64/snapd/contributors","subscribers_url":"https://api.github.com/repos/anonymouse64/snapd/subscribers","subscription_url":"https://api.github.com/repos/anonymouse64/snapd/subscription","commits_url":"https://api.github.com/repos/anonymouse64/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/anonymouse64/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/anonymouse64/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/anonymouse64/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/anonymouse64/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/anonymouse64/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anonymouse64/snapd/merges","archive_url":"https://api.github.com/repos/anonymouse64/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anonymouse64/snapd/downloads","issues_url":"https://api.github.com/repos/anonymouse64/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/anonymouse64/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/anonymouse64/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/anonymouse64/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anonymouse64/snapd/labels{/name}","releases_url":"https://api.github.com/repos/anonymouse64/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/anonymouse64/snapd/deployments","created_at":"2018-05-01T04:38:39Z","updated_at":"2019-02-15T12:14:48Z","pushed_at":"2020-01-13T20:42:17Z","git_url":"git://github.com/anonymouse64/snapd.git","ssh_url":"git@github.com:anonymouse64/snapd.git","clone_url":"https://github.com/anonymouse64/snapd.git","svn_url":"https://github.com/anonymouse64/snapd","homepage":"","size":90901,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"0c3c751a9e2e40dd4bfe778a821f9c23b575d1b8","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2020-01-13T15:01:46Z","pushed_at":"2020-01-13T20:40:18Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":90868,"stargazers_count":1245,"watchers_count":1245,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":325,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":58,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":325,"open_issues":58,"watchers":1245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/7947"},"html":{"href":"https://github.com/snapcore/snapd/pull/7947"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/7947"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/7947/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/7947/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/7947/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/041696f073842495b2341f40baa1701d412f57d3"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":21,"maintainer_can_modify":false,"commits":3,"additions":99,"deletions":36,"changed_files":6}}
other: {"actor":{"display_login":"anonymouse64"}}