payload: {"action":"created","issue":{"url":"https://api.github.com/repos/s3inlc/hashtopolis/issues/568","repository_url":"https://api.github.com/repos/s3inlc/hashtopolis","labels_url":"https://api.github.com/repos/s3inlc/hashtopolis/issues/568/labels{/name}","comments_url":"https://api.github.com/repos/s3inlc/hashtopolis/issues/568/comments","events_url":"https://api.github.com/repos/s3inlc/hashtopolis/issues/568/events","html_url":"https://github.com/s3inlc/hashtopolis/pull/568","id":472623952,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwOTUwODcx","number":568,"title":"Mask API keys for other users with config setting","user":{"login":"noncenz","id":33376717,"node_id":"MDQ6VXNlcjMzMzc2NzE3","avatar_url":"https://avatars3.githubusercontent.com/u/33376717?v=4","gravatar_id":"","url":"https://api.github.com/users/noncenz","html_url":"https://github.com/noncenz","followers_url":"https://api.github.com/users/noncenz/followers","following_url":"https://api.github.com/users/noncenz/following{/other_user}","gists_url":"https://api.github.com/users/noncenz/gists{/gist_id}","starred_url":"https://api.github.com/users/noncenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noncenz/subscriptions","organizations_url":"https://api.github.com/users/noncenz/orgs","repos_url":"https://api.github.com/users/noncenz/repos","events_url":"https://api.github.com/users/noncenz/events{/privacy}","received_events_url":"https://api.github.com/users/noncenz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-25T01:42:17Z","updated_at":"2019-07-31T00:58:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/s3inlc/hashtopolis/pulls/568","html_url":"https://github.com/s3inlc/hashtopolis/pull/568","diff_url":"https://github.com/s3inlc/hashtopolis/pull/568.diff","patch_url":"https://github.com/s3inlc/hashtopolis/pull/568.patch"},"body":"Addressing enhancement #565 this change masks viewing of other user's API keys by administrators. This change also prevents reassignment of API keys between users. \r\n\r\nSet `$MASK_API_KEYS = true` in conf.php to activate the feature."},"comment":{"url":"https://api.github.com/repos/s3inlc/hashtopolis/issues/comments/516650908","html_url":"https://github.com/s3inlc/hashtopolis/pull/568#issuecomment-516650908","issue_url":"https://api.github.com/repos/s3inlc/hashtopolis/issues/568","id":516650908,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNjY1MDkwOA==","user":{"login":"noncenz","id":33376717,"node_id":"MDQ6VXNlcjMzMzc2NzE3","avatar_url":"https://avatars3.githubusercontent.com/u/33376717?v=4","gravatar_id":"","url":"https://api.github.com/users/noncenz","html_url":"https://github.com/noncenz","followers_url":"https://api.github.com/users/noncenz/followers","following_url":"https://api.github.com/users/noncenz/following{/other_user}","gists_url":"https://api.github.com/users/noncenz/gists{/gist_id}","starred_url":"https://api.github.com/users/noncenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noncenz/subscriptions","organizations_url":"https://api.github.com/users/noncenz/orgs","repos_url":"https://api.github.com/users/noncenz/repos","events_url":"https://api.github.com/users/noncenz/events{/privacy}","received_events_url":"https://api.github.com/users/noncenz/received_events","type":"User","site_admin":false},"created_at":"2019-07-31T00:58:24Z","updated_at":"2019-07-31T00:58:24Z","author_association":"NONE","body":"Hi Sien, I think I'll need a little more guidance on this - I read the enhancement as the app instance having multiple admins and we don't want admins to see each other's API keys. \r\n\r\n- We can't expose the config setting to Admins through the GUI as they could just turn it off. Would it the best to add it to the database and just not map to the UI, or maybe use an include file other than conf.php?\r\n\r\n- I had assumed all users were admins in this case and they would see their own keys through the API Management screen; an oversight on my part. Regular users will need to see keys without exposing them to an admin. Should we list them out under My Account > Settings? Or perhaps admins can see all user keys but other admin keys are masked?\r\n"}}
other: {"actor":{"display_login":"noncenz"}}