payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments/257017303","pull_request_review_id":203976042,"id":257017303,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzAxNzMwMw==","diff_hunk":"@@ -0,0 +1,45 @@\n+package datadog.trace.instrumentation.reactor.core;\n+\n+import datadog.trace.context.TraceScope;\n+import io.opentracing.Scope;\n+import io.opentracing.Span;\n+import io.opentracing.util.GlobalTracer;\n+import net.bytebuddy.asm.Advice;\n+import reactor.core.CoreSubscriber;\n+\n+/**\n+ * Instruments Flux#subscribe(CoreSubscriber) and Mono#subscribe(CoreSubscriber). It looks like Mono\n+ * and Flux implementations tend to do a lot of interesting work on subscription.","path":"dd-java-agent/instrumentation/reactor-core-3.1/src/main/java8/datadog/trace/instrumentation/reactor/core/FluxAndMonoSubscribeAdvice.java","position":12,"original_position":12,"commit_id":"bda312201f81f8754b0a38e27fd8d69334091e52","original_commit_id":"bda312201f81f8754b0a38e27fd8d69334091e52","user":{"login":"tylerbenson","id":734411,"node_id":"MDQ6VXNlcjczNDQxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/734411?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerbenson","html_url":"https://github.com/tylerbenson","followers_url":"https://api.github.com/users/tylerbenson/followers","following_url":"https://api.github.com/users/tylerbenson/following{/other_user}","gists_url":"https://api.github.com/users/tylerbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbenson/subscriptions","organizations_url":"https://api.github.com/users/tylerbenson/orgs","repos_url":"https://api.github.com/users/tylerbenson/repos","events_url":"https://api.github.com/users/tylerbenson/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbenson/received_events","type":"User","site_admin":false},"body":"Did you consider instrumenting the underlying executors used by reactor instead?","created_at":"2019-02-14T21:22:55Z","updated_at":"2019-02-14T21:36:16Z","html_url":"https://github.com/DataDog/dd-trace-java/pull/706#discussion_r257017303","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments/257017303"},"html":{"href":"https://github.com/DataDog/dd-trace-java/pull/706#discussion_r257017303"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706","id":252369523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyMzY5NTIz","html_url":"https://github.com/DataDog/dd-trace-java/pull/706","diff_url":"https://github.com/DataDog/dd-trace-java/pull/706.diff","patch_url":"https://github.com/DataDog/dd-trace-java/pull/706.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/706","number":706,"state":"open","locked":false,"title":"Improve webflux instrumentation","user":{"login":"mar-kolya","id":1003102,"node_id":"MDQ6VXNlcjEwMDMxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1003102?v=4","gravatar_id":"","url":"https://api.github.com/users/mar-kolya","html_url":"https://github.com/mar-kolya","followers_url":"https://api.github.com/users/mar-kolya/followers","following_url":"https://api.github.com/users/mar-kolya/following{/other_user}","gists_url":"https://api.github.com/users/mar-kolya/gists{/gist_id}","starred_url":"https://api.github.com/users/mar-kolya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mar-kolya/subscriptions","organizations_url":"https://api.github.com/users/mar-kolya/orgs","repos_url":"https://api.github.com/users/mar-kolya/repos","events_url":"https://api.github.com/users/mar-kolya/events{/privacy}","received_events_url":"https://api.github.com/users/mar-kolya/received_events","type":"User","site_admin":false},"body":"Add instrumentation for reactor core to propagate spans through `Mono`/`Flux` execution.\r\nAlso improve Spring Webflux instrumentation to use this functionality.","created_at":"2019-02-12T15:53:44Z","updated_at":"2019-02-14T21:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c3ec749adf36b2f00615fb8d98eed3e0d9f3d4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":663630239,"node_id":"MDU6TGFiZWw2NjM2MzAyMzk=","url":"https://api.github.com/repos/DataDog/dd-trace-java/labels/integrations","name":"integrations","color":"c2e0c6","default":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones/37","html_url":"https://github.com/DataDog/dd-trace-java/milestone/37","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones/37/labels","id":4048732,"node_id":"MDk6TWlsZXN0b25lNDA0ODczMg==","number":37,"title":"0.24.0","description":"","creator":{"login":"tylerbenson","id":734411,"node_id":"MDQ6VXNlcjczNDQxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/734411?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerbenson","html_url":"https://github.com/tylerbenson","followers_url":"https://api.github.com/users/tylerbenson/followers","following_url":"https://api.github.com/users/tylerbenson/following{/other_user}","gists_url":"https://api.github.com/users/tylerbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbenson/subscriptions","organizations_url":"https://api.github.com/users/tylerbenson/orgs","repos_url":"https://api.github.com/users/tylerbenson/repos","events_url":"https://api.github.com/users/tylerbenson/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbenson/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2019-02-11T19:33:57Z","updated_at":"2019-02-13T18:22:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/706/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/bda312201f81f8754b0a38e27fd8d69334091e52","head":{"label":"DataDog:mar-kolya/webflux-fixes","ref":"mar-kolya/webflux-fixes","sha":"bda312201f81f8754b0a38e27fd8d69334091e52","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":89221572,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyMTU3Mg==","name":"dd-trace-java","full_name":"DataDog/dd-trace-java","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-java","description":"Datadog APM client for Java","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-java","forks_url":"https://api.github.com/repos/DataDog/dd-trace-java/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-java/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-java/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-java/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-java/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-java/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-java/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-java/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-java/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-java/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-java/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-java/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-java/deployments","created_at":"2017-04-24T09:24:40Z","updated_at":"2019-02-14T15:44:51Z","pushed_at":"2019-02-14T16:45:15Z","git_url":"git://github.com/DataDog/dd-trace-java.git","ssh_url":"git@github.com:DataDog/dd-trace-java.git","clone_url":"https://github.com/DataDog/dd-trace-java.git","svn_url":"https://github.com/DataDog/dd-trace-java","homepage":"https://docs.datadoghq.com/tracing/languages/java","size":124060,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":33,"watchers":75,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"5bc3ec82c2adf2e7a7254d046fc9b725a4370621","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":89221572,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyMTU3Mg==","name":"dd-trace-java","full_name":"DataDog/dd-trace-java","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-java","description":"Datadog APM client for Java","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-java","forks_url":"https://api.github.com/repos/DataDog/dd-trace-java/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-java/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-java/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-java/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-java/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-java/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-java/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-java/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-java/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-java/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-java/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-java/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-java/deployments","created_at":"2017-04-24T09:24:40Z","updated_at":"2019-02-14T15:44:51Z","pushed_at":"2019-02-14T16:45:15Z","git_url":"git://github.com/DataDog/dd-trace-java.git","ssh_url":"git@github.com:DataDog/dd-trace-java.git","clone_url":"https://github.com/DataDog/dd-trace-java.git","svn_url":"https://github.com/DataDog/dd-trace-java","homepage":"https://docs.datadoghq.com/tracing/languages/java","size":124060,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":33,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706"},"html":{"href":"https://github.com/DataDog/dd-trace-java/pull/706"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/issues/706"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/bda312201f81f8754b0a38e27fd8d69334091e52"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"tylerbenson"}}