payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/detect-secrets/pulls/comments/339819736","pull_request_review_id":308183334,"id":339819736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTgxOTczNg==","diff_hunk":"@@ -43,14 +43,16 @@ def verify(self, token, content):\n \n def get_secret_access_keys(content):\n     # AWS secret access keys are 40 characters long.\n+    # e.g. some_function('AKIA...', '[secret key]')","path":"detect_secrets/plugins/aws.py","position":4,"original_position":4,"commit_id":"570b41b2ec623a9974fc708d7fdfe419f27be028","original_commit_id":"570b41b2ec623a9974fc708d7fdfe419f27be028","user":{"login":"KevinHock","id":3076393,"node_id":"MDQ6VXNlcjMwNzYzOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3076393?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinHock","html_url":"https://github.com/KevinHock","followers_url":"https://api.github.com/users/KevinHock/followers","following_url":"https://api.github.com/users/KevinHock/following{/other_user}","gists_url":"https://api.github.com/users/KevinHock/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinHock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinHock/subscriptions","organizations_url":"https://api.github.com/users/KevinHock/orgs","repos_url":"https://api.github.com/users/KevinHock/repos","events_url":"https://api.github.com/users/KevinHock/events{/privacy}","received_events_url":"https://api.github.com/users/KevinHock/received_events","type":"User","site_admin":false},"body":"Sure, before we were only looking for secret keys in assignments, whereas this adds looking for them as function arguments too. The test cases I added might shed light on this.","created_at":"2019-10-28T22:22:40Z","updated_at":"2019-10-28T22:22:40Z","html_url":"https://github.com/Yelp/detect-secrets/pull/255#discussion_r339819736","pull_request_url":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Yelp/detect-secrets/pulls/comments/339819736"},"html":{"href":"https://github.com/Yelp/detect-secrets/pull/255#discussion_r339819736"},"pull_request":{"href":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255"}},"in_reply_to_id":339081976},"pull_request":{"url":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255","id":329932434,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5OTMyNDM0","html_url":"https://github.com/Yelp/detect-secrets/pull/255","diff_url":"https://github.com/Yelp/detect-secrets/pull/255.diff","patch_url":"https://github.com/Yelp/detect-secrets/pull/255.patch","issue_url":"https://api.github.com/repos/Yelp/detect-secrets/issues/255","number":255,"state":"open","locked":false,"title":"Bring-your own-plugins (BYOP), via --custom-plugins option","user":{"login":"KevinHock","id":3076393,"node_id":"MDQ6VXNlcjMwNzYzOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3076393?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinHock","html_url":"https://github.com/KevinHock","followers_url":"https://api.github.com/users/KevinHock/followers","following_url":"https://api.github.com/users/KevinHock/following{/other_user}","gists_url":"https://api.github.com/users/KevinHock/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinHock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinHock/subscriptions","organizations_url":"https://api.github.com/users/KevinHock/orgs","repos_url":"https://api.github.com/users/KevinHock/repos","events_url":"https://api.github.com/users/KevinHock/events{/privacy}","received_events_url":"https://api.github.com/users/KevinHock/received_events","type":"User","site_admin":false},"body":"In case you wanted to make e.g. a new entropy plugin with different metacharacters, or a new keyword type detector, or a company-specific plugin, or use it/tune it privately before merging upstream.\r\n\r\nTo be used like so: `detect-secrets scan  --custom-plugins custom_plugins/ test_data/each_secret.py`\r\n\r\nWe had a \"[truffleHog](https://github.com/dxa4481/truffleHog) vs. [metasploit](https://github.com/rapid7/metasploit-framework)\"  discussion internally. With the former, you can e.g. edit a config file with regexes in it like [`shhgit`](https://github.com/eth0izzle/shhgit/blob/master/config.yaml), with the latter you write your own modules.\r\n\r\nMain reasons why this seems like a better fit for `detect-secrets`\r\n- More general purpose\r\n- We would still need verification functions written in Python if we put all our regexes in a config\r\n- This encourages writing tests","created_at":"2019-10-18T21:35:59Z","updated_at":"2019-10-28T22:22:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e358e92c9cc45ba81ceba68a0d77d12113a254","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1280806963,"node_id":"MDU6TGFiZWwxMjgwODA2OTYz","url":"https://api.github.com/repos/Yelp/detect-secrets/labels/accuracy","name":"accuracy","color":"a7f9b3","default":false},{"id":769575570,"node_id":"MDU6TGFiZWw3Njk1NzU1NzA=","url":"https://api.github.com/repos/Yelp/detect-secrets/labels/bug","name":"bug","color":"ee0701","default":true},{"id":1363372921,"node_id":"MDU6TGFiZWwxMzYzMzcyOTIx","url":"https://api.github.com/repos/Yelp/detect-secrets/labels/feature","name":"feature","color":"dd8bdd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255/commits","review_comments_url":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255/comments","review_comment_url":"https://api.github.com/repos/Yelp/detect-secrets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/detect-secrets/issues/255/comments","statuses_url":"https://api.github.com/repos/Yelp/detect-secrets/statuses/570b41b2ec623a9974fc708d7fdfe419f27be028","head":{"label":"Yelp:byop_feature","ref":"byop_feature","sha":"570b41b2ec623a9974fc708d7fdfe419f27be028","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":113111650,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMTE2NTA=","name":"detect-secrets","full_name":"Yelp/detect-secrets","private":false,"owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yelp/detect-secrets","description":"An enterprise friendly way of detecting and preventing secrets in code.","fork":false,"url":"https://api.github.com/repos/Yelp/detect-secrets","forks_url":"https://api.github.com/repos/Yelp/detect-secrets/forks","keys_url":"https://api.github.com/repos/Yelp/detect-secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/detect-secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/detect-secrets/teams","hooks_url":"https://api.github.com/repos/Yelp/detect-secrets/hooks","issue_events_url":"https://api.github.com/repos/Yelp/detect-secrets/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/detect-secrets/events","assignees_url":"https://api.github.com/repos/Yelp/detect-secrets/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/detect-secrets/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/detect-secrets/tags","blobs_url":"https://api.github.com/repos/Yelp/detect-secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/detect-secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/detect-secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/detect-secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/detect-secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/detect-secrets/languages","stargazers_url":"https://api.github.com/repos/Yelp/detect-secrets/stargazers","contributors_url":"https://api.github.com/repos/Yelp/detect-secrets/contributors","subscribers_url":"https://api.github.com/repos/Yelp/detect-secrets/subscribers","subscription_url":"https://api.github.com/repos/Yelp/detect-secrets/subscription","commits_url":"https://api.github.com/repos/Yelp/detect-secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/detect-secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/detect-secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/detect-secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/detect-secrets/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/detect-secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/detect-secrets/merges","archive_url":"https://api.github.com/repos/Yelp/detect-secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/detect-secrets/downloads","issues_url":"https://api.github.com/repos/Yelp/detect-secrets/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/detect-secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/detect-secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/detect-secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/detect-secrets/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/detect-secrets/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/detect-secrets/deployments","created_at":"2017-12-05T00:38:38Z","updated_at":"2019-10-28T21:42:43Z","pushed_at":"2019-10-28T21:42:51Z","git_url":"git://github.com/Yelp/detect-secrets.git","ssh_url":"git@github.com:Yelp/detect-secrets.git","clone_url":"https://github.com/Yelp/detect-secrets.git","svn_url":"https://github.com/Yelp/detect-secrets","homepage":"","size":961,"stargazers_count":979,"watchers_count":979,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":90,"open_issues":37,"watchers":979,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"5706eb1076ca286b4357ba34fac33d6df672f0bc","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":113111650,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMTE2NTA=","name":"detect-secrets","full_name":"Yelp/detect-secrets","private":false,"owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yelp/detect-secrets","description":"An enterprise friendly way of detecting and preventing secrets in code.","fork":false,"url":"https://api.github.com/repos/Yelp/detect-secrets","forks_url":"https://api.github.com/repos/Yelp/detect-secrets/forks","keys_url":"https://api.github.com/repos/Yelp/detect-secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/detect-secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/detect-secrets/teams","hooks_url":"https://api.github.com/repos/Yelp/detect-secrets/hooks","issue_events_url":"https://api.github.com/repos/Yelp/detect-secrets/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/detect-secrets/events","assignees_url":"https://api.github.com/repos/Yelp/detect-secrets/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/detect-secrets/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/detect-secrets/tags","blobs_url":"https://api.github.com/repos/Yelp/detect-secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/detect-secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/detect-secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/detect-secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/detect-secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/detect-secrets/languages","stargazers_url":"https://api.github.com/repos/Yelp/detect-secrets/stargazers","contributors_url":"https://api.github.com/repos/Yelp/detect-secrets/contributors","subscribers_url":"https://api.github.com/repos/Yelp/detect-secrets/subscribers","subscription_url":"https://api.github.com/repos/Yelp/detect-secrets/subscription","commits_url":"https://api.github.com/repos/Yelp/detect-secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/detect-secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/detect-secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/detect-secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/detect-secrets/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/detect-secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/detect-secrets/merges","archive_url":"https://api.github.com/repos/Yelp/detect-secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/detect-secrets/downloads","issues_url":"https://api.github.com/repos/Yelp/detect-secrets/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/detect-secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/detect-secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/detect-secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/detect-secrets/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/detect-secrets/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/detect-secrets/deployments","created_at":"2017-12-05T00:38:38Z","updated_at":"2019-10-28T21:42:43Z","pushed_at":"2019-10-28T21:42:51Z","git_url":"git://github.com/Yelp/detect-secrets.git","ssh_url":"git@github.com:Yelp/detect-secrets.git","clone_url":"https://github.com/Yelp/detect-secrets.git","svn_url":"https://github.com/Yelp/detect-secrets","homepage":"","size":961,"stargazers_count":979,"watchers_count":979,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":90,"open_issues":37,"watchers":979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255"},"html":{"href":"https://github.com/Yelp/detect-secrets/pull/255"},"issue":{"href":"https://api.github.com/repos/Yelp/detect-secrets/issues/255"},"comments":{"href":"https://api.github.com/repos/Yelp/detect-secrets/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/detect-secrets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/detect-secrets/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/detect-secrets/statuses/570b41b2ec623a9974fc708d7fdfe419f27be028"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"KevinHock"}}