payload: {"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments/343616139","pull_request_review_id":313286607,"id":343616139,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzYxNjEzOQ==","diff_hunk":"@@ -90,6 +90,8 @@ unsafe fn cache_methods(env: &JNIEnv) {\n         \"getErrorCode\",\n         \"()B\",\n     );\n+    RUNTIME_ADAPTER_INITIALIZE =","path":"exonum-java-binding/core/rust/src/utils/jni_cache.rs","position":23,"original_position":23,"commit_id":"0d6bd2a1cbd0ecccb287f2b6047c10536cd4e9f1","original_commit_id":"0d6bd2a1cbd0ecccb287f2b6047c10536cd4e9f1","user":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"body":"Just in case: there is no measurable performance benefit in caching infrequently called methods; so it is not required. But maybe for consistency and clearer code organization it still makes sense.","created_at":"2019-11-07T12:06:31Z","updated_at":"2019-11-07T12:09:00Z","html_url":"https://github.com/exonum/exonum-java-binding/pull/1218#discussion_r343616139","pull_request_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments/343616139"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/1218#discussion_r343616139"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218","id":337889073,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3ODg5MDcz","html_url":"https://github.com/exonum/exonum-java-binding/pull/1218","diff_url":"https://github.com/exonum/exonum-java-binding/pull/1218.diff","patch_url":"https://github.com/exonum/exonum-java-binding/pull/1218.patch","issue_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/1218","number":1218,"state":"open","locked":false,"title":"Update to Exonum revision 2bbea6654 [ECR-3804]","user":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nUpdated native code to revision `2bbea6654` of Core.\r\n\r\n---\r\nSee: https://jira.bf.local/browse/ECR-3804\r\n\r\n### Definition of Done\r\n\r\n- [ ] There are no TODOs left in the code\r\n- [ ] Change is covered by automated [tests](https://github.com/exonum/exonum-java-binding/blob/master/CONTRIBUTING.md#tests)\r\n- [ ] The [coding guidelines](https://github.com/exonum/exonum-java-binding/blob/master/CONTRIBUTING.md#the-code-style) are followed\r\n- [ ] Public API has Javadoc\r\n- [ ] Method preconditions are checked and documented in the Javadoc of the method\r\n- [ ] Changelog is updated if needed (in case of notable or breaking changes)\r\n- [ ] The continuous integration build passes\r\n","created_at":"2019-11-07T07:07:35Z","updated_at":"2019-11-07T12:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93c84d0beaf38d349ad7f8e1d01c1b86cabb4b3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"skletsun","id":195867,"node_id":"MDQ6VXNlcjE5NTg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/195867?v=4","gravatar_id":"","url":"https://api.github.com/users/skletsun","html_url":"https://github.com/skletsun","followers_url":"https://api.github.com/users/skletsun/followers","following_url":"https://api.github.com/users/skletsun/following{/other_user}","gists_url":"https://api.github.com/users/skletsun/gists{/gist_id}","starred_url":"https://api.github.com/users/skletsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skletsun/subscriptions","organizations_url":"https://api.github.com/users/skletsun/orgs","repos_url":"https://api.github.com/users/skletsun/repos","events_url":"https://api.github.com/users/skletsun/events{/privacy}","received_events_url":"https://api.github.com/users/skletsun/received_events","type":"User","site_admin":false},{"login":"ipenkin","id":37984794,"node_id":"MDQ6VXNlcjM3OTg0Nzk0","avatar_url":"https://avatars1.githubusercontent.com/u/37984794?v=4","gravatar_id":"","url":"https://api.github.com/users/ipenkin","html_url":"https://github.com/ipenkin","followers_url":"https://api.github.com/users/ipenkin/followers","following_url":"https://api.github.com/users/ipenkin/following{/other_user}","gists_url":"https://api.github.com/users/ipenkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ipenkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipenkin/subscriptions","organizations_url":"https://api.github.com/users/ipenkin/orgs","repos_url":"https://api.github.com/users/ipenkin/repos","events_url":"https://api.github.com/users/ipenkin/events{/privacy}","received_events_url":"https://api.github.com/users/ipenkin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/1218/comments","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/0d6bd2a1cbd0ecccb287f2b6047c10536cd4e9f1","head":{"label":"vitvakatu:ecr-3804-update-exonum","ref":"ecr-3804-update-exonum","sha":"0d6bd2a1cbd0ecccb287f2b6047c10536cd4e9f1","user":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"repo":{"id":137995778,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5OTU3Nzg=","name":"exonum-java-binding","full_name":"vitvakatu/exonum-java-binding","private":false,"owner":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vitvakatu/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":true,"url":"https://api.github.com/repos/vitvakatu/exonum-java-binding","forks_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/vitvakatu/exonum-java-binding/deployments","created_at":"2018-06-20T07:27:21Z","updated_at":"2019-07-12T08:37:23Z","pushed_at":"2019-11-07T09:23:38Z","git_url":"git://github.com/vitvakatu/exonum-java-binding.git","ssh_url":"git@github.com:vitvakatu/exonum-java-binding.git","clone_url":"https://github.com/vitvakatu/exonum-java-binding.git","svn_url":"https://github.com/vitvakatu/exonum-java-binding","homepage":"http://exonum.com","size":6162,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"4349999ca1c2281cc5c700707bce82be0ac9ee9e","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":92375988,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM3NTk4OA==","name":"exonum-java-binding","full_name":"exonum/exonum-java-binding","private":false,"owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exonum/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":false,"url":"https://api.github.com/repos/exonum/exonum-java-binding","forks_url":"https://api.github.com/repos/exonum/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/exonum/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/exonum/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/exonum/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/exonum/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum-java-binding/deployments","created_at":"2017-05-25T07:12:56Z","updated_at":"2019-11-06T15:58:41Z","pushed_at":"2019-11-07T09:23:39Z","git_url":"git://github.com/exonum/exonum-java-binding.git","ssh_url":"git@github.com:exonum/exonum-java-binding.git","clone_url":"https://github.com/exonum/exonum-java-binding.git","svn_url":"https://github.com/exonum/exonum-java-binding","homepage":"https://exonum.com","size":6073,"stargazers_count":54,"watchers_count":54,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":20,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/1218"},"issue":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/1218"},"comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/0d6bd2a1cbd0ecccb287f2b6047c10536cd4e9f1"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"dmitry-timofeev"}}