payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/288690168","pull_request_review_id":243417895,"id":288690168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODY5MDE2OA==","diff_hunk":"@@ -19,3 +19,12 @@ DependencyInjection\n      my_service:\n        factory: ['@factory_service', method]\n    ```\n+\n+HttpKernel\n+----------\n+\n+* The method `FilterControllerArgumentsEvent::getArguments()` marked final.","path":"UPGRADE-4.4.md","position":8,"original_position":8,"commit_id":"64a2ee011755c00314aebf6f57d384616a57802c","original_commit_id":"64a2ee011755c00314aebf6f57d384616a57802c","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"missing verb: has been","created_at":"2019-05-29T17:45:11Z","updated_at":"2019-05-29T17:45:12Z","html_url":"https://github.com/symfony/symfony/pull/31701#discussion_r288690168","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/31701","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/288690168"},"html":{"href":"https://github.com/symfony/symfony/pull/31701#discussion_r288690168"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/31701"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/31701","id":283359093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMzU5MDkz","html_url":"https://github.com/symfony/symfony/pull/31701","diff_url":"https://github.com/symfony/symfony/pull/31701.diff","patch_url":"https://github.com/symfony/symfony/pull/31701.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/31701","number":31701,"state":"open","locked":false,"title":"[HttpKernel] The methods of the deprecated event should be final","user":{"login":"Simperfit","id":3451634,"node_id":"MDQ6VXNlcjM0NTE2MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3451634?v=4","gravatar_id":"","url":"https://api.github.com/users/Simperfit","html_url":"https://github.com/Simperfit","followers_url":"https://api.github.com/users/Simperfit/followers","following_url":"https://api.github.com/users/Simperfit/following{/other_user}","gists_url":"https://api.github.com/users/Simperfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Simperfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simperfit/subscriptions","organizations_url":"https://api.github.com/users/Simperfit/orgs","repos_url":"https://api.github.com/users/Simperfit/repos","events_url":"https://api.github.com/users/Simperfit/events{/privacy}","received_events_url":"https://api.github.com/users/Simperfit/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 4.4\r\n| Bug fix?      | no\r\n| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->\r\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->\r\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\r\n| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->\r\n| License       | MIT\r\n| Doc PR        | none <!-- required for new features -->\r\n\r\n<!--\r\nReplace this notice by a short README for your feature/bugfix. This will help people\r\nunderstand your PR and can be used as a start for the documentation.\r\n\r\nAdditionally (see https://symfony.com/roadmap):\r\n - Bug fixes must be submitted against the lowest maintained branch where they apply\r\n   (lowest branches are regularly merged to upper ones so they get the fixes too).\r\n - Features and deprecations must be submitted against the master branch.\r\n-->\r\n\r\n\r\nThis PRs allows to change the return types in 5.0 of the differents methods of the deprecated events class.\r\n\r\nAs said in https://github.com/symfony/symfony/pull/31672#discussion_r288480871","created_at":"2019-05-29T17:23:15Z","updated_at":"2019-05-29T17:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5602ca885198534ffd839c2f6eae9156542e87a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":131507,"node_id":"MDU6TGFiZWwxMzE1MDc=","url":"https://api.github.com/repos/symfony/symfony/labels/HttpKernel","name":"HttpKernel","color":"DDDDDD","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/31701/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/31701/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/31701/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/64a2ee011755c00314aebf6f57d384616a57802c","head":{"label":"Simperfit:made-final-to-prepare-the-cleaning-in-http-kernel","ref":"made-final-to-prepare-the-cleaning-in-http-kernel","sha":"64a2ee011755c00314aebf6f57d384616a57802c","user":{"login":"Simperfit","id":3451634,"node_id":"MDQ6VXNlcjM0NTE2MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3451634?v=4","gravatar_id":"","url":"https://api.github.com/users/Simperfit","html_url":"https://github.com/Simperfit","followers_url":"https://api.github.com/users/Simperfit/followers","following_url":"https://api.github.com/users/Simperfit/following{/other_user}","gists_url":"https://api.github.com/users/Simperfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Simperfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simperfit/subscriptions","organizations_url":"https://api.github.com/users/Simperfit/orgs","repos_url":"https://api.github.com/users/Simperfit/repos","events_url":"https://api.github.com/users/Simperfit/events{/privacy}","received_events_url":"https://api.github.com/users/Simperfit/received_events","type":"User","site_admin":false},"repo":{"id":53192551,"node_id":"MDEwOlJlcG9zaXRvcnk1MzE5MjU1MQ==","name":"symfony","full_name":"Simperfit/symfony","private":false,"owner":{"login":"Simperfit","id":3451634,"node_id":"MDQ6VXNlcjM0NTE2MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3451634?v=4","gravatar_id":"","url":"https://api.github.com/users/Simperfit","html_url":"https://github.com/Simperfit","followers_url":"https://api.github.com/users/Simperfit/followers","following_url":"https://api.github.com/users/Simperfit/following{/other_user}","gists_url":"https://api.github.com/users/Simperfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Simperfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simperfit/subscriptions","organizations_url":"https://api.github.com/users/Simperfit/orgs","repos_url":"https://api.github.com/users/Simperfit/repos","events_url":"https://api.github.com/users/Simperfit/events{/privacy}","received_events_url":"https://api.github.com/users/Simperfit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Simperfit/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/Simperfit/symfony","forks_url":"https://api.github.com/repos/Simperfit/symfony/forks","keys_url":"https://api.github.com/repos/Simperfit/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Simperfit/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Simperfit/symfony/teams","hooks_url":"https://api.github.com/repos/Simperfit/symfony/hooks","issue_events_url":"https://api.github.com/repos/Simperfit/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Simperfit/symfony/events","assignees_url":"https://api.github.com/repos/Simperfit/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Simperfit/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Simperfit/symfony/tags","blobs_url":"https://api.github.com/repos/Simperfit/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Simperfit/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Simperfit/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Simperfit/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Simperfit/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Simperfit/symfony/languages","stargazers_url":"https://api.github.com/repos/Simperfit/symfony/stargazers","contributors_url":"https://api.github.com/repos/Simperfit/symfony/contributors","subscribers_url":"https://api.github.com/repos/Simperfit/symfony/subscribers","subscription_url":"https://api.github.com/repos/Simperfit/symfony/subscription","commits_url":"https://api.github.com/repos/Simperfit/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Simperfit/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Simperfit/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Simperfit/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Simperfit/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Simperfit/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Simperfit/symfony/merges","archive_url":"https://api.github.com/repos/Simperfit/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Simperfit/symfony/downloads","issues_url":"https://api.github.com/repos/Simperfit/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Simperfit/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Simperfit/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Simperfit/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Simperfit/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Simperfit/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Simperfit/symfony/deployments","created_at":"2016-03-05T08:55:40Z","updated_at":"2016-03-05T08:55:55Z","pushed_at":"2019-05-29T17:35:33Z","git_url":"git://github.com/Simperfit/symfony.git","ssh_url":"git@github.com:Simperfit/symfony.git","clone_url":"https://github.com/Simperfit/symfony.git","svn_url":"https://github.com/Simperfit/symfony","homepage":"symfony.com","size":132313,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:4.4","ref":"4.4","sha":"19811b88740c87534d95af1ed177075c2a5c01ce","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2019-05-29T17:11:00Z","pushed_at":"2019-05-29T17:37:23Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":137971,"stargazers_count":20826,"watchers_count":20826,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6916,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":844,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6916,"open_issues":844,"watchers":20826,"default_branch":"4.4"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/31701"},"html":{"href":"https://github.com/symfony/symfony/pull/31701"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/31701"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/31701/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/31701/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/31701/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/64a2ee011755c00314aebf6f57d384616a57802c"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"nicolas-grekas"}}