payload: {"action":"closed","number":309,"pull_request":{"url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/309","id":274742717,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NzQyNzE3","html_url":"https://github.com/mozilla-iam/dino-park-front-end/pull/309","diff_url":"https://github.com/mozilla-iam/dino-park-front-end/pull/309.diff","patch_url":"https://github.com/mozilla-iam/dino-park-front-end/pull/309.patch","issue_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues/309","number":309,"state":"closed","locked":false,"title":"Fix DP-1300","user":{"login":"hidde","id":178782,"node_id":"MDQ6VXNlcjE3ODc4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/178782?v=4","gravatar_id":"","url":"https://api.github.com/users/hidde","html_url":"https://github.com/hidde","followers_url":"https://api.github.com/users/hidde/followers","following_url":"https://api.github.com/users/hidde/following{/other_user}","gists_url":"https://api.github.com/users/hidde/gists{/gist_id}","starred_url":"https://api.github.com/users/hidde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hidde/subscriptions","organizations_url":"https://api.github.com/users/hidde/orgs","repos_url":"https://api.github.com/users/hidde/repos","events_url":"https://api.github.com/users/hidde/events{/privacy}","received_events_url":"https://api.github.com/users/hidde/received_events","type":"User","site_admin":false},"body":"We use `flex: 1` to make the element between header and footer span all leftover space. \r\n\r\nIt did not apply in profiles, because `vue-apollo`'s `ApolloQuery` component wraps itself in a div that does not have a container class. Therefore the thing with `.container` was no longer a direct child of the app.\r\n\r\nFixed by setting `container` class on each router view. This makes sense as whatever the router view is, we want it to have this behaviour.","created_at":"2019-04-30T13:57:57Z","updated_at":"2019-04-30T18:34:21Z","closed_at":"2019-04-30T18:34:21Z","merged_at":"2019-04-30T18:34:21Z","merge_commit_sha":"f78b1859166d82a0cf064d6539730228f6a997c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/309/commits","review_comments_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/309/comments","review_comment_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues/309/comments","statuses_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/statuses/d0cb70d1c5d32fb308bc9b426c534ddeabaf4f05","head":{"label":"hidde:make-footer-stick-always","ref":"make-footer-stick-always","sha":"d0cb70d1c5d32fb308bc9b426c534ddeabaf4f05","user":{"login":"hidde","id":178782,"node_id":"MDQ6VXNlcjE3ODc4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/178782?v=4","gravatar_id":"","url":"https://api.github.com/users/hidde","html_url":"https://github.com/hidde","followers_url":"https://api.github.com/users/hidde/followers","following_url":"https://api.github.com/users/hidde/following{/other_user}","gists_url":"https://api.github.com/users/hidde/gists{/gist_id}","starred_url":"https://api.github.com/users/hidde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hidde/subscriptions","organizations_url":"https://api.github.com/users/hidde/orgs","repos_url":"https://api.github.com/users/hidde/repos","events_url":"https://api.github.com/users/hidde/events{/privacy}","received_events_url":"https://api.github.com/users/hidde/received_events","type":"User","site_admin":false},"repo":{"id":144827318,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MjczMTg=","name":"dino-park-front-end","full_name":"hidde/dino-park-front-end","private":false,"owner":{"login":"hidde","id":178782,"node_id":"MDQ6VXNlcjE3ODc4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/178782?v=4","gravatar_id":"","url":"https://api.github.com/users/hidde","html_url":"https://github.com/hidde","followers_url":"https://api.github.com/users/hidde/followers","following_url":"https://api.github.com/users/hidde/following{/other_user}","gists_url":"https://api.github.com/users/hidde/gists{/gist_id}","starred_url":"https://api.github.com/users/hidde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hidde/subscriptions","organizations_url":"https://api.github.com/users/hidde/orgs","repos_url":"https://api.github.com/users/hidde/repos","events_url":"https://api.github.com/users/hidde/events{/privacy}","received_events_url":"https://api.github.com/users/hidde/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hidde/dino-park-front-end","description":"Front-end for Mozillians.org","fork":true,"url":"https://api.github.com/repos/hidde/dino-park-front-end","forks_url":"https://api.github.com/repos/hidde/dino-park-front-end/forks","keys_url":"https://api.github.com/repos/hidde/dino-park-front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hidde/dino-park-front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hidde/dino-park-front-end/teams","hooks_url":"https://api.github.com/repos/hidde/dino-park-front-end/hooks","issue_events_url":"https://api.github.com/repos/hidde/dino-park-front-end/issues/events{/number}","events_url":"https://api.github.com/repos/hidde/dino-park-front-end/events","assignees_url":"https://api.github.com/repos/hidde/dino-park-front-end/assignees{/user}","branches_url":"https://api.github.com/repos/hidde/dino-park-front-end/branches{/branch}","tags_url":"https://api.github.com/repos/hidde/dino-park-front-end/tags","blobs_url":"https://api.github.com/repos/hidde/dino-park-front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hidde/dino-park-front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hidde/dino-park-front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/hidde/dino-park-front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hidde/dino-park-front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/hidde/dino-park-front-end/languages","stargazers_url":"https://api.github.com/repos/hidde/dino-park-front-end/stargazers","contributors_url":"https://api.github.com/repos/hidde/dino-park-front-end/contributors","subscribers_url":"https://api.github.com/repos/hidde/dino-park-front-end/subscribers","subscription_url":"https://api.github.com/repos/hidde/dino-park-front-end/subscription","commits_url":"https://api.github.com/repos/hidde/dino-park-front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/hidde/dino-park-front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/hidde/dino-park-front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/hidde/dino-park-front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/hidde/dino-park-front-end/contents/{+path}","compare_url":"https://api.github.com/repos/hidde/dino-park-front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hidde/dino-park-front-end/merges","archive_url":"https://api.github.com/repos/hidde/dino-park-front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hidde/dino-park-front-end/downloads","issues_url":"https://api.github.com/repos/hidde/dino-park-front-end/issues{/number}","pulls_url":"https://api.github.com/repos/hidde/dino-park-front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/hidde/dino-park-front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/hidde/dino-park-front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hidde/dino-park-front-end/labels{/name}","releases_url":"https://api.github.com/repos/hidde/dino-park-front-end/releases{/id}","deployments_url":"https://api.github.com/repos/hidde/dino-park-front-end/deployments","created_at":"2018-08-15T08:31:46Z","updated_at":"2018-08-15T08:31:48Z","pushed_at":"2019-04-30T13:56:16Z","git_url":"git://github.com/hidde/dino-park-front-end.git","ssh_url":"git@github.com:hidde/dino-park-front-end.git","clone_url":"https://github.com/hidde/dino-park-front-end.git","svn_url":"https://github.com/hidde/dino-park-front-end","homepage":null,"size":5853,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-iam:master","ref":"master","sha":"8f2e1b7ffe2896e2e5fee698d0a62c86dc5dbf29","user":{"login":"mozilla-iam","id":22923188,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTIzMTg4","avatar_url":"https://avatars1.githubusercontent.com/u/22923188?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-iam","html_url":"https://github.com/mozilla-iam","followers_url":"https://api.github.com/users/mozilla-iam/followers","following_url":"https://api.github.com/users/mozilla-iam/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-iam/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-iam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-iam/subscriptions","organizations_url":"https://api.github.com/users/mozilla-iam/orgs","repos_url":"https://api.github.com/users/mozilla-iam/repos","events_url":"https://api.github.com/users/mozilla-iam/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-iam/received_events","type":"Organization","site_admin":false},"repo":{"id":141425073,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0MjUwNzM=","name":"dino-park-front-end","full_name":"mozilla-iam/dino-park-front-end","private":false,"owner":{"login":"mozilla-iam","id":22923188,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTIzMTg4","avatar_url":"https://avatars1.githubusercontent.com/u/22923188?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-iam","html_url":"https://github.com/mozilla-iam","followers_url":"https://api.github.com/users/mozilla-iam/followers","following_url":"https://api.github.com/users/mozilla-iam/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-iam/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-iam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-iam/subscriptions","organizations_url":"https://api.github.com/users/mozilla-iam/orgs","repos_url":"https://api.github.com/users/mozilla-iam/repos","events_url":"https://api.github.com/users/mozilla-iam/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-iam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-iam/dino-park-front-end","description":"Front-end for Mozillians.org","fork":false,"url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end","forks_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/forks","keys_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/teams","hooks_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/hooks","issue_events_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/events","assignees_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/tags","blobs_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/languages","stargazers_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/stargazers","contributors_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/contributors","subscribers_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/subscribers","subscription_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/subscription","commits_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/merges","archive_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/downloads","issues_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/deployments","created_at":"2018-07-18T11:22:51Z","updated_at":"2019-04-29T10:29:01Z","pushed_at":"2019-04-30T18:34:21Z","git_url":"git://github.com/mozilla-iam/dino-park-front-end.git","ssh_url":"git@github.com:mozilla-iam/dino-park-front-end.git","clone_url":"https://github.com/mozilla-iam/dino-park-front-end.git","svn_url":"https://github.com/mozilla-iam/dino-park-front-end","homepage":null,"size":5827,"stargazers_count":7,"watchers_count":7,"language":"Vue","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":10,"open_issues":17,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/309"},"html":{"href":"https://github.com/mozilla-iam/dino-park-front-end/pull/309"},"issue":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues/309"},"comments":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-iam/dino-park-front-end/statuses/d0cb70d1c5d32fb308bc9b426c534ddeabaf4f05"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fiji-flo","id":3604775,"node_id":"MDQ6VXNlcjM2MDQ3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3604775?v=4","gravatar_id":"","url":"https://api.github.com/users/fiji-flo","html_url":"https://github.com/fiji-flo","followers_url":"https://api.github.com/users/fiji-flo/followers","following_url":"https://api.github.com/users/fiji-flo/following{/other_user}","gists_url":"https://api.github.com/users/fiji-flo/gists{/gist_id}","starred_url":"https://api.github.com/users/fiji-flo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiji-flo/subscriptions","organizations_url":"https://api.github.com/users/fiji-flo/orgs","repos_url":"https://api.github.com/users/fiji-flo/repos","events_url":"https://api.github.com/users/fiji-flo/events{/privacy}","received_events_url":"https://api.github.com/users/fiji-flo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":10,"deletions":11,"changed_files":5}}
other: {"actor":{"display_login":"fiji-flo"}}