payload: {"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/10968","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/10968/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/10968/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/10968/events","html_url":"https://github.com/scipy/scipy/issues/10968","id":510614199,"node_id":"MDU6SXNzdWU1MTA2MTQxOTk=","number":10968,"title":"API: Change normalized=False to normalize=True in Rotation","user":{"login":"nmayorov","id":7074023,"node_id":"MDQ6VXNlcjcwNzQwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7074023?v=4","gravatar_id":"","url":"https://api.github.com/users/nmayorov","html_url":"https://github.com/nmayorov","followers_url":"https://api.github.com/users/nmayorov/followers","following_url":"https://api.github.com/users/nmayorov/following{/other_user}","gists_url":"https://api.github.com/users/nmayorov/gists{/gist_id}","starred_url":"https://api.github.com/users/nmayorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmayorov/subscriptions","organizations_url":"https://api.github.com/users/nmayorov/orgs","repos_url":"https://api.github.com/users/nmayorov/repos","events_url":"https://api.github.com/users/nmayorov/events{/privacy}","received_events_url":"https://api.github.com/users/nmayorov/received_events","type":"User","site_admin":false},"labels":[{"id":108549863,"node_id":"MDU6TGFiZWwxMDg1NDk4NjM=","url":"https://api.github.com/repos/scipy/scipy/labels/maintenance","name":"maintenance","color":"fef2c0","default":false},{"id":199201380,"node_id":"MDU6TGFiZWwxOTkyMDEzODA=","url":"https://api.github.com/repos/scipy/scipy/labels/needs-decision","name":"needs-decision","color":"fbca04","default":false},{"id":37345293,"node_id":"MDU6TGFiZWwzNzM0NTI5Mw==","url":"https://api.github.com/repos/scipy/scipy/labels/scipy.spatial","name":"scipy.spatial","color":"0366d6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-10-22T12:12:48Z","updated_at":"2019-11-12T11:15:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In `Rotation` we used keyword `normalized` to indicate that normalization of vectors/quaternions was done:\r\n\r\n`def __init__(self, quat, normalized=False, copy=True)` So if `normalized=False`, then normalization is required.\r\n\r\nI think it was an unfortunate choice and passing imperatives as `copy`, `normalize`, etc. is much more common, natural and easier to reason about. \r\n\r\nThere are two public methods with `normalized`: `from_quat` and `match_vectors`. The `__init__` might be considered as private.\r\n\r\nI think ideally we change that, but I'm not sure how to do it in a straightforward and safe way through a deprecation cycle.\r\n\r\nIs it worth it? If yes, how can we do it?\r\n\r\n@rgommers @matthew-brett @pmla "},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/552850185","html_url":"https://github.com/scipy/scipy/issues/10968#issuecomment-552850185","issue_url":"https://api.github.com/repos/scipy/scipy/issues/10968","id":552850185,"node_id":"MDEyOklzc3VlQ29tbWVudDU1Mjg1MDE4NQ==","user":{"login":"nmayorov","id":7074023,"node_id":"MDQ6VXNlcjcwNzQwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7074023?v=4","gravatar_id":"","url":"https://api.github.com/users/nmayorov","html_url":"https://github.com/nmayorov","followers_url":"https://api.github.com/users/nmayorov/followers","following_url":"https://api.github.com/users/nmayorov/following{/other_user}","gists_url":"https://api.github.com/users/nmayorov/gists{/gist_id}","starred_url":"https://api.github.com/users/nmayorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmayorov/subscriptions","organizations_url":"https://api.github.com/users/nmayorov/orgs","repos_url":"https://api.github.com/users/nmayorov/repos","events_url":"https://api.github.com/users/nmayorov/events{/privacy}","received_events_url":"https://api.github.com/users/nmayorov/received_events","type":"User","site_admin":false},"created_at":"2019-11-12T11:15:36Z","updated_at":"2019-11-12T11:15:36Z","author_association":"CONTRIBUTOR","body":"Now looking at it, I think it might be better to simply deprecate `normalized` (and then remove) and stick to some fixed strategy --- never normalize (expect normalized input) or always normalize.\r\n\r\nWhat do you think about this approach? Which \"fixed strategy\" is more logical if we go this way?"}}
other: {"actor":{"display_login":"nmayorov"}}