payload: {"action":"created","issue":{"url":"https://api.github.com/repos/pulumi/pulumi-eks/issues/141","repository_url":"https://api.github.com/repos/pulumi/pulumi-eks","labels_url":"https://api.github.com/repos/pulumi/pulumi-eks/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/pulumi/pulumi-eks/issues/141/comments","events_url":"https://api.github.com/repos/pulumi/pulumi-eks/issues/141/events","html_url":"https://github.com/pulumi/pulumi-eks/issues/141","id":450563647,"node_id":"MDU6SXNzdWU0NTA1NjM2NDc=","number":141,"title":"Multiple default storageClasses when specifying storageClass in EKS cluster","user":{"login":"Brianbrifri","id":9084149,"node_id":"MDQ6VXNlcjkwODQxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/9084149?v=4","gravatar_id":"","url":"https://api.github.com/users/Brianbrifri","html_url":"https://github.com/Brianbrifri","followers_url":"https://api.github.com/users/Brianbrifri/followers","following_url":"https://api.github.com/users/Brianbrifri/following{/other_user}","gists_url":"https://api.github.com/users/Brianbrifri/gists{/gist_id}","starred_url":"https://api.github.com/users/Brianbrifri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brianbrifri/subscriptions","organizations_url":"https://api.github.com/users/Brianbrifri/orgs","repos_url":"https://api.github.com/users/Brianbrifri/repos","events_url":"https://api.github.com/users/Brianbrifri/events{/privacy}","received_events_url":"https://api.github.com/users/Brianbrifri/received_events","type":"User","site_admin":false},"labels":[{"id":1105861395,"node_id":"MDU6TGFiZWwxMTA1ODYxMzk1","url":"https://api.github.com/repos/pulumi/pulumi-eks/labels/customer/feedback","name":"customer/feedback","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"metral","id":1112768,"node_id":"MDQ6VXNlcjExMTI3Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/1112768?v=4","gravatar_id":"","url":"https://api.github.com/users/metral","html_url":"https://github.com/metral","followers_url":"https://api.github.com/users/metral/followers","following_url":"https://api.github.com/users/metral/following{/other_user}","gists_url":"https://api.github.com/users/metral/gists{/gist_id}","starred_url":"https://api.github.com/users/metral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metral/subscriptions","organizations_url":"https://api.github.com/users/metral/orgs","repos_url":"https://api.github.com/users/metral/repos","events_url":"https://api.github.com/users/metral/events{/privacy}","received_events_url":"https://api.github.com/users/metral/received_events","type":"User","site_admin":false},"assignees":[{"login":"metral","id":1112768,"node_id":"MDQ6VXNlcjExMTI3Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/1112768?v=4","gravatar_id":"","url":"https://api.github.com/users/metral","html_url":"https://github.com/metral","followers_url":"https://api.github.com/users/metral/followers","following_url":"https://api.github.com/users/metral/following{/other_user}","gists_url":"https://api.github.com/users/metral/gists{/gist_id}","starred_url":"https://api.github.com/users/metral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metral/subscriptions","organizations_url":"https://api.github.com/users/metral/orgs","repos_url":"https://api.github.com/users/metral/repos","events_url":"https://api.github.com/users/metral/events{/privacy}","received_events_url":"https://api.github.com/users/metral/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pulumi/pulumi-eks/milestones/6","html_url":"https://github.com/pulumi/pulumi-eks/milestone/6","labels_url":"https://api.github.com/repos/pulumi/pulumi-eks/milestones/6/labels","id":4294468,"node_id":"MDk6TWlsZXN0b25lNDI5NDQ2OA==","number":6,"title":"0.24","description":null,"creator":{"login":"joeduffy","id":3953235,"node_id":"MDQ6VXNlcjM5NTMyMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3953235?v=4","gravatar_id":"","url":"https://api.github.com/users/joeduffy","html_url":"https://github.com/joeduffy","followers_url":"https://api.github.com/users/joeduffy/followers","following_url":"https://api.github.com/users/joeduffy/following{/other_user}","gists_url":"https://api.github.com/users/joeduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/joeduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeduffy/subscriptions","organizations_url":"https://api.github.com/users/joeduffy/orgs","repos_url":"https://api.github.com/users/joeduffy/repos","events_url":"https://api.github.com/users/joeduffy/events{/privacy}","received_events_url":"https://api.github.com/users/joeduffy/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2019-05-08T00:52:17Z","updated_at":"2019-06-03T16:42:37Z","due_on":"2019-07-07T07:00:00Z","closed_at":null},"comments":3,"created_at":"2019-05-31T00:33:31Z","updated_at":"2019-06-03T20:27:50Z","closed_at":null,"author_association":"NONE","body":"When creating an EKS cluster and specifying a custom storage class (e.g. `st1`), the default `gp2` storageClass is created along side the custom `st1` storageClass which is also marked as default. \r\n\r\nWhere `storageClass = \"st1\"`:\r\n```// Create a VPC for our cluster.\r\nconst vpc = new awsx.ec2.Vpc(\"Kafka-VPC\", {numberOfAvailabilityZones: 3});\r\n\r\n// Create an EKS cluster with the given configuration.\r\nconst cluster = new eks.Cluster(\"kafka-cluster\", {\r\n    vpcId: vpc.id,\r\n    subnetIds: vpc.privateSubnetIds,\r\n    instanceType: instanceType,\r\n    desiredCapacity: desiredCapacity,\r\n    minSize: minSize,\r\n    maxSize: maxSize,\r\n    storageClasses: storageClass,\r\n    deployDashboard: deployDashboard,\r\n});\r\n```\r\n\r\nThis results in:\r\n```> kubectl get storageclasses\r\nNAME                                   PROVISIONER             AGE\r\ngp2 (default)                          kubernetes.io/aws-ebs   23m\r\nkafka-cluster-st1-evr2qvmh (default)   kubernetes.io/aws-ebs   21m\r\n```\r\n\r\nThis can cause issues when helm charts rely on one default storage class since the storageClass name cannot be passed directly to the charts. \r\n\r\nExpected behavior: One storageClass is marked as default after EKS creation (preferably the user specified class)\r\nActual behavior: Both the EKS created `gp2` **AND** the user specified `st1` storage class are marked as default.\r\n\r\nOther thoughts:\r\nAbility to add/remove default status to storageClasses"},"comment":{"url":"https://api.github.com/repos/pulumi/pulumi-eks/issues/comments/498413718","html_url":"https://github.com/pulumi/pulumi-eks/issues/141#issuecomment-498413718","issue_url":"https://api.github.com/repos/pulumi/pulumi-eks/issues/141","id":498413718,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5ODQxMzcxOA==","user":{"login":"Brianbrifri","id":9084149,"node_id":"MDQ6VXNlcjkwODQxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/9084149?v=4","gravatar_id":"","url":"https://api.github.com/users/Brianbrifri","html_url":"https://github.com/Brianbrifri","followers_url":"https://api.github.com/users/Brianbrifri/followers","following_url":"https://api.github.com/users/Brianbrifri/following{/other_user}","gists_url":"https://api.github.com/users/Brianbrifri/gists{/gist_id}","starred_url":"https://api.github.com/users/Brianbrifri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brianbrifri/subscriptions","organizations_url":"https://api.github.com/users/Brianbrifri/orgs","repos_url":"https://api.github.com/users/Brianbrifri/repos","events_url":"https://api.github.com/users/Brianbrifri/events{/privacy}","received_events_url":"https://api.github.com/users/Brianbrifri/received_events","type":"User","site_admin":false},"created_at":"2019-06-03T20:27:50Z","updated_at":"2019-06-03T20:27:50Z","author_association":"NONE","body":"@metral As a follow up to this, I commented out the storageClass parameter above, ran `pulumi update`, then pulumi deleted the `st1` storageClass but then created another default `gp2` storageClass named `kafka-cluster-gp2-dd7h3rgp` along side the default `gp2` storageClass created by AWS EKS. \r\n\r\nIs this intended behavior?\r\n"}}
other: {"actor":{"display_login":"Brianbrifri"}}