payload: {"action":"created","comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/284932422","pull_request_review_id":238680938,"id":284932422,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDkzMjQyMg==","diff_hunk":"@@ -110,6 +110,13 @@ void Lyrics::read(XmlReader& e)\n             if (!readProperties(e))\n                   e.unknown();\n             }\n+      if (!isStyled(Pid::OFFSET) && !e.pasteMode()) {\n+            // fix offset for pre-3.1 scores\n+            // 3.0: y offset was meaningless if autoplace is set\n+            QPointF off = propertyDefault(Pid::OFFSET).toPointF();","path":"libmscore/lyrics.cpp","position":7,"original_position":7,"commit_id":"3dab967f6d0d49203e998b4c2babd06d8af81a9a","original_commit_id":"3dab967f6d0d49203e998b4c2babd06d8af81a9a","user":{"login":"dmitrio95","id":6000747,"node_id":"MDQ6VXNlcjYwMDA3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6000747?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrio95","html_url":"https://github.com/dmitrio95","followers_url":"https://api.github.com/users/dmitrio95/followers","following_url":"https://api.github.com/users/dmitrio95/following{/other_user}","gists_url":"https://api.github.com/users/dmitrio95/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrio95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrio95/subscriptions","organizations_url":"https://api.github.com/users/dmitrio95/orgs","repos_url":"https://api.github.com/users/dmitrio95/repos","events_url":"https://api.github.com/users/dmitrio95/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrio95/received_events","type":"User","site_admin":false},"body":"A minor point, but this `propertyDefault()` call can be moved inside the `if` block, otherwise the result is anyway not used.","created_at":"2019-05-16T23:20:34Z","updated_at":"2019-05-16T23:20:58Z","html_url":"https://github.com/musescore/MuseScore/pull/5017#discussion_r284932422","pull_request_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5017","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/284932422"},"html":{"href":"https://github.com/musescore/MuseScore/pull/5017#discussion_r284932422"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5017"}}},"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/5017","id":278514007,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4NTE0MDA3","html_url":"https://github.com/musescore/MuseScore/pull/5017","diff_url":"https://github.com/musescore/MuseScore/pull/5017.diff","patch_url":"https://github.com/musescore/MuseScore/pull/5017.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/5017","number":5017,"state":"open","locked":false,"title":"fix #289148: lyrics offset issues","user":{"login":"MarcSabatella","id":1799936,"node_id":"MDQ6VXNlcjE3OTk5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1799936?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"body":"See https://musescore.org/en/node/289148\r\n\r\nAfter the merge of #4982, the one element that has a compatibility issue with respect to 3.0 is lyrics, because the way we represent offsets.  But the good news is, this also gives us an opportunity to greatly improve the import from 2.x.  We had been throwing away offset information because there was no way for autoplace to use it, but now there is.\r\n\r\nSo this PR fixes the offset lyrics offset issue on import of 3.0 scores via the change to Lyrics::read(), plus the addition of Lyrics::getPropertyStyle().  It also allows 2.x lyrics to retain offset via the change to readLyrics() in read206.cpp.  The change to Lyrics::undoChangeProperty() also helps with compatiblity, but isn't actually as crucial, it just allows turning off autoplace for lyrics to rebase and thus preserve the offset, as it did in 3.0, and thus avoids the lyric \"jumping\".\r\n\r\nThis fix is important; without it any 3.0 score with manual adjustments to lyrics that don't turn off autoplace will look wrong.","created_at":"2019-05-14T04:19:53Z","updated_at":"2019-05-16T23:20:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e4701db03d18d8c0900d020dcdd5bd82d6b38e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5017/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5017/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/5017/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/3dab967f6d0d49203e998b4c2babd06d8af81a9a","head":{"label":"MarcSabatella:lyrics-offset","ref":"lyrics-offset","sha":"3dab967f6d0d49203e998b4c2babd06d8af81a9a","user":{"login":"MarcSabatella","id":1799936,"node_id":"MDQ6VXNlcjE3OTk5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1799936?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"repo":{"id":14895853,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg5NTg1Mw==","name":"MuseScore","full_name":"MarcSabatella/MuseScore","private":false,"owner":{"login":"MarcSabatella","id":1799936,"node_id":"MDQ6VXNlcjE3OTk5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1799936?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MarcSabatella/MuseScore","description":"MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/MarcSabatella/MuseScore","forks_url":"https://api.github.com/repos/MarcSabatella/MuseScore/forks","keys_url":"https://api.github.com/repos/MarcSabatella/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcSabatella/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcSabatella/MuseScore/teams","hooks_url":"https://api.github.com/repos/MarcSabatella/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/MarcSabatella/MuseScore/events","assignees_url":"https://api.github.com/repos/MarcSabatella/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/MarcSabatella/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/MarcSabatella/MuseScore/tags","blobs_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcSabatella/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcSabatella/MuseScore/languages","stargazers_url":"https://api.github.com/repos/MarcSabatella/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/MarcSabatella/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/MarcSabatella/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/MarcSabatella/MuseScore/subscription","commits_url":"https://api.github.com/repos/MarcSabatella/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcSabatella/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcSabatella/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/MarcSabatella/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcSabatella/MuseScore/merges","archive_url":"https://api.github.com/repos/MarcSabatella/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcSabatella/MuseScore/downloads","issues_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/MarcSabatella/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcSabatella/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcSabatella/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcSabatella/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/MarcSabatella/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/MarcSabatella/MuseScore/deployments","created_at":"2013-12-03T14:25:39Z","updated_at":"2019-03-24T13:50:34Z","pushed_at":"2019-05-16T22:47:28Z","git_url":"git://github.com/MarcSabatella/MuseScore.git","ssh_url":"git@github.com:MarcSabatella/MuseScore.git","clone_url":"https://github.com/MarcSabatella/MuseScore.git","svn_url":"https://github.com/MarcSabatella/MuseScore","homepage":"http://musescore.org","size":342385,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"66b30c3a81aabb9dc962c22d936b055da382b306","user":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU0Nzkz","name":"MuseScore","full_name":"musescore/MuseScore","private":false,"owner":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2019-05-16T22:44:04Z","pushed_at":"2019-05-16T23:04:27Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":358255,"stargazers_count":3670,"watchers_count":3670,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1174,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":179,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1174,"open_issues":179,"watchers":3670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5017"},"html":{"href":"https://github.com/musescore/MuseScore/pull/5017"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/5017"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/5017/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5017/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5017/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/3dab967f6d0d49203e998b4c2babd06d8af81a9a"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"dmitrio95"}}