payload: {"action":"created","comment":{"url":"https://api.github.com/repos/caicloud/rudder-client/pulls/comments/302800945","pull_request_review_id":261026657,"id":302800945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjgwMDk0NQ==","diff_hunk":"@@ -245,10 +250,23 @@ func getConsoleIsCommand(c *corev1.Container) *bool {\n \treturn convertBoolToPointer(c.Command != nil && len(c.Command) != 0)\n }\n \n-func getConsoleIsLog(pod *Pod) *bool {\n+// get container console flag from pod annotation\n+func getConsoleIsLog(pod *Pod, cn string) *bool {","path":"serializer/universal/container.go","position":32,"original_position":32,"commit_id":"70d10ae6f2574ba17722ebfb6b6cfc7b4092ee3b","original_commit_id":"9afb6668f5714a2254718100c325b9ccb25a58a8","user":{"login":"hezhizhen","id":7611700,"node_id":"MDQ6VXNlcjc2MTE3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7611700?v=4","gravatar_id":"","url":"https://api.github.com/users/hezhizhen","html_url":"https://github.com/hezhizhen","followers_url":"https://api.github.com/users/hezhizhen/followers","following_url":"https://api.github.com/users/hezhizhen/following{/other_user}","gists_url":"https://api.github.com/users/hezhizhen/gists{/gist_id}","starred_url":"https://api.github.com/users/hezhizhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hezhizhen/subscriptions","organizations_url":"https://api.github.com/users/hezhizhen/orgs","repos_url":"https://api.github.com/users/hezhizhen/repos","events_url":"https://api.github.com/users/hezhizhen/events{/privacy}","received_events_url":"https://api.github.com/users/hezhizhen/received_events","type":"User","site_admin":false},"body":"pod可以简写成p，因为类型是Pod；\r\ncn应该写完整containerName，因为类型上并不能判断","created_at":"2019-07-12T01:45:59Z","updated_at":"2019-07-12T01:46:06Z","html_url":"https://github.com/caicloud/rudder-client/pull/32#discussion_r302800945","pull_request_url":"https://api.github.com/repos/caicloud/rudder-client/pulls/32","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/caicloud/rudder-client/pulls/comments/302800945"},"html":{"href":"https://github.com/caicloud/rudder-client/pull/32#discussion_r302800945"},"pull_request":{"href":"https://api.github.com/repos/caicloud/rudder-client/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/caicloud/rudder-client/pulls/32","id":296884251,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2ODg0MjUx","html_url":"https://github.com/caicloud/rudder-client/pull/32","diff_url":"https://github.com/caicloud/rudder-client/pull/32.diff","patch_url":"https://github.com/caicloud/rudder-client/pull/32.patch","issue_url":"https://api.github.com/repos/caicloud/rudder-client/issues/32","number":32,"state":"open","locked":false,"title":"[CPS-2544] fix(consoleLog): fix the error judge about container console log flag","user":{"login":"whalecold","id":9996054,"node_id":"MDQ6VXNlcjk5OTYwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9996054?v=4","gravatar_id":"","url":"https://api.github.com/users/whalecold","html_url":"https://github.com/whalecold","followers_url":"https://api.github.com/users/whalecold/followers","following_url":"https://api.github.com/users/whalecold/following{/other_user}","gists_url":"https://api.github.com/users/whalecold/gists{/gist_id}","starred_url":"https://api.github.com/users/whalecold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whalecold/subscriptions","organizations_url":"https://api.github.com/users/whalecold/orgs","repos_url":"https://api.github.com/users/whalecold/repos","events_url":"https://api.github.com/users/whalecold/events{/privacy}","received_events_url":"https://api.github.com/users/whalecold/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request! See below for tips! -->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nfix(consoleLog): fix the error judge about container console log flag\r\n\r\n**Which issue(s) this PR is related to** *(optional, link to 3rd issue(s))*:\r\n\r\nFixes #\r\n\r\nReference to #\r\n<!-- 填在 Fixes，PR 合并就会关 issue。填在 Reference to 会关联 issue，不会联动关闭，caicloud/quality 请用这个。-->\r\n\r\n**Special notes for your reviewer**:\r\n\r\n/cc @hezhizhen @zxq-bit \r\n\r\n<!-- Please answer the following questions during the code freeze, and delete this line.\r\n**Code freeze questions**\r\n\r\n1. What causes this PR to not be merged before code freeze?\r\n2. Why this PR is absolutely necessary for this version? Paste a screenshot of smoke testing docs if you could.\r\n3. What's the effects after merging it?\r\n4. Is there anyway we can skip this to not affect the overall process?\r\n-->\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n\r\n```release-note\r\nNONE\r\n```\r\n\r\n<!--  Thanks for sending a pull request! Here are some tips:\r\n\r\n1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md  <-- what is the review process looks like\r\n2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md  <-- how to structure your git commit\r\n3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md        <-- how to work with caicloud bot\r\n\r\nOther tips from Kubernetes cmomunity:\r\n\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n","created_at":"2019-07-12T01:39:40Z","updated_at":"2019-07-12T01:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de37e2bd76157611fbc6da2108487338825d42df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zxq-bit","id":4223062,"node_id":"MDQ6VXNlcjQyMjMwNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4223062?v=4","gravatar_id":"","url":"https://api.github.com/users/zxq-bit","html_url":"https://github.com/zxq-bit","followers_url":"https://api.github.com/users/zxq-bit/followers","following_url":"https://api.github.com/users/zxq-bit/following{/other_user}","gists_url":"https://api.github.com/users/zxq-bit/gists{/gist_id}","starred_url":"https://api.github.com/users/zxq-bit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxq-bit/subscriptions","organizations_url":"https://api.github.com/users/zxq-bit/orgs","repos_url":"https://api.github.com/users/zxq-bit/repos","events_url":"https://api.github.com/users/zxq-bit/events{/privacy}","received_events_url":"https://api.github.com/users/zxq-bit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":915843105,"node_id":"MDU6TGFiZWw5MTU4NDMxMDU=","url":"https://api.github.com/repos/caicloud/rudder-client/labels/caicloud-cla:%20yes","name":"caicloud-cla: yes","color":"bfe5bf","default":false},{"id":915843210,"node_id":"MDU6TGFiZWw5MTU4NDMyMTA=","url":"https://api.github.com/repos/caicloud/rudder-client/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":915843149,"node_id":"MDU6TGFiZWw5MTU4NDMxNDk=","url":"https://api.github.com/repos/caicloud/rudder-client/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caicloud/rudder-client/pulls/32/commits","review_comments_url":"https://api.github.com/repos/caicloud/rudder-client/pulls/32/comments","review_comment_url":"https://api.github.com/repos/caicloud/rudder-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caicloud/rudder-client/issues/32/comments","statuses_url":"https://api.github.com/repos/caicloud/rudder-client/statuses/70d10ae6f2574ba17722ebfb6b6cfc7b4092ee3b","head":{"label":"whalecold:console","ref":"console","sha":"70d10ae6f2574ba17722ebfb6b6cfc7b4092ee3b","user":{"login":"whalecold","id":9996054,"node_id":"MDQ6VXNlcjk5OTYwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9996054?v=4","gravatar_id":"","url":"https://api.github.com/users/whalecold","html_url":"https://github.com/whalecold","followers_url":"https://api.github.com/users/whalecold/followers","following_url":"https://api.github.com/users/whalecold/following{/other_user}","gists_url":"https://api.github.com/users/whalecold/gists{/gist_id}","starred_url":"https://api.github.com/users/whalecold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whalecold/subscriptions","organizations_url":"https://api.github.com/users/whalecold/orgs","repos_url":"https://api.github.com/users/whalecold/repos","events_url":"https://api.github.com/users/whalecold/events{/privacy}","received_events_url":"https://api.github.com/users/whalecold/received_events","type":"User","site_admin":false},"repo":{"id":194641036,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ2NDEwMzY=","name":"rudder-client","full_name":"whalecold/rudder-client","private":false,"owner":{"login":"whalecold","id":9996054,"node_id":"MDQ6VXNlcjk5OTYwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9996054?v=4","gravatar_id":"","url":"https://api.github.com/users/whalecold","html_url":"https://github.com/whalecold","followers_url":"https://api.github.com/users/whalecold/followers","following_url":"https://api.github.com/users/whalecold/following{/other_user}","gists_url":"https://api.github.com/users/whalecold/gists{/gist_id}","starred_url":"https://api.github.com/users/whalecold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whalecold/subscriptions","organizations_url":"https://api.github.com/users/whalecold/orgs","repos_url":"https://api.github.com/users/whalecold/repos","events_url":"https://api.github.com/users/whalecold/events{/privacy}","received_events_url":"https://api.github.com/users/whalecold/received_events","type":"User","site_admin":false},"html_url":"https://github.com/whalecold/rudder-client","description":"Dynamic kubernetes client, chart render, resource status assistants for rudder","fork":true,"url":"https://api.github.com/repos/whalecold/rudder-client","forks_url":"https://api.github.com/repos/whalecold/rudder-client/forks","keys_url":"https://api.github.com/repos/whalecold/rudder-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whalecold/rudder-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whalecold/rudder-client/teams","hooks_url":"https://api.github.com/repos/whalecold/rudder-client/hooks","issue_events_url":"https://api.github.com/repos/whalecold/rudder-client/issues/events{/number}","events_url":"https://api.github.com/repos/whalecold/rudder-client/events","assignees_url":"https://api.github.com/repos/whalecold/rudder-client/assignees{/user}","branches_url":"https://api.github.com/repos/whalecold/rudder-client/branches{/branch}","tags_url":"https://api.github.com/repos/whalecold/rudder-client/tags","blobs_url":"https://api.github.com/repos/whalecold/rudder-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whalecold/rudder-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whalecold/rudder-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/whalecold/rudder-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whalecold/rudder-client/statuses/{sha}","languages_url":"https://api.github.com/repos/whalecold/rudder-client/languages","stargazers_url":"https://api.github.com/repos/whalecold/rudder-client/stargazers","contributors_url":"https://api.github.com/repos/whalecold/rudder-client/contributors","subscribers_url":"https://api.github.com/repos/whalecold/rudder-client/subscribers","subscription_url":"https://api.github.com/repos/whalecold/rudder-client/subscription","commits_url":"https://api.github.com/repos/whalecold/rudder-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/whalecold/rudder-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/whalecold/rudder-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/whalecold/rudder-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/whalecold/rudder-client/contents/{+path}","compare_url":"https://api.github.com/repos/whalecold/rudder-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whalecold/rudder-client/merges","archive_url":"https://api.github.com/repos/whalecold/rudder-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whalecold/rudder-client/downloads","issues_url":"https://api.github.com/repos/whalecold/rudder-client/issues{/number}","pulls_url":"https://api.github.com/repos/whalecold/rudder-client/pulls{/number}","milestones_url":"https://api.github.com/repos/whalecold/rudder-client/milestones{/number}","notifications_url":"https://api.github.com/repos/whalecold/rudder-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whalecold/rudder-client/labels{/name}","releases_url":"https://api.github.com/repos/whalecold/rudder-client/releases{/id}","deployments_url":"https://api.github.com/repos/whalecold/rudder-client/deployments","created_at":"2019-07-01T09:21:41Z","updated_at":"2019-07-01T09:21:44Z","pushed_at":"2019-07-12T01:43:22Z","git_url":"git://github.com/whalecold/rudder-client.git","ssh_url":"git@github.com:whalecold/rudder-client.git","clone_url":"https://github.com/whalecold/rudder-client.git","svn_url":"https://github.com/whalecold/rudder-client","homepage":null,"size":5738,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caicloud:master","ref":"master","sha":"588df7ca5c9e94ff1beaa49921c58d86254f210d","user":{"login":"caicloud","id":12522124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIyMTI0","avatar_url":"https://avatars2.githubusercontent.com/u/12522124?v=4","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"repo":{"id":131278526,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyNzg1MjY=","name":"rudder-client","full_name":"caicloud/rudder-client","private":false,"owner":{"login":"caicloud","id":12522124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIyMTI0","avatar_url":"https://avatars2.githubusercontent.com/u/12522124?v=4","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/caicloud/rudder-client","description":"Dynamic kubernetes client, chart render, resource status assistants for rudder","fork":false,"url":"https://api.github.com/repos/caicloud/rudder-client","forks_url":"https://api.github.com/repos/caicloud/rudder-client/forks","keys_url":"https://api.github.com/repos/caicloud/rudder-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caicloud/rudder-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caicloud/rudder-client/teams","hooks_url":"https://api.github.com/repos/caicloud/rudder-client/hooks","issue_events_url":"https://api.github.com/repos/caicloud/rudder-client/issues/events{/number}","events_url":"https://api.github.com/repos/caicloud/rudder-client/events","assignees_url":"https://api.github.com/repos/caicloud/rudder-client/assignees{/user}","branches_url":"https://api.github.com/repos/caicloud/rudder-client/branches{/branch}","tags_url":"https://api.github.com/repos/caicloud/rudder-client/tags","blobs_url":"https://api.github.com/repos/caicloud/rudder-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caicloud/rudder-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caicloud/rudder-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/caicloud/rudder-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caicloud/rudder-client/statuses/{sha}","languages_url":"https://api.github.com/repos/caicloud/rudder-client/languages","stargazers_url":"https://api.github.com/repos/caicloud/rudder-client/stargazers","contributors_url":"https://api.github.com/repos/caicloud/rudder-client/contributors","subscribers_url":"https://api.github.com/repos/caicloud/rudder-client/subscribers","subscription_url":"https://api.github.com/repos/caicloud/rudder-client/subscription","commits_url":"https://api.github.com/repos/caicloud/rudder-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/caicloud/rudder-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/caicloud/rudder-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/caicloud/rudder-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/caicloud/rudder-client/contents/{+path}","compare_url":"https://api.github.com/repos/caicloud/rudder-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caicloud/rudder-client/merges","archive_url":"https://api.github.com/repos/caicloud/rudder-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caicloud/rudder-client/downloads","issues_url":"https://api.github.com/repos/caicloud/rudder-client/issues{/number}","pulls_url":"https://api.github.com/repos/caicloud/rudder-client/pulls{/number}","milestones_url":"https://api.github.com/repos/caicloud/rudder-client/milestones{/number}","notifications_url":"https://api.github.com/repos/caicloud/rudder-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caicloud/rudder-client/labels{/name}","releases_url":"https://api.github.com/repos/caicloud/rudder-client/releases{/id}","deployments_url":"https://api.github.com/repos/caicloud/rudder-client/deployments","created_at":"2018-04-27T09:53:43Z","updated_at":"2019-07-12T01:01:47Z","pushed_at":"2019-07-12T01:43:24Z","git_url":"git://github.com/caicloud/rudder-client.git","ssh_url":"git@github.com:caicloud/rudder-client.git","clone_url":"https://github.com/caicloud/rudder-client.git","svn_url":"https://github.com/caicloud/rudder-client","homepage":null,"size":5739,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caicloud/rudder-client/pulls/32"},"html":{"href":"https://github.com/caicloud/rudder-client/pull/32"},"issue":{"href":"https://api.github.com/repos/caicloud/rudder-client/issues/32"},"comments":{"href":"https://api.github.com/repos/caicloud/rudder-client/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/caicloud/rudder-client/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/caicloud/rudder-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caicloud/rudder-client/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/caicloud/rudder-client/statuses/70d10ae6f2574ba17722ebfb6b6cfc7b4092ee3b"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"hezhizhen"}}