payload: {"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-android/issues/2760","repository_url":"https://api.github.com/repos/xamarin/xamarin-android","labels_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/2760/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/2760/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/2760/events","html_url":"https://github.com/xamarin/xamarin-android/pull/2760","id":413246799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1Mjc0MjEx","number":2760,"title":"[Xamarin.Android.Build.Tasks] support F# 4.5 Windows path","user":{"login":"jonathanpeppers","id":840039,"node_id":"MDQ6VXNlcjg0MDAzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/840039?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanpeppers","html_url":"https://github.com/jonathanpeppers","followers_url":"https://api.github.com/users/jonathanpeppers/followers","following_url":"https://api.github.com/users/jonathanpeppers/following{/other_user}","gists_url":"https://api.github.com/users/jonathanpeppers/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanpeppers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanpeppers/subscriptions","organizations_url":"https://api.github.com/users/jonathanpeppers/orgs","repos_url":"https://api.github.com/users/jonathanpeppers/repos","events_url":"https://api.github.com/users/jonathanpeppers/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanpeppers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-02-22T05:14:10Z","updated_at":"2019-02-22T10:27:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/2760","html_url":"https://github.com/xamarin/xamarin-android/pull/2760","diff_url":"https://github.com/xamarin/xamarin-android/pull/2760.diff","patch_url":"https://github.com/xamarin/xamarin-android/pull/2760.patch"},"body":"Context: https://devblogs.microsoft.com/dotnet/announcing-f-4-5/\r\n\r\nSince VS 15.8 on Windows, F# 4.5 is now installed along with Visual\r\nStudio to support side-by-side installations. Previously F# was\r\ninstalled in a system-wide location specified by `%FSHARPINSTALLDIR%`:\r\n\r\n    C:\\Program Files (x86)\\Microsoft SDKs\\F#\\10.1\\Framework\\v4.0\\\r\n\r\nThe new locations are, for example:\r\n\r\n    C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\Common7\\IDE\\CommonExtensions\\Microsoft\\FSharp\r\n    C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Preview\\Common7\\IDE\\CommonExtensions\\Microsoft\\FSharp\r\n\r\nI have also seen a few instances where our F#-related MSBuild tests\r\nfailed on Windows, failing to import `Microsoft.FSharp.targets`:\r\n\r\n    bin\\TestRelease\\temp\\BuildBasicApplicationFSharp\\UnnamedProject.fsproj error MSB4057:\r\n        The target \"Build\" does not exist in the project.\r\n\r\nIn this case, *all* of our probing for `Microsoft.FSharp.targets`\r\nfailed:\r\n\r\n    NoImport: $(MSBuildExtensionsPath32)\\Microsoft\\VisualStudio\\v$(VisualStudioVersion)\\FSharp\\Microsoft.FSharp.Targets at (44;5) Not imported due to false condition; ('$(Language)' != 'F#' And Exists('$(MSBuildExtensionsPath32)\\Microsoft\\VisualStudio\\v$(VisualStudioVersion)\\FSharp\\Microsoft.FSharp.Targets')) was evaluated as ('' != 'F#' And Exists('E:\\A\\_work\\382\\s\\bin\\Release\\lib\\xamarin.android\\xbuild\\Microsoft\\VisualStudio\\v15.0\\FSharp\\Microsoft.FSharp.Targets')).\r\n    NoImport: $(FSharpInstallDir)Microsoft.FSharp.Targets at (47;5) Not imported due to false condition; ('$(Language)' != 'F#' And Exists('$(FSharpInstallDir)Microsoft.FSharp.Targets')) was evaluated as ('' != 'F#' And Exists('Microsoft.FSharp.Targets')).\r\n    NoImport: $(MSBuildExtensionsPath32)\\..\\Microsoft SDKs\\F#\\4.1\\Framework\\v4.0\\Microsoft.FSharp.Targets at (50;5) Not imported due to false condition; ('$(Language)' != 'F#' And Exists('$(MSBuildExtensionsPath32)\\..\\Microsoft SDKs\\F#\\4.1\\Framework\\v4.0\\Microsoft.FSharp.Targets')) was evaluated as ('' != 'F#' And Exists('E:\\A\\_work\\382\\s\\bin\\Release\\lib\\xamarin.android\\xbuild\\..\\Microsoft SDKs\\F#\\4.1\\Framework\\v4.0\\Microsoft.FSharp.Targets')).\r\n    NoImport: $(MSBuildExtensionsPath32)\\..\\Microsoft SDKs\\F#\\4.0\\Framework\\v4.0\\Microsoft.FSharp.Targets at (53;5) Not imported due to false condition; ('$(Language)' != 'F#' And Exists('$(MSBuildExtensionsPath32)\\..\\Microsoft SDKs\\F#\\4.0\\Framework\\v4.0\\Microsoft.FSharp.Targets')) was evaluated as ('' != 'F#' And Exists('E:\\A\\_work\\382\\s\\bin\\Release\\lib\\xamarin.android\\xbuild\\..\\Microsoft SDKs\\F#\\4.0\\Framework\\v4.0\\Microsoft.FSharp.Targets')).\r\n    NoImport: $(MSBuildExtensionsPath32)\\..\\Microsoft SDKs\\F#\\3.1\\Framework\\v4.0\\Microsoft.FSharp.Targets at (56;5) Not imported due to false condition; ('$(Language)' != 'F#' And Exists('$(MSBuildExtensionsPath32)\\..\\Microsoft SDKs\\F#\\3.1\\Framework\\v4.0\\Microsoft.FSharp.Targets')) was evaluated as ('' != 'F#' And Exists('E:\\A\\_work\\382\\s\\bin\\Release\\lib\\xamarin.android\\xbuild\\..\\Microsoft SDKs\\F#\\3.1\\Framework\\v4.0\\Microsoft.FSharp.Targets')).\r\n\r\nSo the fix here is to add an extra `<Import/>` for:\r\n\r\n    $(MSBuildToolsPath32)\\..\\..\\..\\Common7\\IDE\\CommonExtensions\\Microsoft\\FSharp\\Microsoft.FSharp.Targets\r\n\r\nI found this path when digging through binlogs, which is how NuGet's\r\nMSBuild targets are imported:\r\n\r\n    <PropertyGroup>\r\n      <NuGetRestoreTargets Condition=\"'$(NuGetRestoreTargets)'==''\">$(MSBuildToolsPath32)\\..\\..\\..\\Common7\\IDE\\CommonExtensions\\Microsoft\\NuGet\\NuGet.targets</NuGetRestoreTargets>\r\n      ...\r\n      </PropertyGroup>\r\n    <Import Condition=\"Exists('$(NuGetRestoreTargets)')\" Project=\"$(NuGetRestoreTargets)\" />\r\n\r\nCurrently, I think you would have to modify `%FSHARPINSTALLDIR%` to\r\nuse F# 4.5 with Xamarin.Android on Windows."},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-android/issues/comments/466350300","html_url":"https://github.com/xamarin/xamarin-android/pull/2760#issuecomment-466350300","issue_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/2760","id":466350300,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NjM1MDMwMA==","user":{"login":"dellis1972","id":810617,"node_id":"MDQ6VXNlcjgxMDYxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/810617?v=4","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"created_at":"2019-02-22T10:27:45Z","updated_at":"2019-02-22T10:27:45Z","author_association":"CONTRIBUTOR","body":"@jonathanpeppers we might want to look at enabling these tests on windows if this fixes the FSharp stuff\r\n\r\nhttps://github.com/xamarin/xamarin-android/blob/b08240ee50e941cb326688cc0dcf5969ebfe5473/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs#L480\r\n\r\nhttps://github.com/xamarin/xamarin-android/blob/b08240ee50e941cb326688cc0dcf5969ebfe5473/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs#L507"}}
other: {"actor":{"display_login":"dellis1972"}}