payload: {"action":"created","comment":{"url":"https://api.github.com/repos/decidim/decidim/pulls/comments/355396354","pull_request_review_id":328853061,"id":355396354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTM5NjM1NA==","diff_hunk":"@@ -11,9 +11,7 @@ class ImageUploader < ApplicationUploader\n     # CarrierWave automatically calls this method and validates the content\n     # type fo the temp file to match against any of these options.\n     def content_type_whitelist\n-      [\n-        %r{image\\/}\n-      ]\n+      extension_whitelist.map { |ext| \"image/#{ext}\" }","path":"decidim-core/app/uploaders/decidim/image_uploader.rb","position":7,"original_position":7,"commit_id":"9e024c0588c1ac7f54dac7c8c6e490fbe55db6a5","original_commit_id":"9e024c0588c1ac7f54dac7c8c6e490fbe55db6a5","user":{"login":"oriolgual","id":5254,"node_id":"MDQ6VXNlcjUyNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5254?v=4","gravatar_id":"","url":"https://api.github.com/users/oriolgual","html_url":"https://github.com/oriolgual","followers_url":"https://api.github.com/users/oriolgual/followers","following_url":"https://api.github.com/users/oriolgual/following{/other_user}","gists_url":"https://api.github.com/users/oriolgual/gists{/gist_id}","starred_url":"https://api.github.com/users/oriolgual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriolgual/subscriptions","organizations_url":"https://api.github.com/users/oriolgual/orgs","repos_url":"https://api.github.com/users/oriolgual/repos","events_url":"https://api.github.com/users/oriolgual/events{/privacy}","received_events_url":"https://api.github.com/users/oriolgual/received_events","type":"User","site_admin":false},"body":"Oh, forget about this, I read the list from the attachment uploader, not the image!","created_at":"2019-12-09T11:26:30Z","updated_at":"2019-12-09T11:26:30Z","html_url":"https://github.com/decidim/decidim/pull/5553#discussion_r355396354","pull_request_url":"https://api.github.com/repos/decidim/decidim/pulls/5553","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments/355396354"},"html":{"href":"https://github.com/decidim/decidim/pull/5553#discussion_r355396354"},"pull_request":{"href":"https://api.github.com/repos/decidim/decidim/pulls/5553"}},"in_reply_to_id":355388807},"pull_request":{"url":"https://api.github.com/repos/decidim/decidim/pulls/5553","id":350650102,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwNjUwMTAy","html_url":"https://github.com/decidim/decidim/pull/5553","diff_url":"https://github.com/decidim/decidim/pull/5553.diff","patch_url":"https://github.com/decidim/decidim/pull/5553.patch","issue_url":"https://api.github.com/repos/decidim/decidim/issues/5553","number":5553,"state":"open","locked":false,"title":"Security patches","user":{"login":"txus","id":83234,"node_id":"MDQ6VXNlcjgzMjM0","avatar_url":"https://avatars2.githubusercontent.com/u/83234?v=4","gravatar_id":"","url":"https://api.github.com/users/txus","html_url":"https://github.com/txus","followers_url":"https://api.github.com/users/txus/followers","following_url":"https://api.github.com/users/txus/following{/other_user}","gists_url":"https://api.github.com/users/txus/gists{/gist_id}","starred_url":"https://api.github.com/users/txus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txus/subscriptions","organizations_url":"https://api.github.com/users/txus/orgs","repos_url":"https://api.github.com/users/txus/repos","events_url":"https://api.github.com/users/txus/events{/privacy}","received_events_url":"https://api.github.com/users/txus/received_events","type":"User","site_admin":false},"body":"#### :tophat: What? Why?\r\n\r\nApply a number of security patches after a security review.\r\n\r\n#### :clipboard: Subtasks\r\n- [x] Don't allow comments deeper than MAX_DEPTH\r\n- [x] Force SSL from decidim-core\r\n- [x] Do not expose GraphiQL nor ruby version in production\r\n- [x] Throttle failed authorization attempts\r\n- [x] Prevent timing attacks on login and leaking timing info\r\n- [x] Expire sessions after 24h of creation\r\n- [x] Do not expose process statistics in the API if hidden\r\n- [x] Invalidate sessions on logout\r\n- [x] Do now allow uploading SVGs\r\n- [x] Do not expose image processing errors\r\n- [x] XSS sanitization\r\n- [x] Add server-side pagination of commnets\r\n- [ ] Add client-side pagination of comments (infinite scrolling)","created_at":"2019-12-09T10:57:25Z","updated_at":"2019-12-09T11:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a53404e3d3b6451d14975381329b70f099cdc509","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrcasals","id":491891,"node_id":"MDQ6VXNlcjQ5MTg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decidim/decidim/pulls/5553/commits","review_comments_url":"https://api.github.com/repos/decidim/decidim/pulls/5553/comments","review_comment_url":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decidim/decidim/issues/5553/comments","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/9e024c0588c1ac7f54dac7c8c6e490fbe55db6a5","head":{"label":"codegram:fixes","ref":"fixes","sha":"9e024c0588c1ac7f54dac7c8c6e490fbe55db6a5","user":{"login":"codegram","id":82056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMDU2","avatar_url":"https://avatars0.githubusercontent.com/u/82056?v=4","gravatar_id":"","url":"https://api.github.com/users/codegram","html_url":"https://github.com/codegram","followers_url":"https://api.github.com/users/codegram/followers","following_url":"https://api.github.com/users/codegram/following{/other_user}","gists_url":"https://api.github.com/users/codegram/gists{/gist_id}","starred_url":"https://api.github.com/users/codegram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codegram/subscriptions","organizations_url":"https://api.github.com/users/codegram/orgs","repos_url":"https://api.github.com/users/codegram/repos","events_url":"https://api.github.com/users/codegram/events{/privacy}","received_events_url":"https://api.github.com/users/codegram/received_events","type":"Organization","site_admin":false},"repo":{"id":225328812,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUzMjg4MTI=","name":"decidim","full_name":"codegram/decidim","private":false,"owner":{"login":"codegram","id":82056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMDU2","avatar_url":"https://avatars0.githubusercontent.com/u/82056?v=4","gravatar_id":"","url":"https://api.github.com/users/codegram","html_url":"https://github.com/codegram","followers_url":"https://api.github.com/users/codegram/followers","following_url":"https://api.github.com/users/codegram/following{/other_user}","gists_url":"https://api.github.com/users/codegram/gists{/gist_id}","starred_url":"https://api.github.com/users/codegram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codegram/subscriptions","organizations_url":"https://api.github.com/users/codegram/orgs","repos_url":"https://api.github.com/users/codegram/repos","events_url":"https://api.github.com/users/codegram/events{/privacy}","received_events_url":"https://api.github.com/users/codegram/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codegram/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails","fork":true,"url":"https://api.github.com/repos/codegram/decidim","forks_url":"https://api.github.com/repos/codegram/decidim/forks","keys_url":"https://api.github.com/repos/codegram/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codegram/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codegram/decidim/teams","hooks_url":"https://api.github.com/repos/codegram/decidim/hooks","issue_events_url":"https://api.github.com/repos/codegram/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/codegram/decidim/events","assignees_url":"https://api.github.com/repos/codegram/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/codegram/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/codegram/decidim/tags","blobs_url":"https://api.github.com/repos/codegram/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codegram/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codegram/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/codegram/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codegram/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/codegram/decidim/languages","stargazers_url":"https://api.github.com/repos/codegram/decidim/stargazers","contributors_url":"https://api.github.com/repos/codegram/decidim/contributors","subscribers_url":"https://api.github.com/repos/codegram/decidim/subscribers","subscription_url":"https://api.github.com/repos/codegram/decidim/subscription","commits_url":"https://api.github.com/repos/codegram/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/codegram/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/codegram/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/codegram/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/codegram/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/codegram/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codegram/decidim/merges","archive_url":"https://api.github.com/repos/codegram/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codegram/decidim/downloads","issues_url":"https://api.github.com/repos/codegram/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/codegram/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/codegram/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/codegram/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codegram/decidim/labels{/name}","releases_url":"https://api.github.com/repos/codegram/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/codegram/decidim/deployments","created_at":"2019-12-02T08:54:35Z","updated_at":"2019-12-02T08:54:38Z","pushed_at":"2019-12-09T10:49:24Z","git_url":"git://github.com/codegram/decidim.git","ssh_url":"git@github.com:codegram/decidim.git","clone_url":"https://github.com/codegram/decidim.git","svn_url":"https://github.com/codegram/decidim","homepage":"https://decidim.org/","size":78115,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decidim:master","ref":"master","sha":"343ca1c296ae80f3bc348232f7e5d8edcac90fe0","user":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"node_id":"MDEwOlJlcG9zaXRvcnk2NTkxNDA4Ng==","name":"decidim","full_name":"decidim/decidim","private":false,"owner":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2019-12-07T18:18:45Z","pushed_at":"2019-12-09T10:57:26Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"https://decidim.org/","size":78405,"stargazers_count":599,"watchers_count":599,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":171,"open_issues":76,"watchers":599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/5553"},"html":{"href":"https://github.com/decidim/decidim/pull/5553"},"issue":{"href":"https://api.github.com/repos/decidim/decidim/issues/5553"},"comments":{"href":"https://api.github.com/repos/decidim/decidim/issues/5553/comments"},"review_comments":{"href":"https://api.github.com/repos/decidim/decidim/pulls/5553/comments"},"review_comment":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decidim/decidim/pulls/5553/commits"},"statuses":{"href":"https://api.github.com/repos/decidim/decidim/statuses/9e024c0588c1ac7f54dac7c8c6e490fbe55db6a5"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"oriolgual"}}