payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/comments/331119175","pull_request_review_id":296976690,"id":331119175,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMTExOTE3NQ==","diff_hunk":"@@ -301,6 +312,15 @@ func (a *awsProvider) authorizeSgIngress(sgID string, vpc *ec2.Vpc) error {\n \t\t\t\t\t(&ec2.IpRange{}).\n \t\t\t\t\t\tSetCidrIp(myIP + \"/32\"),\n \t\t\t\t}),\n+\t\t\t(&ec2.IpPermission{}).\n+\t\t\t\tSetIpProtocol(\"tcp\").\n+\t\t\t\t// winrm port\n+\t\t\t\tSetFromPort(5986).","path":"tools/windows-node-installer/pkg/cloudprovider/aws/ec2.go","position":55,"original_position":50,"commit_id":"54a92deb72b38e77de019572b3f4d81b3a84fead","original_commit_id":"730f7762fcda1f2929910c844aa5dc013a16a896","user":{"login":"aravindhp","id":11638995,"node_id":"MDQ6VXNlcjExNjM4OTk1","avatar_url":"https://avatars3.githubusercontent.com/u/11638995?v=4","gravatar_id":"","url":"https://api.github.com/users/aravindhp","html_url":"https://github.com/aravindhp","followers_url":"https://api.github.com/users/aravindhp/followers","following_url":"https://api.github.com/users/aravindhp/following{/other_user}","gists_url":"https://api.github.com/users/aravindhp/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindhp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindhp/subscriptions","organizations_url":"https://api.github.com/users/aravindhp/orgs","repos_url":"https://api.github.com/users/aravindhp/repos","events_url":"https://api.github.com/users/aravindhp/events{/privacy}","received_events_url":"https://api.github.com/users/aravindhp/received_events","type":"User","site_admin":false},"body":"Why? You are introducing the port in this PR and it is a two line change to make it a constant. Please don't add to tech debit if possible.","created_at":"2019-10-03T15:56:34Z","updated_at":"2019-10-03T15:56:35Z","html_url":"https://github.com/openshift/windows-machine-config-operator/pull/32#discussion_r331119175","pull_request_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/comments/331119175"},"html":{"href":"https://github.com/openshift/windows-machine-config-operator/pull/32#discussion_r331119175"},"pull_request":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32"}},"in_reply_to_id":328315224},"pull_request":{"url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32","id":321404631,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxNDA0NjMx","html_url":"https://github.com/openshift/windows-machine-config-operator/pull/32","diff_url":"https://github.com/openshift/windows-machine-config-operator/pull/32.diff","patch_url":"https://github.com/openshift/windows-machine-config-operator/pull/32.patch","issue_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues/32","number":32,"state":"open","locked":false,"title":"[aws] Enable winrm when launching Windows instance","user":{"login":"leonjia0112","id":17820732,"node_id":"MDQ6VXNlcjE3ODIwNzMy","avatar_url":"https://avatars2.githubusercontent.com/u/17820732?v=4","gravatar_id":"","url":"https://api.github.com/users/leonjia0112","html_url":"https://github.com/leonjia0112","followers_url":"https://api.github.com/users/leonjia0112/followers","following_url":"https://api.github.com/users/leonjia0112/following{/other_user}","gists_url":"https://api.github.com/users/leonjia0112/gists{/gist_id}","starred_url":"https://api.github.com/users/leonjia0112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonjia0112/subscriptions","organizations_url":"https://api.github.com/users/leonjia0112/orgs","repos_url":"https://api.github.com/users/leonjia0112/repos","events_url":"https://api.github.com/users/leonjia0112/events{/privacy}","received_events_url":"https://api.github.com/users/leonjia0112/received_events","type":"User","site_admin":false},"body":"Inject PowerShell script to launch Windows instance and open port `5986` for winrm https\r\ninbound traffic so the windows instance is ready for Ansible communication at\r\nlaunch and every time it boot up.\r\n\r\nChange the `createInstance()` function input with an extra parameter the contains the user data input, which is be either Windows PowerShell command or other. So this function is still generic for all the instance type.\r\n\r\n**Another PR with addition feature for telling user that there is an already exist sg that doesn't not contains winrm port and we create creating a new sg that has winrm asscociated with it.**\r\n\r\n**Testing is not done. Another commit for testing.**\r\n\r\n","created_at":"2019-09-25T19:35:55Z","updated_at":"2019-10-03T15:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1409075d74c43dac1f6c3f3eecbb8dc0a0b65a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1522191520,"node_id":"MDU6TGFiZWwxNTIyMTkxNTIw","url":"https://api.github.com/repos/openshift/windows-machine-config-operator/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32/commits","review_comments_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32/comments","review_comment_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues/32/comments","statuses_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/statuses/54a92deb72b38e77de019572b3f4d81b3a84fead","head":{"label":"leonjia0112:enable-instance-winrm","ref":"enable-instance-winrm","sha":"54a92deb72b38e77de019572b3f4d81b3a84fead","user":{"login":"leonjia0112","id":17820732,"node_id":"MDQ6VXNlcjE3ODIwNzMy","avatar_url":"https://avatars2.githubusercontent.com/u/17820732?v=4","gravatar_id":"","url":"https://api.github.com/users/leonjia0112","html_url":"https://github.com/leonjia0112","followers_url":"https://api.github.com/users/leonjia0112/followers","following_url":"https://api.github.com/users/leonjia0112/following{/other_user}","gists_url":"https://api.github.com/users/leonjia0112/gists{/gist_id}","starred_url":"https://api.github.com/users/leonjia0112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonjia0112/subscriptions","organizations_url":"https://api.github.com/users/leonjia0112/orgs","repos_url":"https://api.github.com/users/leonjia0112/repos","events_url":"https://api.github.com/users/leonjia0112/events{/privacy}","received_events_url":"https://api.github.com/users/leonjia0112/received_events","type":"User","site_admin":false},"repo":{"id":206835199,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY4MzUxOTk=","name":"windows-machine-config-operator","full_name":"leonjia0112/windows-machine-config-operator","private":false,"owner":{"login":"leonjia0112","id":17820732,"node_id":"MDQ6VXNlcjE3ODIwNzMy","avatar_url":"https://avatars2.githubusercontent.com/u/17820732?v=4","gravatar_id":"","url":"https://api.github.com/users/leonjia0112","html_url":"https://github.com/leonjia0112","followers_url":"https://api.github.com/users/leonjia0112/followers","following_url":"https://api.github.com/users/leonjia0112/following{/other_user}","gists_url":"https://api.github.com/users/leonjia0112/gists{/gist_id}","starred_url":"https://api.github.com/users/leonjia0112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonjia0112/subscriptions","organizations_url":"https://api.github.com/users/leonjia0112/orgs","repos_url":"https://api.github.com/users/leonjia0112/repos","events_url":"https://api.github.com/users/leonjia0112/events{/privacy}","received_events_url":"https://api.github.com/users/leonjia0112/received_events","type":"User","site_admin":false},"html_url":"https://github.com/leonjia0112/windows-machine-config-operator","description":"Windows MCO for OpenShift that handles addition of Windows nodes to the cluster","fork":true,"url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator","forks_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/forks","keys_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/teams","hooks_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/hooks","issue_events_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/issues/events{/number}","events_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/events","assignees_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/assignees{/user}","branches_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/branches{/branch}","tags_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/tags","blobs_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/languages","stargazers_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/stargazers","contributors_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/contributors","subscribers_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/subscribers","subscription_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/subscription","commits_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/contents/{+path}","compare_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/merges","archive_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/downloads","issues_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/issues{/number}","pulls_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/labels{/name}","releases_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/releases{/id}","deployments_url":"https://api.github.com/repos/leonjia0112/windows-machine-config-operator/deployments","created_at":"2019-09-06T16:37:55Z","updated_at":"2019-09-26T14:49:57Z","pushed_at":"2019-10-03T15:11:16Z","git_url":"git://github.com/leonjia0112/windows-machine-config-operator.git","ssh_url":"git@github.com:leonjia0112/windows-machine-config-operator.git","clone_url":"https://github.com/leonjia0112/windows-machine-config-operator.git","svn_url":"https://github.com/leonjia0112/windows-machine-config-operator","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8f74849eb3cf4a86440bc9b1714684ab977e2cd9","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":202786481,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI3ODY0ODE=","name":"windows-machine-config-operator","full_name":"openshift/windows-machine-config-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/windows-machine-config-operator","description":"Windows MCO for OpenShift that handles addition of Windows nodes to the cluster","fork":false,"url":"https://api.github.com/repos/openshift/windows-machine-config-operator","forks_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/forks","keys_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/teams","hooks_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/events","assignees_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/tags","blobs_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/subscription","commits_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/merges","archive_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/downloads","issues_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/windows-machine-config-operator/deployments","created_at":"2019-08-16T19:20:23Z","updated_at":"2019-10-03T15:46:54Z","pushed_at":"2019-10-03T15:49:23Z","git_url":"git://github.com/openshift/windows-machine-config-operator.git","ssh_url":"git@github.com:openshift/windows-machine-config-operator.git","clone_url":"https://github.com/openshift/windows-machine-config-operator.git","svn_url":"https://github.com/openshift/windows-machine-config-operator","homepage":null,"size":205,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32"},"html":{"href":"https://github.com/openshift/windows-machine-config-operator/pull/32"},"issue":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues/32"},"comments":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/windows-machine-config-operator/statuses/54a92deb72b38e77de019572b3f4d81b3a84fead"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"aravindhp"}}