payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/361213961","pull_request_review_id":336261137,"id":361213961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTIxMzk2MQ==","diff_hunk":"@@ -174,85 +171,80 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {\n                     .collect();\n                 (arm, arm_candidates)\n             })\n-            .collect();\n-\n-        // Step 3. Create the decision tree and record the places that we bind or test.\n+            .collect()\n+    }\n \n+    /// Create the decision tree for the match expression.\n+    ///\n+    /// Modifies `candidates` to store the bindings and type ascriptions for\n+    /// that candidate.\n+    ///\n+    /// Returns the places that need fake borrows because we bind or test them.\n+    fn lower_match_tree<'pat>(\n+        &mut self,\n+        block: BasicBlock,\n+        scrutinee_span: Span,\n+        match_has_guard: bool,\n+        mut candidates: Vec<&mut Candidate<'pat, 'tcx>>,\n+    ) -> Vec<(Place<'tcx>, Local)> {\n         // The set of places that we are creating fake borrows of. If there are\n         // no match guards then we don't need any fake borrows, so don't track\n         // them.\n         let mut fake_borrows = if match_has_guard { Some(FxHashSet::default()) } else { None };\n \n-        // These candidates are kept sorted such that the highest priority\n-        // candidate comes first in the list. (i.e., same order as in source)\n-        // As we gnerate the decision tree,","path":"src/librustc_mir/build/matches/mod.rs","position":208,"original_position":155,"commit_id":"5268d00688f400720c029eb84f5829af03b8de8e","original_commit_id":"1a5dc2d2a800de68b986f93ebe18daae3dc99b18","user":{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false},"body":"Ah 👍 ","created_at":"2019-12-24T18:59:35Z","updated_at":"2019-12-24T18:59:35Z","html_url":"https://github.com/rust-lang/rust/pull/67592#discussion_r361213961","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/67592","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/361213961"},"html":{"href":"https://github.com/rust-lang/rust/pull/67592#discussion_r361213961"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/67592"}},"in_reply_to_id":361205604},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/67592","id":356676896,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2Njc2ODk2","html_url":"https://github.com/rust-lang/rust/pull/67592","diff_url":"https://github.com/rust-lang/rust/pull/67592.diff","patch_url":"https://github.com/rust-lang/rust/pull/67592.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/67592","number":67592,"state":"open","locked":false,"title":"Prepare for lowering or-patterns","user":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"body":"This is probably best reviewed commit-by-commit.\r\n\r\n* Rustfmt `rustc_mir::build::{self, matches}`\r\n* Remove `-Znll-dont-emit-read-for-match`\r\n* Split `match_expr` into smaller functions\r\n* Feature gate or-patterns in const contexts\r\n* Allow `incomplete_features` for or-patterns tests \r\n\r\nr? @Centril ","created_at":"2019-12-24T17:14:46Z","updated_at":"2019-12-24T18:59:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5d3873c8fe766fbabd3ff53b370c665d6ed885f","assignee":{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false},"assignees":[{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1683099516,"node_id":"MDU6TGFiZWwxNjgzMDk5NTE2","url":"https://api.github.com/repos/rust-lang/rust/labels/F-const_if_match","name":"F-const_if_match","color":"f9c0cc","default":false,"description":"`#![feature(const_if_match)]`"},{"id":1506199886,"node_id":"MDU6TGFiZWwxNTA2MTk5ODg2","url":"https://api.github.com/repos/rust-lang/rust/labels/F-or_patterns","name":"F-or_patterns","color":"f9c0cc","default":false,"description":"`#![feature(or_patterns)]`"},{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false,"description":"Status: Awaiting review from the assignee but also interested parties."}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/67592/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/67592/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/67592/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/5268d00688f400720c029eb84f5829af03b8de8e","head":{"label":"matthewjasper:cleanup-match","ref":"cleanup-match","sha":"5268d00688f400720c029eb84f5829af03b8de8e","user":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"repo":{"id":86588393,"node_id":"MDEwOlJlcG9zaXRvcnk4NjU4ODM5Mw==","name":"rust","full_name":"matthewjasper/rust","private":false,"owner":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matthewjasper/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/matthewjasper/rust","forks_url":"https://api.github.com/repos/matthewjasper/rust/forks","keys_url":"https://api.github.com/repos/matthewjasper/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewjasper/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewjasper/rust/teams","hooks_url":"https://api.github.com/repos/matthewjasper/rust/hooks","issue_events_url":"https://api.github.com/repos/matthewjasper/rust/issues/events{/number}","events_url":"https://api.github.com/repos/matthewjasper/rust/events","assignees_url":"https://api.github.com/repos/matthewjasper/rust/assignees{/user}","branches_url":"https://api.github.com/repos/matthewjasper/rust/branches{/branch}","tags_url":"https://api.github.com/repos/matthewjasper/rust/tags","blobs_url":"https://api.github.com/repos/matthewjasper/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewjasper/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewjasper/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewjasper/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewjasper/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewjasper/rust/languages","stargazers_url":"https://api.github.com/repos/matthewjasper/rust/stargazers","contributors_url":"https://api.github.com/repos/matthewjasper/rust/contributors","subscribers_url":"https://api.github.com/repos/matthewjasper/rust/subscribers","subscription_url":"https://api.github.com/repos/matthewjasper/rust/subscription","commits_url":"https://api.github.com/repos/matthewjasper/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewjasper/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewjasper/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewjasper/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewjasper/rust/contents/{+path}","compare_url":"https://api.github.com/repos/matthewjasper/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewjasper/rust/merges","archive_url":"https://api.github.com/repos/matthewjasper/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewjasper/rust/downloads","issues_url":"https://api.github.com/repos/matthewjasper/rust/issues{/number}","pulls_url":"https://api.github.com/repos/matthewjasper/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewjasper/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewjasper/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewjasper/rust/labels{/name}","releases_url":"https://api.github.com/repos/matthewjasper/rust/releases{/id}","deployments_url":"https://api.github.com/repos/matthewjasper/rust/deployments","created_at":"2017-03-29T13:54:25Z","updated_at":"2019-11-03T17:11:57Z","pushed_at":"2019-12-24T17:26:42Z","git_url":"git://github.com/matthewjasper/rust.git","ssh_url":"git@github.com:matthewjasper/rust.git","clone_url":"https://github.com/matthewjasper/rust.git","svn_url":"https://github.com/matthewjasper/rust","homepage":"https://www.rust-lang.org","size":477023,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"84d8f9ddd3819501735d30b3c584c6935ef6c9da","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"Empowering everyone to build reliable and efficient software.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2019-12-24T18:02:10Z","pushed_at":"2019-12-24T18:02:14Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":480838,"stargazers_count":41387,"watchers_count":41387,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6371,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5201,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6371,"open_issues":5201,"watchers":41387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/67592"},"html":{"href":"https://github.com/rust-lang/rust/pull/67592"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/67592"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/67592/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/67592/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/67592/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/5268d00688f400720c029eb84f5829af03b8de8e"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"Centril"}}