payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/284670357","pull_request_review_id":238344753,"id":284670357,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDY3MDM1Nw==","diff_hunk":"@@ -35,41 +35,110 @@ metadata:\n ----\n <1> If a label has been added it appears under `labels`.\n \n-.. If a label is not present, add a key/value pair:\n+.. If the label is not present, add a key/value pair:\n +\n ----\n $ oc label machineconfigpool worker custom-kubelet=small-pods\n ----\n \n .Procedure\n \n-. Create a Custom Resource (CR) for your configuration change.\n+. Configure container garbage collection:\n+\n+.. Create a Custom Resource (CR) for your configuration change.\n +\n-.Sample configuration for a *garbage* CR\n+.Sample configuration for a container garbage collection CR:\n [source,yaml]\n ----\n apiVersion: machineconfiguration.openshift.io/v1\n kind: KubeletConfig\n metadata:\n-  name: set-garbage-collection <1>\n+  name: gc-container <1>\n spec:\n-  machineConfigPoolSelector:\n+  machineConfigSelector:\n     matchLabels:\n       custom-kubelet: small-pods <2>\n-  kubeletConfig:\n-    ImageMinimumGCAge: 0 <3>\n-    ImageGCHighThresholdPercent: 85 <4>\n-    ImageGCLowThresholdPercent: 80 <5>\n-----\n-<1> Assign a name to CR.\n-<2> Specify the label to apply the configuration change.\n-<3> Specify the minimum age for an unused image before it is garbage collected. A value of `0` means no limit.\n-<4> Specify the percent of disk usage after which image garbage collection is always run.\n-<5> Specify the percent of disk usage before which image garbage collection is never run.\n-\n-. Create the garbage collection object:\n+  kubeletArguments:\n+    eviction-soft: <3>\n+    - memory.available<100Mi <4>\n+    - nodefs.available<10%\n+    - nodefs.inodesFree<5%\n+    - imagefs.available<15%\n+    - imagefs.inodesFree<10%\n+    eviction-soft-grace-period: <5>\n+    - memory.available=1m30s\n+    - nodefs.available=1m30s\n+    - nodefs.inodesFree=1m30s\n+    - imagefs.available=1m30s\n+    - imagefs.inodesFree=1m30s\n+----\n+<1> Name for the object.\n+<2> Selector label.\n+<3> Type of eviction: `eviction-soft` or `eviction-hard`.\n+<4> Eviction thresholds based on a specific eviction trigger signal.\n+<5> Grace periods for the soft eviction. This parameter does not apply to `eviction-hard`.\n+\n+.. Create the object:\n +\n ----\n-oc create -f <file-name>.yaml\n+$ oc create -f <file-name>.yaml\n+----\n++\n+For example:\n++\n+----\n+oc create -f gc-container.yaml\n+\n+kubeletconfig.machineconfiguration.openshift.io/gc-container created\n ----\n \n+. Configure image garbage collection:\n+\n+.. Create a Custom Resource (CR) for your configuration change.\n++\n+.Sample configuration for an image garbage collection CR:\n+[source,yaml]\n+----\n+apiVersion: machineconfiguration.openshift.io/v1\n+kind: KubeletConfig\n+metadata:\n+  name: gc-image <1>\n+spec:\n+  machineConfigSelector:\n+    matchLabels:\n+      custom-kubelet: small-pods <2>\n+  kubeletArguments:","path":"modules/nodes-nodes-garbage-collection-configuring.adoc","position":null,"original_position":105,"commit_id":"d4d8eb22f3a158713598130430a8714b11ef2f40","original_commit_id":"f7f36b8a20d599f0c438991cad09532c18cab330","user":{"login":"weinliu","id":36030569,"node_id":"MDQ6VXNlcjM2MDMwNTY5","avatar_url":"https://avatars1.githubusercontent.com/u/36030569?v=4","gravatar_id":"","url":"https://api.github.com/users/weinliu","html_url":"https://github.com/weinliu","followers_url":"https://api.github.com/users/weinliu/followers","following_url":"https://api.github.com/users/weinliu/following{/other_user}","gists_url":"https://api.github.com/users/weinliu/gists{/gist_id}","starred_url":"https://api.github.com/users/weinliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinliu/subscriptions","organizations_url":"https://api.github.com/users/weinliu/orgs","repos_url":"https://api.github.com/users/weinliu/repos","events_url":"https://api.github.com/users/weinliu/events{/privacy}","received_events_url":"https://api.github.com/users/weinliu/received_events","type":"User","site_admin":false},"body":"machineConfigSelector => machineConfigPoolSelector","created_at":"2019-05-16T11:58:17Z","updated_at":"2019-05-16T11:58:18Z","html_url":"https://github.com/openshift/openshift-docs/pull/14453#discussion_r284670357","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/284670357"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/14453#discussion_r284670357"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453"}},"in_reply_to_id":284284571},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453","id":270604786,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNjA0Nzg2","html_url":"https://github.com/openshift/openshift-docs/pull/14453","diff_url":"https://github.com/openshift/openshift-docs/pull/14453.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/14453.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/14453","number":14453,"state":"open","locked":false,"title":"Garbage Collection fka Nodes docs feedback 4","user":{"login":"mburke5678","id":25209155,"node_id":"MDQ6VXNlcjI1MjA5MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/25209155?v=4","gravatar_id":"","url":"https://api.github.com/users/mburke5678","html_url":"https://github.com/mburke5678","followers_url":"https://api.github.com/users/mburke5678/followers","following_url":"https://api.github.com/users/mburke5678/following{/other_user}","gists_url":"https://api.github.com/users/mburke5678/gists{/gist_id}","starred_url":"https://api.github.com/users/mburke5678/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mburke5678/subscriptions","organizations_url":"https://api.github.com/users/mburke5678/orgs","repos_url":"https://api.github.com/users/mburke5678/repos","events_url":"https://api.github.com/users/mburke5678/events{/privacy}","received_events_url":"https://api.github.com/users/mburke5678/received_events","type":"User","site_admin":false},"body":"Comments per @sunilcio \r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1688637#c11","created_at":"2019-04-15T17:20:04Z","updated_at":"2019-05-16T11:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3abc31a862e9d067edb386a69df73ffbe15eae9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1063092795,"node_id":"MDU6TGFiZWwxMDYzMDkyNzk1","url":"https://api.github.com/repos/openshift/openshift-docs/labels/branch/enterprise-4.1","name":"branch/enterprise-4.1","color":"77dd9e","default":false},{"id":1153951703,"node_id":"MDU6TGFiZWwxMTUzOTUxNzAz","url":"https://api.github.com/repos/openshift/openshift-docs/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":751797317,"node_id":"MDU6TGFiZWw3NTE3OTczMTc=","url":"https://api.github.com/repos/openshift/openshift-docs/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":{"url":"https://api.github.com/repos/openshift/openshift-docs/milestones/6","html_url":"https://github.com/openshift/openshift-docs/milestone/6","labels_url":"https://api.github.com/repos/openshift/openshift-docs/milestones/6/labels","id":1435997,"node_id":"MDk6TWlsZXN0b25lMTQzNTk5Nw==","number":6,"title":"Future Release","description":"Tracker for content relevant to latest Origin code, but still targeting a future release of Enterprise, Dedicated, and/or Online.","creator":{"login":"adellape","id":3442316,"node_id":"MDQ6VXNlcjM0NDIzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3442316?v=4","gravatar_id":"","url":"https://api.github.com/users/adellape","html_url":"https://github.com/adellape","followers_url":"https://api.github.com/users/adellape/followers","following_url":"https://api.github.com/users/adellape/following{/other_user}","gists_url":"https://api.github.com/users/adellape/gists{/gist_id}","starred_url":"https://api.github.com/users/adellape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adellape/subscriptions","organizations_url":"https://api.github.com/users/adellape/orgs","repos_url":"https://api.github.com/users/adellape/repos","events_url":"https://api.github.com/users/adellape/events{/privacy}","received_events_url":"https://api.github.com/users/adellape/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":479,"state":"open","created_at":"2015-11-30T20:14:06Z","updated_at":"2019-05-15T21:14:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/14453/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/d4d8eb22f3a158713598130430a8714b11ef2f40","head":{"label":"mburke5678:BZ-1688637-4","ref":"BZ-1688637-4","sha":"d4d8eb22f3a158713598130430a8714b11ef2f40","user":{"login":"mburke5678","id":25209155,"node_id":"MDQ6VXNlcjI1MjA5MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/25209155?v=4","gravatar_id":"","url":"https://api.github.com/users/mburke5678","html_url":"https://github.com/mburke5678","followers_url":"https://api.github.com/users/mburke5678/followers","following_url":"https://api.github.com/users/mburke5678/following{/other_user}","gists_url":"https://api.github.com/users/mburke5678/gists{/gist_id}","starred_url":"https://api.github.com/users/mburke5678/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mburke5678/subscriptions","organizations_url":"https://api.github.com/users/mburke5678/orgs","repos_url":"https://api.github.com/users/mburke5678/repos","events_url":"https://api.github.com/users/mburke5678/events{/privacy}","received_events_url":"https://api.github.com/users/mburke5678/received_events","type":"User","site_admin":false},"repo":{"id":81145217,"node_id":"MDEwOlJlcG9zaXRvcnk4MTE0NTIxNw==","name":"openshift-docs","full_name":"mburke5678/openshift-docs","private":false,"owner":{"login":"mburke5678","id":25209155,"node_id":"MDQ6VXNlcjI1MjA5MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/25209155?v=4","gravatar_id":"","url":"https://api.github.com/users/mburke5678","html_url":"https://github.com/mburke5678","followers_url":"https://api.github.com/users/mburke5678/followers","following_url":"https://api.github.com/users/mburke5678/following{/other_user}","gists_url":"https://api.github.com/users/mburke5678/gists{/gist_id}","starred_url":"https://api.github.com/users/mburke5678/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mburke5678/subscriptions","organizations_url":"https://api.github.com/users/mburke5678/orgs","repos_url":"https://api.github.com/users/mburke5678/repos","events_url":"https://api.github.com/users/mburke5678/events{/privacy}","received_events_url":"https://api.github.com/users/mburke5678/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mburke5678/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/mburke5678/openshift-docs","forks_url":"https://api.github.com/repos/mburke5678/openshift-docs/forks","keys_url":"https://api.github.com/repos/mburke5678/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mburke5678/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mburke5678/openshift-docs/teams","hooks_url":"https://api.github.com/repos/mburke5678/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/mburke5678/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/mburke5678/openshift-docs/events","assignees_url":"https://api.github.com/repos/mburke5678/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/mburke5678/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/mburke5678/openshift-docs/tags","blobs_url":"https://api.github.com/repos/mburke5678/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mburke5678/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mburke5678/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mburke5678/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mburke5678/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/mburke5678/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/mburke5678/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/mburke5678/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/mburke5678/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/mburke5678/openshift-docs/subscription","commits_url":"https://api.github.com/repos/mburke5678/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mburke5678/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mburke5678/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mburke5678/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mburke5678/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/mburke5678/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mburke5678/openshift-docs/merges","archive_url":"https://api.github.com/repos/mburke5678/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mburke5678/openshift-docs/downloads","issues_url":"https://api.github.com/repos/mburke5678/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/mburke5678/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/mburke5678/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/mburke5678/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mburke5678/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/mburke5678/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/mburke5678/openshift-docs/deployments","created_at":"2017-02-06T23:41:14Z","updated_at":"2019-05-13T13:47:51Z","pushed_at":"2019-05-15T17:53:51Z","git_url":"git://github.com/mburke5678/openshift-docs.git","ssh_url":"git@github.com:mburke5678/openshift-docs.git","clone_url":"https://github.com/mburke5678/openshift-docs.git","svn_url":"https://github.com/mburke5678/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":94971,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"enterprise-4.1"}},"base":{"label":"openshift:enterprise-4.1","ref":"enterprise-4.1","sha":"9a1b5c702acb26accdc3bdf3d7d3b7f6a2fc9783","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MDg0NA==","name":"openshift-docs","full_name":"openshift/openshift-docs","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2019-05-16T08:34:38Z","pushed_at":"2019-05-16T08:19:43Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":95474,"stargazers_count":282,"watchers_count":282,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":710,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":355,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":710,"open_issues":355,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/14453"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/14453"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/14453/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/14453/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/d4d8eb22f3a158713598130430a8714b11ef2f40"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"weinliu"}}