payload: {"action":"closed","number":3825,"pull_request":{"url":"https://api.github.com/repos/microsoft/terminal/pulls/3825","id":348513047,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4NTEzMDQ3","html_url":"https://github.com/microsoft/terminal/pull/3825","diff_url":"https://github.com/microsoft/terminal/pull/3825.diff","patch_url":"https://github.com/microsoft/terminal/pull/3825.patch","issue_url":"https://api.github.com/repos/microsoft/terminal/issues/3825","number":3825,"state":"closed","locked":false,"title":"Add support for new panes with specifc profiles and other settings overrides","user":{"login":"zadjii-msft","id":18356694,"node_id":"MDQ6VXNlcjE4MzU2Njk0","avatar_url":"https://avatars3.githubusercontent.com/u/18356694?v=4","gravatar_id":"","url":"https://api.github.com/users/zadjii-msft","html_url":"https://github.com/zadjii-msft","followers_url":"https://api.github.com/users/zadjii-msft/followers","following_url":"https://api.github.com/users/zadjii-msft/following{/other_user}","gists_url":"https://api.github.com/users/zadjii-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/zadjii-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zadjii-msft/subscriptions","organizations_url":"https://api.github.com/users/zadjii-msft/orgs","repos_url":"https://api.github.com/users/zadjii-msft/repos","events_url":"https://api.github.com/users/zadjii-msft/events{/privacy}","received_events_url":"https://api.github.com/users/zadjii-msft/received_events","type":"User","site_admin":false},"body":"## Summary of the Pull Request\r\n\r\n\r\nThis enables the user to set a number of extra settings in the `NewTab` and `SplitPane` `ShortcutAction`s, that enable customizing how a new terminal is created at runtime. The following four properties were added:\r\n* `profile`\r\n* `commandline`\r\n* `tabTitle`\r\n* `startingDirectory`\r\n\r\n`profile` can be used with either a GUID or the name of a profile, and the action will launch that profile instead of the default.\r\n\r\n`commandline`, `tabTitle`, and `startingDirectory` can all be used to override the profile's values of those settings. This will be more useful for #607.\r\n\r\nWith this PR, you can make bindings like the following:\r\n\r\n```json\r\n\r\n{ \"keys\": [\"ctrl+a\"], \"command\": { \"action\": \"splitPane\", \"split\": \"vertical\" } },\r\n{ \"keys\": [\"ctrl+b\"], \"command\": { \"action\": \"splitPane\", \"split\": \"vertical\", \"profile\": \"{6239a42c-1111-49a3-80bd-e8fdd045185c}\" } },\r\n{ \"keys\": [\"ctrl+c\"], \"command\": { \"action\": \"splitPane\", \"split\": \"vertical\", \"profile\": \"profile1\" } },\r\n{ \"keys\": [\"ctrl+d\"], \"command\": { \"action\": \"splitPane\", \"split\": \"vertical\", \"profile\": \"profile2\" } },\r\n{ \"keys\": [\"ctrl+e\"], \"command\": { \"action\": \"splitPane\", \"split\": \"horizontal\", \"commandline\": \"foo.exe\" } },\r\n{ \"keys\": [\"ctrl+f\"], \"command\": { \"action\": \"splitPane\", \"split\": \"horizontal\", \"profile\": \"profile1\", \"commandline\": \"foo.exe\" } },\r\n{ \"keys\": [\"ctrl+g\"], \"command\": { \"action\": \"newTab\" } },\r\n{ \"keys\": [\"ctrl+h\"], \"command\": { \"action\": \"newTab\", \"startingDirectory\": \"c:\\\\foo\" } },\r\n{ \"keys\": [\"ctrl+i\"], \"command\": { \"action\": \"newTab\", \"profile\": \"profile2\", \"startingDirectory\": \"c:\\\\foo\" } },\r\n{ \"keys\": [\"ctrl+j\"], \"command\": { \"action\": \"newTab\", \"tabTitle\": \"bar\" } },\r\n{ \"keys\": [\"ctrl+k\"], \"command\": { \"action\": \"newTab\", \"profile\": \"profile2\", \"tabTitle\": \"bar\" } },\r\n{ \"keys\": [\"ctrl+l\"], \"command\": { \"action\": \"newTab\", \"profile\": \"profile1\", \"tabTitle\": \"bar\", \"startingDirectory\": \"c:\\\\foo\", \"commandline\":\"foo.exe\" } }\r\n```\r\n\r\n## References\r\n\r\nThis is a lot of work that was largely started in pursuit of #607. We want people to be able to override these properties straight from the commandline. While they may not make as much sense as keybindings like this, they'll make more sense as commandline arguments.\r\n\r\n## PR Checklist\r\n* [x] Closes #998\r\n* [x] I work here\r\n* [x] Tests added/passed\r\n* [x] Requires documentation to be updated\r\n\r\n## Validation Steps Performed\r\nThere are tests 🎉\r\n\r\nManually added some bindings, they opened the correct profiles in panes/tabs","created_at":"2019-12-03T19:37:58Z","updated_at":"2019-12-09T13:02:31Z","closed_at":"2019-12-09T13:02:31Z","merged_at":"2019-12-09T13:02:30Z","merge_commit_sha":"dd1c7b3e525b5f4b03642e10602e1154e36d8a9a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"miniksa","id":18221333,"node_id":"MDQ6VXNlcjE4MjIxMzMz","avatar_url":"https://avatars0.githubusercontent.com/u/18221333?v=4","gravatar_id":"","url":"https://api.github.com/users/miniksa","html_url":"https://github.com/miniksa","followers_url":"https://api.github.com/users/miniksa/followers","following_url":"https://api.github.com/users/miniksa/following{/other_user}","gists_url":"https://api.github.com/users/miniksa/gists{/gist_id}","starred_url":"https://api.github.com/users/miniksa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miniksa/subscriptions","organizations_url":"https://api.github.com/users/miniksa/orgs","repos_url":"https://api.github.com/users/miniksa/repos","events_url":"https://api.github.com/users/miniksa/events{/privacy}","received_events_url":"https://api.github.com/users/miniksa/received_events","type":"User","site_admin":false},{"login":"leonMSFT","id":57155886,"node_id":"MDQ6VXNlcjU3MTU1ODg2","avatar_url":"https://avatars0.githubusercontent.com/u/57155886?v=4","gravatar_id":"","url":"https://api.github.com/users/leonMSFT","html_url":"https://github.com/leonMSFT","followers_url":"https://api.github.com/users/leonMSFT/followers","following_url":"https://api.github.com/users/leonMSFT/following{/other_user}","gists_url":"https://api.github.com/users/leonMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/leonMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonMSFT/subscriptions","organizations_url":"https://api.github.com/users/leonMSFT/orgs","repos_url":"https://api.github.com/users/leonMSFT/repos","events_url":"https://api.github.com/users/leonMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/leonMSFT/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1355048958,"node_id":"MDU6TGFiZWwxMzU1MDQ4OTU4","url":"https://api.github.com/repos/microsoft/terminal/labels/Area-Settings","name":"Area-Settings","color":"005ab4","default":false,"description":"Issues related to settings and customizability, for console or terminal"},{"id":1364956924,"node_id":"MDU6TGFiZWwxMzY0OTU2OTI0","url":"https://api.github.com/repos/microsoft/terminal/labels/AutoMerge","name":"AutoMerge","color":"10ff10","default":false,"description":"Marked for automatic merge by the bot when requirements are met"},{"id":1364939389,"node_id":"MDU6TGFiZWwxMzY0OTM5Mzg5","url":"https://api.github.com/repos/microsoft/terminal/labels/Product-Terminal","name":"Product-Terminal","color":"590059","default":false,"description":"The new Windows Terminal."}],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/terminal/pulls/3825/commits","review_comments_url":"https://api.github.com/repos/microsoft/terminal/pulls/3825/comments","review_comment_url":"https://api.github.com/repos/microsoft/terminal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/terminal/issues/3825/comments","statuses_url":"https://api.github.com/repos/microsoft/terminal/statuses/b8eecb6497c0f4c9e160357d02db0a0905c906ed","head":{"label":"microsoft:dev/migrie/f/new-terminal-args","ref":"dev/migrie/f/new-terminal-args","sha":"b8eecb6497c0f4c9e160357d02db0a0905c906ed","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":100060912,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjA5MTI=","name":"terminal","full_name":"microsoft/terminal","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/terminal","description":"The new Windows Terminal, and the original Windows console host - all in the same place!","fork":false,"url":"https://api.github.com/repos/microsoft/terminal","forks_url":"https://api.github.com/repos/microsoft/terminal/forks","keys_url":"https://api.github.com/repos/microsoft/terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/terminal/teams","hooks_url":"https://api.github.com/repos/microsoft/terminal/hooks","issue_events_url":"https://api.github.com/repos/microsoft/terminal/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/terminal/events","assignees_url":"https://api.github.com/repos/microsoft/terminal/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/terminal/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/terminal/tags","blobs_url":"https://api.github.com/repos/microsoft/terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/terminal/languages","stargazers_url":"https://api.github.com/repos/microsoft/terminal/stargazers","contributors_url":"https://api.github.com/repos/microsoft/terminal/contributors","subscribers_url":"https://api.github.com/repos/microsoft/terminal/subscribers","subscription_url":"https://api.github.com/repos/microsoft/terminal/subscription","commits_url":"https://api.github.com/repos/microsoft/terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/terminal/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/terminal/merges","archive_url":"https://api.github.com/repos/microsoft/terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/terminal/downloads","issues_url":"https://api.github.com/repos/microsoft/terminal/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/terminal/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/terminal/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/terminal/deployments","created_at":"2017-08-11T18:38:22Z","updated_at":"2019-12-09T12:59:18Z","pushed_at":"2019-12-09T13:02:32Z","git_url":"git://github.com/microsoft/terminal.git","ssh_url":"git@github.com:microsoft/terminal.git","clone_url":"https://github.com/microsoft/terminal.git","svn_url":"https://github.com/microsoft/terminal","homepage":"","size":53288,"stargazers_count":55288,"watchers_count":55288,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5346,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":831,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5346,"open_issues":831,"watchers":55288,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"9145903e118bfa3b48749694689aec3a191bc4ac","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":100060912,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjA5MTI=","name":"terminal","full_name":"microsoft/terminal","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/terminal","description":"The new Windows Terminal, and the original Windows console host - all in the same place!","fork":false,"url":"https://api.github.com/repos/microsoft/terminal","forks_url":"https://api.github.com/repos/microsoft/terminal/forks","keys_url":"https://api.github.com/repos/microsoft/terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/terminal/teams","hooks_url":"https://api.github.com/repos/microsoft/terminal/hooks","issue_events_url":"https://api.github.com/repos/microsoft/terminal/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/terminal/events","assignees_url":"https://api.github.com/repos/microsoft/terminal/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/terminal/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/terminal/tags","blobs_url":"https://api.github.com/repos/microsoft/terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/terminal/languages","stargazers_url":"https://api.github.com/repos/microsoft/terminal/stargazers","contributors_url":"https://api.github.com/repos/microsoft/terminal/contributors","subscribers_url":"https://api.github.com/repos/microsoft/terminal/subscribers","subscription_url":"https://api.github.com/repos/microsoft/terminal/subscription","commits_url":"https://api.github.com/repos/microsoft/terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/terminal/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/terminal/merges","archive_url":"https://api.github.com/repos/microsoft/terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/terminal/downloads","issues_url":"https://api.github.com/repos/microsoft/terminal/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/terminal/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/terminal/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/terminal/deployments","created_at":"2017-08-11T18:38:22Z","updated_at":"2019-12-09T12:59:18Z","pushed_at":"2019-12-09T13:02:32Z","git_url":"git://github.com/microsoft/terminal.git","ssh_url":"git@github.com:microsoft/terminal.git","clone_url":"https://github.com/microsoft/terminal.git","svn_url":"https://github.com/microsoft/terminal","homepage":"","size":53288,"stargazers_count":55288,"watchers_count":55288,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5346,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":831,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5346,"open_issues":831,"watchers":55288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/3825"},"html":{"href":"https://github.com/microsoft/terminal/pull/3825"},"issue":{"href":"https://api.github.com/repos/microsoft/terminal/issues/3825"},"comments":{"href":"https://api.github.com/repos/microsoft/terminal/issues/3825/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/3825/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/3825/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/terminal/statuses/b8eecb6497c0f4c9e160357d02db0a0905c906ed"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"msftbot[bot]","id":48340428,"node_id":"MDM6Qm90NDgzNDA0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/in/26612?v=4","gravatar_id":"","url":"https://api.github.com/users/msftbot%5Bbot%5D","html_url":"https://github.com/apps/msftbot","followers_url":"https://api.github.com/users/msftbot%5Bbot%5D/followers","following_url":"https://api.github.com/users/msftbot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/msftbot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/msftbot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftbot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/msftbot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/msftbot%5Bbot%5D/repos","events_url":"https://api.github.com/users/msftbot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/msftbot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":3,"review_comments":28,"maintainer_can_modify":false,"commits":33,"additions":718,"deletions":171,"changed_files":15}}
other: {"actor":{"display_login":"msftbot"}}