payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments/269404477","pull_request_review_id":219266410,"id":269404477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTQwNDQ3Nw==","diff_hunk":"@@ -255,93 +243,153 @@ func testProxNetwork(t *testing.T) {\n \t\t// context deadline exceeded\n \t\t// however, it might just mean that not all possible messages are received\n \t\t// now we must check if all required messages are received\n-\t\tcnt := tstdata.getMsgCount()\n-\t\tlog.Debug(\"TestProxNetwork finished\", \"rcv\", cnt)\n-\t\tif cnt < tstdata.requiredMessages {\n+\t\tlog.Debug(\"TestProxNetwork finished\", \"rcv\", tstdata.getMsgCount())\n+\t\tif !isSuccess(tstdata) {\n \t\t\tt.Fatal(result.Error)\n \t\t}\n \t}\n-\tt.Logf(\"completed %d\", result.Duration)\n }\n \n-func (tstdata *testData) sendAllMsgs() {\n+func isSuccess(d *testData) bool {\n+\tcnt := d.getMsgCount()\n+\tif cnt < d.requiredMessages {\n+\t\tif d.isExpectationsChanged() {\n+\t\t\t// network configuration has changed since beginning of","path":"swarm/pss/prox_test.go","position":153,"original_position":153,"commit_id":"9a0be3c0d3906248ea3fba605d3765818e76b2d4","original_commit_id":"9a0be3c0d3906248ea3fba605d3765818e76b2d4","user":{"login":"zelig","id":769725,"node_id":"MDQ6VXNlcjc2OTcyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/769725?v=4","gravatar_id":"","url":"https://api.github.com/users/zelig","html_url":"https://github.com/zelig","followers_url":"https://api.github.com/users/zelig/followers","following_url":"https://api.github.com/users/zelig/following{/other_user}","gists_url":"https://api.github.com/users/zelig/gists{/gist_id}","starred_url":"https://api.github.com/users/zelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelig/subscriptions","organizations_url":"https://api.github.com/users/zelig/orgs","repos_url":"https://api.github.com/users/zelig/repos","events_url":"https://api.github.com/users/zelig/events{/privacy}","received_events_url":"https://api.github.com/users/zelig/received_events","type":"User","site_admin":false},"body":"why would this happen  in this  test? it really should not","created_at":"2019-03-27T04:48:17Z","updated_at":"2019-03-27T04:48:32Z","html_url":"https://github.com/ethersphere/go-ethereum/pull/1319#discussion_r269404477","pull_request_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments/269404477"},"html":{"href":"https://github.com/ethersphere/go-ethereum/pull/1319#discussion_r269404477"},"pull_request":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319"}}},"pull_request":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319","id":264570968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NTcwOTY4","html_url":"https://github.com/ethersphere/go-ethereum/pull/1319","diff_url":"https://github.com/ethersphere/go-ethereum/pull/1319.diff","patch_url":"https://github.com/ethersphere/go-ethereum/pull/1319.patch","issue_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1319","number":1319,"state":"open","locked":false,"title":"Flaky TestProxNetwork fixed ","user":{"login":"gluk256","id":9915581,"node_id":"MDQ6VXNlcjk5MTU1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/9915581?v=4","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"body":"Apparently, the problems were caused by a blocked channel. Reading function exits, another function writes to the channel, and it's blocked, since nobody reads.\r\n\r\nAlso, closes https://github.com/ethersphere/go-ethereum/issues/1308","created_at":"2019-03-26T15:26:33Z","updated_at":"2019-03-27T04:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e111d8597b7bae0a3828c8fc0da8ef3c2158a88","assignee":{"login":"gluk256","id":9915581,"node_id":"MDQ6VXNlcjk5MTU1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/9915581?v=4","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"assignees":[{"login":"gluk256","id":9915581,"node_id":"MDQ6VXNlcjk5MTU1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/9915581?v=4","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"frncmx","id":1735667,"node_id":"MDQ6VXNlcjE3MzU2Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1735667?v=4","gravatar_id":"","url":"https://api.github.com/users/frncmx","html_url":"https://github.com/frncmx","followers_url":"https://api.github.com/users/frncmx/followers","following_url":"https://api.github.com/users/frncmx/following{/other_user}","gists_url":"https://api.github.com/users/frncmx/gists{/gist_id}","starred_url":"https://api.github.com/users/frncmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frncmx/subscriptions","organizations_url":"https://api.github.com/users/frncmx/orgs","repos_url":"https://api.github.com/users/frncmx/repos","events_url":"https://api.github.com/users/frncmx/events{/privacy}","received_events_url":"https://api.github.com/users/frncmx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319/commits","review_comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319/comments","review_comment_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1319/comments","statuses_url":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/9a0be3c0d3906248ea3fba605d3765818e76b2d4","head":{"label":"gluk256:611-flaky","ref":"611-flaky","sha":"9a0be3c0d3906248ea3fba605d3765818e76b2d4","user":{"login":"gluk256","id":9915581,"node_id":"MDQ6VXNlcjk5MTU1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/9915581?v=4","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"repo":{"id":60187660,"node_id":"MDEwOlJlcG9zaXRvcnk2MDE4NzY2MA==","name":"go-ethereum","full_name":"gluk256/go-ethereum","private":false,"owner":{"login":"gluk256","id":9915581,"node_id":"MDQ6VXNlcjk5MTU1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/9915581?v=4","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gluk256/go-ethereum","description":"Official golang implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/gluk256/go-ethereum","forks_url":"https://api.github.com/repos/gluk256/go-ethereum/forks","keys_url":"https://api.github.com/repos/gluk256/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluk256/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluk256/go-ethereum/teams","hooks_url":"https://api.github.com/repos/gluk256/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/gluk256/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/gluk256/go-ethereum/events","assignees_url":"https://api.github.com/repos/gluk256/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/gluk256/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/gluk256/go-ethereum/tags","blobs_url":"https://api.github.com/repos/gluk256/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluk256/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluk256/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluk256/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluk256/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/gluk256/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/gluk256/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/gluk256/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/gluk256/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/gluk256/go-ethereum/subscription","commits_url":"https://api.github.com/repos/gluk256/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluk256/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluk256/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluk256/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluk256/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/gluk256/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluk256/go-ethereum/merges","archive_url":"https://api.github.com/repos/gluk256/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluk256/go-ethereum/downloads","issues_url":"https://api.github.com/repos/gluk256/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/gluk256/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/gluk256/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/gluk256/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluk256/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/gluk256/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/gluk256/go-ethereum/deployments","created_at":"2016-06-01T15:11:56Z","updated_at":"2019-01-29T23:29:00Z","pushed_at":"2019-03-26T15:23:09Z","git_url":"git://github.com/gluk256/go-ethereum.git","ssh_url":"git@github.com:gluk256/go-ethereum.git","clone_url":"https://github.com/gluk256/go-ethereum.git","svn_url":"https://github.com/gluk256/go-ethereum","homepage":"http://ethereum.github.io/go-ethereum/","size":114718,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ethersphere:master","ref":"master","sha":"acbb8a1439a8c2c7bb879a10170423bfe03d8484","user":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"repo":{"id":17790136,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MDEzNg==","name":"go-ethereum","full_name":"ethersphere/go-ethereum","private":false,"owner":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethersphere/go-ethereum","description":"Ethereum Go","fork":true,"url":"https://api.github.com/repos/ethersphere/go-ethereum","forks_url":"https://api.github.com/repos/ethersphere/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethersphere/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethersphere/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethersphere/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethersphere/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethersphere/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethersphere/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethersphere/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethersphere/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethersphere/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethersphere/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethersphere/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethersphere/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethersphere/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethersphere/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethersphere/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethersphere/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethersphere/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethersphere/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethersphere/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethersphere/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethersphere/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethersphere/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethersphere/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethersphere/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethersphere/go-ethereum/deployments","created_at":"2014-03-16T02:06:34Z","updated_at":"2019-03-25T13:47:00Z","pushed_at":"2019-03-27T01:52:28Z","git_url":"git://github.com/ethersphere/go-ethereum.git","ssh_url":"git@github.com:ethersphere/go-ethereum.git","clone_url":"https://github.com/ethersphere/go-ethereum.git","svn_url":"https://github.com/ethersphere/go-ethereum","homepage":"","size":118412,"stargazers_count":121,"watchers_count":121,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":230,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":40,"open_issues":230,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319"},"html":{"href":"https://github.com/ethersphere/go-ethereum/pull/1319"},"issue":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1319"},"comments":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1319/comments"},"review_comments":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319/comments"},"review_comment":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/pulls/1319/commits"},"statuses":{"href":"https://api.github.com/repos/ethersphere/go-ethereum/statuses/9a0be3c0d3906248ea3fba605d3765818e76b2d4"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"zelig"}}