payload: {"action":"closed","number":20733,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/20733","id":251341441,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMzQxNDQx","html_url":"https://github.com/ampproject/amphtml/pull/20733","diff_url":"https://github.com/ampproject/amphtml/pull/20733.diff","patch_url":"https://github.com/ampproject/amphtml/pull/20733.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/20733","number":20733,"state":"closed","locked":false,"title":"✨ Implement arrows for carousel v2.","user":{"login":"sparhami","id":1410321,"node_id":"MDQ6VXNlcjE0MTAzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1410321?v=4","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"body":"- Implement `getElementCssValue`\r\n- Fix e2e target's file argument.\r\n- Split carousel internal CSS from amp-carousel CSS.\r\n- Only update the current index when scrolling has stopped.\r\n- Add arrows with default UX.\r\n  * Hide arrows when not looping and at the start/end.\r\n  * Hide arrows when the user has navigated via touch.\r\n- Add manual test for overriding arrows.\r\n- Track / propagate the source of navigation in the carousel.\r\n- Trigger an action when the index changes with HIGH or LOW trust,\r\ndepending on the source of the change.\r\n\r\n@nainar This PR hides the arrows when the user has manually swiped to another slide (not just interacted with it, so if they release before swiping to a new slide, we keep the arrows). For a MVP this is might be fine, but we may want something better.\r\n@aghassemi I believe we discussed this at some point, but wanted to make sure that we did want to always trigger the action, but with HIGH or LOW trust (rather then not triggering the action at all in the LOW trust case).\r\n/cc @cvializ Made some small changes to e2e files and added a test. Feel free to review as well!\r\n","created_at":"2019-02-08T03:23:14Z","updated_at":"2019-02-11T22:56:17Z","closed_at":"2019-02-11T22:56:17Z","merged_at":"2019-02-11T22:56:17Z","merge_commit_sha":"45046f5d1964ddb75d498601ba5d1281ae735491","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20733/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20733/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/20733/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/a151426212df79c9d1682f777a379d61e59ee5e8","head":{"label":"sparhami:carousel_2_arrows","ref":"carousel_2_arrows","sha":"a151426212df79c9d1682f777a379d61e59ee5e8","user":{"login":"sparhami","id":1410321,"node_id":"MDQ6VXNlcjE0MTAzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1410321?v=4","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"repo":{"id":136093392,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwOTMzOTI=","name":"amphtml","full_name":"sparhami/amphtml","private":false,"owner":{"login":"sparhami","id":1410321,"node_id":"MDQ6VXNlcjE0MTAzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1410321?v=4","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sparhami/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/sparhami/amphtml","forks_url":"https://api.github.com/repos/sparhami/amphtml/forks","keys_url":"https://api.github.com/repos/sparhami/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparhami/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparhami/amphtml/teams","hooks_url":"https://api.github.com/repos/sparhami/amphtml/hooks","issue_events_url":"https://api.github.com/repos/sparhami/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/sparhami/amphtml/events","assignees_url":"https://api.github.com/repos/sparhami/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/sparhami/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/sparhami/amphtml/tags","blobs_url":"https://api.github.com/repos/sparhami/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparhami/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparhami/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparhami/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparhami/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/sparhami/amphtml/languages","stargazers_url":"https://api.github.com/repos/sparhami/amphtml/stargazers","contributors_url":"https://api.github.com/repos/sparhami/amphtml/contributors","subscribers_url":"https://api.github.com/repos/sparhami/amphtml/subscribers","subscription_url":"https://api.github.com/repos/sparhami/amphtml/subscription","commits_url":"https://api.github.com/repos/sparhami/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparhami/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparhami/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparhami/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparhami/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/sparhami/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparhami/amphtml/merges","archive_url":"https://api.github.com/repos/sparhami/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparhami/amphtml/downloads","issues_url":"https://api.github.com/repos/sparhami/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/sparhami/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/sparhami/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/sparhami/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparhami/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/sparhami/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/sparhami/amphtml/deployments","created_at":"2018-06-04T23:23:37Z","updated_at":"2019-01-23T23:14:05Z","pushed_at":"2019-02-11T22:21:54Z","git_url":"git://github.com/sparhami/amphtml.git","ssh_url":"git@github.com:sparhami/amphtml.git","clone_url":"https://github.com/sparhami/amphtml.git","svn_url":"https://github.com/sparhami/amphtml","homepage":"https://www.ampproject.org","size":577865,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"9895d70e8afc9e2ac5e38655e5509c57f87c98d1","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"The AMP web component library.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2019-02-11T22:15:19Z","pushed_at":"2019-02-11T22:56:17Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":577150,"stargazers_count":12328,"watchers_count":12328,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2796,"mirror_url":null,"archived":false,"open_issues_count":1544,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2796,"open_issues":1544,"watchers":12328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20733"},"html":{"href":"https://github.com/ampproject/amphtml/pull/20733"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/20733"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/20733/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20733/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20733/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/a151426212df79c9d1682f777a379d61e59ee5e8"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sparhami","id":1410321,"node_id":"MDQ6VXNlcjE0MTAzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1410321?v=4","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"comments":3,"review_comments":9,"maintainer_can_modify":false,"commits":3,"additions":593,"deletions":130,"changed_files":11}}
other: {"actor":{"display_login":"sparhami"}}