payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Globulation2/glob2/pulls/comments/361800426","pull_request_review_id":336920318,"id":361800426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTgwMDQyNg==","diff_hunk":"@@ -0,0 +1,10 @@\n+#!/bin/bash","path":"scripts/install_deps","position":1,"original_position":1,"commit_id":"c77578b44f3935b83f3c8eb961350875c26300aa","original_commit_id":"c77578b44f3935b83f3c8eb961350875c26300aa","user":{"login":"richelbilderbeek","id":2098230,"node_id":"MDQ6VXNlcjIwOTgyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2098230?v=4","gravatar_id":"","url":"https://api.github.com/users/richelbilderbeek","html_url":"https://github.com/richelbilderbeek","followers_url":"https://api.github.com/users/richelbilderbeek/followers","following_url":"https://api.github.com/users/richelbilderbeek/following{/other_user}","gists_url":"https://api.github.com/users/richelbilderbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/richelbilderbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richelbilderbeek/subscriptions","organizations_url":"https://api.github.com/users/richelbilderbeek/orgs","repos_url":"https://api.github.com/users/richelbilderbeek/repos","events_url":"https://api.github.com/users/richelbilderbeek/events{/privacy}","received_events_url":"https://api.github.com/users/richelbilderbeek/received_events","type":"User","site_admin":false},"body":"I agree with the reasoning. Go ahead and rename, you're the boss here.","created_at":"2019-12-28T15:43:15Z","updated_at":"2019-12-28T15:43:16Z","html_url":"https://github.com/Globulation2/glob2/pull/6#discussion_r361800426","pull_request_url":"https://api.github.com/repos/Globulation2/glob2/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Globulation2/glob2/pulls/comments/361800426"},"html":{"href":"https://github.com/Globulation2/glob2/pull/6#discussion_r361800426"},"pull_request":{"href":"https://api.github.com/repos/Globulation2/glob2/pulls/6"}},"in_reply_to_id":361800143},"pull_request":{"url":"https://api.github.com/repos/Globulation2/glob2/pulls/6","id":357432338,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3NDMyMzM4","html_url":"https://github.com/Globulation2/glob2/pull/6","diff_url":"https://github.com/Globulation2/glob2/pull/6.diff","patch_url":"https://github.com/Globulation2/glob2/pull/6.patch","issue_url":"https://api.github.com/repos/Globulation2/glob2/issues/6","number":6,"state":"open","locked":false,"title":"Update scons, add Travis, qmake build and tests, fix #2","user":{"login":"richelbilderbeek","id":2098230,"node_id":"MDQ6VXNlcjIwOTgyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2098230?v=4","gravatar_id":"","url":"https://api.github.com/users/richelbilderbeek","html_url":"https://github.com/richelbilderbeek","followers_url":"https://api.github.com/users/richelbilderbeek/followers","following_url":"https://api.github.com/users/richelbilderbeek/following{/other_user}","gists_url":"https://api.github.com/users/richelbilderbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/richelbilderbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richelbilderbeek/subscriptions","organizations_url":"https://api.github.com/users/richelbilderbeek/orgs","repos_url":"https://api.github.com/users/richelbilderbeek/repos","events_url":"https://api.github.com/users/richelbilderbeek/events{/privacy}","received_events_url":"https://api.github.com/users/richelbilderbeek/received_events","type":"User","site_admin":false},"body":"Hi Globulation 2 maintainers,\r\n\r\nAs per [this Issue](https://github.com/Globulation2/glob2/issues/2) I submit this Pull Request.\r\n\r\nChanges:\r\n\r\n * scons now uses `makeVariable` and `Variable` instead of the deprecated `makeOptions` and `Options`\r\n * This is checked by a Travis CI script: upon a commit, the build process is started on a virtual machine, so one can see if a commit breaks a build\r\n * The build is also re-done by a Qt Creator project file, `src/globulation2.pro`\r\n * The build is also re-done by a Qt Creator project file, `src/globulation2_test.pro` that runs the cpptests in the test folder. Although these tests seem rather trivial, my new addition may upon up the path to write more tests in the future\r\n\r\nI volunteer to maintain the `.travis.yml` and `.pro`(and `.pri`) files.\r\n\r\nEnjoy :+1:\r\n\r\n\r\n","created_at":"2019-12-28T10:13:21Z","updated_at":"2019-12-28T15:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f46639fae1606656792a0e663296daeff4b09157","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Globulation2/glob2/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Globulation2/glob2/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Globulation2/glob2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Globulation2/glob2/issues/6/comments","statuses_url":"https://api.github.com/repos/Globulation2/glob2/statuses/c77578b44f3935b83f3c8eb961350875c26300aa","head":{"label":"richelbilderbeek:master","ref":"master","sha":"c77578b44f3935b83f3c8eb961350875c26300aa","user":{"login":"richelbilderbeek","id":2098230,"node_id":"MDQ6VXNlcjIwOTgyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2098230?v=4","gravatar_id":"","url":"https://api.github.com/users/richelbilderbeek","html_url":"https://github.com/richelbilderbeek","followers_url":"https://api.github.com/users/richelbilderbeek/followers","following_url":"https://api.github.com/users/richelbilderbeek/following{/other_user}","gists_url":"https://api.github.com/users/richelbilderbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/richelbilderbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richelbilderbeek/subscriptions","organizations_url":"https://api.github.com/users/richelbilderbeek/orgs","repos_url":"https://api.github.com/users/richelbilderbeek/repos","events_url":"https://api.github.com/users/richelbilderbeek/events{/privacy}","received_events_url":"https://api.github.com/users/richelbilderbeek/received_events","type":"User","site_admin":false},"repo":{"id":230403281,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA0MDMyODE=","name":"glob2","full_name":"richelbilderbeek/glob2","private":false,"owner":{"login":"richelbilderbeek","id":2098230,"node_id":"MDQ6VXNlcjIwOTgyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2098230?v=4","gravatar_id":"","url":"https://api.github.com/users/richelbilderbeek","html_url":"https://github.com/richelbilderbeek","followers_url":"https://api.github.com/users/richelbilderbeek/followers","following_url":"https://api.github.com/users/richelbilderbeek/following{/other_user}","gists_url":"https://api.github.com/users/richelbilderbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/richelbilderbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richelbilderbeek/subscriptions","organizations_url":"https://api.github.com/users/richelbilderbeek/orgs","repos_url":"https://api.github.com/users/richelbilderbeek/repos","events_url":"https://api.github.com/users/richelbilderbeek/events{/privacy}","received_events_url":"https://api.github.com/users/richelbilderbeek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richelbilderbeek/glob2","description":"A real time strategy game that aims to remove all micro management","fork":true,"url":"https://api.github.com/repos/richelbilderbeek/glob2","forks_url":"https://api.github.com/repos/richelbilderbeek/glob2/forks","keys_url":"https://api.github.com/repos/richelbilderbeek/glob2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richelbilderbeek/glob2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richelbilderbeek/glob2/teams","hooks_url":"https://api.github.com/repos/richelbilderbeek/glob2/hooks","issue_events_url":"https://api.github.com/repos/richelbilderbeek/glob2/issues/events{/number}","events_url":"https://api.github.com/repos/richelbilderbeek/glob2/events","assignees_url":"https://api.github.com/repos/richelbilderbeek/glob2/assignees{/user}","branches_url":"https://api.github.com/repos/richelbilderbeek/glob2/branches{/branch}","tags_url":"https://api.github.com/repos/richelbilderbeek/glob2/tags","blobs_url":"https://api.github.com/repos/richelbilderbeek/glob2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richelbilderbeek/glob2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richelbilderbeek/glob2/git/refs{/sha}","trees_url":"https://api.github.com/repos/richelbilderbeek/glob2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richelbilderbeek/glob2/statuses/{sha}","languages_url":"https://api.github.com/repos/richelbilderbeek/glob2/languages","stargazers_url":"https://api.github.com/repos/richelbilderbeek/glob2/stargazers","contributors_url":"https://api.github.com/repos/richelbilderbeek/glob2/contributors","subscribers_url":"https://api.github.com/repos/richelbilderbeek/glob2/subscribers","subscription_url":"https://api.github.com/repos/richelbilderbeek/glob2/subscription","commits_url":"https://api.github.com/repos/richelbilderbeek/glob2/commits{/sha}","git_commits_url":"https://api.github.com/repos/richelbilderbeek/glob2/git/commits{/sha}","comments_url":"https://api.github.com/repos/richelbilderbeek/glob2/comments{/number}","issue_comment_url":"https://api.github.com/repos/richelbilderbeek/glob2/issues/comments{/number}","contents_url":"https://api.github.com/repos/richelbilderbeek/glob2/contents/{+path}","compare_url":"https://api.github.com/repos/richelbilderbeek/glob2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richelbilderbeek/glob2/merges","archive_url":"https://api.github.com/repos/richelbilderbeek/glob2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richelbilderbeek/glob2/downloads","issues_url":"https://api.github.com/repos/richelbilderbeek/glob2/issues{/number}","pulls_url":"https://api.github.com/repos/richelbilderbeek/glob2/pulls{/number}","milestones_url":"https://api.github.com/repos/richelbilderbeek/glob2/milestones{/number}","notifications_url":"https://api.github.com/repos/richelbilderbeek/glob2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richelbilderbeek/glob2/labels{/name}","releases_url":"https://api.github.com/repos/richelbilderbeek/glob2/releases{/id}","deployments_url":"https://api.github.com/repos/richelbilderbeek/glob2/deployments","created_at":"2019-12-27T08:25:41Z","updated_at":"2019-12-28T11:33:20Z","pushed_at":"2019-12-28T11:33:17Z","git_url":"git://github.com/richelbilderbeek/glob2.git","ssh_url":"git@github.com:richelbilderbeek/glob2.git","clone_url":"https://github.com/richelbilderbeek/glob2.git","svn_url":"https://github.com/richelbilderbeek/glob2","homepage":"https://globulation2.org","size":138612,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Globulation2:master","ref":"master","sha":"7f3154e35e4d749b7247f7b9e6156a574e8982d9","user":{"login":"Globulation2","id":59262430,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjYyNDMw","avatar_url":"https://avatars2.githubusercontent.com/u/59262430?v=4","gravatar_id":"","url":"https://api.github.com/users/Globulation2","html_url":"https://github.com/Globulation2","followers_url":"https://api.github.com/users/Globulation2/followers","following_url":"https://api.github.com/users/Globulation2/following{/other_user}","gists_url":"https://api.github.com/users/Globulation2/gists{/gist_id}","starred_url":"https://api.github.com/users/Globulation2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Globulation2/subscriptions","organizations_url":"https://api.github.com/users/Globulation2/orgs","repos_url":"https://api.github.com/users/Globulation2/repos","events_url":"https://api.github.com/users/Globulation2/events{/privacy}","received_events_url":"https://api.github.com/users/Globulation2/received_events","type":"Organization","site_admin":false},"repo":{"id":230307566,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAzMDc1NjY=","name":"glob2","full_name":"Globulation2/glob2","private":false,"owner":{"login":"Globulation2","id":59262430,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjYyNDMw","avatar_url":"https://avatars2.githubusercontent.com/u/59262430?v=4","gravatar_id":"","url":"https://api.github.com/users/Globulation2","html_url":"https://github.com/Globulation2","followers_url":"https://api.github.com/users/Globulation2/followers","following_url":"https://api.github.com/users/Globulation2/following{/other_user}","gists_url":"https://api.github.com/users/Globulation2/gists{/gist_id}","starred_url":"https://api.github.com/users/Globulation2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Globulation2/subscriptions","organizations_url":"https://api.github.com/users/Globulation2/orgs","repos_url":"https://api.github.com/users/Globulation2/repos","events_url":"https://api.github.com/users/Globulation2/events{/privacy}","received_events_url":"https://api.github.com/users/Globulation2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Globulation2/glob2","description":"A real time strategy game that aims to remove all micro management","fork":false,"url":"https://api.github.com/repos/Globulation2/glob2","forks_url":"https://api.github.com/repos/Globulation2/glob2/forks","keys_url":"https://api.github.com/repos/Globulation2/glob2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Globulation2/glob2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Globulation2/glob2/teams","hooks_url":"https://api.github.com/repos/Globulation2/glob2/hooks","issue_events_url":"https://api.github.com/repos/Globulation2/glob2/issues/events{/number}","events_url":"https://api.github.com/repos/Globulation2/glob2/events","assignees_url":"https://api.github.com/repos/Globulation2/glob2/assignees{/user}","branches_url":"https://api.github.com/repos/Globulation2/glob2/branches{/branch}","tags_url":"https://api.github.com/repos/Globulation2/glob2/tags","blobs_url":"https://api.github.com/repos/Globulation2/glob2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Globulation2/glob2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Globulation2/glob2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Globulation2/glob2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Globulation2/glob2/statuses/{sha}","languages_url":"https://api.github.com/repos/Globulation2/glob2/languages","stargazers_url":"https://api.github.com/repos/Globulation2/glob2/stargazers","contributors_url":"https://api.github.com/repos/Globulation2/glob2/contributors","subscribers_url":"https://api.github.com/repos/Globulation2/glob2/subscribers","subscription_url":"https://api.github.com/repos/Globulation2/glob2/subscription","commits_url":"https://api.github.com/repos/Globulation2/glob2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Globulation2/glob2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Globulation2/glob2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Globulation2/glob2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Globulation2/glob2/contents/{+path}","compare_url":"https://api.github.com/repos/Globulation2/glob2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Globulation2/glob2/merges","archive_url":"https://api.github.com/repos/Globulation2/glob2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Globulation2/glob2/downloads","issues_url":"https://api.github.com/repos/Globulation2/glob2/issues{/number}","pulls_url":"https://api.github.com/repos/Globulation2/glob2/pulls{/number}","milestones_url":"https://api.github.com/repos/Globulation2/glob2/milestones{/number}","notifications_url":"https://api.github.com/repos/Globulation2/glob2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Globulation2/glob2/labels{/name}","releases_url":"https://api.github.com/repos/Globulation2/glob2/releases{/id}","deployments_url":"https://api.github.com/repos/Globulation2/glob2/deployments","created_at":"2019-12-26T18:08:06Z","updated_at":"2019-12-28T07:32:25Z","pushed_at":"2019-12-28T11:44:55Z","git_url":"git://github.com/Globulation2/glob2.git","ssh_url":"git@github.com:Globulation2/glob2.git","clone_url":"https://github.com/Globulation2/glob2.git","svn_url":"https://github.com/Globulation2/glob2","homepage":"https://globulation2.org","size":138630,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Globulation2/glob2/pulls/6"},"html":{"href":"https://github.com/Globulation2/glob2/pull/6"},"issue":{"href":"https://api.github.com/repos/Globulation2/glob2/issues/6"},"comments":{"href":"https://api.github.com/repos/Globulation2/glob2/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Globulation2/glob2/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Globulation2/glob2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Globulation2/glob2/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Globulation2/glob2/statuses/c77578b44f3935b83f3c8eb961350875c26300aa"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"richelbilderbeek"}}