payload: {"action":"created","issue":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/454","repository_url":"https://api.github.com/repos/Azure/aks-engine","labels_url":"https://api.github.com/repos/Azure/aks-engine/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/Azure/aks-engine/issues/454/comments","events_url":"https://api.github.com/repos/Azure/aks-engine/issues/454/events","html_url":"https://github.com/Azure/aks-engine/pull/454","id":407673562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMDk0MzY4","number":454,"title":"[WIP] chore: Update calico to 3.5 and allow calico to work with azure CNI","user":{"login":"song-jiang","id":28784648,"node_id":"MDQ6VXNlcjI4Nzg0NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/28784648?v=4","gravatar_id":"","url":"https://api.github.com/users/song-jiang","html_url":"https://github.com/song-jiang","followers_url":"https://api.github.com/users/song-jiang/followers","following_url":"https://api.github.com/users/song-jiang/following{/other_user}","gists_url":"https://api.github.com/users/song-jiang/gists{/gist_id}","starred_url":"https://api.github.com/users/song-jiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/song-jiang/subscriptions","organizations_url":"https://api.github.com/users/song-jiang/orgs","repos_url":"https://api.github.com/users/song-jiang/repos","events_url":"https://api.github.com/users/song-jiang/events{/privacy}","received_events_url":"https://api.github.com/users/song-jiang/received_events","type":"User","site_admin":false},"labels":[{"id":1128165842,"node_id":"MDU6TGFiZWwxMTI4MTY1ODQy","url":"https://api.github.com/repos/Azure/aks-engine/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"E0596D","default":false},{"id":1128165839,"node_id":"MDU6TGFiZWwxMTI4MTY1ODM5","url":"https://api.github.com/repos/Azure/aks-engine/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"E0596D","default":false},{"id":1128999543,"node_id":"MDU6TGFiZWwxMTI4OTk5NTQz","url":"https://api.github.com/repos/Azure/aks-engine/labels/size/XXL","name":"size/XXL","color":"ddc433","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2019-02-07T12:21:49Z","updated_at":"2019-03-05T15:09:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/454","html_url":"https://github.com/Azure/aks-engine/pull/454","diff_url":"https://github.com/Azure/aks-engine/pull/454.diff","patch_url":"https://github.com/Azure/aks-engine/pull/454.patch"},"body":"<!-- Thank you for helping aks-engine with a pull request!\r\nUse conventional commit messages, such as\r\n  feat: add a knob to the frobnitz\r\nor\r\n  fix: repair hole in wumpus\r\nAnd read this for faster PR reviews: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews -->\r\n\r\n**Reason for Change**:\r\n<!-- What does this PR improve or fix in aks-engine? -->\r\n- Upgrade calico to v3.5\r\n- Allow calico to work with azure CNI by setting \r\n```NetworkPolicy: \"calico\" , NetworkPlugin: \"azure\"```\r\nIn this case, calico per-host daemon works with azure CNI plugin and azure IPAM to support network policy. \r\n\r\n- Continue support kubenet network plugin by setting\r\n```NetworkPolicy: \"calico\" , NetworkPlugin: \"kubenet\"```\r\n\r\n**Issue Fixed**:\r\n<!-- If this PR fixes GitHub issue 1234, add \"Fixes #1234\" to the next line. -->\r\n\r\n\r\n**Requirements**:\r\n<!-- Put an \"X\" character inside the brackets of each completed task. Some may be optional depending on the PR. -->\r\n\r\n- [ ] uses [conventional commit messages](https://www.conventionalcommits.org/)\r\n  <!-- Common commit types:\r\n        build: Build 🏭\r\n        chore: Maintenance 🔧\r\n        ci: Continuous Integration 💜\r\n        docs: Documentation 📘\r\n        feat: Features 🌈\r\n        fix: Bug Fixes 🐞\r\n        perf: Performance Improvements 🚀\r\n        refactor: Code Refactoring 💎\r\n        revert: Revert Change ◀️\r\n        style: Code Style 🎶\r\n        test: Testing 💚 -->\r\n- [ ] includes documentation\r\n- [ ] adds unit tests\r\n- [ ] tested upgrade from previous version\r\n\r\n**Notes**:\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/comments/469715934","html_url":"https://github.com/Azure/aks-engine/pull/454#issuecomment-469715934","issue_url":"https://api.github.com/repos/Azure/aks-engine/issues/454","id":469715934,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2OTcxNTkzNA==","user":{"login":"acs-bot","id":24280864,"node_id":"MDQ6VXNlcjI0MjgwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/24280864?v=4","gravatar_id":"","url":"https://api.github.com/users/acs-bot","html_url":"https://github.com/acs-bot","followers_url":"https://api.github.com/users/acs-bot/followers","following_url":"https://api.github.com/users/acs-bot/following{/other_user}","gists_url":"https://api.github.com/users/acs-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/acs-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acs-bot/subscriptions","organizations_url":"https://api.github.com/users/acs-bot/orgs","repos_url":"https://api.github.com/users/acs-bot/repos","events_url":"https://api.github.com/users/acs-bot/events{/privacy}","received_events_url":"https://api.github.com/users/acs-bot/received_events","type":"User","site_admin":false},"created_at":"2019-03-05T15:09:39Z","updated_at":"2019-03-05T15:09:39Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/Azure/aks-engine/pull/454#\" title=\"Author self-approved\">song-jiang</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **serbrech**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @serbrech` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/Azure/aks-engine/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"serbrech\"]} -->"}}
other: {"actor":{"display_login":"acs-bot"}}