payload: {"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/3117","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/3117/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/3117/comments","events_url":"https://api.github.com/repos/knative/serving/issues/3117/events","html_url":"https://github.com/knative/serving/pull/3117","id":407498479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwOTYwMzE2","number":3117,"title":"Fix some stuff around the tests","user":{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},"labels":[{"id":859767870,"node_id":"MDU6TGFiZWw4NTk3Njc4NzA=","url":"https://api.github.com/repos/knative/serving/labels/size/M","name":"size/M","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"dgerd","id":43425586,"node_id":"MDQ6VXNlcjQzNDI1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/43425586?v=4","gravatar_id":"","url":"https://api.github.com/users/dgerd","html_url":"https://github.com/dgerd","followers_url":"https://api.github.com/users/dgerd/followers","following_url":"https://api.github.com/users/dgerd/following{/other_user}","gists_url":"https://api.github.com/users/dgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/dgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgerd/subscriptions","organizations_url":"https://api.github.com/users/dgerd/orgs","repos_url":"https://api.github.com/users/dgerd/repos","events_url":"https://api.github.com/users/dgerd/events{/privacy}","received_events_url":"https://api.github.com/users/dgerd/received_events","type":"User","site_admin":false},"assignees":[{"login":"dgerd","id":43425586,"node_id":"MDQ6VXNlcjQzNDI1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/43425586?v=4","gravatar_id":"","url":"https://api.github.com/users/dgerd","html_url":"https://github.com/dgerd","followers_url":"https://api.github.com/users/dgerd/followers","following_url":"https://api.github.com/users/dgerd/following{/other_user}","gists_url":"https://api.github.com/users/dgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/dgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgerd/subscriptions","organizations_url":"https://api.github.com/users/dgerd/orgs","repos_url":"https://api.github.com/users/dgerd/repos","events_url":"https://api.github.com/users/dgerd/events{/privacy}","received_events_url":"https://api.github.com/users/dgerd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2019-02-07T00:52:03Z","updated_at":"2019-02-07T01:14:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/3117","html_url":"https://github.com/knative/serving/pull/3117","diff_url":"https://github.com/knative/serving/pull/3117.diff","patch_url":"https://github.com/knative/serving/pull/3117.patch"},"body":"/lint\r\n## Proposed Changes\r\n\r\n* remove extremely annoying logging from Prometheus worker.go (I downgraded it to Debug, so it won't show in the test output and made it print in a more sensible way)\r\n* downgraded util logging as well. Still possible to see by passing logLevel flag.\r\n* make `validateDomains` return error and fatal in the test instead. \r\n* make `validateDomains` do much more stuff in parallel. My test runs are consistently down from 210s to ~160s. A minute a run, sounds like fun.\r\n* this also incorporates the change I did in different PR, where **all** domains are probed to be ready, since we've seen many a second gateway propagation delays\r\n* some error changes here and there\r\n\r\n/cc @mattmoor @dgerd \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/461253230","html_url":"https://github.com/knative/serving/pull/3117#issuecomment-461253230","issue_url":"https://api.github.com/repos/knative/serving/issues/3117","id":461253230,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MTI1MzIzMA==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2019-02-07T01:14:40Z","updated_at":"2019-02-07T01:14:40Z","author_association":"NONE","body":"@vagababov: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-knative-serving-upgrade-tests | 60ff92e3bd281980ae0722e3e2f13f75edb44057 | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/3117/pull-knative-serving-upgrade-tests/1093311417601232896/) | `/test pull-knative-serving-upgrade-tests`\npull-knative-serving-build-tests | 60ff92e3bd281980ae0722e3e2f13f75edb44057 | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/3117/pull-knative-serving-build-tests/1093311417597038592/) | `/test pull-knative-serving-build-tests`\npull-knative-serving-integration-tests | 66c63ee5996593c5d53f2f25f7fee0ef72aa4045 | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/3117/pull-knative-serving-integration-tests/1093316073618411522/) | `/test pull-knative-serving-integration-tests`\n\n[Full PR test history](https://gubernator.knative.dev/pr/knative_serving/3117). [Your PR dashboard](https://gubernator.knative.dev/pr/vagababov).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
other: {"actor":{"display_login":"knative-prow-robot"}}