payload: {"action":"closed","number":5326,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/5326","id":318422062,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4NDIyMDYy","html_url":"https://github.com/musescore/MuseScore/pull/5326","diff_url":"https://github.com/musescore/MuseScore/pull/5326.diff","patch_url":"https://github.com/musescore/MuseScore/pull/5326.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/5326","number":5326,"state":"closed","locked":false,"title":"fix #293228: accessibility for QML palettes","user":{"login":"MarcSabatella","id":1799936,"node_id":"MDQ6VXNlcjE3OTk5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1799936?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"body":"Resolves: https://musescore.org/en/node/293228\r\n\r\nThe QML palette implementation is inherently much more accessible than the original,\r\nbut it needs a few small changes to work correctly:\r\n\r\n1) the palette-search command was incorrectly still transferring focus to the old search box.\r\nFixed to transfer focus to the paletteWidget itself,\r\nwith a TODO noting that we really should be getting the search box within the palette.\r\nI just don't know how to access individual QML widgets.\r\n\r\n2) search box had no accessible text so it only read \"edit\",\r\nfixed to inherit the placeholder text (\"Search\").\r\n\r\n3) Names of key signatures and other palette cells that include unpronounceable Unicode characters\r\nwere not being read correctly (eg, Eb major reads as just \"E major\").\r\nFix is to call makeReadable() on the cell name for the AccessibleTextRole,\r\nand to be sure that role name is exposed in the model.\r\n\r\nI do not know a way to create automated tests for this.\r\n\r\nThis PR replaces the corresponding code in #5270.","created_at":"2019-09-17T16:24:11Z","updated_at":"2019-09-17T17:43:43Z","closed_at":"2019-09-17T17:43:43Z","merged_at":"2019-09-17T17:43:43Z","merge_commit_sha":"b382ebdf11c4f948163bd84732cb5419c8d39a61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1045081654,"node_id":"MDU6TGFiZWwxMDQ1MDgxNjU0","url":"https://api.github.com/repos/musescore/MuseScore/labels/RNIB","name":"RNIB","color":"37207c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5326/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5326/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/5326/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/ef018c2f5b7fe3b8185d963d09f02178e02f07a0","head":{"label":"MarcSabatella:293228-palette-search","ref":"293228-palette-search","sha":"ef018c2f5b7fe3b8185d963d09f02178e02f07a0","user":{"login":"MarcSabatella","id":1799936,"node_id":"MDQ6VXNlcjE3OTk5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1799936?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"repo":{"id":14895853,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg5NTg1Mw==","name":"MuseScore","full_name":"MarcSabatella/MuseScore","private":false,"owner":{"login":"MarcSabatella","id":1799936,"node_id":"MDQ6VXNlcjE3OTk5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1799936?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MarcSabatella/MuseScore","description":"MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/MarcSabatella/MuseScore","forks_url":"https://api.github.com/repos/MarcSabatella/MuseScore/forks","keys_url":"https://api.github.com/repos/MarcSabatella/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcSabatella/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcSabatella/MuseScore/teams","hooks_url":"https://api.github.com/repos/MarcSabatella/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/MarcSabatella/MuseScore/events","assignees_url":"https://api.github.com/repos/MarcSabatella/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/MarcSabatella/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/MarcSabatella/MuseScore/tags","blobs_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcSabatella/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcSabatella/MuseScore/languages","stargazers_url":"https://api.github.com/repos/MarcSabatella/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/MarcSabatella/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/MarcSabatella/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/MarcSabatella/MuseScore/subscription","commits_url":"https://api.github.com/repos/MarcSabatella/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcSabatella/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcSabatella/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcSabatella/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/MarcSabatella/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcSabatella/MuseScore/merges","archive_url":"https://api.github.com/repos/MarcSabatella/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcSabatella/MuseScore/downloads","issues_url":"https://api.github.com/repos/MarcSabatella/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/MarcSabatella/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcSabatella/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcSabatella/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcSabatella/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/MarcSabatella/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/MarcSabatella/MuseScore/deployments","created_at":"2013-12-03T14:25:39Z","updated_at":"2019-03-24T13:50:34Z","pushed_at":"2019-09-17T16:21:27Z","git_url":"git://github.com/MarcSabatella/MuseScore.git","ssh_url":"git@github.com:MarcSabatella/MuseScore.git","clone_url":"https://github.com/MarcSabatella/MuseScore.git","svn_url":"https://github.com/MarcSabatella/MuseScore","homepage":"http://musescore.org","size":356462,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"c2a26cd72b777f834ab0f65946c0b2be1777d9c4","user":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU0Nzkz","name":"MuseScore","full_name":"musescore/MuseScore","private":false,"owner":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2019-09-17T16:02:48Z","pushed_at":"2019-09-17T17:43:43Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":383263,"stargazers_count":3964,"watchers_count":3964,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1253,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":174,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1253,"open_issues":174,"watchers":3964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5326"},"html":{"href":"https://github.com/musescore/MuseScore/pull/5326"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/5326"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/5326/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5326/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5326/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/ef018c2f5b7fe3b8185d963d09f02178e02f07a0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"anatoly-os","id":18065034,"node_id":"MDQ6VXNlcjE4MDY1MDM0","avatar_url":"https://avatars2.githubusercontent.com/u/18065034?v=4","gravatar_id":"","url":"https://api.github.com/users/anatoly-os","html_url":"https://github.com/anatoly-os","followers_url":"https://api.github.com/users/anatoly-os/followers","following_url":"https://api.github.com/users/anatoly-os/following{/other_user}","gists_url":"https://api.github.com/users/anatoly-os/gists{/gist_id}","starred_url":"https://api.github.com/users/anatoly-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatoly-os/subscriptions","organizations_url":"https://api.github.com/users/anatoly-os/orgs","repos_url":"https://api.github.com/users/anatoly-os/repos","events_url":"https://api.github.com/users/anatoly-os/events{/privacy}","received_events_url":"https://api.github.com/users/anatoly-os/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":9,"changed_files":4}}
other: {"actor":{"display_login":"anatoly-os"}}