payload: {"action":"closed","number":6341,"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/6341","id":288036672,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4MDM2Njcy","html_url":"https://github.com/hail-is/hail/pull/6341","diff_url":"https://github.com/hail-is/hail/pull/6341.diff","patch_url":"https://github.com/hail-is/hail/pull/6341.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/6341","number":6341,"state":"closed","locked":false,"title":"[batch] fix cancelled","user":{"login":"jigold","id":1693348,"node_id":"MDQ6VXNlcjE2OTMzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"body":"I implemented `cancelled` as a join from the batch table rather than storing redundant information for each job.\r\n\r\n@akotlar The issue was that all jobs were getting set to cancelled at the same time (and thus notifying children), so always run jobs were all getting run at once neglecting the hierarchy of job dependencies. This is the purpose of having the `cancelled` flag as separate from the `Cancelled` state and is checked in `create_if_ready`.\r\n\r\n@cseed Can you look and see if this solves the cancel problem we discussed earlier? The faulty PR was this one: https://github.com/hail-is/hail/pull/6128/files","created_at":"2019-06-13T18:03:17Z","updated_at":"2019-06-16T03:41:03Z","closed_at":"2019-06-16T03:41:03Z","merged_at":"2019-06-16T03:41:03Z","merge_commit_sha":"272b26b19b5ce301d68e0eb5e12a896f19ca790b","assignee":{"login":"akotlar","id":5543229,"node_id":"MDQ6VXNlcjU1NDMyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5543229?v=4","gravatar_id":"","url":"https://api.github.com/users/akotlar","html_url":"https://github.com/akotlar","followers_url":"https://api.github.com/users/akotlar/followers","following_url":"https://api.github.com/users/akotlar/following{/other_user}","gists_url":"https://api.github.com/users/akotlar/gists{/gist_id}","starred_url":"https://api.github.com/users/akotlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akotlar/subscriptions","organizations_url":"https://api.github.com/users/akotlar/orgs","repos_url":"https://api.github.com/users/akotlar/repos","events_url":"https://api.github.com/users/akotlar/events{/privacy}","received_events_url":"https://api.github.com/users/akotlar/received_events","type":"User","site_admin":false},"assignees":[{"login":"akotlar","id":5543229,"node_id":"MDQ6VXNlcjU1NDMyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5543229?v=4","gravatar_id":"","url":"https://api.github.com/users/akotlar","html_url":"https://github.com/akotlar","followers_url":"https://api.github.com/users/akotlar/followers","following_url":"https://api.github.com/users/akotlar/following{/other_user}","gists_url":"https://api.github.com/users/akotlar/gists{/gist_id}","starred_url":"https://api.github.com/users/akotlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akotlar/subscriptions","organizations_url":"https://api.github.com/users/akotlar/orgs","repos_url":"https://api.github.com/users/akotlar/repos","events_url":"https://api.github.com/users/akotlar/events{/privacy}","received_events_url":"https://api.github.com/users/akotlar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/6341/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/6341/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/6341/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/6aca95a5ac88ec3a6027be5b2f5d6f07d0ec7776","head":{"label":"jigold:batch-fix-cancel","ref":"batch-fix-cancel","sha":"6aca95a5ac88ec3a6027be5b2f5d6f07d0ec7776","user":{"login":"jigold","id":1693348,"node_id":"MDQ6VXNlcjE2OTMzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"repo":{"id":64695542,"node_id":"MDEwOlJlcG9zaXRvcnk2NDY5NTU0Mg==","name":"hail","full_name":"jigold/hail","private":false,"owner":{"login":"jigold","id":1693348,"node_id":"MDQ6VXNlcjE2OTMzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jigold/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/jigold/hail","forks_url":"https://api.github.com/repos/jigold/hail/forks","keys_url":"https://api.github.com/repos/jigold/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jigold/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jigold/hail/teams","hooks_url":"https://api.github.com/repos/jigold/hail/hooks","issue_events_url":"https://api.github.com/repos/jigold/hail/issues/events{/number}","events_url":"https://api.github.com/repos/jigold/hail/events","assignees_url":"https://api.github.com/repos/jigold/hail/assignees{/user}","branches_url":"https://api.github.com/repos/jigold/hail/branches{/branch}","tags_url":"https://api.github.com/repos/jigold/hail/tags","blobs_url":"https://api.github.com/repos/jigold/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jigold/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jigold/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/jigold/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jigold/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/jigold/hail/languages","stargazers_url":"https://api.github.com/repos/jigold/hail/stargazers","contributors_url":"https://api.github.com/repos/jigold/hail/contributors","subscribers_url":"https://api.github.com/repos/jigold/hail/subscribers","subscription_url":"https://api.github.com/repos/jigold/hail/subscription","commits_url":"https://api.github.com/repos/jigold/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/jigold/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/jigold/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/jigold/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/jigold/hail/contents/{+path}","compare_url":"https://api.github.com/repos/jigold/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jigold/hail/merges","archive_url":"https://api.github.com/repos/jigold/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jigold/hail/downloads","issues_url":"https://api.github.com/repos/jigold/hail/issues{/number}","pulls_url":"https://api.github.com/repos/jigold/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/jigold/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/jigold/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jigold/hail/labels{/name}","releases_url":"https://api.github.com/repos/jigold/hail/releases{/id}","deployments_url":"https://api.github.com/repos/jigold/hail/deployments","created_at":"2016-08-01T19:28:56Z","updated_at":"2019-06-14T15:15:17Z","pushed_at":"2019-06-15T20:08:05Z","git_url":"git://github.com/jigold/hail.git","ssh_url":"git@github.com:jigold/hail.git","clone_url":"https://github.com/jigold/hail.git","svn_url":"https://github.com/jigold/hail","homepage":"","size":77782,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"a93256870dbf34bd0ecc03d52f72326a354986a9","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2019-06-16T01:47:46Z","pushed_at":"2019-06-16T03:41:03Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":69310,"stargazers_count":530,"watchers_count":530,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":228,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":133,"open_issues":228,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6341"},"html":{"href":"https://github.com/hail-is/hail/pull/6341"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/6341"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/6341/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6341/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6341/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/6aca95a5ac88ec3a6027be5b2f5d6f07d0ec7776"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"comments":1,"review_comments":21,"maintainer_can_modify":false,"commits":13,"additions":87,"deletions":31,"changed_files":4}}
other: {"actor":{"display_login":"danking"}}