payload: {"action":"created","issue":{"url":"https://api.github.com/repos/UXAspects/UXAspects/issues/1122","repository_url":"https://api.github.com/repos/UXAspects/UXAspects","labels_url":"https://api.github.com/repos/UXAspects/UXAspects/issues/1122/labels{/name}","comments_url":"https://api.github.com/repos/UXAspects/UXAspects/issues/1122/comments","events_url":"https://api.github.com/repos/UXAspects/UXAspects/issues/1122/events","html_url":"https://github.com/UXAspects/UXAspects/pull/1122","id":460501148,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxNjE5NjEw","number":1122,"title":"EL-3492 - Remove AngularJS source and resources from the main library (additional changes)","user":{"login":"ashley-hunter","id":20795331,"node_id":"MDQ6VXNlcjIwNzk1MzMx","avatar_url":"https://avatars2.githubusercontent.com/u/20795331?v=4","gravatar_id":"","url":"https://api.github.com/users/ashley-hunter","html_url":"https://github.com/ashley-hunter","followers_url":"https://api.github.com/users/ashley-hunter/followers","following_url":"https://api.github.com/users/ashley-hunter/following{/other_user}","gists_url":"https://api.github.com/users/ashley-hunter/gists{/gist_id}","starred_url":"https://api.github.com/users/ashley-hunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashley-hunter/subscriptions","organizations_url":"https://api.github.com/users/ashley-hunter/orgs","repos_url":"https://api.github.com/users/ashley-hunter/repos","events_url":"https://api.github.com/users/ashley-hunter/events{/privacy}","received_events_url":"https://api.github.com/users/ashley-hunter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-06-25T15:42:26Z","updated_at":"2019-06-25T16:18:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/UXAspects/UXAspects/pulls/1122","html_url":"https://github.com/UXAspects/UXAspects/pull/1122","diff_url":"https://github.com/UXAspects/UXAspects/pull/1122.diff","patch_url":"https://github.com/UXAspects/UXAspects/pull/1122.patch"},"body":"#### Checklist\r\n<!-- Use an 'x' to check those which apply. -->\r\n* [x] The contents of this PR are mine to submit. No third party code or other material is being committed.\r\n* [x] New third party dependencies (if any) are linked via `package.json`. Third party dependencies are licenced under one of the following: Apache, MIT, BSD, Mozilla Public License, Eclipse Public License, or Oracle Binary Code License.\r\n* [x] The code in this PR does not contain export-restricted encryption algorithms.\r\n\r\n#### Ticket / Issue\r\n<!-- Either a Jira URL or a description of the issue that this PR addresses. -->\r\nhttps://portal.digitalsafe.net/browse/EL-3492\r\n\r\n#### Description of Proposed Changes\r\n<!-- Describe what was changed and how it addresses the original issue. -->\r\nI have some additional changes that could be considered as part of EL-3492 or we may want to create separate tickets for them if they don't fit into the existing ticket:\r\n\r\n### Webpack Configuration\r\n- Removed Angular.js from the webpack config - which allows use to remove the entire `scripts.js` bundle and `ScriptsWebpackPlugin`\r\n\r\n### Documentation\r\n- Flippable Cards example was using `nested-donut` AngularJS component - switched to use Angular component.\r\n- Converted documentation site to a pure Angular application - removed all hybrid code. This will now allow us to detect expression changed errors in our docs site (which I have now spotted a few that i need to raise tickets for).\r\n- Removed all uses of the `HybridModule` in our documentation site as this is no longer required\r\n\r\n### package.json\r\n- We had a load of dependencies that were in `package.json` that were only used by Angular.js so I have removed them\r\n- Removed `dist` and `ng1` files from the list of included files in `src/package.json`\r\n\r\n### Miscellaneous\r\n- Fixed some incorrect typings in the `InfiniteScrollDirective`\r\n- Added markdown file to keep track of any breaking changes (you may already already be doing this in which case this can be removed)\r\n\r\n### Hybrid Module\r\n**[Breaking Change]** I have moved the `HybridModule` to a separate entrypoint (https://github.com/ng-packagr/ng-packagr/blob/master/docs/secondary-entrypoints.md)\r\n\r\n- We can keep the hybrid code in this repository as it does depend on `@angular/*` packages.\r\n- It will no longer be included in the `@ux-aspects/ux-aspects` import, so we no longer require applications to install `@angular/upgrade` if they are not using any hybrid components and we ensure no upgrade or hybrid code gets included in their bundle unnecessarily.\r\n- `@angular/upgrade` is now an optional dependency (previously mandatory even if not used)\r\n- `HybridModule` would now be imported from `@ux-aspects/ux-aspects/hybrid`\r\n- `ng-packagr` handles multiple entry points automatically, no changes to build steps etc.. required.\r\n\r\n\r\n#### Documentation CI URL\r\n<!-- Initiate a build at https://jenkins.swinfra.net/job/SEPG/view/Templates/job/New%20SEPG%20Build/build -->\r\n<!-- Append the branch name to the following URL: -->\r\nhttps://pages.github.houston.softwaregrp.net/sepg-docs-qa/UXAspects_CI_UXAspects_EL-3492-remove-angularjs-2\r\n"},"comment":{"url":"https://api.github.com/repos/UXAspects/UXAspects/issues/comments/505516981","html_url":"https://github.com/UXAspects/UXAspects/pull/1122#issuecomment-505516981","issue_url":"https://api.github.com/repos/UXAspects/UXAspects/issues/1122","id":505516981,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNTUxNjk4MQ==","user":{"login":"ashley-hunter","id":20795331,"node_id":"MDQ6VXNlcjIwNzk1MzMx","avatar_url":"https://avatars2.githubusercontent.com/u/20795331?v=4","gravatar_id":"","url":"https://api.github.com/users/ashley-hunter","html_url":"https://github.com/ashley-hunter","followers_url":"https://api.github.com/users/ashley-hunter/followers","following_url":"https://api.github.com/users/ashley-hunter/following{/other_user}","gists_url":"https://api.github.com/users/ashley-hunter/gists{/gist_id}","starred_url":"https://api.github.com/users/ashley-hunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashley-hunter/subscriptions","organizations_url":"https://api.github.com/users/ashley-hunter/orgs","repos_url":"https://api.github.com/users/ashley-hunter/repos","events_url":"https://api.github.com/users/ashley-hunter/events{/privacy}","received_events_url":"https://api.github.com/users/ashley-hunter/received_events","type":"User","site_admin":false},"created_at":"2019-06-25T16:18:13Z","updated_at":"2019-06-25T16:18:13Z","author_association":"MEMBER","body":"Ah, even better! I have removed it now, thanks"}}
other: {"actor":{"display_login":"ashley-hunter"}}