payload: {"action":"opened","number":612,"pull_request":{"url":"https://api.github.com/repos/tinygo-org/tinygo/pulls/612","id":326879836,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2ODc5ODM2","html_url":"https://github.com/tinygo-org/tinygo/pull/612","diff_url":"https://github.com/tinygo-org/tinygo/pull/612.diff","patch_url":"https://github.com/tinygo-org/tinygo/pull/612.patch","issue_url":"https://api.github.com/repos/tinygo-org/tinygo/issues/612","number":612,"state":"open","locked":false,"title":"machine/nrf: do not compare slices against nil","user":{"login":"aykevl","id":729697,"node_id":"MDQ6VXNlcjcyOTY5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/729697?v=4","gravatar_id":"","url":"https://api.github.com/users/aykevl","html_url":"https://github.com/aykevl","followers_url":"https://api.github.com/users/aykevl/followers","following_url":"https://api.github.com/users/aykevl/following{/other_user}","gists_url":"https://api.github.com/users/aykevl/gists{/gist_id}","starred_url":"https://api.github.com/users/aykevl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aykevl/subscriptions","organizations_url":"https://api.github.com/users/aykevl/orgs","repos_url":"https://api.github.com/users/aykevl/repos","events_url":"https://api.github.com/users/aykevl/events{/privacy}","received_events_url":"https://api.github.com/users/aykevl/received_events","type":"User","site_admin":false},"body":"Comparing slices against nil currently causes the slice to escape, due to a limitation in LLVM 8. This leads to lots of unnecessary heap allocations. With LLVM 9 and some modifications to TinyGo, this should be fixed. However, this commit is an easy win right now.\r\n\r\nReturning an error when both slices are nil is not necessary, when the check is left out it should just do nothing.\r\n\r\nFor updating an SPI screen using the st7735 driver, this results in a ~7% performance win.","created_at":"2019-10-10T18:50:25Z","updated_at":"2019-10-10T18:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tinygo-org/tinygo/pulls/612/commits","review_comments_url":"https://api.github.com/repos/tinygo-org/tinygo/pulls/612/comments","review_comment_url":"https://api.github.com/repos/tinygo-org/tinygo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tinygo-org/tinygo/issues/612/comments","statuses_url":"https://api.github.com/repos/tinygo-org/tinygo/statuses/d70ba520315068485cf8b5606a1bcbc08c9ac239","head":{"label":"tinygo-org:nrf-spi-tx-noescape","ref":"nrf-spi-tx-noescape","sha":"d70ba520315068485cf8b5606a1bcbc08c9ac239","user":{"login":"tinygo-org","id":45223613,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjIzNjEz","avatar_url":"https://avatars2.githubusercontent.com/u/45223613?v=4","gravatar_id":"","url":"https://api.github.com/users/tinygo-org","html_url":"https://github.com/tinygo-org","followers_url":"https://api.github.com/users/tinygo-org/followers","following_url":"https://api.github.com/users/tinygo-org/following{/other_user}","gists_url":"https://api.github.com/users/tinygo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tinygo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinygo-org/subscriptions","organizations_url":"https://api.github.com/users/tinygo-org/orgs","repos_url":"https://api.github.com/users/tinygo-org/repos","events_url":"https://api.github.com/users/tinygo-org/events{/privacy}","received_events_url":"https://api.github.com/users/tinygo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":136505169,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MDUxNjk=","name":"tinygo","full_name":"tinygo-org/tinygo","private":false,"owner":{"login":"tinygo-org","id":45223613,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjIzNjEz","avatar_url":"https://avatars2.githubusercontent.com/u/45223613?v=4","gravatar_id":"","url":"https://api.github.com/users/tinygo-org","html_url":"https://github.com/tinygo-org","followers_url":"https://api.github.com/users/tinygo-org/followers","following_url":"https://api.github.com/users/tinygo-org/following{/other_user}","gists_url":"https://api.github.com/users/tinygo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tinygo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinygo-org/subscriptions","organizations_url":"https://api.github.com/users/tinygo-org/orgs","repos_url":"https://api.github.com/users/tinygo-org/repos","events_url":"https://api.github.com/users/tinygo-org/events{/privacy}","received_events_url":"https://api.github.com/users/tinygo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tinygo-org/tinygo","description":"Go compiler for small places. Microcontrollers, WebAssembly, and command-line tools. Based on LLVM.","fork":false,"url":"https://api.github.com/repos/tinygo-org/tinygo","forks_url":"https://api.github.com/repos/tinygo-org/tinygo/forks","keys_url":"https://api.github.com/repos/tinygo-org/tinygo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinygo-org/tinygo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinygo-org/tinygo/teams","hooks_url":"https://api.github.com/repos/tinygo-org/tinygo/hooks","issue_events_url":"https://api.github.com/repos/tinygo-org/tinygo/issues/events{/number}","events_url":"https://api.github.com/repos/tinygo-org/tinygo/events","assignees_url":"https://api.github.com/repos/tinygo-org/tinygo/assignees{/user}","branches_url":"https://api.github.com/repos/tinygo-org/tinygo/branches{/branch}","tags_url":"https://api.github.com/repos/tinygo-org/tinygo/tags","blobs_url":"https://api.github.com/repos/tinygo-org/tinygo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinygo-org/tinygo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinygo-org/tinygo/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinygo-org/tinygo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinygo-org/tinygo/statuses/{sha}","languages_url":"https://api.github.com/repos/tinygo-org/tinygo/languages","stargazers_url":"https://api.github.com/repos/tinygo-org/tinygo/stargazers","contributors_url":"https://api.github.com/repos/tinygo-org/tinygo/contributors","subscribers_url":"https://api.github.com/repos/tinygo-org/tinygo/subscribers","subscription_url":"https://api.github.com/repos/tinygo-org/tinygo/subscription","commits_url":"https://api.github.com/repos/tinygo-org/tinygo/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinygo-org/tinygo/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinygo-org/tinygo/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinygo-org/tinygo/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinygo-org/tinygo/contents/{+path}","compare_url":"https://api.github.com/repos/tinygo-org/tinygo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinygo-org/tinygo/merges","archive_url":"https://api.github.com/repos/tinygo-org/tinygo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinygo-org/tinygo/downloads","issues_url":"https://api.github.com/repos/tinygo-org/tinygo/issues{/number}","pulls_url":"https://api.github.com/repos/tinygo-org/tinygo/pulls{/number}","milestones_url":"https://api.github.com/repos/tinygo-org/tinygo/milestones{/number}","notifications_url":"https://api.github.com/repos/tinygo-org/tinygo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinygo-org/tinygo/labels{/name}","releases_url":"https://api.github.com/repos/tinygo-org/tinygo/releases{/id}","deployments_url":"https://api.github.com/repos/tinygo-org/tinygo/deployments","created_at":"2018-06-07T16:39:19Z","updated_at":"2019-10-10T15:26:52Z","pushed_at":"2019-10-10T18:49:52Z","git_url":"git://github.com/tinygo-org/tinygo.git","ssh_url":"git@github.com:tinygo-org/tinygo.git","clone_url":"https://github.com/tinygo-org/tinygo.git","svn_url":"https://github.com/tinygo-org/tinygo","homepage":"https://tinygo.org","size":2568,"stargazers_count":4536,"watchers_count":4536,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":197,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":69,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":197,"open_issues":69,"watchers":4536,"default_branch":"master"}},"base":{"label":"tinygo-org:dev","ref":"dev","sha":"832f301a7405b1587d18c91c4a0caa3be3715fc3","user":{"login":"tinygo-org","id":45223613,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjIzNjEz","avatar_url":"https://avatars2.githubusercontent.com/u/45223613?v=4","gravatar_id":"","url":"https://api.github.com/users/tinygo-org","html_url":"https://github.com/tinygo-org","followers_url":"https://api.github.com/users/tinygo-org/followers","following_url":"https://api.github.com/users/tinygo-org/following{/other_user}","gists_url":"https://api.github.com/users/tinygo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tinygo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinygo-org/subscriptions","organizations_url":"https://api.github.com/users/tinygo-org/orgs","repos_url":"https://api.github.com/users/tinygo-org/repos","events_url":"https://api.github.com/users/tinygo-org/events{/privacy}","received_events_url":"https://api.github.com/users/tinygo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":136505169,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MDUxNjk=","name":"tinygo","full_name":"tinygo-org/tinygo","private":false,"owner":{"login":"tinygo-org","id":45223613,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjIzNjEz","avatar_url":"https://avatars2.githubusercontent.com/u/45223613?v=4","gravatar_id":"","url":"https://api.github.com/users/tinygo-org","html_url":"https://github.com/tinygo-org","followers_url":"https://api.github.com/users/tinygo-org/followers","following_url":"https://api.github.com/users/tinygo-org/following{/other_user}","gists_url":"https://api.github.com/users/tinygo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tinygo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinygo-org/subscriptions","organizations_url":"https://api.github.com/users/tinygo-org/orgs","repos_url":"https://api.github.com/users/tinygo-org/repos","events_url":"https://api.github.com/users/tinygo-org/events{/privacy}","received_events_url":"https://api.github.com/users/tinygo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tinygo-org/tinygo","description":"Go compiler for small places. Microcontrollers, WebAssembly, and command-line tools. Based on LLVM.","fork":false,"url":"https://api.github.com/repos/tinygo-org/tinygo","forks_url":"https://api.github.com/repos/tinygo-org/tinygo/forks","keys_url":"https://api.github.com/repos/tinygo-org/tinygo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinygo-org/tinygo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinygo-org/tinygo/teams","hooks_url":"https://api.github.com/repos/tinygo-org/tinygo/hooks","issue_events_url":"https://api.github.com/repos/tinygo-org/tinygo/issues/events{/number}","events_url":"https://api.github.com/repos/tinygo-org/tinygo/events","assignees_url":"https://api.github.com/repos/tinygo-org/tinygo/assignees{/user}","branches_url":"https://api.github.com/repos/tinygo-org/tinygo/branches{/branch}","tags_url":"https://api.github.com/repos/tinygo-org/tinygo/tags","blobs_url":"https://api.github.com/repos/tinygo-org/tinygo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinygo-org/tinygo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinygo-org/tinygo/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinygo-org/tinygo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinygo-org/tinygo/statuses/{sha}","languages_url":"https://api.github.com/repos/tinygo-org/tinygo/languages","stargazers_url":"https://api.github.com/repos/tinygo-org/tinygo/stargazers","contributors_url":"https://api.github.com/repos/tinygo-org/tinygo/contributors","subscribers_url":"https://api.github.com/repos/tinygo-org/tinygo/subscribers","subscription_url":"https://api.github.com/repos/tinygo-org/tinygo/subscription","commits_url":"https://api.github.com/repos/tinygo-org/tinygo/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinygo-org/tinygo/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinygo-org/tinygo/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinygo-org/tinygo/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinygo-org/tinygo/contents/{+path}","compare_url":"https://api.github.com/repos/tinygo-org/tinygo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinygo-org/tinygo/merges","archive_url":"https://api.github.com/repos/tinygo-org/tinygo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinygo-org/tinygo/downloads","issues_url":"https://api.github.com/repos/tinygo-org/tinygo/issues{/number}","pulls_url":"https://api.github.com/repos/tinygo-org/tinygo/pulls{/number}","milestones_url":"https://api.github.com/repos/tinygo-org/tinygo/milestones{/number}","notifications_url":"https://api.github.com/repos/tinygo-org/tinygo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinygo-org/tinygo/labels{/name}","releases_url":"https://api.github.com/repos/tinygo-org/tinygo/releases{/id}","deployments_url":"https://api.github.com/repos/tinygo-org/tinygo/deployments","created_at":"2018-06-07T16:39:19Z","updated_at":"2019-10-10T15:26:52Z","pushed_at":"2019-10-10T18:49:52Z","git_url":"git://github.com/tinygo-org/tinygo.git","ssh_url":"git@github.com:tinygo-org/tinygo.git","clone_url":"https://github.com/tinygo-org/tinygo.git","svn_url":"https://github.com/tinygo-org/tinygo","homepage":"https://tinygo.org","size":2568,"stargazers_count":4536,"watchers_count":4536,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":197,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":69,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":197,"open_issues":69,"watchers":4536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tinygo-org/tinygo/pulls/612"},"html":{"href":"https://github.com/tinygo-org/tinygo/pull/612"},"issue":{"href":"https://api.github.com/repos/tinygo-org/tinygo/issues/612"},"comments":{"href":"https://api.github.com/repos/tinygo-org/tinygo/issues/612/comments"},"review_comments":{"href":"https://api.github.com/repos/tinygo-org/tinygo/pulls/612/comments"},"review_comment":{"href":"https://api.github.com/repos/tinygo-org/tinygo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tinygo-org/tinygo/pulls/612/commits"},"statuses":{"href":"https://api.github.com/repos/tinygo-org/tinygo/statuses/d70ba520315068485cf8b5606a1bcbc08c9ac239"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":5,"changed_files":1}}
other: {"actor":{"display_login":"aykevl"}}