payload: {"action":"created","comment":{"url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/comments/334664125","pull_request_review_id":301527274,"id":334664125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDY2NDEyNQ==","diff_hunk":"@@ -380,11 +460,11 @@ contract Attestations is\n   )\n     external\n     view\n-    returns (uint64, uint64)\n+    returns (uint32, uint32)\n   {\n     return (\n       identifiers[identifier].attestations[account].completed,\n-      uint64(identifiers[identifier].attestations[account].issuers.length)\n+      identifiers[identifier].attestations[account].requested","path":"packages/protocol/contracts/identity/Attestations.sol","position":193,"original_position":193,"commit_id":"bb877177278bc93e14d2605fe3db6fb6de5a790f","original_commit_id":"bb877177278bc93e14d2605fe3db6fb6de5a790f","user":{"login":"asaj","id":3280356,"node_id":"MDQ6VXNlcjMyODAzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3280356?v=4","gravatar_id":"","url":"https://api.github.com/users/asaj","html_url":"https://github.com/asaj","followers_url":"https://api.github.com/users/asaj/followers","following_url":"https://api.github.com/users/asaj/following{/other_user}","gists_url":"https://api.github.com/users/asaj/gists{/gist_id}","starred_url":"https://api.github.com/users/asaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaj/subscriptions","organizations_url":"https://api.github.com/users/asaj/orgs","repos_url":"https://api.github.com/users/asaj/repos","events_url":"https://api.github.com/users/asaj/events{/privacy}","received_events_url":"https://api.github.com/users/asaj/received_events","type":"User","site_admin":false},"body":"Why do we need to explicitly store the number requested? Wouldn't it be the length of the `issuers` array, plus the number requested in `requests`?","created_at":"2019-10-14T21:10:32Z","updated_at":"2019-10-14T21:10:43Z","html_url":"https://github.com/celo-org/celo-monorepo/pull/1327#discussion_r334664125","pull_request_url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/comments/334664125"},"html":{"href":"https://github.com/celo-org/celo-monorepo/pull/1327#discussion_r334664125"},"pull_request":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327"}}},"pull_request":{"url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327","id":327887831,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3ODg3ODMx","html_url":"https://github.com/celo-org/celo-monorepo/pull/1327","diff_url":"https://github.com/celo-org/celo-monorepo/pull/1327.diff","patch_url":"https://github.com/celo-org/celo-monorepo/pull/1327.patch","issue_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues/1327","number":1327,"state":"open","locked":false,"title":"Add revealIssuers Transaction","user":{"login":"nambrot","id":571810,"node_id":"MDQ6VXNlcjU3MTgxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/571810?v=4","gravatar_id":"","url":"https://api.github.com/users/nambrot","html_url":"https://github.com/nambrot","followers_url":"https://api.github.com/users/nambrot/followers","following_url":"https://api.github.com/users/nambrot/following{/other_user}","gists_url":"https://api.github.com/users/nambrot/gists{/gist_id}","starred_url":"https://api.github.com/users/nambrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nambrot/subscriptions","organizations_url":"https://api.github.com/users/nambrot/orgs","repos_url":"https://api.github.com/users/nambrot/repos","events_url":"https://api.github.com/users/nambrot/events{/privacy}","received_events_url":"https://api.github.com/users/nambrot/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis PR is the first part for #1314. It adds the commit/reveal transactions, in Attestations speak `request`/`revealIssuers`. It does not currently enforce the wait, will be done in a separate pr once #1197 gets merged\r\n\r\n- [x] record block times\r\n- [x] contractkit mods\r\n\r\n### Tested\r\n\r\n- Unit tests\r\n\r\n### Other changes\r\n\r\nN/A\r\n\r\n\r\n### Backwards compatibility\r\n\r\n- Once merged, it is not backwards compatible\r\n","created_at":"2019-10-14T16:47:51Z","updated_at":"2019-10-14T21:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cdb97882b84a3b50b2a569d0095aeef35da0e94","assignee":{"login":"asaj","id":3280356,"node_id":"MDQ6VXNlcjMyODAzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3280356?v=4","gravatar_id":"","url":"https://api.github.com/users/asaj","html_url":"https://github.com/asaj","followers_url":"https://api.github.com/users/asaj/followers","following_url":"https://api.github.com/users/asaj/following{/other_user}","gists_url":"https://api.github.com/users/asaj/gists{/gist_id}","starred_url":"https://api.github.com/users/asaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaj/subscriptions","organizations_url":"https://api.github.com/users/asaj/orgs","repos_url":"https://api.github.com/users/asaj/repos","events_url":"https://api.github.com/users/asaj/events{/privacy}","received_events_url":"https://api.github.com/users/asaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"asaj","id":3280356,"node_id":"MDQ6VXNlcjMyODAzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3280356?v=4","gravatar_id":"","url":"https://api.github.com/users/asaj","html_url":"https://github.com/asaj","followers_url":"https://api.github.com/users/asaj/followers","following_url":"https://api.github.com/users/asaj/following{/other_user}","gists_url":"https://api.github.com/users/asaj/gists{/gist_id}","starred_url":"https://api.github.com/users/asaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaj/subscriptions","organizations_url":"https://api.github.com/users/asaj/orgs","repos_url":"https://api.github.com/users/asaj/repos","events_url":"https://api.github.com/users/asaj/events{/privacy}","received_events_url":"https://api.github.com/users/asaj/received_events","type":"User","site_admin":false},{"login":"m-chrzan","id":16142976,"node_id":"MDQ6VXNlcjE2MTQyOTc2","avatar_url":"https://avatars0.githubusercontent.com/u/16142976?v=4","gravatar_id":"","url":"https://api.github.com/users/m-chrzan","html_url":"https://github.com/m-chrzan","followers_url":"https://api.github.com/users/m-chrzan/followers","following_url":"https://api.github.com/users/m-chrzan/following{/other_user}","gists_url":"https://api.github.com/users/m-chrzan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-chrzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-chrzan/subscriptions","organizations_url":"https://api.github.com/users/m-chrzan/orgs","repos_url":"https://api.github.com/users/m-chrzan/repos","events_url":"https://api.github.com/users/m-chrzan/events{/privacy}","received_events_url":"https://api.github.com/users/m-chrzan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"m-chrzan","id":16142976,"node_id":"MDQ6VXNlcjE2MTQyOTc2","avatar_url":"https://avatars0.githubusercontent.com/u/16142976?v=4","gravatar_id":"","url":"https://api.github.com/users/m-chrzan","html_url":"https://github.com/m-chrzan","followers_url":"https://api.github.com/users/m-chrzan/followers","following_url":"https://api.github.com/users/m-chrzan/following{/other_user}","gists_url":"https://api.github.com/users/m-chrzan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-chrzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-chrzan/subscriptions","organizations_url":"https://api.github.com/users/m-chrzan/orgs","repos_url":"https://api.github.com/users/m-chrzan/repos","events_url":"https://api.github.com/users/m-chrzan/events{/privacy}","received_events_url":"https://api.github.com/users/m-chrzan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327/commits","review_comments_url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327/comments","review_comment_url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues/1327/comments","statuses_url":"https://api.github.com/repos/celo-org/celo-monorepo/statuses/bb877177278bc93e14d2605fe3db6fb6de5a790f","head":{"label":"celo-org:nambrot/attestation-commit","ref":"nambrot/attestation-commit","sha":"bb877177278bc93e14d2605fe3db6fb6de5a790f","user":{"login":"celo-org","id":37552875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTUyODc1","avatar_url":"https://avatars2.githubusercontent.com/u/37552875?v=4","gravatar_id":"","url":"https://api.github.com/users/celo-org","html_url":"https://github.com/celo-org","followers_url":"https://api.github.com/users/celo-org/followers","following_url":"https://api.github.com/users/celo-org/following{/other_user}","gists_url":"https://api.github.com/users/celo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/celo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celo-org/subscriptions","organizations_url":"https://api.github.com/users/celo-org/orgs","repos_url":"https://api.github.com/users/celo-org/repos","events_url":"https://api.github.com/users/celo-org/events{/privacy}","received_events_url":"https://api.github.com/users/celo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":197642503,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc2NDI1MDM=","name":"celo-monorepo","full_name":"celo-org/celo-monorepo","private":false,"owner":{"login":"celo-org","id":37552875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTUyODc1","avatar_url":"https://avatars2.githubusercontent.com/u/37552875?v=4","gravatar_id":"","url":"https://api.github.com/users/celo-org","html_url":"https://github.com/celo-org","followers_url":"https://api.github.com/users/celo-org/followers","following_url":"https://api.github.com/users/celo-org/following{/other_user}","gists_url":"https://api.github.com/users/celo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/celo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celo-org/subscriptions","organizations_url":"https://api.github.com/users/celo-org/orgs","repos_url":"https://api.github.com/users/celo-org/repos","events_url":"https://api.github.com/users/celo-org/events{/privacy}","received_events_url":"https://api.github.com/users/celo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/celo-org/celo-monorepo","description":"Official repository for core projects comprising the Celo platform","fork":false,"url":"https://api.github.com/repos/celo-org/celo-monorepo","forks_url":"https://api.github.com/repos/celo-org/celo-monorepo/forks","keys_url":"https://api.github.com/repos/celo-org/celo-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/celo-org/celo-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/celo-org/celo-monorepo/teams","hooks_url":"https://api.github.com/repos/celo-org/celo-monorepo/hooks","issue_events_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/celo-org/celo-monorepo/events","assignees_url":"https://api.github.com/repos/celo-org/celo-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/celo-org/celo-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/celo-org/celo-monorepo/tags","blobs_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/celo-org/celo-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/celo-org/celo-monorepo/languages","stargazers_url":"https://api.github.com/repos/celo-org/celo-monorepo/stargazers","contributors_url":"https://api.github.com/repos/celo-org/celo-monorepo/contributors","subscribers_url":"https://api.github.com/repos/celo-org/celo-monorepo/subscribers","subscription_url":"https://api.github.com/repos/celo-org/celo-monorepo/subscription","commits_url":"https://api.github.com/repos/celo-org/celo-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/celo-org/celo-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/celo-org/celo-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/celo-org/celo-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/celo-org/celo-monorepo/merges","archive_url":"https://api.github.com/repos/celo-org/celo-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/celo-org/celo-monorepo/downloads","issues_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/celo-org/celo-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/celo-org/celo-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/celo-org/celo-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/celo-org/celo-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/celo-org/celo-monorepo/deployments","created_at":"2019-07-18T19:05:59Z","updated_at":"2019-10-14T20:41:01Z","pushed_at":"2019-10-14T20:48:38Z","git_url":"git://github.com/celo-org/celo-monorepo.git","ssh_url":"git@github.com:celo-org/celo-monorepo.git","clone_url":"https://github.com/celo-org/celo-monorepo.git","svn_url":"https://github.com/celo-org/celo-monorepo","homepage":"https://celo.org","size":43374,"stargazers_count":61,"watchers_count":61,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":348,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":348,"watchers":61,"default_branch":"master"}},"base":{"label":"celo-org:master","ref":"master","sha":"e8f6f1d366d975209bc0f21cb91ae2ef2119f810","user":{"login":"celo-org","id":37552875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTUyODc1","avatar_url":"https://avatars2.githubusercontent.com/u/37552875?v=4","gravatar_id":"","url":"https://api.github.com/users/celo-org","html_url":"https://github.com/celo-org","followers_url":"https://api.github.com/users/celo-org/followers","following_url":"https://api.github.com/users/celo-org/following{/other_user}","gists_url":"https://api.github.com/users/celo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/celo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celo-org/subscriptions","organizations_url":"https://api.github.com/users/celo-org/orgs","repos_url":"https://api.github.com/users/celo-org/repos","events_url":"https://api.github.com/users/celo-org/events{/privacy}","received_events_url":"https://api.github.com/users/celo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":197642503,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc2NDI1MDM=","name":"celo-monorepo","full_name":"celo-org/celo-monorepo","private":false,"owner":{"login":"celo-org","id":37552875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTUyODc1","avatar_url":"https://avatars2.githubusercontent.com/u/37552875?v=4","gravatar_id":"","url":"https://api.github.com/users/celo-org","html_url":"https://github.com/celo-org","followers_url":"https://api.github.com/users/celo-org/followers","following_url":"https://api.github.com/users/celo-org/following{/other_user}","gists_url":"https://api.github.com/users/celo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/celo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celo-org/subscriptions","organizations_url":"https://api.github.com/users/celo-org/orgs","repos_url":"https://api.github.com/users/celo-org/repos","events_url":"https://api.github.com/users/celo-org/events{/privacy}","received_events_url":"https://api.github.com/users/celo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/celo-org/celo-monorepo","description":"Official repository for core projects comprising the Celo platform","fork":false,"url":"https://api.github.com/repos/celo-org/celo-monorepo","forks_url":"https://api.github.com/repos/celo-org/celo-monorepo/forks","keys_url":"https://api.github.com/repos/celo-org/celo-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/celo-org/celo-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/celo-org/celo-monorepo/teams","hooks_url":"https://api.github.com/repos/celo-org/celo-monorepo/hooks","issue_events_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/celo-org/celo-monorepo/events","assignees_url":"https://api.github.com/repos/celo-org/celo-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/celo-org/celo-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/celo-org/celo-monorepo/tags","blobs_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/celo-org/celo-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/celo-org/celo-monorepo/languages","stargazers_url":"https://api.github.com/repos/celo-org/celo-monorepo/stargazers","contributors_url":"https://api.github.com/repos/celo-org/celo-monorepo/contributors","subscribers_url":"https://api.github.com/repos/celo-org/celo-monorepo/subscribers","subscription_url":"https://api.github.com/repos/celo-org/celo-monorepo/subscription","commits_url":"https://api.github.com/repos/celo-org/celo-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/celo-org/celo-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/celo-org/celo-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/celo-org/celo-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/celo-org/celo-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/celo-org/celo-monorepo/merges","archive_url":"https://api.github.com/repos/celo-org/celo-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/celo-org/celo-monorepo/downloads","issues_url":"https://api.github.com/repos/celo-org/celo-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/celo-org/celo-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/celo-org/celo-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/celo-org/celo-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/celo-org/celo-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/celo-org/celo-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/celo-org/celo-monorepo/deployments","created_at":"2019-07-18T19:05:59Z","updated_at":"2019-10-14T20:41:01Z","pushed_at":"2019-10-14T20:48:38Z","git_url":"git://github.com/celo-org/celo-monorepo.git","ssh_url":"git@github.com:celo-org/celo-monorepo.git","clone_url":"https://github.com/celo-org/celo-monorepo.git","svn_url":"https://github.com/celo-org/celo-monorepo","homepage":"https://celo.org","size":43374,"stargazers_count":61,"watchers_count":61,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":348,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":348,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327"},"html":{"href":"https://github.com/celo-org/celo-monorepo/pull/1327"},"issue":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/issues/1327"},"comments":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/issues/1327/comments"},"review_comments":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327/comments"},"review_comment":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/pulls/1327/commits"},"statuses":{"href":"https://api.github.com/repos/celo-org/celo-monorepo/statuses/bb877177278bc93e14d2605fe3db6fb6de5a790f"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"asaj"}}