payload: {"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/comments/297959359","pull_request_review_id":254978403,"id":297959359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Nzk1OTM1OQ==","diff_hunk":"@@ -218,6 +218,11 @@ private Run CreateSarifRun()\n                     _originalUriBasePath = \"file:/\" + _originalUriBasePath;\n                 }\n \n+                if (_originalUriBasePath.EndsWith(\":\"))\n+                {\n+                    _originalUriBasePath = _originalUriBasePath + \"/\";","path":"src/Sarif.Converters/FortifyFprConverter.cs","position":null,"original_position":6,"commit_id":"ea959a9d2ce8586db8cbf10e3fa3c636fa367c31","original_commit_id":"5baf6686f29b098828dfc5b8c9794e5d2e629fcf","user":{"login":"harleenkohli","id":23230747,"node_id":"MDQ6VXNlcjIzMjMwNzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/23230747?v=4","gravatar_id":"","url":"https://api.github.com/users/harleenkohli","html_url":"https://github.com/harleenkohli","followers_url":"https://api.github.com/users/harleenkohli/followers","following_url":"https://api.github.com/users/harleenkohli/following{/other_user}","gists_url":"https://api.github.com/users/harleenkohli/gists{/gist_id}","starred_url":"https://api.github.com/users/harleenkohli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harleenkohli/subscriptions","organizations_url":"https://api.github.com/users/harleenkohli/orgs","repos_url":"https://api.github.com/users/harleenkohli/repos","events_url":"https://api.github.com/users/harleenkohli/events{/privacy}","received_events_url":"https://api.github.com/users/harleenkohli/received_events","type":"User","site_admin":false},"body":"thanks, updated. and i extracted the method to bring under unit test, this includes linux platform related change as well, so i added that as another test case.\r\n\r\n---\r\nIn reply to: [297943211](https://github.com/microsoft/sarif-sdk/pull/1547#discussion_r297943211) [](ancestors = 297943211)","created_at":"2019-06-27T03:02:51Z","updated_at":"2019-06-27T03:02:51Z","html_url":"https://github.com/microsoft/sarif-sdk/pull/1547#discussion_r297959359","pull_request_url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/comments/297959359"},"html":{"href":"https://github.com/microsoft/sarif-sdk/pull/1547#discussion_r297959359"},"pull_request":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547"}},"in_reply_to_id":297943211},"pull_request":{"url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547","id":292225580,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyMjI1NTgw","html_url":"https://github.com/microsoft/sarif-sdk/pull/1547","diff_url":"https://github.com/microsoft/sarif-sdk/pull/1547.diff","patch_url":"https://github.com/microsoft/sarif-sdk/pull/1547.patch","issue_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues/1547","number":1547,"state":"open","locked":false,"title":"Fortify converter ignores originalUriBaseId if root (e.g. C:)","user":{"login":"harleenkohli","id":23230747,"node_id":"MDQ6VXNlcjIzMjMwNzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/23230747?v=4","gravatar_id":"","url":"https://api.github.com/users/harleenkohli","html_url":"https://github.com/harleenkohli","followers_url":"https://api.github.com/users/harleenkohli/followers","following_url":"https://api.github.com/users/harleenkohli/following{/other_user}","gists_url":"https://api.github.com/users/harleenkohli/gists{/gist_id}","starred_url":"https://api.github.com/users/harleenkohli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harleenkohli/subscriptions","organizations_url":"https://api.github.com/users/harleenkohli/orgs","repos_url":"https://api.github.com/users/harleenkohli/repos","events_url":"https://api.github.com/users/harleenkohli/events{/privacy}","received_events_url":"https://api.github.com/users/harleenkohli/received_events","type":"User","site_admin":false},"body":"in fvdl, if <SourceBasePath> is a root (e.g C:), this is ignored by fortify converter.\r\n    <SourceBasePath>C:</SourceBasePath>\r\n\r\nThis is because Uri.TryCreate method does not treat \"C:\" as an absolute URI.\r\n\r\nFixing this by manually appending a \"/\" . We had a test case which covers this scenario already, hence rebaselined it to new expected result.","created_at":"2019-06-27T01:34:37Z","updated_at":"2019-06-27T03:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38f78a3fb37b41251112b98165e9a68c4c1ca23b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547/commits","review_comments_url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547/comments","review_comment_url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues/1547/comments","statuses_url":"https://api.github.com/repos/microsoft/sarif-sdk/statuses/ea959a9d2ce8586db8cbf10e3fa3c636fa367c31","head":{"label":"microsoft:fortify-missing-originalUriBaseId","ref":"fortify-missing-originalUriBaseId","sha":"ea959a9d2ce8586db8cbf10e3fa3c636fa367c31","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45640472,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY0MDQ3Mg==","name":"sarif-sdk","full_name":"microsoft/sarif-sdk","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/sarif-sdk","description":".NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/sarif-standard/sarif-spec)","fork":false,"url":"https://api.github.com/repos/microsoft/sarif-sdk","forks_url":"https://api.github.com/repos/microsoft/sarif-sdk/forks","keys_url":"https://api.github.com/repos/microsoft/sarif-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/sarif-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/sarif-sdk/teams","hooks_url":"https://api.github.com/repos/microsoft/sarif-sdk/hooks","issue_events_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/sarif-sdk/events","assignees_url":"https://api.github.com/repos/microsoft/sarif-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/sarif-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/sarif-sdk/tags","blobs_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/sarif-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/sarif-sdk/languages","stargazers_url":"https://api.github.com/repos/microsoft/sarif-sdk/stargazers","contributors_url":"https://api.github.com/repos/microsoft/sarif-sdk/contributors","subscribers_url":"https://api.github.com/repos/microsoft/sarif-sdk/subscribers","subscription_url":"https://api.github.com/repos/microsoft/sarif-sdk/subscription","commits_url":"https://api.github.com/repos/microsoft/sarif-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/sarif-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/sarif-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/sarif-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/sarif-sdk/merges","archive_url":"https://api.github.com/repos/microsoft/sarif-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/sarif-sdk/downloads","issues_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/sarif-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/sarif-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/sarif-sdk/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/sarif-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/sarif-sdk/deployments","created_at":"2015-11-05T21:26:46Z","updated_at":"2019-06-26T21:55:04Z","pushed_at":"2019-06-27T03:00:52Z","git_url":"git://github.com/microsoft/sarif-sdk.git","ssh_url":"git@github.com:microsoft/sarif-sdk.git","clone_url":"https://github.com/microsoft/sarif-sdk.git","svn_url":"https://github.com/microsoft/sarif-sdk","homepage":"","size":92955,"stargazers_count":40,"watchers_count":40,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":231,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":231,"watchers":40,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"4efcbc947dddb4cca5b7a523b6d7a816cc52e171","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45640472,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY0MDQ3Mg==","name":"sarif-sdk","full_name":"microsoft/sarif-sdk","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/sarif-sdk","description":".NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/sarif-standard/sarif-spec)","fork":false,"url":"https://api.github.com/repos/microsoft/sarif-sdk","forks_url":"https://api.github.com/repos/microsoft/sarif-sdk/forks","keys_url":"https://api.github.com/repos/microsoft/sarif-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/sarif-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/sarif-sdk/teams","hooks_url":"https://api.github.com/repos/microsoft/sarif-sdk/hooks","issue_events_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/sarif-sdk/events","assignees_url":"https://api.github.com/repos/microsoft/sarif-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/sarif-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/sarif-sdk/tags","blobs_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/sarif-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/sarif-sdk/languages","stargazers_url":"https://api.github.com/repos/microsoft/sarif-sdk/stargazers","contributors_url":"https://api.github.com/repos/microsoft/sarif-sdk/contributors","subscribers_url":"https://api.github.com/repos/microsoft/sarif-sdk/subscribers","subscription_url":"https://api.github.com/repos/microsoft/sarif-sdk/subscription","commits_url":"https://api.github.com/repos/microsoft/sarif-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/sarif-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/sarif-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/sarif-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/sarif-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/sarif-sdk/merges","archive_url":"https://api.github.com/repos/microsoft/sarif-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/sarif-sdk/downloads","issues_url":"https://api.github.com/repos/microsoft/sarif-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/sarif-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/sarif-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/sarif-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/sarif-sdk/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/sarif-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/sarif-sdk/deployments","created_at":"2015-11-05T21:26:46Z","updated_at":"2019-06-26T21:55:04Z","pushed_at":"2019-06-27T03:00:52Z","git_url":"git://github.com/microsoft/sarif-sdk.git","ssh_url":"git@github.com:microsoft/sarif-sdk.git","clone_url":"https://github.com/microsoft/sarif-sdk.git","svn_url":"https://github.com/microsoft/sarif-sdk","homepage":"","size":92955,"stargazers_count":40,"watchers_count":40,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":231,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":231,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547"},"html":{"href":"https://github.com/microsoft/sarif-sdk/pull/1547"},"issue":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/issues/1547"},"comments":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/issues/1547/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/pulls/1547/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/sarif-sdk/statuses/ea959a9d2ce8586db8cbf10e3fa3c636fa367c31"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"harleenkohli"}}