payload: {"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/422","repository_url":"https://api.github.com/repos/openzipkin/zipkin-js","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/422/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/422/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/422/events","html_url":"https://github.com/openzipkin/zipkin-js/issues/422","id":472335555,"node_id":"MDU6SXNzdWU0NzIzMzU1NTU=","number":422,"title":"Error: Must be valid TraceId instance","user":{"login":"russell-matt","id":10886400,"node_id":"MDQ6VXNlcjEwODg2NDAw","avatar_url":"https://avatars3.githubusercontent.com/u/10886400?v=4","gravatar_id":"","url":"https://api.github.com/users/russell-matt","html_url":"https://github.com/russell-matt","followers_url":"https://api.github.com/users/russell-matt/followers","following_url":"https://api.github.com/users/russell-matt/following{/other_user}","gists_url":"https://api.github.com/users/russell-matt/gists{/gist_id}","starred_url":"https://api.github.com/users/russell-matt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russell-matt/subscriptions","organizations_url":"https://api.github.com/users/russell-matt/orgs","repos_url":"https://api.github.com/users/russell-matt/repos","events_url":"https://api.github.com/users/russell-matt/events{/privacy}","received_events_url":"https://api.github.com/users/russell-matt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"assignees":[{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2019-07-24T15:02:47Z","updated_at":"2019-07-24T16:33:23Z","closed_at":"2019-07-24T16:26:41Z","author_association":"CONTRIBUTOR","body":"After upgrading to version 0.18.5 of zipkin-instrumentation-restify and zipkin, I am getting the following error when the request to my server comes in with a traceId: \"Error: Must be valid TraceId instance\".\r\n\r\nI've narrowed the problem down to the following snippet of code in [zipkin/tracer/index.js](https://github.com/openzipkin/zipkin-js/blob/master/packages/zipkin/src/tracer/index.js#L171) inside the join function\r\n\r\n```\r\nif (!(traceId instanceof TraceId)) {\r\n    throw new Error('Must be valid TraceId instance');\r\n}\r\n```\r\n\r\nThis if is always resulting to false, after inspecting the traceid passed to this function, I found the following.\r\n\r\ntraceId parameter:\r\n```\r\nTraceId {\r\n  _traceId: 'b7daf2ae1b9e2555',\r\n  _parentId:\r\n   { type: [Getter],\r\n     present: [Getter],\r\n     map: [Function: map],\r\n     ifPresent: [Function: ifPresent],\r\n     flatMap: [Function: flatMap],\r\n     getOrElse: [Function: getOrElse],\r\n     equals: [Function: equals],\r\n     toString: [Function: toString] },\r\n  _spanId: 'b7daf2ae1b9e2555',\r\n  _sampled:\r\n   { type: [Getter],\r\n     present: [Getter],\r\n     map: [Function: map],\r\n     ifPresent: [Function: ifPresent],\r\n     flatMap: [Function: flatMap],\r\n     getOrElse: [Function: getOrElse],\r\n     equals: [Function: equals],\r\n     toString: [Function: toString] },\r\n  _debug: false,\r\n  _shared: false }\r\n```\r\n\r\n`traceId instanceof TraceId_1`: false\r\n`traceId.constructor.name`: TraceId\r\n`TraceId_1.constructor.name`: Function\r\n`TraceId.constructor.name`: Function\r\n\r\nPlease note: The usage of TraceId_1 is because that is the output produced after transpilation, and hence is what is being checked in the code when it is actually running.\r\n\r\n```\r\nif (!(traceId instanceof TraceId_1)) {\r\n    throw new Error('Must be valid TraceId instance');\r\n}\r\n```\r\n\r\nThis issue only happens if the request is made with the traceid and spanid headers populated."},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/comments/514706179","html_url":"https://github.com/openzipkin/zipkin-js/issues/422#issuecomment-514706179","issue_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/422","id":514706179,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNDcwNjE3OQ==","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2019-07-24T16:33:23Z","updated_at":"2019-07-24T16:33:23Z","author_association":"CONTRIBUTOR","body":"https://github.com/openzipkin/zipkin-js/releases/tag/v0.18.6"}}
other: {"actor":{"display_login":"adriancole"}}