payload: {"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/271556435","pull_request_review_id":221977428,"id":271556435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTU1NjQzNQ==","diff_hunk":"@@ -34,6 +34,7 @@ type MixConfig struct {\n \tSwupd   swupdConf\n \tServer  serverConf\n \tMixer   mixerConf\n+\tOs      osConf","path":"config/config.go","position":4,"original_position":4,"commit_id":"0c36713b89f400802bd5fc35087864ee3f5e867b","original_commit_id":"0c36713b89f400802bd5fc35087864ee3f5e867b","user":{"login":"sweeaun","id":32087198,"node_id":"MDQ6VXNlcjMyMDg3MTk4","avatar_url":"https://avatars1.githubusercontent.com/u/32087198?v=4","gravatar_id":"","url":"https://api.github.com/users/sweeaun","html_url":"https://github.com/sweeaun","followers_url":"https://api.github.com/users/sweeaun/followers","following_url":"https://api.github.com/users/sweeaun/following{/other_user}","gists_url":"https://api.github.com/users/sweeaun/gists{/gist_id}","starred_url":"https://api.github.com/users/sweeaun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweeaun/subscriptions","organizations_url":"https://api.github.com/users/sweeaun/orgs","repos_url":"https://api.github.com/users/sweeaun/repos","events_url":"https://api.github.com/users/sweeaun/events{/privacy}","received_events_url":"https://api.github.com/users/sweeaun/received_events","type":"User","site_admin":false},"body":"Sure. I can change it to more specific name related to OsRelease. I will change the section name in the builder.conf as well. Use [OsRelease] instead of [Os].","created_at":"2019-04-03T02:03:10Z","updated_at":"2019-04-03T02:03:10Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/563#discussion_r271556435","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/271556435"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/563#discussion_r271556435"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563"}},"in_reply_to_id":271379924},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563","id":266120658,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2MTIwNjU4","html_url":"https://github.com/clearlinux/mixer-tools/pull/563","diff_url":"https://github.com/clearlinux/mixer-tools/pull/563.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/563.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/563","number":563,"state":"open","locked":false,"title":"config: Allow OS identification customization #560","user":{"login":"sweeaun","id":32087198,"node_id":"MDQ6VXNlcjMyMDg3MTk4","avatar_url":"https://avatars1.githubusercontent.com/u/32087198?v=4","gravatar_id":"","url":"https://api.github.com/users/sweeaun","html_url":"https://github.com/sweeaun","followers_url":"https://api.github.com/users/sweeaun/followers","following_url":"https://api.github.com/users/sweeaun/following{/other_user}","gists_url":"https://api.github.com/users/sweeaun/gists{/gist_id}","starred_url":"https://api.github.com/users/sweeaun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweeaun/subscriptions","organizations_url":"https://api.github.com/users/sweeaun/orgs","repos_url":"https://api.github.com/users/sweeaun/repos","events_url":"https://api.github.com/users/sweeaun/events{/privacy}","received_events_url":"https://api.github.com/users/sweeaun/received_events","type":"User","site_admin":false},"body":"New [Os] section is added in builder.conf file to support\r\nOS identification modification such as NAME, VERSION, ID,\r\nID_LIKE, PRETTY_NAME, ANSI_COLOR, HOME_URL, SUPPORT_URL,\r\nBUG_REPORT_URL and PRIVACY_POLICY_URL for downstream Clear Linux\r\nbuild.\r\n\r\nThis section NOT supporting VERSION_ID since it has been used by\r\nMixer for mixversion.\r\n\r\nExample to modify os-release file:\r\nChange the NAME, PRETTY_NAME and PRIVACY_POLICY_URL\r\n\r\n[Os]\r\n  NAME = \"Clear-Linux-A\"\r\n  PRETTY_NAME = \"A Clear Linux OS\"\r\n  PRIVACY_POLICY_URL = \"\"\r\n\r\nExample to keep value based on default os-release file:\r\n\r\n[Os]\r\n  ANSI_COLOR = \"<NoChange>\"\r\n  HOME_URL = \"<NoChange>\"\r\n  SUPPORT_URL = \"<NoChange>\"\r\n  BUG_REPORT_URL = \"<NoChange>\"\r\n\r\nSigned-off-by: sweeaun <swee.aun.khor@intel.com>","created_at":"2019-04-01T07:23:32Z","updated_at":"2019-04-03T02:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb99dd3442c32704345a16d142681aef5924286c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/563/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/0c36713b89f400802bd5fc35087864ee3f5e867b","head":{"label":"sweeaun:builder-os-section","ref":"builder-os-section","sha":"0c36713b89f400802bd5fc35087864ee3f5e867b","user":{"login":"sweeaun","id":32087198,"node_id":"MDQ6VXNlcjMyMDg3MTk4","avatar_url":"https://avatars1.githubusercontent.com/u/32087198?v=4","gravatar_id":"","url":"https://api.github.com/users/sweeaun","html_url":"https://github.com/sweeaun","followers_url":"https://api.github.com/users/sweeaun/followers","following_url":"https://api.github.com/users/sweeaun/following{/other_user}","gists_url":"https://api.github.com/users/sweeaun/gists{/gist_id}","starred_url":"https://api.github.com/users/sweeaun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweeaun/subscriptions","organizations_url":"https://api.github.com/users/sweeaun/orgs","repos_url":"https://api.github.com/users/sweeaun/repos","events_url":"https://api.github.com/users/sweeaun/events{/privacy}","received_events_url":"https://api.github.com/users/sweeaun/received_events","type":"User","site_admin":false},"repo":{"id":176413024,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0MTMwMjQ=","name":"mixer-tools","full_name":"sweeaun/mixer-tools","private":false,"owner":{"login":"sweeaun","id":32087198,"node_id":"MDQ6VXNlcjMyMDg3MTk4","avatar_url":"https://avatars1.githubusercontent.com/u/32087198?v=4","gravatar_id":"","url":"https://api.github.com/users/sweeaun","html_url":"https://github.com/sweeaun","followers_url":"https://api.github.com/users/sweeaun/followers","following_url":"https://api.github.com/users/sweeaun/following{/other_user}","gists_url":"https://api.github.com/users/sweeaun/gists{/gist_id}","starred_url":"https://api.github.com/users/sweeaun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweeaun/subscriptions","organizations_url":"https://api.github.com/users/sweeaun/orgs","repos_url":"https://api.github.com/users/sweeaun/repos","events_url":"https://api.github.com/users/sweeaun/events{/privacy}","received_events_url":"https://api.github.com/users/sweeaun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sweeaun/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/sweeaun/mixer-tools","forks_url":"https://api.github.com/repos/sweeaun/mixer-tools/forks","keys_url":"https://api.github.com/repos/sweeaun/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sweeaun/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sweeaun/mixer-tools/teams","hooks_url":"https://api.github.com/repos/sweeaun/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/sweeaun/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/sweeaun/mixer-tools/events","assignees_url":"https://api.github.com/repos/sweeaun/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/sweeaun/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/sweeaun/mixer-tools/tags","blobs_url":"https://api.github.com/repos/sweeaun/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sweeaun/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sweeaun/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sweeaun/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sweeaun/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/sweeaun/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/sweeaun/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/sweeaun/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/sweeaun/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/sweeaun/mixer-tools/subscription","commits_url":"https://api.github.com/repos/sweeaun/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sweeaun/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sweeaun/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sweeaun/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sweeaun/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/sweeaun/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sweeaun/mixer-tools/merges","archive_url":"https://api.github.com/repos/sweeaun/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sweeaun/mixer-tools/downloads","issues_url":"https://api.github.com/repos/sweeaun/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/sweeaun/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/sweeaun/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/sweeaun/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sweeaun/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/sweeaun/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/sweeaun/mixer-tools/deployments","created_at":"2019-03-19T03:08:11Z","updated_at":"2019-03-19T03:08:15Z","pushed_at":"2019-03-29T18:44:31Z","git_url":"git://github.com/sweeaun/mixer-tools.git","ssh_url":"git@github.com:sweeaun/mixer-tools.git","clone_url":"https://github.com/sweeaun/mixer-tools.git","svn_url":"https://github.com/sweeaun/mixer-tools","homepage":null,"size":7919,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"3ac4408471952fef46961e181b6b34cbb934c042","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQzOTQ3NA==","name":"mixer-tools","full_name":"clearlinux/mixer-tools","private":false,"owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2019-03-07T22:42:52Z","pushed_at":"2019-04-02T17:53:38Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":7883,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":64,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/563"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/563"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/0c36713b89f400802bd5fc35087864ee3f5e867b"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"sweeaun"}}