payload: {"action":"closed","number":906,"pull_request":{"url":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/906","id":287978526,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3OTc4NTI2","html_url":"https://github.com/uNetworking/uWebSockets/pull/906","diff_url":"https://github.com/uNetworking/uWebSockets/pull/906.diff","patch_url":"https://github.com/uNetworking/uWebSockets/pull/906.patch","issue_url":"https://api.github.com/repos/uNetworking/uWebSockets/issues/906","number":906,"state":"closed","locked":false,"title":"Clarify getHeader argument meaning","user":{"login":"zxey","id":5235838,"node_id":"MDQ6VXNlcjUyMzU4Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5235838?v=4","gravatar_id":"","url":"https://api.github.com/users/zxey","html_url":"https://github.com/zxey","followers_url":"https://api.github.com/users/zxey/followers","following_url":"https://api.github.com/users/zxey/following{/other_user}","gists_url":"https://api.github.com/users/zxey/gists{/gist_id}","starred_url":"https://api.github.com/users/zxey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxey/subscriptions","organizations_url":"https://api.github.com/users/zxey/orgs","repos_url":"https://api.github.com/users/zxey/repos","events_url":"https://api.github.com/users/zxey/events{/privacy}","received_events_url":"https://api.github.com/users/zxey/received_events","type":"User","site_admin":false},"body":"I tried to use getHeader method on HttpRequest and found out that it did not perform case insensitive search on headers.\r\n\r\nIt is specified by [RFC 2616 - \"Hypertext Transfer Protocol -- HTTP/1.1\"](https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2) that headers should be case insensitive:\r\n> Each header field consists of a name followed by a colon (\":\") and the field value. Field names are case-insensitive.\r\n","created_at":"2019-06-13T15:22:52Z","updated_at":"2019-06-14T08:15:03Z","closed_at":"2019-06-14T08:15:03Z","merged_at":"2019-06-14T08:15:02Z","merge_commit_sha":"a2f96d46f944fa6c5db888fc0e000db83521b38d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/906/commits","review_comments_url":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/906/comments","review_comment_url":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uNetworking/uWebSockets/issues/906/comments","statuses_url":"https://api.github.com/repos/uNetworking/uWebSockets/statuses/164b5b7bf9660892f94cafad10415043906a492e","head":{"label":"zxey:master","ref":"master","sha":"164b5b7bf9660892f94cafad10415043906a492e","user":{"login":"zxey","id":5235838,"node_id":"MDQ6VXNlcjUyMzU4Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5235838?v=4","gravatar_id":"","url":"https://api.github.com/users/zxey","html_url":"https://github.com/zxey","followers_url":"https://api.github.com/users/zxey/followers","following_url":"https://api.github.com/users/zxey/following{/other_user}","gists_url":"https://api.github.com/users/zxey/gists{/gist_id}","starred_url":"https://api.github.com/users/zxey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxey/subscriptions","organizations_url":"https://api.github.com/users/zxey/orgs","repos_url":"https://api.github.com/users/zxey/repos","events_url":"https://api.github.com/users/zxey/events{/privacy}","received_events_url":"https://api.github.com/users/zxey/received_events","type":"User","site_admin":false},"repo":{"id":191785996,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE3ODU5OTY=","name":"uWebSockets","full_name":"zxey/uWebSockets","private":false,"owner":{"login":"zxey","id":5235838,"node_id":"MDQ6VXNlcjUyMzU4Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5235838?v=4","gravatar_id":"","url":"https://api.github.com/users/zxey","html_url":"https://github.com/zxey","followers_url":"https://api.github.com/users/zxey/followers","following_url":"https://api.github.com/users/zxey/following{/other_user}","gists_url":"https://api.github.com/users/zxey/gists{/gist_id}","starred_url":"https://api.github.com/users/zxey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxey/subscriptions","organizations_url":"https://api.github.com/users/zxey/orgs","repos_url":"https://api.github.com/users/zxey/repos","events_url":"https://api.github.com/users/zxey/events{/privacy}","received_events_url":"https://api.github.com/users/zxey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zxey/uWebSockets","description":"Simple, secure & standards compliant web I/O for the most demanding of applications","fork":true,"url":"https://api.github.com/repos/zxey/uWebSockets","forks_url":"https://api.github.com/repos/zxey/uWebSockets/forks","keys_url":"https://api.github.com/repos/zxey/uWebSockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zxey/uWebSockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zxey/uWebSockets/teams","hooks_url":"https://api.github.com/repos/zxey/uWebSockets/hooks","issue_events_url":"https://api.github.com/repos/zxey/uWebSockets/issues/events{/number}","events_url":"https://api.github.com/repos/zxey/uWebSockets/events","assignees_url":"https://api.github.com/repos/zxey/uWebSockets/assignees{/user}","branches_url":"https://api.github.com/repos/zxey/uWebSockets/branches{/branch}","tags_url":"https://api.github.com/repos/zxey/uWebSockets/tags","blobs_url":"https://api.github.com/repos/zxey/uWebSockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zxey/uWebSockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zxey/uWebSockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/zxey/uWebSockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zxey/uWebSockets/statuses/{sha}","languages_url":"https://api.github.com/repos/zxey/uWebSockets/languages","stargazers_url":"https://api.github.com/repos/zxey/uWebSockets/stargazers","contributors_url":"https://api.github.com/repos/zxey/uWebSockets/contributors","subscribers_url":"https://api.github.com/repos/zxey/uWebSockets/subscribers","subscription_url":"https://api.github.com/repos/zxey/uWebSockets/subscription","commits_url":"https://api.github.com/repos/zxey/uWebSockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/zxey/uWebSockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/zxey/uWebSockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/zxey/uWebSockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/zxey/uWebSockets/contents/{+path}","compare_url":"https://api.github.com/repos/zxey/uWebSockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zxey/uWebSockets/merges","archive_url":"https://api.github.com/repos/zxey/uWebSockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zxey/uWebSockets/downloads","issues_url":"https://api.github.com/repos/zxey/uWebSockets/issues{/number}","pulls_url":"https://api.github.com/repos/zxey/uWebSockets/pulls{/number}","milestones_url":"https://api.github.com/repos/zxey/uWebSockets/milestones{/number}","notifications_url":"https://api.github.com/repos/zxey/uWebSockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zxey/uWebSockets/labels{/name}","releases_url":"https://api.github.com/repos/zxey/uWebSockets/releases{/id}","deployments_url":"https://api.github.com/repos/zxey/uWebSockets/deployments","created_at":"2019-06-13T15:11:56Z","updated_at":"2019-06-14T07:46:09Z","pushed_at":"2019-06-14T07:46:07Z","git_url":"git://github.com/zxey/uWebSockets.git","ssh_url":"git@github.com:zxey/uWebSockets.git","clone_url":"https://github.com/zxey/uWebSockets.git","svn_url":"https://github.com/zxey/uWebSockets","homepage":"","size":2925,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uNetworking:master","ref":"master","sha":"a87df76f91e4a7e52dd36c2968cca31523bbd1e4","user":{"login":"uNetworking","id":28876608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODc2NjA4","avatar_url":"https://avatars3.githubusercontent.com/u/28876608?v=4","gravatar_id":"","url":"https://api.github.com/users/uNetworking","html_url":"https://github.com/uNetworking","followers_url":"https://api.github.com/users/uNetworking/followers","following_url":"https://api.github.com/users/uNetworking/following{/other_user}","gists_url":"https://api.github.com/users/uNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/uNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uNetworking/subscriptions","organizations_url":"https://api.github.com/users/uNetworking/orgs","repos_url":"https://api.github.com/users/uNetworking/repos","events_url":"https://api.github.com/users/uNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/uNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":54360307,"node_id":"MDEwOlJlcG9zaXRvcnk1NDM2MDMwNw==","name":"uWebSockets","full_name":"uNetworking/uWebSockets","private":false,"owner":{"login":"uNetworking","id":28876608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODc2NjA4","avatar_url":"https://avatars3.githubusercontent.com/u/28876608?v=4","gravatar_id":"","url":"https://api.github.com/users/uNetworking","html_url":"https://github.com/uNetworking","followers_url":"https://api.github.com/users/uNetworking/followers","following_url":"https://api.github.com/users/uNetworking/following{/other_user}","gists_url":"https://api.github.com/users/uNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/uNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uNetworking/subscriptions","organizations_url":"https://api.github.com/users/uNetworking/orgs","repos_url":"https://api.github.com/users/uNetworking/repos","events_url":"https://api.github.com/users/uNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/uNetworking/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uNetworking/uWebSockets","description":"Simple, secure & standards compliant web I/O for the most demanding of applications","fork":false,"url":"https://api.github.com/repos/uNetworking/uWebSockets","forks_url":"https://api.github.com/repos/uNetworking/uWebSockets/forks","keys_url":"https://api.github.com/repos/uNetworking/uWebSockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uNetworking/uWebSockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uNetworking/uWebSockets/teams","hooks_url":"https://api.github.com/repos/uNetworking/uWebSockets/hooks","issue_events_url":"https://api.github.com/repos/uNetworking/uWebSockets/issues/events{/number}","events_url":"https://api.github.com/repos/uNetworking/uWebSockets/events","assignees_url":"https://api.github.com/repos/uNetworking/uWebSockets/assignees{/user}","branches_url":"https://api.github.com/repos/uNetworking/uWebSockets/branches{/branch}","tags_url":"https://api.github.com/repos/uNetworking/uWebSockets/tags","blobs_url":"https://api.github.com/repos/uNetworking/uWebSockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uNetworking/uWebSockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uNetworking/uWebSockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/uNetworking/uWebSockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uNetworking/uWebSockets/statuses/{sha}","languages_url":"https://api.github.com/repos/uNetworking/uWebSockets/languages","stargazers_url":"https://api.github.com/repos/uNetworking/uWebSockets/stargazers","contributors_url":"https://api.github.com/repos/uNetworking/uWebSockets/contributors","subscribers_url":"https://api.github.com/repos/uNetworking/uWebSockets/subscribers","subscription_url":"https://api.github.com/repos/uNetworking/uWebSockets/subscription","commits_url":"https://api.github.com/repos/uNetworking/uWebSockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/uNetworking/uWebSockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/uNetworking/uWebSockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/uNetworking/uWebSockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/uNetworking/uWebSockets/contents/{+path}","compare_url":"https://api.github.com/repos/uNetworking/uWebSockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uNetworking/uWebSockets/merges","archive_url":"https://api.github.com/repos/uNetworking/uWebSockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uNetworking/uWebSockets/downloads","issues_url":"https://api.github.com/repos/uNetworking/uWebSockets/issues{/number}","pulls_url":"https://api.github.com/repos/uNetworking/uWebSockets/pulls{/number}","milestones_url":"https://api.github.com/repos/uNetworking/uWebSockets/milestones{/number}","notifications_url":"https://api.github.com/repos/uNetworking/uWebSockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uNetworking/uWebSockets/labels{/name}","releases_url":"https://api.github.com/repos/uNetworking/uWebSockets/releases{/id}","deployments_url":"https://api.github.com/repos/uNetworking/uWebSockets/deployments","created_at":"2016-03-21T04:39:40Z","updated_at":"2019-06-14T05:48:11Z","pushed_at":"2019-06-14T08:15:02Z","git_url":"git://github.com/uNetworking/uWebSockets.git","ssh_url":"git@github.com:uNetworking/uWebSockets.git","clone_url":"https://github.com/uNetworking/uWebSockets.git","svn_url":"https://github.com/uNetworking/uWebSockets","homepage":"","size":2925,"stargazers_count":10631,"watchers_count":10631,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1009,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1009,"open_issues":17,"watchers":10631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/906"},"html":{"href":"https://github.com/uNetworking/uWebSockets/pull/906"},"issue":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/issues/906"},"comments":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/uNetworking/uWebSockets/statuses/164b5b7bf9660892f94cafad10415043906a492e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexhultman","id":3397140,"node_id":"MDQ6VXNlcjMzOTcxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3397140?v=4","gravatar_id":"","url":"https://api.github.com/users/alexhultman","html_url":"https://github.com/alexhultman","followers_url":"https://api.github.com/users/alexhultman/followers","following_url":"https://api.github.com/users/alexhultman/following{/other_user}","gists_url":"https://api.github.com/users/alexhultman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhultman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhultman/subscriptions","organizations_url":"https://api.github.com/users/alexhultman/orgs","repos_url":"https://api.github.com/users/alexhultman/repos","events_url":"https://api.github.com/users/alexhultman/events{/privacy}","received_events_url":"https://api.github.com/users/alexhultman/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
other: {"actor":{"display_login":"alexhultman"}}