payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/golemfactory/golem/issues/4197","repository_url":"https://api.github.com/repos/golemfactory/golem","labels_url":"https://api.github.com/repos/golemfactory/golem/issues/4197/labels{/name}","comments_url":"https://api.github.com/repos/golemfactory/golem/issues/4197/comments","events_url":"https://api.github.com/repos/golemfactory/golem/issues/4197/events","html_url":"https://github.com/golemfactory/golem/issues/4197","id":444894344,"node_id":"MDU6SXNzdWU0NDQ4OTQzNDQ=","number":4197,"title":"Migrate Payments to Transaction","user":{"login":"jiivan","id":293058,"node_id":"MDQ6VXNlcjI5MzA1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/293058?v=4","gravatar_id":"","url":"https://api.github.com/users/jiivan","html_url":"https://github.com/jiivan","followers_url":"https://api.github.com/users/jiivan/followers","following_url":"https://api.github.com/users/jiivan/following{/other_user}","gists_url":"https://api.github.com/users/jiivan/gists{/gist_id}","starred_url":"https://api.github.com/users/jiivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiivan/subscriptions","organizations_url":"https://api.github.com/users/jiivan/orgs","repos_url":"https://api.github.com/users/jiivan/repos","events_url":"https://api.github.com/users/jiivan/events{/privacy}","received_events_url":"https://api.github.com/users/jiivan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-16T11:08:49Z","updated_at":"2019-06-05T09:44:36Z","closed_at":"2019-06-05T09:44:36Z","author_association":"CONTRIBUTOR","body":"## Rationale\r\nTo achieve _Epic Show top-ups and withdraws in the transaction history_ #4172 .\r\n\r\nThis issue does not cover `Income` nor `DepositPayment`.\r\n\r\n## Description\r\n\r\n### Functional specification\r\n* Implement DB storage as specified in #4172\r\n* Migrate `Payments` to `WalletOperation` and `TaskPayment`. Remove `Payments` table. (use schema migrations)\r\n\r\n### User Interface\r\n\r\nAll rpc that depend on `Payments` should remain the same API (no changes of CLI nor Electron)\r\n\r\n### Technical specification\r\n* DB\r\n```\r\nWalletOperation:\r\n    hash: BlockchainTransactionField\r\n    direction: enum(Incoming, Outgoing)\r\n    type: enum(Transfer, DepositTransfer, TaskPayment, DepositPayment)\r\n    status: enum(Awaiting, Sent, Confirmed, Overdue)\r\n    sender_address: [eth address]\r\n    recipient_address: [eth address]\r\n    amount: HexIntegerField\r\n    currency: enum(GNT, ETH)\r\n    gas_cost: HexIntegerField\r\n\r\nTaskPayment:\r\n    wallet_operation: ->[WalletOperation 1to1]\r\n    node: str\r\n    task: str\r\n    subtask: str\r\n    paid_amount: HexIntegerField\r\n    expected_amount: HexIntegerField\r\n    accepted_ts: int\r\n    settled_ts: int\r\n```\r\n* Refactor payment RPCs\r\n\r\n## Dependencies\r\nNone\r\n\r\n### Sub-components\r\nNone\r\n\r\n### Blockers\r\nNone\r\n\r\n### Additional tests\r\n* Update `Payments` unit tests\r\n* No additional integration tests needed\r\n\r\n\r\n## QA\r\n_Description of the QA process for the feature_\r\n\r\n### Test scenarios:\r\n\r\n#### Base test process\r\n_specify one of: ( if unsure, consult @ZmijaWA or @ederenn )_\r\n** QA limited to the single feature (in case of very trivial changes)\r\n** Smoke Test (the limited set of tests designed to ensure that most critical functionality doesn't experience regressions)\r\n** Full Test (full set of tests for the whole application - in case of more extensive application updates, refactoring etc)\r\n\r\n### New feature tests\r\n_Add test scenarios for the new feature_\r\n\r\n#### Positive Scenario 1\r\n* Step 1\r\n* Step 2\r\n* ...\r\n* Expected results\r\n\r\n#### Positive Scenario 2\r\n* ...\r\n\r\n#### Negative Scenario 1\r\n* Step 1\r\n* Step 2\r\n* ...\r\n* Some expected problem\r\n* Expected problem handling\r\n\r\n### Possible regressions\r\n* is there any functionality that is likely to experience regressions?\r\n* are there any existing application components that should be tested more thoroughly?\r\n\r\n## Progress\r\n\r\n### Development\r\n* [ ] Feature implemented\r\n* [ ] Feature unit/integration tests implemented\r\n\r\n### Dev QA\r\n* [ ] Basic tests by the developer pass\r\n* [ ] Unit tests pass\r\n* [ ] Golem integration tests pass\r\n* [ ] Concent integration tests pass\r\n* [ ] Concent acceptance tests pass\r\n\r\n### QA team\r\n* [ ] Base scenario passes\r\n* [ ] Additional test 1 passes... \r\n* [ ] ... \r\n\r\n## Issues encountered during QA\r\n_When adding an issue here, please update testing scenarios and QA progress above_\r\n* [ ] link to issue... \r\n* [ ] ...\r\n"}}
other: {"actor":{"display_login":"jiivan"}}