payload: {"action":"created","comment":{"url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments/351885921","pull_request_review_id":324407932,"id":351885921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTg4NTkyMQ==","diff_hunk":"@@ -115,7 +115,13 @@\n   gPlatformCommonLibTokenSpaceGuid.PcdSpiIasImage2RegionSize   |0x00000000|UINT32|0x2000019C\n \n   ## This PCD controls enabled debug output devcie\n-  gPlatformCommonLibTokenSpaceGuid.PcdDebugOutputDeviceMask    |0x00000003|UINT32|0x20000400\n+  # Debug Interfaces. BIT0-RAM, BIT1-ISA UART, BIT2 -Not used, BIT3-USB3, BIT4-Serial IO, BIT5-TraceHub\n+  gPlatformCommonLibTokenSpaceGuid.PcdDebugInterfaceFlags      |0x00000011|UINT32|0x20000400\n+\n+  ## This PCD controls deug device number\n+  # Serial IO device: 0 - Serial UART0, 1 - Serial UART1, 2 - Serial UART2,\n+  # ISA UART:         0 - ISA UART device (base 0x2F8),   1 - ISA UART device (base 0x3F8)\n+  gPlatformCommonLibTokenSpaceGuid.PcdDebugDeviceNumber        |0x02|UINT8|0x20000410","path":"BootloaderCommonPkg/BootloaderCommonPkg.dec","position":11,"original_position":11,"commit_id":"58858c659cc72492593515943a085d84d170e5f7","original_commit_id":"58858c659cc72492593515943a085d84d170e5f7","user":{"login":"gdong1","id":22890893,"node_id":"MDQ6VXNlcjIyODkwODkz","avatar_url":"https://avatars2.githubusercontent.com/u/22890893?v=4","gravatar_id":"","url":"https://api.github.com/users/gdong1","html_url":"https://github.com/gdong1","followers_url":"https://api.github.com/users/gdong1/followers","following_url":"https://api.github.com/users/gdong1/following{/other_user}","gists_url":"https://api.github.com/users/gdong1/gists{/gist_id}","starred_url":"https://api.github.com/users/gdong1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdong1/subscriptions","organizations_url":"https://api.github.com/users/gdong1/orgs","repos_url":"https://api.github.com/users/gdong1/repos","events_url":"https://api.github.com/users/gdong1/events{/privacy}","received_events_url":"https://api.github.com/users/gdong1/received_events","type":"User","site_admin":false},"body":"Exactly. debug interface should combine with debug port number.","created_at":"2019-11-28T17:18:33Z","updated_at":"2019-11-28T17:18:33Z","html_url":"https://github.com/slimbootloader/slimbootloader/pull/476#discussion_r351885921","pull_request_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments/351885921"},"html":{"href":"https://github.com/slimbootloader/slimbootloader/pull/476#discussion_r351885921"},"pull_request":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476"}},"in_reply_to_id":351561073},"pull_request":{"url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476","id":346476026,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2NDc2MDI2","html_url":"https://github.com/slimbootloader/slimbootloader/pull/476","diff_url":"https://github.com/slimbootloader/slimbootloader/pull/476.diff","patch_url":"https://github.com/slimbootloader/slimbootloader/pull/476.patch","issue_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/476","number":476,"state":"open","locked":false,"title":"Update debug device support","user":{"login":"gdong1","id":22890893,"node_id":"MDQ6VXNlcjIyODkwODkz","avatar_url":"https://avatars2.githubusercontent.com/u/22890893?v=4","gravatar_id":"","url":"https://api.github.com/users/gdong1","html_url":"https://github.com/gdong1","followers_url":"https://api.github.com/users/gdong1/followers","following_url":"https://api.github.com/users/gdong1/following{/other_user}","gists_url":"https://api.github.com/users/gdong1/gists{/gist_id}","starred_url":"https://api.github.com/users/gdong1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdong1/subscriptions","organizations_url":"https://api.github.com/users/gdong1/orgs","repos_url":"https://api.github.com/users/gdong1/repos","events_url":"https://api.github.com/users/gdong1/events{/privacy}","received_events_url":"https://api.github.com/users/gdong1/received_events","type":"User","site_admin":false},"body":"PcdDebugOutputDeviceMask is defined in BootloaderCommonPkg\r\nThey are a little duplicated. so move PcdDebugInterfaceFlags to\r\nBootloaderCommonPkg and removed PcdDebugOutputDeviceMask.\r\n\r\nAdd a new PCD PcdDebugDeviceNumber to indicate the debug instance\r\nbased on debug interface media.\r\n\r\nFor the value for SetDebugPort/GetDebugPort, Bit7 set means ISA\r\nserial port, else means PCH serial port. Update other code for\r\nabove changes.\r\n\r\nSigned-off-by: Guo Dong <guo.dong@intel.com>","created_at":"2019-11-28T00:46:20Z","updated_at":"2019-11-28T17:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"908f1c391a3e17df1cb2a14daa53d935c008120f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476/commits","review_comments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476/comments","review_comment_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/476/comments","statuses_url":"https://api.github.com/repos/slimbootloader/slimbootloader/statuses/58858c659cc72492593515943a085d84d170e5f7","head":{"label":"gdong1:debug_device_update","ref":"debug_device_update","sha":"58858c659cc72492593515943a085d84d170e5f7","user":{"login":"gdong1","id":22890893,"node_id":"MDQ6VXNlcjIyODkwODkz","avatar_url":"https://avatars2.githubusercontent.com/u/22890893?v=4","gravatar_id":"","url":"https://api.github.com/users/gdong1","html_url":"https://github.com/gdong1","followers_url":"https://api.github.com/users/gdong1/followers","following_url":"https://api.github.com/users/gdong1/following{/other_user}","gists_url":"https://api.github.com/users/gdong1/gists{/gist_id}","starred_url":"https://api.github.com/users/gdong1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdong1/subscriptions","organizations_url":"https://api.github.com/users/gdong1/orgs","repos_url":"https://api.github.com/users/gdong1/repos","events_url":"https://api.github.com/users/gdong1/events{/privacy}","received_events_url":"https://api.github.com/users/gdong1/received_events","type":"User","site_admin":false},"repo":{"id":149490029,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0OTAwMjk=","name":"slimbootloader","full_name":"gdong1/slimbootloader","private":false,"owner":{"login":"gdong1","id":22890893,"node_id":"MDQ6VXNlcjIyODkwODkz","avatar_url":"https://avatars2.githubusercontent.com/u/22890893?v=4","gravatar_id":"","url":"https://api.github.com/users/gdong1","html_url":"https://github.com/gdong1","followers_url":"https://api.github.com/users/gdong1/followers","following_url":"https://api.github.com/users/gdong1/following{/other_user}","gists_url":"https://api.github.com/users/gdong1/gists{/gist_id}","starred_url":"https://api.github.com/users/gdong1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdong1/subscriptions","organizations_url":"https://api.github.com/users/gdong1/orgs","repos_url":"https://api.github.com/users/gdong1/repos","events_url":"https://api.github.com/users/gdong1/events{/privacy}","received_events_url":"https://api.github.com/users/gdong1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gdong1/slimbootloader","description":"Visit http://slimbootloader.github.io for documentation","fork":true,"url":"https://api.github.com/repos/gdong1/slimbootloader","forks_url":"https://api.github.com/repos/gdong1/slimbootloader/forks","keys_url":"https://api.github.com/repos/gdong1/slimbootloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdong1/slimbootloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdong1/slimbootloader/teams","hooks_url":"https://api.github.com/repos/gdong1/slimbootloader/hooks","issue_events_url":"https://api.github.com/repos/gdong1/slimbootloader/issues/events{/number}","events_url":"https://api.github.com/repos/gdong1/slimbootloader/events","assignees_url":"https://api.github.com/repos/gdong1/slimbootloader/assignees{/user}","branches_url":"https://api.github.com/repos/gdong1/slimbootloader/branches{/branch}","tags_url":"https://api.github.com/repos/gdong1/slimbootloader/tags","blobs_url":"https://api.github.com/repos/gdong1/slimbootloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdong1/slimbootloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdong1/slimbootloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdong1/slimbootloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdong1/slimbootloader/statuses/{sha}","languages_url":"https://api.github.com/repos/gdong1/slimbootloader/languages","stargazers_url":"https://api.github.com/repos/gdong1/slimbootloader/stargazers","contributors_url":"https://api.github.com/repos/gdong1/slimbootloader/contributors","subscribers_url":"https://api.github.com/repos/gdong1/slimbootloader/subscribers","subscription_url":"https://api.github.com/repos/gdong1/slimbootloader/subscription","commits_url":"https://api.github.com/repos/gdong1/slimbootloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdong1/slimbootloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdong1/slimbootloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdong1/slimbootloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdong1/slimbootloader/contents/{+path}","compare_url":"https://api.github.com/repos/gdong1/slimbootloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdong1/slimbootloader/merges","archive_url":"https://api.github.com/repos/gdong1/slimbootloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdong1/slimbootloader/downloads","issues_url":"https://api.github.com/repos/gdong1/slimbootloader/issues{/number}","pulls_url":"https://api.github.com/repos/gdong1/slimbootloader/pulls{/number}","milestones_url":"https://api.github.com/repos/gdong1/slimbootloader/milestones{/number}","notifications_url":"https://api.github.com/repos/gdong1/slimbootloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdong1/slimbootloader/labels{/name}","releases_url":"https://api.github.com/repos/gdong1/slimbootloader/releases{/id}","deployments_url":"https://api.github.com/repos/gdong1/slimbootloader/deployments","created_at":"2018-09-19T17:48:00Z","updated_at":"2018-09-19T17:48:09Z","pushed_at":"2019-11-28T00:48:09Z","git_url":"git://github.com/gdong1/slimbootloader.git","ssh_url":"git@github.com:gdong1/slimbootloader.git","clone_url":"https://github.com/gdong1/slimbootloader.git","svn_url":"https://github.com/gdong1/slimbootloader","homepage":"","size":8147,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slimbootloader:master","ref":"master","sha":"40ad2f9fb6f03833a0e633064421fd5ce451bba4","user":{"login":"slimbootloader","id":42816226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODE2MjI2","avatar_url":"https://avatars0.githubusercontent.com/u/42816226?v=4","gravatar_id":"","url":"https://api.github.com/users/slimbootloader","html_url":"https://github.com/slimbootloader","followers_url":"https://api.github.com/users/slimbootloader/followers","following_url":"https://api.github.com/users/slimbootloader/following{/other_user}","gists_url":"https://api.github.com/users/slimbootloader/gists{/gist_id}","starred_url":"https://api.github.com/users/slimbootloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimbootloader/subscriptions","organizations_url":"https://api.github.com/users/slimbootloader/orgs","repos_url":"https://api.github.com/users/slimbootloader/repos","events_url":"https://api.github.com/users/slimbootloader/events{/privacy}","received_events_url":"https://api.github.com/users/slimbootloader/received_events","type":"Organization","site_admin":false},"repo":{"id":148708107,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3MDgxMDc=","name":"slimbootloader","full_name":"slimbootloader/slimbootloader","private":false,"owner":{"login":"slimbootloader","id":42816226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODE2MjI2","avatar_url":"https://avatars0.githubusercontent.com/u/42816226?v=4","gravatar_id":"","url":"https://api.github.com/users/slimbootloader","html_url":"https://github.com/slimbootloader","followers_url":"https://api.github.com/users/slimbootloader/followers","following_url":"https://api.github.com/users/slimbootloader/following{/other_user}","gists_url":"https://api.github.com/users/slimbootloader/gists{/gist_id}","starred_url":"https://api.github.com/users/slimbootloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimbootloader/subscriptions","organizations_url":"https://api.github.com/users/slimbootloader/orgs","repos_url":"https://api.github.com/users/slimbootloader/repos","events_url":"https://api.github.com/users/slimbootloader/events{/privacy}","received_events_url":"https://api.github.com/users/slimbootloader/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/slimbootloader/slimbootloader","description":"Visit http://slimbootloader.github.io for documentation","fork":false,"url":"https://api.github.com/repos/slimbootloader/slimbootloader","forks_url":"https://api.github.com/repos/slimbootloader/slimbootloader/forks","keys_url":"https://api.github.com/repos/slimbootloader/slimbootloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimbootloader/slimbootloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimbootloader/slimbootloader/teams","hooks_url":"https://api.github.com/repos/slimbootloader/slimbootloader/hooks","issue_events_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/events{/number}","events_url":"https://api.github.com/repos/slimbootloader/slimbootloader/events","assignees_url":"https://api.github.com/repos/slimbootloader/slimbootloader/assignees{/user}","branches_url":"https://api.github.com/repos/slimbootloader/slimbootloader/branches{/branch}","tags_url":"https://api.github.com/repos/slimbootloader/slimbootloader/tags","blobs_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimbootloader/slimbootloader/statuses/{sha}","languages_url":"https://api.github.com/repos/slimbootloader/slimbootloader/languages","stargazers_url":"https://api.github.com/repos/slimbootloader/slimbootloader/stargazers","contributors_url":"https://api.github.com/repos/slimbootloader/slimbootloader/contributors","subscribers_url":"https://api.github.com/repos/slimbootloader/slimbootloader/subscribers","subscription_url":"https://api.github.com/repos/slimbootloader/slimbootloader/subscription","commits_url":"https://api.github.com/repos/slimbootloader/slimbootloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimbootloader/slimbootloader/contents/{+path}","compare_url":"https://api.github.com/repos/slimbootloader/slimbootloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimbootloader/slimbootloader/merges","archive_url":"https://api.github.com/repos/slimbootloader/slimbootloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimbootloader/slimbootloader/downloads","issues_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues{/number}","pulls_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls{/number}","milestones_url":"https://api.github.com/repos/slimbootloader/slimbootloader/milestones{/number}","notifications_url":"https://api.github.com/repos/slimbootloader/slimbootloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimbootloader/slimbootloader/labels{/name}","releases_url":"https://api.github.com/repos/slimbootloader/slimbootloader/releases{/id}","deployments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/deployments","created_at":"2018-09-13T23:07:33Z","updated_at":"2019-11-26T20:58:33Z","pushed_at":"2019-11-28T00:48:10Z","git_url":"git://github.com/slimbootloader/slimbootloader.git","ssh_url":"git@github.com:slimbootloader/slimbootloader.git","clone_url":"https://github.com/slimbootloader/slimbootloader.git","svn_url":"https://github.com/slimbootloader/slimbootloader","homepage":"","size":8197,"stargazers_count":146,"watchers_count":146,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":52,"open_issues":6,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476"},"html":{"href":"https://github.com/slimbootloader/slimbootloader/pull/476"},"issue":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/476"},"comments":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/statuses/58858c659cc72492593515943a085d84d170e5f7"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"gdong1"}}