payload: {"action":"created","issue":{"url":"https://api.github.com/repos/TryGhost/Ghost-CLI/issues/495","repository_url":"https://api.github.com/repos/TryGhost/Ghost-CLI","labels_url":"https://api.github.com/repos/TryGhost/Ghost-CLI/issues/495/labels{/name}","comments_url":"https://api.github.com/repos/TryGhost/Ghost-CLI/issues/495/comments","events_url":"https://api.github.com/repos/TryGhost/Ghost-CLI/issues/495/events","html_url":"https://github.com/TryGhost/Ghost-CLI/issues/495","id":264322468,"node_id":"MDU6SXNzdWUyNjQzMjI0Njg=","number":495,"title":"Acme.sh certificate renewal is not complete","user":{"login":"ErisDS","id":101513,"node_id":"MDQ6VXNlcjEwMTUxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"labels":[{"id":422686507,"node_id":"MDU6TGFiZWw0MjI2ODY1MDc=","url":"https://api.github.com/repos/TryGhost/Ghost-CLI/labels/bug","name":"bug","color":"ee0701","default":true},{"id":635202217,"node_id":"MDU6TGFiZWw2MzUyMDIyMTc=","url":"https://api.github.com/repos/TryGhost/Ghost-CLI/labels/rogue","name":"rogue","color":"334444","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-10-10T18:02:27Z","updated_at":"2019-05-08T11:13:26Z","closed_at":"2017-11-23T18:37:13Z","author_association":"MEMBER","body":"I'm having problems with sites going offline with certificate errors. Acme.sh is correctly renewing the certificates, but nginx must be restarted afterwards, and I don't think that has been configured.\r\n\r\nI'm not sure why we haven't had a tonne more reports of this!\r\n\r\nRefs: \r\n\r\n- https://github.com/Neilpang/acme.sh#3-install-the-issued-cert-to-apachenginx-etc\r\n- https://www.rmedgar.com/blog/using-acme-sh-with-nginx\r\n\r\n**Update from @ErisDS 23rd Oct:**\r\n\r\nWe're starting to see more people affected by this. To aid search-ability this manifests itself as `NET::ERR_CERT_DATE_INVALID` errors on your site.\r\n\r\nThe certificate _has_ renewed, but nginx needs to be restarted to pick up the new certs:\r\n\r\nThe solution is to run `sudo systemctl restart nginx` on your box.\r\n\r\n--- \r\n\r\n## Task list \r\n\r\n(Taken from my comment below)\r\n\r\n- [x] 1. Build out the new version\r\n- [ ] 2. Write the documentation for how to manually migrate your site to the new version\r\n     - My expectation is the simple version would be \"run `ghost setup:ssl`, then delete X files\" or similar, and then there'd be an extended version explaining the exact steps for anyone with a customised system.\r\n- [x] 3. Release the new version as a minor?\r\n\r\nAt this point, all new sites are safe, all old ones _can_ migrate.\r\n\r\n- [ ] 4. Write a check that can determine if a blog is using the old ssl setup, make it as robust and simple as possible. E.g. use `fs.exists`.\r\n- [ ] 5. Add a message to as many places as possible shouting about the need to update, linking to the docs.\r\n- [ ] 6. Release as a patch update\r\n\r\nAt this point, all old blogs will learn about the need to migrate. They will be able but it's not easy.\r\n\r\n- [ ] 7. Add a new command: `ghost migrate:ssl` or something equally relatively sensible and future-proof.\r\n- [ ] 8. Make that command do the necessary migration steps \r\n      - e.g. it runs `ghost setup:ssl` and then deletes the old files, or maybe does a more advanced set of steps to be more compatible?\r\n- [ ] 9. Update the docs with the shiny new command\r\n- [ ] 10. _Maybe_ update the messages every where with the new command?\r\n\r\nAt this point, all old blogs have an easy way to migrate.\r\n\r\n- [ ] 11. Deal with any fall out, e.g. bugs in the check, or improvements to the migrate command to ensure these are robust.\r\n- [ ] 12. Implement a system to auto-migrate \r\n"},"comment":{"url":"https://api.github.com/repos/TryGhost/Ghost-CLI/issues/comments/490446272","html_url":"https://github.com/TryGhost/Ghost-CLI/issues/495#issuecomment-490446272","issue_url":"https://api.github.com/repos/TryGhost/Ghost-CLI/issues/495","id":490446272,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MDQ0NjI3Mg==","user":{"login":"maximusk","id":6124091,"node_id":"MDQ6VXNlcjYxMjQwOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6124091?v=4","gravatar_id":"","url":"https://api.github.com/users/maximusk","html_url":"https://github.com/maximusk","followers_url":"https://api.github.com/users/maximusk/followers","following_url":"https://api.github.com/users/maximusk/following{/other_user}","gists_url":"https://api.github.com/users/maximusk/gists{/gist_id}","starred_url":"https://api.github.com/users/maximusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximusk/subscriptions","organizations_url":"https://api.github.com/users/maximusk/orgs","repos_url":"https://api.github.com/users/maximusk/repos","events_url":"https://api.github.com/users/maximusk/events{/privacy}","received_events_url":"https://api.github.com/users/maximusk/received_events","type":"User","site_admin":false},"created_at":"2019-05-08T11:13:26Z","updated_at":"2019-05-08T11:13:26Z","author_association":"NONE","body":"Is there a `systemd` service that checks for the certificate validity and updates it?"}}
other: {"actor":{"display_login":"maximusk"}}