payload: {"action":"created","comment":{"url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/comments/282894249","pull_request_review_id":236117989,"id":282894249,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Mjg5NDI0OQ==","diff_hunk":"@@ -9,9 +9,14 @@ CALL %~dp0init.cmd\n \n PUSHD %~dp0..\n \n-REM TODO: these should be read from the version props file, or similar\n-SET Version=8.6.1\n-SET Tag=-INTERNALONLY\n+REM TODO: these should be read from the version props file, or similar, with the ability to overload via env\n+IF NOT DEFINED Version (\n+    SET Version=8.6.1\n+)\n+\n+IF NOT DEFINED Tag (\n+    SET Tag=-INTERNALONLY","path":".scripts/package.cmd","position":13,"original_position":13,"commit_id":"e710dd90e6cbf7edd8cd5b6e55027ed0fe5cb9d2","original_commit_id":"e710dd90e6cbf7edd8cd5b6e55027ed0fe5cb9d2","user":{"login":"jackgerrits","id":7558482,"node_id":"MDQ6VXNlcjc1NTg0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/7558482?v=4","gravatar_id":"","url":"https://api.github.com/users/jackgerrits","html_url":"https://github.com/jackgerrits","followers_url":"https://api.github.com/users/jackgerrits/followers","following_url":"https://api.github.com/users/jackgerrits/following{/other_user}","gists_url":"https://api.github.com/users/jackgerrits/gists{/gist_id}","starred_url":"https://api.github.com/users/jackgerrits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackgerrits/subscriptions","organizations_url":"https://api.github.com/users/jackgerrits/orgs","repos_url":"https://api.github.com/users/jackgerrits/repos","events_url":"https://api.github.com/users/jackgerrits/events{/privacy}","received_events_url":"https://api.github.com/users/jackgerrits/received_events","type":"User","site_admin":false},"body":"Ah got it, thanks","created_at":"2019-05-10T13:55:38Z","updated_at":"2019-05-10T13:55:38Z","html_url":"https://github.com/VowpalWabbit/vowpal_wabbit/pull/1870#discussion_r282894249","pull_request_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/comments/282894249"},"html":{"href":"https://github.com/VowpalWabbit/vowpal_wabbit/pull/1870#discussion_r282894249"},"pull_request":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870"}},"in_reply_to_id":282893010},"pull_request":{"url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870","id":277584152,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3NTg0MTUy","html_url":"https://github.com/VowpalWabbit/vowpal_wabbit/pull/1870","diff_url":"https://github.com/VowpalWabbit/vowpal_wabbit/pull/1870.diff","patch_url":"https://github.com/VowpalWabbit/vowpal_wabbit/pull/1870.patch","issue_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/1870","number":1870,"state":"open","locked":false,"title":"Enable Version and Tag override for NuGet pack","user":{"login":"lokitoth","id":6936551,"node_id":"MDQ6VXNlcjY5MzY1NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6936551?v=4","gravatar_id":"","url":"https://api.github.com/users/lokitoth","html_url":"https://github.com/lokitoth","followers_url":"https://api.github.com/users/lokitoth/followers","following_url":"https://api.github.com/users/lokitoth/following{/other_user}","gists_url":"https://api.github.com/users/lokitoth/gists{/gist_id}","starred_url":"https://api.github.com/users/lokitoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lokitoth/subscriptions","organizations_url":"https://api.github.com/users/lokitoth/orgs","repos_url":"https://api.github.com/users/lokitoth/repos","events_url":"https://api.github.com/users/lokitoth/events{/privacy}","received_events_url":"https://api.github.com/users/lokitoth/received_events","type":"User","site_admin":false},"body":"This provides a mechanism to insert version/tag during the CI/CD pipeline (thereby inserting a version generated by the pipeline).\r\n\r\nLonger-term this will be handed by a \"version generation\" step, which will read the target version from a file, and create the appropriate artifacts (config.h, build.props, etc.) to be used by the appropriate build systems to inject the version. In the short term, this unblocks work on release pipeline for Windows artifacts.","created_at":"2019-05-09T23:28:43Z","updated_at":"2019-05-10T13:55:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0336081735180464299ac7633325ba5eae07cd5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870/commits","review_comments_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870/comments","review_comment_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/1870/comments","statuses_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/statuses/e710dd90e6cbf7edd8cd5b6e55027ed0fe5cb9d2","head":{"label":"VowpalWabbit:dev/Enable-NugetVersionTagOverride","ref":"dev/Enable-NugetVersionTagOverride","sha":"e710dd90e6cbf7edd8cd5b6e55027ed0fe5cb9d2","user":{"login":"VowpalWabbit","id":43754238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzU0MjM4","avatar_url":"https://avatars0.githubusercontent.com/u/43754238?v=4","gravatar_id":"","url":"https://api.github.com/users/VowpalWabbit","html_url":"https://github.com/VowpalWabbit","followers_url":"https://api.github.com/users/VowpalWabbit/followers","following_url":"https://api.github.com/users/VowpalWabbit/following{/other_user}","gists_url":"https://api.github.com/users/VowpalWabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/VowpalWabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VowpalWabbit/subscriptions","organizations_url":"https://api.github.com/users/VowpalWabbit/orgs","repos_url":"https://api.github.com/users/VowpalWabbit/repos","events_url":"https://api.github.com/users/VowpalWabbit/events{/privacy}","received_events_url":"https://api.github.com/users/VowpalWabbit/received_events","type":"Organization","site_admin":false},"repo":{"id":265995,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU5OTU=","name":"vowpal_wabbit","full_name":"VowpalWabbit/vowpal_wabbit","private":false,"owner":{"login":"VowpalWabbit","id":43754238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzU0MjM4","avatar_url":"https://avatars0.githubusercontent.com/u/43754238?v=4","gravatar_id":"","url":"https://api.github.com/users/VowpalWabbit","html_url":"https://github.com/VowpalWabbit","followers_url":"https://api.github.com/users/VowpalWabbit/followers","following_url":"https://api.github.com/users/VowpalWabbit/following{/other_user}","gists_url":"https://api.github.com/users/VowpalWabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/VowpalWabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VowpalWabbit/subscriptions","organizations_url":"https://api.github.com/users/VowpalWabbit/orgs","repos_url":"https://api.github.com/users/VowpalWabbit/repos","events_url":"https://api.github.com/users/VowpalWabbit/events{/privacy}","received_events_url":"https://api.github.com/users/VowpalWabbit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VowpalWabbit/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":false,"url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit","forks_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/deployments","created_at":"2009-07-31T19:36:58Z","updated_at":"2019-05-10T10:43:22Z","pushed_at":"2019-05-09T23:28:43Z","git_url":"git://github.com/VowpalWabbit/vowpal_wabbit.git","ssh_url":"git@github.com:VowpalWabbit/vowpal_wabbit.git","clone_url":"https://github.com/VowpalWabbit/vowpal_wabbit.git","svn_url":"https://github.com/VowpalWabbit/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":125071,"stargazers_count":6310,"watchers_count":6310,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1535,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1535,"open_issues":75,"watchers":6310,"default_branch":"master"}},"base":{"label":"VowpalWabbit:master","ref":"master","sha":"98d4bd87fadecf8cf2d21310e6b705240f675c2d","user":{"login":"VowpalWabbit","id":43754238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzU0MjM4","avatar_url":"https://avatars0.githubusercontent.com/u/43754238?v=4","gravatar_id":"","url":"https://api.github.com/users/VowpalWabbit","html_url":"https://github.com/VowpalWabbit","followers_url":"https://api.github.com/users/VowpalWabbit/followers","following_url":"https://api.github.com/users/VowpalWabbit/following{/other_user}","gists_url":"https://api.github.com/users/VowpalWabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/VowpalWabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VowpalWabbit/subscriptions","organizations_url":"https://api.github.com/users/VowpalWabbit/orgs","repos_url":"https://api.github.com/users/VowpalWabbit/repos","events_url":"https://api.github.com/users/VowpalWabbit/events{/privacy}","received_events_url":"https://api.github.com/users/VowpalWabbit/received_events","type":"Organization","site_admin":false},"repo":{"id":265995,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU5OTU=","name":"vowpal_wabbit","full_name":"VowpalWabbit/vowpal_wabbit","private":false,"owner":{"login":"VowpalWabbit","id":43754238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzU0MjM4","avatar_url":"https://avatars0.githubusercontent.com/u/43754238?v=4","gravatar_id":"","url":"https://api.github.com/users/VowpalWabbit","html_url":"https://github.com/VowpalWabbit","followers_url":"https://api.github.com/users/VowpalWabbit/followers","following_url":"https://api.github.com/users/VowpalWabbit/following{/other_user}","gists_url":"https://api.github.com/users/VowpalWabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/VowpalWabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VowpalWabbit/subscriptions","organizations_url":"https://api.github.com/users/VowpalWabbit/orgs","repos_url":"https://api.github.com/users/VowpalWabbit/repos","events_url":"https://api.github.com/users/VowpalWabbit/events{/privacy}","received_events_url":"https://api.github.com/users/VowpalWabbit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VowpalWabbit/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":false,"url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit","forks_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/deployments","created_at":"2009-07-31T19:36:58Z","updated_at":"2019-05-10T10:43:22Z","pushed_at":"2019-05-09T23:28:43Z","git_url":"git://github.com/VowpalWabbit/vowpal_wabbit.git","ssh_url":"git@github.com:VowpalWabbit/vowpal_wabbit.git","clone_url":"https://github.com/VowpalWabbit/vowpal_wabbit.git","svn_url":"https://github.com/VowpalWabbit/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":125071,"stargazers_count":6310,"watchers_count":6310,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1535,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1535,"open_issues":75,"watchers":6310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870"},"html":{"href":"https://github.com/VowpalWabbit/vowpal_wabbit/pull/1870"},"issue":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/1870"},"comments":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/issues/1870/comments"},"review_comments":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870/comments"},"review_comment":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/pulls/1870/commits"},"statuses":{"href":"https://api.github.com/repos/VowpalWabbit/vowpal_wabbit/statuses/e710dd90e6cbf7edd8cd5b6e55027ed0fe5cb9d2"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"jackgerrits"}}