payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/knative/serving/issues/4204","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/4204/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/4204/comments","events_url":"https://api.github.com/repos/knative/serving/issues/4204/events","html_url":"https://github.com/knative/serving/issues/4204","id":450760740,"node_id":"MDU6SXNzdWU0NTA3NjA3NDA=","number":4204,"title":"cluster-only service's URL might not be right","user":{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"labels":[{"id":868660931,"node_id":"MDU6TGFiZWw4Njg2NjA5MzE=","url":"https://api.github.com/repos/knative/serving/labels/area/networking","name":"area/networking","color":"e59cc2","default":false},{"id":815594744,"node_id":"MDU6TGFiZWw4MTU1OTQ3NDQ=","url":"https://api.github.com/repos/knative/serving/labels/kind/bug","name":"kind/bug","color":"d73a4a","default":false}],"state":"closed","locked":false,"assignee":{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"assignees":[{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/knative/serving/milestones/24","html_url":"https://github.com/knative/serving/milestone/24","labels_url":"https://api.github.com/repos/knative/serving/milestones/24/labels","id":4390619,"node_id":"MDk6TWlsZXN0b25lNDM5MDYxOQ==","number":24,"title":"Serving 0.8","description":"The ambition of 0.8 is to be a release candidate for a \"v1\" of serving.","creator":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":14,"state":"open","created_at":"2019-06-08T21:55:42Z","updated_at":"2019-07-04T06:31:33Z","due_on":"2019-08-06T07:00:00Z","closed_at":null},"comments":10,"created_at":"2019-05-31T11:51:23Z","updated_at":"2019-07-04T06:31:33Z","closed_at":"2019-07-04T06:31:33Z","author_association":"CONTRIBUTOR","body":"## In what area(s)?\r\n/area networking\r\n\r\n## What version of Knative?\r\n0.6.0\r\n\r\n## Issue\r\n\r\nI created an internal only service via:\r\n```\r\napiVersion: serving.knative.dev/v1alpha1\r\nkind: Service\r\nmetadata:\r\n  name: echo-internal\r\n  labels:\r\n    serving.knative.dev/visibility: cluster-local\r\nspec:\r\n  runLatest:\r\n    configuration:\r\n      revisionTemplate:\r\n        spec:\r\n          container:\r\n            image: duglin/echo\r\n```\r\n\r\nI also modified by domainTemplate to use `-` instead of `.` between the service name and the domain name.\r\n\r\nWhen I look at the `status` section of this service I see this (removed the noise):\r\n```\r\nstatus:\r\n  address:\r\n    hostname: echo-internal.default.svc.cluster.local\r\n    url: http://echo-internal.default.svc.cluster.local\r\n  domain: echo-internal-default.svc.cluster.local\r\n  domainInternal: echo-internal.default.svc.cluster.local\r\n  url: http://echo-internal-default.svc.cluster.local\r\n```\r\n\r\nFirst, some questions:\r\n- why are there so many fields that appear to be duplicates?  E.g. do we need `address.hostname` and `domainInternal` ?\r\n- `url` appears to be new for v0.6 - why is it needed? It seems a bit odd to assume that `http` is the preferred protocol. Why not just have the hostname and let the user decide if they want to use http or https?\r\n- can we be more consistent on the use of \"domain\" vs \"hostname\" ? Personally, I prefer \"hostname\" but either way we should be consistent - not just here but then in other places like our configMaps (e.g. domainTemplate).\r\n\r\nThe issue:\r\n- notice `domain: echo-internal-default.svc.cluster.local` and `url: http://echo-internal-default.svc.cluster.local` both use `-` in the url so I'm assuming these are meant to be externally facing URLs, however this is an internal only service.\r\n- should these fields be empty?\r\n\r\n/cc @ZhiminXiang @tcnghia "}}
other: {"actor":{"display_login":"knative-prow-robot"}}