payload: {"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5523","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5523/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5523/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5523/events","html_url":"https://github.com/MetaMask/metamask-extension/issues/5523","id":370116658,"node_id":"MDU6SXNzdWUzNzAxMTY2NTg=","number":5523,"title":"Ledger / Trezor signing unicode messages does not callback","user":{"login":"mjdietzx","id":7217256,"node_id":"MDQ6VXNlcjcyMTcyNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7217256?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdietzx","html_url":"https://github.com/mjdietzx","followers_url":"https://api.github.com/users/mjdietzx/followers","following_url":"https://api.github.com/users/mjdietzx/following{/other_user}","gists_url":"https://api.github.com/users/mjdietzx/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdietzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdietzx/subscriptions","organizations_url":"https://api.github.com/users/mjdietzx/orgs","repos_url":"https://api.github.com/users/mjdietzx/repos","events_url":"https://api.github.com/users/mjdietzx/events{/privacy}","received_events_url":"https://api.github.com/users/mjdietzx/received_events","type":"User","site_admin":false},"labels":[{"id":1086458588,"node_id":"MDU6TGFiZWwxMDg2NDU4NTg4","url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/L17-hardware","name":"L17-hardware","color":"70e5f4","default":false},{"id":695894223,"node_id":"MDU6TGFiZWw2OTU4OTQyMjM=","url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/N02-needsReproduction","name":"N02-needsReproduction","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":{"login":"brunobar79","id":1247834,"node_id":"MDQ6VXNlcjEyNDc4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1247834?v=4","gravatar_id":"","url":"https://api.github.com/users/brunobar79","html_url":"https://github.com/brunobar79","followers_url":"https://api.github.com/users/brunobar79/followers","following_url":"https://api.github.com/users/brunobar79/following{/other_user}","gists_url":"https://api.github.com/users/brunobar79/gists{/gist_id}","starred_url":"https://api.github.com/users/brunobar79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunobar79/subscriptions","organizations_url":"https://api.github.com/users/brunobar79/orgs","repos_url":"https://api.github.com/users/brunobar79/repos","events_url":"https://api.github.com/users/brunobar79/events{/privacy}","received_events_url":"https://api.github.com/users/brunobar79/received_events","type":"User","site_admin":false},"assignees":[{"login":"brunobar79","id":1247834,"node_id":"MDQ6VXNlcjEyNDc4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1247834?v=4","gravatar_id":"","url":"https://api.github.com/users/brunobar79","html_url":"https://github.com/brunobar79","followers_url":"https://api.github.com/users/brunobar79/followers","following_url":"https://api.github.com/users/brunobar79/following{/other_user}","gists_url":"https://api.github.com/users/brunobar79/gists{/gist_id}","starred_url":"https://api.github.com/users/brunobar79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunobar79/subscriptions","organizations_url":"https://api.github.com/users/brunobar79/orgs","repos_url":"https://api.github.com/users/brunobar79/repos","events_url":"https://api.github.com/users/brunobar79/events{/privacy}","received_events_url":"https://api.github.com/users/brunobar79/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-10-15T11:22:17Z","updated_at":"2019-08-13T13:54:04Z","closed_at":"2019-04-02T16:54:39Z","author_association":"NONE","body":"When signing a message with hardware wallets (tested on both Ledger Nano S and Trezor, with both showing the same behavior):\r\n\r\n(web3 injected into browser by MetaMask 0.2.x?)\r\n```javascript\r\nconst message = web3.fromUtf8('Hello world!');\r\nweb3.personal.sign(message, address, (e, r) => { console.log(e, r) });\r\n```\r\n\r\n(web3 1.0.0)\r\n```javascript\r\nconst signature = await this.web3js.eth.personal.sign('Hello world!', address);\r\n```\r\n\r\nBoth have inconsistent and failing behavior. Sometimes MetaMask actually pops up with the prompt to sign the message. In this case, the signing prompt appears on the HW wallet. From here it is again inconsistent, sometimes the callback of `sign` is actually triggered and we get the signature. Other times I can tell MetaMask receives the signature (it stops loading), but the callback is never triggered.\r\n\r\nAnd sometimes MetaMask never even shows the pop-up to sign the message. And there is no error message or anything. I've been very confused with this bug. Any ideas? There also seems to be some state going on (ie I have to switch between accounts in metamask.) But very hard to figure out a pattern here.\r\n\r\nAny tricks / known issues with Hardware wallets? I know crypto kitties seems to work well with signing a message via MetaMask for their login. So I know its doable but defiently some strange behavior going on."},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/520844276","html_url":"https://github.com/MetaMask/metamask-extension/issues/5523#issuecomment-520844276","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5523","id":520844276,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMDg0NDI3Ng==","user":{"login":"justinkchen","id":1000741,"node_id":"MDQ6VXNlcjEwMDA3NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1000741?v=4","gravatar_id":"","url":"https://api.github.com/users/justinkchen","html_url":"https://github.com/justinkchen","followers_url":"https://api.github.com/users/justinkchen/followers","following_url":"https://api.github.com/users/justinkchen/following{/other_user}","gists_url":"https://api.github.com/users/justinkchen/gists{/gist_id}","starred_url":"https://api.github.com/users/justinkchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinkchen/subscriptions","organizations_url":"https://api.github.com/users/justinkchen/orgs","repos_url":"https://api.github.com/users/justinkchen/repos","events_url":"https://api.github.com/users/justinkchen/events{/privacy}","received_events_url":"https://api.github.com/users/justinkchen/received_events","type":"User","site_admin":false},"created_at":"2019-08-13T13:54:04Z","updated_at":"2019-08-13T13:54:04Z","author_association":"NONE","body":"I'm still getting issues with this I think. any other comments or updates about how to fix it?"}}
other: {"actor":{"display_login":"justinkchen"}}