payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2670","repository_url":"https://api.github.com/repos/pmmp/PocketMine-MP","labels_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2670/labels{/name}","comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2670/comments","events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2670/events","html_url":"https://github.com/pmmp/PocketMine-MP/issues/2670","id":400477078,"node_id":"MDU6SXNzdWU0MDA0NzcwNzg=","number":2670,"title":"MOTD player count is very slow to update","user":{"login":"dktapps","id":14214667,"node_id":"MDQ6VXNlcjE0MjE0NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/14214667?v=4","gravatar_id":"","url":"https://api.github.com/users/dktapps","html_url":"https://github.com/dktapps","followers_url":"https://api.github.com/users/dktapps/followers","following_url":"https://api.github.com/users/dktapps/following{/other_user}","gists_url":"https://api.github.com/users/dktapps/gists{/gist_id}","starred_url":"https://api.github.com/users/dktapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktapps/subscriptions","organizations_url":"https://api.github.com/users/dktapps/orgs","repos_url":"https://api.github.com/users/dktapps/repos","events_url":"https://api.github.com/users/dktapps/events{/privacy}","received_events_url":"https://api.github.com/users/dktapps/received_events","type":"User","site_admin":false},"labels":[{"id":454785701,"node_id":"MDU6TGFiZWw0NTQ3ODU3MDE=","url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Category:%20Core","name":"Category: Core","color":"00aa55","default":false},{"id":569460451,"node_id":"MDU6TGFiZWw1Njk0NjA0NTE=","url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Category:%20Network","name":"Category: Network","color":"00aa55","default":false},{"id":454787133,"node_id":"MDU6TGFiZWw0NTQ3ODcxMzM=","url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Status:%20Debugged","name":"Status: Debugged","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-17T21:47:00Z","updated_at":"2019-06-16T15:17:15Z","closed_at":"2019-06-16T15:17:15Z","author_association":"MEMBER","body":"### Issue description\r\nMOTD online player count depends on `QueryRegenerateEvent`. While this is problematic in itself, the bigger problem is that the query information is only regenerated approximately once every 25 seconds. This appears to be premature optimization.\r\n\r\nThis lag causes the player count shown to clients to be almost always outdated. This does not directly become a problem until the MOTD displays the server as \"full\", at which point the client will refuse to join the server. Because of the lag updating the query information, the real player count might be less, meaning the player can't join a non-full server.\r\n\r\n### Steps to reproduce the issue\r\n1. Have a server with all slots filled.\r\n2. Have 1 player quit, at the same time as another player is observing the server list.\r\n3. Notice the prospective player cannot join the server until ~30 seconds later.\r\n\r\n### OS and versions\r\n<!-- try the `version` command | LATEST IS NOT A VALID VERSION -->\r\n* PocketMine-MP: 3.5.5, 38cf8d157dd1fb46f8b29f0898c4bdd7731b57b5\r\n* PHP: 7.2.13\r\n* Server OS: windows\r\n* Game version: PE/Win10"}}
other: {"actor":{"display_login":"dktapps"}}