payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/comments/302119601","pull_request_review_id":260163625,"id":302119601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjExOTYwMQ==","diff_hunk":"@@ -346,6 +366,9 @@\n   ([this-or-app relative-class-or-instance new-route]\n    (change-route-relative this-or-app relative-class-or-instance new-route {}))\n   ([app-or-comp relative-class-or-instance new-route timeouts]\n+ ;; TODO: Add next lines\n+ ;;   (when-not (seq (proposed-new-path this-or-reconciler relative-class-or-instance new-route))","path":"src/main/com/fulcrologic/fulcro/routing/dynamic_routing.cljc","position":null,"original_position":48,"commit_id":"5549a75b6b879f2a967bae36c8841674a6099b57","original_commit_id":"20dea3ae8777c821fb2e4565b3dda07b8e336ec0","user":{"login":"awkay","id":1177083,"node_id":"MDQ6VXNlcjExNzcwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1177083?v=4","gravatar_id":"","url":"https://api.github.com/users/awkay","html_url":"https://github.com/awkay","followers_url":"https://api.github.com/users/awkay/followers","following_url":"https://api.github.com/users/awkay/following{/other_user}","gists_url":"https://api.github.com/users/awkay/gists{/gist_id}","starred_url":"https://api.github.com/users/awkay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awkay/subscriptions","organizations_url":"https://api.github.com/users/awkay/orgs","repos_url":"https://api.github.com/users/awkay/repos","events_url":"https://api.github.com/users/awkay/events{/privacy}","received_events_url":"https://api.github.com/users/awkay/received_events","type":"User","site_admin":false},"body":"If you look at the other arity of the function I chose the name app-or-comp, so keep consistent","created_at":"2019-07-10T15:10:31Z","updated_at":"2019-07-10T15:10:31Z","html_url":"https://github.com/fulcrologic/fulcro3/pull/31#discussion_r302119601","pull_request_url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/comments/302119601"},"html":{"href":"https://github.com/fulcrologic/fulcro3/pull/31#discussion_r302119601"},"pull_request":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31"}},"in_reply_to_id":302058653},"pull_request":{"url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31","id":295604254,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1NjA0MjU0","html_url":"https://github.com/fulcrologic/fulcro3/pull/31","diff_url":"https://github.com/fulcrologic/fulcro3/pull/31.diff","patch_url":"https://github.com/fulcrologic/fulcro3/pull/31.patch","issue_url":"https://api.github.com/repos/fulcrologic/fulcro3/issues/31","number":31,"state":"open","locked":false,"title":"Incorporated changes from PR #38 on fulcro incubator","user":{"login":"abhi18av","id":12799326,"node_id":"MDQ6VXNlcjEyNzk5MzI2","avatar_url":"https://avatars1.githubusercontent.com/u/12799326?v=4","gravatar_id":"","url":"https://api.github.com/users/abhi18av","html_url":"https://github.com/abhi18av","followers_url":"https://api.github.com/users/abhi18av/followers","following_url":"https://api.github.com/users/abhi18av/following{/other_user}","gists_url":"https://api.github.com/users/abhi18av/gists{/gist_id}","starred_url":"https://api.github.com/users/abhi18av/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhi18av/subscriptions","organizations_url":"https://api.github.com/users/abhi18av/orgs","repos_url":"https://api.github.com/users/abhi18av/repos","events_url":"https://api.github.com/users/abhi18av/events{/privacy}","received_events_url":"https://api.github.com/users/abhi18av/received_events","type":"User","site_admin":false},"body":"Porting over the patch from https://github.com/fulcro-legacy/fulcro-incubator/commit/38659c19cc8caa20167d4649242039d7a35dfae1 to fulcro3 repo","created_at":"2019-07-09T06:32:06Z","updated_at":"2019-07-10T15:10:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a14ae2fea1b7e7d601b3e09ae18404a1a5ddf24a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31/commits","review_comments_url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31/comments","review_comment_url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fulcrologic/fulcro3/issues/31/comments","statuses_url":"https://api.github.com/repos/fulcrologic/fulcro3/statuses/5549a75b6b879f2a967bae36c8841674a6099b57","head":{"label":"abhi18av:bug-fix-dynamic-routing","ref":"bug-fix-dynamic-routing","sha":"5549a75b6b879f2a967bae36c8841674a6099b57","user":{"login":"abhi18av","id":12799326,"node_id":"MDQ6VXNlcjEyNzk5MzI2","avatar_url":"https://avatars1.githubusercontent.com/u/12799326?v=4","gravatar_id":"","url":"https://api.github.com/users/abhi18av","html_url":"https://github.com/abhi18av","followers_url":"https://api.github.com/users/abhi18av/followers","following_url":"https://api.github.com/users/abhi18av/following{/other_user}","gists_url":"https://api.github.com/users/abhi18av/gists{/gist_id}","starred_url":"https://api.github.com/users/abhi18av/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhi18av/subscriptions","organizations_url":"https://api.github.com/users/abhi18av/orgs","repos_url":"https://api.github.com/users/abhi18av/repos","events_url":"https://api.github.com/users/abhi18av/events{/privacy}","received_events_url":"https://api.github.com/users/abhi18av/received_events","type":"User","site_admin":false},"repo":{"id":192499308,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI0OTkzMDg=","name":"fulcro3","full_name":"abhi18av/fulcro3","private":false,"owner":{"login":"abhi18av","id":12799326,"node_id":"MDQ6VXNlcjEyNzk5MzI2","avatar_url":"https://avatars1.githubusercontent.com/u/12799326?v=4","gravatar_id":"","url":"https://api.github.com/users/abhi18av","html_url":"https://github.com/abhi18av","followers_url":"https://api.github.com/users/abhi18av/followers","following_url":"https://api.github.com/users/abhi18av/following{/other_user}","gists_url":"https://api.github.com/users/abhi18av/gists{/gist_id}","starred_url":"https://api.github.com/users/abhi18av/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhi18av/subscriptions","organizations_url":"https://api.github.com/users/abhi18av/orgs","repos_url":"https://api.github.com/users/abhi18av/repos","events_url":"https://api.github.com/users/abhi18av/events{/privacy}","received_events_url":"https://api.github.com/users/abhi18av/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abhi18av/fulcro3","description":"Fulcro 3 - The Next Generation of Fulcro","fork":true,"url":"https://api.github.com/repos/abhi18av/fulcro3","forks_url":"https://api.github.com/repos/abhi18av/fulcro3/forks","keys_url":"https://api.github.com/repos/abhi18av/fulcro3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhi18av/fulcro3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhi18av/fulcro3/teams","hooks_url":"https://api.github.com/repos/abhi18av/fulcro3/hooks","issue_events_url":"https://api.github.com/repos/abhi18av/fulcro3/issues/events{/number}","events_url":"https://api.github.com/repos/abhi18av/fulcro3/events","assignees_url":"https://api.github.com/repos/abhi18av/fulcro3/assignees{/user}","branches_url":"https://api.github.com/repos/abhi18av/fulcro3/branches{/branch}","tags_url":"https://api.github.com/repos/abhi18av/fulcro3/tags","blobs_url":"https://api.github.com/repos/abhi18av/fulcro3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhi18av/fulcro3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhi18av/fulcro3/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhi18av/fulcro3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhi18av/fulcro3/statuses/{sha}","languages_url":"https://api.github.com/repos/abhi18av/fulcro3/languages","stargazers_url":"https://api.github.com/repos/abhi18av/fulcro3/stargazers","contributors_url":"https://api.github.com/repos/abhi18av/fulcro3/contributors","subscribers_url":"https://api.github.com/repos/abhi18av/fulcro3/subscribers","subscription_url":"https://api.github.com/repos/abhi18av/fulcro3/subscription","commits_url":"https://api.github.com/repos/abhi18av/fulcro3/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhi18av/fulcro3/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhi18av/fulcro3/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhi18av/fulcro3/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhi18av/fulcro3/contents/{+path}","compare_url":"https://api.github.com/repos/abhi18av/fulcro3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhi18av/fulcro3/merges","archive_url":"https://api.github.com/repos/abhi18av/fulcro3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhi18av/fulcro3/downloads","issues_url":"https://api.github.com/repos/abhi18av/fulcro3/issues{/number}","pulls_url":"https://api.github.com/repos/abhi18av/fulcro3/pulls{/number}","milestones_url":"https://api.github.com/repos/abhi18av/fulcro3/milestones{/number}","notifications_url":"https://api.github.com/repos/abhi18av/fulcro3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhi18av/fulcro3/labels{/name}","releases_url":"https://api.github.com/repos/abhi18av/fulcro3/releases{/id}","deployments_url":"https://api.github.com/repos/abhi18av/fulcro3/deployments","created_at":"2019-06-18T08:33:46Z","updated_at":"2019-06-19T08:50:31Z","pushed_at":"2019-07-10T13:20:17Z","git_url":"git://github.com/abhi18av/fulcro3.git","ssh_url":"git@github.com:abhi18av/fulcro3.git","clone_url":"https://github.com/abhi18av/fulcro3.git","svn_url":"https://github.com/abhi18av/fulcro3","homepage":null,"size":653,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"fulcrologic:develop","ref":"develop","sha":"7827d5b79e365289217912d4e0132d3f8ee45c02","user":{"login":"fulcrologic","id":30102823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTAyODIz","avatar_url":"https://avatars3.githubusercontent.com/u/30102823?v=4","gravatar_id":"","url":"https://api.github.com/users/fulcrologic","html_url":"https://github.com/fulcrologic","followers_url":"https://api.github.com/users/fulcrologic/followers","following_url":"https://api.github.com/users/fulcrologic/following{/other_user}","gists_url":"https://api.github.com/users/fulcrologic/gists{/gist_id}","starred_url":"https://api.github.com/users/fulcrologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulcrologic/subscriptions","organizations_url":"https://api.github.com/users/fulcrologic/orgs","repos_url":"https://api.github.com/users/fulcrologic/repos","events_url":"https://api.github.com/users/fulcrologic/events{/privacy}","received_events_url":"https://api.github.com/users/fulcrologic/received_events","type":"Organization","site_admin":false},"repo":{"id":187661737,"node_id":"MDEwOlJlcG9zaXRvcnkxODc2NjE3Mzc=","name":"fulcro3","full_name":"fulcrologic/fulcro3","private":false,"owner":{"login":"fulcrologic","id":30102823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTAyODIz","avatar_url":"https://avatars3.githubusercontent.com/u/30102823?v=4","gravatar_id":"","url":"https://api.github.com/users/fulcrologic","html_url":"https://github.com/fulcrologic","followers_url":"https://api.github.com/users/fulcrologic/followers","following_url":"https://api.github.com/users/fulcrologic/following{/other_user}","gists_url":"https://api.github.com/users/fulcrologic/gists{/gist_id}","starred_url":"https://api.github.com/users/fulcrologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulcrologic/subscriptions","organizations_url":"https://api.github.com/users/fulcrologic/orgs","repos_url":"https://api.github.com/users/fulcrologic/repos","events_url":"https://api.github.com/users/fulcrologic/events{/privacy}","received_events_url":"https://api.github.com/users/fulcrologic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fulcrologic/fulcro3","description":"Fulcro 3 - The Next Generation of Fulcro","fork":false,"url":"https://api.github.com/repos/fulcrologic/fulcro3","forks_url":"https://api.github.com/repos/fulcrologic/fulcro3/forks","keys_url":"https://api.github.com/repos/fulcrologic/fulcro3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fulcrologic/fulcro3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fulcrologic/fulcro3/teams","hooks_url":"https://api.github.com/repos/fulcrologic/fulcro3/hooks","issue_events_url":"https://api.github.com/repos/fulcrologic/fulcro3/issues/events{/number}","events_url":"https://api.github.com/repos/fulcrologic/fulcro3/events","assignees_url":"https://api.github.com/repos/fulcrologic/fulcro3/assignees{/user}","branches_url":"https://api.github.com/repos/fulcrologic/fulcro3/branches{/branch}","tags_url":"https://api.github.com/repos/fulcrologic/fulcro3/tags","blobs_url":"https://api.github.com/repos/fulcrologic/fulcro3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fulcrologic/fulcro3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fulcrologic/fulcro3/git/refs{/sha}","trees_url":"https://api.github.com/repos/fulcrologic/fulcro3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fulcrologic/fulcro3/statuses/{sha}","languages_url":"https://api.github.com/repos/fulcrologic/fulcro3/languages","stargazers_url":"https://api.github.com/repos/fulcrologic/fulcro3/stargazers","contributors_url":"https://api.github.com/repos/fulcrologic/fulcro3/contributors","subscribers_url":"https://api.github.com/repos/fulcrologic/fulcro3/subscribers","subscription_url":"https://api.github.com/repos/fulcrologic/fulcro3/subscription","commits_url":"https://api.github.com/repos/fulcrologic/fulcro3/commits{/sha}","git_commits_url":"https://api.github.com/repos/fulcrologic/fulcro3/git/commits{/sha}","comments_url":"https://api.github.com/repos/fulcrologic/fulcro3/comments{/number}","issue_comment_url":"https://api.github.com/repos/fulcrologic/fulcro3/issues/comments{/number}","contents_url":"https://api.github.com/repos/fulcrologic/fulcro3/contents/{+path}","compare_url":"https://api.github.com/repos/fulcrologic/fulcro3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fulcrologic/fulcro3/merges","archive_url":"https://api.github.com/repos/fulcrologic/fulcro3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fulcrologic/fulcro3/downloads","issues_url":"https://api.github.com/repos/fulcrologic/fulcro3/issues{/number}","pulls_url":"https://api.github.com/repos/fulcrologic/fulcro3/pulls{/number}","milestones_url":"https://api.github.com/repos/fulcrologic/fulcro3/milestones{/number}","notifications_url":"https://api.github.com/repos/fulcrologic/fulcro3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fulcrologic/fulcro3/labels{/name}","releases_url":"https://api.github.com/repos/fulcrologic/fulcro3/releases{/id}","deployments_url":"https://api.github.com/repos/fulcrologic/fulcro3/deployments","created_at":"2019-05-20T14:56:43Z","updated_at":"2019-07-09T20:00:43Z","pushed_at":"2019-07-10T13:20:18Z","git_url":"git://github.com/fulcrologic/fulcro3.git","ssh_url":"git@github.com:fulcrologic/fulcro3.git","clone_url":"https://github.com/fulcrologic/fulcro3.git","svn_url":"https://github.com/fulcrologic/fulcro3","homepage":null,"size":667,"stargazers_count":32,"watchers_count":32,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":4,"watchers":32,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31"},"html":{"href":"https://github.com/fulcrologic/fulcro3/pull/31"},"issue":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/issues/31"},"comments":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/fulcrologic/fulcro3/statuses/5549a75b6b879f2a967bae36c8841674a6099b57"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"awkay"}}