payload: {"action":"closed","number":12827,"pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/12827","id":275089871,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1MDg5ODcx","html_url":"https://github.com/Yoast/wordpress-seo/pull/12827","diff_url":"https://github.com/Yoast/wordpress-seo/pull/12827.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/12827.patch","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/12827","number":12827,"state":"closed","locked":false,"title":"Configure imagemin-svgo to handle the SVG accessible attributes.","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Configure `imagemin-svgo` to handle the SVG accessible attributes.\r\n\r\nWith this change, the accessible attributes for the SVG icons in the `images/` directory won't be removed any longer during the build process.\r\n\r\n## Relevant technical choices:\r\n- re-enables `imagemin-svgo` after https://github.com/Yoast/wordpress-seo/commit/7005907934677881fce202d94898c9da55ac43f8\r\n- updates `imagemin-svgo` to latest version: we need some new options available in recent svgo versions. As a consequence, other packages get updated see `yarn.lock` /Cc @Xyfi \r\n- configures the svgo plugins:\r\n  - always removes the `<title>` and `<description>` elements\r\n  - keep ARIA roles and attributes if already set \r\n  - automatically adds `role=\"img\" aria-hidden=\"true\" focusable=\"false\"` 🎉 by using `addAttributesToSVGElement`, see examples on https://github.com/svg/svgo/blob/d6e462b679a11376694c948c81e5c984c3db8bae/plugins/addAttributesToSVGElement.js\r\n  - svgo seems smart enough to not add doubled roles and attributes \r\n  - keeps the other config defaults unchanged\r\n\r\nNote: `waiting.gif` gets changed as well, but there are no visible changes.\r\n\r\n## Test instructions\r\n- check the SVG icons look the same e.g. these ones in the Posts table:\r\n<img width=\"231\" alt=\"Screenshot 2019-05-01 at 18 55 40\" src=\"https://user-images.githubusercontent.com/1682452/57029727-de04ab00-6c42-11e9-8bef-8b5bc0f1bf5f.png\">\r\n\r\n- you can also manually view all the SVG icons in `images` dragging them into a tab of your browser or directly in macOS Finder\r\n- unzip and place the attached SVG icon `test.svg` in the `images` directory\r\n- open `test.svg` in your editor of choice and observe the (intentional) mess in the markup\r\n- run `grunt build:images`\r\n- see the new `test.svg` markup is now very clean and has the accessible attributes\r\n\r\n## UI changes\r\n* [ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.\r\n\r\nFixes #12654 \r\n\r\n[test.svg.zip](https://github.com/Yoast/wordpress-seo/files/3135268/test.svg.zip)\r\n","created_at":"2019-05-01T17:09:35Z","updated_at":"2019-05-07T06:31:54Z","closed_at":"2019-05-07T06:31:54Z","merged_at":"2019-05-07T06:31:53Z","merge_commit_sha":"3f01d2a29101a1a8764428cbd2d0d420845e10c1","assignee":{"login":"Xyfi","id":5389513,"node_id":"MDQ6VXNlcjUzODk1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5389513?v=4","gravatar_id":"","url":"https://api.github.com/users/Xyfi","html_url":"https://github.com/Xyfi","followers_url":"https://api.github.com/users/Xyfi/followers","following_url":"https://api.github.com/users/Xyfi/following{/other_user}","gists_url":"https://api.github.com/users/Xyfi/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyfi/subscriptions","organizations_url":"https://api.github.com/users/Xyfi/orgs","repos_url":"https://api.github.com/users/Xyfi/repos","events_url":"https://api.github.com/users/Xyfi/events{/privacy}","received_events_url":"https://api.github.com/users/Xyfi/received_events","type":"User","site_admin":false},"assignees":[{"login":"Xyfi","id":5389513,"node_id":"MDQ6VXNlcjUzODk1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5389513?v=4","gravatar_id":"","url":"https://api.github.com/users/Xyfi","html_url":"https://github.com/Xyfi","followers_url":"https://api.github.com/users/Xyfi/followers","following_url":"https://api.github.com/users/Xyfi/following{/other_user}","gists_url":"https://api.github.com/users/Xyfi/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyfi/subscriptions","organizations_url":"https://api.github.com/users/Xyfi/orgs","repos_url":"https://api.github.com/users/Xyfi/repos","events_url":"https://api.github.com/users/Xyfi/events{/privacy}","received_events_url":"https://api.github.com/users/Xyfi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/154","html_url":"https://github.com/Yoast/wordpress-seo/milestone/154","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/154/labels","id":4273471,"node_id":"MDk6TWlsZXN0b25lNDI3MzQ3MQ==","number":154,"title":"11.3","description":null,"creator":{"login":"Xyfi","id":5389513,"node_id":"MDQ6VXNlcjUzODk1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5389513?v=4","gravatar_id":"","url":"https://api.github.com/users/Xyfi","html_url":"https://github.com/Xyfi","followers_url":"https://api.github.com/users/Xyfi/followers","following_url":"https://api.github.com/users/Xyfi/following{/other_user}","gists_url":"https://api.github.com/users/Xyfi/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyfi/subscriptions","organizations_url":"https://api.github.com/users/Xyfi/orgs","repos_url":"https://api.github.com/users/Xyfi/repos","events_url":"https://api.github.com/users/Xyfi/events{/privacy}","received_events_url":"https://api.github.com/users/Xyfi/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":11,"state":"open","created_at":"2019-04-30T13:20:07Z","updated_at":"2019-05-07T06:31:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/12827/commits","review_comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/12827/comments","review_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/12827/comments","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/fcee6f0d9e0641724a9756d393450d32a74e783d","head":{"label":"Yoast:12654-svg-accessible-attributes","ref":"12654-svg-accessible-attributes","sha":"fcee6f0d9e0641724a9756d393450d32a74e783d","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","private":false,"owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2019-05-06T10:31:38Z","pushed_at":"2019-05-07T06:31:53Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"https://yoast.com/wordpress/plugins/seo/","size":704438,"stargazers_count":1070,"watchers_count":1070,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":619,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":986,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":619,"open_issues":986,"watchers":1070,"default_branch":"trunk"}},"base":{"label":"Yoast:trunk","ref":"trunk","sha":"6108ff6e9c5d4164175c7abc9ef4cab621ad3057","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","private":false,"owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2019-05-06T10:31:38Z","pushed_at":"2019-05-07T06:31:53Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"https://yoast.com/wordpress/plugins/seo/","size":704438,"stargazers_count":1070,"watchers_count":1070,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":619,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":986,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":619,"open_issues":986,"watchers":1070,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/12827"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/12827"},"issue":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/12827"},"comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/12827/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/12827/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/12827/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/fcee6f0d9e0641724a9756d393450d32a74e783d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Xyfi","id":5389513,"node_id":"MDQ6VXNlcjUzODk1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5389513?v=4","gravatar_id":"","url":"https://api.github.com/users/Xyfi","html_url":"https://github.com/Xyfi","followers_url":"https://api.github.com/users/Xyfi/followers","following_url":"https://api.github.com/users/Xyfi/following{/other_user}","gists_url":"https://api.github.com/users/Xyfi/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyfi/subscriptions","organizations_url":"https://api.github.com/users/Xyfi/orgs","repos_url":"https://api.github.com/users/Xyfi/repos","events_url":"https://api.github.com/users/Xyfi/events{/privacy}","received_events_url":"https://api.github.com/users/Xyfi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":938,"deletions":1016,"changed_files":23}}
other: {"actor":{"display_login":"Xyfi"}}