payload: {"action":"created","issue":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/886","repository_url":"https://api.github.com/repos/sakura-editor/sakura","labels_url":"https://api.github.com/repos/sakura-editor/sakura/issues/886/labels{/name}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/886/comments","events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/886/events","html_url":"https://github.com/sakura-editor/sakura/pull/886","id":438656944,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NjM4MTM4","number":886,"title":"APPVEYOR_REPO_COMMIT の利用をやめる (APPVEYOR_SHORTHASH も廃止する)","user":{"login":"m-tmatma","id":5567450,"node_id":"MDQ6VXNlcjU1Njc0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5567450?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tmatma","html_url":"https://github.com/m-tmatma","followers_url":"https://api.github.com/users/m-tmatma/followers","following_url":"https://api.github.com/users/m-tmatma/following{/other_user}","gists_url":"https://api.github.com/users/m-tmatma/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tmatma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tmatma/subscriptions","organizations_url":"https://api.github.com/users/m-tmatma/orgs","repos_url":"https://api.github.com/users/m-tmatma/repos","events_url":"https://api.github.com/users/m-tmatma/events{/privacy}","received_events_url":"https://api.github.com/users/m-tmatma/received_events","type":"User","site_admin":false},"labels":[{"id":961778227,"node_id":"MDU6TGFiZWw5NjE3NzgyMjc=","url":"https://api.github.com/repos/sakura-editor/sakura/labels/CI","name":"CI","color":"fef2c0","default":false},{"id":1304053780,"node_id":"MDU6TGFiZWwxMzA0MDUzNzgw","url":"https://api.github.com/repos/sakura-editor/sakura/labels/appveyor","name":"appveyor","color":"e8827a","default":false},{"id":1304052349,"node_id":"MDU6TGFiZWwxMzA0MDUyMzQ5","url":"https://api.github.com/repos/sakura-editor/sakura/labels/azure%20pipelines","name":"azure pipelines","color":"f2da57","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1","html_url":"https://github.com/sakura-editor/sakura/milestone/1","labels_url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1/labels","id":3390252,"node_id":"MDk6TWlsZXN0b25lMzM5MDI1Mg==","number":1,"title":"v2.4.0","description":"v.2.4.0","creator":{"login":"kobake","id":2929454,"node_id":"MDQ6VXNlcjI5Mjk0NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2929454?v=4","gravatar_id":"","url":"https://api.github.com/users/kobake","html_url":"https://github.com/kobake","followers_url":"https://api.github.com/users/kobake/followers","following_url":"https://api.github.com/users/kobake/following{/other_user}","gists_url":"https://api.github.com/users/kobake/gists{/gist_id}","starred_url":"https://api.github.com/users/kobake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobake/subscriptions","organizations_url":"https://api.github.com/users/kobake/orgs","repos_url":"https://api.github.com/users/kobake/repos","events_url":"https://api.github.com/users/kobake/events{/privacy}","received_events_url":"https://api.github.com/users/kobake/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":646,"state":"open","created_at":"2018-05-31T12:48:23Z","updated_at":"2019-07-20T23:42:26Z","due_on":null,"closed_at":null},"comments":42,"created_at":"2019-04-30T08:26:11Z","updated_at":"2019-07-21T02:20:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/886","html_url":"https://github.com/sakura-editor/sakura/pull/886","diff_url":"https://github.com/sakura-editor/sakura/pull/886.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/886.patch"},"body":"APPVEYOR_REPO_COMMIT の利用をやめる (APPVEYOR_SHORTHASH も廃止する)\r\n\r\n## 背景\r\n\r\n#821 で Azure Pipelines で環境変数の定義を検討中だが、\r\n[Azure Pipelinse の Predefined variables](https://docs.microsoft.com/ja-jp/azure/devops/pipelines/build/variables?tabs=yaml&view=azure-devops#predefined-variables) では \r\n`$(Build.SourceVersion)` (YMLの場合) あるいは `BUILD_SOURCEVERSION` (バッチファイルの場合) \r\nという appveyor と別の環境変数が割り当てられている。\r\n\r\nしかも\r\n\r\n`git show   -s --format=%H` という git コマンドで取得できるので二重管理になっているので\r\n`APPVEYOR_REPO_COMMIT`を利用するのをやめる。\r\n同様に `APPVEYOR_SHORTHASH` も  対応する `GIT_SHORT_COMMIT_HASH`という変数があるので廃止する\r\n\r\n### 2019/06/15 追記\r\n\r\nTEMP_GIT_SHORT_COMMIT_HASH と TEMP_GIT_COMMIT_HASH を一時的に導入して\r\n動作を維持するようにしました。\r\n\r\n別の PR で GIT_SHORT_COMMIT_HASH と GIT_COMMIT_HASH に名前変更して仕様変更します。\r\n\r\n## ~仕様が変更になる点~\r\n\r\n~ローカルビルドの場合は `APPVEYOR_REPO_COMMIT` が空だったので zip ファイル名には\r\ncommit hash が含まれなかったが、この PR 後は  `GIT_SHORT_COMMIT_HASH` を\r\n参照するようになるので  **Git が有効な場合には** zip ファイル名に short hash が含まれるようになる。~\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments/513513518","html_url":"https://github.com/sakura-editor/sakura/pull/886#issuecomment-513513518","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/886","id":513513518,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMzUxMzUxOA==","user":{"login":"m-tmatma","id":5567450,"node_id":"MDQ6VXNlcjU1Njc0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5567450?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tmatma","html_url":"https://github.com/m-tmatma","followers_url":"https://api.github.com/users/m-tmatma/followers","following_url":"https://api.github.com/users/m-tmatma/following{/other_user}","gists_url":"https://api.github.com/users/m-tmatma/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tmatma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tmatma/subscriptions","organizations_url":"https://api.github.com/users/m-tmatma/orgs","repos_url":"https://api.github.com/users/m-tmatma/repos","events_url":"https://api.github.com/users/m-tmatma/events{/privacy}","received_events_url":"https://api.github.com/users/m-tmatma/received_events","type":"User","site_admin":false},"created_at":"2019-07-21T02:20:20Z","updated_at":"2019-07-21T02:20:20Z","author_association":"MEMBER","body":"ぐちゃぐちゃになったので、動作確認後、PR 作り直します。\r\n\r\n方針は\r\n\r\n1. TEMP_GIT_SHORT_COMMIT_HASH と TEMP_GIT_COMMIT_HASH を一時的に導入する\r\n2. TEMP_GIT_SHORT_COMMIT_HASH と TEMP_GIT_COMMIT_HASH は githash.bat で定義する\r\n3. APPVEYOR_SHORTHASH   → TEMP_GIT_SHORT_COMMIT_HASH への一括置換\r\n4. APPVEYOR_REPO_COMMIT → TEMP_GIT_COMMIT_HASH への一括置換\r\n5. 環境変数 APPVEYOR が定義されているときに TEMP_GIT_SHORT_COMMIT_HASH は GIT_SHORT_COMMIT_HASH (GIT_COMMIT_HASH) をもとに定義する\r\n6. 環境変数 APPVEYOR が定義されているときに TEMP_GIT_COMMIT_HASH は GIT_COMMIT_HASH をもとに定義する\r\n\r\n\r\n\r\n"}}
other: {"actor":{"display_login":"m-tmatma"}}