payload: {"push_id":4371126526,"size":2,"distinct_size":1,"ref":"refs/heads/feature/travis-test-against-variety-of-phpcs-versions","head":"ff44f98a7ffbae350d94581bc4a1b08ec2995301","before":"5bc212c43b559b1e3360313a1ba210016e1257d4","commits":[{"sha":"dedf799eaf479b5d5d2779546d3e72573a0ae558","author":{"name":"jrfnl","email":"50d644c256f2863fd67b233efe329d3f54f4e258@users.noreply.github.com"},"message":"Travis: test against PHP 7.4, not snapshot\n\nLooks like Travis (finally) has got a \"normal\" PHP 7.4 image available.\n\nAlso, as PHP 7.4 has been released, don't allow failures for 7.4 anymore.\n\nAnd while we're at it, let's add a build against `nightly` (PHP 8) which is allowed to fail - for the time being - and allow the plugin to be installed on PHP 8.","distinct":false,"url":"https://api.github.com/repos/Dealerdirect/phpcodesniffer-composer-installer/commits/dedf799eaf479b5d5d2779546d3e72573a0ae558"},{"sha":"ff44f98a7ffbae350d94581bc4a1b08ec2995301","author":{"name":"jrfnl","email":"50d644c256f2863fd67b233efe329d3f54f4e258@users.noreply.github.com"},"message":"Travis: use a mix of PHPCS versions in the matrix\n\nUsing a normal `composer install` means that while the build was testing against various PHP versions, it would only ever test against the latest PHPCS 3.x version (`3.5.3` at the time of writing) for PHP 5.4-7.4 and PHPCS 2.9.2 for PHP 5.3.\n\nThis PR changes the build matrix to test against a variety of PHPCS versions to ensure compatibility with all versions this plugin claims to support.\n\nSome explanation is needed about the choices made in this changeset:\n\n### Adding an `install` section\n\nThe `install` section is intended for installing prerequisites for test build tests.\n\nAFAICS, this wasn't previously used to avoid the PHP `lint` command running over the `vendor` directory, but that can be solved by just removing the `vendor` directory from the list PHP `lint` is run over.\n\nHaving the install instructions in the `install` section makes it clearer that the installation is not part of the tests.\n\n### Changes to the PHP `lint` command\n\nAs mentioned above, the command now excludes the `vendor` directory.\n\nAlso, as most PHP versions now have a second build, adding a `LINT` environment variable so the PHP linting is only done on one build per PHP version.\n\n### Changes to the PHPCS run test command\n\nThe PSR12 ruleset which is part of the `phpcs.xml.dist` ruleset was only added in PHPCS 3.3.0.\n\nAs testing is now done against a wider range of PHPCS versions, this `PSR12` ruleset won't always be available, so I've added a `PHPCS` environment variable to only run the PHPCS check against the repo specific ruleset _once_ per build.\n\nI've added this variable to a build against the latest PHPCS version. While I'd like to use `dev-master` for this, that may be prone to intermittent bugs in PHPCS, so using a stable PHPCS version instead makes the build more sane.\n\nOn all the other builds, only a check against `PHPCompatibility` is run which then tests whether the setting of the `installed_paths` for external standards worked correctly.\n\nNow there are two caveats to this:\n* PHPCompatibility 9.0.0 dropped support for PHPCS < 2.3.0. So for testing against PHPCS < 2.3.0 we need to explicitly install PHPCompatibility 8.0.0.\n* The PHPCS `--exclude` option previously used to exclude the `PHPCompatibility.Upgrade.LowPHPCS` sniff is only available since PHPCS 2.6.2, so cannot be used to exclude that sniff on older PHPCS versions.\n    With that in mind, switching to using the `--sniffs=` command line option to limit the PHPCS run to just one sniff.\n    This option has been available since PHPCS 1.x (or even before), so can be used without problem.\n    Additionally, limiting the test run to just one sniff will make it faster as well.\n    I've just selected one of the sniffs from PHPCompatibility which has been around for a while for this. The actual sniff doesn't matter after all as this test is just about PHPCS recognizing the external standard correctly.\n\n### Custom PHP 5.3 script\n\nAs the script for the PHPCS run has changed now, there is no need for the custom `script` section for the PHP 5.3 build anymore. This can now revert back to using the normal test `script` again, so to that end, I've remove the custom script.","distinct":true,"url":"https://api.github.com/repos/Dealerdirect/phpcodesniffer-composer-installer/commits/ff44f98a7ffbae350d94581bc4a1b08ec2995301"}]}
other: {"actor":{"display_login":"jrfnl"}}