payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/282711779","pull_request_review_id":235881656,"id":282711779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjcxMTc3OQ==","diff_hunk":"@@ -33,12 +33,12 @@\n     Puppet[:vardir] = tmpdir(\"ssl_testing\")\n \n     # Host assumes ca cert and crl are present\n-    File.open(Puppet[:localcacert], 'w') { |f| f.write(@ca_cert.to_pem) }\n-    File.open(Puppet[:hostcrl], 'w') { |f| f.write(@crl.to_pem) }\n+    File.write(Puppet[:localcacert], @ca_cert.to_pem)\n+    File.write(Puppet[:hostcrl], @crl.to_pem)","path":"spec/unit/application/ssl_spec.rb","position":7,"original_position":7,"commit_id":"2ddc5e301029070159f32a66d3b79bc18f21d8ea","original_commit_id":"2ddc5e301029070159f32a66d3b79bc18f21d8ea","user":{"login":"kris-bosland","id":28908461,"node_id":"MDQ6VXNlcjI4OTA4NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/28908461?v=4","gravatar_id":"","url":"https://api.github.com/users/kris-bosland","html_url":"https://github.com/kris-bosland","followers_url":"https://api.github.com/users/kris-bosland/followers","following_url":"https://api.github.com/users/kris-bosland/following{/other_user}","gists_url":"https://api.github.com/users/kris-bosland/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-bosland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-bosland/subscriptions","organizations_url":"https://api.github.com/users/kris-bosland/orgs","repos_url":"https://api.github.com/users/kris-bosland/repos","events_url":"https://api.github.com/users/kris-bosland/events{/privacy}","received_events_url":"https://api.github.com/users/kris-bosland/received_events","type":"User","site_admin":false},"body":"I don't know enough ruby to know the implications of this change - are they equivalent?","created_at":"2019-05-10T00:27:41Z","updated_at":"2019-05-10T00:53:55Z","html_url":"https://github.com/puppetlabs/puppet/pull/7502#discussion_r282711779","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/282711779"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/7502#discussion_r282711779"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502","id":275530998,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NTMwOTk4","html_url":"https://github.com/puppetlabs/puppet/pull/7502","diff_url":"https://github.com/puppetlabs/puppet/pull/7502.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/7502.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7502","number":7502,"state":"open","locked":false,"title":"(PUP-9466) Readd encrypted private keys","user":{"login":"joshcooper","id":737664,"node_id":"MDQ6VXNlcjczNzY2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/737664?v=4","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"Historically `Puppet::SSL::Key` supported password protected private keys,\r\nprovided the password file `Puppet[:passfile]` existed prior to\r\n`Puppet::SSL::Host` being initialized the first time. However, it has two\r\nlimitations:\r\n\r\n * If the private key was encrypted and the `passfile` was later deleted, then\r\n   ruby would hang trying to prompt for the password.\r\n * Private keys were encrypted using 3DES-CBC, which is outdated.\r\n\r\nThis commit adds an optional `password` keyword argument to encrypt and decrypt\r\nthe private key. Decryption will use the cipher and IV specified in the PEM\r\nheader, such as `DEK-Info: AES-128-CBC,7D9CB780A5571FAC184E44E1D736A163`, and\r\nthe provided password.\r\n\r\nEncryption will always use AES-128-CBC and save the private key in the\r\n\"traditional\" PEM format, not PKCS8. GCM is not an option since it's not\r\navailable in ruby 2.3, and openssl 1.1 can't decrypt a previously GCM-encrypted\r\nprivate key.","created_at":"2019-05-02T21:45:43Z","updated_at":"2019-05-10T00:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f179555cf7e8ba3b14e80582a331106bb112a4cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7502/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/2ddc5e301029070159f32a66d3b79bc18f21d8ea","head":{"label":"joshcooper:encrypted-private-keys","ref":"encrypted-private-keys","sha":"2ddc5e301029070159f32a66d3b79bc18f21d8ea","user":{"login":"joshcooper","id":737664,"node_id":"MDQ6VXNlcjczNzY2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/737664?v=4","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"repo":{"id":1632836,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMyODM2","name":"puppet","full_name":"joshcooper/puppet","private":false,"owner":{"login":"joshcooper","id":737664,"node_id":"MDQ6VXNlcjczNzY2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/737664?v=4","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshcooper/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/joshcooper/puppet","forks_url":"https://api.github.com/repos/joshcooper/puppet/forks","keys_url":"https://api.github.com/repos/joshcooper/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshcooper/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshcooper/puppet/teams","hooks_url":"https://api.github.com/repos/joshcooper/puppet/hooks","issue_events_url":"https://api.github.com/repos/joshcooper/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/joshcooper/puppet/events","assignees_url":"https://api.github.com/repos/joshcooper/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/joshcooper/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/joshcooper/puppet/tags","blobs_url":"https://api.github.com/repos/joshcooper/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshcooper/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshcooper/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshcooper/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshcooper/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/joshcooper/puppet/languages","stargazers_url":"https://api.github.com/repos/joshcooper/puppet/stargazers","contributors_url":"https://api.github.com/repos/joshcooper/puppet/contributors","subscribers_url":"https://api.github.com/repos/joshcooper/puppet/subscribers","subscription_url":"https://api.github.com/repos/joshcooper/puppet/subscription","commits_url":"https://api.github.com/repos/joshcooper/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshcooper/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshcooper/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshcooper/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshcooper/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/joshcooper/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshcooper/puppet/merges","archive_url":"https://api.github.com/repos/joshcooper/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshcooper/puppet/downloads","issues_url":"https://api.github.com/repos/joshcooper/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/joshcooper/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/joshcooper/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/joshcooper/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshcooper/puppet/labels{/name}","releases_url":"https://api.github.com/repos/joshcooper/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/joshcooper/puppet/deployments","created_at":"2011-04-18T21:50:21Z","updated_at":"2019-05-03T23:31:38Z","pushed_at":"2019-05-09T22:36:27Z","git_url":"git://github.com/joshcooper/puppet.git","ssh_url":"git@github.com:joshcooper/puppet.git","clone_url":"https://github.com/joshcooper/puppet.git","svn_url":"https://github.com/joshcooper/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":73230,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"b3d12c54069ec738d6c9549bffef705bf4dd7e3d","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NDQ=","name":"puppet","full_name":"puppetlabs/puppet","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2019-05-09T16:52:25Z","pushed_at":"2019-05-09T22:36:29Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":73876,"stargazers_count":5287,"watchers_count":5287,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2085,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2085,"open_issues":40,"watchers":5287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/7502"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/7502"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/7502/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7502/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/2ddc5e301029070159f32a66d3b79bc18f21d8ea"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"kris-bosland"}}