payload: {"action":"opened","number":68641,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/68641","id":317258645,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3MjU4NjQ1","html_url":"https://github.com/NixOS/nixpkgs/pull/68641","diff_url":"https://github.com/NixOS/nixpkgs/pull/68641.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/68641.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/68641","number":68641,"state":"open","locked":false,"title":"bundlerApp: avoid unecessary rebuilds when gemdir changes","user":{"login":"zimbatm","id":3248,"node_id":"MDQ6VXNlcjMyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"body":"Because the gemdir was referenced on the derivation, it would cause the\r\nwhole gemdir to get added to the store, which would in turn force the\r\nderivation to be rebuilt whenever unrelated folder files would change.\r\n\r\n<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->\r\n###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run \"nix-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Ensured that relevant documentation is up to date\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n###### Notify maintainers\r\n\r\ncc @\r\n","created_at":"2019-09-13T10:09:41Z","updated_at":"2019-09-13T10:09:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"manveru","id":3507,"node_id":"MDQ6VXNlcjM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3507?v=4","gravatar_id":"","url":"https://api.github.com/users/manveru","html_url":"https://github.com/manveru","followers_url":"https://api.github.com/users/manveru/followers","following_url":"https://api.github.com/users/manveru/following{/other_user}","gists_url":"https://api.github.com/users/manveru/gists{/gist_id}","starred_url":"https://api.github.com/users/manveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manveru/subscriptions","organizations_url":"https://api.github.com/users/manveru/orgs","repos_url":"https://api.github.com/users/manveru/repos","events_url":"https://api.github.com/users/manveru/events{/privacy}","received_events_url":"https://api.github.com/users/manveru/received_events","type":"User","site_admin":false},{"login":"alyssais","id":2768870,"node_id":"MDQ6VXNlcjI3Njg4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768870?v=4","gravatar_id":"","url":"https://api.github.com/users/alyssais","html_url":"https://github.com/alyssais","followers_url":"https://api.github.com/users/alyssais/followers","following_url":"https://api.github.com/users/alyssais/following{/other_user}","gists_url":"https://api.github.com/users/alyssais/gists{/gist_id}","starred_url":"https://api.github.com/users/alyssais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyssais/subscriptions","organizations_url":"https://api.github.com/users/alyssais/orgs","repos_url":"https://api.github.com/users/alyssais/repos","events_url":"https://api.github.com/users/alyssais/events{/privacy}","received_events_url":"https://api.github.com/users/alyssais/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/68641/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/68641/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/68641/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1ba4dee1eb1b71fff26ef48d3adaae73764bde73","head":{"label":"zimbatm:bundlerapp-no-rebuild","ref":"bundlerapp-no-rebuild","sha":"1ba4dee1eb1b71fff26ef48d3adaae73764bde73","user":{"login":"zimbatm","id":3248,"node_id":"MDQ6VXNlcjMyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"repo":{"id":40831446,"node_id":"MDEwOlJlcG9zaXRvcnk0MDgzMTQ0Ng==","name":"nixpkgs","full_name":"zimbatm/nixpkgs","private":false,"owner":{"login":"zimbatm","id":3248,"node_id":"MDQ6VXNlcjMyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zimbatm/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/zimbatm/nixpkgs","forks_url":"https://api.github.com/repos/zimbatm/nixpkgs/forks","keys_url":"https://api.github.com/repos/zimbatm/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimbatm/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimbatm/nixpkgs/teams","hooks_url":"https://api.github.com/repos/zimbatm/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/zimbatm/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/zimbatm/nixpkgs/events","assignees_url":"https://api.github.com/repos/zimbatm/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/zimbatm/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/zimbatm/nixpkgs/tags","blobs_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimbatm/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/zimbatm/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/zimbatm/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/zimbatm/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/zimbatm/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/zimbatm/nixpkgs/subscription","commits_url":"https://api.github.com/repos/zimbatm/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimbatm/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimbatm/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimbatm/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/zimbatm/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimbatm/nixpkgs/merges","archive_url":"https://api.github.com/repos/zimbatm/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimbatm/nixpkgs/downloads","issues_url":"https://api.github.com/repos/zimbatm/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/zimbatm/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/zimbatm/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/zimbatm/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimbatm/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/zimbatm/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/zimbatm/nixpkgs/deployments","created_at":"2015-08-16T17:52:31Z","updated_at":"2019-07-19T14:39:14Z","pushed_at":"2019-09-13T10:08:38Z","git_url":"git://github.com/zimbatm/nixpkgs.git","ssh_url":"git@github.com:zimbatm/nixpkgs.git","clone_url":"https://github.com/zimbatm/nixpkgs.git","svn_url":"https://github.com/zimbatm/nixpkgs","homepage":null,"size":911708,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"742c485f4f355313078662d0ba9484ceb998868d","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-09-13T09:55:09Z","pushed_at":"2019-09-13T09:56:04Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":1032245,"stargazers_count":4157,"watchers_count":4157,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3970,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4583,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3970,"open_issues":4583,"watchers":4157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/68641"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/68641"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/68641"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/68641/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/68641/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/68641/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/1ba4dee1eb1b71fff26ef48d3adaae73764bde73"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
other: {"actor":{"display_login":"zimbatm"}}