payload: {"action":"created","comment":{"url":"https://api.github.com/repos/loki-project/loki-network/pulls/comments/278926913","pull_request_review_id":231128941,"id":278926913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODkyNjkxMw==","diff_hunk":"@@ -6,25 +6,62 @@ namespace llarp\n {\n   namespace service\n   {\n+    const std::vector< std::string > Address::AllowedTLDs = {\".loki\", \".snode\"};","path":"llarp/service/address.cpp","position":4,"original_position":4,"commit_id":"09f706b9cd402ece23451589eeb2a962c85e26a0","original_commit_id":"09f706b9cd402ece23451589eeb2a962c85e26a0","user":{"login":"michael-loki","id":44553613,"node_id":"MDQ6VXNlcjQ0NTUzNjEz","avatar_url":"https://avatars2.githubusercontent.com/u/44553613?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-loki","html_url":"https://github.com/michael-loki","followers_url":"https://api.github.com/users/michael-loki/followers","following_url":"https://api.github.com/users/michael-loki/following{/other_user}","gists_url":"https://api.github.com/users/michael-loki/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-loki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-loki/subscriptions","organizations_url":"https://api.github.com/users/michael-loki/orgs","repos_url":"https://api.github.com/users/michael-loki/repos","events_url":"https://api.github.com/users/michael-loki/events{/privacy}","received_events_url":"https://api.github.com/users/michael-loki/received_events","type":"User","site_admin":false},"body":"I would say `std::set` for how this is being used","created_at":"2019-04-26T12:30:09Z","updated_at":"2019-04-26T12:33:56Z","html_url":"https://github.com/loki-project/loki-network/pull/564#discussion_r278926913","pull_request_url":"https://api.github.com/repos/loki-project/loki-network/pulls/564","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/loki-project/loki-network/pulls/comments/278926913"},"html":{"href":"https://github.com/loki-project/loki-network/pull/564#discussion_r278926913"},"pull_request":{"href":"https://api.github.com/repos/loki-project/loki-network/pulls/564"}}},"pull_request":{"url":"https://api.github.com/repos/loki-project/loki-network/pulls/564","id":273876041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczODc2MDQx","html_url":"https://github.com/loki-project/loki-network/pull/564","diff_url":"https://github.com/loki-project/loki-network/pull/564.diff","patch_url":"https://github.com/loki-project/loki-network/pull/564.patch","issue_url":"https://api.github.com/repos/loki-project/loki-network/issues/564","number":564,"state":"open","locked":false,"title":"fix Issue 563","user":{"login":"majestrate","id":499653,"node_id":"MDQ6VXNlcjQ5OTY1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/499653?v=4","gravatar_id":"","url":"https://api.github.com/users/majestrate","html_url":"https://github.com/majestrate","followers_url":"https://api.github.com/users/majestrate/followers","following_url":"https://api.github.com/users/majestrate/following{/other_user}","gists_url":"https://api.github.com/users/majestrate/gists{/gist_id}","starred_url":"https://api.github.com/users/majestrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majestrate/subscriptions","organizations_url":"https://api.github.com/users/majestrate/orgs","repos_url":"https://api.github.com/users/majestrate/repos","events_url":"https://api.github.com/users/majestrate/events{/privacy}","received_events_url":"https://api.github.com/users/majestrate/received_events","type":"User","site_admin":false},"body":"enables using subdomains on loki and snode addresses\r\nalso adds some unit tests","created_at":"2019-04-26T12:19:02Z","updated_at":"2019-04-26T12:33:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6549371087e5b055769cb78a646803f5719a18fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/loki-project/loki-network/pulls/564/commits","review_comments_url":"https://api.github.com/repos/loki-project/loki-network/pulls/564/comments","review_comment_url":"https://api.github.com/repos/loki-project/loki-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loki-project/loki-network/issues/564/comments","statuses_url":"https://api.github.com/repos/loki-project/loki-network/statuses/09f706b9cd402ece23451589eeb2a962c85e26a0","head":{"label":"majestrate:issue-563","ref":"issue-563","sha":"09f706b9cd402ece23451589eeb2a962c85e26a0","user":{"login":"majestrate","id":499653,"node_id":"MDQ6VXNlcjQ5OTY1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/499653?v=4","gravatar_id":"","url":"https://api.github.com/users/majestrate","html_url":"https://github.com/majestrate","followers_url":"https://api.github.com/users/majestrate/followers","following_url":"https://api.github.com/users/majestrate/following{/other_user}","gists_url":"https://api.github.com/users/majestrate/gists{/gist_id}","starred_url":"https://api.github.com/users/majestrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majestrate/subscriptions","organizations_url":"https://api.github.com/users/majestrate/orgs","repos_url":"https://api.github.com/users/majestrate/repos","events_url":"https://api.github.com/users/majestrate/events{/privacy}","received_events_url":"https://api.github.com/users/majestrate/received_events","type":"User","site_admin":false},"repo":{"id":158214334,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgyMTQzMzQ=","name":"loki-network","full_name":"majestrate/loki-network","private":false,"owner":{"login":"majestrate","id":499653,"node_id":"MDQ6VXNlcjQ5OTY1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/499653?v=4","gravatar_id":"","url":"https://api.github.com/users/majestrate","html_url":"https://github.com/majestrate","followers_url":"https://api.github.com/users/majestrate/followers","following_url":"https://api.github.com/users/majestrate/following{/other_user}","gists_url":"https://api.github.com/users/majestrate/gists{/gist_id}","starred_url":"https://api.github.com/users/majestrate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majestrate/subscriptions","organizations_url":"https://api.github.com/users/majestrate/orgs","repos_url":"https://api.github.com/users/majestrate/repos","events_url":"https://api.github.com/users/majestrate/events{/privacy}","received_events_url":"https://api.github.com/users/majestrate/received_events","type":"User","site_admin":false},"html_url":"https://github.com/majestrate/loki-network","description":"Lokinet is a private, decentralized and Market based Sybil resistant overlay network for the internet","fork":true,"url":"https://api.github.com/repos/majestrate/loki-network","forks_url":"https://api.github.com/repos/majestrate/loki-network/forks","keys_url":"https://api.github.com/repos/majestrate/loki-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majestrate/loki-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majestrate/loki-network/teams","hooks_url":"https://api.github.com/repos/majestrate/loki-network/hooks","issue_events_url":"https://api.github.com/repos/majestrate/loki-network/issues/events{/number}","events_url":"https://api.github.com/repos/majestrate/loki-network/events","assignees_url":"https://api.github.com/repos/majestrate/loki-network/assignees{/user}","branches_url":"https://api.github.com/repos/majestrate/loki-network/branches{/branch}","tags_url":"https://api.github.com/repos/majestrate/loki-network/tags","blobs_url":"https://api.github.com/repos/majestrate/loki-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majestrate/loki-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majestrate/loki-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/majestrate/loki-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majestrate/loki-network/statuses/{sha}","languages_url":"https://api.github.com/repos/majestrate/loki-network/languages","stargazers_url":"https://api.github.com/repos/majestrate/loki-network/stargazers","contributors_url":"https://api.github.com/repos/majestrate/loki-network/contributors","subscribers_url":"https://api.github.com/repos/majestrate/loki-network/subscribers","subscription_url":"https://api.github.com/repos/majestrate/loki-network/subscription","commits_url":"https://api.github.com/repos/majestrate/loki-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/majestrate/loki-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/majestrate/loki-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/majestrate/loki-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/majestrate/loki-network/contents/{+path}","compare_url":"https://api.github.com/repos/majestrate/loki-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majestrate/loki-network/merges","archive_url":"https://api.github.com/repos/majestrate/loki-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majestrate/loki-network/downloads","issues_url":"https://api.github.com/repos/majestrate/loki-network/issues{/number}","pulls_url":"https://api.github.com/repos/majestrate/loki-network/pulls{/number}","milestones_url":"https://api.github.com/repos/majestrate/loki-network/milestones{/number}","notifications_url":"https://api.github.com/repos/majestrate/loki-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majestrate/loki-network/labels{/name}","releases_url":"https://api.github.com/repos/majestrate/loki-network/releases{/id}","deployments_url":"https://api.github.com/repos/majestrate/loki-network/deployments","created_at":"2018-11-19T11:55:47Z","updated_at":"2019-04-25T17:16:18Z","pushed_at":"2019-04-26T12:17:58Z","git_url":"git://github.com/majestrate/loki-network.git","ssh_url":"git@github.com:majestrate/loki-network.git","clone_url":"https://github.com/majestrate/loki-network.git","svn_url":"https://github.com/majestrate/loki-network","homepage":"","size":18569,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"loki-project:master","ref":"master","sha":"353021b671bfe830b35165c6e80fa34da8e3497d","user":{"login":"loki-project","id":35471049,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDcxMDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/35471049?v=4","gravatar_id":"","url":"https://api.github.com/users/loki-project","html_url":"https://github.com/loki-project","followers_url":"https://api.github.com/users/loki-project/followers","following_url":"https://api.github.com/users/loki-project/following{/other_user}","gists_url":"https://api.github.com/users/loki-project/gists{/gist_id}","starred_url":"https://api.github.com/users/loki-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loki-project/subscriptions","organizations_url":"https://api.github.com/users/loki-project/orgs","repos_url":"https://api.github.com/users/loki-project/repos","events_url":"https://api.github.com/users/loki-project/events{/privacy}","received_events_url":"https://api.github.com/users/loki-project/received_events","type":"Organization","site_admin":false},"repo":{"id":137728328,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MjgzMjg=","name":"loki-network","full_name":"loki-project/loki-network","private":false,"owner":{"login":"loki-project","id":35471049,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDcxMDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/35471049?v=4","gravatar_id":"","url":"https://api.github.com/users/loki-project","html_url":"https://github.com/loki-project","followers_url":"https://api.github.com/users/loki-project/followers","following_url":"https://api.github.com/users/loki-project/following{/other_user}","gists_url":"https://api.github.com/users/loki-project/gists{/gist_id}","starred_url":"https://api.github.com/users/loki-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loki-project/subscriptions","organizations_url":"https://api.github.com/users/loki-project/orgs","repos_url":"https://api.github.com/users/loki-project/repos","events_url":"https://api.github.com/users/loki-project/events{/privacy}","received_events_url":"https://api.github.com/users/loki-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/loki-project/loki-network","description":"Lokinet is a private, decentralized and IP based overlay network for the internet.","fork":false,"url":"https://api.github.com/repos/loki-project/loki-network","forks_url":"https://api.github.com/repos/loki-project/loki-network/forks","keys_url":"https://api.github.com/repos/loki-project/loki-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loki-project/loki-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loki-project/loki-network/teams","hooks_url":"https://api.github.com/repos/loki-project/loki-network/hooks","issue_events_url":"https://api.github.com/repos/loki-project/loki-network/issues/events{/number}","events_url":"https://api.github.com/repos/loki-project/loki-network/events","assignees_url":"https://api.github.com/repos/loki-project/loki-network/assignees{/user}","branches_url":"https://api.github.com/repos/loki-project/loki-network/branches{/branch}","tags_url":"https://api.github.com/repos/loki-project/loki-network/tags","blobs_url":"https://api.github.com/repos/loki-project/loki-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loki-project/loki-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loki-project/loki-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/loki-project/loki-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loki-project/loki-network/statuses/{sha}","languages_url":"https://api.github.com/repos/loki-project/loki-network/languages","stargazers_url":"https://api.github.com/repos/loki-project/loki-network/stargazers","contributors_url":"https://api.github.com/repos/loki-project/loki-network/contributors","subscribers_url":"https://api.github.com/repos/loki-project/loki-network/subscribers","subscription_url":"https://api.github.com/repos/loki-project/loki-network/subscription","commits_url":"https://api.github.com/repos/loki-project/loki-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/loki-project/loki-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/loki-project/loki-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/loki-project/loki-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/loki-project/loki-network/contents/{+path}","compare_url":"https://api.github.com/repos/loki-project/loki-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loki-project/loki-network/merges","archive_url":"https://api.github.com/repos/loki-project/loki-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loki-project/loki-network/downloads","issues_url":"https://api.github.com/repos/loki-project/loki-network/issues{/number}","pulls_url":"https://api.github.com/repos/loki-project/loki-network/pulls{/number}","milestones_url":"https://api.github.com/repos/loki-project/loki-network/milestones{/number}","notifications_url":"https://api.github.com/repos/loki-project/loki-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loki-project/loki-network/labels{/name}","releases_url":"https://api.github.com/repos/loki-project/loki-network/releases{/id}","deployments_url":"https://api.github.com/repos/loki-project/loki-network/deployments","created_at":"2018-06-18T08:39:19Z","updated_at":"2019-04-26T10:28:55Z","pushed_at":"2019-04-26T12:19:03Z","git_url":"git://github.com/loki-project/loki-network.git","ssh_url":"git@github.com:loki-project/loki-network.git","clone_url":"https://github.com/loki-project/loki-network.git","svn_url":"https://github.com/loki-project/loki-network","homepage":"https://loki.network/","size":18474,"stargazers_count":99,"watchers_count":99,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":35,"open_issues":52,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loki-project/loki-network/pulls/564"},"html":{"href":"https://github.com/loki-project/loki-network/pull/564"},"issue":{"href":"https://api.github.com/repos/loki-project/loki-network/issues/564"},"comments":{"href":"https://api.github.com/repos/loki-project/loki-network/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/loki-project/loki-network/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/loki-project/loki-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loki-project/loki-network/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/loki-project/loki-network/statuses/09f706b9cd402ece23451589eeb2a962c85e26a0"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"michael-loki"}}