payload: {"action":"created","issue":{"url":"https://api.github.com/repos/brave/brave-core/issues/1982","repository_url":"https://api.github.com/repos/brave/brave-core","labels_url":"https://api.github.com/repos/brave/brave-core/issues/1982/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/1982/comments","events_url":"https://api.github.com/repos/brave/brave-core/issues/1982/events","html_url":"https://github.com/brave/brave-core/pull/1982","id":421798653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxNzY2NzA4","number":1982,"title":"Non-referral downloads should use generic refcode","user":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"assignees":[{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-03-16T11:40:56Z","updated_at":"2019-03-16T11:45:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/1982","html_url":"https://github.com/brave/brave-core/pull/1982","diff_url":"https://github.com/brave/brave-core/pull/1982.diff","patch_url":"https://github.com/brave/brave-core/pull/1982.patch"},"body":"Fixes brave/brave-browser#2547\r\n\r\n## Submitter Checklist:\r\n\r\n- [ ] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- Verified that these changes build without errors on\r\n  - [ ] Windows\r\n  - [ ] macOS\r\n  - [ ] Linux\r\n- Verified that these changes pass automated tests (`npm test brave_unit_tests && npm test brave_browser_tests`) on\r\n  - [ ] Windows\r\n  - [ ] macOS\r\n  - [ ] Linux\r\n- [ ] Verified that all lint errors/warnings are resolved (`npm run lint`)\r\n- [ ] Ran `git rebase master` (if needed).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone\r\n\r\n## Test Plan:\r\n\r\n- Download a non-referral stub installer (i.e., no referral code embedded in its filename)\r\n- Delete existing profile\r\n- Run the installer\r\n- After the installer completes, launch Brave and wait ~10 seconds\r\n- Confirm that `Local State` file (e.g., `/c/Users/emerick/AppData/Local/BraveSoftware/Brave-Browser-Development/User Data/Local State`) contains `\"promo_code\":\"BRV001\"` entry\r\n- Confirm with server team that daily ping for this run looked similar to this (in particular, `ref` is `BRV001`):\r\n\r\n    `https://laptop-updates.brave.com/1/usage/brave-core?platform=winx64-bc&channel=release&version=0.64.4&daily=true&weekly=true&monthly=true&first=true&w oi=2019-03-11&ref=BRV001`\r\n\r\n- Should also confirm that regular referral downloads continue to work as normal\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions \r\n- [ ] Verify test plan is specified in PR before merging to source\r\n"},"comment":{"url":"https://api.github.com/repos/brave/brave-core/issues/comments/473523091","html_url":"https://github.com/brave/brave-core/pull/1982#issuecomment-473523091","issue_url":"https://api.github.com/repos/brave/brave-core/issues/1982","id":473523091,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MzUyMzA5MQ==","user":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"created_at":"2019-03-16T11:45:19Z","updated_at":"2019-03-16T11:45:19Z","author_association":"CONTRIBUTOR","body":"@bbondy Two things to note here:\r\n\r\n1. The default referral code will revert to `none` 90 days after first run, just like normal referral codes.\r\n1. Since the referral code check is only performed on first run after install, pre-existing non-referral installations will continue to send `none`.\r\n\r\nMy reading of brave/brave-browser#2547 is that this is the expected/intended behavior, but if not please let me know!"}}
other: {"actor":{"display_login":"emerick"}}