payload: {"action":"created","issue":{"url":"https://api.github.com/repos/root-project/root/issues/4072","repository_url":"https://api.github.com/repos/root-project/root","labels_url":"https://api.github.com/repos/root-project/root/issues/4072/labels{/name}","comments_url":"https://api.github.com/repos/root-project/root/issues/4072/comments","events_url":"https://api.github.com/repos/root-project/root/issues/4072/events","html_url":"https://github.com/root-project/root/pull/4072","id":466317130,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MTc5Njcx","number":4072,"title":"[Exp PyROOT] Fixed 'tutorial-math-Legendre-py' test","user":{"login":"maxgalli","id":26309531,"node_id":"MDQ6VXNlcjI2MzA5NTMx","avatar_url":"https://avatars1.githubusercontent.com/u/26309531?v=4","gravatar_id":"","url":"https://api.github.com/users/maxgalli","html_url":"https://github.com/maxgalli","followers_url":"https://api.github.com/users/maxgalli/followers","following_url":"https://api.github.com/users/maxgalli/following{/other_user}","gists_url":"https://api.github.com/users/maxgalli/gists{/gist_id}","starred_url":"https://api.github.com/users/maxgalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxgalli/subscriptions","organizations_url":"https://api.github.com/users/maxgalli/orgs","repos_url":"https://api.github.com/users/maxgalli/repos","events_url":"https://api.github.com/users/maxgalli/events{/privacy}","received_events_url":"https://api.github.com/users/maxgalli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"etejedor","id":8089558,"node_id":"MDQ6VXNlcjgwODk1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8089558?v=4","gravatar_id":"","url":"https://api.github.com/users/etejedor","html_url":"https://github.com/etejedor","followers_url":"https://api.github.com/users/etejedor/followers","following_url":"https://api.github.com/users/etejedor/following{/other_user}","gists_url":"https://api.github.com/users/etejedor/gists{/gist_id}","starred_url":"https://api.github.com/users/etejedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etejedor/subscriptions","organizations_url":"https://api.github.com/users/etejedor/orgs","repos_url":"https://api.github.com/users/etejedor/repos","events_url":"https://api.github.com/users/etejedor/events{/privacy}","received_events_url":"https://api.github.com/users/etejedor/received_events","type":"User","site_admin":false},"assignees":[{"login":"etejedor","id":8089558,"node_id":"MDQ6VXNlcjgwODk1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8089558?v=4","gravatar_id":"","url":"https://api.github.com/users/etejedor","html_url":"https://github.com/etejedor","followers_url":"https://api.github.com/users/etejedor/followers","following_url":"https://api.github.com/users/etejedor/following{/other_user}","gists_url":"https://api.github.com/users/etejedor/gists{/gist_id}","starred_url":"https://api.github.com/users/etejedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etejedor/subscriptions","organizations_url":"https://api.github.com/users/etejedor/orgs","repos_url":"https://api.github.com/users/etejedor/repos","events_url":"https://api.github.com/users/etejedor/events{/privacy}","received_events_url":"https://api.github.com/users/etejedor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-07-10T13:42:14Z","updated_at":"2019-07-11T08:30:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/4072","html_url":"https://github.com/root-project/root/pull/4072","diff_url":"https://github.com/root-project/root/pull/4072.diff","patch_url":"https://github.com/root-project/root/pull/4072.patch"},"body":"The test mentioned above was rewritten in order to pass in Experimental PyROOT.\r\nWhat made the test passing in the current PyROOT and failing in the Experimental one is the absence in Cppyy of a converter function which works with Python objects of type NoneType and is fired in lines like the following:\r\n`leg.AddEntry(L[0].Draw(), \" L_{0}(x)\", \"l\")`\r\nThe presence of this function basically splits the above command like the following: \r\n1. the function is drawn on the canvas with the command\r\n`L[0].Draw()`\r\n2. the entry is added to the legend with the command\r\n`leg.AddEntry(None, \" L_{0}(x)\", \"l\")`\r\nSince it's also conceptually wrong to put the Draw() method as argument of the AddEntry function, it was decided to do the two things separately with a loop over the elements of the L list."},"comment":{"url":"https://api.github.com/repos/root-project/root/issues/comments/510387148","html_url":"https://github.com/root-project/root/pull/4072#issuecomment-510387148","issue_url":"https://api.github.com/repos/root-project/root/issues/4072","id":510387148,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMDM4NzE0OA==","user":{"login":"etejedor","id":8089558,"node_id":"MDQ6VXNlcjgwODk1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8089558?v=4","gravatar_id":"","url":"https://api.github.com/users/etejedor","html_url":"https://github.com/etejedor","followers_url":"https://api.github.com/users/etejedor/followers","following_url":"https://api.github.com/users/etejedor/following{/other_user}","gists_url":"https://api.github.com/users/etejedor/gists{/gist_id}","starred_url":"https://api.github.com/users/etejedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etejedor/subscriptions","organizations_url":"https://api.github.com/users/etejedor/orgs","repos_url":"https://api.github.com/users/etejedor/repos","events_url":"https://api.github.com/users/etejedor/events{/privacy}","received_events_url":"https://api.github.com/users/etejedor/received_events","type":"User","site_admin":false},"created_at":"2019-07-11T08:30:34Z","updated_at":"2019-07-11T08:30:34Z","author_association":"CONTRIBUTOR","body":"Just to add on what @maxgalli said, the current PyROOT allows the conversion from Python `None` to C++ null pointer:\r\nhttps://github.com/root-project/root/blob/master/bindings/pyroot/src/Converters.cxx#L676\r\nSuch conversion does not exist in the new Cppyy.\r\n\r\nAnyway, the tutorial should not pass `None` (or null ptr) as the first argument of `AddEntry`, but the function object that is drawn. In the C++ equivalent of the tutorial, this is done by passing the result of `DrawCopy` to `AddEntry`."}}
other: {"actor":{"display_login":"etejedor"}}