payload: {"action":"created","issue":{"url":"https://api.github.com/repos/JavaMoney/jsr354-api/issues/122","repository_url":"https://api.github.com/repos/JavaMoney/jsr354-api","labels_url":"https://api.github.com/repos/JavaMoney/jsr354-api/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/JavaMoney/jsr354-api/issues/122/comments","events_url":"https://api.github.com/repos/JavaMoney/jsr354-api/issues/122/events","html_url":"https://github.com/JavaMoney/jsr354-api/pull/122","id":473680848,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNzg3NTgw","number":122,"title":"Switch build to OpenJDK 11","user":{"login":"marschall","id":471021,"node_id":"MDQ6VXNlcjQ3MTAyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/471021?v=4","gravatar_id":"","url":"https://api.github.com/users/marschall","html_url":"https://github.com/marschall","followers_url":"https://api.github.com/users/marschall/followers","following_url":"https://api.github.com/users/marschall/following{/other_user}","gists_url":"https://api.github.com/users/marschall/gists{/gist_id}","starred_url":"https://api.github.com/users/marschall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marschall/subscriptions","organizations_url":"https://api.github.com/users/marschall/orgs","repos_url":"https://api.github.com/users/marschall/repos","events_url":"https://api.github.com/users/marschall/events{/privacy}","received_events_url":"https://api.github.com/users/marschall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2019-07-27T21:48:49Z","updated_at":"2019-07-28T14:24:48Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/JavaMoney/jsr354-api/pulls/122","html_url":"https://github.com/JavaMoney/jsr354-api/pull/122","diff_url":"https://github.com/JavaMoney/jsr354-api/pull/122.diff","patch_url":"https://github.com/JavaMoney/jsr354-api/pull/122.patch"},"body":"Java 9 is EoL which causes some builds to fail like #121.\r\nJava 11 is the current LTS however Oracle no longer provides updates\r\nfor their OpenJDK 11 builds and Oracle JDK 11 has an OTN license.\r\nThis makes openjdk11 currently the best option for TravisCI.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/javamoney/jsr354-api/122)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/JavaMoney/jsr354-api/issues/comments/515767067","html_url":"https://github.com/JavaMoney/jsr354-api/pull/122#issuecomment-515767067","issue_url":"https://api.github.com/repos/JavaMoney/jsr354-api/issues/122","id":515767067,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNTc2NzA2Nw==","user":{"login":"marschall","id":471021,"node_id":"MDQ6VXNlcjQ3MTAyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/471021?v=4","gravatar_id":"","url":"https://api.github.com/users/marschall","html_url":"https://github.com/marschall","followers_url":"https://api.github.com/users/marschall/followers","following_url":"https://api.github.com/users/marschall/following{/other_user}","gists_url":"https://api.github.com/users/marschall/gists{/gist_id}","starred_url":"https://api.github.com/users/marschall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marschall/subscriptions","organizations_url":"https://api.github.com/users/marschall/orgs","repos_url":"https://api.github.com/users/marschall/repos","events_url":"https://api.github.com/users/marschall/events{/privacy}","received_events_url":"https://api.github.com/users/marschall/received_events","type":"User","site_admin":false},"created_at":"2019-07-28T14:24:48Z","updated_at":"2019-07-28T14:24:48Z","author_association":"MEMBER","body":"> > But we currently do not build with 8, we only build with 9. Well we try to, the builds fail.\r\n> \r\n> I'm not 100% sure but I clearly remember that I used JavaMoney on a project with JDK8. That means that we use JDK9 but we compile everything to 8 bytecode.\r\n\r\nYes we do. All this PR does is use JDK 11 instead of JDK 9 to compile Java 8 byte code. Also it changes to JDK 11 to run the tests instead of JDK 9. It is not my intention to require Java 11 for users. \r\nJust to iterate this PR will have no affect for users on Java 8 or 11. The only thing changing is we use JDK 11 for compiling and testing, the bytecode will remain as is, Java 8 compatible and not using any Java 11 classes, method or features. The artifact will remain Java 8 compatible."}}
other: {"actor":{"display_login":"marschall"}}