payload: {"action":"created","issue":{"url":"https://api.github.com/repos/European-XFEL/karabo_data/issues/158","repository_url":"https://api.github.com/repos/European-XFEL/karabo_data","labels_url":"https://api.github.com/repos/European-XFEL/karabo_data/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/European-XFEL/karabo_data/issues/158/comments","events_url":"https://api.github.com/repos/European-XFEL/karabo_data/issues/158/events","html_url":"https://github.com/European-XFEL/karabo_data/issues/158","id":442812796,"node_id":"MDU6SXNzdWU0NDI4MTI3OTY=","number":158,"title":"Investigate using scipy map_coordinates() to interpolate data onto a regular grid","user":{"login":"takluyver","id":327925,"node_id":"MDQ6VXNlcjMyNzkyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/327925?v=4","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-05-10T17:05:38Z","updated_at":"2019-05-13T08:54:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I think it might be possible to make the image assembly with interpolation more efficient by using [map_coordinates()](https://docs.scipy.org/doc/scipy/reference/generated/scipy.ndimage.map_coordinates.html) in place of [affine_transform()](https://docs.scipy.org/doc/scipy/reference/generated/scipy.ndimage.affine_transform.html).\r\n\r\nThe idea is to require less work for each frame: we can compute the mapping from output coordinates to input coordinates once and reuse it for each frame.\r\n\r\nAlso, the current implementation positions each tile in a separate layer, and then use `numpy.nanmax()` to flatten the 128 layers into a single 2D image. The intermediate array containing the layers is hundreds of MB. I think it should be possible to position all the tiles directly to a 2D array in a single call. We'll need to take care that it doesn't interpolate between pixels which are adjacent in data but not in physical space."},"comment":{"url":"https://api.github.com/repos/European-XFEL/karabo_data/issues/comments/491735948","html_url":"https://github.com/European-XFEL/karabo_data/issues/158#issuecomment-491735948","issue_url":"https://api.github.com/repos/European-XFEL/karabo_data/issues/158","id":491735948,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MTczNTk0OA==","user":{"login":"takluyver","id":327925,"node_id":"MDQ6VXNlcjMyNzkyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/327925?v=4","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"created_at":"2019-05-13T08:54:03Z","updated_at":"2019-05-13T08:54:03Z","author_association":"CONTRIBUTOR","body":"Feel free to investigate it! But I'd be surprised if Scipy was leaving significant performance improvements on the table for no good reason, so I'd guess that anything significantly faster would come with some kind of trade-off, and it would be useful to know what that is."}}
other: {"actor":{"display_login":"takluyver"}}