payload: {"action":"created","issue":{"url":"https://api.github.com/repos/monero-project/monero/issues/6015","repository_url":"https://api.github.com/repos/monero-project/monero","labels_url":"https://api.github.com/repos/monero-project/monero/issues/6015/labels{/name}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/6015/comments","events_url":"https://api.github.com/repos/monero-project/monero/issues/6015/events","html_url":"https://github.com/monero-project/monero/pull/6015","id":511608199,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxNzc1MjA2","number":6015,"title":"cmake: Fix generation of version.cpp","user":{"login":"ndorf","id":5393543,"node_id":"MDQ6VXNlcjUzOTM1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5393543?v=4","gravatar_id":"","url":"https://api.github.com/users/ndorf","html_url":"https://github.com/ndorf","followers_url":"https://api.github.com/users/ndorf/followers","following_url":"https://api.github.com/users/ndorf/following{/other_user}","gists_url":"https://api.github.com/users/ndorf/gists{/gist_id}","starred_url":"https://api.github.com/users/ndorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndorf/subscriptions","organizations_url":"https://api.github.com/users/ndorf/orgs","repos_url":"https://api.github.com/users/ndorf/repos","events_url":"https://api.github.com/users/ndorf/events{/privacy}","received_events_url":"https://api.github.com/users/ndorf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-10-23T22:38:57Z","updated_at":"2019-10-29T17:44:25Z","closed_at":"2019-10-24T23:39:16Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/6015","html_url":"https://github.com/monero-project/monero/pull/6015","diff_url":"https://github.com/monero-project/monero/pull/6015.diff","patch_url":"https://github.com/monero-project/monero/pull/6015.patch"},"body":"This fixes #6012 and seems to work correctly in all cases. The file is regenerated if and only if the version tag changes (or the input file does). In particular:\r\n\r\n1) Nothing is regenerated or rebuilt if nothing changes in the source tree\r\n2) After `git commit --allow-empty -m 'whatever'`, the version file is regenerated and built, and the executables quickly relinked, with no unexpected other targets being built. The new executables report the correct new version hash.\r\n3) Modifying the input file `src/version.cpp.in` or deleting the output file `build/.../version.cpp` causes the file to be regenerated with no unexpected errors.\r\n\r\nAdditionally, since 33e91e1a1e94c2957f59def9fe49f75956a9f699, I don't think the two cases not using GenVersion.cmake could have worked -- they don't set `VERSION_IS_RELEASE`, without which the generated version.cpp fails to compile (empty space after the bool assignment). That should also be fixed here."},"comment":{"url":"https://api.github.com/repos/monero-project/monero/issues/comments/547546689","html_url":"https://github.com/monero-project/monero/pull/6015#issuecomment-547546689","issue_url":"https://api.github.com/repos/monero-project/monero/issues/6015","id":547546689,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzU0NjY4OQ==","user":{"login":"ndorf","id":5393543,"node_id":"MDQ6VXNlcjUzOTM1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5393543?v=4","gravatar_id":"","url":"https://api.github.com/users/ndorf","html_url":"https://github.com/ndorf","followers_url":"https://api.github.com/users/ndorf/followers","following_url":"https://api.github.com/users/ndorf/following{/other_user}","gists_url":"https://api.github.com/users/ndorf/gists{/gist_id}","starred_url":"https://api.github.com/users/ndorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndorf/subscriptions","organizations_url":"https://api.github.com/users/ndorf/orgs","repos_url":"https://api.github.com/users/ndorf/repos","events_url":"https://api.github.com/users/ndorf/events{/privacy}","received_events_url":"https://api.github.com/users/ndorf/received_events","type":"User","site_admin":false},"created_at":"2019-10-29T17:44:25Z","updated_at":"2019-10-29T17:44:25Z","author_association":"CONTRIBUTOR","body":"Thanks for the fix @trasherdk , sorry I didn't think to test that case."}}
other: {"actor":{"display_login":"ndorf"}}