payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/AssemblyScript/assemblyscript/issues/819","repository_url":"https://api.github.com/repos/AssemblyScript/assemblyscript","labels_url":"https://api.github.com/repos/AssemblyScript/assemblyscript/issues/819/labels{/name}","comments_url":"https://api.github.com/repos/AssemblyScript/assemblyscript/issues/819/comments","events_url":"https://api.github.com/repos/AssemblyScript/assemblyscript/issues/819/events","html_url":"https://github.com/AssemblyScript/assemblyscript/issues/819","id":489881796,"node_id":"MDU6SXNzdWU0ODk4ODE3OTY=","number":819,"title":"[Tests] Need improve custom rule for allowing skip return type declaration for callbacks","user":{"login":"MaxGraey","id":1301959,"node_id":"MDQ6VXNlcjEzMDE5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1301959?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGraey","html_url":"https://github.com/MaxGraey","followers_url":"https://api.github.com/users/MaxGraey/followers","following_url":"https://api.github.com/users/MaxGraey/following{/other_user}","gists_url":"https://api.github.com/users/MaxGraey/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGraey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGraey/subscriptions","organizations_url":"https://api.github.com/users/MaxGraey/orgs","repos_url":"https://api.github.com/users/MaxGraey/repos","events_url":"https://api.github.com/users/MaxGraey/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGraey/received_events","type":"User","site_admin":false},"labels":[{"id":705344993,"node_id":"MDU6TGFiZWw3MDUzNDQ5OTM=","url":"https://api.github.com/repos/AssemblyScript/assemblyscript/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":705344995,"node_id":"MDU6TGFiZWw3MDUzNDQ5OTU=","url":"https://api.github.com/repos/AssemblyScript/assemblyscript/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-09-05T16:51:21Z","updated_at":"2019-09-29T17:13:43Z","closed_at":"2019-09-29T17:13:43Z","author_association":"MEMBER","body":"Will be great write this for internal tests:\r\n```ts\r\nvar result = source.filter(value => value > 2); // linter with custom rule not happy currently\r\n```\r\ninstead:\r\n```ts\r\nvar result = source.filter((value: i32): bool => value > 2);\r\n```\r\n\r\nCode part in [`\"lib/lint/src/rules/asTypeRule.ts\"`](https://github.com/AssemblyScript/assemblyscript/blob/master/lib/lint/src/rules/asTypesRule.ts#L48) which should be changed:\r\n```ts\r\n...\r\n  visitArrowFunction(node: ts.ArrowFunction) {\r\n    this.checkFunctionReturnType(node);\r\n    super.visitArrowFunction(node);\r\n  }\r\n...\r\n```\r\n\r\nBut still guard for return type for rest cases"}}
other: {"actor":{"display_login":"dcodeIO"}}