payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/254918329","pull_request_review_id":201386599,"id":254918329,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDkxODMyOQ==","diff_hunk":"@@ -1,5 +1,7 @@\n @if not defined DEBUG_HELPER @ECHO OFF\n \n+setlocal","path":"vcbuild.bat","position":3,"original_position":3,"commit_id":"623ec643b1a708bad1da9f293cbe933b10b71be1","original_commit_id":"623ec643b1a708bad1da9f293cbe933b10b71be1","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"body":"> Would it make sense to replace this line with\r\n\r\nGood idea.\r\nI'd suggest:\r\n```cmd\r\n:: Other scripts rely on the environment variables set in this script. So we explicitly allow them to escape.\r\nendlocal\r\n```\r\n","created_at":"2019-02-08T00:19:58Z","updated_at":"2019-02-08T00:19:58Z","html_url":"https://github.com/nodejs/node/pull/25994#discussion_r254918329","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/25994","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/254918329"},"html":{"href":"https://github.com/nodejs/node/pull/25994#discussion_r254918329"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/25994"}},"in_reply_to_id":254865559},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/25994","id":251262341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMjYyMzQx","html_url":"https://github.com/nodejs/node/pull/25994","diff_url":"https://github.com/nodejs/node/pull/25994.diff","patch_url":"https://github.com/nodejs/node/pull/25994.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/25994","number":25994,"state":"open","locked":false,"title":"win, build: add 'verbose' mode and scope environment changes","user":{"login":"jkunkee","id":653553,"node_id":"MDQ6VXNlcjY1MzU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/653553?v=4","gravatar_id":"","url":"https://api.github.com/users/jkunkee","html_url":"https://github.com/jkunkee","followers_url":"https://api.github.com/users/jkunkee/followers","following_url":"https://api.github.com/users/jkunkee/following{/other_user}","gists_url":"https://api.github.com/users/jkunkee/gists{/gist_id}","starred_url":"https://api.github.com/users/jkunkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkunkee/subscriptions","organizations_url":"https://api.github.com/users/jkunkee/orgs","repos_url":"https://api.github.com/users/jkunkee/repos","events_url":"https://api.github.com/users/jkunkee/events{/privacy}","received_events_url":"https://api.github.com/users/jkunkee/received_events","type":"User","site_admin":false},"body":"This commit adds a 'verbose' flag to vcbuild.bat that turns on outputs\r\nuseful for build debugging, including MSBuild BinLogging and\r\nDEBUG_HELPER logging.\r\n\r\nIt also adds a 'setlocal' call so internal environment variables no\r\nlonger leak out to the calling shell.\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n    - n/a\r\n- [ ] documentation is changed or added\r\n    - n/a\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2019-02-07T20:44:28Z","updated_at":"2019-02-08T00:19:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"531317ab83f10654add28b3f5ee63d5b779d3ef7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":166236401,"node_id":"MDU6TGFiZWwxNjYyMzY0MDE=","url":"https://api.github.com/repos/nodejs/node/labels/windows","name":"windows","color":"9944dd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/25994/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/25994/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/25994/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/623ec643b1a708bad1da9f293cbe933b10b71be1","head":{"label":"jkunkee:win-build-script-tweaks","ref":"win-build-script-tweaks","sha":"623ec643b1a708bad1da9f293cbe933b10b71be1","user":{"login":"jkunkee","id":653553,"node_id":"MDQ6VXNlcjY1MzU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/653553?v=4","gravatar_id":"","url":"https://api.github.com/users/jkunkee","html_url":"https://github.com/jkunkee","followers_url":"https://api.github.com/users/jkunkee/followers","following_url":"https://api.github.com/users/jkunkee/following{/other_user}","gists_url":"https://api.github.com/users/jkunkee/gists{/gist_id}","starred_url":"https://api.github.com/users/jkunkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkunkee/subscriptions","organizations_url":"https://api.github.com/users/jkunkee/orgs","repos_url":"https://api.github.com/users/jkunkee/repos","events_url":"https://api.github.com/users/jkunkee/events{/privacy}","received_events_url":"https://api.github.com/users/jkunkee/received_events","type":"User","site_admin":false},"repo":{"id":169486653,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0ODY2NTM=","name":"node","full_name":"jkunkee/node","private":false,"owner":{"login":"jkunkee","id":653553,"node_id":"MDQ6VXNlcjY1MzU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/653553?v=4","gravatar_id":"","url":"https://api.github.com/users/jkunkee","html_url":"https://github.com/jkunkee","followers_url":"https://api.github.com/users/jkunkee/followers","following_url":"https://api.github.com/users/jkunkee/following{/other_user}","gists_url":"https://api.github.com/users/jkunkee/gists{/gist_id}","starred_url":"https://api.github.com/users/jkunkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkunkee/subscriptions","organizations_url":"https://api.github.com/users/jkunkee/orgs","repos_url":"https://api.github.com/users/jkunkee/repos","events_url":"https://api.github.com/users/jkunkee/events{/privacy}","received_events_url":"https://api.github.com/users/jkunkee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jkunkee/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/jkunkee/node","forks_url":"https://api.github.com/repos/jkunkee/node/forks","keys_url":"https://api.github.com/repos/jkunkee/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkunkee/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkunkee/node/teams","hooks_url":"https://api.github.com/repos/jkunkee/node/hooks","issue_events_url":"https://api.github.com/repos/jkunkee/node/issues/events{/number}","events_url":"https://api.github.com/repos/jkunkee/node/events","assignees_url":"https://api.github.com/repos/jkunkee/node/assignees{/user}","branches_url":"https://api.github.com/repos/jkunkee/node/branches{/branch}","tags_url":"https://api.github.com/repos/jkunkee/node/tags","blobs_url":"https://api.github.com/repos/jkunkee/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkunkee/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkunkee/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkunkee/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkunkee/node/statuses/{sha}","languages_url":"https://api.github.com/repos/jkunkee/node/languages","stargazers_url":"https://api.github.com/repos/jkunkee/node/stargazers","contributors_url":"https://api.github.com/repos/jkunkee/node/contributors","subscribers_url":"https://api.github.com/repos/jkunkee/node/subscribers","subscription_url":"https://api.github.com/repos/jkunkee/node/subscription","commits_url":"https://api.github.com/repos/jkunkee/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkunkee/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkunkee/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkunkee/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkunkee/node/contents/{+path}","compare_url":"https://api.github.com/repos/jkunkee/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkunkee/node/merges","archive_url":"https://api.github.com/repos/jkunkee/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkunkee/node/downloads","issues_url":"https://api.github.com/repos/jkunkee/node/issues{/number}","pulls_url":"https://api.github.com/repos/jkunkee/node/pulls{/number}","milestones_url":"https://api.github.com/repos/jkunkee/node/milestones{/number}","notifications_url":"https://api.github.com/repos/jkunkee/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkunkee/node/labels{/name}","releases_url":"https://api.github.com/repos/jkunkee/node/releases{/id}","deployments_url":"https://api.github.com/repos/jkunkee/node/deployments","created_at":"2019-02-06T22:28:37Z","updated_at":"2019-02-06T22:29:12Z","pushed_at":"2019-02-07T23:24:44Z","git_url":"git://github.com/jkunkee/node.git","ssh_url":"git@github.com:jkunkee/node.git","clone_url":"https://github.com/jkunkee/node.git","svn_url":"https://github.com/jkunkee/node","homepage":"https://nodejs.org","size":453714,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"b4e670dc26b50271457a257ccb244b14ff323b64","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2019-02-08T00:11:08Z","pushed_at":"2019-02-08T00:10:15Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":452245,"stargazers_count":57976,"watchers_count":57976,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12832,"mirror_url":null,"archived":false,"open_issues_count":830,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12832,"open_issues":830,"watchers":57976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/25994"},"html":{"href":"https://github.com/nodejs/node/pull/25994"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/25994"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/25994/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/25994/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/25994/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/623ec643b1a708bad1da9f293cbe933b10b71be1"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"refack"}}