payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/316042110","pull_request_review_id":277613665,"id":316042110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjA0MjExMA==","diff_hunk":"@@ -390,7 +390,7 @@ func New(code string) (*Tracer, error) {\n \t\treturn 1\n \t})\n \ttracer.vm.PushGlobalGoFunction(\"isPrecompiled\", func(ctx *duktape.Context) int {\n-\t\t_, ok := vm.PrecompiledContractsByzantium[common.BytesToAddress(popSlice(ctx))]\n+\t\t_, ok := vm.PrecompiledContractsIstanbul[common.BytesToAddress(popSlice(ctx))]","path":"eth/tracers/tracer.go","position":5,"original_position":5,"commit_id":"e5bdb968848d33919b4aef3750be74c6ab85ecc4","original_commit_id":"e5bdb968848d33919b4aef3750be74c6ab85ecc4","user":{"login":"holiman","id":142290,"node_id":"MDQ6VXNlcjE0MjI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/142290?v=4","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"body":"I think that is an ok change. This adds a helper-method to the js-environment, and it is obviously already not quite correct (if executed pre-byzantium). This change does not really make it a lot more incorrect. \r\nA proper fix would be to look at the block number and chain config, but those are not accessible at this point, so would need a refactor which it out of scope for this PR, imo.  ","created_at":"2019-08-21T07:51:46Z","updated_at":"2019-08-21T07:51:46Z","html_url":"https://github.com/ethereum/go-ethereum/pull/19972#discussion_r316042110","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/316042110"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/19972#discussion_r316042110"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972"}},"in_reply_to_id":315597097},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972","id":308087149,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MDg3MTQ5","html_url":"https://github.com/ethereum/go-ethereum/pull/19972","diff_url":"https://github.com/ethereum/go-ethereum/pull/19972.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/19972.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/19972","number":19972,"state":"open","locked":false,"title":"BLAKE2b F compression function precompile","user":{"login":"pdyraga","id":4712360,"node_id":"MDQ6VXNlcjQ3MTIzNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/4712360?v=4","gravatar_id":"","url":"https://api.github.com/users/pdyraga","html_url":"https://github.com/pdyraga","followers_url":"https://api.github.com/users/pdyraga/followers","following_url":"https://api.github.com/users/pdyraga/following{/other_user}","gists_url":"https://api.github.com/users/pdyraga/gists{/gist_id}","starred_url":"https://api.github.com/users/pdyraga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdyraga/subscriptions","organizations_url":"https://api.github.com/users/pdyraga/orgs","repos_url":"https://api.github.com/users/pdyraga/repos","events_url":"https://api.github.com/users/pdyraga/events{/privacy}","received_events_url":"https://api.github.com/users/pdyraga/received_events","type":"User","site_admin":false},"body":"The precompile at `0x09` wraps the BLAKE2b F compression function:\r\nhttps://tools.ietf.org/html/rfc7693#section-3.2\r\n\r\nThe precompile requires 6 inputs tightly encoded, taking exactly 213 bytes, as explained below.\r\n\r\n- `rounds` - the number of rounds - 32-bit unsigned big-endian word\r\n- `h` - the state vector - 8 unsigned 64-bit little-endian words\r\n- `m` - the message block vector - 16 unsigned 64-bit little-endian words\r\n- `t_0, t_1` - offset counters - 2 unsigned 64-bit little-endian words\r\n- `f` - the final block indicator flag - 8-bit word\r\n\r\n```\r\n[4 bytes for rounds][64 bytes for h][128 bytes for m][8 bytes for t_0] \\\r\n[8 bytes for t_1][1 byte for f]\r\n```\r\n\r\nThe boolean `f` parameter is considered as `true` if set to `1`.\r\nThe boolean `f` parameter is considered as `false` if set to `0`.\r\nAll other values yield an invalid encoding of `f` error.\r\n\r\nThe precompile should compute the F function as specified in the RFC\r\n(https://tools.ietf.org/html/rfc7693#section-3.2) and return the updated\r\nstate vector `h` with unchanged encoding (little-endian).\r\n\r\nSee [EIP-152](https://github.com/ethereum/EIPs/pull/2129) for details.","created_at":"2019-08-16T14:00:09Z","updated_at":"2019-08-21T07:51:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b13440b0a16f359546e71ff82ecd5da83fb6570e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"holiman","id":142290,"node_id":"MDQ6VXNlcjE0MjI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/142290?v=4","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},{"login":"rjl493456442","id":5959481,"node_id":"MDQ6VXNlcjU5NTk0ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1360996892,"node_id":"MDU6TGFiZWwxMzYwOTk2ODky","url":"https://api.github.com/repos/ethereum/go-ethereum/labels/istanbul","name":"istanbul","color":"aaf796","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/19972/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/e5bdb968848d33919b4aef3750be74c6ab85ecc4","head":{"label":"keep-network:istanbul-eip-152-blake2b-f-precompile","ref":"istanbul-eip-152-blake2b-f-precompile","sha":"e5bdb968848d33919b4aef3750be74c6ab85ecc4","user":{"login":"keep-network","id":30537626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTM3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/30537626?v=4","gravatar_id":"","url":"https://api.github.com/users/keep-network","html_url":"https://github.com/keep-network","followers_url":"https://api.github.com/users/keep-network/followers","following_url":"https://api.github.com/users/keep-network/following{/other_user}","gists_url":"https://api.github.com/users/keep-network/gists{/gist_id}","starred_url":"https://api.github.com/users/keep-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keep-network/subscriptions","organizations_url":"https://api.github.com/users/keep-network/orgs","repos_url":"https://api.github.com/users/keep-network/repos","events_url":"https://api.github.com/users/keep-network/events{/privacy}","received_events_url":"https://api.github.com/users/keep-network/received_events","type":"Organization","site_admin":false},"repo":{"id":127683917,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2ODM5MTc=","name":"go-ethereum","full_name":"keep-network/go-ethereum","private":false,"owner":{"login":"keep-network","id":30537626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTM3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/30537626?v=4","gravatar_id":"","url":"https://api.github.com/users/keep-network","html_url":"https://github.com/keep-network","followers_url":"https://api.github.com/users/keep-network/followers","following_url":"https://api.github.com/users/keep-network/following{/other_user}","gists_url":"https://api.github.com/users/keep-network/gists{/gist_id}","starred_url":"https://api.github.com/users/keep-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keep-network/subscriptions","organizations_url":"https://api.github.com/users/keep-network/orgs","repos_url":"https://api.github.com/users/keep-network/repos","events_url":"https://api.github.com/users/keep-network/events{/privacy}","received_events_url":"https://api.github.com/users/keep-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keep-network/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/keep-network/go-ethereum","forks_url":"https://api.github.com/repos/keep-network/go-ethereum/forks","keys_url":"https://api.github.com/repos/keep-network/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keep-network/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keep-network/go-ethereum/teams","hooks_url":"https://api.github.com/repos/keep-network/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/keep-network/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/keep-network/go-ethereum/events","assignees_url":"https://api.github.com/repos/keep-network/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/keep-network/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/keep-network/go-ethereum/tags","blobs_url":"https://api.github.com/repos/keep-network/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keep-network/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keep-network/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/keep-network/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keep-network/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/keep-network/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/keep-network/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/keep-network/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/keep-network/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/keep-network/go-ethereum/subscription","commits_url":"https://api.github.com/repos/keep-network/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/keep-network/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/keep-network/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/keep-network/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/keep-network/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/keep-network/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keep-network/go-ethereum/merges","archive_url":"https://api.github.com/repos/keep-network/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keep-network/go-ethereum/downloads","issues_url":"https://api.github.com/repos/keep-network/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/keep-network/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/keep-network/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/keep-network/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keep-network/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/keep-network/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/keep-network/go-ethereum/deployments","created_at":"2018-04-02T00:49:54Z","updated_at":"2019-07-30T18:30:48Z","pushed_at":"2019-08-20T09:36:28Z","git_url":"git://github.com/keep-network/go-ethereum.git","ssh_url":"git@github.com:keep-network/go-ethereum.git","clone_url":"https://github.com/keep-network/go-ethereum.git","svn_url":"https://github.com/keep-network/go-ethereum","homepage":"https://geth.ethereum.org","size":135376,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"039a9c36226eafaf07942ecfb6082a90945ea86a","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MjkxOQ==","name":"go-ethereum","full_name":"ethereum/go-ethereum","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2019-08-21T07:17:26Z","pushed_at":"2019-08-21T07:17:20Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":133051,"stargazers_count":24090,"watchers_count":24090,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8666,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":468,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":8666,"open_issues":468,"watchers":24090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/19972"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/19972"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/19972/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/19972/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/e5bdb968848d33919b4aef3750be74c6ab85ecc4"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"holiman"}}