payload: {"action":"created","issue":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6908","repository_url":"https://api.github.com/repos/rubocop-hq/rubocop","labels_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6908/labels{/name}","comments_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6908/comments","events_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6908/events","html_url":"https://github.com/rubocop-hq/rubocop/pull/6908","id":430556787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4NDE4NTEw","number":6908,"title":"[Fix #6893] FIX bug with splat or methods exceptions on `RescuedExceptionsVariableName`","user":{"login":"anthony-robin","id":5428510,"node_id":"MDQ6VXNlcjU0Mjg1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5428510?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-robin","html_url":"https://github.com/anthony-robin","followers_url":"https://api.github.com/users/anthony-robin/followers","following_url":"https://api.github.com/users/anthony-robin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-robin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-robin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-robin/subscriptions","organizations_url":"https://api.github.com/users/anthony-robin/orgs","repos_url":"https://api.github.com/users/anthony-robin/repos","events_url":"https://api.github.com/users/anthony-robin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-robin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-04-08T16:56:41Z","updated_at":"2019-04-20T07:52:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6908","html_url":"https://github.com/rubocop-hq/rubocop/pull/6908","diff_url":"https://github.com/rubocop-hq/rubocop/pull/6908.diff","patch_url":"https://github.com/rubocop-hq/rubocop/pull/6908.patch"},"body":"This PR makes the `Naming/RescuedExceptionsVariableName` cop to play friendly\r\nwith exceptions listed using the splat operator or calling a method on a class.\r\n\r\n```ruby\r\nhandled = [StandardError]\r\n\r\nbegin\r\n  something\r\nrescue *handled\r\n  # do something\r\nend\r\n```\r\n\r\n```ruby\r\nbegin\r\n  something\r\nrescue ActiveSupport::JSON.my_method\r\n  # do something\r\nend\r\n```\r\n\r\nFix #6893\r\nFix #6907\r\nFix #6912\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](https://github.com/rubocop-hq/rubocop/blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n* [x] Run `bundle exec rake default`. It executes all tests and RuboCop for itself, and generates the documentation.\r\n\r\n[1]: https://chris.beams.io/posts/git-commit/\r\n"},"comment":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/comments/485067726","html_url":"https://github.com/rubocop-hq/rubocop/pull/6908#issuecomment-485067726","issue_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6908","id":485067726,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NTA2NzcyNg==","user":{"login":"bbatsov","id":103882,"node_id":"MDQ6VXNlcjEwMzg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"created_at":"2019-04-20T07:52:51Z","updated_at":"2019-04-20T07:52:51Z","author_association":"COLLABORATOR","body":"> @exception_name.children\r\n\r\nShould return `nil` for `e`. I can't imagine how this can be giving some result. In general what you need to check is that whatever was passed to `rescue` is not `lvasgn` node. That's everything else is out the scope of the cop."}}
other: {"actor":{"display_login":"bbatsov"}}