payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/comments/347438495","pull_request_review_id":318407117,"id":347438495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzQzODQ5NQ==","diff_hunk":"@@ -77,7 +78,10 @@ fn expand_contract(args: ContractArgs) -> Result<TokenStream> {\n     //   the path will always be rooted on the cargo manifest directory.\n     //   Eventually we can use the `Span::source_file` API to have a better\n     //   experience.\n-    let artifact_path = args.artifact_path;\n+    let artifact_path = {\n+        let full_path = fs::canonicalize(args.artifact_path.value())?;\n+        LitStr::new(&full_path.to_string_lossy(), args.artifact_path.span())\n+    };","path":"derive/src/lib.rs","position":16,"original_position":16,"commit_id":"43b9e8825011ffd9048f7cc83365109ab72c6a73","original_commit_id":"43b9e8825011ffd9048f7cc83365109ab72c6a73","user":{"login":"nlordell","id":4210206,"node_id":"MDQ6VXNlcjQyMTAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4210206?v=4","gravatar_id":"","url":"https://api.github.com/users/nlordell","html_url":"https://github.com/nlordell","followers_url":"https://api.github.com/users/nlordell/followers","following_url":"https://api.github.com/users/nlordell/following{/other_user}","gists_url":"https://api.github.com/users/nlordell/gists{/gist_id}","starred_url":"https://api.github.com/users/nlordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlordell/subscriptions","organizations_url":"https://api.github.com/users/nlordell/orgs","repos_url":"https://api.github.com/users/nlordell/repos","events_url":"https://api.github.com/users/nlordell/events{/privacy}","received_events_url":"https://api.github.com/users/nlordell/received_events","type":"User","site_admin":false},"body":"Hehe yes it is.","created_at":"2019-11-18T15:17:25Z","updated_at":"2019-11-18T15:17:25Z","html_url":"https://github.com/gnosis/ethcontract-rs/pull/39#discussion_r347438495","pull_request_url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/comments/347438495"},"html":{"href":"https://github.com/gnosis/ethcontract-rs/pull/39#discussion_r347438495"},"pull_request":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39"}},"in_reply_to_id":347402090},"pull_request":{"url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39","id":339984297,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5OTg0Mjk3","html_url":"https://github.com/gnosis/ethcontract-rs/pull/39","diff_url":"https://github.com/gnosis/ethcontract-rs/pull/39.diff","patch_url":"https://github.com/gnosis/ethcontract-rs/pull/39.patch","issue_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/39","number":39,"state":"open","locked":false,"title":"New Contract Method API","user":{"login":"nlordell","id":4210206,"node_id":"MDQ6VXNlcjQyMTAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4210206?v=4","gravatar_id":"","url":"https://api.github.com/users/nlordell","html_url":"https://github.com/nlordell","followers_url":"https://api.github.com/users/nlordell/followers","following_url":"https://api.github.com/users/nlordell/following{/other_user}","gists_url":"https://api.github.com/users/nlordell/gists{/gist_id}","starred_url":"https://api.github.com/users/nlordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlordell/subscriptions","organizations_url":"https://api.github.com/users/nlordell/orgs","repos_url":"https://api.github.com/users/nlordell/repos","events_url":"https://api.github.com/users/nlordell/events{/privacy}","received_events_url":"https://api.github.com/users/nlordell/received_events","type":"User","site_admin":false},"body":"When first designing the contract API I made a wrong assumption that non-view functions could never be called and only could send transactions. This PR refactors the `CallBuilder` and `SendBuilder` API into a `ViewMethodBuilder` and `MethodBuilder` where `MethodBuilder` (which used to be the `SendBuilder`) can now also just call to be evaluated on the node without modifying state.\r\n\r\nNote that the generated code still restricts view methods to not be able to actually send transactions.\r\n\r\n### Test Plain\r\nFix existing unit tests and examples and ensure they still run.","created_at":"2019-11-12T16:02:55Z","updated_at":"2019-11-18T15:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e28ddca50b334ad806324166173740d9e5daee94","assignee":null,"assignees":[],"requested_reviewers":[{"login":"josojo","id":7348154,"node_id":"MDQ6VXNlcjczNDgxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7348154?v=4","gravatar_id":"","url":"https://api.github.com/users/josojo","html_url":"https://github.com/josojo","followers_url":"https://api.github.com/users/josojo/followers","following_url":"https://api.github.com/users/josojo/following{/other_user}","gists_url":"https://api.github.com/users/josojo/gists{/gist_id}","starred_url":"https://api.github.com/users/josojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josojo/subscriptions","organizations_url":"https://api.github.com/users/josojo/orgs","repos_url":"https://api.github.com/users/josojo/repos","events_url":"https://api.github.com/users/josojo/events{/privacy}","received_events_url":"https://api.github.com/users/josojo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39/commits","review_comments_url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39/comments","review_comment_url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/39/comments","statuses_url":"https://api.github.com/repos/gnosis/ethcontract-rs/statuses/43b9e8825011ffd9048f7cc83365109ab72c6a73","head":{"label":"gnosis:new_method_api","ref":"new_method_api","sha":"43b9e8825011ffd9048f7cc83365109ab72c6a73","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":215829151,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU4MjkxNTE=","name":"ethcontract-rs","full_name":"gnosis/ethcontract-rs","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/ethcontract-rs","description":"Generate type-safe bindings for interacting with Ethereum contracts.","fork":false,"url":"https://api.github.com/repos/gnosis/ethcontract-rs","forks_url":"https://api.github.com/repos/gnosis/ethcontract-rs/forks","keys_url":"https://api.github.com/repos/gnosis/ethcontract-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/ethcontract-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/ethcontract-rs/teams","hooks_url":"https://api.github.com/repos/gnosis/ethcontract-rs/hooks","issue_events_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/ethcontract-rs/events","assignees_url":"https://api.github.com/repos/gnosis/ethcontract-rs/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/ethcontract-rs/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/ethcontract-rs/tags","blobs_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/ethcontract-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/ethcontract-rs/languages","stargazers_url":"https://api.github.com/repos/gnosis/ethcontract-rs/stargazers","contributors_url":"https://api.github.com/repos/gnosis/ethcontract-rs/contributors","subscribers_url":"https://api.github.com/repos/gnosis/ethcontract-rs/subscribers","subscription_url":"https://api.github.com/repos/gnosis/ethcontract-rs/subscription","commits_url":"https://api.github.com/repos/gnosis/ethcontract-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/ethcontract-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/ethcontract-rs/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/ethcontract-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/ethcontract-rs/merges","archive_url":"https://api.github.com/repos/gnosis/ethcontract-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/ethcontract-rs/downloads","issues_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/ethcontract-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/ethcontract-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/ethcontract-rs/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/ethcontract-rs/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/ethcontract-rs/deployments","created_at":"2019-10-17T15:44:20Z","updated_at":"2019-11-14T13:12:12Z","pushed_at":"2019-11-17T14:34:08Z","git_url":"git://github.com/gnosis/ethcontract-rs.git","ssh_url":"git@github.com:gnosis/ethcontract-rs.git","clone_url":"https://github.com/gnosis/ethcontract-rs.git","svn_url":"https://github.com/gnosis/ethcontract-rs","homepage":"","size":182,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":17,"watchers":3,"default_branch":"master"}},"base":{"label":"gnosis:master","ref":"master","sha":"e6823ae05e93794b90d4e4d34a3c8f0692429783","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":215829151,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU4MjkxNTE=","name":"ethcontract-rs","full_name":"gnosis/ethcontract-rs","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/ethcontract-rs","description":"Generate type-safe bindings for interacting with Ethereum contracts.","fork":false,"url":"https://api.github.com/repos/gnosis/ethcontract-rs","forks_url":"https://api.github.com/repos/gnosis/ethcontract-rs/forks","keys_url":"https://api.github.com/repos/gnosis/ethcontract-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/ethcontract-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/ethcontract-rs/teams","hooks_url":"https://api.github.com/repos/gnosis/ethcontract-rs/hooks","issue_events_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/ethcontract-rs/events","assignees_url":"https://api.github.com/repos/gnosis/ethcontract-rs/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/ethcontract-rs/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/ethcontract-rs/tags","blobs_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/ethcontract-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/ethcontract-rs/languages","stargazers_url":"https://api.github.com/repos/gnosis/ethcontract-rs/stargazers","contributors_url":"https://api.github.com/repos/gnosis/ethcontract-rs/contributors","subscribers_url":"https://api.github.com/repos/gnosis/ethcontract-rs/subscribers","subscription_url":"https://api.github.com/repos/gnosis/ethcontract-rs/subscription","commits_url":"https://api.github.com/repos/gnosis/ethcontract-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/ethcontract-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/ethcontract-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/ethcontract-rs/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/ethcontract-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/ethcontract-rs/merges","archive_url":"https://api.github.com/repos/gnosis/ethcontract-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/ethcontract-rs/downloads","issues_url":"https://api.github.com/repos/gnosis/ethcontract-rs/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/ethcontract-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/ethcontract-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/ethcontract-rs/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/ethcontract-rs/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/ethcontract-rs/deployments","created_at":"2019-10-17T15:44:20Z","updated_at":"2019-11-14T13:12:12Z","pushed_at":"2019-11-17T14:34:08Z","git_url":"git://github.com/gnosis/ethcontract-rs.git","ssh_url":"git@github.com:gnosis/ethcontract-rs.git","clone_url":"https://github.com/gnosis/ethcontract-rs.git","svn_url":"https://github.com/gnosis/ethcontract-rs","homepage":"","size":182,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":17,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39"},"html":{"href":"https://github.com/gnosis/ethcontract-rs/pull/39"},"issue":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/39"},"comments":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/gnosis/ethcontract-rs/statuses/43b9e8825011ffd9048f7cc83365109ab72c6a73"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"nlordell"}}