payload: {"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/comments/280532118","pull_request_review_id":233150315,"id":280532118,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDUzMjExOA==","diff_hunk":"@@ -1562,6 +1562,34 @@\n           }\n         ]\n       }\n+    },\n+    \"StepFunctionsExecutionPolicy\": {\n+      \"Description\": \"Gives permission to start a Step Functions state machine execution\",\n+      \"Parameters\": {\n+        \"StateMachineName\": {\n+          \"Description\":\"The name of the state machine to execute.\"\n+        }\n+      },\n+      \"Definition\": {\n+        \"Statement\": [\n+          {\n+            \"Effect\": \"Allow\",\n+            \"Action\": [\n+              \"states:StartExecution\"","path":"samtranslator/policy_templates_data/policy_templates.json","position":17,"original_position":17,"commit_id":"396e9f120d594fe287fe048c8769a0af7dc6cc7e","original_commit_id":"396e9f120d594fe287fe048c8769a0af7dc6cc7e","user":{"login":"jlhood","id":1444420,"node_id":"MDQ6VXNlcjE0NDQ0MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1444420?v=4","gravatar_id":"","url":"https://api.github.com/users/jlhood","html_url":"https://github.com/jlhood","followers_url":"https://api.github.com/users/jlhood/followers","following_url":"https://api.github.com/users/jlhood/following{/other_user}","gists_url":"https://api.github.com/users/jlhood/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhood/subscriptions","organizations_url":"https://api.github.com/users/jlhood/orgs","repos_url":"https://api.github.com/users/jlhood/repos","events_url":"https://api.github.com/users/jlhood/events{/privacy}","received_events_url":"https://api.github.com/users/jlhood/received_events","type":"User","site_admin":false},"body":"Are there other permissions we should include here as well? Are you sure this is the only logical action to give to a function to interact with a state machine? `states:StopExecution` seems to make sense, but looking at [the docs](https://docs.aws.amazon.com/IAM/latest/UserGuide/list_awsstepfunctions.html), it doesn't look like it's scoped to a state machine (which seems weird).\r\n\r\nI'm not going to block on this since we could add additional permissions later, but I'll also check around with others to see if any other permissions are logical to add to this policy.","created_at":"2019-05-02T17:57:44Z","updated_at":"2019-05-02T17:58:54Z","html_url":"https://github.com/awslabs/serverless-application-model/pull/904#discussion_r280532118","pull_request_url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/comments/280532118"},"html":{"href":"https://github.com/awslabs/serverless-application-model/pull/904#discussion_r280532118"},"pull_request":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904","id":274524466,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NTI0NDY2","html_url":"https://github.com/awslabs/serverless-application-model/pull/904","diff_url":"https://github.com/awslabs/serverless-application-model/pull/904.diff","patch_url":"https://github.com/awslabs/serverless-application-model/pull/904.patch","issue_url":"https://api.github.com/repos/awslabs/serverless-application-model/issues/904","number":904,"state":"open","locked":false,"title":"feat(policy-templates): add new policy for allowing step functions ex…","user":{"login":"ljacobsson","id":7579097,"node_id":"MDQ6VXNlcjc1NzkwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7579097?v=4","gravatar_id":"","url":"https://api.github.com/users/ljacobsson","html_url":"https://github.com/ljacobsson","followers_url":"https://api.github.com/users/ljacobsson/followers","following_url":"https://api.github.com/users/ljacobsson/following{/other_user}","gists_url":"https://api.github.com/users/ljacobsson/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacobsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacobsson/subscriptions","organizations_url":"https://api.github.com/users/ljacobsson/orgs","repos_url":"https://api.github.com/users/ljacobsson/repos","events_url":"https://api.github.com/users/ljacobsson/events{/privacy}","received_events_url":"https://api.github.com/users/ljacobsson/received_events","type":"User","site_admin":false},"body":"…ecutions\r\n\r\n*Description of changes:*\r\nAdded policy template allowing `states:StartExecution` on a Step Functions state machine\r\n\r\n*Description of how you validated changes:*\r\nI have used the policy statement in my own stacks. \r\n\r\n*Checklist:*\r\n\r\n- [X] Write/update tests\r\n- [X] `make pr` passes\r\n- [X] Update documentation\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2019-04-29T21:07:20Z","updated_at":"2019-05-02T17:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c23a528548156cc91c05af14212285767f969031","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904/commits","review_comments_url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904/comments","review_comment_url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/serverless-application-model/issues/904/comments","statuses_url":"https://api.github.com/repos/awslabs/serverless-application-model/statuses/396e9f120d594fe287fe048c8769a0af7dc6cc7e","head":{"label":"ljacobsson:master","ref":"master","sha":"396e9f120d594fe287fe048c8769a0af7dc6cc7e","user":{"login":"ljacobsson","id":7579097,"node_id":"MDQ6VXNlcjc1NzkwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7579097?v=4","gravatar_id":"","url":"https://api.github.com/users/ljacobsson","html_url":"https://github.com/ljacobsson","followers_url":"https://api.github.com/users/ljacobsson/followers","following_url":"https://api.github.com/users/ljacobsson/following{/other_user}","gists_url":"https://api.github.com/users/ljacobsson/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacobsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacobsson/subscriptions","organizations_url":"https://api.github.com/users/ljacobsson/orgs","repos_url":"https://api.github.com/users/ljacobsson/repos","events_url":"https://api.github.com/users/ljacobsson/events{/privacy}","received_events_url":"https://api.github.com/users/ljacobsson/received_events","type":"User","site_admin":false},"repo":{"id":184131265,"node_id":"MDEwOlJlcG9zaXRvcnkxODQxMzEyNjU=","name":"serverless-application-model","full_name":"ljacobsson/serverless-application-model","private":false,"owner":{"login":"ljacobsson","id":7579097,"node_id":"MDQ6VXNlcjc1NzkwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7579097?v=4","gravatar_id":"","url":"https://api.github.com/users/ljacobsson","html_url":"https://github.com/ljacobsson","followers_url":"https://api.github.com/users/ljacobsson/followers","following_url":"https://api.github.com/users/ljacobsson/following{/other_user}","gists_url":"https://api.github.com/users/ljacobsson/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacobsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacobsson/subscriptions","organizations_url":"https://api.github.com/users/ljacobsson/orgs","repos_url":"https://api.github.com/users/ljacobsson/repos","events_url":"https://api.github.com/users/ljacobsson/events{/privacy}","received_events_url":"https://api.github.com/users/ljacobsson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ljacobsson/serverless-application-model","description":"AWS Serverless Application Model (AWS SAM) prescribes rules for expressing Serverless applications on AWS.","fork":true,"url":"https://api.github.com/repos/ljacobsson/serverless-application-model","forks_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/forks","keys_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/teams","hooks_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/hooks","issue_events_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/issues/events{/number}","events_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/events","assignees_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/assignees{/user}","branches_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/branches{/branch}","tags_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/tags","blobs_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/statuses/{sha}","languages_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/languages","stargazers_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/stargazers","contributors_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/contributors","subscribers_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/subscribers","subscription_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/subscription","commits_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/contents/{+path}","compare_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/merges","archive_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/downloads","issues_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/issues{/number}","pulls_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/pulls{/number}","milestones_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/milestones{/number}","notifications_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/labels{/name}","releases_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/releases{/id}","deployments_url":"https://api.github.com/repos/ljacobsson/serverless-application-model/deployments","created_at":"2019-04-29T19:29:07Z","updated_at":"2019-04-30T09:50:25Z","pushed_at":"2019-04-30T09:50:22Z","git_url":"git://github.com/ljacobsson/serverless-application-model.git","ssh_url":"git@github.com:ljacobsson/serverless-application-model.git","clone_url":"https://github.com/ljacobsson/serverless-application-model.git","svn_url":"https://github.com/ljacobsson/serverless-application-model","homepage":"","size":7456,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:develop","ref":"develop","sha":"166304b8e3e3089377f701d1dbe5f4b254603df3","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":70530854,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUzMDg1NA==","name":"serverless-application-model","full_name":"awslabs/serverless-application-model","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/serverless-application-model","description":"AWS Serverless Application Model (AWS SAM) prescribes rules for expressing Serverless applications on AWS.","fork":false,"url":"https://api.github.com/repos/awslabs/serverless-application-model","forks_url":"https://api.github.com/repos/awslabs/serverless-application-model/forks","keys_url":"https://api.github.com/repos/awslabs/serverless-application-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/serverless-application-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/serverless-application-model/teams","hooks_url":"https://api.github.com/repos/awslabs/serverless-application-model/hooks","issue_events_url":"https://api.github.com/repos/awslabs/serverless-application-model/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/serverless-application-model/events","assignees_url":"https://api.github.com/repos/awslabs/serverless-application-model/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/serverless-application-model/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/serverless-application-model/tags","blobs_url":"https://api.github.com/repos/awslabs/serverless-application-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/serverless-application-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/serverless-application-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/serverless-application-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/serverless-application-model/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/serverless-application-model/languages","stargazers_url":"https://api.github.com/repos/awslabs/serverless-application-model/stargazers","contributors_url":"https://api.github.com/repos/awslabs/serverless-application-model/contributors","subscribers_url":"https://api.github.com/repos/awslabs/serverless-application-model/subscribers","subscription_url":"https://api.github.com/repos/awslabs/serverless-application-model/subscription","commits_url":"https://api.github.com/repos/awslabs/serverless-application-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/serverless-application-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/serverless-application-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/serverless-application-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/serverless-application-model/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/serverless-application-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/serverless-application-model/merges","archive_url":"https://api.github.com/repos/awslabs/serverless-application-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/serverless-application-model/downloads","issues_url":"https://api.github.com/repos/awslabs/serverless-application-model/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/serverless-application-model/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/serverless-application-model/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/serverless-application-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/serverless-application-model/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/serverless-application-model/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/serverless-application-model/deployments","created_at":"2016-10-10T21:36:18Z","updated_at":"2019-05-02T14:54:05Z","pushed_at":"2019-05-02T17:52:42Z","git_url":"git://github.com/awslabs/serverless-application-model.git","ssh_url":"git@github.com:awslabs/serverless-application-model.git","clone_url":"https://github.com/awslabs/serverless-application-model.git","svn_url":"https://github.com/awslabs/serverless-application-model","homepage":"","size":7455,"stargazers_count":5107,"watchers_count":5107,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1162,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":165,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1162,"open_issues":165,"watchers":5107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904"},"html":{"href":"https://github.com/awslabs/serverless-application-model/pull/904"},"issue":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/issues/904"},"comments":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/serverless-application-model/statuses/396e9f120d594fe287fe048c8769a0af7dc6cc7e"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"jlhood"}}