payload: {"action":"created","issue":{"url":"https://api.github.com/repos/spyder-ide/spyder/issues/9554","repository_url":"https://api.github.com/repos/spyder-ide/spyder","labels_url":"https://api.github.com/repos/spyder-ide/spyder/issues/9554/labels{/name}","comments_url":"https://api.github.com/repos/spyder-ide/spyder/issues/9554/comments","events_url":"https://api.github.com/repos/spyder-ide/spyder/issues/9554/events","html_url":"https://github.com/spyder-ide/spyder/pull/9554","id":454891053,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3MjUxOTQ5","number":9554,"title":"PR: Remove stylesheet workarounds for the options and browse button when under the dark theme","user":{"login":"jnsebgosselin","id":10170372,"node_id":"MDQ6VXNlcjEwMTcwMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/10170372?v=4","gravatar_id":"","url":"https://api.github.com/users/jnsebgosselin","html_url":"https://github.com/jnsebgosselin","followers_url":"https://api.github.com/users/jnsebgosselin/followers","following_url":"https://api.github.com/users/jnsebgosselin/following{/other_user}","gists_url":"https://api.github.com/users/jnsebgosselin/gists{/gist_id}","starred_url":"https://api.github.com/users/jnsebgosselin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnsebgosselin/subscriptions","organizations_url":"https://api.github.com/users/jnsebgosselin/orgs","repos_url":"https://api.github.com/users/jnsebgosselin/repos","events_url":"https://api.github.com/users/jnsebgosselin/events{/privacy}","received_events_url":"https://api.github.com/users/jnsebgosselin/received_events","type":"User","site_admin":false},"labels":[{"id":821135260,"node_id":"MDU6TGFiZWw4MjExMzUyNjA=","url":"https://api.github.com/repos/spyder-ide/spyder/labels/status:Pending%20Changes/Test","name":"status:Pending Changes/Test","color":"00f07d","default":false},{"id":177806169,"node_id":"MDU6TGFiZWwxNzc4MDYxNjk=","url":"https://api.github.com/repos/spyder-ide/spyder/labels/tag:Ui","name":"tag:Ui","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"jnsebgosselin","id":10170372,"node_id":"MDQ6VXNlcjEwMTcwMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/10170372?v=4","gravatar_id":"","url":"https://api.github.com/users/jnsebgosselin","html_url":"https://github.com/jnsebgosselin","followers_url":"https://api.github.com/users/jnsebgosselin/followers","following_url":"https://api.github.com/users/jnsebgosselin/following{/other_user}","gists_url":"https://api.github.com/users/jnsebgosselin/gists{/gist_id}","starred_url":"https://api.github.com/users/jnsebgosselin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnsebgosselin/subscriptions","organizations_url":"https://api.github.com/users/jnsebgosselin/orgs","repos_url":"https://api.github.com/users/jnsebgosselin/repos","events_url":"https://api.github.com/users/jnsebgosselin/events{/privacy}","received_events_url":"https://api.github.com/users/jnsebgosselin/received_events","type":"User","site_admin":false},"assignees":[{"login":"jnsebgosselin","id":10170372,"node_id":"MDQ6VXNlcjEwMTcwMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/10170372?v=4","gravatar_id":"","url":"https://api.github.com/users/jnsebgosselin","html_url":"https://github.com/jnsebgosselin","followers_url":"https://api.github.com/users/jnsebgosselin/followers","following_url":"https://api.github.com/users/jnsebgosselin/following{/other_user}","gists_url":"https://api.github.com/users/jnsebgosselin/gists{/gist_id}","starred_url":"https://api.github.com/users/jnsebgosselin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnsebgosselin/subscriptions","organizations_url":"https://api.github.com/users/jnsebgosselin/orgs","repos_url":"https://api.github.com/users/jnsebgosselin/repos","events_url":"https://api.github.com/users/jnsebgosselin/events{/privacy}","received_events_url":"https://api.github.com/users/jnsebgosselin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spyder-ide/spyder/milestones/65","html_url":"https://github.com/spyder-ide/spyder/milestone/65","labels_url":"https://api.github.com/repos/spyder-ide/spyder/milestones/65/labels","id":4326856,"node_id":"MDk6TWlsZXN0b25lNDMyNjg1Ng==","number":65,"title":"v4.0betaX","description":"","creator":{"login":"ccordoba12","id":365293,"node_id":"MDQ6VXNlcjM2NTI5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/365293?v=4","gravatar_id":"","url":"https://api.github.com/users/ccordoba12","html_url":"https://github.com/ccordoba12","followers_url":"https://api.github.com/users/ccordoba12/followers","following_url":"https://api.github.com/users/ccordoba12/following{/other_user}","gists_url":"https://api.github.com/users/ccordoba12/gists{/gist_id}","starred_url":"https://api.github.com/users/ccordoba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccordoba12/subscriptions","organizations_url":"https://api.github.com/users/ccordoba12/orgs","repos_url":"https://api.github.com/users/ccordoba12/repos","events_url":"https://api.github.com/users/ccordoba12/events{/privacy}","received_events_url":"https://api.github.com/users/ccordoba12/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":0,"state":"open","created_at":"2019-05-18T09:20:13Z","updated_at":"2019-06-17T15:45:51Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2019-06-11T20:34:36Z","updated_at":"2019-06-18T20:53:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/spyder-ide/spyder/pulls/9554","html_url":"https://github.com/spyder-ide/spyder/pull/9554","diff_url":"https://github.com/spyder-ide/spyder/pull/9554.diff","patch_url":"https://github.com/spyder-ide/spyder/pull/9554.patch"},"body":"## Description of Changes\r\n\r\nAs reported in https://github.com/ColinDuquesnoy/QDarkStyleSheet/issues/187, `QToolButton` were not styled correctly in `QDarkStyleSheet` when the `PopupMode` of the button was set to `InstantPopup`. Because of this, workarounds were added in Spyder to make the options and browse buttons look ok.\r\n\r\nSince this is going to be fixed in version 2.8 of `QDarkStyleSheet`, these workarounds are not longer necessary, so this PR propose to remove them. Besides, there were some problems with these workarounds :\r\n\r\n- First, the padding of the button in `QDarkStyleSheet` is not `3 px`  but `2 px`.\r\n- Second, the workaround was applied to the browse button of the `BaseTabs` class even when not in dark mode, causing a distortion of the aspect ratio of this button. This also caused this button to be not positioned the same way as the other tab corner widgets as noticed in PR https://github.com/spyder-ide/spyder/pull/9452#issuecomment-497460070.\r\n\r\n![image](https://user-images.githubusercontent.com/10170372/59303716-c8809900-8c64-11e9-8635-2925a68e8982.png)\r\n\r\n- Third, the hard coded padding added to the stop and reset button for the IPython plugin were not needed and ignored by Qt anyway.\r\n\r\nHere is a screenshot of Spyder after the changes running the latest version of `QDarkStyleSheet` on the `develop` branch :\r\n\r\n![image](https://user-images.githubusercontent.com/10170372/59304488-5dd05d00-8c66-11e9-9dfb-7cc022f91186.png)\r\n\r\n\r\n### Issue(s) Resolved\r\n\r\nFixes what was reported in PR https://github.com/spyder-ide/spyder/pull/9452#issuecomment-497460070\r\n\r\nNote: these changes were initially part of PR https://github.com/spyder-ide/spyder/pull/9452 (see commit https://github.com/spyder-ide/spyder/commit/486534cb34cf759f9a6571f8f5c2012ed8611910) but I think it is better that they are considered and reviewed in a separate PR.\r\n\r\n### Affirmation\r\n\r\nBy submitting this Pull Request or typing my (user)name below,\r\nI affirm the [Developer Certificate of Origin](https://developercertificate.org)\r\nwith respect to all commits and content included in this PR,\r\nand understand I am releasing the same under Spyder's MIT (Expat) license.\r\n\r\nI certify the above statement is true and correct: Jean-Sébastien Gosselin\r\n"},"comment":{"url":"https://api.github.com/repos/spyder-ide/spyder/issues/comments/503307597","html_url":"https://github.com/spyder-ide/spyder/pull/9554#issuecomment-503307597","issue_url":"https://api.github.com/repos/spyder-ide/spyder/issues/9554","id":503307597,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMzMwNzU5Nw==","user":{"login":"dpizetta","id":5084939,"node_id":"MDQ6VXNlcjUwODQ5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/5084939?v=4","gravatar_id":"","url":"https://api.github.com/users/dpizetta","html_url":"https://github.com/dpizetta","followers_url":"https://api.github.com/users/dpizetta/followers","following_url":"https://api.github.com/users/dpizetta/following{/other_user}","gists_url":"https://api.github.com/users/dpizetta/gists{/gist_id}","starred_url":"https://api.github.com/users/dpizetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpizetta/subscriptions","organizations_url":"https://api.github.com/users/dpizetta/orgs","repos_url":"https://api.github.com/users/dpizetta/repos","events_url":"https://api.github.com/users/dpizetta/events{/privacy}","received_events_url":"https://api.github.com/users/dpizetta/received_events","type":"User","site_admin":false},"created_at":"2019-06-18T20:53:38Z","updated_at":"2019-06-18T20:53:38Z","author_association":"NONE","body":"Some suggestions below:\r\n\r\n- Separator in 'fake' toolbars: As you are creating the toolbars as widgets and using VLine as separators, the toolbars separators are 16px height in qdark. To create a similarity you can use the VLine with 60-80% height for all themes or keep them fixed at 16px.\r\n\r\n- I notice some problems in headers from the different dock. See the comparison between \"files\" and \"variable profile\". Padding or margins seems to be different, left and right, and top and bottom. Maybe some hard-coded values. Also, the \"Name\" column could be expanded at the start.\r\n\r\n![diff-space-header-profile-table](https://user-images.githubusercontent.com/5084939/59718917-8d94dd00-91f1-11e9-8716-1a284b8ac826.gif)\r\n\r\n- Icons out of center: I don't know if it is intended, but it seems they are not in the center.\r\n![icons-image-out-off-center](https://user-images.githubusercontent.com/5084939/59718675-06476980-91f1-11e9-9f13-c32602f3a812.gif)\r\n\r\nIf you would like I open new issues, please, let me know. Tks\r\n"}}
other: {"actor":{"display_login":"dpizetta"}}