payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/297264444","pull_request_review_id":254105867,"id":297264444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzI2NDQ0NA==","diff_hunk":"@@ -24,6 +24,7 @@ PyGithub==1.43.7\n pylint==2.3.1\n PyMySQL==0.9.3\n pytest==4.6.3\n+python-json-logger","path":"docker/requirements.txt","position":null,"original_position":4,"commit_id":"eb4337b0bdbd5f719803a4ab78c57216df4b51e0","original_commit_id":"ef85b05aeacd4fc8066a1f8d0721b7d3ba46ea63","user":{"login":"johnc1231","id":13773586,"node_id":"MDQ6VXNlcjEzNzczNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/13773586?v=4","gravatar_id":"","url":"https://api.github.com/users/johnc1231","html_url":"https://github.com/johnc1231","followers_url":"https://api.github.com/users/johnc1231/followers","following_url":"https://api.github.com/users/johnc1231/following{/other_user}","gists_url":"https://api.github.com/users/johnc1231/gists{/gist_id}","starred_url":"https://api.github.com/users/johnc1231/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnc1231/subscriptions","organizations_url":"https://api.github.com/users/johnc1231/orgs","repos_url":"https://api.github.com/users/johnc1231/repos","events_url":"https://api.github.com/users/johnc1231/events{/privacy}","received_events_url":"https://api.github.com/users/johnc1231/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2019-06-25T15:55:15Z","updated_at":"2019-06-25T15:55:15Z","html_url":"https://github.com/hail-is/hail/pull/6453#discussion_r297264444","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/6453","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/297264444"},"html":{"href":"https://github.com/hail-is/hail/pull/6453#discussion_r297264444"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6453"}},"in_reply_to_id":297199250},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/6453","id":291263210,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMjYzMjEw","html_url":"https://github.com/hail-is/hail/pull/6453","diff_url":"https://github.com/hail-is/hail/pull/6453.diff","patch_url":"https://github.com/hail-is/hail/pull/6453.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/6453","number":6453,"state":"open","locked":false,"title":"Use JSON formatting in logs","user":{"login":"johnc1231","id":13773586,"node_id":"MDQ6VXNlcjEzNzczNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/13773586?v=4","gravatar_id":"","url":"https://api.github.com/users/johnc1231","html_url":"https://github.com/johnc1231","followers_url":"https://api.github.com/users/johnc1231/followers","following_url":"https://api.github.com/users/johnc1231/following{/other_user}","gists_url":"https://api.github.com/users/johnc1231/gists{/gist_id}","starred_url":"https://api.github.com/users/johnc1231/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnc1231/subscriptions","organizations_url":"https://api.github.com/users/johnc1231/orgs","repos_url":"https://api.github.com/users/johnc1231/repos","events_url":"https://api.github.com/users/johnc1231/events{/privacy}","received_events_url":"https://api.github.com/users/johnc1231/received_events","type":"User","site_admin":false},"body":"I just pulled in a library specifically for json log formatting that handles escaping nicely + makes it easy to add anything else we might want to do. I've obviously not run batch locally but I've tested this code locally by running \r\n\r\n```from hailtop.gear import configure_logging\r\nimport logging\r\nconfigure_logging()\r\nlogging.info('\"Foo\"')\r\n```\r\n\r\nWe are definitely going to want more than this eventually, but this should at least let us start to break up our logs in Kibana. And it's hard to test more complicated things without some way to run my own batch. ","created_at":"2019-06-24T19:22:17Z","updated_at":"2019-06-25T15:55:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"048092b2fe07046e51b6333f6f405983910df38e","assignee":{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"assignees":[{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/6453/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/6453/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/6453/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/eb4337b0bdbd5f719803a4ab78c57216df4b51e0","head":{"label":"johnc1231:johnc-log-wrangling","ref":"johnc-log-wrangling","sha":"eb4337b0bdbd5f719803a4ab78c57216df4b51e0","user":{"login":"johnc1231","id":13773586,"node_id":"MDQ6VXNlcjEzNzczNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/13773586?v=4","gravatar_id":"","url":"https://api.github.com/users/johnc1231","html_url":"https://github.com/johnc1231","followers_url":"https://api.github.com/users/johnc1231/followers","following_url":"https://api.github.com/users/johnc1231/following{/other_user}","gists_url":"https://api.github.com/users/johnc1231/gists{/gist_id}","starred_url":"https://api.github.com/users/johnc1231/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnc1231/subscriptions","organizations_url":"https://api.github.com/users/johnc1231/orgs","repos_url":"https://api.github.com/users/johnc1231/repos","events_url":"https://api.github.com/users/johnc1231/events{/privacy}","received_events_url":"https://api.github.com/users/johnc1231/received_events","type":"User","site_admin":false},"repo":{"id":78463138,"node_id":"MDEwOlJlcG9zaXRvcnk3ODQ2MzEzOA==","name":"hail","full_name":"johnc1231/hail","private":false,"owner":{"login":"johnc1231","id":13773586,"node_id":"MDQ6VXNlcjEzNzczNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/13773586?v=4","gravatar_id":"","url":"https://api.github.com/users/johnc1231","html_url":"https://github.com/johnc1231","followers_url":"https://api.github.com/users/johnc1231/followers","following_url":"https://api.github.com/users/johnc1231/following{/other_user}","gists_url":"https://api.github.com/users/johnc1231/gists{/gist_id}","starred_url":"https://api.github.com/users/johnc1231/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnc1231/subscriptions","organizations_url":"https://api.github.com/users/johnc1231/orgs","repos_url":"https://api.github.com/users/johnc1231/repos","events_url":"https://api.github.com/users/johnc1231/events{/privacy}","received_events_url":"https://api.github.com/users/johnc1231/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnc1231/hail","description":"Scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/johnc1231/hail","forks_url":"https://api.github.com/repos/johnc1231/hail/forks","keys_url":"https://api.github.com/repos/johnc1231/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnc1231/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnc1231/hail/teams","hooks_url":"https://api.github.com/repos/johnc1231/hail/hooks","issue_events_url":"https://api.github.com/repos/johnc1231/hail/issues/events{/number}","events_url":"https://api.github.com/repos/johnc1231/hail/events","assignees_url":"https://api.github.com/repos/johnc1231/hail/assignees{/user}","branches_url":"https://api.github.com/repos/johnc1231/hail/branches{/branch}","tags_url":"https://api.github.com/repos/johnc1231/hail/tags","blobs_url":"https://api.github.com/repos/johnc1231/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnc1231/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnc1231/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnc1231/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnc1231/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/johnc1231/hail/languages","stargazers_url":"https://api.github.com/repos/johnc1231/hail/stargazers","contributors_url":"https://api.github.com/repos/johnc1231/hail/contributors","subscribers_url":"https://api.github.com/repos/johnc1231/hail/subscribers","subscription_url":"https://api.github.com/repos/johnc1231/hail/subscription","commits_url":"https://api.github.com/repos/johnc1231/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnc1231/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnc1231/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnc1231/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnc1231/hail/contents/{+path}","compare_url":"https://api.github.com/repos/johnc1231/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnc1231/hail/merges","archive_url":"https://api.github.com/repos/johnc1231/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnc1231/hail/downloads","issues_url":"https://api.github.com/repos/johnc1231/hail/issues{/number}","pulls_url":"https://api.github.com/repos/johnc1231/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/johnc1231/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/johnc1231/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnc1231/hail/labels{/name}","releases_url":"https://api.github.com/repos/johnc1231/hail/releases{/id}","deployments_url":"https://api.github.com/repos/johnc1231/hail/deployments","created_at":"2017-01-09T19:52:45Z","updated_at":"2019-06-25T02:35:57Z","pushed_at":"2019-06-25T15:55:00Z","git_url":"git://github.com/johnc1231/hail.git","ssh_url":"git@github.com:johnc1231/hail.git","clone_url":"https://github.com/johnc1231/hail.git","svn_url":"https://github.com/johnc1231/hail","homepage":"https://hail.is","size":68958,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"346fb67aa5f943c42981025823876272ee222183","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2019-06-25T13:13:11Z","pushed_at":"2019-06-25T15:55:02Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":69526,"stargazers_count":533,"watchers_count":533,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":243,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":135,"open_issues":243,"watchers":533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6453"},"html":{"href":"https://github.com/hail-is/hail/pull/6453"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/6453"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/6453/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6453/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/6453/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/eb4337b0bdbd5f719803a4ab78c57216df4b51e0"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"johnc1231"}}