payload: {"action":"created","issue":{"url":"https://api.github.com/repos/tektoncd/pipeline/issues/1638","repository_url":"https://api.github.com/repos/tektoncd/pipeline","labels_url":"https://api.github.com/repos/tektoncd/pipeline/issues/1638/labels{/name}","comments_url":"https://api.github.com/repos/tektoncd/pipeline/issues/1638/comments","events_url":"https://api.github.com/repos/tektoncd/pipeline/issues/1638/events","html_url":"https://github.com/tektoncd/pipeline/pull/1638","id":529578746,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2NDMwMzk4","number":1638,"title":"Update v1alpha1 status types to line fields","user":{"login":"poy","id":6554782,"node_id":"MDQ6VXNlcjY1NTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/6554782?v=4","gravatar_id":"","url":"https://api.github.com/users/poy","html_url":"https://github.com/poy","followers_url":"https://api.github.com/users/poy/followers","following_url":"https://api.github.com/users/poy/following{/other_user}","gists_url":"https://api.github.com/users/poy/gists{/gist_id}","starred_url":"https://api.github.com/users/poy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poy/subscriptions","organizations_url":"https://api.github.com/users/poy/orgs","repos_url":"https://api.github.com/users/poy/repos","events_url":"https://api.github.com/users/poy/events{/privacy}","received_events_url":"https://api.github.com/users/poy/received_events","type":"User","site_admin":false},"labels":[{"id":1205639294,"node_id":"MDU6TGFiZWwxMjA1NjM5Mjk0","url":"https://api.github.com/repos/tektoncd/pipeline/labels/cla:%20yes","name":"cla: yes","color":"0c6a89","default":false,"description":"Trying to make the CLA bot happy with ppl from different companies work on one commit"},{"id":1402688528,"node_id":"MDU6TGFiZWwxNDAyNjg4NTI4","url":"https://api.github.com/repos/tektoncd/pipeline/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false,"description":"Indicates a non-member PR verified by an org member that is safe to test."},{"id":1060218475,"node_id":"MDU6TGFiZWwxMDYwMjE4NDc1","url":"https://api.github.com/repos/tektoncd/pipeline/labels/size/L","name":"size/L","color":"ee9900","default":false,"description":"Denotes a PR that changes 100-499 lines, ignoring generated files."}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-11-27T21:23:29Z","updated_at":"2019-11-27T21:53:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tektoncd/pipeline/pulls/1638","html_url":"https://github.com/tektoncd/pipeline/pull/1638","diff_url":"https://github.com/tektoncd/pipeline/pull/1638.diff","patch_url":"https://github.com/tektoncd/pipeline/pull/1638.patch"},"body":"\r\n\r\n<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->\r\n\r\n# Changes\r\n\r\n<!-- Describe your changes here- ideally you can get that description straight from\r\nyour descriptive commit message(s)! -->\r\nSplits up the status types into two structs:\r\n\r\n* XXXStatus\r\n* XXXStatusFields\r\n\r\nThis first inlines both knative's duck status type and the\r\nXXXStatusFields. The second stores all the fields that were originially\r\nin XXXStatus. This is advantageous as downstream users can now embed a\r\nthe XXXStatusFields if their CRDs manage a Tekton object.\r\n\r\nThis pattern is demonstrated in Knative (e.g., Serving). Moving to this\r\npattern does not change the JSON/YAML structure in anyway, however it\r\ndoes change how status objects have to be instantiated in Go.\r\n\r\nfixes #1590\r\n\r\n# Submitter Checklist\r\n\r\nThese are the criteria that every PR should meet, please check them off as you\r\nreview them:\r\n\r\n- [x] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)\r\n- [x] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if user facing)\r\n- [x] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)\r\n\r\n_See [the contribution guide](https://github.com/tektoncd/pipeline/blob/master/CONTRIBUTING.md) for more details._\r\n\r\nDouble check this list of stuff that's easy to miss:\r\n\r\n- If you are adding [a new binary/image to the `cmd` dir](../cmd), please update\r\n  [the release Task](../tekton/publish.yaml) to build and release this image.\r\n\r\n## Reviewer Notes\r\n\r\nIf [API changes](https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md) are included, [additive changes](https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#additive-changes) must be approved by at least two [OWNERS](https://github.com/tektoncd/pipeline/blob/master/OWNERS) and [backwards incompatible changes](https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-incompatible-changes) must be approved by [more than 50% of the OWNERS](https://github.com/tektoncd/pipeline/blob/master/OWNERS), and they must first be added [in a backwards compatible way](https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-compatible-changes-first).\r\n\r\n# Release Notes\r\n\r\n```\r\nDescribe any user facing changes here, or delete this block.\r\n\r\nExamples of user facing changes:\r\n- API changes\r\n- Bug fixes\r\n- Any changes in behavior\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/tektoncd/pipeline/issues/comments/559263444","html_url":"https://github.com/tektoncd/pipeline/pull/1638#issuecomment-559263444","issue_url":"https://api.github.com/repos/tektoncd/pipeline/issues/1638","id":559263444,"node_id":"MDEyOklzc3VlQ29tbWVudDU1OTI2MzQ0NA==","user":{"login":"tekton-robot","id":48335577,"node_id":"MDQ6VXNlcjQ4MzM1NTc3","avatar_url":"https://avatars3.githubusercontent.com/u/48335577?v=4","gravatar_id":"","url":"https://api.github.com/users/tekton-robot","html_url":"https://github.com/tekton-robot","followers_url":"https://api.github.com/users/tekton-robot/followers","following_url":"https://api.github.com/users/tekton-robot/following{/other_user}","gists_url":"https://api.github.com/users/tekton-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/tekton-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekton-robot/subscriptions","organizations_url":"https://api.github.com/users/tekton-robot/orgs","repos_url":"https://api.github.com/users/tekton-robot/repos","events_url":"https://api.github.com/users/tekton-robot/events{/privacy}","received_events_url":"https://api.github.com/users/tekton-robot/received_events","type":"User","site_admin":false},"created_at":"2019-11-27T21:53:57Z","updated_at":"2019-11-27T21:53:57Z","author_association":"COLLABORATOR","body":"@poy: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-tekton-pipeline-unit-tests | a7d2ddc724454ab0cd258acd9596a1f7c4580be8 | [link](https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/1638/pull-tekton-pipeline-unit-tests/1199807810544603137/) | `/test tekton-pipeline-unit-tests`\n\n[Full PR test history](https://tekton-releases.appspot.com/pr/tektoncd_pipeline/1638). [Your PR dashboard](https://prow.tekton.dev/pr/poy).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
other: {"actor":{"display_login":"tekton-robot"}}