payload: {"action":"created","issue":{"url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer/issues/1","repository_url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer","labels_url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer/issues/1/comments","events_url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer/issues/1/events","html_url":"https://github.com/agoose77/jupyterlab-log-renderer/issues/1","id":542796152,"node_id":"MDU6SXNzdWU1NDI3OTYxNTI=","number":1,"title":"Extra lines in log when level is below warning","user":{"login":"thdhondt","id":9611679,"node_id":"MDQ6VXNlcjk2MTE2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/9611679?v=4","gravatar_id":"","url":"https://api.github.com/users/thdhondt","html_url":"https://github.com/thdhondt","followers_url":"https://api.github.com/users/thdhondt/followers","following_url":"https://api.github.com/users/thdhondt/following{/other_user}","gists_url":"https://api.github.com/users/thdhondt/gists{/gist_id}","starred_url":"https://api.github.com/users/thdhondt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thdhondt/subscriptions","organizations_url":"https://api.github.com/users/thdhondt/orgs","repos_url":"https://api.github.com/users/thdhondt/repos","events_url":"https://api.github.com/users/thdhondt/events{/privacy}","received_events_url":"https://api.github.com/users/thdhondt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-12-27T08:35:17Z","updated_at":"2019-12-27T20:39:32Z","closed_at":null,"author_association":"NONE","body":"First of all, thanks a lot for your work on this repo! \r\n\r\nI have been trying to use this work for a personal project where logging from my Python code to a Jupyterlab interface would be really useful.\r\n\r\nI have however encountered an issue when setting the logging level on info or lower in the log viewer. Every time I log a message (with any level), I will see three lines in the log viewer:\r\n- Two times the log message at the initial log level \r\n- One empty log message at the info level\r\nHere is an image that illustrates this:\r\n![image](https://user-images.githubusercontent.com/9611679/71509206-df967980-288a-11ea-8ab2-ad79db77c4f3.png)\r\n\r\nThis is the piece of code that creates the issue:\r\n![image](https://user-images.githubusercontent.com/9611679/71509222-ecb36880-288a-11ea-96af-76ace8c01816.png)\r\nI have used the logging handler class provided in your jupyter demo directory.\r\n\r\nAs far as the white line is concerned, it could come from the the white line that is output by the display call inside the logger. You can see this white line in the previous image. Calling multiple time the logger inside a same cell keeps adding those white lines and the output cell grows.\r\n\r\nAny idea where those issues might come from?\r\nDo you see the same behavior on your side? \r\nIs this something related to this repository or rather to the log console inside Jupyter?\r\n\r\nThanks in advance for your help :)."},"comment":{"url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer/issues/comments/569342092","html_url":"https://github.com/agoose77/jupyterlab-log-renderer/issues/1#issuecomment-569342092","issue_url":"https://api.github.com/repos/agoose77/jupyterlab-log-renderer/issues/1","id":569342092,"node_id":"MDEyOklzc3VlQ29tbWVudDU2OTM0MjA5Mg==","user":{"login":"agoose77","id":1248413,"node_id":"MDQ6VXNlcjEyNDg0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1248413?v=4","gravatar_id":"","url":"https://api.github.com/users/agoose77","html_url":"https://github.com/agoose77","followers_url":"https://api.github.com/users/agoose77/followers","following_url":"https://api.github.com/users/agoose77/following{/other_user}","gists_url":"https://api.github.com/users/agoose77/gists{/gist_id}","starred_url":"https://api.github.com/users/agoose77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoose77/subscriptions","organizations_url":"https://api.github.com/users/agoose77/orgs","repos_url":"https://api.github.com/users/agoose77/repos","events_url":"https://api.github.com/users/agoose77/events{/privacy}","received_events_url":"https://api.github.com/users/agoose77/received_events","type":"User","site_admin":false},"created_at":"2019-12-27T20:39:32Z","updated_at":"2019-12-27T20:39:32Z","author_association":"OWNER","body":"Hi @thdhondt,\r\nThanks for the feedback.\r\n\r\nI've also noticed this. The reason for this is that the current implementation of JupyterLab's log console automatically logs any cell output (regardless of whether it is \"caught\" or not by the display handler) if the log console level is set to a value lower (or equal IIRC) to a chosen value. TL;DR, JLab shows any cell outputs in the log, if the console is set to INFO. \r\n\r\nOf course, my demo calls `display()` explicitly, so we already render once to the log console once, and this is why you get _two_ entries.\r\n\r\nI'm not sure of the best solution to this yet - it would need to be on the JupyterLab side really, otherwise I would have to write a lot of code to check if the output had already been logged (which would get quite hacky). Jason Grout had some ideas over on the Gitter chat, but I haven't had any time to think about them yet :/"}}
other: {"actor":{"display_login":"agoose77"}}