payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/327244439","pull_request_review_id":291945164,"id":327244439,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzI0NDQzOQ==","diff_hunk":"@@ -136,7 +136,7 @@ func convertQuantityToQemuSize(size resource.Quantity) string {\n }\n \n func (o *qemuOperations) Resize(image string, size resource.Quantity) error {\n-\t_, err := qemuExecFunction(nil, nil, \"qemu-img\", \"resize\", \"-f\", \"raw\", image, convertQuantityToQemuSize(size))\n+\t_, err := qemuExecFunction(nil, nil, \"qemu-img\", \"resize\", \"-f\", \"raw\", \"--preallocation=falloc\", image, convertQuantityToQemuSize(size))","path":"pkg/image/qemu.go","position":5,"original_position":5,"commit_id":"5109eef828ab5e1210b07a0e00ad03580760fec5","original_commit_id":"5109eef828ab5e1210b07a0e00ad03580760fec5","user":{"login":"gsr-shanks","id":1453085,"node_id":"MDQ6VXNlcjE0NTMwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1453085?v=4","gravatar_id":"","url":"https://api.github.com/users/gsr-shanks","html_url":"https://github.com/gsr-shanks","followers_url":"https://api.github.com/users/gsr-shanks/followers","following_url":"https://api.github.com/users/gsr-shanks/following{/other_user}","gists_url":"https://api.github.com/users/gsr-shanks/gists{/gist_id}","starred_url":"https://api.github.com/users/gsr-shanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsr-shanks/subscriptions","organizations_url":"https://api.github.com/users/gsr-shanks/orgs","repos_url":"https://api.github.com/users/gsr-shanks/repos","events_url":"https://api.github.com/users/gsr-shanks/events{/privacy}","received_events_url":"https://api.github.com/users/gsr-shanks/received_events","type":"User","site_admin":false},"body":"Looks like we are missing \"-o\" here ?","created_at":"2019-09-23T17:43:29Z","updated_at":"2019-09-23T17:43:29Z","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/970#discussion_r327244439","pull_request_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/327244439"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/970#discussion_r327244439"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970","id":320385936,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwMzg1OTM2","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/970","diff_url":"https://github.com/kubevirt/containerized-data-importer/pull/970.diff","patch_url":"https://github.com/kubevirt/containerized-data-importer/pull/970.patch","issue_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/970","number":970,"state":"open","locked":false,"title":"falloc on resize and blank disk.","user":{"login":"awels","id":4523502,"node_id":"MDQ6VXNlcjQ1MjM1MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4523502?v=4","gravatar_id":"","url":"https://api.github.com/users/awels","html_url":"https://github.com/awels","followers_url":"https://api.github.com/users/awels/followers","following_url":"https://api.github.com/users/awels/following{/other_user}","gists_url":"https://api.github.com/users/awels/gists{/gist_id}","starred_url":"https://api.github.com/users/awels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awels/subscriptions","organizations_url":"https://api.github.com/users/awels/orgs","repos_url":"https://api.github.com/users/awels/repos","events_url":"https://api.github.com/users/awels/events{/privacy}","received_events_url":"https://api.github.com/users/awels/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Alexander Wels <awels@redhat.com>\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nUse falloc when resizing/creating blank to make sure we can guarantee the space reported is available for VMs.\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nResize/Blank disk now use falloc instead of being sparse to guarantee available space.\r\n```\r\n\r\n","created_at":"2019-09-23T16:46:19Z","updated_at":"2019-09-23T17:43:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"027fbe0a6583fc81e276e860c7f32c2af7b607e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1052058295,"node_id":"MDU6TGFiZWwxMDUyMDU4Mjk1","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":1051871092,"node_id":"MDU6TGFiZWwxMDUxODcxMDky","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":1051873433,"node_id":"MDU6TGFiZWwxMDUxODczNDMz","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970/commits","review_comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970/comments","review_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/970/comments","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/5109eef828ab5e1210b07a0e00ad03580760fec5","head":{"label":"awels:backoff_size","ref":"backoff_size","sha":"5109eef828ab5e1210b07a0e00ad03580760fec5","user":{"login":"awels","id":4523502,"node_id":"MDQ6VXNlcjQ1MjM1MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4523502?v=4","gravatar_id":"","url":"https://api.github.com/users/awels","html_url":"https://github.com/awels","followers_url":"https://api.github.com/users/awels/followers","following_url":"https://api.github.com/users/awels/following{/other_user}","gists_url":"https://api.github.com/users/awels/gists{/gist_id}","starred_url":"https://api.github.com/users/awels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awels/subscriptions","organizations_url":"https://api.github.com/users/awels/orgs","repos_url":"https://api.github.com/users/awels/repos","events_url":"https://api.github.com/users/awels/events{/privacy}","received_events_url":"https://api.github.com/users/awels/received_events","type":"User","site_admin":false},"repo":{"id":134304931,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzMDQ5MzE=","name":"containerized-data-importer","full_name":"awels/containerized-data-importer","private":false,"owner":{"login":"awels","id":4523502,"node_id":"MDQ6VXNlcjQ1MjM1MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4523502?v=4","gravatar_id":"","url":"https://api.github.com/users/awels","html_url":"https://github.com/awels","followers_url":"https://api.github.com/users/awels/followers","following_url":"https://api.github.com/users/awels/following{/other_user}","gists_url":"https://api.github.com/users/awels/gists{/gist_id}","starred_url":"https://api.github.com/users/awels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awels/subscriptions","organizations_url":"https://api.github.com/users/awels/orgs","repos_url":"https://api.github.com/users/awels/repos","events_url":"https://api.github.com/users/awels/events{/privacy}","received_events_url":"https://api.github.com/users/awels/received_events","type":"User","site_admin":false},"html_url":"https://github.com/awels/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":true,"url":"https://api.github.com/repos/awels/containerized-data-importer","forks_url":"https://api.github.com/repos/awels/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/awels/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awels/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awels/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/awels/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/awels/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/awels/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/awels/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/awels/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/awels/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/awels/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awels/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awels/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/awels/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awels/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/awels/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/awels/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/awels/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/awels/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/awels/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/awels/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/awels/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/awels/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/awels/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/awels/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/awels/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awels/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/awels/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awels/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/awels/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/awels/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/awels/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/awels/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awels/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/awels/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/awels/containerized-data-importer/deployments","created_at":"2018-05-21T17:52:31Z","updated_at":"2019-09-19T11:21:58Z","pushed_at":"2019-09-23T16:44:23Z","git_url":"git://github.com/awels/containerized-data-importer.git","ssh_url":"git@github.com:awels/containerized-data-importer.git","clone_url":"https://github.com/awels/containerized-data-importer.git","svn_url":"https://github.com/awels/containerized-data-importer","homepage":"","size":117025,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"47fbebad420117ce95057577172a0e3efdcfbe39","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":117756215,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NTYyMTU=","name":"containerized-data-importer","full_name":"kubevirt/containerized-data-importer","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":false,"url":"https://api.github.com/repos/kubevirt/containerized-data-importer","forks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/deployments","created_at":"2018-01-16T23:35:48Z","updated_at":"2019-09-23T17:24:02Z","pushed_at":"2019-09-23T17:24:00Z","git_url":"git://github.com/kubevirt/containerized-data-importer.git","ssh_url":"git@github.com:kubevirt/containerized-data-importer.git","clone_url":"https://github.com/kubevirt/containerized-data-importer.git","svn_url":"https://github.com/kubevirt/containerized-data-importer","homepage":"","size":117029,"stargazers_count":152,"watchers_count":152,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":24,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/970"},"issue":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/970"},"comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/970/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/970/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/5109eef828ab5e1210b07a0e00ad03580760fec5"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"gsr-shanks"}}