payload: {"action":"opened","number":1306,"pull_request":{"url":"https://api.github.com/repos/diasurgical/devilution/pulls/1306","id":297352575,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MzUyNTc1","html_url":"https://github.com/diasurgical/devilution/pull/1306","diff_url":"https://github.com/diasurgical/devilution/pull/1306.diff","patch_url":"https://github.com/diasurgical/devilution/pull/1306.patch","issue_url":"https://api.github.com/repos/diasurgical/devilution/issues/1306","number":1306,"state":"open","locked":false,"title":"Dmax renames","user":{"login":"BorisTheBrave","id":183773,"node_id":"MDQ6VXNlcjE4Mzc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/183773?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisTheBrave","html_url":"https://github.com/BorisTheBrave","followers_url":"https://api.github.com/users/BorisTheBrave/followers","following_url":"https://api.github.com/users/BorisTheBrave/following{/other_user}","gists_url":"https://api.github.com/users/BorisTheBrave/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisTheBrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisTheBrave/subscriptions","organizations_url":"https://api.github.com/users/BorisTheBrave/orgs","repos_url":"https://api.github.com/users/BorisTheBrave/repos","events_url":"https://api.github.com/users/BorisTheBrave/events{/privacy}","received_events_url":"https://api.github.com/users/BorisTheBrave/received_events","type":"User","site_admin":false},"body":"I've not actually compiled this code, so I've stuck with very basic changes that I can be confident will compile and give byte identical output.\r\n\r\nThis PR is also an introduction. Hello! I've spent the last week reading the dlrg code trying to understand it. I plan to publish a write up of how it all works, shortly. That means I've got a pretty clear idea how this code is meant to work. Please let me know if there's anything useful I can do to contribute based on that knowledge. Are you looking for comments on functions (similar to sanctuary)? What about additional enums or macros to clarify things?\r\n\r\nI've also identified two possible bugs. I've not seen any `BUGFIX` comments except out-of-bounds notes, so I wasn't sure whether you are seeking notes on this.","created_at":"2019-07-13T22:44:36Z","updated_at":"2019-07-13T22:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diasurgical/devilution/pulls/1306/commits","review_comments_url":"https://api.github.com/repos/diasurgical/devilution/pulls/1306/comments","review_comment_url":"https://api.github.com/repos/diasurgical/devilution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diasurgical/devilution/issues/1306/comments","statuses_url":"https://api.github.com/repos/diasurgical/devilution/statuses/6b46bfbaea40a5f53cf7164a5da9f69259fd5c7e","head":{"label":"BorisTheBrave:dmax-renames","ref":"dmax-renames","sha":"6b46bfbaea40a5f53cf7164a5da9f69259fd5c7e","user":{"login":"BorisTheBrave","id":183773,"node_id":"MDQ6VXNlcjE4Mzc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/183773?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisTheBrave","html_url":"https://github.com/BorisTheBrave","followers_url":"https://api.github.com/users/BorisTheBrave/followers","following_url":"https://api.github.com/users/BorisTheBrave/following{/other_user}","gists_url":"https://api.github.com/users/BorisTheBrave/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisTheBrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisTheBrave/subscriptions","organizations_url":"https://api.github.com/users/BorisTheBrave/orgs","repos_url":"https://api.github.com/users/BorisTheBrave/repos","events_url":"https://api.github.com/users/BorisTheBrave/events{/privacy}","received_events_url":"https://api.github.com/users/BorisTheBrave/received_events","type":"User","site_admin":false},"repo":{"id":196771860,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY3NzE4NjA=","name":"devilution","full_name":"BorisTheBrave/devilution","private":false,"owner":{"login":"BorisTheBrave","id":183773,"node_id":"MDQ6VXNlcjE4Mzc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/183773?v=4","gravatar_id":"","url":"https://api.github.com/users/BorisTheBrave","html_url":"https://github.com/BorisTheBrave","followers_url":"https://api.github.com/users/BorisTheBrave/followers","following_url":"https://api.github.com/users/BorisTheBrave/following{/other_user}","gists_url":"https://api.github.com/users/BorisTheBrave/gists{/gist_id}","starred_url":"https://api.github.com/users/BorisTheBrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorisTheBrave/subscriptions","organizations_url":"https://api.github.com/users/BorisTheBrave/orgs","repos_url":"https://api.github.com/users/BorisTheBrave/repos","events_url":"https://api.github.com/users/BorisTheBrave/events{/privacy}","received_events_url":"https://api.github.com/users/BorisTheBrave/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BorisTheBrave/devilution","description":"Diablo devolved - magic behind the 1996 computer game","fork":true,"url":"https://api.github.com/repos/BorisTheBrave/devilution","forks_url":"https://api.github.com/repos/BorisTheBrave/devilution/forks","keys_url":"https://api.github.com/repos/BorisTheBrave/devilution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BorisTheBrave/devilution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BorisTheBrave/devilution/teams","hooks_url":"https://api.github.com/repos/BorisTheBrave/devilution/hooks","issue_events_url":"https://api.github.com/repos/BorisTheBrave/devilution/issues/events{/number}","events_url":"https://api.github.com/repos/BorisTheBrave/devilution/events","assignees_url":"https://api.github.com/repos/BorisTheBrave/devilution/assignees{/user}","branches_url":"https://api.github.com/repos/BorisTheBrave/devilution/branches{/branch}","tags_url":"https://api.github.com/repos/BorisTheBrave/devilution/tags","blobs_url":"https://api.github.com/repos/BorisTheBrave/devilution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BorisTheBrave/devilution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BorisTheBrave/devilution/git/refs{/sha}","trees_url":"https://api.github.com/repos/BorisTheBrave/devilution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BorisTheBrave/devilution/statuses/{sha}","languages_url":"https://api.github.com/repos/BorisTheBrave/devilution/languages","stargazers_url":"https://api.github.com/repos/BorisTheBrave/devilution/stargazers","contributors_url":"https://api.github.com/repos/BorisTheBrave/devilution/contributors","subscribers_url":"https://api.github.com/repos/BorisTheBrave/devilution/subscribers","subscription_url":"https://api.github.com/repos/BorisTheBrave/devilution/subscription","commits_url":"https://api.github.com/repos/BorisTheBrave/devilution/commits{/sha}","git_commits_url":"https://api.github.com/repos/BorisTheBrave/devilution/git/commits{/sha}","comments_url":"https://api.github.com/repos/BorisTheBrave/devilution/comments{/number}","issue_comment_url":"https://api.github.com/repos/BorisTheBrave/devilution/issues/comments{/number}","contents_url":"https://api.github.com/repos/BorisTheBrave/devilution/contents/{+path}","compare_url":"https://api.github.com/repos/BorisTheBrave/devilution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BorisTheBrave/devilution/merges","archive_url":"https://api.github.com/repos/BorisTheBrave/devilution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BorisTheBrave/devilution/downloads","issues_url":"https://api.github.com/repos/BorisTheBrave/devilution/issues{/number}","pulls_url":"https://api.github.com/repos/BorisTheBrave/devilution/pulls{/number}","milestones_url":"https://api.github.com/repos/BorisTheBrave/devilution/milestones{/number}","notifications_url":"https://api.github.com/repos/BorisTheBrave/devilution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BorisTheBrave/devilution/labels{/name}","releases_url":"https://api.github.com/repos/BorisTheBrave/devilution/releases{/id}","deployments_url":"https://api.github.com/repos/BorisTheBrave/devilution/deployments","created_at":"2019-07-13T22:32:30Z","updated_at":"2019-07-13T22:32:34Z","pushed_at":"2019-07-13T22:36:21Z","git_url":"git://github.com/BorisTheBrave/devilution.git","ssh_url":"git@github.com:BorisTheBrave/devilution.git","clone_url":"https://github.com/BorisTheBrave/devilution.git","svn_url":"https://github.com/BorisTheBrave/devilution","homepage":"","size":8714,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diasurgical:master","ref":"master","sha":"aa151d98e8067d2af4308ed96b99f14bb6259461","user":{"login":"diasurgical","id":40645014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjQ1MDE0","avatar_url":"https://avatars1.githubusercontent.com/u/40645014?v=4","gravatar_id":"","url":"https://api.github.com/users/diasurgical","html_url":"https://github.com/diasurgical","followers_url":"https://api.github.com/users/diasurgical/followers","following_url":"https://api.github.com/users/diasurgical/following{/other_user}","gists_url":"https://api.github.com/users/diasurgical/gists{/gist_id}","starred_url":"https://api.github.com/users/diasurgical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasurgical/subscriptions","organizations_url":"https://api.github.com/users/diasurgical/orgs","repos_url":"https://api.github.com/users/diasurgical/repos","events_url":"https://api.github.com/users/diasurgical/events{/privacy}","received_events_url":"https://api.github.com/users/diasurgical/received_events","type":"Organization","site_admin":false},"repo":{"id":127684759,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2ODQ3NTk=","name":"devilution","full_name":"diasurgical/devilution","private":false,"owner":{"login":"diasurgical","id":40645014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjQ1MDE0","avatar_url":"https://avatars1.githubusercontent.com/u/40645014?v=4","gravatar_id":"","url":"https://api.github.com/users/diasurgical","html_url":"https://github.com/diasurgical","followers_url":"https://api.github.com/users/diasurgical/followers","following_url":"https://api.github.com/users/diasurgical/following{/other_user}","gists_url":"https://api.github.com/users/diasurgical/gists{/gist_id}","starred_url":"https://api.github.com/users/diasurgical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasurgical/subscriptions","organizations_url":"https://api.github.com/users/diasurgical/orgs","repos_url":"https://api.github.com/users/diasurgical/repos","events_url":"https://api.github.com/users/diasurgical/events{/privacy}","received_events_url":"https://api.github.com/users/diasurgical/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/diasurgical/devilution","description":"Diablo devolved - magic behind the 1996 computer game","fork":false,"url":"https://api.github.com/repos/diasurgical/devilution","forks_url":"https://api.github.com/repos/diasurgical/devilution/forks","keys_url":"https://api.github.com/repos/diasurgical/devilution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diasurgical/devilution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diasurgical/devilution/teams","hooks_url":"https://api.github.com/repos/diasurgical/devilution/hooks","issue_events_url":"https://api.github.com/repos/diasurgical/devilution/issues/events{/number}","events_url":"https://api.github.com/repos/diasurgical/devilution/events","assignees_url":"https://api.github.com/repos/diasurgical/devilution/assignees{/user}","branches_url":"https://api.github.com/repos/diasurgical/devilution/branches{/branch}","tags_url":"https://api.github.com/repos/diasurgical/devilution/tags","blobs_url":"https://api.github.com/repos/diasurgical/devilution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diasurgical/devilution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diasurgical/devilution/git/refs{/sha}","trees_url":"https://api.github.com/repos/diasurgical/devilution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diasurgical/devilution/statuses/{sha}","languages_url":"https://api.github.com/repos/diasurgical/devilution/languages","stargazers_url":"https://api.github.com/repos/diasurgical/devilution/stargazers","contributors_url":"https://api.github.com/repos/diasurgical/devilution/contributors","subscribers_url":"https://api.github.com/repos/diasurgical/devilution/subscribers","subscription_url":"https://api.github.com/repos/diasurgical/devilution/subscription","commits_url":"https://api.github.com/repos/diasurgical/devilution/commits{/sha}","git_commits_url":"https://api.github.com/repos/diasurgical/devilution/git/commits{/sha}","comments_url":"https://api.github.com/repos/diasurgical/devilution/comments{/number}","issue_comment_url":"https://api.github.com/repos/diasurgical/devilution/issues/comments{/number}","contents_url":"https://api.github.com/repos/diasurgical/devilution/contents/{+path}","compare_url":"https://api.github.com/repos/diasurgical/devilution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diasurgical/devilution/merges","archive_url":"https://api.github.com/repos/diasurgical/devilution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diasurgical/devilution/downloads","issues_url":"https://api.github.com/repos/diasurgical/devilution/issues{/number}","pulls_url":"https://api.github.com/repos/diasurgical/devilution/pulls{/number}","milestones_url":"https://api.github.com/repos/diasurgical/devilution/milestones{/number}","notifications_url":"https://api.github.com/repos/diasurgical/devilution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diasurgical/devilution/labels{/name}","releases_url":"https://api.github.com/repos/diasurgical/devilution/releases{/id}","deployments_url":"https://api.github.com/repos/diasurgical/devilution/deployments","created_at":"2018-04-02T01:01:47Z","updated_at":"2019-07-13T18:16:43Z","pushed_at":"2019-07-13T04:02:52Z","git_url":"git://github.com/diasurgical/devilution.git","ssh_url":"git@github.com:diasurgical/devilution.git","clone_url":"https://github.com/diasurgical/devilution.git","svn_url":"https://github.com/diasurgical/devilution","homepage":"","size":8714,"stargazers_count":6556,"watchers_count":6556,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":771,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":771,"open_issues":20,"watchers":6556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/1306"},"html":{"href":"https://github.com/diasurgical/devilution/pull/1306"},"issue":{"href":"https://api.github.com/repos/diasurgical/devilution/issues/1306"},"comments":{"href":"https://api.github.com/repos/diasurgical/devilution/issues/1306/comments"},"review_comments":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/1306/comments"},"review_comment":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/1306/commits"},"statuses":{"href":"https://api.github.com/repos/diasurgical/devilution/statuses/6b46bfbaea40a5f53cf7164a5da9f69259fd5c7e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":136,"deletions":136,"changed_files":4}}
other: {"actor":{"display_login":"BorisTheBrave"}}