payload: {"action":"created","issue":{"url":"https://api.github.com/repos/PCMDI/cmor/issues/367","repository_url":"https://api.github.com/repos/PCMDI/cmor","labels_url":"https://api.github.com/repos/PCMDI/cmor/issues/367/labels{/name}","comments_url":"https://api.github.com/repos/PCMDI/cmor/issues/367/comments","events_url":"https://api.github.com/repos/PCMDI/cmor/issues/367/events","html_url":"https://github.com/PCMDI/cmor/issues/367","id":338880893,"node_id":"MDU6SXNzdWUzMzg4ODA4OTM=","number":367,"title":"PrePARE missing  _FillValue exit","user":{"login":"wachsylon","id":20439919,"node_id":"MDQ6VXNlcjIwNDM5OTE5","avatar_url":"https://avatars0.githubusercontent.com/u/20439919?v=4","gravatar_id":"","url":"https://api.github.com/users/wachsylon","html_url":"https://github.com/wachsylon","followers_url":"https://api.github.com/users/wachsylon/followers","following_url":"https://api.github.com/users/wachsylon/following{/other_user}","gists_url":"https://api.github.com/users/wachsylon/gists{/gist_id}","starred_url":"https://api.github.com/users/wachsylon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachsylon/subscriptions","organizations_url":"https://api.github.com/users/wachsylon/orgs","repos_url":"https://api.github.com/users/wachsylon/repos","events_url":"https://api.github.com/users/wachsylon/events{/privacy}","received_events_url":"https://api.github.com/users/wachsylon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-06T10:03:33Z","updated_at":"2019-06-26T23:48:02Z","closed_at":null,"author_association":"COLLABORATOR","body":"Hi,\r\nI have data files with variables which do not include _FillValue and _MissingValue attributes. This causes the following error wihtin PrePARE:\r\n```\r\nTraceback (most recent call last):\r\n...\r\n  File \"/work/bm0021/miniconda2/envs/cmor/lib/python2.7/site-packages/cmip6_cv/PrePARE/PrePARE.py\", line 446, in ControlVocab\r\n    varmissing = infile.variables[var[0]]._FillValue[0]\r\nAttributeError: _FillValue\r\n```\r\nHowever, I would like to have an overview about all missing or wrong variable attributes so PrePARE should not exit at this point without checking the other ones. I installed it via conda.\r\nIs there already an option to ignore that error or is it a bug?\r\nI have not looked into the src of PrePARE yet.\r\nBest regards,\r\nFabi"},"comment":{"url":"https://api.github.com/repos/PCMDI/cmor/issues/comments/506084645","html_url":"https://github.com/PCMDI/cmor/issues/367#issuecomment-506084645","issue_url":"https://api.github.com/repos/PCMDI/cmor/issues/367","id":506084645,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNjA4NDY0NQ==","user":{"login":"mauzey1","id":42009431,"node_id":"MDQ6VXNlcjQyMDA5NDMx","avatar_url":"https://avatars0.githubusercontent.com/u/42009431?v=4","gravatar_id":"","url":"https://api.github.com/users/mauzey1","html_url":"https://github.com/mauzey1","followers_url":"https://api.github.com/users/mauzey1/followers","following_url":"https://api.github.com/users/mauzey1/following{/other_user}","gists_url":"https://api.github.com/users/mauzey1/gists{/gist_id}","starred_url":"https://api.github.com/users/mauzey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauzey1/subscriptions","organizations_url":"https://api.github.com/users/mauzey1/orgs","repos_url":"https://api.github.com/users/mauzey1/repos","events_url":"https://api.github.com/users/mauzey1/events{/privacy}","received_events_url":"https://api.github.com/users/mauzey1/received_events","type":"User","site_admin":false},"created_at":"2019-06-26T23:48:02Z","updated_at":"2019-06-26T23:48:02Z","author_association":"COLLABORATOR","body":"@taylor13 The variable `basin` in table `Ofx` is the only variable I have found that has the type integer.  \r\nhttps://github.com/PCMDI/cmor/blob/2e9f6b2f6acbd25d15b6c46a26176632c864ac8b/TestTables/CMIP6_Ofx.json#L35-L54\r\nI thought it would use -999 as its missing value.\r\nhttps://github.com/PCMDI/cmor/blob/2e9f6b2f6acbd25d15b6c46a26176632c864ac8b/TestTables/CMIP6_Ofx.json#L9\r\nHowever, when I got a NetCDF file for `basin` from ESGF I found out that it was using 0 as its `missing_value` and `_FillValue`.\r\n\r\nShould we treat `basin` as a special case?  It's the only variable that has the attributes `flag_values` and `flag_meanings`."}}
other: {"actor":{"display_login":"mauzey1"}}