payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments/297189600","pull_request_review_id":254006080,"id":297189600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzE4OTYwMA==","diff_hunk":"@@ -129,6 +155,14 @@ public double LargeChange\n             set => SetValue(LargeChangeProperty, value);\n         }\n \n+        protected override void OnInitialized()\n+        {\n+            base.OnInitialized();\n+\n+            Maximum = ValidateMaximum(Maximum);","path":"src/Avalonia.Controls/Primitives/RangeBase.cs","position":73,"original_position":73,"commit_id":"440af4623550861e917c9ff62f668bc2af7997b9","original_commit_id":"440af4623550861e917c9ff62f668bc2af7997b9","user":{"login":"MarchingCube","id":2588062,"node_id":"MDQ6VXNlcjI1ODgwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/2588062?v=4","gravatar_id":"","url":"https://api.github.com/users/MarchingCube","html_url":"https://github.com/MarchingCube","followers_url":"https://api.github.com/users/MarchingCube/followers","following_url":"https://api.github.com/users/MarchingCube/following{/other_user}","gists_url":"https://api.github.com/users/MarchingCube/gists{/gist_id}","starred_url":"https://api.github.com/users/MarchingCube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarchingCube/subscriptions","organizations_url":"https://api.github.com/users/MarchingCube/orgs","repos_url":"https://api.github.com/users/MarchingCube/repos","events_url":"https://api.github.com/users/MarchingCube/events{/privacy}","received_events_url":"https://api.github.com/users/MarchingCube/received_events","type":"User","site_admin":false},"body":"I think we need to apply `Minimum` here as well.","created_at":"2019-06-25T13:32:35Z","updated_at":"2019-06-25T13:32:35Z","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/2683#discussion_r297189600","pull_request_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments/297189600"},"html":{"href":"https://github.com/AvaloniaUI/Avalonia/pull/2683#discussion_r297189600"},"pull_request":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683"}}},"pull_request":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683","id":291547743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxNTQ3NzQz","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/2683","diff_url":"https://github.com/AvaloniaUI/Avalonia/pull/2683.diff","patch_url":"https://github.com/AvaloniaUI/Avalonia/pull/2683.patch","issue_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2683","number":2683,"state":"open","locked":false,"title":" Don't coerce RangeBase values until initialized.","user":{"login":"grokys","id":1775141,"node_id":"MDQ6VXNlcjE3NzUxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1775141?v=4","gravatar_id":"","url":"https://api.github.com/users/grokys","html_url":"https://github.com/grokys","followers_url":"https://api.github.com/users/grokys/followers","following_url":"https://api.github.com/users/grokys/following{/other_user}","gists_url":"https://api.github.com/users/grokys/gists{/gist_id}","starred_url":"https://api.github.com/users/grokys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokys/subscriptions","organizations_url":"https://api.github.com/users/grokys/orgs","repos_url":"https://api.github.com/users/grokys/repos","events_url":"https://api.github.com/users/grokys/events{/privacy}","received_events_url":"https://api.github.com/users/grokys/received_events","type":"User","site_admin":false},"body":"## What does the pull request do?\r\n\r\nAs described in #2372, the order that the `Minimum`, `Maximum` and `Value` properties on `RangeBase`-derived controls were set in XAML affected the final values.\r\n\r\nTo fix this, don't coerce the properties until initialization has finished and we know that we have all the information we need.\r\n\r\nAlso added a virtual `OnInitialized` method to `StyledElement` so that a control can easily react to its own initialization.\r\n\r\n## Checklist\r\n\r\n- [x] Added unit tests (if possible)?\r\n\r\n## Fixed issues\r\n\r\nFixes #2372\r\n","created_at":"2019-06-25T13:05:57Z","updated_at":"2019-06-25T13:32:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca2c57c938716151375b3c0d6d560938048feff7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"core","id":1785154,"node_id":"MDQ6VGVhbTE3ODUxNTQ=","slug":"core","description":"Core team","privacy":"closed","url":"https://api.github.com/teams/1785154","html_url":"https://github.com/orgs/AvaloniaUI/teams/core","members_url":"https://api.github.com/teams/1785154/members{/member}","repositories_url":"https://api.github.com/teams/1785154/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683/commits","review_comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683/comments","review_comment_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2683/comments","statuses_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/440af4623550861e917c9ff62f668bc2af7997b9","head":{"label":"AvaloniaUI:fixes/2372-slider-coercion","ref":"fixes/2372-slider-coercion","sha":"440af4623550861e917c9ff62f668bc2af7997b9","user":{"login":"AvaloniaUI","id":14075148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDc1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/14075148?v=4","gravatar_id":"","url":"https://api.github.com/users/AvaloniaUI","html_url":"https://github.com/AvaloniaUI","followers_url":"https://api.github.com/users/AvaloniaUI/followers","following_url":"https://api.github.com/users/AvaloniaUI/following{/other_user}","gists_url":"https://api.github.com/users/AvaloniaUI/gists{/gist_id}","starred_url":"https://api.github.com/users/AvaloniaUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvaloniaUI/subscriptions","organizations_url":"https://api.github.com/users/AvaloniaUI/orgs","repos_url":"https://api.github.com/users/AvaloniaUI/repos","events_url":"https://api.github.com/users/AvaloniaUI/events{/privacy}","received_events_url":"https://api.github.com/users/AvaloniaUI/received_events","type":"Organization","site_admin":false},"repo":{"id":14964475,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NDQ3NQ==","name":"Avalonia","full_name":"AvaloniaUI/Avalonia","private":false,"owner":{"login":"AvaloniaUI","id":14075148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDc1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/14075148?v=4","gravatar_id":"","url":"https://api.github.com/users/AvaloniaUI","html_url":"https://github.com/AvaloniaUI","followers_url":"https://api.github.com/users/AvaloniaUI/followers","following_url":"https://api.github.com/users/AvaloniaUI/following{/other_user}","gists_url":"https://api.github.com/users/AvaloniaUI/gists{/gist_id}","starred_url":"https://api.github.com/users/AvaloniaUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvaloniaUI/subscriptions","organizations_url":"https://api.github.com/users/AvaloniaUI/orgs","repos_url":"https://api.github.com/users/AvaloniaUI/repos","events_url":"https://api.github.com/users/AvaloniaUI/events{/privacy}","received_events_url":"https://api.github.com/users/AvaloniaUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AvaloniaUI/Avalonia","description":"A multi-platform .NET UI framework","fork":false,"url":"https://api.github.com/repos/AvaloniaUI/Avalonia","forks_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/forks","keys_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/teams","hooks_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/hooks","issue_events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/events{/number}","events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/events","assignees_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/assignees{/user}","branches_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/branches{/branch}","tags_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/tags","blobs_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/refs{/sha}","trees_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/{sha}","languages_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/languages","stargazers_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/stargazers","contributors_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/contributors","subscribers_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/subscribers","subscription_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/subscription","commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/commits{/sha}","git_commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/commits{/sha}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/comments{/number}","issue_comment_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/comments{/number}","contents_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/contents/{+path}","compare_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/merges","archive_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/downloads","issues_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues{/number}","pulls_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls{/number}","milestones_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/milestones{/number}","notifications_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/labels{/name}","releases_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/releases{/id}","deployments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/deployments","created_at":"2013-12-05T20:13:21Z","updated_at":"2019-06-25T13:29:51Z","pushed_at":"2019-06-25T13:05:58Z","git_url":"git://github.com/AvaloniaUI/Avalonia.git","ssh_url":"git@github.com:AvaloniaUI/Avalonia.git","clone_url":"https://github.com/AvaloniaUI/Avalonia.git","svn_url":"https://github.com/AvaloniaUI/Avalonia","homepage":"http://avaloniaui.net","size":62330,"stargazers_count":6695,"watchers_count":6695,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":615,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":420,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":615,"open_issues":420,"watchers":6695,"default_branch":"master"}},"base":{"label":"AvaloniaUI:master","ref":"master","sha":"8876d3a4e02189f830ac4fb9c83a1ee503742ac6","user":{"login":"AvaloniaUI","id":14075148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDc1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/14075148?v=4","gravatar_id":"","url":"https://api.github.com/users/AvaloniaUI","html_url":"https://github.com/AvaloniaUI","followers_url":"https://api.github.com/users/AvaloniaUI/followers","following_url":"https://api.github.com/users/AvaloniaUI/following{/other_user}","gists_url":"https://api.github.com/users/AvaloniaUI/gists{/gist_id}","starred_url":"https://api.github.com/users/AvaloniaUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvaloniaUI/subscriptions","organizations_url":"https://api.github.com/users/AvaloniaUI/orgs","repos_url":"https://api.github.com/users/AvaloniaUI/repos","events_url":"https://api.github.com/users/AvaloniaUI/events{/privacy}","received_events_url":"https://api.github.com/users/AvaloniaUI/received_events","type":"Organization","site_admin":false},"repo":{"id":14964475,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NDQ3NQ==","name":"Avalonia","full_name":"AvaloniaUI/Avalonia","private":false,"owner":{"login":"AvaloniaUI","id":14075148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDc1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/14075148?v=4","gravatar_id":"","url":"https://api.github.com/users/AvaloniaUI","html_url":"https://github.com/AvaloniaUI","followers_url":"https://api.github.com/users/AvaloniaUI/followers","following_url":"https://api.github.com/users/AvaloniaUI/following{/other_user}","gists_url":"https://api.github.com/users/AvaloniaUI/gists{/gist_id}","starred_url":"https://api.github.com/users/AvaloniaUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvaloniaUI/subscriptions","organizations_url":"https://api.github.com/users/AvaloniaUI/orgs","repos_url":"https://api.github.com/users/AvaloniaUI/repos","events_url":"https://api.github.com/users/AvaloniaUI/events{/privacy}","received_events_url":"https://api.github.com/users/AvaloniaUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AvaloniaUI/Avalonia","description":"A multi-platform .NET UI framework","fork":false,"url":"https://api.github.com/repos/AvaloniaUI/Avalonia","forks_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/forks","keys_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/teams","hooks_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/hooks","issue_events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/events{/number}","events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/events","assignees_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/assignees{/user}","branches_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/branches{/branch}","tags_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/tags","blobs_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/refs{/sha}","trees_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/{sha}","languages_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/languages","stargazers_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/stargazers","contributors_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/contributors","subscribers_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/subscribers","subscription_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/subscription","commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/commits{/sha}","git_commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/commits{/sha}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/comments{/number}","issue_comment_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/comments{/number}","contents_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/contents/{+path}","compare_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/merges","archive_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/downloads","issues_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues{/number}","pulls_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls{/number}","milestones_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/milestones{/number}","notifications_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/labels{/name}","releases_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/releases{/id}","deployments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/deployments","created_at":"2013-12-05T20:13:21Z","updated_at":"2019-06-25T13:29:51Z","pushed_at":"2019-06-25T13:05:58Z","git_url":"git://github.com/AvaloniaUI/Avalonia.git","ssh_url":"git@github.com:AvaloniaUI/Avalonia.git","clone_url":"https://github.com/AvaloniaUI/Avalonia.git","svn_url":"https://github.com/AvaloniaUI/Avalonia","homepage":"http://avaloniaui.net","size":62330,"stargazers_count":6695,"watchers_count":6695,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":615,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":420,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":615,"open_issues":420,"watchers":6695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683"},"html":{"href":"https://github.com/AvaloniaUI/Avalonia/pull/2683"},"issue":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2683"},"comments":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2683/comments"},"review_comments":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683/comments"},"review_comment":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2683/commits"},"statuses":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/440af4623550861e917c9ff62f668bc2af7997b9"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"MarchingCube"}}