payload: {"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/comments/278776124","pull_request_review_id":230939713,"id":278776124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODc3NjEyNA==","diff_hunk":"@@ -411,10 +411,15 @@ struct snd_sof_dev {\n \tstruct snd_dma_buffer dmatb;\n \tstruct snd_dma_buffer dmatp;\n \tint dma_trace_pages;\n-\twait_queue_head_t trace_sleep;\n \tu32 host_offset;\n-\tu32 dtrace_is_enabled;\n-\tu32 dtrace_error;\n+\tunsigned int dtrace_is_enabled:1; /* FW DMA trace is active */\n+\tunsigned int dtrace_error:1;      /* FW sent non-recoverable error */\n+\n+\t/* DFS trace client state */\n+\twait_queue_head_t dftrace_sleep;","path":"sound/soc/sof/sof-priv.h","position":12,"original_position":12,"commit_id":"d5897a31374e75ce0750f981e8ecc79675af9eb1","original_commit_id":"d5897a31374e75ce0750f981e8ecc79675af9eb1","user":{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},"body":"Not sure I see the  point of renaming this? we have a mix of 'trace', 'dtrace', 'dftrace' and it starts to look messy? ","created_at":"2019-04-26T00:27:47Z","updated_at":"2019-04-26T00:34:20Z","html_url":"https://github.com/thesofproject/linux/pull/781#discussion_r278776124","pull_request_url":"https://api.github.com/repos/thesofproject/linux/pulls/781","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments/278776124"},"html":{"href":"https://github.com/thesofproject/linux/pull/781#discussion_r278776124"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/781"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/781","id":267123024,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3MTIzMDI0","html_url":"https://github.com/thesofproject/linux/pull/781","diff_url":"https://github.com/thesofproject/linux/pull/781.diff","patch_url":"https://github.com/thesofproject/linux/pull/781.patch","issue_url":"https://api.github.com/repos/thesofproject/linux/issues/781","number":781,"state":"open","locked":false,"title":"ASoC: SOF: force end-of-file for debugfs trace at suspend","user":{"login":"kv2019i","id":46528387,"node_id":"MDQ6VXNlcjQ2NTI4Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/46528387?v=4","gravatar_id":"","url":"https://api.github.com/users/kv2019i","html_url":"https://github.com/kv2019i","followers_url":"https://api.github.com/users/kv2019i/followers","following_url":"https://api.github.com/users/kv2019i/following{/other_user}","gists_url":"https://api.github.com/users/kv2019i/gists{/gist_id}","starred_url":"https://api.github.com/users/kv2019i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kv2019i/subscriptions","organizations_url":"https://api.github.com/users/kv2019i/orgs","repos_url":"https://api.github.com/users/kv2019i/repos","events_url":"https://api.github.com/users/kv2019i/events{/privacy}","received_events_url":"https://api.github.com/users/kv2019i/received_events","type":"User","site_admin":false},"body":"Current trace implementation gets out of sync when sof device is\r\nput to suspend. The debugfs file handle is kept open, but\r\nfirmware will reset its state. After resume, debugfs client's read\r\noffset will not be synchronized to firmware and this may result\r\nin traces read in incorrect order and/or stale data being read\r\nafter resume.\r\n\r\nChangelog:\r\n- 24th Apr: Updated patchset with simplified code. Reworked to signal EOF only once so that this works with old and new sof-loggers. \r\n- 11th Apr: Revised patchset to address comments so far, no longer RFC\r\n- 3th Aprh: initial patchset (RFC)\r\n\r\nRelated patches:\r\n- sof-logger patch PR1312 (need not be merged at the same time)\r\n   https://github.com/thesofproject/sof/pull/1312\r\n\r\n~~ Issues handled in previous iterations~~:\r\n - ~~this is not full alternative but has overlap with issue #306 (and related PR)~~ -> this can be merged as incremental update\r\n - ~~locking needs to be revisited still (I'll go through this if we move forward)~~ -> handled in PR800\r\n - ~~having multiple u32 entries for various single-bit pieces of dtrace info in sof-priv.h is ugly, I'd like to combine these~~ -> sorted in 11th April push \r\n","created_at":"2019-04-03T16:28:08Z","updated_at":"2019-04-26T00:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7920d0f5b87d347b84552e4a2eff39533e1b848c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"juimonen","id":1136650,"node_id":"MDQ6VXNlcjExMzY2NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1136650?v=4","gravatar_id":"","url":"https://api.github.com/users/juimonen","html_url":"https://github.com/juimonen","followers_url":"https://api.github.com/users/juimonen/followers","following_url":"https://api.github.com/users/juimonen/following{/other_user}","gists_url":"https://api.github.com/users/juimonen/gists{/gist_id}","starred_url":"https://api.github.com/users/juimonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juimonen/subscriptions","organizations_url":"https://api.github.com/users/juimonen/orgs","repos_url":"https://api.github.com/users/juimonen/repos","events_url":"https://api.github.com/users/juimonen/events{/privacy}","received_events_url":"https://api.github.com/users/juimonen/received_events","type":"User","site_admin":false},{"login":"lyakh","id":1363683,"node_id":"MDQ6VXNlcjEzNjM2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1363683?v=4","gravatar_id":"","url":"https://api.github.com/users/lyakh","html_url":"https://github.com/lyakh","followers_url":"https://api.github.com/users/lyakh/followers","following_url":"https://api.github.com/users/lyakh/following{/other_user}","gists_url":"https://api.github.com/users/lyakh/gists{/gist_id}","starred_url":"https://api.github.com/users/lyakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyakh/subscriptions","organizations_url":"https://api.github.com/users/lyakh/orgs","repos_url":"https://api.github.com/users/lyakh/repos","events_url":"https://api.github.com/users/lyakh/events{/privacy}","received_events_url":"https://api.github.com/users/lyakh/received_events","type":"User","site_admin":false},{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},{"login":"keyonjie","id":10458135,"node_id":"MDQ6VXNlcjEwNDU4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/10458135?v=4","gravatar_id":"","url":"https://api.github.com/users/keyonjie","html_url":"https://github.com/keyonjie","followers_url":"https://api.github.com/users/keyonjie/followers","following_url":"https://api.github.com/users/keyonjie/following{/other_user}","gists_url":"https://api.github.com/users/keyonjie/gists{/gist_id}","starred_url":"https://api.github.com/users/keyonjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyonjie/subscriptions","organizations_url":"https://api.github.com/users/keyonjie/orgs","repos_url":"https://api.github.com/users/keyonjie/repos","events_url":"https://api.github.com/users/keyonjie/events{/privacy}","received_events_url":"https://api.github.com/users/keyonjie/received_events","type":"User","site_admin":false},{"login":"singalsu","id":28754793,"node_id":"MDQ6VXNlcjI4NzU0Nzkz","avatar_url":"https://avatars0.githubusercontent.com/u/28754793?v=4","gravatar_id":"","url":"https://api.github.com/users/singalsu","html_url":"https://github.com/singalsu","followers_url":"https://api.github.com/users/singalsu/followers","following_url":"https://api.github.com/users/singalsu/following{/other_user}","gists_url":"https://api.github.com/users/singalsu/gists{/gist_id}","starred_url":"https://api.github.com/users/singalsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singalsu/subscriptions","organizations_url":"https://api.github.com/users/singalsu/orgs","repos_url":"https://api.github.com/users/singalsu/repos","events_url":"https://api.github.com/users/singalsu/events{/privacy}","received_events_url":"https://api.github.com/users/singalsu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/linux/pulls/781/commits","review_comments_url":"https://api.github.com/repos/thesofproject/linux/pulls/781/comments","review_comment_url":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/linux/issues/781/comments","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/d5897a31374e75ce0750f981e8ecc79675af9eb1","head":{"label":"kv2019i:topic/trace-suspend-fix","ref":"topic/trace-suspend-fix","sha":"d5897a31374e75ce0750f981e8ecc79675af9eb1","user":{"login":"kv2019i","id":46528387,"node_id":"MDQ6VXNlcjQ2NTI4Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/46528387?v=4","gravatar_id":"","url":"https://api.github.com/users/kv2019i","html_url":"https://github.com/kv2019i","followers_url":"https://api.github.com/users/kv2019i/followers","following_url":"https://api.github.com/users/kv2019i/following{/other_user}","gists_url":"https://api.github.com/users/kv2019i/gists{/gist_id}","starred_url":"https://api.github.com/users/kv2019i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kv2019i/subscriptions","organizations_url":"https://api.github.com/users/kv2019i/orgs","repos_url":"https://api.github.com/users/kv2019i/repos","events_url":"https://api.github.com/users/kv2019i/events{/privacy}","received_events_url":"https://api.github.com/users/kv2019i/received_events","type":"User","site_admin":false},"repo":{"id":177140531,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcxNDA1MzE=","name":"linux","full_name":"kv2019i/linux","private":false,"owner":{"login":"kv2019i","id":46528387,"node_id":"MDQ6VXNlcjQ2NTI4Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/46528387?v=4","gravatar_id":"","url":"https://api.github.com/users/kv2019i","html_url":"https://github.com/kv2019i","followers_url":"https://api.github.com/users/kv2019i/followers","following_url":"https://api.github.com/users/kv2019i/following{/other_user}","gists_url":"https://api.github.com/users/kv2019i/gists{/gist_id}","starred_url":"https://api.github.com/users/kv2019i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kv2019i/subscriptions","organizations_url":"https://api.github.com/users/kv2019i/orgs","repos_url":"https://api.github.com/users/kv2019i/repos","events_url":"https://api.github.com/users/kv2019i/events{/privacy}","received_events_url":"https://api.github.com/users/kv2019i/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kv2019i/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/kv2019i/linux","forks_url":"https://api.github.com/repos/kv2019i/linux/forks","keys_url":"https://api.github.com/repos/kv2019i/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kv2019i/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kv2019i/linux/teams","hooks_url":"https://api.github.com/repos/kv2019i/linux/hooks","issue_events_url":"https://api.github.com/repos/kv2019i/linux/issues/events{/number}","events_url":"https://api.github.com/repos/kv2019i/linux/events","assignees_url":"https://api.github.com/repos/kv2019i/linux/assignees{/user}","branches_url":"https://api.github.com/repos/kv2019i/linux/branches{/branch}","tags_url":"https://api.github.com/repos/kv2019i/linux/tags","blobs_url":"https://api.github.com/repos/kv2019i/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kv2019i/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kv2019i/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/kv2019i/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kv2019i/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/kv2019i/linux/languages","stargazers_url":"https://api.github.com/repos/kv2019i/linux/stargazers","contributors_url":"https://api.github.com/repos/kv2019i/linux/contributors","subscribers_url":"https://api.github.com/repos/kv2019i/linux/subscribers","subscription_url":"https://api.github.com/repos/kv2019i/linux/subscription","commits_url":"https://api.github.com/repos/kv2019i/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/kv2019i/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/kv2019i/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/kv2019i/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/kv2019i/linux/contents/{+path}","compare_url":"https://api.github.com/repos/kv2019i/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kv2019i/linux/merges","archive_url":"https://api.github.com/repos/kv2019i/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kv2019i/linux/downloads","issues_url":"https://api.github.com/repos/kv2019i/linux/issues{/number}","pulls_url":"https://api.github.com/repos/kv2019i/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/kv2019i/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/kv2019i/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kv2019i/linux/labels{/name}","releases_url":"https://api.github.com/repos/kv2019i/linux/releases{/id}","deployments_url":"https://api.github.com/repos/kv2019i/linux/deployments","created_at":"2019-03-22T12:58:13Z","updated_at":"2019-03-22T13:06:28Z","pushed_at":"2019-04-24T16:12:49Z","git_url":"git://github.com/kv2019i/linux.git","ssh_url":"git@github.com:kv2019i/linux.git","clone_url":"https://github.com/kv2019i/linux.git","svn_url":"https://github.com/kv2019i/linux","homepage":"","size":3055021,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"topic/sof-dev"}},"base":{"label":"thesofproject:topic/sof-dev","ref":"topic/sof-dev","sha":"2e945691f2c09ddf533e7bab6a875d99ccac7c46","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135611127,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTExMjc=","name":"linux","full_name":"thesofproject/linux","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/thesofproject/linux","forks_url":"https://api.github.com/repos/thesofproject/linux/forks","keys_url":"https://api.github.com/repos/thesofproject/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/linux/teams","hooks_url":"https://api.github.com/repos/thesofproject/linux/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/linux/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/linux/events","assignees_url":"https://api.github.com/repos/thesofproject/linux/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/linux/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/linux/tags","blobs_url":"https://api.github.com/repos/thesofproject/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/linux/languages","stargazers_url":"https://api.github.com/repos/thesofproject/linux/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/linux/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/linux/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/linux/subscription","commits_url":"https://api.github.com/repos/thesofproject/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/linux/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/linux/merges","archive_url":"https://api.github.com/repos/thesofproject/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/linux/downloads","issues_url":"https://api.github.com/repos/thesofproject/linux/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/linux/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/linux/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/linux/deployments","created_at":"2018-05-31T16:47:45Z","updated_at":"2019-04-25T00:52:38Z","pushed_at":"2019-04-25T21:01:46Z","git_url":"git://github.com/thesofproject/linux.git","ssh_url":"git@github.com:thesofproject/linux.git","clone_url":"https://github.com/thesofproject/linux.git","svn_url":"https://github.com/thesofproject/linux","homepage":"","size":3086525,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":89,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":38,"open_issues":89,"watchers":10,"default_branch":"topic/sof-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/781"},"html":{"href":"https://github.com/thesofproject/linux/pull/781"},"issue":{"href":"https://api.github.com/repos/thesofproject/linux/issues/781"},"comments":{"href":"https://api.github.com/repos/thesofproject/linux/issues/781/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/781/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/781/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/linux/statuses/d5897a31374e75ce0750f981e8ecc79675af9eb1"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"plbossart"}}