payload: {"action":"created","comment":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/comments/304323971","pull_request_review_id":262930515,"id":304323971,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDMyMzk3MQ==","diff_hunk":"@@ -1,28 +1,74 @@\n import React from \"react\";\n-import styled from \"styled-components\";\n+import styled, { css } from \"styled-components\";\n+import { rgba } from \"polished\";","path":"packages/article-skeleton/src/sticky-save-and-share-bar.js","position":4,"original_position":4,"commit_id":"28d7f3cce301b1148ab6c6d4961a5b39e41d2bef","original_commit_id":"28d7f3cce301b1148ab6c6d4961a5b39e41d2bef","user":{"login":"aronshamash","id":1736782,"node_id":"MDQ6VXNlcjE3MzY3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1736782?v=4","gravatar_id":"","url":"https://api.github.com/users/aronshamash","html_url":"https://github.com/aronshamash","followers_url":"https://api.github.com/users/aronshamash/followers","following_url":"https://api.github.com/users/aronshamash/following{/other_user}","gists_url":"https://api.github.com/users/aronshamash/gists{/gist_id}","starred_url":"https://api.github.com/users/aronshamash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronshamash/subscriptions","organizations_url":"https://api.github.com/users/aronshamash/orgs","repos_url":"https://api.github.com/users/aronshamash/repos","events_url":"https://api.github.com/users/aronshamash/events{/privacy}","received_events_url":"https://api.github.com/users/aronshamash/received_events","type":"User","site_admin":false},"body":"what does this give us?","created_at":"2019-07-17T10:13:23Z","updated_at":"2019-07-17T10:22:55Z","html_url":"https://github.com/newsuk/times-components/pull/2120#discussion_r304323971","pull_request_url":"https://api.github.com/repos/newsuk/times-components/pulls/2120","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments/304323971"},"html":{"href":"https://github.com/newsuk/times-components/pull/2120#discussion_r304323971"},"pull_request":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/2120"}}},"pull_request":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/2120","id":297156858,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MTU2ODU4","html_url":"https://github.com/newsuk/times-components/pull/2120","diff_url":"https://github.com/newsuk/times-components/pull/2120.diff","patch_url":"https://github.com/newsuk/times-components/pull/2120.patch","issue_url":"https://api.github.com/repos/newsuk/times-components/issues/2120","number":2120,"state":"open","locked":false,"title":"feat: save and share bar styles + animated transition ","user":{"login":"nathggns","id":719814,"node_id":"MDQ6VXNlcjcxOTgxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/719814?v=4","gravatar_id":"","url":"https://api.github.com/users/nathggns","html_url":"https://github.com/nathggns","followers_url":"https://api.github.com/users/nathggns/followers","following_url":"https://api.github.com/users/nathggns/following{/other_user}","gists_url":"https://api.github.com/users/nathggns/gists{/gist_id}","starred_url":"https://api.github.com/users/nathggns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathggns/subscriptions","organizations_url":"https://api.github.com/users/nathggns/orgs","repos_url":"https://api.github.com/users/nathggns/repos","events_url":"https://api.github.com/users/nathggns/events{/privacy}","received_events_url":"https://api.github.com/users/nathggns/received_events","type":"User","site_admin":false},"body":"JIRA ticket: https://nidigitalsolutions.jira.com/browse/REPLAT-6878\r\n\r\nThe save & share bar has had its styles updated, including:\r\n\r\n- Making icon sizes more unified\r\n- Making the hover bubbles circles rather than ovals\r\n- Making the icons centered vertically and horizontally within their bubbles\r\n- Making the icons and labels vertically centered within the save and share bar\r\n- Reducing the height of the save and share bar when sticky\r\n- Making the drop shadow less harsh \r\n- The save/saved label is now right aligned, so that the gap between it and the icon is consistent. \r\n\r\nYou can see the effects of these changes in the below screenshots.\r\n\r\n### Non sticky mode:\r\n\r\n![Screen Shot 2019-07-16 at 11 24 21](https://user-images.githubusercontent.com/719814/61287210-4849d800-a7bc-11e9-9dfd-83032ab22583.png)\r\n\r\n### Sticky mode:\r\n\r\n![Screen Shot 2019-07-16 at 11 12 32](https://user-images.githubusercontent.com/719814/61286495-de7cfe80-a7ba-11e9-8407-d9da5b45fcb7.png)\r\n\r\n### Hover states:\r\n\r\n![Screen Shot 2019-07-16 at 11 23 57](https://user-images.githubusercontent.com/719814/61287219-4da72280-a7bc-11e9-8132-bf8847650000.png)\r\n\r\n## Transition\r\n\r\nHowever, as the save and share bar now changes height between its sticky and non-sticky states, a decision was made to make it smoothly transition between those two heights as you scroll. In order to do that, a \"scroll progress\" tracking feature was introduced as part of the sticky package, allowing you to create styles that are computed as a proportion of the users scroll progress through the sticky elements original position on the page. \r\n\r\nYou can see the transition in the GIF below. It may take a while to load and the quality may be too low, so you can also [download a video copy from slack here](https://newscorp.enterprise.slack.com/files/WEUELNSD7/FL4BJ10UA/save_and_share_bar_transition.mp4)\r\n\r\n![ezgif com-optimize](https://user-images.githubusercontent.com/719814/61286851-9f9b7880-a7bb-11e9-836f-99cbf9a6aeac.gif)\r\n\r\n## Todo\r\n\r\n- [ ] Cross browser testing \r\n","created_at":"2019-07-12T17:21:02Z","updated_at":"2019-07-17T10:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4e5113313001c821885abd2eaf9c939734774c4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jmars","id":615608,"node_id":"MDQ6VXNlcjYxNTYwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/615608?v=4","gravatar_id":"","url":"https://api.github.com/users/jmars","html_url":"https://github.com/jmars","followers_url":"https://api.github.com/users/jmars/followers","following_url":"https://api.github.com/users/jmars/following{/other_user}","gists_url":"https://api.github.com/users/jmars/gists{/gist_id}","starred_url":"https://api.github.com/users/jmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmars/subscriptions","organizations_url":"https://api.github.com/users/jmars/orgs","repos_url":"https://api.github.com/users/jmars/repos","events_url":"https://api.github.com/users/jmars/events{/privacy}","received_events_url":"https://api.github.com/users/jmars/received_events","type":"User","site_admin":false},{"login":"parkjh","id":3116673,"node_id":"MDQ6VXNlcjMxMTY2NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3116673?v=4","gravatar_id":"","url":"https://api.github.com/users/parkjh","html_url":"https://github.com/parkjh","followers_url":"https://api.github.com/users/parkjh/followers","following_url":"https://api.github.com/users/parkjh/following{/other_user}","gists_url":"https://api.github.com/users/parkjh/gists{/gist_id}","starred_url":"https://api.github.com/users/parkjh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkjh/subscriptions","organizations_url":"https://api.github.com/users/parkjh/orgs","repos_url":"https://api.github.com/users/parkjh/repos","events_url":"https://api.github.com/users/parkjh/events{/privacy}","received_events_url":"https://api.github.com/users/parkjh/received_events","type":"User","site_admin":false},{"login":"nehasri89","id":9569135,"node_id":"MDQ6VXNlcjk1NjkxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/9569135?v=4","gravatar_id":"","url":"https://api.github.com/users/nehasri89","html_url":"https://github.com/nehasri89","followers_url":"https://api.github.com/users/nehasri89/followers","following_url":"https://api.github.com/users/nehasri89/following{/other_user}","gists_url":"https://api.github.com/users/nehasri89/gists{/gist_id}","starred_url":"https://api.github.com/users/nehasri89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nehasri89/subscriptions","organizations_url":"https://api.github.com/users/nehasri89/orgs","repos_url":"https://api.github.com/users/nehasri89/repos","events_url":"https://api.github.com/users/nehasri89/events{/privacy}","received_events_url":"https://api.github.com/users/nehasri89/received_events","type":"User","site_admin":false},{"login":"ValGeorgiev","id":12056467,"node_id":"MDQ6VXNlcjEyMDU2NDY3","avatar_url":"https://avatars0.githubusercontent.com/u/12056467?v=4","gravatar_id":"","url":"https://api.github.com/users/ValGeorgiev","html_url":"https://github.com/ValGeorgiev","followers_url":"https://api.github.com/users/ValGeorgiev/followers","following_url":"https://api.github.com/users/ValGeorgiev/following{/other_user}","gists_url":"https://api.github.com/users/ValGeorgiev/gists{/gist_id}","starred_url":"https://api.github.com/users/ValGeorgiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValGeorgiev/subscriptions","organizations_url":"https://api.github.com/users/ValGeorgiev/orgs","repos_url":"https://api.github.com/users/ValGeorgiev/repos","events_url":"https://api.github.com/users/ValGeorgiev/events{/privacy}","received_events_url":"https://api.github.com/users/ValGeorgiev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-components/pulls/2120/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-components/pulls/2120/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-components/issues/2120/comments","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/28d7f3cce301b1148ab6c6d4961a5b39e41d2bef","head":{"label":"newsuk:feat/save-share-bar","ref":"feat/save-share-bar","sha":"28d7f3cce301b1148ab6c6d4961a5b39e41d2bef","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","private":false,"owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2019-07-16T17:06:47Z","pushed_at":"2019-07-17T09:09:12Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":116878,"stargazers_count":176,"watchers_count":176,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":27,"open_issues":41,"watchers":176,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"1821a3f5f6a3f6bd69c34374e4623ed2907cf46d","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","private":false,"owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2019-07-16T17:06:47Z","pushed_at":"2019-07-17T09:09:12Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":116878,"stargazers_count":176,"watchers_count":176,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":27,"open_issues":41,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/2120"},"html":{"href":"https://github.com/newsuk/times-components/pull/2120"},"issue":{"href":"https://api.github.com/repos/newsuk/times-components/issues/2120"},"comments":{"href":"https://api.github.com/repos/newsuk/times-components/issues/2120/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/2120/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/2120/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-components/statuses/28d7f3cce301b1148ab6c6d4961a5b39e41d2bef"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"aronshamash"}}