payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/comments/272646059","pull_request_review_id":223349638,"id":272646059,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjY0NjA1OQ==","diff_hunk":"@@ -1321,6 +1341,9 @@ static int mask_event(struct switchtec_dev *stdev, int eid, int idx)\n \thdr_reg = event_regs[eid].map_reg(stdev, off, idx);\n \thdr = ioread32(hdr_reg);\n \n+\tif (!event_supported(stdev, eid, idx))","path":"switchtec.c","position":333,"original_position":38,"commit_id":"2d3600e56e79896f27ed97bc78ea67f8bae681fb","original_commit_id":"0c1f980ed34f869b85f5d91b839eeabb9e4d28f1","user":{"login":"lsgunth","id":6739835,"node_id":"MDQ6VXNlcjY3Mzk4MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6739835?v=4","gravatar_id":"","url":"https://api.github.com/users/lsgunth","html_url":"https://github.com/lsgunth","followers_url":"https://api.github.com/users/lsgunth/followers","following_url":"https://api.github.com/users/lsgunth/following{/other_user}","gists_url":"https://api.github.com/users/lsgunth/gists{/gist_id}","starred_url":"https://api.github.com/users/lsgunth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsgunth/subscriptions","organizations_url":"https://api.github.com/users/lsgunth/orgs","repos_url":"https://api.github.com/users/lsgunth/repos","events_url":"https://api.github.com/users/lsgunth/events{/privacy}","received_events_url":"https://api.github.com/users/lsgunth/received_events","type":"User","site_admin":false},"body":"This seems overkill. We just read hdr on the line earlier and we read it again inside event_supported. Seems like you can just check the bit directly here.","created_at":"2019-04-05T15:49:43Z","updated_at":"2019-04-05T15:51:43Z","html_url":"https://github.com/kelvin-cao/switchtec-kernel/pull/4#discussion_r272646059","pull_request_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/comments/272646059"},"html":{"href":"https://github.com/kelvin-cao/switchtec-kernel/pull/4#discussion_r272646059"},"pull_request":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4","id":266925172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2OTI1MTcy","html_url":"https://github.com/kelvin-cao/switchtec-kernel/pull/4","diff_url":"https://github.com/kelvin-cao/switchtec-kernel/pull/4.diff","patch_url":"https://github.com/kelvin-cao/switchtec-kernel/pull/4.patch","issue_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/4","number":4,"state":"open","locked":false,"title":"Events x4","user":{"login":"kelvin-cao","id":30617003,"node_id":"MDQ6VXNlcjMwNjE3MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/30617003?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvin-cao","html_url":"https://github.com/kelvin-cao","followers_url":"https://api.github.com/users/kelvin-cao/followers","following_url":"https://api.github.com/users/kelvin-cao/following{/other_user}","gists_url":"https://api.github.com/users/kelvin-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvin-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvin-cao/subscriptions","organizations_url":"https://api.github.com/users/kelvin-cao/orgs","repos_url":"https://api.github.com/users/kelvin-cao/repos","events_url":"https://api.github.com/users/kelvin-cao/events{/privacy}","received_events_url":"https://api.github.com/users/kelvin-cao/received_events","type":"User","site_admin":false},"body":"Removed the evlist stuff.","created_at":"2019-04-03T07:37:09Z","updated_at":"2019-04-05T15:51:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af1172a1413897c0bb2745274093d72323d9a95f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4/commits","review_comments_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4/comments","review_comment_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/4/comments","statuses_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/statuses/2d3600e56e79896f27ed97bc78ea67f8bae681fb","head":{"label":"kelvin-cao:events_x4","ref":"events_x4","sha":"2d3600e56e79896f27ed97bc78ea67f8bae681fb","user":{"login":"kelvin-cao","id":30617003,"node_id":"MDQ6VXNlcjMwNjE3MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/30617003?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvin-cao","html_url":"https://github.com/kelvin-cao","followers_url":"https://api.github.com/users/kelvin-cao/followers","following_url":"https://api.github.com/users/kelvin-cao/following{/other_user}","gists_url":"https://api.github.com/users/kelvin-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvin-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvin-cao/subscriptions","organizations_url":"https://api.github.com/users/kelvin-cao/orgs","repos_url":"https://api.github.com/users/kelvin-cao/repos","events_url":"https://api.github.com/users/kelvin-cao/events{/privacy}","received_events_url":"https://api.github.com/users/kelvin-cao/received_events","type":"User","site_admin":false},"repo":{"id":113834106,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4MzQxMDY=","name":"switchtec-kernel","full_name":"kelvin-cao/switchtec-kernel","private":false,"owner":{"login":"kelvin-cao","id":30617003,"node_id":"MDQ6VXNlcjMwNjE3MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/30617003?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvin-cao","html_url":"https://github.com/kelvin-cao","followers_url":"https://api.github.com/users/kelvin-cao/followers","following_url":"https://api.github.com/users/kelvin-cao/following{/other_user}","gists_url":"https://api.github.com/users/kelvin-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvin-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvin-cao/subscriptions","organizations_url":"https://api.github.com/users/kelvin-cao/orgs","repos_url":"https://api.github.com/users/kelvin-cao/repos","events_url":"https://api.github.com/users/kelvin-cao/events{/privacy}","received_events_url":"https://api.github.com/users/kelvin-cao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kelvin-cao/switchtec-kernel","description":"A kernel module for the Microsemi PCIe switch","fork":true,"url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel","forks_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/forks","keys_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/teams","hooks_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/hooks","issue_events_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/events","assignees_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/tags","blobs_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/languages","stargazers_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/stargazers","contributors_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/contributors","subscribers_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/subscribers","subscription_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/subscription","commits_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/merges","archive_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/downloads","issues_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/labels{/name}","releases_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/deployments","created_at":"2017-12-11T08:43:16Z","updated_at":"2018-12-27T03:30:57Z","pushed_at":"2019-04-03T07:37:10Z","git_url":"git://github.com/kelvin-cao/switchtec-kernel.git","ssh_url":"git@github.com:kelvin-cao/switchtec-kernel.git","clone_url":"https://github.com/kelvin-cao/switchtec-kernel.git","svn_url":"https://github.com/kelvin-cao/switchtec-kernel","homepage":null,"size":384,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"kelvin-cao:devel_unified","ref":"devel_unified","sha":"ba65e6c01b34866958ed4c2c66c3b132b177b5a8","user":{"login":"kelvin-cao","id":30617003,"node_id":"MDQ6VXNlcjMwNjE3MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/30617003?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvin-cao","html_url":"https://github.com/kelvin-cao","followers_url":"https://api.github.com/users/kelvin-cao/followers","following_url":"https://api.github.com/users/kelvin-cao/following{/other_user}","gists_url":"https://api.github.com/users/kelvin-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvin-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvin-cao/subscriptions","organizations_url":"https://api.github.com/users/kelvin-cao/orgs","repos_url":"https://api.github.com/users/kelvin-cao/repos","events_url":"https://api.github.com/users/kelvin-cao/events{/privacy}","received_events_url":"https://api.github.com/users/kelvin-cao/received_events","type":"User","site_admin":false},"repo":{"id":113834106,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4MzQxMDY=","name":"switchtec-kernel","full_name":"kelvin-cao/switchtec-kernel","private":false,"owner":{"login":"kelvin-cao","id":30617003,"node_id":"MDQ6VXNlcjMwNjE3MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/30617003?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvin-cao","html_url":"https://github.com/kelvin-cao","followers_url":"https://api.github.com/users/kelvin-cao/followers","following_url":"https://api.github.com/users/kelvin-cao/following{/other_user}","gists_url":"https://api.github.com/users/kelvin-cao/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvin-cao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvin-cao/subscriptions","organizations_url":"https://api.github.com/users/kelvin-cao/orgs","repos_url":"https://api.github.com/users/kelvin-cao/repos","events_url":"https://api.github.com/users/kelvin-cao/events{/privacy}","received_events_url":"https://api.github.com/users/kelvin-cao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kelvin-cao/switchtec-kernel","description":"A kernel module for the Microsemi PCIe switch","fork":true,"url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel","forks_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/forks","keys_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/teams","hooks_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/hooks","issue_events_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/events","assignees_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/tags","blobs_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/languages","stargazers_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/stargazers","contributors_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/contributors","subscribers_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/subscribers","subscription_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/subscription","commits_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/merges","archive_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/downloads","issues_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/labels{/name}","releases_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/deployments","created_at":"2017-12-11T08:43:16Z","updated_at":"2018-12-27T03:30:57Z","pushed_at":"2019-04-03T07:37:10Z","git_url":"git://github.com/kelvin-cao/switchtec-kernel.git","ssh_url":"git@github.com:kelvin-cao/switchtec-kernel.git","clone_url":"https://github.com/kelvin-cao/switchtec-kernel.git","svn_url":"https://github.com/kelvin-cao/switchtec-kernel","homepage":null,"size":384,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4"},"html":{"href":"https://github.com/kelvin-cao/switchtec-kernel/pull/4"},"issue":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/4"},"comments":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/kelvin-cao/switchtec-kernel/statuses/2d3600e56e79896f27ed97bc78ea67f8bae681fb"}},"author_association":"OWNER"}}
other: {"actor":{"display_login":"lsgunth"}}