payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/317596455","pull_request_review_id":279582095,"id":317596455,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzU5NjQ1NQ==","diff_hunk":"@@ -285,7 +284,7 @@ def eval(cls, a, x):\n         #    of both s and x), i.e.\n         #    lowergamma(s, exp(2*I*pi*n)*x) = exp(2*pi*I*n*a)*lowergamma(a, x)\n         from sympy import unpolarify, I\n-        if x == 0:\n+        if x is S.Zero:","path":"sympy/functions/special/gamma_functions.py","position":18,"original_position":18,"commit_id":"f706a0fdeb4f089541fd20d19aaf33601cc467c5","original_commit_id":"f706a0fdeb4f089541fd20d19aaf33601cc467c5","user":{"login":"oscarbenjamin","id":1159732,"node_id":"MDQ6VXNlcjExNTk3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1159732?v=4","gravatar_id":"","url":"https://api.github.com/users/oscarbenjamin","html_url":"https://github.com/oscarbenjamin","followers_url":"https://api.github.com/users/oscarbenjamin/followers","following_url":"https://api.github.com/users/oscarbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/oscarbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarbenjamin/subscriptions","organizations_url":"https://api.github.com/users/oscarbenjamin/orgs","repos_url":"https://api.github.com/users/oscarbenjamin/repos","events_url":"https://api.github.com/users/oscarbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/oscarbenjamin/received_events","type":"User","site_admin":false},"body":"Maybe this could be `.is_zero` instead of also checking that below","created_at":"2019-08-26T13:13:50Z","updated_at":"2019-08-26T13:13:50Z","html_url":"https://github.com/sympy/sympy/pull/17510#discussion_r317596455","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/17510","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/317596455"},"html":{"href":"https://github.com/sympy/sympy/pull/17510#discussion_r317596455"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17510"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/17510","id":310685975,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwNjg1OTc1","html_url":"https://github.com/sympy/sympy/pull/17510","diff_url":"https://github.com/sympy/sympy/pull/17510.diff","patch_url":"https://github.com/sympy/sympy/pull/17510.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/17510","number":17510,"state":"open","locked":false,"title":"Better `eval` and `is_zero` checking for a number of functions.","user":{"login":"oscargus","id":8114497,"node_id":"MDQ6VXNlcjgxMTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8114497?v=4","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"body":"…appelf1 and hyper\r\n\r\n<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests . Please also\r\nwrite a comment on that issue linking back to this pull request once it is\r\nopen. -->\r\nFixes #17511\r\n\r\n#### Brief description of what is fixed or changed\r\nMany functions now use `is_zero` in `eval` (typically towards the end of `eval` for performance reasons). This will lead to smaller expressions in general.\r\n\r\nMany functions now have a dedicated `_eval_is_zero` function.\r\n\r\nAlso, added support for `evaluate`-keywords to `hyper` and `appellf1`. `hyper` never evaluates, but I think it makes sense to support it anyway, if nothing else for the `is_zero` and `is_rational`-support.\r\n\r\n#### Other comments\r\n\r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. The bot will check your release notes\r\nautomatically to see if they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* functions\r\n   * `hyper` and `appellf1` supports `evaluate` keyword.       \r\n   * Many functions now use `is_zero` to evaluate which leads to smaller expressions.\r\n   * Better `is_zero` check for many functions.\r\n   * `beta` evaluates expressions if one of the arguments is `1`.\r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2019-08-25T13:37:26Z","updated_at":"2019-08-26T13:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc89301c688c721a8efb94056147487ef1d57c06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":83720928,"node_id":"MDU6TGFiZWw4MzcyMDkyOA==","url":"https://api.github.com/repos/sympy/sympy/labels/core","name":"core","color":"0000FF","default":false},{"id":315103853,"node_id":"MDU6TGFiZWwzMTUxMDM4NTM=","url":"https://api.github.com/repos/sympy/sympy/labels/functions","name":"functions","color":"0000FF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/17510/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/17510/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/17510/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/f706a0fdeb4f089541fd20d19aaf33601cc467c5","head":{"label":"oscargus:iszerorational","ref":"iszerorational","sha":"f706a0fdeb4f089541fd20d19aaf33601cc467c5","user":{"login":"oscargus","id":8114497,"node_id":"MDQ6VXNlcjgxMTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8114497?v=4","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"repo":{"id":164848022,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ4NDgwMjI=","name":"sympy","full_name":"oscargus/sympy","private":false,"owner":{"login":"oscargus","id":8114497,"node_id":"MDQ6VXNlcjgxMTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8114497?v=4","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oscargus/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/oscargus/sympy","forks_url":"https://api.github.com/repos/oscargus/sympy/forks","keys_url":"https://api.github.com/repos/oscargus/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oscargus/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oscargus/sympy/teams","hooks_url":"https://api.github.com/repos/oscargus/sympy/hooks","issue_events_url":"https://api.github.com/repos/oscargus/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/oscargus/sympy/events","assignees_url":"https://api.github.com/repos/oscargus/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/oscargus/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/oscargus/sympy/tags","blobs_url":"https://api.github.com/repos/oscargus/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oscargus/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oscargus/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/oscargus/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oscargus/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/oscargus/sympy/languages","stargazers_url":"https://api.github.com/repos/oscargus/sympy/stargazers","contributors_url":"https://api.github.com/repos/oscargus/sympy/contributors","subscribers_url":"https://api.github.com/repos/oscargus/sympy/subscribers","subscription_url":"https://api.github.com/repos/oscargus/sympy/subscription","commits_url":"https://api.github.com/repos/oscargus/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/oscargus/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/oscargus/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/oscargus/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/oscargus/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/oscargus/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oscargus/sympy/merges","archive_url":"https://api.github.com/repos/oscargus/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oscargus/sympy/downloads","issues_url":"https://api.github.com/repos/oscargus/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/oscargus/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/oscargus/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/oscargus/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oscargus/sympy/labels{/name}","releases_url":"https://api.github.com/repos/oscargus/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/oscargus/sympy/deployments","created_at":"2019-01-09T11:12:38Z","updated_at":"2019-08-26T10:33:16Z","pushed_at":"2019-08-26T10:33:14Z","git_url":"git://github.com/oscargus/sympy.git","ssh_url":"git@github.com:oscargus/sympy.git","clone_url":"https://github.com/oscargus/sympy.git","svn_url":"https://github.com/oscargus/sympy","homepage":"https://sympy.org/","size":111324,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"f88589f4512870794834f57edb39ec1afa730b68","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","private":false,"owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2019-08-26T11:02:38Z","pushed_at":"2019-08-26T10:37:16Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"https://sympy.org/","size":110602,"stargazers_count":6148,"watchers_count":6148,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2688,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2688,"open_issues":3595,"watchers":6148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17510"},"html":{"href":"https://github.com/sympy/sympy/pull/17510"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/17510"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/17510/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17510/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17510/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/f706a0fdeb4f089541fd20d19aaf33601cc467c5"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"oscarbenjamin"}}