payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/326536544","pull_request_review_id":291040414,"id":326536544,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjUzNjU0NA==","diff_hunk":"@@ -17,11 +17,6 @@ BOOL OOPStackUnwinderX86::Unwind(T_CONTEXT* pContextRecord, T_KNONVOLATILE_CONTE\n     rd.SP = pContextRecord->Esp;\n     rd.PCTAddr = (UINT_PTR)&(pContextRecord->Eip);\n \n-    if (pContextPointers)","path":"src/unwinder/i386/unwinder_i386.cpp","position":2,"original_position":4,"commit_id":"689d0ebaa2248c44b84fec962f59f6f54c50df8c","original_commit_id":"a23f1095abdb4130ad294aafbc4053004d6f0dc8","user":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"Well, it is still in-out on amd64 - it doesn't destroy the previous state.","created_at":"2019-09-20T09:05:18Z","updated_at":"2019-09-20T09:05:18Z","html_url":"https://github.com/dotnet/coreclr/pull/26789#discussion_r326536544","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/26789","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/326536544"},"html":{"href":"https://github.com/dotnet/coreclr/pull/26789#discussion_r326536544"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26789"}},"in_reply_to_id":326361727},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/26789","id":319426715,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5NDI2NzE1","html_url":"https://github.com/dotnet/coreclr/pull/26789","diff_url":"https://github.com/dotnet/coreclr/pull/26789.diff","patch_url":"https://github.com/dotnet/coreclr/pull/26789.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/26789","number":26789,"state":"open","locked":false,"title":"[Linux/x86] Fix OOPStackUnwinderX86::Unwind","user":{"login":"kbaladurin","id":29702773,"node_id":"MDQ6VXNlcjI5NzAyNzcz","avatar_url":"https://avatars0.githubusercontent.com/u/29702773?v=4","gravatar_id":"","url":"https://api.github.com/users/kbaladurin","html_url":"https://github.com/kbaladurin","followers_url":"https://api.github.com/users/kbaladurin/followers","following_url":"https://api.github.com/users/kbaladurin/following{/other_user}","gists_url":"https://api.github.com/users/kbaladurin/gists{/gist_id}","starred_url":"https://api.github.com/users/kbaladurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbaladurin/subscriptions","organizations_url":"https://api.github.com/users/kbaladurin/orgs","repos_url":"https://api.github.com/users/kbaladurin/repos","events_url":"https://api.github.com/users/kbaladurin/events{/privacy}","received_events_url":"https://api.github.com/users/kbaladurin/received_events","type":"User","site_admin":false},"body":"We cannot set `pCurrentContextPointers` to `pContextPointers` before unwinding because `pContextRecord` is zeroed. Copy non zero pointers from `pContextPointers` to `pCurrentContextPointers` instead of it.\r\n\r\nThis patch fixes https://github.com/dotnet/coreclr/issues/26788","created_at":"2019-09-19T19:22:07Z","updated_at":"2019-09-20T09:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd04af0f26c9bca69e0768f6427e903ffc6153af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/26789/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/26789/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/26789/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/689d0ebaa2248c44b84fec962f59f6f54c50df8c","head":{"label":"kbaladurin:fix-unwind-x86","ref":"fix-unwind-x86","sha":"689d0ebaa2248c44b84fec962f59f6f54c50df8c","user":{"login":"kbaladurin","id":29702773,"node_id":"MDQ6VXNlcjI5NzAyNzcz","avatar_url":"https://avatars0.githubusercontent.com/u/29702773?v=4","gravatar_id":"","url":"https://api.github.com/users/kbaladurin","html_url":"https://github.com/kbaladurin","followers_url":"https://api.github.com/users/kbaladurin/followers","following_url":"https://api.github.com/users/kbaladurin/following{/other_user}","gists_url":"https://api.github.com/users/kbaladurin/gists{/gist_id}","starred_url":"https://api.github.com/users/kbaladurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbaladurin/subscriptions","organizations_url":"https://api.github.com/users/kbaladurin/orgs","repos_url":"https://api.github.com/users/kbaladurin/repos","events_url":"https://api.github.com/users/kbaladurin/events{/privacy}","received_events_url":"https://api.github.com/users/kbaladurin/received_events","type":"User","site_admin":false},"repo":{"id":95425148,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQyNTE0OA==","name":"coreclr","full_name":"kbaladurin/coreclr","private":false,"owner":{"login":"kbaladurin","id":29702773,"node_id":"MDQ6VXNlcjI5NzAyNzcz","avatar_url":"https://avatars0.githubusercontent.com/u/29702773?v=4","gravatar_id":"","url":"https://api.github.com/users/kbaladurin","html_url":"https://github.com/kbaladurin","followers_url":"https://api.github.com/users/kbaladurin/followers","following_url":"https://api.github.com/users/kbaladurin/following{/other_user}","gists_url":"https://api.github.com/users/kbaladurin/gists{/gist_id}","starred_url":"https://api.github.com/users/kbaladurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbaladurin/subscriptions","organizations_url":"https://api.github.com/users/kbaladurin/orgs","repos_url":"https://api.github.com/users/kbaladurin/repos","events_url":"https://api.github.com/users/kbaladurin/events{/privacy}","received_events_url":"https://api.github.com/users/kbaladurin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kbaladurin/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/kbaladurin/coreclr","forks_url":"https://api.github.com/repos/kbaladurin/coreclr/forks","keys_url":"https://api.github.com/repos/kbaladurin/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbaladurin/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbaladurin/coreclr/teams","hooks_url":"https://api.github.com/repos/kbaladurin/coreclr/hooks","issue_events_url":"https://api.github.com/repos/kbaladurin/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/kbaladurin/coreclr/events","assignees_url":"https://api.github.com/repos/kbaladurin/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/kbaladurin/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/kbaladurin/coreclr/tags","blobs_url":"https://api.github.com/repos/kbaladurin/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbaladurin/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbaladurin/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbaladurin/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbaladurin/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/kbaladurin/coreclr/languages","stargazers_url":"https://api.github.com/repos/kbaladurin/coreclr/stargazers","contributors_url":"https://api.github.com/repos/kbaladurin/coreclr/contributors","subscribers_url":"https://api.github.com/repos/kbaladurin/coreclr/subscribers","subscription_url":"https://api.github.com/repos/kbaladurin/coreclr/subscription","commits_url":"https://api.github.com/repos/kbaladurin/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbaladurin/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbaladurin/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbaladurin/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbaladurin/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/kbaladurin/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbaladurin/coreclr/merges","archive_url":"https://api.github.com/repos/kbaladurin/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbaladurin/coreclr/downloads","issues_url":"https://api.github.com/repos/kbaladurin/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/kbaladurin/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/kbaladurin/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/kbaladurin/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbaladurin/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/kbaladurin/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/kbaladurin/coreclr/deployments","created_at":"2017-06-26T08:27:41Z","updated_at":"2019-07-17T16:58:38Z","pushed_at":"2019-09-20T09:03:18Z","git_url":"git://github.com/kbaladurin/coreclr.git","ssh_url":"git@github.com:kbaladurin/coreclr.git","clone_url":"https://github.com/kbaladurin/coreclr.git","svn_url":"https://github.com/kbaladurin/coreclr","homepage":"https://github.com/dotnet/core","size":304848,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d88bc184d054fe8e4915964330ca65378d59ef27","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"CoreCLR is the runtime for .NET Core. It includes the garbage collector, JIT compiler, primitive data types and low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2019-09-20T08:18:18Z","pushed_at":"2019-09-20T09:03:20Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/core/","size":308691,"stargazers_count":12053,"watchers_count":12053,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2832,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2160,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2832,"open_issues":2160,"watchers":12053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26789"},"html":{"href":"https://github.com/dotnet/coreclr/pull/26789"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/26789"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/26789/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26789/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26789/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/689d0ebaa2248c44b84fec962f59f6f54c50df8c"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"janvorli"}}