payload: {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments/336967732","pull_request_review_id":304496705,"id":336967732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjk2NzczMg==","diff_hunk":"@@ -32,7 +38,7 @@\n      *            ID if the controller\n      */\n     public TargetWithActionType(final String controllerId) {\n-        this(controllerId, ActionType.FORCED, 0);\n+        this(controllerId, ActionType.FORCED, 0, null);","path":"hawkbit-repository/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/model/TargetWithActionType.java","position":25,"original_position":25,"commit_id":"894de3a88db27e534fcf0c59fddecf465fd80bcb","original_commit_id":"79baf68f17853c126c9f63781cec667da79d7bfd","user":{"login":"vigier","id":25368795,"node_id":"MDQ6VXNlcjI1MzY4Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/25368795?v=4","gravatar_id":"","url":"https://api.github.com/users/vigier","html_url":"https://github.com/vigier","followers_url":"https://api.github.com/users/vigier/followers","following_url":"https://api.github.com/users/vigier/following{/other_user}","gists_url":"https://api.github.com/users/vigier/gists{/gist_id}","starred_url":"https://api.github.com/users/vigier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigier/subscriptions","organizations_url":"https://api.github.com/users/vigier/orgs","repos_url":"https://api.github.com/users/vigier/repos","events_url":"https://api.github.com/users/vigier/events{/privacy}","received_events_url":"https://api.github.com/users/vigier/received_events","type":"User","site_admin":false},"body":"If a class uses internally `null` I do not care.\r\nBuit accepting `null` via a public method signature avoids you from writing clean code.\r\nSo putting \"the burden\" into the method definition is clearly preferable.","created_at":"2019-10-21T11:35:52Z","updated_at":"2019-10-21T11:35:52Z","html_url":"https://github.com/eclipse/hawkbit/pull/895#discussion_r336967732","pull_request_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/895","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments/336967732"},"html":{"href":"https://github.com/eclipse/hawkbit/pull/895#discussion_r336967732"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/895"}},"in_reply_to_id":334861754},"pull_request":{"url":"https://api.github.com/repos/eclipse/hawkbit/pulls/895","id":325331015,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1MzMxMDE1","html_url":"https://github.com/eclipse/hawkbit/pull/895","diff_url":"https://github.com/eclipse/hawkbit/pull/895.diff","patch_url":"https://github.com/eclipse/hawkbit/pull/895.patch","issue_url":"https://api.github.com/repos/eclipse/hawkbit/issues/895","number":895,"state":"open","locked":false,"title":"Prioritisation of assignments via mgmt-API","user":{"login":"StefanKlt","id":35995139,"node_id":"MDQ6VXNlcjM1OTk1MTM5","avatar_url":"https://avatars0.githubusercontent.com/u/35995139?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanKlt","html_url":"https://github.com/StefanKlt","followers_url":"https://api.github.com/users/StefanKlt/followers","following_url":"https://api.github.com/users/StefanKlt/following{/other_user}","gists_url":"https://api.github.com/users/StefanKlt/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKlt/subscriptions","organizations_url":"https://api.github.com/users/StefanKlt/orgs","repos_url":"https://api.github.com/users/StefanKlt/repos","events_url":"https://api.github.com/users/StefanKlt/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKlt/received_events","type":"User","site_admin":false},"body":"When Multi Assignments is enabled, it is possible to define multiple distribution sets that should all be installed to a device. In that case it should be possible to specify the importance of the different distribution sets. That way the installation of a security patch will not be blocked by an other less important update.\r\nTo achieve that every action (representing the assignment of a distribution set to a target) will get a weight property. This number between (0 to 1000) represents the importance of this action (where 0 means not important and 1000 means very important) can then be exposed to the device directly or used to determine the order the actions are exposed to the device.\r\nThese changes enable an operator to specify a weight via mgmt-api when crating an manual assignment, a rollout or a target filter with an auto assignment. In case of a rollout and a target filter this weight is applied to every action resulting from it.\r\nFor now it is not mandatory for the operator to specify the weight, since it is not jet possible to do it via mgmt-UI. This should be enforced after the UI is adapted as well.","created_at":"2019-10-07T14:27:41Z","updated_at":"2019-10-21T11:35:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c46c76f3e0b789a3feae426212ade88ee812552","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/eclipse/hawkbit/milestones/21","html_url":"https://github.com/eclipse/hawkbit/milestone/21","labels_url":"https://api.github.com/repos/eclipse/hawkbit/milestones/21/labels","id":4529865,"node_id":"MDk6TWlsZXN0b25lNDUyOTg2NQ==","number":21,"title":"0.3.0M6","description":"","creator":{"login":"schabdo","id":18215905,"node_id":"MDQ6VXNlcjE4MjE1OTA1","avatar_url":"https://avatars3.githubusercontent.com/u/18215905?v=4","gravatar_id":"","url":"https://api.github.com/users/schabdo","html_url":"https://github.com/schabdo","followers_url":"https://api.github.com/users/schabdo/followers","following_url":"https://api.github.com/users/schabdo/following{/other_user}","gists_url":"https://api.github.com/users/schabdo/gists{/gist_id}","starred_url":"https://api.github.com/users/schabdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schabdo/subscriptions","organizations_url":"https://api.github.com/users/schabdo/orgs","repos_url":"https://api.github.com/users/schabdo/repos","events_url":"https://api.github.com/users/schabdo/events{/privacy}","received_events_url":"https://api.github.com/users/schabdo/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":14,"state":"open","created_at":"2019-07-29T13:28:53Z","updated_at":"2019-10-21T09:00:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/895/commits","review_comments_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/895/comments","review_comment_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hawkbit/issues/895/comments","statuses_url":"https://api.github.com/repos/eclipse/hawkbit/statuses/894de3a88db27e534fcf0c59fddecf465fd80bcb","head":{"label":"bsinno:feature_prioritisation_of_campaigns","ref":"feature_prioritisation_of_campaigns","sha":"894de3a88db27e534fcf0c59fddecf465fd80bcb","user":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":50108079,"node_id":"MDEwOlJlcG9zaXRvcnk1MDEwODA3OQ==","name":"hawkbit","full_name":"bsinno/hawkbit","private":false,"owner":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bsinno/hawkbit","description":null,"fork":true,"url":"https://api.github.com/repos/bsinno/hawkbit","forks_url":"https://api.github.com/repos/bsinno/hawkbit/forks","keys_url":"https://api.github.com/repos/bsinno/hawkbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hawkbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hawkbit/teams","hooks_url":"https://api.github.com/repos/bsinno/hawkbit/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hawkbit/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hawkbit/events","assignees_url":"https://api.github.com/repos/bsinno/hawkbit/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hawkbit/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hawkbit/tags","blobs_url":"https://api.github.com/repos/bsinno/hawkbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hawkbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hawkbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hawkbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hawkbit/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hawkbit/languages","stargazers_url":"https://api.github.com/repos/bsinno/hawkbit/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hawkbit/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hawkbit/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hawkbit/subscription","commits_url":"https://api.github.com/repos/bsinno/hawkbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hawkbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hawkbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hawkbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hawkbit/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hawkbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hawkbit/merges","archive_url":"https://api.github.com/repos/bsinno/hawkbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hawkbit/downloads","issues_url":"https://api.github.com/repos/bsinno/hawkbit/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hawkbit/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hawkbit/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hawkbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hawkbit/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hawkbit/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hawkbit/deployments","created_at":"2016-01-21T13:05:15Z","updated_at":"2019-10-21T07:02:32Z","pushed_at":"2019-10-21T11:24:37Z","git_url":"git://github.com/bsinno/hawkbit.git","ssh_url":"git@github.com:bsinno/hawkbit.git","clone_url":"https://github.com/bsinno/hawkbit.git","svn_url":"https://github.com/bsinno/hawkbit","homepage":null,"size":23751,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":1,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"193603282af6afa4e8a368e49e1ffa23f88dfb02","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":45860898,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2MDg5OA==","name":"hawkbit","full_name":"eclipse/hawkbit","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/hawkbit","description":"Eclipse hawkBit™","fork":false,"url":"https://api.github.com/repos/eclipse/hawkbit","forks_url":"https://api.github.com/repos/eclipse/hawkbit/forks","keys_url":"https://api.github.com/repos/eclipse/hawkbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hawkbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hawkbit/teams","hooks_url":"https://api.github.com/repos/eclipse/hawkbit/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hawkbit/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hawkbit/events","assignees_url":"https://api.github.com/repos/eclipse/hawkbit/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hawkbit/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hawkbit/tags","blobs_url":"https://api.github.com/repos/eclipse/hawkbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hawkbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hawkbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hawkbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hawkbit/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hawkbit/languages","stargazers_url":"https://api.github.com/repos/eclipse/hawkbit/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hawkbit/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hawkbit/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hawkbit/subscription","commits_url":"https://api.github.com/repos/eclipse/hawkbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hawkbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hawkbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hawkbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hawkbit/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hawkbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hawkbit/merges","archive_url":"https://api.github.com/repos/eclipse/hawkbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hawkbit/downloads","issues_url":"https://api.github.com/repos/eclipse/hawkbit/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hawkbit/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hawkbit/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hawkbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hawkbit/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hawkbit/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hawkbit/deployments","created_at":"2015-11-09T19:19:06Z","updated_at":"2019-10-21T09:00:02Z","pushed_at":"2019-10-21T11:24:39Z","git_url":"git://github.com/eclipse/hawkbit.git","ssh_url":"git@github.com:eclipse/hawkbit.git","clone_url":"https://github.com/eclipse/hawkbit.git","svn_url":"https://github.com/eclipse/hawkbit","homepage":"https://projects.eclipse.org/projects/iot.hawkbit","size":21231,"stargazers_count":207,"watchers_count":207,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":80,"open_issues":43,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/895"},"html":{"href":"https://github.com/eclipse/hawkbit/pull/895"},"issue":{"href":"https://api.github.com/repos/eclipse/hawkbit/issues/895"},"comments":{"href":"https://api.github.com/repos/eclipse/hawkbit/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hawkbit/statuses/894de3a88db27e534fcf0c59fddecf465fd80bcb"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"vigier"}}