payload: {"action":"created","comment":{"url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/comments/275123618","pull_request_review_id":226359162,"id":275123618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTEyMzYxOA==","diff_hunk":"@@ -2580,14 +2577,15 @@ impl<'a> Parser<'a> {\n \n     /// Returns the next event in a pre-order AST walk, along with its\n     /// start and end offset in the source.\n+    #[inline(always)]","path":"src/parse.rs","position":169,"original_position":167,"commit_id":"d68e2407cd44a09eea9465b0d6b084518b98f74c","original_commit_id":"8cc2b45a0b8f2953f6849149a0e5cc33057b6325","user":{"login":"marcusklaas","id":1255413,"node_id":"MDQ6VXNlcjEyNTU0MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1255413?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"body":"It's not serious, but it is measurable: around 2%. This call is very hot. The reason for forcing inlining it was that the regular (non source-mapped) iterator has to strip source information otherwise. If it is inlined, the source references need not even be formed.\r\n\r\nI suspect it's not inlined because it's fairly large as you say and it's used by two distinct iterators. But these are mutually exclusive in use for any given parser. So while forcing inlining here may increase code size a bit, it shouldn't hurt instruction caches.","created_at":"2019-04-13T16:17:18Z","updated_at":"2019-04-13T16:17:18Z","html_url":"https://github.com/raphlinus/pulldown-cmark/pull/260#discussion_r275123618","pull_request_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/comments/275123618"},"html":{"href":"https://github.com/raphlinus/pulldown-cmark/pull/260#discussion_r275123618"},"pull_request":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260"}},"in_reply_to_id":275121570},"pull_request":{"url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260","id":267909779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3OTA5Nzc5","html_url":"https://github.com/raphlinus/pulldown-cmark/pull/260","diff_url":"https://github.com/raphlinus/pulldown-cmark/pull/260.diff","patch_url":"https://github.com/raphlinus/pulldown-cmark/pull/260.patch","issue_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues/260","number":260,"state":"open","locked":false,"title":"Make code spans into leaf nodes","user":{"login":"marcusklaas","id":1255413,"node_id":"MDQ6VXNlcjEyNTU0MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1255413?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"body":"Makes code blocks into leaf nodes, i.e., nodes without children. This simplifies parsing a bit and should signal better to the user what to expect: there is nothing but text inside a code block. This means that there is just one event per code block instead of a minimum of three.\r\n\r\nAs a trade-off, this code may now allocate where the previous approach did not. However, we do everything to avoid this and it should be rare. The reduced number of events should offset this potential extra cost and then some.\r\n\r\ncrdt benchmark, baseline\r\n```\r\nrunning 1 test\r\ntest to_html::crdt_empty_options               ... bench:     599,347 ns/iter (+/- 10,162)\r\n```\r\n\r\ncrdt benchmark, with this PR\r\n```\r\nrunning 1 test\r\ntest to_html::crdt_empty_options               ... bench:     519,990 ns/iter (+/- 10,503)\r\n```\r\n\r\nDuring the making of this PR, I found that the test normalization code was too aggressive; it replaced breaks by whitespaces inside code blocks. This could allow us to pass tests [like this](https://spec.commonmark.org/0.28/#example-317) without actually doing the right thing. This has now been fixed.\r\n\r\n**Note**: this is a breaking change.","created_at":"2019-04-05T17:42:56Z","updated_at":"2019-04-13T16:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0976bb2392732c757b66cf83a20c7b3833e674c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260/commits","review_comments_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260/comments","review_comment_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues/260/comments","statuses_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/statuses/d68e2407cd44a09eea9465b0d6b084518b98f74c","head":{"label":"marcusklaas:inline-code","ref":"inline-code","sha":"d68e2407cd44a09eea9465b0d6b084518b98f74c","user":{"login":"marcusklaas","id":1255413,"node_id":"MDQ6VXNlcjEyNTU0MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1255413?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"repo":{"id":169124379,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkxMjQzNzk=","name":"pulldown-cmark","full_name":"marcusklaas/pulldown-cmark","private":false,"owner":{"login":"marcusklaas","id":1255413,"node_id":"MDQ6VXNlcjEyNTU0MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1255413?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marcusklaas/pulldown-cmark","description":null,"fork":true,"url":"https://api.github.com/repos/marcusklaas/pulldown-cmark","forks_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/forks","keys_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/teams","hooks_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/hooks","issue_events_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/issues/events{/number}","events_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/events","assignees_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/assignees{/user}","branches_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/branches{/branch}","tags_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/tags","blobs_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/statuses/{sha}","languages_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/languages","stargazers_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/stargazers","contributors_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/contributors","subscribers_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/subscribers","subscription_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/subscription","commits_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/contents/{+path}","compare_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/merges","archive_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/downloads","issues_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/issues{/number}","pulls_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/pulls{/number}","milestones_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/milestones{/number}","notifications_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/labels{/name}","releases_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/releases{/id}","deployments_url":"https://api.github.com/repos/marcusklaas/pulldown-cmark/deployments","created_at":"2019-02-04T18:12:11Z","updated_at":"2019-03-16T17:56:32Z","pushed_at":"2019-04-13T16:06:08Z","git_url":"git://github.com/marcusklaas/pulldown-cmark.git","ssh_url":"git@github.com:marcusklaas/pulldown-cmark.git","clone_url":"https://github.com/marcusklaas/pulldown-cmark.git","svn_url":"https://github.com/marcusklaas/pulldown-cmark","homepage":null,"size":6152,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raphlinus:master","ref":"master","sha":"e3454db884ccd473a1955cb1323d5a49dd77a1ed","user":{"login":"raphlinus","id":242367,"node_id":"MDQ6VXNlcjI0MjM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/242367?v=4","gravatar_id":"","url":"https://api.github.com/users/raphlinus","html_url":"https://github.com/raphlinus","followers_url":"https://api.github.com/users/raphlinus/followers","following_url":"https://api.github.com/users/raphlinus/following{/other_user}","gists_url":"https://api.github.com/users/raphlinus/gists{/gist_id}","starred_url":"https://api.github.com/users/raphlinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphlinus/subscriptions","organizations_url":"https://api.github.com/users/raphlinus/orgs","repos_url":"https://api.github.com/users/raphlinus/repos","events_url":"https://api.github.com/users/raphlinus/events{/privacy}","received_events_url":"https://api.github.com/users/raphlinus/received_events","type":"User","site_admin":false},"repo":{"id":36815297,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgxNTI5Nw==","name":"pulldown-cmark","full_name":"raphlinus/pulldown-cmark","private":false,"owner":{"login":"raphlinus","id":242367,"node_id":"MDQ6VXNlcjI0MjM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/242367?v=4","gravatar_id":"","url":"https://api.github.com/users/raphlinus","html_url":"https://github.com/raphlinus","followers_url":"https://api.github.com/users/raphlinus/followers","following_url":"https://api.github.com/users/raphlinus/following{/other_user}","gists_url":"https://api.github.com/users/raphlinus/gists{/gist_id}","starred_url":"https://api.github.com/users/raphlinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphlinus/subscriptions","organizations_url":"https://api.github.com/users/raphlinus/orgs","repos_url":"https://api.github.com/users/raphlinus/repos","events_url":"https://api.github.com/users/raphlinus/events{/privacy}","received_events_url":"https://api.github.com/users/raphlinus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raphlinus/pulldown-cmark","description":null,"fork":false,"url":"https://api.github.com/repos/raphlinus/pulldown-cmark","forks_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/forks","keys_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/teams","hooks_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/hooks","issue_events_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues/events{/number}","events_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/events","assignees_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/assignees{/user}","branches_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/branches{/branch}","tags_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/tags","blobs_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/statuses/{sha}","languages_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/languages","stargazers_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/stargazers","contributors_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/contributors","subscribers_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/subscribers","subscription_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/subscription","commits_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/contents/{+path}","compare_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/merges","archive_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/downloads","issues_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues{/number}","pulls_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls{/number}","milestones_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/milestones{/number}","notifications_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/labels{/name}","releases_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/releases{/id}","deployments_url":"https://api.github.com/repos/raphlinus/pulldown-cmark/deployments","created_at":"2015-06-03T16:12:34Z","updated_at":"2019-04-13T16:06:08Z","pushed_at":"2019-04-13T16:06:06Z","git_url":"git://github.com/raphlinus/pulldown-cmark.git","ssh_url":"git@github.com:raphlinus/pulldown-cmark.git","clone_url":"https://github.com/raphlinus/pulldown-cmark.git","svn_url":"https://github.com/raphlinus/pulldown-cmark","homepage":null,"size":1094,"stargazers_count":637,"watchers_count":637,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":98,"open_issues":30,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260"},"html":{"href":"https://github.com/raphlinus/pulldown-cmark/pull/260"},"issue":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues/260"},"comments":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/raphlinus/pulldown-cmark/statuses/d68e2407cd44a09eea9465b0d6b084518b98f74c"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"marcusklaas"}}