payload: {"action":"closed","number":1565,"pull_request":{"url":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/1565","id":353257583,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMjU3NTgz","html_url":"https://github.com/sql-machine-learning/elasticdl/pull/1565","diff_url":"https://github.com/sql-machine-learning/elasticdl/pull/1565.diff","patch_url":"https://github.com/sql-machine-learning/elasticdl/pull/1565.patch","issue_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues/1565","number":1565,"state":"closed","locked":false,"title":"Override __add__ and __iadd__ in Tensor","user":{"login":"shijungg","id":8281325,"node_id":"MDQ6VXNlcjgyODEzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8281325?v=4","gravatar_id":"","url":"https://api.github.com/users/shijungg","html_url":"https://github.com/shijungg","followers_url":"https://api.github.com/users/shijungg/followers","following_url":"https://api.github.com/users/shijungg/following{/other_user}","gists_url":"https://api.github.com/users/shijungg/gists{/gist_id}","starred_url":"https://api.github.com/users/shijungg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shijungg/subscriptions","organizations_url":"https://api.github.com/users/shijungg/orgs","repos_url":"https://api.github.com/users/shijungg/repos","events_url":"https://api.github.com/users/shijungg/events{/privacy}","received_events_url":"https://api.github.com/users/shijungg/received_events","type":"User","site_admin":false},"body":"`__add__` is for `+` and `__iadd__` is for `+=`.\r\nI personally think you should not do inplace operation`return self` in `__add__`. `__add__` should return a new instance. Inplace operation should be implemented in `__iadd__`","created_at":"2019-12-15T09:48:16Z","updated_at":"2019-12-15T13:08:34Z","closed_at":"2019-12-15T13:08:34Z","merged_at":null,"merge_commit_sha":"2b9b7f511b0ebfa44989b150a4ae9f58990394f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/1565/commits","review_comments_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/1565/comments","review_comment_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues/1565/comments","statuses_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/statuses/92bed0fd26f586a9ac938ad51971e21728310a8c","head":{"label":"shijungg:tensor","ref":"tensor","sha":"92bed0fd26f586a9ac938ad51971e21728310a8c","user":{"login":"shijungg","id":8281325,"node_id":"MDQ6VXNlcjgyODEzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8281325?v=4","gravatar_id":"","url":"https://api.github.com/users/shijungg","html_url":"https://github.com/shijungg","followers_url":"https://api.github.com/users/shijungg/followers","following_url":"https://api.github.com/users/shijungg/following{/other_user}","gists_url":"https://api.github.com/users/shijungg/gists{/gist_id}","starred_url":"https://api.github.com/users/shijungg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shijungg/subscriptions","organizations_url":"https://api.github.com/users/shijungg/orgs","repos_url":"https://api.github.com/users/shijungg/repos","events_url":"https://api.github.com/users/shijungg/events{/privacy}","received_events_url":"https://api.github.com/users/shijungg/received_events","type":"User","site_admin":false},"repo":{"id":215740455,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU3NDA0NTU=","name":"elasticdl","full_name":"shijungg/elasticdl","private":false,"owner":{"login":"shijungg","id":8281325,"node_id":"MDQ6VXNlcjgyODEzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8281325?v=4","gravatar_id":"","url":"https://api.github.com/users/shijungg","html_url":"https://github.com/shijungg","followers_url":"https://api.github.com/users/shijungg/followers","following_url":"https://api.github.com/users/shijungg/following{/other_user}","gists_url":"https://api.github.com/users/shijungg/gists{/gist_id}","starred_url":"https://api.github.com/users/shijungg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shijungg/subscriptions","organizations_url":"https://api.github.com/users/shijungg/orgs","repos_url":"https://api.github.com/users/shijungg/repos","events_url":"https://api.github.com/users/shijungg/events{/privacy}","received_events_url":"https://api.github.com/users/shijungg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shijungg/elasticdl","description":"Kubernetes-native Deep Learning Framework","fork":true,"url":"https://api.github.com/repos/shijungg/elasticdl","forks_url":"https://api.github.com/repos/shijungg/elasticdl/forks","keys_url":"https://api.github.com/repos/shijungg/elasticdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shijungg/elasticdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shijungg/elasticdl/teams","hooks_url":"https://api.github.com/repos/shijungg/elasticdl/hooks","issue_events_url":"https://api.github.com/repos/shijungg/elasticdl/issues/events{/number}","events_url":"https://api.github.com/repos/shijungg/elasticdl/events","assignees_url":"https://api.github.com/repos/shijungg/elasticdl/assignees{/user}","branches_url":"https://api.github.com/repos/shijungg/elasticdl/branches{/branch}","tags_url":"https://api.github.com/repos/shijungg/elasticdl/tags","blobs_url":"https://api.github.com/repos/shijungg/elasticdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shijungg/elasticdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shijungg/elasticdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/shijungg/elasticdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shijungg/elasticdl/statuses/{sha}","languages_url":"https://api.github.com/repos/shijungg/elasticdl/languages","stargazers_url":"https://api.github.com/repos/shijungg/elasticdl/stargazers","contributors_url":"https://api.github.com/repos/shijungg/elasticdl/contributors","subscribers_url":"https://api.github.com/repos/shijungg/elasticdl/subscribers","subscription_url":"https://api.github.com/repos/shijungg/elasticdl/subscription","commits_url":"https://api.github.com/repos/shijungg/elasticdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/shijungg/elasticdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/shijungg/elasticdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/shijungg/elasticdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/shijungg/elasticdl/contents/{+path}","compare_url":"https://api.github.com/repos/shijungg/elasticdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shijungg/elasticdl/merges","archive_url":"https://api.github.com/repos/shijungg/elasticdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shijungg/elasticdl/downloads","issues_url":"https://api.github.com/repos/shijungg/elasticdl/issues{/number}","pulls_url":"https://api.github.com/repos/shijungg/elasticdl/pulls{/number}","milestones_url":"https://api.github.com/repos/shijungg/elasticdl/milestones{/number}","notifications_url":"https://api.github.com/repos/shijungg/elasticdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shijungg/elasticdl/labels{/name}","releases_url":"https://api.github.com/repos/shijungg/elasticdl/releases{/id}","deployments_url":"https://api.github.com/repos/shijungg/elasticdl/deployments","created_at":"2019-10-17T08:23:01Z","updated_at":"2019-10-24T06:28:31Z","pushed_at":"2019-12-15T13:07:38Z","git_url":"git://github.com/shijungg/elasticdl.git","ssh_url":"git@github.com:shijungg/elasticdl.git","clone_url":"https://github.com/shijungg/elasticdl.git","svn_url":"https://github.com/shijungg/elasticdl","homepage":"https://elasticdl.org","size":6864,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sql-machine-learning:develop","ref":"develop","sha":"c37c1f763acb217a58a9f9a1b31768900cd1e023","user":{"login":"sql-machine-learning","id":48231449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MjMxNDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/48231449?v=4","gravatar_id":"","url":"https://api.github.com/users/sql-machine-learning","html_url":"https://github.com/sql-machine-learning","followers_url":"https://api.github.com/users/sql-machine-learning/followers","following_url":"https://api.github.com/users/sql-machine-learning/following{/other_user}","gists_url":"https://api.github.com/users/sql-machine-learning/gists{/gist_id}","starred_url":"https://api.github.com/users/sql-machine-learning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sql-machine-learning/subscriptions","organizations_url":"https://api.github.com/users/sql-machine-learning/orgs","repos_url":"https://api.github.com/users/sql-machine-learning/repos","events_url":"https://api.github.com/users/sql-machine-learning/events{/privacy}","received_events_url":"https://api.github.com/users/sql-machine-learning/received_events","type":"Organization","site_admin":false},"repo":{"id":154232678,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyMzI2Nzg=","name":"elasticdl","full_name":"sql-machine-learning/elasticdl","private":false,"owner":{"login":"sql-machine-learning","id":48231449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MjMxNDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/48231449?v=4","gravatar_id":"","url":"https://api.github.com/users/sql-machine-learning","html_url":"https://github.com/sql-machine-learning","followers_url":"https://api.github.com/users/sql-machine-learning/followers","following_url":"https://api.github.com/users/sql-machine-learning/following{/other_user}","gists_url":"https://api.github.com/users/sql-machine-learning/gists{/gist_id}","starred_url":"https://api.github.com/users/sql-machine-learning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sql-machine-learning/subscriptions","organizations_url":"https://api.github.com/users/sql-machine-learning/orgs","repos_url":"https://api.github.com/users/sql-machine-learning/repos","events_url":"https://api.github.com/users/sql-machine-learning/events{/privacy}","received_events_url":"https://api.github.com/users/sql-machine-learning/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sql-machine-learning/elasticdl","description":"Kubernetes-native Deep Learning Framework","fork":false,"url":"https://api.github.com/repos/sql-machine-learning/elasticdl","forks_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/forks","keys_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/teams","hooks_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/hooks","issue_events_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues/events{/number}","events_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/events","assignees_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/assignees{/user}","branches_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/branches{/branch}","tags_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/tags","blobs_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/statuses/{sha}","languages_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/languages","stargazers_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/stargazers","contributors_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/contributors","subscribers_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/subscribers","subscription_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/subscription","commits_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/contents/{+path}","compare_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/merges","archive_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/downloads","issues_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues{/number}","pulls_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls{/number}","milestones_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/milestones{/number}","notifications_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/labels{/name}","releases_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/releases{/id}","deployments_url":"https://api.github.com/repos/sql-machine-learning/elasticdl/deployments","created_at":"2018-10-22T23:53:10Z","updated_at":"2019-12-14T07:59:56Z","pushed_at":"2019-12-15T13:07:39Z","git_url":"git://github.com/sql-machine-learning/elasticdl.git","ssh_url":"git@github.com:sql-machine-learning/elasticdl.git","clone_url":"https://github.com/sql-machine-learning/elasticdl.git","svn_url":"https://github.com/sql-machine-learning/elasticdl","homepage":"https://elasticdl.org","size":6614,"stargazers_count":392,"watchers_count":392,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":64,"open_issues":43,"watchers":392,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/1565"},"html":{"href":"https://github.com/sql-machine-learning/elasticdl/pull/1565"},"issue":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues/1565"},"comments":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/issues/1565/comments"},"review_comments":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/1565/comments"},"review_comment":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/pulls/1565/commits"},"statuses":{"href":"https://api.github.com/repos/sql-machine-learning/elasticdl/statuses/92bed0fd26f586a9ac938ad51971e21728310a8c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":0,"deletions":0,"changed_files":0}}
other: {"actor":{"display_login":"shijungg"}}