payload: {"action":"created","comment":{"url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/comments/269423931","pull_request_review_id":219289818,"id":269423931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTQyMzkzMQ==","diff_hunk":"@@ -1779,6 +1779,51 @@ public static function escapeJSOutput($str)\n         return $str;\n     }\n \n+    /**\n+     * This method lets old updates insert shop system pages. The table \"shop_system_page\" has been removed in shop-165.inc.php and\n+     * old updates would fail when triggered afterwards.\n+     *\n+     * You should not use this method in new packages, which already know about the change.\n+     *\n+     * @param $shop_id\n+     * @param $name_internal\n+     * @param $name\n+     * @param string $cms_tree_id\n+     *\n+     * @deprecated since 6.2.0 - no longer used.\n+     */\n+    public static function addShopSystemPage($shop_id, $name_internal, $name, $cms_tree_id = '', $id = null)\n+    {\n+        if (self::TableExists('shop_system_page')) {\n+            $query = \"INSERT INTO `shop_system_page`\n+                      SET `shop_id` = '\".$shop_id.\"',\n+                          `name_internal` = '\".$name_internal.\"',\n+                          `name` = '\".$name.\"',\n+                          `cms_tree_id` = '\".$cms_tree_id.\"'\";\n+            if (null !== $id) {\n+                $query .= \", `id`='\".MySqlLegacySupport::getInstance()->real_escape_string($id).\"'\";\n+            }\n+            self::_RunQuery($query, __LINE__);\n+        } else {\n+            $shop = TdbShop::GetNewInstance();\n+            if ($shop->Load($shop_id)) {\n+                $portals = $shop->GetFieldCmsPortalIdList();\n+                foreach ($portals as $portalid) {\n+                    $query = \"INSERT INTO `cms_portal_system_page` SET\n+                                `cms_portal_id` =   '\".MySqlLegacySupport::getInstance()->real_escape_string($portalid).\"',","path":"src/CoreBundle/private/library/classes/TCMSLogChange.class.php","position":35,"original_position":35,"commit_id":"1e892452654b1befd89b6f981c3b37f31eb3f7df","original_commit_id":"1e892452654b1befd89b6f981c3b37f31eb3f7df","user":{"login":"UlrichKu","id":20949224,"node_id":"MDQ6VXNlcjIwOTQ5MjI0","avatar_url":"https://avatars0.githubusercontent.com/u/20949224?v=4","gravatar_id":"","url":"https://api.github.com/users/UlrichKu","html_url":"https://github.com/UlrichKu","followers_url":"https://api.github.com/users/UlrichKu/followers","following_url":"https://api.github.com/users/UlrichKu/following{/other_user}","gists_url":"https://api.github.com/users/UlrichKu/gists{/gist_id}","starred_url":"https://api.github.com/users/UlrichKu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UlrichKu/subscriptions","organizations_url":"https://api.github.com/users/UlrichKu/orgs","repos_url":"https://api.github.com/users/UlrichKu/repos","events_url":"https://api.github.com/users/UlrichKu/events{/privacy}","received_events_url":"https://api.github.com/users/UlrichKu/received_events","type":"User","site_admin":false},"body":"Is this copied from somewhere?\r\n\r\nOtherwise on could use \"database_connection\" for the escaping.","created_at":"2019-03-27T06:51:32Z","updated_at":"2019-03-27T06:51:37Z","html_url":"https://github.com/chameleon-system/chameleon-base/pull/291#discussion_r269423931","pull_request_url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/comments/269423931"},"html":{"href":"https://github.com/chameleon-system/chameleon-base/pull/291#discussion_r269423931"},"pull_request":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291","id":264617945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NjE3OTQ1","html_url":"https://github.com/chameleon-system/chameleon-base/pull/291","diff_url":"https://github.com/chameleon-system/chameleon-base/pull/291.diff","patch_url":"https://github.com/chameleon-system/chameleon-base/pull/291.patch","issue_url":"https://api.github.com/repos/chameleon-system/chameleon-base/issues/291","number":291,"state":"open","locked":false,"title":"Feature/323 cleanup","user":{"login":"umulmrum","id":6984809,"node_id":"MDQ6VXNlcjY5ODQ4MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6984809?v=4","gravatar_id":"","url":"https://api.github.com/users/umulmrum","html_url":"https://github.com/umulmrum","followers_url":"https://api.github.com/users/umulmrum/followers","following_url":"https://api.github.com/users/umulmrum/following{/other_user}","gists_url":"https://api.github.com/users/umulmrum/gists{/gist_id}","starred_url":"https://api.github.com/users/umulmrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umulmrum/subscriptions","organizations_url":"https://api.github.com/users/umulmrum/orgs","repos_url":"https://api.github.com/users/umulmrum/repos","events_url":"https://api.github.com/users/umulmrum/events{/privacy}","received_events_url":"https://api.github.com/users/umulmrum/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch        | master\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed issues  | chameleon-system/chameleon-system#323\r\n| License       | MIT\r\n","created_at":"2019-03-26T17:16:03Z","updated_at":"2019-03-27T06:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32cdab0c287aba6aee7635395581ceaca92dc03a","assignee":{"login":"UlrichKu","id":20949224,"node_id":"MDQ6VXNlcjIwOTQ5MjI0","avatar_url":"https://avatars0.githubusercontent.com/u/20949224?v=4","gravatar_id":"","url":"https://api.github.com/users/UlrichKu","html_url":"https://github.com/UlrichKu","followers_url":"https://api.github.com/users/UlrichKu/followers","following_url":"https://api.github.com/users/UlrichKu/following{/other_user}","gists_url":"https://api.github.com/users/UlrichKu/gists{/gist_id}","starred_url":"https://api.github.com/users/UlrichKu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UlrichKu/subscriptions","organizations_url":"https://api.github.com/users/UlrichKu/orgs","repos_url":"https://api.github.com/users/UlrichKu/repos","events_url":"https://api.github.com/users/UlrichKu/events{/privacy}","received_events_url":"https://api.github.com/users/UlrichKu/received_events","type":"User","site_admin":false},"assignees":[{"login":"UlrichKu","id":20949224,"node_id":"MDQ6VXNlcjIwOTQ5MjI0","avatar_url":"https://avatars0.githubusercontent.com/u/20949224?v=4","gravatar_id":"","url":"https://api.github.com/users/UlrichKu","html_url":"https://github.com/UlrichKu","followers_url":"https://api.github.com/users/UlrichKu/followers","following_url":"https://api.github.com/users/UlrichKu/following{/other_user}","gists_url":"https://api.github.com/users/UlrichKu/gists{/gist_id}","starred_url":"https://api.github.com/users/UlrichKu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UlrichKu/subscriptions","organizations_url":"https://api.github.com/users/UlrichKu/orgs","repos_url":"https://api.github.com/users/UlrichKu/repos","events_url":"https://api.github.com/users/UlrichKu/events{/privacy}","received_events_url":"https://api.github.com/users/UlrichKu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291/commits","review_comments_url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291/comments","review_comment_url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chameleon-system/chameleon-base/issues/291/comments","statuses_url":"https://api.github.com/repos/chameleon-system/chameleon-base/statuses/1e892452654b1befd89b6f981c3b37f31eb3f7df","head":{"label":"umulmrum:feature/323-cleanup","ref":"feature/323-cleanup","sha":"1e892452654b1befd89b6f981c3b37f31eb3f7df","user":{"login":"umulmrum","id":6984809,"node_id":"MDQ6VXNlcjY5ODQ4MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6984809?v=4","gravatar_id":"","url":"https://api.github.com/users/umulmrum","html_url":"https://github.com/umulmrum","followers_url":"https://api.github.com/users/umulmrum/followers","following_url":"https://api.github.com/users/umulmrum/following{/other_user}","gists_url":"https://api.github.com/users/umulmrum/gists{/gist_id}","starred_url":"https://api.github.com/users/umulmrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umulmrum/subscriptions","organizations_url":"https://api.github.com/users/umulmrum/orgs","repos_url":"https://api.github.com/users/umulmrum/repos","events_url":"https://api.github.com/users/umulmrum/events{/privacy}","received_events_url":"https://api.github.com/users/umulmrum/received_events","type":"User","site_admin":false},"repo":{"id":143120875,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxMjA4NzU=","name":"chameleon-base","full_name":"umulmrum/chameleon-base","private":false,"owner":{"login":"umulmrum","id":6984809,"node_id":"MDQ6VXNlcjY5ODQ4MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6984809?v=4","gravatar_id":"","url":"https://api.github.com/users/umulmrum","html_url":"https://github.com/umulmrum","followers_url":"https://api.github.com/users/umulmrum/followers","following_url":"https://api.github.com/users/umulmrum/following{/other_user}","gists_url":"https://api.github.com/users/umulmrum/gists{/gist_id}","starred_url":"https://api.github.com/users/umulmrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umulmrum/subscriptions","organizations_url":"https://api.github.com/users/umulmrum/orgs","repos_url":"https://api.github.com/users/umulmrum/repos","events_url":"https://api.github.com/users/umulmrum/events{/privacy}","received_events_url":"https://api.github.com/users/umulmrum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/umulmrum/chameleon-base","description":null,"fork":true,"url":"https://api.github.com/repos/umulmrum/chameleon-base","forks_url":"https://api.github.com/repos/umulmrum/chameleon-base/forks","keys_url":"https://api.github.com/repos/umulmrum/chameleon-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umulmrum/chameleon-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umulmrum/chameleon-base/teams","hooks_url":"https://api.github.com/repos/umulmrum/chameleon-base/hooks","issue_events_url":"https://api.github.com/repos/umulmrum/chameleon-base/issues/events{/number}","events_url":"https://api.github.com/repos/umulmrum/chameleon-base/events","assignees_url":"https://api.github.com/repos/umulmrum/chameleon-base/assignees{/user}","branches_url":"https://api.github.com/repos/umulmrum/chameleon-base/branches{/branch}","tags_url":"https://api.github.com/repos/umulmrum/chameleon-base/tags","blobs_url":"https://api.github.com/repos/umulmrum/chameleon-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umulmrum/chameleon-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umulmrum/chameleon-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/umulmrum/chameleon-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umulmrum/chameleon-base/statuses/{sha}","languages_url":"https://api.github.com/repos/umulmrum/chameleon-base/languages","stargazers_url":"https://api.github.com/repos/umulmrum/chameleon-base/stargazers","contributors_url":"https://api.github.com/repos/umulmrum/chameleon-base/contributors","subscribers_url":"https://api.github.com/repos/umulmrum/chameleon-base/subscribers","subscription_url":"https://api.github.com/repos/umulmrum/chameleon-base/subscription","commits_url":"https://api.github.com/repos/umulmrum/chameleon-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/umulmrum/chameleon-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/umulmrum/chameleon-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/umulmrum/chameleon-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/umulmrum/chameleon-base/contents/{+path}","compare_url":"https://api.github.com/repos/umulmrum/chameleon-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umulmrum/chameleon-base/merges","archive_url":"https://api.github.com/repos/umulmrum/chameleon-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umulmrum/chameleon-base/downloads","issues_url":"https://api.github.com/repos/umulmrum/chameleon-base/issues{/number}","pulls_url":"https://api.github.com/repos/umulmrum/chameleon-base/pulls{/number}","milestones_url":"https://api.github.com/repos/umulmrum/chameleon-base/milestones{/number}","notifications_url":"https://api.github.com/repos/umulmrum/chameleon-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umulmrum/chameleon-base/labels{/name}","releases_url":"https://api.github.com/repos/umulmrum/chameleon-base/releases{/id}","deployments_url":"https://api.github.com/repos/umulmrum/chameleon-base/deployments","created_at":"2018-08-01T07:37:00Z","updated_at":"2019-03-26T10:08:12Z","pushed_at":"2019-03-26T17:15:02Z","git_url":"git://github.com/umulmrum/chameleon-base.git","ssh_url":"git@github.com:umulmrum/chameleon-base.git","clone_url":"https://github.com/umulmrum/chameleon-base.git","svn_url":"https://github.com/umulmrum/chameleon-base","homepage":null,"size":14748,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chameleon-system:master","ref":"master","sha":"58bbacaf30505a67634daf05d3555fb789f7f1a3","user":{"login":"chameleon-system","id":17141685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTQxNjg1","avatar_url":"https://avatars3.githubusercontent.com/u/17141685?v=4","gravatar_id":"","url":"https://api.github.com/users/chameleon-system","html_url":"https://github.com/chameleon-system","followers_url":"https://api.github.com/users/chameleon-system/followers","following_url":"https://api.github.com/users/chameleon-system/following{/other_user}","gists_url":"https://api.github.com/users/chameleon-system/gists{/gist_id}","starred_url":"https://api.github.com/users/chameleon-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chameleon-system/subscriptions","organizations_url":"https://api.github.com/users/chameleon-system/orgs","repos_url":"https://api.github.com/users/chameleon-system/repos","events_url":"https://api.github.com/users/chameleon-system/events{/privacy}","received_events_url":"https://api.github.com/users/chameleon-system/received_events","type":"Organization","site_admin":false},"repo":{"id":139870579,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4NzA1Nzk=","name":"chameleon-base","full_name":"chameleon-system/chameleon-base","private":false,"owner":{"login":"chameleon-system","id":17141685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTQxNjg1","avatar_url":"https://avatars3.githubusercontent.com/u/17141685?v=4","gravatar_id":"","url":"https://api.github.com/users/chameleon-system","html_url":"https://github.com/chameleon-system","followers_url":"https://api.github.com/users/chameleon-system/followers","following_url":"https://api.github.com/users/chameleon-system/following{/other_user}","gists_url":"https://api.github.com/users/chameleon-system/gists{/gist_id}","starred_url":"https://api.github.com/users/chameleon-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chameleon-system/subscriptions","organizations_url":"https://api.github.com/users/chameleon-system/orgs","repos_url":"https://api.github.com/users/chameleon-system/repos","events_url":"https://api.github.com/users/chameleon-system/events{/privacy}","received_events_url":"https://api.github.com/users/chameleon-system/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chameleon-system/chameleon-base","description":null,"fork":false,"url":"https://api.github.com/repos/chameleon-system/chameleon-base","forks_url":"https://api.github.com/repos/chameleon-system/chameleon-base/forks","keys_url":"https://api.github.com/repos/chameleon-system/chameleon-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chameleon-system/chameleon-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chameleon-system/chameleon-base/teams","hooks_url":"https://api.github.com/repos/chameleon-system/chameleon-base/hooks","issue_events_url":"https://api.github.com/repos/chameleon-system/chameleon-base/issues/events{/number}","events_url":"https://api.github.com/repos/chameleon-system/chameleon-base/events","assignees_url":"https://api.github.com/repos/chameleon-system/chameleon-base/assignees{/user}","branches_url":"https://api.github.com/repos/chameleon-system/chameleon-base/branches{/branch}","tags_url":"https://api.github.com/repos/chameleon-system/chameleon-base/tags","blobs_url":"https://api.github.com/repos/chameleon-system/chameleon-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chameleon-system/chameleon-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chameleon-system/chameleon-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/chameleon-system/chameleon-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chameleon-system/chameleon-base/statuses/{sha}","languages_url":"https://api.github.com/repos/chameleon-system/chameleon-base/languages","stargazers_url":"https://api.github.com/repos/chameleon-system/chameleon-base/stargazers","contributors_url":"https://api.github.com/repos/chameleon-system/chameleon-base/contributors","subscribers_url":"https://api.github.com/repos/chameleon-system/chameleon-base/subscribers","subscription_url":"https://api.github.com/repos/chameleon-system/chameleon-base/subscription","commits_url":"https://api.github.com/repos/chameleon-system/chameleon-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/chameleon-system/chameleon-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/chameleon-system/chameleon-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/chameleon-system/chameleon-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/chameleon-system/chameleon-base/contents/{+path}","compare_url":"https://api.github.com/repos/chameleon-system/chameleon-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chameleon-system/chameleon-base/merges","archive_url":"https://api.github.com/repos/chameleon-system/chameleon-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chameleon-system/chameleon-base/downloads","issues_url":"https://api.github.com/repos/chameleon-system/chameleon-base/issues{/number}","pulls_url":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls{/number}","milestones_url":"https://api.github.com/repos/chameleon-system/chameleon-base/milestones{/number}","notifications_url":"https://api.github.com/repos/chameleon-system/chameleon-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chameleon-system/chameleon-base/labels{/name}","releases_url":"https://api.github.com/repos/chameleon-system/chameleon-base/releases{/id}","deployments_url":"https://api.github.com/repos/chameleon-system/chameleon-base/deployments","created_at":"2018-07-05T15:46:20Z","updated_at":"2019-03-26T09:55:59Z","pushed_at":"2019-03-26T17:16:04Z","git_url":"git://github.com/chameleon-system/chameleon-base.git","ssh_url":"git@github.com:chameleon-system/chameleon-base.git","clone_url":"https://github.com/chameleon-system/chameleon-base.git","svn_url":"https://github.com/chameleon-system/chameleon-base","homepage":"","size":14395,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":20,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291"},"html":{"href":"https://github.com/chameleon-system/chameleon-base/pull/291"},"issue":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/issues/291"},"comments":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/chameleon-system/chameleon-base/statuses/1e892452654b1befd89b6f981c3b37f31eb3f7df"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"UlrichKu"}}