payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Cantera/cantera/pulls/comments/354607535","pull_request_review_id":327927702,"id":354607535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDYwNzUzNQ==","diff_hunk":"@@ -109,6 +109,11 @@ class ThermoPhase : public Phase\n         return \"ThermoPhase\";\n     }\n \n+    //! String indicating the phase (liquid, vapor, etc.) of the phase\n+    virtual std::string getPhase() const {\n+        throw NotImplementedError(\"ThermoPhase::getPhase\");\n+    }","path":"include/cantera/thermo/ThermoPhase.h","position":7,"original_position":7,"commit_id":"4b04c335175523513df763f558736bc91914ef07","original_commit_id":"4b04c335175523513df763f558736bc91914ef07","user":{"login":"speth","id":644977,"node_id":"MDQ6VXNlcjY0NDk3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/644977?v=4","gravatar_id":"","url":"https://api.github.com/users/speth","html_url":"https://github.com/speth","followers_url":"https://api.github.com/users/speth/followers","following_url":"https://api.github.com/users/speth/following{/other_user}","gists_url":"https://api.github.com/users/speth/gists{/gist_id}","starred_url":"https://api.github.com/users/speth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speth/subscriptions","organizations_url":"https://api.github.com/users/speth/orgs","repos_url":"https://api.github.com/users/speth/repos","events_url":"https://api.github.com/users/speth/events{/privacy}","received_events_url":"https://api.github.com/users/speth/received_events","type":"User","site_admin":false},"body":"Agreed, the many meanings of 'phase' are a challenge. `phaseOfMatter` actually sounds pretty good to me, and I don't think it's overly verbose compared to many other method names that we have like `getPartialMolarEnthalpies`.","created_at":"2019-12-05T23:54:52Z","updated_at":"2019-12-05T23:54:53Z","html_url":"https://github.com/Cantera/cantera/pull/722#discussion_r354607535","pull_request_url":"https://api.github.com/repos/Cantera/cantera/pulls/722","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/comments/354607535"},"html":{"href":"https://github.com/Cantera/cantera/pull/722#discussion_r354607535"},"pull_request":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/722"}},"in_reply_to_id":353306181},"pull_request":{"url":"https://api.github.com/repos/Cantera/cantera/pulls/722","id":325044327,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1MDQ0MzI3","html_url":"https://github.com/Cantera/cantera/pull/722","diff_url":"https://github.com/Cantera/cantera/pull/722.diff","patch_url":"https://github.com/Cantera/cantera/pull/722.patch","issue_url":"https://api.github.com/repos/Cantera/cantera/issues/722","number":722,"state":"open","locked":false,"title":"[Thermo] Adds getPhase function","user":{"login":"bryanwweber","id":4396228,"node_id":"MDQ6VXNlcjQzOTYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/4396228?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanwweber","html_url":"https://github.com/bryanwweber","followers_url":"https://api.github.com/users/bryanwweber/followers","following_url":"https://api.github.com/users/bryanwweber/following{/other_user}","gists_url":"https://api.github.com/users/bryanwweber/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwweber/subscriptions","organizations_url":"https://api.github.com/users/bryanwweber/orgs","repos_url":"https://api.github.com/users/bryanwweber/repos","events_url":"https://api.github.com/users/bryanwweber/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwweber/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n- `getPhase` returns the phase (liquid, vapor, etc.) of the phase. Not\r\nimplemented in the base `ThermoPhase`, must be overridden in derived\r\nclasses because it only makes sense for phases that can have multiple\r\nphases.\r\n\r\nNot sure if this will be more generally useful. I was using it to help debug #721, but added it here to the `PureFluidPhase` instead of `WaterSSTP` because I don't want to touch `WaterSSTP` with a 39.5-foot pole. I could add a similar function to `WaterSSTP` though, if desired.","created_at":"2019-10-06T15:26:44Z","updated_at":"2019-12-05T23:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8964a292daec1cd4bebe29dc0d3cc6ea0eec146e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cantera/cantera/pulls/722/commits","review_comments_url":"https://api.github.com/repos/Cantera/cantera/pulls/722/comments","review_comment_url":"https://api.github.com/repos/Cantera/cantera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cantera/cantera/issues/722/comments","statuses_url":"https://api.github.com/repos/Cantera/cantera/statuses/4b04c335175523513df763f558736bc91914ef07","head":{"label":"bryanwweber:add-get-phase","ref":"add-get-phase","sha":"4b04c335175523513df763f558736bc91914ef07","user":{"login":"bryanwweber","id":4396228,"node_id":"MDQ6VXNlcjQzOTYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/4396228?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanwweber","html_url":"https://github.com/bryanwweber","followers_url":"https://api.github.com/users/bryanwweber/followers","following_url":"https://api.github.com/users/bryanwweber/following{/other_user}","gists_url":"https://api.github.com/users/bryanwweber/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwweber/subscriptions","organizations_url":"https://api.github.com/users/bryanwweber/orgs","repos_url":"https://api.github.com/users/bryanwweber/repos","events_url":"https://api.github.com/users/bryanwweber/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwweber/received_events","type":"User","site_admin":false},"repo":{"id":33513928,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUxMzkyOA==","name":"cantera","full_name":"bryanwweber/cantera","private":false,"owner":{"login":"bryanwweber","id":4396228,"node_id":"MDQ6VXNlcjQzOTYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/4396228?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanwweber","html_url":"https://github.com/bryanwweber","followers_url":"https://api.github.com/users/bryanwweber/followers","following_url":"https://api.github.com/users/bryanwweber/following{/other_user}","gists_url":"https://api.github.com/users/bryanwweber/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwweber/subscriptions","organizations_url":"https://api.github.com/users/bryanwweber/orgs","repos_url":"https://api.github.com/users/bryanwweber/repos","events_url":"https://api.github.com/users/bryanwweber/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwweber/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bryanwweber/cantera","description":"Chemical kinetics, thermodynamics, and transport tool suite","fork":true,"url":"https://api.github.com/repos/bryanwweber/cantera","forks_url":"https://api.github.com/repos/bryanwweber/cantera/forks","keys_url":"https://api.github.com/repos/bryanwweber/cantera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryanwweber/cantera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryanwweber/cantera/teams","hooks_url":"https://api.github.com/repos/bryanwweber/cantera/hooks","issue_events_url":"https://api.github.com/repos/bryanwweber/cantera/issues/events{/number}","events_url":"https://api.github.com/repos/bryanwweber/cantera/events","assignees_url":"https://api.github.com/repos/bryanwweber/cantera/assignees{/user}","branches_url":"https://api.github.com/repos/bryanwweber/cantera/branches{/branch}","tags_url":"https://api.github.com/repos/bryanwweber/cantera/tags","blobs_url":"https://api.github.com/repos/bryanwweber/cantera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryanwweber/cantera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryanwweber/cantera/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryanwweber/cantera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryanwweber/cantera/statuses/{sha}","languages_url":"https://api.github.com/repos/bryanwweber/cantera/languages","stargazers_url":"https://api.github.com/repos/bryanwweber/cantera/stargazers","contributors_url":"https://api.github.com/repos/bryanwweber/cantera/contributors","subscribers_url":"https://api.github.com/repos/bryanwweber/cantera/subscribers","subscription_url":"https://api.github.com/repos/bryanwweber/cantera/subscription","commits_url":"https://api.github.com/repos/bryanwweber/cantera/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryanwweber/cantera/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryanwweber/cantera/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryanwweber/cantera/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryanwweber/cantera/contents/{+path}","compare_url":"https://api.github.com/repos/bryanwweber/cantera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryanwweber/cantera/merges","archive_url":"https://api.github.com/repos/bryanwweber/cantera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryanwweber/cantera/downloads","issues_url":"https://api.github.com/repos/bryanwweber/cantera/issues{/number}","pulls_url":"https://api.github.com/repos/bryanwweber/cantera/pulls{/number}","milestones_url":"https://api.github.com/repos/bryanwweber/cantera/milestones{/number}","notifications_url":"https://api.github.com/repos/bryanwweber/cantera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryanwweber/cantera/labels{/name}","releases_url":"https://api.github.com/repos/bryanwweber/cantera/releases{/id}","deployments_url":"https://api.github.com/repos/bryanwweber/cantera/deployments","created_at":"2015-04-07T00:53:59Z","updated_at":"2019-12-05T13:43:54Z","pushed_at":"2019-12-05T13:43:51Z","git_url":"git://github.com/bryanwweber/cantera.git","ssh_url":"git@github.com:bryanwweber/cantera.git","clone_url":"https://github.com/bryanwweber/cantera.git","svn_url":"https://github.com/bryanwweber/cantera","homepage":"","size":35515,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cantera:master","ref":"master","sha":"3cd180254098c3931786d27e2531d42db07c7837","user":{"login":"Cantera","id":817698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNzY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/817698?v=4","gravatar_id":"","url":"https://api.github.com/users/Cantera","html_url":"https://github.com/Cantera","followers_url":"https://api.github.com/users/Cantera/followers","following_url":"https://api.github.com/users/Cantera/following{/other_user}","gists_url":"https://api.github.com/users/Cantera/gists{/gist_id}","starred_url":"https://api.github.com/users/Cantera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cantera/subscriptions","organizations_url":"https://api.github.com/users/Cantera/orgs","repos_url":"https://api.github.com/users/Cantera/repos","events_url":"https://api.github.com/users/Cantera/events{/privacy}","received_events_url":"https://api.github.com/users/Cantera/received_events","type":"Organization","site_admin":false},"repo":{"id":32940327,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk0MDMyNw==","name":"cantera","full_name":"Cantera/cantera","private":false,"owner":{"login":"Cantera","id":817698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNzY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/817698?v=4","gravatar_id":"","url":"https://api.github.com/users/Cantera","html_url":"https://github.com/Cantera","followers_url":"https://api.github.com/users/Cantera/followers","following_url":"https://api.github.com/users/Cantera/following{/other_user}","gists_url":"https://api.github.com/users/Cantera/gists{/gist_id}","starred_url":"https://api.github.com/users/Cantera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cantera/subscriptions","organizations_url":"https://api.github.com/users/Cantera/orgs","repos_url":"https://api.github.com/users/Cantera/repos","events_url":"https://api.github.com/users/Cantera/events{/privacy}","received_events_url":"https://api.github.com/users/Cantera/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cantera/cantera","description":"Chemical kinetics, thermodynamics, and transport tool suite","fork":false,"url":"https://api.github.com/repos/Cantera/cantera","forks_url":"https://api.github.com/repos/Cantera/cantera/forks","keys_url":"https://api.github.com/repos/Cantera/cantera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cantera/cantera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cantera/cantera/teams","hooks_url":"https://api.github.com/repos/Cantera/cantera/hooks","issue_events_url":"https://api.github.com/repos/Cantera/cantera/issues/events{/number}","events_url":"https://api.github.com/repos/Cantera/cantera/events","assignees_url":"https://api.github.com/repos/Cantera/cantera/assignees{/user}","branches_url":"https://api.github.com/repos/Cantera/cantera/branches{/branch}","tags_url":"https://api.github.com/repos/Cantera/cantera/tags","blobs_url":"https://api.github.com/repos/Cantera/cantera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cantera/cantera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cantera/cantera/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cantera/cantera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cantera/cantera/statuses/{sha}","languages_url":"https://api.github.com/repos/Cantera/cantera/languages","stargazers_url":"https://api.github.com/repos/Cantera/cantera/stargazers","contributors_url":"https://api.github.com/repos/Cantera/cantera/contributors","subscribers_url":"https://api.github.com/repos/Cantera/cantera/subscribers","subscription_url":"https://api.github.com/repos/Cantera/cantera/subscription","commits_url":"https://api.github.com/repos/Cantera/cantera/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cantera/cantera/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cantera/cantera/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cantera/cantera/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cantera/cantera/contents/{+path}","compare_url":"https://api.github.com/repos/Cantera/cantera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cantera/cantera/merges","archive_url":"https://api.github.com/repos/Cantera/cantera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cantera/cantera/downloads","issues_url":"https://api.github.com/repos/Cantera/cantera/issues{/number}","pulls_url":"https://api.github.com/repos/Cantera/cantera/pulls{/number}","milestones_url":"https://api.github.com/repos/Cantera/cantera/milestones{/number}","notifications_url":"https://api.github.com/repos/Cantera/cantera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cantera/cantera/labels{/name}","releases_url":"https://api.github.com/repos/Cantera/cantera/releases{/id}","deployments_url":"https://api.github.com/repos/Cantera/cantera/deployments","created_at":"2015-03-26T16:54:16Z","updated_at":"2019-12-05T10:09:01Z","pushed_at":"2019-12-05T20:11:07Z","git_url":"git://github.com/Cantera/cantera.git","ssh_url":"git@github.com:Cantera/cantera.git","clone_url":"https://github.com/Cantera/cantera.git","svn_url":"https://github.com/Cantera/cantera","homepage":"https://cantera.org","size":42459,"stargazers_count":219,"watchers_count":219,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":70,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":163,"open_issues":70,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/722"},"html":{"href":"https://github.com/Cantera/cantera/pull/722"},"issue":{"href":"https://api.github.com/repos/Cantera/cantera/issues/722"},"comments":{"href":"https://api.github.com/repos/Cantera/cantera/issues/722/comments"},"review_comments":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/722/comments"},"review_comment":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/722/commits"},"statuses":{"href":"https://api.github.com/repos/Cantera/cantera/statuses/4b04c335175523513df763f558736bc91914ef07"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"speth"}}