payload: {"action":"closed","number":28825,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/28825","id":353929349,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzOTI5MzQ5","html_url":"https://github.com/apple/swift/pull/28825","diff_url":"https://github.com/apple/swift/pull/28825.diff","patch_url":"https://github.com/apple/swift/pull/28825.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/28825","number":28825,"state":"closed","locked":false,"title":"[5.2] [Runtime] Handle Error-conforming-to-NSObject casting fully.","user":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"body":"Rather than attempting Error bridging early when trying to dynamically\r\ncast to NSError or NSObject, treat it as the last thing we do when\r\nall else fails. Push most of this code over into Objective-C-specific\r\nhandling rather than #ifdef'd into the main casting logic to make that\r\nslightly more clear.\r\n\r\nOne oddity of Error/NSError bridging is that a class that conforms to\r\nError can be dynamically cast to NSObject via Error bridging. This has\r\nalways been known to the static compiler, but the runtime itself was\r\nnot always handling such a cast uniformly. Do so now,\r\nuniformly. However, this forced us to weaken an assertion, because\r\ncasting a class type to NSError or NSObject can produce an object with\r\na different identity.\r\n\r\nFixes rdar://problem/57393991.","created_at":"2019-12-17T05:51:04Z","updated_at":"2019-12-18T23:48:32Z","closed_at":"2019-12-18T23:48:32Z","merged_at":"2019-12-18T23:48:32Z","merge_commit_sha":"41afb8c7fa7d008b806e378b95743a34d5869654","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/28825/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/28825/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/28825/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/e2610b651036690fdf5e307db72231ea88a69662","head":{"label":"DougGregor:bridge-all-the-errors-5.2","ref":"bridge-all-the-errors-5.2","sha":"e2610b651036690fdf5e307db72231ea88a69662","user":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"repo":{"id":50400732,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQwMDczMg==","name":"swift","full_name":"DougGregor/swift","private":false,"owner":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DougGregor/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/DougGregor/swift","forks_url":"https://api.github.com/repos/DougGregor/swift/forks","keys_url":"https://api.github.com/repos/DougGregor/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DougGregor/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DougGregor/swift/teams","hooks_url":"https://api.github.com/repos/DougGregor/swift/hooks","issue_events_url":"https://api.github.com/repos/DougGregor/swift/issues/events{/number}","events_url":"https://api.github.com/repos/DougGregor/swift/events","assignees_url":"https://api.github.com/repos/DougGregor/swift/assignees{/user}","branches_url":"https://api.github.com/repos/DougGregor/swift/branches{/branch}","tags_url":"https://api.github.com/repos/DougGregor/swift/tags","blobs_url":"https://api.github.com/repos/DougGregor/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DougGregor/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DougGregor/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/DougGregor/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DougGregor/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/DougGregor/swift/languages","stargazers_url":"https://api.github.com/repos/DougGregor/swift/stargazers","contributors_url":"https://api.github.com/repos/DougGregor/swift/contributors","subscribers_url":"https://api.github.com/repos/DougGregor/swift/subscribers","subscription_url":"https://api.github.com/repos/DougGregor/swift/subscription","commits_url":"https://api.github.com/repos/DougGregor/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/DougGregor/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/DougGregor/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/DougGregor/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/DougGregor/swift/contents/{+path}","compare_url":"https://api.github.com/repos/DougGregor/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DougGregor/swift/merges","archive_url":"https://api.github.com/repos/DougGregor/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DougGregor/swift/downloads","issues_url":"https://api.github.com/repos/DougGregor/swift/issues{/number}","pulls_url":"https://api.github.com/repos/DougGregor/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/DougGregor/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/DougGregor/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DougGregor/swift/labels{/name}","releases_url":"https://api.github.com/repos/DougGregor/swift/releases{/id}","deployments_url":"https://api.github.com/repos/DougGregor/swift/deployments","created_at":"2016-01-26T03:34:10Z","updated_at":"2019-06-02T14:02:42Z","pushed_at":"2019-12-18T23:48:06Z","git_url":"git://github.com/DougGregor/swift.git","ssh_url":"git@github.com:DougGregor/swift.git","clone_url":"https://github.com/DougGregor/swift.git","svn_url":"https://github.com/DougGregor/swift","homepage":"https://swift.org/","size":432545,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"apple:swift-5.2-branch","ref":"swift-5.2-branch","sha":"8719cbd4696f99100cbc2c393fe2f7233578ca69","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2019-12-18T23:31:18Z","pushed_at":"2019-12-18T23:48:33Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":516775,"stargazers_count":50090,"watchers_count":50090,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8096,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":440,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8096,"open_issues":440,"watchers":50090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/28825"},"html":{"href":"https://github.com/apple/swift/pull/28825"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/28825"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/28825/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/28825/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/28825/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/e2610b651036690fdf5e307db72231ea88a69662"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":149,"deletions":83,"changed_files":8}}
other: {"actor":{"display_login":"DougGregor"}}