payload: {"action":"created","comment":{"url":"https://api.github.com/repos/amzn/ion-python/pulls/comments/329791576","pull_request_review_id":295257842,"id":329791576,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTc5MTU3Ng==","diff_hunk":"@@ -0,0 +1,138 @@\n+# Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\").\n+# You may not use this file except in compliance with the License.\n+# A copy of the License is located at:\n+#\n+#    http://aws.amazon.com/apache2.0/\n+#\n+# or in the \"license\" file accompanying this file. This file is\n+# distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS\n+# OF ANY KIND, either express or implied. See the License for the\n+# specific language governing permissions and limitations under the\n+# License.\n+\n+# Python 2/3 compatibility\n+from decimal import Decimal\n+\n+import pytest\n+\n+from amazon.ion.core import Timestamp, TimestampPrecision, record\n+from tests import parametrize\n+\n+\n+class _P(record('timestamps', 'expected_microseconds')):\n+    def __str__(self):\n+        return self.desc\n+\n+\n+MISSING_MICROSECOND = _P(\n+    timestamps=[Timestamp(\n+            2011, 1, 1,\n+            0, 0, 0, None,\n+            precision=TimestampPrecision.SECOND, fractional_precision=6, fractional_seconds=0\n+            ),\n+            Timestamp(\n+            2011, 1, 1,\n+            0, 0, 0, None,\n+            precision=TimestampPrecision.SECOND, fractional_precision=6, fractional_seconds=Decimal('0.123456')\n+            ),\n+            Timestamp(\n+            2011, 1, 1,\n+            0, 0, 0, None,\n+            precision=TimestampPrecision.SECOND, fractional_precision=6, fractional_seconds=Decimal('0.123456789')\n+            ),\n+            Timestamp(\n+            2011, 1, 1,\n+            0, 0, 0, None,\n+            precision=TimestampPrecision.SECOND, fractional_precision=6, fractional_seconds=Decimal('0.000123')\n+            ),\n+            Timestamp(\n+            2011, 1, 1,\n+            0, 0, 0, None,\n+            precision=TimestampPrecision.SECOND, fractional_precision=6, fractional_seconds=Decimal('0.123000')\n+            )],\n+    expected_microseconds=[0, 123456, 123456, 123, 123000]","path":"tests/test_timestamp.py","position":55,"original_position":55,"commit_id":"f90eedfab0a11c5ca87b147af6bd9bb034e90567","original_commit_id":"f90eedfab0a11c5ca87b147af6bd9bb034e90567","user":{"login":"avneet-toor-bq","id":55262251,"node_id":"MDQ6VXNlcjU1MjYyMjUx","avatar_url":"https://avatars2.githubusercontent.com/u/55262251?v=4","gravatar_id":"","url":"https://api.github.com/users/avneet-toor-bq","html_url":"https://github.com/avneet-toor-bq","followers_url":"https://api.github.com/users/avneet-toor-bq/followers","following_url":"https://api.github.com/users/avneet-toor-bq/following{/other_user}","gists_url":"https://api.github.com/users/avneet-toor-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/avneet-toor-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avneet-toor-bq/subscriptions","organizations_url":"https://api.github.com/users/avneet-toor-bq/orgs","repos_url":"https://api.github.com/users/avneet-toor-bq/repos","events_url":"https://api.github.com/users/avneet-toor-bq/events{/privacy}","received_events_url":"https://api.github.com/users/avneet-toor-bq/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2019-09-30T21:19:30Z","updated_at":"2019-09-30T21:19:31Z","html_url":"https://github.com/amzn/ion-python/pull/100#discussion_r329791576","pull_request_url":"https://api.github.com/repos/amzn/ion-python/pulls/100","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/amzn/ion-python/pulls/comments/329791576"},"html":{"href":"https://github.com/amzn/ion-python/pull/100#discussion_r329791576"},"pull_request":{"href":"https://api.github.com/repos/amzn/ion-python/pulls/100"}},"in_reply_to_id":329422379},"pull_request":{"url":"https://api.github.com/repos/amzn/ion-python/pulls/100","id":318468210,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4NDY4MjEw","html_url":"https://github.com/amzn/ion-python/pull/100","diff_url":"https://github.com/amzn/ion-python/pull/100.diff","patch_url":"https://github.com/amzn/ion-python/pull/100.patch","issue_url":"https://api.github.com/repos/amzn/ion-python/issues/100","number":100,"state":"open","locked":false,"title":"Support timestamps with more than 6 digits of fractional precision","user":{"login":"avneet-toor-bq","id":55262251,"node_id":"MDQ6VXNlcjU1MjYyMjUx","avatar_url":"https://avatars2.githubusercontent.com/u/55262251?v=4","gravatar_id":"","url":"https://api.github.com/users/avneet-toor-bq","html_url":"https://github.com/avneet-toor-bq","followers_url":"https://api.github.com/users/avneet-toor-bq/followers","following_url":"https://api.github.com/users/avneet-toor-bq/following{/other_user}","gists_url":"https://api.github.com/users/avneet-toor-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/avneet-toor-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avneet-toor-bq/subscriptions","organizations_url":"https://api.github.com/users/avneet-toor-bq/orgs","repos_url":"https://api.github.com/users/avneet-toor-bq/repos","events_url":"https://api.github.com/users/avneet-toor-bq/events{/privacy}","received_events_url":"https://api.github.com/users/avneet-toor-bq/received_events","type":"User","site_admin":false},"body":"Issue #35 \r\n\r\n- Store the fractional seconds component as a property on the Timestamp object, storing full fidelity.\r\n- Truncate the fractional seconds to microseconds, if need be, and pass that to the Timestamp/datetime.\r\n- When serializing said Timestamp object the writer will use that fractional seconds field to encode the timestamp in text/binary with whatever fidelity it was set. \r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","created_at":"2019-09-17T18:26:47Z","updated_at":"2019-09-30T21:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f2c6f8303209ba11ee2a2d9c6e50169eaf9df25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/amzn/ion-python/pulls/100/commits","review_comments_url":"https://api.github.com/repos/amzn/ion-python/pulls/100/comments","review_comment_url":"https://api.github.com/repos/amzn/ion-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amzn/ion-python/issues/100/comments","statuses_url":"https://api.github.com/repos/amzn/ion-python/statuses/f90eedfab0a11c5ca87b147af6bd9bb034e90567","head":{"label":"avneet-toor-bq:test-unit-tests","ref":"test-unit-tests","sha":"f90eedfab0a11c5ca87b147af6bd9bb034e90567","user":{"login":"avneet-toor-bq","id":55262251,"node_id":"MDQ6VXNlcjU1MjYyMjUx","avatar_url":"https://avatars2.githubusercontent.com/u/55262251?v=4","gravatar_id":"","url":"https://api.github.com/users/avneet-toor-bq","html_url":"https://github.com/avneet-toor-bq","followers_url":"https://api.github.com/users/avneet-toor-bq/followers","following_url":"https://api.github.com/users/avneet-toor-bq/following{/other_user}","gists_url":"https://api.github.com/users/avneet-toor-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/avneet-toor-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avneet-toor-bq/subscriptions","organizations_url":"https://api.github.com/users/avneet-toor-bq/orgs","repos_url":"https://api.github.com/users/avneet-toor-bq/repos","events_url":"https://api.github.com/users/avneet-toor-bq/events{/privacy}","received_events_url":"https://api.github.com/users/avneet-toor-bq/received_events","type":"User","site_admin":false},"repo":{"id":208167378,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxNjczNzg=","name":"ion-python","full_name":"avneet-toor-bq/ion-python","private":false,"owner":{"login":"avneet-toor-bq","id":55262251,"node_id":"MDQ6VXNlcjU1MjYyMjUx","avatar_url":"https://avatars2.githubusercontent.com/u/55262251?v=4","gravatar_id":"","url":"https://api.github.com/users/avneet-toor-bq","html_url":"https://github.com/avneet-toor-bq","followers_url":"https://api.github.com/users/avneet-toor-bq/followers","following_url":"https://api.github.com/users/avneet-toor-bq/following{/other_user}","gists_url":"https://api.github.com/users/avneet-toor-bq/gists{/gist_id}","starred_url":"https://api.github.com/users/avneet-toor-bq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avneet-toor-bq/subscriptions","organizations_url":"https://api.github.com/users/avneet-toor-bq/orgs","repos_url":"https://api.github.com/users/avneet-toor-bq/repos","events_url":"https://api.github.com/users/avneet-toor-bq/events{/privacy}","received_events_url":"https://api.github.com/users/avneet-toor-bq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/avneet-toor-bq/ion-python","description":"A Python Implementation of Amazon Ion.","fork":true,"url":"https://api.github.com/repos/avneet-toor-bq/ion-python","forks_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/forks","keys_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/teams","hooks_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/hooks","issue_events_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/issues/events{/number}","events_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/events","assignees_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/assignees{/user}","branches_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/branches{/branch}","tags_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/tags","blobs_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/statuses/{sha}","languages_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/languages","stargazers_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/stargazers","contributors_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/contributors","subscribers_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/subscribers","subscription_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/subscription","commits_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/contents/{+path}","compare_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/merges","archive_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/downloads","issues_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/issues{/number}","pulls_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/pulls{/number}","milestones_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/milestones{/number}","notifications_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/labels{/name}","releases_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/releases{/id}","deployments_url":"https://api.github.com/repos/avneet-toor-bq/ion-python/deployments","created_at":"2019-09-13T00:10:34Z","updated_at":"2019-09-13T00:10:36Z","pushed_at":"2019-09-27T23:32:51Z","git_url":"git://github.com/avneet-toor-bq/ion-python.git","ssh_url":"git@github.com:avneet-toor-bq/ion-python.git","clone_url":"https://github.com/avneet-toor-bq/ion-python.git","svn_url":"https://github.com/avneet-toor-bq/ion-python","homepage":"http://amzn.github.io/ion-docs/","size":498,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amzn:master","ref":"master","sha":"c3d6613b4f611857bee1c1b9c414aebd9abf21d7","user":{"login":"amzn","id":8594673,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTQ2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8594673?v=4","gravatar_id":"","url":"https://api.github.com/users/amzn","html_url":"https://github.com/amzn","followers_url":"https://api.github.com/users/amzn/followers","following_url":"https://api.github.com/users/amzn/following{/other_user}","gists_url":"https://api.github.com/users/amzn/gists{/gist_id}","starred_url":"https://api.github.com/users/amzn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amzn/subscriptions","organizations_url":"https://api.github.com/users/amzn/orgs","repos_url":"https://api.github.com/users/amzn/repos","events_url":"https://api.github.com/users/amzn/events{/privacy}","received_events_url":"https://api.github.com/users/amzn/received_events","type":"Organization","site_admin":false},"repo":{"id":55726462,"node_id":"MDEwOlJlcG9zaXRvcnk1NTcyNjQ2Mg==","name":"ion-python","full_name":"amzn/ion-python","private":false,"owner":{"login":"amzn","id":8594673,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTQ2NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8594673?v=4","gravatar_id":"","url":"https://api.github.com/users/amzn","html_url":"https://github.com/amzn","followers_url":"https://api.github.com/users/amzn/followers","following_url":"https://api.github.com/users/amzn/following{/other_user}","gists_url":"https://api.github.com/users/amzn/gists{/gist_id}","starred_url":"https://api.github.com/users/amzn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amzn/subscriptions","organizations_url":"https://api.github.com/users/amzn/orgs","repos_url":"https://api.github.com/users/amzn/repos","events_url":"https://api.github.com/users/amzn/events{/privacy}","received_events_url":"https://api.github.com/users/amzn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/amzn/ion-python","description":"A Python Implementation of Amazon Ion.","fork":false,"url":"https://api.github.com/repos/amzn/ion-python","forks_url":"https://api.github.com/repos/amzn/ion-python/forks","keys_url":"https://api.github.com/repos/amzn/ion-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amzn/ion-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amzn/ion-python/teams","hooks_url":"https://api.github.com/repos/amzn/ion-python/hooks","issue_events_url":"https://api.github.com/repos/amzn/ion-python/issues/events{/number}","events_url":"https://api.github.com/repos/amzn/ion-python/events","assignees_url":"https://api.github.com/repos/amzn/ion-python/assignees{/user}","branches_url":"https://api.github.com/repos/amzn/ion-python/branches{/branch}","tags_url":"https://api.github.com/repos/amzn/ion-python/tags","blobs_url":"https://api.github.com/repos/amzn/ion-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amzn/ion-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amzn/ion-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/amzn/ion-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amzn/ion-python/statuses/{sha}","languages_url":"https://api.github.com/repos/amzn/ion-python/languages","stargazers_url":"https://api.github.com/repos/amzn/ion-python/stargazers","contributors_url":"https://api.github.com/repos/amzn/ion-python/contributors","subscribers_url":"https://api.github.com/repos/amzn/ion-python/subscribers","subscription_url":"https://api.github.com/repos/amzn/ion-python/subscription","commits_url":"https://api.github.com/repos/amzn/ion-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/amzn/ion-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/amzn/ion-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/amzn/ion-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/amzn/ion-python/contents/{+path}","compare_url":"https://api.github.com/repos/amzn/ion-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amzn/ion-python/merges","archive_url":"https://api.github.com/repos/amzn/ion-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amzn/ion-python/downloads","issues_url":"https://api.github.com/repos/amzn/ion-python/issues{/number}","pulls_url":"https://api.github.com/repos/amzn/ion-python/pulls{/number}","milestones_url":"https://api.github.com/repos/amzn/ion-python/milestones{/number}","notifications_url":"https://api.github.com/repos/amzn/ion-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amzn/ion-python/labels{/name}","releases_url":"https://api.github.com/repos/amzn/ion-python/releases{/id}","deployments_url":"https://api.github.com/repos/amzn/ion-python/deployments","created_at":"2016-04-07T20:38:50Z","updated_at":"2019-09-30T18:44:50Z","pushed_at":"2019-09-30T18:44:48Z","git_url":"git://github.com/amzn/ion-python.git","ssh_url":"git@github.com:amzn/ion-python.git","clone_url":"https://github.com/amzn/ion-python.git","svn_url":"https://github.com/amzn/ion-python","homepage":"http://amzn.github.io/ion-docs/","size":341,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":22,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amzn/ion-python/pulls/100"},"html":{"href":"https://github.com/amzn/ion-python/pull/100"},"issue":{"href":"https://api.github.com/repos/amzn/ion-python/issues/100"},"comments":{"href":"https://api.github.com/repos/amzn/ion-python/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/amzn/ion-python/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/amzn/ion-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amzn/ion-python/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/amzn/ion-python/statuses/f90eedfab0a11c5ca87b147af6bd9bb034e90567"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"avneet-toor-bq"}}