payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/352922401","pull_request_review_id":325821377,"id":352922401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjkyMjQwMQ==","diff_hunk":"@@ -127,10 +127,10 @@ def load_replay_buffer(self) -> None:\n         filename = os.path.join(self.policy.model_path, \"last_replay_buffer.hdf5\")\n         LOGGER.info(\"Loading Experience Replay Buffer from {}\".format(filename))\n         with open(filename, \"rb+\") as file_object:\n-            self.training_buffer.update_buffer.load_from_file(file_object)\n+            self.update_buffer.load_from_file(file_object)\n         LOGGER.info(\n             \"Experience replay buffer has {} experiences.\".format(\n-                len(self.training_buffer.update_buffer[\"actions\"])\n+                len(self.update_buffer[\"actions\"])","path":"ml-agents/mlagents/trainers/sac/trainer.py","position":27,"original_position":27,"commit_id":"d452faf998ef76a694ee86c4458d718f3c08effd","original_commit_id":"a4ef53b1c9b03c167ca2bae8b59a609ffd5732a9","user":{"login":"chriselion","id":6877802,"node_id":"MDQ6VXNlcjY4Nzc4MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/6877802?v=4","gravatar_id":"","url":"https://api.github.com/users/chriselion","html_url":"https://github.com/chriselion","followers_url":"https://api.github.com/users/chriselion/followers","following_url":"https://api.github.com/users/chriselion/following{/other_user}","gists_url":"https://api.github.com/users/chriselion/gists{/gist_id}","starred_url":"https://api.github.com/users/chriselion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriselion/subscriptions","organizations_url":"https://api.github.com/users/chriselion/orgs","repos_url":"https://api.github.com/users/chriselion/repos","events_url":"https://api.github.com/users/chriselion/events{/privacy}","received_events_url":"https://api.github.com/users/chriselion/received_events","type":"User","site_admin":false},"body":"self.update_buffer.num_experiences?","created_at":"2019-12-02T23:55:54Z","updated_at":"2019-12-02T23:55:55Z","html_url":"https://github.com/Unity-Technologies/ml-agents/pull/2964#discussion_r352922401","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/352922401"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/2964#discussion_r352922401"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964","id":345371457,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1MzcxNDU3","html_url":"https://github.com/Unity-Technologies/ml-agents/pull/2964","diff_url":"https://github.com/Unity-Technologies/ml-agents/pull/2964.diff","patch_url":"https://github.com/Unity-Technologies/ml-agents/pull/2964.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/2964","number":2964,"state":"open","locked":false,"title":"Split Buffer into processing and update buffers","user":{"login":"ervteng","id":5085265,"node_id":"MDQ6VXNlcjUwODUyNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5085265?v=4","gravatar_id":"","url":"https://api.github.com/users/ervteng","html_url":"https://github.com/ervteng","followers_url":"https://api.github.com/users/ervteng/followers","following_url":"https://api.github.com/users/ervteng/following{/other_user}","gists_url":"https://api.github.com/users/ervteng/gists{/gist_id}","starred_url":"https://api.github.com/users/ervteng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervteng/subscriptions","organizations_url":"https://api.github.com/users/ervteng/orgs","repos_url":"https://api.github.com/users/ervteng/repos","events_url":"https://api.github.com/users/ervteng/events{/privacy}","received_events_url":"https://api.github.com/users/ervteng/received_events","type":"User","site_admin":false},"body":"This is a series of PRs that intend to move the agent processing logic (add_experiences and process_experiences) out of the trainer and into a separate class. The plan is to do so in steps:\r\n\r\n- Split the processing buffers (keeping track of agent trajectories and assembling trajectories) and update buffer (complete trajectories to be used for training) within the Trainer (this PR)\r\n- Move the processing buffer and add/process experiences into a separate, outside class\r\n- Change the data type of the update buffer to be a Trajectory\r\n- Place and read Trajectories from queues, add subscription mechanism for both AgentProcessor and Trainers","created_at":"2019-11-25T19:07:28Z","updated_at":"2019-12-02T23:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7878896b5aae18c8e5e51261305368b7897b3c61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/2964/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/d452faf998ef76a694ee86c4458d718f3c08effd","head":{"label":"Unity-Technologies:develop-splitbuffer","ref":"develop-splitbuffer","sha":"d452faf998ef76a694ee86c4458d718f3c08effd","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MDQ2MTM=","name":"ml-agents","full_name":"Unity-Technologies/ml-agents","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents Toolkit","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2019-12-02T23:31:10Z","pushed_at":"2019-12-02T23:51:37Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":333013,"stargazers_count":7300,"watchers_count":7300,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1901,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1901,"open_issues":124,"watchers":7300,"default_branch":"master"}},"base":{"label":"Unity-Technologies:develop","ref":"develop","sha":"407288208d31802c878d89f66d8ee0d1019effde","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MDQ2MTM=","name":"ml-agents","full_name":"Unity-Technologies/ml-agents","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents Toolkit","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2019-12-02T23:31:10Z","pushed_at":"2019-12-02T23:51:37Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":333013,"stargazers_count":7300,"watchers_count":7300,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1901,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1901,"open_issues":124,"watchers":7300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/2964"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/2964"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/2964/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/2964/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/d452faf998ef76a694ee86c4458d718f3c08effd"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"chriselion"}}