payload: {"action":"created","issue":{"url":"https://api.github.com/repos/stellar/go/issues/1149","repository_url":"https://api.github.com/repos/stellar/go","labels_url":"https://api.github.com/repos/stellar/go/issues/1149/labels{/name}","comments_url":"https://api.github.com/repos/stellar/go/issues/1149/comments","events_url":"https://api.github.com/repos/stellar/go/issues/1149/events","html_url":"https://github.com/stellar/go/issues/1149","id":434091859,"node_id":"MDU6SXNzdWU0MzQwOTE4NTk=","number":1149,"title":"Issue: Streampayments contains empty memo fields","user":{"login":"Pedity-Luffy","id":45870711,"node_id":"MDQ6VXNlcjQ1ODcwNzEx","avatar_url":"https://avatars3.githubusercontent.com/u/45870711?v=4","gravatar_id":"","url":"https://api.github.com/users/Pedity-Luffy","html_url":"https://github.com/Pedity-Luffy","followers_url":"https://api.github.com/users/Pedity-Luffy/followers","following_url":"https://api.github.com/users/Pedity-Luffy/following{/other_user}","gists_url":"https://api.github.com/users/Pedity-Luffy/gists{/gist_id}","starred_url":"https://api.github.com/users/Pedity-Luffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pedity-Luffy/subscriptions","organizations_url":"https://api.github.com/users/Pedity-Luffy/orgs","repos_url":"https://api.github.com/users/Pedity-Luffy/repos","events_url":"https://api.github.com/users/Pedity-Luffy/events{/privacy}","received_events_url":"https://api.github.com/users/Pedity-Luffy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-04-17T04:56:44Z","updated_at":"2019-04-23T04:24:38Z","closed_at":"2019-04-22T20:05:05Z","author_association":"NONE","body":"The Streampayments function in stellar go horizon, returns empty memo Type and memo Value. All other fields work fine. \r\nhttps://godoc.org/github.com/stellar/go/clients/horizon#Client.StreamPayments\r\nhttps://godoc.org/github.com/stellar/go/clients/horizon#Payment\r\nThis issue is tested for memo type - ID, TEXT, HASH\r\n\r\nAn rough example is below -\r\n```\r\n\tconst address = \"GBD3ECXAO4427NFYIZH6TYSZVX2I76KVUHYYKJIQZUYC3GHA73KHGNNV\"\r\n\r\n\tctx := context.Background()\r\n\r\n\tcursor := horizon.Cursor(\"98924319576453121\")\r\nhorizon.DefaultPublicNetClient.StreamPayments(ctx, address, &cursor, func(payment horizon.Payment) {\r\n\t\tfmt.Println(\"Payment Memo Type\", payment.Memo.Type)\r\n\t\tfmt.Println(\"Payment Memo Value\", payment.Memo.Value)\r\n}\r\n```\r\n\r\nTo update the the payment structure, a user will have to run the mocking LoadMemo method and than Memo Data will be updated. For example\r\n```\r\n\tconst address = \"GBD3ECXAO4427NFYIZH6TYSZVX2I76KVUHYYKJIQZUYC3GHA73KHGNNV\"\r\n\r\n\tctx := context.Background()\r\n\r\n\tcursor := horizon.Cursor(\"98924319576453121\")\r\nhorizon.DefaultPublicNetClient.StreamPayments(ctx, address, &cursor, func(payment horizon.Payment) {\r\n\t        horizon.DefaultPublicNetClient.LoadMemo(&payment)\r\n\t\tfmt.Println(\"Payment Memo Type\", payment.Memo.Type)\r\n\t\tfmt.Println(\"Payment Memo Value\", payment.Memo.Value)\r\n}\r\n```\r\nThis should be default without using LoadMemo or should be updated in stellar godoc."},"comment":{"url":"https://api.github.com/repos/stellar/go/issues/comments/485638496","html_url":"https://github.com/stellar/go/issues/1149#issuecomment-485638496","issue_url":"https://api.github.com/repos/stellar/go/issues/1149","id":485638496,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NTYzODQ5Ng==","user":{"login":"ire-and-curses","id":1606404,"node_id":"MDQ6VXNlcjE2MDY0MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1606404?v=4","gravatar_id":"","url":"https://api.github.com/users/ire-and-curses","html_url":"https://github.com/ire-and-curses","followers_url":"https://api.github.com/users/ire-and-curses/followers","following_url":"https://api.github.com/users/ire-and-curses/following{/other_user}","gists_url":"https://api.github.com/users/ire-and-curses/gists{/gist_id}","starred_url":"https://api.github.com/users/ire-and-curses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ire-and-curses/subscriptions","organizations_url":"https://api.github.com/users/ire-and-curses/orgs","repos_url":"https://api.github.com/users/ire-and-curses/repos","events_url":"https://api.github.com/users/ire-and-curses/events{/privacy}","received_events_url":"https://api.github.com/users/ire-and-curses/received_events","type":"User","site_admin":false},"created_at":"2019-04-23T04:24:38Z","updated_at":"2019-04-23T04:24:38Z","author_association":"CONTRIBUTOR","body":"@Pedity-Luffy I agree this should be clarified. @poliha lets confirm the behaviour in the new `horizonclient` and modify as needed."}}
other: {"actor":{"display_login":"ire-and-curses"}}