payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/291406079","pull_request_review_id":246857591,"id":291406079,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTQwNjA3OQ==","diff_hunk":"@@ -22,64 +22,109 @@ struct gpio_sam_config {\n };\n \n struct gpio_sam_runtime {\n+\tu32_t invert;\n \tsys_slist_t cb;\n };\n \n #define DEV_CFG(dev) \\\n \t((const struct gpio_sam_config *const)(dev)->config->config_info)\n+#define DEV_DATA(dev) \\\n+\t((struct gpio_sam_runtime *const)(dev)->driver_data)\n \n-static int gpio_sam_config_pin(Pio * const pio, u32_t mask, int flags)\n+static int gpio_sam_config_pin(struct device *dev, Pio * const pio, u32_t mask,\n+\t\t\t       int flags)\n {\n+\tstruct gpio_sam_runtime *const dev_data = DEV_DATA(dev);\n+\n+\tif (!(flags & (GPIO_OUTPUT | GPIO_INPUT))) {\n+\t\t/* Neither input nor output mode is selected */\n+\n+\t\t/* Disable the interrupt. */\n+\t\tpio->PIO_IDR = mask;\n+\t\t/* Disable pull-up. */\n+\t\tpio->PIO_PUDR = mask;\n+\t\t/* Disable pull-down. */\n+\t\tpio->PIO_PPDDR = mask;\n+\t\t/* Let the PIO control the pin (instead of a peripheral). */\n+\t\tpio->PIO_PER = mask;\n+\t\t/* Disable output. */\n+\t\tpio->PIO_ODR = mask;\n+\n+\t\treturn 0;\n+\t}\n+\n \t/* Setup the pin direcion. */\n-\tif ((flags & GPIO_DIR_MASK) == GPIO_DIR_OUT) {\n+\tif (flags & GPIO_OUTPUT) {\n+\t\tif (flags & GPIO_OUTPUT_INIT_HIGH) {\n+\t\t\t/* Set the pin. */\n+\t\t\tpio->PIO_SODR = mask;\n+\t\t}\n+\t\tif (flags & GPIO_OUTPUT_INIT_LOW) {\n+\t\t\t/* Clear the pin. */\n+\t\t\tpio->PIO_CODR = mask;\n+\t\t}\n \t\tpio->PIO_OER = mask;\n \t} else {\n \t\tpio->PIO_ODR = mask;\n \t}\n \n+\t/* Note: Input is always enabled. */\n+\n+\tif (flags & GPIO_ACTIVE_LOW) {\n+\t\tdev_data->invert |= mask;\n+\t} else {\n+\t\tdev_data->invert &= ~mask;\n+\t}\n+\n \t/* Setup interrupt configuration. */\n-\tif (flags & GPIO_INT) {\n-\t\tif (flags & GPIO_INT_DOUBLE_EDGE) {\n-\t\t\treturn -ENOTSUP;\n-\t\t}\n \n-\t\t/* Enable the interrupt. */\n-\t\tpio->PIO_IER = mask;\n+\t/* Disable the interrupt. */\n+\tpio->PIO_IDR = mask;\n+\t/* Disable additional interrupt modes. */\n+\tpio->PIO_AIMDR = mask;\n+\n+\tif ((flags & GPIO_INT) &&\n+\t    (flags & (GPIO_INT_LOW_0 | GPIO_INT_HIGH_1))) {\n+\t\tif (!((flags & GPIO_INT_LOW_0) && (flags & GPIO_INT_HIGH_1))) {\n+\t\t\t/* Enable additional interrupt modes. */\n+\t\t\tpio->PIO_AIMER = mask;\n+\n+\t\t\tif (flags & GPIO_INT_EDGE) {\n+\t\t\t\tpio->PIO_ESR = mask;\n+\t\t\t} else {\n+\t\t\t\tpio->PIO_LSR = mask;\n+\t\t\t}\n \n-\t\t/* Enable the additional interrupt modes. */\n-\t\tpio->PIO_AIMER = mask;\n+\t\t\tbool rising_edge = flags & GPIO_INT_HIGH_1;\n \n-\t\tif (flags & GPIO_INT_EDGE) {\n-\t\t\tpio->PIO_ESR = mask;\n-\t\t} else {\n-\t\t\tpio->PIO_LSR = mask;\n-\t\t}\n+\t\t\tif ((flags & GPIO_INT_LEVELS_LOGICAL) &&\n+\t\t\t    (flags & GPIO_ACTIVE_LOW)) {\n+\t\t\t\trising_edge = !rising_edge;\n+\t\t\t}\n \n-\t\tif (flags & GPIO_INT_ACTIVE_HIGH) {\n-\t\t\t/* Set to high-level or rising edge. */\n-\t\t\tpio->PIO_REHLSR = mask;\n-\t\t} else {\n-\t\t\t/* Set to low-level or falling edge. */\n-\t\t\tpio->PIO_FELLSR = mask;\n+\t\t\tif (rising_edge) {\n+\t\t\t\t/* Set to high-level or rising edge. */\n+\t\t\t\tpio->PIO_REHLSR = mask;\n+\t\t\t} else {\n+\t\t\t\t/* Set to low-level or falling edge. */\n+\t\t\t\tpio->PIO_FELLSR = mask;\n+\t\t\t}\n \t\t}\n-\t} else {\n-\t\t/* Disable the interrupt. */\n-\t\tpio->PIO_IDR = mask;\n \n-\t\t/* Disable ther additional interrupt modes. */\n-\t\tpio->PIO_AIMDR = mask;\n+\t\t/* Enable the interrupt. */\n+\t\tpio->PIO_IER = mask;\n \t}\n \n \t/* Setup Pull-up resistor. */\n-\tif ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_UP) {\n+\tif (flags & GPIO_PULL_UP) {","path":"drivers/gpio/gpio_sam.c","position":125,"original_position":125,"commit_id":"ba1d89e3a64cc9e2aada34d3566a4f645c4066a3","original_commit_id":"18012a6fa173c66d881ddae845d5d87a9d1f9c61","user":{"login":"mbolivar","id":35088,"node_id":"MDQ6VXNlcjM1MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/35088?v=4","gravatar_id":"","url":"https://api.github.com/users/mbolivar","html_url":"https://github.com/mbolivar","followers_url":"https://api.github.com/users/mbolivar/followers","following_url":"https://api.github.com/users/mbolivar/following{/other_user}","gists_url":"https://api.github.com/users/mbolivar/gists{/gist_id}","starred_url":"https://api.github.com/users/mbolivar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbolivar/subscriptions","organizations_url":"https://api.github.com/users/mbolivar/orgs","repos_url":"https://api.github.com/users/mbolivar/repos","events_url":"https://api.github.com/users/mbolivar/events{/privacy}","received_events_url":"https://api.github.com/users/mbolivar/received_events","type":"User","site_admin":false},"body":"Does it really make sense to let the user turn on both the pull up and pull down resistors? Sorry if I am not understanding the idea, but it doesn't seem sensible.\r\n\r\nI guess part of the Zephyr philosophy is \"minimal error checking\". But maybe we could add some asserts for inconsistent behavior like this if you agree it doesn't make sense, but don't want to add code or runtime cost to check this sort of thing in production builds.","created_at":"2019-06-06T23:15:41Z","updated_at":"2019-06-06T23:19:32Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/16648#discussion_r291406079","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/291406079"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/16648#discussion_r291406079"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648","id":285575332,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NTc1MzMy","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/16648","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/16648.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/16648.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/16648","number":16648,"state":"open","locked":false,"title":"Update GPIO API to support flags used by Linux DT bindings","user":{"login":"mnkp","id":28196316,"node_id":"MDQ6VXNlcjI4MTk2MzE2","avatar_url":"https://avatars0.githubusercontent.com/u/28196316?v=4","gravatar_id":"","url":"https://api.github.com/users/mnkp","html_url":"https://github.com/mnkp","followers_url":"https://api.github.com/users/mnkp/followers","following_url":"https://api.github.com/users/mnkp/following{/other_user}","gists_url":"https://api.github.com/users/mnkp/gists{/gist_id}","starred_url":"https://api.github.com/users/mnkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnkp/subscriptions","organizations_url":"https://api.github.com/users/mnkp/orgs","repos_url":"https://api.github.com/users/mnkp/repos","events_url":"https://api.github.com/users/mnkp/events{/privacy}","received_events_url":"https://api.github.com/users/mnkp/received_events","type":"User","site_admin":false},"body":"This is a first PR in series which updates GPIO API, drivers and samples to implement changes discussed in #15611, #10339. It is based on work done in #12651, #11880.\r\n\r\nThe primary focus of this PR is to introduce standard flags used by [Linux DT bindings](https://elixir.bootlin.com/linux/latest/source/include/dt-bindings/gpio/gpio.h). The specific changes implemented:\r\n- Added GPIO_ACTIVE_LOW, GPIO_ACTIVE_HIGH to indicate pin active state.\r\n- Added GPIO_OPEN_DRAIN, GPIO_OPEN_SOURCE to configure single ended pin\r\n  driving mode.\r\n- Added GPIO_PULL_UP, GPIO_PULL_DOWN flags.\r\n\r\nSupport for GPIO_PERSISTENT, GPIO_TRANSITORY flags (bit 3) will be added later.\r\n\r\nRemaining changes:\r\n- Added flags to support [gpio](https://www.kernel.org/doc/Documentation/devicetree/bindings/gpio/gpio.txt) and [pinctrl](https://www.kernel.org/doc/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt) bindings defined in form of properties.\r\n    - GPIO_INPUT, GPIO_OUTPUT to configure pin as input or output.\r\n    - Added GPIO_OUTPUT_LOW, GPIO_OUTPUT_HIGH flags to initialize output in low or high state.\r\n\r\n- All GPIO flags which should not be used in DTS were removed from DT bindings gpio.h file. Support for DTS properties of GPIO node such as: input, output-low, output-high, line-name, etc. will be added in the future.\r\n- GPIO_INT_* flags were reworked to support configuration of pin interrupts on logical or physical levels.\r\n- Following flags were deprecated: GPIO_DIR_*, GPIO_DS_DISCONNECT_*, GPIO_PUD_*, GPIO_INT_ACTIVE_*, GPIO_INT_DOUBLE_EDGE, GPIO_POL_*.\r\n- Added gpio_pin_set, gpio_pin_get functions which work with pin logical levels, taking into account GPIO_ACTIVE_LOW flag\r\n\r\ngpio_sam, gpio_gecko drivers along with .dts and other infrastructure files were updated to reflect above changes. Also 'button' and 'blinky' samples were updated to use the new GPIO flags.\r\n\r\nThis PR is not yet complete. To be able to merge it we need to update all existing GPIO drivers, samples and tests to use the new flags.\r\n\r\nAny functional changes not mentioned here will be addressed in subsequent PRs. Specifically this PR doesn't modify flags related to pin drive strength, debouncing neither attempts to introduce functions operating on ports.\r\n","created_at":"2019-06-05T22:33:07Z","updated_at":"2019-06-06T23:19:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"643c47f21d947f6ba229f88cc7613fda1036ddb7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"pabigot","id":964298,"node_id":"MDQ6VXNlcjk2NDI5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/964298?v=4","gravatar_id":"","url":"https://api.github.com/users/pabigot","html_url":"https://github.com/pabigot","followers_url":"https://api.github.com/users/pabigot/followers","following_url":"https://api.github.com/users/pabigot/following{/other_user}","gists_url":"https://api.github.com/users/pabigot/gists{/gist_id}","starred_url":"https://api.github.com/users/pabigot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabigot/subscriptions","organizations_url":"https://api.github.com/users/pabigot/orgs","repos_url":"https://api.github.com/users/pabigot/repos","events_url":"https://api.github.com/users/pabigot/events{/privacy}","received_events_url":"https://api.github.com/users/pabigot/received_events","type":"User","site_admin":false},{"login":"fallrisk","id":1434184,"node_id":"MDQ6VXNlcjE0MzQxODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1434184?v=4","gravatar_id":"","url":"https://api.github.com/users/fallrisk","html_url":"https://github.com/fallrisk","followers_url":"https://api.github.com/users/fallrisk/followers","following_url":"https://api.github.com/users/fallrisk/following{/other_user}","gists_url":"https://api.github.com/users/fallrisk/gists{/gist_id}","starred_url":"https://api.github.com/users/fallrisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fallrisk/subscriptions","organizations_url":"https://api.github.com/users/fallrisk/orgs","repos_url":"https://api.github.com/users/fallrisk/repos","events_url":"https://api.github.com/users/fallrisk/events{/privacy}","received_events_url":"https://api.github.com/users/fallrisk/received_events","type":"User","site_admin":false},{"login":"b0661","id":5486823,"node_id":"MDQ6VXNlcjU0ODY4MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5486823?v=4","gravatar_id":"","url":"https://api.github.com/users/b0661","html_url":"https://github.com/b0661","followers_url":"https://api.github.com/users/b0661/followers","following_url":"https://api.github.com/users/b0661/following{/other_user}","gists_url":"https://api.github.com/users/b0661/gists{/gist_id}","starred_url":"https://api.github.com/users/b0661/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b0661/subscriptions","organizations_url":"https://api.github.com/users/b0661/orgs","repos_url":"https://api.github.com/users/b0661/repos","events_url":"https://api.github.com/users/b0661/events{/privacy}","received_events_url":"https://api.github.com/users/b0661/received_events","type":"User","site_admin":false},{"login":"MaureenHelm","id":6172539,"node_id":"MDQ6VXNlcjYxNzI1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"carlescufi","id":12450381,"node_id":"MDQ6VXNlcjEyNDUwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false},{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false},{"login":"anangl","id":16913290,"node_id":"MDQ6VXNlcjE2OTEzMjkw","avatar_url":"https://avatars3.githubusercontent.com/u/16913290?v=4","gravatar_id":"","url":"https://api.github.com/users/anangl","html_url":"https://github.com/anangl","followers_url":"https://api.github.com/users/anangl/followers","following_url":"https://api.github.com/users/anangl/following{/other_user}","gists_url":"https://api.github.com/users/anangl/gists{/gist_id}","starred_url":"https://api.github.com/users/anangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anangl/subscriptions","organizations_url":"https://api.github.com/users/anangl/orgs","repos_url":"https://api.github.com/users/anangl/repos","events_url":"https://api.github.com/users/anangl/events{/privacy}","received_events_url":"https://api.github.com/users/anangl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":807706246,"node_id":"MDU6TGFiZWw4MDc3MDYyNDY=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/DNM","name":"DNM","color":"b60205","default":false},{"id":796963297,"node_id":"MDU6TGFiZWw3OTY5NjMyOTc=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20API","name":"area: API","color":"ededed","default":false},{"id":700751309,"node_id":"MDU6TGFiZWw3MDA3NTEzMDk=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20GPIO","name":"area: GPIO","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/16648/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/ba1d89e3a64cc9e2aada34d3566a4f645c4066a3","head":{"label":"mnkp:gpio_api_update","ref":"gpio_api_update","sha":"ba1d89e3a64cc9e2aada34d3566a4f645c4066a3","user":{"login":"mnkp","id":28196316,"node_id":"MDQ6VXNlcjI4MTk2MzE2","avatar_url":"https://avatars0.githubusercontent.com/u/28196316?v=4","gravatar_id":"","url":"https://api.github.com/users/mnkp","html_url":"https://github.com/mnkp","followers_url":"https://api.github.com/users/mnkp/followers","following_url":"https://api.github.com/users/mnkp/following{/other_user}","gists_url":"https://api.github.com/users/mnkp/gists{/gist_id}","starred_url":"https://api.github.com/users/mnkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnkp/subscriptions","organizations_url":"https://api.github.com/users/mnkp/orgs","repos_url":"https://api.github.com/users/mnkp/repos","events_url":"https://api.github.com/users/mnkp/events{/privacy}","received_events_url":"https://api.github.com/users/mnkp/received_events","type":"User","site_admin":false},"repo":{"id":89915654,"node_id":"MDEwOlJlcG9zaXRvcnk4OTkxNTY1NA==","name":"zephyr","full_name":"mnkp/zephyr","private":false,"owner":{"login":"mnkp","id":28196316,"node_id":"MDQ6VXNlcjI4MTk2MzE2","avatar_url":"https://avatars0.githubusercontent.com/u/28196316?v=4","gravatar_id":"","url":"https://api.github.com/users/mnkp","html_url":"https://github.com/mnkp","followers_url":"https://api.github.com/users/mnkp/followers","following_url":"https://api.github.com/users/mnkp/following{/other_user}","gists_url":"https://api.github.com/users/mnkp/gists{/gist_id}","starred_url":"https://api.github.com/users/mnkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnkp/subscriptions","organizations_url":"https://api.github.com/users/mnkp/orgs","repos_url":"https://api.github.com/users/mnkp/repos","events_url":"https://api.github.com/users/mnkp/events{/privacy}","received_events_url":"https://api.github.com/users/mnkp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mnkp/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/mnkp/zephyr","forks_url":"https://api.github.com/repos/mnkp/zephyr/forks","keys_url":"https://api.github.com/repos/mnkp/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnkp/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnkp/zephyr/teams","hooks_url":"https://api.github.com/repos/mnkp/zephyr/hooks","issue_events_url":"https://api.github.com/repos/mnkp/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/mnkp/zephyr/events","assignees_url":"https://api.github.com/repos/mnkp/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/mnkp/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/mnkp/zephyr/tags","blobs_url":"https://api.github.com/repos/mnkp/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnkp/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnkp/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnkp/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnkp/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/mnkp/zephyr/languages","stargazers_url":"https://api.github.com/repos/mnkp/zephyr/stargazers","contributors_url":"https://api.github.com/repos/mnkp/zephyr/contributors","subscribers_url":"https://api.github.com/repos/mnkp/zephyr/subscribers","subscription_url":"https://api.github.com/repos/mnkp/zephyr/subscription","commits_url":"https://api.github.com/repos/mnkp/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnkp/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnkp/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnkp/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnkp/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/mnkp/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnkp/zephyr/merges","archive_url":"https://api.github.com/repos/mnkp/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnkp/zephyr/downloads","issues_url":"https://api.github.com/repos/mnkp/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/mnkp/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/mnkp/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/mnkp/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnkp/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/mnkp/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/mnkp/zephyr/deployments","created_at":"2017-05-01T10:35:59Z","updated_at":"2019-06-04T23:39:36Z","pushed_at":"2019-06-06T22:21:51Z","git_url":"git://github.com/mnkp/zephyr.git","ssh_url":"git@github.com:mnkp/zephyr.git","clone_url":"https://github.com/mnkp/zephyr.git","svn_url":"https://github.com/mnkp/zephyr","homepage":"http://zephyrproject.org/doc","size":225143,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"eeb2e67f2b3b025a57499411a109f5d0ba7df15c","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2019-06-06T21:23:38Z","pushed_at":"2019-06-06T22:48:15Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":225837,"stargazers_count":2116,"watchers_count":2116,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1295,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1212,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1295,"open_issues":1212,"watchers":2116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/16648"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/16648"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/16648/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/16648/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/ba1d89e3a64cc9e2aada34d3566a4f645c4066a3"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"mbolivar"}}