payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/283655977","pull_request_review_id":237063266,"id":283655977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzY1NTk3Nw==","diff_hunk":"@@ -283,11 +282,6 @@ export function format_dialog(client, path, start, size) {\n                                 { validate: (name, vals) => utils.validate_fsys_label(name, vals.type),\n                                   visible: is_filesystem\n                                 }),\n-                      TextInput(\"custom\", _(\"Filesystem type\"),\n-                                { visible: function (vals) {\n-                                    return vals.type == \"custom\";\n-                                }\n-                                }),","path":"pkg/storaged/format-dialog.jsx","position":90,"original_position":16,"commit_id":"3c6624ac26bcdcd708fe9f11a29dd3c2262aa0c3","original_commit_id":"91204e2019943d56838a7024954c0e2f7503b81a","user":{"login":"mvollmer","id":3228183,"node_id":"MDQ6VXNlcjMyMjgxODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3228183?v=4","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"body":"Yes, exactly.","created_at":"2019-05-14T07:18:15Z","updated_at":"2019-05-14T07:18:15Z","html_url":"https://github.com/cockpit-project/cockpit/pull/11712#discussion_r283655977","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/283655977"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/11712#discussion_r283655977"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712"}},"in_reply_to_id":283390522},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712","id":274683487,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NjgzNDg3","html_url":"https://github.com/cockpit-project/cockpit/pull/11712","diff_url":"https://github.com/cockpit-project/cockpit/pull/11712.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/11712.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/11712","number":11712,"state":"open","locked":false,"title":"storage: Factor encryption out of filesystem type when formatting","user":{"login":"mvollmer","id":3228183,"node_id":"MDQ6VXNlcjMyMjgxODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3228183?v=4","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"body":"This way, people can easily make encrypted block devices without\r\nfilesystems in them.\r\n\r\nThis also opens the avenue to adding more encryption technologies,\r\nlike \"LUKSv2\".\r\n\r\nFixes #11482\r\n\r\nRelease notes:\r\n-------------\r\n### Storage: When formatting, encryption can be selected independently\r\n\r\nPreviously, Cockpit has offered encryption for only two types of filesystems, xfs and ext4.  Now you can select the filesystem type and the encrpytion technology separately.\r\n![image](https://user-images.githubusercontent.com/3228183/57607540-f6929080-7573-11e9-8704-1c8c48d888d6.png)\r\n","created_at":"2019-04-30T10:54:12Z","updated_at":"2019-05-14T07:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"833a06690d77dac2bd8f77476d6cb1282ad3623c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andreasn","id":209895,"node_id":"MDQ6VXNlcjIwOTg5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/209895?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasn","html_url":"https://github.com/andreasn","followers_url":"https://api.github.com/users/andreasn/followers","following_url":"https://api.github.com/users/andreasn/following{/other_user}","gists_url":"https://api.github.com/users/andreasn/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasn/subscriptions","organizations_url":"https://api.github.com/users/andreasn/orgs","repos_url":"https://api.github.com/users/andreasn/repos","events_url":"https://api.github.com/users/andreasn/events{/privacy}","received_events_url":"https://api.github.com/users/andreasn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1323286821,"node_id":"MDU6TGFiZWwxMzIzMjg2ODIx","url":"https://api.github.com/repos/cockpit-project/cockpit/labels/release-note","name":"release-note","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/11712/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/3c6624ac26bcdcd708fe9f11a29dd3c2262aa0c3","head":{"label":"mvollmer:storage-luks-as-option","ref":"storage-luks-as-option","sha":"3c6624ac26bcdcd708fe9f11a29dd3c2262aa0c3","user":{"login":"mvollmer","id":3228183,"node_id":"MDQ6VXNlcjMyMjgxODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3228183?v=4","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"repo":{"id":20679941,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY3OTk0MQ==","name":"cockpit","full_name":"mvollmer/cockpit","private":false,"owner":{"login":"mvollmer","id":3228183,"node_id":"MDQ6VXNlcjMyMjgxODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3228183?v=4","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mvollmer/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":true,"url":"https://api.github.com/repos/mvollmer/cockpit","forks_url":"https://api.github.com/repos/mvollmer/cockpit/forks","keys_url":"https://api.github.com/repos/mvollmer/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvollmer/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvollmer/cockpit/teams","hooks_url":"https://api.github.com/repos/mvollmer/cockpit/hooks","issue_events_url":"https://api.github.com/repos/mvollmer/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/mvollmer/cockpit/events","assignees_url":"https://api.github.com/repos/mvollmer/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/mvollmer/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/mvollmer/cockpit/tags","blobs_url":"https://api.github.com/repos/mvollmer/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvollmer/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvollmer/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvollmer/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvollmer/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/mvollmer/cockpit/languages","stargazers_url":"https://api.github.com/repos/mvollmer/cockpit/stargazers","contributors_url":"https://api.github.com/repos/mvollmer/cockpit/contributors","subscribers_url":"https://api.github.com/repos/mvollmer/cockpit/subscribers","subscription_url":"https://api.github.com/repos/mvollmer/cockpit/subscription","commits_url":"https://api.github.com/repos/mvollmer/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvollmer/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvollmer/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvollmer/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvollmer/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/mvollmer/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvollmer/cockpit/merges","archive_url":"https://api.github.com/repos/mvollmer/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvollmer/cockpit/downloads","issues_url":"https://api.github.com/repos/mvollmer/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/mvollmer/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/mvollmer/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/mvollmer/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvollmer/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/mvollmer/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/mvollmer/cockpit/deployments","created_at":"2014-06-10T09:35:54Z","updated_at":"2019-02-06T11:42:37Z","pushed_at":"2019-05-13T13:28:50Z","git_url":"git://github.com/mvollmer/cockpit.git","ssh_url":"git@github.com:mvollmer/cockpit.git","clone_url":"https://github.com/mvollmer/cockpit.git","svn_url":"https://github.com/mvollmer/cockpit","homepage":"http://www.cockpit-project.org/","size":69218,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":24,"watchers":2,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"66a0fec879045c7241823366a2abe7b2d75157cf","user":{"login":"cockpit-project","id":5765104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0OTIxNg==","name":"cockpit","full_name":"cockpit-project/cockpit","private":false,"owner":{"login":"cockpit-project","id":5765104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2019-05-14T06:52:08Z","pushed_at":"2019-05-14T07:05:59Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":67867,"stargazers_count":4012,"watchers_count":4012,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":540,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":443,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":540,"open_issues":443,"watchers":4012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/11712"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/11712"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/11712/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/11712/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/3c6624ac26bcdcd708fe9f11a29dd3c2262aa0c3"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"mvollmer"}}