payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments/363765510","pull_request_review_id":339259002,"id":363765510,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mzc2NTUxMA==","diff_hunk":"@@ -23,7 +24,12 @@ const synchronizedWrite = synchronized()\n export default class Proxy {\n   constructor(app, conf) {\n     this._app = app\n-    this._xoProxyConf = conf['xo-proxy']\n+    const xoProxyConf = (this._xoProxyConf = conf['xo-proxy'])\n+    const pattern = {\n+      '{date}': new Date().toISOString(),","path":"packages/xo-server/src/xo-mixins/proxies.js","position":15,"original_position":15,"commit_id":"094741ea5f97f01527dbc9eddca2c2f522a333cc","original_commit_id":"094741ea5f97f01527dbc9eddca2c2f522a333cc","user":{"login":"julien-f","id":298721,"node_id":"MDQ6VXNlcjI5ODcyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/298721?v=4","gravatar_id":"","url":"https://api.github.com/users/julien-f","html_url":"https://github.com/julien-f","followers_url":"https://api.github.com/users/julien-f/followers","following_url":"https://api.github.com/users/julien-f/following{/other_user}","gists_url":"https://api.github.com/users/julien-f/gists{/gist_id}","starred_url":"https://api.github.com/users/julien-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien-f/subscriptions","organizations_url":"https://api.github.com/users/julien-f/orgs","repos_url":"https://api.github.com/users/julien-f/repos","events_url":"https://api.github.com/users/julien-f/events{/privacy}","received_events_url":"https://api.github.com/users/julien-f/received_events","type":"User","site_admin":false},"body":"The date is now incorrect.","created_at":"2020-01-07T14:13:11Z","updated_at":"2020-01-07T14:13:11Z","html_url":"https://github.com/vatesfr/xen-orchestra/pull/4724#discussion_r363765510","pull_request_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments/363765510"},"html":{"href":"https://github.com/vatesfr/xen-orchestra/pull/4724#discussion_r363765510"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724","id":360002389,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwMDAyMzg5","html_url":"https://github.com/vatesfr/xen-orchestra/pull/4724","diff_url":"https://github.com/vatesfr/xen-orchestra/pull/4724.diff","patch_url":"https://github.com/vatesfr/xen-orchestra/pull/4724.patch","issue_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/4724","number":4724,"state":"open","locked":false,"title":"feat(xo-server/proxy): make static values configurable ","user":{"login":"badrAZ","id":21563339,"node_id":"MDQ6VXNlcjIxNTYzMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/21563339?v=4","gravatar_id":"","url":"https://api.github.com/users/badrAZ","html_url":"https://github.com/badrAZ","followers_url":"https://api.github.com/users/badrAZ/followers","following_url":"https://api.github.com/users/badrAZ/following{/other_user}","gists_url":"https://api.github.com/users/badrAZ/gists{/gist_id}","starred_url":"https://api.github.com/users/badrAZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badrAZ/subscriptions","organizations_url":"https://api.github.com/users/badrAZ/orgs","repos_url":"https://api.github.com/users/badrAZ/repos","events_url":"https://api.github.com/users/badrAZ/events{/privacy}","received_events_url":"https://api.github.com/users/badrAZ/received_events","type":"User","site_admin":false},"body":"See xoa#49\r\n\r\n## Check list\r\n\r\n> Check if done, if not relevant leave unchecked.\r\n\r\n- [x] PR reference the relevant issue (e.g. `Fixes #007` or `See xoa-support#42`)\r\n- [ ] if UI changes, a screenshot has been added to the PR\r\n- [ ] documentation updated\r\n- `CHANGELOG.unreleased.md`:\r\n  - [ ] enhancement/bug fix entry added\r\n  - [ ] list of packages to release updated (`${name} v${new version}`)\r\n- **I have tested added/updated features** (and impacted code)\r\n  - [ ] unit tests (e.g. [`cron/parse.spec.js`](https://github.com/vatesfr/xen-orchestra/blob/b24400b21de1ebafa1099c56bac1de5c988d9202/%40xen-orchestra/cron/src/parse.spec.js))\r\n  - [ ] if `xo-server` API changes, the corresponding test has been added to/updated on [`xo-server-test`](https://github.com/vatesfr/xen-orchestra/tree/master/packages/xo-server-test)\r\n  - [x] at least manual testing\r\n\r\n### Process\r\n\r\n1. create a PR as soon as possible\r\n1. mark it as `WiP:` (Work in Progress) if not ready to be merged\r\n1. when you want a review, add a reviewer (and only one)\r\n1. if necessary, update your PR, and re- add a reviewer\r\n\r\nFrom [_the Four Agreements_](https://en.wikipedia.org/wiki/Don_Miguel_Ruiz#The_Four_Agreements):\r\n\r\n1. Be impeccable with your word.\r\n1. Don't take anything personally.\r\n1. Don't make assumptions.\r\n1. Always do your best.\r\n","created_at":"2020-01-07T13:59:04Z","updated_at":"2020-01-07T14:13:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf4185903c3356edb6b63a987b2a53c4ef2b5672","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/4724/comments","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/094741ea5f97f01527dbc9eddca2c2f522a333cc","head":{"label":"vatesfr:moveStaticValToConfig","ref":"moveStaticValToConfig","sha":"094741ea5f97f01527dbc9eddca2c2f522a333cc","user":{"login":"vatesfr","id":2064170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc3OTU3","name":"xen-orchestra","full_name":"vatesfr/xen-orchestra","private":false,"owner":{"login":"vatesfr","id":2064170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vatesfr/xen-orchestra","description":"The complete web solution for XenServer/XCP-ng","fork":false,"url":"https://api.github.com/repos/vatesfr/xen-orchestra","forks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/forks","keys_url":"https://api.github.com/repos/vatesfr/xen-orchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xen-orchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xen-orchestra/teams","hooks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/events","assignees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xen-orchestra/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/tags","blobs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xen-orchestra/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscription","commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xen-orchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xen-orchestra/merges","archive_url":"https://api.github.com/repos/vatesfr/xen-orchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xen-orchestra/downloads","issues_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xen-orchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xen-orchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xen-orchestra/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xen-orchestra/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2020-01-07T10:14:40Z","pushed_at":"2020-01-07T14:12:01Z","git_url":"git://github.com/vatesfr/xen-orchestra.git","ssh_url":"git@github.com:vatesfr/xen-orchestra.git","clone_url":"https://github.com/vatesfr/xen-orchestra.git","svn_url":"https://github.com/vatesfr/xen-orchestra","homepage":"","size":38450,"stargazers_count":255,"watchers_count":255,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":495,"license":null,"forks":96,"open_issues":495,"watchers":255,"default_branch":"master"}},"base":{"label":"vatesfr:proxy-v1","ref":"proxy-v1","sha":"d0e38e2dbcba9c5f8391162d32f88b44c08461cd","user":{"login":"vatesfr","id":2064170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc3OTU3","name":"xen-orchestra","full_name":"vatesfr/xen-orchestra","private":false,"owner":{"login":"vatesfr","id":2064170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vatesfr/xen-orchestra","description":"The complete web solution for XenServer/XCP-ng","fork":false,"url":"https://api.github.com/repos/vatesfr/xen-orchestra","forks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/forks","keys_url":"https://api.github.com/repos/vatesfr/xen-orchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xen-orchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xen-orchestra/teams","hooks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/events","assignees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xen-orchestra/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/tags","blobs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xen-orchestra/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscription","commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xen-orchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xen-orchestra/merges","archive_url":"https://api.github.com/repos/vatesfr/xen-orchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xen-orchestra/downloads","issues_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xen-orchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xen-orchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xen-orchestra/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xen-orchestra/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2020-01-07T10:14:40Z","pushed_at":"2020-01-07T14:12:01Z","git_url":"git://github.com/vatesfr/xen-orchestra.git","ssh_url":"git@github.com:vatesfr/xen-orchestra.git","clone_url":"https://github.com/vatesfr/xen-orchestra.git","svn_url":"https://github.com/vatesfr/xen-orchestra","homepage":"","size":38450,"stargazers_count":255,"watchers_count":255,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":495,"license":null,"forks":96,"open_issues":495,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724"},"html":{"href":"https://github.com/vatesfr/xen-orchestra/pull/4724"},"issue":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/4724"},"comments":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/4724/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/4724/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/094741ea5f97f01527dbc9eddca2c2f522a333cc"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"julien-f"}}