payload: {"action":"opened","number":86,"pull_request":{"url":"https://api.github.com/repos/andy-5/wslgit/pulls/86","id":325931590,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1OTMxNTkw","html_url":"https://github.com/andy-5/wslgit/pull/86","diff_url":"https://github.com/andy-5/wslgit/pull/86.diff","patch_url":"https://github.com/andy-5/wslgit/pull/86.patch","issue_url":"https://api.github.com/repos/andy-5/wslgit/issues/86","number":86,"state":"open","locked":false,"title":"Using wslpath for translating absolute paths Win<->WSL","user":{"login":"carlolars","id":13761538,"node_id":"MDQ6VXNlcjEzNzYxNTM4","avatar_url":"https://avatars3.githubusercontent.com/u/13761538?v=4","gravatar_id":"","url":"https://api.github.com/users/carlolars","html_url":"https://github.com/carlolars","followers_url":"https://api.github.com/users/carlolars/followers","following_url":"https://api.github.com/users/carlolars/following{/other_user}","gists_url":"https://api.github.com/users/carlolars/gists{/gist_id}","starred_url":"https://api.github.com/users/carlolars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlolars/subscriptions","organizations_url":"https://api.github.com/users/carlolars/orgs","repos_url":"https://api.github.com/users/carlolars/repos","events_url":"https://api.github.com/users/carlolars/events{/privacy}","received_events_url":"https://api.github.com/users/carlolars/received_events","type":"User","site_admin":false},"body":"I've implemented using `wslpath` to translate win-paths to wsl-paths and vice versa.\r\n\r\nThe translation from windows to wsl path is as fast as the previous implementation, but the wsl to windows path translation gets a ~60ms penalty because of one extra process invoke of the output from the git command.\r\n\r\n- Using `wslpath` to translate absolute paths. #12\r\n  - Supports paths like `\\\\server\\share` **if** the same path is mounted in WSL (see [Mounting network locations](https://blogs.msdn.microsoft.com/wsl/2017/04/18/file-system-improvements-to-the-windows-subsystem-for-linux/)).\r\n  - Supports `\\\\wsl$`. #71\r\n  - Supports any mount paths (`/c`, `/mnt/c`, `/my/mount/path/c`, etc), so no need for `WSLGIT_MOUNT_ROOT` anymore.\r\n  - Supports manually mounted paths (not in fstab or automounted).\r\n- Works with `log -L 1,1:C:\\path\\to\\file` and `log -L :funcname:C:\\path\\to\\file`\r\n- Implemented benchmarks.  \r\n- Added a simple file log that can be enabled to log input arguments and the resulting git command, as well as the output translation.\r\n- Changed from assert_cli to assert_cmd crate for testing CLI. \r\n\r\n\r\n**Benchmark results:**\r\n```\r\nBefore wslpath:\r\ntest bench::no_translation              ... bench:  60,846,590 ns/iter (+/- 11,856,476)\r\ntest bench::translate_absolute_argument ... bench:  71,600,430 ns/iter (+/- 2,973,202)\r\ntest bench::translate_output            ... bench:  56,521,180 ns/iter (+/- 3,329,437)\r\ntest bench::translate_relative_argument ... bench:  62,603,140 ns/iter (+/- 3,727,496)\r\n\r\nUsing wslpath:\r\ntest bench::no_translation              ... bench:  60,685,500 ns/iter (+/- 13,579,360)\r\ntest bench::translate_absolute_argument ... bench:  69,877,700 ns/iter (+/- 12,559,499)\r\ntest bench::translate_output            ... bench: 110,932,150 ns/iter (+/- 4,230,732)\r\ntest bench::translate_relative_argument ... bench:  61,110,610 ns/iter (+/- 1,364,392)\r\n```\r\n","created_at":"2019-10-08T19:43:53Z","updated_at":"2019-10-08T19:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andy-5/wslgit/pulls/86/commits","review_comments_url":"https://api.github.com/repos/andy-5/wslgit/pulls/86/comments","review_comment_url":"https://api.github.com/repos/andy-5/wslgit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andy-5/wslgit/issues/86/comments","statuses_url":"https://api.github.com/repos/andy-5/wslgit/statuses/94e193fcbf744f01da4256d8b80a9c42eb41e206","head":{"label":"carlolars:wslpath","ref":"wslpath","sha":"94e193fcbf744f01da4256d8b80a9c42eb41e206","user":{"login":"carlolars","id":13761538,"node_id":"MDQ6VXNlcjEzNzYxNTM4","avatar_url":"https://avatars3.githubusercontent.com/u/13761538?v=4","gravatar_id":"","url":"https://api.github.com/users/carlolars","html_url":"https://github.com/carlolars","followers_url":"https://api.github.com/users/carlolars/followers","following_url":"https://api.github.com/users/carlolars/following{/other_user}","gists_url":"https://api.github.com/users/carlolars/gists{/gist_id}","starred_url":"https://api.github.com/users/carlolars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlolars/subscriptions","organizations_url":"https://api.github.com/users/carlolars/orgs","repos_url":"https://api.github.com/users/carlolars/repos","events_url":"https://api.github.com/users/carlolars/events{/privacy}","received_events_url":"https://api.github.com/users/carlolars/received_events","type":"User","site_admin":false},"repo":{"id":190446499,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA0NDY0OTk=","name":"wslgit","full_name":"carlolars/wslgit","private":false,"owner":{"login":"carlolars","id":13761538,"node_id":"MDQ6VXNlcjEzNzYxNTM4","avatar_url":"https://avatars3.githubusercontent.com/u/13761538?v=4","gravatar_id":"","url":"https://api.github.com/users/carlolars","html_url":"https://github.com/carlolars","followers_url":"https://api.github.com/users/carlolars/followers","following_url":"https://api.github.com/users/carlolars/following{/other_user}","gists_url":"https://api.github.com/users/carlolars/gists{/gist_id}","starred_url":"https://api.github.com/users/carlolars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlolars/subscriptions","organizations_url":"https://api.github.com/users/carlolars/orgs","repos_url":"https://api.github.com/users/carlolars/repos","events_url":"https://api.github.com/users/carlolars/events{/privacy}","received_events_url":"https://api.github.com/users/carlolars/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carlolars/wslgit","description":"Use Git installed in Bash on Windows/Windows Subsystem for Linux (WSL) from Windows and Visual Studio Code (VSCode), patched for Fork (www.fork.dev)","fork":true,"url":"https://api.github.com/repos/carlolars/wslgit","forks_url":"https://api.github.com/repos/carlolars/wslgit/forks","keys_url":"https://api.github.com/repos/carlolars/wslgit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlolars/wslgit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlolars/wslgit/teams","hooks_url":"https://api.github.com/repos/carlolars/wslgit/hooks","issue_events_url":"https://api.github.com/repos/carlolars/wslgit/issues/events{/number}","events_url":"https://api.github.com/repos/carlolars/wslgit/events","assignees_url":"https://api.github.com/repos/carlolars/wslgit/assignees{/user}","branches_url":"https://api.github.com/repos/carlolars/wslgit/branches{/branch}","tags_url":"https://api.github.com/repos/carlolars/wslgit/tags","blobs_url":"https://api.github.com/repos/carlolars/wslgit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlolars/wslgit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlolars/wslgit/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlolars/wslgit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlolars/wslgit/statuses/{sha}","languages_url":"https://api.github.com/repos/carlolars/wslgit/languages","stargazers_url":"https://api.github.com/repos/carlolars/wslgit/stargazers","contributors_url":"https://api.github.com/repos/carlolars/wslgit/contributors","subscribers_url":"https://api.github.com/repos/carlolars/wslgit/subscribers","subscription_url":"https://api.github.com/repos/carlolars/wslgit/subscription","commits_url":"https://api.github.com/repos/carlolars/wslgit/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlolars/wslgit/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlolars/wslgit/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlolars/wslgit/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlolars/wslgit/contents/{+path}","compare_url":"https://api.github.com/repos/carlolars/wslgit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlolars/wslgit/merges","archive_url":"https://api.github.com/repos/carlolars/wslgit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlolars/wslgit/downloads","issues_url":"https://api.github.com/repos/carlolars/wslgit/issues{/number}","pulls_url":"https://api.github.com/repos/carlolars/wslgit/pulls{/number}","milestones_url":"https://api.github.com/repos/carlolars/wslgit/milestones{/number}","notifications_url":"https://api.github.com/repos/carlolars/wslgit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlolars/wslgit/labels{/name}","releases_url":"https://api.github.com/repos/carlolars/wslgit/releases{/id}","deployments_url":"https://api.github.com/repos/carlolars/wslgit/deployments","created_at":"2019-06-05T18:19:55Z","updated_at":"2019-09-25T09:12:01Z","pushed_at":"2019-10-08T19:39:35Z","git_url":"git://github.com/carlolars/wslgit.git","ssh_url":"git@github.com:carlolars/wslgit.git","clone_url":"https://github.com/carlolars/wslgit.git","svn_url":"https://github.com/carlolars/wslgit","homepage":"","size":85,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"fork-patch"}},"base":{"label":"andy-5:master","ref":"master","sha":"0fb28f67e5d667d38c87697764e4a33732278338","user":{"login":"andy-5","id":2477826,"node_id":"MDQ6VXNlcjI0Nzc4MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2477826?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-5","html_url":"https://github.com/andy-5","followers_url":"https://api.github.com/users/andy-5/followers","following_url":"https://api.github.com/users/andy-5/following{/other_user}","gists_url":"https://api.github.com/users/andy-5/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-5/subscriptions","organizations_url":"https://api.github.com/users/andy-5/orgs","repos_url":"https://api.github.com/users/andy-5/repos","events_url":"https://api.github.com/users/andy-5/events{/privacy}","received_events_url":"https://api.github.com/users/andy-5/received_events","type":"User","site_admin":false},"repo":{"id":98505208,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUwNTIwOA==","name":"wslgit","full_name":"andy-5/wslgit","private":false,"owner":{"login":"andy-5","id":2477826,"node_id":"MDQ6VXNlcjI0Nzc4MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2477826?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-5","html_url":"https://github.com/andy-5","followers_url":"https://api.github.com/users/andy-5/followers","following_url":"https://api.github.com/users/andy-5/following{/other_user}","gists_url":"https://api.github.com/users/andy-5/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-5/subscriptions","organizations_url":"https://api.github.com/users/andy-5/orgs","repos_url":"https://api.github.com/users/andy-5/repos","events_url":"https://api.github.com/users/andy-5/events{/privacy}","received_events_url":"https://api.github.com/users/andy-5/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andy-5/wslgit","description":"Use Git installed in Bash on Windows/Windows Subsystem for Linux (WSL) from Windows and Visual Studio Code (VSCode)","fork":false,"url":"https://api.github.com/repos/andy-5/wslgit","forks_url":"https://api.github.com/repos/andy-5/wslgit/forks","keys_url":"https://api.github.com/repos/andy-5/wslgit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy-5/wslgit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy-5/wslgit/teams","hooks_url":"https://api.github.com/repos/andy-5/wslgit/hooks","issue_events_url":"https://api.github.com/repos/andy-5/wslgit/issues/events{/number}","events_url":"https://api.github.com/repos/andy-5/wslgit/events","assignees_url":"https://api.github.com/repos/andy-5/wslgit/assignees{/user}","branches_url":"https://api.github.com/repos/andy-5/wslgit/branches{/branch}","tags_url":"https://api.github.com/repos/andy-5/wslgit/tags","blobs_url":"https://api.github.com/repos/andy-5/wslgit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy-5/wslgit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy-5/wslgit/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy-5/wslgit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy-5/wslgit/statuses/{sha}","languages_url":"https://api.github.com/repos/andy-5/wslgit/languages","stargazers_url":"https://api.github.com/repos/andy-5/wslgit/stargazers","contributors_url":"https://api.github.com/repos/andy-5/wslgit/contributors","subscribers_url":"https://api.github.com/repos/andy-5/wslgit/subscribers","subscription_url":"https://api.github.com/repos/andy-5/wslgit/subscription","commits_url":"https://api.github.com/repos/andy-5/wslgit/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy-5/wslgit/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy-5/wslgit/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy-5/wslgit/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy-5/wslgit/contents/{+path}","compare_url":"https://api.github.com/repos/andy-5/wslgit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy-5/wslgit/merges","archive_url":"https://api.github.com/repos/andy-5/wslgit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy-5/wslgit/downloads","issues_url":"https://api.github.com/repos/andy-5/wslgit/issues{/number}","pulls_url":"https://api.github.com/repos/andy-5/wslgit/pulls{/number}","milestones_url":"https://api.github.com/repos/andy-5/wslgit/milestones{/number}","notifications_url":"https://api.github.com/repos/andy-5/wslgit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy-5/wslgit/labels{/name}","releases_url":"https://api.github.com/repos/andy-5/wslgit/releases{/id}","deployments_url":"https://api.github.com/repos/andy-5/wslgit/deployments","created_at":"2017-07-27T07:10:30Z","updated_at":"2019-10-06T11:05:45Z","pushed_at":"2019-09-18T10:13:56Z","git_url":"git://github.com/andy-5/wslgit.git","ssh_url":"git@github.com:andy-5/wslgit.git","clone_url":"https://github.com/andy-5/wslgit.git","svn_url":"https://github.com/andy-5/wslgit","homepage":"","size":78,"stargazers_count":634,"watchers_count":634,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":11,"watchers":634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andy-5/wslgit/pulls/86"},"html":{"href":"https://github.com/andy-5/wslgit/pull/86"},"issue":{"href":"https://api.github.com/repos/andy-5/wslgit/issues/86"},"comments":{"href":"https://api.github.com/repos/andy-5/wslgit/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/andy-5/wslgit/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/andy-5/wslgit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andy-5/wslgit/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/andy-5/wslgit/statuses/94e193fcbf744f01da4256d8b80a9c42eb41e206"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":8,"additions":473,"deletions":279,"changed_files":5}}
other: {"actor":{"display_login":"carlolars"}}