payload: {"action":"created","comment":{"url":"https://api.github.com/repos/badoo/RIBs/pulls/comments/261007019","pull_request_review_id":208842438,"id":261007019,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTAwNzAxOQ==","diff_hunk":"@@ -0,0 +1,318 @@\n+/*\n+ * Copyright (C) 2017. Uber Technologies\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.badoo.ribs.core\n+\n+import android.os.Bundle\n+import android.os.Parcelable\n+import android.support.annotation.CallSuper\n+import android.support.annotation.MainThread\n+import android.support.annotation.VisibleForTesting\n+import android.util.SparseArray\n+import android.view.ViewGroup\n+import com.badoo.ribs.core.view.RibView\n+import com.badoo.ribs.core.view.ViewFactory\n+import com.badoo.ribs.core.requestcode.RequestCodeRegistry\n+import com.uber.rib.util.RibRefWatcher\n+import java.util.UUID\n+import java.util.concurrent.CopyOnWriteArrayList\n+\n+/**\n+ * Responsible for handling the addition and removal of child nodes.\n+ **/\n+open class Node<V : RibView>(\n+    val forClass: Class<*>,","path":"android/libraries/rib-base/src/main/java/com/badoo/ribs/core/Node.kt","position":35,"original_position":36,"commit_id":"41c340bfdca1ff93d19c04e5cd5ea16917349a97","original_commit_id":"b5d44aed40e744987ec347498391eed6b7bf5fb3","user":{"login":"zsoltk","id":238198,"node_id":"MDQ6VXNlcjIzODE5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/238198?v=4","gravatar_id":"","url":"https://api.github.com/users/zsoltk","html_url":"https://github.com/zsoltk","followers_url":"https://api.github.com/users/zsoltk/followers","following_url":"https://api.github.com/users/zsoltk/following{/other_user}","gists_url":"https://api.github.com/users/zsoltk/gists{/gist_id}","starred_url":"https://api.github.com/users/zsoltk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsoltk/subscriptions","organizations_url":"https://api.github.com/users/zsoltk/orgs","repos_url":"https://api.github.com/users/zsoltk/repos","events_url":"https://api.github.com/users/zsoltk/events{/privacy}","received_events_url":"https://api.github.com/users/zsoltk/received_events","type":"User","site_admin":false},"body":"@Nublo @ShikaSD Class here is only for 1. mainly deciding which type of rib should go into which view container when routing (since it's only the type, an automatically generated unique id doesn't make sense there) 2. debugging node structure.\r\n\r\nWe still have rib id and tag with unique values even for nodes of the same type. Do you see a case where we still need it in the above 2 scenarios?","created_at":"2019-02-28T00:44:13Z","updated_at":"2019-02-28T00:44:14Z","html_url":"https://github.com/badoo/RIBs/pull/1#discussion_r261007019","pull_request_url":"https://api.github.com/repos/badoo/RIBs/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/badoo/RIBs/pulls/comments/261007019"},"html":{"href":"https://github.com/badoo/RIBs/pull/1#discussion_r261007019"},"pull_request":{"href":"https://api.github.com/repos/badoo/RIBs/pulls/1"}},"in_reply_to_id":260984315},"pull_request":{"url":"https://api.github.com/repos/badoo/RIBs/pulls/1","id":254214989,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MjE0OTg5","html_url":"https://github.com/badoo/RIBs/pull/1","diff_url":"https://github.com/badoo/RIBs/pull/1.diff","patch_url":"https://github.com/badoo/RIBs/pull/1.patch","issue_url":"https://api.github.com/repos/badoo/RIBs/issues/1","number":1,"state":"open","locked":false,"title":"[WIP] Badoo ribs mvp","user":{"login":"zsoltk","id":238198,"node_id":"MDQ6VXNlcjIzODE5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/238198?v=4","gravatar_id":"","url":"https://api.github.com/users/zsoltk","html_url":"https://github.com/zsoltk","followers_url":"https://api.github.com/users/zsoltk/followers","following_url":"https://api.github.com/users/zsoltk/following{/other_user}","gists_url":"https://api.github.com/users/zsoltk/gists{/gist_id}","starred_url":"https://api.github.com/users/zsoltk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsoltk/subscriptions","organizations_url":"https://api.github.com/users/zsoltk/orgs","repos_url":"https://api.github.com/users/zsoltk/repos","events_url":"https://api.github.com/users/zsoltk/events{/privacy}","received_events_url":"https://api.github.com/users/zsoltk/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-19T11:24:10Z","updated_at":"2019-02-28T00:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da0cd4895dafb893d93440ddd9958217bc8f997","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/badoo/RIBs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/badoo/RIBs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/badoo/RIBs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/badoo/RIBs/issues/1/comments","statuses_url":"https://api.github.com/repos/badoo/RIBs/statuses/41c340bfdca1ff93d19c04e5cd5ea16917349a97","head":{"label":"zsoltk:badoo-ribs-mvp","ref":"badoo-ribs-mvp","sha":"41c340bfdca1ff93d19c04e5cd5ea16917349a97","user":{"login":"zsoltk","id":238198,"node_id":"MDQ6VXNlcjIzODE5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/238198?v=4","gravatar_id":"","url":"https://api.github.com/users/zsoltk","html_url":"https://github.com/zsoltk","followers_url":"https://api.github.com/users/zsoltk/followers","following_url":"https://api.github.com/users/zsoltk/following{/other_user}","gists_url":"https://api.github.com/users/zsoltk/gists{/gist_id}","starred_url":"https://api.github.com/users/zsoltk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsoltk/subscriptions","organizations_url":"https://api.github.com/users/zsoltk/orgs","repos_url":"https://api.github.com/users/zsoltk/repos","events_url":"https://api.github.com/users/zsoltk/events{/privacy}","received_events_url":"https://api.github.com/users/zsoltk/received_events","type":"User","site_admin":false},"repo":{"id":170874709,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA4NzQ3MDk=","name":"RIBs","full_name":"zsoltk/RIBs","private":false,"owner":{"login":"zsoltk","id":238198,"node_id":"MDQ6VXNlcjIzODE5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/238198?v=4","gravatar_id":"","url":"https://api.github.com/users/zsoltk","html_url":"https://github.com/zsoltk","followers_url":"https://api.github.com/users/zsoltk/followers","following_url":"https://api.github.com/users/zsoltk/following{/other_user}","gists_url":"https://api.github.com/users/zsoltk/gists{/gist_id}","starred_url":"https://api.github.com/users/zsoltk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsoltk/subscriptions","organizations_url":"https://api.github.com/users/zsoltk/orgs","repos_url":"https://api.github.com/users/zsoltk/repos","events_url":"https://api.github.com/users/zsoltk/events{/privacy}","received_events_url":"https://api.github.com/users/zsoltk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zsoltk/RIBs","description":"Uber's cross-platform mobile architecture framework.","fork":true,"url":"https://api.github.com/repos/zsoltk/RIBs","forks_url":"https://api.github.com/repos/zsoltk/RIBs/forks","keys_url":"https://api.github.com/repos/zsoltk/RIBs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zsoltk/RIBs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zsoltk/RIBs/teams","hooks_url":"https://api.github.com/repos/zsoltk/RIBs/hooks","issue_events_url":"https://api.github.com/repos/zsoltk/RIBs/issues/events{/number}","events_url":"https://api.github.com/repos/zsoltk/RIBs/events","assignees_url":"https://api.github.com/repos/zsoltk/RIBs/assignees{/user}","branches_url":"https://api.github.com/repos/zsoltk/RIBs/branches{/branch}","tags_url":"https://api.github.com/repos/zsoltk/RIBs/tags","blobs_url":"https://api.github.com/repos/zsoltk/RIBs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zsoltk/RIBs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zsoltk/RIBs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zsoltk/RIBs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zsoltk/RIBs/statuses/{sha}","languages_url":"https://api.github.com/repos/zsoltk/RIBs/languages","stargazers_url":"https://api.github.com/repos/zsoltk/RIBs/stargazers","contributors_url":"https://api.github.com/repos/zsoltk/RIBs/contributors","subscribers_url":"https://api.github.com/repos/zsoltk/RIBs/subscribers","subscription_url":"https://api.github.com/repos/zsoltk/RIBs/subscription","commits_url":"https://api.github.com/repos/zsoltk/RIBs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zsoltk/RIBs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zsoltk/RIBs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zsoltk/RIBs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zsoltk/RIBs/contents/{+path}","compare_url":"https://api.github.com/repos/zsoltk/RIBs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zsoltk/RIBs/merges","archive_url":"https://api.github.com/repos/zsoltk/RIBs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zsoltk/RIBs/downloads","issues_url":"https://api.github.com/repos/zsoltk/RIBs/issues{/number}","pulls_url":"https://api.github.com/repos/zsoltk/RIBs/pulls{/number}","milestones_url":"https://api.github.com/repos/zsoltk/RIBs/milestones{/number}","notifications_url":"https://api.github.com/repos/zsoltk/RIBs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zsoltk/RIBs/labels{/name}","releases_url":"https://api.github.com/repos/zsoltk/RIBs/releases{/id}","deployments_url":"https://api.github.com/repos/zsoltk/RIBs/deployments","created_at":"2019-02-15T14:08:10Z","updated_at":"2019-02-15T14:08:13Z","pushed_at":"2019-02-27T23:02:25Z","git_url":"git://github.com/zsoltk/RIBs.git","ssh_url":"git@github.com:zsoltk/RIBs.git","clone_url":"https://github.com/zsoltk/RIBs.git","svn_url":"https://github.com/zsoltk/RIBs","homepage":"https://eng.uber.com/tag/ribs/","size":4762,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"badoo:master","ref":"master","sha":"d5f6dbe95fcca0e6d8d08926b06ccd015f4678b3","user":{"login":"badoo","id":1277442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1277442?v=4","gravatar_id":"","url":"https://api.github.com/users/badoo","html_url":"https://github.com/badoo","followers_url":"https://api.github.com/users/badoo/followers","following_url":"https://api.github.com/users/badoo/following{/other_user}","gists_url":"https://api.github.com/users/badoo/gists{/gist_id}","starred_url":"https://api.github.com/users/badoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoo/subscriptions","organizations_url":"https://api.github.com/users/badoo/orgs","repos_url":"https://api.github.com/users/badoo/repos","events_url":"https://api.github.com/users/badoo/events{/privacy}","received_events_url":"https://api.github.com/users/badoo/received_events","type":"Organization","site_admin":false},"repo":{"id":170855556,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA4NTU1NTY=","name":"RIBs","full_name":"badoo/RIBs","private":false,"owner":{"login":"badoo","id":1277442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1277442?v=4","gravatar_id":"","url":"https://api.github.com/users/badoo","html_url":"https://github.com/badoo","followers_url":"https://api.github.com/users/badoo/followers","following_url":"https://api.github.com/users/badoo/following{/other_user}","gists_url":"https://api.github.com/users/badoo/gists{/gist_id}","starred_url":"https://api.github.com/users/badoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoo/subscriptions","organizations_url":"https://api.github.com/users/badoo/orgs","repos_url":"https://api.github.com/users/badoo/repos","events_url":"https://api.github.com/users/badoo/events{/privacy}","received_events_url":"https://api.github.com/users/badoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/badoo/RIBs","description":"Uber's cross-platform mobile architecture framework.","fork":true,"url":"https://api.github.com/repos/badoo/RIBs","forks_url":"https://api.github.com/repos/badoo/RIBs/forks","keys_url":"https://api.github.com/repos/badoo/RIBs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badoo/RIBs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badoo/RIBs/teams","hooks_url":"https://api.github.com/repos/badoo/RIBs/hooks","issue_events_url":"https://api.github.com/repos/badoo/RIBs/issues/events{/number}","events_url":"https://api.github.com/repos/badoo/RIBs/events","assignees_url":"https://api.github.com/repos/badoo/RIBs/assignees{/user}","branches_url":"https://api.github.com/repos/badoo/RIBs/branches{/branch}","tags_url":"https://api.github.com/repos/badoo/RIBs/tags","blobs_url":"https://api.github.com/repos/badoo/RIBs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badoo/RIBs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badoo/RIBs/git/refs{/sha}","trees_url":"https://api.github.com/repos/badoo/RIBs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badoo/RIBs/statuses/{sha}","languages_url":"https://api.github.com/repos/badoo/RIBs/languages","stargazers_url":"https://api.github.com/repos/badoo/RIBs/stargazers","contributors_url":"https://api.github.com/repos/badoo/RIBs/contributors","subscribers_url":"https://api.github.com/repos/badoo/RIBs/subscribers","subscription_url":"https://api.github.com/repos/badoo/RIBs/subscription","commits_url":"https://api.github.com/repos/badoo/RIBs/commits{/sha}","git_commits_url":"https://api.github.com/repos/badoo/RIBs/git/commits{/sha}","comments_url":"https://api.github.com/repos/badoo/RIBs/comments{/number}","issue_comment_url":"https://api.github.com/repos/badoo/RIBs/issues/comments{/number}","contents_url":"https://api.github.com/repos/badoo/RIBs/contents/{+path}","compare_url":"https://api.github.com/repos/badoo/RIBs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badoo/RIBs/merges","archive_url":"https://api.github.com/repos/badoo/RIBs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badoo/RIBs/downloads","issues_url":"https://api.github.com/repos/badoo/RIBs/issues{/number}","pulls_url":"https://api.github.com/repos/badoo/RIBs/pulls{/number}","milestones_url":"https://api.github.com/repos/badoo/RIBs/milestones{/number}","notifications_url":"https://api.github.com/repos/badoo/RIBs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badoo/RIBs/labels{/name}","releases_url":"https://api.github.com/repos/badoo/RIBs/releases{/id}","deployments_url":"https://api.github.com/repos/badoo/RIBs/deployments","created_at":"2019-02-15T11:37:01Z","updated_at":"2019-02-23T11:02:15Z","pushed_at":"2019-02-27T23:02:28Z","git_url":"git://github.com/badoo/RIBs.git","ssh_url":"git@github.com:badoo/RIBs.git","clone_url":"https://github.com/badoo/RIBs.git","svn_url":"https://github.com/badoo/RIBs","homepage":"https://eng.uber.com/tag/ribs/","size":4420,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/badoo/RIBs/pulls/1"},"html":{"href":"https://github.com/badoo/RIBs/pull/1"},"issue":{"href":"https://api.github.com/repos/badoo/RIBs/issues/1"},"comments":{"href":"https://api.github.com/repos/badoo/RIBs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/badoo/RIBs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/badoo/RIBs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/badoo/RIBs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/badoo/RIBs/statuses/41c340bfdca1ff93d19c04e5cd5ea16917349a97"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"zsoltk"}}