payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/298657965","pull_request_review_id":255853755,"id":298657965,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODY1Nzk2NQ==","diff_hunk":"@@ -3642,3 +3647,50 @@ func WaitAgentConnected(virtClient kubecli.KubevirtClient, vmi *v1.VirtualMachin\n \t\treturn false\n \t}, 420*time.Second, 2).Should(BeTrue(), \"Should have agent connected condition\")\n }\n+\n+// generatePrivateKey creates a RSA Private Key of specified byte size\n+func GeneratePrivateKey(bitSize int) (*rsa.PrivateKey, error) {\n+\t// Private Key generation\n+\tprivateKey, err := rsa.GenerateKey(cryptorand.Reader, bitSize)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\t// Validate Private Key","path":"tests/utils.go","position":34,"original_position":34,"commit_id":"c1cb32296befd581e2faea78aed70b3e403a538b","original_commit_id":"c1cb32296befd581e2faea78aed70b3e403a538b","user":{"login":"sHaggYcaT","id":5021404,"node_id":"MDQ6VXNlcjUwMjE0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5021404?v=4","gravatar_id":"","url":"https://api.github.com/users/sHaggYcaT","html_url":"https://github.com/sHaggYcaT","followers_url":"https://api.github.com/users/sHaggYcaT/followers","following_url":"https://api.github.com/users/sHaggYcaT/following{/other_user}","gists_url":"https://api.github.com/users/sHaggYcaT/gists{/gist_id}","starred_url":"https://api.github.com/users/sHaggYcaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHaggYcaT/subscriptions","organizations_url":"https://api.github.com/users/sHaggYcaT/orgs","repos_url":"https://api.github.com/users/sHaggYcaT/repos","events_url":"https://api.github.com/users/sHaggYcaT/events{/privacy}","received_events_url":"https://api.github.com/users/sHaggYcaT/received_events","type":"User","site_admin":false},"body":"As far as I know, code styles recommends avoiding obvious comments, like this:\r\n\r\n// Adding a to b\r\nc = a + b","created_at":"2019-06-28T16:08:30Z","updated_at":"2019-06-28T16:25:21Z","html_url":"https://github.com/kubevirt/kubevirt/pull/2436#discussion_r298657965","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/298657965"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/2436#discussion_r298657965"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436","id":292366765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyMzY2NzY1","html_url":"https://github.com/kubevirt/kubevirt/pull/2436","diff_url":"https://github.com/kubevirt/kubevirt/pull/2436.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/2436.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/2436","number":2436,"state":"open","locked":false,"title":"Add remaining tests for, secrets and configmap as volumes","user":{"login":"kbidarkar","id":373096,"node_id":"MDQ6VXNlcjM3MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/373096?v=4","gravatar_id":"","url":"https://api.github.com/users/kbidarkar","html_url":"https://github.com/kbidarkar","followers_url":"https://api.github.com/users/kbidarkar/followers","following_url":"https://api.github.com/users/kbidarkar/following{/other_user}","gists_url":"https://api.github.com/users/kbidarkar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbidarkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbidarkar/subscriptions","organizations_url":"https://api.github.com/users/kbidarkar/orgs","repos_url":"https://api.github.com/users/kbidarkar/repos","events_url":"https://api.github.com/users/kbidarkar/events{/privacy}","received_events_url":"https://api.github.com/users/kbidarkar/received_events","type":"User","site_admin":false},"body":"1) This is port from kubevirt-ansible repo\r\n\r\n2) Add test, configmap and secret as volumes on\r\n   the same VM.\r\n\r\n3) Add test, Secret with SSH Keys - Single Volume.\r\n\r\nSigned-off-by: Kedar Bidarkar <kbidarka@redhat.com>\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:  Ports tests related to `secrets and config-maps` from kubevirt-ansible to this repo. \r\nPorts the below mentioned PR:\r\nhttps://github.com/kubevirt/kubevirt-ansible/pull/478\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```\r\nNONE\r\n```\r\n","created_at":"2019-06-27T10:22:25Z","updated_at":"2019-06-28T16:25:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccef407b46f42fde22a8b28e173fb47da1cabe2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":971140815,"node_id":"MDU6TGFiZWw5NzExNDA4MTU=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":583175137,"node_id":"MDU6TGFiZWw1ODMxNzUxMzc=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/2436/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/c1cb32296befd581e2faea78aed70b3e403a538b","head":{"label":"kbidarkar:port-secret_cfgmap","ref":"port-secret_cfgmap","sha":"c1cb32296befd581e2faea78aed70b3e403a538b","user":{"login":"kbidarkar","id":373096,"node_id":"MDQ6VXNlcjM3MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/373096?v=4","gravatar_id":"","url":"https://api.github.com/users/kbidarkar","html_url":"https://github.com/kbidarkar","followers_url":"https://api.github.com/users/kbidarkar/followers","following_url":"https://api.github.com/users/kbidarkar/following{/other_user}","gists_url":"https://api.github.com/users/kbidarkar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbidarkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbidarkar/subscriptions","organizations_url":"https://api.github.com/users/kbidarkar/orgs","repos_url":"https://api.github.com/users/kbidarkar/repos","events_url":"https://api.github.com/users/kbidarkar/events{/privacy}","received_events_url":"https://api.github.com/users/kbidarkar/received_events","type":"User","site_admin":false},"repo":{"id":156194895,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxOTQ4OTU=","name":"kubevirt","full_name":"kbidarkar/kubevirt","private":false,"owner":{"login":"kbidarkar","id":373096,"node_id":"MDQ6VXNlcjM3MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/373096?v=4","gravatar_id":"","url":"https://api.github.com/users/kbidarkar","html_url":"https://github.com/kbidarkar","followers_url":"https://api.github.com/users/kbidarkar/followers","following_url":"https://api.github.com/users/kbidarkar/following{/other_user}","gists_url":"https://api.github.com/users/kbidarkar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbidarkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbidarkar/subscriptions","organizations_url":"https://api.github.com/users/kbidarkar/orgs","repos_url":"https://api.github.com/users/kbidarkar/repos","events_url":"https://api.github.com/users/kbidarkar/events{/privacy}","received_events_url":"https://api.github.com/users/kbidarkar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kbidarkar/kubevirt","description":"Kubernetes Virtualization API and runtime in order to define and manage virtual machines.","fork":true,"url":"https://api.github.com/repos/kbidarkar/kubevirt","forks_url":"https://api.github.com/repos/kbidarkar/kubevirt/forks","keys_url":"https://api.github.com/repos/kbidarkar/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbidarkar/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbidarkar/kubevirt/teams","hooks_url":"https://api.github.com/repos/kbidarkar/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kbidarkar/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kbidarkar/kubevirt/events","assignees_url":"https://api.github.com/repos/kbidarkar/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kbidarkar/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kbidarkar/kubevirt/tags","blobs_url":"https://api.github.com/repos/kbidarkar/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbidarkar/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbidarkar/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbidarkar/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbidarkar/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kbidarkar/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kbidarkar/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kbidarkar/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kbidarkar/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kbidarkar/kubevirt/subscription","commits_url":"https://api.github.com/repos/kbidarkar/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbidarkar/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbidarkar/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbidarkar/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbidarkar/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kbidarkar/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbidarkar/kubevirt/merges","archive_url":"https://api.github.com/repos/kbidarkar/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbidarkar/kubevirt/downloads","issues_url":"https://api.github.com/repos/kbidarkar/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kbidarkar/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kbidarkar/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kbidarkar/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbidarkar/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kbidarkar/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kbidarkar/kubevirt/deployments","created_at":"2018-11-05T09:50:38Z","updated_at":"2018-11-05T09:50:42Z","pushed_at":"2019-06-28T12:12:18Z","git_url":"git://github.com/kbidarkar/kubevirt.git","ssh_url":"git@github.com:kbidarkar/kubevirt.git","clone_url":"https://github.com/kbidarkar/kubevirt.git","svn_url":"https://github.com/kbidarkar/kubevirt","homepage":"https://kubevirt.io","size":211301,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"f1a83d92df8eca521758e1825f416ab003dbd9dc","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2019-06-28T14:47:59Z","pushed_at":"2019-06-28T15:12:53Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"https://kubevirt.io","size":211656,"stargazers_count":1372,"watchers_count":1372,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":284,"open_issues":125,"watchers":1372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/2436"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/2436"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/2436/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/2436/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/c1cb32296befd581e2faea78aed70b3e403a538b"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"sHaggYcaT"}}