payload: {"action":"created","issue":{"url":"https://api.github.com/repos/climate-machine/CLIMA/issues/543","repository_url":"https://api.github.com/repos/climate-machine/CLIMA","labels_url":"https://api.github.com/repos/climate-machine/CLIMA/issues/543/labels{/name}","comments_url":"https://api.github.com/repos/climate-machine/CLIMA/issues/543/comments","events_url":"https://api.github.com/repos/climate-machine/CLIMA/issues/543/events","html_url":"https://github.com/climate-machine/CLIMA/pull/543","id":524676788,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyNDA5MTQ3","number":543,"title":"Make arguments to update_aux! more general","user":{"login":"blallen","id":7977055,"node_id":"MDQ6VXNlcjc5NzcwNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7977055?v=4","gravatar_id":"","url":"https://api.github.com/users/blallen","html_url":"https://github.com/blallen","followers_url":"https://api.github.com/users/blallen/followers","following_url":"https://api.github.com/users/blallen/following{/other_user}","gists_url":"https://api.github.com/users/blallen/gists{/gist_id}","starred_url":"https://api.github.com/users/blallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blallen/subscriptions","organizations_url":"https://api.github.com/users/blallen/orgs","repos_url":"https://api.github.com/users/blallen/repos","events_url":"https://api.github.com/users/blallen/events{/privacy}","received_events_url":"https://api.github.com/users/blallen/received_events","type":"User","site_admin":false},"labels":[{"id":1601182959,"node_id":"MDU6TGFiZWwxNjAxMTgyOTU5","url":"https://api.github.com/repos/climate-machine/CLIMA/labels/DG%20Kernels","name":"DG Kernels","color":"ff0000","default":false},{"id":1555023425,"node_id":"MDU6TGFiZWwxNTU1MDIzNDI1","url":"https://api.github.com/repos/climate-machine/CLIMA/labels/Ocean","name":"Ocean","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-11-18T23:17:51Z","updated_at":"2019-11-18T23:25:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/climate-machine/CLIMA/pulls/543","html_url":"https://github.com/climate-machine/CLIMA/pull/543","diff_url":"https://github.com/climate-machine/CLIMA/pull/543.diff","patch_url":"https://github.com/climate-machine/CLIMA/pull/543.patch"},"body":"Our current call to `update_aux!` only allows one to use state and auxiliary variables during the function call. Since `auxstate` and `diffstate` are now members of the `DGModel` struct, I'd like to access them this way instead of being passed in as arguments. This would be very useful for the ocean model (PR #535) which needs to access the gradient variables during the `update_aux!` call. \r\n\r\nI'm not 100% happy with the current implementation, as it requires the function passed into `nodal_update_aux!` to always take all three arrays as arguments, but this is still fewer changes than passing the gradient variables as an argument in `update_aux!`. Please give suggestions if you can think of a better way to do this. This is also partially future-proofing for when we add an integral state to the `DGModel` struct. \r\n\r\nAlso, why this is passing the tests that explicitly use `update_aux!` but not those that don't is a little obtuse to me. Help here would be much appreciated :)"},"comment":{"url":"https://api.github.com/repos/climate-machine/CLIMA/issues/comments/555257718","html_url":"https://github.com/climate-machine/CLIMA/pull/543#issuecomment-555257718","issue_url":"https://api.github.com/repos/climate-machine/CLIMA/issues/543","id":555257718,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NTI1NzcxOA==","user":{"login":"jkozdon","id":1994742,"node_id":"MDQ6VXNlcjE5OTQ3NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1994742?v=4","gravatar_id":"","url":"https://api.github.com/users/jkozdon","html_url":"https://github.com/jkozdon","followers_url":"https://api.github.com/users/jkozdon/followers","following_url":"https://api.github.com/users/jkozdon/following{/other_user}","gists_url":"https://api.github.com/users/jkozdon/gists{/gist_id}","starred_url":"https://api.github.com/users/jkozdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkozdon/subscriptions","organizations_url":"https://api.github.com/users/jkozdon/orgs","repos_url":"https://api.github.com/users/jkozdon/repos","events_url":"https://api.github.com/users/jkozdon/events{/privacy}","received_events_url":"https://api.github.com/users/jkozdon/received_events","type":"User","site_admin":false},"created_at":"2019-11-18T23:25:44Z","updated_at":"2019-11-18T23:25:44Z","author_association":"CONTRIBUTOR","body":"This interface is fine with me."}}
other: {"actor":{"display_login":"jkozdon"}}