payload: {"action":"created","issue":{"url":"https://api.github.com/repos/paritytech/yamux/issues/50","repository_url":"https://api.github.com/repos/paritytech/yamux","labels_url":"https://api.github.com/repos/paritytech/yamux/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/paritytech/yamux/issues/50/comments","events_url":"https://api.github.com/repos/paritytech/yamux/issues/50/events","html_url":"https://github.com/paritytech/yamux/pull/50","id":423259676,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyODcxMTcz","number":50,"title":"Rework implementation.","user":{"login":"twittner","id":132165,"node_id":"MDQ6VXNlcjEzMjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/132165?v=4","gravatar_id":"","url":"https://api.github.com/users/twittner","html_url":"https://github.com/twittner","followers_url":"https://api.github.com/users/twittner/followers","following_url":"https://api.github.com/users/twittner/following{/other_user}","gists_url":"https://api.github.com/users/twittner/gists{/gist_id}","starred_url":"https://api.github.com/users/twittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twittner/subscriptions","organizations_url":"https://api.github.com/users/twittner/orgs","repos_url":"https://api.github.com/users/twittner/repos","events_url":"https://api.github.com/users/twittner/events{/privacy}","received_events_url":"https://api.github.com/users/twittner/received_events","type":"User","site_admin":false},"labels":[{"id":1283469911,"node_id":"MDU6TGFiZWwxMjgzNDY5OTEx","url":"https://api.github.com/repos/paritytech/yamux/labels/ready%20for%20review","name":"ready for review","color":"ffdd00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-20T13:46:19Z","updated_at":"2019-04-24T09:43:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/paritytech/yamux/pulls/50","html_url":"https://github.com/paritytech/yamux/pull/50","diff_url":"https://github.com/paritytech/yamux/pull/50.diff","patch_url":"https://github.com/paritytech/yamux/pull/50.patch"},"body":"Try a different implementation approach. Also fixes the sometimes not terminating test in `concurrent.rs` (cf. #49). In terms of performance the test in `concurrent.rs` now takes 1.8s vs. 6.6s on my machine (real time, 1000 streams each sending and receiving 1000 KiB of data, compiled in release mode)."},"comment":{"url":"https://api.github.com/repos/paritytech/yamux/issues/comments/486148677","html_url":"https://github.com/paritytech/yamux/pull/50#issuecomment-486148677","issue_url":"https://api.github.com/repos/paritytech/yamux/issues/50","id":486148677,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NjE0ODY3Nw==","user":{"login":"twittner","id":132165,"node_id":"MDQ6VXNlcjEzMjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/132165?v=4","gravatar_id":"","url":"https://api.github.com/users/twittner","html_url":"https://github.com/twittner","followers_url":"https://api.github.com/users/twittner/followers","following_url":"https://api.github.com/users/twittner/following{/other_user}","gists_url":"https://api.github.com/users/twittner/gists{/gist_id}","starred_url":"https://api.github.com/users/twittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twittner/subscriptions","organizations_url":"https://api.github.com/users/twittner/orgs","repos_url":"https://api.github.com/users/twittner/repos","events_url":"https://api.github.com/users/twittner/events{/privacy}","received_events_url":"https://api.github.com/users/twittner/received_events","type":"User","site_admin":false},"created_at":"2019-04-24T09:43:51Z","updated_at":"2019-04-24T09:43:51Z","author_association":"MEMBER","body":"> > [...] dropping a connection `Handle` seems to initiate a \"graceful\" `close()` of the connection, whereas I would have expected that to be a `reset()` [...]\r\n> \r\n> We can change the `Drop` impl to trigger a connection abort.\r\n\r\nI was thinking more about it and the change to send `Abort` in `Drop` is wrong I think. A `Handle::close` followed by a `Handle::drop` will send messages `Close`, followed by `Abort` to the connection actor and in most cases this will be almost the same as sending `Abort` directly since the actor will not have finished the closing of the connection when being told to abort. Instead `Handle::abort` should be viewed as an alternative to `Handle::close` which can be invoked by clients if they wish to terminate the connection immediately, but usually `Handle::close` will be used (either explicitly or implicitly by `Drop`). If you (@romanb, @tomaka) agree, I would like to revert 64b9caaa0a09fd16622e6ab8c0bf7a515b683518."}}
other: {"actor":{"display_login":"twittner"}}