payload: {"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/266253165","pull_request_review_id":215369036,"id":266253165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjI1MzE2NQ==","diff_hunk":"@@ -826,6 +826,9 @@ def chebpow(c, pow, maxpower=16):\n     array([15.5, 22. , 16. , ..., 12.5, 12. ,  8. ])\n \n     \"\"\"\n+    # note: this is more efficient than `pu._pow(chebmul, c1, c2)`, as it\n+    # avoids converting between z and c series repeatedly\n+","path":"numpy/polynomial/chebyshev.py","position":6,"original_position":6,"commit_id":"ddbc31c2d71285f426dc16fab8ac2e00ffe6c1f8","original_commit_id":"ddbc31c2d71285f426dc16fab8ac2e00ffe6c1f8","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"`as_series` still makes a pointless copy. If efficiency isn't a concern, then maybe we should just merge #11816","created_at":"2019-03-17T18:41:55Z","updated_at":"2019-03-17T18:41:56Z","html_url":"https://github.com/numpy/numpy/pull/13146#discussion_r266253165","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/13146","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/266253165"},"html":{"href":"https://github.com/numpy/numpy/pull/13146#discussion_r266253165"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/13146"}},"in_reply_to_id":266250121},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/13146","id":261816381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxODE2Mzgx","html_url":"https://github.com/numpy/numpy/pull/13146","diff_url":"https://github.com/numpy/numpy/pull/13146.diff","patch_url":"https://github.com/numpy/numpy/pull/13146.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/13146","number":13146,"state":"open","locked":false,"title":"MAINT: Unify polynomial power functions","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"These power functions are all the same - the algorithm used does not care about the basis.\r\n\r\n`polypow` and `chebpow` have some optimizations in their versions, so I have left those intact.\r\n\r\nNote that this will conflict with #11816. This is a more conservative approach that does not attempt to change any implementation in a way that affects optimization. It would be fairly straightforward to rebase that PR on top of this one if we decide we want to remove the optimizations.","created_at":"2019-03-17T03:43:05Z","updated_at":"2019-03-17T18:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50b08e93403424d9b1ac161864841b3f35b6ed72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":36825825,"node_id":"MDU6TGFiZWwzNjgyNTgyNQ==","url":"https://api.github.com/repos/numpy/numpy/labels/03%20-%20Maintenance","name":"03 - Maintenance","color":"fef2c0","default":false},{"id":16917596,"node_id":"MDU6TGFiZWwxNjkxNzU5Ng==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.polynomial","name":"component: numpy.polynomial","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/13146/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/13146/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/13146/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/ddbc31c2d71285f426dc16fab8ac2e00ffe6c1f8","head":{"label":"eric-wieser:poly-pow","ref":"poly-pow","sha":"ddbc31c2d71285f426dc16fab8ac2e00ffe6c1f8","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"repo":{"id":57262933,"node_id":"MDEwOlJlcG9zaXRvcnk1NzI2MjkzMw==","name":"numpy","full_name":"eric-wieser/numpy","private":false,"owner":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eric-wieser/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/eric-wieser/numpy","forks_url":"https://api.github.com/repos/eric-wieser/numpy/forks","keys_url":"https://api.github.com/repos/eric-wieser/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eric-wieser/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eric-wieser/numpy/teams","hooks_url":"https://api.github.com/repos/eric-wieser/numpy/hooks","issue_events_url":"https://api.github.com/repos/eric-wieser/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/eric-wieser/numpy/events","assignees_url":"https://api.github.com/repos/eric-wieser/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/eric-wieser/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/eric-wieser/numpy/tags","blobs_url":"https://api.github.com/repos/eric-wieser/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eric-wieser/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eric-wieser/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/eric-wieser/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eric-wieser/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/eric-wieser/numpy/languages","stargazers_url":"https://api.github.com/repos/eric-wieser/numpy/stargazers","contributors_url":"https://api.github.com/repos/eric-wieser/numpy/contributors","subscribers_url":"https://api.github.com/repos/eric-wieser/numpy/subscribers","subscription_url":"https://api.github.com/repos/eric-wieser/numpy/subscription","commits_url":"https://api.github.com/repos/eric-wieser/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/eric-wieser/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/eric-wieser/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/eric-wieser/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/eric-wieser/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/eric-wieser/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eric-wieser/numpy/merges","archive_url":"https://api.github.com/repos/eric-wieser/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eric-wieser/numpy/downloads","issues_url":"https://api.github.com/repos/eric-wieser/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/eric-wieser/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/eric-wieser/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/eric-wieser/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eric-wieser/numpy/labels{/name}","releases_url":"https://api.github.com/repos/eric-wieser/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/eric-wieser/numpy/deployments","created_at":"2016-04-28T02:09:21Z","updated_at":"2018-06-10T07:03:02Z","pushed_at":"2019-03-17T04:09:04Z","git_url":"git://github.com/eric-wieser/numpy.git","ssh_url":"git@github.com:eric-wieser/numpy.git","clone_url":"https://github.com/eric-wieser/numpy.git","svn_url":"https://github.com/eric-wieser/numpy","homepage":"http://www.numpy.org/","size":62761,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"06da877ceae914a875bd1a55cd8e271332358803","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"The fundamental package for scientific computing with Python.","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2019-03-17T17:15:43Z","pushed_at":"2019-03-17T17:22:05Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":64530,"stargazers_count":9962,"watchers_count":9962,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3394,"mirror_url":null,"archived":false,"open_issues_count":1998,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3394,"open_issues":1998,"watchers":9962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/13146"},"html":{"href":"https://github.com/numpy/numpy/pull/13146"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/13146"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/13146/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/13146/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/13146/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/ddbc31c2d71285f426dc16fab8ac2e00ffe6c1f8"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"eric-wieser"}}