payload: {"action":"created","issue":{"url":"https://api.github.com/repos/cms-l1t-offline/cmssw/issues/770","repository_url":"https://api.github.com/repos/cms-l1t-offline/cmssw","labels_url":"https://api.github.com/repos/cms-l1t-offline/cmssw/issues/770/labels{/name}","comments_url":"https://api.github.com/repos/cms-l1t-offline/cmssw/issues/770/comments","events_url":"https://api.github.com/repos/cms-l1t-offline/cmssw/issues/770/events","html_url":"https://github.com/cms-l1t-offline/cmssw/pull/770","id":448107567,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxOTY3MTk1","number":770,"title":"Protecting uGMT emulator from zero pT muons","user":{"login":"dinyar","id":1653340,"node_id":"MDQ6VXNlcjE2NTMzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1653340?v=4","gravatar_id":"","url":"https://api.github.com/users/dinyar","html_url":"https://github.com/dinyar","followers_url":"https://api.github.com/users/dinyar/followers","following_url":"https://api.github.com/users/dinyar/following{/other_user}","gists_url":"https://api.github.com/users/dinyar/gists{/gist_id}","starred_url":"https://api.github.com/users/dinyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinyar/subscriptions","organizations_url":"https://api.github.com/users/dinyar/orgs","repos_url":"https://api.github.com/users/dinyar/repos","events_url":"https://api.github.com/users/dinyar/events{/privacy}","received_events_url":"https://api.github.com/users/dinyar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-05-24T10:54:48Z","updated_at":"2019-08-15T11:07:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cms-l1t-offline/cmssw/pulls/770","html_url":"https://github.com/cms-l1t-offline/cmssw/pull/770","diff_url":"https://github.com/cms-l1t-offline/cmssw/pull/770.diff","patch_url":"https://github.com/cms-l1t-offline/cmssw/pull/770.patch"},"body":"Hi,\r\n\r\nmuon data with pT = 0 is defined as 'no muon' according to the interface note. The uGMT firmware detects such data and discards it at the inputs, but the emulator seems to be susceptible to receiving muons with reasonable coordinates and quality but pT = 0. In such a case it can happen that a pT = 0 muon cancels out a proper one leading to a mismatch between firmware and emulator.\r\n\r\nI've introduced a simple pT > 0 check in the L1TMuonProducer to make sure we only accept proper muons in our input.\r\n\r\n@rekovic, please let me know if I should make this PR against a different branch.\r\n@thomreis if you could have a quick look to make sure I didn't miss anything this would be appreciated.\r\n\r\nCheers,\r\nDinyar"},"comment":{"url":"https://api.github.com/repos/cms-l1t-offline/cmssw/issues/comments/521605082","html_url":"https://github.com/cms-l1t-offline/cmssw/pull/770#issuecomment-521605082","issue_url":"https://api.github.com/repos/cms-l1t-offline/cmssw/issues/770","id":521605082,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMTYwNTA4Mg==","user":{"login":"dinyar","id":1653340,"node_id":"MDQ6VXNlcjE2NTMzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1653340?v=4","gravatar_id":"","url":"https://api.github.com/users/dinyar","html_url":"https://github.com/dinyar","followers_url":"https://api.github.com/users/dinyar/followers","following_url":"https://api.github.com/users/dinyar/following{/other_user}","gists_url":"https://api.github.com/users/dinyar/gists{/gist_id}","starred_url":"https://api.github.com/users/dinyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinyar/subscriptions","organizations_url":"https://api.github.com/users/dinyar/orgs","repos_url":"https://api.github.com/users/dinyar/repos","events_url":"https://api.github.com/users/dinyar/events{/privacy}","received_events_url":"https://api.github.com/users/dinyar/received_events","type":"User","site_admin":false},"created_at":"2019-08-15T11:07:27Z","updated_at":"2019-08-15T11:07:27Z","author_association":"NONE","body":"Hi Thomas,\r\n\r\nthanks for the reply and sorry for the long silence. I managed to have a think about this now and I think you're right that it shouldn't be negatively affected. If I understand the autoBxRange algo correctly this is to avoid computing outputs for BXs where only partial information is available, so if we do have a muon in some BX (even if it's with pT 0) this would still correctly indicate the BX range as the pT != 0 cleaning is done later.\r\n\r\nGiven that @rekovic, could you merge this PR?\r\n\r\nCheers,\r\nDinyar"}}
other: {"actor":{"display_login":"dinyar"}}