payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/lostisland/faraday/issues/960","repository_url":"https://api.github.com/repos/lostisland/faraday","labels_url":"https://api.github.com/repos/lostisland/faraday/issues/960/labels{/name}","comments_url":"https://api.github.com/repos/lostisland/faraday/issues/960/comments","events_url":"https://api.github.com/repos/lostisland/faraday/issues/960/events","html_url":"https://github.com/lostisland/faraday/issues/960","id":427373854,"node_id":"MDU6SXNzdWU0MjczNzM4NTQ=","number":960,"title":"URL with unicode query string nolonger work after 0.13.0","user":{"login":"albb0920","id":276340,"node_id":"MDQ6VXNlcjI3NjM0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/276340?v=4","gravatar_id":"","url":"https://api.github.com/users/albb0920","html_url":"https://github.com/albb0920","followers_url":"https://api.github.com/users/albb0920/followers","following_url":"https://api.github.com/users/albb0920/following{/other_user}","gists_url":"https://api.github.com/users/albb0920/gists{/gist_id}","starred_url":"https://api.github.com/users/albb0920/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albb0920/subscriptions","organizations_url":"https://api.github.com/users/albb0920/orgs","repos_url":"https://api.github.com/users/albb0920/repos","events_url":"https://api.github.com/users/albb0920/events{/privacy}","received_events_url":"https://api.github.com/users/albb0920/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-31T08:55:30Z","updated_at":"2019-03-31T08:55:40Z","closed_at":"2019-03-31T08:55:40Z","author_association":"NONE","body":"## Basic Info\r\n\r\n* Faraday Version: 0.15.4\r\n* Ruby Version: 2.5.0\r\n\r\n## Issue description\r\nDoing GET with Unicode characters like this used to work under 0.12.4.\r\n\r\n```ruby\r\nFaraday.get 'http://example.com/?a=測試'\r\n```\r\n\r\nAfter 0.13.0, this no longer works, an URI::InvalidURIError would be raised.\r\n```\r\nTraceback (most recent call last):\r\n        10: from test_faraday.rb:12:in `<main>'\r\n         9: from faraday-0.15.4/lib/faraday.rb:103:in `method_missing'\r\n         8: from faraday-0.15.4/lib/faraday/connection.rb:138:in `get'\r\n         7: from faraday-0.15.4/lib/faraday/connection.rb:377:in `run_request'\r\n         6: from faraday-0.15.4/lib/faraday/connection.rb:477:in `proxy_for_request'\r\n         5: from faraday-0.15.4/lib/faraday/utils.rb:275:in `URI'\r\n         4: from faraday-0.15.4/lib/faraday/utils.rb:275:in `call'\r\n         3: from uri/common.rb:743:in `URI'\r\n         2: from uri/common.rb:237:in `parse'\r\n         1: from uri/rfc3986_parser.rb:73:in `parse'\r\nuri/rfc3986_parser.rb:21:in `split': URI must be ascii only \"http://example.com/?a=\\u6E2C\\u8A66\" (URI::InvalidURIError)\r\n```\r\n\r\nWe found this recently as one of our dependency no longer locks to 0.12.x.\r\n\r\nThis might not be a bug, as unicode on url path never worked.\r\n```ruby\r\nFaraday.get 'http://example.com/測試'\r\n```\r\n\r\nI opened this issue to document this change of behavior.\r\n\r\nThere's two simple fix:\r\n\r\n* repalce the uri parser\r\n```ruby\r\nFaraday::Utils.default_uri_parser = ->(uri) { Addressable::URI.parse(uri)\r\n```\r\n\r\n* Use hash parameters syntax\r\n```ruby\r\nFaraday.get 'http://example.com/', a: '測試'\r\n```\r\n\r\n## Steps to reproduce\r\nIf possible, please provide the steps to reproduce the issue.\r\n\r\n```ruby\r\nFaraday.get 'http://example.com/?a=測試'\r\n```"}}
other: {"actor":{"display_login":"albb0920"}}