payload: {"action":"created","issue":{"url":"https://api.github.com/repos/adonisjs/adonis-session/issues/10","repository_url":"https://api.github.com/repos/adonisjs/adonis-session","labels_url":"https://api.github.com/repos/adonisjs/adonis-session/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/adonisjs/adonis-session/issues/10/comments","events_url":"https://api.github.com/repos/adonisjs/adonis-session/issues/10/events","html_url":"https://github.com/adonisjs/adonis-session/pull/10","id":403874498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4MTg2MTUw","number":10,"title":"fix: use same bson library as mongodb driver","user":{"login":"targos","id":2352663,"node_id":"MDQ6VXNlcjIzNTI2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-01-28T15:41:14Z","updated_at":"2019-04-24T09:01:19Z","closed_at":"2019-03-23T08:00:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/adonisjs/adonis-session/pulls/10","html_url":"https://github.com/adonisjs/adonis-session/pull/10","diff_url":"https://github.com/adonisjs/adonis-session/pull/10.diff","patch_url":"https://github.com/adonisjs/adonis-session/pull/10.patch"},"body":"<!-- CLICK \"Preview\" FOR INSTRUCTIONS IN A MORE READABLE FORMAT -->\r\n\r\n## Proposed changes\r\n\r\nThere is an incompatibility between `bson` version 4.0.0 and the version used by the mongodb driver to serialize queries [(version ^1.0.4)](https://github.com/mongodb/node-mongodb-native/blob/c6f417e5fe54691783bccc466e7703a5d380739e/package.json#L25).\r\n\r\nThe serializer in `bson` 1.1.0 only checks for `_bsontype === 'ObjectID'`:\r\nhttps://github.com/mongodb/js-bson/blob/v1.1.0/lib/bson/parser/serializer.js#L721-L723\r\n\r\nIn `bson` 4.0.0, the field was changed to `ObjectId` (notice the lowercase \"d\"):\r\nhttps://github.com/mongodb/js-bson/blob/v4.0.1/lib/objectid.js#L50\r\n\r\nThis breaks `adonis-session` when used with `lucid-mongo` because the serialization ignores the `_id` as it doesn't have the expected `_bsontype`.\r\n\r\nTo fix this, we propose to stick with the `bson` version as used by the driver.\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce?\r\n\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/adonisjs/adonis-session/blob/develop/CONTRIBUTING.md) doc\r\n- [ ] Lint and unit tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works.\r\n- [ ] I have added necessary documentation (if appropriate)\r\n"},"comment":{"url":"https://api.github.com/repos/adonisjs/adonis-session/issues/comments/486134039","html_url":"https://github.com/adonisjs/adonis-session/pull/10#issuecomment-486134039","issue_url":"https://api.github.com/repos/adonisjs/adonis-session/issues/10","id":486134039,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NjEzNDAzOQ==","user":{"login":"targos","id":2352663,"node_id":"MDQ6VXNlcjIzNTI2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"created_at":"2019-04-24T09:01:19Z","updated_at":"2019-04-24T09:01:19Z","author_association":"CONTRIBUTOR","body":"Thank you. Is it possible to have a release with this fix?"}}
other: {"actor":{"display_login":"targos"}}