payload: {"action":"created","issue":{"url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/637","repository_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer","labels_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/637/labels{/name}","comments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/637/comments","events_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/637/events","html_url":"https://github.com/GoogleWebComponents/model-viewer/issues/637","id":455908941,"node_id":"MDU6SXNzdWU0NTU5MDg5NDE=","number":637,"title":"HDR Environment not lighting models on Samsung Galaxy S8 or S9","user":{"login":"pushmatrix","id":190692,"node_id":"MDQ6VXNlcjE5MDY5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/190692?v=4","gravatar_id":"","url":"https://api.github.com/users/pushmatrix","html_url":"https://github.com/pushmatrix","followers_url":"https://api.github.com/users/pushmatrix/followers","following_url":"https://api.github.com/users/pushmatrix/following{/other_user}","gists_url":"https://api.github.com/users/pushmatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/pushmatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushmatrix/subscriptions","organizations_url":"https://api.github.com/users/pushmatrix/orgs","repos_url":"https://api.github.com/users/pushmatrix/repos","events_url":"https://api.github.com/users/pushmatrix/events{/privacy}","received_events_url":"https://api.github.com/users/pushmatrix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-06-13T19:14:08Z","updated_at":"2019-06-13T22:09:40Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!-- Instructions For Filing a Bug: https://github.com/GoogleWebComponents/model-viewer/blob/master/CONTRIBUTING.md#filing-bugs -->\r\n### Description\r\n\r\nCurrently testing viewing a PBR model on a Samsung Galaxy S8 and S9 and am running into an issue where it appears unlit.\r\n<img width=\"477\" alt=\"Screen Shot 2019-06-13 at 2 24 54 PM\" src=\"https://user-images.githubusercontent.com/190692/59457975-7ddb5a00-8de7-11e9-922d-838018120a22.png\">\r\n\r\nI have stage lighting set to 0, and if I turn stage lighting back on, then you do see it lit:\r\n\r\n<img width=\"450\" alt=\"Screen Shot 2019-06-13 at 2 25 56 PM\" src=\"https://user-images.githubusercontent.com/190692/59458363-47eaa580-8de8-11e9-833d-2e794959d56f.png\">\r\n\r\nCaveat: I am testing this in Browserstack since I don't have an actual S8 or S9, however browserstack is just a video feed from real devices. It works on an S10.\r\n\r\nI get the following in console:\r\n\r\n<img width=\"1194\" alt=\"Screen Shot 2019-06-13 at 2 26 08 PM\" src=\"https://user-images.githubusercontent.com/190692/59460545-58e9e580-8ded-11e9-8cb7-aba54eab6e93.png\">\r\n\r\n\r\n#### Live Demo\r\nhttps://obtainable-pancake-1.glitch.me/\r\n\r\n\r\n### OS & Browser Affected\r\n<img width=\"368\" alt=\"Screen Shot 2019-06-13 at 3 12 28 PM\" src=\"https://user-images.githubusercontent.com/190692/59460690-ae25f700-8ded-11e9-982e-39db3c9a0038.png\">\r\n\r\n\r\n### Versions\r\n<!--\r\nInclude the version of `<model-viewer>`, three.js, along with any polyfills that you're\r\nusing. The output of `npm ls` should include this information (if you're using npm).\r\n-->\r\n- model-viewer: v0.3.1\r\n- three.js: r101\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/comments/501896947","html_url":"https://github.com/GoogleWebComponents/model-viewer/issues/637#issuecomment-501896947","issue_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/637","id":501896947,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMTg5Njk0Nw==","user":{"login":"elalish","id":1649964,"node_id":"MDQ6VXNlcjE2NDk5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1649964?v=4","gravatar_id":"","url":"https://api.github.com/users/elalish","html_url":"https://github.com/elalish","followers_url":"https://api.github.com/users/elalish/followers","following_url":"https://api.github.com/users/elalish/following{/other_user}","gists_url":"https://api.github.com/users/elalish/gists{/gist_id}","starred_url":"https://api.github.com/users/elalish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elalish/subscriptions","organizations_url":"https://api.github.com/users/elalish/orgs","repos_url":"https://api.github.com/users/elalish/repos","events_url":"https://api.github.com/users/elalish/events{/privacy}","received_events_url":"https://api.github.com/users/elalish/received_events","type":"User","site_admin":false},"created_at":"2019-06-13T22:09:40Z","updated_at":"2019-06-13T22:09:40Z","author_association":"COLLABORATOR","body":"Nevermind, I bet @cdata is right. Our environment map generation uses half float textures, and when that's not supported, everything down stream of that will fail. OES_texture_float_linear and EXT_shader_texture_lod are pretty critical to us now. We might want to decide if we should build an IBL system that doesn't rely on these extensions."}}
other: {"actor":{"display_login":"elalish"}}