payload: {"action":"opened","number":1231,"pull_request":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/1231","id":273092089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczMDkyMDg5","html_url":"https://github.com/novnc/noVNC/pull/1231","diff_url":"https://github.com/novnc/noVNC/pull/1231.diff","patch_url":"https://github.com/novnc/noVNC/pull/1231.patch","issue_url":"https://api.github.com/repos/novnc/noVNC/issues/1231","number":1231,"state":"open","locked":false,"title":"Added a Snap package for noVNC","user":{"login":"tkedwards","id":1695095,"node_id":"MDQ6VXNlcjE2OTUwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1695095?v=4","gravatar_id":"","url":"https://api.github.com/users/tkedwards","html_url":"https://github.com/tkedwards","followers_url":"https://api.github.com/users/tkedwards/followers","following_url":"https://api.github.com/users/tkedwards/following{/other_user}","gists_url":"https://api.github.com/users/tkedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/tkedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkedwards/subscriptions","organizations_url":"https://api.github.com/users/tkedwards/orgs","repos_url":"https://api.github.com/users/tkedwards/repos","events_url":"https://api.github.com/users/tkedwards/events{/privacy}","received_events_url":"https://api.github.com/users/tkedwards/received_events","type":"User","site_admin":false},"body":"I've added a Snap package to make noVNC easy to install and run as a service. This involves 3 changes:\r\n- to README.md to add a docs section for the Snap package\r\n- the addition of snap/snapcraft.yaml which contains everything needed to generate the Snap package\r\n- added extra logic for finding the WEBSOCKIFY binary. This is due to the fact that although the Snap package uses the Ubuntu 'websockify' package the binary it installs (inside the Snap confinement directory) is usr/bin/python2-websockify. This is because the update-alternatives system that creates usr/bin/websockify doesn't run in DEB packages used as part of a Snap\r\n\r\nIf you accept this change there's one more thing - someone needs to submit the Snap package to the store. I can do it, but the store's docs say that the project team should usually be the ones to do it: https://docs.snapcraft.io/releasing-to-the-snap-store/6848","created_at":"2019-04-24T11:40:01Z","updated_at":"2019-04-24T11:40:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/novnc/noVNC/pulls/1231/commits","review_comments_url":"https://api.github.com/repos/novnc/noVNC/pulls/1231/comments","review_comment_url":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novnc/noVNC/issues/1231/comments","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/3a63bc7bfc29d0fe4f586cf24e06692145716f9a","head":{"label":"tkedwards:snap_package","ref":"snap_package","sha":"3a63bc7bfc29d0fe4f586cf24e06692145716f9a","user":{"login":"tkedwards","id":1695095,"node_id":"MDQ6VXNlcjE2OTUwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1695095?v=4","gravatar_id":"","url":"https://api.github.com/users/tkedwards","html_url":"https://github.com/tkedwards","followers_url":"https://api.github.com/users/tkedwards/followers","following_url":"https://api.github.com/users/tkedwards/following{/other_user}","gists_url":"https://api.github.com/users/tkedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/tkedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkedwards/subscriptions","organizations_url":"https://api.github.com/users/tkedwards/orgs","repos_url":"https://api.github.com/users/tkedwards/repos","events_url":"https://api.github.com/users/tkedwards/events{/privacy}","received_events_url":"https://api.github.com/users/tkedwards/received_events","type":"User","site_admin":false},"repo":{"id":182337854,"node_id":"MDEwOlJlcG9zaXRvcnkxODIzMzc4NTQ=","name":"noVNC","full_name":"tkedwards/noVNC","private":false,"owner":{"login":"tkedwards","id":1695095,"node_id":"MDQ6VXNlcjE2OTUwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1695095?v=4","gravatar_id":"","url":"https://api.github.com/users/tkedwards","html_url":"https://github.com/tkedwards","followers_url":"https://api.github.com/users/tkedwards/followers","following_url":"https://api.github.com/users/tkedwards/following{/other_user}","gists_url":"https://api.github.com/users/tkedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/tkedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkedwards/subscriptions","organizations_url":"https://api.github.com/users/tkedwards/orgs","repos_url":"https://api.github.com/users/tkedwards/repos","events_url":"https://api.github.com/users/tkedwards/events{/privacy}","received_events_url":"https://api.github.com/users/tkedwards/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tkedwards/noVNC","description":"VNC client using HTML5 (WebSockets, Canvas)","fork":true,"url":"https://api.github.com/repos/tkedwards/noVNC","forks_url":"https://api.github.com/repos/tkedwards/noVNC/forks","keys_url":"https://api.github.com/repos/tkedwards/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkedwards/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkedwards/noVNC/teams","hooks_url":"https://api.github.com/repos/tkedwards/noVNC/hooks","issue_events_url":"https://api.github.com/repos/tkedwards/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/tkedwards/noVNC/events","assignees_url":"https://api.github.com/repos/tkedwards/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/tkedwards/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/tkedwards/noVNC/tags","blobs_url":"https://api.github.com/repos/tkedwards/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkedwards/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkedwards/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkedwards/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkedwards/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/tkedwards/noVNC/languages","stargazers_url":"https://api.github.com/repos/tkedwards/noVNC/stargazers","contributors_url":"https://api.github.com/repos/tkedwards/noVNC/contributors","subscribers_url":"https://api.github.com/repos/tkedwards/noVNC/subscribers","subscription_url":"https://api.github.com/repos/tkedwards/noVNC/subscription","commits_url":"https://api.github.com/repos/tkedwards/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkedwards/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkedwards/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkedwards/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkedwards/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/tkedwards/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkedwards/noVNC/merges","archive_url":"https://api.github.com/repos/tkedwards/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkedwards/noVNC/downloads","issues_url":"https://api.github.com/repos/tkedwards/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/tkedwards/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/tkedwards/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/tkedwards/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkedwards/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/tkedwards/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/tkedwards/noVNC/deployments","created_at":"2019-04-19T23:41:19Z","updated_at":"2019-04-24T11:22:05Z","pushed_at":"2019-04-24T11:28:45Z","git_url":"git://github.com/tkedwards/noVNC.git","ssh_url":"git@github.com:tkedwards/noVNC.git","clone_url":"https://github.com/tkedwards/noVNC.git","svn_url":"https://github.com/tkedwards/noVNC","homepage":"https://novnc.com","size":9527,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"novnc:master","ref":"master","sha":"2b2b6073dd6e9b6b3bef0d65797bbe16b026f362","user":{"login":"novnc","id":24572588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTcyNTg4","avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"repo":{"id":598164,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgxNjQ=","name":"noVNC","full_name":"novnc/noVNC","private":false,"owner":{"login":"novnc","id":24572588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTcyNTg4","avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/novnc/noVNC","description":"VNC client using HTML5 (WebSockets, Canvas)","fork":false,"url":"https://api.github.com/repos/novnc/noVNC","forks_url":"https://api.github.com/repos/novnc/noVNC/forks","keys_url":"https://api.github.com/repos/novnc/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novnc/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novnc/noVNC/teams","hooks_url":"https://api.github.com/repos/novnc/noVNC/hooks","issue_events_url":"https://api.github.com/repos/novnc/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/novnc/noVNC/events","assignees_url":"https://api.github.com/repos/novnc/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/novnc/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/novnc/noVNC/tags","blobs_url":"https://api.github.com/repos/novnc/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novnc/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novnc/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/novnc/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/novnc/noVNC/languages","stargazers_url":"https://api.github.com/repos/novnc/noVNC/stargazers","contributors_url":"https://api.github.com/repos/novnc/noVNC/contributors","subscribers_url":"https://api.github.com/repos/novnc/noVNC/subscribers","subscription_url":"https://api.github.com/repos/novnc/noVNC/subscription","commits_url":"https://api.github.com/repos/novnc/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/novnc/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/novnc/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/novnc/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/novnc/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/novnc/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novnc/noVNC/merges","archive_url":"https://api.github.com/repos/novnc/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novnc/noVNC/downloads","issues_url":"https://api.github.com/repos/novnc/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/novnc/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/novnc/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/novnc/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novnc/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/novnc/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/novnc/noVNC/deployments","created_at":"2010-04-07T01:55:44Z","updated_at":"2019-04-24T08:07:35Z","pushed_at":"2019-04-15T14:13:26Z","git_url":"git://github.com/novnc/noVNC.git","ssh_url":"git@github.com:novnc/noVNC.git","clone_url":"https://github.com/novnc/noVNC.git","svn_url":"https://github.com/novnc/noVNC","homepage":"https://novnc.com","size":9513,"stargazers_count":5297,"watchers_count":5297,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":38,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1129,"open_issues":38,"watchers":5297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1231"},"html":{"href":"https://github.com/novnc/noVNC/pull/1231"},"issue":{"href":"https://api.github.com/repos/novnc/noVNC/issues/1231"},"comments":{"href":"https://api.github.com/repos/novnc/noVNC/issues/1231/comments"},"review_comments":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1231/comments"},"review_comment":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1231/commits"},"statuses":{"href":"https://api.github.com/repos/novnc/noVNC/statuses/3a63bc7bfc29d0fe4f586cf24e06692145716f9a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":16,"additions":68,"deletions":2,"changed_files":3}}
other: {"actor":{"display_login":"tkedwards"}}