payload: {"action":"created","issue":{"url":"https://api.github.com/repos/ros2/rclcpp/issues/809","repository_url":"https://api.github.com/repos/ros2/rclcpp","labels_url":"https://api.github.com/repos/ros2/rclcpp/issues/809/labels{/name}","comments_url":"https://api.github.com/repos/ros2/rclcpp/issues/809/comments","events_url":"https://api.github.com/repos/ros2/rclcpp/issues/809/events","html_url":"https://github.com/ros2/rclcpp/pull/809","id":475307254,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzMDg1ODI4","number":809,"title":"Overload on_parameter_events function","user":{"login":"alsora","id":25433200,"node_id":"MDQ6VXNlcjI1NDMzMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/25433200?v=4","gravatar_id":"","url":"https://api.github.com/users/alsora","html_url":"https://github.com/alsora","followers_url":"https://api.github.com/users/alsora/followers","following_url":"https://api.github.com/users/alsora/following{/other_user}","gists_url":"https://api.github.com/users/alsora/gists{/gist_id}","starred_url":"https://api.github.com/users/alsora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alsora/subscriptions","organizations_url":"https://api.github.com/users/alsora/orgs","repos_url":"https://api.github.com/users/alsora/repos","events_url":"https://api.github.com/users/alsora/events{/privacy}","received_events_url":"https://api.github.com/users/alsora/received_events","type":"User","site_admin":false},"labels":[{"id":180241234,"node_id":"MDU6TGFiZWwxODAyNDEyMzQ=","url":"https://api.github.com/repos/ros2/rclcpp/labels/in%20review","name":"in review","color":"388be2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-31T19:02:34Z","updated_at":"2019-08-09T14:36:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ros2/rclcpp/pulls/809","html_url":"https://github.com/ros2/rclcpp/pull/809","diff_url":"https://github.com/ros2/rclcpp/pull/809.diff","patch_url":"https://github.com/ros2/rclcpp/pull/809.patch"},"body":"Currently the on_parameter_event function can't be called from a class that derives from `node`.\r\n\r\nThe following fails\r\n```\r\nclass MyNode : public rclcpp::Node\r\n{\r\n   MyNode() : Node(\"my_node\")\r\n   {\r\n     auto AsyncParameterClient::OnParameterEvent(this, callback);\r\n   }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/ros2/rclcpp/issues/comments/519943587","html_url":"https://github.com/ros2/rclcpp/pull/809#issuecomment-519943587","issue_url":"https://api.github.com/repos/ros2/rclcpp/issues/809","id":519943587,"node_id":"MDEyOklzc3VlQ29tbWVudDUxOTk0MzU4Nw==","user":{"login":"alsora","id":25433200,"node_id":"MDQ6VXNlcjI1NDMzMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/25433200?v=4","gravatar_id":"","url":"https://api.github.com/users/alsora","html_url":"https://github.com/alsora","followers_url":"https://api.github.com/users/alsora/followers","following_url":"https://api.github.com/users/alsora/following{/other_user}","gists_url":"https://api.github.com/users/alsora/gists{/gist_id}","starred_url":"https://api.github.com/users/alsora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alsora/subscriptions","organizations_url":"https://api.github.com/users/alsora/orgs","repos_url":"https://api.github.com/users/alsora/repos","events_url":"https://api.github.com/users/alsora/events{/privacy}","received_events_url":"https://api.github.com/users/alsora/received_events","type":"User","site_admin":false},"created_at":"2019-08-09T14:36:40Z","updated_at":"2019-08-09T14:36:40Z","author_association":"CONTRIBUTOR","body":"The difference between the demo and my code is that I'm not creating a parameter client, but rather I only want to subscribe to the \"events\" topic.\r\n\r\nAsyncParameterClient provides a static function for doing that.\r\nThis PR is adding the same overloads used for the AsyncParameterClient also to the static function.\r\n\r\n(I will add the error later)"}}
other: {"actor":{"display_login":"alsora"}}