payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pulp/plugin_template/pulls/comments/305103198","pull_request_review_id":263892519,"id":305103198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTEwMzE5OA==","diff_hunk":"@@ -90,11 +91,11 @@ coverage run $(which django-admin) runserver 24817 --noreload >> ~/django_runser\n wait_for_pulp 20\n \n # Run functional tests\n-pytest -v -r sx --color=yes --pyargs pulpcore.tests.functional || show_logs_and_return_non_zero\n {% if plugin_name != 'pulpcore' %}pytest -v -r sx --color=yes --pyargs {{ plugin_snake }}.tests.functional || show_logs_and_return_non_zero","path":"templates/travis/.travis/script.sh.j2","position":13,"original_position":13,"commit_id":"1587f0993849339ba6486a0e2f74b6be250dd4d6","original_commit_id":"1587f0993849339ba6486a0e2f74b6be250dd4d6","user":{"login":"gmbnomis","id":6278695,"node_id":"MDQ6VXNlcjYyNzg2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6278695?v=4","gravatar_id":"","url":"https://api.github.com/users/gmbnomis","html_url":"https://github.com/gmbnomis","followers_url":"https://api.github.com/users/gmbnomis/followers","following_url":"https://api.github.com/users/gmbnomis/following{/other_user}","gists_url":"https://api.github.com/users/gmbnomis/gists{/gist_id}","starred_url":"https://api.github.com/users/gmbnomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmbnomis/subscriptions","organizations_url":"https://api.github.com/users/gmbnomis/orgs","repos_url":"https://api.github.com/users/gmbnomis/repos","events_url":"https://api.github.com/users/gmbnomis/events{/privacy}","received_events_url":"https://api.github.com/users/gmbnomis/received_events","type":"User","site_admin":false},"body":"Idea: Put this `pytest` call into the `else` clause of `if [ -x $FUNC_TEST_SCRIPT ]; then` below.\r\n\r\nThis would allow plugins to override how to run the plugin's functional test (and still provide a default for the common case). Additionally, we can get rid of magic plugin name `if`s.","created_at":"2019-07-18T20:34:21Z","updated_at":"2019-07-18T20:34:21Z","html_url":"https://github.com/pulp/plugin_template/pull/86#discussion_r305103198","pull_request_url":"https://api.github.com/repos/pulp/plugin_template/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pulp/plugin_template/pulls/comments/305103198"},"html":{"href":"https://github.com/pulp/plugin_template/pull/86#discussion_r305103198"},"pull_request":{"href":"https://api.github.com/repos/pulp/plugin_template/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/plugin_template/pulls/86","id":299076545,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5MDc2NTQ1","html_url":"https://github.com/pulp/plugin_template/pull/86","diff_url":"https://github.com/pulp/plugin_template/pull/86.diff","patch_url":"https://github.com/pulp/plugin_template/pull/86.patch","issue_url":"https://api.github.com/repos/pulp/plugin_template/issues/86","number":86,"state":"open","locked":false,"title":"Creating functional test script hook","user":{"login":"daviddavis","id":86290,"node_id":"MDQ6VXNlcjg2Mjkw","avatar_url":"https://avatars0.githubusercontent.com/u/86290?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddavis","html_url":"https://github.com/daviddavis","followers_url":"https://api.github.com/users/daviddavis/followers","following_url":"https://api.github.com/users/daviddavis/following{/other_user}","gists_url":"https://api.github.com/users/daviddavis/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddavis/subscriptions","organizations_url":"https://api.github.com/users/daviddavis/orgs","repos_url":"https://api.github.com/users/daviddavis/repos","events_url":"https://api.github.com/users/daviddavis/events{/privacy}","received_events_url":"https://api.github.com/users/daviddavis/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-18T20:19:58Z","updated_at":"2019-07-18T20:34:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a08607b600b22e0139c5544922c47d7ed8cb65e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulp/plugin_template/pulls/86/commits","review_comments_url":"https://api.github.com/repos/pulp/plugin_template/pulls/86/comments","review_comment_url":"https://api.github.com/repos/pulp/plugin_template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/plugin_template/issues/86/comments","statuses_url":"https://api.github.com/repos/pulp/plugin_template/statuses/1587f0993849339ba6486a0e2f74b6be250dd4d6","head":{"label":"daviddavis:creating-func-test-script","ref":"creating-func-test-script","sha":"1587f0993849339ba6486a0e2f74b6be250dd4d6","user":{"login":"daviddavis","id":86290,"node_id":"MDQ6VXNlcjg2Mjkw","avatar_url":"https://avatars0.githubusercontent.com/u/86290?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddavis","html_url":"https://github.com/daviddavis","followers_url":"https://api.github.com/users/daviddavis/followers","following_url":"https://api.github.com/users/daviddavis/following{/other_user}","gists_url":"https://api.github.com/users/daviddavis/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddavis/subscriptions","organizations_url":"https://api.github.com/users/daviddavis/orgs","repos_url":"https://api.github.com/users/daviddavis/repos","events_url":"https://api.github.com/users/daviddavis/events{/privacy}","received_events_url":"https://api.github.com/users/daviddavis/received_events","type":"User","site_admin":false},"repo":{"id":140016108,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMTYxMDg=","name":"plugin_template","full_name":"daviddavis/plugin_template","private":false,"owner":{"login":"daviddavis","id":86290,"node_id":"MDQ6VXNlcjg2Mjkw","avatar_url":"https://avatars0.githubusercontent.com/u/86290?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddavis","html_url":"https://github.com/daviddavis","followers_url":"https://api.github.com/users/daviddavis/followers","following_url":"https://api.github.com/users/daviddavis/following{/other_user}","gists_url":"https://api.github.com/users/daviddavis/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddavis/subscriptions","organizations_url":"https://api.github.com/users/daviddavis/orgs","repos_url":"https://api.github.com/users/daviddavis/repos","events_url":"https://api.github.com/users/daviddavis/events{/privacy}","received_events_url":"https://api.github.com/users/daviddavis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/daviddavis/plugin_template","description":null,"fork":true,"url":"https://api.github.com/repos/daviddavis/plugin_template","forks_url":"https://api.github.com/repos/daviddavis/plugin_template/forks","keys_url":"https://api.github.com/repos/daviddavis/plugin_template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daviddavis/plugin_template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daviddavis/plugin_template/teams","hooks_url":"https://api.github.com/repos/daviddavis/plugin_template/hooks","issue_events_url":"https://api.github.com/repos/daviddavis/plugin_template/issues/events{/number}","events_url":"https://api.github.com/repos/daviddavis/plugin_template/events","assignees_url":"https://api.github.com/repos/daviddavis/plugin_template/assignees{/user}","branches_url":"https://api.github.com/repos/daviddavis/plugin_template/branches{/branch}","tags_url":"https://api.github.com/repos/daviddavis/plugin_template/tags","blobs_url":"https://api.github.com/repos/daviddavis/plugin_template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daviddavis/plugin_template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daviddavis/plugin_template/git/refs{/sha}","trees_url":"https://api.github.com/repos/daviddavis/plugin_template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daviddavis/plugin_template/statuses/{sha}","languages_url":"https://api.github.com/repos/daviddavis/plugin_template/languages","stargazers_url":"https://api.github.com/repos/daviddavis/plugin_template/stargazers","contributors_url":"https://api.github.com/repos/daviddavis/plugin_template/contributors","subscribers_url":"https://api.github.com/repos/daviddavis/plugin_template/subscribers","subscription_url":"https://api.github.com/repos/daviddavis/plugin_template/subscription","commits_url":"https://api.github.com/repos/daviddavis/plugin_template/commits{/sha}","git_commits_url":"https://api.github.com/repos/daviddavis/plugin_template/git/commits{/sha}","comments_url":"https://api.github.com/repos/daviddavis/plugin_template/comments{/number}","issue_comment_url":"https://api.github.com/repos/daviddavis/plugin_template/issues/comments{/number}","contents_url":"https://api.github.com/repos/daviddavis/plugin_template/contents/{+path}","compare_url":"https://api.github.com/repos/daviddavis/plugin_template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daviddavis/plugin_template/merges","archive_url":"https://api.github.com/repos/daviddavis/plugin_template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daviddavis/plugin_template/downloads","issues_url":"https://api.github.com/repos/daviddavis/plugin_template/issues{/number}","pulls_url":"https://api.github.com/repos/daviddavis/plugin_template/pulls{/number}","milestones_url":"https://api.github.com/repos/daviddavis/plugin_template/milestones{/number}","notifications_url":"https://api.github.com/repos/daviddavis/plugin_template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daviddavis/plugin_template/labels{/name}","releases_url":"https://api.github.com/repos/daviddavis/plugin_template/releases{/id}","deployments_url":"https://api.github.com/repos/daviddavis/plugin_template/deployments","created_at":"2018-07-06T18:02:33Z","updated_at":"2018-07-06T18:02:35Z","pushed_at":"2019-07-18T20:29:26Z","git_url":"git://github.com/daviddavis/plugin_template.git","ssh_url":"git@github.com:daviddavis/plugin_template.git","clone_url":"https://github.com/daviddavis/plugin_template.git","svn_url":"https://github.com/daviddavis/plugin_template","homepage":null,"size":288,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"bc323f38698005cc7ffe6d8f66e130f97a3d7e3f","user":{"login":"pulp","id":2103606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDM2MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/2103606?v=4","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":104753269,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NTMyNjk=","name":"plugin_template","full_name":"pulp/plugin_template","private":false,"owner":{"login":"pulp","id":2103606,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDM2MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/2103606?v=4","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pulp/plugin_template","description":null,"fork":false,"url":"https://api.github.com/repos/pulp/plugin_template","forks_url":"https://api.github.com/repos/pulp/plugin_template/forks","keys_url":"https://api.github.com/repos/pulp/plugin_template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/plugin_template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/plugin_template/teams","hooks_url":"https://api.github.com/repos/pulp/plugin_template/hooks","issue_events_url":"https://api.github.com/repos/pulp/plugin_template/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/plugin_template/events","assignees_url":"https://api.github.com/repos/pulp/plugin_template/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/plugin_template/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/plugin_template/tags","blobs_url":"https://api.github.com/repos/pulp/plugin_template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/plugin_template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/plugin_template/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/plugin_template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/plugin_template/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/plugin_template/languages","stargazers_url":"https://api.github.com/repos/pulp/plugin_template/stargazers","contributors_url":"https://api.github.com/repos/pulp/plugin_template/contributors","subscribers_url":"https://api.github.com/repos/pulp/plugin_template/subscribers","subscription_url":"https://api.github.com/repos/pulp/plugin_template/subscription","commits_url":"https://api.github.com/repos/pulp/plugin_template/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/plugin_template/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/plugin_template/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/plugin_template/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/plugin_template/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/plugin_template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/plugin_template/merges","archive_url":"https://api.github.com/repos/pulp/plugin_template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/plugin_template/downloads","issues_url":"https://api.github.com/repos/pulp/plugin_template/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/plugin_template/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/plugin_template/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/plugin_template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/plugin_template/labels{/name}","releases_url":"https://api.github.com/repos/pulp/plugin_template/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/plugin_template/deployments","created_at":"2017-09-25T13:25:20Z","updated_at":"2019-07-18T12:34:14Z","pushed_at":"2019-07-18T20:29:27Z","git_url":"git://github.com/pulp/plugin_template.git","ssh_url":"git@github.com:pulp/plugin_template.git","clone_url":"https://github.com/pulp/plugin_template.git","svn_url":"https://github.com/pulp/plugin_template","homepage":null,"size":272,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":13,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/plugin_template/pulls/86"},"html":{"href":"https://github.com/pulp/plugin_template/pull/86"},"issue":{"href":"https://api.github.com/repos/pulp/plugin_template/issues/86"},"comments":{"href":"https://api.github.com/repos/pulp/plugin_template/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/plugin_template/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/plugin_template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/plugin_template/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/plugin_template/statuses/1587f0993849339ba6486a0e2f74b6be250dd4d6"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"gmbnomis"}}