payload: {"action":"created","issue":{"url":"https://api.github.com/repos/dequelabs/axe-core/issues/1326","repository_url":"https://api.github.com/repos/dequelabs/axe-core","labels_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1326/labels{/name}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1326/comments","events_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1326/events","html_url":"https://github.com/dequelabs/axe-core/issues/1326","id":400249544,"node_id":"MDU6SXNzdWU0MDAyNDk1NDQ=","number":1326,"title":"button-name rule gives incorrect advise for button elements","user":{"login":"WilcoFiers","id":530687,"node_id":"MDQ6VXNlcjUzMDY4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530687?v=4","gravatar_id":"","url":"https://api.github.com/users/WilcoFiers","html_url":"https://github.com/WilcoFiers","followers_url":"https://api.github.com/users/WilcoFiers/followers","following_url":"https://api.github.com/users/WilcoFiers/following{/other_user}","gists_url":"https://api.github.com/users/WilcoFiers/gists{/gist_id}","starred_url":"https://api.github.com/users/WilcoFiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilcoFiers/subscriptions","organizations_url":"https://api.github.com/users/WilcoFiers/orgs","repos_url":"https://api.github.com/users/WilcoFiers/repos","events_url":"https://api.github.com/users/WilcoFiers/events{/privacy}","received_events_url":"https://api.github.com/users/WilcoFiers/received_events","type":"User","site_admin":false},"labels":[{"id":222828382,"node_id":"MDU6TGFiZWwyMjI4MjgzODI=","url":"https://api.github.com/repos/dequelabs/axe-core/labels/bug","name":"bug","color":"b60205","default":true},{"id":238331950,"node_id":"MDU6TGFiZWwyMzgzMzE5NTA=","url":"https://api.github.com/repos/dequelabs/axe-core/labels/documentation","name":"documentation","color":"4bef04","default":true},{"id":1163432538,"node_id":"MDU6TGFiZWwxMTYzNDMyNTM4","url":"https://api.github.com/repos/dequelabs/axe-core/labels/rule%20metadata","name":"rule metadata","color":"c8cc0e","default":false}],"state":"open","locked":false,"assignee":{"login":"scurker","id":1062039,"node_id":"MDQ6VXNlcjEwNjIwMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1062039?v=4","gravatar_id":"","url":"https://api.github.com/users/scurker","html_url":"https://github.com/scurker","followers_url":"https://api.github.com/users/scurker/followers","following_url":"https://api.github.com/users/scurker/following{/other_user}","gists_url":"https://api.github.com/users/scurker/gists{/gist_id}","starred_url":"https://api.github.com/users/scurker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scurker/subscriptions","organizations_url":"https://api.github.com/users/scurker/orgs","repos_url":"https://api.github.com/users/scurker/repos","events_url":"https://api.github.com/users/scurker/events{/privacy}","received_events_url":"https://api.github.com/users/scurker/received_events","type":"User","site_admin":false},"assignees":[{"login":"scurker","id":1062039,"node_id":"MDQ6VXNlcjEwNjIwMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1062039?v=4","gravatar_id":"","url":"https://api.github.com/users/scurker","html_url":"https://github.com/scurker","followers_url":"https://api.github.com/users/scurker/followers","following_url":"https://api.github.com/users/scurker/following{/other_user}","gists_url":"https://api.github.com/users/scurker/gists{/gist_id}","starred_url":"https://api.github.com/users/scurker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scurker/subscriptions","organizations_url":"https://api.github.com/users/scurker/orgs","repos_url":"https://api.github.com/users/scurker/repos","events_url":"https://api.github.com/users/scurker/events{/privacy}","received_events_url":"https://api.github.com/users/scurker/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dequelabs/axe-core/milestones/8","html_url":"https://github.com/dequelabs/axe-core/milestone/8","labels_url":"https://api.github.com/repos/dequelabs/axe-core/milestones/8/labels","id":4252398,"node_id":"MDk6TWlsZXN0b25lNDI1MjM5OA==","number":8,"title":"Axe-core 3.3","description":"","creator":{"login":"WilcoFiers","id":530687,"node_id":"MDQ6VXNlcjUzMDY4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530687?v=4","gravatar_id":"","url":"https://api.github.com/users/WilcoFiers","html_url":"https://github.com/WilcoFiers","followers_url":"https://api.github.com/users/WilcoFiers/followers","following_url":"https://api.github.com/users/WilcoFiers/following{/other_user}","gists_url":"https://api.github.com/users/WilcoFiers/gists{/gist_id}","starred_url":"https://api.github.com/users/WilcoFiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilcoFiers/subscriptions","organizations_url":"https://api.github.com/users/WilcoFiers/orgs","repos_url":"https://api.github.com/users/WilcoFiers/repos","events_url":"https://api.github.com/users/WilcoFiers/events{/privacy}","received_events_url":"https://api.github.com/users/WilcoFiers/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":27,"state":"open","created_at":"2019-04-23T15:37:00Z","updated_at":"2019-07-11T17:38:22Z","due_on":"2019-07-01T07:00:00Z","closed_at":null},"comments":1,"created_at":"2019-01-17T12:13:56Z","updated_at":"2019-07-11T17:49:16Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Axe-core should not pass the following element:\r\n\r\n```html\r\n<button value=\"foo\" tabindex=\"-1\"></button>\r\n```\r\n\r\nThis is caused by the `value` attribute. The button-name rule has the non-empty-value check for `input[type=button]` elements, and relies on `focusable-no-name` to still fail buttons if they have a value attribute but no accessible name. Firstly this leads to a confusing remediation message, where axe is saying to put a value attribute on buttons. Secondly, because `focusable-no-name` looks at focus, you can trip it up by putting `tabindex=\"-1\"` on the button.\r\n\r\nI think the way to fix this is to break the rule up. Have one rule for `button` elements, and a second for `input` buttons. This is similar to the problem we have with `svg` elements where we're recommending to put an `alt` attribute on them. See #1192"},"comment":{"url":"https://api.github.com/repos/dequelabs/axe-core/issues/comments/510586636","html_url":"https://github.com/dequelabs/axe-core/issues/1326#issuecomment-510586636","issue_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1326","id":510586636,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMDU4NjYzNg==","user":{"login":"jeankaplansky","id":4044039,"node_id":"MDQ6VXNlcjQwNDQwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4044039?v=4","gravatar_id":"","url":"https://api.github.com/users/jeankaplansky","html_url":"https://github.com/jeankaplansky","followers_url":"https://api.github.com/users/jeankaplansky/followers","following_url":"https://api.github.com/users/jeankaplansky/following{/other_user}","gists_url":"https://api.github.com/users/jeankaplansky/gists{/gist_id}","starred_url":"https://api.github.com/users/jeankaplansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeankaplansky/subscriptions","organizations_url":"https://api.github.com/users/jeankaplansky/orgs","repos_url":"https://api.github.com/users/jeankaplansky/repos","events_url":"https://api.github.com/users/jeankaplansky/events{/privacy}","received_events_url":"https://api.github.com/users/jeankaplansky/received_events","type":"User","site_admin":false},"created_at":"2019-07-11T17:49:16Z","updated_at":"2019-07-11T17:49:16Z","author_association":"NONE","body":"https://dequeuniversity.com/rules/axe/3.3/button-name\r\nhttps://dequeuniversity.com/rules/axe/3.3/input-button-name"}}
other: {"actor":{"display_login":"jeankaplansky"}}