payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/br/pulls/comments/356463887","pull_request_review_id":330372425,"id":356463887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjQ2Mzg4Nw==","diff_hunk":"@@ -37,7 +38,11 @@ func ParseBackend(rawURL string, options *BackendOptions) (*backup.StorageBacken\n \t\treturn &backup.StorageBackend{Backend: &backup.StorageBackend_Noop{Noop: noop}}, nil\n \n \tcase \"s3\":\n-\t\ts3 := &backup.S3{Bucket: u.Host, Prefix: u.Path}\n+\t\tif u.Host == \"\" {\n+\t\t\treturn nil, errors.Errorf(\"please specify the bucket for s3 in %s\", rawURL)\n+\t\t}\n+\t\tprefix := strings.Trim(u.Path, \"/\")","path":"pkg/storage/parse.go","position":16,"original_position":16,"commit_id":"716d84e87f1cdea25e8dcbd26b8d4ed0d7f813d6","original_commit_id":"716d84e87f1cdea25e8dcbd26b8d4ed0d7f813d6","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"Could you add tests to cover them?","created_at":"2019-12-11T08:45:22Z","updated_at":"2019-12-11T08:53:19Z","html_url":"https://github.com/pingcap/br/pull/103#discussion_r356463887","pull_request_url":"https://api.github.com/repos/pingcap/br/pulls/103","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/br/pulls/comments/356463887"},"html":{"href":"https://github.com/pingcap/br/pull/103#discussion_r356463887"},"pull_request":{"href":"https://api.github.com/repos/pingcap/br/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/br/pulls/103","id":351789043,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNzg5MDQz","html_url":"https://github.com/pingcap/br/pull/103","diff_url":"https://github.com/pingcap/br/pull/103.diff","patch_url":"https://github.com/pingcap/br/pull/103.patch","issue_url":"https://api.github.com/repos/pingcap/br/issues/103","number":103,"state":"open","locked":false,"title":"backup: store backupmeta to s3","user":{"login":"DanielZhangQD","id":36026334,"node_id":"MDQ6VXNlcjM2MDI2MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/36026334?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielZhangQD","html_url":"https://github.com/DanielZhangQD","followers_url":"https://api.github.com/users/DanielZhangQD/followers","following_url":"https://api.github.com/users/DanielZhangQD/following{/other_user}","gists_url":"https://api.github.com/users/DanielZhangQD/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielZhangQD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielZhangQD/subscriptions","organizations_url":"https://api.github.com/users/DanielZhangQD/orgs","repos_url":"https://api.github.com/users/DanielZhangQD/repos","events_url":"https://api.github.com/users/DanielZhangQD/events{/privacy}","received_events_url":"https://api.github.com/users/DanielZhangQD/received_events","type":"User","site_admin":false},"body":"Support storing backup meta to s3, and support backup and restore with s3.","created_at":"2019-12-11T08:36:44Z","updated_at":"2019-12-11T08:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7dd12bc6eeeb439dcbb45dc6558ca26ed06bf31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kennytm","id":103023,"node_id":"MDQ6VXNlcjEwMzAyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/103023?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytm","html_url":"https://github.com/kennytm","followers_url":"https://api.github.com/users/kennytm/followers","following_url":"https://api.github.com/users/kennytm/following{/other_user}","gists_url":"https://api.github.com/users/kennytm/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytm/subscriptions","organizations_url":"https://api.github.com/users/kennytm/orgs","repos_url":"https://api.github.com/users/kennytm/repos","events_url":"https://api.github.com/users/kennytm/events{/privacy}","received_events_url":"https://api.github.com/users/kennytm/received_events","type":"User","site_admin":false},{"login":"tennix","id":7932127,"node_id":"MDQ6VXNlcjc5MzIxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7932127?v=4","gravatar_id":"","url":"https://api.github.com/users/tennix","html_url":"https://github.com/tennix","followers_url":"https://api.github.com/users/tennix/followers","following_url":"https://api.github.com/users/tennix/following{/other_user}","gists_url":"https://api.github.com/users/tennix/gists{/gist_id}","starred_url":"https://api.github.com/users/tennix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tennix/subscriptions","organizations_url":"https://api.github.com/users/tennix/orgs","repos_url":"https://api.github.com/users/tennix/repos","events_url":"https://api.github.com/users/tennix/events{/privacy}","received_events_url":"https://api.github.com/users/tennix/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/br/pulls/103/commits","review_comments_url":"https://api.github.com/repos/pingcap/br/pulls/103/comments","review_comment_url":"https://api.github.com/repos/pingcap/br/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/br/issues/103/comments","statuses_url":"https://api.github.com/repos/pingcap/br/statuses/716d84e87f1cdea25e8dcbd26b8d4ed0d7f813d6","head":{"label":"DanielZhangQD:ms3","ref":"ms3","sha":"716d84e87f1cdea25e8dcbd26b8d4ed0d7f813d6","user":{"login":"DanielZhangQD","id":36026334,"node_id":"MDQ6VXNlcjM2MDI2MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/36026334?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielZhangQD","html_url":"https://github.com/DanielZhangQD","followers_url":"https://api.github.com/users/DanielZhangQD/followers","following_url":"https://api.github.com/users/DanielZhangQD/following{/other_user}","gists_url":"https://api.github.com/users/DanielZhangQD/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielZhangQD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielZhangQD/subscriptions","organizations_url":"https://api.github.com/users/DanielZhangQD/orgs","repos_url":"https://api.github.com/users/DanielZhangQD/repos","events_url":"https://api.github.com/users/DanielZhangQD/events{/privacy}","received_events_url":"https://api.github.com/users/DanielZhangQD/received_events","type":"User","site_admin":false},"repo":{"id":227315156,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczMTUxNTY=","name":"br","full_name":"DanielZhangQD/br","private":false,"owner":{"login":"DanielZhangQD","id":36026334,"node_id":"MDQ6VXNlcjM2MDI2MzM0","avatar_url":"https://avatars1.githubusercontent.com/u/36026334?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielZhangQD","html_url":"https://github.com/DanielZhangQD","followers_url":"https://api.github.com/users/DanielZhangQD/followers","following_url":"https://api.github.com/users/DanielZhangQD/following{/other_user}","gists_url":"https://api.github.com/users/DanielZhangQD/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielZhangQD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielZhangQD/subscriptions","organizations_url":"https://api.github.com/users/DanielZhangQD/orgs","repos_url":"https://api.github.com/users/DanielZhangQD/repos","events_url":"https://api.github.com/users/DanielZhangQD/events{/privacy}","received_events_url":"https://api.github.com/users/DanielZhangQD/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DanielZhangQD/br","description":"A command-line tool for distributed backup and restoration of the TiDB cluster data","fork":true,"url":"https://api.github.com/repos/DanielZhangQD/br","forks_url":"https://api.github.com/repos/DanielZhangQD/br/forks","keys_url":"https://api.github.com/repos/DanielZhangQD/br/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielZhangQD/br/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielZhangQD/br/teams","hooks_url":"https://api.github.com/repos/DanielZhangQD/br/hooks","issue_events_url":"https://api.github.com/repos/DanielZhangQD/br/issues/events{/number}","events_url":"https://api.github.com/repos/DanielZhangQD/br/events","assignees_url":"https://api.github.com/repos/DanielZhangQD/br/assignees{/user}","branches_url":"https://api.github.com/repos/DanielZhangQD/br/branches{/branch}","tags_url":"https://api.github.com/repos/DanielZhangQD/br/tags","blobs_url":"https://api.github.com/repos/DanielZhangQD/br/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielZhangQD/br/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielZhangQD/br/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielZhangQD/br/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielZhangQD/br/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielZhangQD/br/languages","stargazers_url":"https://api.github.com/repos/DanielZhangQD/br/stargazers","contributors_url":"https://api.github.com/repos/DanielZhangQD/br/contributors","subscribers_url":"https://api.github.com/repos/DanielZhangQD/br/subscribers","subscription_url":"https://api.github.com/repos/DanielZhangQD/br/subscription","commits_url":"https://api.github.com/repos/DanielZhangQD/br/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielZhangQD/br/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielZhangQD/br/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielZhangQD/br/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielZhangQD/br/contents/{+path}","compare_url":"https://api.github.com/repos/DanielZhangQD/br/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielZhangQD/br/merges","archive_url":"https://api.github.com/repos/DanielZhangQD/br/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielZhangQD/br/downloads","issues_url":"https://api.github.com/repos/DanielZhangQD/br/issues{/number}","pulls_url":"https://api.github.com/repos/DanielZhangQD/br/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielZhangQD/br/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielZhangQD/br/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielZhangQD/br/labels{/name}","releases_url":"https://api.github.com/repos/DanielZhangQD/br/releases{/id}","deployments_url":"https://api.github.com/repos/DanielZhangQD/br/deployments","created_at":"2019-12-11T08:34:25Z","updated_at":"2019-12-11T08:34:27Z","pushed_at":"2019-12-11T08:35:05Z","git_url":"git://github.com/DanielZhangQD/br.git","ssh_url":"git@github.com:DanielZhangQD/br.git","clone_url":"https://github.com/DanielZhangQD/br.git","svn_url":"https://github.com/DanielZhangQD/br","homepage":"","size":440,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"dd51353aa5a94bb4083f7265f4c3b60ff930a82e","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":204888772,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ4ODg3NzI=","name":"br","full_name":"pingcap/br","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/br","description":"A command-line tool for distributed backup and restoration of the TiDB cluster data","fork":false,"url":"https://api.github.com/repos/pingcap/br","forks_url":"https://api.github.com/repos/pingcap/br/forks","keys_url":"https://api.github.com/repos/pingcap/br/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/br/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/br/teams","hooks_url":"https://api.github.com/repos/pingcap/br/hooks","issue_events_url":"https://api.github.com/repos/pingcap/br/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/br/events","assignees_url":"https://api.github.com/repos/pingcap/br/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/br/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/br/tags","blobs_url":"https://api.github.com/repos/pingcap/br/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/br/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/br/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/br/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/br/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/br/languages","stargazers_url":"https://api.github.com/repos/pingcap/br/stargazers","contributors_url":"https://api.github.com/repos/pingcap/br/contributors","subscribers_url":"https://api.github.com/repos/pingcap/br/subscribers","subscription_url":"https://api.github.com/repos/pingcap/br/subscription","commits_url":"https://api.github.com/repos/pingcap/br/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/br/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/br/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/br/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/br/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/br/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/br/merges","archive_url":"https://api.github.com/repos/pingcap/br/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/br/downloads","issues_url":"https://api.github.com/repos/pingcap/br/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/br/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/br/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/br/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/br/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/br/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/br/deployments","created_at":"2019-08-28T08:52:34Z","updated_at":"2019-12-11T07:14:07Z","pushed_at":"2019-12-11T08:48:12Z","git_url":"git://github.com/pingcap/br.git","ssh_url":"git@github.com:pingcap/br.git","clone_url":"https://github.com/pingcap/br.git","svn_url":"https://github.com/pingcap/br","homepage":"","size":440,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/br/pulls/103"},"html":{"href":"https://github.com/pingcap/br/pull/103"},"issue":{"href":"https://api.github.com/repos/pingcap/br/issues/103"},"comments":{"href":"https://api.github.com/repos/pingcap/br/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/br/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/br/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/br/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/br/statuses/716d84e87f1cdea25e8dcbd26b8d4ed0d7f813d6"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"overvenus"}}