payload: {"action":"opened","number":1933,"pull_request":{"url":"https://api.github.com/repos/harmony-one/harmony/pulls/1933","id":347998162,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3OTk4MTYy","html_url":"https://github.com/harmony-one/harmony/pull/1933","diff_url":"https://github.com/harmony-one/harmony/pull/1933.diff","patch_url":"https://github.com/harmony-one/harmony/pull/1933.patch","issue_url":"https://api.github.com/repos/harmony-one/harmony/issues/1933","number":1933,"state":"open","locked":false,"title":"[unit-testing] Finish one-node-staked-vote tests","user":{"login":"janet-harmony","id":56005637,"node_id":"MDQ6VXNlcjU2MDA1NjM3","avatar_url":"https://avatars3.githubusercontent.com/u/56005637?v=4","gravatar_id":"","url":"https://api.github.com/users/janet-harmony","html_url":"https://github.com/janet-harmony","followers_url":"https://api.github.com/users/janet-harmony/followers","following_url":"https://api.github.com/users/janet-harmony/following{/other_user}","gists_url":"https://api.github.com/users/janet-harmony/gists{/gist_id}","starred_url":"https://api.github.com/users/janet-harmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janet-harmony/subscriptions","organizations_url":"https://api.github.com/users/janet-harmony/orgs","repos_url":"https://api.github.com/users/janet-harmony/repos","events_url":"https://api.github.com/users/janet-harmony/events{/privacy}","received_events_url":"https://api.github.com/users/janet-harmony/received_events","type":"User","site_admin":false},"body":"* Generate Decider for base case of 50/50 nodes\r\n* Add Quorum Achieved tests for all Staker nodes & all nodes signed\r\n* Add QuorumAchieved tests for all Harmony nodes signed\r\n* Add RewardThreshold tests for all above cases\r\n\r\n## Issue\r\n\r\n#1860 \r\n\r\n## Test\r\n\r\n### Unit Test Coverage\r\n\r\n```\r\n$ go test -v -count=1 github.com/harmony-one/harmony/consensus/quorum/...\r\n=== RUN   TestPolicy\r\n--- PASS: TestPolicy (0.00s)\r\n=== RUN   TestQuorumThreshold\r\n--- PASS: TestQuorumThreshold (0.00s)\r\n=== RUN   TestEvenNodes\r\n--- PASS: TestEvenNodes (0.19s)\r\n=== RUN   Test33HarmonyNodes\r\n--- PASS: Test33HarmonyNodes (0.08s)\r\nPASS\r\nok  \tgithub.com/harmony-one/harmony/consensus/quorum\t0.320s\r\n```\r\n\r\n## Operational Checklist\r\n\r\n1. **Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?**. (If no, skip to question 8.)\r\n\r\n    **NO**\r\n\r\n8. **Does this PR introduce backward-incompatible changes *NOT* related to on-disk data structure and/or over-the-wire protocol?** (If no, continue to question 11.)\r\n\r\n    **NO**\r\n\r\n11. **Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?**\r\n\r\n    **NO**\r\n\r\n## TODO","created_at":"2019-12-02T21:55:15Z","updated_at":"2019-12-02T21:55:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"fxfactorial","id":3036816,"node_id":"MDQ6VXNlcjMwMzY4MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3036816?v=4","gravatar_id":"","url":"https://api.github.com/users/fxfactorial","html_url":"https://github.com/fxfactorial","followers_url":"https://api.github.com/users/fxfactorial/followers","following_url":"https://api.github.com/users/fxfactorial/following{/other_user}","gists_url":"https://api.github.com/users/fxfactorial/gists{/gist_id}","starred_url":"https://api.github.com/users/fxfactorial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxfactorial/subscriptions","organizations_url":"https://api.github.com/users/fxfactorial/orgs","repos_url":"https://api.github.com/users/fxfactorial/repos","events_url":"https://api.github.com/users/fxfactorial/events{/privacy}","received_events_url":"https://api.github.com/users/fxfactorial/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1933/commits","review_comments_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1933/comments","review_comment_url":"https://api.github.com/repos/harmony-one/harmony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harmony-one/harmony/issues/1933/comments","statuses_url":"https://api.github.com/repos/harmony-one/harmony/statuses/fdf2b936725542c63512da38b0a8d9582f64887c","head":{"label":"janet-harmony:quorum-testing","ref":"quorum-testing","sha":"fdf2b936725542c63512da38b0a8d9582f64887c","user":{"login":"janet-harmony","id":56005637,"node_id":"MDQ6VXNlcjU2MDA1NjM3","avatar_url":"https://avatars3.githubusercontent.com/u/56005637?v=4","gravatar_id":"","url":"https://api.github.com/users/janet-harmony","html_url":"https://github.com/janet-harmony","followers_url":"https://api.github.com/users/janet-harmony/followers","following_url":"https://api.github.com/users/janet-harmony/following{/other_user}","gists_url":"https://api.github.com/users/janet-harmony/gists{/gist_id}","starred_url":"https://api.github.com/users/janet-harmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janet-harmony/subscriptions","organizations_url":"https://api.github.com/users/janet-harmony/orgs","repos_url":"https://api.github.com/users/janet-harmony/repos","events_url":"https://api.github.com/users/janet-harmony/events{/privacy}","received_events_url":"https://api.github.com/users/janet-harmony/received_events","type":"User","site_admin":false},"repo":{"id":222148563,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIxNDg1NjM=","name":"harmony","full_name":"janet-harmony/harmony","private":false,"owner":{"login":"janet-harmony","id":56005637,"node_id":"MDQ6VXNlcjU2MDA1NjM3","avatar_url":"https://avatars3.githubusercontent.com/u/56005637?v=4","gravatar_id":"","url":"https://api.github.com/users/janet-harmony","html_url":"https://github.com/janet-harmony","followers_url":"https://api.github.com/users/janet-harmony/followers","following_url":"https://api.github.com/users/janet-harmony/following{/other_user}","gists_url":"https://api.github.com/users/janet-harmony/gists{/gist_id}","starred_url":"https://api.github.com/users/janet-harmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janet-harmony/subscriptions","organizations_url":"https://api.github.com/users/janet-harmony/orgs","repos_url":"https://api.github.com/users/janet-harmony/repos","events_url":"https://api.github.com/users/janet-harmony/events{/privacy}","received_events_url":"https://api.github.com/users/janet-harmony/received_events","type":"User","site_admin":false},"html_url":"https://github.com/janet-harmony/harmony","description":"The core protocol of harmony","fork":true,"url":"https://api.github.com/repos/janet-harmony/harmony","forks_url":"https://api.github.com/repos/janet-harmony/harmony/forks","keys_url":"https://api.github.com/repos/janet-harmony/harmony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janet-harmony/harmony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janet-harmony/harmony/teams","hooks_url":"https://api.github.com/repos/janet-harmony/harmony/hooks","issue_events_url":"https://api.github.com/repos/janet-harmony/harmony/issues/events{/number}","events_url":"https://api.github.com/repos/janet-harmony/harmony/events","assignees_url":"https://api.github.com/repos/janet-harmony/harmony/assignees{/user}","branches_url":"https://api.github.com/repos/janet-harmony/harmony/branches{/branch}","tags_url":"https://api.github.com/repos/janet-harmony/harmony/tags","blobs_url":"https://api.github.com/repos/janet-harmony/harmony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janet-harmony/harmony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janet-harmony/harmony/git/refs{/sha}","trees_url":"https://api.github.com/repos/janet-harmony/harmony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janet-harmony/harmony/statuses/{sha}","languages_url":"https://api.github.com/repos/janet-harmony/harmony/languages","stargazers_url":"https://api.github.com/repos/janet-harmony/harmony/stargazers","contributors_url":"https://api.github.com/repos/janet-harmony/harmony/contributors","subscribers_url":"https://api.github.com/repos/janet-harmony/harmony/subscribers","subscription_url":"https://api.github.com/repos/janet-harmony/harmony/subscription","commits_url":"https://api.github.com/repos/janet-harmony/harmony/commits{/sha}","git_commits_url":"https://api.github.com/repos/janet-harmony/harmony/git/commits{/sha}","comments_url":"https://api.github.com/repos/janet-harmony/harmony/comments{/number}","issue_comment_url":"https://api.github.com/repos/janet-harmony/harmony/issues/comments{/number}","contents_url":"https://api.github.com/repos/janet-harmony/harmony/contents/{+path}","compare_url":"https://api.github.com/repos/janet-harmony/harmony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janet-harmony/harmony/merges","archive_url":"https://api.github.com/repos/janet-harmony/harmony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janet-harmony/harmony/downloads","issues_url":"https://api.github.com/repos/janet-harmony/harmony/issues{/number}","pulls_url":"https://api.github.com/repos/janet-harmony/harmony/pulls{/number}","milestones_url":"https://api.github.com/repos/janet-harmony/harmony/milestones{/number}","notifications_url":"https://api.github.com/repos/janet-harmony/harmony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janet-harmony/harmony/labels{/name}","releases_url":"https://api.github.com/repos/janet-harmony/harmony/releases{/id}","deployments_url":"https://api.github.com/repos/janet-harmony/harmony/deployments","created_at":"2019-11-16T19:24:59Z","updated_at":"2019-12-02T18:56:29Z","pushed_at":"2019-12-02T21:51:57Z","git_url":"git://github.com/janet-harmony/harmony.git","ssh_url":"git@github.com:janet-harmony/harmony.git","clone_url":"https://github.com/janet-harmony/harmony.git","svn_url":"https://github.com/janet-harmony/harmony","homepage":"https://harmony.one","size":15517,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harmony-one:master","ref":"master","sha":"a8a9f7c95199ccc8b8a7f2b0c641543d4c9b9889","user":{"login":"harmony-one","id":39147399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ3Mzk5","avatar_url":"https://avatars2.githubusercontent.com/u/39147399?v=4","gravatar_id":"","url":"https://api.github.com/users/harmony-one","html_url":"https://github.com/harmony-one","followers_url":"https://api.github.com/users/harmony-one/followers","following_url":"https://api.github.com/users/harmony-one/following{/other_user}","gists_url":"https://api.github.com/users/harmony-one/gists{/gist_id}","starred_url":"https://api.github.com/users/harmony-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmony-one/subscriptions","organizations_url":"https://api.github.com/users/harmony-one/orgs","repos_url":"https://api.github.com/users/harmony-one/repos","events_url":"https://api.github.com/users/harmony-one/events{/privacy}","received_events_url":"https://api.github.com/users/harmony-one/received_events","type":"Organization","site_admin":false},"repo":{"id":134344706,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzNDQ3MDY=","name":"harmony","full_name":"harmony-one/harmony","private":false,"owner":{"login":"harmony-one","id":39147399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ3Mzk5","avatar_url":"https://avatars2.githubusercontent.com/u/39147399?v=4","gravatar_id":"","url":"https://api.github.com/users/harmony-one","html_url":"https://github.com/harmony-one","followers_url":"https://api.github.com/users/harmony-one/followers","following_url":"https://api.github.com/users/harmony-one/following{/other_user}","gists_url":"https://api.github.com/users/harmony-one/gists{/gist_id}","starred_url":"https://api.github.com/users/harmony-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmony-one/subscriptions","organizations_url":"https://api.github.com/users/harmony-one/orgs","repos_url":"https://api.github.com/users/harmony-one/repos","events_url":"https://api.github.com/users/harmony-one/events{/privacy}","received_events_url":"https://api.github.com/users/harmony-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/harmony-one/harmony","description":"The core protocol of harmony","fork":false,"url":"https://api.github.com/repos/harmony-one/harmony","forks_url":"https://api.github.com/repos/harmony-one/harmony/forks","keys_url":"https://api.github.com/repos/harmony-one/harmony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harmony-one/harmony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harmony-one/harmony/teams","hooks_url":"https://api.github.com/repos/harmony-one/harmony/hooks","issue_events_url":"https://api.github.com/repos/harmony-one/harmony/issues/events{/number}","events_url":"https://api.github.com/repos/harmony-one/harmony/events","assignees_url":"https://api.github.com/repos/harmony-one/harmony/assignees{/user}","branches_url":"https://api.github.com/repos/harmony-one/harmony/branches{/branch}","tags_url":"https://api.github.com/repos/harmony-one/harmony/tags","blobs_url":"https://api.github.com/repos/harmony-one/harmony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harmony-one/harmony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harmony-one/harmony/git/refs{/sha}","trees_url":"https://api.github.com/repos/harmony-one/harmony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harmony-one/harmony/statuses/{sha}","languages_url":"https://api.github.com/repos/harmony-one/harmony/languages","stargazers_url":"https://api.github.com/repos/harmony-one/harmony/stargazers","contributors_url":"https://api.github.com/repos/harmony-one/harmony/contributors","subscribers_url":"https://api.github.com/repos/harmony-one/harmony/subscribers","subscription_url":"https://api.github.com/repos/harmony-one/harmony/subscription","commits_url":"https://api.github.com/repos/harmony-one/harmony/commits{/sha}","git_commits_url":"https://api.github.com/repos/harmony-one/harmony/git/commits{/sha}","comments_url":"https://api.github.com/repos/harmony-one/harmony/comments{/number}","issue_comment_url":"https://api.github.com/repos/harmony-one/harmony/issues/comments{/number}","contents_url":"https://api.github.com/repos/harmony-one/harmony/contents/{+path}","compare_url":"https://api.github.com/repos/harmony-one/harmony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harmony-one/harmony/merges","archive_url":"https://api.github.com/repos/harmony-one/harmony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harmony-one/harmony/downloads","issues_url":"https://api.github.com/repos/harmony-one/harmony/issues{/number}","pulls_url":"https://api.github.com/repos/harmony-one/harmony/pulls{/number}","milestones_url":"https://api.github.com/repos/harmony-one/harmony/milestones{/number}","notifications_url":"https://api.github.com/repos/harmony-one/harmony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harmony-one/harmony/labels{/name}","releases_url":"https://api.github.com/repos/harmony-one/harmony/releases{/id}","deployments_url":"https://api.github.com/repos/harmony-one/harmony/deployments","created_at":"2018-05-22T01:37:50Z","updated_at":"2019-12-02T17:43:07Z","pushed_at":"2019-12-02T21:35:01Z","git_url":"git://github.com/harmony-one/harmony.git","ssh_url":"git@github.com:harmony-one/harmony.git","clone_url":"https://github.com/harmony-one/harmony.git","svn_url":"https://github.com/harmony-one/harmony","homepage":"https://harmony.one","size":15524,"stargazers_count":246,"watchers_count":246,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":192,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":76,"open_issues":192,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1933"},"html":{"href":"https://github.com/harmony-one/harmony/pull/1933"},"issue":{"href":"https://api.github.com/repos/harmony-one/harmony/issues/1933"},"comments":{"href":"https://api.github.com/repos/harmony-one/harmony/issues/1933/comments"},"review_comments":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1933/comments"},"review_comment":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1933/commits"},"statuses":{"href":"https://api.github.com/repos/harmony-one/harmony/statuses/fdf2b936725542c63512da38b0a8d9582f64887c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":174,"deletions":46,"changed_files":1}}
other: {"actor":{"display_login":"janet-harmony"}}