payload: {"action":"created","issue":{"url":"https://api.github.com/repos/thomasp85/grid/issues/14","repository_url":"https://api.github.com/repos/thomasp85/grid","labels_url":"https://api.github.com/repos/thomasp85/grid/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/thomasp85/grid/issues/14/comments","events_url":"https://api.github.com/repos/thomasp85/grid/issues/14/events","html_url":"https://github.com/thomasp85/grid/issues/14","id":432431155,"node_id":"MDU6SXNzdWU0MzI0MzExNTU=","number":14,"title":"Issues with new unit implementation","user":{"login":"thomasp85","id":1775316,"node_id":"MDQ6VXNlcjE3NzUzMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1775316?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasp85","html_url":"https://github.com/thomasp85","followers_url":"https://api.github.com/users/thomasp85/followers","following_url":"https://api.github.com/users/thomasp85/following{/other_user}","gists_url":"https://api.github.com/users/thomasp85/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasp85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasp85/subscriptions","organizations_url":"https://api.github.com/users/thomasp85/orgs","repos_url":"https://api.github.com/users/thomasp85/repos","events_url":"https://api.github.com/users/thomasp85/events{/privacy}","received_events_url":"https://api.github.com/users/thomasp85/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":63,"created_at":"2019-04-12T07:44:17Z","updated_at":"2019-12-12T21:42:42Z","closed_at":null,"author_association":"OWNER","body":"- [ ] 1)\r\n```\r\n* installing *source* package ‘augmentedRCBD’ ...\r\n...\r\n** byte-compile and prepare package for lazy loading\r\nError in get(x, envir = ns, inherits = FALSE) :\r\n object 'unit.list' not found\r\nError: unable to load R code in package ‘augmentedRCBD’\r\n```\r\nwhich I presume should be using the generic unit().\r\n\r\nThe problem is the resize_heights() function, which plays silly games to try to perform a unit subset assignment.  I think that this might be fixed by just relying on grid's unit subset assignment, but I need to test on R with the new-unit patch applied.\r\n\r\n- [ ] 2)\r\n\r\nPackages Gmisc ggfittext ggrepel ggstatplot: check class() assuming length 1, a bug in those packages.  We reported Gmisc: I will leave the others until this is live.\r\n\r\n- [x] 3)\r\n```\r\nVECTOR_ELT() can only be applied to a 'list', not a 'double'\r\n```\r\nin many packages:\r\nBAS CINNA DescribeDisplay EMMIXmfa GGally ICtest LDheatmap\r\nPPforest SHELF StratigrapheR airGR auditor codebook  ggmcmc lemon\r\nnzelect qualvar randomForestExplainer rrr specmine staRdom statVisual tsfeatures userfriendlyscience\r\n\r\nGGally and codebook give some context:\r\n```\r\nError in grid.Call.graphics(C_setviewport, vp, TRUE): VECTOR_ELT() can only be applied to a 'list', not a 'double'\r\n```\r\nas before.\r\n\r\n- [x] 4)\r\n```\r\n (list) object cannot be coerced to type 'double'\r\n```\r\nfrom unit() in ggpol.\r\n\r\n- [x] 5)\r\n```\r\nREAL() can only be applied to a 'numeric', not a 'integer'\r\n```\r\nfrom Ops.units in IntNMF NMF SCROPIUS diceR iTOP pheatmap, seemingly all from NMF.\r\n\r\n- [x] 6)\r\n```\r\n`heatmap_width` and `width` should not all be the absolute units.\r\n```\r\nfrom CNVScope armada countToFPKM eclust wilson\r\n\r\n- [x] 7)\r\n```\r\nold version of unit class is no longer allowed\r\n```\r\nfrom fewer after reinstallation - MTLR SpatialBall firebehavioR foreSIGHT superheat xpose .  Some say from is.unit().\r\n\r\n- [ ] 8)\r\n```\r\nError in mm2pixels(convert(u, \"mm\")) : Unit must be in millimeters\r\n```\r\nfrom MendelianRandomization Miso PCRedux PPQplan Plasmidprofiler otsad autoplotly frailtyEM getTBinR gprofiler2 heatmaply manhattanly\r\nneatmaps otsad personalized plotly rabhit trelliscopejs wilson\r\n\r\n- [x] 9)\r\nParamHelpers segfaults, in its obfuscated tests.\r\n\r\n- [x] 10)\r\ncowplot has a Floating point exception in shared_legends.Rmd.\r\n\r\n- [ ] 11)\r\n```\r\nError in FUN(X[[i]], ...) : object is not coercible to a unit\r\nCalls: blobbogram -> Summary.unit -> unlist -> lapply -> FUN\r\n```\r\nfrom gemtc.\r\n\r\n- [x] 12)\r\n```\r\nError in unit(3, \"grobwidth\", data = seg_plot_yaxis_grobs[[longest_segment]]) :\r\n data must be either NULL, have length 1, or match the length of the final unit vector\r\nCalls: plot_gene_map -> unit\r\n```\r\nfrom genoPlotR.\r\n\r\n- [ ] 13)\r\n```\r\nError in grid::unit(c(0, 0, 0, marginLength), marginUnit) : Invalid unit\r\nCalls: ggMarginal ... addMainTheme -> <Anonymous> -> find_args -> mget -> <Anonymous>\r\n```\r\nfrom ggExtra\r\n\r\n- [ ] 14)\r\n```\r\nError in `attributes<-`(x, attr) :\r\n 'names' attribute [2] must be the same length as the vector [1]\r\nCalls: <Anonymous> ... gtable_add_rows -> insert.unit -> unit.c -> [ -> [.unit\r\n```\r\nfrom ggraph\r\n\r\n- [ ] 15)\r\nError in grid::unit(c(0, 0, 0, marginLength), marginUnit) : Invalid unit\r\nCalls: <Anonymous> ... addMainTheme -> <Anonymous> -> find_args -> mget -> <Anonymous>\r\n\r\nfrom ggstatsplot\r\n\r\n- [ ] 16)\r\n```\r\n Error in unit(x, unit) : Invalid unit\r\n Calls: grid.export ... as.animUnit -> as.animUnit.numeric -> animUnit -> is.unit -> unit\r\n```\r\nfrom gridSVG, which I expect is known.\r\n\r\n- [ ] 17)\r\n```\r\nError in (function (cl, name, valueClass)  :\r\n c(\"assignment of an object of class “simpleUnit” is not valid for @‘mar’ in an object of class “hexVP”; is(value, \\\"unit\\\") is not TRUE\", \"assignment of an object of class “unit” is not valid for @‘mar’ in an object of class “hexVP”; is(value, \\\"unit\\\") is not TRUE\", \"assignment of an object of class “unit_v2” is not valid for @‘mar’ in an object of class “hexVP”; is(value, \\\"unit\\\") is not TRUE\")\r\nCalls: plot -> plot -> .local -> hexViewport -> <Anonymous>\r\n```\r\nfrom hexbin lidR survey\r\n\r\n- [ ] 18)\r\n```\r\nError in unit(as.numeric(arrow$length) * mag, attr(arrow$length, \"unit\")) :\r\n Invalid unit\r\nCalls: <Anonymous> ... <Anonymous> -> .fun -> do.call -> <Anonymous> -> f -> unit\r\n```\r\nfrom metR tmap\r\n\r\n- [ ] 19)\r\n```\r\nWarning in check_units(width, unit) :\r\n Multiple grid::units detected. Casting all to 'unit' argument ('mm').\r\nWarning in check_units(height, unit) :\r\n Multiple grid::units detected. Casting all to 'unit' argument ('mm').\r\n>\r\n> # With no panels, printing shows the layout\r\n> figure1\r\nError in grid::unit(., saved_unit) : Invalid unit\r\nCalls: <Anonymous> ... eval -> _fseq -> freduce -> <Anonymous> -> <Anonymous>\r\n```\r\nfrom multipanelfigure\r\n\r\n- [ ] 20)\r\n```\r\nError in sum(g_tab$widths[[5]], g_tab$widths[[6]], g_tab$widths[[7]]) :\r\n invalid 'type' (list) of argument\r\nCalls: thresh_forest\r\n```\r\nin nathresh\r\n\r\n- [ ] 21)\r\n```\r\n Error: isTRUE(all.equal(getGrob(result, \"MAP\"), truth)) is not TRUE\r\n```\r\nin portfolio\r\n\r\n- [ ] 22)\r\n```\r\nError in grid::unit(c(0, 0, 0, marginLength), marginUnit) : Invalid unit\r\nCalls: scatterplot ... addMainTheme -> <Anonymous> -> find_args -> mget -> <Anonymous>\r\n```\r\nin sensitivity\r\n\r\n- [ ] 23)\r\n```\r\nError in matchData[[i]] * amount[i] :\r\n non-numeric argument to binary operator\r\nCalls: plotSelected ... <Anonymous> -> do.call -> sisalTable -> Summary.unit\r\n```\r\nin sisal and stripless\r\n"},"comment":{"url":"https://api.github.com/repos/thomasp85/grid/issues/comments/565199988","html_url":"https://github.com/thomasp85/grid/issues/14#issuecomment-565199988","issue_url":"https://api.github.com/repos/thomasp85/grid/issues/14","id":565199988,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NTE5OTk4OA==","user":{"login":"pmur002","id":2044052,"node_id":"MDQ6VXNlcjIwNDQwNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2044052?v=4","gravatar_id":"","url":"https://api.github.com/users/pmur002","html_url":"https://github.com/pmur002","followers_url":"https://api.github.com/users/pmur002/followers","following_url":"https://api.github.com/users/pmur002/following{/other_user}","gists_url":"https://api.github.com/users/pmur002/gists{/gist_id}","starred_url":"https://api.github.com/users/pmur002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmur002/subscriptions","organizations_url":"https://api.github.com/users/pmur002/orgs","repos_url":"https://api.github.com/users/pmur002/repos","events_url":"https://api.github.com/users/pmur002/events{/privacy}","received_events_url":"https://api.github.com/users/pmur002/received_events","type":"User","site_admin":false},"created_at":"2019-12-12T21:42:41Z","updated_at":"2019-12-12T21:42:41Z","author_association":"COLLABORATOR","body":"Signs of progress in latest revdepcheck.  Here's the error list ...\r\n```\r\nanimint2 ... ERROR\r\nbomrang ... ERROR\r\ncowplot ... ERROR\r\ngg.gap ... ERROR\r\nggpol ... ERROR\r\nggraph ... ERROR\r\nlemon ... ERROR\r\nmultipanelfigure ... ERROR\r\nParamHelpers ... ERROR\r\npartykit ... ERROR\r\nportfolio ... ERROR\r\nsurveillance ... ERROR\r\ntmap ... ERROR\r\nufs ... ERROR\r\nvcd ... ERROR\r\nwilson ... ERROR\r\n```\r\nA couple of new ones in there, plus a couple that I thought we had fixed, so I need to look closer. \r\n\r\nBut still, progress!\r\n"}}
other: {"actor":{"display_login":"pmur002"}}