payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/library-go/pulls/comments/279689531","pull_request_review_id":232086713,"id":279689531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTY4OTUzMQ==","diff_hunk":"@@ -701,10 +701,12 @@ func getInstallerPodImageFromEnv() string {\n \treturn os.Getenv(\"OPERATOR_IMAGE\")\n }\n \n-// ensureCerts makes sure that our certs are ready or it will return an error to trigger a requeue so that we try again\n-func (c InstallerController) ensureCerts() error {\n-\tmissing := []string{}\n-\tfor _, cm := range c.certConfigMaps {\n+// ensureRequiredResourcesExist makes sure that all non-optional resources are ready or it will return an error to trigger a requeue so that we try again.\n+func (c InstallerController) ensureRequiredResourcesExist() error {\n+\tmissingSecrets := []string{}\n+\tmissingConfigs := []string{}\n+\n+\tfor _, cm := range append(c.certConfigMaps, c.configMaps...) {","path":"pkg/operator/staticpod/controller/installer/installer_controller.go","position":13,"original_position":13,"commit_id":"d2d5a2af9361b56b25ff9bb3d4f2fe5bb160e0b0","original_commit_id":"d2d5a2af9361b56b25ff9bb3d4f2fe5bb160e0b0","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"bad style, append mutate the c.certConfigMaps array.","created_at":"2019-04-30T10:03:54Z","updated_at":"2019-04-30T10:06:10Z","html_url":"https://github.com/openshift/library-go/pull/376#discussion_r279689531","pull_request_url":"https://api.github.com/repos/openshift/library-go/pulls/376","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/library-go/pulls/comments/279689531"},"html":{"href":"https://github.com/openshift/library-go/pull/376#discussion_r279689531"},"pull_request":{"href":"https://api.github.com/repos/openshift/library-go/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/library-go/pulls/376","id":274648429,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NjQ4NDI5","html_url":"https://github.com/openshift/library-go/pull/376","diff_url":"https://github.com/openshift/library-go/pull/376.diff","patch_url":"https://github.com/openshift/library-go/pull/376.patch","issue_url":"https://api.github.com/repos/openshift/library-go/issues/376","number":376,"state":"open","locked":false,"title":"installer: ensure the etcd-client secret is available","user":{"login":"mfojtik","id":44136,"node_id":"MDQ6VXNlcjQ0MTM2","avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"A high rate of failed installer pods on revision `1` observed via CI. Caused by missing `etcd-client-1` secret which is part of the \"required\" secrets.\r\n\r\n```\r\nI0429 20:43:28.093507       1 cmd.go:246] Creating target resource directory \"/etc/kubernetes/static-pod-resources/kube-apiserver-pod-1\" ...\r\nI0429 20:43:28.093861       1 cmd.go:171] Creating target resource directory \"/etc/kubernetes/static-pod-resources/kube-apiserver-pod-1\" ...\r\nI0429 20:43:28.093951       1 cmd.go:179] Getting secrets ...\r\nI0429 20:43:28.096810       1 copy.go:24] Failed to get secret openshift-kube-apiserver/etcd-client-1: secrets \"etcd-client-1\" not found\r\nF0429 20:43:28.101133       1 cmd.go:89] failed to copy: secrets \"etcd-client-1\" not found\r\n```\r\n\r\nWe already have mechanism to ensure some (cert) required secrets and configs are available at the time we run the pod, this add all required secrets and configs to the check as the installer pod will always fail when those does not exists and we should rather wait in the operator than creating and failing the installer pod?\r\n\r\nAlso improving the error message to see the namespace (not always obvious in tests).\r\n\r\nProof: https://github.com/openshift/cluster-kube-apiserver-operator/pull/446\r\n\r\n/cc @deads2k \r\n/cc @damemi ","created_at":"2019-04-30T09:01:17Z","updated_at":"2019-04-30T10:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b93c262709cf3bef20331b53799a2b2ff9082aa","assignee":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"damemi","id":1839101,"node_id":"MDQ6VXNlcjE4MzkxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839101?v=4","gravatar_id":"","url":"https://api.github.com/users/damemi","html_url":"https://github.com/damemi","followers_url":"https://api.github.com/users/damemi/followers","following_url":"https://api.github.com/users/damemi/following{/other_user}","gists_url":"https://api.github.com/users/damemi/gists{/gist_id}","starred_url":"https://api.github.com/users/damemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damemi/subscriptions","organizations_url":"https://api.github.com/users/damemi/orgs","repos_url":"https://api.github.com/users/damemi/repos","events_url":"https://api.github.com/users/damemi/events{/privacy}","received_events_url":"https://api.github.com/users/damemi/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":930107204,"node_id":"MDU6TGFiZWw5MzAxMDcyMDQ=","url":"https://api.github.com/repos/openshift/library-go/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":930106681,"node_id":"MDU6TGFiZWw5MzAxMDY2ODE=","url":"https://api.github.com/repos/openshift/library-go/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/library-go/pulls/376/commits","review_comments_url":"https://api.github.com/repos/openshift/library-go/pulls/376/comments","review_comment_url":"https://api.github.com/repos/openshift/library-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/library-go/issues/376/comments","statuses_url":"https://api.github.com/repos/openshift/library-go/statuses/d2d5a2af9361b56b25ff9bb3d4f2fe5bb160e0b0","head":{"label":"mfojtik:ensure-etcd-client","ref":"ensure-etcd-client","sha":"d2d5a2af9361b56b25ff9bb3d4f2fe5bb160e0b0","user":{"login":"mfojtik","id":44136,"node_id":"MDQ6VXNlcjQ0MTM2","avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":133040210,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNDAyMTA=","name":"library-go","full_name":"mfojtik/library-go","private":false,"owner":{"login":"mfojtik","id":44136,"node_id":"MDQ6VXNlcjQ0MTM2","avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mfojtik/library-go","description":"Helpers for going from apis and clients to useful runtime constructs","fork":true,"url":"https://api.github.com/repos/mfojtik/library-go","forks_url":"https://api.github.com/repos/mfojtik/library-go/forks","keys_url":"https://api.github.com/repos/mfojtik/library-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/library-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/library-go/teams","hooks_url":"https://api.github.com/repos/mfojtik/library-go/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/library-go/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/library-go/events","assignees_url":"https://api.github.com/repos/mfojtik/library-go/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/library-go/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/library-go/tags","blobs_url":"https://api.github.com/repos/mfojtik/library-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/library-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/library-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/library-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/library-go/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/library-go/languages","stargazers_url":"https://api.github.com/repos/mfojtik/library-go/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/library-go/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/library-go/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/library-go/subscription","commits_url":"https://api.github.com/repos/mfojtik/library-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/library-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/library-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/library-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/library-go/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/library-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/library-go/merges","archive_url":"https://api.github.com/repos/mfojtik/library-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/library-go/downloads","issues_url":"https://api.github.com/repos/mfojtik/library-go/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/library-go/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/library-go/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/library-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/library-go/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/library-go/releases{/id}","deployments_url":"https://api.github.com/repos/mfojtik/library-go/deployments","created_at":"2018-05-11T13:01:07Z","updated_at":"2019-04-30T08:51:58Z","pushed_at":"2019-04-30T09:51:58Z","git_url":"git://github.com/mfojtik/library-go.git","ssh_url":"git@github.com:mfojtik/library-go.git","clone_url":"https://github.com/mfojtik/library-go.git","svn_url":"https://github.com/mfojtik/library-go","homepage":null,"size":36075,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d30d2ce056122ec5b5bc0a35056c220103ef7026","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":132917906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MTc5MDY=","name":"library-go","full_name":"openshift/library-go","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/library-go","description":"Helpers for going from apis and clients to useful runtime constructs","fork":false,"url":"https://api.github.com/repos/openshift/library-go","forks_url":"https://api.github.com/repos/openshift/library-go/forks","keys_url":"https://api.github.com/repos/openshift/library-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/library-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/library-go/teams","hooks_url":"https://api.github.com/repos/openshift/library-go/hooks","issue_events_url":"https://api.github.com/repos/openshift/library-go/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/library-go/events","assignees_url":"https://api.github.com/repos/openshift/library-go/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/library-go/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/library-go/tags","blobs_url":"https://api.github.com/repos/openshift/library-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/library-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/library-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/library-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/library-go/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/library-go/languages","stargazers_url":"https://api.github.com/repos/openshift/library-go/stargazers","contributors_url":"https://api.github.com/repos/openshift/library-go/contributors","subscribers_url":"https://api.github.com/repos/openshift/library-go/subscribers","subscription_url":"https://api.github.com/repos/openshift/library-go/subscription","commits_url":"https://api.github.com/repos/openshift/library-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/library-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/library-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/library-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/library-go/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/library-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/library-go/merges","archive_url":"https://api.github.com/repos/openshift/library-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/library-go/downloads","issues_url":"https://api.github.com/repos/openshift/library-go/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/library-go/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/library-go/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/library-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/library-go/labels{/name}","releases_url":"https://api.github.com/repos/openshift/library-go/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/library-go/deployments","created_at":"2018-05-10T15:14:38Z","updated_at":"2019-04-29T15:22:22Z","pushed_at":"2019-04-30T09:51:59Z","git_url":"git://github.com/openshift/library-go.git","ssh_url":"git@github.com:openshift/library-go.git","clone_url":"https://github.com/openshift/library-go.git","svn_url":"https://github.com/openshift/library-go","homepage":null,"size":37114,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":20,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/library-go/pulls/376"},"html":{"href":"https://github.com/openshift/library-go/pull/376"},"issue":{"href":"https://api.github.com/repos/openshift/library-go/issues/376"},"comments":{"href":"https://api.github.com/repos/openshift/library-go/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/library-go/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/library-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/library-go/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/library-go/statuses/d2d5a2af9361b56b25ff9bb3d4f2fe5bb160e0b0"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"sttts"}}