payload: {"action":"created","issue":{"url":"https://api.github.com/repos/cossacklabs/themis/issues/500","repository_url":"https://api.github.com/repos/cossacklabs/themis","labels_url":"https://api.github.com/repos/cossacklabs/themis/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/cossacklabs/themis/issues/500/comments","events_url":"https://api.github.com/repos/cossacklabs/themis/issues/500/events","html_url":"https://github.com/cossacklabs/themis/pull/500","id":469788647,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4OTI4OTM0","number":500,"title":"Fix error handling in key generation","user":{"login":"ilammy","id":1256587,"node_id":"MDQ6VXNlcjEyNTY1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1256587?v=4","gravatar_id":"","url":"https://api.github.com/users/ilammy","html_url":"https://github.com/ilammy","followers_url":"https://api.github.com/users/ilammy/followers","following_url":"https://api.github.com/users/ilammy/following{/other_user}","gists_url":"https://api.github.com/users/ilammy/gists{/gist_id}","starred_url":"https://api.github.com/users/ilammy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilammy/subscriptions","organizations_url":"https://api.github.com/users/ilammy/orgs","repos_url":"https://api.github.com/users/ilammy/repos","events_url":"https://api.github.com/users/ilammy/events{/privacy}","received_events_url":"https://api.github.com/users/ilammy/received_events","type":"User","site_admin":false},"labels":[{"id":220153287,"node_id":"MDU6TGFiZWwyMjAxNTMyODc=","url":"https://api.github.com/repos/cossacklabs/themis/labels/core","name":"core","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-18T14:03:30Z","updated_at":"2019-07-18T15:52:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cossacklabs/themis/pulls/500","html_url":"https://github.com/cossacklabs/themis/pull/500","diff_url":"https://github.com/cossacklabs/themis/pull/500.diff","patch_url":"https://github.com/cossacklabs/themis/pull/500.patch"},"body":"Note that EC key generation has incorrect return value when public key export fails (should be `res2` instead of `res`). This may cause key generation function to return success if private key has been exported successfully, but public key has not. The user will then proceed with uninitialized public key buffer and will not be amused afterwards.\r\n\r\nChange variable names to be more distinct so that the difference is more obvious and add some empty lines so that the code is easier to read.\r\n\r\nAdd a test which makes sure we have correct behavior when one of the keys fail. Using NULL values is the easiest way to trigger this behavior.\r\n\r\nThanks to @vixentael for finding this! 🔍 🕵️‍♀️ "},"comment":{"url":"https://api.github.com/repos/cossacklabs/themis/issues/comments/512875770","html_url":"https://github.com/cossacklabs/themis/pull/500#issuecomment-512875770","issue_url":"https://api.github.com/repos/cossacklabs/themis/issues/500","id":512875770,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMjg3NTc3MA==","user":{"login":"ilammy","id":1256587,"node_id":"MDQ6VXNlcjEyNTY1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1256587?v=4","gravatar_id":"","url":"https://api.github.com/users/ilammy","html_url":"https://github.com/ilammy","followers_url":"https://api.github.com/users/ilammy/followers","following_url":"https://api.github.com/users/ilammy/following{/other_user}","gists_url":"https://api.github.com/users/ilammy/gists{/gist_id}","starred_url":"https://api.github.com/users/ilammy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilammy/subscriptions","organizations_url":"https://api.github.com/users/ilammy/orgs","repos_url":"https://api.github.com/users/ilammy/repos","events_url":"https://api.github.com/users/ilammy/events{/privacy}","received_events_url":"https://api.github.com/users/ilammy/received_events","type":"User","site_admin":false},"created_at":"2019-07-18T15:52:24Z","updated_at":"2019-07-18T15:52:24Z","author_association":"CONTRIBUTOR","body":"@secumod,\r\n\r\n> was this formatted with clang-format?\r\n\r\nYes—aside from empty lines. IIRC, it can insert them in simple cases (like between functions), but more meaningful split still requires human intervention."}}
other: {"actor":{"display_login":"ilammy"}}