payload: {"action":"opened","number":47,"pull_request":{"url":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/47","id":262662301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNjYyMzAx","html_url":"https://github.com/browserpass/browserpass-extension/pull/47","diff_url":"https://github.com/browserpass/browserpass-extension/pull/47.diff","patch_url":"https://github.com/browserpass/browserpass-extension/pull/47.patch","issue_url":"https://api.github.com/repos/browserpass/browserpass-extension/issues/47","number":47,"state":"open","locked":false,"title":"Include specificity in popup ordering algorithm","user":{"login":"maximbaz","id":1177900,"node_id":"MDQ6VXNlcjExNzc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1177900?v=4","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"body":"When we are showing results for a single domain, it makes sense to consider specificity and show results for subdomains on top.\r\n\r\nFor example, when you open `https://aur.archlinux.org` for the very first time, a popup should show `aur.archlinux.org` above `archlinux.org`, not below.\r\n\r\nI'm intentionally not including specificity in consideration when the popup is *not* filtered for a single domain, because the order doesn't look self-explanatory at all (and also for performance reasons).\r\n\r\nIt was also highly requested in https://github.com/browserpass/browserpass/issues/264","created_at":"2019-03-19T23:00:41Z","updated_at":"2019-03-19T23:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/47/commits","review_comments_url":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/47/comments","review_comment_url":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/browserpass/browserpass-extension/issues/47/comments","statuses_url":"https://api.github.com/repos/browserpass/browserpass-extension/statuses/26e299634e5f189ca646e03a5be00ed02f037619","head":{"label":"maximbaz:popup-sort-specificity","ref":"popup-sort-specificity","sha":"26e299634e5f189ca646e03a5be00ed02f037619","user":{"login":"maximbaz","id":1177900,"node_id":"MDQ6VXNlcjExNzc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1177900?v=4","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"repo":{"id":128798078,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3OTgwNzg=","name":"browserpass-extension","full_name":"maximbaz/browserpass-extension","private":false,"owner":{"login":"maximbaz","id":1177900,"node_id":"MDQ6VXNlcjExNzc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1177900?v=4","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maximbaz/browserpass-extension","description":"Browserpass web extension","fork":true,"url":"https://api.github.com/repos/maximbaz/browserpass-extension","forks_url":"https://api.github.com/repos/maximbaz/browserpass-extension/forks","keys_url":"https://api.github.com/repos/maximbaz/browserpass-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximbaz/browserpass-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximbaz/browserpass-extension/teams","hooks_url":"https://api.github.com/repos/maximbaz/browserpass-extension/hooks","issue_events_url":"https://api.github.com/repos/maximbaz/browserpass-extension/issues/events{/number}","events_url":"https://api.github.com/repos/maximbaz/browserpass-extension/events","assignees_url":"https://api.github.com/repos/maximbaz/browserpass-extension/assignees{/user}","branches_url":"https://api.github.com/repos/maximbaz/browserpass-extension/branches{/branch}","tags_url":"https://api.github.com/repos/maximbaz/browserpass-extension/tags","blobs_url":"https://api.github.com/repos/maximbaz/browserpass-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximbaz/browserpass-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximbaz/browserpass-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximbaz/browserpass-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximbaz/browserpass-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/maximbaz/browserpass-extension/languages","stargazers_url":"https://api.github.com/repos/maximbaz/browserpass-extension/stargazers","contributors_url":"https://api.github.com/repos/maximbaz/browserpass-extension/contributors","subscribers_url":"https://api.github.com/repos/maximbaz/browserpass-extension/subscribers","subscription_url":"https://api.github.com/repos/maximbaz/browserpass-extension/subscription","commits_url":"https://api.github.com/repos/maximbaz/browserpass-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximbaz/browserpass-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximbaz/browserpass-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximbaz/browserpass-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximbaz/browserpass-extension/contents/{+path}","compare_url":"https://api.github.com/repos/maximbaz/browserpass-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximbaz/browserpass-extension/merges","archive_url":"https://api.github.com/repos/maximbaz/browserpass-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximbaz/browserpass-extension/downloads","issues_url":"https://api.github.com/repos/maximbaz/browserpass-extension/issues{/number}","pulls_url":"https://api.github.com/repos/maximbaz/browserpass-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/maximbaz/browserpass-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/maximbaz/browserpass-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximbaz/browserpass-extension/labels{/name}","releases_url":"https://api.github.com/repos/maximbaz/browserpass-extension/releases{/id}","deployments_url":"https://api.github.com/repos/maximbaz/browserpass-extension/deployments","created_at":"2018-04-09T16:02:37Z","updated_at":"2018-04-09T16:02:40Z","pushed_at":"2019-03-19T22:50:56Z","git_url":"git://github.com/maximbaz/browserpass-extension.git","ssh_url":"git@github.com:maximbaz/browserpass-extension.git","clone_url":"https://github.com/maximbaz/browserpass-extension.git","svn_url":"https://github.com/maximbaz/browserpass-extension","homepage":null,"size":198,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"browserpass:master","ref":"master","sha":"59d215d38930214fc586a9a805706363b37f8e8c","user":{"login":"browserpass","id":38192353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTkyMzUz","avatar_url":"https://avatars3.githubusercontent.com/u/38192353?v=4","gravatar_id":"","url":"https://api.github.com/users/browserpass","html_url":"https://github.com/browserpass","followers_url":"https://api.github.com/users/browserpass/followers","following_url":"https://api.github.com/users/browserpass/following{/other_user}","gists_url":"https://api.github.com/users/browserpass/gists{/gist_id}","starred_url":"https://api.github.com/users/browserpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browserpass/subscriptions","organizations_url":"https://api.github.com/users/browserpass/orgs","repos_url":"https://api.github.com/users/browserpass/repos","events_url":"https://api.github.com/users/browserpass/events{/privacy}","received_events_url":"https://api.github.com/users/browserpass/received_events","type":"Organization","site_admin":false},"repo":{"id":128682851,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2ODI4NTE=","name":"browserpass-extension","full_name":"browserpass/browserpass-extension","private":false,"owner":{"login":"browserpass","id":38192353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTkyMzUz","avatar_url":"https://avatars3.githubusercontent.com/u/38192353?v=4","gravatar_id":"","url":"https://api.github.com/users/browserpass","html_url":"https://github.com/browserpass","followers_url":"https://api.github.com/users/browserpass/followers","following_url":"https://api.github.com/users/browserpass/following{/other_user}","gists_url":"https://api.github.com/users/browserpass/gists{/gist_id}","starred_url":"https://api.github.com/users/browserpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browserpass/subscriptions","organizations_url":"https://api.github.com/users/browserpass/orgs","repos_url":"https://api.github.com/users/browserpass/repos","events_url":"https://api.github.com/users/browserpass/events{/privacy}","received_events_url":"https://api.github.com/users/browserpass/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/browserpass/browserpass-extension","description":"Browserpass web extension","fork":false,"url":"https://api.github.com/repos/browserpass/browserpass-extension","forks_url":"https://api.github.com/repos/browserpass/browserpass-extension/forks","keys_url":"https://api.github.com/repos/browserpass/browserpass-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/browserpass/browserpass-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/browserpass/browserpass-extension/teams","hooks_url":"https://api.github.com/repos/browserpass/browserpass-extension/hooks","issue_events_url":"https://api.github.com/repos/browserpass/browserpass-extension/issues/events{/number}","events_url":"https://api.github.com/repos/browserpass/browserpass-extension/events","assignees_url":"https://api.github.com/repos/browserpass/browserpass-extension/assignees{/user}","branches_url":"https://api.github.com/repos/browserpass/browserpass-extension/branches{/branch}","tags_url":"https://api.github.com/repos/browserpass/browserpass-extension/tags","blobs_url":"https://api.github.com/repos/browserpass/browserpass-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/browserpass/browserpass-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/browserpass/browserpass-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/browserpass/browserpass-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/browserpass/browserpass-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/browserpass/browserpass-extension/languages","stargazers_url":"https://api.github.com/repos/browserpass/browserpass-extension/stargazers","contributors_url":"https://api.github.com/repos/browserpass/browserpass-extension/contributors","subscribers_url":"https://api.github.com/repos/browserpass/browserpass-extension/subscribers","subscription_url":"https://api.github.com/repos/browserpass/browserpass-extension/subscription","commits_url":"https://api.github.com/repos/browserpass/browserpass-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/browserpass/browserpass-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/browserpass/browserpass-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/browserpass/browserpass-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/browserpass/browserpass-extension/contents/{+path}","compare_url":"https://api.github.com/repos/browserpass/browserpass-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/browserpass/browserpass-extension/merges","archive_url":"https://api.github.com/repos/browserpass/browserpass-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/browserpass/browserpass-extension/downloads","issues_url":"https://api.github.com/repos/browserpass/browserpass-extension/issues{/number}","pulls_url":"https://api.github.com/repos/browserpass/browserpass-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/browserpass/browserpass-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/browserpass/browserpass-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/browserpass/browserpass-extension/labels{/name}","releases_url":"https://api.github.com/repos/browserpass/browserpass-extension/releases{/id}","deployments_url":"https://api.github.com/repos/browserpass/browserpass-extension/deployments","created_at":"2018-04-08T21:20:20Z","updated_at":"2019-03-19T22:20:53Z","pushed_at":"2019-03-19T22:20:52Z","git_url":"git://github.com/browserpass/browserpass-extension.git","ssh_url":"git@github.com:browserpass/browserpass-extension.git","clone_url":"https://github.com/browserpass/browserpass-extension.git","svn_url":"https://github.com/browserpass/browserpass-extension","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/47"},"html":{"href":"https://github.com/browserpass/browserpass-extension/pull/47"},"issue":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/issues/47"},"comments":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/browserpass/browserpass-extension/statuses/26e299634e5f189ca646e03a5be00ed02f037619"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":12,"deletions":3,"changed_files":1}}
other: {"actor":{"display_login":"maximbaz"}}