payload: {"action":"created","issue":{"url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator/issues/51","repository_url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator","labels_url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator/issues/51/comments","events_url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator/issues/51/events","html_url":"https://github.com/ThomasTJdev/nim_websitecreator/issues/51","id":411086207,"node_id":"MDU6SXNzdWU0MTEwODYyMDc=","number":51,"title":"## Private checklist for PR #39","user":{"login":"ThomasTJdev","id":1888696,"node_id":"MDQ6VXNlcjE4ODg2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1888696?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasTJdev","html_url":"https://github.com/ThomasTJdev","followers_url":"https://api.github.com/users/ThomasTJdev/followers","following_url":"https://api.github.com/users/ThomasTJdev/following{/other_user}","gists_url":"https://api.github.com/users/ThomasTJdev/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasTJdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasTJdev/subscriptions","organizations_url":"https://api.github.com/users/ThomasTJdev/orgs","repos_url":"https://api.github.com/users/ThomasTJdev/repos","events_url":"https://api.github.com/users/ThomasTJdev/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasTJdev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ThomasTJdev","id":1888696,"node_id":"MDQ6VXNlcjE4ODg2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1888696?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasTJdev","html_url":"https://github.com/ThomasTJdev","followers_url":"https://api.github.com/users/ThomasTJdev/followers","following_url":"https://api.github.com/users/ThomasTJdev/following{/other_user}","gists_url":"https://api.github.com/users/ThomasTJdev/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasTJdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasTJdev/subscriptions","organizations_url":"https://api.github.com/users/ThomasTJdev/orgs","repos_url":"https://api.github.com/users/ThomasTJdev/repos","events_url":"https://api.github.com/users/ThomasTJdev/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasTJdev/received_events","type":"User","site_admin":false},"assignees":[{"login":"ThomasTJdev","id":1888696,"node_id":"MDQ6VXNlcjE4ODg2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1888696?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasTJdev","html_url":"https://github.com/ThomasTJdev","followers_url":"https://api.github.com/users/ThomasTJdev/followers","following_url":"https://api.github.com/users/ThomasTJdev/following{/other_user}","gists_url":"https://api.github.com/users/ThomasTJdev/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasTJdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasTJdev/subscriptions","organizations_url":"https://api.github.com/users/ThomasTJdev/orgs","repos_url":"https://api.github.com/users/ThomasTJdev/repos","events_url":"https://api.github.com/users/ThomasTJdev/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasTJdev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2019-02-16T16:09:31Z","updated_at":"2019-02-22T17:38:10Z","closed_at":null,"author_association":"OWNER","body":"## General\r\n- [x] General UI check\r\n- [x] Files - UI\r\n- [x] Files - Folder (from image)\r\n- [x] Files - Count (#45)\r\n- [x] Plugin - UI\r\n- [x] Plugin - Enable/Disable route\r\n- [x] Docket\r\n- [x] Firejail\r\n- [x] WebP\r\n- [ ] Unsplash **I can't get it to work**\r\n- [x] Postgres \r\n```nim\r\n# Not tested.\r\n# Is \"WITHOUT OIDS\" required? https://www.postgresql.org/docs/9.6/datatype-oid.html\r\n\"Object identifiers (OIDs) are used internally by PostgreSQL as primary keys for various system tables. OIDs are not added to user-created tables, unless WITH OIDS is specified when the table is created, or the default_with_oids configuration variable is enabled. \"\r\n```\r\n- [x] DevOps folder\r\n- [x] Datetime2human integration\r\n- [x] Online config\r\n- [x] Admin panel\r\n- [x] Honeypot\r\n- [x] 2FA\r\n- [x] Password generater (random)\r\n- [x] Logs - UI\r\n- [x] Nimble install on a clean system\r\n- [x] Nim latest devel (Error.. hmm.. **Plugin error as mentioned in the comment below, closed**\r\n```nim\r\nNim Compiler Version 0.19.9 [Linux: amd64] - Compiled at 2019-02-16\r\nnimwc_main.nim(115, 5) Error: cannot generate VM code for pluginsPath = [\"/home/user/nim/nim_websitecreator/plugins/contact\"]\r\n```\r\n- [x] Check changelog\r\n\r\n## Other\r\n- [x] Error using Summernote with Bulma (#37)\r\n- [x] Version bump to 5 **What do you think?**\r\n- [ ] History table - purpose? **Well, I added it myself :laughing: Purpose was to keep track on what the users were doing. No purpose at the moment, deletable.**\r\n- [ ] -d:noFields - purpose?\r\n- [x] `nimwc2fa.nim` - is it needed? Can we delete it?\r\n- [ ] TOS\r\n```\r\nCould be expandede? Like https://cxmanager.dk/eula ?\r\nThe font didn't work for me. I changed it to font-family sans-serif.\r\nShouldn't we make it editable? Like the config file. Then the user can specify the details to comply with GDPR.\r\n```\r\n\r\n## Future\r\n- [x] `files.tmpl` should use the files-table instead of walkdir on `files/privat-public`. We can then also show how many times, a file has been downloaded. **Agree with comment below, closed**\r\n- [x] 2FA and pwd flow - **Agree with comment below, closed**\r\n```\r\nWe should first check pwd and email, if they match we should ask for 2FA. Or we can keep the current layout to force the user to think about 2FA on every login.\r\n```\r\n- [ ] Nim's symlink proc cant overwrite existing symlink (#36)\r\n- [ ] Update NimWC.org with information about all the new features :)\r\n\r\n_Originally posted by @ThomasTJdev in https://github.com/ThomasTJdev/nim_websitecreator/pull/39#issuecomment-462368761_"},"comment":{"url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator/issues/comments/466481022","html_url":"https://github.com/ThomasTJdev/nim_websitecreator/issues/51#issuecomment-466481022","issue_url":"https://api.github.com/repos/ThomasTJdev/nim_websitecreator/issues/51","id":466481022,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NjQ4MTAyMg==","user":{"login":"juancarlospaco","id":1189414,"node_id":"MDQ6VXNlcjExODk0MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1189414?v=4","gravatar_id":"","url":"https://api.github.com/users/juancarlospaco","html_url":"https://github.com/juancarlospaco","followers_url":"https://api.github.com/users/juancarlospaco/followers","following_url":"https://api.github.com/users/juancarlospaco/following{/other_user}","gists_url":"https://api.github.com/users/juancarlospaco/gists{/gist_id}","starred_url":"https://api.github.com/users/juancarlospaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juancarlospaco/subscriptions","organizations_url":"https://api.github.com/users/juancarlospaco/orgs","repos_url":"https://api.github.com/users/juancarlospaco/repos","events_url":"https://api.github.com/users/juancarlospaco/events{/privacy}","received_events_url":"https://api.github.com/users/juancarlospaco/received_events","type":"User","site_admin":false},"created_at":"2019-02-22T17:38:10Z","updated_at":"2019-02-22T17:38:10Z","author_association":"COLLABORATOR","body":"You are right, maybe it should be a `staticRead` of a simple HTML file, like change it from `*.tmpl` to `*.html`."}}
other: {"actor":{"display_login":"juancarlospaco"}}