payload: {"action":"created","comment":{"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments/362931215","pull_request_review_id":338236101,"id":362931215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MjkzMTIxNQ==","diff_hunk":"@@ -280,15 +285,12 @@ class D2LQuickEvalSubmissions extends mixinBehaviors(\n \t\tif (this._initialLoad) {\n \t\t\tthis.filterAppliedShortcut();\n \t\t\tthis.searchAppliedShortcut();\n-\t\t}\n \n-\t\tif (this._initialLoad &&\n-\t\t\tentity.hasClass('empty') &&\n-\t\t\t(this.searchApplied || this.filterApplied)\n-\t\t) {\n-\t\t\tawait this._clearFilterAndSearch();\n-\t\t\tthis._initialLoad = false;\n-\t\t\treturn;\n+\t\t\tif (entity.hasClass('empty') && (this.searchApplied || this.filterApplied)) {\n+\t\t\t\tthis.addEventListener('d2l-hm-filter-filters-loaded', this._handleFilterLoadedNoResultsOnInitialLoad);","path":"components/d2l-quick-eval/d2l-quick-eval-submissions.js","position":26,"original_position":26,"commit_id":"78063aaf8b115a7fbd4a82d0cddae82ae169f8cf","original_commit_id":"3cbf33ca5f869b3b27ca0d04b1db60944f60e0bf","user":{"login":"maboelsoudd2l","id":52468201,"node_id":"MDQ6VXNlcjUyNDY4MjAx","avatar_url":"https://avatars1.githubusercontent.com/u/52468201?v=4","gravatar_id":"","url":"https://api.github.com/users/maboelsoudd2l","html_url":"https://github.com/maboelsoudd2l","followers_url":"https://api.github.com/users/maboelsoudd2l/followers","following_url":"https://api.github.com/users/maboelsoudd2l/following{/other_user}","gists_url":"https://api.github.com/users/maboelsoudd2l/gists{/gist_id}","starred_url":"https://api.github.com/users/maboelsoudd2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maboelsoudd2l/subscriptions","organizations_url":"https://api.github.com/users/maboelsoudd2l/orgs","repos_url":"https://api.github.com/users/maboelsoudd2l/repos","events_url":"https://api.github.com/users/maboelsoudd2l/events{/privacy}","received_events_url":"https://api.github.com/users/maboelsoudd2l/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2020-01-03T19:27:10Z","updated_at":"2020-01-03T19:28:55Z","html_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/581#discussion_r362931215","pull_request_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments/362931215"},"html":{"href":"https://github.com/BrightspaceHypermediaComponents/activities/pull/581#discussion_r362931215"},"pull_request":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581"}},"in_reply_to_id":362927099},"pull_request":{"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581","id":359065749,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5MDY1NzQ5","html_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/581","diff_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/581.diff","patch_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/581.patch","issue_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/581","number":581,"state":"open","locked":false,"title":"US105733 - Fix for Quick Eval 1 result page return filter bug","user":{"login":"dmackenz","id":20796985,"node_id":"MDQ6VXNlcjIwNzk2OTg1","avatar_url":"https://avatars0.githubusercontent.com/u/20796985?v=4","gravatar_id":"","url":"https://api.github.com/users/dmackenz","html_url":"https://github.com/dmackenz","followers_url":"https://api.github.com/users/dmackenz/followers","following_url":"https://api.github.com/users/dmackenz/following{/other_user}","gists_url":"https://api.github.com/users/dmackenz/gists{/gist_id}","starred_url":"https://api.github.com/users/dmackenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmackenz/subscriptions","organizations_url":"https://api.github.com/users/dmackenz/orgs","repos_url":"https://api.github.com/users/dmackenz/repos","events_url":"https://api.github.com/users/dmackenz/events{/privacy}","received_events_url":"https://api.github.com/users/dmackenz/received_events","type":"User","site_admin":false},"body":"The reason why this is happening is that there is an exception/race condition occurring inside of the d2l-hm-filter component. When quick eval loads with a filter and no results, an entity with the class 'empty' is loaded. This triggers quick eval to clear the filter. This causes an exception because a subsequent entity is required before the filter can be cleared. This subsequent entity contains the 'clear' action. This bug was occurring before because the subsequent entity had not been received before the filter clearing was being called (thus resulting in a race condition).\r\n\r\nThe way that I proposed to fix this is when the 'empty' entity is received, add an event listener that listens for the subsequent entity to arrive and load the necessary data into the filter. On the event listener being triggered, clear the filter and remove the one-time event listener.","created_at":"2020-01-03T17:35:52Z","updated_at":"2020-01-03T19:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4fcb5b81ed9cdfbda2760c04fe7f16291b313cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AlexBedley","id":11522163,"node_id":"MDQ6VXNlcjExNTIyMTYz","avatar_url":"https://avatars1.githubusercontent.com/u/11522163?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexBedley","html_url":"https://github.com/AlexBedley","followers_url":"https://api.github.com/users/AlexBedley/followers","following_url":"https://api.github.com/users/AlexBedley/following{/other_user}","gists_url":"https://api.github.com/users/AlexBedley/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexBedley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexBedley/subscriptions","organizations_url":"https://api.github.com/users/AlexBedley/orgs","repos_url":"https://api.github.com/users/AlexBedley/repos","events_url":"https://api.github.com/users/AlexBedley/events{/privacy}","received_events_url":"https://api.github.com/users/AlexBedley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581/commits","review_comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581/comments","review_comment_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/581/comments","statuses_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/78063aaf8b115a7fbd4a82d0cddae82ae169f8cf","head":{"label":"BrightspaceHypermediaComponents:dmackenzie/US105733_fix-one-search-result-bugs-quick-eval","ref":"dmackenzie/US105733_fix-one-search-result-bugs-quick-eval","sha":"78063aaf8b115a7fbd4a82d0cddae82ae169f8cf","user":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":153316014,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMTYwMTQ=","name":"activities","full_name":"BrightspaceHypermediaComponents/activities","private":false,"owner":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrightspaceHypermediaComponents/activities","description":null,"fork":false,"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities","forks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/forks","keys_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/teams","hooks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/hooks","issue_events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/events{/number}","events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/events","assignees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/assignees{/user}","branches_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/branches{/branch}","tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/tags","blobs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/languages","stargazers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/stargazers","contributors_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contributors","subscribers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscribers","subscription_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscription","commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contents/{+path}","compare_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/merges","archive_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/downloads","issues_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues{/number}","pulls_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/labels{/name}","releases_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/releases{/id}","deployments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/deployments","created_at":"2018-10-16T16:14:04Z","updated_at":"2020-01-02T21:57:20Z","pushed_at":"2020-01-03T19:14:56Z","git_url":"git://github.com/BrightspaceHypermediaComponents/activities.git","ssh_url":"git@github.com:BrightspaceHypermediaComponents/activities.git","clone_url":"https://github.com/BrightspaceHypermediaComponents/activities.git","svn_url":"https://github.com/BrightspaceHypermediaComponents/activities","homepage":null,"size":4955,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":17,"watchers":3,"default_branch":"master"}},"base":{"label":"BrightspaceHypermediaComponents:master","ref":"master","sha":"f0ae425905635274d927337f155e8196808d0a8a","user":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":153316014,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMTYwMTQ=","name":"activities","full_name":"BrightspaceHypermediaComponents/activities","private":false,"owner":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrightspaceHypermediaComponents/activities","description":null,"fork":false,"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities","forks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/forks","keys_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/teams","hooks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/hooks","issue_events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/events{/number}","events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/events","assignees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/assignees{/user}","branches_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/branches{/branch}","tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/tags","blobs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/languages","stargazers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/stargazers","contributors_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contributors","subscribers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscribers","subscription_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscription","commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contents/{+path}","compare_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/merges","archive_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/downloads","issues_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues{/number}","pulls_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/labels{/name}","releases_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/releases{/id}","deployments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/deployments","created_at":"2018-10-16T16:14:04Z","updated_at":"2020-01-02T21:57:20Z","pushed_at":"2020-01-03T19:14:56Z","git_url":"git://github.com/BrightspaceHypermediaComponents/activities.git","ssh_url":"git@github.com:BrightspaceHypermediaComponents/activities.git","clone_url":"https://github.com/BrightspaceHypermediaComponents/activities.git","svn_url":"https://github.com/BrightspaceHypermediaComponents/activities","homepage":null,"size":4955,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":17,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581"},"html":{"href":"https://github.com/BrightspaceHypermediaComponents/activities/pull/581"},"issue":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/581"},"comments":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/78063aaf8b115a7fbd4a82d0cddae82ae169f8cf"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"maboelsoudd2l"}}