payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/comments/303603708","pull_request_review_id":262034436,"id":303603708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzYwMzcwOA==","diff_hunk":"@@ -36,16 +36,17 @@ def revert(self):\n \n class SadPath(object):\n     def __init__(self, oper_type, vm_list, portchannel_ports, vm_dut_map, test_args):\n-        self.oper_type = oper_type\n+        (self.oper_type, self.cnt) = oper_type.split(':') if ':' in oper_type else (oper_type, 1)\n+        self.cnt = int(self.cnt)\n         self.vm_list = vm_list\n         self.portchannel_ports = portchannel_ports\n         self.vm_dut_map = vm_dut_map\n         self.test_args = test_args\n-        self.neigh_vm = None\n-        self.neigh_name = None\n-        self.vm_handle = None\n-        self.neigh_bgp = None\n-        self.dut_bgp = None\n+        self.neigh_vm = []\n+        self.neigh_name = dict()\n+        self.vm_handle = dict()\n+        self.neigh_bgp = dict()\n+        self.dut_bgp = dict()","path":"ansible/roles/test/files/ptftests/sad_path.py","position":null,"original_position":20,"commit_id":"f86054cccf7fc6c651716c3a11917c035fd40c44","original_commit_id":"3fa98e2ab3f59f423a15ef15c7945375696bbc7a","user":{"login":"neethajohn","id":48968228,"node_id":"MDQ6VXNlcjQ4OTY4MjI4","avatar_url":"https://avatars0.githubusercontent.com/u/48968228?v=4","gravatar_id":"","url":"https://api.github.com/users/neethajohn","html_url":"https://github.com/neethajohn","followers_url":"https://api.github.com/users/neethajohn/followers","following_url":"https://api.github.com/users/neethajohn/following{/other_user}","gists_url":"https://api.github.com/users/neethajohn/gists{/gist_id}","starred_url":"https://api.github.com/users/neethajohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neethajohn/subscriptions","organizations_url":"https://api.github.com/users/neethajohn/orgs","repos_url":"https://api.github.com/users/neethajohn/repos","events_url":"https://api.github.com/users/neethajohn/events{/privacy}","received_events_url":"https://api.github.com/users/neethajohn/received_events","type":"User","site_admin":false},"body":"done","created_at":"2019-07-15T19:44:03Z","updated_at":"2019-07-15T19:44:04Z","html_url":"https://github.com/Azure/sonic-mgmt/pull/1004#discussion_r303603708","pull_request_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/comments/303603708"},"html":{"href":"https://github.com/Azure/sonic-mgmt/pull/1004#discussion_r303603708"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004"}},"in_reply_to_id":302792406},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004","id":296840640,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2ODQwNjQw","html_url":"https://github.com/Azure/sonic-mgmt/pull/1004","diff_url":"https://github.com/Azure/sonic-mgmt/pull/1004.diff","patch_url":"https://github.com/Azure/sonic-mgmt/pull/1004.patch","issue_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/1004","number":1004,"state":"open","locked":false,"title":"[warm-reboot] Add Preboot n BGP member down and n Lag down tests","user":{"login":"neethajohn","id":48968228,"node_id":"MDQ6VXNlcjQ4OTY4MjI4","avatar_url":"https://avatars0.githubusercontent.com/u/48968228?v=4","gravatar_id":"","url":"https://api.github.com/users/neethajohn","html_url":"https://github.com/neethajohn","followers_url":"https://api.github.com/users/neethajohn/followers","following_url":"https://api.github.com/users/neethajohn/following{/other_user}","gists_url":"https://api.github.com/users/neethajohn/gists{/gist_id}","starred_url":"https://api.github.com/users/neethajohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neethajohn/subscriptions","organizations_url":"https://api.github.com/users/neethajohn/orgs","repos_url":"https://api.github.com/users/neethajohn/repos","events_url":"https://api.github.com/users/neethajohn/events{/privacy}","received_events_url":"https://api.github.com/users/neethajohn/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Neetha John <nejo@microsoft.com>\r\n\r\n### Description of PR\r\nExtend the warm-reboot sad path BGP and LAG tests for bringing n BGP members or n lags down instead of a single one\r\n\r\n### Type of change\r\n\r\n- [] Bug fix\r\n- [] Testbed and Framework(new/improvement)\r\n- [x] Test case(new/improvement)\r\n\r\n### Approach\r\n#### How did you do it?\r\n* warm-reboot-sad.yml \r\n     - Added ':' separated parameter for each preboot operation which indicates the number of bgp members/lag down.  If no ':' separated parameter exists, the count is set to 1\r\n* validate_preboot_list.yml \r\n     - Validate if the cnt for each preboot operation is within allowed limits. For bgp and lag down case, the max value is set to one less than the number of Vms. For lag member case, max allowed value is the total number of members in a lag\r\n* sad_path.py\r\n    - VM selection method is extended to select count number of VMs after picking a start VM.  \r\n    - extend all cases to make changes for count number of VMs instead of a single VM\r\n\r\n#### How did you verify/test it?\r\nRan the test on T0 topology and all cases passed\r\nRegression run for fast-reboot and warm-reboot tests also passed\r\n","created_at":"2019-07-11T21:53:03Z","updated_at":"2019-07-15T19:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"824de1229e567bdc8182700e35c3adae7d165ddf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pavel-shirshov","id":13968565,"node_id":"MDQ6VXNlcjEzOTY4NTY1","avatar_url":"https://avatars1.githubusercontent.com/u/13968565?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-shirshov","html_url":"https://github.com/pavel-shirshov","followers_url":"https://api.github.com/users/pavel-shirshov/followers","following_url":"https://api.github.com/users/pavel-shirshov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-shirshov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-shirshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-shirshov/subscriptions","organizations_url":"https://api.github.com/users/pavel-shirshov/orgs","repos_url":"https://api.github.com/users/pavel-shirshov/repos","events_url":"https://api.github.com/users/pavel-shirshov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-shirshov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":332076467,"node_id":"MDU6TGFiZWwzMzIwNzY0Njc=","url":"https://api.github.com/repos/Azure/sonic-mgmt/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":1198996779,"node_id":"MDU6TGFiZWwxMTk4OTk2Nzc5","url":"https://api.github.com/repos/Azure/sonic-mgmt/labels/Request%20for%20201811%20branch%20:shipit:","name":"Request for 201811 branch :shipit:","color":"b5a4f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/1004/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-mgmt/statuses/f86054cccf7fc6c651716c3a11917c035fd40c44","head":{"label":"neethajohn:warmboot-nbgp-nlag","ref":"warmboot-nbgp-nlag","sha":"f86054cccf7fc6c651716c3a11917c035fd40c44","user":{"login":"neethajohn","id":48968228,"node_id":"MDQ6VXNlcjQ4OTY4MjI4","avatar_url":"https://avatars0.githubusercontent.com/u/48968228?v=4","gravatar_id":"","url":"https://api.github.com/users/neethajohn","html_url":"https://github.com/neethajohn","followers_url":"https://api.github.com/users/neethajohn/followers","following_url":"https://api.github.com/users/neethajohn/following{/other_user}","gists_url":"https://api.github.com/users/neethajohn/gists{/gist_id}","starred_url":"https://api.github.com/users/neethajohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neethajohn/subscriptions","organizations_url":"https://api.github.com/users/neethajohn/orgs","repos_url":"https://api.github.com/users/neethajohn/repos","events_url":"https://api.github.com/users/neethajohn/events{/privacy}","received_events_url":"https://api.github.com/users/neethajohn/received_events","type":"User","site_admin":false},"repo":{"id":187916283,"node_id":"MDEwOlJlcG9zaXRvcnkxODc5MTYyODM=","name":"sonic-mgmt","full_name":"neethajohn/sonic-mgmt","private":false,"owner":{"login":"neethajohn","id":48968228,"node_id":"MDQ6VXNlcjQ4OTY4MjI4","avatar_url":"https://avatars0.githubusercontent.com/u/48968228?v=4","gravatar_id":"","url":"https://api.github.com/users/neethajohn","html_url":"https://github.com/neethajohn","followers_url":"https://api.github.com/users/neethajohn/followers","following_url":"https://api.github.com/users/neethajohn/following{/other_user}","gists_url":"https://api.github.com/users/neethajohn/gists{/gist_id}","starred_url":"https://api.github.com/users/neethajohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neethajohn/subscriptions","organizations_url":"https://api.github.com/users/neethajohn/orgs","repos_url":"https://api.github.com/users/neethajohn/repos","events_url":"https://api.github.com/users/neethajohn/events{/privacy}","received_events_url":"https://api.github.com/users/neethajohn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/neethajohn/sonic-mgmt","description":"Configuration management examples for SONiC","fork":true,"url":"https://api.github.com/repos/neethajohn/sonic-mgmt","forks_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/forks","keys_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/teams","hooks_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/hooks","issue_events_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/issues/events{/number}","events_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/events","assignees_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/assignees{/user}","branches_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/branches{/branch}","tags_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/tags","blobs_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/languages","stargazers_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/stargazers","contributors_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/contributors","subscribers_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/subscribers","subscription_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/subscription","commits_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/contents/{+path}","compare_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/merges","archive_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/downloads","issues_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/issues{/number}","pulls_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/labels{/name}","releases_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/releases{/id}","deployments_url":"https://api.github.com/repos/neethajohn/sonic-mgmt/deployments","created_at":"2019-05-21T21:30:40Z","updated_at":"2019-07-11T20:56:53Z","pushed_at":"2019-07-15T19:41:26Z","git_url":"git://github.com/neethajohn/sonic-mgmt.git","ssh_url":"git@github.com:neethajohn/sonic-mgmt.git","clone_url":"https://github.com/neethajohn/sonic-mgmt.git","svn_url":"https://github.com/neethajohn/sonic-mgmt","homepage":null,"size":1985,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"58a7780a445a28e56437c7093c3998ed67cc6aea","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":52558133,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1ODEzMw==","name":"sonic-mgmt","full_name":"Azure/sonic-mgmt","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-mgmt","description":"Configuration management examples for SONiC","fork":false,"url":"https://api.github.com/repos/Azure/sonic-mgmt","forks_url":"https://api.github.com/repos/Azure/sonic-mgmt/forks","keys_url":"https://api.github.com/repos/Azure/sonic-mgmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-mgmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-mgmt/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-mgmt/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-mgmt/events","assignees_url":"https://api.github.com/repos/Azure/sonic-mgmt/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-mgmt/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-mgmt/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-mgmt/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-mgmt/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-mgmt/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-mgmt/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-mgmt/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-mgmt/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-mgmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-mgmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-mgmt/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-mgmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-mgmt/merges","archive_url":"https://api.github.com/repos/Azure/sonic-mgmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-mgmt/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-mgmt/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-mgmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-mgmt/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-mgmt/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-mgmt/deployments","created_at":"2016-02-25T21:28:59Z","updated_at":"2019-07-11T20:28:09Z","pushed_at":"2019-07-15T19:41:27Z","git_url":"git://github.com/Azure/sonic-mgmt.git","ssh_url":"git@github.com:Azure/sonic-mgmt.git","clone_url":"https://github.com/Azure/sonic-mgmt.git","svn_url":"https://github.com/Azure/sonic-mgmt","homepage":null,"size":1985,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":150,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":122,"open_issues":150,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004"},"html":{"href":"https://github.com/Azure/sonic-mgmt/pull/1004"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/issues/1004"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/issues/1004/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/1004/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/statuses/f86054cccf7fc6c651716c3a11917c035fd40c44"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"neethajohn"}}