payload: {"action":"created","issue":{"url":"https://api.github.com/repos/google/CausalImpact/issues/31","repository_url":"https://api.github.com/repos/google/CausalImpact","labels_url":"https://api.github.com/repos/google/CausalImpact/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/google/CausalImpact/issues/31/comments","events_url":"https://api.github.com/repos/google/CausalImpact/issues/31/events","html_url":"https://github.com/google/CausalImpact/issues/31","id":446302009,"node_id":"MDU6SXNzdWU0NDYzMDIwMDk=","number":31,"title":"Relative Effects incorrect (wrong sign) when post-period mean is negative","user":{"login":"mefergus","id":32277181,"node_id":"MDQ6VXNlcjMyMjc3MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/32277181?v=4","gravatar_id":"","url":"https://api.github.com/users/mefergus","html_url":"https://github.com/mefergus","followers_url":"https://api.github.com/users/mefergus/followers","following_url":"https://api.github.com/users/mefergus/following{/other_user}","gists_url":"https://api.github.com/users/mefergus/gists{/gist_id}","starred_url":"https://api.github.com/users/mefergus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefergus/subscriptions","organizations_url":"https://api.github.com/users/mefergus/orgs","repos_url":"https://api.github.com/users/mefergus/repos","events_url":"https://api.github.com/users/mefergus/events{/privacy}","received_events_url":"https://api.github.com/users/mefergus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-20T20:43:57Z","updated_at":"2019-05-29T18:21:36Z","closed_at":null,"author_association":"NONE","body":"See impact_inference.R, line 248:\r\n```R\r\n  summary <- dplyr::mutate(summary,\r\n                           RelEffect = AbsEffect / Pred,\r\n                           RelEffect.lower = AbsEffect.lower / Pred,\r\n                           RelEffect.upper = AbsEffect.upper / Pred,\r\n                           RelEffect.sd = AbsEffect.sd / Pred)\r\n```\r\nI noticed negative RelEffect.sd in my `CausalImpactObject$summary` which is clearly the product of not using ```abs(Pred)``` as the denominator, as I believe it should be in each of these cases.  In particular the upper and lower bounds are out of order, too, when ```Pred < 0 ```."},"comment":{"url":"https://api.github.com/repos/google/CausalImpact/issues/comments/497052917","html_url":"https://github.com/google/CausalImpact/issues/31#issuecomment-497052917","issue_url":"https://api.github.com/repos/google/CausalImpact/issues/31","id":497052917,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NzA1MjkxNw==","user":{"login":"mefergus","id":32277181,"node_id":"MDQ6VXNlcjMyMjc3MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/32277181?v=4","gravatar_id":"","url":"https://api.github.com/users/mefergus","html_url":"https://github.com/mefergus","followers_url":"https://api.github.com/users/mefergus/followers","following_url":"https://api.github.com/users/mefergus/following{/other_user}","gists_url":"https://api.github.com/users/mefergus/gists{/gist_id}","starred_url":"https://api.github.com/users/mefergus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefergus/subscriptions","organizations_url":"https://api.github.com/users/mefergus/orgs","repos_url":"https://api.github.com/users/mefergus/repos","events_url":"https://api.github.com/users/mefergus/events{/privacy}","received_events_url":"https://api.github.com/users/mefergus/received_events","type":"User","site_admin":false},"created_at":"2019-05-29T18:21:36Z","updated_at":"2019-05-29T18:21:36Z","author_association":"NONE","body":"It may be sufficient to issue a warning when Pred is negative -- further consideration reminds me that working with relative measures \"around\" zero is fundamentally problematic."}}
other: {"actor":{"display_login":"mefergus"}}