payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/stellar/js-stellar-wallets/issues/35","repository_url":"https://api.github.com/repos/stellar/js-stellar-wallets","labels_url":"https://api.github.com/repos/stellar/js-stellar-wallets/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/stellar/js-stellar-wallets/issues/35/comments","events_url":"https://api.github.com/repos/stellar/js-stellar-wallets/issues/35/events","html_url":"https://github.com/stellar/js-stellar-wallets/issues/35","id":435765719,"node_id":"MDU6SXNzdWU0MzU3NjU3MTk=","number":35,"title":"Decide when trades / transfers / etc. get reframed","user":{"login":"morleyzhi","id":1668327,"node_id":"MDQ6VXNlcjE2NjgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1668327?v=4","gravatar_id":"","url":"https://api.github.com/users/morleyzhi","html_url":"https://github.com/morleyzhi","followers_url":"https://api.github.com/users/morleyzhi/followers","following_url":"https://api.github.com/users/morleyzhi/following{/other_user}","gists_url":"https://api.github.com/users/morleyzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/morleyzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morleyzhi/subscriptions","organizations_url":"https://api.github.com/users/morleyzhi/orgs","repos_url":"https://api.github.com/users/morleyzhi/repos","events_url":"https://api.github.com/users/morleyzhi/events{/privacy}","received_events_url":"https://api.github.com/users/morleyzhi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stellar/js-stellar-wallets/milestones/2","html_url":"https://github.com/stellar/js-stellar-wallets/milestone/2","labels_url":"https://api.github.com/repos/stellar/js-stellar-wallets/milestones/2/labels","id":4303392,"node_id":"MDk6TWlsZXN0b25lNDMwMzM5Mg==","number":2,"title":"Data","description":"Complete data API","creator":{"login":"morleyzhi","id":1668327,"node_id":"MDQ6VXNlcjE2NjgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1668327?v=4","gravatar_id":"","url":"https://api.github.com/users/morleyzhi","html_url":"https://github.com/morleyzhi","followers_url":"https://api.github.com/users/morleyzhi/followers","following_url":"https://api.github.com/users/morleyzhi/following{/other_user}","gists_url":"https://api.github.com/users/morleyzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/morleyzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morleyzhi/subscriptions","organizations_url":"https://api.github.com/users/morleyzhi/orgs","repos_url":"https://api.github.com/users/morleyzhi/repos","events_url":"https://api.github.com/users/morleyzhi/events{/privacy}","received_events_url":"https://api.github.com/users/morleyzhi/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2019-05-10T17:01:36Z","updated_at":"2019-05-21T18:37:03Z","due_on":"2019-06-21T07:00:00Z","closed_at":null},"comments":1,"created_at":"2019-04-22T15:19:28Z","updated_at":"2019-05-21T18:37:03Z","closed_at":"2019-05-21T18:37:03Z","author_association":"MEMBER","body":"Right now, fetchTrades / fetchOpenOffers / etc. get un-reframed details (so there's usually a seller and buyer on the object, whereas we might care more to think about what the owner of the private key is \"sending\" and \"receiving\").\r\n\r\nIt seems strange to have a \"Reframed\" type for each non-reframed type, but maybe that's the only option.\r\n\r\nSo I think these are some our options:\r\n- Always reframe data in terms of DataProvider's account\r\n- Never reframe data\r\n- Reframe data if the user turns on a DataProvider mode\r\n- Leave it up to the dev to reframe using our lib's stateless functions"}}
other: {"actor":{"display_login":"morleyzhi"}}