payload: {"action":"created","issue":{"url":"https://api.github.com/repos/1aim/serde_postgres/issues/4","repository_url":"https://api.github.com/repos/1aim/serde_postgres","labels_url":"https://api.github.com/repos/1aim/serde_postgres/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/1aim/serde_postgres/issues/4/comments","events_url":"https://api.github.com/repos/1aim/serde_postgres/issues/4/events","html_url":"https://github.com/1aim/serde_postgres/pull/4","id":416287573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NTg4NzAz","number":4,"title":"Added deserialize_ignore_any implementation","user":{"login":"winstonewert","id":858493,"node_id":"MDQ6VXNlcjg1ODQ5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/858493?v=4","gravatar_id":"","url":"https://api.github.com/users/winstonewert","html_url":"https://github.com/winstonewert","followers_url":"https://api.github.com/users/winstonewert/followers","following_url":"https://api.github.com/users/winstonewert/following{/other_user}","gists_url":"https://api.github.com/users/winstonewert/gists{/gist_id}","starred_url":"https://api.github.com/users/winstonewert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winstonewert/subscriptions","organizations_url":"https://api.github.com/users/winstonewert/orgs","repos_url":"https://api.github.com/users/winstonewert/repos","events_url":"https://api.github.com/users/winstonewert/events{/privacy}","received_events_url":"https://api.github.com/users/winstonewert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Aaronepower","id":4464295,"node_id":"MDQ6VXNlcjQ0NjQyOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4464295?v=4","gravatar_id":"","url":"https://api.github.com/users/Aaronepower","html_url":"https://github.com/Aaronepower","followers_url":"https://api.github.com/users/Aaronepower/followers","following_url":"https://api.github.com/users/Aaronepower/following{/other_user}","gists_url":"https://api.github.com/users/Aaronepower/gists{/gist_id}","starred_url":"https://api.github.com/users/Aaronepower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aaronepower/subscriptions","organizations_url":"https://api.github.com/users/Aaronepower/orgs","repos_url":"https://api.github.com/users/Aaronepower/repos","events_url":"https://api.github.com/users/Aaronepower/events{/privacy}","received_events_url":"https://api.github.com/users/Aaronepower/received_events","type":"User","site_admin":false},"assignees":[{"login":"Aaronepower","id":4464295,"node_id":"MDQ6VXNlcjQ0NjQyOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4464295?v=4","gravatar_id":"","url":"https://api.github.com/users/Aaronepower","html_url":"https://github.com/Aaronepower","followers_url":"https://api.github.com/users/Aaronepower/followers","following_url":"https://api.github.com/users/Aaronepower/following{/other_user}","gists_url":"https://api.github.com/users/Aaronepower/gists{/gist_id}","starred_url":"https://api.github.com/users/Aaronepower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aaronepower/subscriptions","organizations_url":"https://api.github.com/users/Aaronepower/orgs","repos_url":"https://api.github.com/users/Aaronepower/repos","events_url":"https://api.github.com/users/Aaronepower/events{/privacy}","received_events_url":"https://api.github.com/users/Aaronepower/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-03-01T21:32:35Z","updated_at":"2019-03-04T16:06:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/1aim/serde_postgres/pulls/4","html_url":"https://github.com/1aim/serde_postgres/pull/4","diff_url":"https://github.com/1aim/serde_postgres/pull/4.diff","patch_url":"https://github.com/1aim/serde_postgres/pull/4.patch"},"body":"deserialize_ignore_any is called when there is a column in the query set\r\nthat is not in the struct. Previously, this returned an error, but this\r\nchange makes it ignore the extra column.\r\n\r\nThis change is primariliy to improve the error reporting when the user\r\nmisspells a field name. Prior to this change this simply gives the error\r\nInvalidType due to calling the deserialize_ignore_any function. With\r\nthis change, the error message becomes \"missing field `field_name`\"\r\nwhich is much better.\r\n\r\nThe mechanics are that serde attempts to resolve all of the columns in\r\nthe query set first, thus returning the unhelpful error from\r\ndeserialize_ignore_any function before finding the field in the struct\r\nthat was never resolved and returning the more useful missing field\r\nfunction.\r\n\r\nIt is also possible that it might be useful to define a struct that only\r\ncaptures a subset of the columns from a sql query. I don't have a use\r\ncase for this, but is seems concievable.\r\n\r\nThe alternative solution would be to attempt to produce better error\r\nmessages in deserialize_ignore_any, such as indicating which column is\r\nthe source of the ignored any, but this information does not seem\r\nreadily available in that function."},"comment":{"url":"https://api.github.com/repos/1aim/serde_postgres/issues/comments/469309169","html_url":"https://github.com/1aim/serde_postgres/pull/4#issuecomment-469309169","issue_url":"https://api.github.com/repos/1aim/serde_postgres/issues/4","id":469309169,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2OTMwOTE2OQ==","user":{"login":"Aaronepower","id":4464295,"node_id":"MDQ6VXNlcjQ0NjQyOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4464295?v=4","gravatar_id":"","url":"https://api.github.com/users/Aaronepower","html_url":"https://github.com/Aaronepower","followers_url":"https://api.github.com/users/Aaronepower/followers","following_url":"https://api.github.com/users/Aaronepower/following{/other_user}","gists_url":"https://api.github.com/users/Aaronepower/gists{/gist_id}","starred_url":"https://api.github.com/users/Aaronepower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aaronepower/subscriptions","organizations_url":"https://api.github.com/users/Aaronepower/orgs","repos_url":"https://api.github.com/users/Aaronepower/repos","events_url":"https://api.github.com/users/Aaronepower/events{/privacy}","received_events_url":"https://api.github.com/users/Aaronepower/received_events","type":"User","site_admin":false},"created_at":"2019-03-04T16:06:32Z","updated_at":"2019-03-04T16:06:32Z","author_association":"CONTRIBUTOR","body":"Thank you for your work, and congrats your first contribution! :tada: "}}
other: {"actor":{"display_login":"Aaronepower"}}