payload: {"action":"opened","number":5141,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/5141","id":270992781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwOTkyNzgx","html_url":"https://github.com/dcos/dcos/pull/5141","diff_url":"https://github.com/dcos/dcos/pull/5141.diff","patch_url":"https://github.com/dcos/dcos/pull/5141.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/5141","number":5141,"state":"open","locked":false,"title":"Fix prometheus task metrics in bridged and virtual IP mode","user":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"body":"## High-level description\r\n\r\nThis PR updates telegraf to collect metrics from the mesos agent's IP address, rather than its host's loopback address.\r\n\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - [DCOS_OSS-5022](https://jira.mesosphere.com/browse/DCOS_OSS-5022) Prometheus task metrics don't work in bridge or virtual IP mode\r\n\r\n\r\n## Related tickets (optional)\r\n\r\nOther tickets related to this change:\r\n\r\n  - [DCOS_OSS-<number>](https://jira.mesosphere.com/browse/DCOS_OSS-<number>) Foo the Bar so it stops Bazzing.\r\n\r\n\r\n## Checklist for all PRs\r\n\r\n  - [ ] Added a comprehensible changelog entry to `CHANGES.md` or explain why this is not a user-facing change:\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n\r\n## Instructions and review process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using GitHub's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).\r\n","created_at":"2019-04-16T16:48:20Z","updated_at":"2019-04-16T16:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/5141/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/5141/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/5141/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/9a87e34c8f75ef13019de253a6d0febda36d0a41","head":{"label":"philipnrmn:task-hostname","ref":"task-hostname","sha":"9a87e34c8f75ef13019de253a6d0febda36d0a41","user":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"repo":{"id":92886752,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjg4Njc1Mg==","name":"dcos","full_name":"philipnrmn/dcos","private":false,"owner":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/philipnrmn/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/philipnrmn/dcos","forks_url":"https://api.github.com/repos/philipnrmn/dcos/forks","keys_url":"https://api.github.com/repos/philipnrmn/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philipnrmn/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philipnrmn/dcos/teams","hooks_url":"https://api.github.com/repos/philipnrmn/dcos/hooks","issue_events_url":"https://api.github.com/repos/philipnrmn/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/philipnrmn/dcos/events","assignees_url":"https://api.github.com/repos/philipnrmn/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/philipnrmn/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/philipnrmn/dcos/tags","blobs_url":"https://api.github.com/repos/philipnrmn/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philipnrmn/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philipnrmn/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/philipnrmn/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philipnrmn/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/philipnrmn/dcos/languages","stargazers_url":"https://api.github.com/repos/philipnrmn/dcos/stargazers","contributors_url":"https://api.github.com/repos/philipnrmn/dcos/contributors","subscribers_url":"https://api.github.com/repos/philipnrmn/dcos/subscribers","subscription_url":"https://api.github.com/repos/philipnrmn/dcos/subscription","commits_url":"https://api.github.com/repos/philipnrmn/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/philipnrmn/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/philipnrmn/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/philipnrmn/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/philipnrmn/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/philipnrmn/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philipnrmn/dcos/merges","archive_url":"https://api.github.com/repos/philipnrmn/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philipnrmn/dcos/downloads","issues_url":"https://api.github.com/repos/philipnrmn/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/philipnrmn/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/philipnrmn/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/philipnrmn/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philipnrmn/dcos/labels{/name}","releases_url":"https://api.github.com/repos/philipnrmn/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/philipnrmn/dcos/deployments","created_at":"2017-05-31T00:06:25Z","updated_at":"2018-12-07T23:59:24Z","pushed_at":"2019-04-16T16:46:45Z","git_url":"git://github.com/philipnrmn/dcos.git","ssh_url":"git@github.com:philipnrmn/dcos.git","clone_url":"https://github.com/philipnrmn/dcos.git","svn_url":"https://github.com/philipnrmn/dcos","homepage":"https://dcos.io","size":8515,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"9e82984df604f878fd8699a0939c4423e2a9437d","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"node_id":"MDEwOlJlcG9zaXRvcnk1NjE4NDA1MA==","name":"dcos","full_name":"dcos/dcos","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2019-04-16T13:41:36Z","pushed_at":"2019-04-16T16:38:09Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":9837,"stargazers_count":2146,"watchers_count":2146,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":451,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":451,"open_issues":51,"watchers":2146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/5141"},"html":{"href":"https://github.com/dcos/dcos/pull/5141"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/5141"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/5141/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/5141/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/5141/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/9a87e34c8f75ef13019de253a6d0febda36d0a41"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
other: {"actor":{"display_login":"philipnrmn"}}