payload: {"action":"created","comment":{"url":"https://api.github.com/repos/3scale/3scale-operator/pulls/comments/359477392","pull_request_review_id":334144781,"id":359477392,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTQ3NzM5Mg==","diff_hunk":"@@ -326,3 +326,15 @@ existing secret names.\n | --- | --- | --- |\n | AWS_ACCESS_KEY_ID | AWS Access Key ID to use in S3 Storage for System's file storage | N/A |\n | AWS_SECRET_ACCESS_KEY | AWS Access Key Secret to use in S3 Storage for System's file storage | N/A |\n+\n+#### system-smtp\n+\n+| **Field** | **Description** | **Default value** |\n+| --- | --- | --- |\n+| address | Address (hostname or IP) of the remote mail server to use. If set to a value different than `\"\"` System will use the mail server to send mails related to events that happen in the API management solution |  `\"\"` |\n+| username | In case the mail server requires authentication, set the username using this setting | `\"\"` |\n+| password | In case the mail server requires authentication, set the password using this setting | `\"\"` |\n+| domain | If a HELO domain is needed to be specified set it using this setting | `\"\"` |","path":"doc/apimanager-reference.md","position":12,"original_position":12,"commit_id":"3992acaebe6fe48807d176ab996dd6c038a0e929","original_commit_id":"3992acaebe6fe48807d176ab996dd6c038a0e929","user":{"login":"thomasmaas","id":54224,"node_id":"MDQ6VXNlcjU0MjI0","avatar_url":"https://avatars1.githubusercontent.com/u/54224?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasmaas","html_url":"https://github.com/thomasmaas","followers_url":"https://api.github.com/users/thomasmaas/followers","following_url":"https://api.github.com/users/thomasmaas/following{/other_user}","gists_url":"https://api.github.com/users/thomasmaas/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmaas/subscriptions","organizations_url":"https://api.github.com/users/thomasmaas/orgs","repos_url":"https://api.github.com/users/thomasmaas/repos","events_url":"https://api.github.com/users/thomasmaas/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmaas/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n| domain | In case the mail server requires a HELO domain. | `\"\"` |\r\n```","created_at":"2019-12-18T17:35:03Z","updated_at":"2019-12-18T17:35:04Z","html_url":"https://github.com/3scale/3scale-operator/pull/280#discussion_r359477392","pull_request_url":"https://api.github.com/repos/3scale/3scale-operator/pulls/280","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/3scale/3scale-operator/pulls/comments/359477392"},"html":{"href":"https://github.com/3scale/3scale-operator/pull/280#discussion_r359477392"},"pull_request":{"href":"https://api.github.com/repos/3scale/3scale-operator/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/3scale/3scale-operator/pulls/280","id":341547583,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNTQ3NTgz","html_url":"https://github.com/3scale/3scale-operator/pull/280","diff_url":"https://github.com/3scale/3scale-operator/pull/280.diff","patch_url":"https://github.com/3scale/3scale-operator/pull/280.patch","issue_url":"https://api.github.com/repos/3scale/3scale-operator/issues/280","number":280,"state":"open","locked":false,"title":"Move system smtp to secret","user":{"login":"miguelsorianod","id":37954906,"node_id":"MDQ6VXNlcjM3OTU0OTA2","avatar_url":"https://avatars3.githubusercontent.com/u/37954906?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelsorianod","html_url":"https://github.com/miguelsorianod","followers_url":"https://api.github.com/users/miguelsorianod/followers","following_url":"https://api.github.com/users/miguelsorianod/following{/other_user}","gists_url":"https://api.github.com/users/miguelsorianod/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelsorianod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelsorianod/subscriptions","organizations_url":"https://api.github.com/users/miguelsorianod/orgs","repos_url":"https://api.github.com/users/miguelsorianod/repos","events_url":"https://api.github.com/users/miguelsorianod/events{/privacy}","received_events_url":"https://api.github.com/users/miguelsorianod/received_events","type":"User","site_admin":false},"body":"This PR changes the deployment of the SMTP configuration from a ConfigMap to a Secret.\r\nThe reason of this is because some of the configuration contains credentials.","created_at":"2019-11-15T16:35:49Z","updated_at":"2019-12-18T17:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2ead8e9f6ad420cb50e4a05f78314479405585c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3scale/3scale-operator/pulls/280/commits","review_comments_url":"https://api.github.com/repos/3scale/3scale-operator/pulls/280/comments","review_comment_url":"https://api.github.com/repos/3scale/3scale-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3scale/3scale-operator/issues/280/comments","statuses_url":"https://api.github.com/repos/3scale/3scale-operator/statuses/3992acaebe6fe48807d176ab996dd6c038a0e929","head":{"label":"3scale:move-system-smtp-to-secret","ref":"move-system-smtp-to-secret","sha":"3992acaebe6fe48807d176ab996dd6c038a0e929","user":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":158574728,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg1NzQ3Mjg=","name":"3scale-operator","full_name":"3scale/3scale-operator","private":false,"owner":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3scale/3scale-operator","description":"Openshift operator to install a 3scale API Management solution","fork":false,"url":"https://api.github.com/repos/3scale/3scale-operator","forks_url":"https://api.github.com/repos/3scale/3scale-operator/forks","keys_url":"https://api.github.com/repos/3scale/3scale-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/3scale-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/3scale-operator/teams","hooks_url":"https://api.github.com/repos/3scale/3scale-operator/hooks","issue_events_url":"https://api.github.com/repos/3scale/3scale-operator/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/3scale-operator/events","assignees_url":"https://api.github.com/repos/3scale/3scale-operator/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/3scale-operator/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/3scale-operator/tags","blobs_url":"https://api.github.com/repos/3scale/3scale-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/3scale-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/3scale-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/3scale-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/3scale-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/3scale-operator/languages","stargazers_url":"https://api.github.com/repos/3scale/3scale-operator/stargazers","contributors_url":"https://api.github.com/repos/3scale/3scale-operator/contributors","subscribers_url":"https://api.github.com/repos/3scale/3scale-operator/subscribers","subscription_url":"https://api.github.com/repos/3scale/3scale-operator/subscription","commits_url":"https://api.github.com/repos/3scale/3scale-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/3scale-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/3scale-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/3scale-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/3scale-operator/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/3scale-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/3scale-operator/merges","archive_url":"https://api.github.com/repos/3scale/3scale-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/3scale-operator/downloads","issues_url":"https://api.github.com/repos/3scale/3scale-operator/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/3scale-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/3scale-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/3scale-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/3scale-operator/labels{/name}","releases_url":"https://api.github.com/repos/3scale/3scale-operator/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/3scale-operator/deployments","created_at":"2018-11-21T16:11:35Z","updated_at":"2019-12-16T17:06:40Z","pushed_at":"2019-12-18T16:18:50Z","git_url":"git://github.com/3scale/3scale-operator.git","ssh_url":"git@github.com:3scale/3scale-operator.git","clone_url":"https://github.com/3scale/3scale-operator.git","svn_url":"https://github.com/3scale/3scale-operator","homepage":"","size":1398,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":27,"watchers":12,"default_branch":"master"}},"base":{"label":"3scale:master","ref":"master","sha":"ce0b0a87de1253c478f17f70ec0f288ecc72056d","user":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":158574728,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg1NzQ3Mjg=","name":"3scale-operator","full_name":"3scale/3scale-operator","private":false,"owner":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3scale/3scale-operator","description":"Openshift operator to install a 3scale API Management solution","fork":false,"url":"https://api.github.com/repos/3scale/3scale-operator","forks_url":"https://api.github.com/repos/3scale/3scale-operator/forks","keys_url":"https://api.github.com/repos/3scale/3scale-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/3scale-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/3scale-operator/teams","hooks_url":"https://api.github.com/repos/3scale/3scale-operator/hooks","issue_events_url":"https://api.github.com/repos/3scale/3scale-operator/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/3scale-operator/events","assignees_url":"https://api.github.com/repos/3scale/3scale-operator/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/3scale-operator/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/3scale-operator/tags","blobs_url":"https://api.github.com/repos/3scale/3scale-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/3scale-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/3scale-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/3scale-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/3scale-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/3scale-operator/languages","stargazers_url":"https://api.github.com/repos/3scale/3scale-operator/stargazers","contributors_url":"https://api.github.com/repos/3scale/3scale-operator/contributors","subscribers_url":"https://api.github.com/repos/3scale/3scale-operator/subscribers","subscription_url":"https://api.github.com/repos/3scale/3scale-operator/subscription","commits_url":"https://api.github.com/repos/3scale/3scale-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/3scale-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/3scale-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/3scale-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/3scale-operator/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/3scale-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/3scale-operator/merges","archive_url":"https://api.github.com/repos/3scale/3scale-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/3scale-operator/downloads","issues_url":"https://api.github.com/repos/3scale/3scale-operator/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/3scale-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/3scale-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/3scale-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/3scale-operator/labels{/name}","releases_url":"https://api.github.com/repos/3scale/3scale-operator/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/3scale-operator/deployments","created_at":"2018-11-21T16:11:35Z","updated_at":"2019-12-16T17:06:40Z","pushed_at":"2019-12-18T16:18:50Z","git_url":"git://github.com/3scale/3scale-operator.git","ssh_url":"git@github.com:3scale/3scale-operator.git","clone_url":"https://github.com/3scale/3scale-operator.git","svn_url":"https://github.com/3scale/3scale-operator","homepage":"","size":1398,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":27,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3scale/3scale-operator/pulls/280"},"html":{"href":"https://github.com/3scale/3scale-operator/pull/280"},"issue":{"href":"https://api.github.com/repos/3scale/3scale-operator/issues/280"},"comments":{"href":"https://api.github.com/repos/3scale/3scale-operator/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/3scale/3scale-operator/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/3scale/3scale-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3scale/3scale-operator/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/3scale/3scale-operator/statuses/3992acaebe6fe48807d176ab996dd6c038a0e929"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"thomasmaas"}}