payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/softcover/softcover/issues/102","repository_url":"https://api.github.com/repos/softcover/softcover","labels_url":"https://api.github.com/repos/softcover/softcover/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/softcover/softcover/issues/102/comments","events_url":"https://api.github.com/repos/softcover/softcover/issues/102/events","html_url":"https://github.com/softcover/softcover/issues/102","id":33893615,"node_id":"MDU6SXNzdWUzMzg5MzYxNQ==","number":102,"title":"Found cause of 2 failing epub tests on Ubuntu 12.04.","user":{"login":"cirosantilli","id":1429315,"node_id":"MDQ6VXNlcjE0MjkzMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1429315?v=4","gravatar_id":"","url":"https://api.github.com/users/cirosantilli","html_url":"https://github.com/cirosantilli","followers_url":"https://api.github.com/users/cirosantilli/followers","following_url":"https://api.github.com/users/cirosantilli/following{/other_user}","gists_url":"https://api.github.com/users/cirosantilli/gists{/gist_id}","starred_url":"https://api.github.com/users/cirosantilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirosantilli/subscriptions","organizations_url":"https://api.github.com/users/cirosantilli/orgs","repos_url":"https://api.github.com/users/cirosantilli/repos","events_url":"https://api.github.com/users/cirosantilli/events{/privacy}","received_events_url":"https://api.github.com/users/cirosantilli/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2014-05-20T14:30:15Z","updated_at":"2019-03-23T16:39:45Z","closed_at":"2019-03-23T16:39:45Z","author_association":"CONTRIBUTOR","body":"I currently have 3 failing tests on Linux x84_64, 2 of which have the same cause. I have found the cause, but haven't patched yet because I don't know the best way to solve it.\n\nThe failing tests are:\n- https://github.com/softcover/softcover/blob/a675309210a508bb2d18867a21bead3b977c84ab/spec/builders/epub_spec.rb#L17\n- https://github.com/softcover/softcover/blob/a675309210a508bb2d18867a21bead3b977c84ab/spec/builders/epub_spec.rb#L204\n\nWhy they fail:\n- `generate_book` in `before` generates a dummy `spec/fixtures/book/ebooks/test-book.epub` file containing 4 bytes: `test`, obviously invalid.\n- `@builder.build!` in `before` generates the real output `spec/fixtures/book/ebooks/book.epub`, whose filename is specified by `config/book.yml:filename`, which is valid.\n- but then at https://github.com/softcover/softcover/blob/a675309210a508bb2d18867a21bead3b977c84ab/lib/softcover/commands/epub_validator.rb#L9 it is doing `epub = Dir.glob('ebooks/*.epub').first`, and on Linux that happens to find `test-book.epub` (unspecified order), which is invalid. Perhaphs the tests passes on Mac OS because of the unspecified behavior.\n\nThe above can be observed by commenting out the `after(:all) { remove_book }` which would clean up those files.\n\nMy proposed solution: fix the checked filename. The problem: I had a hard time finding the right way to get that output name. It should be `Softcover::BookManifest.new.filename`, but using that directly raises an exception.\n"}}
other: {"actor":{"display_login":"mhartl"}}