payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/346663662","pull_request_review_id":317410546,"id":346663662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NjY2MzY2Mg==","diff_hunk":"@@ -29,23 +29,40 @@\n using System.Reflection;\n using System.Collections.Generic;\n using System.Runtime.InteropServices;\n-\n+using System.Threading;\n using ObjCRuntime;\n \n namespace Foundation {\n \n \tpublic partial class NSDate {\n-\t\tconst long NSDATE_TICKS = 631139040000000000;\n+\t\tconst double NANOSECS_PER_MILLISEC = 1000000.0;\n+\n+\t\tprivate static readonly NSCalendar calendar;","path":"src/Foundation/NSDate.cs","position":14,"original_position":14,"commit_id":"9ee8afe4cf7a16fde45ac1b2bc9a9ec62888e144","original_commit_id":"9ee8afe4cf7a16fde45ac1b2bc9a9ec62888e144","user":{"login":"Therzok","id":109974,"node_id":"MDQ6VXNlcjEwOTk3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/109974?v=4","gravatar_id":"","url":"https://api.github.com/users/Therzok","html_url":"https://github.com/Therzok","followers_url":"https://api.github.com/users/Therzok/followers","following_url":"https://api.github.com/users/Therzok/following{/other_user}","gists_url":"https://api.github.com/users/Therzok/gists{/gist_id}","starred_url":"https://api.github.com/users/Therzok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Therzok/subscriptions","organizations_url":"https://api.github.com/users/Therzok/orgs","repos_url":"https://api.github.com/users/Therzok/repos","events_url":"https://api.github.com/users/Therzok/events{/privacy}","received_events_url":"https://api.github.com/users/Therzok/received_events","type":"User","site_admin":false},"body":"This can be initialized inline (avoiding static constructor):\r\n```csharp\r\nstatic readonly NSCalendar calendar = new NSCalendar (NSCalendarType.Gregorian) { \r\n    TimeZone = NSTimeZone.FromName (\"UTC\"),\r\n};\r\n```","created_at":"2019-11-15T05:09:20Z","updated_at":"2019-11-15T05:09:26Z","html_url":"https://github.com/xamarin/xamarin-macios/pull/7404#discussion_r346663662","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/346663662"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/7404#discussion_r346663662"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404","id":339641297,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5NjQxMjk3","html_url":"https://github.com/xamarin/xamarin-macios/pull/7404","diff_url":"https://github.com/xamarin/xamarin-macios/pull/7404.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/7404.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/7404","number":7404,"state":"open","locked":false,"title":"Fix DateTime -> NSDate conversion","user":{"login":"whitneyschmidt","id":51677938,"node_id":"MDQ6VXNlcjUxNjc3OTM4","avatar_url":"https://avatars3.githubusercontent.com/u/51677938?v=4","gravatar_id":"","url":"https://api.github.com/users/whitneyschmidt","html_url":"https://github.com/whitneyschmidt","followers_url":"https://api.github.com/users/whitneyschmidt/followers","following_url":"https://api.github.com/users/whitneyschmidt/following{/other_user}","gists_url":"https://api.github.com/users/whitneyschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/whitneyschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitneyschmidt/subscriptions","organizations_url":"https://api.github.com/users/whitneyschmidt/orgs","repos_url":"https://api.github.com/users/whitneyschmidt/repos","events_url":"https://api.github.com/users/whitneyschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/whitneyschmidt/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/xamarin/xamarin-macios/issues/6993\r\n\r\nUpdate conversions from `NSDate` to `DateTime` and `DateTime` to `NSDate` to use date components instead of `SecondsSinceReferenceDate`.\r\n\r\nThe number of seconds since reference date is inconsistent between `NSDate` and `DateTime`. See the associated bug - converting `DateTime` 1/1/1 to `NSDate` ends up giving you an `NSDate` a couple days off :(","created_at":"2019-11-11T22:20:05Z","updated_at":"2019-11-15T05:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0f77d19d5c56f8a15212684fda9ef4c4e3f57d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chamons","id":6392201,"node_id":"MDQ6VXNlcjYzOTIyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6392201?v=4","gravatar_id":"","url":"https://api.github.com/users/chamons","html_url":"https://github.com/chamons","followers_url":"https://api.github.com/users/chamons/followers","following_url":"https://api.github.com/users/chamons/following{/other_user}","gists_url":"https://api.github.com/users/chamons/gists{/gist_id}","starred_url":"https://api.github.com/users/chamons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamons/subscriptions","organizations_url":"https://api.github.com/users/chamons/orgs","repos_url":"https://api.github.com/users/chamons/repos","events_url":"https://api.github.com/users/chamons/events{/privacy}","received_events_url":"https://api.github.com/users/chamons/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":361456714,"node_id":"MDU6TGFiZWwzNjE0NTY3MTQ=","url":"https://api.github.com/repos/xamarin/xamarin-macios/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/7404/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/9ee8afe4cf7a16fde45ac1b2bc9a9ec62888e144","head":{"label":"whitneyschmidt:datetimefix","ref":"datetimefix","sha":"9ee8afe4cf7a16fde45ac1b2bc9a9ec62888e144","user":{"login":"whitneyschmidt","id":51677938,"node_id":"MDQ6VXNlcjUxNjc3OTM4","avatar_url":"https://avatars3.githubusercontent.com/u/51677938?v=4","gravatar_id":"","url":"https://api.github.com/users/whitneyschmidt","html_url":"https://github.com/whitneyschmidt","followers_url":"https://api.github.com/users/whitneyschmidt/followers","following_url":"https://api.github.com/users/whitneyschmidt/following{/other_user}","gists_url":"https://api.github.com/users/whitneyschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/whitneyschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitneyschmidt/subscriptions","organizations_url":"https://api.github.com/users/whitneyschmidt/orgs","repos_url":"https://api.github.com/users/whitneyschmidt/repos","events_url":"https://api.github.com/users/whitneyschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/whitneyschmidt/received_events","type":"User","site_admin":false},"repo":{"id":192787193,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI3ODcxOTM=","name":"xamarin-macios","full_name":"whitneyschmidt/xamarin-macios","private":false,"owner":{"login":"whitneyschmidt","id":51677938,"node_id":"MDQ6VXNlcjUxNjc3OTM4","avatar_url":"https://avatars3.githubusercontent.com/u/51677938?v=4","gravatar_id":"","url":"https://api.github.com/users/whitneyschmidt","html_url":"https://github.com/whitneyschmidt","followers_url":"https://api.github.com/users/whitneyschmidt/followers","following_url":"https://api.github.com/users/whitneyschmidt/following{/other_user}","gists_url":"https://api.github.com/users/whitneyschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/whitneyschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitneyschmidt/subscriptions","organizations_url":"https://api.github.com/users/whitneyschmidt/orgs","repos_url":"https://api.github.com/users/whitneyschmidt/repos","events_url":"https://api.github.com/users/whitneyschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/whitneyschmidt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/whitneyschmidt/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":true,"url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios","forks_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/forks","keys_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/events","assignees_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/merges","archive_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/whitneyschmidt/xamarin-macios/deployments","created_at":"2019-06-19T18:49:31Z","updated_at":"2019-06-19T18:49:47Z","pushed_at":"2019-11-14T21:51:03Z","git_url":"git://github.com/whitneyschmidt/xamarin-macios.git","ssh_url":"git@github.com:whitneyschmidt/xamarin-macios.git","clone_url":"https://github.com/whitneyschmidt/xamarin-macios.git","svn_url":"https://github.com/whitneyschmidt/xamarin-macios","homepage":null,"size":109925,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"5e2231d533926893d9dbc533be542ad1e5a0d262","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":56710511,"node_id":"MDEwOlJlcG9zaXRvcnk1NjcxMDUxMQ==","name":"xamarin-macios","full_name":"xamarin/xamarin-macios","private":false,"owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xamarin/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-macios","forks_url":"https://api.github.com/repos/xamarin/xamarin-macios/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-macios/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-macios/deployments","created_at":"2016-04-20T18:24:26Z","updated_at":"2019-11-14T19:35:32Z","pushed_at":"2019-11-14T23:15:37Z","git_url":"git://github.com/xamarin/xamarin-macios.git","ssh_url":"git@github.com:xamarin/xamarin-macios.git","clone_url":"https://github.com/xamarin/xamarin-macios.git","svn_url":"https://github.com/xamarin/xamarin-macios","homepage":null,"size":110368,"stargazers_count":1718,"watchers_count":1718,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":436,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":344,"open_issues":436,"watchers":1718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/7404"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/7404"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/7404/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/7404/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/9ee8afe4cf7a16fde45ac1b2bc9a9ec62888e144"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"Therzok"}}