payload: {"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/1","id":280996840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwOTk2ODQw","html_url":"https://github.com/shishirsharma/botkit-storage-firestore/pull/1","diff_url":"https://github.com/shishirsharma/botkit-storage-firestore/pull/1.diff","patch_url":"https://github.com/shishirsharma/botkit-storage-firestore/pull/1.patch","issue_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues/1","number":1,"state":"closed","locked":false,"title":"updated firestore get and save methods","user":{"login":"nigelalford","id":3691012,"node_id":"MDQ6VXNlcjM2OTEwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3691012?v=4","gravatar_id":"","url":"https://api.github.com/users/nigelalford","html_url":"https://github.com/nigelalford","followers_url":"https://api.github.com/users/nigelalford/followers","following_url":"https://api.github.com/users/nigelalford/following{/other_user}","gists_url":"https://api.github.com/users/nigelalford/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelalford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelalford/subscriptions","organizations_url":"https://api.github.com/users/nigelalford/orgs","repos_url":"https://api.github.com/users/nigelalford/repos","events_url":"https://api.github.com/users/nigelalford/events{/privacy}","received_events_url":"https://api.github.com/users/nigelalford/received_events","type":"User","site_admin":false},"body":"Not sure how, but my node_modules version of the index.js file differs from your version in the upper sections. Those changes allow a few changes that I think should remain:\r\n* I can pass in 'methods' to define custom collections\r\n* The creation of the method api's are dynamic\r\n\r\nOutside of those changes, I had a problem with google cloud not working for `get` and `all`. Google wants callbacks defined, I suspect this is an API change. \r\n\r\n* Line 121, the `exists` property was not found on the returned document but `empty` is.\r\n* Line 129, the records returned are stored in a `docs` array\r\n\r\nAll existing tests pass, but I'm open to making any other changes deemed necessary to push this PR through. I'm happy to discuss this more if anymore context is needed for this PR.","created_at":"2019-05-22T00:51:02Z","updated_at":"2019-05-24T15:30:44Z","closed_at":"2019-05-24T15:30:44Z","merged_at":null,"merge_commit_sha":"a9901b9fc86918070063baf1291758dfa4afceb7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/1/commits","review_comments_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/1/comments","review_comment_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues/1/comments","statuses_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/statuses/c04990f37dcc9cfb8a62492b937739eacbe26032","head":{"label":"nigelalford:master","ref":"master","sha":"c04990f37dcc9cfb8a62492b937739eacbe26032","user":{"login":"nigelalford","id":3691012,"node_id":"MDQ6VXNlcjM2OTEwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3691012?v=4","gravatar_id":"","url":"https://api.github.com/users/nigelalford","html_url":"https://github.com/nigelalford","followers_url":"https://api.github.com/users/nigelalford/followers","following_url":"https://api.github.com/users/nigelalford/following{/other_user}","gists_url":"https://api.github.com/users/nigelalford/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelalford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelalford/subscriptions","organizations_url":"https://api.github.com/users/nigelalford/orgs","repos_url":"https://api.github.com/users/nigelalford/repos","events_url":"https://api.github.com/users/nigelalford/events{/privacy}","received_events_url":"https://api.github.com/users/nigelalford/received_events","type":"User","site_admin":false},"repo":{"id":187934431,"node_id":"MDEwOlJlcG9zaXRvcnkxODc5MzQ0MzE=","name":"botkit-storage-firestore-v2","full_name":"nigelalford/botkit-storage-firestore-v2","private":false,"owner":{"login":"nigelalford","id":3691012,"node_id":"MDQ6VXNlcjM2OTEwMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3691012?v=4","gravatar_id":"","url":"https://api.github.com/users/nigelalford","html_url":"https://github.com/nigelalford","followers_url":"https://api.github.com/users/nigelalford/followers","following_url":"https://api.github.com/users/nigelalford/following{/other_user}","gists_url":"https://api.github.com/users/nigelalford/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelalford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelalford/subscriptions","organizations_url":"https://api.github.com/users/nigelalford/orgs","repos_url":"https://api.github.com/users/nigelalford/repos","events_url":"https://api.github.com/users/nigelalford/events{/privacy}","received_events_url":"https://api.github.com/users/nigelalford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nigelalford/botkit-storage-firestore-v2","description":"Firestore storage module for Botkit","fork":true,"url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2","forks_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/forks","keys_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/teams","hooks_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/hooks","issue_events_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/issues/events{/number}","events_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/events","assignees_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/assignees{/user}","branches_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/branches{/branch}","tags_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/tags","blobs_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/languages","stargazers_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/stargazers","contributors_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/contributors","subscribers_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/subscribers","subscription_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/subscription","commits_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/contents/{+path}","compare_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/merges","archive_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/downloads","issues_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/issues{/number}","pulls_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/labels{/name}","releases_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/releases{/id}","deployments_url":"https://api.github.com/repos/nigelalford/botkit-storage-firestore-v2/deployments","created_at":"2019-05-22T00:39:16Z","updated_at":"2019-05-24T04:00:00Z","pushed_at":"2019-05-24T03:59:58Z","git_url":"git://github.com/nigelalford/botkit-storage-firestore-v2.git","ssh_url":"git@github.com:nigelalford/botkit-storage-firestore-v2.git","clone_url":"https://github.com/nigelalford/botkit-storage-firestore-v2.git","svn_url":"https://github.com/nigelalford/botkit-storage-firestore-v2","homepage":"http://howdy.ai/botkit","size":55,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shishirsharma:master","ref":"master","sha":"f0d4a722798350c2d9309a60de37f6c03f45ca4a","user":{"login":"shishirsharma","id":476201,"node_id":"MDQ6VXNlcjQ3NjIwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/476201?v=4","gravatar_id":"","url":"https://api.github.com/users/shishirsharma","html_url":"https://github.com/shishirsharma","followers_url":"https://api.github.com/users/shishirsharma/followers","following_url":"https://api.github.com/users/shishirsharma/following{/other_user}","gists_url":"https://api.github.com/users/shishirsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/shishirsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shishirsharma/subscriptions","organizations_url":"https://api.github.com/users/shishirsharma/orgs","repos_url":"https://api.github.com/users/shishirsharma/repos","events_url":"https://api.github.com/users/shishirsharma/events{/privacy}","received_events_url":"https://api.github.com/users/shishirsharma/received_events","type":"User","site_admin":false},"repo":{"id":143605352,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MDUzNTI=","name":"botkit-storage-firestore","full_name":"shishirsharma/botkit-storage-firestore","private":false,"owner":{"login":"shishirsharma","id":476201,"node_id":"MDQ6VXNlcjQ3NjIwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/476201?v=4","gravatar_id":"","url":"https://api.github.com/users/shishirsharma","html_url":"https://github.com/shishirsharma","followers_url":"https://api.github.com/users/shishirsharma/followers","following_url":"https://api.github.com/users/shishirsharma/following{/other_user}","gists_url":"https://api.github.com/users/shishirsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/shishirsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shishirsharma/subscriptions","organizations_url":"https://api.github.com/users/shishirsharma/orgs","repos_url":"https://api.github.com/users/shishirsharma/repos","events_url":"https://api.github.com/users/shishirsharma/events{/privacy}","received_events_url":"https://api.github.com/users/shishirsharma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shishirsharma/botkit-storage-firestore","description":"Firestore storage module for Botkit","fork":true,"url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore","forks_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/forks","keys_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/teams","hooks_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/hooks","issue_events_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues/events{/number}","events_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/events","assignees_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/assignees{/user}","branches_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/branches{/branch}","tags_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/tags","blobs_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/git/refs{/sha}","trees_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/statuses/{sha}","languages_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/languages","stargazers_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/stargazers","contributors_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/contributors","subscribers_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/subscribers","subscription_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/subscription","commits_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/commits{/sha}","git_commits_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/git/commits{/sha}","comments_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/comments{/number}","issue_comment_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues/comments{/number}","contents_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/contents/{+path}","compare_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/merges","archive_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/downloads","issues_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues{/number}","pulls_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls{/number}","milestones_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/milestones{/number}","notifications_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/labels{/name}","releases_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/releases{/id}","deployments_url":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/deployments","created_at":"2018-08-05T11:01:30Z","updated_at":"2019-03-04T03:34:45Z","pushed_at":"2019-05-24T03:59:59Z","git_url":"git://github.com/shishirsharma/botkit-storage-firestore.git","ssh_url":"git@github.com:shishirsharma/botkit-storage-firestore.git","clone_url":"https://github.com/shishirsharma/botkit-storage-firestore.git","svn_url":"https://github.com/shishirsharma/botkit-storage-firestore","homepage":"http://howdy.ai/botkit","size":18,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/1"},"html":{"href":"https://github.com/shishirsharma/botkit-storage-firestore/pull/1"},"issue":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues/1"},"comments":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/shishirsharma/botkit-storage-firestore/statuses/c04990f37dcc9cfb8a62492b937739eacbe26032"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":3957,"deletions":283,"changed_files":9}}
other: {"actor":{"display_login":"nigelalford"}}