payload: {"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/332145448","pull_request_review_id":298292768,"id":332145448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjE0NTQ0OA==","diff_hunk":"@@ -103,6 +103,16 @@ func (c *Reconciler) reconcileDeployment(ctx context.Context, rev *v1alpha1.Revi\n \t\t\t\t\tbreak\n \t\t\t\t}\n \t\t\t}\n+\t\t\tif cond := rev.Status.GetCondition(v1alpha1.RevisionConditionResourcesAvailable); cond != nil && cond.Status == corev1.ConditionFalse {\n+\t\t\t\tfor _, volume := range rev.Spec.Volumes {\n+\t\t\t\t\tif secret := volume.VolumeSource.Secret; secret != nil {\n+\t\t\t\t\t\t_, err := c.secretLister.Secrets(rev.Namespace).Get(secret.SecretName)\n+\t\t\t\t\t\tif err != nil {\n+\t\t\t\t\t\t\trev.Status.MarkSecretNotFound(\"The secret cannot be found\")","path":"pkg/reconciler/revision/reconcile_resources.go","position":9,"original_position":9,"commit_id":"ddbe4b68fb7ed673ab2e580c7bdb49cbe0ff84a2","original_commit_id":"ddbe4b68fb7ed673ab2e580c7bdb49cbe0ff84a2","user":{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},"body":"This seems like a constant string, why is it a parameter.\r\nAlso it is probably useful to include the name of the parameter.\r\nAlso you override the already set error if more than one secret is set incorrectly.\r\nFinally, you presume that the error is `NotFound` which is not correct.","created_at":"2019-10-07T17:33:43Z","updated_at":"2019-10-07T17:38:05Z","html_url":"https://github.com/knative/serving/pull/5760#discussion_r332145448","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/5760","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/332145448"},"html":{"href":"https://github.com/knative/serving/pull/5760#discussion_r332145448"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/5760"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/5760","id":325360589,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1MzYwNTg5","html_url":"https://github.com/knative/serving/pull/5760","diff_url":"https://github.com/knative/serving/pull/5760.diff","patch_url":"https://github.com/knative/serving/pull/5760.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/5760","number":5760,"state":"open","locked":false,"title":"Surface secret error in revision reconciliation","user":{"login":"taragu","id":6353048,"node_id":"MDQ6VXNlcjYzNTMwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6353048?v=4","gravatar_id":"","url":"https://api.github.com/users/taragu","html_url":"https://github.com/taragu","followers_url":"https://api.github.com/users/taragu/followers","following_url":"https://api.github.com/users/taragu/following{/other_user}","gists_url":"https://api.github.com/users/taragu/gists{/gist_id}","starred_url":"https://api.github.com/users/taragu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taragu/subscriptions","organizations_url":"https://api.github.com/users/taragu/orgs","repos_url":"https://api.github.com/users/taragu/repos","events_url":"https://api.github.com/users/taragu/events{/privacy}","received_events_url":"https://api.github.com/users/taragu/received_events","type":"User","site_admin":false},"body":"/lint\r\n\r\nFixes #5103\r\n\r\n## Proposed Changes\r\n\r\n* When deployment times out, check if the secret exists\r\n\r\n**Release Note**\r\n\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2019-10-07T15:24:49Z","updated_at":"2019-10-07T17:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a242089cbcb057edb0d2ab7e9512641f762fd06d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},{"login":"dgerd","id":43425586,"node_id":"MDQ6VXNlcjQzNDI1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/43425586?v=4","gravatar_id":"","url":"https://api.github.com/users/dgerd","html_url":"https://github.com/dgerd","followers_url":"https://api.github.com/users/dgerd/followers","following_url":"https://api.github.com/users/dgerd/following{/other_user}","gists_url":"https://api.github.com/users/dgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/dgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgerd/subscriptions","organizations_url":"https://api.github.com/users/dgerd/orgs","repos_url":"https://api.github.com/users/dgerd/repos","events_url":"https://api.github.com/users/dgerd/events{/privacy}","received_events_url":"https://api.github.com/users/dgerd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":825408057,"node_id":"MDU6TGFiZWw4MjU0MDgwNTc=","url":"https://api.github.com/repos/knative/serving/labels/area/API","name":"area/API","color":"0052cc","default":false},{"id":874441804,"node_id":"MDU6TGFiZWw4NzQ0NDE4MDQ=","url":"https://api.github.com/repos/knative/serving/labels/area/test-and-release","name":"area/test-and-release","color":"daef5f","default":false},{"id":1294350338,"node_id":"MDU6TGFiZWwxMjk0MzUwMzM4","url":"https://api.github.com/repos/knative/serving/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/5760/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/5760/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/5760/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/ddbe4b68fb7ed673ab2e580c7bdb49cbe0ff84a2","head":{"label":"taragu:propagate-secret-failure","ref":"propagate-secret-failure","sha":"ddbe4b68fb7ed673ab2e580c7bdb49cbe0ff84a2","user":{"login":"taragu","id":6353048,"node_id":"MDQ6VXNlcjYzNTMwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6353048?v=4","gravatar_id":"","url":"https://api.github.com/users/taragu","html_url":"https://github.com/taragu","followers_url":"https://api.github.com/users/taragu/followers","following_url":"https://api.github.com/users/taragu/following{/other_user}","gists_url":"https://api.github.com/users/taragu/gists{/gist_id}","starred_url":"https://api.github.com/users/taragu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taragu/subscriptions","organizations_url":"https://api.github.com/users/taragu/orgs","repos_url":"https://api.github.com/users/taragu/repos","events_url":"https://api.github.com/users/taragu/events{/privacy}","received_events_url":"https://api.github.com/users/taragu/received_events","type":"User","site_admin":false},"repo":{"id":194578542,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ1Nzg1NDI=","name":"serving","full_name":"taragu/serving","private":false,"owner":{"login":"taragu","id":6353048,"node_id":"MDQ6VXNlcjYzNTMwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6353048?v=4","gravatar_id":"","url":"https://api.github.com/users/taragu","html_url":"https://github.com/taragu","followers_url":"https://api.github.com/users/taragu/followers","following_url":"https://api.github.com/users/taragu/following{/other_user}","gists_url":"https://api.github.com/users/taragu/gists{/gist_id}","starred_url":"https://api.github.com/users/taragu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taragu/subscriptions","organizations_url":"https://api.github.com/users/taragu/orgs","repos_url":"https://api.github.com/users/taragu/repos","events_url":"https://api.github.com/users/taragu/events{/privacy}","received_events_url":"https://api.github.com/users/taragu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/taragu/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/taragu/serving","forks_url":"https://api.github.com/repos/taragu/serving/forks","keys_url":"https://api.github.com/repos/taragu/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taragu/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taragu/serving/teams","hooks_url":"https://api.github.com/repos/taragu/serving/hooks","issue_events_url":"https://api.github.com/repos/taragu/serving/issues/events{/number}","events_url":"https://api.github.com/repos/taragu/serving/events","assignees_url":"https://api.github.com/repos/taragu/serving/assignees{/user}","branches_url":"https://api.github.com/repos/taragu/serving/branches{/branch}","tags_url":"https://api.github.com/repos/taragu/serving/tags","blobs_url":"https://api.github.com/repos/taragu/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taragu/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taragu/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/taragu/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taragu/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/taragu/serving/languages","stargazers_url":"https://api.github.com/repos/taragu/serving/stargazers","contributors_url":"https://api.github.com/repos/taragu/serving/contributors","subscribers_url":"https://api.github.com/repos/taragu/serving/subscribers","subscription_url":"https://api.github.com/repos/taragu/serving/subscription","commits_url":"https://api.github.com/repos/taragu/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/taragu/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/taragu/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/taragu/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/taragu/serving/contents/{+path}","compare_url":"https://api.github.com/repos/taragu/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taragu/serving/merges","archive_url":"https://api.github.com/repos/taragu/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taragu/serving/downloads","issues_url":"https://api.github.com/repos/taragu/serving/issues{/number}","pulls_url":"https://api.github.com/repos/taragu/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/taragu/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/taragu/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taragu/serving/labels{/name}","releases_url":"https://api.github.com/repos/taragu/serving/releases{/id}","deployments_url":"https://api.github.com/repos/taragu/serving/deployments","created_at":"2019-07-01T01:17:19Z","updated_at":"2019-09-27T18:39:19Z","pushed_at":"2019-10-07T15:33:02Z","git_url":"git://github.com/taragu/serving.git","ssh_url":"git@github.com:taragu/serving.git","clone_url":"https://github.com/taragu/serving.git","svn_url":"https://github.com/taragu/serving","homepage":"https://knative.dev/docs/serving/","size":41848,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"5cee7b100dde6dbb84a93591cd2bbf3ec557fb4e","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2019-10-07T13:46:47Z","pushed_at":"2019-10-07T15:33:04Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"https://knative.dev/docs/serving/","size":41770,"stargazers_count":2303,"watchers_count":2303,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":452,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":313,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":452,"open_issues":313,"watchers":2303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/5760"},"html":{"href":"https://github.com/knative/serving/pull/5760"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/5760"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/5760/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/5760/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/5760/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/ddbe4b68fb7ed673ab2e580c7bdb49cbe0ff84a2"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"vagababov"}}