payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/comments/256534195","pull_request_review_id":203381490,"id":256534195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjUzNDE5NQ==","diff_hunk":"@@ -93,4 +93,34 @@ export const dispatchSyntheticEvent = (element, type, properties = {\n \n export const ASSETS_DIRECTORY = '../examples/assets/';\n \n+/**\n+ * Returns the full path for an asset by name. This is a convenience helper so\n+ * that we don't need to change paths throughout all test suites if we ever\n+ * decide to move files around.\n+ *\n+ * @param {string} name\n+ * @return {string}\n+ */\n export const assetPath = (name) => `${ASSETS_DIRECTORY}${name}`;\n+\n+\n+/**\n+ * Returns truu if the given element is in the tree of the document of the","path":"src/test/helpers.js","position":25,"original_position":25,"commit_id":"5372f9a7180ddc34383a096d5984337e0a2eeeac","original_commit_id":"5372f9a7180ddc34383a096d5984337e0a2eeeac","user":{"login":"cdata","id":240083,"node_id":"MDQ6VXNlcjI0MDA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/240083?v=4","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":"Will fix","created_at":"2019-02-13T18:43:06Z","updated_at":"2019-02-13T18:43:06Z","html_url":"https://github.com/GoogleWebComponents/model-viewer/pull/345#discussion_r256534195","pull_request_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/comments/256534195"},"html":{"href":"https://github.com/GoogleWebComponents/model-viewer/pull/345#discussion_r256534195"},"pull_request":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345"}},"in_reply_to_id":255637737},"pull_request":{"url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345","id":251536904,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNTM2OTA0","html_url":"https://github.com/GoogleWebComponents/model-viewer/pull/345","diff_url":"https://github.com/GoogleWebComponents/model-viewer/pull/345.diff","patch_url":"https://github.com/GoogleWebComponents/model-viewer/pull/345.patch","issue_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/345","number":345,"state":"open","locked":false,"title":"Sparsely announce loading status to screen readers","user":{"login":"cdata","id":240083,"node_id":"MDQ6VXNlcjI0MDA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/240083?v=4","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":"This change proposes providing screenreader users with sparse updates on the current loading status of all `<model-viewer>` elements on the page. Some details of the change:\r\n\r\n - A singleton manages aggregation and observation of the loading state of all `<model-viewer>` instances that apply the `LoadingMixin`\r\n - `<model-viewer>` instances are observed when they connect to the document, and ignored after they disconnect\r\n - Two announcements are made: an initial one (\"There are 3D models that are loading\") and a final one (\"All 3D models have loaded\")\r\n - An initial announcement is made if (and only if) there is at least one `<model-viewer>` in the document\r\n - When all currently observed instances have either loaded or errored, the final announcement is made\r\n - Note: since the status announcer is bundled with the `<model-viewer>` implementation, at least one `<model-viewer>` must be upgraded and in the document for the initial to be made\r\n\r\nHere is a demo of the behavior, using emulated network conditions (\"Fast 3G\" in DevTools):\r\n\r\n![announceloading](https://user-images.githubusercontent.com/240083/52509964-07b3b600-2baf-11e9-9b78-8e378b08d690.gif)\r\n\r\nFixes #301 ","created_at":"2019-02-08T17:12:29Z","updated_at":"2019-02-13T18:43:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f673f61727eb14ff1a55b327285256885fc6ff7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345/commits","review_comments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345/comments","review_comment_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/345/comments","statuses_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/statuses/5372f9a7180ddc34383a096d5984337e0a2eeeac","head":{"label":"GoogleWebComponents:announce-loading-status","ref":"announce-loading-status","sha":"5372f9a7180ddc34383a096d5984337e0a2eeeac","user":{"login":"GoogleWebComponents","id":7328930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMjg5MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328930?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleWebComponents","html_url":"https://github.com/GoogleWebComponents","followers_url":"https://api.github.com/users/GoogleWebComponents/followers","following_url":"https://api.github.com/users/GoogleWebComponents/following{/other_user}","gists_url":"https://api.github.com/users/GoogleWebComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleWebComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleWebComponents/subscriptions","organizations_url":"https://api.github.com/users/GoogleWebComponents/orgs","repos_url":"https://api.github.com/users/GoogleWebComponents/repos","events_url":"https://api.github.com/users/GoogleWebComponents/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleWebComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":153651476,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2NTE0NzY=","name":"model-viewer","full_name":"GoogleWebComponents/model-viewer","private":false,"owner":{"login":"GoogleWebComponents","id":7328930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMjg5MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328930?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleWebComponents","html_url":"https://github.com/GoogleWebComponents","followers_url":"https://api.github.com/users/GoogleWebComponents/followers","following_url":"https://api.github.com/users/GoogleWebComponents/following{/other_user}","gists_url":"https://api.github.com/users/GoogleWebComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleWebComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleWebComponents/subscriptions","organizations_url":"https://api.github.com/users/GoogleWebComponents/orgs","repos_url":"https://api.github.com/users/GoogleWebComponents/repos","events_url":"https://api.github.com/users/GoogleWebComponents/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleWebComponents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleWebComponents/model-viewer","description":"Easily display interactive 3D models on the web and in AR! ","fork":false,"url":"https://api.github.com/repos/GoogleWebComponents/model-viewer","forks_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/forks","keys_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/teams","hooks_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/hooks","issue_events_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/events","assignees_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/tags","blobs_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/languages","stargazers_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/stargazers","contributors_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/contributors","subscribers_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/subscribers","subscription_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/subscription","commits_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/merges","archive_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/downloads","issues_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/labels{/name}","releases_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/deployments","created_at":"2018-10-18T16:05:16Z","updated_at":"2019-02-13T16:55:08Z","pushed_at":"2019-02-13T17:58:47Z","git_url":"git://github.com/GoogleWebComponents/model-viewer.git","ssh_url":"git@github.com:GoogleWebComponents/model-viewer.git","clone_url":"https://github.com/GoogleWebComponents/model-viewer.git","svn_url":"https://github.com/GoogleWebComponents/model-viewer","homepage":"https://googlewebcomponents.github.io/model-viewer/","size":124215,"stargazers_count":369,"watchers_count":369,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":102,"watchers":369,"default_branch":"master"}},"base":{"label":"GoogleWebComponents:master","ref":"master","sha":"4597fe10e9c4fa3ab44dba5e6ec2ffdc032d0ad7","user":{"login":"GoogleWebComponents","id":7328930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMjg5MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328930?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleWebComponents","html_url":"https://github.com/GoogleWebComponents","followers_url":"https://api.github.com/users/GoogleWebComponents/followers","following_url":"https://api.github.com/users/GoogleWebComponents/following{/other_user}","gists_url":"https://api.github.com/users/GoogleWebComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleWebComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleWebComponents/subscriptions","organizations_url":"https://api.github.com/users/GoogleWebComponents/orgs","repos_url":"https://api.github.com/users/GoogleWebComponents/repos","events_url":"https://api.github.com/users/GoogleWebComponents/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleWebComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":153651476,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2NTE0NzY=","name":"model-viewer","full_name":"GoogleWebComponents/model-viewer","private":false,"owner":{"login":"GoogleWebComponents","id":7328930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMjg5MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328930?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleWebComponents","html_url":"https://github.com/GoogleWebComponents","followers_url":"https://api.github.com/users/GoogleWebComponents/followers","following_url":"https://api.github.com/users/GoogleWebComponents/following{/other_user}","gists_url":"https://api.github.com/users/GoogleWebComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleWebComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleWebComponents/subscriptions","organizations_url":"https://api.github.com/users/GoogleWebComponents/orgs","repos_url":"https://api.github.com/users/GoogleWebComponents/repos","events_url":"https://api.github.com/users/GoogleWebComponents/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleWebComponents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleWebComponents/model-viewer","description":"Easily display interactive 3D models on the web and in AR! ","fork":false,"url":"https://api.github.com/repos/GoogleWebComponents/model-viewer","forks_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/forks","keys_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/teams","hooks_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/hooks","issue_events_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/events","assignees_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/tags","blobs_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/languages","stargazers_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/stargazers","contributors_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/contributors","subscribers_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/subscribers","subscription_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/subscription","commits_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/merges","archive_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/downloads","issues_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/labels{/name}","releases_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleWebComponents/model-viewer/deployments","created_at":"2018-10-18T16:05:16Z","updated_at":"2019-02-13T16:55:08Z","pushed_at":"2019-02-13T17:58:47Z","git_url":"git://github.com/GoogleWebComponents/model-viewer.git","ssh_url":"git@github.com:GoogleWebComponents/model-viewer.git","clone_url":"https://github.com/GoogleWebComponents/model-viewer.git","svn_url":"https://github.com/GoogleWebComponents/model-viewer","homepage":"https://googlewebcomponents.github.io/model-viewer/","size":124215,"stargazers_count":369,"watchers_count":369,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":102,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345"},"html":{"href":"https://github.com/GoogleWebComponents/model-viewer/pull/345"},"issue":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/345"},"comments":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleWebComponents/model-viewer/statuses/5372f9a7180ddc34383a096d5984337e0a2eeeac"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"cdata"}}