payload: {"action":"created","issue":{"url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3458","repository_url":"https://api.github.com/repos/jwplayer/jwplayer","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3458/labels{/name}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3458/comments","events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3458/events","html_url":"https://github.com/jwplayer/jwplayer/pull/3458","id":474847083,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyNzE3MjA5","number":3458,"title":"[JW8-8984] Change player aspect ratio in between videos","user":{"login":"robwalch","id":333258,"node_id":"MDQ6VXNlcjMzMzI1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/125","html_url":"https://github.com/jwplayer/jwplayer/milestone/125","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/125/labels","id":4401921,"node_id":"MDk6TWlsZXN0b25lNDQwMTkyMQ==","number":125,"title":"8.10.0","description":null,"creator":{"login":"pajong","id":13631194,"node_id":"MDQ6VXNlcjEzNjMxMTk0","avatar_url":"https://avatars2.githubusercontent.com/u/13631194?v=4","gravatar_id":"","url":"https://api.github.com/users/pajong","html_url":"https://github.com/pajong","followers_url":"https://api.github.com/users/pajong/followers","following_url":"https://api.github.com/users/pajong/following{/other_user}","gists_url":"https://api.github.com/users/pajong/gists{/gist_id}","starred_url":"https://api.github.com/users/pajong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajong/subscriptions","organizations_url":"https://api.github.com/users/pajong/orgs","repos_url":"https://api.github.com/users/pajong/repos","events_url":"https://api.github.com/users/pajong/events{/privacy}","received_events_url":"https://api.github.com/users/pajong/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":5,"state":"open","created_at":"2019-06-12T16:45:34Z","updated_at":"2019-08-01T13:55:41Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2019-07-30T22:17:31Z","updated_at":"2019-08-01T22:40:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3458","html_url":"https://github.com/jwplayer/jwplayer/pull/3458","diff_url":"https://github.com/jwplayer/jwplayer/pull/3458.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/3458.patch"},"body":"### This PR will...\r\nResize the player when `setConfig` is called with `width` `height` or `aspectratio`. The \"resize\" event if fired immediately after a change to `width` and `height` or `aspectratio`.\r\n\r\n### Why is this Pull Request needed?\r\nSo that developers can update any combination of `width`, `height`, `aspectratio` and `stretching` after the player is setup. So, if you just want to update `aspectratio` between playlist items:\r\n\r\n```\r\n{\r\n        width: '100%',\r\n        aspectratio: '16:9',\r\n        events: {\r\n// If your feed has width and height info you could do this on \"playlistItem\"\r\n            visualQuality: function(e) {\r\n                if (e.level && e.level.width) {\r\n                    this.setConfig({\r\n                        aspectratio: e.level.width + ':' + e.level.height\r\n                    });\r\n                }\r\n            }\r\n        },\r\n        playlist: '//video-feed.json'\r\n}\r\n``` \r\n\r\n\r\nHere's an example that will resize the player to 640x360 while ads are playing, with ads filling the player viewport, and then switch to a responsive width with an aspect ratio that matches video when content is playing:\r\n```\r\n{\r\n        // `aspectratio` is only supported with responsive widths\r\n        //  (width must be a percentage)\r\n        width: '100%',\r\n        aspectratio: '16:9',\r\n        events: {\r\n            visualQuality: function(e) {\r\n                if (e.level && e.level.width) {\r\n                    this.setConfig({\r\n                        width: '100%',\r\n                        aspectratio: e.level.width + ':' + e.level.height\r\n                    });\r\n                }\r\n            },\r\n            adBreakStart: function() {\r\n                this.setConfig({\r\n                    width: 640,\r\n                    height: 360,\r\n                    stretching: 'fill'\r\n                });\r\n            },\r\n            adBreakEnd: function() {\r\n                this.setConfig({\r\n                    width: 640,\r\n                    height: 360,\r\n                    stretching: 'uniform'\r\n                });\r\n            }\r\n        },\r\n        playlist: '//video-feed.json',\r\n        advertising: {\r\n            skipoffset: 1,\r\n            tag: 'ad-tag.xml'\r\n        },\r\n    }\r\n```\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\nhttps://github.com/jwplayer/jwplayer-commercial/pull/6910\r\n\r\n#### Addresses Issue(s):\r\nJW8-8984\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments/517483134","html_url":"https://github.com/jwplayer/jwplayer/pull/3458#issuecomment-517483134","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3458","id":517483134,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNzQ4MzEzNA==","user":{"login":"jwplayer-robot","id":5805482,"node_id":"MDQ6VXNlcjU4MDU0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/5805482?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer-robot","html_url":"https://github.com/jwplayer-robot","followers_url":"https://api.github.com/users/jwplayer-robot/followers","following_url":"https://api.github.com/users/jwplayer-robot/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer-robot/subscriptions","organizations_url":"https://api.github.com/users/jwplayer-robot/orgs","repos_url":"https://api.github.com/users/jwplayer-robot/repos","events_url":"https://api.github.com/users/jwplayer-robot/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer-robot/received_events","type":"User","site_admin":false},"created_at":"2019-08-01T22:40:16Z","updated_at":"2019-08-01T22:40:16Z","author_association":"NONE","body":"[:warning:](http://jenkins.jwplayer.com/job/jw7-pr-multi-opensource/787/) MULTI Build for commit 1a0ac1c1074549ba62aa4f18f056c67d53796ba9 is unstable (FAILURE).\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-opensource/7855/) jwplayer build SUCCESS\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-opensource-unit-tests/5149/) jwplayer unit tests SUCCESS\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial/22806/) jwplayer-commercial build SUCCESS\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial-unit-tests/19444/) jwplayer-commercial unit tests SUCCESS\n[:cucumber:.js Allure Report](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial-cucumber-wdio/1636/allure/) FAILURE\n[:cucumber: Allure Report](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial-cucumber/18305/allure/) UNSTABLE\n[:eggplant:](http://player-pr-test-jenkins.longtailvideo.com/builds/22806/archive/test/squash/) Manual Tests\n[:tv:](http://player-pr-test-jenkins.longtailvideo.com/builds/22806/archive/test/view/) Views\n"}}
other: {"actor":{"display_login":"jwplayer-robot"}}