payload: {"action":"closed","number":2860,"pull_request":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2860","id":301851208,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxODUxMjA4","html_url":"https://github.com/ElementsProject/lightning/pull/2860","diff_url":"https://github.com/ElementsProject/lightning/pull/2860.diff","patch_url":"https://github.com/ElementsProject/lightning/pull/2860.patch","issue_url":"https://api.github.com/repos/ElementsProject/lightning/issues/2860","number":2860,"state":"closed","locked":false,"title":"Add optional start_time and end_time filtering parameters to listforwards","user":{"login":"kristapsk","id":4500994,"node_id":"MDQ6VXNlcjQ1MDA5OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4500994?v=4","gravatar_id":"","url":"https://api.github.com/users/kristapsk","html_url":"https://github.com/kristapsk","followers_url":"https://api.github.com/users/kristapsk/followers","following_url":"https://api.github.com/users/kristapsk/following{/other_user}","gists_url":"https://api.github.com/users/kristapsk/gists{/gist_id}","starred_url":"https://api.github.com/users/kristapsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristapsk/subscriptions","organizations_url":"https://api.github.com/users/kristapsk/orgs","repos_url":"https://api.github.com/users/kristapsk/repos","events_url":"https://api.github.com/users/kristapsk/events{/privacy}","received_events_url":"https://api.github.com/users/kristapsk/received_events","type":"User","site_admin":false},"body":"It's useful especially in case of a lot of forwarding happening through node. In my [feereport plugin](https://github.com/kristapsk/lightning-feereport) I'm only interested in last 30 days of forwards, not whole history.\r\n\r\nAlso adds generic support for time parameters. Currently accepts integer timestamps, but can be modified to support decimals and even human readable time strings in the future.\r\n\r\nCouldn't get `tools/update-mocks.sh` working, modified `wallet/test/run-wallet.c` by hand.\r\n\r\nTested with my mainnet node.","created_at":"2019-07-28T18:34:32Z","updated_at":"2019-08-06T04:38:25Z","closed_at":"2019-08-06T04:38:25Z","merged_at":null,"merge_commit_sha":"c736e0af60bcd38263e798621975598b32e72769","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2860/commits","review_comments_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2860/comments","review_comment_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/issues/2860/comments","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/7303b581c013033bdd44f89bee4baf9efe3bb445","head":{"label":"kristapsk:listforwards-timefilter","ref":"listforwards-timefilter","sha":"7303b581c013033bdd44f89bee4baf9efe3bb445","user":{"login":"kristapsk","id":4500994,"node_id":"MDQ6VXNlcjQ1MDA5OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4500994?v=4","gravatar_id":"","url":"https://api.github.com/users/kristapsk","html_url":"https://github.com/kristapsk","followers_url":"https://api.github.com/users/kristapsk/followers","following_url":"https://api.github.com/users/kristapsk/following{/other_user}","gists_url":"https://api.github.com/users/kristapsk/gists{/gist_id}","starred_url":"https://api.github.com/users/kristapsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristapsk/subscriptions","organizations_url":"https://api.github.com/users/kristapsk/orgs","repos_url":"https://api.github.com/users/kristapsk/repos","events_url":"https://api.github.com/users/kristapsk/events{/privacy}","received_events_url":"https://api.github.com/users/kristapsk/received_events","type":"User","site_admin":false},"repo":{"id":159732877,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3MzI4Nzc=","name":"lightning","full_name":"kristapsk/lightning","private":false,"owner":{"login":"kristapsk","id":4500994,"node_id":"MDQ6VXNlcjQ1MDA5OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4500994?v=4","gravatar_id":"","url":"https://api.github.com/users/kristapsk","html_url":"https://github.com/kristapsk","followers_url":"https://api.github.com/users/kristapsk/followers","following_url":"https://api.github.com/users/kristapsk/following{/other_user}","gists_url":"https://api.github.com/users/kristapsk/gists{/gist_id}","starred_url":"https://api.github.com/users/kristapsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristapsk/subscriptions","organizations_url":"https://api.github.com/users/kristapsk/orgs","repos_url":"https://api.github.com/users/kristapsk/repos","events_url":"https://api.github.com/users/kristapsk/events{/privacy}","received_events_url":"https://api.github.com/users/kristapsk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kristapsk/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":true,"url":"https://api.github.com/repos/kristapsk/lightning","forks_url":"https://api.github.com/repos/kristapsk/lightning/forks","keys_url":"https://api.github.com/repos/kristapsk/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kristapsk/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kristapsk/lightning/teams","hooks_url":"https://api.github.com/repos/kristapsk/lightning/hooks","issue_events_url":"https://api.github.com/repos/kristapsk/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/kristapsk/lightning/events","assignees_url":"https://api.github.com/repos/kristapsk/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/kristapsk/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/kristapsk/lightning/tags","blobs_url":"https://api.github.com/repos/kristapsk/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kristapsk/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kristapsk/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/kristapsk/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kristapsk/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/kristapsk/lightning/languages","stargazers_url":"https://api.github.com/repos/kristapsk/lightning/stargazers","contributors_url":"https://api.github.com/repos/kristapsk/lightning/contributors","subscribers_url":"https://api.github.com/repos/kristapsk/lightning/subscribers","subscription_url":"https://api.github.com/repos/kristapsk/lightning/subscription","commits_url":"https://api.github.com/repos/kristapsk/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/kristapsk/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/kristapsk/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/kristapsk/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/kristapsk/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/kristapsk/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kristapsk/lightning/merges","archive_url":"https://api.github.com/repos/kristapsk/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kristapsk/lightning/downloads","issues_url":"https://api.github.com/repos/kristapsk/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/kristapsk/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/kristapsk/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/kristapsk/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kristapsk/lightning/labels{/name}","releases_url":"https://api.github.com/repos/kristapsk/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/kristapsk/lightning/deployments","created_at":"2018-11-29T21:59:38Z","updated_at":"2019-07-27T09:14:49Z","pushed_at":"2019-07-28T18:28:46Z","git_url":"git://github.com/kristapsk/lightning.git","ssh_url":"git@github.com:kristapsk/lightning.git","clone_url":"https://github.com/kristapsk/lightning.git","svn_url":"https://github.com/kristapsk/lightning","homepage":"","size":25994,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ElementsProject:master","ref":"master","sha":"6bb8525e5d233daa9292c14dc2302669c0f49d0a","user":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":37350472,"node_id":"MDEwOlJlcG9zaXRvcnkzNzM1MDQ3Mg==","name":"lightning","full_name":"ElementsProject/lightning","private":false,"owner":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ElementsProject/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":false,"url":"https://api.github.com/repos/ElementsProject/lightning","forks_url":"https://api.github.com/repos/ElementsProject/lightning/forks","keys_url":"https://api.github.com/repos/ElementsProject/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementsProject/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementsProject/lightning/teams","hooks_url":"https://api.github.com/repos/ElementsProject/lightning/hooks","issue_events_url":"https://api.github.com/repos/ElementsProject/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ElementsProject/lightning/events","assignees_url":"https://api.github.com/repos/ElementsProject/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ElementsProject/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ElementsProject/lightning/tags","blobs_url":"https://api.github.com/repos/ElementsProject/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementsProject/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementsProject/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementsProject/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementsProject/lightning/languages","stargazers_url":"https://api.github.com/repos/ElementsProject/lightning/stargazers","contributors_url":"https://api.github.com/repos/ElementsProject/lightning/contributors","subscribers_url":"https://api.github.com/repos/ElementsProject/lightning/subscribers","subscription_url":"https://api.github.com/repos/ElementsProject/lightning/subscription","commits_url":"https://api.github.com/repos/ElementsProject/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementsProject/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementsProject/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElementsProject/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ElementsProject/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementsProject/lightning/merges","archive_url":"https://api.github.com/repos/ElementsProject/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementsProject/lightning/downloads","issues_url":"https://api.github.com/repos/ElementsProject/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ElementsProject/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementsProject/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementsProject/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementsProject/lightning/labels{/name}","releases_url":"https://api.github.com/repos/ElementsProject/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ElementsProject/lightning/deployments","created_at":"2015-06-13T00:04:22Z","updated_at":"2019-08-06T04:07:01Z","pushed_at":"2019-08-06T04:10:37Z","git_url":"git://github.com/ElementsProject/lightning.git","ssh_url":"git@github.com:ElementsProject/lightning.git","clone_url":"https://github.com/ElementsProject/lightning.git","svn_url":"https://github.com/ElementsProject/lightning","homepage":"","size":26372,"stargazers_count":1523,"watchers_count":1523,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":188,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":433,"open_issues":188,"watchers":1523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2860"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/2860"},"issue":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/2860"},"comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/2860/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2860/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2860/commits"},"statuses":{"href":"https://api.github.com/repos/ElementsProject/lightning/statuses/7303b581c013033bdd44f89bee4baf9efe3bb445"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":91,"deletions":22,"changed_files":10}}
other: {"actor":{"display_login":"rustyrussell"}}