payload: {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/352342629","pull_request_review_id":324938142,"id":352342629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjM0MjYyOQ==","diff_hunk":"@@ -136,7 +136,7 @@ in {\n         UMask = \"0007\";\n         # TODO: might get renamed to MATOMO_USER_PATH in future versions\n         # chown + chmod in preStart needs root\n-        PermissionsStartOnly = true;\n+        StateDirectory = \"matomo\";","path":"nixos/modules/services/web-apps/matomo.nix","position":5,"original_position":5,"commit_id":"2da6f99eb438d1fed070c3aa94fc05e27d26dd91","original_commit_id":"2da6f99eb438d1fed070c3aa94fc05e27d26dd91","user":{"login":"aanderse","id":7755101,"node_id":"MDQ6VXNlcjc3NTUxMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/7755101?v=4","gravatar_id":"","url":"https://api.github.com/users/aanderse","html_url":"https://github.com/aanderse","followers_url":"https://api.github.com/users/aanderse/followers","following_url":"https://api.github.com/users/aanderse/following{/other_user}","gists_url":"https://api.github.com/users/aanderse/gists{/gist_id}","starred_url":"https://api.github.com/users/aanderse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanderse/subscriptions","organizations_url":"https://api.github.com/users/aanderse/orgs","repos_url":"https://api.github.com/users/aanderse/repos","events_url":"https://api.github.com/users/aanderse/events{/privacy}","received_events_url":"https://api.github.com/users/aanderse/received_events","type":"User","site_admin":false},"body":"Looks to me like root is potentially required, but unable to determine without looking at previous module. Depends on whether or not you have a `/var/lib/piwik` folder.\r\n\r\nThis is the sorta thing `stateVersion` is for, I guess. Generally we shouldn't do things like this and leave it up to the user if a user name or folder name is really bugging them that much... :man_shrugging:","created_at":"2019-12-01T12:51:52Z","updated_at":"2019-12-01T12:51:53Z","html_url":"https://github.com/NixOS/nixpkgs/pull/74319#discussion_r352342629","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/352342629"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/74319#discussion_r352342629"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319"}},"in_reply_to_id":352211342},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319","id":346160420,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2MTYwNDIw","html_url":"https://github.com/NixOS/nixpkgs/pull/74319","diff_url":"https://github.com/NixOS/nixpkgs/pull/74319.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/74319.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/74319","number":74319,"state":"open","locked":false,"title":"matomo: 3.11.0 -> 3.13.0","user":{"login":"Kiwi","id":35715,"node_id":"MDQ6VXNlcjM1NzE1","avatar_url":"https://avatars0.githubusercontent.com/u/35715?v=4","gravatar_id":"","url":"https://api.github.com/users/Kiwi","html_url":"https://github.com/Kiwi","followers_url":"https://api.github.com/users/Kiwi/followers","following_url":"https://api.github.com/users/Kiwi/following{/other_user}","gists_url":"https://api.github.com/users/Kiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/Kiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kiwi/subscriptions","organizations_url":"https://api.github.com/users/Kiwi/orgs","repos_url":"https://api.github.com/users/Kiwi/repos","events_url":"https://api.github.com/users/Kiwi/events{/privacy}","received_events_url":"https://api.github.com/users/Kiwi/received_events","type":"User","site_admin":false},"body":"<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->\r\n###### Motivation for this change\r\nThe long awaited update to Matomo 3.12.0 has finally arrived! Here it comes... wait what do you mean you missed it?! Oh no, too slow! Well here's 3.13.0 instead!\r\n\r\n###### Things done\r\n\r\nI checked out [this other PR](https://github.com/NixOS/nixpkgs/pull/73577) before I made these additional changes. Now that one is clearly inferior at this point and should be closed in favor of this one so that I don't have to redo everything. :smile:\r\n\r\nI had to add an additional file to the list to fix; and then add in a check to keep the builds succeeding. The matomo-beta would fail when `wc` tried to count a non-existent file that is only in the latest and greatest. No file? No problem! nop! I also removed the recently (within the last few months, I'm sure) deprecated PermissionsStartOnly; and while I'm not certain that there aren't additional necessary changes that I am unaware of I do know I've been running it in production...\r\n\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run \"nix-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Ensured that relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n###### Notify maintainers\r\n\r\ncc @florianjacob @aanderse @dasJ @Kiwi \r\n","created_at":"2019-11-27T10:18:39Z","updated_at":"2019-12-01T12:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cb678eba27ae85ddf38a9038829d9b505846b61","assignee":null,"assignees":[],"requested_reviewers":[{"login":"florianjacob","id":1109959,"node_id":"MDQ6VXNlcjExMDk5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1109959?v=4","gravatar_id":"","url":"https://api.github.com/users/florianjacob","html_url":"https://github.com/florianjacob","followers_url":"https://api.github.com/users/florianjacob/followers","following_url":"https://api.github.com/users/florianjacob/following{/other_user}","gists_url":"https://api.github.com/users/florianjacob/gists{/gist_id}","starred_url":"https://api.github.com/users/florianjacob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florianjacob/subscriptions","organizations_url":"https://api.github.com/users/florianjacob/orgs","repos_url":"https://api.github.com/users/florianjacob/repos","events_url":"https://api.github.com/users/florianjacob/events{/privacy}","received_events_url":"https://api.github.com/users/florianjacob/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false,"description":null},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false,"description":null},{"id":740714914,"node_id":"MDU6TGFiZWw3NDA3MTQ5MTQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/11.by:%20package-maintainer","name":"11.by: package-maintainer","color":"ddeecc","default":false,"description":null},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false,"description":null},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/74319/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2da6f99eb438d1fed070c3aa94fc05e27d26dd91","head":{"label":"Kiwi:matomo-consistency-3.13.0","ref":"matomo-consistency-3.13.0","sha":"2da6f99eb438d1fed070c3aa94fc05e27d26dd91","user":{"login":"Kiwi","id":35715,"node_id":"MDQ6VXNlcjM1NzE1","avatar_url":"https://avatars0.githubusercontent.com/u/35715?v=4","gravatar_id":"","url":"https://api.github.com/users/Kiwi","html_url":"https://github.com/Kiwi","followers_url":"https://api.github.com/users/Kiwi/followers","following_url":"https://api.github.com/users/Kiwi/following{/other_user}","gists_url":"https://api.github.com/users/Kiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/Kiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kiwi/subscriptions","organizations_url":"https://api.github.com/users/Kiwi/orgs","repos_url":"https://api.github.com/users/Kiwi/repos","events_url":"https://api.github.com/users/Kiwi/events{/privacy}","received_events_url":"https://api.github.com/users/Kiwi/received_events","type":"User","site_admin":false},"repo":{"id":172448785,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI0NDg3ODU=","name":"nixpkgs","full_name":"Kiwi/nixpkgs","private":false,"owner":{"login":"Kiwi","id":35715,"node_id":"MDQ6VXNlcjM1NzE1","avatar_url":"https://avatars0.githubusercontent.com/u/35715?v=4","gravatar_id":"","url":"https://api.github.com/users/Kiwi","html_url":"https://github.com/Kiwi","followers_url":"https://api.github.com/users/Kiwi/followers","following_url":"https://api.github.com/users/Kiwi/following{/other_user}","gists_url":"https://api.github.com/users/Kiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/Kiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kiwi/subscriptions","organizations_url":"https://api.github.com/users/Kiwi/orgs","repos_url":"https://api.github.com/users/Kiwi/repos","events_url":"https://api.github.com/users/Kiwi/events{/privacy}","received_events_url":"https://api.github.com/users/Kiwi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kiwi/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Kiwi/nixpkgs","forks_url":"https://api.github.com/repos/Kiwi/nixpkgs/forks","keys_url":"https://api.github.com/repos/Kiwi/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kiwi/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kiwi/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Kiwi/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Kiwi/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Kiwi/nixpkgs/events","assignees_url":"https://api.github.com/repos/Kiwi/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Kiwi/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Kiwi/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Kiwi/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kiwi/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kiwi/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kiwi/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kiwi/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Kiwi/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Kiwi/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Kiwi/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Kiwi/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Kiwi/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Kiwi/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kiwi/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kiwi/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kiwi/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kiwi/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Kiwi/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kiwi/nixpkgs/merges","archive_url":"https://api.github.com/repos/Kiwi/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kiwi/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Kiwi/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Kiwi/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Kiwi/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Kiwi/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kiwi/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Kiwi/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Kiwi/nixpkgs/deployments","created_at":"2019-02-25T06:38:23Z","updated_at":"2019-11-30T18:06:31Z","pushed_at":"2019-11-30T18:06:27Z","git_url":"git://github.com/Kiwi/nixpkgs.git","ssh_url":"git@github.com:Kiwi/nixpkgs.git","clone_url":"https://github.com/Kiwi/nixpkgs.git","svn_url":"https://github.com/Kiwi/nixpkgs","homepage":null,"size":1058114,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"25a95a97647deddc61e64a92ba512356771b2091","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-12-01T12:26:12Z","pushed_at":"2019-12-01T12:33:51Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":1080330,"stargazers_count":4433,"watchers_count":4433,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4258,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4258,"open_issues":5132,"watchers":4433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/74319"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/74319"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/74319/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/74319/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2da6f99eb438d1fed070c3aa94fc05e27d26dd91"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"aanderse"}}