payload: {"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments/301998071","pull_request_review_id":260009293,"id":301998071,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTk5ODA3MQ==","diff_hunk":"@@ -21,5 +21,6 @@ export async function getKubeConfig(): Promise<string> {\n     var clusterName : string = tl.getInput(\"kubernetesCluster\", true);\n     var azureSubscriptionEndpoint : string = tl.getInput(\"azureSubscriptionEndpoint\", true);\n     var resourceGroup : string = tl.getInput(\"azureResourceGroup\", true);\n-    return getKubeConfigFromAKS(azureSubscriptionEndpoint, resourceGroup, clusterName);\n+    var useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');\n+    return getKubeConfigFromAKS(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin);","path":"Tasks/HelmDeployV0/src/clusters/armkubernetescluster.ts","position":22,"original_position":22,"commit_id":"4a9a0951cedeca60025f6809729cfbdf22c8f614","original_commit_id":"4a9a0951cedeca60025f6809729cfbdf22c8f614","user":{"login":"bansalaseem","id":22289943,"node_id":"MDQ6VXNlcjIyMjg5OTQz","avatar_url":"https://avatars1.githubusercontent.com/u/22289943?v=4","gravatar_id":"","url":"https://api.github.com/users/bansalaseem","html_url":"https://github.com/bansalaseem","followers_url":"https://api.github.com/users/bansalaseem/followers","following_url":"https://api.github.com/users/bansalaseem/following{/other_user}","gists_url":"https://api.github.com/users/bansalaseem/gists{/gist_id}","starred_url":"https://api.github.com/users/bansalaseem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bansalaseem/subscriptions","organizations_url":"https://api.github.com/users/bansalaseem/orgs","repos_url":"https://api.github.com/users/bansalaseem/repos","events_url":"https://api.github.com/users/bansalaseem/events{/privacy}","received_events_url":"https://api.github.com/users/bansalaseem/received_events","type":"User","site_admin":false},"body":"will it fail for the existing definitions because they dont have useClusteradmin property?","created_at":"2019-07-10T10:39:23Z","updated_at":"2019-07-10T10:39:23Z","html_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/10867#discussion_r301998071","pull_request_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments/301998071"},"html":{"href":"https://github.com/microsoft/azure-pipelines-tasks/pull/10867#discussion_r301998071"},"pull_request":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867","id":296102385,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MTAyMzg1","html_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/10867","diff_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/10867.diff","patch_url":"https://github.com/microsoft/azure-pipelines-tasks/pull/10867.patch","issue_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/10867","number":10867,"state":"open","locked":false,"title":"Added use admin creds option for helm deploy task","user":{"login":"dabasnidhi","id":12389221,"node_id":"MDQ6VXNlcjEyMzg5MjIx","avatar_url":"https://avatars0.githubusercontent.com/u/12389221?v=4","gravatar_id":"","url":"https://api.github.com/users/dabasnidhi","html_url":"https://github.com/dabasnidhi","followers_url":"https://api.github.com/users/dabasnidhi/followers","following_url":"https://api.github.com/users/dabasnidhi/following{/other_user}","gists_url":"https://api.github.com/users/dabasnidhi/gists{/gist_id}","starred_url":"https://api.github.com/users/dabasnidhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabasnidhi/subscriptions","organizations_url":"https://api.github.com/users/dabasnidhi/orgs","repos_url":"https://api.github.com/users/dabasnidhi/repos","events_url":"https://api.github.com/users/dabasnidhi/events{/privacy}","received_events_url":"https://api.github.com/users/dabasnidhi/received_events","type":"User","site_admin":false},"body":"In the kubernetes deployment task , there is an option \"Use cluster admin credentials\" for the service connection type \"Azure Resource Manager\". Have added the same for \"Package and deploy Helm charts\" task for the same connection type.\r\nRelated issue- https://github.com/microsoft/azure-pipelines-tasks/issues/10022\r\n![image](https://user-images.githubusercontent.com/12389221/60960941-ac861b00-a328-11e9-90c9-2f1685bc2686.png)\r\n","created_at":"2019-07-10T10:08:16Z","updated_at":"2019-07-10T10:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"624ae831db6ec4ac1203e205c3120ff31f692c95","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ajinkya599","id":11447401,"node_id":"MDQ6VXNlcjExNDQ3NDAx","avatar_url":"https://avatars3.githubusercontent.com/u/11447401?v=4","gravatar_id":"","url":"https://api.github.com/users/ajinkya599","html_url":"https://github.com/ajinkya599","followers_url":"https://api.github.com/users/ajinkya599/followers","following_url":"https://api.github.com/users/ajinkya599/following{/other_user}","gists_url":"https://api.github.com/users/ajinkya599/gists{/gist_id}","starred_url":"https://api.github.com/users/ajinkya599/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajinkya599/subscriptions","organizations_url":"https://api.github.com/users/ajinkya599/orgs","repos_url":"https://api.github.com/users/ajinkya599/repos","events_url":"https://api.github.com/users/ajinkya599/events{/privacy}","received_events_url":"https://api.github.com/users/ajinkya599/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867/commits","review_comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867/comments","review_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/10867/comments","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/4a9a0951cedeca60025f6809729cfbdf22c8f614","head":{"label":"microsoft:users/nidabas/HelmUpdate","ref":"users/nidabas/HelmUpdate","sha":"4a9a0951cedeca60025f6809729cfbdf22c8f614","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"azure-pipelines-tasks","full_name":"microsoft/azure-pipelines-tasks","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azure-pipelines-tasks","description":"Tasks for Azure Pipelines","fork":false,"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks","forks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/forks","keys_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/teams","hooks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/events","assignees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/tags","blobs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/languages","stargazers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscription","commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/merges","archive_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/downloads","issues_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2019-07-09T22:00:22Z","pushed_at":"2019-07-10T10:27:49Z","git_url":"git://github.com/microsoft/azure-pipelines-tasks.git","ssh_url":"git@github.com:microsoft/azure-pipelines-tasks.git","clone_url":"https://github.com/microsoft/azure-pipelines-tasks.git","svn_url":"https://github.com/microsoft/azure-pipelines-tasks","homepage":"https://aka.ms/tfbuild","size":410324,"stargazers_count":1532,"watchers_count":1532,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1200,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":605,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1200,"open_issues":605,"watchers":1532,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"ecff2844a4291aab7ee70a6c5c777ea883cbe20a","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"azure-pipelines-tasks","full_name":"microsoft/azure-pipelines-tasks","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azure-pipelines-tasks","description":"Tasks for Azure Pipelines","fork":false,"url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks","forks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/forks","keys_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/teams","hooks_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/events","assignees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/tags","blobs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/languages","stargazers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/subscription","commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/merges","archive_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/downloads","issues_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2019-07-09T22:00:22Z","pushed_at":"2019-07-10T10:27:49Z","git_url":"git://github.com/microsoft/azure-pipelines-tasks.git","ssh_url":"git@github.com:microsoft/azure-pipelines-tasks.git","clone_url":"https://github.com/microsoft/azure-pipelines-tasks.git","svn_url":"https://github.com/microsoft/azure-pipelines-tasks","homepage":"https://aka.ms/tfbuild","size":410324,"stargazers_count":1532,"watchers_count":1532,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1200,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":605,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1200,"open_issues":605,"watchers":1532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867"},"html":{"href":"https://github.com/microsoft/azure-pipelines-tasks/pull/10867"},"issue":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/10867"},"comments":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/issues/10867/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/pulls/10867/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/azure-pipelines-tasks/statuses/4a9a0951cedeca60025f6809729cfbdf22c8f614"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"bansalaseem"}}