payload: {"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/299","repository_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy","labels_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/299/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/299/events","html_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/299","id":534243003,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMTg3NTE4","number":299,"title":"Store CritAncestor condition in the forest","user":{"login":"yiqigao217","id":51385444,"node_id":"MDQ6VXNlcjUxMzg1NDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/51385444?v=4","gravatar_id":"","url":"https://api.github.com/users/yiqigao217","html_url":"https://github.com/yiqigao217","followers_url":"https://api.github.com/users/yiqigao217/followers","following_url":"https://api.github.com/users/yiqigao217/following{/other_user}","gists_url":"https://api.github.com/users/yiqigao217/gists{/gist_id}","starred_url":"https://api.github.com/users/yiqigao217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiqigao217/subscriptions","organizations_url":"https://api.github.com/users/yiqigao217/orgs","repos_url":"https://api.github.com/users/yiqigao217/repos","events_url":"https://api.github.com/users/yiqigao217/events{/privacy}","received_events_url":"https://api.github.com/users/yiqigao217/received_events","type":"User","site_admin":false},"labels":[{"id":1262095667,"node_id":"MDU6TGFiZWwxMjYyMDk1NjY3","url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false,"description":"Indicates the PR's author has signed the CNCF CLA."},{"id":1262095305,"node_id":"MDU6TGFiZWwxMjYyMDk1MzA1","url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/labels/size/M","name":"size/M","color":"eebb00","default":false,"description":"Denotes a PR that changes 30-99 lines, ignoring generated files."}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-12-06T20:28:11Z","updated_at":"2019-12-06T20:28:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/pulls/299","html_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/299","diff_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/299.diff","patch_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/299.patch"},"body":"This is part of #282 and #195 \r\n\r\nCritAncestor condition is set when any ancestor has local critical\r\nconditions. Currently, it's only set in the HierarchyConfiguration\r\nobject. This commit sets the CritAncestor condition in the forest first\r\nwith ancestor namespace as the key. This change enables object\r\ncontroller to just look in the forest to find all critical conditions in\r\nthe namespaces, so that it can stop propagation if any condition\r\ndetected.\r\n\r\nTested with \"make test\" and \"make test NOC=1\" and all tests passed."},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/comments/562726038","html_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/299#issuecomment-562726038","issue_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/299","id":562726038,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MjcyNjAzOA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-12-06T20:28:26Z","updated_at":"2019-12-06T20:28:26Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes-sigs/multi-tenancy/pull/299#\" title=\"Author self-approved\">yiqigao217</a>*\nTo complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **dtoledo67**\nYou can assign the PR to them by writing `/assign @dtoledo67` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fmulti-tenancy).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes-sigs/multi-tenancy/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dtoledo67\"]} -->"}}
other: {"actor":{"display_login":"k8s-ci-robot"}}