payload: {"action":"created","comment":{"url":"https://api.github.com/repos/denoland/deno/pulls/comments/277188921","pull_request_review_id":228935100,"id":277188921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzE4ODkyMQ==","diff_hunk":"@@ -179,3 +193,37 @@ export function run(opt: RunOptions): Process {\n \n   return new Process(res);\n }\n+\n+export enum Signal {\n+  SIGHUP = 1,\n+  SIGINT,\n+  SIGQUIT,","path":"js/process.ts","position":null,"original_position":36,"commit_id":"add5d7b8b23a923de86a394a33f41d54ce748f8e","original_commit_id":"6a63aba03e0fea6b13aaeecc216d3fc86b07bbdd","user":{"login":"ry","id":80,"node_id":"MDQ6VXNlcjgw","avatar_url":"https://avatars1.githubusercontent.com/u/80?v=4","gravatar_id":"","url":"https://api.github.com/users/ry","html_url":"https://github.com/ry","followers_url":"https://api.github.com/users/ry/followers","following_url":"https://api.github.com/users/ry/following{/other_user}","gists_url":"https://api.github.com/users/ry/gists{/gist_id}","starred_url":"https://api.github.com/users/ry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry/subscriptions","organizations_url":"https://api.github.com/users/ry/orgs","repos_url":"https://api.github.com/users/ry/repos","events_url":"https://api.github.com/users/ry/events{/privacy}","received_events_url":"https://api.github.com/users/ry/received_events","type":"User","site_admin":false},"body":"Ok that works ","created_at":"2019-04-22T01:23:46Z","updated_at":"2019-04-22T01:23:46Z","html_url":"https://github.com/denoland/deno/pull/2177#discussion_r277188921","pull_request_url":"https://api.github.com/repos/denoland/deno/pulls/2177","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/denoland/deno/pulls/comments/277188921"},"html":{"href":"https://github.com/denoland/deno/pull/2177#discussion_r277188921"},"pull_request":{"href":"https://api.github.com/repos/denoland/deno/pulls/2177"}},"in_reply_to_id":277185326},"pull_request":{"url":"https://api.github.com/repos/denoland/deno/pulls/2177","id":272245172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMjQ1MTcy","html_url":"https://github.com/denoland/deno/pull/2177","diff_url":"https://github.com/denoland/deno/pull/2177.diff","patch_url":"https://github.com/denoland/deno/pull/2177.patch","issue_url":"https://api.github.com/repos/denoland/deno/issues/2177","number":2177,"state":"open","locked":false,"title":"Add Deno.kill(pid, signo) and process.kill(signo) (Unix only)","user":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"body":"Implemented for Unix only first.\r\n\r\n+ Node: [`process.kill(pid[, signal])`](https://nodejs.org/api/process.html#process_process_kill_pid_signal)\r\n+ Python: [`os.kill(pid, sig)`](https://docs.python.org/2/library/os.html#os.kill)\r\n+ C: [`int kill(pid_t pid, int sig)`](http://man7.org/linux/man-pages/man2/kill.2.html)\r\n+ Go: [`os.FindProcess` + `func (p *Process) Signal(sig Signal) error`](https://golang.org/pkg/os/#Process.Signal)\r\n\r\nAlso add a test to verify if process gets killed on `close` is working fine. If it works, then we might want to close #1494 ","created_at":"2019-04-21T22:27:27Z","updated_at":"2019-04-22T01:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"758e482534f53afe1aec6528f01151a687a9bd0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/denoland/deno/pulls/2177/commits","review_comments_url":"https://api.github.com/repos/denoland/deno/pulls/2177/comments","review_comment_url":"https://api.github.com/repos/denoland/deno/pulls/comments{/number}","comments_url":"https://api.github.com/repos/denoland/deno/issues/2177/comments","statuses_url":"https://api.github.com/repos/denoland/deno/statuses/add5d7b8b23a923de86a394a33f41d54ce748f8e","head":{"label":"kevinkassimo:process/kill","ref":"process/kill","sha":"add5d7b8b23a923de86a394a33f41d54ce748f8e","user":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"repo":{"id":136137114,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxMzcxMTQ=","name":"deno","full_name":"kevinkassimo/deno","private":false,"owner":{"login":"kevinkassimo","id":15007517,"node_id":"MDQ6VXNlcjE1MDA3NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/15007517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkassimo","html_url":"https://github.com/kevinkassimo","followers_url":"https://api.github.com/users/kevinkassimo/followers","following_url":"https://api.github.com/users/kevinkassimo/following{/other_user}","gists_url":"https://api.github.com/users/kevinkassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkassimo/subscriptions","organizations_url":"https://api.github.com/users/kevinkassimo/orgs","repos_url":"https://api.github.com/users/kevinkassimo/repos","events_url":"https://api.github.com/users/kevinkassimo/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkassimo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kevinkassimo/deno","description":"A secure TypeScript runtime on V8","fork":true,"url":"https://api.github.com/repos/kevinkassimo/deno","forks_url":"https://api.github.com/repos/kevinkassimo/deno/forks","keys_url":"https://api.github.com/repos/kevinkassimo/deno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinkassimo/deno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinkassimo/deno/teams","hooks_url":"https://api.github.com/repos/kevinkassimo/deno/hooks","issue_events_url":"https://api.github.com/repos/kevinkassimo/deno/issues/events{/number}","events_url":"https://api.github.com/repos/kevinkassimo/deno/events","assignees_url":"https://api.github.com/repos/kevinkassimo/deno/assignees{/user}","branches_url":"https://api.github.com/repos/kevinkassimo/deno/branches{/branch}","tags_url":"https://api.github.com/repos/kevinkassimo/deno/tags","blobs_url":"https://api.github.com/repos/kevinkassimo/deno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinkassimo/deno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinkassimo/deno/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinkassimo/deno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinkassimo/deno/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinkassimo/deno/languages","stargazers_url":"https://api.github.com/repos/kevinkassimo/deno/stargazers","contributors_url":"https://api.github.com/repos/kevinkassimo/deno/contributors","subscribers_url":"https://api.github.com/repos/kevinkassimo/deno/subscribers","subscription_url":"https://api.github.com/repos/kevinkassimo/deno/subscription","commits_url":"https://api.github.com/repos/kevinkassimo/deno/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinkassimo/deno/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinkassimo/deno/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinkassimo/deno/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinkassimo/deno/contents/{+path}","compare_url":"https://api.github.com/repos/kevinkassimo/deno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinkassimo/deno/merges","archive_url":"https://api.github.com/repos/kevinkassimo/deno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinkassimo/deno/downloads","issues_url":"https://api.github.com/repos/kevinkassimo/deno/issues{/number}","pulls_url":"https://api.github.com/repos/kevinkassimo/deno/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinkassimo/deno/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinkassimo/deno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinkassimo/deno/labels{/name}","releases_url":"https://api.github.com/repos/kevinkassimo/deno/releases{/id}","deployments_url":"https://api.github.com/repos/kevinkassimo/deno/deployments","created_at":"2018-06-05T07:25:02Z","updated_at":"2019-03-20T18:07:02Z","pushed_at":"2019-04-22T00:44:32Z","git_url":"git://github.com/kevinkassimo/deno.git","ssh_url":"git@github.com:kevinkassimo/deno.git","clone_url":"https://github.com/kevinkassimo/deno.git","svn_url":"https://github.com/kevinkassimo/deno","homepage":"","size":4187,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"denoland:master","ref":"master","sha":"9dfebbc9496138efbeedc431068f41662c780f3e","user":{"login":"denoland","id":42048915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQ4OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/42048915?v=4","gravatar_id":"","url":"https://api.github.com/users/denoland","html_url":"https://github.com/denoland","followers_url":"https://api.github.com/users/denoland/followers","following_url":"https://api.github.com/users/denoland/following{/other_user}","gists_url":"https://api.github.com/users/denoland/gists{/gist_id}","starred_url":"https://api.github.com/users/denoland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denoland/subscriptions","organizations_url":"https://api.github.com/users/denoland/orgs","repos_url":"https://api.github.com/users/denoland/repos","events_url":"https://api.github.com/users/denoland/events{/privacy}","received_events_url":"https://api.github.com/users/denoland/received_events","type":"Organization","site_admin":false},"repo":{"id":133442384,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDIzODQ=","name":"deno","full_name":"denoland/deno","private":false,"owner":{"login":"denoland","id":42048915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQ4OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/42048915?v=4","gravatar_id":"","url":"https://api.github.com/users/denoland","html_url":"https://github.com/denoland","followers_url":"https://api.github.com/users/denoland/followers","following_url":"https://api.github.com/users/denoland/following{/other_user}","gists_url":"https://api.github.com/users/denoland/gists{/gist_id}","starred_url":"https://api.github.com/users/denoland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denoland/subscriptions","organizations_url":"https://api.github.com/users/denoland/orgs","repos_url":"https://api.github.com/users/denoland/repos","events_url":"https://api.github.com/users/denoland/events{/privacy}","received_events_url":"https://api.github.com/users/denoland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/denoland/deno","description":"A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio","fork":false,"url":"https://api.github.com/repos/denoland/deno","forks_url":"https://api.github.com/repos/denoland/deno/forks","keys_url":"https://api.github.com/repos/denoland/deno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denoland/deno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denoland/deno/teams","hooks_url":"https://api.github.com/repos/denoland/deno/hooks","issue_events_url":"https://api.github.com/repos/denoland/deno/issues/events{/number}","events_url":"https://api.github.com/repos/denoland/deno/events","assignees_url":"https://api.github.com/repos/denoland/deno/assignees{/user}","branches_url":"https://api.github.com/repos/denoland/deno/branches{/branch}","tags_url":"https://api.github.com/repos/denoland/deno/tags","blobs_url":"https://api.github.com/repos/denoland/deno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denoland/deno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denoland/deno/git/refs{/sha}","trees_url":"https://api.github.com/repos/denoland/deno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denoland/deno/statuses/{sha}","languages_url":"https://api.github.com/repos/denoland/deno/languages","stargazers_url":"https://api.github.com/repos/denoland/deno/stargazers","contributors_url":"https://api.github.com/repos/denoland/deno/contributors","subscribers_url":"https://api.github.com/repos/denoland/deno/subscribers","subscription_url":"https://api.github.com/repos/denoland/deno/subscription","commits_url":"https://api.github.com/repos/denoland/deno/commits{/sha}","git_commits_url":"https://api.github.com/repos/denoland/deno/git/commits{/sha}","comments_url":"https://api.github.com/repos/denoland/deno/comments{/number}","issue_comment_url":"https://api.github.com/repos/denoland/deno/issues/comments{/number}","contents_url":"https://api.github.com/repos/denoland/deno/contents/{+path}","compare_url":"https://api.github.com/repos/denoland/deno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denoland/deno/merges","archive_url":"https://api.github.com/repos/denoland/deno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denoland/deno/downloads","issues_url":"https://api.github.com/repos/denoland/deno/issues{/number}","pulls_url":"https://api.github.com/repos/denoland/deno/pulls{/number}","milestones_url":"https://api.github.com/repos/denoland/deno/milestones{/number}","notifications_url":"https://api.github.com/repos/denoland/deno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denoland/deno/labels{/name}","releases_url":"https://api.github.com/repos/denoland/deno/releases{/id}","deployments_url":"https://api.github.com/repos/denoland/deno/deployments","created_at":"2018-05-15T01:34:26Z","updated_at":"2019-04-22T01:06:53Z","pushed_at":"2019-04-22T00:44:34Z","git_url":"git://github.com/denoland/deno.git","ssh_url":"git@github.com:denoland/deno.git","clone_url":"https://github.com/denoland/deno.git","svn_url":"https://github.com/denoland/deno","homepage":"https://deno.land/","size":18070,"stargazers_count":33407,"watchers_count":33407,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1595,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":204,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1595,"open_issues":204,"watchers":33407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/denoland/deno/pulls/2177"},"html":{"href":"https://github.com/denoland/deno/pull/2177"},"issue":{"href":"https://api.github.com/repos/denoland/deno/issues/2177"},"comments":{"href":"https://api.github.com/repos/denoland/deno/issues/2177/comments"},"review_comments":{"href":"https://api.github.com/repos/denoland/deno/pulls/2177/comments"},"review_comment":{"href":"https://api.github.com/repos/denoland/deno/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/denoland/deno/pulls/2177/commits"},"statuses":{"href":"https://api.github.com/repos/denoland/deno/statuses/add5d7b8b23a923de86a394a33f41d54ce748f8e"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"ry"}}