payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments/308057003","pull_request_review_id":267569278,"id":308057003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODA1NzAwMw==","diff_hunk":"@@ -113,6 +127,23 @@ - (NSDictionary *)jsonDictionary\n     return dictionary;\n }\n \n+- (NSString *)URLMapSubkey:(BOOL)instanceAware\n+{\n+    // The subkey is in the of format of @\"URLMap-key1=value1&key2=value2...\",\n+    // where key1, key2... are the request parameters that may affect the url mapping.\n+    // Currently the only parameter that affects the mapping is instance aware flag.\n+    //\n+    // Example of subkeys:\n+    // \"URLMap-\" : with all possible keys being their default value repectively. Default\n+    //             value of instance_aware is NO, so \"URLMap-\" represents \"URLMap-instance_aware=NO\"\n+    // \"URLMap-instance_aware=YES\" : with instance_aware being YES.\n+    //\n+    // The benefit of such a design is, if we are introducing new parameters what will affect the\n+    // mapping, there will be no breaking change to existing clients who don't use the new parameters.\n+    \n+    return instanceAware ? @\"URLMap-instance_aware=YES\" : @\"URLMap-\";","path":"IdentityCore/src/cache/metadata/accountMetadata/MSIDAccountMetadataCacheItem.m","position":73,"original_position":73,"commit_id":"8fcce91bdb9198359b605532ed2591a1adeb1781","original_commit_id":"8fcce91bdb9198359b605532ed2591a1adeb1781","user":{"login":"antrix1989","id":1989385,"node_id":"MDQ6VXNlcjE5ODkzODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1989385?v=4","gravatar_id":"","url":"https://api.github.com/users/antrix1989","html_url":"https://github.com/antrix1989","followers_url":"https://api.github.com/users/antrix1989/followers","following_url":"https://api.github.com/users/antrix1989/following{/other_user}","gists_url":"https://api.github.com/users/antrix1989/gists{/gist_id}","starred_url":"https://api.github.com/users/antrix1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antrix1989/subscriptions","organizations_url":"https://api.github.com/users/antrix1989/orgs","repos_url":"https://api.github.com/users/antrix1989/repos","events_url":"https://api.github.com/users/antrix1989/events{/privacy}","received_events_url":"https://api.github.com/users/antrix1989/received_events","type":"User","site_admin":false},"body":"+1, since \"URLMap\" is part of the key, we could use flat dictionary here.","created_at":"2019-07-29T05:08:10Z","updated_at":"2019-07-29T05:08:10Z","html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/505#discussion_r308057003","pull_request_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments/308057003"},"html":{"href":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/505#discussion_r308057003"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505"}},"in_reply_to_id":307983217},"pull_request":{"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505","id":301292757,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMjkyNzU3","html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/505","diff_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/505.diff","patch_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/505.patch","issue_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/505","number":505,"state":"open","locked":false,"title":"Make instance aware part of the key of account metadata","user":{"login":"jasoncoolmax","id":8347347,"node_id":"MDQ6VXNlcjgzNDczNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8347347?v=4","gravatar_id":"","url":"https://api.github.com/users/jasoncoolmax","html_url":"https://github.com/jasoncoolmax","followers_url":"https://api.github.com/users/jasoncoolmax/followers","following_url":"https://api.github.com/users/jasoncoolmax/following{/other_user}","gists_url":"https://api.github.com/users/jasoncoolmax/gists{/gist_id}","starred_url":"https://api.github.com/users/jasoncoolmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasoncoolmax/subscriptions","organizations_url":"https://api.github.com/users/jasoncoolmax/orgs","repos_url":"https://api.github.com/users/jasoncoolmax/repos","events_url":"https://api.github.com/users/jasoncoolmax/events{/privacy}","received_events_url":"https://api.github.com/users/jasoncoolmax/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-25T20:10:25Z","updated_at":"2019-07-29T05:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32452619bedfe263e48ff97f8e8c9474fe2e9429","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1350275418,"node_id":"MDU6TGFiZWwxMzUwMjc1NDE4","url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/labels/0.5.0","name":"0.5.0","color":"0f189b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505/commits","review_comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505/comments","review_comment_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/505/comments","statuses_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/8fcce91bdb9198359b605532ed2591a1adeb1781","head":{"label":"AzureAD:jason/makeAccountMetadataInstanceAware","ref":"jason/makeAccountMetadataInstanceAware","sha":"8fcce91bdb9198359b605532ed2591a1adeb1781","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":109302939,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMDI5Mzk=","name":"microsoft-authentication-library-common-for-objc","full_name":"AzureAD/microsoft-authentication-library-common-for-objc","private":false,"owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","description":"Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)","fork":false,"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc","forks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/deployments","created_at":"2017-11-02T18:22:35Z","updated_at":"2019-05-25T00:36:40Z","pushed_at":"2019-07-29T04:19:44Z","git_url":"git://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","ssh_url":"git@github.com:AzureAD/microsoft-authentication-library-common-for-objc.git","clone_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","svn_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","homepage":null,"size":7054,"stargazers_count":5,"watchers_count":5,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":58,"watchers":5,"default_branch":"master"}},"base":{"label":"AzureAD:release/1.3.0","ref":"release/1.3.0","sha":"3c6906c11cf9b80962fea152615bee1b462b87af","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":109302939,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMDI5Mzk=","name":"microsoft-authentication-library-common-for-objc","full_name":"AzureAD/microsoft-authentication-library-common-for-objc","private":false,"owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","description":"Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)","fork":false,"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc","forks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/deployments","created_at":"2017-11-02T18:22:35Z","updated_at":"2019-05-25T00:36:40Z","pushed_at":"2019-07-29T04:19:44Z","git_url":"git://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","ssh_url":"git@github.com:AzureAD/microsoft-authentication-library-common-for-objc.git","clone_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","svn_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","homepage":null,"size":7054,"stargazers_count":5,"watchers_count":5,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":58,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505"},"html":{"href":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/505"},"issue":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/505"},"comments":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/8fcce91bdb9198359b605532ed2591a1adeb1781"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"antrix1989"}}