payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twosigma/Cook/pulls/comments/340672266","pull_request_review_id":309277644,"id":340672266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDY3MjI2Ng==","diff_hunk":"@@ -582,18 +582,24 @@\n             (when is-rate-limited?\n               (swap! user->rate-limit-count update user #(inc (or % 0))))\n             (not (and is-rate-limited? enforcing-job-launch-rate-limit?))))\n-        considerable-jobs\n-        (->> pending-jobs\n-             (util/filter-based-on-quota user->quota user->usage)\n-             (filter (fn [job] (util/job-allowed-to-start? db job)))\n-             (filter user-within-launch-rate-limit?-fn)\n-             (filter launch-plugin/filter-job-launches)\n-             (take num-considerable)\n-             ; Force this to be taken eagerly so that the log line is accurate.\n-             (doall))]\n+        quota-filter-jobs (util/filter-based-on-quota user->quota user->usage pending-jobs)\n+        allowed-to-start-jobs (filter (fn [job] (util/job-allowed-to-start? db job)) quota-filter-jobs)\n+        within-launch-rate-jobs (filter user-within-launch-rate-limit?-fn allowed-to-start-jobs)\n+        launch-plugin-jobs (filter launch-plugin/filter-job-launches within-launch-rate-jobs)","path":"scheduler/src/cook/scheduler/scheduler.clj","position":16,"original_position":16,"commit_id":"8de0dee7d0b44d9298c8908e8ef656db3f235776","original_commit_id":"bdea9be61d77aa04bdc5c8076dd103aad2785de2","user":{"login":"dposada","id":444778,"node_id":"MDQ6VXNlcjQ0NDc3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/444778?v=4","gravatar_id":"","url":"https://api.github.com/users/dposada","html_url":"https://github.com/dposada","followers_url":"https://api.github.com/users/dposada/followers","following_url":"https://api.github.com/users/dposada/following{/other_user}","gists_url":"https://api.github.com/users/dposada/gists{/gist_id}","starred_url":"https://api.github.com/users/dposada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposada/subscriptions","organizations_url":"https://api.github.com/users/dposada/orgs","repos_url":"https://api.github.com/users/dposada/repos","events_url":"https://api.github.com/users/dposada/events{/privacy}","received_events_url":"https://api.github.com/users/dposada/received_events","type":"User","site_admin":false},"body":"If we're going to give it a name, let's give it a meaningful name","created_at":"2019-10-30T15:04:48Z","updated_at":"2019-10-30T15:04:48Z","html_url":"https://github.com/twosigma/Cook/pull/1275#discussion_r340672266","pull_request_url":"https://api.github.com/repos/twosigma/Cook/pulls/1275","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/comments/340672266"},"html":{"href":"https://github.com/twosigma/Cook/pull/1275#discussion_r340672266"},"pull_request":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1275"}},"in_reply_to_id":340424713},"pull_request":{"url":"https://api.github.com/repos/twosigma/Cook/pulls/1275","id":333957426,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzOTU3NDI2","html_url":"https://github.com/twosigma/Cook/pull/1275","diff_url":"https://github.com/twosigma/Cook/pull/1275.diff","patch_url":"https://github.com/twosigma/Cook/pull/1275.patch","issue_url":"https://api.github.com/repos/twosigma/Cook/issues/1275","number":1275,"state":"open","locked":false,"title":"Improve logging as we filter jobs from being considered.","user":{"login":"scrosby","id":253292,"node_id":"MDQ6VXNlcjI1MzI5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/253292?v=4","gravatar_id":"","url":"https://api.github.com/users/scrosby","html_url":"https://github.com/scrosby","followers_url":"https://api.github.com/users/scrosby/followers","following_url":"https://api.github.com/users/scrosby/following{/other_user}","gists_url":"https://api.github.com/users/scrosby/gists{/gist_id}","starred_url":"https://api.github.com/users/scrosby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrosby/subscriptions","organizations_url":"https://api.github.com/users/scrosby/orgs","repos_url":"https://api.github.com/users/scrosby/repos","events_url":"https://api.github.com/users/scrosby/events{/privacy}","received_events_url":"https://api.github.com/users/scrosby/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this PR\r\n\r\n- Log as we filter out jobs from being considered\r\n\r\n## Why are we making these changes?\r\n- Make it easier to determine where and why we cease to consider jobs for scheduling\r\n\r\n","created_at":"2019-10-30T00:37:45Z","updated_at":"2019-10-30T15:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52a883be67a155650713a0ba83888b4a47e8eb46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twosigma/Cook/pulls/1275/commits","review_comments_url":"https://api.github.com/repos/twosigma/Cook/pulls/1275/comments","review_comment_url":"https://api.github.com/repos/twosigma/Cook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twosigma/Cook/issues/1275/comments","statuses_url":"https://api.github.com/repos/twosigma/Cook/statuses/8de0dee7d0b44d9298c8908e8ef656db3f235776","head":{"label":"scrosby:outgoing/improve-log-job-filtering","ref":"outgoing/improve-log-job-filtering","sha":"8de0dee7d0b44d9298c8908e8ef656db3f235776","user":{"login":"scrosby","id":253292,"node_id":"MDQ6VXNlcjI1MzI5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/253292?v=4","gravatar_id":"","url":"https://api.github.com/users/scrosby","html_url":"https://github.com/scrosby","followers_url":"https://api.github.com/users/scrosby/followers","following_url":"https://api.github.com/users/scrosby/following{/other_user}","gists_url":"https://api.github.com/users/scrosby/gists{/gist_id}","starred_url":"https://api.github.com/users/scrosby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrosby/subscriptions","organizations_url":"https://api.github.com/users/scrosby/orgs","repos_url":"https://api.github.com/users/scrosby/repos","events_url":"https://api.github.com/users/scrosby/events{/privacy}","received_events_url":"https://api.github.com/users/scrosby/received_events","type":"User","site_admin":false},"repo":{"id":121643897,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2NDM4OTc=","name":"Cook","full_name":"scrosby/Cook","private":false,"owner":{"login":"scrosby","id":253292,"node_id":"MDQ6VXNlcjI1MzI5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/253292?v=4","gravatar_id":"","url":"https://api.github.com/users/scrosby","html_url":"https://github.com/scrosby","followers_url":"https://api.github.com/users/scrosby/followers","following_url":"https://api.github.com/users/scrosby/following{/other_user}","gists_url":"https://api.github.com/users/scrosby/gists{/gist_id}","starred_url":"https://api.github.com/users/scrosby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrosby/subscriptions","organizations_url":"https://api.github.com/users/scrosby/orgs","repos_url":"https://api.github.com/users/scrosby/repos","events_url":"https://api.github.com/users/scrosby/events{/privacy}","received_events_url":"https://api.github.com/users/scrosby/received_events","type":"User","site_admin":false},"html_url":"https://github.com/scrosby/Cook","description":"Fair job scheduler on Mesos for batch workloads and Spark","fork":true,"url":"https://api.github.com/repos/scrosby/Cook","forks_url":"https://api.github.com/repos/scrosby/Cook/forks","keys_url":"https://api.github.com/repos/scrosby/Cook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrosby/Cook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrosby/Cook/teams","hooks_url":"https://api.github.com/repos/scrosby/Cook/hooks","issue_events_url":"https://api.github.com/repos/scrosby/Cook/issues/events{/number}","events_url":"https://api.github.com/repos/scrosby/Cook/events","assignees_url":"https://api.github.com/repos/scrosby/Cook/assignees{/user}","branches_url":"https://api.github.com/repos/scrosby/Cook/branches{/branch}","tags_url":"https://api.github.com/repos/scrosby/Cook/tags","blobs_url":"https://api.github.com/repos/scrosby/Cook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrosby/Cook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrosby/Cook/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrosby/Cook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrosby/Cook/statuses/{sha}","languages_url":"https://api.github.com/repos/scrosby/Cook/languages","stargazers_url":"https://api.github.com/repos/scrosby/Cook/stargazers","contributors_url":"https://api.github.com/repos/scrosby/Cook/contributors","subscribers_url":"https://api.github.com/repos/scrosby/Cook/subscribers","subscription_url":"https://api.github.com/repos/scrosby/Cook/subscription","commits_url":"https://api.github.com/repos/scrosby/Cook/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrosby/Cook/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrosby/Cook/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrosby/Cook/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrosby/Cook/contents/{+path}","compare_url":"https://api.github.com/repos/scrosby/Cook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrosby/Cook/merges","archive_url":"https://api.github.com/repos/scrosby/Cook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrosby/Cook/downloads","issues_url":"https://api.github.com/repos/scrosby/Cook/issues{/number}","pulls_url":"https://api.github.com/repos/scrosby/Cook/pulls{/number}","milestones_url":"https://api.github.com/repos/scrosby/Cook/milestones{/number}","notifications_url":"https://api.github.com/repos/scrosby/Cook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrosby/Cook/labels{/name}","releases_url":"https://api.github.com/repos/scrosby/Cook/releases{/id}","deployments_url":"https://api.github.com/repos/scrosby/Cook/deployments","created_at":"2018-02-15T15:13:27Z","updated_at":"2019-10-25T15:32:05Z","pushed_at":"2019-10-30T14:36:29Z","git_url":"git://github.com/scrosby/Cook.git","ssh_url":"git@github.com:scrosby/Cook.git","clone_url":"https://github.com/scrosby/Cook.git","svn_url":"https://github.com/scrosby/Cook","homepage":"","size":44581,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twosigma:master","ref":"master","sha":"8609df34d864ccf4736d540cc821c2682e6f5e78","user":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"repo":{"id":42325066,"node_id":"MDEwOlJlcG9zaXRvcnk0MjMyNTA2Ng==","name":"Cook","full_name":"twosigma/Cook","private":false,"owner":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twosigma/Cook","description":"Fair job scheduler on Mesos for batch workloads and Spark","fork":false,"url":"https://api.github.com/repos/twosigma/Cook","forks_url":"https://api.github.com/repos/twosigma/Cook/forks","keys_url":"https://api.github.com/repos/twosigma/Cook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twosigma/Cook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twosigma/Cook/teams","hooks_url":"https://api.github.com/repos/twosigma/Cook/hooks","issue_events_url":"https://api.github.com/repos/twosigma/Cook/issues/events{/number}","events_url":"https://api.github.com/repos/twosigma/Cook/events","assignees_url":"https://api.github.com/repos/twosigma/Cook/assignees{/user}","branches_url":"https://api.github.com/repos/twosigma/Cook/branches{/branch}","tags_url":"https://api.github.com/repos/twosigma/Cook/tags","blobs_url":"https://api.github.com/repos/twosigma/Cook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twosigma/Cook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twosigma/Cook/git/refs{/sha}","trees_url":"https://api.github.com/repos/twosigma/Cook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twosigma/Cook/statuses/{sha}","languages_url":"https://api.github.com/repos/twosigma/Cook/languages","stargazers_url":"https://api.github.com/repos/twosigma/Cook/stargazers","contributors_url":"https://api.github.com/repos/twosigma/Cook/contributors","subscribers_url":"https://api.github.com/repos/twosigma/Cook/subscribers","subscription_url":"https://api.github.com/repos/twosigma/Cook/subscription","commits_url":"https://api.github.com/repos/twosigma/Cook/commits{/sha}","git_commits_url":"https://api.github.com/repos/twosigma/Cook/git/commits{/sha}","comments_url":"https://api.github.com/repos/twosigma/Cook/comments{/number}","issue_comment_url":"https://api.github.com/repos/twosigma/Cook/issues/comments{/number}","contents_url":"https://api.github.com/repos/twosigma/Cook/contents/{+path}","compare_url":"https://api.github.com/repos/twosigma/Cook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twosigma/Cook/merges","archive_url":"https://api.github.com/repos/twosigma/Cook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twosigma/Cook/downloads","issues_url":"https://api.github.com/repos/twosigma/Cook/issues{/number}","pulls_url":"https://api.github.com/repos/twosigma/Cook/pulls{/number}","milestones_url":"https://api.github.com/repos/twosigma/Cook/milestones{/number}","notifications_url":"https://api.github.com/repos/twosigma/Cook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twosigma/Cook/labels{/name}","releases_url":"https://api.github.com/repos/twosigma/Cook/releases{/id}","deployments_url":"https://api.github.com/repos/twosigma/Cook/deployments","created_at":"2015-09-11T18:20:08Z","updated_at":"2019-10-29T21:53:10Z","pushed_at":"2019-10-30T14:36:30Z","git_url":"git://github.com/twosigma/Cook.git","ssh_url":"git@github.com:twosigma/Cook.git","clone_url":"https://github.com/twosigma/Cook.git","svn_url":"https://github.com/twosigma/Cook","homepage":"","size":44513,"stargazers_count":293,"watchers_count":293,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":107,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":107,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1275"},"html":{"href":"https://github.com/twosigma/Cook/pull/1275"},"issue":{"href":"https://api.github.com/repos/twosigma/Cook/issues/1275"},"comments":{"href":"https://api.github.com/repos/twosigma/Cook/issues/1275/comments"},"review_comments":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1275/comments"},"review_comment":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1275/commits"},"statuses":{"href":"https://api.github.com/repos/twosigma/Cook/statuses/8de0dee7d0b44d9298c8908e8ef656db3f235776"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"dposada"}}