payload: {"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments/302692712","pull_request_review_id":260820269,"id":302692712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjY5MjcxMg==","diff_hunk":"@@ -1132,5 +1132,87 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe\n \t\t\t.map(extensionId => (<IExtensionRecommendation>{ extensionId, sources: ['application'] })));\n \t}\n \n+\t// called when Visualizer icon is clicked in the Query Results grid; \"Never Show Again\" is not an option\n+\tpromptVisualizerExtensions(): void {","path":"src/vs/workbench/contrib/extensions/electron-browser/extensionTipsService.ts","position":14,"original_position":14,"commit_id":"3bf1e51625dd5b152532cac42f211993d61ead70","original_commit_id":"3bf1e51625dd5b152532cac42f211993d61ead70","user":{"login":"kevcunnane","id":10819925,"node_id":"MDQ6VXNlcjEwODE5OTI1","avatar_url":"https://avatars3.githubusercontent.com/u/10819925?v=4","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"body":"A few things:\r\n- Any edit to the src/vs tree needs a SQL Carbon Edit comment block or it'll be deleted on next merge. Please verify any cases where you have this and add the comments.\r\n- In this specific case, Let's not put this logic in the VS code area. There's no reason this couldn't just go directly in your action instead of in this service. I'd just move to the file you have the main action in for now.","created_at":"2019-07-11T18:49:09Z","updated_at":"2019-07-11T18:54:23Z","html_url":"https://github.com/microsoft/azuredatastudio/pull/6347#discussion_r302692712","pull_request_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments/302692712"},"html":{"href":"https://github.com/microsoft/azuredatastudio/pull/6347#discussion_r302692712"},"pull_request":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347","id":296283205,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MjgzMjA1","html_url":"https://github.com/microsoft/azuredatastudio/pull/6347","diff_url":"https://github.com/microsoft/azuredatastudio/pull/6347.diff","patch_url":"https://github.com/microsoft/azuredatastudio/pull/6347.patch","issue_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/6347","number":6347,"state":"open","locked":false,"title":"Introducing Visualizer (SandDance) to the SQL Query Editor.","user":{"login":"rchlkm","id":14362577,"node_id":"MDQ6VXNlcjE0MzYyNTc3","avatar_url":"https://avatars2.githubusercontent.com/u/14362577?v=4","gravatar_id":"","url":"https://api.github.com/users/rchlkm","html_url":"https://github.com/rchlkm","followers_url":"https://api.github.com/users/rchlkm/followers","following_url":"https://api.github.com/users/rchlkm/following{/other_user}","gists_url":"https://api.github.com/users/rchlkm/gists{/gist_id}","starred_url":"https://api.github.com/users/rchlkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchlkm/subscriptions","organizations_url":"https://api.github.com/users/rchlkm/orgs","repos_url":"https://api.github.com/users/rchlkm/repos","events_url":"https://api.github.com/users/rchlkm/events{/privacy}","received_events_url":"https://api.github.com/users/rchlkm/received_events","type":"User","site_admin":false},"body":"This is the first pull request by Garage interns working on the data visualization experience in Azure Data Studio using SandDance.\r\n\r\nThe garageMVP branch is up to date with the master branch. garageMVP also has changes from [alanren/ExtRecommendationAppLaunch](https://github.com/microsoft/azuredatastudio/pull/6105). Alan Ren's code structure was used to create the Visualizer (SandDance) extension recommendation popup. \r\n\r\n--\r\nWhen a user runs a query, they will be recommended to install the SandDance extension to visualize their data. They will have the option to \"Don't show again\". We will work on prompting the popup less frequently.\r\n![runQuery_popup](https://user-images.githubusercontent.com/14362577/60943581-41423780-a29b-11e9-9b2a-2f2d2a20e39b.png)\r\n\r\nWe introduced a Visualizer icon in the SQL Query Editor Results Grid. This icon will be reviewed soon to ensure it meets the icon standards. Currently, we have both the normal and inverse icons.\r\n\r\n![visualizer_gridactions](https://user-images.githubusercontent.com/14362577/60943932-4eabf180-a29c-11e9-9526-06946dfa147a.png)\r\n\r\n![viewVisualizer](https://user-images.githubusercontent.com/14362577/60944381-7b143d80-a29d-11e9-888e-9dc53fd3ffde.png)\r\n\r\nWhen a user clicks on this icon, if they do not have the SandDance extension, they will be prompted to install the extension. Since the extension is required to utilized the feature, they will not have the option to \"Don't show again\".\r\n![visualizerIcon_popup](https://user-images.githubusercontent.com/14362577/60943991-7438fb00-a29c-11e9-8a93-cc6518d56a98.png)\r\n\r\n\"Install Extension\" will download the SandDance extension. When more visualizer extensions are added, the same button can be used to install all the visualizer extensions at once as long as product.json is updated.\r\n\r\n\"More info\" will take the user to the extension marketplace that shows all the visualizer extensions. Currently it is just SandDance.\r\n\r\nOnce SandDance is installed, when a user clicks on the visualizer icon, the SandDance extension will take over to load the query data in SandDance. This will be pushed in a separate pull request.","created_at":"2019-07-10T18:03:32Z","updated_at":"2019-07-11T18:54:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d2186628c3550f2512c943bd2be3ac69d0e81a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347/commits","review_comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347/comments","review_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/6347/comments","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/3bf1e51625dd5b152532cac42f211993d61ead70","head":{"label":"microsoft:garagedev2","ref":"garagedev2","sha":"3bf1e51625dd5b152532cac42f211993d61ead70","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"azuredatastudio","full_name":"microsoft/azuredatastudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azuredatastudio","description":"Azure Data Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/microsoft/azuredatastudio","forks_url":"https://api.github.com/repos/microsoft/azuredatastudio/forks","keys_url":"https://api.github.com/repos/microsoft/azuredatastudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azuredatastudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azuredatastudio/teams","hooks_url":"https://api.github.com/repos/microsoft/azuredatastudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azuredatastudio/events","assignees_url":"https://api.github.com/repos/microsoft/azuredatastudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azuredatastudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/tags","blobs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azuredatastudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/azuredatastudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azuredatastudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscription","commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azuredatastudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azuredatastudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azuredatastudio/merges","archive_url":"https://api.github.com/repos/microsoft/azuredatastudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azuredatastudio/downloads","issues_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azuredatastudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azuredatastudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azuredatastudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azuredatastudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azuredatastudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2019-07-11T17:47:19Z","pushed_at":"2019-07-11T18:19:56Z","git_url":"git://github.com/microsoft/azuredatastudio.git","ssh_url":"git@github.com:microsoft/azuredatastudio.git","clone_url":"https://github.com/microsoft/azuredatastudio.git","svn_url":"https://github.com/microsoft/azuredatastudio","homepage":"","size":54635,"stargazers_count":5170,"watchers_count":5170,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1437,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":386,"open_issues":1437,"watchers":5170,"default_branch":"master"}},"base":{"label":"microsoft:garageMVP","ref":"garageMVP","sha":"57c980d2c5234d082aac64a5240bfeebae301420","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"azuredatastudio","full_name":"microsoft/azuredatastudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azuredatastudio","description":"Azure Data Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/microsoft/azuredatastudio","forks_url":"https://api.github.com/repos/microsoft/azuredatastudio/forks","keys_url":"https://api.github.com/repos/microsoft/azuredatastudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azuredatastudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azuredatastudio/teams","hooks_url":"https://api.github.com/repos/microsoft/azuredatastudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azuredatastudio/events","assignees_url":"https://api.github.com/repos/microsoft/azuredatastudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azuredatastudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/tags","blobs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azuredatastudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/azuredatastudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azuredatastudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscription","commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azuredatastudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azuredatastudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azuredatastudio/merges","archive_url":"https://api.github.com/repos/microsoft/azuredatastudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azuredatastudio/downloads","issues_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azuredatastudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azuredatastudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azuredatastudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azuredatastudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azuredatastudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2019-07-11T17:47:19Z","pushed_at":"2019-07-11T18:19:56Z","git_url":"git://github.com/microsoft/azuredatastudio.git","ssh_url":"git@github.com:microsoft/azuredatastudio.git","clone_url":"https://github.com/microsoft/azuredatastudio.git","svn_url":"https://github.com/microsoft/azuredatastudio","homepage":"","size":54635,"stargazers_count":5170,"watchers_count":5170,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1437,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":386,"open_issues":1437,"watchers":5170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347"},"html":{"href":"https://github.com/microsoft/azuredatastudio/pull/6347"},"issue":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/issues/6347"},"comments":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/issues/6347/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/6347/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/3bf1e51625dd5b152532cac42f211993d61ead70"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"kevcunnane"}}