payload: {"action":"created","issue":{"url":"https://api.github.com/repos/panda3d/panda3d/issues/717","repository_url":"https://api.github.com/repos/panda3d/panda3d","labels_url":"https://api.github.com/repos/panda3d/panda3d/issues/717/labels{/name}","comments_url":"https://api.github.com/repos/panda3d/panda3d/issues/717/comments","events_url":"https://api.github.com/repos/panda3d/panda3d/issues/717/events","html_url":"https://github.com/panda3d/panda3d/pull/717","id":485091592,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwODAyMTIy","number":717,"title":"The CMake buildsystem","user":{"login":"CFSworks","id":700768,"node_id":"MDQ6VXNlcjcwMDc2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/700768?v=4","gravatar_id":"","url":"https://api.github.com/users/CFSworks","html_url":"https://github.com/CFSworks","followers_url":"https://api.github.com/users/CFSworks/followers","following_url":"https://api.github.com/users/CFSworks/following{/other_user}","gists_url":"https://api.github.com/users/CFSworks/gists{/gist_id}","starred_url":"https://api.github.com/users/CFSworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CFSworks/subscriptions","organizations_url":"https://api.github.com/users/CFSworks/orgs","repos_url":"https://api.github.com/users/CFSworks/repos","events_url":"https://api.github.com/users/CFSworks/events{/privacy}","received_events_url":"https://api.github.com/users/CFSworks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rdb","id":194842,"node_id":"MDQ6VXNlcjE5NDg0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/194842?v=4","gravatar_id":"","url":"https://api.github.com/users/rdb","html_url":"https://github.com/rdb","followers_url":"https://api.github.com/users/rdb/followers","following_url":"https://api.github.com/users/rdb/following{/other_user}","gists_url":"https://api.github.com/users/rdb/gists{/gist_id}","starred_url":"https://api.github.com/users/rdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdb/subscriptions","organizations_url":"https://api.github.com/users/rdb/orgs","repos_url":"https://api.github.com/users/rdb/repos","events_url":"https://api.github.com/users/rdb/events{/privacy}","received_events_url":"https://api.github.com/users/rdb/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdb","id":194842,"node_id":"MDQ6VXNlcjE5NDg0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/194842?v=4","gravatar_id":"","url":"https://api.github.com/users/rdb","html_url":"https://github.com/rdb","followers_url":"https://api.github.com/users/rdb/followers","following_url":"https://api.github.com/users/rdb/following{/other_user}","gists_url":"https://api.github.com/users/rdb/gists{/gist_id}","starred_url":"https://api.github.com/users/rdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdb/subscriptions","organizations_url":"https://api.github.com/users/rdb/orgs","repos_url":"https://api.github.com/users/rdb/repos","events_url":"https://api.github.com/users/rdb/events{/privacy}","received_events_url":"https://api.github.com/users/rdb/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2019-08-26T07:35:25Z","updated_at":"2019-10-05T21:07:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/panda3d/panda3d/pulls/717","html_url":"https://github.com/panda3d/panda3d/pull/717","diff_url":"https://github.com/panda3d/panda3d/pull/717.diff","patch_url":"https://github.com/panda3d/panda3d/pull/717.patch"},"body":"This does not (yet) handle:\r\n- TinyDisplay\r\n- maya tools\r\n- max tools\r\n- Creating an NSIS installer or other OS-specific packages\r\n- `make wheel`\r\n- Android\r\n- libRocket\r\n- PhysX\r\n- SpeedTree\r\n\r\nThis should be testable (on all platforms) with:\r\n- `mkdir build && cd build`\r\n- `cmake -DTHIRDPARTY_DIRETORY=/path/to/thirdparty ..`\r\n- `cmake --build .`\r\n\r\nHopefully this is without problem in most cases and should be suitable for merging to `master` even if we aren't yet telling people to drop makepanda. That is, while it's not all it can be, it should be far enough along that it doesn't create (substantial) confusion for users, and that we can even start using it ourselves primarily. Hence, this is not a draft PR.\r\n\r\nNote there are some slight issues with the thirdparty zip currently which might require turning off certain features (HAVE_...) for now; I hope some of these are impetus for updating the thirdparty zip, though.\r\n\r\nThe situation with Travis will require attention. I consider a `-DCOMPOSITE_SOURCE_LIMIT=0` build to be an essential code quality check, but unfortunately that currently blows past the 50 minute limit on Travis jobs. Enabling ccache doesn't appear to help as Travis will even skip uploading the cache if the job limit is exceeded. A discussion about what jobs are appropriate should take place before we merge this down. In particular, we need to come up with some representative matrix of:\r\n- OS (macOS/Windows/Linux)\r\n- Compiler (clang/gcc/MSVC)\r\n- Build backend (Makefiles/MSbuild/Xcode/Ninja)\r\n- Build frontend (CMake/makepanda)\r\n- Python version\r\n- Composite on/off\r\n- Metalibs on/off"},"comment":{"url":"https://api.github.com/repos/panda3d/panda3d/issues/comments/538688653","html_url":"https://github.com/panda3d/panda3d/pull/717#issuecomment-538688653","issue_url":"https://api.github.com/repos/panda3d/panda3d/issues/717","id":538688653,"node_id":"MDEyOklzc3VlQ29tbWVudDUzODY4ODY1Mw==","user":{"login":"rdb","id":194842,"node_id":"MDQ6VXNlcjE5NDg0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/194842?v=4","gravatar_id":"","url":"https://api.github.com/users/rdb","html_url":"https://github.com/rdb","followers_url":"https://api.github.com/users/rdb/followers","following_url":"https://api.github.com/users/rdb/following{/other_user}","gists_url":"https://api.github.com/users/rdb/gists{/gist_id}","starred_url":"https://api.github.com/users/rdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdb/subscriptions","organizations_url":"https://api.github.com/users/rdb/orgs","repos_url":"https://api.github.com/users/rdb/repos","events_url":"https://api.github.com/users/rdb/events{/privacy}","received_events_url":"https://api.github.com/users/rdb/received_events","type":"User","site_admin":false},"created_at":"2019-10-05T21:07:54Z","updated_at":"2019-10-05T21:07:54Z","author_association":"MEMBER","body":"@CFSworks I'm aware that there are parts where the ABI still differs from NDEBUG.  (Not sure how this particularly egregious case has been missed.)  These cases should be fixed.  I will remove the NDEBUG guard.  Automating ABI testing has been on my mind for a long time, but I've never gotten around to doing it.\r\n\r\nI suppose we're not really selling it as a \"guarantee\" as long as we don't actually test that it's the case, but the reason why this ABI compatibility is important is so that people can build their own third-party extensions and still use our deployment system, which downloads a Release version of the Panda binaries.\r\n\r\nFurthermore, the reason why Standard shouldn't have NDEBUG is because NDEBUG removes a lot of things that people really do expect from a \"Standard\" build of Panda3D.  Panda will often simply crash if you pass an out-of-bounds value to a function.  This is not acceptable behaviour for Python users, who have no way to debug segmentation faults."}}
other: {"actor":{"display_login":"rdb"}}