payload: {"action":"closed","number":649,"pull_request":{"url":"https://api.github.com/repos/dash-project/dash/pulls/649","id":279496506,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5NDk2NTA2","html_url":"https://github.com/dash-project/dash/pull/649","diff_url":"https://github.com/dash-project/dash/pull/649.diff","patch_url":"https://github.com/dash-project/dash/pull/649.patch","issue_url":"https://api.github.com/repos/dash-project/dash/issues/649","number":649,"state":"closed","locked":false,"title":"TilePattern: Fix coordinate <-> index conversion","user":{"login":"devreal","id":10974502,"node_id":"MDQ6VXNlcjEwOTc0NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},"body":"The conversion between coordinates and indices should not be done through directly throught the `CartesianIndexSpace` because that has no notion of tiles. \r\n\r\nTo make things consistent, this PR removes the exposure of the `[local_]memory_layout` in the patterns and adds a missing `coords` member that takes a viewspec. All conversion should be done through the patterns as the results might differ from the conversion the `memory_layout` provides for some pattern types.\r\n\r\nFixes #620 ","created_at":"2019-05-16T13:03:18Z","updated_at":"2019-08-02T13:08:31Z","closed_at":"2019-08-02T13:08:31Z","merged_at":"2019-08-02T13:08:31Z","merge_commit_sha":"5b1a1ec52a082fb0bcb620473ed0c49f37266b7a","assignee":{"login":"devreal","id":10974502,"node_id":"MDQ6VXNlcjEwOTc0NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},"assignees":[{"login":"devreal","id":10974502,"node_id":"MDQ6VXNlcjEwOTc0NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fuchsto","id":37075,"node_id":"MDQ6VXNlcjM3MDc1","avatar_url":"https://avatars2.githubusercontent.com/u/37075?v=4","gravatar_id":"","url":"https://api.github.com/users/fuchsto","html_url":"https://github.com/fuchsto","followers_url":"https://api.github.com/users/fuchsto/followers","following_url":"https://api.github.com/users/fuchsto/following{/other_user}","gists_url":"https://api.github.com/users/fuchsto/gists{/gist_id}","starred_url":"https://api.github.com/users/fuchsto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuchsto/subscriptions","organizations_url":"https://api.github.com/users/fuchsto/orgs","repos_url":"https://api.github.com/users/fuchsto/repos","events_url":"https://api.github.com/users/fuchsto/events{/privacy}","received_events_url":"https://api.github.com/users/fuchsto/received_events","type":"User","site_admin":false},{"login":"pascalj","id":330168,"node_id":"MDQ6VXNlcjMzMDE2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/330168?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalj","html_url":"https://github.com/pascalj","followers_url":"https://api.github.com/users/pascalj/followers","following_url":"https://api.github.com/users/pascalj/following{/other_user}","gists_url":"https://api.github.com/users/pascalj/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalj/subscriptions","organizations_url":"https://api.github.com/users/pascalj/orgs","repos_url":"https://api.github.com/users/pascalj/repos","events_url":"https://api.github.com/users/pascalj/events{/privacy}","received_events_url":"https://api.github.com/users/pascalj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484173025,"node_id":"MDU6TGFiZWw0ODQxNzMwMjU=","url":"https://api.github.com/repos/dash-project/dash/labels/specification:dash-concepts","name":"specification:dash-concepts","color":"b0f26a","default":false}],"milestone":{"url":"https://api.github.com/repos/dash-project/dash/milestones/3","html_url":"https://github.com/dash-project/dash/milestone/3","labels_url":"https://api.github.com/repos/dash-project/dash/milestones/3/labels","id":2143706,"node_id":"MDk6TWlsZXN0b25lMjE0MzcwNg==","number":3,"title":"dash-0.4.0","description":"","creator":{"login":"fuchsto","id":37075,"node_id":"MDQ6VXNlcjM3MDc1","avatar_url":"https://avatars2.githubusercontent.com/u/37075?v=4","gravatar_id":"","url":"https://api.github.com/users/fuchsto","html_url":"https://github.com/fuchsto","followers_url":"https://api.github.com/users/fuchsto/followers","following_url":"https://api.github.com/users/fuchsto/following{/other_user}","gists_url":"https://api.github.com/users/fuchsto/gists{/gist_id}","starred_url":"https://api.github.com/users/fuchsto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuchsto/subscriptions","organizations_url":"https://api.github.com/users/fuchsto/orgs","repos_url":"https://api.github.com/users/fuchsto/repos","events_url":"https://api.github.com/users/fuchsto/events{/privacy}","received_events_url":"https://api.github.com/users/fuchsto/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":25,"state":"open","created_at":"2016-11-18T09:15:18Z","updated_at":"2019-08-02T13:08:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dash-project/dash/pulls/649/commits","review_comments_url":"https://api.github.com/repos/dash-project/dash/pulls/649/comments","review_comment_url":"https://api.github.com/repos/dash-project/dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dash-project/dash/issues/649/comments","statuses_url":"https://api.github.com/repos/dash-project/dash/statuses/7a57d24a948e4c8f4f9074aa3e3976a87b8019bc","head":{"label":"dash-project:bug-620-tilepattern","ref":"bug-620-tilepattern","sha":"7a57d24a948e4c8f4f9074aa3e3976a87b8019bc","user":{"login":"dash-project","id":14168660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"repo":{"id":45930061,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzMDA2MQ==","name":"dash","full_name":"dash-project/dash","private":false,"owner":{"login":"dash-project","id":14168660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dash-project/dash","description":"DASH, the C++ Template Library for Distributed Data Structures with Support for Hierarchical Locality for HPC and Data-Driven Science","fork":false,"url":"https://api.github.com/repos/dash-project/dash","forks_url":"https://api.github.com/repos/dash-project/dash/forks","keys_url":"https://api.github.com/repos/dash-project/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dash-project/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dash-project/dash/teams","hooks_url":"https://api.github.com/repos/dash-project/dash/hooks","issue_events_url":"https://api.github.com/repos/dash-project/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dash-project/dash/events","assignees_url":"https://api.github.com/repos/dash-project/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dash-project/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dash-project/dash/tags","blobs_url":"https://api.github.com/repos/dash-project/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dash-project/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dash-project/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dash-project/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dash-project/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dash-project/dash/languages","stargazers_url":"https://api.github.com/repos/dash-project/dash/stargazers","contributors_url":"https://api.github.com/repos/dash-project/dash/contributors","subscribers_url":"https://api.github.com/repos/dash-project/dash/subscribers","subscription_url":"https://api.github.com/repos/dash-project/dash/subscription","commits_url":"https://api.github.com/repos/dash-project/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dash-project/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dash-project/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dash-project/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dash-project/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dash-project/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dash-project/dash/merges","archive_url":"https://api.github.com/repos/dash-project/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dash-project/dash/downloads","issues_url":"https://api.github.com/repos/dash-project/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dash-project/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dash-project/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dash-project/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dash-project/dash/labels{/name}","releases_url":"https://api.github.com/repos/dash-project/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dash-project/dash/deployments","created_at":"2015-11-10T17:56:37Z","updated_at":"2019-07-18T15:46:29Z","pushed_at":"2019-08-02T13:08:30Z","git_url":"git://github.com/dash-project/dash.git","ssh_url":"git@github.com:dash-project/dash.git","clone_url":"https://github.com/dash-project/dash.git","svn_url":"https://github.com/dash-project/dash","homepage":"http://www.dash-project.org/","size":14494,"stargazers_count":102,"watchers_count":102,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":91,"watchers":102,"default_branch":"development"}},"base":{"label":"dash-project:development","ref":"development","sha":"d41cb35d69cae46144ee4bb5c5d12502011ec6e5","user":{"login":"dash-project","id":14168660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"repo":{"id":45930061,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzMDA2MQ==","name":"dash","full_name":"dash-project/dash","private":false,"owner":{"login":"dash-project","id":14168660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dash-project/dash","description":"DASH, the C++ Template Library for Distributed Data Structures with Support for Hierarchical Locality for HPC and Data-Driven Science","fork":false,"url":"https://api.github.com/repos/dash-project/dash","forks_url":"https://api.github.com/repos/dash-project/dash/forks","keys_url":"https://api.github.com/repos/dash-project/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dash-project/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dash-project/dash/teams","hooks_url":"https://api.github.com/repos/dash-project/dash/hooks","issue_events_url":"https://api.github.com/repos/dash-project/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dash-project/dash/events","assignees_url":"https://api.github.com/repos/dash-project/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dash-project/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dash-project/dash/tags","blobs_url":"https://api.github.com/repos/dash-project/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dash-project/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dash-project/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dash-project/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dash-project/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dash-project/dash/languages","stargazers_url":"https://api.github.com/repos/dash-project/dash/stargazers","contributors_url":"https://api.github.com/repos/dash-project/dash/contributors","subscribers_url":"https://api.github.com/repos/dash-project/dash/subscribers","subscription_url":"https://api.github.com/repos/dash-project/dash/subscription","commits_url":"https://api.github.com/repos/dash-project/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dash-project/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dash-project/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dash-project/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dash-project/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dash-project/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dash-project/dash/merges","archive_url":"https://api.github.com/repos/dash-project/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dash-project/dash/downloads","issues_url":"https://api.github.com/repos/dash-project/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dash-project/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dash-project/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dash-project/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dash-project/dash/labels{/name}","releases_url":"https://api.github.com/repos/dash-project/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dash-project/dash/deployments","created_at":"2015-11-10T17:56:37Z","updated_at":"2019-07-18T15:46:29Z","pushed_at":"2019-08-02T13:08:30Z","git_url":"git://github.com/dash-project/dash.git","ssh_url":"git@github.com:dash-project/dash.git","clone_url":"https://github.com/dash-project/dash.git","svn_url":"https://github.com/dash-project/dash","homepage":"http://www.dash-project.org/","size":14494,"stargazers_count":102,"watchers_count":102,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":91,"watchers":102,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/dash-project/dash/pulls/649"},"html":{"href":"https://github.com/dash-project/dash/pull/649"},"issue":{"href":"https://api.github.com/repos/dash-project/dash/issues/649"},"comments":{"href":"https://api.github.com/repos/dash-project/dash/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/dash-project/dash/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/dash-project/dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dash-project/dash/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/dash-project/dash/statuses/7a57d24a948e4c8f4f9074aa3e3976a87b8019bc"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"devreal","id":10974502,"node_id":"MDQ6VXNlcjEwOTc0NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":405,"deletions":265,"changed_files":17}}
other: {"actor":{"display_login":"devreal"}}