payload: {"action":"closed","number":1068,"pull_request":{"url":"https://api.github.com/repos/electrode-io/electrode-native/pulls/1068","id":255049328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MDQ5MzI4","html_url":"https://github.com/electrode-io/electrode-native/pull/1068","diff_url":"https://github.com/electrode-io/electrode-native/pull/1068.diff","patch_url":"https://github.com/electrode-io/electrode-native/pull/1068.patch","issue_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/1068","number":1068,"state":"closed","locked":false,"title":"Fix react-native modules order","user":{"login":"jduthon","id":4168055,"node_id":"MDQ6VXNlcjQxNjgwNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4168055?v=4","gravatar_id":"","url":"https://api.github.com/users/jduthon","html_url":"https://github.com/jduthon","followers_url":"https://api.github.com/users/jduthon/followers","following_url":"https://api.github.com/users/jduthon/following{/other_user}","gists_url":"https://api.github.com/users/jduthon/gists{/gist_id}","starred_url":"https://api.github.com/users/jduthon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduthon/subscriptions","organizations_url":"https://api.github.com/users/jduthon/orgs","repos_url":"https://api.github.com/users/jduthon/repos","events_url":"https://api.github.com/users/jduthon/events{/privacy}","received_events_url":"https://api.github.com/users/jduthon/received_events","type":"User","site_admin":false},"body":"The modules order might actually be important in certain cases.\r\nIn our example `lottie-react-native` depends on `react-native` being built first, though when only resorting to alphabetical ordering we try to build `lottie-react-native` first.\r\n\r\nThis fix this particular issue, but maybe the order of dependencies problem should be taken further later? As an example for Lottie, `lottie-ios` should also be built before `lottie-react-native`. Luckily for this alphabetical works, but I could see how this might not stand the test of time and other plugins.\r\n\r\nMaybe the information about the plugin could be made more public (that might actually already be the case in a cauldron?), and in this case the final user should be responsible for the sorting and the platform should only insure `react-native` comes before the user-defined plugins I think.\r\n\r\nRelated PR to support LottieReactNative in the manifest: https://github.com/electrode-io/electrode-native-manifest/pull/99","created_at":"2019-02-21T14:38:51Z","updated_at":"2019-02-27T18:23:03Z","closed_at":"2019-02-27T18:23:03Z","merged_at":"2019-02-27T18:23:02Z","merge_commit_sha":"d86f1d71d91eaa072e93c1695d36d595e0a43ef0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/electrode-io/electrode-native/pulls/1068/commits","review_comments_url":"https://api.github.com/repos/electrode-io/electrode-native/pulls/1068/comments","review_comment_url":"https://api.github.com/repos/electrode-io/electrode-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/1068/comments","statuses_url":"https://api.github.com/repos/electrode-io/electrode-native/statuses/18467fc2b1f7c5756eb68105a7ed9adddc8385c7","head":{"label":"babbel:fix/rn-plugins-order","ref":"fix/rn-plugins-order","sha":"18467fc2b1f7c5756eb68105a7ed9adddc8385c7","user":{"login":"babbel","id":2762251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjIyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2762251?v=4","gravatar_id":"","url":"https://api.github.com/users/babbel","html_url":"https://github.com/babbel","followers_url":"https://api.github.com/users/babbel/followers","following_url":"https://api.github.com/users/babbel/following{/other_user}","gists_url":"https://api.github.com/users/babbel/gists{/gist_id}","starred_url":"https://api.github.com/users/babbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbel/subscriptions","organizations_url":"https://api.github.com/users/babbel/orgs","repos_url":"https://api.github.com/users/babbel/repos","events_url":"https://api.github.com/users/babbel/events{/privacy}","received_events_url":"https://api.github.com/users/babbel/received_events","type":"Organization","site_admin":false},"repo":{"id":170301254,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAzMDEyNTQ=","name":"electrode-native","full_name":"babbel/electrode-native","private":false,"owner":{"login":"babbel","id":2762251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjIyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2762251?v=4","gravatar_id":"","url":"https://api.github.com/users/babbel","html_url":"https://github.com/babbel","followers_url":"https://api.github.com/users/babbel/followers","following_url":"https://api.github.com/users/babbel/following{/other_user}","gists_url":"https://api.github.com/users/babbel/gists{/gist_id}","starred_url":"https://api.github.com/users/babbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbel/subscriptions","organizations_url":"https://api.github.com/users/babbel/orgs","repos_url":"https://api.github.com/users/babbel/repos","events_url":"https://api.github.com/users/babbel/events{/privacy}","received_events_url":"https://api.github.com/users/babbel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/babbel/electrode-native","description":"A platform to ease integration&delivery of React Native apps in existing mobile applications","fork":true,"url":"https://api.github.com/repos/babbel/electrode-native","forks_url":"https://api.github.com/repos/babbel/electrode-native/forks","keys_url":"https://api.github.com/repos/babbel/electrode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babbel/electrode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babbel/electrode-native/teams","hooks_url":"https://api.github.com/repos/babbel/electrode-native/hooks","issue_events_url":"https://api.github.com/repos/babbel/electrode-native/issues/events{/number}","events_url":"https://api.github.com/repos/babbel/electrode-native/events","assignees_url":"https://api.github.com/repos/babbel/electrode-native/assignees{/user}","branches_url":"https://api.github.com/repos/babbel/electrode-native/branches{/branch}","tags_url":"https://api.github.com/repos/babbel/electrode-native/tags","blobs_url":"https://api.github.com/repos/babbel/electrode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babbel/electrode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babbel/electrode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/babbel/electrode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babbel/electrode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/babbel/electrode-native/languages","stargazers_url":"https://api.github.com/repos/babbel/electrode-native/stargazers","contributors_url":"https://api.github.com/repos/babbel/electrode-native/contributors","subscribers_url":"https://api.github.com/repos/babbel/electrode-native/subscribers","subscription_url":"https://api.github.com/repos/babbel/electrode-native/subscription","commits_url":"https://api.github.com/repos/babbel/electrode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/babbel/electrode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/babbel/electrode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/babbel/electrode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/babbel/electrode-native/contents/{+path}","compare_url":"https://api.github.com/repos/babbel/electrode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babbel/electrode-native/merges","archive_url":"https://api.github.com/repos/babbel/electrode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babbel/electrode-native/downloads","issues_url":"https://api.github.com/repos/babbel/electrode-native/issues{/number}","pulls_url":"https://api.github.com/repos/babbel/electrode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/babbel/electrode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/babbel/electrode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babbel/electrode-native/labels{/name}","releases_url":"https://api.github.com/repos/babbel/electrode-native/releases{/id}","deployments_url":"https://api.github.com/repos/babbel/electrode-native/deployments","created_at":"2019-02-12T10:46:35Z","updated_at":"2019-02-25T14:01:47Z","pushed_at":"2019-02-25T14:02:11Z","git_url":"git://github.com/babbel/electrode-native.git","ssh_url":"git@github.com:babbel/electrode-native.git","clone_url":"https://github.com/babbel/electrode-native.git","svn_url":"https://github.com/babbel/electrode-native","homepage":"http://www.electrode.io/site/native.html","size":13696,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electrode-io:master","ref":"master","sha":"eb5551527a03c25c078614b41ae5da55c3292348","user":{"login":"electrode-io","id":20847973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODQ3OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/20847973?v=4","gravatar_id":"","url":"https://api.github.com/users/electrode-io","html_url":"https://github.com/electrode-io","followers_url":"https://api.github.com/users/electrode-io/followers","following_url":"https://api.github.com/users/electrode-io/following{/other_user}","gists_url":"https://api.github.com/users/electrode-io/gists{/gist_id}","starred_url":"https://api.github.com/users/electrode-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrode-io/subscriptions","organizations_url":"https://api.github.com/users/electrode-io/orgs","repos_url":"https://api.github.com/users/electrode-io/repos","events_url":"https://api.github.com/users/electrode-io/events{/privacy}","received_events_url":"https://api.github.com/users/electrode-io/received_events","type":"Organization","site_admin":false},"repo":{"id":98331207,"node_id":"MDEwOlJlcG9zaXRvcnk5ODMzMTIwNw==","name":"electrode-native","full_name":"electrode-io/electrode-native","private":false,"owner":{"login":"electrode-io","id":20847973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODQ3OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/20847973?v=4","gravatar_id":"","url":"https://api.github.com/users/electrode-io","html_url":"https://github.com/electrode-io","followers_url":"https://api.github.com/users/electrode-io/followers","following_url":"https://api.github.com/users/electrode-io/following{/other_user}","gists_url":"https://api.github.com/users/electrode-io/gists{/gist_id}","starred_url":"https://api.github.com/users/electrode-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrode-io/subscriptions","organizations_url":"https://api.github.com/users/electrode-io/orgs","repos_url":"https://api.github.com/users/electrode-io/repos","events_url":"https://api.github.com/users/electrode-io/events{/privacy}","received_events_url":"https://api.github.com/users/electrode-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electrode-io/electrode-native","description":"A platform to ease integration&delivery of React Native apps in existing mobile applications","fork":false,"url":"https://api.github.com/repos/electrode-io/electrode-native","forks_url":"https://api.github.com/repos/electrode-io/electrode-native/forks","keys_url":"https://api.github.com/repos/electrode-io/electrode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electrode-io/electrode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electrode-io/electrode-native/teams","hooks_url":"https://api.github.com/repos/electrode-io/electrode-native/hooks","issue_events_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/events{/number}","events_url":"https://api.github.com/repos/electrode-io/electrode-native/events","assignees_url":"https://api.github.com/repos/electrode-io/electrode-native/assignees{/user}","branches_url":"https://api.github.com/repos/electrode-io/electrode-native/branches{/branch}","tags_url":"https://api.github.com/repos/electrode-io/electrode-native/tags","blobs_url":"https://api.github.com/repos/electrode-io/electrode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electrode-io/electrode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electrode-io/electrode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/electrode-io/electrode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electrode-io/electrode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/electrode-io/electrode-native/languages","stargazers_url":"https://api.github.com/repos/electrode-io/electrode-native/stargazers","contributors_url":"https://api.github.com/repos/electrode-io/electrode-native/contributors","subscribers_url":"https://api.github.com/repos/electrode-io/electrode-native/subscribers","subscription_url":"https://api.github.com/repos/electrode-io/electrode-native/subscription","commits_url":"https://api.github.com/repos/electrode-io/electrode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/electrode-io/electrode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/electrode-io/electrode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/electrode-io/electrode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/electrode-io/electrode-native/contents/{+path}","compare_url":"https://api.github.com/repos/electrode-io/electrode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electrode-io/electrode-native/merges","archive_url":"https://api.github.com/repos/electrode-io/electrode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electrode-io/electrode-native/downloads","issues_url":"https://api.github.com/repos/electrode-io/electrode-native/issues{/number}","pulls_url":"https://api.github.com/repos/electrode-io/electrode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/electrode-io/electrode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/electrode-io/electrode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electrode-io/electrode-native/labels{/name}","releases_url":"https://api.github.com/repos/electrode-io/electrode-native/releases{/id}","deployments_url":"https://api.github.com/repos/electrode-io/electrode-native/deployments","created_at":"2017-07-25T17:11:27Z","updated_at":"2019-02-27T02:04:42Z","pushed_at":"2019-02-27T18:23:02Z","git_url":"git://github.com/electrode-io/electrode-native.git","ssh_url":"git@github.com:electrode-io/electrode-native.git","clone_url":"https://github.com/electrode-io/electrode-native.git","svn_url":"https://github.com/electrode-io/electrode-native","homepage":"http://www.electrode.io/site/native.html","size":13715,"stargazers_count":469,"watchers_count":469,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":11,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electrode-io/electrode-native/pulls/1068"},"html":{"href":"https://github.com/electrode-io/electrode-native/pull/1068"},"issue":{"href":"https://api.github.com/repos/electrode-io/electrode-native/issues/1068"},"comments":{"href":"https://api.github.com/repos/electrode-io/electrode-native/issues/1068/comments"},"review_comments":{"href":"https://api.github.com/repos/electrode-io/electrode-native/pulls/1068/comments"},"review_comment":{"href":"https://api.github.com/repos/electrode-io/electrode-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electrode-io/electrode-native/pulls/1068/commits"},"statuses":{"href":"https://api.github.com/repos/electrode-io/electrode-native/statuses/18467fc2b1f7c5756eb68105a7ed9adddc8385c7"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"belemaire","id":1390588,"node_id":"MDQ6VXNlcjEzOTA1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1390588?v=4","gravatar_id":"","url":"https://api.github.com/users/belemaire","html_url":"https://github.com/belemaire","followers_url":"https://api.github.com/users/belemaire/followers","following_url":"https://api.github.com/users/belemaire/following{/other_user}","gists_url":"https://api.github.com/users/belemaire/gists{/gist_id}","starred_url":"https://api.github.com/users/belemaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belemaire/subscriptions","organizations_url":"https://api.github.com/users/belemaire/orgs","repos_url":"https://api.github.com/users/belemaire/repos","events_url":"https://api.github.com/users/belemaire/events{/privacy}","received_events_url":"https://api.github.com/users/belemaire/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":0,"changed_files":1}}
other: {"actor":{"display_login":"belemaire"}}