payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/comments/325449789","pull_request_review_id":289628890,"id":325449789,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTQ0OTc4OQ==","diff_hunk":"@@ -101,9 +101,10 @@ def get_stock_data(self, save=False, as_dict=False, force_update=False):\n         if not data:\n             raise Exception('No data found')\n         time = datetime.utcnow() - timedelta(hours=3)\n-        self.stocks = [Stock(\n-            *[format_values(d) for d in list(zip(headers_data.values(), row))], time.isoformat()\n-        ) for row in data[1:]]\n+        formatted_values = ((format_value(method, value) for method, value in zip(\n+            headers_info.values(), row,\n+        )) for row in data)","path":"google_sheets/crawler.py","position":18,"original_position":18,"commit_id":"cc3c2490cadf3f612e549a73b4f457aa6d0041e5","original_commit_id":"cc3c2490cadf3f612e549a73b4f457aa6d0041e5","user":{"login":"rdemetrescu","id":506371,"node_id":"MDQ6VXNlcjUwNjM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/506371?v=4","gravatar_id":"","url":"https://api.github.com/users/rdemetrescu","html_url":"https://github.com/rdemetrescu","followers_url":"https://api.github.com/users/rdemetrescu/followers","following_url":"https://api.github.com/users/rdemetrescu/following{/other_user}","gists_url":"https://api.github.com/users/rdemetrescu/gists{/gist_id}","starred_url":"https://api.github.com/users/rdemetrescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdemetrescu/subscriptions","organizations_url":"https://api.github.com/users/rdemetrescu/orgs","repos_url":"https://api.github.com/users/rdemetrescu/repos","events_url":"https://api.github.com/users/rdemetrescu/events{/privacy}","received_events_url":"https://api.github.com/users/rdemetrescu/received_events","type":"User","site_admin":false},"body":"voce pode evitar a conversão para lista filtrando assim:\r\n\r\n```python\r\n\r\n        formatted_values = ((format_value(method, value) for method, value in zip(\r\n            headers_info.values(), row,\r\n        )) for row in islice(data, 1, None))\r\n```\r\n\r\nE aí vc tira o `list(.....)[1:]` na linha seguinte","created_at":"2019-09-18T01:35:25Z","updated_at":"2019-09-18T01:35:25Z","html_url":"https://github.com/Guilehm/stocks-crawler/pull/17#discussion_r325449789","pull_request_url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/comments/325449789"},"html":{"href":"https://github.com/Guilehm/stocks-crawler/pull/17#discussion_r325449789"},"pull_request":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17","id":316702488,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NzAyNDg4","html_url":"https://github.com/Guilehm/stocks-crawler/pull/17","diff_url":"https://github.com/Guilehm/stocks-crawler/pull/17.diff","patch_url":"https://github.com/Guilehm/stocks-crawler/pull/17.patch","issue_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/17","number":17,"state":"open","locked":false,"title":"Improve functions","user":{"login":"Guilehm","id":33688752,"node_id":"MDQ6VXNlcjMzNjg4NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/33688752?v=4","gravatar_id":"","url":"https://api.github.com/users/Guilehm","html_url":"https://github.com/Guilehm","followers_url":"https://api.github.com/users/Guilehm/followers","following_url":"https://api.github.com/users/Guilehm/following{/other_user}","gists_url":"https://api.github.com/users/Guilehm/gists{/gist_id}","starred_url":"https://api.github.com/users/Guilehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guilehm/subscriptions","organizations_url":"https://api.github.com/users/Guilehm/orgs","repos_url":"https://api.github.com/users/Guilehm/repos","events_url":"https://api.github.com/users/Guilehm/events{/privacy}","received_events_url":"https://api.github.com/users/Guilehm/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-12T02:28:42Z","updated_at":"2019-09-18T01:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a13d4c6967dc22c88a65911f94970a7574ef358c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/17/comments","statuses_url":"https://api.github.com/repos/Guilehm/stocks-crawler/statuses/cc3c2490cadf3f612e549a73b4f457aa6d0041e5","head":{"label":"Guilehm:feature/improve-functions","ref":"feature/improve-functions","sha":"cc3c2490cadf3f612e549a73b4f457aa6d0041e5","user":{"login":"Guilehm","id":33688752,"node_id":"MDQ6VXNlcjMzNjg4NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/33688752?v=4","gravatar_id":"","url":"https://api.github.com/users/Guilehm","html_url":"https://github.com/Guilehm","followers_url":"https://api.github.com/users/Guilehm/followers","following_url":"https://api.github.com/users/Guilehm/following{/other_user}","gists_url":"https://api.github.com/users/Guilehm/gists{/gist_id}","starred_url":"https://api.github.com/users/Guilehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guilehm/subscriptions","organizations_url":"https://api.github.com/users/Guilehm/orgs","repos_url":"https://api.github.com/users/Guilehm/repos","events_url":"https://api.github.com/users/Guilehm/events{/privacy}","received_events_url":"https://api.github.com/users/Guilehm/received_events","type":"User","site_admin":false},"repo":{"id":202794245,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI3OTQyNDU=","name":"stocks-crawler","full_name":"Guilehm/stocks-crawler","private":false,"owner":{"login":"Guilehm","id":33688752,"node_id":"MDQ6VXNlcjMzNjg4NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/33688752?v=4","gravatar_id":"","url":"https://api.github.com/users/Guilehm","html_url":"https://github.com/Guilehm","followers_url":"https://api.github.com/users/Guilehm/followers","following_url":"https://api.github.com/users/Guilehm/following{/other_user}","gists_url":"https://api.github.com/users/Guilehm/gists{/gist_id}","starred_url":"https://api.github.com/users/Guilehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guilehm/subscriptions","organizations_url":"https://api.github.com/users/Guilehm/orgs","repos_url":"https://api.github.com/users/Guilehm/repos","events_url":"https://api.github.com/users/Guilehm/events{/privacy}","received_events_url":"https://api.github.com/users/Guilehm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Guilehm/stocks-crawler","description":"Retrieve stocks data","fork":false,"url":"https://api.github.com/repos/Guilehm/stocks-crawler","forks_url":"https://api.github.com/repos/Guilehm/stocks-crawler/forks","keys_url":"https://api.github.com/repos/Guilehm/stocks-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Guilehm/stocks-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Guilehm/stocks-crawler/teams","hooks_url":"https://api.github.com/repos/Guilehm/stocks-crawler/hooks","issue_events_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/Guilehm/stocks-crawler/events","assignees_url":"https://api.github.com/repos/Guilehm/stocks-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/Guilehm/stocks-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/Guilehm/stocks-crawler/tags","blobs_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Guilehm/stocks-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/Guilehm/stocks-crawler/languages","stargazers_url":"https://api.github.com/repos/Guilehm/stocks-crawler/stargazers","contributors_url":"https://api.github.com/repos/Guilehm/stocks-crawler/contributors","subscribers_url":"https://api.github.com/repos/Guilehm/stocks-crawler/subscribers","subscription_url":"https://api.github.com/repos/Guilehm/stocks-crawler/subscription","commits_url":"https://api.github.com/repos/Guilehm/stocks-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Guilehm/stocks-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Guilehm/stocks-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/Guilehm/stocks-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Guilehm/stocks-crawler/merges","archive_url":"https://api.github.com/repos/Guilehm/stocks-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Guilehm/stocks-crawler/downloads","issues_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/Guilehm/stocks-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/Guilehm/stocks-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Guilehm/stocks-crawler/labels{/name}","releases_url":"https://api.github.com/repos/Guilehm/stocks-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/Guilehm/stocks-crawler/deployments","created_at":"2019-08-16T20:20:59Z","updated_at":"2019-09-10T03:37:59Z","pushed_at":"2019-09-18T00:41:48Z","git_url":"git://github.com/Guilehm/stocks-crawler.git","ssh_url":"git@github.com:Guilehm/stocks-crawler.git","clone_url":"https://github.com/Guilehm/stocks-crawler.git","svn_url":"https://github.com/Guilehm/stocks-crawler","homepage":"https://gui-stocks.herokuapp.com/","size":4388,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Guilehm:master","ref":"master","sha":"9c1b91849dca010a73ae0de39ed1514ae83c9291","user":{"login":"Guilehm","id":33688752,"node_id":"MDQ6VXNlcjMzNjg4NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/33688752?v=4","gravatar_id":"","url":"https://api.github.com/users/Guilehm","html_url":"https://github.com/Guilehm","followers_url":"https://api.github.com/users/Guilehm/followers","following_url":"https://api.github.com/users/Guilehm/following{/other_user}","gists_url":"https://api.github.com/users/Guilehm/gists{/gist_id}","starred_url":"https://api.github.com/users/Guilehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guilehm/subscriptions","organizations_url":"https://api.github.com/users/Guilehm/orgs","repos_url":"https://api.github.com/users/Guilehm/repos","events_url":"https://api.github.com/users/Guilehm/events{/privacy}","received_events_url":"https://api.github.com/users/Guilehm/received_events","type":"User","site_admin":false},"repo":{"id":202794245,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI3OTQyNDU=","name":"stocks-crawler","full_name":"Guilehm/stocks-crawler","private":false,"owner":{"login":"Guilehm","id":33688752,"node_id":"MDQ6VXNlcjMzNjg4NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/33688752?v=4","gravatar_id":"","url":"https://api.github.com/users/Guilehm","html_url":"https://github.com/Guilehm","followers_url":"https://api.github.com/users/Guilehm/followers","following_url":"https://api.github.com/users/Guilehm/following{/other_user}","gists_url":"https://api.github.com/users/Guilehm/gists{/gist_id}","starred_url":"https://api.github.com/users/Guilehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guilehm/subscriptions","organizations_url":"https://api.github.com/users/Guilehm/orgs","repos_url":"https://api.github.com/users/Guilehm/repos","events_url":"https://api.github.com/users/Guilehm/events{/privacy}","received_events_url":"https://api.github.com/users/Guilehm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Guilehm/stocks-crawler","description":"Retrieve stocks data","fork":false,"url":"https://api.github.com/repos/Guilehm/stocks-crawler","forks_url":"https://api.github.com/repos/Guilehm/stocks-crawler/forks","keys_url":"https://api.github.com/repos/Guilehm/stocks-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Guilehm/stocks-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Guilehm/stocks-crawler/teams","hooks_url":"https://api.github.com/repos/Guilehm/stocks-crawler/hooks","issue_events_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/Guilehm/stocks-crawler/events","assignees_url":"https://api.github.com/repos/Guilehm/stocks-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/Guilehm/stocks-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/Guilehm/stocks-crawler/tags","blobs_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Guilehm/stocks-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/Guilehm/stocks-crawler/languages","stargazers_url":"https://api.github.com/repos/Guilehm/stocks-crawler/stargazers","contributors_url":"https://api.github.com/repos/Guilehm/stocks-crawler/contributors","subscribers_url":"https://api.github.com/repos/Guilehm/stocks-crawler/subscribers","subscription_url":"https://api.github.com/repos/Guilehm/stocks-crawler/subscription","commits_url":"https://api.github.com/repos/Guilehm/stocks-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Guilehm/stocks-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Guilehm/stocks-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Guilehm/stocks-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/Guilehm/stocks-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Guilehm/stocks-crawler/merges","archive_url":"https://api.github.com/repos/Guilehm/stocks-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Guilehm/stocks-crawler/downloads","issues_url":"https://api.github.com/repos/Guilehm/stocks-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/Guilehm/stocks-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/Guilehm/stocks-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Guilehm/stocks-crawler/labels{/name}","releases_url":"https://api.github.com/repos/Guilehm/stocks-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/Guilehm/stocks-crawler/deployments","created_at":"2019-08-16T20:20:59Z","updated_at":"2019-09-10T03:37:59Z","pushed_at":"2019-09-18T00:41:48Z","git_url":"git://github.com/Guilehm/stocks-crawler.git","ssh_url":"git@github.com:Guilehm/stocks-crawler.git","clone_url":"https://github.com/Guilehm/stocks-crawler.git","svn_url":"https://github.com/Guilehm/stocks-crawler","homepage":"https://gui-stocks.herokuapp.com/","size":4388,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17"},"html":{"href":"https://github.com/Guilehm/stocks-crawler/pull/17"},"issue":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/17"},"comments":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Guilehm/stocks-crawler/statuses/cc3c2490cadf3f612e549a73b4f457aa6d0041e5"}},"author_association":"OWNER"}}
other: {"actor":{"display_login":"rdemetrescu"}}