payload: {"action":"closed","number":418,"pull_request":{"url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/418","id":333537018,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNTM3MDE4","html_url":"https://github.com/presslabs/mysql-operator/pull/418","diff_url":"https://github.com/presslabs/mysql-operator/pull/418.diff","patch_url":"https://github.com/presslabs/mysql-operator/pull/418.patch","issue_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/418","number":418,"state":"closed","locked":false,"title":"Log cluster/master name instead of entire object when reconciling","user":{"login":"tanordheim","id":49933,"node_id":"MDQ6VXNlcjQ5OTMz","avatar_url":"https://avatars0.githubusercontent.com/u/49933?v=4","gravatar_id":"","url":"https://api.github.com/users/tanordheim","html_url":"https://github.com/tanordheim","followers_url":"https://api.github.com/users/tanordheim/followers","following_url":"https://api.github.com/users/tanordheim/following{/other_user}","gists_url":"https://api.github.com/users/tanordheim/gists{/gist_id}","starred_url":"https://api.github.com/users/tanordheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanordheim/subscriptions","organizations_url":"https://api.github.com/users/tanordheim/orgs","repos_url":"https://api.github.com/users/tanordheim/repos","events_url":"https://api.github.com/users/tanordheim/events{/privacy}","received_events_url":"https://api.github.com/users/tanordheim/received_events","type":"User","site_admin":false},"body":"There's a slight inconsistency in the JSON logs from the orchestrator where it usually logs the name of the cluster or master when reconciling - except for when logging \"reconciling cluster\" where the `cluster` key in the JSON output contains the entire `MysqlCluster` API resource.\r\n\r\nThis is causing a slight problem in our logging infrastructure where we have Beats picking up container logs and feeding them to Elasticsearch and it's unable to map these messages to the Elasticsearch index (eg. `object mapping for [json.cluster] tried to parse field [cluster] as object, but found a concrete value`).\r\n\r\nThis also removes a similar problem during when logging \"cluster failover finished\" where the entire master object was logged; this log statement has been removed as per @AMecea's suggestion. This also fixes #414 where there was some confusion around whether or not a failover had happened when seeing this log statement logged continuously.","created_at":"2019-10-29T10:25:42Z","updated_at":"2019-10-30T11:21:55Z","closed_at":"2019-10-30T11:21:55Z","merged_at":"2019-10-30T11:21:55Z","merge_commit_sha":"30208e858bcdba638b198f158681830f93ea6280","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/418/commits","review_comments_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/418/comments","review_comment_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/418/comments","statuses_url":"https://api.github.com/repos/presslabs/mysql-operator/statuses/cc84c527bfa76ebe13d129512ab31fade4ccf62e","head":{"label":"tanordheim:cluster-log-consistency","ref":"cluster-log-consistency","sha":"cc84c527bfa76ebe13d129512ab31fade4ccf62e","user":{"login":"tanordheim","id":49933,"node_id":"MDQ6VXNlcjQ5OTMz","avatar_url":"https://avatars0.githubusercontent.com/u/49933?v=4","gravatar_id":"","url":"https://api.github.com/users/tanordheim","html_url":"https://github.com/tanordheim","followers_url":"https://api.github.com/users/tanordheim/followers","following_url":"https://api.github.com/users/tanordheim/following{/other_user}","gists_url":"https://api.github.com/users/tanordheim/gists{/gist_id}","starred_url":"https://api.github.com/users/tanordheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanordheim/subscriptions","organizations_url":"https://api.github.com/users/tanordheim/orgs","repos_url":"https://api.github.com/users/tanordheim/repos","events_url":"https://api.github.com/users/tanordheim/events{/privacy}","received_events_url":"https://api.github.com/users/tanordheim/received_events","type":"User","site_admin":false},"repo":{"id":218257633,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgyNTc2MzM=","name":"mysql-operator","full_name":"tanordheim/mysql-operator","private":false,"owner":{"login":"tanordheim","id":49933,"node_id":"MDQ6VXNlcjQ5OTMz","avatar_url":"https://avatars0.githubusercontent.com/u/49933?v=4","gravatar_id":"","url":"https://api.github.com/users/tanordheim","html_url":"https://github.com/tanordheim","followers_url":"https://api.github.com/users/tanordheim/followers","following_url":"https://api.github.com/users/tanordheim/following{/other_user}","gists_url":"https://api.github.com/users/tanordheim/gists{/gist_id}","starred_url":"https://api.github.com/users/tanordheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanordheim/subscriptions","organizations_url":"https://api.github.com/users/tanordheim/orgs","repos_url":"https://api.github.com/users/tanordheim/repos","events_url":"https://api.github.com/users/tanordheim/events{/privacy}","received_events_url":"https://api.github.com/users/tanordheim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tanordheim/mysql-operator","description":"Bulletproof MySQL on Kubernetes using Percona Server","fork":true,"url":"https://api.github.com/repos/tanordheim/mysql-operator","forks_url":"https://api.github.com/repos/tanordheim/mysql-operator/forks","keys_url":"https://api.github.com/repos/tanordheim/mysql-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanordheim/mysql-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanordheim/mysql-operator/teams","hooks_url":"https://api.github.com/repos/tanordheim/mysql-operator/hooks","issue_events_url":"https://api.github.com/repos/tanordheim/mysql-operator/issues/events{/number}","events_url":"https://api.github.com/repos/tanordheim/mysql-operator/events","assignees_url":"https://api.github.com/repos/tanordheim/mysql-operator/assignees{/user}","branches_url":"https://api.github.com/repos/tanordheim/mysql-operator/branches{/branch}","tags_url":"https://api.github.com/repos/tanordheim/mysql-operator/tags","blobs_url":"https://api.github.com/repos/tanordheim/mysql-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanordheim/mysql-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanordheim/mysql-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanordheim/mysql-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanordheim/mysql-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/tanordheim/mysql-operator/languages","stargazers_url":"https://api.github.com/repos/tanordheim/mysql-operator/stargazers","contributors_url":"https://api.github.com/repos/tanordheim/mysql-operator/contributors","subscribers_url":"https://api.github.com/repos/tanordheim/mysql-operator/subscribers","subscription_url":"https://api.github.com/repos/tanordheim/mysql-operator/subscription","commits_url":"https://api.github.com/repos/tanordheim/mysql-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanordheim/mysql-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanordheim/mysql-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanordheim/mysql-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanordheim/mysql-operator/contents/{+path}","compare_url":"https://api.github.com/repos/tanordheim/mysql-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanordheim/mysql-operator/merges","archive_url":"https://api.github.com/repos/tanordheim/mysql-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanordheim/mysql-operator/downloads","issues_url":"https://api.github.com/repos/tanordheim/mysql-operator/issues{/number}","pulls_url":"https://api.github.com/repos/tanordheim/mysql-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/tanordheim/mysql-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/tanordheim/mysql-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanordheim/mysql-operator/labels{/name}","releases_url":"https://api.github.com/repos/tanordheim/mysql-operator/releases{/id}","deployments_url":"https://api.github.com/repos/tanordheim/mysql-operator/deployments","created_at":"2019-10-29T10:09:08Z","updated_at":"2019-10-29T10:09:09Z","pushed_at":"2019-10-29T14:02:42Z","git_url":"git://github.com/tanordheim/mysql-operator.git","ssh_url":"git@github.com:tanordheim/mysql-operator.git","clone_url":"https://github.com/tanordheim/mysql-operator.git","svn_url":"https://github.com/tanordheim/mysql-operator","homepage":"https://www.presslabs.com/docs/mysql-operator","size":40531,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"presslabs:master","ref":"master","sha":"b93196ef4b1f6f5865baf55f1fc160a7de079179","user":{"login":"presslabs","id":1033395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1033395?v=4","gravatar_id":"","url":"https://api.github.com/users/presslabs","html_url":"https://github.com/presslabs","followers_url":"https://api.github.com/users/presslabs/followers","following_url":"https://api.github.com/users/presslabs/following{/other_user}","gists_url":"https://api.github.com/users/presslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/presslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presslabs/subscriptions","organizations_url":"https://api.github.com/users/presslabs/orgs","repos_url":"https://api.github.com/users/presslabs/repos","events_url":"https://api.github.com/users/presslabs/events{/privacy}","received_events_url":"https://api.github.com/users/presslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":109712767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MTI3Njc=","name":"mysql-operator","full_name":"presslabs/mysql-operator","private":false,"owner":{"login":"presslabs","id":1033395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1033395?v=4","gravatar_id":"","url":"https://api.github.com/users/presslabs","html_url":"https://github.com/presslabs","followers_url":"https://api.github.com/users/presslabs/followers","following_url":"https://api.github.com/users/presslabs/following{/other_user}","gists_url":"https://api.github.com/users/presslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/presslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presslabs/subscriptions","organizations_url":"https://api.github.com/users/presslabs/orgs","repos_url":"https://api.github.com/users/presslabs/repos","events_url":"https://api.github.com/users/presslabs/events{/privacy}","received_events_url":"https://api.github.com/users/presslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/presslabs/mysql-operator","description":"Bulletproof MySQL on Kubernetes using Percona Server","fork":false,"url":"https://api.github.com/repos/presslabs/mysql-operator","forks_url":"https://api.github.com/repos/presslabs/mysql-operator/forks","keys_url":"https://api.github.com/repos/presslabs/mysql-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/presslabs/mysql-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/presslabs/mysql-operator/teams","hooks_url":"https://api.github.com/repos/presslabs/mysql-operator/hooks","issue_events_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/events{/number}","events_url":"https://api.github.com/repos/presslabs/mysql-operator/events","assignees_url":"https://api.github.com/repos/presslabs/mysql-operator/assignees{/user}","branches_url":"https://api.github.com/repos/presslabs/mysql-operator/branches{/branch}","tags_url":"https://api.github.com/repos/presslabs/mysql-operator/tags","blobs_url":"https://api.github.com/repos/presslabs/mysql-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/presslabs/mysql-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/presslabs/mysql-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/presslabs/mysql-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/presslabs/mysql-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/presslabs/mysql-operator/languages","stargazers_url":"https://api.github.com/repos/presslabs/mysql-operator/stargazers","contributors_url":"https://api.github.com/repos/presslabs/mysql-operator/contributors","subscribers_url":"https://api.github.com/repos/presslabs/mysql-operator/subscribers","subscription_url":"https://api.github.com/repos/presslabs/mysql-operator/subscription","commits_url":"https://api.github.com/repos/presslabs/mysql-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/presslabs/mysql-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/presslabs/mysql-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/presslabs/mysql-operator/contents/{+path}","compare_url":"https://api.github.com/repos/presslabs/mysql-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/presslabs/mysql-operator/merges","archive_url":"https://api.github.com/repos/presslabs/mysql-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/presslabs/mysql-operator/downloads","issues_url":"https://api.github.com/repos/presslabs/mysql-operator/issues{/number}","pulls_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/presslabs/mysql-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/presslabs/mysql-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/presslabs/mysql-operator/labels{/name}","releases_url":"https://api.github.com/repos/presslabs/mysql-operator/releases{/id}","deployments_url":"https://api.github.com/repos/presslabs/mysql-operator/deployments","created_at":"2017-11-06T15:24:51Z","updated_at":"2019-10-30T10:16:29Z","pushed_at":"2019-10-30T11:21:55Z","git_url":"git://github.com/presslabs/mysql-operator.git","ssh_url":"git@github.com:presslabs/mysql-operator.git","clone_url":"https://github.com/presslabs/mysql-operator.git","svn_url":"https://github.com/presslabs/mysql-operator","homepage":"https://www.presslabs.com/docs/mysql-operator","size":40538,"stargazers_count":244,"watchers_count":244,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":58,"open_issues":62,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/418"},"html":{"href":"https://github.com/presslabs/mysql-operator/pull/418"},"issue":{"href":"https://api.github.com/repos/presslabs/mysql-operator/issues/418"},"comments":{"href":"https://api.github.com/repos/presslabs/mysql-operator/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/presslabs/mysql-operator/statuses/cc84c527bfa76ebe13d129512ab31fade4ccf62e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AMecea","id":11756727,"node_id":"MDQ6VXNlcjExNzU2NzI3","avatar_url":"https://avatars3.githubusercontent.com/u/11756727?v=4","gravatar_id":"","url":"https://api.github.com/users/AMecea","html_url":"https://github.com/AMecea","followers_url":"https://api.github.com/users/AMecea/followers","following_url":"https://api.github.com/users/AMecea/following{/other_user}","gists_url":"https://api.github.com/users/AMecea/gists{/gist_id}","starred_url":"https://api.github.com/users/AMecea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMecea/subscriptions","organizations_url":"https://api.github.com/users/AMecea/orgs","repos_url":"https://api.github.com/users/AMecea/repos","events_url":"https://api.github.com/users/AMecea/events{/privacy}","received_events_url":"https://api.github.com/users/AMecea/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":1,"deletions":2,"changed_files":2}}
other: {"actor":{"display_login":"AMecea"}}