payload: {"action":"created","issue":{"url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/issues/89","repository_url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp","labels_url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/issues/89/comments","events_url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/issues/89/events","html_url":"https://github.com/heremaps/here-olp-edge-sdk-cpp/pull/89","id":481067052,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NjM4ODA2","number":89,"title":"Ported NetworkProtocol.java to the new http network interface","user":{"login":"borzun","id":33369297,"node_id":"MDQ6VXNlcjMzMzY5Mjk3","avatar_url":"https://avatars2.githubusercontent.com/u/33369297?v=4","gravatar_id":"","url":"https://api.github.com/users/borzun","html_url":"https://github.com/borzun","followers_url":"https://api.github.com/users/borzun/followers","following_url":"https://api.github.com/users/borzun/following{/other_user}","gists_url":"https://api.github.com/users/borzun/gists{/gist_id}","starred_url":"https://api.github.com/users/borzun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borzun/subscriptions","organizations_url":"https://api.github.com/users/borzun/orgs","repos_url":"https://api.github.com/users/borzun/repos","events_url":"https://api.github.com/users/borzun/events{/privacy}","received_events_url":"https://api.github.com/users/borzun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-08-15T09:20:39Z","updated_at":"2019-08-15T09:47:34Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/pulls/89","html_url":"https://github.com/heremaps/here-olp-edge-sdk-cpp/pull/89","diff_url":"https://github.com/heremaps/here-olp-edge-sdk-cpp/pull/89.diff","patch_url":"https://github.com/heremaps/here-olp-edge-sdk-cpp/pull/89.patch"},"body":"- added NetworkProtocol.java, which implements the http network interface,\r\nwhich is based on the previous version of NetworkProtocol.java;\r\n- also, aligned the java code to Google Java code style;\r\n\r\nIn order to generate the new EdgeNetworkProtocol.jar based on http interface,\r\nuse the EDGE_SDK_USE_HTTP_NETWORK_PROTOCOL=YES cmake var.\r\n\r\nRelates to: OLPEDGE-371\r\n\r\nSigned-off-by: Bohdan Kurylovych <ext-bohdan.kurylovych@here.com>"},"comment":{"url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/issues/comments/521584933","html_url":"https://github.com/heremaps/here-olp-edge-sdk-cpp/pull/89#issuecomment-521584933","issue_url":"https://api.github.com/repos/heremaps/here-olp-edge-sdk-cpp/issues/89","id":521584933,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMTU4NDkzMw==","user":{"login":"serhiikobalt","id":51826758,"node_id":"MDQ6VXNlcjUxODI2NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/51826758?v=4","gravatar_id":"","url":"https://api.github.com/users/serhiikobalt","html_url":"https://github.com/serhiikobalt","followers_url":"https://api.github.com/users/serhiikobalt/followers","following_url":"https://api.github.com/users/serhiikobalt/following{/other_user}","gists_url":"https://api.github.com/users/serhiikobalt/gists{/gist_id}","starred_url":"https://api.github.com/users/serhiikobalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhiikobalt/subscriptions","organizations_url":"https://api.github.com/users/serhiikobalt/orgs","repos_url":"https://api.github.com/users/serhiikobalt/repos","events_url":"https://api.github.com/users/serhiikobalt/events{/privacy}","received_events_url":"https://api.github.com/users/serhiikobalt/received_events","type":"User","site_admin":false},"created_at":"2019-08-15T09:47:34Z","updated_at":"2019-08-15T09:47:34Z","author_association":"COLLABORATOR","body":"I'd rather did something like this, \r\n```\r\nif (NOT EDGE_SDK_USE_HTTP_NETWORK_PROTOCOL)\r\n    set(EDGE_SDK_NETWORK_VERSION 0.0.1)\r\n    set(EDGE_SDK_HTTP_NETWORK_VERSION 0.0.2)\r\n\r\n    set(EDGE_NETWORK_PROTOCOL_JAR EdgeNetworkProtocol)\r\n    set(EDGE_HTTP_NETWORK_PROTOCOL_JAR EdgeHttpNetworkProtocol)\r\n\r\n    add_jar(${EDGE_NETWORK_PROTOCOL_JAR}\r\n        SOURCES ${CMAKE_CURRENT_LIST_DIR}/../src/network/android/NetworkProtocol.java ${CMAKE_CURRENT_LIST_DIR}/../src/network/android/NetworkSSLContextFactory.java\r\n        VERSION ${EDGE_SDK_NETWORK_VERSION}\r\n    )\r\n    add_jar(${EDGE_HTTP_NETWORK_PROTOCOL_JAR}\r\n        SOURCES ${CMAKE_CURRENT_LIST_DIR}/../src/http/android/NetworkProtocol.java\r\n        VERSION ${EDGE_SDK_HTTP_NETWORK_VERSION}\r\n    )\r\nelse()\r\n    set(EDGE_SDK_HTTP_NETWORK_VERSION 0.0.2)\r\n\r\n    set(EDGE_HTTP_NETWORK_PROTOCOL_JAR EdgeHttpNetworkProtocol)\r\n\r\n    add_jar(${EDGE_HTTP_NETWORK_PROTOCOL_JAR}\r\n        SOURCES ${CMAKE_CURRENT_LIST_DIR}/../src/http/android/NetworkProtocol.java\r\n        VERSION ${EDGE_SDK_HTTP_NETWORK_VERSION}\r\n    )\r\n\r\nendif()\r\n```"}}
other: {"actor":{"display_login":"serhiikobalt"}}