payload: {"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/detectron2/pulls/comments/362341243","pull_request_review_id":337502879,"id":362341243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MjM0MTI0Mw==","diff_hunk":"@@ -123,10 +124,12 @@ def inference_on_dataset(model, data_loader, evaluator):\n                 torch.cuda.synchronize()\n             total_compute_time += time.perf_counter() - start_compute_time\n             evaluator.process(inputs, outputs)\n+            total_time += time.perf_counter() - start_compute_time\n \n             if idx >= num_warmup * 2:\n                 seconds_per_img = total_compute_time / (idx + 1 - num_warmup)\n-                eta = datetime.timedelta(seconds=int(seconds_per_img * (total - idx - 1)))\n+                total_seconds_per_img = total_time / (idx + 1 - num_warmup)","path":"detectron2/evaluation/evaluator.py","position":17,"original_position":17,"commit_id":"69c1cc982c8aab8ee37302898dd2bc644dd6f0e4","original_commit_id":"69c1cc982c8aab8ee37302898dd2bc644dd6f0e4","user":{"login":"ppwwyyxx","id":1381301,"node_id":"MDQ6VXNlcjEzODEzMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1381301?v=4","gravatar_id":"","url":"https://api.github.com/users/ppwwyyxx","html_url":"https://github.com/ppwwyyxx","followers_url":"https://api.github.com/users/ppwwyyxx/followers","following_url":"https://api.github.com/users/ppwwyyxx/following{/other_user}","gists_url":"https://api.github.com/users/ppwwyyxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ppwwyyxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppwwyyxx/subscriptions","organizations_url":"https://api.github.com/users/ppwwyyxx/orgs","repos_url":"https://api.github.com/users/ppwwyyxx/repos","events_url":"https://api.github.com/users/ppwwyyxx/events{/privacy}","received_events_url":"https://api.github.com/users/ppwwyyxx/received_events","type":"User","site_admin":false},"body":"Why not just \r\n```\r\n total_seconds_per_img = (time.perf_counter() - start_time) / (idx + 1 - num_warmup)\r\n```\r\nit will then also include data time (and simpler). If you aim for more accurate ETA, data time should be included as well.","created_at":"2020-01-01T20:26:00Z","updated_at":"2020-01-01T20:26:00Z","html_url":"https://github.com/facebookresearch/detectron2/pull/589#discussion_r362341243","pull_request_url":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/detectron2/pulls/comments/362341243"},"html":{"href":"https://github.com/facebookresearch/detectron2/pull/589#discussion_r362341243"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589"}}},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589","id":357314511,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3MzE0NTEx","html_url":"https://github.com/facebookresearch/detectron2/pull/589","diff_url":"https://github.com/facebookresearch/detectron2/pull/589.diff","patch_url":"https://github.com/facebookresearch/detectron2/pull/589.patch","issue_url":"https://api.github.com/repos/facebookresearch/detectron2/issues/589","number":589,"state":"open","locked":false,"title":"add `evaluator.process` time to ETA","user":{"login":"bendidi","id":22003440,"node_id":"MDQ6VXNlcjIyMDAzNDQw","avatar_url":"https://avatars0.githubusercontent.com/u/22003440?v=4","gravatar_id":"","url":"https://api.github.com/users/bendidi","html_url":"https://github.com/bendidi","followers_url":"https://api.github.com/users/bendidi/followers","following_url":"https://api.github.com/users/bendidi/following{/other_user}","gists_url":"https://api.github.com/users/bendidi/gists{/gist_id}","starred_url":"https://api.github.com/users/bendidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendidi/subscriptions","organizations_url":"https://api.github.com/users/bendidi/orgs","repos_url":"https://api.github.com/users/bendidi/repos","events_url":"https://api.github.com/users/bendidi/events{/privacy}","received_events_url":"https://api.github.com/users/bendidi/received_events","type":"User","site_admin":false},"body":"The time needed for `evaluator.process()` is not negligible, and it often leads to wrong ETA calculation\r\n\r\n```\r\n[12/27 20:06:29 d2.evaluation.evaluator]: Inference done 11/3944. 0.1170 s / img. ETA=0:07:39\r\n[12/27 20:06:35 d2.evaluation.evaluator]: Inference done 29/3944. 0.1192 s / img. ETA=0:07:42\r\n[12/27 20:06:40 d2.evaluation.evaluator]: Inference done 46/3944. 0.1206 s / img. ETA=0:07:42\r\n....\r\n....\r\n[12/27 20:14:33 d2.evaluation.evaluator]: Inference done 1777/3944. 0.1248 s / img. ETA=0:00:06\r\n[12/27 20:14:38 d2.evaluation.evaluator]: Inference done 1816/3944. 0.1245 s / img. ETA=0:00:00\r\n[12/27 20:14:43 d2.evaluation.evaluator]: Inference done 1840/3944. 0.1245 s / img. ETA=-1 day, 23:59:55\r\n[12/27 20:14:49 d2.evaluation.evaluator]: Inference done 1860/3944. 0.1246 s / img. ETA=-1 day, 23:59:50\r\n[12/27 20:14:54 d2.evaluation.evaluator]: Inference done 1879/3944. 0.1246 s / img. ETA=-1 day, 23:59:45\r\n[12/27 20:14:59 d2.evaluation.evaluator]: Inference done 1918/3944. 0.1244 s / img. ETA=-1 day, 23:59:39\r\n```","created_at":"2019-12-27T19:52:51Z","updated_at":"2020-01-01T20:26:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e6017289b077e0dc74e4720b7d203bcc2f5f27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1539587663,"node_id":"MDU6TGFiZWwxNTM5NTg3NjYz","url":"https://api.github.com/repos/facebookresearch/detectron2/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false,"description":"This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/detectron2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/detectron2/issues/589/comments","statuses_url":"https://api.github.com/repos/facebookresearch/detectron2/statuses/69c1cc982c8aab8ee37302898dd2bc644dd6f0e4","head":{"label":"bendidi:master","ref":"master","sha":"69c1cc982c8aab8ee37302898dd2bc644dd6f0e4","user":{"login":"bendidi","id":22003440,"node_id":"MDQ6VXNlcjIyMDAzNDQw","avatar_url":"https://avatars0.githubusercontent.com/u/22003440?v=4","gravatar_id":"","url":"https://api.github.com/users/bendidi","html_url":"https://github.com/bendidi","followers_url":"https://api.github.com/users/bendidi/followers","following_url":"https://api.github.com/users/bendidi/following{/other_user}","gists_url":"https://api.github.com/users/bendidi/gists{/gist_id}","starred_url":"https://api.github.com/users/bendidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendidi/subscriptions","organizations_url":"https://api.github.com/users/bendidi/orgs","repos_url":"https://api.github.com/users/bendidi/repos","events_url":"https://api.github.com/users/bendidi/events{/privacy}","received_events_url":"https://api.github.com/users/bendidi/received_events","type":"User","site_admin":false},"repo":{"id":230505075,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA1MDUwNzU=","name":"detectron2","full_name":"bendidi/detectron2","private":false,"owner":{"login":"bendidi","id":22003440,"node_id":"MDQ6VXNlcjIyMDAzNDQw","avatar_url":"https://avatars0.githubusercontent.com/u/22003440?v=4","gravatar_id":"","url":"https://api.github.com/users/bendidi","html_url":"https://github.com/bendidi","followers_url":"https://api.github.com/users/bendidi/followers","following_url":"https://api.github.com/users/bendidi/following{/other_user}","gists_url":"https://api.github.com/users/bendidi/gists{/gist_id}","starred_url":"https://api.github.com/users/bendidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendidi/subscriptions","organizations_url":"https://api.github.com/users/bendidi/orgs","repos_url":"https://api.github.com/users/bendidi/repos","events_url":"https://api.github.com/users/bendidi/events{/privacy}","received_events_url":"https://api.github.com/users/bendidi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bendidi/detectron2","description":"Detectron2 is FAIR's next-generation research platform for object detection and segmentation.","fork":true,"url":"https://api.github.com/repos/bendidi/detectron2","forks_url":"https://api.github.com/repos/bendidi/detectron2/forks","keys_url":"https://api.github.com/repos/bendidi/detectron2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendidi/detectron2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendidi/detectron2/teams","hooks_url":"https://api.github.com/repos/bendidi/detectron2/hooks","issue_events_url":"https://api.github.com/repos/bendidi/detectron2/issues/events{/number}","events_url":"https://api.github.com/repos/bendidi/detectron2/events","assignees_url":"https://api.github.com/repos/bendidi/detectron2/assignees{/user}","branches_url":"https://api.github.com/repos/bendidi/detectron2/branches{/branch}","tags_url":"https://api.github.com/repos/bendidi/detectron2/tags","blobs_url":"https://api.github.com/repos/bendidi/detectron2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendidi/detectron2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendidi/detectron2/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendidi/detectron2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendidi/detectron2/statuses/{sha}","languages_url":"https://api.github.com/repos/bendidi/detectron2/languages","stargazers_url":"https://api.github.com/repos/bendidi/detectron2/stargazers","contributors_url":"https://api.github.com/repos/bendidi/detectron2/contributors","subscribers_url":"https://api.github.com/repos/bendidi/detectron2/subscribers","subscription_url":"https://api.github.com/repos/bendidi/detectron2/subscription","commits_url":"https://api.github.com/repos/bendidi/detectron2/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendidi/detectron2/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendidi/detectron2/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendidi/detectron2/issues/comments{/number}","contents_url":"https://api.github.com/repos/bendidi/detectron2/contents/{+path}","compare_url":"https://api.github.com/repos/bendidi/detectron2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendidi/detectron2/merges","archive_url":"https://api.github.com/repos/bendidi/detectron2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendidi/detectron2/downloads","issues_url":"https://api.github.com/repos/bendidi/detectron2/issues{/number}","pulls_url":"https://api.github.com/repos/bendidi/detectron2/pulls{/number}","milestones_url":"https://api.github.com/repos/bendidi/detectron2/milestones{/number}","notifications_url":"https://api.github.com/repos/bendidi/detectron2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendidi/detectron2/labels{/name}","releases_url":"https://api.github.com/repos/bendidi/detectron2/releases{/id}","deployments_url":"https://api.github.com/repos/bendidi/detectron2/deployments","created_at":"2019-12-27T19:26:45Z","updated_at":"2020-01-01T15:51:02Z","pushed_at":"2020-01-01T15:50:58Z","git_url":"git://github.com/bendidi/detectron2.git","ssh_url":"git@github.com:bendidi/detectron2.git","clone_url":"https://github.com/bendidi/detectron2.git","svn_url":"https://github.com/bendidi/detectron2","homepage":"","size":1818,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"d27408849f9d5a124d6d136a69c091b984b4292f","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":206660580,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY2NjA1ODA=","name":"detectron2","full_name":"facebookresearch/detectron2","private":false,"owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebookresearch/detectron2","description":"Detectron2 is FAIR's next-generation research platform for object detection and segmentation.","fork":false,"url":"https://api.github.com/repos/facebookresearch/detectron2","forks_url":"https://api.github.com/repos/facebookresearch/detectron2/forks","keys_url":"https://api.github.com/repos/facebookresearch/detectron2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/detectron2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/detectron2/teams","hooks_url":"https://api.github.com/repos/facebookresearch/detectron2/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/detectron2/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/detectron2/events","assignees_url":"https://api.github.com/repos/facebookresearch/detectron2/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/detectron2/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/detectron2/tags","blobs_url":"https://api.github.com/repos/facebookresearch/detectron2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/detectron2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/detectron2/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/detectron2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/detectron2/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/detectron2/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/detectron2/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/detectron2/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/detectron2/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/detectron2/subscription","commits_url":"https://api.github.com/repos/facebookresearch/detectron2/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/detectron2/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/detectron2/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/detectron2/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/detectron2/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/detectron2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/detectron2/merges","archive_url":"https://api.github.com/repos/facebookresearch/detectron2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/detectron2/downloads","issues_url":"https://api.github.com/repos/facebookresearch/detectron2/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/detectron2/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/detectron2/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/detectron2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/detectron2/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/detectron2/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/detectron2/deployments","created_at":"2019-09-05T21:30:20Z","updated_at":"2020-01-01T20:17:57Z","pushed_at":"2020-01-01T15:51:01Z","git_url":"git://github.com/facebookresearch/detectron2.git","ssh_url":"git@github.com:facebookresearch/detectron2.git","clone_url":"https://github.com/facebookresearch/detectron2.git","svn_url":"https://github.com/facebookresearch/detectron2","homepage":"","size":1809,"stargazers_count":6993,"watchers_count":6993,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1163,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1163,"open_issues":39,"watchers":6993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589"},"html":{"href":"https://github.com/facebookresearch/detectron2/pull/589"},"issue":{"href":"https://api.github.com/repos/facebookresearch/detectron2/issues/589"},"comments":{"href":"https://api.github.com/repos/facebookresearch/detectron2/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/detectron2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/detectron2/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/detectron2/statuses/69c1cc982c8aab8ee37302898dd2bc644dd6f0e4"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"ppwwyyxx"}}