payload: {"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/9061","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/9061/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/9061/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/9061/events","html_url":"https://github.com/qgis/QGIS/pull/9061","id":405609734,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5NTMwNzgx","number":9061,"title":"New Shapefile Layer: reorganise additional dimensions checkboxes","user":{"login":"agiudiceandrea","id":16253859,"node_id":"MDQ6VXNlcjE2MjUzODU5","avatar_url":"https://avatars0.githubusercontent.com/u/16253859?v=4","gravatar_id":"","url":"https://api.github.com/users/agiudiceandrea","html_url":"https://github.com/agiudiceandrea","followers_url":"https://api.github.com/users/agiudiceandrea/followers","following_url":"https://api.github.com/users/agiudiceandrea/following{/other_user}","gists_url":"https://api.github.com/users/agiudiceandrea/gists{/gist_id}","starred_url":"https://api.github.com/users/agiudiceandrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agiudiceandrea/subscriptions","organizations_url":"https://api.github.com/users/agiudiceandrea/orgs","repos_url":"https://api.github.com/users/agiudiceandrea/repos","events_url":"https://api.github.com/users/agiudiceandrea/events{/privacy}","received_events_url":"https://api.github.com/users/agiudiceandrea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-02-01T09:02:24Z","updated_at":"2019-02-06T21:48:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/9061","html_url":"https://github.com/qgis/QGIS/pull/9061","diff_url":"https://github.com/qgis/QGIS/pull/9061.diff","patch_url":"https://github.com/qgis/QGIS/pull/9061.patch"},"body":"## Description\r\nIn the New Shapefile Layer dialog there are two checkboxes (\"Include Z dimension\", \"Include M values\") that allow to create shapefiles with added Z and M \"additional dimensions\"\r\n\r\n![image](https://user-images.githubusercontent.com/16253859/52096572-a5afeb00-25c7-11e9-9fc2-da38e1c103b5.png)\r\n\r\nSince the two checkboxes are not non mutually exclusive, the user could check none, only one, or both of them, thus wrongly thinking that 4 kinds of new shapefile layer could be created, e.g. for Point geometry type:\r\n- Point (X,Y)\r\n- PointZ (X,Y,Z)\r\n- PointM (X,Y,M)\r\n- PointZM (X,Y,Z,M)\r\n\r\nwhile actually only 3 types of Point shapefiles do exists:\r\n- Point (X,Y)\r\n- PointM (X,Y,M)\r\n- PointZ = PointZM (X,Y,Z,M)\r\n\r\nIn fact, whether checking only the \"Include Z dimension\" checkbox or checking both the \"Include Z dimension\" and the \"Include M values\" checkboxes, will lead to create the very same ZM new shapefile layer.\r\n\r\nIn order to solve this ambiguity, I propose to change the New Shapefile Layer dialog adding the label \"Additional dimensions\" in the checkboxes row and changing the two non mutually exclusive in three mutually exclusive checkboxes \"None\", \"Z + M values\", \"M values\", with \"None\" pre checked by default (since it seems to me it's not possible to have two mutually exclusive checkboxes that could be both unchecked after one of them is chechekd).\r\n\r\n![image](https://user-images.githubusercontent.com/16253859/52111112-0577b780-2603-11e9-87bb-a1515ecc4ae2.png)\r\n\r\nNote: this proposed change however will make the New Shapefile Layer dialog inconsistent with the other New SpatiaLite/GeoPackage/Memory layer dialogs about the Z and M checkboxes. Could this be a problem?\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [ ] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and contain sufficient information in the commit message to be documented\r\n- [ ] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [ ] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTING.md#contributing-to-qgis) before each commit\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/461201250","html_url":"https://github.com/qgis/QGIS/pull/9061#issuecomment-461201250","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/9061","id":461201250,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MTIwMTI1MA==","user":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"created_at":"2019-02-06T21:48:47Z","updated_at":"2019-02-06T21:48:47Z","author_association":"MEMBER","body":"I also like the current state."}}
other: {"actor":{"display_login":"m-kuhn"}}