payload: {"action":"created","issue":{"url":"https://api.github.com/repos/founders-programme-2/commons/issues/133","repository_url":"https://api.github.com/repos/founders-programme-2/commons","labels_url":"https://api.github.com/repos/founders-programme-2/commons/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/founders-programme-2/commons/issues/133/comments","events_url":"https://api.github.com/repos/founders-programme-2/commons/issues/133/events","html_url":"https://github.com/founders-programme-2/commons/pull/133","id":439231672,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1MDgyODM1","number":133,"title":"Feature/tests","user":{"login":"charlielafosse","id":32115309,"node_id":"MDQ6VXNlcjMyMTE1MzA5","avatar_url":"https://avatars0.githubusercontent.com/u/32115309?v=4","gravatar_id":"","url":"https://api.github.com/users/charlielafosse","html_url":"https://github.com/charlielafosse","followers_url":"https://api.github.com/users/charlielafosse/followers","following_url":"https://api.github.com/users/charlielafosse/following{/other_user}","gists_url":"https://api.github.com/users/charlielafosse/gists{/gist_id}","starred_url":"https://api.github.com/users/charlielafosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlielafosse/subscriptions","organizations_url":"https://api.github.com/users/charlielafosse/orgs","repos_url":"https://api.github.com/users/charlielafosse/repos","events_url":"https://api.github.com/users/charlielafosse/events{/privacy}","received_events_url":"https://api.github.com/users/charlielafosse/received_events","type":"User","site_admin":false},"labels":[{"id":1309245758,"node_id":"MDU6TGFiZWwxMzA5MjQ1NzU4","url":"https://api.github.com/repos/founders-programme-2/commons/labels/awaiting-review","name":"awaiting-review","color":"f39c12","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2019-05-01T16:42:44Z","updated_at":"2019-05-02T10:56:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/founders-programme-2/commons/pulls/133","html_url":"https://github.com/founders-programme-2/commons/pull/133","diff_url":"https://github.com/founders-programme-2/commons/pull/133.diff","patch_url":"https://github.com/founders-programme-2/commons/pull/133.patch"},"body":"Hello! :leaves: \r\n\r\nSo this proved to be a little trickier than I thought it would've been, but what we've now got is:\r\n\r\n1. A unit test for the `About` component that just checks that it renders (lol)\r\n\r\n2. Some unit and integration tests for the `Method` and `MethodCard` components\r\n\r\nI hope it's something you can build off (if you have time!) and it was super interesting for me, so thank you for letting me tinker! I used [react-testing-library](https://testing-library.com/) which was really helpful for finding and selecting things in a kind of virtual DOM. The existing tests check for different effects upon the remaining resource points when a certain resource is selected.\r\n\r\nWith the way it's currently set up, you can create more `consts` for each method card's 'Use this resource' checkbox like so: \r\n\r\n`const networkMapCheckbox = getAllByTestId('Network map')[0];`\r\n\r\nAnd that test ID ('Network map') is now being passed from the `cardTitle` value in your `data/methodCardData.js`, down as a prop through `Method` and eventually landing as a unique `data-testid` attribute on the checkbox `input` for each `MethodCard` component that's rendered. You could theoretically chain together lots of `fireEvent.click`s on the different checkboxes and test that the remaining resource points are correct.\r\n\r\nRelates #115 "},"comment":{"url":"https://api.github.com/repos/founders-programme-2/commons/issues/comments/488630501","html_url":"https://github.com/founders-programme-2/commons/pull/133#issuecomment-488630501","issue_url":"https://api.github.com/repos/founders-programme-2/commons/issues/133","id":488630501,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4ODYzMDUwMQ==","user":{"login":"ali-7","id":36124895,"node_id":"MDQ6VXNlcjM2MTI0ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/36124895?v=4","gravatar_id":"","url":"https://api.github.com/users/ali-7","html_url":"https://github.com/ali-7","followers_url":"https://api.github.com/users/ali-7/followers","following_url":"https://api.github.com/users/ali-7/following{/other_user}","gists_url":"https://api.github.com/users/ali-7/gists{/gist_id}","starred_url":"https://api.github.com/users/ali-7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ali-7/subscriptions","organizations_url":"https://api.github.com/users/ali-7/orgs","repos_url":"https://api.github.com/users/ali-7/repos","events_url":"https://api.github.com/users/ali-7/events{/privacy}","received_events_url":"https://api.github.com/users/ali-7/received_events","type":"User","site_admin":false},"created_at":"2019-05-02T10:56:58Z","updated_at":"2019-05-02T10:56:58Z","author_association":"MEMBER","body":"> Also, do you know if it makes a difference with or without quotes? I know that there's a `JSON` standard that requires double quotes on the properties/key names of JSON objects, but I'm not sure about general objects\r\n\r\n@charlielafosse it will not make any difference, but I get the config on how to, from the eslint config docs, and saw some examples that use double quotes also in the `js` config, like they want to be consistent with `JSON` standard in `js` files. so that why I ask if there some reason to change it :joy: "}}
other: {"actor":{"display_login":"ali-7"}}