payload: {"action":"created","issue":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/4185","repository_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/4185/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/4185/comments","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/4185/events","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/4185","id":484001714,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5OTY3MDQy","number":4185,"title":"4176 Fix saving of shipping method when automatically advancing subscription order state","user":{"login":"kristinalim","id":2243,"node_id":"MDQ6VXNlcjIyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2243?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinalim","html_url":"https://github.com/kristinalim","followers_url":"https://api.github.com/users/kristinalim/followers","following_url":"https://api.github.com/users/kristinalim/following{/other_user}","gists_url":"https://api.github.com/users/kristinalim/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinalim/subscriptions","organizations_url":"https://api.github.com/users/kristinalim/orgs","repos_url":"https://api.github.com/users/kristinalim/repos","events_url":"https://api.github.com/users/kristinalim/events{/privacy}","received_events_url":"https://api.github.com/users/kristinalim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kristinalim","id":2243,"node_id":"MDQ6VXNlcjIyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2243?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinalim","html_url":"https://github.com/kristinalim","followers_url":"https://api.github.com/users/kristinalim/followers","following_url":"https://api.github.com/users/kristinalim/following{/other_user}","gists_url":"https://api.github.com/users/kristinalim/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinalim/subscriptions","organizations_url":"https://api.github.com/users/kristinalim/orgs","repos_url":"https://api.github.com/users/kristinalim/repos","events_url":"https://api.github.com/users/kristinalim/events{/privacy}","received_events_url":"https://api.github.com/users/kristinalim/received_events","type":"User","site_admin":false},"assignees":[{"login":"kristinalim","id":2243,"node_id":"MDQ6VXNlcjIyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2243?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinalim","html_url":"https://github.com/kristinalim","followers_url":"https://api.github.com/users/kristinalim/followers","following_url":"https://api.github.com/users/kristinalim/following{/other_user}","gists_url":"https://api.github.com/users/kristinalim/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinalim/subscriptions","organizations_url":"https://api.github.com/users/kristinalim/orgs","repos_url":"https://api.github.com/users/kristinalim/repos","events_url":"https://api.github.com/users/kristinalim/events{/privacy}","received_events_url":"https://api.github.com/users/kristinalim/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-08-22T13:40:33Z","updated_at":"2019-08-22T23:39:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/4185","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/4185","diff_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/4185.diff","patch_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/4185.patch"},"body":"#### What? Why?\r\n\r\n- Closes #4176\r\n\r\nWhen automatically advancing subscription orders from cart to completion, through `SubscriptionPlacementJob`, the original shipping method of the order is not retained.\r\n\r\nWe use `AdvanceOrderService` to wrap `order.next` with OFN-specific logic, such as retaining the shipping method when the order is transitioned to \"delivery\" state. `SubscriptionPlacementJob` still uses the `order.next` form, which loses the previously selected shipping method.\r\n\r\n#### What should we test?\r\n\r\n- Create three shipping methods:\r\n  * Volunteer discount with negative shipping fee.\r\n  * Delivery, $1 shipping fee.\r\n  * Express delivery, $2 shipping fee.\r\n- Create a subscription with the Express delivery as shipping method.\r\n- Open an order cycle for that subscription.\r\n- Wait six minutes for the order to be placed.\r\n- Check the shipping fee on the order. This should be $2 now.\r\n- Check other order details.\r\n\r\nNow just double-checking:\r\n\r\n- Close the order cycle.\r\n- Wait six minutes for the confirmation email to come through.\r\n- Check the shipping fee.\r\n- Check other order details.\r\n\r\n#### Release notes\r\n\r\n- Do not lose the previously selected shipping method for a subscription when automatically transitioning to \"delivery\" state through `SubscriptionPlacementJob`.\r\n\r\nChangelog Category: Fixed"},"comment":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments/524118222","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/4185#issuecomment-524118222","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/4185","id":524118222,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNDExODIyMg==","user":{"login":"kristinalim","id":2243,"node_id":"MDQ6VXNlcjIyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2243?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinalim","html_url":"https://github.com/kristinalim","followers_url":"https://api.github.com/users/kristinalim/followers","following_url":"https://api.github.com/users/kristinalim/following{/other_user}","gists_url":"https://api.github.com/users/kristinalim/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinalim/subscriptions","organizations_url":"https://api.github.com/users/kristinalim/orgs","repos_url":"https://api.github.com/users/kristinalim/repos","events_url":"https://api.github.com/users/kristinalim/events{/privacy}","received_events_url":"https://api.github.com/users/kristinalim/received_events","type":"User","site_admin":false},"created_at":"2019-08-22T23:39:57Z","updated_at":"2019-08-22T23:39:57Z","author_association":"MEMBER","body":"@mkllnk Thank you very much for adding the \"What should we test\" part! :heart:"}}
other: {"actor":{"display_login":"kristinalim"}}