payload: {"action":"created","comment":{"url":"https://api.github.com/repos/espressomd/espresso/pulls/comments/268645903","pull_request_review_id":218334779,"id":268645903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODY0NTkwMw==","diff_hunk":"@@ -165,30 +125,30 @@ cdef class PScriptInterface(object):\n         else:\n             raise TypeError(\"Unknown type for conversion to Variant\")\n \n-    cdef variant_to_python_object(self, Variant value) except +:\n+    cdef variant_to_python_object(self, const Variant & value) except +:\n         cdef ObjectId oid\n         cdef vector[Variant] vec\n-        cdef int type = value.which()\n         cdef shared_ptr[ScriptInterfaceBase] ptr\n-\n-        if < int > type == <int > NONE:\n+        if is_none(value):\n             return None\n-        if < int > type == <int > BOOL:\n-            return get[bool](value)\n-        if < int > type == <int > INT:\n-            return get[int](value)\n-        if < int > type == <int > DOUBLE:\n-            return get[double](value)\n-        if < int > type == <int > STRING:\n-            return to_str(get[string](value))\n-        if < int > type == <int > INT_VECTOR:\n-            return get[vector[int]](value)\n-        if < int > type == <int > DOUBLE_VECTOR:\n-            return get[vector[double]](value)\n-        if < int > type == <int > OBJECTID:\n+        if is_type[bool](value):","path":"src/python/espressomd/script_interface.pyx","position":160,"original_position":160,"commit_id":"ada134861a15121e685e121b026402bb9ba370b9","original_commit_id":"ada134861a15121e685e121b026402bb9ba370b9","user":{"login":"fweik","id":893663,"node_id":"MDQ6VXNlcjg5MzY2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/893663?v=4","gravatar_id":"","url":"https://api.github.com/users/fweik","html_url":"https://github.com/fweik","followers_url":"https://api.github.com/users/fweik/followers","following_url":"https://api.github.com/users/fweik/following{/other_user}","gists_url":"https://api.github.com/users/fweik/gists{/gist_id}","starred_url":"https://api.github.com/users/fweik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fweik/subscriptions","organizations_url":"https://api.github.com/users/fweik/orgs","repos_url":"https://api.github.com/users/fweik/repos","events_url":"https://api.github.com/users/fweik/events{/privacy}","received_events_url":"https://api.github.com/users/fweik/received_events","type":"User","site_admin":false},"body":"Can you elaborate on that?","created_at":"2019-03-25T13:43:45Z","updated_at":"2019-03-25T13:43:45Z","html_url":"https://github.com/espressomd/espresso/pull/2629#discussion_r268645903","pull_request_url":"https://api.github.com/repos/espressomd/espresso/pulls/2629","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/comments/268645903"},"html":{"href":"https://github.com/espressomd/espresso/pull/2629#discussion_r268645903"},"pull_request":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2629"}},"in_reply_to_id":268594257},"pull_request":{"url":"https://api.github.com/repos/espressomd/espresso/pulls/2629","id":263942815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzOTQyODE1","html_url":"https://github.com/espressomd/espresso/pull/2629","diff_url":"https://github.com/espressomd/espresso/pull/2629.diff","patch_url":"https://github.com/espressomd/espresso/pull/2629.patch","issue_url":"https://api.github.com/repos/espressomd/espresso/issues/2629","number":2629,"state":"open","locked":false,"title":"WIP: Vector3d support for ScriptInterface","user":{"login":"fweik","id":893663,"node_id":"MDQ6VXNlcjg5MzY2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/893663?v=4","gravatar_id":"","url":"https://api.github.com/users/fweik","html_url":"https://github.com/fweik","followers_url":"https://api.github.com/users/fweik/followers","following_url":"https://api.github.com/users/fweik/following{/other_user}","gists_url":"https://api.github.com/users/fweik/gists{/gist_id}","starred_url":"https://api.github.com/users/fweik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fweik/subscriptions","organizations_url":"https://api.github.com/users/fweik/orgs","repos_url":"https://api.github.com/users/fweik/repos","events_url":"https://api.github.com/users/fweik/events{/privacy}","received_events_url":"https://api.github.com/users/fweik/received_events","type":"User","site_admin":false},"body":"Fixes #2531. Fixes #1687.\r\nDescription of changes:\r\n - Directly support Vector3d for script_interface parameters\r\n - Moved conversions from python to c++\r\n\r\n","created_at":"2019-03-24T22:40:58Z","updated_at":"2019-03-25T13:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32d801719da632cebea7ccad9a5baa7afa8015fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/espressomd/espresso/pulls/2629/commits","review_comments_url":"https://api.github.com/repos/espressomd/espresso/pulls/2629/comments","review_comment_url":"https://api.github.com/repos/espressomd/espresso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressomd/espresso/issues/2629/comments","statuses_url":"https://api.github.com/repos/espressomd/espresso/statuses/ada134861a15121e685e121b026402bb9ba370b9","head":{"label":"fweik:Vector","ref":"Vector","sha":"ada134861a15121e685e121b026402bb9ba370b9","user":{"login":"fweik","id":893663,"node_id":"MDQ6VXNlcjg5MzY2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/893663?v=4","gravatar_id":"","url":"https://api.github.com/users/fweik","html_url":"https://github.com/fweik","followers_url":"https://api.github.com/users/fweik/followers","following_url":"https://api.github.com/users/fweik/following{/other_user}","gists_url":"https://api.github.com/users/fweik/gists{/gist_id}","starred_url":"https://api.github.com/users/fweik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fweik/subscriptions","organizations_url":"https://api.github.com/users/fweik/orgs","repos_url":"https://api.github.com/users/fweik/repos","events_url":"https://api.github.com/users/fweik/events{/privacy}","received_events_url":"https://api.github.com/users/fweik/received_events","type":"User","site_admin":false},"repo":{"id":18612897,"node_id":"MDEwOlJlcG9zaXRvcnkxODYxMjg5Nw==","name":"espresso","full_name":"fweik/espresso","private":false,"owner":{"login":"fweik","id":893663,"node_id":"MDQ6VXNlcjg5MzY2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/893663?v=4","gravatar_id":"","url":"https://api.github.com/users/fweik","html_url":"https://github.com/fweik","followers_url":"https://api.github.com/users/fweik/followers","following_url":"https://api.github.com/users/fweik/following{/other_user}","gists_url":"https://api.github.com/users/fweik/gists{/gist_id}","starred_url":"https://api.github.com/users/fweik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fweik/subscriptions","organizations_url":"https://api.github.com/users/fweik/orgs","repos_url":"https://api.github.com/users/fweik/repos","events_url":"https://api.github.com/users/fweik/events{/privacy}","received_events_url":"https://api.github.com/users/fweik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fweik/espresso","description":"The ESPResSo package","fork":true,"url":"https://api.github.com/repos/fweik/espresso","forks_url":"https://api.github.com/repos/fweik/espresso/forks","keys_url":"https://api.github.com/repos/fweik/espresso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fweik/espresso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fweik/espresso/teams","hooks_url":"https://api.github.com/repos/fweik/espresso/hooks","issue_events_url":"https://api.github.com/repos/fweik/espresso/issues/events{/number}","events_url":"https://api.github.com/repos/fweik/espresso/events","assignees_url":"https://api.github.com/repos/fweik/espresso/assignees{/user}","branches_url":"https://api.github.com/repos/fweik/espresso/branches{/branch}","tags_url":"https://api.github.com/repos/fweik/espresso/tags","blobs_url":"https://api.github.com/repos/fweik/espresso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fweik/espresso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fweik/espresso/git/refs{/sha}","trees_url":"https://api.github.com/repos/fweik/espresso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fweik/espresso/statuses/{sha}","languages_url":"https://api.github.com/repos/fweik/espresso/languages","stargazers_url":"https://api.github.com/repos/fweik/espresso/stargazers","contributors_url":"https://api.github.com/repos/fweik/espresso/contributors","subscribers_url":"https://api.github.com/repos/fweik/espresso/subscribers","subscription_url":"https://api.github.com/repos/fweik/espresso/subscription","commits_url":"https://api.github.com/repos/fweik/espresso/commits{/sha}","git_commits_url":"https://api.github.com/repos/fweik/espresso/git/commits{/sha}","comments_url":"https://api.github.com/repos/fweik/espresso/comments{/number}","issue_comment_url":"https://api.github.com/repos/fweik/espresso/issues/comments{/number}","contents_url":"https://api.github.com/repos/fweik/espresso/contents/{+path}","compare_url":"https://api.github.com/repos/fweik/espresso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fweik/espresso/merges","archive_url":"https://api.github.com/repos/fweik/espresso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fweik/espresso/downloads","issues_url":"https://api.github.com/repos/fweik/espresso/issues{/number}","pulls_url":"https://api.github.com/repos/fweik/espresso/pulls{/number}","milestones_url":"https://api.github.com/repos/fweik/espresso/milestones{/number}","notifications_url":"https://api.github.com/repos/fweik/espresso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fweik/espresso/labels{/name}","releases_url":"https://api.github.com/repos/fweik/espresso/releases{/id}","deployments_url":"https://api.github.com/repos/fweik/espresso/deployments","created_at":"2014-04-09T20:52:30Z","updated_at":"2019-03-15T11:21:00Z","pushed_at":"2019-03-24T23:12:10Z","git_url":"git://github.com/fweik/espresso.git","ssh_url":"git@github.com:fweik/espresso.git","clone_url":"https://github.com/fweik/espresso.git","svn_url":"https://github.com/fweik/espresso","homepage":"http://espressomd.org","size":122861,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"python"}},"base":{"label":"espressomd:python","ref":"python","sha":"b25c0148bde7908af926e6360198ac7532c6688a","user":{"login":"espressomd","id":689837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4OTgzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/689837?v=4","gravatar_id":"","url":"https://api.github.com/users/espressomd","html_url":"https://github.com/espressomd","followers_url":"https://api.github.com/users/espressomd/followers","following_url":"https://api.github.com/users/espressomd/following{/other_user}","gists_url":"https://api.github.com/users/espressomd/gists{/gist_id}","starred_url":"https://api.github.com/users/espressomd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressomd/subscriptions","organizations_url":"https://api.github.com/users/espressomd/orgs","repos_url":"https://api.github.com/users/espressomd/repos","events_url":"https://api.github.com/users/espressomd/events{/privacy}","received_events_url":"https://api.github.com/users/espressomd/received_events","type":"Organization","site_admin":false},"repo":{"id":1524644,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NjQ0","name":"espresso","full_name":"espressomd/espresso","private":false,"owner":{"login":"espressomd","id":689837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4OTgzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/689837?v=4","gravatar_id":"","url":"https://api.github.com/users/espressomd","html_url":"https://github.com/espressomd","followers_url":"https://api.github.com/users/espressomd/followers","following_url":"https://api.github.com/users/espressomd/following{/other_user}","gists_url":"https://api.github.com/users/espressomd/gists{/gist_id}","starred_url":"https://api.github.com/users/espressomd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressomd/subscriptions","organizations_url":"https://api.github.com/users/espressomd/orgs","repos_url":"https://api.github.com/users/espressomd/repos","events_url":"https://api.github.com/users/espressomd/events{/privacy}","received_events_url":"https://api.github.com/users/espressomd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/espressomd/espresso","description":"The ESPResSo package","fork":false,"url":"https://api.github.com/repos/espressomd/espresso","forks_url":"https://api.github.com/repos/espressomd/espresso/forks","keys_url":"https://api.github.com/repos/espressomd/espresso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressomd/espresso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressomd/espresso/teams","hooks_url":"https://api.github.com/repos/espressomd/espresso/hooks","issue_events_url":"https://api.github.com/repos/espressomd/espresso/issues/events{/number}","events_url":"https://api.github.com/repos/espressomd/espresso/events","assignees_url":"https://api.github.com/repos/espressomd/espresso/assignees{/user}","branches_url":"https://api.github.com/repos/espressomd/espresso/branches{/branch}","tags_url":"https://api.github.com/repos/espressomd/espresso/tags","blobs_url":"https://api.github.com/repos/espressomd/espresso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressomd/espresso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressomd/espresso/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressomd/espresso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressomd/espresso/statuses/{sha}","languages_url":"https://api.github.com/repos/espressomd/espresso/languages","stargazers_url":"https://api.github.com/repos/espressomd/espresso/stargazers","contributors_url":"https://api.github.com/repos/espressomd/espresso/contributors","subscribers_url":"https://api.github.com/repos/espressomd/espresso/subscribers","subscription_url":"https://api.github.com/repos/espressomd/espresso/subscription","commits_url":"https://api.github.com/repos/espressomd/espresso/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressomd/espresso/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressomd/espresso/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressomd/espresso/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressomd/espresso/contents/{+path}","compare_url":"https://api.github.com/repos/espressomd/espresso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressomd/espresso/merges","archive_url":"https://api.github.com/repos/espressomd/espresso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressomd/espresso/downloads","issues_url":"https://api.github.com/repos/espressomd/espresso/issues{/number}","pulls_url":"https://api.github.com/repos/espressomd/espresso/pulls{/number}","milestones_url":"https://api.github.com/repos/espressomd/espresso/milestones{/number}","notifications_url":"https://api.github.com/repos/espressomd/espresso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressomd/espresso/labels{/name}","releases_url":"https://api.github.com/repos/espressomd/espresso/releases{/id}","deployments_url":"https://api.github.com/repos/espressomd/espresso/deployments","created_at":"2011-03-25T07:43:15Z","updated_at":"2019-03-21T15:55:24Z","pushed_at":"2019-03-24T23:12:11Z","git_url":"git://github.com/espressomd/espresso.git","ssh_url":"git@github.com:espressomd/espresso.git","clone_url":"https://github.com/espressomd/espresso.git","svn_url":"https://github.com/espressomd/espresso","homepage":"http://espressomd.org","size":118932,"stargazers_count":85,"watchers_count":85,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":124,"open_issues":138,"watchers":85,"default_branch":"python"}},"_links":{"self":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2629"},"html":{"href":"https://github.com/espressomd/espresso/pull/2629"},"issue":{"href":"https://api.github.com/repos/espressomd/espresso/issues/2629"},"comments":{"href":"https://api.github.com/repos/espressomd/espresso/issues/2629/comments"},"review_comments":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2629/comments"},"review_comment":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2629/commits"},"statuses":{"href":"https://api.github.com/repos/espressomd/espresso/statuses/ada134861a15121e685e121b026402bb9ba370b9"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"fweik"}}