payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/comments/352744460","pull_request_review_id":325426357,"id":352744460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mjc0NDQ2MA==","diff_hunk":"@@ -27,4 +27,11 @@ include(\"testcases.jl\")\n         ρ_alg = fourier(scfres.ρ)\n         @test maximum(abs.(ρ_alg - ρ_nl)) < 30tol\n     end\n+\n+    # Run other mixing with nlsolve (the others are too slow...)\n+    for mixing in (KerkerMixing(), SimpleMixing(), nothing)\n+        scfres = self_consistent_field!(Hamiltonian(basis, ρ0), n_bands, tol=tol, solver=scf_nlsolve_solver(), mixing=mixing)","path":"test/scf_compare.jl","position":null,"original_position":7,"commit_id":"864b84a1fd3a7fff9a9790ed096d14d5a76bc7dc","original_commit_id":"a2f94663caf5f93552afa5bd3ec7460e86be949a","user":{"login":"antoine-levitt","id":88065,"node_id":"MDQ6VXNlcjg4MDY1","avatar_url":"https://avatars2.githubusercontent.com/u/88065?v=4","gravatar_id":"","url":"https://api.github.com/users/antoine-levitt","html_url":"https://github.com/antoine-levitt","followers_url":"https://api.github.com/users/antoine-levitt/followers","following_url":"https://api.github.com/users/antoine-levitt/following{/other_user}","gists_url":"https://api.github.com/users/antoine-levitt/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-levitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-levitt/subscriptions","organizations_url":"https://api.github.com/users/antoine-levitt/orgs","repos_url":"https://api.github.com/users/antoine-levitt/repos","events_url":"https://api.github.com/users/antoine-levitt/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-levitt/received_events","type":"User","site_admin":false},"body":"fix your editor ;-)\r\n(I broke the line)","created_at":"2019-12-02T18:01:40Z","updated_at":"2019-12-02T18:01:40Z","html_url":"https://github.com/JuliaMolSim/DFTK.jl/pull/71#discussion_r352744460","pull_request_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/comments/352744460"},"html":{"href":"https://github.com/JuliaMolSim/DFTK.jl/pull/71#discussion_r352744460"},"pull_request":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71"}},"in_reply_to_id":352590052},"pull_request":{"url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71","id":346951896,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2OTUxODk2","html_url":"https://github.com/JuliaMolSim/DFTK.jl/pull/71","diff_url":"https://github.com/JuliaMolSim/DFTK.jl/pull/71.diff","patch_url":"https://github.com/JuliaMolSim/DFTK.jl/pull/71.patch","issue_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/71","number":71,"state":"open","locked":false,"title":"Kerker","user":{"login":"antoine-levitt","id":88065,"node_id":"MDQ6VXNlcjg4MDY1","avatar_url":"https://avatars2.githubusercontent.com/u/88065?v=4","gravatar_id":"","url":"https://api.github.com/users/antoine-levitt","html_url":"https://github.com/antoine-levitt","followers_url":"https://api.github.com/users/antoine-levitt/followers","following_url":"https://api.github.com/users/antoine-levitt/following{/other_user}","gists_url":"https://api.github.com/users/antoine-levitt/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-levitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-levitt/subscriptions","organizations_url":"https://api.github.com/users/antoine-levitt/orgs","repos_url":"https://api.github.com/users/antoine-levitt/repos","events_url":"https://api.github.com/users/antoine-levitt/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-levitt/received_events","type":"User","site_admin":false},"body":"Test case: supercell of magnesium in one direction, with random deviations to the positions:\r\n```\r\nRandom.seed!(0)\r\ncomposition = [Mg => [x + .1*randn(3) ./ supercell for x in composition[1][2]]]\r\n```\r\nwhere Kerker clearly dominates.","created_at":"2019-11-29T08:58:03Z","updated_at":"2019-12-02T18:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4575fc2b9859b651a9eaa8cc082921012a29191","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71/commits","review_comments_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71/comments","review_comment_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/71/comments","statuses_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/statuses/864b84a1fd3a7fff9a9790ed096d14d5a76bc7dc","head":{"label":"JuliaMolSim:kerker","ref":"kerker","sha":"864b84a1fd3a7fff9a9790ed096d14d5a76bc7dc","user":{"login":"JuliaMolSim","id":57396615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3Mzk2NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/57396615?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaMolSim","html_url":"https://github.com/JuliaMolSim","followers_url":"https://api.github.com/users/JuliaMolSim/followers","following_url":"https://api.github.com/users/JuliaMolSim/following{/other_user}","gists_url":"https://api.github.com/users/JuliaMolSim/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaMolSim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaMolSim/subscriptions","organizations_url":"https://api.github.com/users/JuliaMolSim/orgs","repos_url":"https://api.github.com/users/JuliaMolSim/repos","events_url":"https://api.github.com/users/JuliaMolSim/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaMolSim/received_events","type":"Organization","site_admin":false},"repo":{"id":181734238,"node_id":"MDEwOlJlcG9zaXRvcnkxODE3MzQyMzg=","name":"DFTK.jl","full_name":"JuliaMolSim/DFTK.jl","private":false,"owner":{"login":"JuliaMolSim","id":57396615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3Mzk2NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/57396615?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaMolSim","html_url":"https://github.com/JuliaMolSim","followers_url":"https://api.github.com/users/JuliaMolSim/followers","following_url":"https://api.github.com/users/JuliaMolSim/following{/other_user}","gists_url":"https://api.github.com/users/JuliaMolSim/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaMolSim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaMolSim/subscriptions","organizations_url":"https://api.github.com/users/JuliaMolSim/orgs","repos_url":"https://api.github.com/users/JuliaMolSim/repos","events_url":"https://api.github.com/users/JuliaMolSim/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaMolSim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaMolSim/DFTK.jl","description":"Density-functional toolkit","fork":false,"url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl","forks_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/forks","keys_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/teams","hooks_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/events","assignees_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/tags","blobs_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/subscription","commits_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/merges","archive_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/downloads","issues_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/deployments","created_at":"2019-04-16T17:15:53Z","updated_at":"2019-12-02T09:35:39Z","pushed_at":"2019-12-02T18:01:22Z","git_url":"git://github.com/JuliaMolSim/DFTK.jl.git","ssh_url":"git@github.com:JuliaMolSim/DFTK.jl.git","clone_url":"https://github.com/JuliaMolSim/DFTK.jl.git","svn_url":"https://github.com/JuliaMolSim/DFTK.jl","homepage":"https://dftk.org","size":659,"stargazers_count":11,"watchers_count":11,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":20,"watchers":11,"default_branch":"master"}},"base":{"label":"JuliaMolSim:master","ref":"master","sha":"f426ceacc78d048b02bf9462765bb98bfd0368d5","user":{"login":"JuliaMolSim","id":57396615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3Mzk2NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/57396615?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaMolSim","html_url":"https://github.com/JuliaMolSim","followers_url":"https://api.github.com/users/JuliaMolSim/followers","following_url":"https://api.github.com/users/JuliaMolSim/following{/other_user}","gists_url":"https://api.github.com/users/JuliaMolSim/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaMolSim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaMolSim/subscriptions","organizations_url":"https://api.github.com/users/JuliaMolSim/orgs","repos_url":"https://api.github.com/users/JuliaMolSim/repos","events_url":"https://api.github.com/users/JuliaMolSim/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaMolSim/received_events","type":"Organization","site_admin":false},"repo":{"id":181734238,"node_id":"MDEwOlJlcG9zaXRvcnkxODE3MzQyMzg=","name":"DFTK.jl","full_name":"JuliaMolSim/DFTK.jl","private":false,"owner":{"login":"JuliaMolSim","id":57396615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3Mzk2NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/57396615?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaMolSim","html_url":"https://github.com/JuliaMolSim","followers_url":"https://api.github.com/users/JuliaMolSim/followers","following_url":"https://api.github.com/users/JuliaMolSim/following{/other_user}","gists_url":"https://api.github.com/users/JuliaMolSim/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaMolSim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaMolSim/subscriptions","organizations_url":"https://api.github.com/users/JuliaMolSim/orgs","repos_url":"https://api.github.com/users/JuliaMolSim/repos","events_url":"https://api.github.com/users/JuliaMolSim/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaMolSim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaMolSim/DFTK.jl","description":"Density-functional toolkit","fork":false,"url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl","forks_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/forks","keys_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/teams","hooks_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/events","assignees_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/tags","blobs_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/subscription","commits_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/merges","archive_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/downloads","issues_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/deployments","created_at":"2019-04-16T17:15:53Z","updated_at":"2019-12-02T09:35:39Z","pushed_at":"2019-12-02T18:01:22Z","git_url":"git://github.com/JuliaMolSim/DFTK.jl.git","ssh_url":"git@github.com:JuliaMolSim/DFTK.jl.git","clone_url":"https://github.com/JuliaMolSim/DFTK.jl.git","svn_url":"https://github.com/JuliaMolSim/DFTK.jl","homepage":"https://dftk.org","size":659,"stargazers_count":11,"watchers_count":11,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":20,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71"},"html":{"href":"https://github.com/JuliaMolSim/DFTK.jl/pull/71"},"issue":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/71"},"comments":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaMolSim/DFTK.jl/statuses/864b84a1fd3a7fff9a9790ed096d14d5a76bc7dc"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"antoine-levitt"}}