payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twosigma/waiter/pulls/comments/312717287","pull_request_review_id":273441727,"id":312717287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjcxNzI4Nw==","diff_hunk":"@@ -279,9 +280,55 @@\n                 (fn []\n                   (let [{:keys [active-instances failed-instances]} (:instances (service-settings waiter-url service-id))\n                         pod-ids (->> (concat active-instances failed-instances)\n-                                  (map :id)\n-                                  (map (fn [instance-id]\n-                                         (subs instance-id 0 (string/last-index-of instance-id \"-\"))))\n-                                  (into #{}))]\n+                                     (map :k8s/pod-name)\n+                                     (into #{}))]\n                     (log/info pod-ids)\n                     (< 1 (count pod-ids)))))))))))\n+\n+(deftest ^:parallel ^:integration-slow ^:resource-heavy test-kubernetes-pod-expiry-grace-period\n+  (testing-using-waiter-url\n+    (when (using-k8s? waiter-url)\n+      (if-let [custom-image (System/getenv \"INTEGRATION_TEST_BAD_IMAGE\")]\n+        (let [{:keys [container-running-grace-secs]} (get-kubernetes-scheduler-settings waiter-url)\n+              request-timeout-ms (* 3 container-running-grace-secs 1000)\n+              waiter-params (assoc (kitchen-params)\n+                              :distribution-scheme \"simple\"\n+                              :image custom-image\n+                              :name (rand-name)\n+                              :timeout request-timeout-ms)\n+              waiter-headers (pc/map-keys #(str \"x-waiter-\" (name %)) waiter-params)\n+              service-id (retrieve-service-id waiter-url waiter-headers)\n+              abort-ch (async/promise-chan)\n+              status-promise (promise)]\n+          (is service-id)\n+          (if (> container-running-grace-secs 150)\n+            (is false \"container-running-grace-secs will cause the test to run for too long\")\n+            (with-service-cleanup\n+              service-id\n+              ;; make request to launch service\n+              (async/thread","path":"waiter/integration/waiter/kubernetes_scheduler_integration_test.clj","position":null,"original_position":66,"commit_id":"6fecf8bbef8168d728dafc24c6dba8e3a3e1f595","original_commit_id":"cf534d4c6c0f95ad64e6928e4d8252370684805d","user":{"login":"shamsimam","id":6611249,"node_id":"MDQ6VXNlcjY2MTEyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6611249?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsimam","html_url":"https://github.com/shamsimam","followers_url":"https://api.github.com/users/shamsimam/followers","following_url":"https://api.github.com/users/shamsimam/following{/other_user}","gists_url":"https://api.github.com/users/shamsimam/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsimam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsimam/subscriptions","organizations_url":"https://api.github.com/users/shamsimam/orgs","repos_url":"https://api.github.com/users/shamsimam/repos","events_url":"https://api.github.com/users/shamsimam/events{/privacy}","received_events_url":"https://api.github.com/users/shamsimam/received_events","type":"User","site_admin":false},"body":"I realized that the autoscaler will try to keep at least `min-instances` running. Relying on that behavior, simplified the test even more.","created_at":"2019-08-10T22:55:54Z","updated_at":"2019-08-10T22:55:54Z","html_url":"https://github.com/twosigma/waiter/pull/906#discussion_r312717287","pull_request_url":"https://api.github.com/repos/twosigma/waiter/pulls/906","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/twosigma/waiter/pulls/comments/312717287"},"html":{"href":"https://github.com/twosigma/waiter/pull/906#discussion_r312717287"},"pull_request":{"href":"https://api.github.com/repos/twosigma/waiter/pulls/906"}},"in_reply_to_id":312690565},"pull_request":{"url":"https://api.github.com/repos/twosigma/waiter/pulls/906","id":304865975,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0ODY1OTc1","html_url":"https://github.com/twosigma/waiter/pull/906","diff_url":"https://github.com/twosigma/waiter/pull/906.diff","patch_url":"https://github.com/twosigma/waiter/pull/906.patch","issue_url":"https://api.github.com/repos/twosigma/waiter/issues/906","number":906,"state":"open","locked":false,"title":"expires kubernetes services instances stuck in non-running state","user":{"login":"shamsimam","id":6611249,"node_id":"MDQ6VXNlcjY2MTEyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6611249?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsimam","html_url":"https://github.com/shamsimam","followers_url":"https://api.github.com/users/shamsimam/followers","following_url":"https://api.github.com/users/shamsimam/following{/other_user}","gists_url":"https://api.github.com/users/shamsimam/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsimam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsimam/subscriptions","organizations_url":"https://api.github.com/users/shamsimam/orgs","repos_url":"https://api.github.com/users/shamsimam/repos","events_url":"https://api.github.com/users/shamsimam/events{/privacy}","received_events_url":"https://api.github.com/users/shamsimam/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this PR\r\n\r\n- adds the container-running-grace-secs configuration to the kubernetes scheduler\r\n\r\n## Why are we making these changes?\r\n\r\nWe would like to replace pods that do not start but are not cleaned up by the grace period trigger (which takes effect only after the container has started) in kubernetes.\r\n","created_at":"2019-08-06T19:54:23Z","updated_at":"2019-08-10T22:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92f1ad30f1c9b53b5e4a850b2cc3485967be1a08","assignee":{"login":"shamsimam","id":6611249,"node_id":"MDQ6VXNlcjY2MTEyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6611249?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsimam","html_url":"https://github.com/shamsimam","followers_url":"https://api.github.com/users/shamsimam/followers","following_url":"https://api.github.com/users/shamsimam/following{/other_user}","gists_url":"https://api.github.com/users/shamsimam/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsimam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsimam/subscriptions","organizations_url":"https://api.github.com/users/shamsimam/orgs","repos_url":"https://api.github.com/users/shamsimam/repos","events_url":"https://api.github.com/users/shamsimam/events{/privacy}","received_events_url":"https://api.github.com/users/shamsimam/received_events","type":"User","site_admin":false},"assignees":[{"login":"shamsimam","id":6611249,"node_id":"MDQ6VXNlcjY2MTEyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6611249?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsimam","html_url":"https://github.com/shamsimam","followers_url":"https://api.github.com/users/shamsimam/followers","following_url":"https://api.github.com/users/shamsimam/following{/other_user}","gists_url":"https://api.github.com/users/shamsimam/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsimam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsimam/subscriptions","organizations_url":"https://api.github.com/users/shamsimam/orgs","repos_url":"https://api.github.com/users/shamsimam/repos","events_url":"https://api.github.com/users/shamsimam/events{/privacy}","received_events_url":"https://api.github.com/users/shamsimam/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twosigma/waiter/pulls/906/commits","review_comments_url":"https://api.github.com/repos/twosigma/waiter/pulls/906/comments","review_comment_url":"https://api.github.com/repos/twosigma/waiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twosigma/waiter/issues/906/comments","statuses_url":"https://api.github.com/repos/twosigma/waiter/statuses/6fecf8bbef8168d728dafc24c6dba8e3a3e1f595","head":{"label":"twosigma:container-running-grace-secs","ref":"container-running-grace-secs","sha":"6fecf8bbef8168d728dafc24c6dba8e3a3e1f595","user":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"repo":{"id":81378873,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM3ODg3Mw==","name":"waiter","full_name":"twosigma/waiter","private":false,"owner":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twosigma/waiter","description":"Runs, manages, and autoscales web services on Mesos and Kubernetes","fork":false,"url":"https://api.github.com/repos/twosigma/waiter","forks_url":"https://api.github.com/repos/twosigma/waiter/forks","keys_url":"https://api.github.com/repos/twosigma/waiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twosigma/waiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twosigma/waiter/teams","hooks_url":"https://api.github.com/repos/twosigma/waiter/hooks","issue_events_url":"https://api.github.com/repos/twosigma/waiter/issues/events{/number}","events_url":"https://api.github.com/repos/twosigma/waiter/events","assignees_url":"https://api.github.com/repos/twosigma/waiter/assignees{/user}","branches_url":"https://api.github.com/repos/twosigma/waiter/branches{/branch}","tags_url":"https://api.github.com/repos/twosigma/waiter/tags","blobs_url":"https://api.github.com/repos/twosigma/waiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twosigma/waiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twosigma/waiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/twosigma/waiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twosigma/waiter/statuses/{sha}","languages_url":"https://api.github.com/repos/twosigma/waiter/languages","stargazers_url":"https://api.github.com/repos/twosigma/waiter/stargazers","contributors_url":"https://api.github.com/repos/twosigma/waiter/contributors","subscribers_url":"https://api.github.com/repos/twosigma/waiter/subscribers","subscription_url":"https://api.github.com/repos/twosigma/waiter/subscription","commits_url":"https://api.github.com/repos/twosigma/waiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/twosigma/waiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/twosigma/waiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/twosigma/waiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/twosigma/waiter/contents/{+path}","compare_url":"https://api.github.com/repos/twosigma/waiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twosigma/waiter/merges","archive_url":"https://api.github.com/repos/twosigma/waiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twosigma/waiter/downloads","issues_url":"https://api.github.com/repos/twosigma/waiter/issues{/number}","pulls_url":"https://api.github.com/repos/twosigma/waiter/pulls{/number}","milestones_url":"https://api.github.com/repos/twosigma/waiter/milestones{/number}","notifications_url":"https://api.github.com/repos/twosigma/waiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twosigma/waiter/labels{/name}","releases_url":"https://api.github.com/repos/twosigma/waiter/releases{/id}","deployments_url":"https://api.github.com/repos/twosigma/waiter/deployments","created_at":"2017-02-08T21:40:37Z","updated_at":"2019-08-09T21:24:09Z","pushed_at":"2019-08-10T22:54:57Z","git_url":"git://github.com/twosigma/waiter.git","ssh_url":"git@github.com:twosigma/waiter.git","clone_url":"https://github.com/twosigma/waiter.git","svn_url":"https://github.com/twosigma/waiter","homepage":"","size":5301,"stargazers_count":53,"watchers_count":53,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":43,"watchers":53,"default_branch":"master"}},"base":{"label":"twosigma:master","ref":"master","sha":"2fdb496f64df32cd02347c07f2d4b01d831342e0","user":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"repo":{"id":81378873,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM3ODg3Mw==","name":"waiter","full_name":"twosigma/waiter","private":false,"owner":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twosigma/waiter","description":"Runs, manages, and autoscales web services on Mesos and Kubernetes","fork":false,"url":"https://api.github.com/repos/twosigma/waiter","forks_url":"https://api.github.com/repos/twosigma/waiter/forks","keys_url":"https://api.github.com/repos/twosigma/waiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twosigma/waiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twosigma/waiter/teams","hooks_url":"https://api.github.com/repos/twosigma/waiter/hooks","issue_events_url":"https://api.github.com/repos/twosigma/waiter/issues/events{/number}","events_url":"https://api.github.com/repos/twosigma/waiter/events","assignees_url":"https://api.github.com/repos/twosigma/waiter/assignees{/user}","branches_url":"https://api.github.com/repos/twosigma/waiter/branches{/branch}","tags_url":"https://api.github.com/repos/twosigma/waiter/tags","blobs_url":"https://api.github.com/repos/twosigma/waiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twosigma/waiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twosigma/waiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/twosigma/waiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twosigma/waiter/statuses/{sha}","languages_url":"https://api.github.com/repos/twosigma/waiter/languages","stargazers_url":"https://api.github.com/repos/twosigma/waiter/stargazers","contributors_url":"https://api.github.com/repos/twosigma/waiter/contributors","subscribers_url":"https://api.github.com/repos/twosigma/waiter/subscribers","subscription_url":"https://api.github.com/repos/twosigma/waiter/subscription","commits_url":"https://api.github.com/repos/twosigma/waiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/twosigma/waiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/twosigma/waiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/twosigma/waiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/twosigma/waiter/contents/{+path}","compare_url":"https://api.github.com/repos/twosigma/waiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twosigma/waiter/merges","archive_url":"https://api.github.com/repos/twosigma/waiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twosigma/waiter/downloads","issues_url":"https://api.github.com/repos/twosigma/waiter/issues{/number}","pulls_url":"https://api.github.com/repos/twosigma/waiter/pulls{/number}","milestones_url":"https://api.github.com/repos/twosigma/waiter/milestones{/number}","notifications_url":"https://api.github.com/repos/twosigma/waiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twosigma/waiter/labels{/name}","releases_url":"https://api.github.com/repos/twosigma/waiter/releases{/id}","deployments_url":"https://api.github.com/repos/twosigma/waiter/deployments","created_at":"2017-02-08T21:40:37Z","updated_at":"2019-08-09T21:24:09Z","pushed_at":"2019-08-10T22:54:57Z","git_url":"git://github.com/twosigma/waiter.git","ssh_url":"git@github.com:twosigma/waiter.git","clone_url":"https://github.com/twosigma/waiter.git","svn_url":"https://github.com/twosigma/waiter","homepage":"","size":5301,"stargazers_count":53,"watchers_count":53,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":43,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twosigma/waiter/pulls/906"},"html":{"href":"https://github.com/twosigma/waiter/pull/906"},"issue":{"href":"https://api.github.com/repos/twosigma/waiter/issues/906"},"comments":{"href":"https://api.github.com/repos/twosigma/waiter/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/twosigma/waiter/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/twosigma/waiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twosigma/waiter/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/twosigma/waiter/statuses/6fecf8bbef8168d728dafc24c6dba8e3a3e1f595"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"shamsimam"}}