payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/comments/262983990","pull_request_review_id":211284392,"id":262983990,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Mjk4Mzk5MA==","diff_hunk":"@@ -3,60 +3,78 @@\n using BinaryBuilder\n \n name = \"LibCURL\"\n-version = v\"7.61.0\"\n+version = v\"7.64.0\"\n \n # Collection of sources required to build LibCURL\n sources = [\n-    \"https://curl.haxx.se/download/curl-7.61.0.tar.gz\" =>\n-    \"64141f0db4945268a21b490d58806b97c615d3d0c75bf8c335bbe0efd13b45b5\",\n-\n+    \"https://curl.haxx.se/download/curl-7.64.0.tar.gz\" =>\n+    \"cb90d2eb74d4e358c1ed1489f8e3af96b50ea4374ad71f143fa4595e998d81b5\",\n ]\n \n # Bash recipe for building across all platforms\n script = raw\"\"\"\n-cd $WORKSPACE/srcdir/curl-7.61.0\n-./configure --prefix=$prefix --host=$target --with-mbedtls --without-ssl --disable-manual\n+cd $WORKSPACE/srcdir/curl-7.64.0\n+\n+# Set up ca path/bundle\n+ca_args=\"\"\n+if [[ $target == x86_64-apple-darwin14 ]]; then\n+    ca_args=\"--with-ca-bundle=/etc/ssl/cert.pem\"\n+elif [[ $target == *-linux-* ]]; then\n+    ca_args=\"--with-ca-bundle=/etc/ssl/certs/ca-certificates.crt\"\n+fi","path":"build_tarballs.jl","position":28,"original_position":28,"commit_id":"26e3bde1f310e26bb59ecbbb14a1e7841ecc7293","original_commit_id":"26e3bde1f310e26bb59ecbbb14a1e7841ecc7293","user":{"login":"fchorney","id":202139,"node_id":"MDQ6VXNlcjIwMjEzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/202139?v=4","gravatar_id":"","url":"https://api.github.com/users/fchorney","html_url":"https://github.com/fchorney","followers_url":"https://api.github.com/users/fchorney/followers","following_url":"https://api.github.com/users/fchorney/following{/other_user}","gists_url":"https://api.github.com/users/fchorney/gists{/gist_id}","starred_url":"https://api.github.com/users/fchorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fchorney/subscriptions","organizations_url":"https://api.github.com/users/fchorney/orgs","repos_url":"https://api.github.com/users/fchorney/repos","events_url":"https://api.github.com/users/fchorney/events{/privacy}","received_events_url":"https://api.github.com/users/fchorney/received_events","type":"User","site_admin":false},"body":"yeah, I think it'll just put that path into the build so that it looks for the cacert there. I don't think there's a way to actually embed a cacert into it based on what I've seen so far. I could change this build to simply update everything, and perhaps mess with the certs at a later date, so we don't introduce this change into this PR. ","created_at":"2019-03-06T15:11:20Z","updated_at":"2019-03-06T15:11:20Z","html_url":"https://github.com/JuliaWeb/LibCURLBuilder/pull/12#discussion_r262983990","pull_request_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/comments/262983990"},"html":{"href":"https://github.com/JuliaWeb/LibCURLBuilder/pull/12#discussion_r262983990"},"pull_request":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12"}},"in_reply_to_id":262556981},"pull_request":{"url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12","id":257591398,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NTkxMzk4","html_url":"https://github.com/JuliaWeb/LibCURLBuilder/pull/12","diff_url":"https://github.com/JuliaWeb/LibCURLBuilder/pull/12.diff","patch_url":"https://github.com/JuliaWeb/LibCURLBuilder/pull/12.patch","issue_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues/12","number":12,"state":"open","locked":false,"title":"Update CURL, MbedTLS, and Zlib","user":{"login":"fchorney","id":202139,"node_id":"MDQ6VXNlcjIwMjEzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/202139?v=4","gravatar_id":"","url":"https://api.github.com/users/fchorney","html_url":"https://github.com/fchorney","followers_url":"https://api.github.com/users/fchorney/followers","following_url":"https://api.github.com/users/fchorney/following{/other_user}","gists_url":"https://api.github.com/users/fchorney/gists{/gist_id}","starred_url":"https://api.github.com/users/fchorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fchorney/subscriptions","organizations_url":"https://api.github.com/users/fchorney/orgs","repos_url":"https://api.github.com/users/fchorney/repos","events_url":"https://api.github.com/users/fchorney/events{/privacy}","received_events_url":"https://api.github.com/users/fchorney/received_events","type":"User","site_admin":false},"body":"- CURL: 7.61.0 -> 7.64.0\r\n- MbedTLS: 0.11.0 -> 0.17.0\r\n- Zlib: 1.0.2 -> 1.0.3\r\n- FreeBSD Doesn't seem to want to compile anymore possibly due to https://github.com/JuliaPackaging/BinaryBuilder.jl/pull/390\r\n- Pin BinaryBuilder to version 0.1.4 so we aren't always using master and we can upgrade on a need be basis. \r\n- MbedTLS version in .travis.yml is pinned to 0.6.6 because 0.6.7 is currently broken. see https://github.com/JuliaWeb/MbedTLS.jl/issues/193\r\n- Build script also tries to build in the openssl CA Cert\r\n  - On macOS it links to /etc/ssl/cert.pem\r\n  - On linux it links to /etc/ssl/certs/ca-certificates.crt","created_at":"2019-03-01T21:43:36Z","updated_at":"2019-03-06T15:11:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd434343cdb2e1425f60f50989c9dc2d089595bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12/commits","review_comments_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12/comments","review_comment_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues/12/comments","statuses_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/statuses/26e3bde1f310e26bb59ecbbb14a1e7841ecc7293","head":{"label":"fchorney:fc/update-libcurl","ref":"fc/update-libcurl","sha":"26e3bde1f310e26bb59ecbbb14a1e7841ecc7293","user":{"login":"fchorney","id":202139,"node_id":"MDQ6VXNlcjIwMjEzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/202139?v=4","gravatar_id":"","url":"https://api.github.com/users/fchorney","html_url":"https://github.com/fchorney","followers_url":"https://api.github.com/users/fchorney/followers","following_url":"https://api.github.com/users/fchorney/following{/other_user}","gists_url":"https://api.github.com/users/fchorney/gists{/gist_id}","starred_url":"https://api.github.com/users/fchorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fchorney/subscriptions","organizations_url":"https://api.github.com/users/fchorney/orgs","repos_url":"https://api.github.com/users/fchorney/repos","events_url":"https://api.github.com/users/fchorney/events{/privacy}","received_events_url":"https://api.github.com/users/fchorney/received_events","type":"User","site_admin":false},"repo":{"id":173371751,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMzNzE3NTE=","name":"LibCURLBuilder","full_name":"fchorney/LibCURLBuilder","private":false,"owner":{"login":"fchorney","id":202139,"node_id":"MDQ6VXNlcjIwMjEzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/202139?v=4","gravatar_id":"","url":"https://api.github.com/users/fchorney","html_url":"https://github.com/fchorney","followers_url":"https://api.github.com/users/fchorney/followers","following_url":"https://api.github.com/users/fchorney/following{/other_user}","gists_url":"https://api.github.com/users/fchorney/gists{/gist_id}","starred_url":"https://api.github.com/users/fchorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fchorney/subscriptions","organizations_url":"https://api.github.com/users/fchorney/orgs","repos_url":"https://api.github.com/users/fchorney/repos","events_url":"https://api.github.com/users/fchorney/events{/privacy}","received_events_url":"https://api.github.com/users/fchorney/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fchorney/LibCURLBuilder","description":null,"fork":true,"url":"https://api.github.com/repos/fchorney/LibCURLBuilder","forks_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/forks","keys_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/teams","hooks_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/hooks","issue_events_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/issues/events{/number}","events_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/events","assignees_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/assignees{/user}","branches_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/branches{/branch}","tags_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/tags","blobs_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/languages","stargazers_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/stargazers","contributors_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/contributors","subscribers_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/subscribers","subscription_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/subscription","commits_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/contents/{+path}","compare_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/merges","archive_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/downloads","issues_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/issues{/number}","pulls_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/labels{/name}","releases_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/releases{/id}","deployments_url":"https://api.github.com/repos/fchorney/LibCURLBuilder/deployments","created_at":"2019-03-01T21:41:55Z","updated_at":"2019-03-01T21:41:57Z","pushed_at":"2019-03-04T20:59:41Z","git_url":"git://github.com/fchorney/LibCURLBuilder.git","ssh_url":"git@github.com:fchorney/LibCURLBuilder.git","clone_url":"https://github.com/fchorney/LibCURLBuilder.git","svn_url":"https://github.com/fchorney/LibCURLBuilder","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaWeb:master","ref":"master","sha":"702ba2fe8e8bbc382df366d027d4742fd400bf36","user":{"login":"JuliaWeb","id":8564604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjQ2MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8564604?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaWeb","html_url":"https://github.com/JuliaWeb","followers_url":"https://api.github.com/users/JuliaWeb/followers","following_url":"https://api.github.com/users/JuliaWeb/following{/other_user}","gists_url":"https://api.github.com/users/JuliaWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaWeb/subscriptions","organizations_url":"https://api.github.com/users/JuliaWeb/orgs","repos_url":"https://api.github.com/users/JuliaWeb/repos","events_url":"https://api.github.com/users/JuliaWeb/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaWeb/received_events","type":"Organization","site_admin":false},"repo":{"id":144387914,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzODc5MTQ=","name":"LibCURLBuilder","full_name":"JuliaWeb/LibCURLBuilder","private":false,"owner":{"login":"JuliaWeb","id":8564604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjQ2MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8564604?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaWeb","html_url":"https://github.com/JuliaWeb","followers_url":"https://api.github.com/users/JuliaWeb/followers","following_url":"https://api.github.com/users/JuliaWeb/following{/other_user}","gists_url":"https://api.github.com/users/JuliaWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaWeb/subscriptions","organizations_url":"https://api.github.com/users/JuliaWeb/orgs","repos_url":"https://api.github.com/users/JuliaWeb/repos","events_url":"https://api.github.com/users/JuliaWeb/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaWeb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaWeb/LibCURLBuilder","description":null,"fork":false,"url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder","forks_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/forks","keys_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/teams","hooks_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/hooks","issue_events_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/events","assignees_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/tags","blobs_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/languages","stargazers_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/stargazers","contributors_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/contributors","subscribers_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/subscribers","subscription_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/subscription","commits_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/merges","archive_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/downloads","issues_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/labels{/name}","releases_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/deployments","created_at":"2018-08-11T13:34:15Z","updated_at":"2018-09-08T17:52:21Z","pushed_at":"2019-03-04T20:59:42Z","git_url":"git://github.com/JuliaWeb/LibCURLBuilder.git","ssh_url":"git@github.com:JuliaWeb/LibCURLBuilder.git","clone_url":"https://github.com/JuliaWeb/LibCURLBuilder.git","svn_url":"https://github.com/JuliaWeb/LibCURLBuilder","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12"},"html":{"href":"https://github.com/JuliaWeb/LibCURLBuilder/pull/12"},"issue":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues/12"},"comments":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaWeb/LibCURLBuilder/statuses/26e3bde1f310e26bb59ecbbb14a1e7841ecc7293"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"fchorney"}}