payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/performance/pulls/comments/308432055","pull_request_review_id":268033565,"id":308432055,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODQzMjA1NQ==","diff_hunk":"@@ -70,9 +71,7 @@ public IList<Counter> Parse(string mergeTraceFile, string processName)\n \n                 source.Kernel.ProcessEndGroup += evt =>\n                 {\n-                    // not using processname here because it's not tracked by the state machine when the process just ended\n-                    // but ImageFileName exists\n-                    if (pid.HasValue && evt.ProcessID == pid && evt.ImageFileName == imageFileName)\n+                    if (pid.HasValue && imageFile.Equals(evt.ImageFileName, StringComparison.OrdinalIgnoreCase) && pid == evt.ProcessID)","path":"src/tools/ScenarioMeasurement/Startup/ProcessTimeParser.cs","position":42,"original_position":42,"commit_id":"45fa08ae5561390971a463d5071c767ef32d7596","original_commit_id":"45fa08ae5561390971a463d5071c767ef32d7596","user":{"login":"DrewScoggins","id":9439069,"node_id":"MDQ6VXNlcjk0MzkwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9439069?v=4","gravatar_id":"","url":"https://api.github.com/users/DrewScoggins","html_url":"https://github.com/DrewScoggins","followers_url":"https://api.github.com/users/DrewScoggins/followers","following_url":"https://api.github.com/users/DrewScoggins/following{/other_user}","gists_url":"https://api.github.com/users/DrewScoggins/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewScoggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewScoggins/subscriptions","organizations_url":"https://api.github.com/users/DrewScoggins/orgs","repos_url":"https://api.github.com/users/DrewScoggins/repos","events_url":"https://api.github.com/users/DrewScoggins/events{/privacy}","received_events_url":"https://api.github.com/users/DrewScoggins/received_events","type":"User","site_admin":false},"body":"I think that number three is not quite correct. It does not have to be our test process that starts, as any process that got assigned the recycled pid would trigger this ProcessEngGroup code, and we would not even have to miss the start event for this process, because it would not have the same name as our target process and we would never run that code.","created_at":"2019-07-29T20:52:00Z","updated_at":"2019-07-29T20:52:00Z","html_url":"https://github.com/dotnet/performance/pull/704#discussion_r308432055","pull_request_url":"https://api.github.com/repos/dotnet/performance/pulls/704","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/performance/pulls/comments/308432055"},"html":{"href":"https://github.com/dotnet/performance/pull/704#discussion_r308432055"},"pull_request":{"href":"https://api.github.com/repos/dotnet/performance/pulls/704"}},"in_reply_to_id":307936835},"pull_request":{"url":"https://api.github.com/repos/dotnet/performance/pulls/704","id":301308370,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzA4Mzcw","html_url":"https://github.com/dotnet/performance/pull/704","diff_url":"https://github.com/dotnet/performance/pull/704.diff","patch_url":"https://github.com/dotnet/performance/pull/704.patch","issue_url":"https://api.github.com/repos/dotnet/performance/issues/704","number":704,"state":"open","locked":false,"title":"Add iteration set up to Startup Tool","user":{"login":"ooooolivia","id":51934529,"node_id":"MDQ6VXNlcjUxOTM0NTI5","avatar_url":"https://avatars0.githubusercontent.com/u/51934529?v=4","gravatar_id":"","url":"https://api.github.com/users/ooooolivia","html_url":"https://github.com/ooooolivia","followers_url":"https://api.github.com/users/ooooolivia/followers","following_url":"https://api.github.com/users/ooooolivia/following{/other_user}","gists_url":"https://api.github.com/users/ooooolivia/gists{/gist_id}","starred_url":"https://api.github.com/users/ooooolivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooooolivia/subscriptions","organizations_url":"https://api.github.com/users/ooooolivia/orgs","repos_url":"https://api.github.com/users/ooooolivia/repos","events_url":"https://api.github.com/users/ooooolivia/events{/privacy}","received_events_url":"https://api.github.com/users/ooooolivia/received_events","type":"User","site_admin":false},"body":"- Startup.cs: Added iteration set up option before each iteration \r\n- ProcessTimeParser.cs: \r\n1) Changed it to matching event's commandLine instead, which is more accurate when events associated with setup/cleanup share the same process name with those of the actual test (ex: dotnet.exe)\r\n2) Todo: This means we need to change the same thing for other metric types as well\r\n- Util\\ProcessHelper.cs: handle the case when the exit code is not 0 and give a ExitedWithError, instead of Success\r\n- Todo: \r\n1) add iteration clean up\r\n2) fix test log issue\r\n\r\n","created_at":"2019-07-25T20:58:47Z","updated_at":"2019-07-29T20:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bdb5c7eb4ac6de82fb2bbc2792fd3d7ec3f6c98","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DrewScoggins","id":9439069,"node_id":"MDQ6VXNlcjk0MzkwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9439069?v=4","gravatar_id":"","url":"https://api.github.com/users/DrewScoggins","html_url":"https://github.com/DrewScoggins","followers_url":"https://api.github.com/users/DrewScoggins/followers","following_url":"https://api.github.com/users/DrewScoggins/following{/other_user}","gists_url":"https://api.github.com/users/DrewScoggins/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewScoggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewScoggins/subscriptions","organizations_url":"https://api.github.com/users/DrewScoggins/orgs","repos_url":"https://api.github.com/users/DrewScoggins/repos","events_url":"https://api.github.com/users/DrewScoggins/events{/privacy}","received_events_url":"https://api.github.com/users/DrewScoggins/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/performance/pulls/704/commits","review_comments_url":"https://api.github.com/repos/dotnet/performance/pulls/704/comments","review_comment_url":"https://api.github.com/repos/dotnet/performance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/performance/issues/704/comments","statuses_url":"https://api.github.com/repos/dotnet/performance/statuses/45fa08ae5561390971a463d5071c767ef32d7596","head":{"label":"ooooolivia:master","ref":"master","sha":"45fa08ae5561390971a463d5071c767ef32d7596","user":{"login":"ooooolivia","id":51934529,"node_id":"MDQ6VXNlcjUxOTM0NTI5","avatar_url":"https://avatars0.githubusercontent.com/u/51934529?v=4","gravatar_id":"","url":"https://api.github.com/users/ooooolivia","html_url":"https://github.com/ooooolivia","followers_url":"https://api.github.com/users/ooooolivia/followers","following_url":"https://api.github.com/users/ooooolivia/following{/other_user}","gists_url":"https://api.github.com/users/ooooolivia/gists{/gist_id}","starred_url":"https://api.github.com/users/ooooolivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooooolivia/subscriptions","organizations_url":"https://api.github.com/users/ooooolivia/orgs","repos_url":"https://api.github.com/users/ooooolivia/repos","events_url":"https://api.github.com/users/ooooolivia/events{/privacy}","received_events_url":"https://api.github.com/users/ooooolivia/received_events","type":"User","site_admin":false},"repo":{"id":197480446,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc0ODA0NDY=","name":"performance","full_name":"ooooolivia/performance","private":false,"owner":{"login":"ooooolivia","id":51934529,"node_id":"MDQ6VXNlcjUxOTM0NTI5","avatar_url":"https://avatars0.githubusercontent.com/u/51934529?v=4","gravatar_id":"","url":"https://api.github.com/users/ooooolivia","html_url":"https://github.com/ooooolivia","followers_url":"https://api.github.com/users/ooooolivia/followers","following_url":"https://api.github.com/users/ooooolivia/following{/other_user}","gists_url":"https://api.github.com/users/ooooolivia/gists{/gist_id}","starred_url":"https://api.github.com/users/ooooolivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooooolivia/subscriptions","organizations_url":"https://api.github.com/users/ooooolivia/orgs","repos_url":"https://api.github.com/users/ooooolivia/repos","events_url":"https://api.github.com/users/ooooolivia/events{/privacy}","received_events_url":"https://api.github.com/users/ooooolivia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ooooolivia/performance","description":"This repo contains benchmarks used for testing the performance of all .NET Runtimes","fork":true,"url":"https://api.github.com/repos/ooooolivia/performance","forks_url":"https://api.github.com/repos/ooooolivia/performance/forks","keys_url":"https://api.github.com/repos/ooooolivia/performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooooolivia/performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooooolivia/performance/teams","hooks_url":"https://api.github.com/repos/ooooolivia/performance/hooks","issue_events_url":"https://api.github.com/repos/ooooolivia/performance/issues/events{/number}","events_url":"https://api.github.com/repos/ooooolivia/performance/events","assignees_url":"https://api.github.com/repos/ooooolivia/performance/assignees{/user}","branches_url":"https://api.github.com/repos/ooooolivia/performance/branches{/branch}","tags_url":"https://api.github.com/repos/ooooolivia/performance/tags","blobs_url":"https://api.github.com/repos/ooooolivia/performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooooolivia/performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooooolivia/performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooooolivia/performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooooolivia/performance/statuses/{sha}","languages_url":"https://api.github.com/repos/ooooolivia/performance/languages","stargazers_url":"https://api.github.com/repos/ooooolivia/performance/stargazers","contributors_url":"https://api.github.com/repos/ooooolivia/performance/contributors","subscribers_url":"https://api.github.com/repos/ooooolivia/performance/subscribers","subscription_url":"https://api.github.com/repos/ooooolivia/performance/subscription","commits_url":"https://api.github.com/repos/ooooolivia/performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooooolivia/performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooooolivia/performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooooolivia/performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooooolivia/performance/contents/{+path}","compare_url":"https://api.github.com/repos/ooooolivia/performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooooolivia/performance/merges","archive_url":"https://api.github.com/repos/ooooolivia/performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooooolivia/performance/downloads","issues_url":"https://api.github.com/repos/ooooolivia/performance/issues{/number}","pulls_url":"https://api.github.com/repos/ooooolivia/performance/pulls{/number}","milestones_url":"https://api.github.com/repos/ooooolivia/performance/milestones{/number}","notifications_url":"https://api.github.com/repos/ooooolivia/performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooooolivia/performance/labels{/name}","releases_url":"https://api.github.com/repos/ooooolivia/performance/releases{/id}","deployments_url":"https://api.github.com/repos/ooooolivia/performance/deployments","created_at":"2019-07-18T00:13:09Z","updated_at":"2019-07-26T21:13:16Z","pushed_at":"2019-07-26T21:13:13Z","git_url":"git://github.com/ooooolivia/performance.git","ssh_url":"git@github.com:ooooolivia/performance.git","clone_url":"https://github.com/ooooolivia/performance.git","svn_url":"https://github.com/ooooolivia/performance","homepage":"","size":3084,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6af21140e67ccaafde948a0c402cd9d3475cea8b","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":124948838,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NDg4Mzg=","name":"performance","full_name":"dotnet/performance","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/performance","description":"This repo contains benchmarks used for testing the performance of all .NET Runtimes","fork":false,"url":"https://api.github.com/repos/dotnet/performance","forks_url":"https://api.github.com/repos/dotnet/performance/forks","keys_url":"https://api.github.com/repos/dotnet/performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/performance/teams","hooks_url":"https://api.github.com/repos/dotnet/performance/hooks","issue_events_url":"https://api.github.com/repos/dotnet/performance/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/performance/events","assignees_url":"https://api.github.com/repos/dotnet/performance/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/performance/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/performance/tags","blobs_url":"https://api.github.com/repos/dotnet/performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/performance/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/performance/languages","stargazers_url":"https://api.github.com/repos/dotnet/performance/stargazers","contributors_url":"https://api.github.com/repos/dotnet/performance/contributors","subscribers_url":"https://api.github.com/repos/dotnet/performance/subscribers","subscription_url":"https://api.github.com/repos/dotnet/performance/subscription","commits_url":"https://api.github.com/repos/dotnet/performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/performance/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/performance/merges","archive_url":"https://api.github.com/repos/dotnet/performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/performance/downloads","issues_url":"https://api.github.com/repos/dotnet/performance/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/performance/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/performance/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/performance/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/performance/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/performance/deployments","created_at":"2018-03-12T20:41:10Z","updated_at":"2019-07-29T19:59:05Z","pushed_at":"2019-07-29T19:59:01Z","git_url":"git://github.com/dotnet/performance.git","ssh_url":"git@github.com:dotnet/performance.git","clone_url":"https://github.com/dotnet/performance.git","svn_url":"https://github.com/dotnet/performance","homepage":"","size":3085,"stargazers_count":203,"watchers_count":203,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":57,"open_issues":37,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/performance/pulls/704"},"html":{"href":"https://github.com/dotnet/performance/pull/704"},"issue":{"href":"https://api.github.com/repos/dotnet/performance/issues/704"},"comments":{"href":"https://api.github.com/repos/dotnet/performance/issues/704/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/performance/pulls/704/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/performance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/performance/pulls/704/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/performance/statuses/45fa08ae5561390971a463d5071c767ef32d7596"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"DrewScoggins"}}