payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/helm/charts/issues/15658","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/15658/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/15658/comments","events_url":"https://api.github.com/repos/helm/charts/issues/15658/events","html_url":"https://github.com/helm/charts/issues/15658","id":469386536,"node_id":"MDU6SXNzdWU0NjkzODY1MzY=","number":15658,"title":"[stable/redis] Exporter REDIS_ADDR invalid separator in cluster mode","user":{"login":"a7i","id":9448877,"node_id":"MDQ6VXNlcjk0NDg4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/9448877?v=4","gravatar_id":"","url":"https://api.github.com/users/a7i","html_url":"https://github.com/a7i","followers_url":"https://api.github.com/users/a7i/followers","following_url":"https://api.github.com/users/a7i/following{/other_user}","gists_url":"https://api.github.com/users/a7i/gists{/gist_id}","starred_url":"https://api.github.com/users/a7i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a7i/subscriptions","organizations_url":"https://api.github.com/users/a7i/orgs","repos_url":"https://api.github.com/users/a7i/repos","events_url":"https://api.github.com/users/a7i/events{/privacy}","received_events_url":"https://api.github.com/users/a7i/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-07-17T18:48:57Z","updated_at":"2019-07-24T16:46:18Z","closed_at":"2019-07-24T16:46:18Z","author_association":"NONE","body":"<!-- Thanks for filing an issue! Before hitting the button, please answer these questions. It's helpful to search the existing GitHub issues first. It's likely that another user has already reported the issue you're facing, or it's a known issue that we're already aware of \r\n\r\nFill in as much of the template below as you can.  If you leave out information, we can't help you as well.\r\n\r\nBe ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue.  If we're wrong, PLEASE feel free to reopen it and explain why.\r\n-->\r\n\r\n**Describe the bug**\r\nIssues with metrics exporter when deploying a Redis chart (v8.1.2) with cluster and metrics enabled. Exporter container logs errors but it does not crash. As a result, metrics are not published.\r\n\r\n**Version of Helm and Kubernetes**:\r\nHelm v2.12.2\r\nKubernetes v1.12.6\r\n\r\n**Which chart**:\r\nstable/redis\r\n\r\n**What happened**:\r\nIn chart upgrade to 8.0.18, metrics image tag was changed to`v1.0.3`. if you have cluster enabled, it attempts to put in a comma-separated value for the REDIS_ADDR val which is not an acceptable argument.\r\n\r\n```\r\n        env:\r\n        - name: REDIS_ADDR\r\n          value: \"redis-app-master:6379,redis-app-slave:6379\"\r\n```\r\n\r\nLogs from redis_exporter\r\n```\r\ntime=\"2019-07-17T18:29:25Z\" level=debug msg=\"Trying DialURL(): redis://redis-app-master:6379,redis-app-slave:6379\"\r\ntime=\"2019-07-17T18:29:25Z\" level=debug msg=\"DialURL() failed, err: dial tcp: lookup redis-app-master:6379,redis-app-slave:6379: no such host\"\r\ntime=\"2019-07-17T18:29:25Z\" level=debug msg=\"Trying: Dial(): tcp redis-app-master:6379,redis-app-slave:6379\"\r\ntime=\"2019-07-17T18:29:25Z\" level=error msg=\"Couldn't connect to redis instance\"\r\ntime=\"2019-07-17T18:29:25Z\" level=debug msg=\"connectToRedis( redis-app-master:6379,redis-app-slave:6379 ) err: dial tcp: address redis-app-master:6379,redis-app-slave:6379: too many colons in address\"\r\n```\r\n\r\n**What you expected to happen**:\r\nIt should set up the addresses properly with the supplied separator.\r\n\r\n**How to reproduce it** (as minimally and precisely as possible):\r\n\r\n- Use chart version 8.1.2\r\n- Set cluster to enabled\r\n- Set metrics to enabled, set debug flag as show below\r\n```\r\n  metrics:\r\n    enabled: true\r\n    extraArgs: {\r\n      \"debug\": \"true\"\r\n    }\r\n```\r\n- Deploy chart\r\n- Observe metrics logs and error mentioned above\r\n\r\n**Anything else we need to know**:\r\n\r\n"}}
other: {"actor":{"display_login":"k8s-ci-robot"}}