payload: {"action":"created","issue":{"url":"https://api.github.com/repos/cri-o/cri-o/issues/2746","repository_url":"https://api.github.com/repos/cri-o/cri-o","labels_url":"https://api.github.com/repos/cri-o/cri-o/issues/2746/labels{/name}","comments_url":"https://api.github.com/repos/cri-o/cri-o/issues/2746/comments","events_url":"https://api.github.com/repos/cri-o/cri-o/issues/2746/events","html_url":"https://github.com/cri-o/cri-o/pull/2746","id":484229422,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwMTU0Mjkz","number":2746,"title":"wipe only crio","user":{"login":"haircommander","id":9082919,"node_id":"MDQ6VXNlcjkwODI5MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9082919?v=4","gravatar_id":"","url":"https://api.github.com/users/haircommander","html_url":"https://github.com/haircommander","followers_url":"https://api.github.com/users/haircommander/followers","following_url":"https://api.github.com/users/haircommander/following{/other_user}","gists_url":"https://api.github.com/users/haircommander/gists{/gist_id}","starred_url":"https://api.github.com/users/haircommander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haircommander/subscriptions","organizations_url":"https://api.github.com/users/haircommander/orgs","repos_url":"https://api.github.com/users/haircommander/repos","events_url":"https://api.github.com/users/haircommander/events{/privacy}","received_events_url":"https://api.github.com/users/haircommander/received_events","type":"User","site_admin":false},"labels":[{"id":1032163114,"node_id":"MDU6TGFiZWwxMDMyMTYzMTE0","url":"https://api.github.com/repos/cri-o/cri-o/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1315177517,"node_id":"MDU6TGFiZWwxMzE1MTc3NTE3","url":"https://api.github.com/repos/cri-o/cri-o/labels/dco-signoff:%20yes","name":"dco-signoff: yes","color":"bfe5bf","default":false},{"id":1032162481,"node_id":"MDU6TGFiZWwxMDMyMTYyNDgx","url":"https://api.github.com/repos/cri-o/cri-o/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1369476242,"node_id":"MDU6TGFiZWwxMzY5NDc2MjQy","url":"https://api.github.com/repos/cri-o/cri-o/labels/needs-backport","name":"needs-backport","color":"86e8d4","default":false},{"id":1403117356,"node_id":"MDU6TGFiZWwxNDAzMTE3MzU2","url":"https://api.github.com/repos/cri-o/cri-o/labels/release-1.15","name":"release-1.15","color":"6809e5","default":false},{"id":1537215465,"node_id":"MDU6TGFiZWwxNTM3MjE1NDY1","url":"https://api.github.com/repos/cri-o/cri-o/labels/release-1.16","name":"release-1.16","color":"95f9d8","default":false},{"id":679128061,"node_id":"MDU6TGFiZWw2NzkxMjgwNjE=","url":"https://api.github.com/repos/cri-o/cri-o/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"mrunalp","id":53798,"node_id":"MDQ6VXNlcjUzNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/53798?v=4","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrunalp","id":53798,"node_id":"MDQ6VXNlcjUzNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/53798?v=4","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2019-08-22T21:38:12Z","updated_at":"2019-09-28T06:52:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cri-o/cri-o/pulls/2746","html_url":"https://github.com/cri-o/cri-o/pull/2746","diff_url":"https://github.com/cri-o/cri-o/pull/2746.diff","patch_url":"https://github.com/cri-o/cri-o/pull/2746.patch"},"body":"As it stands, crio-wipe is dangerous. If a user wants to preserve their podman containers, or buildah images on a node, they won't be able to. Downloading a new CRI-O, or installing for the first time, will delete them.\r\n\r\nFix this by being more deft about container and image deletion. This PR includes:\r\n\r\n- a new binary: crio-wiper, which is downloaded into the contrib/crio-wipe/crio-wiper folder. It is responsible for reading from storage directly, filtering out crio containers and images, unmounting and deleting them.\r\n- Because we want crio-wiper to be looking at the same storage location as crio, I have factored out the argument and conf file handling to a separate library: clicommon, which both crio and crio-wiper can read from.\r\n- Added a make target for downloading crio-wiper\r\n- added a test suite. To do so, the existing integration test suite had to be adapted a little (it didn't use set -u). The test suite is currently pretty sparse, but it demonstrates the usage of crio-wiper.\r\n\r\n~This PR is technically a WIP, I need to make sure the spec file downloads it, and need to test it in the wild, as well as make sure I am sure about how images should work. I'm putting it out here for review to make sure my direction is good.~ \r\n\r\nalso fixes: https://github.com/cri-o/cri-o/issues/2725"},"comment":{"url":"https://api.github.com/repos/cri-o/cri-o/issues/comments/536160014","html_url":"https://github.com/cri-o/cri-o/pull/2746#issuecomment-536160014","issue_url":"https://api.github.com/repos/cri-o/cri-o/issues/2746","id":536160014,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNjE2MDAxNA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-09-28T06:52:23Z","updated_at":"2019-09-28T06:52:23Z","author_association":"NONE","body":"@haircommander: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/e2e_features_fedora | b1113b030b394c7d9b70727a0df0224e8e335c3a | [link](https://openshift-gce-devel.appspot.com/build/origin-federated-results/pr-logs/pull/cri-o_cri-o/2746/test_pull_request_crio_e2e_features_fedora/5430/) | `/test e2e_features_fedora`\nci/openshift-jenkins/e2e_fedora | b1113b030b394c7d9b70727a0df0224e8e335c3a | [link](https://openshift-gce-devel.appspot.com/build/origin-federated-results/pr-logs/pull/cri-o_cri-o/2746/test_pull_request_crio_e2e_fedora/7471/) | `/test e2e_fedora`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/cri-o_cri-o/2746). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/haircommander). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/cri-o/cri-o/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
other: {"actor":{"display_login":"openshift-ci-robot"}}