payload: {"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/enhancements/issues/793","repository_url":"https://api.github.com/repos/kubernetes/enhancements","labels_url":"https://api.github.com/repos/kubernetes/enhancements/issues/793/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/enhancements/issues/793/comments","events_url":"https://api.github.com/repos/kubernetes/enhancements/issues/793/events","html_url":"https://github.com/kubernetes/enhancements/issues/793","id":405026318,"node_id":"MDU6SXNzdWU0MDUwMjYzMTg=","number":793,"title":"Promote Node OS/Arch labels to GA","user":{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"labels":[{"id":861943380,"node_id":"MDU6TGFiZWw4NjE5NDMzODA=","url":"https://api.github.com/repos/kubernetes/enhancements/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":413888892,"node_id":"MDU6TGFiZWw0MTM4ODg4OTI=","url":"https://api.github.com/repos/kubernetes/enhancements/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":500133888,"node_id":"MDU6TGFiZWw1MDAxMzM4ODg=","url":"https://api.github.com/repos/kubernetes/enhancements/labels/stage/stable","name":"stage/stable","color":"0e8a16","default":false},{"id":820252948,"node_id":"MDU6TGFiZWw4MjAyNTI5NDg=","url":"https://api.github.com/repos/kubernetes/enhancements/labels/tracked/yes","name":"tracked/yes","color":"108737","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/enhancements/milestones/13","html_url":"https://github.com/kubernetes/enhancements/milestone/13","labels_url":"https://api.github.com/repos/kubernetes/enhancements/milestones/13/labels","id":3464825,"node_id":"MDk6TWlsZXN0b25lMzQ2NDgyNQ==","number":13,"title":"v1.14","description":"","creator":{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":7,"state":"open","created_at":"2018-07-01T10:46:20Z","updated_at":"2019-02-23T00:27:13Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2019-01-31T00:25:05Z","updated_at":"2019-02-23T01:48:35Z","closed_at":null,"author_association":"MEMBER","body":"# Enhancement Description\r\n- One-line enhancement description (can be used as a release note): \r\n```\r\nkubelet: OS and Arch information is now recorded in `kubernetes.io/os` and `kubernetes.io/arch` labels on Node objects. The previous labels (`beta.kubernetes.io/os` and `beta.kubernetes.io/arch`) are still recorded, but are deprecated and targeted for removal in 1.18.\r\n```\r\n- PRs:\r\n  - [ ] https://github.com/kubernetes/kubernetes/pull/73333\r\n- Primary contact (assignee): @yujuhong \r\n- Responsible SIGs: Node\r\n- Design proposal link: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190130-node-os-arch-labels.md\r\n- Link to e2e and/or unit tests:\r\n- Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @dchen1107 @liggitt \r\n- Approver (likely from SIG/area to which enhancement belongs): @dchen1107 @smarterclayton \r\n- Enhancement target (which target equals to which milestone):\r\n  - Beta release target: 1.3\r\n  - Stable release target: 1.14\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/enhancements/issues/comments/466604279","html_url":"https://github.com/kubernetes/enhancements/issues/793#issuecomment-466604279","issue_url":"https://api.github.com/repos/kubernetes/enhancements/issues/793","id":466604279,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NjYwNDI3OQ==","user":{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"created_at":"2019-02-23T01:48:35Z","updated_at":"2019-02-23T01:48:35Z","author_association":"MEMBER","body":"I've added unit tests in both the node controller (pending PR #74442) and the kubelet (#73333). \r\nI am on the fence of whether an e2e test is needed. I can add one to check whether both beta and GA labels are applied to all nodes, but that'd only check if label will be applied for 1.13 and before kubelets.\r\nOur existing test suites do not test the scenario of upgrade/downgrade + changing OS/arch for nodes, so those cases will not be tested. \r\n\r\n@liggitt @derekwaynecarr @thockin, as reviewers of the KEP, do you think the individual component (unit) tests are sufficient?"}}
other: {"actor":{"display_login":"yujuhong"}}