payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments/279249041","pull_request_review_id":231530398,"id":279249041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTI0OTA0MQ==","diff_hunk":"@@ -9,136 +9,108 @@ using namespace ONNX_NAMESPACE;\n using namespace ::onnxruntime::common;\n namespace onnxruntime {\n \n-Status ConvAddFusion::ApplyImpl(onnxruntime::Graph& graph, bool& modified, int graph_level) const {\n-  std::vector<onnxruntime::NodeIndex> removed_nodes;\n-  for (auto& node : graph.Nodes()) {\n-    ORT_RETURN_IF_ERROR(Recurse(node, modified, graph_level));\n-\n-    if (!graph_utils::IsSupportedOptypeVersionAndDomain(node, \"Conv\", 1) ||\n-        !graph_utils::IsSupportedProvider(node, GetCompatibleExecutionProviders()) ||\n-        node.GetOutputEdgesCount() != 1) {\n-      continue;\n-    }\n+Status ConvAddFusion::Apply(Graph& graph, Node& node, bool& modified, bool& /*removed*/) {\n+  auto& conv_node = node;\n+  const auto& add_node = *conv_node.OutputNodesBegin();\n+  const auto& conv_inputs = conv_node.InputDefs();","path":"onnxruntime/core/optimizer/conv_add_fusion.cc","position":17,"original_position":17,"commit_id":"94ed2228aab35cd62fa023eb942767c8f7ec3ad9","original_commit_id":"94ed2228aab35cd62fa023eb942767c8f7ec3ad9","user":{"login":"skottmckay","id":979079,"node_id":"MDQ6VXNlcjk3OTA3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/979079?v=4","gravatar_id":"","url":"https://api.github.com/users/skottmckay","html_url":"https://github.com/skottmckay","followers_url":"https://api.github.com/users/skottmckay/followers","following_url":"https://api.github.com/users/skottmckay/following{/other_user}","gists_url":"https://api.github.com/users/skottmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/skottmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skottmckay/subscriptions","organizations_url":"https://api.github.com/users/skottmckay/orgs","repos_url":"https://api.github.com/users/skottmckay/repos","events_url":"https://api.github.com/users/skottmckay/events{/privacy}","received_events_url":"https://api.github.com/users/skottmckay/received_events","type":"User","site_admin":false},"body":"If the Conv node produces graph output, would it have an empty output nodes list (so dereferencing the iterator would be an error)?","created_at":"2019-04-29T06:44:18Z","updated_at":"2019-04-29T06:44:18Z","html_url":"https://github.com/Microsoft/onnxruntime/pull/863#discussion_r279249041","pull_request_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments/279249041"},"html":{"href":"https://github.com/Microsoft/onnxruntime/pull/863#discussion_r279249041"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863","id":272063838,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMDYzODM4","html_url":"https://github.com/Microsoft/onnxruntime/pull/863","diff_url":"https://github.com/Microsoft/onnxruntime/pull/863.diff","patch_url":"https://github.com/Microsoft/onnxruntime/pull/863.patch","issue_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/863","number":863,"state":"open","locked":false,"title":"Conv(Add|Mul|BN)Fusion as rewrite rules","user":{"login":"kkaranasos","id":7536337,"node_id":"MDQ6VXNlcjc1MzYzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/7536337?v=4","gravatar_id":"","url":"https://api.github.com/users/kkaranasos","html_url":"https://github.com/kkaranasos","followers_url":"https://api.github.com/users/kkaranasos/followers","following_url":"https://api.github.com/users/kkaranasos/following{/other_user}","gists_url":"https://api.github.com/users/kkaranasos/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaranasos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaranasos/subscriptions","organizations_url":"https://api.github.com/users/kkaranasos/orgs","repos_url":"https://api.github.com/users/kkaranasos/repos","events_url":"https://api.github.com/users/kkaranasos/events{/privacy}","received_events_url":"https://api.github.com/users/kkaranasos/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-19T18:35:25Z","updated_at":"2019-04-29T06:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e1fbc5d414792dc47d2bc6d5db450c7041b418a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863/commits","review_comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863/comments","review_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/863/comments","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/94ed2228aab35cd62fa023eb942767c8f7ec3ad9","head":{"label":"Microsoft:kkaranasos/transformers-to-rules-2","ref":"kkaranasos/transformers-to-rules-2","sha":"94ed2228aab35cd62fa023eb942767c8f7ec3ad9","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":156939672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5Mzk2NzI=","name":"onnxruntime","full_name":"Microsoft/onnxruntime","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/onnxruntime","description":"ONNX Runtime: cross-platform, high performance scoring engine for ML models","fork":false,"url":"https://api.github.com/repos/Microsoft/onnxruntime","forks_url":"https://api.github.com/repos/Microsoft/onnxruntime/forks","keys_url":"https://api.github.com/repos/Microsoft/onnxruntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/onnxruntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/onnxruntime/teams","hooks_url":"https://api.github.com/repos/Microsoft/onnxruntime/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/onnxruntime/events","assignees_url":"https://api.github.com/repos/Microsoft/onnxruntime/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/onnxruntime/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/tags","blobs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/onnxruntime/languages","stargazers_url":"https://api.github.com/repos/Microsoft/onnxruntime/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/onnxruntime/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscription","commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/onnxruntime/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/onnxruntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/onnxruntime/merges","archive_url":"https://api.github.com/repos/Microsoft/onnxruntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/onnxruntime/downloads","issues_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/onnxruntime/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/onnxruntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/onnxruntime/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/onnxruntime/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/onnxruntime/deployments","created_at":"2018-11-10T02:22:53Z","updated_at":"2019-04-29T05:44:57Z","pushed_at":"2019-04-29T05:44:50Z","git_url":"git://github.com/Microsoft/onnxruntime.git","ssh_url":"git@github.com:Microsoft/onnxruntime.git","clone_url":"https://github.com/Microsoft/onnxruntime.git","svn_url":"https://github.com/Microsoft/onnxruntime","homepage":"","size":19951,"stargazers_count":695,"watchers_count":695,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":132,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":132,"open_issues":68,"watchers":695,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5e3a266709f9ac4873b2a47370b058ca6e917f96","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":156939672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5Mzk2NzI=","name":"onnxruntime","full_name":"Microsoft/onnxruntime","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/onnxruntime","description":"ONNX Runtime: cross-platform, high performance scoring engine for ML models","fork":false,"url":"https://api.github.com/repos/Microsoft/onnxruntime","forks_url":"https://api.github.com/repos/Microsoft/onnxruntime/forks","keys_url":"https://api.github.com/repos/Microsoft/onnxruntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/onnxruntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/onnxruntime/teams","hooks_url":"https://api.github.com/repos/Microsoft/onnxruntime/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/onnxruntime/events","assignees_url":"https://api.github.com/repos/Microsoft/onnxruntime/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/onnxruntime/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/tags","blobs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/onnxruntime/languages","stargazers_url":"https://api.github.com/repos/Microsoft/onnxruntime/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/onnxruntime/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscription","commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/onnxruntime/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/onnxruntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/onnxruntime/merges","archive_url":"https://api.github.com/repos/Microsoft/onnxruntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/onnxruntime/downloads","issues_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/onnxruntime/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/onnxruntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/onnxruntime/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/onnxruntime/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/onnxruntime/deployments","created_at":"2018-11-10T02:22:53Z","updated_at":"2019-04-29T05:44:57Z","pushed_at":"2019-04-29T05:44:50Z","git_url":"git://github.com/Microsoft/onnxruntime.git","ssh_url":"git@github.com:Microsoft/onnxruntime.git","clone_url":"https://github.com/Microsoft/onnxruntime.git","svn_url":"https://github.com/Microsoft/onnxruntime","homepage":"","size":19951,"stargazers_count":695,"watchers_count":695,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":132,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":132,"open_issues":68,"watchers":695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863"},"html":{"href":"https://github.com/Microsoft/onnxruntime/pull/863"},"issue":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/issues/863"},"comments":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/issues/863/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/863/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/94ed2228aab35cd62fa023eb942767c8f7ec3ad9"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"skottmckay"}}