payload: {"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/23239","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/23239/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/23239/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/23239/events","html_url":"https://github.com/magento/magento2/pull/23239","id":455718692,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3OTA3ODcw","number":23239,"title":"[Backport] Fix retrieving remote address when Magento behind reverse proxy","user":{"login":"ihor-sviziev","id":1873745,"node_id":"MDQ6VXNlcjE4NzM3NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"labels":[{"id":1062590646,"node_id":"MDU6TGFiZWwxMDYyNTkwNjQ2","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Framework/HTTP","name":"Component: Framework/HTTP","color":"7fb703","default":false},{"id":688784074,"node_id":"MDU6TGFiZWw2ODg3ODQwNzQ=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20on%20hold","name":"Progress: on hold","color":"d93f0b","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-06-13T12:41:50Z","updated_at":"2019-06-14T05:46:57Z","closed_at":"2019-06-14T05:46:56Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/23239","html_url":"https://github.com/magento/magento2/pull/23239","diff_url":"https://github.com/magento/magento2/pull/23239.diff","patch_url":"https://github.com/magento/magento2/pull/23239.patch"},"body":"### Original Pull Request\r\nhttps://github.com/magento/magento2/pull/23219\r\n\r\n### Description (*)\r\nAdd `X-Forwarded-For` header to list of alternate headers for getting remote address.\r\nThis is default header that common used by well known reverse proxies like nginx, apache, varnish and many services.\r\n\r\nMore info: https://dev98.de/2017/01/02/how-to-add-alternative-http-headers-to-magento-2/\r\n\r\n### Fixed Issues (if relevant)\r\nN/A\r\n\r\n### Manual testing scenarios (*)\r\n1. Setup Magento with reverse proxy, nginx for instance\r\n2. Try to get client IP address using following method: `\\Magento\\Framework\\HTTP\\PhpEnvironment\\RemoteAddress::getRemoteAddress`\r\n\r\n**Actual result:**\r\nRetrieved address - IP address of reverse proxy\r\n\r\n**Expected result:**\r\nRetrieved address - client's IP address\r\n\r\n### Questions or comments\r\n<!---\r\n\tIf relevant, here you can ask questions or provide comments on your pull request for the reviewer\r\n\tFor example if you need assistance with writing tests or would like some feedback on one of your development ideas\r\n-->\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/501976571","html_url":"https://github.com/magento/magento2/pull/23239#issuecomment-501976571","issue_url":"https://api.github.com/repos/magento/magento2/issues/23239","id":501976571,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMTk3NjU3MQ==","user":{"login":"m2-assistant[bot]","id":48600411,"node_id":"MDM6Qm90NDg2MDA0MTE=","avatar_url":"https://avatars0.githubusercontent.com/in/27048?v=4","gravatar_id":"","url":"https://api.github.com/users/m2-assistant%5Bbot%5D","html_url":"https://github.com/apps/m2-assistant","followers_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/followers","following_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/repos","events_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/m2-assistant%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-06-14T05:46:57Z","updated_at":"2019-06-14T05:46:57Z","author_association":"NONE","body":"Hi @ihor-sviziev, thank you for your contribution! </br>Please, complete [Contribution Survey](https://opensource.magento.com/survey/contribution/magento+magento2+23239), it will take less than a minute. </br>Your feedback will help us to improve contribution process."}}
other: {"actor":{"display_login":"m2-assistant"}}