payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/sorainsm/library-of-lighting-models/issues/8","repository_url":"https://api.github.com/repos/sorainsm/library-of-lighting-models","labels_url":"https://api.github.com/repos/sorainsm/library-of-lighting-models/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/sorainsm/library-of-lighting-models/issues/8/comments","events_url":"https://api.github.com/repos/sorainsm/library-of-lighting-models/issues/8/events","html_url":"https://github.com/sorainsm/library-of-lighting-models/issues/8","id":504619953,"node_id":"MDU6SXNzdWU1MDQ2MTk5NTM=","number":8,"title":"CA - Non functional requirements","user":{"login":"peter-michalski","id":55030803,"node_id":"MDQ6VXNlcjU1MDMwODAz","avatar_url":"https://avatars0.githubusercontent.com/u/55030803?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-michalski","html_url":"https://github.com/peter-michalski","followers_url":"https://api.github.com/users/peter-michalski/followers","following_url":"https://api.github.com/users/peter-michalski/following{/other_user}","gists_url":"https://api.github.com/users/peter-michalski/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-michalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-michalski/subscriptions","organizations_url":"https://api.github.com/users/peter-michalski/orgs","repos_url":"https://api.github.com/users/peter-michalski/repos","events_url":"https://api.github.com/users/peter-michalski/events{/privacy}","received_events_url":"https://api.github.com/users/peter-michalski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"sorainsm","id":11723492,"node_id":"MDQ6VXNlcjExNzIzNDky","avatar_url":"https://avatars0.githubusercontent.com/u/11723492?v=4","gravatar_id":"","url":"https://api.github.com/users/sorainsm","html_url":"https://github.com/sorainsm","followers_url":"https://api.github.com/users/sorainsm/followers","following_url":"https://api.github.com/users/sorainsm/following{/other_user}","gists_url":"https://api.github.com/users/sorainsm/gists{/gist_id}","starred_url":"https://api.github.com/users/sorainsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorainsm/subscriptions","organizations_url":"https://api.github.com/users/sorainsm/orgs","repos_url":"https://api.github.com/users/sorainsm/repos","events_url":"https://api.github.com/users/sorainsm/events{/privacy}","received_events_url":"https://api.github.com/users/sorainsm/received_events","type":"User","site_admin":false},"assignees":[{"login":"sorainsm","id":11723492,"node_id":"MDQ6VXNlcjExNzIzNDky","avatar_url":"https://avatars0.githubusercontent.com/u/11723492?v=4","gravatar_id":"","url":"https://api.github.com/users/sorainsm","html_url":"https://github.com/sorainsm","followers_url":"https://api.github.com/users/sorainsm/followers","following_url":"https://api.github.com/users/sorainsm/following{/other_user}","gists_url":"https://api.github.com/users/sorainsm/gists{/gist_id}","starred_url":"https://api.github.com/users/sorainsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorainsm/subscriptions","organizations_url":"https://api.github.com/users/sorainsm/orgs","repos_url":"https://api.github.com/users/sorainsm/repos","events_url":"https://api.github.com/users/sorainsm/events{/privacy}","received_events_url":"https://api.github.com/users/sorainsm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2019-10-09T12:29:11Z","updated_at":"2019-11-05T04:33:00Z","closed_at":"2019-11-05T04:32:59Z","author_association":"COLLABORATOR","body":"Just did a first quick skim through your CA and it looks very good. \r\n\r\nOne issue that I am seeing is that the NFRs look to me like functional requirements (even though the functions are not directly related to the main problem domain - they are design level functions to deal with NFRs which are not directly specified). \r\n\r\nA common definition of NFR is \"specifies criteria that can be used to judge the operation of a system, rather than specific behaviors\" (found on Wikipedia, but still correct).\r\n\r\nThe NFR that you have listed are things the program does i.e. behaviours. I am wondering if the CA needs to specifically list the NFR that those behaviours are trying to address in order to make it easier for the programmer or reader of the CA to understand. For example, should R13 specify that it is for robustness? \r\n\r\nAdditionally, once the NFR of robustness is clearly established, is the behaviour that you have written a design decision instead of an abstraction?\r\n\r\nI would like @smiths imput on this. I may misunderstand the NFR at this level and need to change my report in the future, now I am unsure.\r\n\r\n"}}
other: {"actor":{"display_login":"sorainsm"}}