payload: {"action":"created","issue":{"url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/1148","repository_url":"https://api.github.com/repos/AdguardTeam/CoreLibs","labels_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/1148/labels{/name}","comments_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/1148/comments","events_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/1148/events","html_url":"https://github.com/AdguardTeam/CoreLibs/issues/1148","id":501411882,"node_id":"MDU6SXNzdWU1MDE0MTE4ODI=","number":1148,"title":"Rules with $popup modifier cause that blocking rules don't work","user":{"login":"AdamWr","id":29142494,"node_id":"MDQ6VXNlcjI5MTQyNDk0","avatar_url":"https://avatars2.githubusercontent.com/u/29142494?v=4","gravatar_id":"","url":"https://api.github.com/users/AdamWr","html_url":"https://github.com/AdamWr","followers_url":"https://api.github.com/users/AdamWr/followers","following_url":"https://api.github.com/users/AdamWr/following{/other_user}","gists_url":"https://api.github.com/users/AdamWr/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWr/subscriptions","organizations_url":"https://api.github.com/users/AdamWr/orgs","repos_url":"https://api.github.com/users/AdamWr/repos","events_url":"https://api.github.com/users/AdamWr/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWr/received_events","type":"User","site_admin":false},"labels":[{"id":781211244,"node_id":"MDU6TGFiZWw3ODEyMTEyNDQ=","url":"https://api.github.com/repos/AdguardTeam/CoreLibs/labels/P3:%20Medium","name":"P3: Medium","color":"fbca04","default":false},{"id":487540292,"node_id":"MDU6TGFiZWw0ODc1NDAyOTI=","url":"https://api.github.com/repos/AdguardTeam/CoreLibs/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"sxgunchenko","id":26045362,"node_id":"MDQ6VXNlcjI2MDQ1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/26045362?v=4","gravatar_id":"","url":"https://api.github.com/users/sxgunchenko","html_url":"https://github.com/sxgunchenko","followers_url":"https://api.github.com/users/sxgunchenko/followers","following_url":"https://api.github.com/users/sxgunchenko/following{/other_user}","gists_url":"https://api.github.com/users/sxgunchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sxgunchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxgunchenko/subscriptions","organizations_url":"https://api.github.com/users/sxgunchenko/orgs","repos_url":"https://api.github.com/users/sxgunchenko/repos","events_url":"https://api.github.com/users/sxgunchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sxgunchenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"sxgunchenko","id":26045362,"node_id":"MDQ6VXNlcjI2MDQ1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/26045362?v=4","gravatar_id":"","url":"https://api.github.com/users/sxgunchenko","html_url":"https://github.com/sxgunchenko","followers_url":"https://api.github.com/users/sxgunchenko/followers","following_url":"https://api.github.com/users/sxgunchenko/following{/other_user}","gists_url":"https://api.github.com/users/sxgunchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sxgunchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxgunchenko/subscriptions","organizations_url":"https://api.github.com/users/sxgunchenko/orgs","repos_url":"https://api.github.com/users/sxgunchenko/repos","events_url":"https://api.github.com/users/sxgunchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sxgunchenko/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AdguardTeam/CoreLibs/milestones/12","html_url":"https://github.com/AdguardTeam/CoreLibs/milestone/12","labels_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/milestones/12/labels","id":4358774,"node_id":"MDk6TWlsZXN0b25lNDM1ODc3NA==","number":12,"title":"v1.5","description":"Filtering engine improvements","creator":{"login":"ameshkov","id":5947035,"node_id":"MDQ6VXNlcjU5NDcwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5947035?v=4","gravatar_id":"","url":"https://api.github.com/users/ameshkov","html_url":"https://github.com/ameshkov","followers_url":"https://api.github.com/users/ameshkov/followers","following_url":"https://api.github.com/users/ameshkov/following{/other_user}","gists_url":"https://api.github.com/users/ameshkov/gists{/gist_id}","starred_url":"https://api.github.com/users/ameshkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameshkov/subscriptions","organizations_url":"https://api.github.com/users/ameshkov/orgs","repos_url":"https://api.github.com/users/ameshkov/repos","events_url":"https://api.github.com/users/ameshkov/events{/privacy}","received_events_url":"https://api.github.com/users/ameshkov/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":25,"state":"open","created_at":"2019-05-29T13:53:03Z","updated_at":"2019-10-02T14:14:23Z","due_on":"2019-07-29T07:00:00Z","closed_at":null},"comments":2,"created_at":"2019-10-02T10:42:17Z","updated_at":"2019-10-02T15:01:24Z","closed_at":null,"author_association":"NONE","body":"### Steps to reproduce\r\n<!--- Provide a link to a live example or a clear set of steps to reproduce the issue -->\r\n1. Go here - http://sendsurl.com/PIT8M\r\n2. Ad marked on screenshot below should be blocked:\r\n<details><summary>Screenshots</summary>\r\n\r\n![image](https://user-images.githubusercontent.com/29142494/66037562-300e6d00-e510-11e9-8d29-cad1486e5ae2.png)\r\n\r\n![image](https://user-images.githubusercontent.com/29142494/66038213-c5f6c780-e511-11e9-9fa9-793929612406.png)\r\n\r\n</details>\r\n\r\nThere are 2 iframes from `deloplen.com` and one is blocked, but second not.\r\nIn Base filter there are these rules:\r\n```\r\n||deloplen.com^$third-party\r\n||deloplen.com^$popup\r\n||deloplen.com^\r\n```\r\nif I disable `||deloplen.com^$popup` then both iframes are blocked.\r\n\r\n### Steps to reproduce if link above will stop works\r\n1. Add these rules:\r\n`||youtube.com^`\r\n`||youtube.com^$popup`\r\n 2. Go here - https://www.cdaction.pl/news-56870/doom-eternal-mamy-gameplay-i-date-premiery-wideo.html\r\n\r\n### Expected behavior\r\n<!--- Tell us what should happen -->\r\nI think that iframes from `deloplen.com`/`youtube.com` should be blocked/removed.\r\n\r\n### Actual behavior\r\n<!--- Tell us what happens instead -->\r\nIframes from `deloplen.com`/`youtube.com` are not blocked/removed.\r\n\r\n### Your environment\r\n<!--- Please include all relevant details about the environment you experienced the bug in -->\r\n* AdGuard for Windows 7.2.2943 NIGHTLY (CL 1.5.60)\r\n"},"comment":{"url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/comments/537535077","html_url":"https://github.com/AdguardTeam/CoreLibs/issues/1148#issuecomment-537535077","issue_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/1148","id":537535077,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNzUzNTA3Nw==","user":{"login":"sfionov","id":47204,"node_id":"MDQ6VXNlcjQ3MjA0","avatar_url":"https://avatars2.githubusercontent.com/u/47204?v=4","gravatar_id":"","url":"https://api.github.com/users/sfionov","html_url":"https://github.com/sfionov","followers_url":"https://api.github.com/users/sfionov/followers","following_url":"https://api.github.com/users/sfionov/following{/other_user}","gists_url":"https://api.github.com/users/sfionov/gists{/gist_id}","starred_url":"https://api.github.com/users/sfionov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfionov/subscriptions","organizations_url":"https://api.github.com/users/sfionov/orgs","repos_url":"https://api.github.com/users/sfionov/repos","events_url":"https://api.github.com/users/sfionov/events{/privacy}","received_events_url":"https://api.github.com/users/sfionov/received_events","type":"User","site_admin":false},"created_at":"2019-10-02T15:01:24Z","updated_at":"2019-10-02T15:01:24Z","author_association":"MEMBER","body":"> In Base Filter there are this rules:\r\n\r\n@AdamWr \r\n\r\n```\r\n||deloplen.com^$third-party\r\n||deloplen.com^$popup\r\n||deloplen.com^\r\n```\r\n\r\nThis is combination with undefined behaviour - every rule for the same url and have the same priority.\r\nSo only one of them will be applied.\r\nPlease reduce such rules into one."}}
other: {"actor":{"display_login":"sfionov"}}