payload: {"action":"created","issue":{"url":"https://api.github.com/repos/commanderx16/x16-emulator/issues/106","repository_url":"https://api.github.com/repos/commanderx16/x16-emulator","labels_url":"https://api.github.com/repos/commanderx16/x16-emulator/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/commanderx16/x16-emulator/issues/106/comments","events_url":"https://api.github.com/repos/commanderx16/x16-emulator/issues/106/events","html_url":"https://github.com/commanderx16/x16-emulator/pull/106","id":496709701,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5OTk3MjMz","number":106,"title":"issue #51: Draw optimizations","user":{"login":"indigodarkwolf","id":5104193,"node_id":"MDQ6VXNlcjUxMDQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5104193?v=4","gravatar_id":"","url":"https://api.github.com/users/indigodarkwolf","html_url":"https://github.com/indigodarkwolf","followers_url":"https://api.github.com/users/indigodarkwolf/followers","following_url":"https://api.github.com/users/indigodarkwolf/following{/other_user}","gists_url":"https://api.github.com/users/indigodarkwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/indigodarkwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indigodarkwolf/subscriptions","organizations_url":"https://api.github.com/users/indigodarkwolf/orgs","repos_url":"https://api.github.com/users/indigodarkwolf/repos","events_url":"https://api.github.com/users/indigodarkwolf/events{/privacy}","received_events_url":"https://api.github.com/users/indigodarkwolf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-09-21T22:43:47Z","updated_at":"2019-09-22T06:28:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/commanderx16/x16-emulator/pulls/106","html_url":"https://github.com/commanderx16/x16-emulator/pull/106","diff_url":"https://github.com/commanderx16/x16-emulator/pull/106.diff","patch_url":"https://github.com/commanderx16/x16-emulator/pull/106.patch"},"body":"Some simple optimizations to get_pixel and get_sprite which reduce overhead from needlessly recalculating values that only change with layer and sprite attribute changes. Current layer and sprite properties are calculated into structs that can be referenced instead of performing the math for each pixel.\r\n\r\nIn my profiling, the largest single hotspot remaining in get_pixel() and get_sprite() seems to be the calls to video_space_read(), and my best guess is that branch instructions are causing needless stalling when it would be faster to perform a bitwise-and in the special cases of get_pixel() and get_sprite(). That last tweak is pending a question in issue #51."},"comment":{"url":"https://api.github.com/repos/commanderx16/x16-emulator/issues/comments/533853943","html_url":"https://github.com/commanderx16/x16-emulator/pull/106#issuecomment-533853943","issue_url":"https://api.github.com/repos/commanderx16/x16-emulator/issues/106","id":533853943,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMzg1Mzk0Mw==","user":{"login":"indigodarkwolf","id":5104193,"node_id":"MDQ6VXNlcjUxMDQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5104193?v=4","gravatar_id":"","url":"https://api.github.com/users/indigodarkwolf","html_url":"https://github.com/indigodarkwolf","followers_url":"https://api.github.com/users/indigodarkwolf/followers","following_url":"https://api.github.com/users/indigodarkwolf/following{/other_user}","gists_url":"https://api.github.com/users/indigodarkwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/indigodarkwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indigodarkwolf/subscriptions","organizations_url":"https://api.github.com/users/indigodarkwolf/orgs","repos_url":"https://api.github.com/users/indigodarkwolf/repos","events_url":"https://api.github.com/users/indigodarkwolf/events{/privacy}","received_events_url":"https://api.github.com/users/indigodarkwolf/received_events","type":"User","site_admin":false},"created_at":"2019-09-22T06:28:39Z","updated_at":"2019-09-22T06:28:39Z","author_association":"CONTRIBUTOR","body":"Git _is_ hard. >.> And my dayjob uses Perforce."}}
other: {"actor":{"display_login":"indigodarkwolf"}}