payload: {"action":"created","issue":{"url":"https://api.github.com/repos/RichiH/modbus_exporter/issues/4","repository_url":"https://api.github.com/repos/RichiH/modbus_exporter","labels_url":"https://api.github.com/repos/RichiH/modbus_exporter/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/RichiH/modbus_exporter/issues/4/comments","events_url":"https://api.github.com/repos/RichiH/modbus_exporter/issues/4/events","html_url":"https://github.com/RichiH/modbus_exporter/issues/4","id":523113329,"node_id":"MDU6SXNzdWU1MjMxMTMzMjk=","number":4,"title":"Status of the connection","user":{"login":"daviddetorres","id":48695803,"node_id":"MDQ6VXNlcjQ4Njk1ODAz","avatar_url":"https://avatars1.githubusercontent.com/u/48695803?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddetorres","html_url":"https://github.com/daviddetorres","followers_url":"https://api.github.com/users/daviddetorres/followers","following_url":"https://api.github.com/users/daviddetorres/following{/other_user}","gists_url":"https://api.github.com/users/daviddetorres/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddetorres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddetorres/subscriptions","organizations_url":"https://api.github.com/users/daviddetorres/orgs","repos_url":"https://api.github.com/users/daviddetorres/repos","events_url":"https://api.github.com/users/daviddetorres/events{/privacy}","received_events_url":"https://api.github.com/users/daviddetorres/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-11-14T21:26:00Z","updated_at":"2019-12-09T20:02:30Z","closed_at":null,"author_association":"NONE","body":"In some cases it can happen that the TCP connection with the device is ok, but the modbus server is not running, the client is connecting to another open port or that the modbus ID configured is not correct. \r\n\r\nIt also can happen that in the configuration shown in the README with a modbus TCP/RTU bridge, that the bridge is online (so the connection is established) but the connection with the RTU devices (usually a RS232 or RS485 bus) is not ok (bus disconnected, incorrect serial configuration, etc). \r\n\r\nIt could be interesting to add a metric to inform about the connection status (connection_up?) if the socket is correctly established, independently of the result of the query of the modbus registers. This can help to detect failures in the devices or configuration issues. \r\n\r\nIf you think any of this ideas would be worth to work in, I could work in a PR."},"comment":{"url":"https://api.github.com/repos/RichiH/modbus_exporter/issues/comments/563410935","html_url":"https://github.com/RichiH/modbus_exporter/issues/4#issuecomment-563410935","issue_url":"https://api.github.com/repos/RichiH/modbus_exporter/issues/4","id":563410935,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MzQxMDkzNQ==","user":{"login":"daviddetorres","id":48695803,"node_id":"MDQ6VXNlcjQ4Njk1ODAz","avatar_url":"https://avatars1.githubusercontent.com/u/48695803?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddetorres","html_url":"https://github.com/daviddetorres","followers_url":"https://api.github.com/users/daviddetorres/followers","following_url":"https://api.github.com/users/daviddetorres/following{/other_user}","gists_url":"https://api.github.com/users/daviddetorres/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddetorres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddetorres/subscriptions","organizations_url":"https://api.github.com/users/daviddetorres/orgs","repos_url":"https://api.github.com/users/daviddetorres/repos","events_url":"https://api.github.com/users/daviddetorres/events{/privacy}","received_events_url":"https://api.github.com/users/daviddetorres/received_events","type":"User","site_admin":false},"created_at":"2019-12-09T20:02:30Z","updated_at":"2019-12-09T20:02:30Z","author_association":"NONE","body":"I'll work in a PR to add these error metrics. \r\n\r\nMaybe it would be interesting, as you pointed, to give information of the number of failures, even adding a label with the type of failure (connection_error, timeout, incorrect_function?, bad_address?). This way operator would have more information on the type of problem they are addressing."}}
other: {"actor":{"display_login":"daviddetorres"}}