payload: {"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/433","repository_url":"https://api.github.com/repos/jenkinsci/git-client-plugin","labels_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/433/comments","events_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/433/events","html_url":"https://github.com/jenkinsci/git-client-plugin/pull/433","id":455837688,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4MDA0NjMy","number":433,"title":"JENKINS-45228 Add authentication to git merge operations","user":{"login":"gjabouley-invn","id":47566129,"node_id":"MDQ6VXNlcjQ3NTY2MTI5","avatar_url":"https://avatars3.githubusercontent.com/u/47566129?v=4","gravatar_id":"","url":"https://api.github.com/users/gjabouley-invn","html_url":"https://github.com/gjabouley-invn","followers_url":"https://api.github.com/users/gjabouley-invn/followers","following_url":"https://api.github.com/users/gjabouley-invn/following{/other_user}","gists_url":"https://api.github.com/users/gjabouley-invn/gists{/gist_id}","starred_url":"https://api.github.com/users/gjabouley-invn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjabouley-invn/subscriptions","organizations_url":"https://api.github.com/users/gjabouley-invn/orgs","repos_url":"https://api.github.com/users/gjabouley-invn/repos","events_url":"https://api.github.com/users/gjabouley-invn/events{/privacy}","received_events_url":"https://api.github.com/users/gjabouley-invn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2019-06-13T16:27:04Z","updated_at":"2019-07-08T15:35:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/433","html_url":"https://github.com/jenkinsci/git-client-plugin/pull/433","diff_url":"https://github.com/jenkinsci/git-client-plugin/pull/433.diff","patch_url":"https://github.com/jenkinsci/git-client-plugin/pull/433.patch"},"body":"## [JENKINS-45228](https://issues.jenkins-ci.org/browse/JENKINS-45228) - Enable authentication for git merge operations to support Git LFS during merge\r\n\r\nWhen doing a git merge in a branch containing modified/new LFS objects, git LFS will connect to remote to fetch the LFS objects.\r\n`ssh -- git@github.com git-lfs-authenticate ...`\r\nIf the command is executed with credentail, then it will fail with obscur error message:\r\n\r\n```\r\nError downloading object: binary2.bin (d3cf8be): Smudge error: Error downloading binary2.bin (d3cf8beded408772d7d3fbecd0423ca9b26265426f3a101cf263a549fc49e16b): batch request: Permission denied (publickey).: exit status 255\r\n\r\nErrors logged to /var/jenkins_home/workspace/reproduce_JENKINS_45228/.git/lfs/logs/20190613T143217.983927423.log\r\nUse `git lfs logs last` to view the log.\r\nerror: external filter 'git-lfs filter-process' failed\r\nfatal: binary2.bin: smudge filter lfs failed\r\n```\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/jenkinsci/git-client-plugin/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have referenced the Jira issue related to my changes in one or more commit messages\r\n- [x] I have added tests that verify my changes\r\n- [x] Unit tests pass locally with my changes\r\n- [ ] I have added documentation as necessary\r\n- [x] No Javadoc warnings were introduced with my changes\r\n- [x] No spotbugs warnings were introduced with my changes\r\n- [x] I have interactively tested my changes\r\n\r\n## Types of changes\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n## Comments\r\n\r\nThis is a very first attempt to fix this problem.\r\nIt was just interactively tested locally, and it actually solves related issue.\r\nAnyway, i'm not Java developer, so probably this PR lack some quality (unit test, coverage, ...).\r\nAny guidance to make it quickly acceptable and candidate for release would be appreciated.\r\n\r\nNote: i was not able to implement the same for JGit"},"comment":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/comments/509276539","html_url":"https://github.com/jenkinsci/git-client-plugin/pull/433#issuecomment-509276539","issue_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/433","id":509276539,"node_id":"MDEyOklzc3VlQ29tbWVudDUwOTI3NjUzOQ==","user":{"login":"MarkEWaite","id":156685,"node_id":"MDQ6VXNlcjE1NjY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/156685?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkEWaite","html_url":"https://github.com/MarkEWaite","followers_url":"https://api.github.com/users/MarkEWaite/followers","following_url":"https://api.github.com/users/MarkEWaite/following{/other_user}","gists_url":"https://api.github.com/users/MarkEWaite/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkEWaite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkEWaite/subscriptions","organizations_url":"https://api.github.com/users/MarkEWaite/orgs","repos_url":"https://api.github.com/users/MarkEWaite/repos","events_url":"https://api.github.com/users/MarkEWaite/events{/privacy}","received_events_url":"https://api.github.com/users/MarkEWaite/received_events","type":"User","site_admin":false},"created_at":"2019-07-08T15:35:58Z","updated_at":"2019-07-08T15:35:58Z","author_association":"CONTRIBUTOR","body":"No action needed from you @gjabouley-invn . My weekend work on the plugin was spent releasing a new git plugin version and preparing changelogs for upcoming release of git plugin 4.0.0 and git client plugin 3.0.0.  I haven't yet decided if I'm willing to include this pull request in that upcoming release."}}
other: {"actor":{"display_login":"MarkEWaite"}}