payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/256172068","pull_request_review_id":202939098,"id":256172068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjE3MjA2OA==","diff_hunk":"@@ -95,8 +125,12 @@ func TestUploadToGcs(t *testing.T) {\n \t\t\tt.Errorf(\"%s: expected an error but got none\", testCase.name)\n \t\t}\n \n-\t\tif count != (testCase.passingTargets + testCase.failingTargets) {\n-\t\t\tt.Errorf(\"%s: had %d passing and %d failing targets but only ran %d targets, not %d\", testCase.name, testCase.passingTargets, testCase.failingTargets, count, testCase.passingTargets+testCase.failingTargets)\n+\t\t// the fail func will update count for each retry, while the flaky func only updates count on final try\n+\t\tfinalFailingCount := testCase.failingTargets * uploadRetries\n+\t\tfinalPassingCount := testCase.passingTargets + testCase.flakyTargets\n+\n+\t\tif count != (finalPassingCount + finalFailingCount) {","path":"prow/pod-utils/gcs/upload_test.go","position":73,"original_position":73,"commit_id":"b79bc0aa7cd10221d3bc609cf16bf111a62d7371","original_commit_id":"5d096a94e5e0754135ce4cb4d95f92a3e6ff4954","user":{"login":"fejta","id":940341,"node_id":"MDQ6VXNlcjk0MDM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"IMO that is unnecessary, and just makes the test case more fragile than necessary.\r\n\r\nWhat is important is that a) we have a flaky uploader that will not pass the first time b) that passes on subsequent attempts and c) this results in a successful upload.\r\n\r\nIdeally we can tune whether we retry 2, 5, 50 times without rewriting the test case.","created_at":"2019-02-12T22:22:11Z","updated_at":"2019-02-12T22:29:55Z","html_url":"https://github.com/kubernetes/test-infra/pull/11133#discussion_r256172068","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/256172068"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/11133#discussion_r256172068"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133"}},"in_reply_to_id":256085230},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133","id":250576238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwNTc2MjM4","html_url":"https://github.com/kubernetes/test-infra/pull/11133","diff_url":"https://github.com/kubernetes/test-infra/pull/11133.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/11133.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/11133","number":11133,"state":"open","locked":false,"title":"Retry data upload 3 times #10884","user":{"login":"jluhrsen","id":3209625,"node_id":"MDQ6VXNlcjMyMDk2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3209625?v=4","gravatar_id":"","url":"https://api.github.com/users/jluhrsen","html_url":"https://github.com/jluhrsen","followers_url":"https://api.github.com/users/jluhrsen/followers","following_url":"https://api.github.com/users/jluhrsen/following{/other_user}","gists_url":"https://api.github.com/users/jluhrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jluhrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluhrsen/subscriptions","organizations_url":"https://api.github.com/users/jluhrsen/orgs","repos_url":"https://api.github.com/users/jluhrsen/repos","events_url":"https://api.github.com/users/jluhrsen/events{/privacy}","received_events_url":"https://api.github.com/users/jluhrsen/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>","created_at":"2019-02-05T22:34:00Z","updated_at":"2019-02-12T22:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7c08093151e5b9fcebae4f6b77e584f923d4b09","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cjwagner","id":5334145,"node_id":"MDQ6VXNlcjUzMzQxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":412127043,"node_id":"MDU6TGFiZWw0MTIxMjcwNDM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":1039750554,"node_id":"MDU6TGFiZWwxMDM5NzUwNTU0","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow/gcsupload","name":"area/prow/gcsupload","color":"0052cc","default":false},{"id":1039749263,"node_id":"MDU6TGFiZWwxMDM5NzQ5MjYz","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow/pod-utilities","name":"area/prow/pod-utilities","color":"0052cc","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1086786497,"node_id":"MDU6TGFiZWwxMDg2Nzg2NDk3","url":"https://api.github.com/repos/kubernetes/test-infra/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":718255721,"node_id":"MDU6TGFiZWw3MTgyNTU3MjE=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":671126262,"node_id":"MDU6TGFiZWw2NzExMjYyNjI=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/M","name":"size/M","color":"eebb00","default":false},{"id":521200414,"node_id":"MDU6TGFiZWw1MjEyMDA0MTQ=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/%C2%AF%5C_(%E3%83%84)_/%C2%AF","name":"¯\\_(ツ)_/¯","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/11133/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/b79bc0aa7cd10221d3bc609cf16bf111a62d7371","head":{"label":"jluhrsen:10884","ref":"10884","sha":"b79bc0aa7cd10221d3bc609cf16bf111a62d7371","user":{"login":"jluhrsen","id":3209625,"node_id":"MDQ6VXNlcjMyMDk2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3209625?v=4","gravatar_id":"","url":"https://api.github.com/users/jluhrsen","html_url":"https://github.com/jluhrsen","followers_url":"https://api.github.com/users/jluhrsen/followers","following_url":"https://api.github.com/users/jluhrsen/following{/other_user}","gists_url":"https://api.github.com/users/jluhrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jluhrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluhrsen/subscriptions","organizations_url":"https://api.github.com/users/jluhrsen/orgs","repos_url":"https://api.github.com/users/jluhrsen/repos","events_url":"https://api.github.com/users/jluhrsen/events{/privacy}","received_events_url":"https://api.github.com/users/jluhrsen/received_events","type":"User","site_admin":false},"repo":{"id":168439339,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg0MzkzMzk=","name":"test-infra","full_name":"jluhrsen/test-infra","private":false,"owner":{"login":"jluhrsen","id":3209625,"node_id":"MDQ6VXNlcjMyMDk2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3209625?v=4","gravatar_id":"","url":"https://api.github.com/users/jluhrsen","html_url":"https://github.com/jluhrsen","followers_url":"https://api.github.com/users/jluhrsen/followers","following_url":"https://api.github.com/users/jluhrsen/following{/other_user}","gists_url":"https://api.github.com/users/jluhrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jluhrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluhrsen/subscriptions","organizations_url":"https://api.github.com/users/jluhrsen/orgs","repos_url":"https://api.github.com/users/jluhrsen/repos","events_url":"https://api.github.com/users/jluhrsen/events{/privacy}","received_events_url":"https://api.github.com/users/jluhrsen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jluhrsen/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/jluhrsen/test-infra","forks_url":"https://api.github.com/repos/jluhrsen/test-infra/forks","keys_url":"https://api.github.com/repos/jluhrsen/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jluhrsen/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jluhrsen/test-infra/teams","hooks_url":"https://api.github.com/repos/jluhrsen/test-infra/hooks","issue_events_url":"https://api.github.com/repos/jluhrsen/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/jluhrsen/test-infra/events","assignees_url":"https://api.github.com/repos/jluhrsen/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/jluhrsen/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/jluhrsen/test-infra/tags","blobs_url":"https://api.github.com/repos/jluhrsen/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jluhrsen/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jluhrsen/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/jluhrsen/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jluhrsen/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/jluhrsen/test-infra/languages","stargazers_url":"https://api.github.com/repos/jluhrsen/test-infra/stargazers","contributors_url":"https://api.github.com/repos/jluhrsen/test-infra/contributors","subscribers_url":"https://api.github.com/repos/jluhrsen/test-infra/subscribers","subscription_url":"https://api.github.com/repos/jluhrsen/test-infra/subscription","commits_url":"https://api.github.com/repos/jluhrsen/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/jluhrsen/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/jluhrsen/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/jluhrsen/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/jluhrsen/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/jluhrsen/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jluhrsen/test-infra/merges","archive_url":"https://api.github.com/repos/jluhrsen/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jluhrsen/test-infra/downloads","issues_url":"https://api.github.com/repos/jluhrsen/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/jluhrsen/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/jluhrsen/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/jluhrsen/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jluhrsen/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/jluhrsen/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/jluhrsen/test-infra/deployments","created_at":"2019-01-31T00:53:35Z","updated_at":"2019-02-05T19:15:35Z","pushed_at":"2019-02-12T21:44:51Z","git_url":"git://github.com/jluhrsen/test-infra.git","ssh_url":"git@github.com:jluhrsen/test-infra.git","clone_url":"https://github.com/jluhrsen/test-infra.git","svn_url":"https://github.com/jluhrsen/test-infra","homepage":null,"size":75432,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"67936444db22f0eb034df86a7518faf2dd55ef39","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2019-02-12T22:23:19Z","pushed_at":"2019-02-12T22:23:09Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":76488,"stargazers_count":915,"watchers_count":915,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":737,"mirror_url":null,"archived":false,"open_issues_count":366,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":737,"open_issues":366,"watchers":915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/11133"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/11133"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/11133/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/11133/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/b79bc0aa7cd10221d3bc609cf16bf111a62d7371"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"fejta"}}