payload: {"action":"created","issue":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/6686","repository_url":"https://api.github.com/repos/jupyterlab/jupyterlab","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/6686/labels{/name}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/6686/comments","events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/6686/events","html_url":"https://github.com/jupyterlab/jupyterlab/pull/6686","id":459393590,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNzY1MTg4","number":6686,"title":"Fix downloads in Chrome with xsrf token","user":{"login":"tslaton","id":9665562,"node_id":"MDQ6VXNlcjk2NjU1NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9665562?v=4","gravatar_id":"","url":"https://api.github.com/users/tslaton","html_url":"https://github.com/tslaton","followers_url":"https://api.github.com/users/tslaton/followers","following_url":"https://api.github.com/users/tslaton/following{/other_user}","gists_url":"https://api.github.com/users/tslaton/gists{/gist_id}","starred_url":"https://api.github.com/users/tslaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tslaton/subscriptions","organizations_url":"https://api.github.com/users/tslaton/orgs","repos_url":"https://api.github.com/users/tslaton/repos","events_url":"https://api.github.com/users/tslaton/events{/privacy}","received_events_url":"https://api.github.com/users/tslaton/received_events","type":"User","site_admin":false},"labels":[{"id":390178969,"node_id":"MDU6TGFiZWwzOTAxNzg5Njk=","url":"https://api.github.com/repos/jupyterlab/jupyterlab/labels/status:Needs%20Info","name":"status:Needs Info","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"jasongrout","id":192614,"node_id":"MDQ6VXNlcjE5MjYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasongrout","id":192614,"node_id":"MDQ6VXNlcjE5MjYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones/31","html_url":"https://github.com/jupyterlab/jupyterlab/milestone/31","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones/31/labels","id":4097142,"node_id":"MDk6TWlsZXN0b25lNDA5NzE0Mg==","number":31,"title":"1.1","description":"A post JupyterLab 1.0 release.","creator":{"login":"afshin","id":159529,"node_id":"MDQ6VXNlcjE1OTUyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/159529?v=4","gravatar_id":"","url":"https://api.github.com/users/afshin","html_url":"https://github.com/afshin","followers_url":"https://api.github.com/users/afshin/followers","following_url":"https://api.github.com/users/afshin/following{/other_user}","gists_url":"https://api.github.com/users/afshin/gists{/gist_id}","starred_url":"https://api.github.com/users/afshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afshin/subscriptions","organizations_url":"https://api.github.com/users/afshin/orgs","repos_url":"https://api.github.com/users/afshin/repos","events_url":"https://api.github.com/users/afshin/events{/privacy}","received_events_url":"https://api.github.com/users/afshin/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":29,"state":"open","created_at":"2019-02-28T16:26:23Z","updated_at":"2019-08-02T21:59:04Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2019-06-21T22:27:25Z","updated_at":"2019-08-03T08:35:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/6686","html_url":"https://github.com/jupyterlab/jupyterlab/pull/6686","diff_url":"https://github.com/jupyterlab/jupyterlab/pull/6686.diff","patch_url":"https://github.com/jupyterlab/jupyterlab/pull/6686.patch"},"body":"<!--\r\nThanks for contributing to JupyterLab!\r\nPlease fill out the following items to submit a pull request.\r\nSee the contributing guidelines for more information:\r\nhttps://github.com/jupyterlab/jupyterlab/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n## References\r\n\r\nhttps://github.com/jupyterlab/jupyterlab/issues/6658\r\n\r\n<!-- Note issue numbers this pull request addresses (should be at least one, see contributing guidelines above). -->\r\n\r\n<!-- Note any other pull requests that address this issue and how this pull request is different. -->\r\n\r\n## Code changes\r\n\r\n<!-- Describe the code changes and how they address the issue. -->\r\n\r\nI removed `target=_blank` from the href created for downloading files because it:\r\n* has no effect in Firefox or Safari, given the `download` attribute is present\r\n* is insufficient to allow downloads in Chrome, which still get a 403: Forbidden error\r\n\r\nI added `?_xsrf=<token>` and a specified the file name in the download attribute to fix the download issues in Chrome. Chrome does not automatically determine the file name when the attribute is blank."},"comment":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/comments/517906582","html_url":"https://github.com/jupyterlab/jupyterlab/pull/6686#issuecomment-517906582","issue_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/6686","id":517906582,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNzkwNjU4Mg==","user":{"login":"jasongrout","id":192614,"node_id":"MDQ6VXNlcjE5MjYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"created_at":"2019-08-03T08:35:21Z","updated_at":"2019-08-03T08:35:21Z","author_association":"CONTRIBUTOR","body":"> Still, FWIW, we should ensure that the notebook server doesn't include the xsrf token in logs if given as a url param (it probably does).\r\n\r\nI just checked - the notebook server does log the xsrf token given in a GET request."}}
other: {"actor":{"display_login":"jasongrout"}}