payload: {"action":"closed","number":5876,"pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/5876","id":352181242,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMTgxMjQy","html_url":"https://github.com/rstudio/rstudio/pull/5876","diff_url":"https://github.com/rstudio/rstudio/pull/5876.diff","patch_url":"https://github.com/rstudio/rstudio/pull/5876.patch","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/5876","number":5876,"state":"closed","locked":false,"title":"fix accessibility of SVN Resolve dialog","user":{"login":"gtritchie","id":10569626,"node_id":"MDQ6VXNlcjEwNTY5NjI2","avatar_url":"https://avatars3.githubusercontent.com/u/10569626?v=4","gravatar_id":"","url":"https://api.github.com/users/gtritchie","html_url":"https://github.com/gtritchie","followers_url":"https://api.github.com/users/gtritchie/followers","following_url":"https://api.github.com/users/gtritchie/following{/other_user}","gists_url":"https://api.github.com/users/gtritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/gtritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtritchie/subscriptions","organizations_url":"https://api.github.com/users/gtritchie/orgs","repos_url":"https://api.github.com/users/gtritchie/repos","events_url":"https://api.github.com/users/gtritchie/events{/privacy}","received_events_url":"https://api.github.com/users/gtritchie/received_events","type":"User","site_admin":false},"body":"An example of a simple-looking dialog with a remarkable number of accessibility problems. Fixed by brute force in code. If I come across more examples following this same pattern I might consider creating a standard control that hides the gory details, but this does the trick for this case.\r\n\r\nProblems:\r\n- contrast too low on descriptions (bumped up contrast)\r\n- radio buttons not associated with their labels (gave labels IDs, then associated radio buttons via `for`) \r\n- radio buttons not associated with their descriptions (gave descriptions IDs, then associated buttons with `aria-describedby`); a screen reader will typically read the label, pause, then read the description (depending on screen reader verbosity settings)\r\n- group of radio buttons not associated with heading (\"Resolve the selected path using\"); gave the heading an ID, gave the group the \"group\" role, then associated label using `aria-labelledby`\r\n\r\n<img width=\"310\" alt=\"2019-12-11_16-34-31\" src=\"https://user-images.githubusercontent.com/10569626/70672764-19357680-1c35-11ea-903d-c3d95c1de56f.png\">\r\n","created_at":"2019-12-12T00:49:56Z","updated_at":"2019-12-12T17:18:45Z","closed_at":"2019-12-12T17:18:45Z","merged_at":"2019-12-12T17:18:45Z","merge_commit_sha":"82121af40217d767865f07af08b67dad9b5ceaf2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1050977845,"node_id":"MDU6TGFiZWwxMDUwOTc3ODQ1","url":"https://api.github.com/repos/rstudio/rstudio/labels/accessibility","name":"accessibility","color":"8772ff","default":false,"description":""},{"id":835530769,"node_id":"MDU6TGFiZWw4MzU1MzA3Njk=","url":"https://api.github.com/repos/rstudio/rstudio/labels/vcs","name":"vcs","color":"003bdd","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/rstudio/rstudio/milestones/4","html_url":"https://github.com/rstudio/rstudio/milestone/4","labels_url":"https://api.github.com/repos/rstudio/rstudio/milestones/4/labels","id":2807857,"node_id":"MDk6TWlsZXN0b25lMjgwNzg1Nw==","number":4,"title":"v1.3","description":"","creator":{"login":"jmcphers","id":470418,"node_id":"MDQ6VXNlcjQ3MDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/470418?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcphers","html_url":"https://github.com/jmcphers","followers_url":"https://api.github.com/users/jmcphers/followers","following_url":"https://api.github.com/users/jmcphers/following{/other_user}","gists_url":"https://api.github.com/users/jmcphers/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcphers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcphers/subscriptions","organizations_url":"https://api.github.com/users/jmcphers/orgs","repos_url":"https://api.github.com/users/jmcphers/repos","events_url":"https://api.github.com/users/jmcphers/events{/privacy}","received_events_url":"https://api.github.com/users/jmcphers/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":240,"state":"open","created_at":"2017-10-02T17:09:06Z","updated_at":"2019-12-12T17:18:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rstudio/rstudio/pulls/5876/commits","review_comments_url":"https://api.github.com/repos/rstudio/rstudio/pulls/5876/comments","review_comment_url":"https://api.github.com/repos/rstudio/rstudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/5876/comments","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/e1d882900e507225a7a0191332e6f0e6ce774bfb","head":{"label":"rstudio:bugfix/svn-resolve-dialog-a11y","ref":"bugfix/svn-resolve-dialog-a11y","sha":"e1d882900e507225a7a0191332e6f0e6ce774bfb","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":1147463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDYz","name":"rstudio","full_name":"rstudio/rstudio","private":false,"owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rstudio/rstudio","description":"RStudio is an integrated development environment (IDE) for R","fork":false,"url":"https://api.github.com/repos/rstudio/rstudio","forks_url":"https://api.github.com/repos/rstudio/rstudio/forks","keys_url":"https://api.github.com/repos/rstudio/rstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/rstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/rstudio/teams","hooks_url":"https://api.github.com/repos/rstudio/rstudio/hooks","issue_events_url":"https://api.github.com/repos/rstudio/rstudio/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/rstudio/events","assignees_url":"https://api.github.com/repos/rstudio/rstudio/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/rstudio/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/rstudio/tags","blobs_url":"https://api.github.com/repos/rstudio/rstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/rstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/rstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/rstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/rstudio/languages","stargazers_url":"https://api.github.com/repos/rstudio/rstudio/stargazers","contributors_url":"https://api.github.com/repos/rstudio/rstudio/contributors","subscribers_url":"https://api.github.com/repos/rstudio/rstudio/subscribers","subscription_url":"https://api.github.com/repos/rstudio/rstudio/subscription","commits_url":"https://api.github.com/repos/rstudio/rstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/rstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/rstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/rstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/rstudio/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/rstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/rstudio/merges","archive_url":"https://api.github.com/repos/rstudio/rstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/rstudio/downloads","issues_url":"https://api.github.com/repos/rstudio/rstudio/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/rstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/rstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/rstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/rstudio/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/rstudio/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/rstudio/deployments","created_at":"2010-12-07T19:10:25Z","updated_at":"2019-12-12T17:18:30Z","pushed_at":"2019-12-12T17:18:45Z","git_url":"git://github.com/rstudio/rstudio.git","ssh_url":"git@github.com:rstudio/rstudio.git","clone_url":"https://github.com/rstudio/rstudio.git","svn_url":"https://github.com/rstudio/rstudio","homepage":"https://www.rstudio.com/products/rstudio/","size":198333,"stargazers_count":3006,"watchers_count":3006,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":746,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1157,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":746,"open_issues":1157,"watchers":3006,"default_branch":"master"}},"base":{"label":"rstudio:master","ref":"master","sha":"063457a32b589ac7d723785e1e62bd4c210d1a41","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":1147463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDYz","name":"rstudio","full_name":"rstudio/rstudio","private":false,"owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rstudio/rstudio","description":"RStudio is an integrated development environment (IDE) for R","fork":false,"url":"https://api.github.com/repos/rstudio/rstudio","forks_url":"https://api.github.com/repos/rstudio/rstudio/forks","keys_url":"https://api.github.com/repos/rstudio/rstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/rstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/rstudio/teams","hooks_url":"https://api.github.com/repos/rstudio/rstudio/hooks","issue_events_url":"https://api.github.com/repos/rstudio/rstudio/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/rstudio/events","assignees_url":"https://api.github.com/repos/rstudio/rstudio/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/rstudio/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/rstudio/tags","blobs_url":"https://api.github.com/repos/rstudio/rstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/rstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/rstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/rstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/rstudio/languages","stargazers_url":"https://api.github.com/repos/rstudio/rstudio/stargazers","contributors_url":"https://api.github.com/repos/rstudio/rstudio/contributors","subscribers_url":"https://api.github.com/repos/rstudio/rstudio/subscribers","subscription_url":"https://api.github.com/repos/rstudio/rstudio/subscription","commits_url":"https://api.github.com/repos/rstudio/rstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/rstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/rstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/rstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/rstudio/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/rstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/rstudio/merges","archive_url":"https://api.github.com/repos/rstudio/rstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/rstudio/downloads","issues_url":"https://api.github.com/repos/rstudio/rstudio/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/rstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/rstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/rstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/rstudio/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/rstudio/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/rstudio/deployments","created_at":"2010-12-07T19:10:25Z","updated_at":"2019-12-12T17:18:30Z","pushed_at":"2019-12-12T17:18:45Z","git_url":"git://github.com/rstudio/rstudio.git","ssh_url":"git@github.com:rstudio/rstudio.git","clone_url":"https://github.com/rstudio/rstudio.git","svn_url":"https://github.com/rstudio/rstudio","homepage":"https://www.rstudio.com/products/rstudio/","size":198333,"stargazers_count":3006,"watchers_count":3006,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":746,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1157,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":746,"open_issues":1157,"watchers":3006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/5876"},"html":{"href":"https://github.com/rstudio/rstudio/pull/5876"},"issue":{"href":"https://api.github.com/repos/rstudio/rstudio/issues/5876"},"comments":{"href":"https://api.github.com/repos/rstudio/rstudio/issues/5876/comments"},"review_comments":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/5876/comments"},"review_comment":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/5876/commits"},"statuses":{"href":"https://api.github.com/repos/rstudio/rstudio/statuses/e1d882900e507225a7a0191332e6f0e6ce774bfb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gtritchie","id":10569626,"node_id":"MDQ6VXNlcjEwNTY5NjI2","avatar_url":"https://avatars3.githubusercontent.com/u/10569626?v=4","gravatar_id":"","url":"https://api.github.com/users/gtritchie","html_url":"https://github.com/gtritchie","followers_url":"https://api.github.com/users/gtritchie/followers","following_url":"https://api.github.com/users/gtritchie/following{/other_user}","gists_url":"https://api.github.com/users/gtritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/gtritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtritchie/subscriptions","organizations_url":"https://api.github.com/users/gtritchie/orgs","repos_url":"https://api.github.com/users/gtritchie/repos","events_url":"https://api.github.com/users/gtritchie/events{/privacy}","received_events_url":"https://api.github.com/users/gtritchie/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":79,"deletions":36,"changed_files":3}}
other: {"actor":{"display_login":"gtritchie"}}