payload: {"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/359133114","pull_request_review_id":333706645,"id":359133114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTEzMzExNA==","diff_hunk":"@@ -80,13 +81,20 @@ def run(test, params, env):\n     if not md5:\n         test.error(\"Fail to save tmp file\")\n     convert_test.destroy_vm()\n-    n_params = convert_test.convert()\n-    convert_test.compare_test(n_params)\n-    convert_test.verify_info(n_params)\n-    convert_test.start_vm(n_params)\n \n-    # check md5sum after conversion\n-    ret = convert_test.check_file(t_file, md5)\n-    if not ret:\n-        test.error(\"image content changed after convert\")\n-    convert_test.clean()\n+    cluster_size_set = params.get(\"cluster_size_set\")","path":"qemu/tests/qemu_disk_img_convert.py","position":20,"original_position":20,"commit_id":"dc46d5af2bd1c14751c6644a66eee42921d0dc4b","original_commit_id":"d7aeff0f1f73820f589277fbbe36e3cd810bd038","user":{"login":"YongxueHong","id":24557394,"node_id":"MDQ6VXNlcjI0NTU3Mzk0","avatar_url":"https://avatars2.githubusercontent.com/u/24557394?v=4","gravatar_id":"","url":"https://api.github.com/users/YongxueHong","html_url":"https://github.com/YongxueHong","followers_url":"https://api.github.com/users/YongxueHong/followers","following_url":"https://api.github.com/users/YongxueHong/following{/other_user}","gists_url":"https://api.github.com/users/YongxueHong/gists{/gist_id}","starred_url":"https://api.github.com/users/YongxueHong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YongxueHong/subscriptions","organizations_url":"https://api.github.com/users/YongxueHong/orgs","repos_url":"https://api.github.com/users/YongxueHong/repos","events_url":"https://api.github.com/users/YongxueHong/events{/privacy}","received_events_url":"https://api.github.com/users/YongxueHong/received_events","type":"User","site_admin":false},"body":"You could use  `cluster_size_set = params.get(\"cluster_size_set\", \"\")`:\r\nPlease see virttest/utils_params:\r\n```\r\nclass Params(IterableUserDict):\r\n\r\n    \"\"\"\r\n    A dict-like object passed to every test.\r\n    \"\"\"\r\n    lock = Lock()\r\n\r\n    def __getitem__(self, key):\r\n        \"\"\" overrides the error messages of missing params[$key] \"\"\"\r\n        try:\r\n            return IterableUserDict.__getitem__(self, key)\r\n        except KeyError:\r\n            raise ParamNotFound(\"Mandatory parameter '%s' is missing. \"\r\n                                \"Check your cfg files for typos/mistakes\" %\r\n                                key)\r\n\r\n    def get(self, key, default=None):\r\n        \"\"\" overrides the behavior to catch ParamNotFound error\"\"\"\r\n        try:\r\n            return self[key]\r\n        except ParamNotFound:\r\n            return default\r\n```","created_at":"2019-12-18T03:06:41Z","updated_at":"2019-12-18T03:18:31Z","html_url":"https://github.com/autotest/tp-qemu/pull/2020#discussion_r359133114","pull_request_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/359133114"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/2020#discussion_r359133114"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020","id":351214677,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMjE0Njc3","html_url":"https://github.com/autotest/tp-qemu/pull/2020","diff_url":"https://github.com/autotest/tp-qemu/pull/2020.diff","patch_url":"https://github.com/autotest/tp-qemu/pull/2020.patch","issue_url":"https://api.github.com/repos/autotest/tp-qemu/issues/2020","number":2020,"state":"open","locked":false,"title":"qemu_disk_img: Complete the supported cluster_size values","user":{"login":"hellohellenmao","id":46562218,"node_id":"MDQ6VXNlcjQ2NTYyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/46562218?v=4","gravatar_id":"","url":"https://api.github.com/users/hellohellenmao","html_url":"https://github.com/hellohellenmao","followers_url":"https://api.github.com/users/hellohellenmao/followers","following_url":"https://api.github.com/users/hellohellenmao/following{/other_user}","gists_url":"https://api.github.com/users/hellohellenmao/gists{/gist_id}","starred_url":"https://api.github.com/users/hellohellenmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellohellenmao/subscriptions","organizations_url":"https://api.github.com/users/hellohellenmao/orgs","repos_url":"https://api.github.com/users/hellohellenmao/repos","events_url":"https://api.github.com/users/hellohellenmao/events{/privacy}","received_events_url":"https://api.github.com/users/hellohellenmao/received_events","type":"User","site_admin":false},"body":"qemu_img: Delete the dup cases with the ones in qemu_disk_img\r\n\r\n1. Add the remain supported cluster_size values - A power of two between 512 and 2048k.\r\n2. Delete the duplicate case with the ones in qemu_disk_img cfg file.\r\n\r\nID: 1781474\r\nSigned-off-by: Tingting Mao <timao@redhat.com>","created_at":"2019-12-10T06:00:33Z","updated_at":"2019-12-18T03:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c4e020e305b2963a1e8214a09b93a813dff0a81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/issues/2020/comments","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/dc46d5af2bd1c14751c6644a66eee42921d0dc4b","head":{"label":"hellohellenmao:1781474","ref":"1781474","sha":"dc46d5af2bd1c14751c6644a66eee42921d0dc4b","user":{"login":"hellohellenmao","id":46562218,"node_id":"MDQ6VXNlcjQ2NTYyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/46562218?v=4","gravatar_id":"","url":"https://api.github.com/users/hellohellenmao","html_url":"https://github.com/hellohellenmao","followers_url":"https://api.github.com/users/hellohellenmao/followers","following_url":"https://api.github.com/users/hellohellenmao/following{/other_user}","gists_url":"https://api.github.com/users/hellohellenmao/gists{/gist_id}","starred_url":"https://api.github.com/users/hellohellenmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellohellenmao/subscriptions","organizations_url":"https://api.github.com/users/hellohellenmao/orgs","repos_url":"https://api.github.com/users/hellohellenmao/repos","events_url":"https://api.github.com/users/hellohellenmao/events{/privacy}","received_events_url":"https://api.github.com/users/hellohellenmao/received_events","type":"User","site_admin":false},"repo":{"id":165049951,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUwNDk5NTE=","name":"tp-qemu","full_name":"hellohellenmao/tp-qemu","private":false,"owner":{"login":"hellohellenmao","id":46562218,"node_id":"MDQ6VXNlcjQ2NTYyMjE4","avatar_url":"https://avatars2.githubusercontent.com/u/46562218?v=4","gravatar_id":"","url":"https://api.github.com/users/hellohellenmao","html_url":"https://github.com/hellohellenmao","followers_url":"https://api.github.com/users/hellohellenmao/followers","following_url":"https://api.github.com/users/hellohellenmao/following{/other_user}","gists_url":"https://api.github.com/users/hellohellenmao/gists{/gist_id}","starred_url":"https://api.github.com/users/hellohellenmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellohellenmao/subscriptions","organizations_url":"https://api.github.com/users/hellohellenmao/orgs","repos_url":"https://api.github.com/users/hellohellenmao/repos","events_url":"https://api.github.com/users/hellohellenmao/events{/privacy}","received_events_url":"https://api.github.com/users/hellohellenmao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hellohellenmao/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":true,"url":"https://api.github.com/repos/hellohellenmao/tp-qemu","forks_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/forks","keys_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/teams","hooks_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/events","assignees_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/tags","blobs_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/subscription","commits_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/merges","archive_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/downloads","issues_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/hellohellenmao/tp-qemu/deployments","created_at":"2019-01-10T11:44:15Z","updated_at":"2019-01-11T06:22:21Z","pushed_at":"2019-12-18T03:16:57Z","git_url":"git://github.com/hellohellenmao/tp-qemu.git","ssh_url":"git@github.com:hellohellenmao/tp-qemu.git","clone_url":"https://github.com/hellohellenmao/tp-qemu.git","svn_url":"https://github.com/hellohellenmao/tp-qemu","homepage":null,"size":47213,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"71a331a14d3601422bab8099e6a7a96242e27c9e","user":{"login":"autotest","id":472856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180304,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4MDMwNA==","name":"tp-qemu","full_name":"autotest/tp-qemu","private":false,"owner":{"login":"autotest","id":472856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/autotest/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-qemu","forks_url":"https://api.github.com/repos/autotest/tp-qemu/forks","keys_url":"https://api.github.com/repos/autotest/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-qemu/teams","hooks_url":"https://api.github.com/repos/autotest/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-qemu/events","assignees_url":"https://api.github.com/repos/autotest/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-qemu/tags","blobs_url":"https://api.github.com/repos/autotest/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-qemu/subscription","commits_url":"https://api.github.com/repos/autotest/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-qemu/merges","archive_url":"https://api.github.com/repos/autotest/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-qemu/downloads","issues_url":"https://api.github.com/repos/autotest/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-qemu/deployments","created_at":"2014-01-23T17:51:34Z","updated_at":"2019-12-11T09:31:37Z","pushed_at":"2019-12-18T03:16:59Z","git_url":"git://github.com/autotest/tp-qemu.git","ssh_url":"git@github.com:autotest/tp-qemu.git","clone_url":"https://github.com/autotest/tp-qemu.git","svn_url":"https://github.com/autotest/tp-qemu","homepage":null,"size":47309,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":141,"open_issues":66,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/2020"},"issue":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/2020"},"comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/2020/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/2020/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-qemu/statuses/dc46d5af2bd1c14751c6644a66eee42921d0dc4b"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"YongxueHong"}}