payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ShifuML/shifu/pulls/comments/282303668","pull_request_review_id":235355593,"id":282303668,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjMwMzY2OA==","diff_hunk":"@@ -386,7 +397,29 @@ public MLData call() {\n                         return ((GenericModel) model).compute(pair.getInput());\n                     }\n                 };\n-                if (multiThread) {\n+                if(multiThread) {\n+                    tasks.add(callable);\n+                } else {\n+                    try {\n+                        modelResults.add(callable.call());\n+                    } catch (Exception e) {\n+                        log.error(\"error in model evaluation\", e);\n+                    }\n+                }\n+            } else if(model instanceof WDLModel) {\n+                final WDLModel wdl = (WDLModel) model;\n+                // if(wdl.getInputCount() != pair.getInput().size()) {\n+                // throw new RuntimeException(\"WDL and input size mismatch: wdl input Size = \" + wdl.getInputCount()\n+                // + \"; data input Size = \" + pair.getInput().size());\n+                // }","path":"src/main/java/ml/shifu/shifu/core/Scorer.java","position":94,"original_position":94,"commit_id":"23d794c1b7888fdfb56b990fec6eef35e0c2f9bb","original_commit_id":"23d794c1b7888fdfb56b990fec6eef35e0c2f9bb","user":{"login":"zhangpengshan","id":7368102,"node_id":"MDQ6VXNlcjczNjgxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/7368102?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangpengshan","html_url":"https://github.com/zhangpengshan","followers_url":"https://api.github.com/users/zhangpengshan/followers","following_url":"https://api.github.com/users/zhangpengshan/following{/other_user}","gists_url":"https://api.github.com/users/zhangpengshan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangpengshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangpengshan/subscriptions","organizations_url":"https://api.github.com/users/zhangpengshan/orgs","repos_url":"https://api.github.com/users/zhangpengshan/repos","events_url":"https://api.github.com/users/zhangpengshan/events{/privacy}","received_events_url":"https://api.github.com/users/zhangpengshan/received_events","type":"User","site_admin":false},"body":"seems we can have exception here to quick identify input inconsistent issue","created_at":"2019-05-09T00:35:26Z","updated_at":"2019-05-09T00:55:18Z","html_url":"https://github.com/ShifuML/shifu/pull/633#discussion_r282303668","pull_request_url":"https://api.github.com/repos/ShifuML/shifu/pulls/633","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/comments/282303668"},"html":{"href":"https://github.com/ShifuML/shifu/pull/633#discussion_r282303668"},"pull_request":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/633"}}},"pull_request":{"url":"https://api.github.com/repos/ShifuML/shifu/pulls/633","id":276548344,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2NTQ4MzQ0","html_url":"https://github.com/ShifuML/shifu/pull/633","diff_url":"https://github.com/ShifuML/shifu/pull/633.diff","patch_url":"https://github.com/ShifuML/shifu/pull/633.patch","issue_url":"https://api.github.com/repos/ShifuML/shifu/issues/633","number":633,"state":"open","locked":false,"title":"wdl eval support","user":{"login":"junshiguo","id":4648883,"node_id":"MDQ6VXNlcjQ2NDg4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4648883?v=4","gravatar_id":"","url":"https://api.github.com/users/junshiguo","html_url":"https://github.com/junshiguo","followers_url":"https://api.github.com/users/junshiguo/followers","following_url":"https://api.github.com/users/junshiguo/following{/other_user}","gists_url":"https://api.github.com/users/junshiguo/gists{/gist_id}","starred_url":"https://api.github.com/users/junshiguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junshiguo/subscriptions","organizations_url":"https://api.github.com/users/junshiguo/orgs","repos_url":"https://api.github.com/users/junshiguo/repos","events_url":"https://api.github.com/users/junshiguo/events{/privacy}","received_events_url":"https://api.github.com/users/junshiguo/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-07T11:00:19Z","updated_at":"2019-05-09T00:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"745f0d87c398af0983f449e5d792e3188c343e84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ShifuML/shifu/pulls/633/commits","review_comments_url":"https://api.github.com/repos/ShifuML/shifu/pulls/633/comments","review_comment_url":"https://api.github.com/repos/ShifuML/shifu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ShifuML/shifu/issues/633/comments","statuses_url":"https://api.github.com/repos/ShifuML/shifu/statuses/23d794c1b7888fdfb56b990fec6eef35e0c2f9bb","head":{"label":"junshiguo:wdl","ref":"wdl","sha":"23d794c1b7888fdfb56b990fec6eef35e0c2f9bb","user":{"login":"junshiguo","id":4648883,"node_id":"MDQ6VXNlcjQ2NDg4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4648883?v=4","gravatar_id":"","url":"https://api.github.com/users/junshiguo","html_url":"https://github.com/junshiguo","followers_url":"https://api.github.com/users/junshiguo/followers","following_url":"https://api.github.com/users/junshiguo/following{/other_user}","gists_url":"https://api.github.com/users/junshiguo/gists{/gist_id}","starred_url":"https://api.github.com/users/junshiguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junshiguo/subscriptions","organizations_url":"https://api.github.com/users/junshiguo/orgs","repos_url":"https://api.github.com/users/junshiguo/repos","events_url":"https://api.github.com/users/junshiguo/events{/privacy}","received_events_url":"https://api.github.com/users/junshiguo/received_events","type":"User","site_admin":false},"repo":{"id":101614387,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2MTQzODc=","name":"shifu","full_name":"junshiguo/shifu","private":false,"owner":{"login":"junshiguo","id":4648883,"node_id":"MDQ6VXNlcjQ2NDg4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4648883?v=4","gravatar_id":"","url":"https://api.github.com/users/junshiguo","html_url":"https://github.com/junshiguo","followers_url":"https://api.github.com/users/junshiguo/followers","following_url":"https://api.github.com/users/junshiguo/following{/other_user}","gists_url":"https://api.github.com/users/junshiguo/gists{/gist_id}","starred_url":"https://api.github.com/users/junshiguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junshiguo/subscriptions","organizations_url":"https://api.github.com/users/junshiguo/orgs","repos_url":"https://api.github.com/users/junshiguo/repos","events_url":"https://api.github.com/users/junshiguo/events{/privacy}","received_events_url":"https://api.github.com/users/junshiguo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/junshiguo/shifu","description":"An end-to-end machine learning and data mining framework on Hadoop","fork":true,"url":"https://api.github.com/repos/junshiguo/shifu","forks_url":"https://api.github.com/repos/junshiguo/shifu/forks","keys_url":"https://api.github.com/repos/junshiguo/shifu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junshiguo/shifu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junshiguo/shifu/teams","hooks_url":"https://api.github.com/repos/junshiguo/shifu/hooks","issue_events_url":"https://api.github.com/repos/junshiguo/shifu/issues/events{/number}","events_url":"https://api.github.com/repos/junshiguo/shifu/events","assignees_url":"https://api.github.com/repos/junshiguo/shifu/assignees{/user}","branches_url":"https://api.github.com/repos/junshiguo/shifu/branches{/branch}","tags_url":"https://api.github.com/repos/junshiguo/shifu/tags","blobs_url":"https://api.github.com/repos/junshiguo/shifu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junshiguo/shifu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junshiguo/shifu/git/refs{/sha}","trees_url":"https://api.github.com/repos/junshiguo/shifu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junshiguo/shifu/statuses/{sha}","languages_url":"https://api.github.com/repos/junshiguo/shifu/languages","stargazers_url":"https://api.github.com/repos/junshiguo/shifu/stargazers","contributors_url":"https://api.github.com/repos/junshiguo/shifu/contributors","subscribers_url":"https://api.github.com/repos/junshiguo/shifu/subscribers","subscription_url":"https://api.github.com/repos/junshiguo/shifu/subscription","commits_url":"https://api.github.com/repos/junshiguo/shifu/commits{/sha}","git_commits_url":"https://api.github.com/repos/junshiguo/shifu/git/commits{/sha}","comments_url":"https://api.github.com/repos/junshiguo/shifu/comments{/number}","issue_comment_url":"https://api.github.com/repos/junshiguo/shifu/issues/comments{/number}","contents_url":"https://api.github.com/repos/junshiguo/shifu/contents/{+path}","compare_url":"https://api.github.com/repos/junshiguo/shifu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junshiguo/shifu/merges","archive_url":"https://api.github.com/repos/junshiguo/shifu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junshiguo/shifu/downloads","issues_url":"https://api.github.com/repos/junshiguo/shifu/issues{/number}","pulls_url":"https://api.github.com/repos/junshiguo/shifu/pulls{/number}","milestones_url":"https://api.github.com/repos/junshiguo/shifu/milestones{/number}","notifications_url":"https://api.github.com/repos/junshiguo/shifu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junshiguo/shifu/labels{/name}","releases_url":"https://api.github.com/repos/junshiguo/shifu/releases{/id}","deployments_url":"https://api.github.com/repos/junshiguo/shifu/deployments","created_at":"2017-08-28T07:07:36Z","updated_at":"2019-04-12T03:14:49Z","pushed_at":"2019-05-07T10:59:18Z","git_url":"git://github.com/junshiguo/shifu.git","ssh_url":"git@github.com:junshiguo/shifu.git","clone_url":"https://github.com/junshiguo/shifu.git","svn_url":"https://github.com/junshiguo/shifu","homepage":"https://github.com/ShifuML/shifu/wiki","size":59173,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"ShifuML:develop","ref":"develop","sha":"0c5b6e5874318b8bebe526e58967af6cef40777c","user":{"login":"ShifuML","id":7340945,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNDA5NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7340945?v=4","gravatar_id":"","url":"https://api.github.com/users/ShifuML","html_url":"https://github.com/ShifuML","followers_url":"https://api.github.com/users/ShifuML/followers","following_url":"https://api.github.com/users/ShifuML/following{/other_user}","gists_url":"https://api.github.com/users/ShifuML/gists{/gist_id}","starred_url":"https://api.github.com/users/ShifuML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShifuML/subscriptions","organizations_url":"https://api.github.com/users/ShifuML/orgs","repos_url":"https://api.github.com/users/ShifuML/repos","events_url":"https://api.github.com/users/ShifuML/events{/privacy}","received_events_url":"https://api.github.com/users/ShifuML/received_events","type":"Organization","site_admin":false},"repo":{"id":19008910,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAwODkxMA==","name":"shifu","full_name":"ShifuML/shifu","private":false,"owner":{"login":"ShifuML","id":7340945,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNDA5NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7340945?v=4","gravatar_id":"","url":"https://api.github.com/users/ShifuML","html_url":"https://github.com/ShifuML","followers_url":"https://api.github.com/users/ShifuML/followers","following_url":"https://api.github.com/users/ShifuML/following{/other_user}","gists_url":"https://api.github.com/users/ShifuML/gists{/gist_id}","starred_url":"https://api.github.com/users/ShifuML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShifuML/subscriptions","organizations_url":"https://api.github.com/users/ShifuML/orgs","repos_url":"https://api.github.com/users/ShifuML/repos","events_url":"https://api.github.com/users/ShifuML/events{/privacy}","received_events_url":"https://api.github.com/users/ShifuML/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ShifuML/shifu","description":"An end-to-end machine learning and data mining framework on Hadoop","fork":false,"url":"https://api.github.com/repos/ShifuML/shifu","forks_url":"https://api.github.com/repos/ShifuML/shifu/forks","keys_url":"https://api.github.com/repos/ShifuML/shifu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShifuML/shifu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShifuML/shifu/teams","hooks_url":"https://api.github.com/repos/ShifuML/shifu/hooks","issue_events_url":"https://api.github.com/repos/ShifuML/shifu/issues/events{/number}","events_url":"https://api.github.com/repos/ShifuML/shifu/events","assignees_url":"https://api.github.com/repos/ShifuML/shifu/assignees{/user}","branches_url":"https://api.github.com/repos/ShifuML/shifu/branches{/branch}","tags_url":"https://api.github.com/repos/ShifuML/shifu/tags","blobs_url":"https://api.github.com/repos/ShifuML/shifu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShifuML/shifu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShifuML/shifu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShifuML/shifu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShifuML/shifu/statuses/{sha}","languages_url":"https://api.github.com/repos/ShifuML/shifu/languages","stargazers_url":"https://api.github.com/repos/ShifuML/shifu/stargazers","contributors_url":"https://api.github.com/repos/ShifuML/shifu/contributors","subscribers_url":"https://api.github.com/repos/ShifuML/shifu/subscribers","subscription_url":"https://api.github.com/repos/ShifuML/shifu/subscription","commits_url":"https://api.github.com/repos/ShifuML/shifu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShifuML/shifu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShifuML/shifu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShifuML/shifu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShifuML/shifu/contents/{+path}","compare_url":"https://api.github.com/repos/ShifuML/shifu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShifuML/shifu/merges","archive_url":"https://api.github.com/repos/ShifuML/shifu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShifuML/shifu/downloads","issues_url":"https://api.github.com/repos/ShifuML/shifu/issues{/number}","pulls_url":"https://api.github.com/repos/ShifuML/shifu/pulls{/number}","milestones_url":"https://api.github.com/repos/ShifuML/shifu/milestones{/number}","notifications_url":"https://api.github.com/repos/ShifuML/shifu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShifuML/shifu/labels{/name}","releases_url":"https://api.github.com/repos/ShifuML/shifu/releases{/id}","deployments_url":"https://api.github.com/repos/ShifuML/shifu/deployments","created_at":"2014-04-21T22:21:09Z","updated_at":"2019-05-08T06:33:30Z","pushed_at":"2019-05-08T16:37:51Z","git_url":"git://github.com/ShifuML/shifu.git","ssh_url":"git@github.com:ShifuML/shifu.git","clone_url":"https://github.com/ShifuML/shifu.git","svn_url":"https://github.com/ShifuML/shifu","homepage":"https://github.com/ShifuML/shifu/wiki","size":13708,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":176,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":84,"open_issues":176,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/633"},"html":{"href":"https://github.com/ShifuML/shifu/pull/633"},"issue":{"href":"https://api.github.com/repos/ShifuML/shifu/issues/633"},"comments":{"href":"https://api.github.com/repos/ShifuML/shifu/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/ShifuML/shifu/statuses/23d794c1b7888fdfb56b990fec6eef35e0c2f9bb"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"zhangpengshan"}}