payload: {"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/26205","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/26205/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/26205/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/26205/events","html_url":"https://github.com/cms-sw/cmssw/pull/26205","id":421943449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxODU0MzIy","number":26205,"title":"Fix v12 IO rule for HitPattern","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131220,"node_id":"MDU6TGFiZWw1NjEzMTIyMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/80","html_url":"https://github.com/cms-sw/cmssw/milestone/80","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/80/labels","id":4076143,"node_id":"MDk6TWlsZXN0b25lNDA3NjE0Mw==","number":80,"title":"CMSSW_10_6_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":146,"state":"open","created_at":"2019-02-21T13:47:27Z","updated_at":"2019-03-18T18:51:20Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2019-03-17T16:21:55Z","updated_at":"2019-03-18T20:55:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/26205","html_url":"https://github.com/cms-sw/cmssw/pull/26205","diff_url":"https://github.com/cms-sw/cmssw/pull/26205.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/26205.patch"},"body":"#### PR description:\r\n\r\nThe original rule depended on the exact order in which the different member data were filled by ROOT. The new rule explicitly tells ROOT about the dependencies between member data.\r\n\r\n#### PR validation:\r\n\r\nCompared reading a file containing a v12 version of HitPattern in both ROOT 6.12 and ROOT 6.14 versions of CMSSW_10_6. Dumped the values of the various functions of HitPattern and compared the results from both versions of ROOT. With this change, the values are identical.\r\n\r\nAdded a unit test which uses values from one of the previously failing v12 data objects.\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/474097440","html_url":"https://github.com/cms-sw/cmssw/pull/26205#issuecomment-474097440","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/26205","id":474097440,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3NDA5NzQ0MA==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2019-03-18T20:55:54Z","updated_at":"2019-03-18T20:55:54Z","author_association":"CONTRIBUTOR","body":"Comparison is ready\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26205/33639/summary.html\n\nComparison Summary:\n - No significant changes to the logs found\n - Reco comparison results: 0 differences found in the comparisons\n - DQMHistoTests: Total files compared: 32\n - DQMHistoTests: Total histograms compared: 3114829\n - DQMHistoTests: Total failures: 1\n - DQMHistoTests: Total nulls: 0\n - DQMHistoTests: Total successes: 3114631\n - DQMHistoTests: Total skipped: 197\n - DQMHistoTests: Total Missing objects: 0\n - DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)\n - Checked 133 log files, 14 edm output root files, 32 DQM output files\n"}}
other: {"actor":{"display_login":"cmsbuild"}}