payload: {"action":"created","issue":{"url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/issues/105","repository_url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl","labels_url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/issues/105/comments","events_url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/issues/105/events","html_url":"https://github.com/brailleapps/dotify.formatter.impl/pull/105","id":457943828,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5NjQ4NTkw","number":105,"title":"Why wait with calling setResolver on Evaluate and PageNumberReference?","user":{"login":"bertfrees","id":1167989,"node_id":"MDQ6VXNlcjExNjc5ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167989?v=4","gravatar_id":"","url":"https://api.github.com/users/bertfrees","html_url":"https://github.com/bertfrees","followers_url":"https://api.github.com/users/bertfrees/followers","following_url":"https://api.github.com/users/bertfrees/following{/other_user}","gists_url":"https://api.github.com/users/bertfrees/gists{/gist_id}","starred_url":"https://api.github.com/users/bertfrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertfrees/subscriptions","organizations_url":"https://api.github.com/users/bertfrees/orgs","repos_url":"https://api.github.com/users/bertfrees/repos","events_url":"https://api.github.com/users/bertfrees/events{/privacy}","received_events_url":"https://api.github.com/users/bertfrees/received_events","type":"User","site_admin":false},"labels":[{"id":1477892368,"node_id":"MDU6TGFiZWwxNDc3ODkyMzY4","url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/labels/Work%20in%20progress","name":"Work in progress","color":"fcff77","default":false}],"state":"open","locked":false,"assignee":{"login":"kalaspuffar","id":1424084,"node_id":"MDQ6VXNlcjE0MjQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1424084?v=4","gravatar_id":"","url":"https://api.github.com/users/kalaspuffar","html_url":"https://github.com/kalaspuffar","followers_url":"https://api.github.com/users/kalaspuffar/followers","following_url":"https://api.github.com/users/kalaspuffar/following{/other_user}","gists_url":"https://api.github.com/users/kalaspuffar/gists{/gist_id}","starred_url":"https://api.github.com/users/kalaspuffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalaspuffar/subscriptions","organizations_url":"https://api.github.com/users/kalaspuffar/orgs","repos_url":"https://api.github.com/users/kalaspuffar/repos","events_url":"https://api.github.com/users/kalaspuffar/events{/privacy}","received_events_url":"https://api.github.com/users/kalaspuffar/received_events","type":"User","site_admin":false},"assignees":[{"login":"kalaspuffar","id":1424084,"node_id":"MDQ6VXNlcjE0MjQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1424084?v=4","gravatar_id":"","url":"https://api.github.com/users/kalaspuffar","html_url":"https://github.com/kalaspuffar","followers_url":"https://api.github.com/users/kalaspuffar/followers","following_url":"https://api.github.com/users/kalaspuffar/following{/other_user}","gists_url":"https://api.github.com/users/kalaspuffar/gists{/gist_id}","starred_url":"https://api.github.com/users/kalaspuffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalaspuffar/subscriptions","organizations_url":"https://api.github.com/users/kalaspuffar/orgs","repos_url":"https://api.github.com/users/kalaspuffar/repos","events_url":"https://api.github.com/users/kalaspuffar/events{/privacy}","received_events_url":"https://api.github.com/users/kalaspuffar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-06-19T10:55:19Z","updated_at":"2019-08-20T09:33:15Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/pulls/105","html_url":"https://github.com/brailleapps/dotify.formatter.impl/pull/105","diff_url":"https://github.com/brailleapps/dotify.formatter.impl/pull/105.diff","patch_url":"https://github.com/brailleapps/dotify.formatter.impl/pull/105.patch"},"body":"Why wait with calling setResolver on Evaluate and PageNumberReference? This makes it impossible to \"peek\" a Evaluate or PageNumberReference segment. Instead of calling setResolver when the segments are layed out, I simply call the method when SegmentProcessor is initialized.\r\n\r\nI must have done something wrong though because I made a test fail. Do you know what's wrong?\r\n\r\n```\r\norg.daisy.dotify.formatter.test.RowByRowTest > testCurrentPage_02 FAILED\r\n    java.lang.AssertionError at RowByRowTest.java:18\r\n```"},"comment":{"url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/issues/comments/522935249","html_url":"https://github.com/brailleapps/dotify.formatter.impl/pull/105#issuecomment-522935249","issue_url":"https://api.github.com/repos/brailleapps/dotify.formatter.impl/issues/105","id":522935249,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMjkzNTI0OQ==","user":{"login":"kalaspuffar","id":1424084,"node_id":"MDQ6VXNlcjE0MjQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1424084?v=4","gravatar_id":"","url":"https://api.github.com/users/kalaspuffar","html_url":"https://github.com/kalaspuffar","followers_url":"https://api.github.com/users/kalaspuffar/followers","following_url":"https://api.github.com/users/kalaspuffar/following{/other_user}","gists_url":"https://api.github.com/users/kalaspuffar/gists{/gist_id}","starred_url":"https://api.github.com/users/kalaspuffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalaspuffar/subscriptions","organizations_url":"https://api.github.com/users/kalaspuffar/orgs","repos_url":"https://api.github.com/users/kalaspuffar/repos","events_url":"https://api.github.com/users/kalaspuffar/events{/privacy}","received_events_url":"https://api.github.com/users/kalaspuffar/received_events","type":"User","site_admin":false},"created_at":"2019-08-20T09:33:15Z","updated_at":"2019-08-20T09:33:15Z","author_association":"MEMBER","body":"Hi @bertfrees \r\n\r\nI've looked into this issue and it seems that the test actually catches the problem with page numbering before layout. We can't know the actual page numbers before layout as the data can have hard linebreaks that could create new pages.\r\n\r\n```\r\n<evaluate expression=\"(format {0} $page)\"/><br/><evaluate expression=\"(format {0} $page)\"/>\r\n```\r\n\r\nMaybe this is not an issue that the page numbers aren't 100% correct, and we could find workarounds.\r\n\r\nI'm still looking at the code but I thought I report my initial findings.\r\n\r\nBest regards\r\nDaniel"}}
other: {"actor":{"display_login":"kalaspuffar"}}