payload: {"action":"closed","number":585,"pull_request":{"url":"https://api.github.com/repos/witnet/witnet-rust/pulls/585","id":270539937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNTM5OTM3","html_url":"https://github.com/witnet/witnet-rust/pull/585","diff_url":"https://github.com/witnet/witnet-rust/pull/585.diff","patch_url":"https://github.com/witnet/witnet-rust/pull/585.patch","issue_url":"https://api.github.com/repos/witnet/witnet-rust/issues/585","number":585,"state":"closed","locked":false,"title":"refactory(clippy): fix clippy warnings","user":{"login":"anler","id":83847,"node_id":"MDQ6VXNlcjgzODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/83847?v=4","gravatar_id":"","url":"https://api.github.com/users/anler","html_url":"https://github.com/anler","followers_url":"https://api.github.com/users/anler/followers","following_url":"https://api.github.com/users/anler/following{/other_user}","gists_url":"https://api.github.com/users/anler/gists{/gist_id}","starred_url":"https://api.github.com/users/anler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anler/subscriptions","organizations_url":"https://api.github.com/users/anler/orgs","repos_url":"https://api.github.com/users/anler/repos","events_url":"https://api.github.com/users/anler/events{/privacy}","received_events_url":"https://api.github.com/users/anler/received_events","type":"User","site_admin":false},"body":"I have updated the `clippy` command inside `Justfile` to include `--alll`, and fixed all the errors.\r\n\r\n<details><summary>The errors reported by clippy</summary>\r\n<pre>\r\n    Checking witnet_util v0.2.0 (/home/anler/src/public/witnet-rust/util)\r\n    Checking witnet_crypto v0.2.0 (/home/anler/src/public/witnet-rust/crypto)\r\nwarning: long literal lacking separators\r\n   --> crypto/src/key.rs:280:29\r\n    |\r\n280 |                 ChildNumber(0x8000002c), // purpose: BIP-44\r\n    |                             ^^^^^^^^^^ help: consider: `0x8000_002c`\r\n    |\r\n    = note: #[warn(clippy::unreadable_literal)] on by default\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> crypto/src/key.rs:281:29\r\n    |\r\n281 |                 ChildNumber(0x80000000), // coin_type: Bitcoin\r\n    |                             ^^^^^^^^^^ help: consider: `0x8000_0000`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> crypto/src/key.rs:282:29\r\n    |\r\n282 |                 ChildNumber(0x80000000), // account: hardened 0\r\n    |                             ^^^^^^^^^^ help: consider: `0x8000_0000`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\n    Checking witnet_p2p v0.2.0 (/home/anler/src/public/witnet-rust/p2p)\r\n    Checking witnet_data_structures v0.2.0 (/home/anler/src/public/witnet-rust/data_structures)\r\nwarning: long literal lacking separators\r\n   --> data_structures/src/builders.rs:242:58\r\n    |\r\n242 |         assert_eq!(witnet_addr.ip, IpAddress::Ipv4 { ip: 2130706433 });\r\n    |                                                          ^^^^^^^^^^ help: consider: `2_130_706_433`\r\n    |\r\n    = note: #[warn(clippy::unreadable_literal)] on by default\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/src/builders.rs:266:39\r\n    |\r\n266 |             ip: IpAddress::Ipv4 { ip: 2130706433 },\r\n    |                                       ^^^^^^^^^^ help: consider: `2_130_706_433`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: the function has a cyclomatic complexity of 31\r\n    --> data_structures/src/data_request.rs:1203:5\r\n     |\r\n1203 | /     fn update_multiple_times() {\r\n1204 | |         // Only the first consecutive call to update_data_request_stages should change the state\r\n1205 | |         let fake_block_hash = Hash::SHA256([1; 32]);\r\n1206 | |         let epoch = 0;\r\n...    |\r\n1381 | |         assert_eq!(p.to_be_stored[0].0, dr_pointer);\r\n1382 | |     }\r\n     | |_____^\r\n     |\r\n     = note: #[warn(clippy::cyclomatic_complexity)] on by default\r\n     = help: you could split it up into multiple smaller functions\r\n     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity\r\n\r\nwarning: long literal lacking separators\r\n   --> p2p/tests/sessions.rs:279:17\r\n    |\r\n279 |     for _ in 0..100000 {\r\n    |                 ^^^^^^ help: consider: `100_000`\r\n    |\r\n    = note: #[warn(clippy::unreadable_literal)] on by default\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: manual implementation of an assign operation\r\n   --> p2p/tests/sessions.rs:282:61\r\n    |\r\n282 |             Some(reference) if reference == \"reference1\" => diff = diff + 1,\r\n    |                                                             ^^^^^^^^^^^^^^^ help: replace it with: `diff += 1`\r\n    |\r\n    = note: #[warn(clippy::assign_op_pattern)] on by default\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: manual implementation of an assign operation\r\n   --> p2p/tests/sessions.rs:283:61\r\n    |\r\n283 |             Some(reference) if reference == \"reference2\" => diff = diff - 1,\r\n    |                                                             ^^^^^^^^^^^^^^^ help: replace it with: `diff -= 1`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: assert!(false) should probably be replaced\r\n   --> p2p/tests/sessions.rs:284:18\r\n    |\r\n284 |               _ => assert!(\r\n    |  __________________^\r\n285 | |                 false,\r\n286 | |                 \"Get random function should retrieve a random session\"\r\n287 | |             ),\r\n    | |_____________^\r\n    |\r\n    = note: #[warn(clippy::assertions_on_constants)] on by default\r\n    = help: use panic!() or unreachable!()\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: the function has a cyclomatic complexity of 26\r\n   --> p2p/tests/sessions.rs:448:1\r\n    |\r\n448 | / fn p2p_sessions_consensus() {\r\n449 | |     // Create sessions struct\r\n450 | |     let mut sessions = Sessions::<String>::default();\r\n451 | |\r\n...   |\r\n520 | |     assert!(sessions.unconsensus_session(outbound_address).is_err());\r\n521 | | }\r\n    | |_^\r\n    |\r\n    = note: #[warn(clippy::cyclomatic_complexity)] on by default\r\n    = help: you could split it up into multiple smaller functions\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity\r\n\r\nwarning: long literal lacking separators\r\n  --> p2p/tests/peers.rs:69:17\r\n   |\r\n69 |     for _ in 0..100000 {\r\n   |                 ^^^^^^ help: consider: `100_000`\r\n   |\r\n   = note: #[warn(clippy::unreadable_literal)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> p2p/tests/sessions.rs:279:17\r\n    |\r\n279 |     for _ in 0..100000 {\r\n    |                 ^^^^^^ help: consider: `100_000`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: manual implementation of an assign operation\r\n  --> p2p/tests/peers.rs:72:47\r\n   |\r\n72 |             Some(addr) if addr == address1 => diff = diff + 1,\r\n   |                                               ^^^^^^^^^^^^^^^ help: replace it with: `diff += 1`\r\n   |\r\n   = note: #[warn(clippy::assign_op_pattern)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: manual implementation of an assign operation\r\n  --> p2p/tests/peers.rs:73:47\r\n   |\r\n73 |             Some(addr) if addr == address2 => diff = diff - 1,\r\n   |                                               ^^^^^^^^^^^^^^^ help: replace it with: `diff -= 1`\r\n   |\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: assert!(false) should probably be replaced\r\n  --> p2p/tests/peers.rs:74:18\r\n   |\r\n74 |               _ => assert!(\r\n   |  __________________^\r\n75 | |                 false,\r\n76 | |                 \"Get random function should retrieve a random address\"\r\n77 | |             ),\r\n   | |_____________^\r\n   |\r\n   = note: #[warn(clippy::assertions_on_constants)] on by default\r\n   = help: use panic!() or unreachable!()\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: manual implementation of an assign operation\r\n   --> p2p/tests/sessions.rs:282:61\r\n    |\r\n282 |             Some(reference) if reference == \"reference1\" => diff = diff + 1,\r\n    |                                                             ^^^^^^^^^^^^^^^ help: replace it with: `diff += 1`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: manual implementation of an assign operation\r\n   --> p2p/tests/sessions.rs:283:61\r\n    |\r\n283 |             Some(reference) if reference == \"reference2\" => diff = diff - 1,\r\n    |                                                             ^^^^^^^^^^^^^^^ help: replace it with: `diff -= 1`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: assert!(false) should probably be replaced\r\n   --> p2p/tests/sessions.rs:284:18\r\n    |\r\n284 |               _ => assert!(\r\n    |  __________________^\r\n285 | |                 false,\r\n286 | |                 \"Get random function should retrieve a random session\"\r\n287 | |             ),\r\n    | |_____________^\r\n    |\r\n    = help: use panic!() or unreachable!()\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: the function has a cyclomatic complexity of 26\r\n   --> p2p/tests/sessions.rs:448:1\r\n    |\r\n448 | / fn p2p_sessions_consensus() {\r\n449 | |     // Create sessions struct\r\n450 | |     let mut sessions = Sessions::<String>::default();\r\n451 | |\r\n...   |\r\n520 | |     assert!(sessions.unconsensus_session(outbound_address).is_err());\r\n521 | | }\r\n    | |_^\r\n    |\r\n    = note: #[warn(clippy::cyclomatic_complexity)] on by default\r\n    = help: you could split it up into multiple smaller functions\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity\r\n\r\nwarning: long literal lacking separators\r\n  --> p2p/tests/peers.rs:69:17\r\n   |\r\n69 |     for _ in 0..100000 {\r\n   |                 ^^^^^^ help: consider: `100_000`\r\n   |\r\n   = note: #[warn(clippy::unreadable_literal)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: manual implementation of an assign operation\r\n  --> p2p/tests/peers.rs:72:47\r\n   |\r\n72 |             Some(addr) if addr == address1 => diff = diff + 1,\r\n   |                                               ^^^^^^^^^^^^^^^ help: replace it with: `diff += 1`\r\n   |\r\n   = note: #[warn(clippy::assign_op_pattern)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: manual implementation of an assign operation\r\n  --> p2p/tests/peers.rs:73:47\r\n   |\r\n73 |             Some(addr) if addr == address2 => diff = diff - 1,\r\n   |                                               ^^^^^^^^^^^^^^^ help: replace it with: `diff -= 1`\r\n   |\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern\r\n\r\nwarning: assert!(false) should probably be replaced\r\n  --> p2p/tests/peers.rs:74:18\r\n   |\r\n74 |               _ => assert!(\r\n   |  __________________^\r\n75 | |                 false,\r\n76 | |                 \"Get random function should retrieve a random address\"\r\n77 | |             ),\r\n   | |_____________^\r\n   |\r\n   = note: #[warn(clippy::assertions_on_constants)] on by default\r\n   = help: use panic!() or unreachable!()\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\n    Checking witnet_rad v0.2.0 (/home/anler/src/public/witnet-rust/rad)\r\n    Checking witnet_config v0.2.0 (/home/anler/src/public/witnet-rust/config)\r\nwarning: long literal lacking separators\r\n --> data_structures/tests/proto.rs:8:35\r\n  |\r\n8 |         ip: IpAddress::Ipv4 { ip: 0x10203040 },\r\n  |                                   ^^^^^^^^^^ help: consider: `0x1020_3040`\r\n  |\r\n  = note: #[warn(clippy::unreadable_literal)] on by default\r\n  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n  --> data_structures/tests/proto.rs:20:18\r\n   |\r\n20 |             ip0: 0x10203040,\r\n   |                  ^^^^^^^^^^ help: consider: `0x1020_3040`\r\n   |\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n  --> data_structures/tests/proto.rs:23:18\r\n   |\r\n23 |             ip3: 0x11111111,\r\n   |                  ^^^^^^^^^^ help: consider: `0x1111_1111`\r\n   |\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: redundant field names in struct initialization\r\n   --> data_structures/tests/serializers.rs:297:13\r\n    |\r\n297 |             sender_address: sender_address,\r\n    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_address`\r\n    |\r\n    = note: #[warn(clippy::redundant_field_names)] on by default\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names\r\n\r\nwarning: redundant field names in struct initialization\r\n   --> data_structures/tests/serializers.rs:298:13\r\n    |\r\n298 |             receiver_address: receiver_address,\r\n    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver_address`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names\r\n\r\nwarning: redundant field names in struct initialization\r\n   --> data_structures/tests/serializers.rs:331:13\r\n    |\r\n331 |             sender_address: sender_address,\r\n    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_address`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names\r\n\r\nwarning: redundant field names in struct initialization\r\n   --> data_structures/tests/serializers.rs:332:13\r\n    |\r\n332 |             receiver_address: receiver_address,\r\n    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver_address`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names\r\n\r\nwarning: redundant field names in struct initialization\r\n   --> data_structures/tests/serializers.rs:365:13\r\n    |\r\n365 |             sender_address: sender_address,\r\n    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_address`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names\r\n\r\nwarning: redundant field names in struct initialization\r\n   --> data_structures/tests/serializers.rs:366:13\r\n    |\r\n366 |             receiver_address: receiver_address,\r\n    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver_address`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names\r\n\r\nwarning: Constants have by default a `'static` lifetime\r\n --> data_structures/tests/serializers.rs:6:30\r\n  |\r\n6 | const EXAMPLE_BLOCK_VECTOR: &'static [u8] = &[\r\n  |                             -^^^^^^^----- help: consider removing `'static`: `&[u8]`\r\n  |\r\n  = note: #[warn(clippy::const_static_lifetime)] on by default\r\n  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:184:35\r\n    |\r\n184 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = note: #[warn(clippy::unreadable_literal)] on by default\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:202:35\r\n    |\r\n202 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:221:35\r\n    |\r\n221 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:226:18\r\n    |\r\n226 |             ip0: 3232235777,\r\n    |                  ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:227:18\r\n    |\r\n227 |             ip1: 3232235776,\r\n    |                  ^^^^^^^^^^ help: consider: `3_232_235_776`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:228:18\r\n    |\r\n228 |             ip2: 3232235778,\r\n    |                  ^^^^^^^^^^ help: consider: `3_232_235_778`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:229:18\r\n    |\r\n229 |             ip3: 3232235777,\r\n    |                  ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:285:35\r\n    |\r\n285 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:289:35\r\n    |\r\n289 |         ip: IpAddress::Ipv4 { ip: 3232235778 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_778`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:319:35\r\n    |\r\n319 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:323:35\r\n    |\r\n323 |         ip: IpAddress::Ipv4 { ip: 3232235778 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_778`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:353:35\r\n    |\r\n353 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/serializers.rs:357:35\r\n    |\r\n357 |         ip: IpAddress::Ipv4 { ip: 3232235778 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_778`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n  --> data_structures/tests/builders.rs:78:35\r\n   |\r\n78 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n   |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n   |\r\n   = note: #[warn(clippy::unreadable_literal)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: All the struct fields are matched to a wildcard pattern, consider using `..`.\r\n   --> data_structures/tests/builders.rs:108:23\r\n    |\r\n108 |         Command::Ping(Ping { nonce: _ }) => assert!(true),\r\n    |                       ^^^^^^^^^^^^^^^^^\r\n    |\r\n    = note: #[warn(clippy::unneeded_field_pattern)] on by default\r\n    = help: Try with `Ping { .. }` instead\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/builders.rs:131:35\r\n    |\r\n131 |         ip: IpAddress::Ipv4 { ip: 3232235777 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_777`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: long literal lacking separators\r\n   --> data_structures/tests/builders.rs:135:35\r\n    |\r\n135 |         ip: IpAddress::Ipv4 { ip: 3232235778 },\r\n    |                                   ^^^^^^^^^^ help: consider: `3_232_235_778`\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal\r\n\r\nwarning: You matched a field with a wildcard pattern. Consider using `..` instead\r\n   --> data_structures/tests/builders.rs:168:13\r\n    |\r\n168 |             timestamp: _,\r\n    |             ^^^^^^^^^^^^\r\n    |\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern\r\n\r\nwarning: You matched a field with a wildcard pattern. Consider using `..` instead\r\n   --> data_structures/tests/builders.rs:174:13\r\n    |\r\n174 |             nonce: _,\r\n    |             ^^^^^^^^\r\n    |\r\n    = help: Try with `Version { version, capabilities, sender_address, receiver_address, user_agent, last_epoch, .. }`\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern\r\n\r\nwarning: assert!(true) will be optimized out by the compiler\r\n   --> data_structures/tests/builders.rs:108:45\r\n    |\r\n108 |         Command::Ping(Ping { nonce: _ }) => assert!(true),\r\n    |                                             ^^^^^^^^^^^^^\r\n    |\r\n    = note: #[warn(clippy::assertions_on_constants)] on by default\r\n    = help: remove it\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: assert!(false) should probably be replaced\r\n   --> data_structures/tests/builders.rs:109:14\r\n    |\r\n109 |         _ => assert!(false, \"Expected ping, found another type\"),\r\n    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n    |\r\n    = help: use panic!() or unreachable!()\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: assert!(true) will be optimized out by the compiler\r\n   --> data_structures/tests/builders.rs:182:13\r\n    |\r\n182 |             assert!(true)\r\n    |             ^^^^^^^^^^^^^\r\n    |\r\n    = help: remove it\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: assert!(false) should probably be replaced\r\n   --> data_structures/tests/builders.rs:184:14\r\n    |\r\n184 |         _ => assert!(false, \"Some field/s do not match the expected value\"),\r\n    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n    |\r\n    = help: use panic!() or unreachable!()\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants\r\n\r\nwarning: identical conversion\r\n  --> rad/src/lib.rs:96:33\r\n   |\r\n96 |     let f_1 = RadonTypes::Float(RadonFloat::from(1f64).into());\r\n   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RadonFloat::from(1f64)`\r\n   |\r\n   = note: #[warn(clippy::identity_conversion)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion\r\n\r\nwarning: identical conversion\r\n  --> rad/src/lib.rs:97:33\r\n   |\r\n97 |     let f_3 = RadonTypes::Float(RadonFloat::from(3f64).into());\r\n   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RadonFloat::from(3f64)`\r\n   |\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion\r\n\r\n    Checking witnet_validations v0.2.0 (/home/anler/src/public/witnet-rust/validations)\r\n    Checking witnet_storage v0.2.0 (/home/anler/src/public/witnet-rust/storage)\r\nwarning: you should consider deriving a `Default` implementation for `backends::rocksdb::rocksdb_mock::DB`\r\n  --> storage/src/backends/rocksdb.rs:69:9\r\n   |\r\n69 | /         pub fn new() -> Self {\r\n70 | |             DB { data: Vec::new() }\r\n71 | |         }\r\n   | |_________^\r\n   |\r\n   = note: #[warn(clippy::new_without_default)] on by default\r\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default\r\nhelp: try this\r\n   |\r\n64 |     #[derive(Default)]\r\n65 |     pub struct DB {\r\n   |\r\n\r\n    Checking witnet_node v0.2.0 (/home/anler/src/public/witnet-rust/node)\r\n    Checking witnet v0.2.0 (/home/anler/src/public/witnet-rust)\r\n    Finished dev [unoptimized + debuginfo] target(s) in 39.96s\r\n</pre>\r\n</details>\r\n\r\n<details><summary>Warnings not fixed in this PR due to oto much effort (cyclomatic complexity)</summary>\r\n<pre>\r\nChecking witnet_data_structures v0.2.0 (/home/anler/src/public/witnet-rust/data_structures)\r\nwarning: the function has a cyclomatic complexity of 31\r\n    --> data_structures/src/data_request.rs:1203:5\r\n     |\r\n1203 | /     fn update_multiple_times() {\r\n1204 | |         // Only the first consecutive call to update_data_request_stages should change the state\r\n1205 | |         let fake_block_hash = Hash::SHA256([1; 32]);\r\n1206 | |         let epoch = 0;\r\n...    |\r\n1381 | |         assert_eq!(p.to_be_stored[0].0, dr_pointer);\r\n1382 | |     }\r\n     | |_____^\r\n     |\r\n     = note: #[warn(clippy::cyclomatic_complexity)] on by default\r\n     = help: you could split it up into multiple smaller functions\r\n     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity\r\n\r\nwarning: the function has a cyclomatic complexity of 26\r\n   --> p2p/tests/sessions.rs:445:1\r\n    |\r\n445 | / fn p2p_sessions_consensus() {\r\n446 | |     // Create sessions struct\r\n447 | |     let mut sessions = Sessions::<String>::default();\r\n448 | |\r\n...   |\r\n517 | |     assert!(sessions.unconsensus_session(outbound_address).is_err());\r\n518 | | }\r\n    | |_^\r\n    |\r\n    = note: #[warn(clippy::cyclomatic_complexity)] on by default\r\n    = help: you could split it up into multiple smaller functions\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity\r\n\r\nwarning: the function has a cyclomatic complexity of 26\r\n   --> p2p/tests/sessions.rs:445:1\r\n    |\r\n445 | / fn p2p_sessions_consensus() {\r\n446 | |     // Create sessions struct\r\n447 | |     let mut sessions = Sessions::<String>::default();\r\n448 | |\r\n...   |\r\n517 | |     assert!(sessions.unconsensus_session(outbound_address).is_err());\r\n518 | | }\r\n    | |_^\r\n    |\r\n    = note: #[warn(clippy::cyclomatic_complexity)] on by default\r\n    = help: you could split it up into multiple smaller functions\r\n    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity\r\n</pre>\r\n</summary>","created_at":"2019-04-15T14:24:05Z","updated_at":"2019-04-16T08:29:10Z","closed_at":"2019-04-16T08:29:10Z","merged_at":"2019-04-16T08:29:10Z","merge_commit_sha":"3818b5810025db911bf94074175aa62f79008cd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/585/commits","review_comments_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/585/comments","review_comment_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/witnet/witnet-rust/issues/585/comments","statuses_url":"https://api.github.com/repos/witnet/witnet-rust/statuses/3818b5810025db911bf94074175aa62f79008cd9","head":{"label":"anler:clippy","ref":"clippy","sha":"3818b5810025db911bf94074175aa62f79008cd9","user":{"login":"anler","id":83847,"node_id":"MDQ6VXNlcjgzODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/83847?v=4","gravatar_id":"","url":"https://api.github.com/users/anler","html_url":"https://github.com/anler","followers_url":"https://api.github.com/users/anler/followers","following_url":"https://api.github.com/users/anler/following{/other_user}","gists_url":"https://api.github.com/users/anler/gists{/gist_id}","starred_url":"https://api.github.com/users/anler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anler/subscriptions","organizations_url":"https://api.github.com/users/anler/orgs","repos_url":"https://api.github.com/users/anler/repos","events_url":"https://api.github.com/users/anler/events{/privacy}","received_events_url":"https://api.github.com/users/anler/received_events","type":"User","site_admin":false},"repo":{"id":150262270,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyNjIyNzA=","name":"witnet-rust","full_name":"anler/witnet-rust","private":false,"owner":{"login":"anler","id":83847,"node_id":"MDQ6VXNlcjgzODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/83847?v=4","gravatar_id":"","url":"https://api.github.com/users/anler","html_url":"https://github.com/anler","followers_url":"https://api.github.com/users/anler/followers","following_url":"https://api.github.com/users/anler/following{/other_user}","gists_url":"https://api.github.com/users/anler/gists{/gist_id}","starred_url":"https://api.github.com/users/anler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anler/subscriptions","organizations_url":"https://api.github.com/users/anler/orgs","repos_url":"https://api.github.com/users/anler/repos","events_url":"https://api.github.com/users/anler/events{/privacy}","received_events_url":"https://api.github.com/users/anler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anler/witnet-rust","description":"An in-progress open source implementation of the Witnet protocol written in Rust.","fork":true,"url":"https://api.github.com/repos/anler/witnet-rust","forks_url":"https://api.github.com/repos/anler/witnet-rust/forks","keys_url":"https://api.github.com/repos/anler/witnet-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anler/witnet-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anler/witnet-rust/teams","hooks_url":"https://api.github.com/repos/anler/witnet-rust/hooks","issue_events_url":"https://api.github.com/repos/anler/witnet-rust/issues/events{/number}","events_url":"https://api.github.com/repos/anler/witnet-rust/events","assignees_url":"https://api.github.com/repos/anler/witnet-rust/assignees{/user}","branches_url":"https://api.github.com/repos/anler/witnet-rust/branches{/branch}","tags_url":"https://api.github.com/repos/anler/witnet-rust/tags","blobs_url":"https://api.github.com/repos/anler/witnet-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anler/witnet-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anler/witnet-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/anler/witnet-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anler/witnet-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/anler/witnet-rust/languages","stargazers_url":"https://api.github.com/repos/anler/witnet-rust/stargazers","contributors_url":"https://api.github.com/repos/anler/witnet-rust/contributors","subscribers_url":"https://api.github.com/repos/anler/witnet-rust/subscribers","subscription_url":"https://api.github.com/repos/anler/witnet-rust/subscription","commits_url":"https://api.github.com/repos/anler/witnet-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/anler/witnet-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/anler/witnet-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/anler/witnet-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/anler/witnet-rust/contents/{+path}","compare_url":"https://api.github.com/repos/anler/witnet-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anler/witnet-rust/merges","archive_url":"https://api.github.com/repos/anler/witnet-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anler/witnet-rust/downloads","issues_url":"https://api.github.com/repos/anler/witnet-rust/issues{/number}","pulls_url":"https://api.github.com/repos/anler/witnet-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/anler/witnet-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/anler/witnet-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anler/witnet-rust/labels{/name}","releases_url":"https://api.github.com/repos/anler/witnet-rust/releases{/id}","deployments_url":"https://api.github.com/repos/anler/witnet-rust/deployments","created_at":"2018-09-25T12:33:32Z","updated_at":"2019-04-15T14:29:48Z","pushed_at":"2019-04-16T06:43:35Z","git_url":"git://github.com/anler/witnet-rust.git","ssh_url":"git@github.com:anler/witnet-rust.git","clone_url":"https://github.com/anler/witnet-rust.git","svn_url":"https://github.com/anler/witnet-rust","homepage":"https://witnet.io","size":2600,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"witnet:master","ref":"master","sha":"79d0e2f3d432e1a8c58fad2ea14e6a897707d71b","user":{"login":"witnet","id":33759927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzU5OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33759927?v=4","gravatar_id":"","url":"https://api.github.com/users/witnet","html_url":"https://github.com/witnet","followers_url":"https://api.github.com/users/witnet/followers","following_url":"https://api.github.com/users/witnet/following{/other_user}","gists_url":"https://api.github.com/users/witnet/gists{/gist_id}","starred_url":"https://api.github.com/users/witnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witnet/subscriptions","organizations_url":"https://api.github.com/users/witnet/orgs","repos_url":"https://api.github.com/users/witnet/repos","events_url":"https://api.github.com/users/witnet/events{/privacy}","received_events_url":"https://api.github.com/users/witnet/received_events","type":"Organization","site_admin":false},"repo":{"id":120209021,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyMDkwMjE=","name":"witnet-rust","full_name":"witnet/witnet-rust","private":false,"owner":{"login":"witnet","id":33759927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzU5OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33759927?v=4","gravatar_id":"","url":"https://api.github.com/users/witnet","html_url":"https://github.com/witnet","followers_url":"https://api.github.com/users/witnet/followers","following_url":"https://api.github.com/users/witnet/following{/other_user}","gists_url":"https://api.github.com/users/witnet/gists{/gist_id}","starred_url":"https://api.github.com/users/witnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witnet/subscriptions","organizations_url":"https://api.github.com/users/witnet/orgs","repos_url":"https://api.github.com/users/witnet/repos","events_url":"https://api.github.com/users/witnet/events{/privacy}","received_events_url":"https://api.github.com/users/witnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/witnet/witnet-rust","description":"Open source implementation of Witnet decentralized oracle network protocol in Rust","fork":false,"url":"https://api.github.com/repos/witnet/witnet-rust","forks_url":"https://api.github.com/repos/witnet/witnet-rust/forks","keys_url":"https://api.github.com/repos/witnet/witnet-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/witnet/witnet-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/witnet/witnet-rust/teams","hooks_url":"https://api.github.com/repos/witnet/witnet-rust/hooks","issue_events_url":"https://api.github.com/repos/witnet/witnet-rust/issues/events{/number}","events_url":"https://api.github.com/repos/witnet/witnet-rust/events","assignees_url":"https://api.github.com/repos/witnet/witnet-rust/assignees{/user}","branches_url":"https://api.github.com/repos/witnet/witnet-rust/branches{/branch}","tags_url":"https://api.github.com/repos/witnet/witnet-rust/tags","blobs_url":"https://api.github.com/repos/witnet/witnet-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/witnet/witnet-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/witnet/witnet-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/witnet/witnet-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/witnet/witnet-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/witnet/witnet-rust/languages","stargazers_url":"https://api.github.com/repos/witnet/witnet-rust/stargazers","contributors_url":"https://api.github.com/repos/witnet/witnet-rust/contributors","subscribers_url":"https://api.github.com/repos/witnet/witnet-rust/subscribers","subscription_url":"https://api.github.com/repos/witnet/witnet-rust/subscription","commits_url":"https://api.github.com/repos/witnet/witnet-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/witnet/witnet-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/witnet/witnet-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/witnet/witnet-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/witnet/witnet-rust/contents/{+path}","compare_url":"https://api.github.com/repos/witnet/witnet-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/witnet/witnet-rust/merges","archive_url":"https://api.github.com/repos/witnet/witnet-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/witnet/witnet-rust/downloads","issues_url":"https://api.github.com/repos/witnet/witnet-rust/issues{/number}","pulls_url":"https://api.github.com/repos/witnet/witnet-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/witnet/witnet-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/witnet/witnet-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/witnet/witnet-rust/labels{/name}","releases_url":"https://api.github.com/repos/witnet/witnet-rust/releases{/id}","deployments_url":"https://api.github.com/repos/witnet/witnet-rust/deployments","created_at":"2018-02-04T17:59:46Z","updated_at":"2019-04-15T09:06:31Z","pushed_at":"2019-04-16T08:29:09Z","git_url":"git://github.com/witnet/witnet-rust.git","ssh_url":"git@github.com:witnet/witnet-rust.git","clone_url":"https://github.com/witnet/witnet-rust.git","svn_url":"https://github.com/witnet/witnet-rust","homepage":"https://docs.witnet.io","size":4853,"stargazers_count":34,"watchers_count":34,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":79,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":21,"open_issues":79,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/585"},"html":{"href":"https://github.com/witnet/witnet-rust/pull/585"},"issue":{"href":"https://api.github.com/repos/witnet/witnet-rust/issues/585"},"comments":{"href":"https://api.github.com/repos/witnet/witnet-rust/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/witnet/witnet-rust/statuses/3818b5810025db911bf94074175aa62f79008cd9"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"anler","id":83847,"node_id":"MDQ6VXNlcjgzODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/83847?v=4","gravatar_id":"","url":"https://api.github.com/users/anler","html_url":"https://github.com/anler","followers_url":"https://api.github.com/users/anler/followers","following_url":"https://api.github.com/users/anler/following{/other_user}","gists_url":"https://api.github.com/users/anler/gists{/gist_id}","starred_url":"https://api.github.com/users/anler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anler/subscriptions","organizations_url":"https://api.github.com/users/anler/orgs","repos_url":"https://api.github.com/users/anler/repos","events_url":"https://api.github.com/users/anler/events{/privacy}","received_events_url":"https://api.github.com/users/anler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":75,"deletions":86,"changed_files":11}}
other: {"actor":{"display_login":"anler"}}