payload: {"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/9336","repository_url":"https://api.github.com/repos/silverstripe/silverstripe-framework","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/9336/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/9336/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/9336/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/9336","id":528456806,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1NTE0OTI3","number":9336,"title":"MINOR: clearer distinction between class names and actual names","user":{"login":"sunnysideup","id":167154,"node_id":"MDQ6VXNlcjE2NzE1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/167154?v=4","gravatar_id":"","url":"https://api.github.com/users/sunnysideup","html_url":"https://github.com/sunnysideup","followers_url":"https://api.github.com/users/sunnysideup/followers","following_url":"https://api.github.com/users/sunnysideup/following{/other_user}","gists_url":"https://api.github.com/users/sunnysideup/gists{/gist_id}","starred_url":"https://api.github.com/users/sunnysideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunnysideup/subscriptions","organizations_url":"https://api.github.com/users/sunnysideup/orgs","repos_url":"https://api.github.com/users/sunnysideup/repos","events_url":"https://api.github.com/users/sunnysideup/events{/privacy}","received_events_url":"https://api.github.com/users/sunnysideup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-11-26T03:02:01Z","updated_at":"2019-11-26T04:52:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/9336","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/9336","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/9336.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/9336.patch"},"body":"<!--\r\nThanks for contributing, you're awesome! :star:\r\nPlease describe expected and observed behaviour, and what you're fixing.\r\nFor visual fixes, please include tested browsers and screenshots.\r\nSearch for related existing issues and link to them if possible.\r\nPlease read https://docs.silverstripe.org/en/contributing/code/\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/558459192","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/9336#issuecomment-558459192","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/9336","id":558459192,"node_id":"MDEyOklzc3VlQ29tbWVudDU1ODQ1OTE5Mg==","user":{"login":"sunnysideup","id":167154,"node_id":"MDQ6VXNlcjE2NzE1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/167154?v=4","gravatar_id":"","url":"https://api.github.com/users/sunnysideup","html_url":"https://github.com/sunnysideup","followers_url":"https://api.github.com/users/sunnysideup/followers","following_url":"https://api.github.com/users/sunnysideup/following{/other_user}","gists_url":"https://api.github.com/users/sunnysideup/gists{/gist_id}","starred_url":"https://api.github.com/users/sunnysideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunnysideup/subscriptions","organizations_url":"https://api.github.com/users/sunnysideup/orgs","repos_url":"https://api.github.com/users/sunnysideup/repos","events_url":"https://api.github.com/users/sunnysideup/events{/privacy}","received_events_url":"https://api.github.com/users/sunnysideup/received_events","type":"User","site_admin":false},"created_at":"2019-11-26T04:52:42Z","updated_at":"2019-11-26T04:52:42Z","author_association":"CONTRIBUTOR","body":"I think this is confusing:\r\n\r\n```php\r\n\r\n   private static $has_many = [\r\n       'Person' => 'Person',\r\n   ];\r\n```\r\n\r\nand should be:\r\n```php\r\n   private static $has_many = [\r\n       'Person' => Person::class,\r\n   ];\r\n```\r\n\r\nThat is all I was trying to fix."}}
other: {"actor":{"display_login":"sunnysideup"}}