payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nteract/nteract/pulls/comments/343262984","pull_request_review_id":312658315,"id":343262984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzI2Mjk4NA==","diff_hunk":"@@ -124,18 +125,30 @@ export class WidgetManager extends base.ManagerBase<DOMWidgetView> {\n     return widget;\r\n   }\r\n \r\n+  /**\r\n+   * Do not use this method. Use `render_view` instead for displaying the widget.\r\n+   *\r\n+   * This method is here because it is required to be implemented by the ManagerBase,\r\n+   * so even though it is not used, do not delete it.\r\n+   * @param msg\r\n+   * @param view\r\n+   * @param options\r\n+   */\r\n   display_view(\r\n     msg: KernelMessage.IMessage,\r\n     view: base.DOMWidgetView,\r\n     options: any\r\n   ): Promise<base.DOMWidgetView> {\r\n-    this.render_view(view);\r\n-    return Promise.resolve(view);\r\n+    throw Error(\"display_view not implemented. Use render_view instead.\");\r\n   }\r\n \r\n-  render_view(view: base.DOMWidgetView): void {\r\n-    view.render();\r\n-    view.trigger(\"displayed\");\r\n+  /**\r\n+   * Render the given view to a target element\r\n+   * @param view View to be rendered\r\n+   * @param el Target element that the view will be rendered within\r\n+   */\r\n+  render_view(view: base.DOMWidgetView, el: HTMLElement): void {\r\n+    pWidget.Widget.attach(view.pWidget, el);\r","path":"packages/jupyter-widgets/src/manager/widget-manager.ts","position":40,"original_position":40,"commit_id":"e236f8ea64cfbcefc533e12ae52877edc9b6d701","original_commit_id":"e236f8ea64cfbcefc533e12ae52877edc9b6d701","user":{"login":"miduncan","id":55718965,"node_id":"MDQ6VXNlcjU1NzE4OTY1","avatar_url":"https://avatars3.githubusercontent.com/u/55718965?v=4","gravatar_id":"","url":"https://api.github.com/users/miduncan","html_url":"https://github.com/miduncan","followers_url":"https://api.github.com/users/miduncan/followers","following_url":"https://api.github.com/users/miduncan/following{/other_user}","gists_url":"https://api.github.com/users/miduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/miduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miduncan/subscriptions","organizations_url":"https://api.github.com/users/miduncan/orgs","repos_url":"https://api.github.com/users/miduncan/repos","events_url":"https://api.github.com/users/miduncan/events{/privacy}","received_events_url":"https://api.github.com/users/miduncan/received_events","type":"User","site_admin":false},"body":"I take that back-- I don't really know the whole picture. What negatives does the existing Phosphor dependency bring with it?","created_at":"2019-11-06T18:43:36Z","updated_at":"2019-11-06T18:43:36Z","html_url":"https://github.com/nteract/nteract/pull/4678#discussion_r343262984","pull_request_url":"https://api.github.com/repos/nteract/nteract/pulls/4678","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments/343262984"},"html":{"href":"https://github.com/nteract/nteract/pull/4678#discussion_r343262984"},"pull_request":{"href":"https://api.github.com/repos/nteract/nteract/pulls/4678"}},"in_reply_to_id":343182672},"pull_request":{"url":"https://api.github.com/repos/nteract/nteract/pulls/4678","id":337119160,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3MTE5MTYw","html_url":"https://github.com/nteract/nteract/pull/4678","diff_url":"https://github.com/nteract/nteract/pull/4678.diff","patch_url":"https://github.com/nteract/nteract/pull/4678.patch","issue_url":"https://api.github.com/repos/nteract/nteract/issues/4678","number":4678,"state":"open","locked":false,"title":"Fix for Box based widgets","user":{"login":"miduncan","id":55718965,"node_id":"MDQ6VXNlcjU1NzE4OTY1","avatar_url":"https://avatars3.githubusercontent.com/u/55718965?v=4","gravatar_id":"","url":"https://api.github.com/users/miduncan","html_url":"https://github.com/miduncan","followers_url":"https://api.github.com/users/miduncan/followers","following_url":"https://api.github.com/users/miduncan/following{/other_user}","gists_url":"https://api.github.com/users/miduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/miduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miduncan/subscriptions","organizations_url":"https://api.github.com/users/miduncan/orgs","repos_url":"https://api.github.com/users/miduncan/repos","events_url":"https://api.github.com/users/miduncan/events{/privacy}","received_events_url":"https://api.github.com/users/miduncan/received_events","type":"User","site_admin":false},"body":"Fixes #4640 \r\n```\r\nimport ipywidgets as widgets\r\nitems = [widgets.IntSlider() for i in range(4)]\r\nwidgets.Box(items)\r\n```\r\nnow outputs\r\n![image](https://user-images.githubusercontent.com/55718965/68259845-db1eb480-ffef-11e9-89bb-066e7af1dd42.png)\r\n","created_at":"2019-11-06T01:13:43Z","updated_at":"2019-11-06T18:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5cc9ed107abd87d7d2bf445b4ec29804e54e25f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rgbkrk","id":836375,"node_id":"MDQ6VXNlcjgzNjM3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":533704505,"node_id":"MDU6TGFiZWw1MzM3MDQ1MDU=","url":"https://api.github.com/repos/nteract/nteract/labels/jupyter-widgets","name":"jupyter-widgets","color":"ff7619","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/nteract/pulls/4678/commits","review_comments_url":"https://api.github.com/repos/nteract/nteract/pulls/4678/comments","review_comment_url":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/nteract/issues/4678/comments","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/e236f8ea64cfbcefc533e12ae52877edc9b6d701","head":{"label":"nteract:miduncan/widget-boxes","ref":"miduncan/widget-boxes","sha":"e236f8ea64cfbcefc533e12ae52877edc9b6d701","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ5NjUyMQ==","name":"nteract","full_name":"nteract/nteract","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/nteract","description":"📘 The interactive computing suite for you!  ✨","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2019-11-06T16:56:59Z","pushed_at":"2019-11-06T17:19:35Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":30461,"stargazers_count":4509,"watchers_count":4509,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":437,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":289,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":437,"open_issues":289,"watchers":4509,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"8b150a4151578ed4ed69b116f98147d4e223f2a1","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ5NjUyMQ==","name":"nteract","full_name":"nteract/nteract","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/nteract","description":"📘 The interactive computing suite for you!  ✨","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2019-11-06T16:56:59Z","pushed_at":"2019-11-06T17:19:35Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":30461,"stargazers_count":4509,"watchers_count":4509,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":437,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":289,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":437,"open_issues":289,"watchers":4509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/4678"},"html":{"href":"https://github.com/nteract/nteract/pull/4678"},"issue":{"href":"https://api.github.com/repos/nteract/nteract/issues/4678"},"comments":{"href":"https://api.github.com/repos/nteract/nteract/issues/4678/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/nteract/pulls/4678/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/nteract/pulls/4678/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/nteract/statuses/e236f8ea64cfbcefc533e12ae52877edc9b6d701"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"miduncan"}}