payload: {"action":"created","comment":{"url":"https://api.github.com/repos/IanGRap/Squish/pulls/comments/276394993","pull_request_review_id":227948232,"id":276394993,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjM5NDk5Mw==","diff_hunk":"@@ -0,0 +1,30 @@\n+﻿using System.Collections;\n+using System.Collections.Generic;\n+using UnityEngine;\n+\n+public class CameraTracker : MonoBehaviour\n+{\n+    [SerializeField]\n+    private float _cameraTrackYCoordinate = 8f;\n+\n+    private bool _hasBeenAdded = false;\n+    private WaitForSeconds _wait = new WaitForSeconds(0.5f);\n+\n+    private void Start()\n+    {\n+        StartCoroutine(AddToCameraManager());\n+    }\n+\n+    private IEnumerator AddToCameraManager()\n+    {\n+        while (!_hasBeenAdded)\n+        {\n+            if (transform.position.y <= _cameraTrackYCoordinate)\n+            {\n+                CameraManager.Instance.AddTrackedTransform(gameObject.transform);\n+                _hasBeenAdded = true;\n+            }\n+            yield return _wait;\n+        }\n+    }\n+}","path":"Assets/Scripts/Blocks/CameraTracker.cs","position":30,"original_position":30,"commit_id":"088faea60297cb51714997aad3e401db3eb24f4d","original_commit_id":"088faea60297cb51714997aad3e401db3eb24f4d","user":{"login":"IanGRap","id":17092690,"node_id":"MDQ6VXNlcjE3MDkyNjkw","avatar_url":"https://avatars0.githubusercontent.com/u/17092690?v=4","gravatar_id":"","url":"https://api.github.com/users/IanGRap","html_url":"https://github.com/IanGRap","followers_url":"https://api.github.com/users/IanGRap/followers","following_url":"https://api.github.com/users/IanGRap/following{/other_user}","gists_url":"https://api.github.com/users/IanGRap/gists{/gist_id}","starred_url":"https://api.github.com/users/IanGRap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanGRap/subscriptions","organizations_url":"https://api.github.com/users/IanGRap/orgs","repos_url":"https://api.github.com/users/IanGRap/repos","events_url":"https://api.github.com/users/IanGRap/events{/privacy}","received_events_url":"https://api.github.com/users/IanGRap/received_events","type":"User","site_admin":false},"body":"okay that sounds like a good concern. Can we still move this code to a respawn block related function?","created_at":"2019-04-17T19:17:21Z","updated_at":"2019-04-17T19:17:21Z","html_url":"https://github.com/IanGRap/Squish/pull/152#discussion_r276394993","pull_request_url":"https://api.github.com/repos/IanGRap/Squish/pulls/152","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/IanGRap/Squish/pulls/comments/276394993"},"html":{"href":"https://github.com/IanGRap/Squish/pull/152#discussion_r276394993"},"pull_request":{"href":"https://api.github.com/repos/IanGRap/Squish/pulls/152"}},"in_reply_to_id":276375027},"pull_request":{"url":"https://api.github.com/repos/IanGRap/Squish/pulls/152","id":271152513,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxMTUyNTEz","html_url":"https://github.com/IanGRap/Squish/pull/152","diff_url":"https://github.com/IanGRap/Squish/pull/152.diff","patch_url":"https://github.com/IanGRap/Squish/pull/152.patch","issue_url":"https://api.github.com/repos/IanGRap/Squish/issues/152","number":152,"state":"open","locked":false,"title":"Respawn as block","user":{"login":"AustinKellar","id":28333213,"node_id":"MDQ6VXNlcjI4MzMzMjEz","avatar_url":"https://avatars3.githubusercontent.com/u/28333213?v=4","gravatar_id":"","url":"https://api.github.com/users/AustinKellar","html_url":"https://github.com/AustinKellar","followers_url":"https://api.github.com/users/AustinKellar/followers","following_url":"https://api.github.com/users/AustinKellar/following{/other_user}","gists_url":"https://api.github.com/users/AustinKellar/gists{/gist_id}","starred_url":"https://api.github.com/users/AustinKellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AustinKellar/subscriptions","organizations_url":"https://api.github.com/users/AustinKellar/orgs","repos_url":"https://api.github.com/users/AustinKellar/repos","events_url":"https://api.github.com/users/AustinKellar/events{/privacy}","received_events_url":"https://api.github.com/users/AustinKellar/received_events","type":"User","site_admin":false},"body":"Contributors: Austin, James\r\n\r\nGoal:\r\nCreate a system where players have a chance to respawn after they die. \r\n\r\nWhat Changed:\r\n- BlockDamager.cs\r\n    - Added logic to the Break() function so that the block spawns a player if it is a RespawnBlock and it squished another player before being destroyed\r\n    - In Update, if the block is a RespawnBlock and FallingPathBlocked() is true, then destroy the block\r\n- Spawner.cs\r\n    - Added a list (which functions as a queue) to store the players waiting to be spawned as a block. \r\n    - When there is a player waiting to respawn, regular block spawning is paused while the Spawner spawns respawn blocks\r\n- MatchManager.cs\r\n    - Added logic for _undoing_ a player death. I.E. added a function to add a player back into _alivePlayers\r\n- PlayerSquishDetector.cs\r\n    - When a player gets squished, if they were squished by a respawn block, tell the respawn block that it killed a player, so that it knows to spawn in a new one.\r\n- PlayerSpawnBeam.cs\r\n    - Contains logic for the beam of light when a player spawns in\r\n- BlockInput.cs\r\n    - Listens for controller input and moves respawn blocks\r\n- CameraTracker.cs\r\n    - Controls when the respawn block gets added to the camera manager\r\n\r\nHow to Test:\r\n- Load up the match scene and die. You should see a respawn block spawn in after ~3 seconds\r\n- Make sure you can control the respawn block with controllers\r\n- Make sure that respawn blocks can squish players\r\n- Make sure respawn blocks CANNOT push other blocks\r\n- Make sure respawn blocks are destroyed once they stop falling\r\n- Make sure that if a respawn block kills a player, it spawns in a new one of the correct color and controller input\r\n- Change the Respawn Delay value on the Block Spawner. This changes the minimum delay time between player death and when they respawn as a block\r\n- Change the Camera Track Y Coordinate value on the CameraTracker component of the respawn block prefab. This field describes the height at which the camera starts tracking respawn blocks\r\n\r\nPRO TIP:\r\n- This feature is way easier to test if you reduce the block spawning rate. Players don't tend to live long enough with the current spawn rate, at least when nobody is controlling them.","created_at":"2019-04-17T04:27:43Z","updated_at":"2019-04-17T19:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa7fb80e8ee893a9a566a4702601d575fb926319","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IanGRap/Squish/pulls/152/commits","review_comments_url":"https://api.github.com/repos/IanGRap/Squish/pulls/152/comments","review_comment_url":"https://api.github.com/repos/IanGRap/Squish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IanGRap/Squish/issues/152/comments","statuses_url":"https://api.github.com/repos/IanGRap/Squish/statuses/088faea60297cb51714997aad3e401db3eb24f4d","head":{"label":"IanGRap:respawn-as-block","ref":"respawn-as-block","sha":"088faea60297cb51714997aad3e401db3eb24f4d","user":{"login":"IanGRap","id":17092690,"node_id":"MDQ6VXNlcjE3MDkyNjkw","avatar_url":"https://avatars0.githubusercontent.com/u/17092690?v=4","gravatar_id":"","url":"https://api.github.com/users/IanGRap","html_url":"https://github.com/IanGRap","followers_url":"https://api.github.com/users/IanGRap/followers","following_url":"https://api.github.com/users/IanGRap/following{/other_user}","gists_url":"https://api.github.com/users/IanGRap/gists{/gist_id}","starred_url":"https://api.github.com/users/IanGRap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanGRap/subscriptions","organizations_url":"https://api.github.com/users/IanGRap/orgs","repos_url":"https://api.github.com/users/IanGRap/repos","events_url":"https://api.github.com/users/IanGRap/events{/privacy}","received_events_url":"https://api.github.com/users/IanGRap/received_events","type":"User","site_admin":false},"repo":{"id":154387094,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzODcwOTQ=","name":"Squish","full_name":"IanGRap/Squish","private":false,"owner":{"login":"IanGRap","id":17092690,"node_id":"MDQ6VXNlcjE3MDkyNjkw","avatar_url":"https://avatars0.githubusercontent.com/u/17092690?v=4","gravatar_id":"","url":"https://api.github.com/users/IanGRap","html_url":"https://github.com/IanGRap","followers_url":"https://api.github.com/users/IanGRap/followers","following_url":"https://api.github.com/users/IanGRap/following{/other_user}","gists_url":"https://api.github.com/users/IanGRap/gists{/gist_id}","starred_url":"https://api.github.com/users/IanGRap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanGRap/subscriptions","organizations_url":"https://api.github.com/users/IanGRap/orgs","repos_url":"https://api.github.com/users/IanGRap/repos","events_url":"https://api.github.com/users/IanGRap/events{/privacy}","received_events_url":"https://api.github.com/users/IanGRap/received_events","type":"User","site_admin":false},"html_url":"https://github.com/IanGRap/Squish","description":null,"fork":false,"url":"https://api.github.com/repos/IanGRap/Squish","forks_url":"https://api.github.com/repos/IanGRap/Squish/forks","keys_url":"https://api.github.com/repos/IanGRap/Squish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IanGRap/Squish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IanGRap/Squish/teams","hooks_url":"https://api.github.com/repos/IanGRap/Squish/hooks","issue_events_url":"https://api.github.com/repos/IanGRap/Squish/issues/events{/number}","events_url":"https://api.github.com/repos/IanGRap/Squish/events","assignees_url":"https://api.github.com/repos/IanGRap/Squish/assignees{/user}","branches_url":"https://api.github.com/repos/IanGRap/Squish/branches{/branch}","tags_url":"https://api.github.com/repos/IanGRap/Squish/tags","blobs_url":"https://api.github.com/repos/IanGRap/Squish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IanGRap/Squish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IanGRap/Squish/git/refs{/sha}","trees_url":"https://api.github.com/repos/IanGRap/Squish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IanGRap/Squish/statuses/{sha}","languages_url":"https://api.github.com/repos/IanGRap/Squish/languages","stargazers_url":"https://api.github.com/repos/IanGRap/Squish/stargazers","contributors_url":"https://api.github.com/repos/IanGRap/Squish/contributors","subscribers_url":"https://api.github.com/repos/IanGRap/Squish/subscribers","subscription_url":"https://api.github.com/repos/IanGRap/Squish/subscription","commits_url":"https://api.github.com/repos/IanGRap/Squish/commits{/sha}","git_commits_url":"https://api.github.com/repos/IanGRap/Squish/git/commits{/sha}","comments_url":"https://api.github.com/repos/IanGRap/Squish/comments{/number}","issue_comment_url":"https://api.github.com/repos/IanGRap/Squish/issues/comments{/number}","contents_url":"https://api.github.com/repos/IanGRap/Squish/contents/{+path}","compare_url":"https://api.github.com/repos/IanGRap/Squish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IanGRap/Squish/merges","archive_url":"https://api.github.com/repos/IanGRap/Squish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IanGRap/Squish/downloads","issues_url":"https://api.github.com/repos/IanGRap/Squish/issues{/number}","pulls_url":"https://api.github.com/repos/IanGRap/Squish/pulls{/number}","milestones_url":"https://api.github.com/repos/IanGRap/Squish/milestones{/number}","notifications_url":"https://api.github.com/repos/IanGRap/Squish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IanGRap/Squish/labels{/name}","releases_url":"https://api.github.com/repos/IanGRap/Squish/releases{/id}","deployments_url":"https://api.github.com/repos/IanGRap/Squish/deployments","created_at":"2018-10-23T19:43:59Z","updated_at":"2019-04-16T20:44:21Z","pushed_at":"2019-04-17T17:33:57Z","git_url":"git://github.com/IanGRap/Squish.git","ssh_url":"git@github.com:IanGRap/Squish.git","clone_url":"https://github.com/IanGRap/Squish.git","svn_url":"https://github.com/IanGRap/Squish","homepage":null,"size":150723,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":null,"forks":0,"open_issues":20,"watchers":1,"default_branch":"development"}},"base":{"label":"IanGRap:development","ref":"development","sha":"b13302c89d7549b8dd7fedc3c033f9559a0777fc","user":{"login":"IanGRap","id":17092690,"node_id":"MDQ6VXNlcjE3MDkyNjkw","avatar_url":"https://avatars0.githubusercontent.com/u/17092690?v=4","gravatar_id":"","url":"https://api.github.com/users/IanGRap","html_url":"https://github.com/IanGRap","followers_url":"https://api.github.com/users/IanGRap/followers","following_url":"https://api.github.com/users/IanGRap/following{/other_user}","gists_url":"https://api.github.com/users/IanGRap/gists{/gist_id}","starred_url":"https://api.github.com/users/IanGRap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanGRap/subscriptions","organizations_url":"https://api.github.com/users/IanGRap/orgs","repos_url":"https://api.github.com/users/IanGRap/repos","events_url":"https://api.github.com/users/IanGRap/events{/privacy}","received_events_url":"https://api.github.com/users/IanGRap/received_events","type":"User","site_admin":false},"repo":{"id":154387094,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzODcwOTQ=","name":"Squish","full_name":"IanGRap/Squish","private":false,"owner":{"login":"IanGRap","id":17092690,"node_id":"MDQ6VXNlcjE3MDkyNjkw","avatar_url":"https://avatars0.githubusercontent.com/u/17092690?v=4","gravatar_id":"","url":"https://api.github.com/users/IanGRap","html_url":"https://github.com/IanGRap","followers_url":"https://api.github.com/users/IanGRap/followers","following_url":"https://api.github.com/users/IanGRap/following{/other_user}","gists_url":"https://api.github.com/users/IanGRap/gists{/gist_id}","starred_url":"https://api.github.com/users/IanGRap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanGRap/subscriptions","organizations_url":"https://api.github.com/users/IanGRap/orgs","repos_url":"https://api.github.com/users/IanGRap/repos","events_url":"https://api.github.com/users/IanGRap/events{/privacy}","received_events_url":"https://api.github.com/users/IanGRap/received_events","type":"User","site_admin":false},"html_url":"https://github.com/IanGRap/Squish","description":null,"fork":false,"url":"https://api.github.com/repos/IanGRap/Squish","forks_url":"https://api.github.com/repos/IanGRap/Squish/forks","keys_url":"https://api.github.com/repos/IanGRap/Squish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IanGRap/Squish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IanGRap/Squish/teams","hooks_url":"https://api.github.com/repos/IanGRap/Squish/hooks","issue_events_url":"https://api.github.com/repos/IanGRap/Squish/issues/events{/number}","events_url":"https://api.github.com/repos/IanGRap/Squish/events","assignees_url":"https://api.github.com/repos/IanGRap/Squish/assignees{/user}","branches_url":"https://api.github.com/repos/IanGRap/Squish/branches{/branch}","tags_url":"https://api.github.com/repos/IanGRap/Squish/tags","blobs_url":"https://api.github.com/repos/IanGRap/Squish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IanGRap/Squish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IanGRap/Squish/git/refs{/sha}","trees_url":"https://api.github.com/repos/IanGRap/Squish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IanGRap/Squish/statuses/{sha}","languages_url":"https://api.github.com/repos/IanGRap/Squish/languages","stargazers_url":"https://api.github.com/repos/IanGRap/Squish/stargazers","contributors_url":"https://api.github.com/repos/IanGRap/Squish/contributors","subscribers_url":"https://api.github.com/repos/IanGRap/Squish/subscribers","subscription_url":"https://api.github.com/repos/IanGRap/Squish/subscription","commits_url":"https://api.github.com/repos/IanGRap/Squish/commits{/sha}","git_commits_url":"https://api.github.com/repos/IanGRap/Squish/git/commits{/sha}","comments_url":"https://api.github.com/repos/IanGRap/Squish/comments{/number}","issue_comment_url":"https://api.github.com/repos/IanGRap/Squish/issues/comments{/number}","contents_url":"https://api.github.com/repos/IanGRap/Squish/contents/{+path}","compare_url":"https://api.github.com/repos/IanGRap/Squish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IanGRap/Squish/merges","archive_url":"https://api.github.com/repos/IanGRap/Squish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IanGRap/Squish/downloads","issues_url":"https://api.github.com/repos/IanGRap/Squish/issues{/number}","pulls_url":"https://api.github.com/repos/IanGRap/Squish/pulls{/number}","milestones_url":"https://api.github.com/repos/IanGRap/Squish/milestones{/number}","notifications_url":"https://api.github.com/repos/IanGRap/Squish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IanGRap/Squish/labels{/name}","releases_url":"https://api.github.com/repos/IanGRap/Squish/releases{/id}","deployments_url":"https://api.github.com/repos/IanGRap/Squish/deployments","created_at":"2018-10-23T19:43:59Z","updated_at":"2019-04-16T20:44:21Z","pushed_at":"2019-04-17T17:33:57Z","git_url":"git://github.com/IanGRap/Squish.git","ssh_url":"git@github.com:IanGRap/Squish.git","clone_url":"https://github.com/IanGRap/Squish.git","svn_url":"https://github.com/IanGRap/Squish","homepage":null,"size":150723,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":null,"forks":0,"open_issues":20,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/IanGRap/Squish/pulls/152"},"html":{"href":"https://github.com/IanGRap/Squish/pull/152"},"issue":{"href":"https://api.github.com/repos/IanGRap/Squish/issues/152"},"comments":{"href":"https://api.github.com/repos/IanGRap/Squish/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/IanGRap/Squish/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/IanGRap/Squish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IanGRap/Squish/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/IanGRap/Squish/statuses/088faea60297cb51714997aad3e401db3eb24f4d"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"IanGRap"}}