payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rclpy/pulls/comments/344913424","pull_request_review_id":315161768,"id":344913424,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDkxMzQyNA==","diff_hunk":"@@ -44,6 +50,17 @@\n TEST_RESOURCES_DIR = pathlib.Path(__file__).resolve().parent / 'resources' / 'test_node'\n \n \n+def are_qos_equal(qos_profile, qos_dict):\n+    # depth and history are skipped because they are not retrieved.","path":"rclpy/test/test_node.py","position":25,"original_position":25,"commit_id":"d5986c97ac96fc1110c8e18a5e27f44395d1049b","original_commit_id":"d5986c97ac96fc1110c8e18a5e27f44395d1049b","user":{"login":"piraka9011","id":16828657,"node_id":"MDQ6VXNlcjE2ODI4NjU3","avatar_url":"https://avatars2.githubusercontent.com/u/16828657?v=4","gravatar_id":"","url":"https://api.github.com/users/piraka9011","html_url":"https://github.com/piraka9011","followers_url":"https://api.github.com/users/piraka9011/followers","following_url":"https://api.github.com/users/piraka9011/following{/other_user}","gists_url":"https://api.github.com/users/piraka9011/gists{/gist_id}","starred_url":"https://api.github.com/users/piraka9011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piraka9011/subscriptions","organizations_url":"https://api.github.com/users/piraka9011/orgs","repos_url":"https://api.github.com/users/piraka9011/repos","events_url":"https://api.github.com/users/piraka9011/events{/privacy}","received_events_url":"https://api.github.com/users/piraka9011/received_events","type":"User","site_admin":false},"body":"nit: start sentence with capital","created_at":"2019-11-11T21:17:24Z","updated_at":"2019-11-11T21:17:24Z","html_url":"https://github.com/ros2/rclpy/pull/454#discussion_r344913424","pull_request_url":"https://api.github.com/repos/ros2/rclpy/pulls/454","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ros2/rclpy/pulls/comments/344913424"},"html":{"href":"https://github.com/ros2/rclpy/pull/454#discussion_r344913424"},"pull_request":{"href":"https://api.github.com/repos/ros2/rclpy/pulls/454"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rclpy/pulls/454","id":333853305,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzODUzMzA1","html_url":"https://github.com/ros2/rclpy/pull/454","diff_url":"https://github.com/ros2/rclpy/pull/454.diff","patch_url":"https://github.com/ros2/rclpy/pull/454.patch","issue_url":"https://api.github.com/repos/ros2/rclpy/issues/454","number":454,"state":"open","locked":false,"title":"Implement functions to get publisher and subcription informations like QoS policies from topic name","user":{"login":"jaisontj","id":13097323,"node_id":"MDQ6VXNlcjEzMDk3MzIz","avatar_url":"https://avatars2.githubusercontent.com/u/13097323?v=4","gravatar_id":"","url":"https://api.github.com/users/jaisontj","html_url":"https://github.com/jaisontj","followers_url":"https://api.github.com/users/jaisontj/followers","following_url":"https://api.github.com/users/jaisontj/following{/other_user}","gists_url":"https://api.github.com/users/jaisontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jaisontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaisontj/subscriptions","organizations_url":"https://api.github.com/users/jaisontj/orgs","repos_url":"https://api.github.com/users/jaisontj/repos","events_url":"https://api.github.com/users/jaisontj/events{/privacy}","received_events_url":"https://api.github.com/users/jaisontj/received_events","type":"User","site_admin":false},"body":"**NOTE: DO NOT MERGE until [rmw #186](https://github.com/ros2/rmw/pull/186),  [rmw_implementation #72](https://github.com/ros2/rmw_implementation/pull/72) and [rcl #511](https://github.com/ros2/rcl/pull/511) are merged.**\r\n\r\nThis PR makes the necessary changes to implement [this](https://github.com/ros2/rmw/issues/151) feature request. The `RCLPY` layer needs to expose functions to the `ros2cli` layer such that `ros2 topic info <topic_name>` can display publisher and subscriptions information for the given `topic_name`.\r\n\r\nSummary of changes:\r\n- Added a new helper function in `common.h/c` to convert `rmw_topic_info_array_t` to a Python list of dictionaries.\r\n- Added  `get_publishers_info_by_topic` and `get_subscriptions_info_by_topic` in `node.py`\r\n- Added  `rclpy_get_publishers_info_by_topic` and\r\n`rclpy_get_subscriptions_information_by_topic` in `_rclpy.c`\r\n- Added tests for `node.get_publishers_info_by_topic` and\r\n`node.get_subscriptions_info_by_topic`\r\n\r\nRelated to issues in aws-roadmap [#85](https://github.com/ros-security/aws-roadmap/issues/85)","created_at":"2019-10-29T20:22:33Z","updated_at":"2019-11-11T21:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63de5c5615ae7ab80bf35f8f2e610bdd6967186a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rclpy/pulls/454/commits","review_comments_url":"https://api.github.com/repos/ros2/rclpy/pulls/454/comments","review_comment_url":"https://api.github.com/repos/ros2/rclpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rclpy/issues/454/comments","statuses_url":"https://api.github.com/repos/ros2/rclpy/statuses/d5986c97ac96fc1110c8e18a5e27f44395d1049b","head":{"label":"aws-ros-dev:jaisontj/impl_qos_in_topic_info","ref":"jaisontj/impl_qos_in_topic_info","sha":"d5986c97ac96fc1110c8e18a5e27f44395d1049b","user":{"login":"aws-ros-dev","id":50376863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzc2ODYz","avatar_url":"https://avatars3.githubusercontent.com/u/50376863?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-ros-dev","html_url":"https://github.com/aws-ros-dev","followers_url":"https://api.github.com/users/aws-ros-dev/followers","following_url":"https://api.github.com/users/aws-ros-dev/following{/other_user}","gists_url":"https://api.github.com/users/aws-ros-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-ros-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-ros-dev/subscriptions","organizations_url":"https://api.github.com/users/aws-ros-dev/orgs","repos_url":"https://api.github.com/users/aws-ros-dev/repos","events_url":"https://api.github.com/users/aws-ros-dev/events{/privacy}","received_events_url":"https://api.github.com/users/aws-ros-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":175093935,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUwOTM5MzU=","name":"rclpy","full_name":"aws-ros-dev/rclpy","private":false,"owner":{"login":"aws-ros-dev","id":50376863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzc2ODYz","avatar_url":"https://avatars3.githubusercontent.com/u/50376863?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-ros-dev","html_url":"https://github.com/aws-ros-dev","followers_url":"https://api.github.com/users/aws-ros-dev/followers","following_url":"https://api.github.com/users/aws-ros-dev/following{/other_user}","gists_url":"https://api.github.com/users/aws-ros-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-ros-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-ros-dev/subscriptions","organizations_url":"https://api.github.com/users/aws-ros-dev/orgs","repos_url":"https://api.github.com/users/aws-ros-dev/repos","events_url":"https://api.github.com/users/aws-ros-dev/events{/privacy}","received_events_url":"https://api.github.com/users/aws-ros-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws-ros-dev/rclpy","description":"This is a development fork. Do not pull from this repo.","fork":true,"url":"https://api.github.com/repos/aws-ros-dev/rclpy","forks_url":"https://api.github.com/repos/aws-ros-dev/rclpy/forks","keys_url":"https://api.github.com/repos/aws-ros-dev/rclpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws-ros-dev/rclpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws-ros-dev/rclpy/teams","hooks_url":"https://api.github.com/repos/aws-ros-dev/rclpy/hooks","issue_events_url":"https://api.github.com/repos/aws-ros-dev/rclpy/issues/events{/number}","events_url":"https://api.github.com/repos/aws-ros-dev/rclpy/events","assignees_url":"https://api.github.com/repos/aws-ros-dev/rclpy/assignees{/user}","branches_url":"https://api.github.com/repos/aws-ros-dev/rclpy/branches{/branch}","tags_url":"https://api.github.com/repos/aws-ros-dev/rclpy/tags","blobs_url":"https://api.github.com/repos/aws-ros-dev/rclpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws-ros-dev/rclpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws-ros-dev/rclpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws-ros-dev/rclpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws-ros-dev/rclpy/statuses/{sha}","languages_url":"https://api.github.com/repos/aws-ros-dev/rclpy/languages","stargazers_url":"https://api.github.com/repos/aws-ros-dev/rclpy/stargazers","contributors_url":"https://api.github.com/repos/aws-ros-dev/rclpy/contributors","subscribers_url":"https://api.github.com/repos/aws-ros-dev/rclpy/subscribers","subscription_url":"https://api.github.com/repos/aws-ros-dev/rclpy/subscription","commits_url":"https://api.github.com/repos/aws-ros-dev/rclpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws-ros-dev/rclpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws-ros-dev/rclpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws-ros-dev/rclpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws-ros-dev/rclpy/contents/{+path}","compare_url":"https://api.github.com/repos/aws-ros-dev/rclpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws-ros-dev/rclpy/merges","archive_url":"https://api.github.com/repos/aws-ros-dev/rclpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws-ros-dev/rclpy/downloads","issues_url":"https://api.github.com/repos/aws-ros-dev/rclpy/issues{/number}","pulls_url":"https://api.github.com/repos/aws-ros-dev/rclpy/pulls{/number}","milestones_url":"https://api.github.com/repos/aws-ros-dev/rclpy/milestones{/number}","notifications_url":"https://api.github.com/repos/aws-ros-dev/rclpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws-ros-dev/rclpy/labels{/name}","releases_url":"https://api.github.com/repos/aws-ros-dev/rclpy/releases{/id}","deployments_url":"https://api.github.com/repos/aws-ros-dev/rclpy/deployments","created_at":"2019-03-11T22:32:48Z","updated_at":"2019-05-28T17:02:48Z","pushed_at":"2019-10-29T20:14:17Z","git_url":"git://github.com/aws-ros-dev/rclpy.git","ssh_url":"git@github.com:aws-ros-dev/rclpy.git","clone_url":"https://github.com/aws-ros-dev/rclpy.git","svn_url":"https://github.com/aws-ros-dev/rclpy","homepage":null,"size":1165,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"e566f3e15094dbb065fda72ee5969e826ff76e52","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":46515609,"node_id":"MDEwOlJlcG9zaXRvcnk0NjUxNTYwOQ==","name":"rclpy","full_name":"ros2/rclpy","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rclpy","description":"rclpy (ROS Client Library for Python)","fork":false,"url":"https://api.github.com/repos/ros2/rclpy","forks_url":"https://api.github.com/repos/ros2/rclpy/forks","keys_url":"https://api.github.com/repos/ros2/rclpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rclpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rclpy/teams","hooks_url":"https://api.github.com/repos/ros2/rclpy/hooks","issue_events_url":"https://api.github.com/repos/ros2/rclpy/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rclpy/events","assignees_url":"https://api.github.com/repos/ros2/rclpy/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rclpy/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rclpy/tags","blobs_url":"https://api.github.com/repos/ros2/rclpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rclpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rclpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rclpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rclpy/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rclpy/languages","stargazers_url":"https://api.github.com/repos/ros2/rclpy/stargazers","contributors_url":"https://api.github.com/repos/ros2/rclpy/contributors","subscribers_url":"https://api.github.com/repos/ros2/rclpy/subscribers","subscription_url":"https://api.github.com/repos/ros2/rclpy/subscription","commits_url":"https://api.github.com/repos/ros2/rclpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rclpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rclpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rclpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rclpy/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rclpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rclpy/merges","archive_url":"https://api.github.com/repos/ros2/rclpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rclpy/downloads","issues_url":"https://api.github.com/repos/ros2/rclpy/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rclpy/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rclpy/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rclpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rclpy/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rclpy/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rclpy/deployments","created_at":"2015-11-19T19:34:49Z","updated_at":"2019-10-31T11:22:49Z","pushed_at":"2019-11-09T01:20:55Z","git_url":"git://github.com/ros2/rclpy.git","ssh_url":"git@github.com:ros2/rclpy.git","clone_url":"https://github.com/ros2/rclpy.git","svn_url":"https://github.com/ros2/rclpy","homepage":null,"size":1134,"stargazers_count":39,"watchers_count":39,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":32,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rclpy/pulls/454"},"html":{"href":"https://github.com/ros2/rclpy/pull/454"},"issue":{"href":"https://api.github.com/repos/ros2/rclpy/issues/454"},"comments":{"href":"https://api.github.com/repos/ros2/rclpy/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rclpy/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rclpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rclpy/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rclpy/statuses/d5986c97ac96fc1110c8e18a5e27f44395d1049b"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"piraka9011"}}