payload: {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/312153477","pull_request_review_id":272722927,"id":312153477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjE1MzQ3Nw==","diff_hunk":"@@ -113,6 +113,16 @@ mkDerivation {\n </programlisting>\n  </para>\n \n+ <note>\n+  <para>\n+    <literal>wrapQtAppsHook</literal> ignores files that are not ELF","path":"doc/languages-frameworks/qt.xml","position":null,"original_position":6,"commit_id":"5b6a30bcd610362776836e7d8911f10eb901c68e","original_commit_id":"78fa8ffc626499cf7fe5f3e4a0784ad6b072676e","user":{"login":"jonringer","id":7673602,"node_id":"MDQ6VXNlcjc2NzM2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/7673602?v=4","gravatar_id":"","url":"https://api.github.com/users/jonringer","html_url":"https://github.com/jonringer","followers_url":"https://api.github.com/users/jonringer/followers","following_url":"https://api.github.com/users/jonringer/following{/other_user}","gists_url":"https://api.github.com/users/jonringer/gists{/gist_id}","starred_url":"https://api.github.com/users/jonringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonringer/subscriptions","organizations_url":"https://api.github.com/users/jonringer/orgs","repos_url":"https://api.github.com/users/jonringer/repos","events_url":"https://api.github.com/users/jonringer/events{/privacy}","received_events_url":"https://api.github.com/users/jonringer/received_events","type":"User","site_admin":false},"body":"it's still accurate terms, if they are unsure, they can look it up with good SEO (high accuracy about what ELF binaries are).\r\n\r\nFor non-experts, i think the `(for example, scripts)` is relatable enough to give them all the context they need","created_at":"2019-08-08T17:25:25Z","updated_at":"2019-08-08T17:25:25Z","html_url":"https://github.com/NixOS/nixpkgs/pull/66325#discussion_r312153477","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/312153477"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/66325#discussion_r312153477"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325"}},"in_reply_to_id":312043986},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325","id":305568295,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NTY4Mjk1","html_url":"https://github.com/NixOS/nixpkgs/pull/66325","diff_url":"https://github.com/NixOS/nixpkgs/pull/66325.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/66325.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/66325","number":66325,"state":"open","locked":false,"title":"doc/qt: add note about wrapQtAppsHook ignoring scripts","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"body":"<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->\r\n###### Motivation for this change\r\nThis should be documented while we have to do this.\r\n\r\n###### Screenshot\r\nBefore:\r\n![Screenshot from 2019-08-08 09 05 04](https://user-images.githubusercontent.com/28888242/62705592-ab91e900-b9bb-11e9-90a5-e31fd24ccd5e.png)\r\n\r\n\r\n\r\nAfter:\r\n![Screenshot from 2019-08-08 09 00 40](https://user-images.githubusercontent.com/28888242/62705440-68d01100-b9bb-11e9-821f-a9822f4f1490.png)\r\n\r\n\r\n###### Things done\r\n\r\nI've build the manual.\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run \"nix-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Ensured that relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n###### Notify maintainers\r\n\r\ncc @\r\n","created_at":"2019-08-08T13:05:59Z","updated_at":"2019-08-08T17:25:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e19febc40b36a53e58a5358bbcea643506dd6002","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":137715073,"node_id":"MDU6TGFiZWwxMzc3MTUwNzM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20qt/kde","name":"6.topic: qt/kde","color":"fef2c0","default":false},{"id":290122655,"node_id":"MDU6TGFiZWwyOTAxMjI2NTU=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20documentation","name":"8.has: documentation","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/66325/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/5b6a30bcd610362776836e7d8911f10eb901c68e","head":{"label":"worldofpeace:docs/isELF-wrapQtAppsHook","ref":"docs/isELF-wrapQtAppsHook","sha":"5b6a30bcd610362776836e7d8911f10eb901c68e","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"repo":{"id":135512384,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1MTIzODQ=","name":"nixpkgs","full_name":"worldofpeace/nixpkgs","private":false,"owner":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"html_url":"https://github.com/worldofpeace/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/worldofpeace/nixpkgs","forks_url":"https://api.github.com/repos/worldofpeace/nixpkgs/forks","keys_url":"https://api.github.com/repos/worldofpeace/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/worldofpeace/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/worldofpeace/nixpkgs/teams","hooks_url":"https://api.github.com/repos/worldofpeace/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/worldofpeace/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/worldofpeace/nixpkgs/events","assignees_url":"https://api.github.com/repos/worldofpeace/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/worldofpeace/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/worldofpeace/nixpkgs/tags","blobs_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/worldofpeace/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/worldofpeace/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/worldofpeace/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/worldofpeace/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/worldofpeace/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/worldofpeace/nixpkgs/subscription","commits_url":"https://api.github.com/repos/worldofpeace/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/worldofpeace/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/worldofpeace/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/worldofpeace/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/worldofpeace/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/worldofpeace/nixpkgs/merges","archive_url":"https://api.github.com/repos/worldofpeace/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/worldofpeace/nixpkgs/downloads","issues_url":"https://api.github.com/repos/worldofpeace/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/worldofpeace/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/worldofpeace/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/worldofpeace/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/worldofpeace/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/worldofpeace/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/worldofpeace/nixpkgs/deployments","created_at":"2018-05-31T00:49:50Z","updated_at":"2018-09-09T22:53:02Z","pushed_at":"2019-08-08T17:04:02Z","git_url":"git://github.com/worldofpeace/nixpkgs.git","ssh_url":"git@github.com:worldofpeace/nixpkgs.git","clone_url":"https://github.com/worldofpeace/nixpkgs.git","svn_url":"https://github.com/worldofpeace/nixpkgs","homepage":null,"size":950576,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"26663f75a55c44d7b0d699fc2b67b8bb5ba1483c","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-08-08T15:44:29Z","pushed_at":"2019-08-08T17:04:06Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":1011576,"stargazers_count":4033,"watchers_count":4033,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3875,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4591,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3875,"open_issues":4591,"watchers":4033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/66325"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/66325"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/66325/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/66325/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/5b6a30bcd610362776836e7d8911f10eb901c68e"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"jonringer"}}