payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Amsterdam/signals/pulls/comments/259793526","pull_request_review_id":207355667,"id":259793526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTc5MzUyNg==","diff_hunk":"@@ -85,46 +58,23 @@ class PrivateSignalSplitViewSet(mixins.CreateModelMixin, mixins.RetrieveModelMix\n     queryset = Signal.objects.all()\n \n \n-class PublicSignalViewSet(mixins.CreateModelMixin,\n-                          DetailSerializerMixin,\n-                          mixins.RetrieveModelMixin,\n-                          viewsets.GenericViewSet):\n-    queryset = Signal.objects.all()\n-    serializer_class = PublicSignalCreateSerializer\n-    serializer_detail_class = PublicSignalSerializerDetail\n-    lookup_field = 'signal_id'\n-\n-\n-class PublicSignalAttachmentsViewSet(mixins.CreateModelMixin, viewsets.GenericViewSet):\n+class PrivateSignalAttachmentsViewSet(mixins.CreateModelMixin, mixins.ListModelMixin,\n+                                      viewsets.GenericViewSet):\n     serializer_class = SignalAttachmentSerializer\n-    signal = None\n-    is_public = True\n-    lookup_field = 'signal_id'\n-    lookup_url_kwarg = 'signal_id'\n-\n-    def _get_signal(self):\n-        if self.signal is None:\n-            self.signal = Signal.objects.get(\n-                **{self.lookup_field: self.kwargs[self.lookup_url_kwarg]})\n-\n-        return self.signal\n-\n-    def get_serializer_context(self):\n-        context = super().get_serializer_context()\n-        context['signal'] = self._get_signal()\n-        context['is_public'] = self.is_public\n+    pagination_class = None\n \n-        return context\n+    _signal = None\n \n+    @property\n+    def signal(self):\n+        if not self._signal:","path":"api/app/signals/apps/signals/v1/private/views.py","position":93,"original_position":93,"commit_id":"55a2a3ef8230cd2a2c743e6a40103c6193425409","original_commit_id":"55a2a3ef8230cd2a2c743e6a40103c6193425409","user":{"login":"vanbuiten","id":23056530,"node_id":"MDQ6VXNlcjIzMDU2NTMw","avatar_url":"https://avatars3.githubusercontent.com/u/23056530?v=4","gravatar_id":"","url":"https://api.github.com/users/vanbuiten","html_url":"https://github.com/vanbuiten","followers_url":"https://api.github.com/users/vanbuiten/followers","following_url":"https://api.github.com/users/vanbuiten/following{/other_user}","gists_url":"https://api.github.com/users/vanbuiten/gists{/gist_id}","starred_url":"https://api.github.com/users/vanbuiten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanbuiten/subscriptions","organizations_url":"https://api.github.com/users/vanbuiten/orgs","repos_url":"https://api.github.com/users/vanbuiten/repos","events_url":"https://api.github.com/users/vanbuiten/events{/privacy}","received_events_url":"https://api.github.com/users/vanbuiten/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-02-25T12:01:56Z","updated_at":"2019-02-25T12:01:56Z","html_url":"https://github.com/Amsterdam/signals/pull/207#discussion_r259793526","pull_request_url":"https://api.github.com/repos/Amsterdam/signals/pulls/207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Amsterdam/signals/pulls/comments/259793526"},"html":{"href":"https://github.com/Amsterdam/signals/pull/207#discussion_r259793526"},"pull_request":{"href":"https://api.github.com/repos/Amsterdam/signals/pulls/207"}},"in_reply_to_id":259440184},"pull_request":{"url":"https://api.github.com/repos/Amsterdam/signals/pulls/207","id":254976342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0OTc2MzQy","html_url":"https://github.com/Amsterdam/signals/pull/207","diff_url":"https://github.com/Amsterdam/signals/pull/207.diff","patch_url":"https://github.com/Amsterdam/signals/pull/207.patch","issue_url":"https://api.github.com/repos/Amsterdam/signals/issues/207","number":207,"state":"open","locked":false,"title":"feature/SIG-937-refactor","user":{"login":"vanbuiten","id":23056530,"node_id":"MDQ6VXNlcjIzMDU2NTMw","avatar_url":"https://avatars3.githubusercontent.com/u/23056530?v=4","gravatar_id":"","url":"https://api.github.com/users/vanbuiten","html_url":"https://github.com/vanbuiten","followers_url":"https://api.github.com/users/vanbuiten/followers","following_url":"https://api.github.com/users/vanbuiten/following{/other_user}","gists_url":"https://api.github.com/users/vanbuiten/gists{/gist_id}","starred_url":"https://api.github.com/users/vanbuiten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanbuiten/subscriptions","organizations_url":"https://api.github.com/users/vanbuiten/orgs","repos_url":"https://api.github.com/users/vanbuiten/repos","events_url":"https://api.github.com/users/vanbuiten/events{/privacy}","received_events_url":"https://api.github.com/users/vanbuiten/received_events","type":"User","site_admin":false},"body":"Fixed public endpoint bugs and private attachment bug + refactored views","created_at":"2019-02-21T10:57:06Z","updated_at":"2019-02-25T12:01:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22d70cc95fe7a3160293e1e3e4b48474b5a44e3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Amsterdam/signals/pulls/207/commits","review_comments_url":"https://api.github.com/repos/Amsterdam/signals/pulls/207/comments","review_comment_url":"https://api.github.com/repos/Amsterdam/signals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Amsterdam/signals/issues/207/comments","statuses_url":"https://api.github.com/repos/Amsterdam/signals/statuses/55a2a3ef8230cd2a2c743e6a40103c6193425409","head":{"label":"Amsterdam:feature/SIG-937-refactor","ref":"feature/SIG-937-refactor","sha":"55a2a3ef8230cd2a2c743e6a40103c6193425409","user":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":136190050,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxOTAwNTA=","name":"signals","full_name":"Amsterdam/signals","private":false,"owner":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Amsterdam/signals","description":"meldingen system amsterdam (signalen/signals)","fork":false,"url":"https://api.github.com/repos/Amsterdam/signals","forks_url":"https://api.github.com/repos/Amsterdam/signals/forks","keys_url":"https://api.github.com/repos/Amsterdam/signals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amsterdam/signals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amsterdam/signals/teams","hooks_url":"https://api.github.com/repos/Amsterdam/signals/hooks","issue_events_url":"https://api.github.com/repos/Amsterdam/signals/issues/events{/number}","events_url":"https://api.github.com/repos/Amsterdam/signals/events","assignees_url":"https://api.github.com/repos/Amsterdam/signals/assignees{/user}","branches_url":"https://api.github.com/repos/Amsterdam/signals/branches{/branch}","tags_url":"https://api.github.com/repos/Amsterdam/signals/tags","blobs_url":"https://api.github.com/repos/Amsterdam/signals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amsterdam/signals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amsterdam/signals/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amsterdam/signals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amsterdam/signals/statuses/{sha}","languages_url":"https://api.github.com/repos/Amsterdam/signals/languages","stargazers_url":"https://api.github.com/repos/Amsterdam/signals/stargazers","contributors_url":"https://api.github.com/repos/Amsterdam/signals/contributors","subscribers_url":"https://api.github.com/repos/Amsterdam/signals/subscribers","subscription_url":"https://api.github.com/repos/Amsterdam/signals/subscription","commits_url":"https://api.github.com/repos/Amsterdam/signals/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amsterdam/signals/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amsterdam/signals/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amsterdam/signals/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amsterdam/signals/contents/{+path}","compare_url":"https://api.github.com/repos/Amsterdam/signals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amsterdam/signals/merges","archive_url":"https://api.github.com/repos/Amsterdam/signals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amsterdam/signals/downloads","issues_url":"https://api.github.com/repos/Amsterdam/signals/issues{/number}","pulls_url":"https://api.github.com/repos/Amsterdam/signals/pulls{/number}","milestones_url":"https://api.github.com/repos/Amsterdam/signals/milestones{/number}","notifications_url":"https://api.github.com/repos/Amsterdam/signals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amsterdam/signals/labels{/name}","releases_url":"https://api.github.com/repos/Amsterdam/signals/releases{/id}","deployments_url":"https://api.github.com/repos/Amsterdam/signals/deployments","created_at":"2018-06-05T14:30:10Z","updated_at":"2019-02-23T14:57:55Z","pushed_at":"2019-02-22T17:59:09Z","git_url":"git://github.com/Amsterdam/signals.git","ssh_url":"git@github.com:Amsterdam/signals.git","clone_url":"https://github.com/Amsterdam/signals.git","svn_url":"https://github.com/Amsterdam/signals","homepage":"","size":3115,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"Amsterdam:master","ref":"master","sha":"4f4014e2d9f934436811b2537712b2777532829d","user":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":136190050,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxOTAwNTA=","name":"signals","full_name":"Amsterdam/signals","private":false,"owner":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Amsterdam/signals","description":"meldingen system amsterdam (signalen/signals)","fork":false,"url":"https://api.github.com/repos/Amsterdam/signals","forks_url":"https://api.github.com/repos/Amsterdam/signals/forks","keys_url":"https://api.github.com/repos/Amsterdam/signals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amsterdam/signals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amsterdam/signals/teams","hooks_url":"https://api.github.com/repos/Amsterdam/signals/hooks","issue_events_url":"https://api.github.com/repos/Amsterdam/signals/issues/events{/number}","events_url":"https://api.github.com/repos/Amsterdam/signals/events","assignees_url":"https://api.github.com/repos/Amsterdam/signals/assignees{/user}","branches_url":"https://api.github.com/repos/Amsterdam/signals/branches{/branch}","tags_url":"https://api.github.com/repos/Amsterdam/signals/tags","blobs_url":"https://api.github.com/repos/Amsterdam/signals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amsterdam/signals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amsterdam/signals/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amsterdam/signals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amsterdam/signals/statuses/{sha}","languages_url":"https://api.github.com/repos/Amsterdam/signals/languages","stargazers_url":"https://api.github.com/repos/Amsterdam/signals/stargazers","contributors_url":"https://api.github.com/repos/Amsterdam/signals/contributors","subscribers_url":"https://api.github.com/repos/Amsterdam/signals/subscribers","subscription_url":"https://api.github.com/repos/Amsterdam/signals/subscription","commits_url":"https://api.github.com/repos/Amsterdam/signals/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amsterdam/signals/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amsterdam/signals/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amsterdam/signals/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amsterdam/signals/contents/{+path}","compare_url":"https://api.github.com/repos/Amsterdam/signals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amsterdam/signals/merges","archive_url":"https://api.github.com/repos/Amsterdam/signals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amsterdam/signals/downloads","issues_url":"https://api.github.com/repos/Amsterdam/signals/issues{/number}","pulls_url":"https://api.github.com/repos/Amsterdam/signals/pulls{/number}","milestones_url":"https://api.github.com/repos/Amsterdam/signals/milestones{/number}","notifications_url":"https://api.github.com/repos/Amsterdam/signals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amsterdam/signals/labels{/name}","releases_url":"https://api.github.com/repos/Amsterdam/signals/releases{/id}","deployments_url":"https://api.github.com/repos/Amsterdam/signals/deployments","created_at":"2018-06-05T14:30:10Z","updated_at":"2019-02-23T14:57:55Z","pushed_at":"2019-02-22T17:59:09Z","git_url":"git://github.com/Amsterdam/signals.git","ssh_url":"git@github.com:Amsterdam/signals.git","clone_url":"https://github.com/Amsterdam/signals.git","svn_url":"https://github.com/Amsterdam/signals","homepage":"","size":3115,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Amsterdam/signals/pulls/207"},"html":{"href":"https://github.com/Amsterdam/signals/pull/207"},"issue":{"href":"https://api.github.com/repos/Amsterdam/signals/issues/207"},"comments":{"href":"https://api.github.com/repos/Amsterdam/signals/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/Amsterdam/signals/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/Amsterdam/signals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Amsterdam/signals/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/Amsterdam/signals/statuses/55a2a3ef8230cd2a2c743e6a40103c6193425409"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"vanbuiten"}}