payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments/283199228","pull_request_review_id":236478569,"id":283199228,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzE5OTIyOA==","diff_hunk":"@@ -44,6 +45,45 @@ const (\n \n const logPrefix = \"[discovery] \"\n \n+// Discovery structure holds discovery service state\n+type Discovery struct {\n+\tidentityRegistry            identity_registry.IdentityRegistry\n+\townIdentity                 identity.Identity\n+\tidentityRegistration        identity_registry.RegistrationDataProvider\n+\tproposalRegistry            ProposalRegistry\n+\tsignerCreate                identity.SignerFactory\n+\tsigner                      identity.Signer\n+\tproposal                    market.ServiceProposal\n+\tstatusChan                  chan Status\n+\tstatus                      Status\n+\tproposalAnnouncementStopped *sync.WaitGroup\n+\tunsubscribe                 func()\n+\tstop                        func()","path":"core/discovery/discovery.go","position":29,"original_position":29,"commit_id":"c4be94bb8bcc5ea9c2e7fff59fb27801f2e57fd7","original_commit_id":"c4be94bb8bcc5ea9c2e7fff59fb27801f2e57fd7","user":{"login":"soffokl","id":8612618,"node_id":"MDQ6VXNlcjg2MTI2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8612618?v=4","gravatar_id":"","url":"https://api.github.com/users/soffokl","html_url":"https://github.com/soffokl","followers_url":"https://api.github.com/users/soffokl/followers","following_url":"https://api.github.com/users/soffokl/following{/other_user}","gists_url":"https://api.github.com/users/soffokl/gists{/gist_id}","starred_url":"https://api.github.com/users/soffokl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soffokl/subscriptions","organizations_url":"https://api.github.com/users/soffokl/orgs","repos_url":"https://api.github.com/users/soffokl/repos","events_url":"https://api.github.com/users/soffokl/events{/privacy}","received_events_url":"https://api.github.com/users/soffokl/received_events","type":"User","site_admin":false},"body":"It looks like `stop` and `unsubscribe` are doing the same things. ","created_at":"2019-05-13T06:19:53Z","updated_at":"2019-05-13T06:25:33Z","html_url":"https://github.com/mysteriumnetwork/node/pull/1050#discussion_r283199228","pull_request_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments/283199228"},"html":{"href":"https://github.com/mysteriumnetwork/node/pull/1050#discussion_r283199228"},"pull_request":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050"}}},"pull_request":{"url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050","id":277695442,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3Njk1NDQy","html_url":"https://github.com/mysteriumnetwork/node/pull/1050","diff_url":"https://github.com/mysteriumnetwork/node/pull/1050.diff","patch_url":"https://github.com/mysteriumnetwork/node/pull/1050.patch","issue_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/1050","number":1050,"state":"open","locked":false,"title":" Implement discovery registry through Mysterium Communication","user":{"login":"Waldz","id":2713911,"node_id":"MDQ6VXNlcjI3MTM5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2713911?v=4","gravatar_id":"","url":"https://api.github.com/users/Waldz","html_url":"https://github.com/Waldz","followers_url":"https://api.github.com/users/Waldz/followers","following_url":"https://api.github.com/users/Waldz/following{/other_user}","gists_url":"https://api.github.com/users/Waldz/gists{/gist_id}","starred_url":"https://api.github.com/users/Waldz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Waldz/subscriptions","organizations_url":"https://api.github.com/users/Waldz/orgs","repos_url":"https://api.github.com/users/Waldz/repos","events_url":"https://api.github.com/users/Waldz/events{/privacy}","received_events_url":"https://api.github.com/users/Waldz/received_events","type":"User","site_admin":false},"body":"Changes made:\r\n- Discovery related code moved to separate package `core/discovery`\r\n- Introduced `discovery.Registry` for abstraction of proposals announcing \r\n- 2 different Discovery providers introduced: `api` and `broker` \r\n- Discovery provider can be chosen by `myst` arguments `--discovery.type` and `--discovery.address`\r\n\r\n<img width=\"1115\" alt=\"Screen Shot 2019-05-10 at 12 52 50\" src=\"https://user-images.githubusercontent.com/2713911/57518801-92c55900-7322-11e9-914e-79060d770c2a.png\">\r\n","created_at":"2019-05-10T09:24:40Z","updated_at":"2019-05-13T06:25:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53d273ea0673562e0b24b777ccf478af0cea47d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tadovas","id":1046590,"node_id":"MDQ6VXNlcjEwNDY1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1046590?v=4","gravatar_id":"","url":"https://api.github.com/users/tadovas","html_url":"https://github.com/tadovas","followers_url":"https://api.github.com/users/tadovas/followers","following_url":"https://api.github.com/users/tadovas/following{/other_user}","gists_url":"https://api.github.com/users/tadovas/gists{/gist_id}","starred_url":"https://api.github.com/users/tadovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadovas/subscriptions","organizations_url":"https://api.github.com/users/tadovas/orgs","repos_url":"https://api.github.com/users/tadovas/repos","events_url":"https://api.github.com/users/tadovas/events{/privacy}","received_events_url":"https://api.github.com/users/tadovas/received_events","type":"User","site_admin":false},{"login":"tadaskay","id":4745368,"node_id":"MDQ6VXNlcjQ3NDUzNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/4745368?v=4","gravatar_id":"","url":"https://api.github.com/users/tadaskay","html_url":"https://github.com/tadaskay","followers_url":"https://api.github.com/users/tadaskay/followers","following_url":"https://api.github.com/users/tadaskay/following{/other_user}","gists_url":"https://api.github.com/users/tadaskay/gists{/gist_id}","starred_url":"https://api.github.com/users/tadaskay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadaskay/subscriptions","organizations_url":"https://api.github.com/users/tadaskay/orgs","repos_url":"https://api.github.com/users/tadaskay/repos","events_url":"https://api.github.com/users/tadaskay/events{/privacy}","received_events_url":"https://api.github.com/users/tadaskay/received_events","type":"User","site_admin":false},{"login":"zolia","id":13434315,"node_id":"MDQ6VXNlcjEzNDM0MzE1","avatar_url":"https://avatars3.githubusercontent.com/u/13434315?v=4","gravatar_id":"","url":"https://api.github.com/users/zolia","html_url":"https://github.com/zolia","followers_url":"https://api.github.com/users/zolia/followers","following_url":"https://api.github.com/users/zolia/following{/other_user}","gists_url":"https://api.github.com/users/zolia/gists{/gist_id}","starred_url":"https://api.github.com/users/zolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolia/subscriptions","organizations_url":"https://api.github.com/users/zolia/orgs","repos_url":"https://api.github.com/users/zolia/repos","events_url":"https://api.github.com/users/zolia/events{/privacy}","received_events_url":"https://api.github.com/users/zolia/received_events","type":"User","site_admin":false},{"login":"vkuznecovas","id":18392269,"node_id":"MDQ6VXNlcjE4MzkyMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/18392269?v=4","gravatar_id":"","url":"https://api.github.com/users/vkuznecovas","html_url":"https://github.com/vkuznecovas","followers_url":"https://api.github.com/users/vkuznecovas/followers","following_url":"https://api.github.com/users/vkuznecovas/following{/other_user}","gists_url":"https://api.github.com/users/vkuznecovas/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuznecovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuznecovas/subscriptions","organizations_url":"https://api.github.com/users/vkuznecovas/orgs","repos_url":"https://api.github.com/users/vkuznecovas/repos","events_url":"https://api.github.com/users/vkuznecovas/events{/privacy}","received_events_url":"https://api.github.com/users/vkuznecovas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050/commits","review_comments_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050/comments","review_comment_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/1050/comments","statuses_url":"https://api.github.com/repos/mysteriumnetwork/node/statuses/c4be94bb8bcc5ea9c2e7fff59fb27801f2e57fd7","head":{"label":"mysteriumnetwork:feature/discovery-registry-with-broker","ref":"feature/discovery-registry-with-broker","sha":"c4be94bb8bcc5ea9c2e7fff59fb27801f2e57fd7","user":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80073079,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA3MzA3OQ==","name":"node","full_name":"mysteriumnetwork/node","private":false,"owner":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mysteriumnetwork/node","description":"Mysterium Node - VPN server and client for Mysterium Network","fork":false,"url":"https://api.github.com/repos/mysteriumnetwork/node","forks_url":"https://api.github.com/repos/mysteriumnetwork/node/forks","keys_url":"https://api.github.com/repos/mysteriumnetwork/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysteriumnetwork/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysteriumnetwork/node/teams","hooks_url":"https://api.github.com/repos/mysteriumnetwork/node/hooks","issue_events_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/events{/number}","events_url":"https://api.github.com/repos/mysteriumnetwork/node/events","assignees_url":"https://api.github.com/repos/mysteriumnetwork/node/assignees{/user}","branches_url":"https://api.github.com/repos/mysteriumnetwork/node/branches{/branch}","tags_url":"https://api.github.com/repos/mysteriumnetwork/node/tags","blobs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysteriumnetwork/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysteriumnetwork/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysteriumnetwork/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mysteriumnetwork/node/languages","stargazers_url":"https://api.github.com/repos/mysteriumnetwork/node/stargazers","contributors_url":"https://api.github.com/repos/mysteriumnetwork/node/contributors","subscribers_url":"https://api.github.com/repos/mysteriumnetwork/node/subscribers","subscription_url":"https://api.github.com/repos/mysteriumnetwork/node/subscription","commits_url":"https://api.github.com/repos/mysteriumnetwork/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysteriumnetwork/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysteriumnetwork/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysteriumnetwork/node/contents/{+path}","compare_url":"https://api.github.com/repos/mysteriumnetwork/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysteriumnetwork/node/merges","archive_url":"https://api.github.com/repos/mysteriumnetwork/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysteriumnetwork/node/downloads","issues_url":"https://api.github.com/repos/mysteriumnetwork/node/issues{/number}","pulls_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mysteriumnetwork/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mysteriumnetwork/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysteriumnetwork/node/labels{/name}","releases_url":"https://api.github.com/repos/mysteriumnetwork/node/releases{/id}","deployments_url":"https://api.github.com/repos/mysteriumnetwork/node/deployments","created_at":"2017-01-26T00:43:08Z","updated_at":"2019-05-12T18:09:07Z","pushed_at":"2019-05-12T20:42:18Z","git_url":"git://github.com/mysteriumnetwork/node.git","ssh_url":"git@github.com:mysteriumnetwork/node.git","clone_url":"https://github.com/mysteriumnetwork/node.git","svn_url":"https://github.com/mysteriumnetwork/node","homepage":"https://mysterium.network/","size":8635,"stargazers_count":513,"watchers_count":513,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":170,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":82,"open_issues":170,"watchers":513,"default_branch":"master"}},"base":{"label":"mysteriumnetwork:master","ref":"master","sha":"2e06e24c817aa711a0af2d88a34b951a1ca639ad","user":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80073079,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA3MzA3OQ==","name":"node","full_name":"mysteriumnetwork/node","private":false,"owner":{"login":"mysteriumnetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/mysteriumnetwork","html_url":"https://github.com/mysteriumnetwork","followers_url":"https://api.github.com/users/mysteriumnetwork/followers","following_url":"https://api.github.com/users/mysteriumnetwork/following{/other_user}","gists_url":"https://api.github.com/users/mysteriumnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/mysteriumnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysteriumnetwork/subscriptions","organizations_url":"https://api.github.com/users/mysteriumnetwork/orgs","repos_url":"https://api.github.com/users/mysteriumnetwork/repos","events_url":"https://api.github.com/users/mysteriumnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/mysteriumnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mysteriumnetwork/node","description":"Mysterium Node - VPN server and client for Mysterium Network","fork":false,"url":"https://api.github.com/repos/mysteriumnetwork/node","forks_url":"https://api.github.com/repos/mysteriumnetwork/node/forks","keys_url":"https://api.github.com/repos/mysteriumnetwork/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysteriumnetwork/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysteriumnetwork/node/teams","hooks_url":"https://api.github.com/repos/mysteriumnetwork/node/hooks","issue_events_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/events{/number}","events_url":"https://api.github.com/repos/mysteriumnetwork/node/events","assignees_url":"https://api.github.com/repos/mysteriumnetwork/node/assignees{/user}","branches_url":"https://api.github.com/repos/mysteriumnetwork/node/branches{/branch}","tags_url":"https://api.github.com/repos/mysteriumnetwork/node/tags","blobs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysteriumnetwork/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysteriumnetwork/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysteriumnetwork/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysteriumnetwork/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mysteriumnetwork/node/languages","stargazers_url":"https://api.github.com/repos/mysteriumnetwork/node/stargazers","contributors_url":"https://api.github.com/repos/mysteriumnetwork/node/contributors","subscribers_url":"https://api.github.com/repos/mysteriumnetwork/node/subscribers","subscription_url":"https://api.github.com/repos/mysteriumnetwork/node/subscription","commits_url":"https://api.github.com/repos/mysteriumnetwork/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysteriumnetwork/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysteriumnetwork/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysteriumnetwork/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysteriumnetwork/node/contents/{+path}","compare_url":"https://api.github.com/repos/mysteriumnetwork/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysteriumnetwork/node/merges","archive_url":"https://api.github.com/repos/mysteriumnetwork/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysteriumnetwork/node/downloads","issues_url":"https://api.github.com/repos/mysteriumnetwork/node/issues{/number}","pulls_url":"https://api.github.com/repos/mysteriumnetwork/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mysteriumnetwork/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mysteriumnetwork/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysteriumnetwork/node/labels{/name}","releases_url":"https://api.github.com/repos/mysteriumnetwork/node/releases{/id}","deployments_url":"https://api.github.com/repos/mysteriumnetwork/node/deployments","created_at":"2017-01-26T00:43:08Z","updated_at":"2019-05-12T18:09:07Z","pushed_at":"2019-05-12T20:42:18Z","git_url":"git://github.com/mysteriumnetwork/node.git","ssh_url":"git@github.com:mysteriumnetwork/node.git","clone_url":"https://github.com/mysteriumnetwork/node.git","svn_url":"https://github.com/mysteriumnetwork/node","homepage":"https://mysterium.network/","size":8635,"stargazers_count":513,"watchers_count":513,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":170,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":82,"open_issues":170,"watchers":513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050"},"html":{"href":"https://github.com/mysteriumnetwork/node/pull/1050"},"issue":{"href":"https://api.github.com/repos/mysteriumnetwork/node/issues/1050"},"comments":{"href":"https://api.github.com/repos/mysteriumnetwork/node/issues/1050/comments"},"review_comments":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050/comments"},"review_comment":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mysteriumnetwork/node/pulls/1050/commits"},"statuses":{"href":"https://api.github.com/repos/mysteriumnetwork/node/statuses/c4be94bb8bcc5ea9c2e7fff59fb27801f2e57fd7"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"soffokl"}}