payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vcync/modV/pulls/comments/320612977","pull_request_review_id":283427267,"id":320612977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDYxMjk3Nw==","diff_hunk":"@@ -90,14 +93,26 @@ function draw(δ) {\n         }\n       }\n \n-      if (!enabled || alpha === 0) return\n+      if (!enabled || alpha === 0) {\n+        continue\n+      }\n \n-      Layer.moduleOrder.forEach((moduleName, moduleIndex) => {\n+      const moduleOrderLength = Layer.moduleOrder.length\n+      for (\n+        let moduleIndex = 0;\n+        moduleIndex < moduleOrderLength;\n+        ++moduleIndex\n+      ) {\n+        const moduleName = Layer.moduleOrder[moduleIndex]\n         const Module = store.getters['modVModules/outerActive'][moduleName]\n \n-        if (!Module) return\n+        if (!Module) {","path":"src/modv/draw.js","position":32,"original_position":32,"commit_id":"6dd4a2a47644e5978ecee11926bfe054c71d1b2a","original_commit_id":"6dd4a2a47644e5978ecee11926bfe054c71d1b2a","user":{"login":"2xAA","id":554219,"node_id":"MDQ6VXNlcjU1NDIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/554219?v=4","gravatar_id":"","url":"https://api.github.com/users/2xAA","html_url":"https://github.com/2xAA","followers_url":"https://api.github.com/users/2xAA/followers","following_url":"https://api.github.com/users/2xAA/following{/other_user}","gists_url":"https://api.github.com/users/2xAA/gists{/gist_id}","starred_url":"https://api.github.com/users/2xAA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2xAA/subscriptions","organizations_url":"https://api.github.com/users/2xAA/orgs","repos_url":"https://api.github.com/users/2xAA/repos","events_url":"https://api.github.com/users/2xAA/events{/privacy}","received_events_url":"https://api.github.com/users/2xAA/received_events","type":"User","site_admin":false},"body":"In `forEach` loop a `return` acts similarly to a `continue` in a `for` loop.\n\nIf I had left the `return` in there, any Module with no opacity, that wasn't enabled or any layer with no modules would have stopped the rest of the draw loop entirely.","created_at":"2019-09-04T07:37:14Z","updated_at":"2019-09-04T07:37:14Z","html_url":"https://github.com/vcync/modV/pull/344#discussion_r320612977","pull_request_url":"https://api.github.com/repos/vcync/modV/pulls/344","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vcync/modV/pulls/comments/320612977"},"html":{"href":"https://github.com/vcync/modV/pull/344#discussion_r320612977"},"pull_request":{"href":"https://api.github.com/repos/vcync/modV/pulls/344"}},"in_reply_to_id":320611350},"pull_request":{"url":"https://api.github.com/repos/vcync/modV/pulls/344","id":312808800,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyODA4ODAw","html_url":"https://github.com/vcync/modV/pull/344","diff_url":"https://github.com/vcync/modV/pull/344.diff","patch_url":"https://github.com/vcync/modV/pull/344.patch","issue_url":"https://api.github.com/repos/vcync/modV/issues/344","number":344,"state":"open","locked":false,"title":"perf(draw): Updates forEach to for for speedy looping","user":{"login":"2xAA","id":554219,"node_id":"MDQ6VXNlcjU1NDIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/554219?v=4","gravatar_id":"","url":"https://api.github.com/users/2xAA","html_url":"https://github.com/2xAA","followers_url":"https://api.github.com/users/2xAA/followers","following_url":"https://api.github.com/users/2xAA/following{/other_user}","gists_url":"https://api.github.com/users/2xAA/gists{/gist_id}","starred_url":"https://api.github.com/users/2xAA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2xAA/subscriptions","organizations_url":"https://api.github.com/users/2xAA/orgs","repos_url":"https://api.github.com/users/2xAA/repos","events_url":"https://api.github.com/users/2xAA/events{/privacy}","received_events_url":"https://api.github.com/users/2xAA/received_events","type":"User","site_admin":false},"body":"Changes `forEach` to `for` in main critical loop.\r\nRE: #293","created_at":"2019-08-30T16:31:33Z","updated_at":"2019-09-04T07:37:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5514ec2e34c27779161c750995fc649a0df4db36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vcync/modV/pulls/344/commits","review_comments_url":"https://api.github.com/repos/vcync/modV/pulls/344/comments","review_comment_url":"https://api.github.com/repos/vcync/modV/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vcync/modV/issues/344/comments","statuses_url":"https://api.github.com/repos/vcync/modV/statuses/6dd4a2a47644e5978ecee11926bfe054c71d1b2a","head":{"label":"vcync:perf/for-loop","ref":"perf/for-loop","sha":"6dd4a2a47644e5978ecee11926bfe054c71d1b2a","user":{"login":"vcync","id":43783088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzgzMDg4","avatar_url":"https://avatars0.githubusercontent.com/u/43783088?v=4","gravatar_id":"","url":"https://api.github.com/users/vcync","html_url":"https://github.com/vcync","followers_url":"https://api.github.com/users/vcync/followers","following_url":"https://api.github.com/users/vcync/following{/other_user}","gists_url":"https://api.github.com/users/vcync/gists{/gist_id}","starred_url":"https://api.github.com/users/vcync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcync/subscriptions","organizations_url":"https://api.github.com/users/vcync/orgs","repos_url":"https://api.github.com/users/vcync/repos","events_url":"https://api.github.com/users/vcync/events{/privacy}","received_events_url":"https://api.github.com/users/vcync/received_events","type":"Organization","site_admin":false},"repo":{"id":28110874,"node_id":"MDEwOlJlcG9zaXRvcnkyODExMDg3NA==","name":"modV","full_name":"vcync/modV","private":false,"owner":{"login":"vcync","id":43783088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzgzMDg4","avatar_url":"https://avatars0.githubusercontent.com/u/43783088?v=4","gravatar_id":"","url":"https://api.github.com/users/vcync","html_url":"https://github.com/vcync","followers_url":"https://api.github.com/users/vcync/followers","following_url":"https://api.github.com/users/vcync/following{/other_user}","gists_url":"https://api.github.com/users/vcync/gists{/gist_id}","starred_url":"https://api.github.com/users/vcync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcync/subscriptions","organizations_url":"https://api.github.com/users/vcync/orgs","repos_url":"https://api.github.com/users/vcync/repos","events_url":"https://api.github.com/users/vcync/events{/privacy}","received_events_url":"https://api.github.com/users/vcync/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vcync/modV","description":"modular audio visualisation powered by JavaScript","fork":false,"url":"https://api.github.com/repos/vcync/modV","forks_url":"https://api.github.com/repos/vcync/modV/forks","keys_url":"https://api.github.com/repos/vcync/modV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcync/modV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcync/modV/teams","hooks_url":"https://api.github.com/repos/vcync/modV/hooks","issue_events_url":"https://api.github.com/repos/vcync/modV/issues/events{/number}","events_url":"https://api.github.com/repos/vcync/modV/events","assignees_url":"https://api.github.com/repos/vcync/modV/assignees{/user}","branches_url":"https://api.github.com/repos/vcync/modV/branches{/branch}","tags_url":"https://api.github.com/repos/vcync/modV/tags","blobs_url":"https://api.github.com/repos/vcync/modV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcync/modV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcync/modV/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcync/modV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcync/modV/statuses/{sha}","languages_url":"https://api.github.com/repos/vcync/modV/languages","stargazers_url":"https://api.github.com/repos/vcync/modV/stargazers","contributors_url":"https://api.github.com/repos/vcync/modV/contributors","subscribers_url":"https://api.github.com/repos/vcync/modV/subscribers","subscription_url":"https://api.github.com/repos/vcync/modV/subscription","commits_url":"https://api.github.com/repos/vcync/modV/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcync/modV/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcync/modV/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcync/modV/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcync/modV/contents/{+path}","compare_url":"https://api.github.com/repos/vcync/modV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcync/modV/merges","archive_url":"https://api.github.com/repos/vcync/modV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcync/modV/downloads","issues_url":"https://api.github.com/repos/vcync/modV/issues{/number}","pulls_url":"https://api.github.com/repos/vcync/modV/pulls{/number}","milestones_url":"https://api.github.com/repos/vcync/modV/milestones{/number}","notifications_url":"https://api.github.com/repos/vcync/modV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcync/modV/labels{/name}","releases_url":"https://api.github.com/repos/vcync/modV/releases{/id}","deployments_url":"https://api.github.com/repos/vcync/modV/deployments","created_at":"2014-12-16T23:02:53Z","updated_at":"2019-08-31T09:21:43Z","pushed_at":"2019-08-31T09:21:42Z","git_url":"git://github.com/vcync/modV.git","ssh_url":"git@github.com:vcync/modV.git","clone_url":"https://github.com/vcync/modV.git","svn_url":"https://github.com/vcync/modV","homepage":"https://modv.js.org","size":75285,"stargazers_count":153,"watchers_count":153,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":39,"watchers":153,"default_branch":"2.0"}},"base":{"label":"vcync:2.0","ref":"2.0","sha":"6545c430f933b0302f829a68d26671334253766a","user":{"login":"vcync","id":43783088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzgzMDg4","avatar_url":"https://avatars0.githubusercontent.com/u/43783088?v=4","gravatar_id":"","url":"https://api.github.com/users/vcync","html_url":"https://github.com/vcync","followers_url":"https://api.github.com/users/vcync/followers","following_url":"https://api.github.com/users/vcync/following{/other_user}","gists_url":"https://api.github.com/users/vcync/gists{/gist_id}","starred_url":"https://api.github.com/users/vcync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcync/subscriptions","organizations_url":"https://api.github.com/users/vcync/orgs","repos_url":"https://api.github.com/users/vcync/repos","events_url":"https://api.github.com/users/vcync/events{/privacy}","received_events_url":"https://api.github.com/users/vcync/received_events","type":"Organization","site_admin":false},"repo":{"id":28110874,"node_id":"MDEwOlJlcG9zaXRvcnkyODExMDg3NA==","name":"modV","full_name":"vcync/modV","private":false,"owner":{"login":"vcync","id":43783088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzgzMDg4","avatar_url":"https://avatars0.githubusercontent.com/u/43783088?v=4","gravatar_id":"","url":"https://api.github.com/users/vcync","html_url":"https://github.com/vcync","followers_url":"https://api.github.com/users/vcync/followers","following_url":"https://api.github.com/users/vcync/following{/other_user}","gists_url":"https://api.github.com/users/vcync/gists{/gist_id}","starred_url":"https://api.github.com/users/vcync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcync/subscriptions","organizations_url":"https://api.github.com/users/vcync/orgs","repos_url":"https://api.github.com/users/vcync/repos","events_url":"https://api.github.com/users/vcync/events{/privacy}","received_events_url":"https://api.github.com/users/vcync/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vcync/modV","description":"modular audio visualisation powered by JavaScript","fork":false,"url":"https://api.github.com/repos/vcync/modV","forks_url":"https://api.github.com/repos/vcync/modV/forks","keys_url":"https://api.github.com/repos/vcync/modV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcync/modV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcync/modV/teams","hooks_url":"https://api.github.com/repos/vcync/modV/hooks","issue_events_url":"https://api.github.com/repos/vcync/modV/issues/events{/number}","events_url":"https://api.github.com/repos/vcync/modV/events","assignees_url":"https://api.github.com/repos/vcync/modV/assignees{/user}","branches_url":"https://api.github.com/repos/vcync/modV/branches{/branch}","tags_url":"https://api.github.com/repos/vcync/modV/tags","blobs_url":"https://api.github.com/repos/vcync/modV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcync/modV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcync/modV/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcync/modV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcync/modV/statuses/{sha}","languages_url":"https://api.github.com/repos/vcync/modV/languages","stargazers_url":"https://api.github.com/repos/vcync/modV/stargazers","contributors_url":"https://api.github.com/repos/vcync/modV/contributors","subscribers_url":"https://api.github.com/repos/vcync/modV/subscribers","subscription_url":"https://api.github.com/repos/vcync/modV/subscription","commits_url":"https://api.github.com/repos/vcync/modV/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcync/modV/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcync/modV/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcync/modV/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcync/modV/contents/{+path}","compare_url":"https://api.github.com/repos/vcync/modV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcync/modV/merges","archive_url":"https://api.github.com/repos/vcync/modV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcync/modV/downloads","issues_url":"https://api.github.com/repos/vcync/modV/issues{/number}","pulls_url":"https://api.github.com/repos/vcync/modV/pulls{/number}","milestones_url":"https://api.github.com/repos/vcync/modV/milestones{/number}","notifications_url":"https://api.github.com/repos/vcync/modV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcync/modV/labels{/name}","releases_url":"https://api.github.com/repos/vcync/modV/releases{/id}","deployments_url":"https://api.github.com/repos/vcync/modV/deployments","created_at":"2014-12-16T23:02:53Z","updated_at":"2019-08-31T09:21:43Z","pushed_at":"2019-08-31T09:21:42Z","git_url":"git://github.com/vcync/modV.git","ssh_url":"git@github.com:vcync/modV.git","clone_url":"https://github.com/vcync/modV.git","svn_url":"https://github.com/vcync/modV","homepage":"https://modv.js.org","size":75285,"stargazers_count":153,"watchers_count":153,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":39,"watchers":153,"default_branch":"2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/vcync/modV/pulls/344"},"html":{"href":"https://github.com/vcync/modV/pull/344"},"issue":{"href":"https://api.github.com/repos/vcync/modV/issues/344"},"comments":{"href":"https://api.github.com/repos/vcync/modV/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/vcync/modV/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/vcync/modV/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vcync/modV/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/vcync/modV/statuses/6dd4a2a47644e5978ecee11926bfe054c71d1b2a"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"2xAA"}}