payload: {"action":"created","issue":{"url":"https://api.github.com/repos/tus/tus-js-client/issues/140","repository_url":"https://api.github.com/repos/tus/tus-js-client","labels_url":"https://api.github.com/repos/tus/tus-js-client/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/tus/tus-js-client/issues/140/comments","events_url":"https://api.github.com/repos/tus/tus-js-client/issues/140/events","html_url":"https://github.com/tus/tus-js-client/pull/140","id":398706119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ0MzA5MDAy","number":140,"title":"Extend Defer length for nodejs environment","user":{"login":"ifedapoolarewaju","id":8383781,"node_id":"MDQ6VXNlcjgzODM3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/8383781?v=4","gravatar_id":"","url":"https://api.github.com/users/ifedapoolarewaju","html_url":"https://github.com/ifedapoolarewaju","followers_url":"https://api.github.com/users/ifedapoolarewaju/followers","following_url":"https://api.github.com/users/ifedapoolarewaju/following{/other_user}","gists_url":"https://api.github.com/users/ifedapoolarewaju/gists{/gist_id}","starred_url":"https://api.github.com/users/ifedapoolarewaju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifedapoolarewaju/subscriptions","organizations_url":"https://api.github.com/users/ifedapoolarewaju/orgs","repos_url":"https://api.github.com/users/ifedapoolarewaju/repos","events_url":"https://api.github.com/users/ifedapoolarewaju/events{/privacy}","received_events_url":"https://api.github.com/users/ifedapoolarewaju/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-01-13T22:23:43Z","updated_at":"2019-02-23T22:51:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tus/tus-js-client/pulls/140","html_url":"https://github.com/tus/tus-js-client/pull/140","diff_url":"https://github.com/tus/tus-js-client/pull/140.diff","patch_url":"https://github.com/tus/tus-js-client/pull/140.patch"},"body":"This PR extends the defer-length implementation so it can work in the nodejs environment"},"comment":{"url":"https://api.github.com/repos/tus/tus-js-client/issues/comments/466707197","html_url":"https://github.com/tus/tus-js-client/pull/140#issuecomment-466707197","issue_url":"https://api.github.com/repos/tus/tus-js-client/issues/140","id":466707197,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NjcwNzE5Nw==","user":{"login":"Acconut","id":1375043,"node_id":"MDQ6VXNlcjEzNzUwNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1375043?v=4","gravatar_id":"","url":"https://api.github.com/users/Acconut","html_url":"https://github.com/Acconut","followers_url":"https://api.github.com/users/Acconut/followers","following_url":"https://api.github.com/users/Acconut/following{/other_user}","gists_url":"https://api.github.com/users/Acconut/gists{/gist_id}","starred_url":"https://api.github.com/users/Acconut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acconut/subscriptions","organizations_url":"https://api.github.com/users/Acconut/orgs","repos_url":"https://api.github.com/users/Acconut/repos","events_url":"https://api.github.com/users/Acconut/events{/privacy}","received_events_url":"https://api.github.com/users/Acconut/received_events","type":"User","site_admin":false},"created_at":"2019-02-23T22:51:01Z","updated_at":"2019-02-23T22:51:01Z","author_association":"MEMBER","body":"Apologies for the delay! I haven't had a thorough look but here a two comments for now:\r\n\r\n> I changed from the use of [Tranforms](https://github.com/tus/tus-js-client/blob/master/lib/node/source.js#L92) to the use of direct streaming because we will be wrongly setting this stream size [here](https://github.com/tus/tus-js-client/blob/master/lib/node/source.js#L94) in the case that the value of `bytesToRead` exceeds the bytesAvailable (This is only likely when `deferredLength` is enabled).\r\n\r\nAFAIK, the `size` property is optional in the Node.js context and does not have to be present: https://github.com/tus/tus-js-client/blob/master/lib/node/request.js#L44\r\n\r\n> I also fixed some bugs that I spotted, e.g [bytesToSkip will always be 0](https://github.com/tus/tus-js-client/blob/master/lib/node/source.js#L87-L90)\r\n\r\nGood catch, thanks for pointing this out! This somehow feels like a bug or a feature that never worked from the beginning. I would like to investigate what I wanted to achieve with it."}}
other: {"actor":{"display_login":"Acconut"}}