payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments/314719766","pull_request_review_id":275949455,"id":314719766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDcxOTc2Ng==","diff_hunk":"@@ -46,12 +40,16 @@\n  *     object. This is what's happening above with `const { default: data }`, it's\n  *     destructuring the result of `import()` and assigning the default export\n  *     to a constant named `data`.\n+ *   - It's recommended that if you want to use an async function for this, you\n+ *     do this as an IIFE inside of `useEffect` — not make `useEffect`'s callback","path":"app/app.js","position":53,"original_position":53,"commit_id":"4758d8580c29e96a6606a8225fd7ec2aa9c63a51","original_commit_id":"1b528fe41dd68857ebe5f5b8780349c6c20b2c36","user":{"login":"aendrew","id":185041,"node_id":"MDQ6VXNlcjE4NTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/185041?v=4","gravatar_id":"","url":"https://api.github.com/users/aendrew","html_url":"https://github.com/aendrew","followers_url":"https://api.github.com/users/aendrew/followers","following_url":"https://api.github.com/users/aendrew/following{/other_user}","gists_url":"https://api.github.com/users/aendrew/gists{/gist_id}","starred_url":"https://api.github.com/users/aendrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aendrew/subscriptions","organizations_url":"https://api.github.com/users/aendrew/orgs","repos_url":"https://api.github.com/users/aendrew/repos","events_url":"https://api.github.com/users/aendrew/events{/privacy}","received_events_url":"https://api.github.com/users/aendrew/received_events","type":"User","site_admin":false},"body":"Done 👍 ","created_at":"2019-08-16T13:29:14Z","updated_at":"2019-08-16T13:29:15Z","html_url":"https://github.com/ft-interactive/starter-kit/pull/242#discussion_r314719766","pull_request_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments/314719766"},"html":{"href":"https://github.com/ft-interactive/starter-kit/pull/242#discussion_r314719766"},"pull_request":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242"}},"in_reply_to_id":314290511},"pull_request":{"url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242","id":294940797,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0OTQwNzk3","html_url":"https://github.com/ft-interactive/starter-kit/pull/242","diff_url":"https://github.com/ft-interactive/starter-kit/pull/242.diff","patch_url":"https://github.com/ft-interactive/starter-kit/pull/242.patch","issue_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/242","number":242,"state":"open","locked":false,"title":"Do SSR with Puppeteer at build-time instead of with JSDOM *every refresh*","user":{"login":"aendrew","id":185041,"node_id":"MDQ6VXNlcjE4NTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/185041?v=4","gravatar_id":"","url":"https://api.github.com/users/aendrew","html_url":"https://github.com/aendrew","followers_url":"https://api.github.com/users/aendrew/followers","following_url":"https://api.github.com/users/aendrew/following{/other_user}","gists_url":"https://api.github.com/users/aendrew/gists{/gist_id}","starred_url":"https://api.github.com/users/aendrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aendrew/subscriptions","organizations_url":"https://api.github.com/users/aendrew/orgs","repos_url":"https://api.github.com/users/aendrew/repos","events_url":"https://api.github.com/users/aendrew/events{/privacy}","received_events_url":"https://api.github.com/users/aendrew/received_events","type":"User","site_admin":false},"body":"The hope with this is that we can stop doing stupid hacky shit in order to ensure JSDOM is able to render things. This should also dramatically speed up the DX because it'll help HMR to work better.\r\n\r\n### Issues to resolve:\r\n\r\n- [x] Whatever sets `html.core` to `html.enhanced` doesn't seem to be firing\r\n- [x] `o-comments` doesn't seem to be working in dev builds (see above).\r\n- [x] `app/index.js` currently doesn't pass linting \r\n- [x] CI is failing because of running as root with --no-sandbox. Might need to use a CircleCI image.\r\n- [x] HMR isn't working for JS\r\n- [ ] ~HMR isn't working for CSS~ Forget it. 🙄 ","created_at":"2019-07-05T17:18:02Z","updated_at":"2019-08-16T13:29:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ccaeccea13b74d0a98bbfe3f6e5cf86464fa7c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242/commits","review_comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242/comments","review_comment_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/242/comments","statuses_url":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/4758d8580c29e96a6606a8225fd7ec2aa9c63a51","head":{"label":"ft-interactive:better-ssr","ref":"better-ssr","sha":"4758d8580c29e96a6606a8225fd7ec2aa9c63a51","user":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"repo":{"id":44748522,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc0ODUyMg==","name":"starter-kit","full_name":"ft-interactive/starter-kit","private":false,"owner":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ft-interactive/starter-kit","description":"A template for graphics pages","fork":false,"url":"https://api.github.com/repos/ft-interactive/starter-kit","forks_url":"https://api.github.com/repos/ft-interactive/starter-kit/forks","keys_url":"https://api.github.com/repos/ft-interactive/starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ft-interactive/starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ft-interactive/starter-kit/teams","hooks_url":"https://api.github.com/repos/ft-interactive/starter-kit/hooks","issue_events_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/ft-interactive/starter-kit/events","assignees_url":"https://api.github.com/repos/ft-interactive/starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/ft-interactive/starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/tags","blobs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/ft-interactive/starter-kit/languages","stargazers_url":"https://api.github.com/repos/ft-interactive/starter-kit/stargazers","contributors_url":"https://api.github.com/repos/ft-interactive/starter-kit/contributors","subscribers_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscribers","subscription_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscription","commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ft-interactive/starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/ft-interactive/starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ft-interactive/starter-kit/merges","archive_url":"https://api.github.com/repos/ft-interactive/starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ft-interactive/starter-kit/downloads","issues_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/ft-interactive/starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/ft-interactive/starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ft-interactive/starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/ft-interactive/starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/ft-interactive/starter-kit/deployments","created_at":"2015-10-22T13:54:04Z","updated_at":"2019-08-07T18:02:20Z","pushed_at":"2019-08-16T13:29:06Z","git_url":"git://github.com/ft-interactive/starter-kit.git","ssh_url":"git@github.com:ft-interactive/starter-kit.git","clone_url":"https://github.com/ft-interactive/starter-kit.git","svn_url":"https://github.com/ft-interactive/starter-kit","homepage":"","size":2040,"stargazers_count":43,"watchers_count":43,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":null,"forks":12,"open_issues":19,"watchers":43,"default_branch":"master"}},"base":{"label":"ft-interactive:v2","ref":"v2","sha":"2907faaa8d8edf9f19f318d71910fe33ef40dd22","user":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"repo":{"id":44748522,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc0ODUyMg==","name":"starter-kit","full_name":"ft-interactive/starter-kit","private":false,"owner":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ft-interactive/starter-kit","description":"A template for graphics pages","fork":false,"url":"https://api.github.com/repos/ft-interactive/starter-kit","forks_url":"https://api.github.com/repos/ft-interactive/starter-kit/forks","keys_url":"https://api.github.com/repos/ft-interactive/starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ft-interactive/starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ft-interactive/starter-kit/teams","hooks_url":"https://api.github.com/repos/ft-interactive/starter-kit/hooks","issue_events_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/ft-interactive/starter-kit/events","assignees_url":"https://api.github.com/repos/ft-interactive/starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/ft-interactive/starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/tags","blobs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/ft-interactive/starter-kit/languages","stargazers_url":"https://api.github.com/repos/ft-interactive/starter-kit/stargazers","contributors_url":"https://api.github.com/repos/ft-interactive/starter-kit/contributors","subscribers_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscribers","subscription_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscription","commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ft-interactive/starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/ft-interactive/starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ft-interactive/starter-kit/merges","archive_url":"https://api.github.com/repos/ft-interactive/starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ft-interactive/starter-kit/downloads","issues_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/ft-interactive/starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/ft-interactive/starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ft-interactive/starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/ft-interactive/starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/ft-interactive/starter-kit/deployments","created_at":"2015-10-22T13:54:04Z","updated_at":"2019-08-07T18:02:20Z","pushed_at":"2019-08-16T13:29:06Z","git_url":"git://github.com/ft-interactive/starter-kit.git","ssh_url":"git@github.com:ft-interactive/starter-kit.git","clone_url":"https://github.com/ft-interactive/starter-kit.git","svn_url":"https://github.com/ft-interactive/starter-kit","homepage":"","size":2040,"stargazers_count":43,"watchers_count":43,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":null,"forks":12,"open_issues":19,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242"},"html":{"href":"https://github.com/ft-interactive/starter-kit/pull/242"},"issue":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/issues/242"},"comments":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/4758d8580c29e96a6606a8225fd7ec2aa9c63a51"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"aendrew"}}