payload: {"action":"created","issue":{"url":"https://api.github.com/repos/juju/python-libjuju/issues/367","repository_url":"https://api.github.com/repos/juju/python-libjuju","labels_url":"https://api.github.com/repos/juju/python-libjuju/issues/367/labels{/name}","comments_url":"https://api.github.com/repos/juju/python-libjuju/issues/367/comments","events_url":"https://api.github.com/repos/juju/python-libjuju/issues/367/events","html_url":"https://github.com/juju/python-libjuju/pull/367","id":525771025,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzMzI4OTYw","number":367,"title":"Surpress KeyError when applications are missing","user":{"login":"SimonRichardson","id":2562584,"node_id":"MDQ6VXNlcjI1NjI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2562584?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonRichardson","html_url":"https://github.com/SimonRichardson","followers_url":"https://api.github.com/users/SimonRichardson/followers","following_url":"https://api.github.com/users/SimonRichardson/following{/other_user}","gists_url":"https://api.github.com/users/SimonRichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRichardson/subscriptions","organizations_url":"https://api.github.com/users/SimonRichardson/orgs","repos_url":"https://api.github.com/users/SimonRichardson/repos","events_url":"https://api.github.com/users/SimonRichardson/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRichardson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2019-11-20T12:24:10Z","updated_at":"2019-11-25T13:47:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/juju/python-libjuju/pulls/367","html_url":"https://github.com/juju/python-libjuju/pull/367","diff_url":"https://github.com/juju/python-libjuju/pull/367.diff","patch_url":"https://github.com/juju/python-libjuju/pull/367.patch"},"body":"The following surpresses a KeyError when a application or a remote\r\napplication is missing. Instead we should return None and correctly\r\nhandle that a application or a remote-application could be missing.\r\n\r\nThis should be safe to do so and the fact that an update from the\r\nall watcher should fill in the gaps eventually. If this is not the\r\ncase, we should in the future ensure that a remote-application can't\r\nraise index/key errors when data is missing.\r\n\r\nThe missing data when raised/thrown criples the library from being\r\nuseful, instead we should really handle all the cases these exist and\r\ncorrectly insert None or a fallback."},"comment":{"url":"https://api.github.com/repos/juju/python-libjuju/issues/comments/558162906","html_url":"https://github.com/juju/python-libjuju/pull/367#issuecomment-558162906","issue_url":"https://api.github.com/repos/juju/python-libjuju/issues/367","id":558162906,"node_id":"MDEyOklzc3VlQ29tbWVudDU1ODE2MjkwNg==","user":{"login":"SimonRichardson","id":2562584,"node_id":"MDQ6VXNlcjI1NjI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2562584?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonRichardson","html_url":"https://github.com/SimonRichardson","followers_url":"https://api.github.com/users/SimonRichardson/followers","following_url":"https://api.github.com/users/SimonRichardson/following{/other_user}","gists_url":"https://api.github.com/users/SimonRichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRichardson/subscriptions","organizations_url":"https://api.github.com/users/SimonRichardson/orgs","repos_url":"https://api.github.com/users/SimonRichardson/repos","events_url":"https://api.github.com/users/SimonRichardson/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRichardson/received_events","type":"User","site_admin":false},"created_at":"2019-11-25T13:47:24Z","updated_at":"2019-11-25T13:47:24Z","author_association":"MEMBER","body":"$$merge$$\r\n\r\nI'm going to merge this fix whilst we're still investigating #366 "}}
other: {"actor":{"display_login":"SimonRichardson"}}