payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments/353986356","pull_request_review_id":327152623,"id":353986356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mzk4NjM1Ng==","diff_hunk":"@@ -91,14 +93,14 @@ func TestGetAllAddressables(t *testing.T) {\n \t}\n \tfor _, tt := range tests {\n \t\tt.Run(tt.name, func(t *testing.T) {\n-\n \t\t\trr := httptest.NewRecorder()\n \t\t\tvar loggerMock = logger.NewMockClient()\n \t\t\trestGetAllAddressables(\n \t\t\t\trr,\n \t\t\t\tloggerMock,\n \t\t\t\ttt.dbMock,\n-\t\t\t\terrorconcept.NewErrorHandler(loggerMock))\n+\t\t\t\terrorconcept.NewErrorHandler(loggerMock),\n+\t\t\t\tconfiguration)","path":"internal/core/metadata/rest_addressable_test.go","position":46,"original_position":46,"commit_id":"f6e9efc7f8bf8b8b6d2005c51935b55977463005","original_commit_id":"f6e9efc7f8bf8b8b6d2005c51935b55977463005","user":{"login":"michaelestrin","id":464327,"node_id":"MDQ6VXNlcjQ2NDMyNw==","avatar_url":"https://avatars3.githubusercontent.com/u/464327?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelestrin","html_url":"https://github.com/michaelestrin","followers_url":"https://api.github.com/users/michaelestrin/followers","following_url":"https://api.github.com/users/michaelestrin/following{/other_user}","gists_url":"https://api.github.com/users/michaelestrin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelestrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelestrin/subscriptions","organizations_url":"https://api.github.com/users/michaelestrin/orgs","repos_url":"https://api.github.com/users/michaelestrin/repos","events_url":"https://api.github.com/users/michaelestrin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelestrin/received_events","type":"User","site_admin":false},"body":"Move your definition of `configuration` into the test loop so each iteration has its own cleanly initialized instance.","created_at":"2019-12-04T21:14:54Z","updated_at":"2019-12-04T21:34:54Z","html_url":"https://github.com/edgexfoundry/edgex-go/pull/2189#discussion_r353986356","pull_request_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments/353986356"},"html":{"href":"https://github.com/edgexfoundry/edgex-go/pull/2189#discussion_r353986356"},"pull_request":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189"}}},"pull_request":{"url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189","id":346342674,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2MzQyNjc0","html_url":"https://github.com/edgexfoundry/edgex-go/pull/2189","diff_url":"https://github.com/edgexfoundry/edgex-go/pull/2189.diff","patch_url":"https://github.com/edgexfoundry/edgex-go/pull/2189.patch","issue_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/2189","number":2189,"state":"open","locked":false,"title":"Refactor Metadata to remove Configuration global variable.","user":{"login":"akramtexas","id":40174952,"node_id":"MDQ6VXNlcjQwMTc0OTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40174952?v=4","gravatar_id":"","url":"https://api.github.com/users/akramtexas","html_url":"https://github.com/akramtexas","followers_url":"https://api.github.com/users/akramtexas/followers","following_url":"https://api.github.com/users/akramtexas/following{/other_user}","gists_url":"https://api.github.com/users/akramtexas/gists{/gist_id}","starred_url":"https://api.github.com/users/akramtexas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akramtexas/subscriptions","organizations_url":"https://api.github.com/users/akramtexas/orgs","repos_url":"https://api.github.com/users/akramtexas/repos","events_url":"https://api.github.com/users/akramtexas/events{/privacy}","received_events_url":"https://api.github.com/users/akramtexas/received_events","type":"User","site_admin":false},"body":"Fix #2023 ","created_at":"2019-11-27T17:00:04Z","updated_at":"2019-12-04T21:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2c016a7a9ecced47359ef1d6814d2a27a003bd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189/commits","review_comments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189/comments","review_comment_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/2189/comments","statuses_url":"https://api.github.com/repos/edgexfoundry/edgex-go/statuses/f6e9efc7f8bf8b8b6d2005c51935b55977463005","head":{"label":"akramtexas:refactor_metadata_remove_configuration_global_2023","ref":"refactor_metadata_remove_configuration_global_2023","sha":"f6e9efc7f8bf8b8b6d2005c51935b55977463005","user":{"login":"akramtexas","id":40174952,"node_id":"MDQ6VXNlcjQwMTc0OTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40174952?v=4","gravatar_id":"","url":"https://api.github.com/users/akramtexas","html_url":"https://github.com/akramtexas","followers_url":"https://api.github.com/users/akramtexas/followers","following_url":"https://api.github.com/users/akramtexas/following{/other_user}","gists_url":"https://api.github.com/users/akramtexas/gists{/gist_id}","starred_url":"https://api.github.com/users/akramtexas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akramtexas/subscriptions","organizations_url":"https://api.github.com/users/akramtexas/orgs","repos_url":"https://api.github.com/users/akramtexas/repos","events_url":"https://api.github.com/users/akramtexas/events{/privacy}","received_events_url":"https://api.github.com/users/akramtexas/received_events","type":"User","site_admin":false},"repo":{"id":136986176,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5ODYxNzY=","name":"edgex-go","full_name":"akramtexas/edgex-go","private":false,"owner":{"login":"akramtexas","id":40174952,"node_id":"MDQ6VXNlcjQwMTc0OTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40174952?v=4","gravatar_id":"","url":"https://api.github.com/users/akramtexas","html_url":"https://github.com/akramtexas","followers_url":"https://api.github.com/users/akramtexas/followers","following_url":"https://api.github.com/users/akramtexas/following{/other_user}","gists_url":"https://api.github.com/users/akramtexas/gists{/gist_id}","starred_url":"https://api.github.com/users/akramtexas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akramtexas/subscriptions","organizations_url":"https://api.github.com/users/akramtexas/orgs","repos_url":"https://api.github.com/users/akramtexas/repos","events_url":"https://api.github.com/users/akramtexas/events{/privacy}","received_events_url":"https://api.github.com/users/akramtexas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/akramtexas/edgex-go","description":"EdgeX Golang Services Monorepo","fork":true,"url":"https://api.github.com/repos/akramtexas/edgex-go","forks_url":"https://api.github.com/repos/akramtexas/edgex-go/forks","keys_url":"https://api.github.com/repos/akramtexas/edgex-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akramtexas/edgex-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akramtexas/edgex-go/teams","hooks_url":"https://api.github.com/repos/akramtexas/edgex-go/hooks","issue_events_url":"https://api.github.com/repos/akramtexas/edgex-go/issues/events{/number}","events_url":"https://api.github.com/repos/akramtexas/edgex-go/events","assignees_url":"https://api.github.com/repos/akramtexas/edgex-go/assignees{/user}","branches_url":"https://api.github.com/repos/akramtexas/edgex-go/branches{/branch}","tags_url":"https://api.github.com/repos/akramtexas/edgex-go/tags","blobs_url":"https://api.github.com/repos/akramtexas/edgex-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akramtexas/edgex-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akramtexas/edgex-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/akramtexas/edgex-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akramtexas/edgex-go/statuses/{sha}","languages_url":"https://api.github.com/repos/akramtexas/edgex-go/languages","stargazers_url":"https://api.github.com/repos/akramtexas/edgex-go/stargazers","contributors_url":"https://api.github.com/repos/akramtexas/edgex-go/contributors","subscribers_url":"https://api.github.com/repos/akramtexas/edgex-go/subscribers","subscription_url":"https://api.github.com/repos/akramtexas/edgex-go/subscription","commits_url":"https://api.github.com/repos/akramtexas/edgex-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/akramtexas/edgex-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/akramtexas/edgex-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/akramtexas/edgex-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/akramtexas/edgex-go/contents/{+path}","compare_url":"https://api.github.com/repos/akramtexas/edgex-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akramtexas/edgex-go/merges","archive_url":"https://api.github.com/repos/akramtexas/edgex-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akramtexas/edgex-go/downloads","issues_url":"https://api.github.com/repos/akramtexas/edgex-go/issues{/number}","pulls_url":"https://api.github.com/repos/akramtexas/edgex-go/pulls{/number}","milestones_url":"https://api.github.com/repos/akramtexas/edgex-go/milestones{/number}","notifications_url":"https://api.github.com/repos/akramtexas/edgex-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akramtexas/edgex-go/labels{/name}","releases_url":"https://api.github.com/repos/akramtexas/edgex-go/releases{/id}","deployments_url":"https://api.github.com/repos/akramtexas/edgex-go/deployments","created_at":"2018-06-11T22:08:10Z","updated_at":"2019-12-04T19:14:19Z","pushed_at":"2019-12-04T19:16:30Z","git_url":"git://github.com/akramtexas/edgex-go.git","ssh_url":"git@github.com:akramtexas/edgex-go.git","clone_url":"https://github.com/akramtexas/edgex-go.git","svn_url":"https://github.com/akramtexas/edgex-go","homepage":null,"size":153919,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edgexfoundry:master","ref":"master","sha":"eb8c69b40c30c044044a3440be54663c5396f06a","user":{"login":"edgexfoundry","id":27781926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzgxOTI2","avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":119106012,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMDYwMTI=","name":"edgex-go","full_name":"edgexfoundry/edgex-go","private":false,"owner":{"login":"edgexfoundry","id":27781926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzgxOTI2","avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edgexfoundry/edgex-go","description":"EdgeX Golang Services Monorepo | Owner: Core/Support WG","fork":false,"url":"https://api.github.com/repos/edgexfoundry/edgex-go","forks_url":"https://api.github.com/repos/edgexfoundry/edgex-go/forks","keys_url":"https://api.github.com/repos/edgexfoundry/edgex-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgexfoundry/edgex-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgexfoundry/edgex-go/teams","hooks_url":"https://api.github.com/repos/edgexfoundry/edgex-go/hooks","issue_events_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/events{/number}","events_url":"https://api.github.com/repos/edgexfoundry/edgex-go/events","assignees_url":"https://api.github.com/repos/edgexfoundry/edgex-go/assignees{/user}","branches_url":"https://api.github.com/repos/edgexfoundry/edgex-go/branches{/branch}","tags_url":"https://api.github.com/repos/edgexfoundry/edgex-go/tags","blobs_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgexfoundry/edgex-go/statuses/{sha}","languages_url":"https://api.github.com/repos/edgexfoundry/edgex-go/languages","stargazers_url":"https://api.github.com/repos/edgexfoundry/edgex-go/stargazers","contributors_url":"https://api.github.com/repos/edgexfoundry/edgex-go/contributors","subscribers_url":"https://api.github.com/repos/edgexfoundry/edgex-go/subscribers","subscription_url":"https://api.github.com/repos/edgexfoundry/edgex-go/subscription","commits_url":"https://api.github.com/repos/edgexfoundry/edgex-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgexfoundry/edgex-go/contents/{+path}","compare_url":"https://api.github.com/repos/edgexfoundry/edgex-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgexfoundry/edgex-go/merges","archive_url":"https://api.github.com/repos/edgexfoundry/edgex-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgexfoundry/edgex-go/downloads","issues_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues{/number}","pulls_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls{/number}","milestones_url":"https://api.github.com/repos/edgexfoundry/edgex-go/milestones{/number}","notifications_url":"https://api.github.com/repos/edgexfoundry/edgex-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgexfoundry/edgex-go/labels{/name}","releases_url":"https://api.github.com/repos/edgexfoundry/edgex-go/releases{/id}","deployments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/deployments","created_at":"2018-01-26T21:37:55Z","updated_at":"2019-12-04T19:32:52Z","pushed_at":"2019-12-04T21:15:49Z","git_url":"git://github.com/edgexfoundry/edgex-go.git","ssh_url":"git@github.com:edgexfoundry/edgex-go.git","clone_url":"https://github.com/edgexfoundry/edgex-go.git","svn_url":"https://github.com/edgexfoundry/edgex-go","homepage":"","size":154714,"stargazers_count":487,"watchers_count":487,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":233,"open_issues":134,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189"},"html":{"href":"https://github.com/edgexfoundry/edgex-go/pull/2189"},"issue":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/2189"},"comments":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/2189/comments"},"review_comments":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189/comments"},"review_comment":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/2189/commits"},"statuses":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/statuses/f6e9efc7f8bf8b8b6d2005c51935b55977463005"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"michaelestrin"}}