payload: {"action":"created","comment":{"url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/comments/309102338","pull_request_review_id":268863608,"id":309102338,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTEwMjMzOA==","diff_hunk":"@@ -194,3 +195,24 @@ def test_pending_transfers_are_cleared(\n         assert confirmation_sender.pending_transaction_queue.qsize() == 0\n     finally:\n         greenlet.kill()\n+\n+\n+def test_do_not_confirm_as_non_bridge_validator(\n+    confirmation_sender_with_non_validator_account, transfer_queue, transfer_event\n+):\n+    try:\n+        greenlet = gevent.spawn(confirmation_sender_with_non_validator_account.run)\n+\n+        assert (\n+            confirmation_sender_with_non_validator_account.pending_transaction_queue.empty()\n+        )\n+\n+        transfer_queue.put(transfer_event)\n+        gevent.sleep(0.1)","path":"tools/bridge/tests/test_confirmation_sender.py","position":59,"original_position":58,"commit_id":"bb27a5ea34905c770078c316c1bf5e2318a7ab41","original_commit_id":"bb27a5ea34905c770078c316c1bf5e2318a7ab41","user":{"login":"weilbith","id":12543647,"node_id":"MDQ6VXNlcjEyNTQzNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12543647?v=4","gravatar_id":"","url":"https://api.github.com/users/weilbith","html_url":"https://github.com/weilbith","followers_url":"https://api.github.com/users/weilbith/followers","following_url":"https://api.github.com/users/weilbith/following{/other_user}","gists_url":"https://api.github.com/users/weilbith/gists{/gist_id}","starred_url":"https://api.github.com/users/weilbith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weilbith/subscriptions","organizations_url":"https://api.github.com/users/weilbith/orgs","repos_url":"https://api.github.com/users/weilbith/repos","events_url":"https://api.github.com/users/weilbith/events{/privacy}","received_events_url":"https://api.github.com/users/weilbith/received_events","type":"User","site_admin":false},"body":"Yeah, I also thought about it while taking the template from you. But as you I can't come up with a better solution for now. I would add a TODO comment on it, just that it is not totally forgotten. Especially when we do some live chain tests and this case fails, the developer see this comment and get an hint.","created_at":"2019-07-31T08:41:06Z","updated_at":"2019-07-31T08:41:06Z","html_url":"https://github.com/trustlines-protocol/blockchain/pull/268#discussion_r309102338","pull_request_url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/comments/309102338"},"html":{"href":"https://github.com/trustlines-protocol/blockchain/pull/268#discussion_r309102338"},"pull_request":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268"}},"in_reply_to_id":309080647},"pull_request":{"url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268","id":301623814,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNjIzODE0","html_url":"https://github.com/trustlines-protocol/blockchain/pull/268","diff_url":"https://github.com/trustlines-protocol/blockchain/pull/268.diff","patch_url":"https://github.com/trustlines-protocol/blockchain/pull/268.patch","issue_url":"https://api.github.com/repos/trustlines-protocol/blockchain/issues/268","number":268,"state":"open","locked":false,"title":"Feature/bridge client account verification","user":{"login":"weilbith","id":12543647,"node_id":"MDQ6VXNlcjEyNTQzNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12543647?v=4","gravatar_id":"","url":"https://api.github.com/users/weilbith","html_url":"https://github.com/weilbith","followers_url":"https://api.github.com/users/weilbith/followers","following_url":"https://api.github.com/users/weilbith/following{/other_user}","gists_url":"https://api.github.com/users/weilbith/gists{/gist_id}","starred_url":"https://api.github.com/users/weilbith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weilbith/subscriptions","organizations_url":"https://api.github.com/users/weilbith/orgs","repos_url":"https://api.github.com/users/weilbith/repos","events_url":"https://api.github.com/users/weilbith/events{/privacy}","received_events_url":"https://api.github.com/users/weilbith/received_events","type":"User","site_admin":false},"body":"Closes #265\r\n","created_at":"2019-07-26T17:28:06Z","updated_at":"2019-07-31T08:41:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16c5a2638e1410a3d1ac1aedf1d30b853f51afc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/trustlines-protocol/blockchain/milestones/12","html_url":"https://github.com/trustlines-protocol/blockchain/milestone/12","labels_url":"https://api.github.com/repos/trustlines-protocol/blockchain/milestones/12/labels","id":4529049,"node_id":"MDk6TWlsZXN0b25lNDUyOTA0OQ==","number":12,"title":"Sprint 08.08.2019","description":"","creator":{"login":"andfletcher","id":39694712,"node_id":"MDQ6VXNlcjM5Njk0NzEy","avatar_url":"https://avatars0.githubusercontent.com/u/39694712?v=4","gravatar_id":"","url":"https://api.github.com/users/andfletcher","html_url":"https://github.com/andfletcher","followers_url":"https://api.github.com/users/andfletcher/followers","following_url":"https://api.github.com/users/andfletcher/following{/other_user}","gists_url":"https://api.github.com/users/andfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/andfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andfletcher/subscriptions","organizations_url":"https://api.github.com/users/andfletcher/orgs","repos_url":"https://api.github.com/users/andfletcher/repos","events_url":"https://api.github.com/users/andfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/andfletcher/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2019-07-29T08:54:34Z","updated_at":"2019-07-30T10:02:29Z","due_on":"2019-08-08T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268/commits","review_comments_url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268/comments","review_comment_url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trustlines-protocol/blockchain/issues/268/comments","statuses_url":"https://api.github.com/repos/trustlines-protocol/blockchain/statuses/bb27a5ea34905c770078c316c1bf5e2318a7ab41","head":{"label":"weilbith:feature/bridge-client-account-verification","ref":"feature/bridge-client-account-verification","sha":"bb27a5ea34905c770078c316c1bf5e2318a7ab41","user":{"login":"weilbith","id":12543647,"node_id":"MDQ6VXNlcjEyNTQzNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12543647?v=4","gravatar_id":"","url":"https://api.github.com/users/weilbith","html_url":"https://github.com/weilbith","followers_url":"https://api.github.com/users/weilbith/followers","following_url":"https://api.github.com/users/weilbith/following{/other_user}","gists_url":"https://api.github.com/users/weilbith/gists{/gist_id}","starred_url":"https://api.github.com/users/weilbith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weilbith/subscriptions","organizations_url":"https://api.github.com/users/weilbith/orgs","repos_url":"https://api.github.com/users/weilbith/repos","events_url":"https://api.github.com/users/weilbith/events{/privacy}","received_events_url":"https://api.github.com/users/weilbith/received_events","type":"User","site_admin":false},"repo":{"id":192491058,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI0OTEwNTg=","name":"blockchain","full_name":"weilbith/blockchain","private":false,"owner":{"login":"weilbith","id":12543647,"node_id":"MDQ6VXNlcjEyNTQzNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12543647?v=4","gravatar_id":"","url":"https://api.github.com/users/weilbith","html_url":"https://github.com/weilbith","followers_url":"https://api.github.com/users/weilbith/followers","following_url":"https://api.github.com/users/weilbith/following{/other_user}","gists_url":"https://api.github.com/users/weilbith/gists{/gist_id}","starred_url":"https://api.github.com/users/weilbith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weilbith/subscriptions","organizations_url":"https://api.github.com/users/weilbith/orgs","repos_url":"https://api.github.com/users/weilbith/repos","events_url":"https://api.github.com/users/weilbith/events{/privacy}","received_events_url":"https://api.github.com/users/weilbith/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weilbith/blockchain","description":null,"fork":true,"url":"https://api.github.com/repos/weilbith/blockchain","forks_url":"https://api.github.com/repos/weilbith/blockchain/forks","keys_url":"https://api.github.com/repos/weilbith/blockchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weilbith/blockchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weilbith/blockchain/teams","hooks_url":"https://api.github.com/repos/weilbith/blockchain/hooks","issue_events_url":"https://api.github.com/repos/weilbith/blockchain/issues/events{/number}","events_url":"https://api.github.com/repos/weilbith/blockchain/events","assignees_url":"https://api.github.com/repos/weilbith/blockchain/assignees{/user}","branches_url":"https://api.github.com/repos/weilbith/blockchain/branches{/branch}","tags_url":"https://api.github.com/repos/weilbith/blockchain/tags","blobs_url":"https://api.github.com/repos/weilbith/blockchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weilbith/blockchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weilbith/blockchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/weilbith/blockchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weilbith/blockchain/statuses/{sha}","languages_url":"https://api.github.com/repos/weilbith/blockchain/languages","stargazers_url":"https://api.github.com/repos/weilbith/blockchain/stargazers","contributors_url":"https://api.github.com/repos/weilbith/blockchain/contributors","subscribers_url":"https://api.github.com/repos/weilbith/blockchain/subscribers","subscription_url":"https://api.github.com/repos/weilbith/blockchain/subscription","commits_url":"https://api.github.com/repos/weilbith/blockchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/weilbith/blockchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/weilbith/blockchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/weilbith/blockchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/weilbith/blockchain/contents/{+path}","compare_url":"https://api.github.com/repos/weilbith/blockchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weilbith/blockchain/merges","archive_url":"https://api.github.com/repos/weilbith/blockchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weilbith/blockchain/downloads","issues_url":"https://api.github.com/repos/weilbith/blockchain/issues{/number}","pulls_url":"https://api.github.com/repos/weilbith/blockchain/pulls{/number}","milestones_url":"https://api.github.com/repos/weilbith/blockchain/milestones{/number}","notifications_url":"https://api.github.com/repos/weilbith/blockchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weilbith/blockchain/labels{/name}","releases_url":"https://api.github.com/repos/weilbith/blockchain/releases{/id}","deployments_url":"https://api.github.com/repos/weilbith/blockchain/deployments","created_at":"2019-06-18T07:42:37Z","updated_at":"2019-06-18T07:42:41Z","pushed_at":"2019-07-29T13:45:11Z","git_url":"git://github.com/weilbith/blockchain.git","ssh_url":"git@github.com:weilbith/blockchain.git","clone_url":"https://github.com/weilbith/blockchain.git","svn_url":"https://github.com/weilbith/blockchain","homepage":null,"size":595,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trustlines-protocol:master","ref":"master","sha":"5a54d4105443fcc51eaf91fe1f9537b89f7d5253","user":{"login":"trustlines-protocol","id":44964337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTY0MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/44964337?v=4","gravatar_id":"","url":"https://api.github.com/users/trustlines-protocol","html_url":"https://github.com/trustlines-protocol","followers_url":"https://api.github.com/users/trustlines-protocol/followers","following_url":"https://api.github.com/users/trustlines-protocol/following{/other_user}","gists_url":"https://api.github.com/users/trustlines-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/trustlines-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustlines-protocol/subscriptions","organizations_url":"https://api.github.com/users/trustlines-protocol/orgs","repos_url":"https://api.github.com/users/trustlines-protocol/repos","events_url":"https://api.github.com/users/trustlines-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/trustlines-protocol/received_events","type":"Organization","site_admin":false},"repo":{"id":171286001,"node_id":"MDEwOlJlcG9zaXRvcnkxNzEyODYwMDE=","name":"blockchain","full_name":"trustlines-protocol/blockchain","private":false,"owner":{"login":"trustlines-protocol","id":44964337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTY0MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/44964337?v=4","gravatar_id":"","url":"https://api.github.com/users/trustlines-protocol","html_url":"https://github.com/trustlines-protocol","followers_url":"https://api.github.com/users/trustlines-protocol/followers","following_url":"https://api.github.com/users/trustlines-protocol/following{/other_user}","gists_url":"https://api.github.com/users/trustlines-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/trustlines-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustlines-protocol/subscriptions","organizations_url":"https://api.github.com/users/trustlines-protocol/orgs","repos_url":"https://api.github.com/users/trustlines-protocol/repos","events_url":"https://api.github.com/users/trustlines-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/trustlines-protocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trustlines-protocol/blockchain","description":null,"fork":false,"url":"https://api.github.com/repos/trustlines-protocol/blockchain","forks_url":"https://api.github.com/repos/trustlines-protocol/blockchain/forks","keys_url":"https://api.github.com/repos/trustlines-protocol/blockchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustlines-protocol/blockchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustlines-protocol/blockchain/teams","hooks_url":"https://api.github.com/repos/trustlines-protocol/blockchain/hooks","issue_events_url":"https://api.github.com/repos/trustlines-protocol/blockchain/issues/events{/number}","events_url":"https://api.github.com/repos/trustlines-protocol/blockchain/events","assignees_url":"https://api.github.com/repos/trustlines-protocol/blockchain/assignees{/user}","branches_url":"https://api.github.com/repos/trustlines-protocol/blockchain/branches{/branch}","tags_url":"https://api.github.com/repos/trustlines-protocol/blockchain/tags","blobs_url":"https://api.github.com/repos/trustlines-protocol/blockchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustlines-protocol/blockchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustlines-protocol/blockchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustlines-protocol/blockchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustlines-protocol/blockchain/statuses/{sha}","languages_url":"https://api.github.com/repos/trustlines-protocol/blockchain/languages","stargazers_url":"https://api.github.com/repos/trustlines-protocol/blockchain/stargazers","contributors_url":"https://api.github.com/repos/trustlines-protocol/blockchain/contributors","subscribers_url":"https://api.github.com/repos/trustlines-protocol/blockchain/subscribers","subscription_url":"https://api.github.com/repos/trustlines-protocol/blockchain/subscription","commits_url":"https://api.github.com/repos/trustlines-protocol/blockchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustlines-protocol/blockchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustlines-protocol/blockchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustlines-protocol/blockchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustlines-protocol/blockchain/contents/{+path}","compare_url":"https://api.github.com/repos/trustlines-protocol/blockchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustlines-protocol/blockchain/merges","archive_url":"https://api.github.com/repos/trustlines-protocol/blockchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustlines-protocol/blockchain/downloads","issues_url":"https://api.github.com/repos/trustlines-protocol/blockchain/issues{/number}","pulls_url":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls{/number}","milestones_url":"https://api.github.com/repos/trustlines-protocol/blockchain/milestones{/number}","notifications_url":"https://api.github.com/repos/trustlines-protocol/blockchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustlines-protocol/blockchain/labels{/name}","releases_url":"https://api.github.com/repos/trustlines-protocol/blockchain/releases{/id}","deployments_url":"https://api.github.com/repos/trustlines-protocol/blockchain/deployments","created_at":"2019-02-18T13:07:11Z","updated_at":"2019-07-30T10:02:32Z","pushed_at":"2019-07-30T10:02:30Z","git_url":"git://github.com/trustlines-protocol/blockchain.git","ssh_url":"git@github.com:trustlines-protocol/blockchain.git","clone_url":"https://github.com/trustlines-protocol/blockchain.git","svn_url":"https://github.com/trustlines-protocol/blockchain","homepage":null,"size":584,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268"},"html":{"href":"https://github.com/trustlines-protocol/blockchain/pull/268"},"issue":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/issues/268"},"comments":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/trustlines-protocol/blockchain/statuses/bb27a5ea34905c770078c316c1bf5e2318a7ab41"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"weilbith"}}