payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dwaite/cookiejar/pulls/comments/360781119","pull_request_review_id":335728755,"id":360781119,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDc4MTExOQ==","diff_hunk":"@@ -74,6 +74,10 @@\n       higher = Cookie.from_set_cookie 'http://foo.com/bar/baz/', 'foo=bar;path=/bar/'\n       CookieValidation.validate_cookie('http://foo.com/bar/baz/', higher)\n     end\n+    it 'should accept SameSite attribute' do","path":"spec/cookie_validation_spec.rb","position":4,"original_position":4,"commit_id":"7c687d052d61fcf8a8c7a0364cc0953693569f2c","original_commit_id":"7c687d052d61fcf8a8c7a0364cc0953693569f2c","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2019-12-23T06:38:32Z","updated_at":"2019-12-23T06:38:33Z","html_url":"https://github.com/dwaite/cookiejar/pull/30#discussion_r360781119","pull_request_url":"https://api.github.com/repos/dwaite/cookiejar/pulls/30","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dwaite/cookiejar/pulls/comments/360781119"},"html":{"href":"https://github.com/dwaite/cookiejar/pull/30#discussion_r360781119"},"pull_request":{"href":"https://api.github.com/repos/dwaite/cookiejar/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/dwaite/cookiejar/pulls/30","id":356201055,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2MjAxMDU1","html_url":"https://github.com/dwaite/cookiejar/pull/30","diff_url":"https://github.com/dwaite/cookiejar/pull/30.diff","patch_url":"https://github.com/dwaite/cookiejar/pull/30.patch","issue_url":"https://api.github.com/repos/dwaite/cookiejar/issues/30","number":30,"state":"open","locked":false,"title":"Add same_site attribute and tests","user":{"login":"p","id":125612,"node_id":"MDQ6VXNlcjEyNTYxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/125612?v=4","gravatar_id":"","url":"https://api.github.com/users/p","html_url":"https://github.com/p","followers_url":"https://api.github.com/users/p/followers","following_url":"https://api.github.com/users/p/following{/other_user}","gists_url":"https://api.github.com/users/p/gists{/gist_id}","starred_url":"https://api.github.com/users/p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p/subscriptions","organizations_url":"https://api.github.com/users/p/orgs","repos_url":"https://api.github.com/users/p/repos","events_url":"https://api.github.com/users/p/events{/privacy}","received_events_url":"https://api.github.com/users/p/received_events","type":"User","site_admin":false},"body":"The commit https://github.com/dwaite/cookiejar/commit/adb79c0a14c2b347c5289e79379a1acfe34bf388 has as its message \"add support for samesite cookie\". It actually only makes the validator recognize the samesite attribute, but does not expose the value via the cookie object and does not add any tests.\r\n\r\nThis PR adds the same_site attribute (note that the instance variable name was changed to @same_site from @samesite to be consistent with http_only/httponly) and adds tests.","created_at":"2019-12-23T06:38:27Z","updated_at":"2019-12-23T06:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"386e0d515dbeee1180693dbd191c0a75cbefe9f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dwaite/cookiejar/pulls/30/commits","review_comments_url":"https://api.github.com/repos/dwaite/cookiejar/pulls/30/comments","review_comment_url":"https://api.github.com/repos/dwaite/cookiejar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dwaite/cookiejar/issues/30/comments","statuses_url":"https://api.github.com/repos/dwaite/cookiejar/statuses/7c687d052d61fcf8a8c7a0364cc0953693569f2c","head":{"label":"p-push:same-site","ref":"same-site","sha":"7c687d052d61fcf8a8c7a0364cc0953693569f2c","user":{"login":"p-push","id":3210923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTA5MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3210923?v=4","gravatar_id":"","url":"https://api.github.com/users/p-push","html_url":"https://github.com/p-push","followers_url":"https://api.github.com/users/p-push/followers","following_url":"https://api.github.com/users/p-push/following{/other_user}","gists_url":"https://api.github.com/users/p-push/gists{/gist_id}","starred_url":"https://api.github.com/users/p-push/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-push/subscriptions","organizations_url":"https://api.github.com/users/p-push/orgs","repos_url":"https://api.github.com/users/p-push/repos","events_url":"https://api.github.com/users/p-push/events{/privacy}","received_events_url":"https://api.github.com/users/p-push/received_events","type":"Organization","site_admin":false},"repo":{"id":229689035,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2ODkwMzU=","name":"cookiejar","full_name":"p-push/cookiejar","private":false,"owner":{"login":"p-push","id":3210923,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTA5MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3210923?v=4","gravatar_id":"","url":"https://api.github.com/users/p-push","html_url":"https://github.com/p-push","followers_url":"https://api.github.com/users/p-push/followers","following_url":"https://api.github.com/users/p-push/following{/other_user}","gists_url":"https://api.github.com/users/p-push/gists{/gist_id}","starred_url":"https://api.github.com/users/p-push/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-push/subscriptions","organizations_url":"https://api.github.com/users/p-push/orgs","repos_url":"https://api.github.com/users/p-push/repos","events_url":"https://api.github.com/users/p-push/events{/privacy}","received_events_url":"https://api.github.com/users/p-push/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/p-push/cookiejar","description":"Manage client-side HTTP cookies in Ruby","fork":true,"url":"https://api.github.com/repos/p-push/cookiejar","forks_url":"https://api.github.com/repos/p-push/cookiejar/forks","keys_url":"https://api.github.com/repos/p-push/cookiejar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p-push/cookiejar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p-push/cookiejar/teams","hooks_url":"https://api.github.com/repos/p-push/cookiejar/hooks","issue_events_url":"https://api.github.com/repos/p-push/cookiejar/issues/events{/number}","events_url":"https://api.github.com/repos/p-push/cookiejar/events","assignees_url":"https://api.github.com/repos/p-push/cookiejar/assignees{/user}","branches_url":"https://api.github.com/repos/p-push/cookiejar/branches{/branch}","tags_url":"https://api.github.com/repos/p-push/cookiejar/tags","blobs_url":"https://api.github.com/repos/p-push/cookiejar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p-push/cookiejar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p-push/cookiejar/git/refs{/sha}","trees_url":"https://api.github.com/repos/p-push/cookiejar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p-push/cookiejar/statuses/{sha}","languages_url":"https://api.github.com/repos/p-push/cookiejar/languages","stargazers_url":"https://api.github.com/repos/p-push/cookiejar/stargazers","contributors_url":"https://api.github.com/repos/p-push/cookiejar/contributors","subscribers_url":"https://api.github.com/repos/p-push/cookiejar/subscribers","subscription_url":"https://api.github.com/repos/p-push/cookiejar/subscription","commits_url":"https://api.github.com/repos/p-push/cookiejar/commits{/sha}","git_commits_url":"https://api.github.com/repos/p-push/cookiejar/git/commits{/sha}","comments_url":"https://api.github.com/repos/p-push/cookiejar/comments{/number}","issue_comment_url":"https://api.github.com/repos/p-push/cookiejar/issues/comments{/number}","contents_url":"https://api.github.com/repos/p-push/cookiejar/contents/{+path}","compare_url":"https://api.github.com/repos/p-push/cookiejar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p-push/cookiejar/merges","archive_url":"https://api.github.com/repos/p-push/cookiejar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p-push/cookiejar/downloads","issues_url":"https://api.github.com/repos/p-push/cookiejar/issues{/number}","pulls_url":"https://api.github.com/repos/p-push/cookiejar/pulls{/number}","milestones_url":"https://api.github.com/repos/p-push/cookiejar/milestones{/number}","notifications_url":"https://api.github.com/repos/p-push/cookiejar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p-push/cookiejar/labels{/name}","releases_url":"https://api.github.com/repos/p-push/cookiejar/releases{/id}","deployments_url":"https://api.github.com/repos/p-push/cookiejar/deployments","created_at":"2019-12-23T06:16:09Z","updated_at":"2019-12-23T06:16:11Z","pushed_at":"2019-12-23T06:36:36Z","git_url":"git://github.com/p-push/cookiejar.git","ssh_url":"git@github.com:p-push/cookiejar.git","clone_url":"https://github.com/p-push/cookiejar.git","svn_url":"https://github.com/p-push/cookiejar","homepage":"","size":131,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dwaite:master","ref":"master","sha":"adb79c0a14c2b347c5289e79379a1acfe34bf388","user":{"login":"dwaite","id":4517,"node_id":"MDQ6VXNlcjQ1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4517?v=4","gravatar_id":"","url":"https://api.github.com/users/dwaite","html_url":"https://github.com/dwaite","followers_url":"https://api.github.com/users/dwaite/followers","following_url":"https://api.github.com/users/dwaite/following{/other_user}","gists_url":"https://api.github.com/users/dwaite/gists{/gist_id}","starred_url":"https://api.github.com/users/dwaite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwaite/subscriptions","organizations_url":"https://api.github.com/users/dwaite/orgs","repos_url":"https://api.github.com/users/dwaite/repos","events_url":"https://api.github.com/users/dwaite/events{/privacy}","received_events_url":"https://api.github.com/users/dwaite/received_events","type":"User","site_admin":false},"repo":{"id":294509,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ1MDk=","name":"cookiejar","full_name":"dwaite/cookiejar","private":false,"owner":{"login":"dwaite","id":4517,"node_id":"MDQ6VXNlcjQ1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4517?v=4","gravatar_id":"","url":"https://api.github.com/users/dwaite","html_url":"https://github.com/dwaite","followers_url":"https://api.github.com/users/dwaite/followers","following_url":"https://api.github.com/users/dwaite/following{/other_user}","gists_url":"https://api.github.com/users/dwaite/gists{/gist_id}","starred_url":"https://api.github.com/users/dwaite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwaite/subscriptions","organizations_url":"https://api.github.com/users/dwaite/orgs","repos_url":"https://api.github.com/users/dwaite/repos","events_url":"https://api.github.com/users/dwaite/events{/privacy}","received_events_url":"https://api.github.com/users/dwaite/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dwaite/cookiejar","description":"Manage client-side HTTP cookies in Ruby","fork":false,"url":"https://api.github.com/repos/dwaite/cookiejar","forks_url":"https://api.github.com/repos/dwaite/cookiejar/forks","keys_url":"https://api.github.com/repos/dwaite/cookiejar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwaite/cookiejar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwaite/cookiejar/teams","hooks_url":"https://api.github.com/repos/dwaite/cookiejar/hooks","issue_events_url":"https://api.github.com/repos/dwaite/cookiejar/issues/events{/number}","events_url":"https://api.github.com/repos/dwaite/cookiejar/events","assignees_url":"https://api.github.com/repos/dwaite/cookiejar/assignees{/user}","branches_url":"https://api.github.com/repos/dwaite/cookiejar/branches{/branch}","tags_url":"https://api.github.com/repos/dwaite/cookiejar/tags","blobs_url":"https://api.github.com/repos/dwaite/cookiejar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwaite/cookiejar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwaite/cookiejar/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwaite/cookiejar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwaite/cookiejar/statuses/{sha}","languages_url":"https://api.github.com/repos/dwaite/cookiejar/languages","stargazers_url":"https://api.github.com/repos/dwaite/cookiejar/stargazers","contributors_url":"https://api.github.com/repos/dwaite/cookiejar/contributors","subscribers_url":"https://api.github.com/repos/dwaite/cookiejar/subscribers","subscription_url":"https://api.github.com/repos/dwaite/cookiejar/subscription","commits_url":"https://api.github.com/repos/dwaite/cookiejar/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwaite/cookiejar/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwaite/cookiejar/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwaite/cookiejar/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwaite/cookiejar/contents/{+path}","compare_url":"https://api.github.com/repos/dwaite/cookiejar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwaite/cookiejar/merges","archive_url":"https://api.github.com/repos/dwaite/cookiejar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwaite/cookiejar/downloads","issues_url":"https://api.github.com/repos/dwaite/cookiejar/issues{/number}","pulls_url":"https://api.github.com/repos/dwaite/cookiejar/pulls{/number}","milestones_url":"https://api.github.com/repos/dwaite/cookiejar/milestones{/number}","notifications_url":"https://api.github.com/repos/dwaite/cookiejar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwaite/cookiejar/labels{/name}","releases_url":"https://api.github.com/repos/dwaite/cookiejar/releases{/id}","deployments_url":"https://api.github.com/repos/dwaite/cookiejar/deployments","created_at":"2009-09-01T17:22:07Z","updated_at":"2019-12-21T09:55:22Z","pushed_at":"2019-12-23T06:38:28Z","git_url":"git://github.com/dwaite/cookiejar.git","ssh_url":"git@github.com:dwaite/cookiejar.git","clone_url":"https://github.com/dwaite/cookiejar.git","svn_url":"https://github.com/dwaite/cookiejar","homepage":"","size":131,"stargazers_count":40,"watchers_count":40,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":45,"open_issues":7,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dwaite/cookiejar/pulls/30"},"html":{"href":"https://github.com/dwaite/cookiejar/pull/30"},"issue":{"href":"https://api.github.com/repos/dwaite/cookiejar/issues/30"},"comments":{"href":"https://api.github.com/repos/dwaite/cookiejar/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/dwaite/cookiejar/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/dwaite/cookiejar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dwaite/cookiejar/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/dwaite/cookiejar/statuses/7c687d052d61fcf8a8c7a0364cc0953693569f2c"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"houndci-bot"}}