payload: {"action":"created","issue":{"url":"https://api.github.com/repos/ExpediaDotCom/haystack/issues/537","repository_url":"https://api.github.com/repos/ExpediaDotCom/haystack","labels_url":"https://api.github.com/repos/ExpediaDotCom/haystack/issues/537/labels{/name}","comments_url":"https://api.github.com/repos/ExpediaDotCom/haystack/issues/537/comments","events_url":"https://api.github.com/repos/ExpediaDotCom/haystack/issues/537/events","html_url":"https://github.com/ExpediaDotCom/haystack/issues/537","id":365010794,"node_id":"MDU6SXNzdWUzNjUwMTA3OTQ=","number":537,"title":"[Feature Request] Improve detection of parent-child relationships","user":{"login":"worldtiki","id":1187103,"node_id":"MDQ6VXNlcjExODcxMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1187103?v=4","gravatar_id":"","url":"https://api.github.com/users/worldtiki","html_url":"https://github.com/worldtiki","followers_url":"https://api.github.com/users/worldtiki/followers","following_url":"https://api.github.com/users/worldtiki/following{/other_user}","gists_url":"https://api.github.com/users/worldtiki/gists{/gist_id}","starred_url":"https://api.github.com/users/worldtiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldtiki/subscriptions","organizations_url":"https://api.github.com/users/worldtiki/orgs","repos_url":"https://api.github.com/users/worldtiki/repos","events_url":"https://api.github.com/users/worldtiki/events{/privacy}","received_events_url":"https://api.github.com/users/worldtiki/received_events","type":"User","site_admin":false},"labels":[{"id":658537864,"node_id":"MDU6TGFiZWw2NTg1Mzc4NjQ=","url":"https://api.github.com/repos/ExpediaDotCom/haystack/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-09-28T19:21:56Z","updated_at":"2019-10-12T05:48:44Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"A service is only displayed in the service graph if a parent-child relationship is found.\r\nThis seems to be done in the [SpanAccumulator.scala](https://github.com/ExpediaDotCom/haystack-service-graph/blob/master/node-finder/src/main/scala/com/expedia/www/haystack/service/graph/node/finder/app/SpanAccumulator.scala) where it looks for 'cs', 'cr' and 'sr', 'ss' tags (to identify as client or server) and then tries to find span pairs based on if they share the same ids.\r\n\r\nIf a server service does not reporting tracing data (for eg: an external third party or a system that doesnt support distributed tracing) and we only have spans coming from the client service, this parent-child relationship is not established and the server service is not represented in the service graph.\r\n\r\nExcept from it's name, there is enough information to represent this service in the service graph as well it's stats (rate of calls, % of failures, etc).\r\n\r\nI'm not really sure how the implementation would look like. One option would be to extend the [idl](https://github.com/ExpediaDotCom/haystack-idl/blob/master/proto/span.proto#L31).\r\nCurrently it only supports the name of the local service. Adding the name of the remote service as an optional field would allow us to display the correct name on the service graph (as well as in the traces view)."},"comment":{"url":"https://api.github.com/repos/ExpediaDotCom/haystack/issues/comments/541288322","html_url":"https://github.com/ExpediaDotCom/haystack/issues/537#issuecomment-541288322","issue_url":"https://api.github.com/repos/ExpediaDotCom/haystack/issues/537","id":541288322,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MTI4ODMyMg==","user":{"login":"ashishagg","id":4974230,"node_id":"MDQ6VXNlcjQ5NzQyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4974230?v=4","gravatar_id":"","url":"https://api.github.com/users/ashishagg","html_url":"https://github.com/ashishagg","followers_url":"https://api.github.com/users/ashishagg/followers","following_url":"https://api.github.com/users/ashishagg/following{/other_user}","gists_url":"https://api.github.com/users/ashishagg/gists{/gist_id}","starred_url":"https://api.github.com/users/ashishagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashishagg/subscriptions","organizations_url":"https://api.github.com/users/ashishagg/orgs","repos_url":"https://api.github.com/users/ashishagg/repos","events_url":"https://api.github.com/users/ashishagg/events{/privacy}","received_events_url":"https://api.github.com/users/ashishagg/received_events","type":"User","site_admin":false},"created_at":"2019-10-12T05:48:44Z","updated_at":"2019-10-12T05:48:44Z","author_association":"CONTRIBUTOR","body":"Did you get a chance to try our ServiceInsights (beta) feature? You need to install newer haystack UI version"}}
other: {"actor":{"display_login":"ashishagg"}}