payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hshoff/vx/pulls/comments/323497011","pull_request_review_id":287120394,"id":323497011,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMzQ5NzAxMQ==","diff_hunk":"@@ -31,6 +31,7 @@\n     \"precommit\": \"lint-staged\",\n     \"setup\": \"yarn run build\",\n     \"test\": \"yarn run jest\",\n+    \"type\": \"nimbus typescript --build --reference-workspaces\",","path":"package.json","position":13,"original_position":13,"commit_id":"6934406356e2caa49daca90fb17e9a930fcde148","original_commit_id":"6934406356e2caa49daca90fb17e9a930fcde148","user":{"login":"milesj","id":143744,"node_id":"MDQ6VXNlcjE0Mzc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/143744?v=4","gravatar_id":"","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"body":"Should only emit declarations, otherwise the TS build would overwrite the Babel build.","created_at":"2019-09-11T23:07:33Z","updated_at":"2019-09-11T23:07:33Z","html_url":"https://github.com/hshoff/vx/pull/488#discussion_r323497011","pull_request_url":"https://api.github.com/repos/hshoff/vx/pulls/488","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hshoff/vx/pulls/comments/323497011"},"html":{"href":"https://github.com/hshoff/vx/pull/488#discussion_r323497011"},"pull_request":{"href":"https://api.github.com/repos/hshoff/vx/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/hshoff/vx/pulls/488","id":316651084,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NjUxMDg0","html_url":"https://github.com/hshoff/vx/pull/488","diff_url":"https://github.com/hshoff/vx/pull/488.diff","patch_url":"https://github.com/hshoff/vx/pull/488.patch","issue_url":"https://api.github.com/repos/hshoff/vx/issues/488","number":488,"state":"open","locked":false,"title":"new(vx-group): re-write in TypeScript","user":{"login":"williaster","id":4496521,"node_id":"MDQ6VXNlcjQ0OTY1MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4496521?v=4","gravatar_id":"","url":"https://api.github.com/users/williaster","html_url":"https://github.com/williaster","followers_url":"https://api.github.com/users/williaster/followers","following_url":"https://api.github.com/users/williaster/following{/other_user}","gists_url":"https://api.github.com/users/williaster/gists{/gist_id}","starred_url":"https://api.github.com/users/williaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williaster/subscriptions","organizations_url":"https://api.github.com/users/williaster/orgs","repos_url":"https://api.github.com/users/williaster/repos","events_url":"https://api.github.com/users/williaster/events{/privacy}","received_events_url":"https://api.github.com/users/williaster/received_events","type":"User","site_admin":false},"body":"#### :rocket: Enhancements\r\n\r\nThis PR builds off of #484, introducing `TypeScript` config and converting the `@vx/group` package (which is quite simple) as a proof of concept. The plan is to convert packages one by one from here 📈 \r\n\r\n<p align=\"center\">\r\n  <img src=\"https://user-images.githubusercontent.com/4496521/64737383-94a25300-d4a1-11e9-88d2-d3908067162e.png\" width=\"200\" />\r\n</p>\r\n\r\nNotes \r\n- `@types/*` related to testing were added to the root `devDeps`\r\n- package-specific types should be added as `deps` in the relevant packages\r\n- `@airbnb/config-babel` adds [`babel-plugin-typescript-to-proptypes`](https://github.com/milesj/babel-plugin-typescript-to-proptypes) when used with the `typescript` driver, which generates `PropTypes` for react component `type`s/`interface`s and requires us to keep the `prop-types` dep though it's no longer referenced in source code. Example compiled `.js` file below:\r\n\r\n<p align=\"center\">\r\n  <img src=\"https://user-images.githubusercontent.com/4496521/64738422-ffed2480-d4a3-11e9-943a-f9692079700a.png\" width=\"800\" />\r\n</p>\r\n\r\n\r\n@hshoff @milesj @shiller @schillerk @techniq \r\n","created_at":"2019-09-11T21:56:24Z","updated_at":"2019-09-11T23:07:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"910a25932f0c59ff2efbd833756f31105b59db8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hshoff/vx/pulls/488/commits","review_comments_url":"https://api.github.com/repos/hshoff/vx/pulls/488/comments","review_comment_url":"https://api.github.com/repos/hshoff/vx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hshoff/vx/issues/488/comments","statuses_url":"https://api.github.com/repos/hshoff/vx/statuses/6934406356e2caa49daca90fb17e9a930fcde148","head":{"label":"hshoff:chris--typescript","ref":"chris--typescript","sha":"6934406356e2caa49daca90fb17e9a930fcde148","user":{"login":"hshoff","id":339208,"node_id":"MDQ6VXNlcjMzOTIwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/339208?v=4","gravatar_id":"","url":"https://api.github.com/users/hshoff","html_url":"https://github.com/hshoff","followers_url":"https://api.github.com/users/hshoff/followers","following_url":"https://api.github.com/users/hshoff/following{/other_user}","gists_url":"https://api.github.com/users/hshoff/gists{/gist_id}","starred_url":"https://api.github.com/users/hshoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshoff/subscriptions","organizations_url":"https://api.github.com/users/hshoff/orgs","repos_url":"https://api.github.com/users/hshoff/repos","events_url":"https://api.github.com/users/hshoff/events{/privacy}","received_events_url":"https://api.github.com/users/hshoff/received_events","type":"User","site_admin":false},"repo":{"id":85095608,"node_id":"MDEwOlJlcG9zaXRvcnk4NTA5NTYwOA==","name":"vx","full_name":"hshoff/vx","private":false,"owner":{"login":"hshoff","id":339208,"node_id":"MDQ6VXNlcjMzOTIwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/339208?v=4","gravatar_id":"","url":"https://api.github.com/users/hshoff","html_url":"https://github.com/hshoff","followers_url":"https://api.github.com/users/hshoff/followers","following_url":"https://api.github.com/users/hshoff/following{/other_user}","gists_url":"https://api.github.com/users/hshoff/gists{/gist_id}","starred_url":"https://api.github.com/users/hshoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshoff/subscriptions","organizations_url":"https://api.github.com/users/hshoff/orgs","repos_url":"https://api.github.com/users/hshoff/repos","events_url":"https://api.github.com/users/hshoff/events{/privacy}","received_events_url":"https://api.github.com/users/hshoff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hshoff/vx","description":"🐯react + d3 = vx | visualization components","fork":false,"url":"https://api.github.com/repos/hshoff/vx","forks_url":"https://api.github.com/repos/hshoff/vx/forks","keys_url":"https://api.github.com/repos/hshoff/vx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hshoff/vx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hshoff/vx/teams","hooks_url":"https://api.github.com/repos/hshoff/vx/hooks","issue_events_url":"https://api.github.com/repos/hshoff/vx/issues/events{/number}","events_url":"https://api.github.com/repos/hshoff/vx/events","assignees_url":"https://api.github.com/repos/hshoff/vx/assignees{/user}","branches_url":"https://api.github.com/repos/hshoff/vx/branches{/branch}","tags_url":"https://api.github.com/repos/hshoff/vx/tags","blobs_url":"https://api.github.com/repos/hshoff/vx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hshoff/vx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hshoff/vx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hshoff/vx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hshoff/vx/statuses/{sha}","languages_url":"https://api.github.com/repos/hshoff/vx/languages","stargazers_url":"https://api.github.com/repos/hshoff/vx/stargazers","contributors_url":"https://api.github.com/repos/hshoff/vx/contributors","subscribers_url":"https://api.github.com/repos/hshoff/vx/subscribers","subscription_url":"https://api.github.com/repos/hshoff/vx/subscription","commits_url":"https://api.github.com/repos/hshoff/vx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hshoff/vx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hshoff/vx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hshoff/vx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hshoff/vx/contents/{+path}","compare_url":"https://api.github.com/repos/hshoff/vx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hshoff/vx/merges","archive_url":"https://api.github.com/repos/hshoff/vx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hshoff/vx/downloads","issues_url":"https://api.github.com/repos/hshoff/vx/issues{/number}","pulls_url":"https://api.github.com/repos/hshoff/vx/pulls{/number}","milestones_url":"https://api.github.com/repos/hshoff/vx/milestones{/number}","notifications_url":"https://api.github.com/repos/hshoff/vx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hshoff/vx/labels{/name}","releases_url":"https://api.github.com/repos/hshoff/vx/releases{/id}","deployments_url":"https://api.github.com/repos/hshoff/vx/deployments","created_at":"2017-03-15T16:25:41Z","updated_at":"2019-09-11T08:23:32Z","pushed_at":"2019-09-11T22:30:21Z","git_url":"git://github.com/hshoff/vx.git","ssh_url":"git@github.com:hshoff/vx.git","clone_url":"https://github.com/hshoff/vx.git","svn_url":"https://github.com/hshoff/vx","homepage":"https://vx-demo.now.sh/","size":8031,"stargazers_count":6342,"watchers_count":6342,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":294,"open_issues":45,"watchers":6342,"default_branch":"master"}},"base":{"label":"hshoff:chris--nimbus","ref":"chris--nimbus","sha":"f56fc692f76e9d49acbb92423281769d3cf9fd92","user":{"login":"hshoff","id":339208,"node_id":"MDQ6VXNlcjMzOTIwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/339208?v=4","gravatar_id":"","url":"https://api.github.com/users/hshoff","html_url":"https://github.com/hshoff","followers_url":"https://api.github.com/users/hshoff/followers","following_url":"https://api.github.com/users/hshoff/following{/other_user}","gists_url":"https://api.github.com/users/hshoff/gists{/gist_id}","starred_url":"https://api.github.com/users/hshoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshoff/subscriptions","organizations_url":"https://api.github.com/users/hshoff/orgs","repos_url":"https://api.github.com/users/hshoff/repos","events_url":"https://api.github.com/users/hshoff/events{/privacy}","received_events_url":"https://api.github.com/users/hshoff/received_events","type":"User","site_admin":false},"repo":{"id":85095608,"node_id":"MDEwOlJlcG9zaXRvcnk4NTA5NTYwOA==","name":"vx","full_name":"hshoff/vx","private":false,"owner":{"login":"hshoff","id":339208,"node_id":"MDQ6VXNlcjMzOTIwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/339208?v=4","gravatar_id":"","url":"https://api.github.com/users/hshoff","html_url":"https://github.com/hshoff","followers_url":"https://api.github.com/users/hshoff/followers","following_url":"https://api.github.com/users/hshoff/following{/other_user}","gists_url":"https://api.github.com/users/hshoff/gists{/gist_id}","starred_url":"https://api.github.com/users/hshoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshoff/subscriptions","organizations_url":"https://api.github.com/users/hshoff/orgs","repos_url":"https://api.github.com/users/hshoff/repos","events_url":"https://api.github.com/users/hshoff/events{/privacy}","received_events_url":"https://api.github.com/users/hshoff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hshoff/vx","description":"🐯react + d3 = vx | visualization components","fork":false,"url":"https://api.github.com/repos/hshoff/vx","forks_url":"https://api.github.com/repos/hshoff/vx/forks","keys_url":"https://api.github.com/repos/hshoff/vx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hshoff/vx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hshoff/vx/teams","hooks_url":"https://api.github.com/repos/hshoff/vx/hooks","issue_events_url":"https://api.github.com/repos/hshoff/vx/issues/events{/number}","events_url":"https://api.github.com/repos/hshoff/vx/events","assignees_url":"https://api.github.com/repos/hshoff/vx/assignees{/user}","branches_url":"https://api.github.com/repos/hshoff/vx/branches{/branch}","tags_url":"https://api.github.com/repos/hshoff/vx/tags","blobs_url":"https://api.github.com/repos/hshoff/vx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hshoff/vx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hshoff/vx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hshoff/vx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hshoff/vx/statuses/{sha}","languages_url":"https://api.github.com/repos/hshoff/vx/languages","stargazers_url":"https://api.github.com/repos/hshoff/vx/stargazers","contributors_url":"https://api.github.com/repos/hshoff/vx/contributors","subscribers_url":"https://api.github.com/repos/hshoff/vx/subscribers","subscription_url":"https://api.github.com/repos/hshoff/vx/subscription","commits_url":"https://api.github.com/repos/hshoff/vx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hshoff/vx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hshoff/vx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hshoff/vx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hshoff/vx/contents/{+path}","compare_url":"https://api.github.com/repos/hshoff/vx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hshoff/vx/merges","archive_url":"https://api.github.com/repos/hshoff/vx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hshoff/vx/downloads","issues_url":"https://api.github.com/repos/hshoff/vx/issues{/number}","pulls_url":"https://api.github.com/repos/hshoff/vx/pulls{/number}","milestones_url":"https://api.github.com/repos/hshoff/vx/milestones{/number}","notifications_url":"https://api.github.com/repos/hshoff/vx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hshoff/vx/labels{/name}","releases_url":"https://api.github.com/repos/hshoff/vx/releases{/id}","deployments_url":"https://api.github.com/repos/hshoff/vx/deployments","created_at":"2017-03-15T16:25:41Z","updated_at":"2019-09-11T08:23:32Z","pushed_at":"2019-09-11T22:30:21Z","git_url":"git://github.com/hshoff/vx.git","ssh_url":"git@github.com:hshoff/vx.git","clone_url":"https://github.com/hshoff/vx.git","svn_url":"https://github.com/hshoff/vx","homepage":"https://vx-demo.now.sh/","size":8031,"stargazers_count":6342,"watchers_count":6342,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":294,"open_issues":45,"watchers":6342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hshoff/vx/pulls/488"},"html":{"href":"https://github.com/hshoff/vx/pull/488"},"issue":{"href":"https://api.github.com/repos/hshoff/vx/issues/488"},"comments":{"href":"https://api.github.com/repos/hshoff/vx/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/hshoff/vx/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/hshoff/vx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hshoff/vx/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/hshoff/vx/statuses/6934406356e2caa49daca90fb17e9a930fcde148"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"milesj"}}