payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/hyperledger/caliper/issues/331","repository_url":"https://api.github.com/repos/hyperledger/caliper","labels_url":"https://api.github.com/repos/hyperledger/caliper/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/caliper/issues/331/comments","events_url":"https://api.github.com/repos/hyperledger/caliper/issues/331/events","html_url":"https://github.com/hyperledger/caliper/issues/331","id":413384326,"node_id":"MDU6SXNzdWU0MTMzODQzMjY=","number":331,"title":"Allow to skip start and end scripts even when they are defined","user":{"login":"aklenik","id":10832624,"node_id":"MDQ6VXNlcjEwODMyNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/10832624?v=4","gravatar_id":"","url":"https://api.github.com/users/aklenik","html_url":"https://github.com/aklenik","followers_url":"https://api.github.com/users/aklenik/followers","following_url":"https://api.github.com/users/aklenik/following{/other_user}","gists_url":"https://api.github.com/users/aklenik/gists{/gist_id}","starred_url":"https://api.github.com/users/aklenik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklenik/subscriptions","organizations_url":"https://api.github.com/users/aklenik/orgs","repos_url":"https://api.github.com/users/aklenik/repos","events_url":"https://api.github.com/users/aklenik/events{/privacy}","received_events_url":"https://api.github.com/users/aklenik/received_events","type":"User","site_admin":false},"labels":[{"id":872888862,"node_id":"MDU6TGFiZWw4NzI4ODg4NjI=","url":"https://api.github.com/repos/hyperledger/caliper/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":872888864,"node_id":"MDU6TGFiZWw4NzI4ODg4NjQ=","url":"https://api.github.com/repos/hyperledger/caliper/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-02-22T12:33:34Z","updated_at":"2019-03-05T09:20:43Z","closed_at":"2019-03-05T09:20:43Z","author_association":"CONTRIBUTOR","body":"## Context\r\nThis issue is a rework of #329.\r\n\r\nDuring the development of user callback or chaincodes, it would be nice to reuse an already started (through the start script) local network. Currently, we need to remove the `start` script from the network configuration file to achieve this.\r\n\r\nAlso, during the debugging of an error, it would be nice to keep the network running at the end of a benchmark to inspect the logs, for example. Currently, we need to remove the `end` script from the network configuration file to achieve this.\r\n\r\n## Expected Behavior\r\nProvide a mechanism to skip the start and/or end scripts even when they are present in the configuration. \r\n\r\n## Actual Behavior\r\nCurrently, we need to remove the `start`/`end` scripts from the network configuration file.\r\n\r\n## Possible Fix\r\nCaliper already provides a flexible configuration mechanism. Two options should be added to the general Caliper configuration file (`config/default.yaml`):\r\n\r\n```yaml\r\ncore:\r\n    skipStartScript: false\r\n    skipEndScript: false\r\n```\r\nThis way the settings can be easily overridden through environment variables or command line arguments. \r\n\r\nFinally, [this](https://github.com/hyperledger/caliper/blob/027528a5f5e142f17c694e6648baec51cb4c2139/src/comm/bench-flow.js#L336) and [this](https://github.com/hyperledger/caliper/blob/027528a5f5e142f17c694e6648baec51cb4c2139/src/comm/bench-flow.js#L382) line should be changed to take the settings into account.\r\n \r\n## Existing issues\r\n- #329 "}}
other: {"actor":{"display_login":"panyu4"}}