payload: {"action":"created","issue":{"url":"https://api.github.com/repos/SAP/devops-docker-images/issues/98","repository_url":"https://api.github.com/repos/SAP/devops-docker-images","labels_url":"https://api.github.com/repos/SAP/devops-docker-images/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/SAP/devops-docker-images/issues/98/comments","events_url":"https://api.github.com/repos/SAP/devops-docker-images/issues/98/events","html_url":"https://github.com/SAP/devops-docker-images/issues/98","id":451891515,"node_id":"MDU6SXNzdWU0NTE4OTE1MTU=","number":98,"title":"Docker Image MTA+Browsers for PR-Voting","user":{"login":"LukasHeimann","id":48723560,"node_id":"MDQ6VXNlcjQ4NzIzNTYw","avatar_url":"https://avatars0.githubusercontent.com/u/48723560?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasHeimann","html_url":"https://github.com/LukasHeimann","followers_url":"https://api.github.com/users/LukasHeimann/followers","following_url":"https://api.github.com/users/LukasHeimann/following{/other_user}","gists_url":"https://api.github.com/users/LukasHeimann/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasHeimann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasHeimann/subscriptions","organizations_url":"https://api.github.com/users/LukasHeimann/orgs","repos_url":"https://api.github.com/users/LukasHeimann/repos","events_url":"https://api.github.com/users/LukasHeimann/events{/privacy}","received_events_url":"https://api.github.com/users/LukasHeimann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"1084565","id":11404457,"node_id":"MDQ6VXNlcjExNDA0NDU3","avatar_url":"https://avatars3.githubusercontent.com/u/11404457?v=4","gravatar_id":"","url":"https://api.github.com/users/1084565","html_url":"https://github.com/1084565","followers_url":"https://api.github.com/users/1084565/followers","following_url":"https://api.github.com/users/1084565/following{/other_user}","gists_url":"https://api.github.com/users/1084565/gists{/gist_id}","starred_url":"https://api.github.com/users/1084565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1084565/subscriptions","organizations_url":"https://api.github.com/users/1084565/orgs","repos_url":"https://api.github.com/users/1084565/repos","events_url":"https://api.github.com/users/1084565/events{/privacy}","received_events_url":"https://api.github.com/users/1084565/received_events","type":"User","site_admin":false},"assignees":[{"login":"1084565","id":11404457,"node_id":"MDQ6VXNlcjExNDA0NDU3","avatar_url":"https://avatars3.githubusercontent.com/u/11404457?v=4","gravatar_id":"","url":"https://api.github.com/users/1084565","html_url":"https://github.com/1084565","followers_url":"https://api.github.com/users/1084565/followers","following_url":"https://api.github.com/users/1084565/following{/other_user}","gists_url":"https://api.github.com/users/1084565/gists{/gist_id}","starred_url":"https://api.github.com/users/1084565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1084565/subscriptions","organizations_url":"https://api.github.com/users/1084565/orgs","repos_url":"https://api.github.com/users/1084565/repos","events_url":"https://api.github.com/users/1084565/events{/privacy}","received_events_url":"https://api.github.com/users/1084565/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2019-06-04T09:30:06Z","updated_at":"2019-06-05T07:15:46Z","closed_at":null,"author_association":"NONE","body":"Hi everyone!\r\n\r\nIn my project, we manually run Unit Tests for an MTA project including Java Services (`mvn verify`), Node.js modules (`npm run test`) and Fiori-Apps (`@sap/grunt-sapui5-bestpractice-test`). We use a Piper Template and configure the docker image for running the tests:\r\n\r\n```yaml\r\n  'Pull-Request Voting':\r\n    dockerCommand: tools/run_tests.sh\r\n    dockerImage: xxx\r\n```\r\n\r\nUnfortunately, there currently is no officially supported docker image containing everything: The MTA-Build-Tooling (for us mvn and node would be enough) _and_ the Webbrowsers (`@sap/grunt-sapui5-bestpractice-test` relies on Chrome Headless (Chromium does fine as well)). There are only the two distinct images `ppiper/mta-archive-builder` and `ppiper/node-browsers`.\r\n\r\nWould it be possible to add Chromium to the MTA-Build-Tooling-Image? Or maybe add another image building on `ppiper/mta-archive-builder` that just adds the few lines of code in `ppiper/node-browsers`?\r\n\r\nAdding it to the MTA-Builder-Image seems like the most reasonable thing to me: MTAs will include Fiori-UIs in most cases. These must use `@sap/grunt-sapui5-bestpractice-build` to use the new portal service on SCP. The recommended way to test them is the `@sap/grunt-sapui5-bestpractice-test`, that is (to my knowledge) the approach suggested by WebIDE to be used. So having support for it in the default image seems logical.\r\n\r\nThank you very much for considering!\r\nKind regards\r\nLukas\r\n"},"comment":{"url":"https://api.github.com/repos/SAP/devops-docker-images/issues/comments/498967217","html_url":"https://github.com/SAP/devops-docker-images/issues/98#issuecomment-498967217","issue_url":"https://api.github.com/repos/SAP/devops-docker-images/issues/98","id":498967217,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5ODk2NzIxNw==","user":{"login":"CCFenner","id":26137398,"node_id":"MDQ6VXNlcjI2MTM3Mzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false},"created_at":"2019-06-05T07:15:46Z","updated_at":"2019-06-05T07:15:46Z","author_association":"MEMBER","body":"We've overcome this by using a Docker sidecar pattern with a Docker network of multiple standard containers in `seleniumExecuteTests`. A standard `node:8` container is used for the test runner talking to a web driver that is then triggering the Chrome browser running in another `selenium/standalone-chrome` standard container. Would this also be possible in your use-case?"}}
other: {"actor":{"display_login":"CCFenner"}}