payload: {"action":"opened","number":10327,"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/10327","id":347605183,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3NjA1MTgz","html_url":"https://github.com/google/ggrc-core/pull/10327","diff_url":"https://github.com/google/ggrc-core/pull/10327.diff","patch_url":"https://github.com/google/ggrc-core/pull/10327.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/10327","number":10327,"state":"open","locked":false,"title":"GGRC-7284 Replace Deferred with Promise","user":{"login":"wofec","id":47753781,"node_id":"MDQ6VXNlcjQ3NzUzNzgx","avatar_url":"https://avatars2.githubusercontent.com/u/47753781?v=4","gravatar_id":"","url":"https://api.github.com/users/wofec","html_url":"https://github.com/wofec","followers_url":"https://api.github.com/users/wofec/followers","following_url":"https://api.github.com/users/wofec/following{/other_user}","gists_url":"https://api.github.com/users/wofec/gists{/gist_id}","starred_url":"https://api.github.com/users/wofec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wofec/subscriptions","organizations_url":"https://api.github.com/users/wofec/orgs","repos_url":"https://api.github.com/users/wofec/repos","events_url":"https://api.github.com/users/wofec/events{/privacy}","received_events_url":"https://api.github.com/users/wofec/received_events","type":"User","site_admin":false},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nIn scope of the migration to CanJS 3 also jQuery was updated to version 3. In version 3 some async changes were introduced for Deferred. It allows to start replacement for Deferred to Promise usages.\r\n\r\n# Steps to test the changes\r\n\r\n1. Confirm edit button.\r\n1.1 Launch GGRC.\r\n1.2 Open assessment.\r\n1.3 Make it completed.\r\n1.4 Click \"Edit Answers\" button and confirm moving.\r\n1.5 Expected: It works.\r\n2. Create document button.\r\n2.1 Launch GGRC.\r\n2.2 Create or open existing data assets object.\r\n2.3 Click \"Attach button\".\r\n2.4 Click \"attach new\" on opened modal.\r\n2.5 Select some files and upload.\r\n2.6 Expect: It works.\r\n3. Workflow utils.\r\n3.1 Launch GGRC.\r\n3.2 Create new workflow.\r\n3.3 Setup task group and activate cycle.\r\n3.4 Expected: It works.\r\n\r\n# Solution description\r\n\r\nReplace Deferred with Promise.\r\n\r\n# Sanity checklist\r\n\r\n- [x] I have clicked through the app to make sure my changes work and not break the app.\r\n- [ ] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [x] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n- [ ] Upon merging, add 'check migration chain' and 'kokoro:force-run' labels to all open PRs with a label 'migration'\r\n- [ ] Upon merging, update 'table structure changes' in weekly deployment documentation\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2019-12-02T12:43:39Z","updated_at":"2019-12-02T12:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/10327/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/10327/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/10327/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/12bf205347ad6a29b8ffb77fe18ec3fb62e0f59e","head":{"label":"wofec:GGRC-7284-1","ref":"GGRC-7284-1","sha":"12bf205347ad6a29b8ffb77fe18ec3fb62e0f59e","user":{"login":"wofec","id":47753781,"node_id":"MDQ6VXNlcjQ3NzUzNzgx","avatar_url":"https://avatars2.githubusercontent.com/u/47753781?v=4","gravatar_id":"","url":"https://api.github.com/users/wofec","html_url":"https://github.com/wofec","followers_url":"https://api.github.com/users/wofec/followers","following_url":"https://api.github.com/users/wofec/following{/other_user}","gists_url":"https://api.github.com/users/wofec/gists{/gist_id}","starred_url":"https://api.github.com/users/wofec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wofec/subscriptions","organizations_url":"https://api.github.com/users/wofec/orgs","repos_url":"https://api.github.com/users/wofec/repos","events_url":"https://api.github.com/users/wofec/events{/privacy}","received_events_url":"https://api.github.com/users/wofec/received_events","type":"User","site_admin":false},"repo":{"id":213869854,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM4Njk4NTQ=","name":"ggrc-core","full_name":"wofec/ggrc-core","private":false,"owner":{"login":"wofec","id":47753781,"node_id":"MDQ6VXNlcjQ3NzUzNzgx","avatar_url":"https://avatars2.githubusercontent.com/u/47753781?v=4","gravatar_id":"","url":"https://api.github.com/users/wofec","html_url":"https://github.com/wofec","followers_url":"https://api.github.com/users/wofec/followers","following_url":"https://api.github.com/users/wofec/following{/other_user}","gists_url":"https://api.github.com/users/wofec/gists{/gist_id}","starred_url":"https://api.github.com/users/wofec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wofec/subscriptions","organizations_url":"https://api.github.com/users/wofec/orgs","repos_url":"https://api.github.com/users/wofec/repos","events_url":"https://api.github.com/users/wofec/events{/privacy}","received_events_url":"https://api.github.com/users/wofec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wofec/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/wofec/ggrc-core","forks_url":"https://api.github.com/repos/wofec/ggrc-core/forks","keys_url":"https://api.github.com/repos/wofec/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wofec/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wofec/ggrc-core/teams","hooks_url":"https://api.github.com/repos/wofec/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/wofec/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/wofec/ggrc-core/events","assignees_url":"https://api.github.com/repos/wofec/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/wofec/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/wofec/ggrc-core/tags","blobs_url":"https://api.github.com/repos/wofec/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wofec/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wofec/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wofec/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wofec/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wofec/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/wofec/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/wofec/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/wofec/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/wofec/ggrc-core/subscription","commits_url":"https://api.github.com/repos/wofec/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wofec/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wofec/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wofec/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wofec/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/wofec/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wofec/ggrc-core/merges","archive_url":"https://api.github.com/repos/wofec/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wofec/ggrc-core/downloads","issues_url":"https://api.github.com/repos/wofec/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/wofec/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wofec/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wofec/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wofec/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/wofec/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/wofec/ggrc-core/deployments","created_at":"2019-10-09T08:59:07Z","updated_at":"2019-10-09T08:59:09Z","pushed_at":"2019-12-02T12:41:38Z","git_url":"git://github.com/wofec/ggrc-core.git","ssh_url":"git@github.com:wofec/ggrc-core.git","clone_url":"https://github.com/wofec/ggrc-core.git","svn_url":"https://github.com/wofec/ggrc-core","homepage":null,"size":97332,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"main"}},"base":{"label":"google:dev","ref":"dev","sha":"23ae2b4e8560cab497fbcdd7f087f300ea72cc1f","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NjM3","name":"ggrc-core","full_name":"google/ggrc-core","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2019-11-28T10:50:34Z","pushed_at":"2019-12-02T12:32:48Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":97395,"stargazers_count":475,"watchers_count":475,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":334,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":334,"open_issues":84,"watchers":475,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10327"},"html":{"href":"https://github.com/google/ggrc-core/pull/10327"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/10327"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/10327/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10327/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10327/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/12bf205347ad6a29b8ffb77fe18ec3fb62e0f59e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":6,"additions":185,"deletions":238,"changed_files":6}}
other: {"actor":{"display_login":"wofec"}}