payload: {"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/30857","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/30857/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/30857/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/30857/events","html_url":"https://github.com/flutter/flutter/pull/30857","id":431559653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5MjA3NzA1","number":30857,"title":"Added support for authentication codes for the VM service.","user":{"login":"bkonyi","id":24210656,"node_id":"MDQ6VXNlcjI0MjEwNjU2","avatar_url":"https://avatars2.githubusercontent.com/u/24210656?v=4","gravatar_id":"","url":"https://api.github.com/users/bkonyi","html_url":"https://github.com/bkonyi","followers_url":"https://api.github.com/users/bkonyi/followers","following_url":"https://api.github.com/users/bkonyi/following{/other_user}","gists_url":"https://api.github.com/users/bkonyi/gists{/gist_id}","starred_url":"https://api.github.com/users/bkonyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkonyi/subscriptions","organizations_url":"https://api.github.com/users/bkonyi/orgs","repos_url":"https://api.github.com/users/bkonyi/repos","events_url":"https://api.github.com/users/bkonyi/events{/privacy}","received_events_url":"https://api.github.com/users/bkonyi/received_events","type":"User","site_admin":false},"labels":[{"id":283479128,"node_id":"MDU6TGFiZWwyODM0NzkxMjg=","url":"https://api.github.com/repos/flutter/flutter/labels/a:%20tests","name":"a: tests","color":"38d8c8","default":false},{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":283480100,"node_id":"MDU6TGFiZWwyODM0ODAxMDA=","url":"https://api.github.com/repos/flutter/flutter/labels/tool","name":"tool","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-04-10T15:11:04Z","updated_at":"2019-04-17T00:05:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/30857","html_url":"https://github.com/flutter/flutter/pull/30857","diff_url":"https://github.com/flutter/flutter/pull/30857.diff","patch_url":"https://github.com/flutter/flutter/pull/30857.patch"},"body":"Previously, a valid web socket connection would use the following URI:\r\n\r\nws://127.0.0.1/ws\r\n\r\nNow, by default, the VM service requires a connection to be made with a\r\nURI similar to the following:\r\n\r\nws://127.0.0.1:8181/Ug_U0QVsqFs=/ws\r\n\r\nwhere Ug_U0QVsqFs is an authentication code generated and shared by the\r\nservice.\r\n\r\nThis behavior can be disabled with the --disable-service-auth-codes\r\nflag.\r\n\r\nDepends on flutter/engine#8594"},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/483887369","html_url":"https://github.com/flutter/flutter/pull/30857#issuecomment-483887369","issue_url":"https://api.github.com/repos/flutter/flutter/issues/30857","id":483887369,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4Mzg4NzM2OQ==","user":{"login":"bkonyi","id":24210656,"node_id":"MDQ6VXNlcjI0MjEwNjU2","avatar_url":"https://avatars2.githubusercontent.com/u/24210656?v=4","gravatar_id":"","url":"https://api.github.com/users/bkonyi","html_url":"https://github.com/bkonyi","followers_url":"https://api.github.com/users/bkonyi/followers","following_url":"https://api.github.com/users/bkonyi/following{/other_user}","gists_url":"https://api.github.com/users/bkonyi/gists{/gist_id}","starred_url":"https://api.github.com/users/bkonyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkonyi/subscriptions","organizations_url":"https://api.github.com/users/bkonyi/orgs","repos_url":"https://api.github.com/users/bkonyi/repos","events_url":"https://api.github.com/users/bkonyi/events{/privacy}","received_events_url":"https://api.github.com/users/bkonyi/received_events","type":"User","site_admin":false},"created_at":"2019-04-17T00:05:32Z","updated_at":"2019-04-17T00:05:32Z","author_association":"CONTRIBUTOR","body":"> My concern is more in the cost of requiring to pass the uri at all. For the android case, we should make sure we scrape the token out of the logs in the attach case so that it doesn't need to be specified.\r\n\r\nThe only time you'll need to specify the URI is when you would have needed to provide `--debugPort` previously. If you run `flutter attach` before running the application, it will pick up the right URI from the logs.\r\n\r\n> For iOS, we'll need to find a way to discover the token as well (does this defeat the point?) or else we need to go back to log parsing.\r\n\r\nYeah, I honestly have no clue how MDNS works or what it does. I'm not sure how we'll be able to get the token as it's part of the path, which I doubt is included anywhere. What is MDNS used for anyway?"}}
other: {"actor":{"display_login":"bkonyi"}}