payload: {"action":"created","issue":{"url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/154","repository_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery","labels_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/154/comments","events_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/154/events","html_url":"https://github.com/wepay/kafka-connect-bigquery/pull/154","id":423727908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMjM0MDIz","number":154,"title":"Support passing GCP credentials as JSON in config","user":{"login":"ivanyu","id":2189030,"node_id":"MDQ6VXNlcjIxODkwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2189030?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanyu","html_url":"https://github.com/ivanyu","followers_url":"https://api.github.com/users/ivanyu/followers","following_url":"https://api.github.com/users/ivanyu/following{/other_user}","gists_url":"https://api.github.com/users/ivanyu/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanyu/subscriptions","organizations_url":"https://api.github.com/users/ivanyu/orgs","repos_url":"https://api.github.com/users/ivanyu/repos","events_url":"https://api.github.com/users/ivanyu/events{/privacy}","received_events_url":"https://api.github.com/users/ivanyu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-03-21T13:26:00Z","updated_at":"2019-10-17T12:44:42Z","closed_at":"2019-10-17T12:44:42Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/154","html_url":"https://github.com/wepay/kafka-connect-bigquery/pull/154","diff_url":"https://github.com/wepay/kafka-connect-bigquery/pull/154.diff","patch_url":"https://github.com/wepay/kafka-connect-bigquery/pull/154.patch"},"body":"Support passing the GCP credentials via the configuration directive `credentials` as a non-escaped JSON blob.\r\n\r\nThis helps to run the Kafka connector when the environment can't be manipulated.\r\n\r\nChanges:\r\n- `credentials` configuration keys added. It has the priority over `keyfile` when provided.\r\n- `GoogleCredentials` objects are now provided by `BigQuerySinkConfig.getCredentials`, which handles both `keyfile` and `credentials` configuration keys.\r\n- The ability to use explicit JSON credentials added to the integration test suite:\r\n  - support of `-c|--credentials` CLI parameter, `KCBQ_TEST_CREDENTIALS` environment variable, and `credentials` configuration key in `integrationtest.sh`; using them in all relevant pieces of config;\r\n  - support of `kcbq_test_credentials` in `integrationTestPrep` Gradle task and passing it to `BucketClearer` and `TableClearer`.\r\n- `README.md` updated.\r\n"},"comment":{"url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/comments/543157023","html_url":"https://github.com/wepay/kafka-connect-bigquery/pull/154#issuecomment-543157023","issue_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/154","id":543157023,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MzE1NzAyMw==","user":{"login":"ivanyu","id":2189030,"node_id":"MDQ6VXNlcjIxODkwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2189030?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanyu","html_url":"https://github.com/ivanyu","followers_url":"https://api.github.com/users/ivanyu/followers","following_url":"https://api.github.com/users/ivanyu/following{/other_user}","gists_url":"https://api.github.com/users/ivanyu/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanyu/subscriptions","organizations_url":"https://api.github.com/users/ivanyu/orgs","repos_url":"https://api.github.com/users/ivanyu/repos","events_url":"https://api.github.com/users/ivanyu/events{/privacy}","received_events_url":"https://api.github.com/users/ivanyu/received_events","type":"User","site_admin":false},"created_at":"2019-10-17T12:44:42Z","updated_at":"2019-10-17T12:44:42Z","author_association":"NONE","body":"@criccomini it seems that what I tried to achieve here was introduced in https://github.com/wepay/kafka-connect-bigquery/commit/2d49a94f94eb62477c65b966782564d008e3be64\r\n\r\nHowever, this new `keySource` configuration is not documented in README, so I'll create a new PR."}}
other: {"actor":{"display_login":"ivanyu"}}