payload: {"action":"closed","number":34238,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/34238","id":349106394,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5MTA2Mzk0","html_url":"https://github.com/angular/angular/pull/34238","diff_url":"https://github.com/angular/angular/pull/34238.diff","patch_url":"https://github.com/angular/angular/pull/34238.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/34238","number":34238,"state":"closed","locked":false,"title":"build: Enable ivy in google3 if ng_module attr is True","user":{"login":"kyliau","id":2941178,"node_id":"MDQ6VXNlcjI5NDExNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2941178?v=4","gravatar_id":"","url":"https://api.github.com/users/kyliau","html_url":"https://github.com/kyliau","followers_url":"https://api.github.com/users/kyliau/followers","following_url":"https://api.github.com/users/kyliau/following{/other_user}","gists_url":"https://api.github.com/users/kyliau/gists{/gist_id}","starred_url":"https://api.github.com/users/kyliau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyliau/subscriptions","organizations_url":"https://api.github.com/users/kyliau/orgs","repos_url":"https://api.github.com/users/kyliau/repos","events_url":"https://api.github.com/users/kyliau/events{/privacy}","received_events_url":"https://api.github.com/users/kyliau/received_events","type":"User","site_admin":false},"body":"This commit creates a way for `ng_module` rule to compile with Ivy based\r\non the `ivy` attribute. This enables google3 targets to pick the\r\ncompiler without using `define` flags.\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n\r\n- [ ] Bugfix\r\n- [x] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Documentation content changes\r\n- [ ] angular.io application / infrastructure changes\r\n- [ ] Other... Please describe:\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2019-12-04T21:41:04Z","updated_at":"2019-12-05T21:09:52Z","closed_at":"2019-12-05T21:09:52Z","merged_at":null,"merge_commit_sha":"e0ad8646133c9eeb8db67264eceef3c4d1621b13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"tools-bazel","id":3050777,"node_id":"MDQ6VGVhbTMwNTA3Nzc=","slug":"tools-bazel","description":"","privacy":"closed","url":"https://api.github.com/teams/3050777","html_url":"https://github.com/orgs/angular/teams/tools-bazel","members_url":"https://api.github.com/teams/3050777/members{/member}","repositories_url":"https://api.github.com/teams/3050777/repos","permission":"pull"}],"labels":[{"id":133556520,"node_id":"MDU6TGFiZWwxMzM1NTY1MjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"6cdd99","default":false,"description":"PR author is ready for this to merge"},{"id":655699838,"node_id":"MDU6TGFiZWw2NTU2OTk4Mzg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false,"description":null},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false,"description":null},{"id":698221504,"node_id":"MDU6TGFiZWw2OTgyMjE1MDQ=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20bazel","name":"comp: bazel","color":"c5def5","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":703,"closed_issues":4134,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2019-12-05T21:09:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/34238/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/34238/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/34238/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/4d72852e41939b93a1c880e21032f35b47f53d6f","head":{"label":"kyliau:ivy-attr","ref":"ivy-attr","sha":"4d72852e41939b93a1c880e21032f35b47f53d6f","user":{"login":"kyliau","id":2941178,"node_id":"MDQ6VXNlcjI5NDExNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2941178?v=4","gravatar_id":"","url":"https://api.github.com/users/kyliau","html_url":"https://github.com/kyliau","followers_url":"https://api.github.com/users/kyliau/followers","following_url":"https://api.github.com/users/kyliau/following{/other_user}","gists_url":"https://api.github.com/users/kyliau/gists{/gist_id}","starred_url":"https://api.github.com/users/kyliau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyliau/subscriptions","organizations_url":"https://api.github.com/users/kyliau/orgs","repos_url":"https://api.github.com/users/kyliau/repos","events_url":"https://api.github.com/users/kyliau/events{/privacy}","received_events_url":"https://api.github.com/users/kyliau/received_events","type":"User","site_admin":false},"repo":{"id":108615338,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2MTUzMzg=","name":"angular","full_name":"kyliau/angular","private":false,"owner":{"login":"kyliau","id":2941178,"node_id":"MDQ6VXNlcjI5NDExNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2941178?v=4","gravatar_id":"","url":"https://api.github.com/users/kyliau","html_url":"https://github.com/kyliau","followers_url":"https://api.github.com/users/kyliau/followers","following_url":"https://api.github.com/users/kyliau/following{/other_user}","gists_url":"https://api.github.com/users/kyliau/gists{/gist_id}","starred_url":"https://api.github.com/users/kyliau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyliau/subscriptions","organizations_url":"https://api.github.com/users/kyliau/orgs","repos_url":"https://api.github.com/users/kyliau/repos","events_url":"https://api.github.com/users/kyliau/events{/privacy}","received_events_url":"https://api.github.com/users/kyliau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kyliau/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/kyliau/angular","forks_url":"https://api.github.com/repos/kyliau/angular/forks","keys_url":"https://api.github.com/repos/kyliau/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyliau/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyliau/angular/teams","hooks_url":"https://api.github.com/repos/kyliau/angular/hooks","issue_events_url":"https://api.github.com/repos/kyliau/angular/issues/events{/number}","events_url":"https://api.github.com/repos/kyliau/angular/events","assignees_url":"https://api.github.com/repos/kyliau/angular/assignees{/user}","branches_url":"https://api.github.com/repos/kyliau/angular/branches{/branch}","tags_url":"https://api.github.com/repos/kyliau/angular/tags","blobs_url":"https://api.github.com/repos/kyliau/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyliau/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyliau/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyliau/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyliau/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/kyliau/angular/languages","stargazers_url":"https://api.github.com/repos/kyliau/angular/stargazers","contributors_url":"https://api.github.com/repos/kyliau/angular/contributors","subscribers_url":"https://api.github.com/repos/kyliau/angular/subscribers","subscription_url":"https://api.github.com/repos/kyliau/angular/subscription","commits_url":"https://api.github.com/repos/kyliau/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyliau/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyliau/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyliau/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyliau/angular/contents/{+path}","compare_url":"https://api.github.com/repos/kyliau/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyliau/angular/merges","archive_url":"https://api.github.com/repos/kyliau/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyliau/angular/downloads","issues_url":"https://api.github.com/repos/kyliau/angular/issues{/number}","pulls_url":"https://api.github.com/repos/kyliau/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/kyliau/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/kyliau/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyliau/angular/labels{/name}","releases_url":"https://api.github.com/repos/kyliau/angular/releases{/id}","deployments_url":"https://api.github.com/repos/kyliau/angular/deployments","created_at":"2017-10-28T03:04:29Z","updated_at":"2019-12-05T18:45:36Z","pushed_at":"2019-12-05T20:47:46Z","git_url":"git://github.com/kyliau/angular.git","ssh_url":"git@github.com:kyliau/angular.git","clone_url":"https://github.com/kyliau/angular.git","svn_url":"https://github.com/kyliau/angular","homepage":"https://angular.io","size":123571,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"02134172dd498cc42b9c57403c208b5ce239ec9c","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2019-12-05T21:07:54Z","pushed_at":"2019-12-05T21:09:49Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":129866,"stargazers_count":55005,"watchers_count":55005,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15197,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3295,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15197,"open_issues":3295,"watchers":55005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/34238"},"html":{"href":"https://github.com/angular/angular/pull/34238"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/34238"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/34238/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/34238/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/34238/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/4d72852e41939b93a1c880e21032f35b47f53d6f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
other: {"actor":{"display_login":"AndrewKushnir"}}