payload: {"action":"created","issue":{"url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/issues/187","repository_url":"https://api.github.com/repos/libretro/Genesis-Plus-GX","labels_url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/issues/187/comments","events_url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/issues/187/events","html_url":"https://github.com/libretro/Genesis-Plus-GX/pull/187","id":491809482,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2MTA1MjUz","number":187,"title":"Protuguese Brazilian Language","user":{"login":"altiereslima","id":18044879,"node_id":"MDQ6VXNlcjE4MDQ0ODc5","avatar_url":"https://avatars2.githubusercontent.com/u/18044879?v=4","gravatar_id":"","url":"https://api.github.com/users/altiereslima","html_url":"https://github.com/altiereslima","followers_url":"https://api.github.com/users/altiereslima/followers","following_url":"https://api.github.com/users/altiereslima/following{/other_user}","gists_url":"https://api.github.com/users/altiereslima/gists{/gist_id}","starred_url":"https://api.github.com/users/altiereslima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/altiereslima/subscriptions","organizations_url":"https://api.github.com/users/altiereslima/orgs","repos_url":"https://api.github.com/users/altiereslima/repos","events_url":"https://api.github.com/users/altiereslima/events{/privacy}","received_events_url":"https://api.github.com/users/altiereslima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-09-10T17:41:30Z","updated_at":"2019-09-17T08:31:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/pulls/187","html_url":"https://github.com/libretro/Genesis-Plus-GX/pull/187","diff_url":"https://github.com/libretro/Genesis-Plus-GX/pull/187.diff","patch_url":"https://github.com/libretro/Genesis-Plus-GX/pull/187.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/issues/comments/532119583","html_url":"https://github.com/libretro/Genesis-Plus-GX/pull/187#issuecomment-532119583","issue_url":"https://api.github.com/repos/libretro/Genesis-Plus-GX/issues/187","id":532119583,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMjExOTU4Mw==","user":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"created_at":"2019-09-17T08:31:58Z","updated_at":"2019-09-17T08:31:58Z","author_association":"NONE","body":"@twinaphex Yes, this looks fine\r\n\r\n@altiereslima Thanks for the great translation! Just for future reference, though, here are a couple of pointers:\r\n\r\n1) When an option has values that don't need translating (enabled/disabled, or numbers), the values should be omitted - e.g. this:\r\n\r\n```c\r\n   {\r\n      \"genesis_plus_gx_lowpass_range\",\r\n      \"Filtro passa-baixo %\",\r\n      \"Especifica a frequência de corte do filtro de áudio passa-baixo. Um valor mais alto aumenta a 'força' percebida do filtro, uma vez que uma faixa mais ampla do espectro de alta frequência é atenuada.\",\r\n      {\r\n         { \"5\",  NULL },\r\n         { \"10\", NULL },\r\n         { \"15\", NULL },\r\n         { \"20\", NULL },\r\n         { \"25\", NULL },\r\n         { \"30\", NULL },\r\n         { \"35\", NULL },\r\n         { \"40\", NULL },\r\n         { \"45\", NULL },\r\n         { \"50\", NULL },\r\n         { \"55\", NULL },\r\n         { \"60\", NULL },\r\n         { \"65\", NULL },\r\n         { \"70\", NULL },\r\n         { \"75\", NULL },\r\n         { \"80\", NULL },\r\n         { \"85\", NULL },\r\n         { \"90\", NULL },\r\n         { \"95\", NULL },\r\n         { NULL, NULL },\r\n      },\r\n      \"60\"\r\n   },\r\n```\r\n\r\ncan be written as this:\r\n\r\n```c\r\n   {\r\n      \"genesis_plus_gx_lowpass_range\",\r\n      \"Filtro passa-baixo %\",\r\n      \"Especifica a frequência de corte do filtro de áudio passa-baixo. Um valor mais alto aumenta a 'força' percebida do filtro, uma vez que uma faixa mais ampla do espectro de alta frequência é atenuada.\",\r\n      {\r\n         { NULL, NULL },\r\n      },\r\n      \"60\"\r\n   },\r\n```\r\n\r\n2) Default values are always read from the US English options, so you can leave them as `NULL` in any translations - e.g.:\r\n\r\n```c\r\n   {\r\n      \"genesis_plus_gx_audio_filter\",\r\n      \"Filtro de áudio\",\r\n      \"Ativa um filtro de áudio passa-baixo para simular melhor o som característico de um Mega Drive Modelo 1.\",\r\n      {\r\n         { \"disabled\", NULL },\r\n         { \"low-pass\", \"Passa-baixo\" },\r\n         { NULL, NULL },\r\n      },\r\n      NULL\r\n   },\r\n```\r\n\r\nThere's an example showing this stuff here: https://github.com/libretro/libretro-common/blob/master/samples/core_options/example_translation/libretro_core_options_intl.h\r\n\r\nNote that there's nothing actually wrong with the way you've done this (and the Turkish translation is the same), but omitting unnecessary entries is tidier, and easier from a maintenance perspective  :)"}}
other: {"actor":{"display_login":"jdgleaver"}}