payload: {"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/304406446","pull_request_review_id":263033751,"id":304406446,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDQwNjQ0Ng==","diff_hunk":"@@ -104,19 +105,39 @@ create or replace function list_tablespace_dbid_dirs(expected_number_of_tablespa\n $$ language plpythonu;\n \n \n+CREATE OR REPLACE FUNCTION insert_noop_xlog_record_master() RETURNS VOID AS\n+    '@abs_builddir@/regress.so', 'insert_noop_xlog_record'\n+LANGUAGE C EXECUTE ON MASTER;\n+\n+\n+CREATE OR REPLACE FUNCTION insert_noop_xlog_record_all_segments() RETURNS SETOF VOID AS\n+'@abs_builddir@/regress.so', 'insert_noop_xlog_record'\n+    LANGUAGE C EXECUTE ON ALL SEGMENTS;\n+\n+\n+CREATE OR REPLACE FUNCTION insert_noop_xlog_record() RETURNS VOID AS $$\n+BEGIN\n+    PERFORM insert_noop_xlog_record_master();\n+    PERFORM insert_noop_xlog_record_all_segments();\n+END;\n+$$LANGUAGE plpgsql;\n+\n+\n create or replace function give_mirrors_time_to_catch_up() returns void as $$\n-declare number_of_segments_behind integer;\n begin\n-\tcheckpoint;\n-\tLOOP\n-\t\tselect count(1) into number_of_segments_behind from gp_stat_replication where sent_location != replay_location;\n-\t\tEXIT WHEN number_of_segments_behind = 0;\n-\t\tperform pg_sleep(0.5);\n-\tEND LOOP;\n+    PERFORM gp_inject_fault2('after_xlog_redo_noop', 'sleep', dbid, hostname, port) FROM gp_segment_configuration WHERE role='m';\n+    PERFORM insert_noop_xlog_record();\n+    PERFORM gp_wait_until_triggered_fault2('after_xlog_redo_noop', 1, dbid, hostname, port) FROM gp_segment_configuration WHERE role='m';\n+    PERFORM gp_inject_fault2('after_xlog_redo_noop', 'reset', dbid, hostname, port) FROM gp_segment_configuration WHERE role='m';\n end;","path":"src/test/regress/input/gp_tablespace_with_faults.source","position":46,"original_position":46,"commit_id":"f55d18c17de54ced8e0e4a0a73af54a3d4aea730","original_commit_id":"f55d18c17de54ced8e0e4a0a73af54a3d4aea730","user":{"login":"berlin-ab","id":87432,"node_id":"MDQ6VXNlcjg3NDMy","avatar_url":"https://avatars2.githubusercontent.com/u/87432?v=4","gravatar_id":"","url":"https://api.github.com/users/berlin-ab","html_url":"https://github.com/berlin-ab","followers_url":"https://api.github.com/users/berlin-ab/followers","following_url":"https://api.github.com/users/berlin-ab/following{/other_user}","gists_url":"https://api.github.com/users/berlin-ab/gists{/gist_id}","starred_url":"https://api.github.com/users/berlin-ab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berlin-ab/subscriptions","organizations_url":"https://api.github.com/users/berlin-ab/orgs","repos_url":"https://api.github.com/users/berlin-ab/repos","events_url":"https://api.github.com/users/berlin-ab/events{/privacy}","received_events_url":"https://api.github.com/users/berlin-ab/received_events","type":"User","site_admin":false},"body":"Where did you get cur_xlog_loc from in this example? I considered `pg_current_xlog_location()` but realized that it wouldn't run on the segment, and therefore wouldn't give us the correct value. I'm going to move forward with the xlog noop for now, but I'll revisit this strategy later. ","created_at":"2019-07-17T13:41:09Z","updated_at":"2019-07-17T13:41:09Z","html_url":"https://github.com/greenplum-db/gpdb/pull/8148#discussion_r304406446","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/304406446"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/8148#discussion_r304406446"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148"}},"in_reply_to_id":304236812},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148","id":298116221,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MTE2MjIx","html_url":"https://github.com/greenplum-db/gpdb/pull/8148","diff_url":"https://github.com/greenplum-db/gpdb/pull/8148.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/8148.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/8148","number":8148,"state":"open","locked":false,"title":"Speed up gp_tablespace_with_faults by using xlog noop","user":{"login":"berlin-ab","id":87432,"node_id":"MDQ6VXNlcjg3NDMy","avatar_url":"https://avatars2.githubusercontent.com/u/87432?v=4","gravatar_id":"","url":"https://api.github.com/users/berlin-ab","html_url":"https://github.com/berlin-ab","followers_url":"https://api.github.com/users/berlin-ab/followers","following_url":"https://api.github.com/users/berlin-ab/following{/other_user}","gists_url":"https://api.github.com/users/berlin-ab/gists{/gist_id}","starred_url":"https://api.github.com/users/berlin-ab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berlin-ab/subscriptions","organizations_url":"https://api.github.com/users/berlin-ab/orgs","repos_url":"https://api.github.com/users/berlin-ab/repos","events_url":"https://api.github.com/users/berlin-ab/events{/privacy}","received_events_url":"https://api.github.com/users/berlin-ab/received_events","type":"User","site_admin":false},"body":"- also, wait for primaries to recover after panics\r\n- also, checkpoint at the end of each test to set redo point to not leak into next test\r\n","created_at":"2019-07-16T16:17:49Z","updated_at":"2019-07-17T13:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e640c3650a9a1525f97e4111e22e19aaad5c0fbe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/8148/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/f55d18c17de54ced8e0e4a0a73af54a3d4aea730","head":{"label":"berlin-ab:switch-to-noop-xlog-for-gp-tablespaces","ref":"switch-to-noop-xlog-for-gp-tablespaces","sha":"f55d18c17de54ced8e0e4a0a73af54a3d4aea730","user":{"login":"berlin-ab","id":87432,"node_id":"MDQ6VXNlcjg3NDMy","avatar_url":"https://avatars2.githubusercontent.com/u/87432?v=4","gravatar_id":"","url":"https://api.github.com/users/berlin-ab","html_url":"https://github.com/berlin-ab","followers_url":"https://api.github.com/users/berlin-ab/followers","following_url":"https://api.github.com/users/berlin-ab/following{/other_user}","gists_url":"https://api.github.com/users/berlin-ab/gists{/gist_id}","starred_url":"https://api.github.com/users/berlin-ab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berlin-ab/subscriptions","organizations_url":"https://api.github.com/users/berlin-ab/orgs","repos_url":"https://api.github.com/users/berlin-ab/repos","events_url":"https://api.github.com/users/berlin-ab/events{/privacy}","received_events_url":"https://api.github.com/users/berlin-ab/received_events","type":"User","site_admin":false},"repo":{"id":144598253,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1OTgyNTM=","name":"gpdb","full_name":"berlin-ab/gpdb","private":false,"owner":{"login":"berlin-ab","id":87432,"node_id":"MDQ6VXNlcjg3NDMy","avatar_url":"https://avatars2.githubusercontent.com/u/87432?v=4","gravatar_id":"","url":"https://api.github.com/users/berlin-ab","html_url":"https://github.com/berlin-ab","followers_url":"https://api.github.com/users/berlin-ab/followers","following_url":"https://api.github.com/users/berlin-ab/following{/other_user}","gists_url":"https://api.github.com/users/berlin-ab/gists{/gist_id}","starred_url":"https://api.github.com/users/berlin-ab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berlin-ab/subscriptions","organizations_url":"https://api.github.com/users/berlin-ab/orgs","repos_url":"https://api.github.com/users/berlin-ab/repos","events_url":"https://api.github.com/users/berlin-ab/events{/privacy}","received_events_url":"https://api.github.com/users/berlin-ab/received_events","type":"User","site_admin":false},"html_url":"https://github.com/berlin-ab/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/berlin-ab/gpdb","forks_url":"https://api.github.com/repos/berlin-ab/gpdb/forks","keys_url":"https://api.github.com/repos/berlin-ab/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/berlin-ab/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/berlin-ab/gpdb/teams","hooks_url":"https://api.github.com/repos/berlin-ab/gpdb/hooks","issue_events_url":"https://api.github.com/repos/berlin-ab/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/berlin-ab/gpdb/events","assignees_url":"https://api.github.com/repos/berlin-ab/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/berlin-ab/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/berlin-ab/gpdb/tags","blobs_url":"https://api.github.com/repos/berlin-ab/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/berlin-ab/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/berlin-ab/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/berlin-ab/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/berlin-ab/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/berlin-ab/gpdb/languages","stargazers_url":"https://api.github.com/repos/berlin-ab/gpdb/stargazers","contributors_url":"https://api.github.com/repos/berlin-ab/gpdb/contributors","subscribers_url":"https://api.github.com/repos/berlin-ab/gpdb/subscribers","subscription_url":"https://api.github.com/repos/berlin-ab/gpdb/subscription","commits_url":"https://api.github.com/repos/berlin-ab/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/berlin-ab/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/berlin-ab/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/berlin-ab/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/berlin-ab/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/berlin-ab/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/berlin-ab/gpdb/merges","archive_url":"https://api.github.com/repos/berlin-ab/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/berlin-ab/gpdb/downloads","issues_url":"https://api.github.com/repos/berlin-ab/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/berlin-ab/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/berlin-ab/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/berlin-ab/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/berlin-ab/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/berlin-ab/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/berlin-ab/gpdb/deployments","created_at":"2018-08-13T15:24:11Z","updated_at":"2019-07-15T15:20:33Z","pushed_at":"2019-07-17T01:07:56Z","git_url":"git://github.com/berlin-ab/gpdb.git","ssh_url":"git@github.com:berlin-ab/gpdb.git","clone_url":"https://github.com/berlin-ab/gpdb.git","svn_url":"https://github.com/berlin-ab/gpdb","homepage":"http://greenplum.org","size":369530,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"41646c8d46ced65df8e1c712fc85716522f3c0d8","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2019-07-17T08:18:31Z","pushed_at":"2019-07-17T13:22:39Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":371368,"stargazers_count":3351,"watchers_count":3351,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":967,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":269,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":967,"open_issues":269,"watchers":3351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/8148"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/8148"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/8148/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/8148/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/f55d18c17de54ced8e0e4a0a73af54a3d4aea730"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"berlin-ab"}}