payload: {"action":"created","issue":{"url":"https://api.github.com/repos/akka/akka/issues/26468","repository_url":"https://api.github.com/repos/akka/akka","labels_url":"https://api.github.com/repos/akka/akka/issues/26468/labels{/name}","comments_url":"https://api.github.com/repos/akka/akka/issues/26468/comments","events_url":"https://api.github.com/repos/akka/akka/issues/26468/events","html_url":"https://github.com/akka/akka/pull/26468","id":417367075,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4Mzc4ODIz","number":26468,"title":"Lease API + use in cluster singleton","user":{"login":"chbatey","id":1866779,"node_id":"MDQ6VXNlcjE4NjY3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"labels":[{"id":37797347,"node_id":"MDU6TGFiZWwzNzc5NzM0Nw==","url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-03-05T15:54:29Z","updated_at":"2019-03-07T08:35:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/26468","html_url":"https://github.com/akka/akka/pull/26468","diff_url":"https://github.com/akka/akka/pull/26468.diff","patch_url":"https://github.com/akka/akka/pull/26468.patch"},"body":"I was thinking of refactoring the cluster singleton manager to take in a separate interface for its cluster interactions so that I could test all the states/transitions without needing a real cluster/multi JVM tests. We've done that for typed extensions I think. \r\n\r\nRemaining:\r\n* [x] Periodic check of the lease \r\n* [ ] Docs for the lease API and how to implement\r\n* [ ] Default lease impl?"},"comment":{"url":"https://api.github.com/repos/akka/akka/issues/comments/470434422","html_url":"https://github.com/akka/akka/pull/26468#issuecomment-470434422","issue_url":"https://api.github.com/repos/akka/akka/issues/26468","id":470434422,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MDQzNDQyMg==","user":{"login":"patriknw","id":336161,"node_id":"MDQ6VXNlcjMzNjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"created_at":"2019-03-07T08:35:45Z","updated_at":"2019-03-07T08:35:45Z","author_association":"MEMBER","body":"> Should we include actor system name in the lease name in case the same lease infrastructure is used for multiple clusters?\r\n\r\nYes, good point. We should do that in SBR too."}}
other: {"actor":{"display_login":"patriknw"}}