payload: {"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/7126","repository_url":"https://api.github.com/repos/spring-projects/spring-security","labels_url":"https://api.github.com/repos/spring-projects/spring-security/issues/7126/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/7126/comments","events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/7126/events","html_url":"https://github.com/spring-projects/spring-security/issues/7126","id":472217397,"node_id":"MDU6SXNzdWU0NzIyMTczOTc=","number":7126,"title":"BearerTokenAuthenticationFilter should check if authentication is required","user":{"login":"jzheaux","id":3627351,"node_id":"MDQ6VXNlcjM2MjczNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3627351?v=4","gravatar_id":"","url":"https://api.github.com/users/jzheaux","html_url":"https://github.com/jzheaux","followers_url":"https://api.github.com/users/jzheaux/followers","following_url":"https://api.github.com/users/jzheaux/following{/other_user}","gists_url":"https://api.github.com/users/jzheaux/gists{/gist_id}","starred_url":"https://api.github.com/users/jzheaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzheaux/subscriptions","organizations_url":"https://api.github.com/users/jzheaux/orgs","repos_url":"https://api.github.com/users/jzheaux/repos","events_url":"https://api.github.com/users/jzheaux/events{/privacy}","received_events_url":"https://api.github.com/users/jzheaux/received_events","type":"User","site_admin":false},"labels":[{"id":555556091,"node_id":"MDU6TGFiZWw1NTU1NTYwOTE=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/in:%20oauth2","name":"in: oauth2","color":"e8f9de","default":false},{"id":322225082,"node_id":"MDU6TGFiZWwzMjIyMjUwODI=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/type:%20enhancement","name":"type: enhancement","color":"e3d9fc","default":false}],"state":"open","locked":false,"assignee":{"login":"jzheaux","id":3627351,"node_id":"MDQ6VXNlcjM2MjczNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3627351?v=4","gravatar_id":"","url":"https://api.github.com/users/jzheaux","html_url":"https://github.com/jzheaux","followers_url":"https://api.github.com/users/jzheaux/followers","following_url":"https://api.github.com/users/jzheaux/following{/other_user}","gists_url":"https://api.github.com/users/jzheaux/gists{/gist_id}","starred_url":"https://api.github.com/users/jzheaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzheaux/subscriptions","organizations_url":"https://api.github.com/users/jzheaux/orgs","repos_url":"https://api.github.com/users/jzheaux/repos","events_url":"https://api.github.com/users/jzheaux/events{/privacy}","received_events_url":"https://api.github.com/users/jzheaux/received_events","type":"User","site_admin":false},"assignees":[{"login":"jzheaux","id":3627351,"node_id":"MDQ6VXNlcjM2MjczNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3627351?v=4","gravatar_id":"","url":"https://api.github.com/users/jzheaux","html_url":"https://github.com/jzheaux","followers_url":"https://api.github.com/users/jzheaux/followers","following_url":"https://api.github.com/users/jzheaux/following{/other_user}","gists_url":"https://api.github.com/users/jzheaux/gists{/gist_id}","starred_url":"https://api.github.com/users/jzheaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzheaux/subscriptions","organizations_url":"https://api.github.com/users/jzheaux/orgs","repos_url":"https://api.github.com/users/jzheaux/repos","events_url":"https://api.github.com/users/jzheaux/events{/privacy}","received_events_url":"https://api.github.com/users/jzheaux/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-security/milestones/142","html_url":"https://github.com/spring-projects/spring-security/milestone/142","labels_url":"https://api.github.com/repos/spring-projects/spring-security/milestones/142/labels","id":4109937,"node_id":"MDk6TWlsZXN0b25lNDEwOTkzNw==","number":142,"title":"5.2.0.M4","description":"","creator":{"login":"rwinch","id":362503,"node_id":"MDQ6VXNlcjM2MjUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/362503?v=4","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":66,"state":"open","created_at":"2019-03-04T20:15:13Z","updated_at":"2019-07-26T18:13:36Z","due_on":"2019-08-01T07:00:00Z","closed_at":null},"comments":0,"created_at":"2019-07-24T10:58:14Z","updated_at":"2019-07-26T20:49:38Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Similar to [`BasicAuthenticationFilter`](https://github.com/spring-projects/spring-security/blob/master/web/src/main/java/org/springframework/security/web/authentication/www/BasicAuthenticationFilter.java#L206), `BearerTokenAuthenticationFilter` should check if authentication is required before proceeding.\r\n\r\nAs does `BasicAuthenticationFilter`, this would happen after the token is extracted from the header, but before the `AuthenticationManager` is invoked.\r\n\r\nThe same three checks that are done with `BasicAuthenticationFilter` would be performed with the slight change that instead of comparing usernames, `BearerTokenAuthenticationFilter` would compare token values."},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments/515595154","html_url":"https://github.com/spring-projects/spring-security/issues/7126#issuecomment-515595154","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/7126","id":515595154,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNTU5NTE1NA==","user":{"login":"rwinch","id":362503,"node_id":"MDQ6VXNlcjM2MjUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/362503?v=4","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"created_at":"2019-07-26T20:49:38Z","updated_at":"2019-07-26T20:49:38Z","author_association":"MEMBER","body":"This has been a source of problems for BasicAuthenticationFilter and just because we do it in one place doesn't mean we should do it it in another. Could you document why this is necessary? \r\n\r\nAnother note, if we do this perhaps it is just part of the matcher that determines if the filter is invoked. "}}
other: {"actor":{"display_login":"rwinch"}}