payload: {"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/275447459","pull_request_review_id":226757308,"id":275447459,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTQ0NzQ1OQ==","diff_hunk":"@@ -4,6 +4,9 @@\n DOCKER_GRAPHDRIVER := $(if $(DOCKER_GRAPHDRIVER),$(DOCKER_GRAPHDRIVER),$(shell docker info 2>&1 | grep \"Storage Driver\" | sed 's/.*: //'))\n export DOCKER_GRAPHDRIVER\n \n+# enable/disable cross-compile\n+DOCKER_CROSS := false","path":"Makefile","position":null,"original_position":5,"commit_id":"934b3a3841fb47649ccf93257ed909cbd0f1caed","original_commit_id":"dd706306c63aa081bb9fda355871b551075b391b","user":{"login":"thaJeztah","id":1804568,"node_id":"MDQ6VXNlcjE4MDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Updated 👍 ","created_at":"2019-04-15T16:38:14Z","updated_at":"2019-04-15T16:38:14Z","html_url":"https://github.com/moby/moby/pull/39069#discussion_r275447459","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/39069","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/275447459"},"html":{"href":"https://github.com/moby/moby/pull/39069#discussion_r275447459"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/39069"}},"in_reply_to_id":275438919},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/39069","id":270247108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMjQ3MTA4","html_url":"https://github.com/moby/moby/pull/39069","diff_url":"https://github.com/moby/moby/pull/39069.diff","patch_url":"https://github.com/moby/moby/pull/39069.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/39069","number":39069,"state":"open","locked":false,"title":"Fix DOCKER_CROSS being overwritten","user":{"login":"thaJeztah","id":1804568,"node_id":"MDQ6VXNlcjE4MDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Not exactly sure why, but this line;\r\n\r\n    build: DOCKER_CROSS ?= false\r\n\r\nAlways overwrote `DOCKER_CROSS` when running `make cross`. Perhaps because it is set in `cross: DOCKER_CROSS := true`, and in a different scope? May also be dependent on the version of `make` in use.\r\n\r\n","created_at":"2019-04-13T18:54:36Z","updated_at":"2019-04-15T16:38:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9afe68c4129dffbd675aa4dbc8d26f96670ba716","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":175375407,"node_id":"MDU6TGFiZWwxNzUzNzU0MDc=","url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/39069/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/39069/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/39069/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/934b3a3841fb47649ccf93257ed909cbd0f1caed","head":{"label":"thaJeztah:fix_cross","ref":"fix_cross","sha":"934b3a3841fb47649ccf93257ed909cbd0f1caed","user":{"login":"thaJeztah","id":1804568,"node_id":"MDQ6VXNlcjE4MDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"repo":{"id":22146654,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE0NjY1NA==","name":"docker","full_name":"thaJeztah/docker","private":false,"owner":{"login":"thaJeztah","id":1804568,"node_id":"MDQ6VXNlcjE4MDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thaJeztah/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/thaJeztah/docker","forks_url":"https://api.github.com/repos/thaJeztah/docker/forks","keys_url":"https://api.github.com/repos/thaJeztah/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thaJeztah/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thaJeztah/docker/teams","hooks_url":"https://api.github.com/repos/thaJeztah/docker/hooks","issue_events_url":"https://api.github.com/repos/thaJeztah/docker/issues/events{/number}","events_url":"https://api.github.com/repos/thaJeztah/docker/events","assignees_url":"https://api.github.com/repos/thaJeztah/docker/assignees{/user}","branches_url":"https://api.github.com/repos/thaJeztah/docker/branches{/branch}","tags_url":"https://api.github.com/repos/thaJeztah/docker/tags","blobs_url":"https://api.github.com/repos/thaJeztah/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thaJeztah/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thaJeztah/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/thaJeztah/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thaJeztah/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/thaJeztah/docker/languages","stargazers_url":"https://api.github.com/repos/thaJeztah/docker/stargazers","contributors_url":"https://api.github.com/repos/thaJeztah/docker/contributors","subscribers_url":"https://api.github.com/repos/thaJeztah/docker/subscribers","subscription_url":"https://api.github.com/repos/thaJeztah/docker/subscription","commits_url":"https://api.github.com/repos/thaJeztah/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/thaJeztah/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/thaJeztah/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/thaJeztah/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/thaJeztah/docker/contents/{+path}","compare_url":"https://api.github.com/repos/thaJeztah/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thaJeztah/docker/merges","archive_url":"https://api.github.com/repos/thaJeztah/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thaJeztah/docker/downloads","issues_url":"https://api.github.com/repos/thaJeztah/docker/issues{/number}","pulls_url":"https://api.github.com/repos/thaJeztah/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/thaJeztah/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/thaJeztah/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thaJeztah/docker/labels{/name}","releases_url":"https://api.github.com/repos/thaJeztah/docker/releases{/id}","deployments_url":"https://api.github.com/repos/thaJeztah/docker/deployments","created_at":"2014-07-23T12:38:51Z","updated_at":"2019-04-15T15:56:38Z","pushed_at":"2019-04-15T16:38:07Z","git_url":"git://github.com/thaJeztah/docker.git","ssh_url":"git@github.com:thaJeztah/docker.git","clone_url":"https://github.com/thaJeztah/docker.git","svn_url":"https://github.com/thaJeztah/docker","homepage":"http://www.docker.com","size":139429,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"a85a64e3b4be815302d106aa7aa4a1f28004897e","user":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"node_id":"MDEwOlJlcG9zaXRvcnk3NjkxNjMx","name":"moby","full_name":"moby/moby","private":false,"owner":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2019-04-15T16:28:32Z","pushed_at":"2019-04-15T16:38:11Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":142145,"stargazers_count":52930,"watchers_count":52930,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15309,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3662,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15309,"open_issues":3662,"watchers":52930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/39069"},"html":{"href":"https://github.com/moby/moby/pull/39069"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/39069"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/39069/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/39069/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/39069/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/934b3a3841fb47649ccf93257ed909cbd0f1caed"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"thaJeztah"}}