payload: {"action":"created","issue":{"url":"https://api.github.com/repos/simulationcraft/simc/issues/4739","repository_url":"https://api.github.com/repos/simulationcraft/simc","labels_url":"https://api.github.com/repos/simulationcraft/simc/issues/4739/labels{/name}","comments_url":"https://api.github.com/repos/simulationcraft/simc/issues/4739/comments","events_url":"https://api.github.com/repos/simulationcraft/simc/issues/4739/events","html_url":"https://github.com/simulationcraft/simc/pull/4739","id":411125687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNjc0NzQx","number":4739,"title":"Fix wrong decimal point for European LC_NUMERIC","user":{"login":"kwuerl","id":6921877,"node_id":"MDQ6VXNlcjY5MjE4Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6921877?v=4","gravatar_id":"","url":"https://api.github.com/users/kwuerl","html_url":"https://github.com/kwuerl","followers_url":"https://api.github.com/users/kwuerl/followers","following_url":"https://api.github.com/users/kwuerl/following{/other_user}","gists_url":"https://api.github.com/users/kwuerl/gists{/gist_id}","starred_url":"https://api.github.com/users/kwuerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwuerl/subscriptions","organizations_url":"https://api.github.com/users/kwuerl/orgs","repos_url":"https://api.github.com/users/kwuerl/repos","events_url":"https://api.github.com/users/kwuerl/events{/privacy}","received_events_url":"https://api.github.com/users/kwuerl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-02-16T23:10:28Z","updated_at":"2019-02-17T11:01:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/simulationcraft/simc/pulls/4739","html_url":"https://github.com/simulationcraft/simc/pull/4739","diff_url":"https://github.com/simulationcraft/simc/pull/4739.diff","patch_url":"https://github.com/simulationcraft/simc/pull/4739.patch"},"body":"There is an issue with the generation of doubles in json in the German (DE_DE) LC_NUMERIC locale.\r\nDue to the indirect use of _vprint_  in the custom _sc_json_writer_t_ doubles are printed as 1,22 instead of 1.22 resulting in this (While generously ignoring setlocale in the main function):\r\n\r\n`... {\"y\":6,00,\"name\":\"10848 to 10892\"},{\"y\":16,00,\"name\":\"10892 to 10936\"},{\"y\":22,00,\"name\":\"10936 to 10980\"},{\"y\":49,00,\"name\":\"10980 to 11024\"},{\"y\":73,00,\"name\":\"11024 to 11068\"},{\"y\":155,00,\"name\":\"11068 to 11112\"},{\"y\":220,00,\"name\":\"11112 to 11156\"},{\"y\":350,00,\"name\":\"11156 to 11200\"},{\"y\":558,00,\"name\":\"11200 to 11244\"},{\"y\":850,00,\"name\":\"11244 to 11288\"},{\"y\":1171,00,\"name\":\"11288 to 11332\"},{\"y\":1692,00,\"name\":\"11332 to 11376\"} ...`\r\n\r\nHonestly i did not understand why doubles need to be limited to precision in machine-read json files so i removed the custom _sc_json_writer_t_ and defaulted to rapidjson's really good dtoa implementation.\r\n\r\nIf you find you need the fixed point doubles in the json output another possibillity ist to simply replace the comma (but i find this pretty ugly...):\r\n\r\n**engine/report/sc_highchart.cpp:513ff**\r\n```\r\nfor ( unsigned i = 0; i < buffer.size(); ++i )\r\n  {\r\n    if(buffer.data()[ i ] == ',')\r\n         this->os_->Put( '.' );\r\n    else\r\n         this->os_->Put(` buffer.data()[ i ] );\r\n  }\r\n```"},"comment":{"url":"https://api.github.com/repos/simulationcraft/simc/issues/comments/464442408","html_url":"https://github.com/simulationcraft/simc/pull/4739#issuecomment-464442408","issue_url":"https://api.github.com/repos/simulationcraft/simc/issues/4739","id":464442408,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NDQ0MjQwOA==","user":{"login":"kwuerl","id":6921877,"node_id":"MDQ6VXNlcjY5MjE4Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6921877?v=4","gravatar_id":"","url":"https://api.github.com/users/kwuerl","html_url":"https://github.com/kwuerl","followers_url":"https://api.github.com/users/kwuerl/followers","following_url":"https://api.github.com/users/kwuerl/following{/other_user}","gists_url":"https://api.github.com/users/kwuerl/gists{/gist_id}","starred_url":"https://api.github.com/users/kwuerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwuerl/subscriptions","organizations_url":"https://api.github.com/users/kwuerl/orgs","repos_url":"https://api.github.com/users/kwuerl/repos","events_url":"https://api.github.com/users/kwuerl/events{/privacy}","received_events_url":"https://api.github.com/users/kwuerl/received_events","type":"User","site_admin":false},"created_at":"2019-02-17T11:01:41Z","updated_at":"2019-02-17T11:01:41Z","author_association":"NONE","body":"This PR is connected to #4740. Both PRs fix the Problem on their own, but each of them a different cause."}}
other: {"actor":{"display_login":"kwuerl"}}