payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/comments/332190447","pull_request_review_id":298351258,"id":332190447,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjE5MDQ0Nw==","diff_hunk":"@@ -274,8 +279,19 @@ AFRAME.registerSystem(\"userinput\", {\n           const activeDevice = this.activeDevices.items[i];\n           const mapping = vrGamepadMappings.get(activeDevice.constructor);\n           mapping && this.registeredMappings.add(mapping);\n-          if (activeDevice instanceof ViveControllerDevice && activeDevice.isViveWand) {\n-            this.registeredMappings.add(viveWandUserBindings);\n+\n+          if (activeDevice instanceof ViveControllerDevice && activeDevice.gamepad) {\n+            console.log(activeDevice);","path":"src/systems/userinput/userinput.js","position":22,"original_position":22,"commit_id":"f7908e69c222c650ed3f9e60f86358f83570066f","original_commit_id":"f7908e69c222c650ed3f9e60f86358f83570066f","user":{"login":"johnshaughnessy","id":4072106,"node_id":"MDQ6VXNlcjQwNzIxMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4072106?v=4","gravatar_id":"","url":"https://api.github.com/users/johnshaughnessy","html_url":"https://github.com/johnshaughnessy","followers_url":"https://api.github.com/users/johnshaughnessy/followers","following_url":"https://api.github.com/users/johnshaughnessy/following{/other_user}","gists_url":"https://api.github.com/users/johnshaughnessy/gists{/gist_id}","starred_url":"https://api.github.com/users/johnshaughnessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnshaughnessy/subscriptions","organizations_url":"https://api.github.com/users/johnshaughnessy/orgs","repos_url":"https://api.github.com/users/johnshaughnessy/repos","events_url":"https://api.github.com/users/johnshaughnessy/events{/privacy}","received_events_url":"https://api.github.com/users/johnshaughnessy/received_events","type":"User","site_admin":false},"body":"drop","created_at":"2019-10-07T19:15:23Z","updated_at":"2019-10-07T19:18:29Z","html_url":"https://github.com/mozilla/hubs/pull/1792#discussion_r332190447","pull_request_url":"https://api.github.com/repos/mozilla/hubs/pulls/1792","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments/332190447"},"html":{"href":"https://github.com/mozilla/hubs/pull/1792#discussion_r332190447"},"pull_request":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/1792"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/1792","id":324875473,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0ODc1NDcz","html_url":"https://github.com/mozilla/hubs/pull/1792","diff_url":"https://github.com/mozilla/hubs/pull/1792.diff","patch_url":"https://github.com/mozilla/hubs/pull/1792.patch","issue_url":"https://api.github.com/repos/mozilla/hubs/issues/1792","number":1792,"state":"open","locked":false,"title":"fix bindings for movement for vive focus plus","user":{"login":"InfiniteLee","id":1821537,"node_id":"MDQ6VXNlcjE4MjE1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1821537?v=4","gravatar_id":"","url":"https://api.github.com/users/InfiniteLee","html_url":"https://github.com/InfiniteLee","followers_url":"https://api.github.com/users/InfiniteLee/followers","following_url":"https://api.github.com/users/InfiniteLee/following{/other_user}","gists_url":"https://api.github.com/users/InfiniteLee/gists{/gist_id}","starred_url":"https://api.github.com/users/InfiniteLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfiniteLee/subscriptions","organizations_url":"https://api.github.com/users/InfiniteLee/orgs","repos_url":"https://api.github.com/users/InfiniteLee/repos","events_url":"https://api.github.com/users/InfiniteLee/events{/privacy}","received_events_url":"https://api.github.com/users/InfiniteLee/received_events","type":"User","site_admin":false},"body":"We are currently using the same input bindings for the Vive Focus Plus as the Vive and Index, however it has inverted y touchpad axis coordinates. This fixes that. \r\n\r\nThere is a separate issue where the pressing on the left touchpad on either controller causes the trigger to also fire (in Hubs this is treated as a teleport)- this appears to be a bug at the gamepad api level, not in Hubs. ","created_at":"2019-10-04T22:54:24Z","updated_at":"2019-10-07T19:18:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac101833eee4001bbf3cb923babeb4cb3f7d9d44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/hubs/pulls/1792/commits","review_comments_url":"https://api.github.com/repos/mozilla/hubs/pulls/1792/comments","review_comment_url":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/hubs/issues/1792/comments","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/f7908e69c222c650ed3f9e60f86358f83570066f","head":{"label":"mozilla:fix/vive-focus-plus-bindings","ref":"fix/vive-focus-plus-bindings","sha":"f7908e69c222c650ed3f9e60f86358f83570066f","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/hubs","description":"Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2019-10-07T17:57:07Z","pushed_at":"2019-10-07T18:26:09Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":146527,"stargazers_count":314,"watchers_count":314,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":239,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":84,"open_issues":239,"watchers":314,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"2e4b565b38dbc209cbe41e595ba5092d8e45237c","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/hubs","description":"Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2019-10-07T17:57:07Z","pushed_at":"2019-10-07T18:26:09Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":146527,"stargazers_count":314,"watchers_count":314,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":239,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":84,"open_issues":239,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/1792"},"html":{"href":"https://github.com/mozilla/hubs/pull/1792"},"issue":{"href":"https://api.github.com/repos/mozilla/hubs/issues/1792"},"comments":{"href":"https://api.github.com/repos/mozilla/hubs/issues/1792/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/1792/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/1792/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/hubs/statuses/f7908e69c222c650ed3f9e60f86358f83570066f"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"johnshaughnessy"}}