payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fwupd/fwupd/pulls/comments/328630314","pull_request_review_id":293744905,"id":328630314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODYzMDMxNA==","diff_hunk":"@@ -0,0 +1,126 @@\n+/*\n+ * Copyright (C) 2019 Mario Limonciello <mario.limonciello@dell.com>\n+ *\n+ * SPDX-License-Identifier: LGPL-2.1+\n+ */\n+\n+#include \"config.h\"\n+\n+#include <gio/gio.h>\n+\n+#include \"fu-uefi-udisks.h\"\n+#include \"fwupd-common.h\"\n+#include \"fwupd-error.h\"\n+\n+#define UDISKS_DBUS_SERVICE\t\t\"org.freedesktop.UDisks2\"\n+#define UDISKS_DBUS_PATH\t\t\"/org/freedesktop/UDisks2/Manager\"\n+#define UDISKS_DBUS_MANAGER_INTERFACE\t\"org.freedesktop.UDisks2.Manager\"\n+#define UDISKS_DBUS_PART_INTERFACE \t\"org.freedesktop.UDisks2.Partition\"\n+#define UDISKS_DBUS_FILE_INTERFACE\t\"org.freedesktop.UDisks2.Filesystem\"\n+#define ESP_DISK_TYPE\t\t\t\"c12a7328-f81f-11d2-ba4b-00a0c93ec93b\"\n+\n+gboolean\n+fu_uefi_is_udisks_path (const gchar *path)\n+{\n+\treturn g_str_has_prefix (path, \"/org/freedesktop/UDisks2/\");\n+}\n+\n+static GDBusProxy *\n+fu_uefi_get_dbus_proxy (const gchar *path, const gchar *interface,","path":"plugins/uefi/fu-uefi-udisks.c","position":29,"original_position":29,"commit_id":"7e81857573576b5207dc5ccd19c237b8379e523c","original_commit_id":"7e81857573576b5207dc5ccd19c237b8379e523c","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"body":"I feel like all the things in theis file should have a `fu_uefi_udisks_` prefix if they're udisks-specific.","created_at":"2019-09-26T14:01:40Z","updated_at":"2019-09-26T14:01:40Z","html_url":"https://github.com/fwupd/fwupd/pull/1406#discussion_r328630314","pull_request_url":"https://api.github.com/repos/fwupd/fwupd/pulls/1406","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fwupd/fwupd/pulls/comments/328630314"},"html":{"href":"https://github.com/fwupd/fwupd/pull/1406#discussion_r328630314"},"pull_request":{"href":"https://api.github.com/repos/fwupd/fwupd/pulls/1406"}}},"pull_request":{"url":"https://api.github.com/repos/fwupd/fwupd/pulls/1406","id":321440860,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxNDQwODYw","html_url":"https://github.com/fwupd/fwupd/pull/1406","diff_url":"https://github.com/fwupd/fwupd/pull/1406.diff","patch_url":"https://github.com/fwupd/fwupd/pull/1406.patch","issue_url":"https://api.github.com/repos/fwupd/fwupd/issues/1406","number":1406,"state":"open","locked":false,"title":"Detect unmounted ESP (Fixes: #1405)","user":{"login":"superm1","id":494526,"node_id":"MDQ6VXNlcjQ5NDUyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/494526?v=4","gravatar_id":"","url":"https://api.github.com/users/superm1","html_url":"https://github.com/superm1","followers_url":"https://api.github.com/users/superm1/followers","following_url":"https://api.github.com/users/superm1/following{/other_user}","gists_url":"https://api.github.com/users/superm1/gists{/gist_id}","starred_url":"https://api.github.com/users/superm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superm1/subscriptions","organizations_url":"https://api.github.com/users/superm1/orgs","repos_url":"https://api.github.com/users/superm1/repos","events_url":"https://api.github.com/users/superm1/events{/privacy}","received_events_url":"https://api.github.com/users/superm1/received_events","type":"User","site_admin":false},"body":"This is also 1.3.3 material, early comments appreciated.\r\n\r\nThere is definitely a memory leak going on with the dbus comms.  Can tell from\r\n```g_atomic_ref_count_dec: assertion 'g_atomitc_int_get (arc) > 0``` showing up in the logs but I'm not sure what i'm doing wrong.  If you spot it, appreciated!\r\n\r\nType of pull request:\r\n- [ ] New plugin (Please include [new plugin checklist](https://github.com/hughsie/fwupd/wiki/New-plugin-checklist))\r\n- [ ] Code fix\r\n- [x] Feature\r\n- [ ] Documentation\r\n","created_at":"2019-09-25T21:10:53Z","updated_at":"2019-09-26T14:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ccbaf50cbf874ae9c1ef97c5cf55670cb064459","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fwupd/fwupd/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/fwupd/fwupd/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/fwupd/fwupd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fwupd/fwupd/issues/1406/comments","statuses_url":"https://api.github.com/repos/fwupd/fwupd/statuses/7e81857573576b5207dc5ccd19c237b8379e523c","head":{"label":"fwupd:wip/superm1/detect-unmounted-esp","ref":"wip/superm1/detect-unmounted-esp","sha":"7e81857573576b5207dc5ccd19c237b8379e523c","user":{"login":"fwupd","id":54377141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mzc3MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/54377141?v=4","gravatar_id":"","url":"https://api.github.com/users/fwupd","html_url":"https://github.com/fwupd","followers_url":"https://api.github.com/users/fwupd/followers","following_url":"https://api.github.com/users/fwupd/following{/other_user}","gists_url":"https://api.github.com/users/fwupd/gists{/gist_id}","starred_url":"https://api.github.com/users/fwupd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwupd/subscriptions","organizations_url":"https://api.github.com/users/fwupd/orgs","repos_url":"https://api.github.com/users/fwupd/repos","events_url":"https://api.github.com/users/fwupd/events{/privacy}","received_events_url":"https://api.github.com/users/fwupd/received_events","type":"Organization","site_admin":false},"repo":{"id":31374735,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM3NDczNQ==","name":"fwupd","full_name":"fwupd/fwupd","private":false,"owner":{"login":"fwupd","id":54377141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mzc3MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/54377141?v=4","gravatar_id":"","url":"https://api.github.com/users/fwupd","html_url":"https://github.com/fwupd","followers_url":"https://api.github.com/users/fwupd/followers","following_url":"https://api.github.com/users/fwupd/following{/other_user}","gists_url":"https://api.github.com/users/fwupd/gists{/gist_id}","starred_url":"https://api.github.com/users/fwupd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwupd/subscriptions","organizations_url":"https://api.github.com/users/fwupd/orgs","repos_url":"https://api.github.com/users/fwupd/repos","events_url":"https://api.github.com/users/fwupd/events{/privacy}","received_events_url":"https://api.github.com/users/fwupd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fwupd/fwupd","description":"A simple daemon to allow session software to update firmware","fork":false,"url":"https://api.github.com/repos/fwupd/fwupd","forks_url":"https://api.github.com/repos/fwupd/fwupd/forks","keys_url":"https://api.github.com/repos/fwupd/fwupd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwupd/fwupd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwupd/fwupd/teams","hooks_url":"https://api.github.com/repos/fwupd/fwupd/hooks","issue_events_url":"https://api.github.com/repos/fwupd/fwupd/issues/events{/number}","events_url":"https://api.github.com/repos/fwupd/fwupd/events","assignees_url":"https://api.github.com/repos/fwupd/fwupd/assignees{/user}","branches_url":"https://api.github.com/repos/fwupd/fwupd/branches{/branch}","tags_url":"https://api.github.com/repos/fwupd/fwupd/tags","blobs_url":"https://api.github.com/repos/fwupd/fwupd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwupd/fwupd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwupd/fwupd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwupd/fwupd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwupd/fwupd/statuses/{sha}","languages_url":"https://api.github.com/repos/fwupd/fwupd/languages","stargazers_url":"https://api.github.com/repos/fwupd/fwupd/stargazers","contributors_url":"https://api.github.com/repos/fwupd/fwupd/contributors","subscribers_url":"https://api.github.com/repos/fwupd/fwupd/subscribers","subscription_url":"https://api.github.com/repos/fwupd/fwupd/subscription","commits_url":"https://api.github.com/repos/fwupd/fwupd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwupd/fwupd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwupd/fwupd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwupd/fwupd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fwupd/fwupd/contents/{+path}","compare_url":"https://api.github.com/repos/fwupd/fwupd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwupd/fwupd/merges","archive_url":"https://api.github.com/repos/fwupd/fwupd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwupd/fwupd/downloads","issues_url":"https://api.github.com/repos/fwupd/fwupd/issues{/number}","pulls_url":"https://api.github.com/repos/fwupd/fwupd/pulls{/number}","milestones_url":"https://api.github.com/repos/fwupd/fwupd/milestones{/number}","notifications_url":"https://api.github.com/repos/fwupd/fwupd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwupd/fwupd/labels{/name}","releases_url":"https://api.github.com/repos/fwupd/fwupd/releases{/id}","deployments_url":"https://api.github.com/repos/fwupd/fwupd/deployments","created_at":"2015-02-26T15:52:25Z","updated_at":"2019-09-26T10:06:25Z","pushed_at":"2019-09-26T13:59:51Z","git_url":"git://github.com/fwupd/fwupd.git","ssh_url":"git@github.com:fwupd/fwupd.git","clone_url":"https://github.com/fwupd/fwupd.git","svn_url":"https://github.com/fwupd/fwupd","homepage":"","size":12404,"stargazers_count":727,"watchers_count":727,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":44,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":103,"open_issues":44,"watchers":727,"default_branch":"master"}},"base":{"label":"fwupd:master","ref":"master","sha":"7b257d969266637a2855118b0fc3192e515a9eb8","user":{"login":"fwupd","id":54377141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mzc3MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/54377141?v=4","gravatar_id":"","url":"https://api.github.com/users/fwupd","html_url":"https://github.com/fwupd","followers_url":"https://api.github.com/users/fwupd/followers","following_url":"https://api.github.com/users/fwupd/following{/other_user}","gists_url":"https://api.github.com/users/fwupd/gists{/gist_id}","starred_url":"https://api.github.com/users/fwupd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwupd/subscriptions","organizations_url":"https://api.github.com/users/fwupd/orgs","repos_url":"https://api.github.com/users/fwupd/repos","events_url":"https://api.github.com/users/fwupd/events{/privacy}","received_events_url":"https://api.github.com/users/fwupd/received_events","type":"Organization","site_admin":false},"repo":{"id":31374735,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM3NDczNQ==","name":"fwupd","full_name":"fwupd/fwupd","private":false,"owner":{"login":"fwupd","id":54377141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mzc3MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/54377141?v=4","gravatar_id":"","url":"https://api.github.com/users/fwupd","html_url":"https://github.com/fwupd","followers_url":"https://api.github.com/users/fwupd/followers","following_url":"https://api.github.com/users/fwupd/following{/other_user}","gists_url":"https://api.github.com/users/fwupd/gists{/gist_id}","starred_url":"https://api.github.com/users/fwupd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwupd/subscriptions","organizations_url":"https://api.github.com/users/fwupd/orgs","repos_url":"https://api.github.com/users/fwupd/repos","events_url":"https://api.github.com/users/fwupd/events{/privacy}","received_events_url":"https://api.github.com/users/fwupd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fwupd/fwupd","description":"A simple daemon to allow session software to update firmware","fork":false,"url":"https://api.github.com/repos/fwupd/fwupd","forks_url":"https://api.github.com/repos/fwupd/fwupd/forks","keys_url":"https://api.github.com/repos/fwupd/fwupd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwupd/fwupd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwupd/fwupd/teams","hooks_url":"https://api.github.com/repos/fwupd/fwupd/hooks","issue_events_url":"https://api.github.com/repos/fwupd/fwupd/issues/events{/number}","events_url":"https://api.github.com/repos/fwupd/fwupd/events","assignees_url":"https://api.github.com/repos/fwupd/fwupd/assignees{/user}","branches_url":"https://api.github.com/repos/fwupd/fwupd/branches{/branch}","tags_url":"https://api.github.com/repos/fwupd/fwupd/tags","blobs_url":"https://api.github.com/repos/fwupd/fwupd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwupd/fwupd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwupd/fwupd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwupd/fwupd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwupd/fwupd/statuses/{sha}","languages_url":"https://api.github.com/repos/fwupd/fwupd/languages","stargazers_url":"https://api.github.com/repos/fwupd/fwupd/stargazers","contributors_url":"https://api.github.com/repos/fwupd/fwupd/contributors","subscribers_url":"https://api.github.com/repos/fwupd/fwupd/subscribers","subscription_url":"https://api.github.com/repos/fwupd/fwupd/subscription","commits_url":"https://api.github.com/repos/fwupd/fwupd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwupd/fwupd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwupd/fwupd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwupd/fwupd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fwupd/fwupd/contents/{+path}","compare_url":"https://api.github.com/repos/fwupd/fwupd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwupd/fwupd/merges","archive_url":"https://api.github.com/repos/fwupd/fwupd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwupd/fwupd/downloads","issues_url":"https://api.github.com/repos/fwupd/fwupd/issues{/number}","pulls_url":"https://api.github.com/repos/fwupd/fwupd/pulls{/number}","milestones_url":"https://api.github.com/repos/fwupd/fwupd/milestones{/number}","notifications_url":"https://api.github.com/repos/fwupd/fwupd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwupd/fwupd/labels{/name}","releases_url":"https://api.github.com/repos/fwupd/fwupd/releases{/id}","deployments_url":"https://api.github.com/repos/fwupd/fwupd/deployments","created_at":"2015-02-26T15:52:25Z","updated_at":"2019-09-26T10:06:25Z","pushed_at":"2019-09-26T13:59:51Z","git_url":"git://github.com/fwupd/fwupd.git","ssh_url":"git@github.com:fwupd/fwupd.git","clone_url":"https://github.com/fwupd/fwupd.git","svn_url":"https://github.com/fwupd/fwupd","homepage":"","size":12404,"stargazers_count":727,"watchers_count":727,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":44,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":103,"open_issues":44,"watchers":727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fwupd/fwupd/pulls/1406"},"html":{"href":"https://github.com/fwupd/fwupd/pull/1406"},"issue":{"href":"https://api.github.com/repos/fwupd/fwupd/issues/1406"},"comments":{"href":"https://api.github.com/repos/fwupd/fwupd/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/fwupd/fwupd/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/fwupd/fwupd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fwupd/fwupd/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/fwupd/fwupd/statuses/7e81857573576b5207dc5ccd19c237b8379e523c"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"hughsie"}}