payload: {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/356914330","pull_request_review_id":330940563,"id":356914330,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjkxNDMzMA==","diff_hunk":"@@ -78,16 +109,22 @@ class Arena : public Allocator {\n   size_t BlockSize() const override { return kBlockSize; }\n \n   bool IsInInlineBlock() const {\n-    return blocks_.empty();\n+    return blocks_size_ == 0;\n   }\n \n  private:\n   char inline_block_[kInlineSize] __attribute__((__aligned__(alignof(max_align_t))));\n-  // Number of bytes allocated in one block\n+  // Number of bytes allocated in one block.\n   const size_t kBlockSize;\n+  // We should have kBlockSize == 1 << kBlockShift;\n+  const uint32_t kBlockShift;\n   // Array of new[] allocated memory blocks\n-  typedef std::vector<char*> Blocks;\n-  Blocks blocks_;\n+  typedef char** Blocks;","path":"memory/arena.h","position":null,"original_position":83,"commit_id":"7126d45fcc4de95659fabe2e660e1269bb2847fe","original_commit_id":"c7bd2584dceaec31b6fcd451cf2325535f52d900","user":{"login":"adagioburner","id":14843681,"node_id":"MDQ6VXNlcjE0ODQzNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/14843681?v=4","gravatar_id":"","url":"https://api.github.com/users/adagioburner","html_url":"https://github.com/adagioburner","followers_url":"https://api.github.com/users/adagioburner/followers","following_url":"https://api.github.com/users/adagioburner/following{/other_user}","gists_url":"https://api.github.com/users/adagioburner/gists{/gist_id}","starred_url":"https://api.github.com/users/adagioburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagioburner/subscriptions","organizations_url":"https://api.github.com/users/adagioburner/orgs","repos_url":"https://api.github.com/users/adagioburner/repos","events_url":"https://api.github.com/users/adagioburner/events{/privacy}","received_events_url":"https://api.github.com/users/adagioburner/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2019-12-12T01:05:20Z","updated_at":"2019-12-12T01:05:20Z","html_url":"https://github.com/facebook/rocksdb/pull/6151#discussion_r356914330","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/6151","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/356914330"},"html":{"href":"https://github.com/facebook/rocksdb/pull/6151#discussion_r356914330"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6151"}},"in_reply_to_id":356894856},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/6151","id":351717261,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNzE3MjYx","html_url":"https://github.com/facebook/rocksdb/pull/6151","diff_url":"https://github.com/facebook/rocksdb/pull/6151.diff","patch_url":"https://github.com/facebook/rocksdb/pull/6151.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/6151","number":6151,"state":"open","locked":false,"title":"Templatize RocksDB memtable skiplist to support 32 bit handles in addition to raw 64 bit pointers","user":{"login":"adagioburner","id":14843681,"node_id":"MDQ6VXNlcjE0ODQzNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/14843681?v=4","gravatar_id":"","url":"https://api.github.com/users/adagioburner","html_url":"https://github.com/adagioburner","followers_url":"https://api.github.com/users/adagioburner/followers","following_url":"https://api.github.com/users/adagioburner/following{/other_user}","gists_url":"https://api.github.com/users/adagioburner/gists{/gist_id}","starred_url":"https://api.github.com/users/adagioburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagioburner/subscriptions","organizations_url":"https://api.github.com/users/adagioburner/orgs","repos_url":"https://api.github.com/users/adagioburner/repos","events_url":"https://api.github.com/users/adagioburner/events{/privacy}","received_events_url":"https://api.github.com/users/adagioburner/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-11T04:14:23Z","updated_at":"2019-12-12T01:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85292dba935631db5be0cf284498b34c58b6e6d1","assignee":{"login":"adagioburner","id":14843681,"node_id":"MDQ6VXNlcjE0ODQzNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/14843681?v=4","gravatar_id":"","url":"https://api.github.com/users/adagioburner","html_url":"https://github.com/adagioburner","followers_url":"https://api.github.com/users/adagioburner/followers","following_url":"https://api.github.com/users/adagioburner/following{/other_user}","gists_url":"https://api.github.com/users/adagioburner/gists{/gist_id}","starred_url":"https://api.github.com/users/adagioburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagioburner/subscriptions","organizations_url":"https://api.github.com/users/adagioburner/orgs","repos_url":"https://api.github.com/users/adagioburner/repos","events_url":"https://api.github.com/users/adagioburner/events{/privacy}","received_events_url":"https://api.github.com/users/adagioburner/received_events","type":"User","site_admin":false},"assignees":[{"login":"adagioburner","id":14843681,"node_id":"MDQ6VXNlcjE0ODQzNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/14843681?v=4","gravatar_id":"","url":"https://api.github.com/users/adagioburner","html_url":"https://github.com/adagioburner","followers_url":"https://api.github.com/users/adagioburner/followers","following_url":"https://api.github.com/users/adagioburner/following{/other_user}","gists_url":"https://api.github.com/users/adagioburner/gists{/gist_id}","starred_url":"https://api.github.com/users/adagioburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagioburner/subscriptions","organizations_url":"https://api.github.com/users/adagioburner/orgs","repos_url":"https://api.github.com/users/adagioburner/repos","events_url":"https://api.github.com/users/adagioburner/events{/privacy}","received_events_url":"https://api.github.com/users/adagioburner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/6151/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/6151/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/6151/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/7126d45fcc4de95659fabe2e660e1269bb2847fe","head":{"label":"adagioburner:T57598689.v2","ref":"T57598689.v2","sha":"7126d45fcc4de95659fabe2e660e1269bb2847fe","user":{"login":"adagioburner","id":14843681,"node_id":"MDQ6VXNlcjE0ODQzNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/14843681?v=4","gravatar_id":"","url":"https://api.github.com/users/adagioburner","html_url":"https://github.com/adagioburner","followers_url":"https://api.github.com/users/adagioburner/followers","following_url":"https://api.github.com/users/adagioburner/following{/other_user}","gists_url":"https://api.github.com/users/adagioburner/gists{/gist_id}","starred_url":"https://api.github.com/users/adagioburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagioburner/subscriptions","organizations_url":"https://api.github.com/users/adagioburner/orgs","repos_url":"https://api.github.com/users/adagioburner/repos","events_url":"https://api.github.com/users/adagioburner/events{/privacy}","received_events_url":"https://api.github.com/users/adagioburner/received_events","type":"User","site_admin":false},"repo":{"id":226958590,"node_id":"MDEwOlJlcG9zaXRvcnkyMjY5NTg1OTA=","name":"rocksdb","full_name":"adagioburner/rocksdb","private":false,"owner":{"login":"adagioburner","id":14843681,"node_id":"MDQ6VXNlcjE0ODQzNjgx","avatar_url":"https://avatars1.githubusercontent.com/u/14843681?v=4","gravatar_id":"","url":"https://api.github.com/users/adagioburner","html_url":"https://github.com/adagioburner","followers_url":"https://api.github.com/users/adagioburner/followers","following_url":"https://api.github.com/users/adagioburner/following{/other_user}","gists_url":"https://api.github.com/users/adagioburner/gists{/gist_id}","starred_url":"https://api.github.com/users/adagioburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagioburner/subscriptions","organizations_url":"https://api.github.com/users/adagioburner/orgs","repos_url":"https://api.github.com/users/adagioburner/repos","events_url":"https://api.github.com/users/adagioburner/events{/privacy}","received_events_url":"https://api.github.com/users/adagioburner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adagioburner/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/adagioburner/rocksdb","forks_url":"https://api.github.com/repos/adagioburner/rocksdb/forks","keys_url":"https://api.github.com/repos/adagioburner/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adagioburner/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adagioburner/rocksdb/teams","hooks_url":"https://api.github.com/repos/adagioburner/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/adagioburner/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/adagioburner/rocksdb/events","assignees_url":"https://api.github.com/repos/adagioburner/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/adagioburner/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/adagioburner/rocksdb/tags","blobs_url":"https://api.github.com/repos/adagioburner/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adagioburner/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adagioburner/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/adagioburner/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adagioburner/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/adagioburner/rocksdb/languages","stargazers_url":"https://api.github.com/repos/adagioburner/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/adagioburner/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/adagioburner/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/adagioburner/rocksdb/subscription","commits_url":"https://api.github.com/repos/adagioburner/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/adagioburner/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/adagioburner/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/adagioburner/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/adagioburner/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/adagioburner/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adagioburner/rocksdb/merges","archive_url":"https://api.github.com/repos/adagioburner/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adagioburner/rocksdb/downloads","issues_url":"https://api.github.com/repos/adagioburner/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/adagioburner/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/adagioburner/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/adagioburner/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adagioburner/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/adagioburner/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/adagioburner/rocksdb/deployments","created_at":"2019-12-09T20:12:42Z","updated_at":"2019-12-09T20:12:44Z","pushed_at":"2019-12-12T00:58:46Z","git_url":"git://github.com/adagioburner/rocksdb.git","ssh_url":"git@github.com:adagioburner/rocksdb.git","clone_url":"https://github.com/adagioburner/rocksdb.git","svn_url":"https://github.com/adagioburner/rocksdb","homepage":"http://rocksdb.org","size":146144,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7a99162a749da0dc3f79a945ff1ce069b95b548a","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM0Mzk1","name":"rocksdb","full_name":"facebook/rocksdb","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2019-12-12T00:02:07Z","pushed_at":"2019-12-12T00:58:48Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":146134,"stargazers_count":15573,"watchers_count":15573,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3468,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":415,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3468,"open_issues":415,"watchers":15573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6151"},"html":{"href":"https://github.com/facebook/rocksdb/pull/6151"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/6151"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/6151/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6151/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6151/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/7126d45fcc4de95659fabe2e660e1269bb2847fe"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"adagioburner"}}