payload: {"action":"opened","number":1729,"pull_request":{"url":"https://api.github.com/repos/urllib3/urllib3/pulls/1729","id":335994980,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1OTk0OTgw","html_url":"https://github.com/urllib3/urllib3/pull/1729","diff_url":"https://github.com/urllib3/urllib3/pull/1729.diff","patch_url":"https://github.com/urllib3/urllib3/pull/1729.patch","issue_url":"https://api.github.com/repos/urllib3/urllib3/issues/1729","number":1729,"state":"open","locked":false,"title":"Fix flaky test_timeout","user":{"login":"pquentin","id":42327,"node_id":"MDQ6VXNlcjQyMzI3","avatar_url":"https://avatars1.githubusercontent.com/u/42327?v=4","gravatar_id":"","url":"https://api.github.com/users/pquentin","html_url":"https://github.com/pquentin","followers_url":"https://api.github.com/users/pquentin/followers","following_url":"https://api.github.com/users/pquentin/following{/other_user}","gists_url":"https://api.github.com/users/pquentin/gists{/gist_id}","starred_url":"https://api.github.com/users/pquentin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pquentin/subscriptions","organizations_url":"https://api.github.com/users/pquentin/orgs","repos_url":"https://api.github.com/users/pquentin/repos","events_url":"https://api.github.com/users/pquentin/events{/privacy}","received_events_url":"https://api.github.com/users/pquentin/received_events","type":"User","site_admin":false},"body":"We had an [interesting test failure in CI](https://ci.appveyor.com/project/pquentin/urllib3/builds/28525448/job/e9nc1ww4d0qyglxe) where this test failed twice in a row: we were expecting a timeout in 0.001 seconds, but both times it took more than one second!\r\n\r\nHow can this happen? Well, when we ask a request to timeout after N seconds, here's what we know:\r\n\r\n * the request will time out, eventually\r\n * it won't timeout before those N seconds\r\n * it could timeout a long time after those N seconds, especially on a busy CI service\r\n\r\nLet's take advantage of those facts by specifying a request-specific timeout that's longer than the pool-level timeout and making sure that the timeout was long indeed.\r\n\r\nWe still test that the request-specific timeout overrides the pool-level timeout, but will stop failing on busy CI services.\r\n\r\n(I'd like to think that this is easier to read and merge commit by commit.)","created_at":"2019-11-03T05:45:10Z","updated_at":"2019-11-03T05:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urllib3/urllib3/pulls/1729/commits","review_comments_url":"https://api.github.com/repos/urllib3/urllib3/pulls/1729/comments","review_comment_url":"https://api.github.com/repos/urllib3/urllib3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urllib3/urllib3/issues/1729/comments","statuses_url":"https://api.github.com/repos/urllib3/urllib3/statuses/a9e1b8699aa748fbd0ec1f861223c19d6ad3d6db","head":{"label":"pquentin:flaky-test-timeout","ref":"flaky-test-timeout","sha":"a9e1b8699aa748fbd0ec1f861223c19d6ad3d6db","user":{"login":"pquentin","id":42327,"node_id":"MDQ6VXNlcjQyMzI3","avatar_url":"https://avatars1.githubusercontent.com/u/42327?v=4","gravatar_id":"","url":"https://api.github.com/users/pquentin","html_url":"https://github.com/pquentin","followers_url":"https://api.github.com/users/pquentin/followers","following_url":"https://api.github.com/users/pquentin/following{/other_user}","gists_url":"https://api.github.com/users/pquentin/gists{/gist_id}","starred_url":"https://api.github.com/users/pquentin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pquentin/subscriptions","organizations_url":"https://api.github.com/users/pquentin/orgs","repos_url":"https://api.github.com/users/pquentin/repos","events_url":"https://api.github.com/users/pquentin/events{/privacy}","received_events_url":"https://api.github.com/users/pquentin/received_events","type":"User","site_admin":false},"repo":{"id":115915424,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU5MTU0MjQ=","name":"urllib3","full_name":"pquentin/urllib3","private":false,"owner":{"login":"pquentin","id":42327,"node_id":"MDQ6VXNlcjQyMzI3","avatar_url":"https://avatars1.githubusercontent.com/u/42327?v=4","gravatar_id":"","url":"https://api.github.com/users/pquentin","html_url":"https://github.com/pquentin","followers_url":"https://api.github.com/users/pquentin/followers","following_url":"https://api.github.com/users/pquentin/following{/other_user}","gists_url":"https://api.github.com/users/pquentin/gists{/gist_id}","starred_url":"https://api.github.com/users/pquentin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pquentin/subscriptions","organizations_url":"https://api.github.com/users/pquentin/orgs","repos_url":"https://api.github.com/users/pquentin/repos","events_url":"https://api.github.com/users/pquentin/events{/privacy}","received_events_url":"https://api.github.com/users/pquentin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pquentin/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":true,"url":"https://api.github.com/repos/pquentin/urllib3","forks_url":"https://api.github.com/repos/pquentin/urllib3/forks","keys_url":"https://api.github.com/repos/pquentin/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pquentin/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pquentin/urllib3/teams","hooks_url":"https://api.github.com/repos/pquentin/urllib3/hooks","issue_events_url":"https://api.github.com/repos/pquentin/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/pquentin/urllib3/events","assignees_url":"https://api.github.com/repos/pquentin/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/pquentin/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/pquentin/urllib3/tags","blobs_url":"https://api.github.com/repos/pquentin/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pquentin/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pquentin/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/pquentin/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pquentin/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/pquentin/urllib3/languages","stargazers_url":"https://api.github.com/repos/pquentin/urllib3/stargazers","contributors_url":"https://api.github.com/repos/pquentin/urllib3/contributors","subscribers_url":"https://api.github.com/repos/pquentin/urllib3/subscribers","subscription_url":"https://api.github.com/repos/pquentin/urllib3/subscription","commits_url":"https://api.github.com/repos/pquentin/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/pquentin/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/pquentin/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/pquentin/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/pquentin/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/pquentin/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pquentin/urllib3/merges","archive_url":"https://api.github.com/repos/pquentin/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pquentin/urllib3/downloads","issues_url":"https://api.github.com/repos/pquentin/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/pquentin/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/pquentin/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/pquentin/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pquentin/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/pquentin/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/pquentin/urllib3/deployments","created_at":"2018-01-01T11:38:01Z","updated_at":"2019-10-10T18:11:30Z","pushed_at":"2019-11-03T05:43:07Z","git_url":"git://github.com/pquentin/urllib3.git","ssh_url":"git@github.com:pquentin/urllib3.git","clone_url":"https://github.com/pquentin/urllib3.git","svn_url":"https://github.com/pquentin/urllib3","homepage":"https://urllib3.readthedocs.io/","size":5260,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleach-spike"}},"base":{"label":"urllib3:master","ref":"master","sha":"f4b36ad045ccfbbfaaadd8e69f9b32c5d81cbd84","user":{"login":"urllib3","id":26825299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODI1Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/26825299?v=4","gravatar_id":"","url":"https://api.github.com/users/urllib3","html_url":"https://github.com/urllib3","followers_url":"https://api.github.com/users/urllib3/followers","following_url":"https://api.github.com/users/urllib3/following{/other_user}","gists_url":"https://api.github.com/users/urllib3/gists{/gist_id}","starred_url":"https://api.github.com/users/urllib3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urllib3/subscriptions","organizations_url":"https://api.github.com/users/urllib3/orgs","repos_url":"https://api.github.com/users/urllib3/repos","events_url":"https://api.github.com/users/urllib3/events{/privacy}","received_events_url":"https://api.github.com/users/urllib3/received_events","type":"Organization","site_admin":false},"repo":{"id":2410676,"node_id":"MDEwOlJlcG9zaXRvcnkyNDEwNjc2","name":"urllib3","full_name":"urllib3/urllib3","private":false,"owner":{"login":"urllib3","id":26825299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODI1Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/26825299?v=4","gravatar_id":"","url":"https://api.github.com/users/urllib3","html_url":"https://github.com/urllib3","followers_url":"https://api.github.com/users/urllib3/followers","following_url":"https://api.github.com/users/urllib3/following{/other_user}","gists_url":"https://api.github.com/users/urllib3/gists{/gist_id}","starred_url":"https://api.github.com/users/urllib3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urllib3/subscriptions","organizations_url":"https://api.github.com/users/urllib3/orgs","repos_url":"https://api.github.com/users/urllib3/repos","events_url":"https://api.github.com/users/urllib3/events{/privacy}","received_events_url":"https://api.github.com/users/urllib3/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/urllib3/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":false,"url":"https://api.github.com/repos/urllib3/urllib3","forks_url":"https://api.github.com/repos/urllib3/urllib3/forks","keys_url":"https://api.github.com/repos/urllib3/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urllib3/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urllib3/urllib3/teams","hooks_url":"https://api.github.com/repos/urllib3/urllib3/hooks","issue_events_url":"https://api.github.com/repos/urllib3/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/urllib3/urllib3/events","assignees_url":"https://api.github.com/repos/urllib3/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/urllib3/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/urllib3/urllib3/tags","blobs_url":"https://api.github.com/repos/urllib3/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urllib3/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urllib3/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/urllib3/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urllib3/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/urllib3/urllib3/languages","stargazers_url":"https://api.github.com/repos/urllib3/urllib3/stargazers","contributors_url":"https://api.github.com/repos/urllib3/urllib3/contributors","subscribers_url":"https://api.github.com/repos/urllib3/urllib3/subscribers","subscription_url":"https://api.github.com/repos/urllib3/urllib3/subscription","commits_url":"https://api.github.com/repos/urllib3/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/urllib3/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/urllib3/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/urllib3/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/urllib3/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/urllib3/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urllib3/urllib3/merges","archive_url":"https://api.github.com/repos/urllib3/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urllib3/urllib3/downloads","issues_url":"https://api.github.com/repos/urllib3/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/urllib3/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/urllib3/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/urllib3/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urllib3/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/urllib3/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/urllib3/urllib3/deployments","created_at":"2011-09-18T18:08:28Z","updated_at":"2019-11-01T16:15:38Z","pushed_at":"2019-11-01T12:57:39Z","git_url":"git://github.com/urllib3/urllib3.git","ssh_url":"git@github.com:urllib3/urllib3.git","clone_url":"https://github.com/urllib3/urllib3.git","svn_url":"https://github.com/urllib3/urllib3","homepage":"https://urllib3.readthedocs.io","size":4677,"stargazers_count":2168,"watchers_count":2168,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":711,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":711,"open_issues":123,"watchers":2168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urllib3/urllib3/pulls/1729"},"html":{"href":"https://github.com/urllib3/urllib3/pull/1729"},"issue":{"href":"https://api.github.com/repos/urllib3/urllib3/issues/1729"},"comments":{"href":"https://api.github.com/repos/urllib3/urllib3/issues/1729/comments"},"review_comments":{"href":"https://api.github.com/repos/urllib3/urllib3/pulls/1729/comments"},"review_comment":{"href":"https://api.github.com/repos/urllib3/urllib3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urllib3/urllib3/pulls/1729/commits"},"statuses":{"href":"https://api.github.com/repos/urllib3/urllib3/statuses/a9e1b8699aa748fbd0ec1f861223c19d6ad3d6db"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":8,"deletions":35,"changed_files":1}}
other: {"actor":{"display_login":"pquentin"}}