payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rancher/docs/pulls/comments/359073208","pull_request_review_id":333636013,"id":359073208,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTA3MzIwOA==","diff_hunk":"@@ -79,7 +79,11 @@ As of Rancher v2.3.0, the Kubernetes metadata feature was added, which allows Ra\n \n **Result:** Kubernetes begins upgrading for the cluster. During the upgrade, your cluster is unavailable.\n \n-> **Note:** The `ingress-nginx` pods are set to only upgrade on delete. After upgrading your cluster, you need to delete these pods to get the correct version for your deployment. \n+### Upgrading ingress-nginx\n+\n+For RKE v0.1.8+, the `ingress-nginx` YAML does not contain an upgrade policy, which makes the update strategy `RollingUpdate` by default. This policy allows the daemonset to restart the pods.\n+\n+For RKE prior to v0.1.8, the `updateStrategy` directive in the `ingress-nginx` YAML was set to `OnDelete` because RKE did not yet support updating ingress and addons. In that case, you will need to delete these pods to get the correct version for your deployment.","path":"content/rancher/v2.x/en/cluster-admin/editing-clusters/_index.md","position":9,"original_position":9,"commit_id":"8780b633886b01197dfa52250a1226f24f36a182","original_commit_id":"8780b633886b01197dfa52250a1226f24f36a182","user":{"login":"Oats87","id":30601846,"node_id":"MDQ6VXNlcjMwNjAxODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/30601846?v=4","gravatar_id":"","url":"https://api.github.com/users/Oats87","html_url":"https://github.com/Oats87","followers_url":"https://api.github.com/users/Oats87/followers","following_url":"https://api.github.com/users/Oats87/following{/other_user}","gists_url":"https://api.github.com/users/Oats87/gists{/gist_id}","starred_url":"https://api.github.com/users/Oats87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oats87/subscriptions","organizations_url":"https://api.github.com/users/Oats87/orgs","repos_url":"https://api.github.com/users/Oats87/repos","events_url":"https://api.github.com/users/Oats87/events{/privacy}","received_events_url":"https://api.github.com/users/Oats87/received_events","type":"User","site_admin":false},"body":"so this actually comes from the the API version, for a while it was `extensions/v1beta1` which defaulted to `OnDelete` and now it's `apps/v1` which defaults to `RollingUpdate` -- we need to find out when this switched","created_at":"2019-12-17T22:56:15Z","updated_at":"2019-12-17T22:56:16Z","html_url":"https://github.com/rancher/docs/pull/1902#discussion_r359073208","pull_request_url":"https://api.github.com/repos/rancher/docs/pulls/1902","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rancher/docs/pulls/comments/359073208"},"html":{"href":"https://github.com/rancher/docs/pull/1902#discussion_r359073208"},"pull_request":{"href":"https://api.github.com/repos/rancher/docs/pulls/1902"}},"in_reply_to_id":359069164},"pull_request":{"url":"https://api.github.com/repos/rancher/docs/pulls/1902","id":329509173,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5NTA5MTcz","html_url":"https://github.com/rancher/docs/pull/1902","diff_url":"https://github.com/rancher/docs/pull/1902.diff","patch_url":"https://github.com/rancher/docs/pull/1902.patch","issue_url":"https://api.github.com/repos/rancher/docs/issues/1902","number":1902,"state":"open","locked":false,"title":"Say to check ingress-nginx upgrade policy","user":{"login":"catherineluse","id":20599230,"node_id":"MDQ6VXNlcjIwNTk5MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/20599230?v=4","gravatar_id":"","url":"https://api.github.com/users/catherineluse","html_url":"https://github.com/catherineluse","followers_url":"https://api.github.com/users/catherineluse/followers","following_url":"https://api.github.com/users/catherineluse/following{/other_user}","gists_url":"https://api.github.com/users/catherineluse/gists{/gist_id}","starred_url":"https://api.github.com/users/catherineluse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catherineluse/subscriptions","organizations_url":"https://api.github.com/users/catherineluse/orgs","repos_url":"https://api.github.com/users/catherineluse/repos","events_url":"https://api.github.com/users/catherineluse/events{/privacy}","received_events_url":"https://api.github.com/users/catherineluse/received_events","type":"User","site_admin":false},"body":"I'm making this correction because it turns out the information in this issue is outdated. https://github.com/rancher/docs/issues/1467\r\n\r\nReference:\r\nhttps://rancher.slack.com/archives/C6U4L2DS9/p1571242285016800","created_at":"2019-10-18T00:02:33Z","updated_at":"2019-12-17T22:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6378522b73aaae49def27b855f3c927c32f7cd54","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aemneina","id":474978,"node_id":"MDQ6VXNlcjQ3NDk3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/474978?v=4","gravatar_id":"","url":"https://api.github.com/users/aemneina","html_url":"https://github.com/aemneina","followers_url":"https://api.github.com/users/aemneina/followers","following_url":"https://api.github.com/users/aemneina/following{/other_user}","gists_url":"https://api.github.com/users/aemneina/gists{/gist_id}","starred_url":"https://api.github.com/users/aemneina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aemneina/subscriptions","organizations_url":"https://api.github.com/users/aemneina/orgs","repos_url":"https://api.github.com/users/aemneina/repos","events_url":"https://api.github.com/users/aemneina/events{/privacy}","received_events_url":"https://api.github.com/users/aemneina/received_events","type":"User","site_admin":false},{"login":"galal-hussein","id":3309968,"node_id":"MDQ6VXNlcjMzMDk5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/3309968?v=4","gravatar_id":"","url":"https://api.github.com/users/galal-hussein","html_url":"https://github.com/galal-hussein","followers_url":"https://api.github.com/users/galal-hussein/followers","following_url":"https://api.github.com/users/galal-hussein/following{/other_user}","gists_url":"https://api.github.com/users/galal-hussein/gists{/gist_id}","starred_url":"https://api.github.com/users/galal-hussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galal-hussein/subscriptions","organizations_url":"https://api.github.com/users/galal-hussein/orgs","repos_url":"https://api.github.com/users/galal-hussein/repos","events_url":"https://api.github.com/users/galal-hussein/events{/privacy}","received_events_url":"https://api.github.com/users/galal-hussein/received_events","type":"User","site_admin":false},{"login":"deniseschannon","id":11410997,"node_id":"MDQ6VXNlcjExNDEwOTk3","avatar_url":"https://avatars1.githubusercontent.com/u/11410997?v=4","gravatar_id":"","url":"https://api.github.com/users/deniseschannon","html_url":"https://github.com/deniseschannon","followers_url":"https://api.github.com/users/deniseschannon/followers","following_url":"https://api.github.com/users/deniseschannon/following{/other_user}","gists_url":"https://api.github.com/users/deniseschannon/gists{/gist_id}","starred_url":"https://api.github.com/users/deniseschannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deniseschannon/subscriptions","organizations_url":"https://api.github.com/users/deniseschannon/orgs","repos_url":"https://api.github.com/users/deniseschannon/repos","events_url":"https://api.github.com/users/deniseschannon/events{/privacy}","received_events_url":"https://api.github.com/users/deniseschannon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1598805948,"node_id":"MDU6TGFiZWwxNTk4ODA1OTQ4","url":"https://api.github.com/repos/rancher/docs/labels/[zube]:%20In%20Review","name":"[zube]: In Review","color":"0052cc","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/docs/pulls/1902/commits","review_comments_url":"https://api.github.com/repos/rancher/docs/pulls/1902/comments","review_comment_url":"https://api.github.com/repos/rancher/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/docs/issues/1902/comments","statuses_url":"https://api.github.com/repos/rancher/docs/statuses/8780b633886b01197dfa52250a1226f24f36a182","head":{"label":"catherineluse:ingress-update-strategy","ref":"ingress-update-strategy","sha":"8780b633886b01197dfa52250a1226f24f36a182","user":{"login":"catherineluse","id":20599230,"node_id":"MDQ6VXNlcjIwNTk5MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/20599230?v=4","gravatar_id":"","url":"https://api.github.com/users/catherineluse","html_url":"https://github.com/catherineluse","followers_url":"https://api.github.com/users/catherineluse/followers","following_url":"https://api.github.com/users/catherineluse/following{/other_user}","gists_url":"https://api.github.com/users/catherineluse/gists{/gist_id}","starred_url":"https://api.github.com/users/catherineluse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catherineluse/subscriptions","organizations_url":"https://api.github.com/users/catherineluse/orgs","repos_url":"https://api.github.com/users/catherineluse/repos","events_url":"https://api.github.com/users/catherineluse/events{/privacy}","received_events_url":"https://api.github.com/users/catherineluse/received_events","type":"User","site_admin":false},"repo":{"id":186486640,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0ODY2NDA=","name":"docs","full_name":"catherineluse/docs","private":false,"owner":{"login":"catherineluse","id":20599230,"node_id":"MDQ6VXNlcjIwNTk5MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/20599230?v=4","gravatar_id":"","url":"https://api.github.com/users/catherineluse","html_url":"https://github.com/catherineluse","followers_url":"https://api.github.com/users/catherineluse/followers","following_url":"https://api.github.com/users/catherineluse/following{/other_user}","gists_url":"https://api.github.com/users/catherineluse/gists{/gist_id}","starred_url":"https://api.github.com/users/catherineluse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catherineluse/subscriptions","organizations_url":"https://api.github.com/users/catherineluse/orgs","repos_url":"https://api.github.com/users/catherineluse/repos","events_url":"https://api.github.com/users/catherineluse/events{/privacy}","received_events_url":"https://api.github.com/users/catherineluse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/catherineluse/docs","description":"Documentation for Rancher products (for 2.0/new site)","fork":true,"url":"https://api.github.com/repos/catherineluse/docs","forks_url":"https://api.github.com/repos/catherineluse/docs/forks","keys_url":"https://api.github.com/repos/catherineluse/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catherineluse/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catherineluse/docs/teams","hooks_url":"https://api.github.com/repos/catherineluse/docs/hooks","issue_events_url":"https://api.github.com/repos/catherineluse/docs/issues/events{/number}","events_url":"https://api.github.com/repos/catherineluse/docs/events","assignees_url":"https://api.github.com/repos/catherineluse/docs/assignees{/user}","branches_url":"https://api.github.com/repos/catherineluse/docs/branches{/branch}","tags_url":"https://api.github.com/repos/catherineluse/docs/tags","blobs_url":"https://api.github.com/repos/catherineluse/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catherineluse/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catherineluse/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/catherineluse/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catherineluse/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/catherineluse/docs/languages","stargazers_url":"https://api.github.com/repos/catherineluse/docs/stargazers","contributors_url":"https://api.github.com/repos/catherineluse/docs/contributors","subscribers_url":"https://api.github.com/repos/catherineluse/docs/subscribers","subscription_url":"https://api.github.com/repos/catherineluse/docs/subscription","commits_url":"https://api.github.com/repos/catherineluse/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/catherineluse/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/catherineluse/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/catherineluse/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/catherineluse/docs/contents/{+path}","compare_url":"https://api.github.com/repos/catherineluse/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catherineluse/docs/merges","archive_url":"https://api.github.com/repos/catherineluse/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catherineluse/docs/downloads","issues_url":"https://api.github.com/repos/catherineluse/docs/issues{/number}","pulls_url":"https://api.github.com/repos/catherineluse/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/catherineluse/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/catherineluse/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catherineluse/docs/labels{/name}","releases_url":"https://api.github.com/repos/catherineluse/docs/releases{/id}","deployments_url":"https://api.github.com/repos/catherineluse/docs/deployments","created_at":"2019-05-13T19:58:30Z","updated_at":"2019-12-16T19:53:50Z","pushed_at":"2019-12-17T22:23:40Z","git_url":"git://github.com/catherineluse/docs.git","ssh_url":"git@github.com:catherineluse/docs.git","clone_url":"https://github.com/catherineluse/docs.git","svn_url":"https://github.com/catherineluse/docs","homepage":"","size":81876,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"4ccbc08d8adde7be597e22e27792b21b476971a5","user":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":129309629,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMDk2Mjk=","name":"docs","full_name":"rancher/docs","private":false,"owner":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rancher/docs","description":"Documentation for Rancher products (for 2.0/new site)","fork":false,"url":"https://api.github.com/repos/rancher/docs","forks_url":"https://api.github.com/repos/rancher/docs/forks","keys_url":"https://api.github.com/repos/rancher/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/docs/teams","hooks_url":"https://api.github.com/repos/rancher/docs/hooks","issue_events_url":"https://api.github.com/repos/rancher/docs/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/docs/events","assignees_url":"https://api.github.com/repos/rancher/docs/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/docs/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/docs/tags","blobs_url":"https://api.github.com/repos/rancher/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/docs/languages","stargazers_url":"https://api.github.com/repos/rancher/docs/stargazers","contributors_url":"https://api.github.com/repos/rancher/docs/contributors","subscribers_url":"https://api.github.com/repos/rancher/docs/subscribers","subscription_url":"https://api.github.com/repos/rancher/docs/subscription","commits_url":"https://api.github.com/repos/rancher/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/docs/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/docs/merges","archive_url":"https://api.github.com/repos/rancher/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/docs/downloads","issues_url":"https://api.github.com/repos/rancher/docs/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/docs/labels{/name}","releases_url":"https://api.github.com/repos/rancher/docs/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/docs/deployments","created_at":"2018-04-12T20:49:13Z","updated_at":"2019-12-17T22:46:45Z","pushed_at":"2019-12-17T22:46:42Z","git_url":"git://github.com/rancher/docs.git","ssh_url":"git@github.com:rancher/docs.git","clone_url":"https://github.com/rancher/docs.git","svn_url":"https://github.com/rancher/docs","homepage":"","size":81325,"stargazers_count":54,"watchers_count":54,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":426,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":144,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":426,"open_issues":144,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/docs/pulls/1902"},"html":{"href":"https://github.com/rancher/docs/pull/1902"},"issue":{"href":"https://api.github.com/repos/rancher/docs/issues/1902"},"comments":{"href":"https://api.github.com/repos/rancher/docs/issues/1902/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/docs/pulls/1902/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/docs/pulls/1902/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/docs/statuses/8780b633886b01197dfa52250a1226f24f36a182"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"Oats87"}}