payload: {"action":"created","issue":{"url":"https://api.github.com/repos/johannfaouzi/pyts/issues/18","repository_url":"https://api.github.com/repos/johannfaouzi/pyts","labels_url":"https://api.github.com/repos/johannfaouzi/pyts/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/johannfaouzi/pyts/issues/18/comments","events_url":"https://api.github.com/repos/johannfaouzi/pyts/issues/18/events","html_url":"https://github.com/johannfaouzi/pyts/pull/18","id":406761393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMzg1MDEy","number":18,"title":"Allow the user to disable scaling on GASF and GADF images","user":{"login":"TobCar","id":28568438,"node_id":"MDQ6VXNlcjI4NTY4NDM4","avatar_url":"https://avatars1.githubusercontent.com/u/28568438?v=4","gravatar_id":"","url":"https://api.github.com/users/TobCar","html_url":"https://github.com/TobCar","followers_url":"https://api.github.com/users/TobCar/followers","following_url":"https://api.github.com/users/TobCar/following{/other_user}","gists_url":"https://api.github.com/users/TobCar/gists{/gist_id}","starred_url":"https://api.github.com/users/TobCar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobCar/subscriptions","organizations_url":"https://api.github.com/users/TobCar/orgs","repos_url":"https://api.github.com/users/TobCar/repos","events_url":"https://api.github.com/users/TobCar/events{/privacy}","received_events_url":"https://api.github.com/users/TobCar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-02-05T12:32:19Z","updated_at":"2019-02-09T11:24:57Z","closed_at":"2019-02-09T11:24:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/johannfaouzi/pyts/pulls/18","html_url":"https://github.com/johannfaouzi/pyts/pull/18","diff_url":"https://github.com/johannfaouzi/pyts/pull/18.diff","patch_url":"https://github.com/johannfaouzi/pyts/pull/18.patch"},"body":"The normalization step when generating the compound images is really useful. However, if the time series data being turned into a compound image is an observation of a longer series of data with a larger range of values, the normalization removes valuable information.\r\n\r\nI'm part of a research team at Queen's University and we are using your library to predict who will experience delirium in the ICU. While developing our model we realized the normalization step made it impossible for the model to learn. To give a practical example, one of the features we have is a patient's heart rate. One patient may have a peak heart rate of 200 whereas another one may have a peak heart rate of 140. The normalization treats both peak values as 1 because the smaller values belongs to a different patient and a different training case. To resolve this we, normalize the data across all the patients before creating the compound images without the normalization step. This way, the GASF and GADF have values within a limited range as required, but we keep information regarding what observations are greater than others to keep the observation in context."},"comment":{"url":"https://api.github.com/repos/johannfaouzi/pyts/issues/comments/462036199","html_url":"https://github.com/johannfaouzi/pyts/pull/18#issuecomment-462036199","issue_url":"https://api.github.com/repos/johannfaouzi/pyts/issues/18","id":462036199,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MjAzNjE5OQ==","user":{"login":"johannfaouzi","id":17053934,"node_id":"MDQ6VXNlcjE3MDUzOTM0","avatar_url":"https://avatars1.githubusercontent.com/u/17053934?v=4","gravatar_id":"","url":"https://api.github.com/users/johannfaouzi","html_url":"https://github.com/johannfaouzi","followers_url":"https://api.github.com/users/johannfaouzi/followers","following_url":"https://api.github.com/users/johannfaouzi/following{/other_user}","gists_url":"https://api.github.com/users/johannfaouzi/gists{/gist_id}","starred_url":"https://api.github.com/users/johannfaouzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannfaouzi/subscriptions","organizations_url":"https://api.github.com/users/johannfaouzi/orgs","repos_url":"https://api.github.com/users/johannfaouzi/repos","events_url":"https://api.github.com/users/johannfaouzi/events{/privacy}","received_events_url":"https://api.github.com/users/johannfaouzi/received_events","type":"User","site_admin":false},"created_at":"2019-02-09T11:24:57Z","updated_at":"2019-02-09T11:24:57Z","author_association":"OWNER","body":"Sure, I totally forgot about it. Sorry for that!"}}
other: {"actor":{"display_login":"johannfaouzi"}}