payload: {"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/311479591","pull_request_review_id":271860311,"id":311479591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTQ3OTU5MQ==","diff_hunk":"@@ -69,6 +70,28 @@ modules_python_libmod_python_la_DEPENDENCIES = $(MODULE_DEPS_LIBS)\n \n modules/python mod-python: modules/python/libmod-python.la\n \n+else\n+\n+module_LTLIBRARIES += modules/python/libmod-python2.la","path":"modules/python/Makefile.am","position":134,"original_position":14,"commit_id":"1f56fa5380e7d9ddf0bef8c55b7cdbdba2abc982","original_commit_id":"d6a4e440cb770aa6b820ea13a88e38adfbf7d592","user":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"body":"[optional]\r\nI would prefer to keep the `libmod-python.la` name, and define as `libmod-python2.la` (almost arbitrary choose)\r\nBecause some cases it is a possibility to have both `libmod-python{,2,3}.la`, where at least two of them defines the same module name as well. (optional because I only could come up the case when developers do switching between branches options)","created_at":"2019-08-07T10:26:05Z","updated_at":"2019-08-07T10:45:14Z","html_url":"https://github.com/balabit/syslog-ng/pull/2845#discussion_r311479591","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/311479591"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2845#discussion_r311479591"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845"}}},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845","id":301317102,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzE3MTAy","html_url":"https://github.com/balabit/syslog-ng/pull/2845","diff_url":"https://github.com/balabit/syslog-ng/pull/2845.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/2845.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2845","number":2845,"state":"open","locked":false,"title":"Option for building/using both Python 2 and Python 3 modules ","user":{"login":"MrAnno","id":3130044,"node_id":"MDQ6VXNlcjMxMzAwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3130044?v=4","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"body":"This PR adds a configure option `--enable-python2-and-3`, which builds syslog-ng with both Python 2 and Python 3 support enabled.\r\n\r\nsyslog-ng compiled with this option will start the Python 2 driver if `python()` or `python2()` is specified in the configuration. `python3()` is for Python 3 plugins.\r\n\r\n`python()` currently means Python 2, but it can be changed or removed in the future.\r\n\r\nIn case `--enable-python2-and-3` is _not_ used, the old behavior remains: `python()` launches the driver syslog-ng was configured with.","created_at":"2019-07-25T21:28:02Z","updated_at":"2019-08-07T10:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcd78ca627df77276ef1e169466ee5b7757fe198","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lbudai","id":5908786,"node_id":"MDQ6VXNlcjU5MDg3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5908786?v=4","gravatar_id":"","url":"https://api.github.com/users/lbudai","html_url":"https://github.com/lbudai","followers_url":"https://api.github.com/users/lbudai/followers","following_url":"https://api.github.com/users/lbudai/following{/other_user}","gists_url":"https://api.github.com/users/lbudai/gists{/gist_id}","starred_url":"https://api.github.com/users/lbudai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbudai/subscriptions","organizations_url":"https://api.github.com/users/lbudai/orgs","repos_url":"https://api.github.com/users/lbudai/repos","events_url":"https://api.github.com/users/lbudai/events{/privacy}","received_events_url":"https://api.github.com/users/lbudai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/balabit/syslog-ng/milestones/22","html_url":"https://github.com/balabit/syslog-ng/milestone/22","labels_url":"https://api.github.com/repos/balabit/syslog-ng/milestones/22/labels","id":4405131,"node_id":"MDk6TWlsZXN0b25lNDQwNTEzMQ==","number":22,"title":"syslog-ng-3.23","description":"","creator":{"login":"Kokan","id":207583,"node_id":"MDQ6VXNlcjIwNzU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/207583?v=4","gravatar_id":"","url":"https://api.github.com/users/Kokan","html_url":"https://github.com/Kokan","followers_url":"https://api.github.com/users/Kokan/followers","following_url":"https://api.github.com/users/Kokan/following{/other_user}","gists_url":"https://api.github.com/users/Kokan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kokan/subscriptions","organizations_url":"https://api.github.com/users/Kokan/orgs","repos_url":"https://api.github.com/users/Kokan/repos","events_url":"https://api.github.com/users/Kokan/events{/privacy}","received_events_url":"https://api.github.com/users/Kokan/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":9,"state":"open","created_at":"2019-06-13T09:51:20Z","updated_at":"2019-08-07T08:28:39Z","due_on":"2019-08-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2845/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/1f56fa5380e7d9ddf0bef8c55b7cdbdba2abc982","head":{"label":"MrAnno:python2-and-3","ref":"python2-and-3","sha":"1f56fa5380e7d9ddf0bef8c55b7cdbdba2abc982","user":{"login":"MrAnno","id":3130044,"node_id":"MDQ6VXNlcjMxMzAwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3130044?v=4","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"repo":{"id":48989715,"node_id":"MDEwOlJlcG9zaXRvcnk0ODk4OTcxNQ==","name":"syslog-ng","full_name":"MrAnno/syslog-ng","private":false,"owner":{"login":"MrAnno","id":3130044,"node_id":"MDQ6VXNlcjMxMzAwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3130044?v=4","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MrAnno/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/MrAnno/syslog-ng","forks_url":"https://api.github.com/repos/MrAnno/syslog-ng/forks","keys_url":"https://api.github.com/repos/MrAnno/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrAnno/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrAnno/syslog-ng/teams","hooks_url":"https://api.github.com/repos/MrAnno/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/MrAnno/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/MrAnno/syslog-ng/events","assignees_url":"https://api.github.com/repos/MrAnno/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/MrAnno/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/MrAnno/syslog-ng/tags","blobs_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrAnno/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/MrAnno/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/MrAnno/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/MrAnno/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/MrAnno/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/MrAnno/syslog-ng/subscription","commits_url":"https://api.github.com/repos/MrAnno/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrAnno/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrAnno/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrAnno/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/MrAnno/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrAnno/syslog-ng/merges","archive_url":"https://api.github.com/repos/MrAnno/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrAnno/syslog-ng/downloads","issues_url":"https://api.github.com/repos/MrAnno/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/MrAnno/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/MrAnno/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/MrAnno/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrAnno/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/MrAnno/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/MrAnno/syslog-ng/deployments","created_at":"2016-01-04T10:17:25Z","updated_at":"2019-07-28T15:11:40Z","pushed_at":"2019-08-05T11:49:57Z","git_url":"git://github.com/MrAnno/syslog-ng.git","ssh_url":"git@github.com:MrAnno/syslog-ng.git","clone_url":"https://github.com/MrAnno/syslog-ng.git","svn_url":"https://github.com/MrAnno/syslog-ng","homepage":"http://www.syslog-ng.org/","size":24490,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"3ecbc2937ce0d7c1ddff334da5ad9fe3833ffde7","user":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Njc1Nw==","name":"syslog-ng","full_name":"balabit/syslog-ng","private":false,"owner":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2019-08-06T12:59:23Z","pushed_at":"2019-08-07T08:20:33Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"https://www.syslog-ng.com","size":27419,"stargazers_count":1128,"watchers_count":1128,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":183,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":309,"open_issues":183,"watchers":1128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2845"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2845"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2845/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2845/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/1f56fa5380e7d9ddf0bef8c55b7cdbdba2abc982"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"Kokan"}}