payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/306818027","pull_request_review_id":266030777,"id":306818027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjgxODAyNw==","diff_hunk":"@@ -667,7 +686,13 @@ def fit_transform(self, X, y=None):\n             will be boolean.\n \n         \"\"\"\n-        return self.fit(X, y).transform(X)\n+        imputer_mask = self._fit(X, y)\n+\n+        if (self.features == \"missing-only\") and \\","path":"sklearn/impute/_base.py","position":53,"original_position":53,"commit_id":"ffe3a5ae7812d51c3ed93ca71791e479c0b0332f","original_commit_id":"ffe3a5ae7812d51c3ed93ca71791e479c0b0332f","user":{"login":"jnothman","id":78827,"node_id":"MDQ6VXNlcjc4ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"these parentheses are unnecessary","created_at":"2019-07-24T13:46:36Z","updated_at":"2019-07-24T13:49:33Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/14356#discussion_r306818027","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/306818027"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/14356#discussion_r306818027"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356","id":297390028,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MzkwMDI4","html_url":"https://github.com/scikit-learn/scikit-learn/pull/14356","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/14356.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/14356.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14356","number":14356,"state":"open","locked":false,"title":"Change fit_transform of MissingInformation class to prevent it from c…","user":{"login":"harsh020","id":39561084,"node_id":"MDQ6VXNlcjM5NTYxMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/39561084?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh020","html_url":"https://github.com/harsh020","followers_url":"https://api.github.com/users/harsh020/followers","following_url":"https://api.github.com/users/harsh020/following{/other_user}","gists_url":"https://api.github.com/users/harsh020/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh020/subscriptions","organizations_url":"https://api.github.com/users/harsh020/orgs","repos_url":"https://api.github.com/users/harsh020/repos","events_url":"https://api.github.com/users/harsh020/events{/privacy}","received_events_url":"https://api.github.com/users/harsh020/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\nFixes #14278\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nThe implementation fixes the function _get_missing_features_info from being called twice in fit_transform and also adds a test to check the result are correct.\r\n\r\n--Declare a private instance variable (double leading underscore variable/mangling) in fit function, to store the return values of _get_missing_features_info.\r\n-- Called fit from fit_transform.\r\n--Used the private instance variable, when implementing transform in fit_transform to retrieve data.\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->","created_at":"2019-07-14T12:04:50Z","updated_at":"2019-07-24T13:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbb83f69c268a51ebf7e18d8c65c78ded4d6537d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14356/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/ffe3a5ae7812d51c3ed93ca71791e479c0b0332f","head":{"label":"harsh020:missing_indicator","ref":"missing_indicator","sha":"ffe3a5ae7812d51c3ed93ca71791e479c0b0332f","user":{"login":"harsh020","id":39561084,"node_id":"MDQ6VXNlcjM5NTYxMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/39561084?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh020","html_url":"https://github.com/harsh020","followers_url":"https://api.github.com/users/harsh020/followers","following_url":"https://api.github.com/users/harsh020/following{/other_user}","gists_url":"https://api.github.com/users/harsh020/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh020/subscriptions","organizations_url":"https://api.github.com/users/harsh020/orgs","repos_url":"https://api.github.com/users/harsh020/repos","events_url":"https://api.github.com/users/harsh020/events{/privacy}","received_events_url":"https://api.github.com/users/harsh020/received_events","type":"User","site_admin":false},"repo":{"id":196708453,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY3MDg0NTM=","name":"scikit-learn","full_name":"harsh020/scikit-learn","private":false,"owner":{"login":"harsh020","id":39561084,"node_id":"MDQ6VXNlcjM5NTYxMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/39561084?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh020","html_url":"https://github.com/harsh020","followers_url":"https://api.github.com/users/harsh020/followers","following_url":"https://api.github.com/users/harsh020/following{/other_user}","gists_url":"https://api.github.com/users/harsh020/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh020/subscriptions","organizations_url":"https://api.github.com/users/harsh020/orgs","repos_url":"https://api.github.com/users/harsh020/repos","events_url":"https://api.github.com/users/harsh020/events{/privacy}","received_events_url":"https://api.github.com/users/harsh020/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harsh020/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/harsh020/scikit-learn","forks_url":"https://api.github.com/repos/harsh020/scikit-learn/forks","keys_url":"https://api.github.com/repos/harsh020/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harsh020/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harsh020/scikit-learn/teams","hooks_url":"https://api.github.com/repos/harsh020/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/harsh020/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/harsh020/scikit-learn/events","assignees_url":"https://api.github.com/repos/harsh020/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/harsh020/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/harsh020/scikit-learn/tags","blobs_url":"https://api.github.com/repos/harsh020/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harsh020/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harsh020/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/harsh020/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harsh020/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/harsh020/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/harsh020/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/harsh020/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/harsh020/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/harsh020/scikit-learn/subscription","commits_url":"https://api.github.com/repos/harsh020/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/harsh020/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/harsh020/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/harsh020/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/harsh020/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/harsh020/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harsh020/scikit-learn/merges","archive_url":"https://api.github.com/repos/harsh020/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harsh020/scikit-learn/downloads","issues_url":"https://api.github.com/repos/harsh020/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/harsh020/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/harsh020/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/harsh020/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harsh020/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/harsh020/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/harsh020/scikit-learn/deployments","created_at":"2019-07-13T10:22:13Z","updated_at":"2019-07-13T10:22:19Z","pushed_at":"2019-07-24T05:56:14Z","git_url":"git://github.com/harsh020/scikit-learn.git","ssh_url":"git@github.com:harsh020/scikit-learn.git","clone_url":"https://github.com/harsh020/scikit-learn.git","svn_url":"https://github.com/harsh020/scikit-learn","homepage":"https://scikit-learn.org","size":104988,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"98e0866318e4c6792096c2b354484b5db8d67fca","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2019-07-24T13:25:23Z","pushed_at":"2019-07-24T11:33:30Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"https://scikit-learn.org","size":105969,"stargazers_count":36256,"watchers_count":36256,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17774,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1957,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17774,"open_issues":1957,"watchers":36256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/14356"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14356"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14356/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14356/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/ffe3a5ae7812d51c3ed93ca71791e479c0b0332f"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"jnothman"}}