payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments/334536182","pull_request_review_id":301377529,"id":334536182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDUzNjE4Mg==","diff_hunk":"@@ -503,6 +503,10 @@ function find_callback_time(integrator,callback::VectorContinuousCallback,counte\n               iter == 12 && error(\"Double callback crossing floating pointer reducer errored. Report this issue.\")\n             end\n             Θ = prevfloat(find_zero(zero_func, (bottom_θ,top_Θ), Roots.AlefeldPotraShi(), atol = callback.abstol/100))\n+            sign_bottom_θ = sign(zero_func(bottom_θ))\n+            while sign(zero_func(Θ)) != sign_bottom_θ","path":"src/callbacks.jl","position":5,"original_position":5,"commit_id":"605dac4094651e5f560dd6621113560a906db70e","original_commit_id":"605dac4094651e5f560dd6621113560a906db70e","user":{"login":"kanav99","id":33966400,"node_id":"MDQ6VXNlcjMzOTY2NDAw","avatar_url":"https://avatars1.githubusercontent.com/u/33966400?v=4","gravatar_id":"","url":"https://api.github.com/users/kanav99","html_url":"https://github.com/kanav99","followers_url":"https://api.github.com/users/kanav99/followers","following_url":"https://api.github.com/users/kanav99/following{/other_user}","gists_url":"https://api.github.com/users/kanav99/gists{/gist_id}","starred_url":"https://api.github.com/users/kanav99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanav99/subscriptions","organizations_url":"https://api.github.com/users/kanav99/orgs","repos_url":"https://api.github.com/users/kanav99/repos","events_url":"https://api.github.com/users/kanav99/events{/privacy}","received_events_url":"https://api.github.com/users/kanav99/received_events","type":"User","site_admin":false},"body":"What do you mean by tolerance? Just discard all the callback tolerances and put `atol = 0` in `find_zero` call?\r\n","created_at":"2019-10-14T15:22:37Z","updated_at":"2019-10-14T15:22:37Z","html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/350#discussion_r334536182","pull_request_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments/334536182"},"html":{"href":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/350#discussion_r334536182"},"pull_request":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350"}},"in_reply_to_id":334312726},"pull_request":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350","id":327586421,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3NTg2NDIx","html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/350","diff_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/350.diff","patch_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/350.patch","issue_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/350","number":350,"state":"open","locked":false,"title":"Fix Rootfinding in Callbacks","user":{"login":"kanav99","id":33966400,"node_id":"MDQ6VXNlcjMzOTY2NDAw","avatar_url":"https://avatars1.githubusercontent.com/u/33966400?v=4","gravatar_id":"","url":"https://api.github.com/users/kanav99","html_url":"https://github.com/kanav99","followers_url":"https://api.github.com/users/kanav99/followers","following_url":"https://api.github.com/users/kanav99/following{/other_user}","gists_url":"https://api.github.com/users/kanav99/gists{/gist_id}","starred_url":"https://api.github.com/users/kanav99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanav99/subscriptions","organizations_url":"https://api.github.com/users/kanav99/orgs","repos_url":"https://api.github.com/users/kanav99/repos","events_url":"https://api.github.com/users/kanav99/events{/privacy}","received_events_url":"https://api.github.com/users/kanav99/received_events","type":"User","site_admin":false},"body":"Ref: https://github.com/JuliaDiffEq/DifferentialEquations.jl/issues/516#issuecomment-541450416","created_at":"2019-10-13T19:43:10Z","updated_at":"2019-10-14T15:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"761bb4cc045237fd7acdd80b74cf5f271b52a2c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350/commits","review_comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350/comments","review_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/350/comments","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/605dac4094651e5f560dd6621113560a906db70e","head":{"label":"JuliaDiffEq:kg/cbfix","ref":"kg/cbfix","sha":"605dac4094651e5f560dd6621113560a906db70e","user":{"login":"JuliaDiffEq","id":21238080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjM4MDgw","avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":71509444,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUwOTQ0NA==","name":"DiffEqBase.jl","full_name":"JuliaDiffEq/DiffEqBase.jl","private":false,"owner":{"login":"JuliaDiffEq","id":21238080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjM4MDgw","avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","description":"The lightweight Base library for shared types and functionality.","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/deployments","created_at":"2016-10-20T22:28:36Z","updated_at":"2019-10-11T04:39:15Z","pushed_at":"2019-10-14T07:11:24Z","git_url":"git://github.com/JuliaDiffEq/DiffEqBase.jl.git","ssh_url":"git@github.com:JuliaDiffEq/DiffEqBase.jl.git","clone_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl.git","svn_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","homepage":null,"size":1223,"stargazers_count":39,"watchers_count":39,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":25,"watchers":39,"default_branch":"master"}},"base":{"label":"JuliaDiffEq:master","ref":"master","sha":"63ccae178058d6102a2e5bfdceeeb6490242b918","user":{"login":"JuliaDiffEq","id":21238080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjM4MDgw","avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":71509444,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUwOTQ0NA==","name":"DiffEqBase.jl","full_name":"JuliaDiffEq/DiffEqBase.jl","private":false,"owner":{"login":"JuliaDiffEq","id":21238080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjM4MDgw","avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","description":"The lightweight Base library for shared types and functionality.","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/deployments","created_at":"2016-10-20T22:28:36Z","updated_at":"2019-10-11T04:39:15Z","pushed_at":"2019-10-14T07:11:24Z","git_url":"git://github.com/JuliaDiffEq/DiffEqBase.jl.git","ssh_url":"git@github.com:JuliaDiffEq/DiffEqBase.jl.git","clone_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl.git","svn_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","homepage":null,"size":1223,"stargazers_count":39,"watchers_count":39,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":25,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350"},"html":{"href":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/350"},"issue":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/350"},"comments":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/605dac4094651e5f560dd6621113560a906db70e"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"kanav99"}}