payload: {"push_id":4033624857,"size":7,"distinct_size":1,"ref":"refs/heads/getOperatorList-cancel","head":"281ed33e4313dd767c4928a95c39feb601f15b47","before":"389a57accc62443be6009c66ce7c557f0aac8d3a","commits":[{"sha":"00efff532cf4754d0335560a5f1afc894ec03417","author":{"name":"Jonas Jenwald","email":"948da68dabc99974f43ccafff8947d7478f569d4@gmail.com"},"message":"Ensure that `addLinkAttributes` is always called with a valid `url` parameter\n\nThere's no good reason for calling this helper function without a `url` parameter, and this way we can prevent that from happening.\nNote how the `PDFOutlineViewer` call-site was already doing the right thing here, and only the `LinkAnnotationElement` call-site needed a small adjustment to make it work.","distinct":false,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/00efff532cf4754d0335560a5f1afc894ec03417"},{"sha":"501e0b3db7e0a885e3b6bd164dae423d584e4bff","author":{"name":"Rob Wu","email":"7e09c9d3e96378bf549fc283fd6e1e5b7014cc33@robwu.nl"},"message":"[CRX] Ignore auto-generated <embed> from Chrome\n\nFixes #11137","distinct":false,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/501e0b3db7e0a885e3b6bd164dae423d584e4bff"},{"sha":"2d2ec11c551807f27357b3f3e7ed4f8d04af6d0a","author":{"name":"Tim van der Meij","email":"4ec1e66dc4bbb8196a5402fa4f873c344f88f2db@gmail.com"},"message":"Merge pull request #11138 from Rob--W/issue11137-ignore-non-loadable-embeds\n\n[CRX] Ignore auto-generated <embed> from Chrome","distinct":false,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/2d2ec11c551807f27357b3f3e7ed4f8d04af6d0a"},{"sha":"12ff252751870bea861944f369a9ecf462c641d3","author":{"name":"Tim van der Meij","email":"4ec1e66dc4bbb8196a5402fa4f873c344f88f2db@gmail.com"},"message":"Merge pull request #11134 from Snuffleupagus/addLinkAttributes-assert-url\n\nEnsure that `addLinkAttributes` is always called with a valid `url` parameter","distinct":false,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/12ff252751870bea861944f369a9ecf462c641d3"},{"sha":"6d1595b6692e1e1456bc81fcc0ce2b4f8a915342","author":{"name":"Jonas Jenwald","email":"948da68dabc99974f43ccafff8947d7478f569d4@gmail.com"},"message":"Stop dispatching a \"localized\" event from the webL10n library, since it's unused and may clash with the default viewer\n\nCurrently this leads to confusing behaviour with `eventBusDispatchToDOM = true` set, since then there's *two* different \"localized\" events being fired.","distinct":false,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/6d1595b6692e1e1456bc81fcc0ce2b4f8a915342"},{"sha":"b86bdefcd91f1fb5026a8429e75a512f8d499209","author":{"name":"Tim van der Meij","email":"4ec1e66dc4bbb8196a5402fa4f873c344f88f2db@gmail.com"},"message":"Merge pull request #11142 from Snuffleupagus/webL10n-rm-fireL10nReadyEvent\n\nStop dispatching a \"localized\" event from the webL10n library, since it's unused and may clash with the default viewer","distinct":false,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/b86bdefcd91f1fb5026a8429e75a512f8d499209"},{"sha":"281ed33e4313dd767c4928a95c39feb601f15b47","author":{"name":"Jonas Jenwald","email":"948da68dabc99974f43ccafff8947d7478f569d4@gmail.com"},"message":"Abort, with a small delay, `getOperatorList` on the worker-thread when rendering is cancelled (PR 11069 follow-up)\n\nWith this patch we're finally able to abort worker-thread parsing of the `OperatorList`, rather than *only* aborting the main-thread rendering itself, when the `RenderTask.cancel` method is being called.\nThis will help improve perceived performance in the default viewer, especially when reading longer and more complex documents, since pages that've been scrolled out-of-view (and thus evicted from the cache) will no longer compete for parsing resources on the worker-thread.\n\n*Please note:* With the implementation in this patch we're *not* aborting worker-thread parsing immediately on `RenderTask.cancel`, since that would lead to *worse* performance in many cases. For example: When zoom/rotation occurs in the viewer, while parsing/rendering is still ongoing, a `cancel` call will usually be (almost) immediately folled by a new `PDFPageProxy.render` call. In that case you obviously don't want to abort parsing on the worker-thread, since that would risk throwing away a partially parsed `OperatorList` and thus force unnecessary re-parsing which will regress perceived performance (especially for more complex documents).\n\nWhen choosing a reasonable delay, before cancelling `getOperatorList` on the worker-thread when `RenderTask.cancel` is called, two different positions need to be considered:\n 1. The delay needs to be short enough, since a timeout in the multiple seconds range would essentially make this entire functionality meaningless (by always allowing most/all pages enough time to finish parsing).\n\n 2. The delay cannot be *too* short, since that would actually *reduce* performance in the zoom/rotation case outlined above. Furthermore, the time between `RenderTask.cancel` and `PDFPageProxy.render` calls will obviously be affected by both general computer performance and current CPU load.\n\nIt's certainly possible that the timeout may require some further tweaks, however the value settled on in this patch was easily *one order* of magnitude larger than the delta between cancel/render in my tests.","distinct":true,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits/281ed33e4313dd767c4928a95c39feb601f15b47"}]}
other: {"actor":{"display_login":"Snuffleupagus"}}