payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pinot/pulls/comments/338210361","pull_request_review_id":306101515,"id":338210361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODIxMDM2MQ==","diff_hunk":"@@ -45,4 +46,7 @@\n    * Returns the bloom filter for the data source if exists, or {@code null} if not.\n    */\n   public abstract BloomFilterReader getBloomFilter();\n+\n+  public abstract PresenceVectorReader getPresenceVector();","path":"pinot-core/src/main/java/org/apache/pinot/core/common/DataSource.java","position":13,"original_position":13,"commit_id":"52c82479ee013e2c38440da7bf8a02ccaed4618f","original_commit_id":"52c82479ee013e2c38440da7bf8a02ccaed4618f","user":{"login":"icefury71","id":728023,"node_id":"MDQ6VXNlcjcyODAyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/728023?v=4","gravatar_id":"","url":"https://api.github.com/users/icefury71","html_url":"https://github.com/icefury71","followers_url":"https://api.github.com/users/icefury71/followers","following_url":"https://api.github.com/users/icefury71/following{/other_user}","gists_url":"https://api.github.com/users/icefury71/gists{/gist_id}","starred_url":"https://api.github.com/users/icefury71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icefury71/subscriptions","organizations_url":"https://api.github.com/users/icefury71/orgs","repos_url":"https://api.github.com/users/icefury71/repos","events_url":"https://api.github.com/users/icefury71/events{/privacy}","received_events_url":"https://api.github.com/users/icefury71/received_events","type":"User","site_admin":false},"body":"PresenceVectorReader has a method called \"isPresent(docId)\" . So it is in fact a presence value vector (although internally it uses a null vector). ","created_at":"2019-10-23T18:29:51Z","updated_at":"2019-10-23T18:29:51Z","html_url":"https://github.com/apache/incubator-pinot/pull/4585#discussion_r338210361","pull_request_url":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pinot/pulls/comments/338210361"},"html":{"href":"https://github.com/apache/incubator-pinot/pull/4585#discussion_r338210361"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585"}},"in_reply_to_id":337634848},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585","id":314245189,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE0MjQ1MTg5","html_url":"https://github.com/apache/incubator-pinot/pull/4585","diff_url":"https://github.com/apache/incubator-pinot/pull/4585.diff","patch_url":"https://github.com/apache/incubator-pinot/pull/4585.patch","issue_url":"https://api.github.com/repos/apache/incubator-pinot/issues/4585","number":4585,"state":"open","locked":false,"title":"Presence vector","user":{"login":"icefury71","id":728023,"node_id":"MDQ6VXNlcjcyODAyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/728023?v=4","gravatar_id":"","url":"https://api.github.com/users/icefury71","html_url":"https://github.com/icefury71","followers_url":"https://api.github.com/users/icefury71/followers","following_url":"https://api.github.com/users/icefury71/following{/other_user}","gists_url":"https://api.github.com/users/icefury71/gists{/gist_id}","starred_url":"https://api.github.com/users/icefury71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icefury71/subscriptions","organizations_url":"https://api.github.com/users/icefury71/orgs","repos_url":"https://api.github.com/users/icefury71/repos","events_url":"https://api.github.com/users/icefury71/events{/privacy}","received_events_url":"https://api.github.com/users/icefury71/received_events","type":"User","site_admin":false},"body":"This PR adds support for a presence vector inside a mutable and immutable segment. This will enable the query layer to ignore null values in the corresponding columns. Please see this issue for more details: https://github.com/apache/incubator-pinot/issues/4230\r\n\r\nHigh level gist is as follows:\r\n* Create a presence vector per column per segment by default. This presence vector keeps track of which document ID has a null value in the corresponding column.\r\n* Expose this through the DataSource interface to enable the caller to ignore such document IDs.\r\n\r\nPresence vector is not really used anywhere as part of this PR. Subsequent PRs will use them to enable filtering out columns in predicates (eg: select ... from table where column_name != null)","created_at":"2019-09-04T21:59:40Z","updated_at":"2019-10-23T18:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6636a8231a394f63a05823748fb5d38d3827548e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pinot/issues/4585/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pinot/statuses/52c82479ee013e2c38440da7bf8a02ccaed4618f","head":{"label":"winedepot:presence_vector","ref":"presence_vector","sha":"52c82479ee013e2c38440da7bf8a02ccaed4618f","user":{"login":"winedepot","id":48841826,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4ODQxODI2","avatar_url":"https://avatars0.githubusercontent.com/u/48841826?v=4","gravatar_id":"","url":"https://api.github.com/users/winedepot","html_url":"https://github.com/winedepot","followers_url":"https://api.github.com/users/winedepot/followers","following_url":"https://api.github.com/users/winedepot/following{/other_user}","gists_url":"https://api.github.com/users/winedepot/gists{/gist_id}","starred_url":"https://api.github.com/users/winedepot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winedepot/subscriptions","organizations_url":"https://api.github.com/users/winedepot/orgs","repos_url":"https://api.github.com/users/winedepot/repos","events_url":"https://api.github.com/users/winedepot/events{/privacy}","received_events_url":"https://api.github.com/users/winedepot/received_events","type":"Organization","site_admin":false},"repo":{"id":177204268,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcyMDQyNjg=","name":"pinot","full_name":"winedepot/pinot","private":false,"owner":{"login":"winedepot","id":48841826,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4ODQxODI2","avatar_url":"https://avatars0.githubusercontent.com/u/48841826?v=4","gravatar_id":"","url":"https://api.github.com/users/winedepot","html_url":"https://github.com/winedepot","followers_url":"https://api.github.com/users/winedepot/followers","following_url":"https://api.github.com/users/winedepot/following{/other_user}","gists_url":"https://api.github.com/users/winedepot/gists{/gist_id}","starred_url":"https://api.github.com/users/winedepot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winedepot/subscriptions","organizations_url":"https://api.github.com/users/winedepot/orgs","repos_url":"https://api.github.com/users/winedepot/repos","events_url":"https://api.github.com/users/winedepot/events{/privacy}","received_events_url":"https://api.github.com/users/winedepot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/winedepot/pinot","description":"Apache Pinot (Incubating) - A realtime distributed OLAP datastore","fork":true,"url":"https://api.github.com/repos/winedepot/pinot","forks_url":"https://api.github.com/repos/winedepot/pinot/forks","keys_url":"https://api.github.com/repos/winedepot/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winedepot/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winedepot/pinot/teams","hooks_url":"https://api.github.com/repos/winedepot/pinot/hooks","issue_events_url":"https://api.github.com/repos/winedepot/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/winedepot/pinot/events","assignees_url":"https://api.github.com/repos/winedepot/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/winedepot/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/winedepot/pinot/tags","blobs_url":"https://api.github.com/repos/winedepot/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winedepot/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winedepot/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/winedepot/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winedepot/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/winedepot/pinot/languages","stargazers_url":"https://api.github.com/repos/winedepot/pinot/stargazers","contributors_url":"https://api.github.com/repos/winedepot/pinot/contributors","subscribers_url":"https://api.github.com/repos/winedepot/pinot/subscribers","subscription_url":"https://api.github.com/repos/winedepot/pinot/subscription","commits_url":"https://api.github.com/repos/winedepot/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/winedepot/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/winedepot/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/winedepot/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/winedepot/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/winedepot/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winedepot/pinot/merges","archive_url":"https://api.github.com/repos/winedepot/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winedepot/pinot/downloads","issues_url":"https://api.github.com/repos/winedepot/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/winedepot/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/winedepot/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/winedepot/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winedepot/pinot/labels{/name}","releases_url":"https://api.github.com/repos/winedepot/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/winedepot/pinot/deployments","created_at":"2019-03-22T20:20:47Z","updated_at":"2019-07-01T23:20:56Z","pushed_at":"2019-10-22T02:54:51Z","git_url":"git://github.com/winedepot/pinot.git","ssh_url":"git@github.com:winedepot/pinot.git","clone_url":"https://github.com/winedepot/pinot.git","svn_url":"https://github.com/winedepot/pinot","homepage":"https://pinot.apache.org","size":178432,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"apache:master","ref":"master","sha":"3579aae5a2cfb6086009cdc3c1b7372351ab8fe3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk2MTA4NQ==","name":"incubator-pinot","full_name":"apache/incubator-pinot","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-pinot","description":"Apache Pinot (Incubating) - A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/apache/incubator-pinot","forks_url":"https://api.github.com/repos/apache/incubator-pinot/forks","keys_url":"https://api.github.com/repos/apache/incubator-pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pinot/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pinot/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pinot/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pinot/events","assignees_url":"https://api.github.com/repos/apache/incubator-pinot/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pinot/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pinot/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pinot/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pinot/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pinot/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pinot/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pinot/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pinot/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pinot/merges","archive_url":"https://api.github.com/repos/apache/incubator-pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pinot/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pinot/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pinot/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pinot/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2019-10-23T17:50:02Z","pushed_at":"2019-10-23T18:23:45Z","git_url":"git://github.com/apache/incubator-pinot.git","ssh_url":"git@github.com:apache/incubator-pinot.git","clone_url":"https://github.com/apache/incubator-pinot.git","svn_url":"https://github.com/apache/incubator-pinot","homepage":"https://pinot.apache.org","size":178308,"stargazers_count":2375,"watchers_count":2375,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":456,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":313,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":456,"open_issues":313,"watchers":2375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585"},"html":{"href":"https://github.com/apache/incubator-pinot/pull/4585"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pinot/issues/4585"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pinot/issues/4585/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pinot/pulls/4585/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pinot/statuses/52c82479ee013e2c38440da7bf8a02ccaed4618f"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"icefury71"}}