payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/comments/336179655","pull_request_review_id":303483823,"id":336179655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjE3OTY1NQ==","diff_hunk":"@@ -134,7 +134,7 @@ func (jcc *JWTCredClaims) refineCredFromJWTClaims() {\n \t}\n \n \tif jti := jcc.ID; jti != \"\" {","path":"pkg/doc/verifiable/credential_jwt.go","position":21,"original_position":21,"commit_id":"397aafdb5428c5bec8f389ada32ba9eecea16b36","original_commit_id":"397aafdb5428c5bec8f389ada32ba9eecea16b36","user":{"login":"troyronda","id":1906596,"node_id":"MDQ6VXNlcjE5MDY1OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1906596?v=4","gravatar_id":"","url":"https://api.github.com/users/troyronda","html_url":"https://github.com/troyronda","followers_url":"https://api.github.com/users/troyronda/followers","following_url":"https://api.github.com/users/troyronda/following{/other_user}","gists_url":"https://api.github.com/users/troyronda/gists{/gist_id}","starred_url":"https://api.github.com/users/troyronda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troyronda/subscriptions","organizations_url":"https://api.github.com/users/troyronda/orgs","repos_url":"https://api.github.com/users/troyronda/repos","events_url":"https://api.github.com/users/troyronda/events{/privacy}","received_events_url":"https://api.github.com/users/troyronda/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand the purpose of these assignments? e.g., `jti := jcc.ID`","created_at":"2019-10-17T19:11:44Z","updated_at":"2019-10-17T19:11:44Z","html_url":"https://github.com/hyperledger/aries-framework-go/pull/508#discussion_r336179655","pull_request_url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/comments/336179655"},"html":{"href":"https://github.com/hyperledger/aries-framework-go/pull/508#discussion_r336179655"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508","id":329115893,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MTE1ODkz","html_url":"https://github.com/hyperledger/aries-framework-go/pull/508","diff_url":"https://github.com/hyperledger/aries-framework-go/pull/508.diff","patch_url":"https://github.com/hyperledger/aries-framework-go/pull/508.patch","issue_url":"https://api.github.com/repos/hyperledger/aries-framework-go/issues/508","number":508,"state":"open","locked":false,"title":"feat: JWT proof of Verifiable Presentation","user":{"login":"kdimak","id":20474355,"node_id":"MDQ6VXNlcjIwNDc0MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/20474355?v=4","gravatar_id":"","url":"https://api.github.com/users/kdimak","html_url":"https://github.com/kdimak","followers_url":"https://api.github.com/users/kdimak/followers","following_url":"https://api.github.com/users/kdimak/following{/other_user}","gists_url":"https://api.github.com/users/kdimak/gists{/gist_id}","starred_url":"https://api.github.com/users/kdimak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdimak/subscriptions","organizations_url":"https://api.github.com/users/kdimak/orgs","repos_url":"https://api.github.com/users/kdimak/repos","events_url":"https://api.github.com/users/kdimak/events{/privacy}","received_events_url":"https://api.github.com/users/kdimak/received_events","type":"User","site_admin":false},"body":"JWS and unsecured JWT external proofs of Verifiable Presentation.\r\n\r\ntest suite stats:\r\n- passes : 67\r\n- failures: 8\r\n\r\nprior to this PR:\r\n- passes : 61\r\n- failures: 14\r\n\r\ncloses #483\r\n\r\nSigned-off-by: Dima <dkinoshenko@gmail.com>\r\n\r\n","created_at":"2019-10-17T07:47:00Z","updated_at":"2019-10-17T19:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1352000113c35f224c9ebeafd84b3fa1343ad69","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Moopli","id":2407581,"node_id":"MDQ6VXNlcjI0MDc1ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2407581?v=4","gravatar_id":"","url":"https://api.github.com/users/Moopli","html_url":"https://github.com/Moopli","followers_url":"https://api.github.com/users/Moopli/followers","following_url":"https://api.github.com/users/Moopli/following{/other_user}","gists_url":"https://api.github.com/users/Moopli/gists{/gist_id}","starred_url":"https://api.github.com/users/Moopli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moopli/subscriptions","organizations_url":"https://api.github.com/users/Moopli/orgs","repos_url":"https://api.github.com/users/Moopli/repos","events_url":"https://api.github.com/users/Moopli/events{/privacy}","received_events_url":"https://api.github.com/users/Moopli/received_events","type":"User","site_admin":false},{"login":"fqutishat","id":19859799,"node_id":"MDQ6VXNlcjE5ODU5Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/19859799?v=4","gravatar_id":"","url":"https://api.github.com/users/fqutishat","html_url":"https://github.com/fqutishat","followers_url":"https://api.github.com/users/fqutishat/followers","following_url":"https://api.github.com/users/fqutishat/following{/other_user}","gists_url":"https://api.github.com/users/fqutishat/gists{/gist_id}","starred_url":"https://api.github.com/users/fqutishat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fqutishat/subscriptions","organizations_url":"https://api.github.com/users/fqutishat/orgs","repos_url":"https://api.github.com/users/fqutishat/repos","events_url":"https://api.github.com/users/fqutishat/events{/privacy}","received_events_url":"https://api.github.com/users/fqutishat/received_events","type":"User","site_admin":false},{"login":"sandrask","id":26148561,"node_id":"MDQ6VXNlcjI2MTQ4NTYx","avatar_url":"https://avatars1.githubusercontent.com/u/26148561?v=4","gravatar_id":"","url":"https://api.github.com/users/sandrask","html_url":"https://github.com/sandrask","followers_url":"https://api.github.com/users/sandrask/followers","following_url":"https://api.github.com/users/sandrask/following{/other_user}","gists_url":"https://api.github.com/users/sandrask/gists{/gist_id}","starred_url":"https://api.github.com/users/sandrask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandrask/subscriptions","organizations_url":"https://api.github.com/users/sandrask/orgs","repos_url":"https://api.github.com/users/sandrask/repos","events_url":"https://api.github.com/users/sandrask/events{/privacy}","received_events_url":"https://api.github.com/users/sandrask/received_events","type":"User","site_admin":false},{"login":"Baha-sk","id":29608896,"node_id":"MDQ6VXNlcjI5NjA4ODk2","avatar_url":"https://avatars3.githubusercontent.com/u/29608896?v=4","gravatar_id":"","url":"https://api.github.com/users/Baha-sk","html_url":"https://github.com/Baha-sk","followers_url":"https://api.github.com/users/Baha-sk/followers","following_url":"https://api.github.com/users/Baha-sk/following{/other_user}","gists_url":"https://api.github.com/users/Baha-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/Baha-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baha-sk/subscriptions","organizations_url":"https://api.github.com/users/Baha-sk/orgs","repos_url":"https://api.github.com/users/Baha-sk/repos","events_url":"https://api.github.com/users/Baha-sk/events{/privacy}","received_events_url":"https://api.github.com/users/Baha-sk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508/commits","review_comments_url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508/comments","review_comment_url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/aries-framework-go/issues/508/comments","statuses_url":"https://api.github.com/repos/hyperledger/aries-framework-go/statuses/397aafdb5428c5bec8f389ada32ba9eecea16b36","head":{"label":"kdimak:issue-483","ref":"issue-483","sha":"397aafdb5428c5bec8f389ada32ba9eecea16b36","user":{"login":"kdimak","id":20474355,"node_id":"MDQ6VXNlcjIwNDc0MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/20474355?v=4","gravatar_id":"","url":"https://api.github.com/users/kdimak","html_url":"https://github.com/kdimak","followers_url":"https://api.github.com/users/kdimak/followers","following_url":"https://api.github.com/users/kdimak/following{/other_user}","gists_url":"https://api.github.com/users/kdimak/gists{/gist_id}","starred_url":"https://api.github.com/users/kdimak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdimak/subscriptions","organizations_url":"https://api.github.com/users/kdimak/orgs","repos_url":"https://api.github.com/users/kdimak/repos","events_url":"https://api.github.com/users/kdimak/events{/privacy}","received_events_url":"https://api.github.com/users/kdimak/received_events","type":"User","site_admin":false},"repo":{"id":202558535,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI1NTg1MzU=","name":"aries-framework-go","full_name":"kdimak/aries-framework-go","private":false,"owner":{"login":"kdimak","id":20474355,"node_id":"MDQ6VXNlcjIwNDc0MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/20474355?v=4","gravatar_id":"","url":"https://api.github.com/users/kdimak","html_url":"https://github.com/kdimak","followers_url":"https://api.github.com/users/kdimak/followers","following_url":"https://api.github.com/users/kdimak/following{/other_user}","gists_url":"https://api.github.com/users/kdimak/gists{/gist_id}","starred_url":"https://api.github.com/users/kdimak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdimak/subscriptions","organizations_url":"https://api.github.com/users/kdimak/orgs","repos_url":"https://api.github.com/users/kdimak/repos","events_url":"https://api.github.com/users/kdimak/events{/privacy}","received_events_url":"https://api.github.com/users/kdimak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kdimak/aries-framework-go","description":"Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services","fork":true,"url":"https://api.github.com/repos/kdimak/aries-framework-go","forks_url":"https://api.github.com/repos/kdimak/aries-framework-go/forks","keys_url":"https://api.github.com/repos/kdimak/aries-framework-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kdimak/aries-framework-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kdimak/aries-framework-go/teams","hooks_url":"https://api.github.com/repos/kdimak/aries-framework-go/hooks","issue_events_url":"https://api.github.com/repos/kdimak/aries-framework-go/issues/events{/number}","events_url":"https://api.github.com/repos/kdimak/aries-framework-go/events","assignees_url":"https://api.github.com/repos/kdimak/aries-framework-go/assignees{/user}","branches_url":"https://api.github.com/repos/kdimak/aries-framework-go/branches{/branch}","tags_url":"https://api.github.com/repos/kdimak/aries-framework-go/tags","blobs_url":"https://api.github.com/repos/kdimak/aries-framework-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kdimak/aries-framework-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kdimak/aries-framework-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/kdimak/aries-framework-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kdimak/aries-framework-go/statuses/{sha}","languages_url":"https://api.github.com/repos/kdimak/aries-framework-go/languages","stargazers_url":"https://api.github.com/repos/kdimak/aries-framework-go/stargazers","contributors_url":"https://api.github.com/repos/kdimak/aries-framework-go/contributors","subscribers_url":"https://api.github.com/repos/kdimak/aries-framework-go/subscribers","subscription_url":"https://api.github.com/repos/kdimak/aries-framework-go/subscription","commits_url":"https://api.github.com/repos/kdimak/aries-framework-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/kdimak/aries-framework-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/kdimak/aries-framework-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/kdimak/aries-framework-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/kdimak/aries-framework-go/contents/{+path}","compare_url":"https://api.github.com/repos/kdimak/aries-framework-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kdimak/aries-framework-go/merges","archive_url":"https://api.github.com/repos/kdimak/aries-framework-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kdimak/aries-framework-go/downloads","issues_url":"https://api.github.com/repos/kdimak/aries-framework-go/issues{/number}","pulls_url":"https://api.github.com/repos/kdimak/aries-framework-go/pulls{/number}","milestones_url":"https://api.github.com/repos/kdimak/aries-framework-go/milestones{/number}","notifications_url":"https://api.github.com/repos/kdimak/aries-framework-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kdimak/aries-framework-go/labels{/name}","releases_url":"https://api.github.com/repos/kdimak/aries-framework-go/releases{/id}","deployments_url":"https://api.github.com/repos/kdimak/aries-framework-go/deployments","created_at":"2019-08-15T14:43:21Z","updated_at":"2019-10-16T05:49:52Z","pushed_at":"2019-10-17T15:50:28Z","git_url":"git://github.com/kdimak/aries-framework-go.git","ssh_url":"git@github.com:kdimak/aries-framework-go.git","clone_url":"https://github.com/kdimak/aries-framework-go.git","svn_url":"https://github.com/kdimak/aries-framework-go","homepage":"https://wiki.hyperledger.org/display/ARIES/aries-framework-go","size":908,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"a792675a08c4ecc3e21c8823df97eaadc254cc93","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":196081240,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYwODEyNDA=","name":"aries-framework-go","full_name":"hyperledger/aries-framework-go","private":false,"owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperledger/aries-framework-go","description":"Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services","fork":false,"url":"https://api.github.com/repos/hyperledger/aries-framework-go","forks_url":"https://api.github.com/repos/hyperledger/aries-framework-go/forks","keys_url":"https://api.github.com/repos/hyperledger/aries-framework-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/aries-framework-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/aries-framework-go/teams","hooks_url":"https://api.github.com/repos/hyperledger/aries-framework-go/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/aries-framework-go/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/aries-framework-go/events","assignees_url":"https://api.github.com/repos/hyperledger/aries-framework-go/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/aries-framework-go/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/aries-framework-go/tags","blobs_url":"https://api.github.com/repos/hyperledger/aries-framework-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/aries-framework-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/aries-framework-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/aries-framework-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/aries-framework-go/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/aries-framework-go/languages","stargazers_url":"https://api.github.com/repos/hyperledger/aries-framework-go/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/aries-framework-go/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/aries-framework-go/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/aries-framework-go/subscription","commits_url":"https://api.github.com/repos/hyperledger/aries-framework-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/aries-framework-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/aries-framework-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/aries-framework-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/aries-framework-go/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/aries-framework-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/aries-framework-go/merges","archive_url":"https://api.github.com/repos/hyperledger/aries-framework-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/aries-framework-go/downloads","issues_url":"https://api.github.com/repos/hyperledger/aries-framework-go/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/aries-framework-go/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/aries-framework-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/aries-framework-go/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/aries-framework-go/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/aries-framework-go/deployments","created_at":"2019-07-09T20:45:08Z","updated_at":"2019-10-17T18:07:50Z","pushed_at":"2019-10-17T18:13:26Z","git_url":"git://github.com/hyperledger/aries-framework-go.git","ssh_url":"git@github.com:hyperledger/aries-framework-go.git","clone_url":"https://github.com/hyperledger/aries-framework-go.git","svn_url":"https://github.com/hyperledger/aries-framework-go","homepage":"https://wiki.hyperledger.org/display/ARIES/aries-framework-go","size":970,"stargazers_count":26,"watchers_count":26,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":116,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":116,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508"},"html":{"href":"https://github.com/hyperledger/aries-framework-go/pull/508"},"issue":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/issues/508"},"comments":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/issues/508/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/pulls/508/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/aries-framework-go/statuses/397aafdb5428c5bec8f389ada32ba9eecea16b36"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"troyronda"}}