payload: {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hono/pulls/comments/327695419","pull_request_review_id":292527607,"id":327695419,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzY5NTQxOQ==","diff_hunk":"@@ -105,21 +105,14 @@\n       </ThreadGroup>\n       <hashTree>\n         <HTTPSamplerProxy guiclass=\"HttpTestSampleGui\" testclass=\"HTTPSamplerProxy\" testname=\"Register Device\" enabled=\"true\">\n-          <boolProp name=\"HTTPSampler.postBodyRaw\">true</boolProp>\n-          <elementProp name=\"HTTPsampler.Arguments\" elementType=\"Arguments\">\n-            <collectionProp name=\"Arguments.arguments\">\n-              <elementProp name=\"\" elementType=\"HTTPArgument\">\n-                <boolProp name=\"HTTPArgument.always_encode\">false</boolProp>\n-                <stringProp name=\"Argument.value\">{&quot;device-id&quot;: &quot;device_${__threadNum}&quot;}</stringProp>\n-                <stringProp name=\"Argument.metadata\">=</stringProp>\n-              </elementProp>\n-            </collectionProp>\n+          <elementProp name=\"HTTPsampler.Arguments\" elementType=\"Arguments\" guiclass=\"HTTPArgumentsPanel\" testclass=\"Arguments\" testname=\"User Defined Variables\" enabled=\"true\">","path":"jmeter/src/jmeter/http_messaging_throughput_test.jmx","position":13,"original_position":13,"commit_id":"931b8fc3ec8988011c8ccb09d54e29415b089264","original_commit_id":"931b8fc3ec8988011c8ccb09d54e29415b089264","user":{"login":"kaizimmerm","id":9153035,"node_id":"MDQ6VXNlcjkxNTMwMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9153035?v=4","gravatar_id":"","url":"https://api.github.com/users/kaizimmerm","html_url":"https://github.com/kaizimmerm","followers_url":"https://api.github.com/users/kaizimmerm/followers","following_url":"https://api.github.com/users/kaizimmerm/following{/other_user}","gists_url":"https://api.github.com/users/kaizimmerm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizimmerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizimmerm/subscriptions","organizations_url":"https://api.github.com/users/kaizimmerm/orgs","repos_url":"https://api.github.com/users/kaizimmerm/repos","events_url":"https://api.github.com/users/kaizimmerm/events{/privacy}","received_events_url":"https://api.github.com/users/kaizimmerm/received_events","type":"User","site_admin":false},"body":"Done. https://github.com/eclipse/hono/pull/1522","created_at":"2019-09-24T15:50:42Z","updated_at":"2019-09-24T15:50:42Z","html_url":"https://github.com/eclipse/hono/pull/1499#discussion_r327695419","pull_request_url":"https://api.github.com/repos/eclipse/hono/pulls/1499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments/327695419"},"html":{"href":"https://github.com/eclipse/hono/pull/1499#discussion_r327695419"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hono/pulls/1499"}},"in_reply_to_id":327060118},"pull_request":{"url":"https://api.github.com/repos/eclipse/hono/pulls/1499","id":318374549,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4Mzc0NTQ5","html_url":"https://github.com/eclipse/hono/pull/1499","diff_url":"https://github.com/eclipse/hono/pull/1499.diff","patch_url":"https://github.com/eclipse/hono/pull/1499.patch","issue_url":"https://api.github.com/repos/eclipse/hono/issues/1499","number":1499,"state":"open","locked":false,"title":"Improved Azure guidance: Azure Service Bus, ARM templates and service endpoints","user":{"login":"kaizimmerm","id":9153035,"node_id":"MDQ6VXNlcjkxNTMwMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9153035?v=4","gravatar_id":"","url":"https://api.github.com/users/kaizimmerm","html_url":"https://github.com/kaizimmerm","followers_url":"https://api.github.com/users/kaizimmerm/followers","following_url":"https://api.github.com/users/kaizimmerm/following{/other_user}","gists_url":"https://api.github.com/users/kaizimmerm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizimmerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizimmerm/subscriptions","organizations_url":"https://api.github.com/users/kaizimmerm/orgs","repos_url":"https://api.github.com/users/kaizimmerm/repos","events_url":"https://api.github.com/users/kaizimmerm/events{/privacy}","received_events_url":"https://api.github.com/users/kaizimmerm/received_events","type":"User","site_admin":false},"body":"Primarily improvements for Azure deployments:\r\n\r\n- [Azure Resource Manager (ARM)](https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-overview) templates for an automated infrastructure deployment.\r\n- [Azure Service Bus](https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-messaging-overview) for the _Eclipse Hono™ AMQP 1.0 Messaging Network_ instead of a self hosted ActiveMQ Artemis.\r\n- [Virtual Network (VNet) service endpoints](https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-service-endpoints-overview) ensure protected communication between AKS and Azure Service Bus.\r\n- Static IPs and DNS names for Azure load balancers provisioned.\r\n- Created a dedicated page in documentation for Azure as this now beyond k8s deployment.\r\n\r\nI had to change a few non Azure related aspects as well to make it happen:\r\n\r\n- Helm values extended to define annotations for services as well as load balancer IPs. The default did not change though.\r\n- Upgraded dispatch router to 1.8 as only this one works with Azure Service Bus.\r\n- Adapted the HTTP load-test script. It seemed it was based on a different/deprecated registry API?\r\n- I configured in the router config an address for event as well to have a balanced event distribution over multiple clients. Maybe I got the event concept wrong but I would expect this behaviour not only for telemetry.\r\n\r\nLet me know what you think,\r\n\r\nKai\r\n\r\n\r\n","created_at":"2019-09-17T14:40:26Z","updated_at":"2019-09-24T15:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d625f48121af99eaeb250d680e1df0600868257","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/hono/pulls/1499/commits","review_comments_url":"https://api.github.com/repos/eclipse/hono/pulls/1499/comments","review_comment_url":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hono/issues/1499/comments","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/8ad2d9975733dc1f129a489f1244e150c1145898","head":{"label":"kaizimmerm:aks","ref":"aks","sha":"8ad2d9975733dc1f129a489f1244e150c1145898","user":{"login":"kaizimmerm","id":9153035,"node_id":"MDQ6VXNlcjkxNTMwMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9153035?v=4","gravatar_id":"","url":"https://api.github.com/users/kaizimmerm","html_url":"https://github.com/kaizimmerm","followers_url":"https://api.github.com/users/kaizimmerm/followers","following_url":"https://api.github.com/users/kaizimmerm/following{/other_user}","gists_url":"https://api.github.com/users/kaizimmerm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizimmerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizimmerm/subscriptions","organizations_url":"https://api.github.com/users/kaizimmerm/orgs","repos_url":"https://api.github.com/users/kaizimmerm/repos","events_url":"https://api.github.com/users/kaizimmerm/events{/privacy}","received_events_url":"https://api.github.com/users/kaizimmerm/received_events","type":"User","site_admin":false},"repo":{"id":168534467,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg1MzQ0Njc=","name":"hono","full_name":"kaizimmerm/hono","private":false,"owner":{"login":"kaizimmerm","id":9153035,"node_id":"MDQ6VXNlcjkxNTMwMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9153035?v=4","gravatar_id":"","url":"https://api.github.com/users/kaizimmerm","html_url":"https://github.com/kaizimmerm","followers_url":"https://api.github.com/users/kaizimmerm/followers","following_url":"https://api.github.com/users/kaizimmerm/following{/other_user}","gists_url":"https://api.github.com/users/kaizimmerm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizimmerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizimmerm/subscriptions","organizations_url":"https://api.github.com/users/kaizimmerm/orgs","repos_url":"https://api.github.com/users/kaizimmerm/repos","events_url":"https://api.github.com/users/kaizimmerm/events{/privacy}","received_events_url":"https://api.github.com/users/kaizimmerm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kaizimmerm/hono","description":"Eclipse Hono™ Project","fork":true,"url":"https://api.github.com/repos/kaizimmerm/hono","forks_url":"https://api.github.com/repos/kaizimmerm/hono/forks","keys_url":"https://api.github.com/repos/kaizimmerm/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaizimmerm/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaizimmerm/hono/teams","hooks_url":"https://api.github.com/repos/kaizimmerm/hono/hooks","issue_events_url":"https://api.github.com/repos/kaizimmerm/hono/issues/events{/number}","events_url":"https://api.github.com/repos/kaizimmerm/hono/events","assignees_url":"https://api.github.com/repos/kaizimmerm/hono/assignees{/user}","branches_url":"https://api.github.com/repos/kaizimmerm/hono/branches{/branch}","tags_url":"https://api.github.com/repos/kaizimmerm/hono/tags","blobs_url":"https://api.github.com/repos/kaizimmerm/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaizimmerm/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaizimmerm/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaizimmerm/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaizimmerm/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/kaizimmerm/hono/languages","stargazers_url":"https://api.github.com/repos/kaizimmerm/hono/stargazers","contributors_url":"https://api.github.com/repos/kaizimmerm/hono/contributors","subscribers_url":"https://api.github.com/repos/kaizimmerm/hono/subscribers","subscription_url":"https://api.github.com/repos/kaizimmerm/hono/subscription","commits_url":"https://api.github.com/repos/kaizimmerm/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaizimmerm/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaizimmerm/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaizimmerm/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaizimmerm/hono/contents/{+path}","compare_url":"https://api.github.com/repos/kaizimmerm/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaizimmerm/hono/merges","archive_url":"https://api.github.com/repos/kaizimmerm/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaizimmerm/hono/downloads","issues_url":"https://api.github.com/repos/kaizimmerm/hono/issues{/number}","pulls_url":"https://api.github.com/repos/kaizimmerm/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/kaizimmerm/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/kaizimmerm/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaizimmerm/hono/labels{/name}","releases_url":"https://api.github.com/repos/kaizimmerm/hono/releases{/id}","deployments_url":"https://api.github.com/repos/kaizimmerm/hono/deployments","created_at":"2019-01-31T14:01:50Z","updated_at":"2019-09-24T15:39:36Z","pushed_at":"2019-09-24T15:50:41Z","git_url":"git://github.com/kaizimmerm/hono.git","ssh_url":"git@github.com:kaizimmerm/hono.git","clone_url":"https://github.com/kaizimmerm/hono.git","svn_url":"https://github.com/kaizimmerm/hono","homepage":"http://www.eclipse.org/hono","size":23851,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"75d4a343c1917441d42c37439ea12a7b1047285e","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":51307016,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwNzAxNg==","name":"hono","full_name":"eclipse/hono","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/hono","description":"Eclipse Hono™ Project","fork":false,"url":"https://api.github.com/repos/eclipse/hono","forks_url":"https://api.github.com/repos/eclipse/hono/forks","keys_url":"https://api.github.com/repos/eclipse/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hono/teams","hooks_url":"https://api.github.com/repos/eclipse/hono/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hono/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hono/events","assignees_url":"https://api.github.com/repos/eclipse/hono/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hono/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hono/tags","blobs_url":"https://api.github.com/repos/eclipse/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hono/languages","stargazers_url":"https://api.github.com/repos/eclipse/hono/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hono/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hono/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hono/subscription","commits_url":"https://api.github.com/repos/eclipse/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hono/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hono/merges","archive_url":"https://api.github.com/repos/eclipse/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hono/downloads","issues_url":"https://api.github.com/repos/eclipse/hono/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hono/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hono/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hono/deployments","created_at":"2016-02-08T15:45:28Z","updated_at":"2019-09-24T11:48:21Z","pushed_at":"2019-09-24T15:49:33Z","git_url":"git://github.com/eclipse/hono.git","ssh_url":"git@github.com:eclipse/hono.git","clone_url":"https://github.com/eclipse/hono.git","svn_url":"https://github.com/eclipse/hono","homepage":"http://www.eclipse.org/hono","size":24734,"stargazers_count":242,"watchers_count":242,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":80,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":76,"open_issues":80,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/1499"},"html":{"href":"https://github.com/eclipse/hono/pull/1499"},"issue":{"href":"https://api.github.com/repos/eclipse/hono/issues/1499"},"comments":{"href":"https://api.github.com/repos/eclipse/hono/issues/1499/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hono/pulls/1499/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hono/pulls/1499/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hono/statuses/8ad2d9975733dc1f129a489f1244e150c1145898"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"kaizimmerm"}}