payload: {"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/28621","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28621/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28621/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28621/events","html_url":"https://github.com/cms-sw/cmssw/pull/28621","id":537455930,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyODA3OTMz","number":28621,"title":"PPS: configurable timing-tracking cut","user":{"login":"jan-kaspar","id":17830858,"node_id":"MDQ6VXNlcjE3ODMwODU4","avatar_url":"https://avatars0.githubusercontent.com/u/17830858?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false,"description":null},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false,"description":null},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false,"description":null},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false,"description":null},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false,"description":null},{"id":56131195,"node_id":"MDU6TGFiZWw1NjEzMTE5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/82","html_url":"https://github.com/cms-sw/cmssw/milestone/82","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/82/labels","id":4894350,"node_id":"MDk6TWlsZXN0b25lNDg5NDM1MA==","number":82,"title":"CMSSW_11_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":66,"state":"open","created_at":"2019-12-02T10:38:40Z","updated_at":"2019-12-13T10:01:59Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2019-12-13T10:01:30Z","updated_at":"2019-12-13T14:00:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/28621","html_url":"https://github.com/cms-sw/cmssw/pull/28621","diff_url":"https://github.com/cms-sw/cmssw/pull/28621.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/28621.patch"},"body":"#### PR description:\r\n\r\nThis PR allows to configure (in python) the cuts for association between timing-RP and tracking-RP local tracks. Previously, these cuts were effectively hard-coded. This is a follow up of an observation presented e.g. in [Proton POG meeting 26 Nov 2019](https://indico.cern.ch/event/865518/contributions/3648775/attachments/1951600/3240029/kaspar_dpg_timing_eff.pdf) (slide 5), showing that the current cuts a little too strict. In order to maintain the backward compatibility, this PR keeps the default cut values as before.\r\n\r\n#### PR validation:\r\n\r\nThe plot below compares proton reconstruction results for different periods (rows) and different CMSSW versions/settiings (colours). Comparing blue (before this PR) with red dashed (this PR, default cuts) shows that there is no difference in results. Comparing red dashed (default cuts) with green (enlarged cuts) shows that more reco-proton objects include non-zero number of timing-RP tracks.\r\n\r\n![make_cmp](https://user-images.githubusercontent.com/17830858/70791259-0f2b8900-1d97-11ea-8210-9dd68eb6e9fb.png)\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/565450874","html_url":"https://github.com/cms-sw/cmssw/pull/28621#issuecomment-565450874","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28621","id":565450874,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NTQ1MDg3NA==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2019-12-13T14:00:23Z","updated_at":"2019-12-13T14:00:23Z","author_association":"CONTRIBUTOR","body":"Comparison is ready\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c2357/3962/summary.html\n\nComparison Summary:\n - No significant changes to the logs found\n - Reco comparison results: 2 differences found in the comparisons\n - DQMHistoTests: Total files compared: 34\n - DQMHistoTests: Total histograms compared: 2798405\n - DQMHistoTests: Total failures: 2\n - DQMHistoTests: Total nulls: 0\n - DQMHistoTests: Total successes: 2798062\n - DQMHistoTests: Total skipped: 341\n - DQMHistoTests: Total Missing objects: 0\n - DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)\n - Checked 147 log files, 16 edm output root files, 34 DQM output files\n"}}
other: {"actor":{"display_login":"cmsbuild"}}