payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MariaDB/server/pulls/comments/265365565","pull_request_review_id":214253775,"id":265365565,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTM2NTU2NQ==","diff_hunk":"@@ -21,11 +21,11 @@ EOF\n     exit 0\n fi\n \n-systemctl set-environment _WSREP_NEW_CLUSTER='--wsrep-new-cluster' && \\\n+echo _WSREP_NEW_CLUSTER='--wsrep-new-cluster' > @mysqlunixdir@/\"wsrep-new-cluster-${1:-mariadb}\" && \\","path":"scripts/galera_new_cluster.sh","position":5,"original_position":5,"commit_id":"d77e660670ccaa856ea458b0175ab7301654c44c","original_commit_id":"d77e660670ccaa856ea458b0175ab7301654c44c","user":{"login":"grooverdan","id":462287,"node_id":"MDQ6VXNlcjQ2MjI4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/462287?v=4","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"body":"`-` before `$` breaks it for mariadb@service\r\n\r\nMaybe something like:\r\n<pre>\r\nSERVICE=${1:-mariadb@service}\r\nFILE=@mysqlunixdir@/wsrep-new-cluster-${SERVICE}\r\necho _WSREP_NEW_CLUSTER='--wsrep-new-cluster' > \"${FILE}\" ...\r\n..\r\nsystemctl start \"$SERVICE\"\r\nrm -f \"$FILE\"\r\n</pre>\r\n\r\nAnd then have both mariadb.service.in and mariadb@service.in the same with:\r\n<pre>\r\nEnvironmentFile=-@mysqlunixdir@/wsrep-new-cluster-%n\r\nEnvironmentFile=-@mysqlunixdir@/wsrep-start-position-%n\r\n</pre>","created_at":"2019-03-13T23:03:11Z","updated_at":"2019-03-13T23:03:11Z","html_url":"https://github.com/MariaDB/server/pull/1143#discussion_r265365565","pull_request_url":"https://api.github.com/repos/MariaDB/server/pulls/1143","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments/265365565"},"html":{"href":"https://github.com/MariaDB/server/pull/1143#discussion_r265365565"},"pull_request":{"href":"https://api.github.com/repos/MariaDB/server/pulls/1143"}}},"pull_request":{"url":"https://api.github.com/repos/MariaDB/server/pulls/1143","id":247989461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ3OTg5NDYx","html_url":"https://github.com/MariaDB/server/pull/1143","diff_url":"https://github.com/MariaDB/server/pull/1143.diff","patch_url":"https://github.com/MariaDB/server/pull/1143.patch","issue_url":"https://api.github.com/repos/MariaDB/server/issues/1143","number":1143,"state":"open","locked":false,"title":"use environment file in systemd units for _WSREP_*","user":{"login":"eworm-de","id":970853,"node_id":"MDQ6VXNlcjk3MDg1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/970853?v=4","gravatar_id":"","url":"https://api.github.com/users/eworm-de","html_url":"https://github.com/eworm-de","followers_url":"https://api.github.com/users/eworm-de/followers","following_url":"https://api.github.com/users/eworm-de/following{/other_user}","gists_url":"https://api.github.com/users/eworm-de/gists{/gist_id}","starred_url":"https://api.github.com/users/eworm-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eworm-de/subscriptions","organizations_url":"https://api.github.com/users/eworm-de/orgs","repos_url":"https://api.github.com/users/eworm-de/repos","events_url":"https://api.github.com/users/eworm-de/events{/privacy}","received_events_url":"https://api.github.com/users/eworm-de/received_events","type":"User","site_admin":false},"body":"We used to run `systemctl set-environment` to pass\r\n_WSREP_START_POSITION. This is bad because:\r\n\r\n* it clutter systemd's environment (yes, pid 1)\r\n* it requires root privileges\r\n\r\nLet's just create an environment file in ExecStartPre=, that is read\r\nbefore ExecStart= kicks in. We have _WSREP_START_POSITION around for the\r\nmain process without any downsides.","created_at":"2019-01-27T23:33:40Z","updated_at":"2019-03-13T23:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c06aad65faa7c64afd115190af40c251fc79cedb","assignee":{"login":"cvicentiu","id":2320573,"node_id":"MDQ6VXNlcjIzMjA1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2320573?v=4","gravatar_id":"","url":"https://api.github.com/users/cvicentiu","html_url":"https://github.com/cvicentiu","followers_url":"https://api.github.com/users/cvicentiu/followers","following_url":"https://api.github.com/users/cvicentiu/following{/other_user}","gists_url":"https://api.github.com/users/cvicentiu/gists{/gist_id}","starred_url":"https://api.github.com/users/cvicentiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvicentiu/subscriptions","organizations_url":"https://api.github.com/users/cvicentiu/orgs","repos_url":"https://api.github.com/users/cvicentiu/repos","events_url":"https://api.github.com/users/cvicentiu/events{/privacy}","received_events_url":"https://api.github.com/users/cvicentiu/received_events","type":"User","site_admin":false},"assignees":[{"login":"cvicentiu","id":2320573,"node_id":"MDQ6VXNlcjIzMjA1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2320573?v=4","gravatar_id":"","url":"https://api.github.com/users/cvicentiu","html_url":"https://github.com/cvicentiu","followers_url":"https://api.github.com/users/cvicentiu/followers","following_url":"https://api.github.com/users/cvicentiu/following{/other_user}","gists_url":"https://api.github.com/users/cvicentiu/gists{/gist_id}","starred_url":"https://api.github.com/users/cvicentiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvicentiu/subscriptions","organizations_url":"https://api.github.com/users/cvicentiu/orgs","repos_url":"https://api.github.com/users/cvicentiu/repos","events_url":"https://api.github.com/users/cvicentiu/events{/privacy}","received_events_url":"https://api.github.com/users/cvicentiu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1127269626,"node_id":"MDU6TGFiZWwxMTI3MjY5NjI2","url":"https://api.github.com/repos/MariaDB/server/labels/license-mca","name":"license-mca","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/MariaDB/server/milestones/5","html_url":"https://github.com/MariaDB/server/milestone/5","labels_url":"https://api.github.com/repos/MariaDB/server/milestones/5/labels","id":2361582,"node_id":"MDk6TWlsZXN0b25lMjM2MTU4Mg==","number":5,"title":"10.3","description":null,"creator":{"login":"svoj","id":7700472,"node_id":"MDQ6VXNlcjc3MDA0NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/7700472?v=4","gravatar_id":"","url":"https://api.github.com/users/svoj","html_url":"https://github.com/svoj","followers_url":"https://api.github.com/users/svoj/followers","following_url":"https://api.github.com/users/svoj/following{/other_user}","gists_url":"https://api.github.com/users/svoj/gists{/gist_id}","starred_url":"https://api.github.com/users/svoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svoj/subscriptions","organizations_url":"https://api.github.com/users/svoj/orgs","repos_url":"https://api.github.com/users/svoj/repos","events_url":"https://api.github.com/users/svoj/events{/privacy}","received_events_url":"https://api.github.com/users/svoj/received_events","type":"User","site_admin":false},"open_issues":91,"closed_issues":214,"state":"open","created_at":"2017-03-03T16:45:11Z","updated_at":"2019-03-13T14:51:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/MariaDB/server/pulls/1143/commits","review_comments_url":"https://api.github.com/repos/MariaDB/server/pulls/1143/comments","review_comment_url":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MariaDB/server/issues/1143/comments","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/d77e660670ccaa856ea458b0175ab7301654c44c","head":{"label":"eworm-de:systemd-environment","ref":"systemd-environment","sha":"d77e660670ccaa856ea458b0175ab7301654c44c","user":{"login":"eworm-de","id":970853,"node_id":"MDQ6VXNlcjk3MDg1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/970853?v=4","gravatar_id":"","url":"https://api.github.com/users/eworm-de","html_url":"https://github.com/eworm-de","followers_url":"https://api.github.com/users/eworm-de/followers","following_url":"https://api.github.com/users/eworm-de/following{/other_user}","gists_url":"https://api.github.com/users/eworm-de/gists{/gist_id}","starred_url":"https://api.github.com/users/eworm-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eworm-de/subscriptions","organizations_url":"https://api.github.com/users/eworm-de/orgs","repos_url":"https://api.github.com/users/eworm-de/repos","events_url":"https://api.github.com/users/eworm-de/events{/privacy}","received_events_url":"https://api.github.com/users/eworm-de/received_events","type":"User","site_admin":false},"repo":{"id":66345046,"node_id":"MDEwOlJlcG9zaXRvcnk2NjM0NTA0Ng==","name":"mariadb-server","full_name":"eworm-de/mariadb-server","private":false,"owner":{"login":"eworm-de","id":970853,"node_id":"MDQ6VXNlcjk3MDg1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/970853?v=4","gravatar_id":"","url":"https://api.github.com/users/eworm-de","html_url":"https://github.com/eworm-de","followers_url":"https://api.github.com/users/eworm-de/followers","following_url":"https://api.github.com/users/eworm-de/following{/other_user}","gists_url":"https://api.github.com/users/eworm-de/gists{/gist_id}","starred_url":"https://api.github.com/users/eworm-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eworm-de/subscriptions","organizations_url":"https://api.github.com/users/eworm-de/orgs","repos_url":"https://api.github.com/users/eworm-de/repos","events_url":"https://api.github.com/users/eworm-de/events{/privacy}","received_events_url":"https://api.github.com/users/eworm-de/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eworm-de/mariadb-server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":true,"url":"https://api.github.com/repos/eworm-de/mariadb-server","forks_url":"https://api.github.com/repos/eworm-de/mariadb-server/forks","keys_url":"https://api.github.com/repos/eworm-de/mariadb-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eworm-de/mariadb-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eworm-de/mariadb-server/teams","hooks_url":"https://api.github.com/repos/eworm-de/mariadb-server/hooks","issue_events_url":"https://api.github.com/repos/eworm-de/mariadb-server/issues/events{/number}","events_url":"https://api.github.com/repos/eworm-de/mariadb-server/events","assignees_url":"https://api.github.com/repos/eworm-de/mariadb-server/assignees{/user}","branches_url":"https://api.github.com/repos/eworm-de/mariadb-server/branches{/branch}","tags_url":"https://api.github.com/repos/eworm-de/mariadb-server/tags","blobs_url":"https://api.github.com/repos/eworm-de/mariadb-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eworm-de/mariadb-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eworm-de/mariadb-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/eworm-de/mariadb-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eworm-de/mariadb-server/statuses/{sha}","languages_url":"https://api.github.com/repos/eworm-de/mariadb-server/languages","stargazers_url":"https://api.github.com/repos/eworm-de/mariadb-server/stargazers","contributors_url":"https://api.github.com/repos/eworm-de/mariadb-server/contributors","subscribers_url":"https://api.github.com/repos/eworm-de/mariadb-server/subscribers","subscription_url":"https://api.github.com/repos/eworm-de/mariadb-server/subscription","commits_url":"https://api.github.com/repos/eworm-de/mariadb-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/eworm-de/mariadb-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/eworm-de/mariadb-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/eworm-de/mariadb-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/eworm-de/mariadb-server/contents/{+path}","compare_url":"https://api.github.com/repos/eworm-de/mariadb-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eworm-de/mariadb-server/merges","archive_url":"https://api.github.com/repos/eworm-de/mariadb-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eworm-de/mariadb-server/downloads","issues_url":"https://api.github.com/repos/eworm-de/mariadb-server/issues{/number}","pulls_url":"https://api.github.com/repos/eworm-de/mariadb-server/pulls{/number}","milestones_url":"https://api.github.com/repos/eworm-de/mariadb-server/milestones{/number}","notifications_url":"https://api.github.com/repos/eworm-de/mariadb-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eworm-de/mariadb-server/labels{/name}","releases_url":"https://api.github.com/repos/eworm-de/mariadb-server/releases{/id}","deployments_url":"https://api.github.com/repos/eworm-de/mariadb-server/deployments","created_at":"2016-08-23T07:41:05Z","updated_at":"2019-03-13T15:10:53Z","pushed_at":"2019-03-13T15:09:57Z","git_url":"git://github.com/eworm-de/mariadb-server.git","ssh_url":"git@github.com:eworm-de/mariadb-server.git","clone_url":"https://github.com/eworm-de/mariadb-server.git","svn_url":"https://github.com/eworm-de/mariadb-server","homepage":"","size":678023,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.3"}},"base":{"label":"MariaDB:10.3","ref":"10.3","sha":"69b33fca8cce0912b7fecc79cbef895a119f3017","user":{"login":"MariaDB","id":4739304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzkzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4739304?v=4","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":19816070,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgxNjA3MA==","name":"server","full_name":"MariaDB/server","private":false,"owner":{"login":"MariaDB","id":4739304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzkzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4739304?v=4","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MariaDB/server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":false,"url":"https://api.github.com/repos/MariaDB/server","forks_url":"https://api.github.com/repos/MariaDB/server/forks","keys_url":"https://api.github.com/repos/MariaDB/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MariaDB/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MariaDB/server/teams","hooks_url":"https://api.github.com/repos/MariaDB/server/hooks","issue_events_url":"https://api.github.com/repos/MariaDB/server/issues/events{/number}","events_url":"https://api.github.com/repos/MariaDB/server/events","assignees_url":"https://api.github.com/repos/MariaDB/server/assignees{/user}","branches_url":"https://api.github.com/repos/MariaDB/server/branches{/branch}","tags_url":"https://api.github.com/repos/MariaDB/server/tags","blobs_url":"https://api.github.com/repos/MariaDB/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MariaDB/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MariaDB/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/MariaDB/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/{sha}","languages_url":"https://api.github.com/repos/MariaDB/server/languages","stargazers_url":"https://api.github.com/repos/MariaDB/server/stargazers","contributors_url":"https://api.github.com/repos/MariaDB/server/contributors","subscribers_url":"https://api.github.com/repos/MariaDB/server/subscribers","subscription_url":"https://api.github.com/repos/MariaDB/server/subscription","commits_url":"https://api.github.com/repos/MariaDB/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/MariaDB/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/MariaDB/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/MariaDB/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/MariaDB/server/contents/{+path}","compare_url":"https://api.github.com/repos/MariaDB/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MariaDB/server/merges","archive_url":"https://api.github.com/repos/MariaDB/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MariaDB/server/downloads","issues_url":"https://api.github.com/repos/MariaDB/server/issues{/number}","pulls_url":"https://api.github.com/repos/MariaDB/server/pulls{/number}","milestones_url":"https://api.github.com/repos/MariaDB/server/milestones{/number}","notifications_url":"https://api.github.com/repos/MariaDB/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MariaDB/server/labels{/name}","releases_url":"https://api.github.com/repos/MariaDB/server/releases{/id}","deployments_url":"https://api.github.com/repos/MariaDB/server/deployments","created_at":"2014-05-15T10:58:50Z","updated_at":"2019-03-13T21:54:28Z","pushed_at":"2019-03-13T22:23:44Z","git_url":"git://github.com/MariaDB/server.git","ssh_url":"git@github.com:MariaDB/server.git","clone_url":"https://github.com/MariaDB/server.git","svn_url":"https://github.com/MariaDB/server","homepage":"","size":705886,"stargazers_count":2505,"watchers_count":2505,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":796,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":796,"open_issues":179,"watchers":2505,"default_branch":"10.4"}},"_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/1143"},"html":{"href":"https://github.com/MariaDB/server/pull/1143"},"issue":{"href":"https://api.github.com/repos/MariaDB/server/issues/1143"},"comments":{"href":"https://api.github.com/repos/MariaDB/server/issues/1143/comments"},"review_comments":{"href":"https://api.github.com/repos/MariaDB/server/pulls/1143/comments"},"review_comment":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MariaDB/server/pulls/1143/commits"},"statuses":{"href":"https://api.github.com/repos/MariaDB/server/statuses/d77e660670ccaa856ea458b0175ab7301654c44c"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"grooverdan"}}