payload: {"action":"created","comment":{"url":"https://api.github.com/repos/roc-project/roc-go/pulls/comments/337177460","pull_request_review_id":304769514,"id":337177460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzE3NzQ2MA==","diff_hunk":"@@ -0,0 +1,116 @@\n+// WARNING: This file has automatically been generated on Sun, 20 Oct 2019 18:32:28 CEST.\n+// Code generated by https://git.io/c-for-go. DO NOT EDIT.\n+\n+package roc\n+\n+/*\n+#cgo CFLAGS: -I\"../include\"\n+#cgo LDFLAGS: -lroc\n+#include \"../include/roc/address.h\"\n+#include \"../include/roc/config.h\"\n+#include \"../include/roc/context.h\"\n+#include \"../include/roc/frame.h\"\n+#include \"../include/roc/log.h\"\n+#include \"../include/roc/platform.h\"\n+#include \"../include/roc/receiver.h\"\n+#include \"../include/roc/sender.h\"\n+#include <stdlib.h>\n+#include \"cgo_helpers.h\"\n+*/\n+import \"C\"\n+\n+// Family as declared in roc/address.h:36\n+type Family int32\n+\n+// Family enumeration from roc/address.h:36\n+const (\n+\tAfInvalid Family = -1\n+\tAfAuto    Family = 0\n+\tAfIpv4    Family = 1\n+\tAfIpv6    Family = 2\n+)\n+\n+// PortType as declared in roc/config.h:35\n+type PortType int32\n+\n+// PortType enumeration from roc/config.h:35\n+const (\n+\tPortAudioSource PortType = 1\n+\tPortAudioRepair PortType = 2\n+)\n+\n+// Protocol as declared in roc/config.h:54\n+type Protocol int32\n+\n+// Protocol enumeration from roc/config.h:54\n+const (\n+\tProtoRtp           Protocol = 1\n+\tProtoRtpRs8mSource Protocol = 2\n+\tProtoRs8mRepair    Protocol = 3\n+\tProtoRtpLdpcSource Protocol = 4\n+\tProtoLdpcRepair    Protocol = 5\n+)\n+\n+// FecCode as declared in roc/config.h:81\n+type FecCode int32\n+\n+// FecCode enumeration from roc/config.h:81\n+const (\n+\tFecDisable       FecCode = -1\n+\tFecDefault       FecCode = 0\n+\tFecRs8m          FecCode = 1\n+\tFecLdpcStaircase FecCode = 2\n+)\n+\n+// PacketEncoding as declared in roc/config.h:91\n+type PacketEncoding int32\n+\n+// PacketEncoding enumeration from roc/config.h:91\n+const (\n+\tPacketEncodingAvpL16 PacketEncoding = 2\n+)\n+\n+// FrameEncoding as declared in roc/config.h:100\n+type FrameEncoding int32\n+\n+// FrameEncoding enumeration from roc/config.h:100\n+const (\n+\tFrameEncodingPcmFloat FrameEncoding = 1\n+)\n+\n+// ChannelSet as declared in roc/config.h:108\n+type ChannelSet int32\n+\n+// ChannelSet enumeration from roc/config.h:108\n+const (\n+\tChannelSetStereo ChannelSet = 2\n+)\n+\n+// ResamplerProfile as declared in roc/config.h:128\n+type ResamplerProfile int32\n+\n+// ResamplerProfile enumeration from roc/config.h:128\n+const (\n+\tResamplerDisable ResamplerProfile = -1\n+\tResamplerDefault ResamplerProfile = 0\n+\tResamplerHigh    ResamplerProfile = 1\n+\tResamplerMedium  ResamplerProfile = 2\n+\tResamplerLow     ResamplerProfile = 3\n+)\n+\n+// LogLevel as declared in roc/log.h:53\n+type LogLevel int32\n+\n+// LogLevel enumeration from roc/log.h:53\n+const (\n+\tLogNone  LogLevel = iota\n+\tLogError LogLevel = 1\n+\tLogInfo  LogLevel = 2\n+\tLogDebug LogLevel = 3\n+\tLogTrace LogLevel = 4\n+)\n+\n+const (\n+\t// AddressSize as declared in roc/address.h:40\n+\tAddressSize = 64","path":"roc/const.go","position":115,"original_position":115,"commit_id":"97d957063d1183cf28714fa3596da3b94262346a","original_commit_id":"97d957063d1183cf28714fa3596da3b94262346a","user":{"login":"Asalle","id":4975074,"node_id":"MDQ6VXNlcjQ5NzUwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4975074?v=4","gravatar_id":"","url":"https://api.github.com/users/Asalle","html_url":"https://github.com/Asalle","followers_url":"https://api.github.com/users/Asalle/followers","following_url":"https://api.github.com/users/Asalle/following{/other_user}","gists_url":"https://api.github.com/users/Asalle/gists{/gist_id}","starred_url":"https://api.github.com/users/Asalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asalle/subscriptions","organizations_url":"https://api.github.com/users/Asalle/orgs","repos_url":"https://api.github.com/users/Asalle/repos","events_url":"https://api.github.com/users/Asalle/events{/privacy}","received_events_url":"https://api.github.com/users/Asalle/received_events","type":"User","site_admin":false},"body":"yes, you pointed out some exported/unexported stuff before and I'm trying to make it work with c-for-go (basically enumerate what do we want exported and unexport everything else)","created_at":"2019-10-21T18:41:06Z","updated_at":"2019-10-21T18:41:07Z","html_url":"https://github.com/roc-project/roc-go/pull/1#discussion_r337177460","pull_request_url":"https://api.github.com/repos/roc-project/roc-go/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/roc-project/roc-go/pulls/comments/337177460"},"html":{"href":"https://github.com/roc-project/roc-go/pull/1#discussion_r337177460"},"pull_request":{"href":"https://api.github.com/repos/roc-project/roc-go/pulls/1"}},"in_reply_to_id":336888347},"pull_request":{"url":"https://api.github.com/repos/roc-project/roc-go/pulls/1","id":327582407,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3NTgyNDA3","html_url":"https://github.com/roc-project/roc-go/pull/1","diff_url":"https://github.com/roc-project/roc-go/pull/1.diff","patch_url":"https://github.com/roc-project/roc-go/pull/1.patch","issue_url":"https://api.github.com/repos/roc-project/roc-go/issues/1","number":1,"state":"open","locked":false,"title":"Creating golang bindings","user":{"login":"Asalle","id":4975074,"node_id":"MDQ6VXNlcjQ5NzUwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4975074?v=4","gravatar_id":"","url":"https://api.github.com/users/Asalle","html_url":"https://github.com/Asalle","followers_url":"https://api.github.com/users/Asalle/followers","following_url":"https://api.github.com/users/Asalle/following{/other_user}","gists_url":"https://api.github.com/users/Asalle/gists{/gist_id}","starred_url":"https://api.github.com/users/Asalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asalle/subscriptions","organizations_url":"https://api.github.com/users/Asalle/orgs","repos_url":"https://api.github.com/users/Asalle/repos","events_url":"https://api.github.com/users/Asalle/events{/privacy}","received_events_url":"https://api.github.com/users/Asalle/received_events","type":"User","site_admin":false},"body":"Regarding your comments to pr #269\r\n> For Address, Context, Recevier, and Sender replace free functions with methods\r\n\r\nIn the last commit I showcased an example of how it would look like, if you find it acceptable I will write bindings to all other functions.\r\n\r\n> For argument that are single values replace slices with passing by value or passing by pointer (depending on whether the function modifies the argument):\r\n\r\nYes, we can tell c-for-go to do that. Please confirm if I put the pointers in the right places.\r\n\r\n> Replace int32 return codes with Go error\r\n\r\nI wrote a simple converter in `roc-wrappers.go`, also I opened an issue in `c-for-go` to find out if we can generate such things in the future. Please feel free to correct me/comment the [issue](https://github.com/xlab/c-for-go/issues/75).\r\n\r\n> Create convenient wrappers for frames of different types, as described in the issue:\r\n\r\nTBD\r\n\r\n> Replace LogHandler function with a Logger interface\r\n\r\nTBD\r\n\r\n> Allocations\r\n\r\nTBD.\r\n\r\nGeneral comments:\r\n1. Thank you so much for creating a new repo, it not only makes more sense, but also makes things much clearer to me.\r\n2. But at the same time, now we have two sources of truth for the headers. Do you have a backward compatibility promise that will absolutely guarantee that headers will not change? If not, maybe we can think about using submodules or something like that inthe future.\r\n3. Please don't inspect commits one by one, instead look at the code. They need to be squashed, but before I get a green light from you I'll keep them as is for simplicity. \r\n4. Readme is highly unproffesional and will be fixed before merge of this pr. Consider it \"my\" personal notes.\r\n\r\n","created_at":"2019-10-13T18:53:58Z","updated_at":"2019-10-21T18:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79716e111666f81fb7d04338da649c22e711f75c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/roc-project/roc-go/pulls/1/commits","review_comments_url":"https://api.github.com/repos/roc-project/roc-go/pulls/1/comments","review_comment_url":"https://api.github.com/repos/roc-project/roc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roc-project/roc-go/issues/1/comments","statuses_url":"https://api.github.com/repos/roc-project/roc-go/statuses/97d957063d1183cf28714fa3596da3b94262346a","head":{"label":"Asalle:develop","ref":"develop","sha":"97d957063d1183cf28714fa3596da3b94262346a","user":{"login":"Asalle","id":4975074,"node_id":"MDQ6VXNlcjQ5NzUwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4975074?v=4","gravatar_id":"","url":"https://api.github.com/users/Asalle","html_url":"https://github.com/Asalle","followers_url":"https://api.github.com/users/Asalle/followers","following_url":"https://api.github.com/users/Asalle/following{/other_user}","gists_url":"https://api.github.com/users/Asalle/gists{/gist_id}","starred_url":"https://api.github.com/users/Asalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asalle/subscriptions","organizations_url":"https://api.github.com/users/Asalle/orgs","repos_url":"https://api.github.com/users/Asalle/repos","events_url":"https://api.github.com/users/Asalle/events{/privacy}","received_events_url":"https://api.github.com/users/Asalle/received_events","type":"User","site_admin":false},"repo":{"id":214814292,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQ4MTQyOTI=","name":"roc-go","full_name":"Asalle/roc-go","private":false,"owner":{"login":"Asalle","id":4975074,"node_id":"MDQ6VXNlcjQ5NzUwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4975074?v=4","gravatar_id":"","url":"https://api.github.com/users/Asalle","html_url":"https://github.com/Asalle","followers_url":"https://api.github.com/users/Asalle/followers","following_url":"https://api.github.com/users/Asalle/following{/other_user}","gists_url":"https://api.github.com/users/Asalle/gists{/gist_id}","starred_url":"https://api.github.com/users/Asalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asalle/subscriptions","organizations_url":"https://api.github.com/users/Asalle/orgs","repos_url":"https://api.github.com/users/Asalle/repos","events_url":"https://api.github.com/users/Asalle/events{/privacy}","received_events_url":"https://api.github.com/users/Asalle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Asalle/roc-go","description":"Go bindings for Roc.","fork":true,"url":"https://api.github.com/repos/Asalle/roc-go","forks_url":"https://api.github.com/repos/Asalle/roc-go/forks","keys_url":"https://api.github.com/repos/Asalle/roc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Asalle/roc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Asalle/roc-go/teams","hooks_url":"https://api.github.com/repos/Asalle/roc-go/hooks","issue_events_url":"https://api.github.com/repos/Asalle/roc-go/issues/events{/number}","events_url":"https://api.github.com/repos/Asalle/roc-go/events","assignees_url":"https://api.github.com/repos/Asalle/roc-go/assignees{/user}","branches_url":"https://api.github.com/repos/Asalle/roc-go/branches{/branch}","tags_url":"https://api.github.com/repos/Asalle/roc-go/tags","blobs_url":"https://api.github.com/repos/Asalle/roc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Asalle/roc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Asalle/roc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/Asalle/roc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Asalle/roc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/Asalle/roc-go/languages","stargazers_url":"https://api.github.com/repos/Asalle/roc-go/stargazers","contributors_url":"https://api.github.com/repos/Asalle/roc-go/contributors","subscribers_url":"https://api.github.com/repos/Asalle/roc-go/subscribers","subscription_url":"https://api.github.com/repos/Asalle/roc-go/subscription","commits_url":"https://api.github.com/repos/Asalle/roc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/Asalle/roc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/Asalle/roc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/Asalle/roc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/Asalle/roc-go/contents/{+path}","compare_url":"https://api.github.com/repos/Asalle/roc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Asalle/roc-go/merges","archive_url":"https://api.github.com/repos/Asalle/roc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Asalle/roc-go/downloads","issues_url":"https://api.github.com/repos/Asalle/roc-go/issues{/number}","pulls_url":"https://api.github.com/repos/Asalle/roc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/Asalle/roc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/Asalle/roc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Asalle/roc-go/labels{/name}","releases_url":"https://api.github.com/repos/Asalle/roc-go/releases{/id}","deployments_url":"https://api.github.com/repos/Asalle/roc-go/deployments","created_at":"2019-10-13T12:14:38Z","updated_at":"2019-10-13T12:14:40Z","pushed_at":"2019-10-20T20:01:02Z","git_url":"git://github.com/Asalle/roc-go.git","ssh_url":"git@github.com:Asalle/roc-go.git","clone_url":"https://github.com/Asalle/roc-go.git","svn_url":"https://github.com/Asalle/roc-go","homepage":"","size":33,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roc-project:master","ref":"master","sha":"f5393fcf776461fc904322b26cadd0b407dfbc80","user":{"login":"roc-project","id":16302098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzAyMDk4","avatar_url":"https://avatars3.githubusercontent.com/u/16302098?v=4","gravatar_id":"","url":"https://api.github.com/users/roc-project","html_url":"https://github.com/roc-project","followers_url":"https://api.github.com/users/roc-project/followers","following_url":"https://api.github.com/users/roc-project/following{/other_user}","gists_url":"https://api.github.com/users/roc-project/gists{/gist_id}","starred_url":"https://api.github.com/users/roc-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roc-project/subscriptions","organizations_url":"https://api.github.com/users/roc-project/orgs","repos_url":"https://api.github.com/users/roc-project/repos","events_url":"https://api.github.com/users/roc-project/events{/privacy}","received_events_url":"https://api.github.com/users/roc-project/received_events","type":"Organization","site_admin":false},"repo":{"id":213385060,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMzODUwNjA=","name":"roc-go","full_name":"roc-project/roc-go","private":false,"owner":{"login":"roc-project","id":16302098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzAyMDk4","avatar_url":"https://avatars3.githubusercontent.com/u/16302098?v=4","gravatar_id":"","url":"https://api.github.com/users/roc-project","html_url":"https://github.com/roc-project","followers_url":"https://api.github.com/users/roc-project/followers","following_url":"https://api.github.com/users/roc-project/following{/other_user}","gists_url":"https://api.github.com/users/roc-project/gists{/gist_id}","starred_url":"https://api.github.com/users/roc-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roc-project/subscriptions","organizations_url":"https://api.github.com/users/roc-project/orgs","repos_url":"https://api.github.com/users/roc-project/repos","events_url":"https://api.github.com/users/roc-project/events{/privacy}","received_events_url":"https://api.github.com/users/roc-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/roc-project/roc-go","description":"Go bindings for Roc.","fork":false,"url":"https://api.github.com/repos/roc-project/roc-go","forks_url":"https://api.github.com/repos/roc-project/roc-go/forks","keys_url":"https://api.github.com/repos/roc-project/roc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roc-project/roc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roc-project/roc-go/teams","hooks_url":"https://api.github.com/repos/roc-project/roc-go/hooks","issue_events_url":"https://api.github.com/repos/roc-project/roc-go/issues/events{/number}","events_url":"https://api.github.com/repos/roc-project/roc-go/events","assignees_url":"https://api.github.com/repos/roc-project/roc-go/assignees{/user}","branches_url":"https://api.github.com/repos/roc-project/roc-go/branches{/branch}","tags_url":"https://api.github.com/repos/roc-project/roc-go/tags","blobs_url":"https://api.github.com/repos/roc-project/roc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roc-project/roc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roc-project/roc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/roc-project/roc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roc-project/roc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/roc-project/roc-go/languages","stargazers_url":"https://api.github.com/repos/roc-project/roc-go/stargazers","contributors_url":"https://api.github.com/repos/roc-project/roc-go/contributors","subscribers_url":"https://api.github.com/repos/roc-project/roc-go/subscribers","subscription_url":"https://api.github.com/repos/roc-project/roc-go/subscription","commits_url":"https://api.github.com/repos/roc-project/roc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/roc-project/roc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/roc-project/roc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/roc-project/roc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/roc-project/roc-go/contents/{+path}","compare_url":"https://api.github.com/repos/roc-project/roc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roc-project/roc-go/merges","archive_url":"https://api.github.com/repos/roc-project/roc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roc-project/roc-go/downloads","issues_url":"https://api.github.com/repos/roc-project/roc-go/issues{/number}","pulls_url":"https://api.github.com/repos/roc-project/roc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/roc-project/roc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/roc-project/roc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roc-project/roc-go/labels{/name}","releases_url":"https://api.github.com/repos/roc-project/roc-go/releases{/id}","deployments_url":"https://api.github.com/repos/roc-project/roc-go/deployments","created_at":"2019-10-07T13:05:00Z","updated_at":"2019-10-13T19:12:27Z","pushed_at":"2019-10-20T20:01:04Z","git_url":"git://github.com/roc-project/roc-go.git","ssh_url":"git@github.com:roc-project/roc-go.git","clone_url":"https://github.com/roc-project/roc-go.git","svn_url":"https://github.com/roc-project/roc-go","homepage":"","size":17,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roc-project/roc-go/pulls/1"},"html":{"href":"https://github.com/roc-project/roc-go/pull/1"},"issue":{"href":"https://api.github.com/repos/roc-project/roc-go/issues/1"},"comments":{"href":"https://api.github.com/repos/roc-project/roc-go/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/roc-project/roc-go/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/roc-project/roc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roc-project/roc-go/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/roc-project/roc-go/statuses/97d957063d1183cf28714fa3596da3b94262346a"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"Asalle"}}