payload: {"action":"closed","issue":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2584","repository_url":"https://api.github.com/repos/DivanteLtd/vue-storefront","labels_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2584/labels{/name}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2584/comments","events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2584/events","html_url":"https://github.com/DivanteLtd/vue-storefront/issues/2584","id":419958948,"node_id":"MDU6SXNzdWU0MTk5NTg5NDg=","number":2584,"title":"Confusing / overcomplicated calculations in cart","user":{"login":"ArturDivante","id":47415585,"node_id":"MDQ6VXNlcjQ3NDE1NTg1","avatar_url":"https://avatars3.githubusercontent.com/u/47415585?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturDivante","html_url":"https://github.com/ArturDivante","followers_url":"https://api.github.com/users/ArturDivante/followers","following_url":"https://api.github.com/users/ArturDivante/following{/other_user}","gists_url":"https://api.github.com/users/ArturDivante/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturDivante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturDivante/subscriptions","organizations_url":"https://api.github.com/users/ArturDivante/orgs","repos_url":"https://api.github.com/users/ArturDivante/repos","events_url":"https://api.github.com/users/ArturDivante/events{/privacy}","received_events_url":"https://api.github.com/users/ArturDivante/received_events","type":"User","site_admin":false},"labels":[{"id":1237005972,"node_id":"MDU6TGFiZWwxMjM3MDA1OTcy","url":"https://api.github.com/repos/DivanteLtd/vue-storefront/labels/RFC","name":"RFC","color":"8be8ae","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-03-12T12:27:53Z","updated_at":"2019-04-16T12:25:36Z","closed_at":"2019-04-16T12:25:36Z","author_association":"COLLABORATOR","body":"## Current behavior\r\nFew diffrent numbers / prices are presented to customer - they seem to be unrelated to each other\r\n\r\n## Expected behavior\r\nPrices are displayed in simple and understandable way\r\n\r\n## Steps to reproduce the issue\r\n1. Open https://demo.storefrontcloud.io/ or https://test.storefrontcloud.io/\r\n2. Add any product to cart\r\n3. Open cart\r\n\r\n![total](https://user-images.githubusercontent.com/47415585/54198967-0d5f2d00-44c8-11e9-9364-8cd3f8f866b7.PNG)\r\n\r\n\r\n## Analysis\r\nCurrently, prices displayed seem to be calculated in this way:\r\n\r\nNetto(net price) = price from magento (not displayed anywhere) - here its 40$\r\nShipping = 5$ (fixed)\r\nDiscount = Netto x 0.15 (15% cart discount set in Magento)\r\nTax = (Netto - Discount) x 0.23 (23% tax rate set in Magento)\r\nSubtotal (price displayed in PLP, PDP and cart) = Netto x 1.23\r\nRed (recuded price in cart) = Subtotal - Discount\r\nGrand Total = Netto + Tax + Shipping - Discount\r\n\r\n**Problem:** Currently, if discount is active, Subtotal and Red prices are misleading, as they are not used anywhere in final price calculation. While they are displayed in PLP, PDP and cart, they have nothing to do with final amount of money payed by customer.\r\n\r\n**Reason:** For the purpose of **Grand total** calculation, **Tax** is based on reduced price. However, for calculating Subtotal price, tax is added to full netto price.\r\n\r\n**Solution** Assuming all caculations are correct, we should consider diffrent set of displayed data (or description), so customer will always know how much he will pay and where are those numbers (i.e. tax and discount) coming from. \r\n"}}
other: {"actor":{"display_login":"pkarw"}}