payload: {"action":"created","comment":{"url":"https://api.github.com/repos/datamade/just-spaces/pulls/comments/273585098","pull_request_review_id":224526261,"id":273585098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzU4NTA5OA==","diff_hunk":"@@ -54,21 +54,27 @@ def run(self, form_entry, request, form, form_element_entries=None):\n             plugin_data = element.plugin_data\n             json_plugin_data = json.loads(plugin_data)\n \n-            name = json_plugin_data['name']\n-            label = json_plugin_data['label']\n-            type = element.plugin_uid\n-            position = element.position\n-\n-            saved_data = form.cleaned_data[name]\n-\n-            SurveyComponent.objects.create(\n-                row=new_survey_row,\n-                name=name,\n-                label=label,\n-                type=type,\n-                position=position,\n-                saved_data=saved_data\n-            )\n+            try:\n+                name = json_plugin_data['name']\n+\n+                label = json_plugin_data['label']\n+                type = element.plugin_uid\n+                position = element.position\n+\n+                saved_data = form.cleaned_data[name]\n+\n+                SurveyComponent.objects.create(\n+                    row=new_survey_row,\n+                    name=name,\n+                    label=label,\n+                    type=type,\n+                    position=position,\n+                    saved_data=saved_data\n+                )\n+\n+            # Help text elements have no name and should not be saved\n+            except KeyError:\n+                pass","path":"fobi_custom/plugins/form_handlers/collect_data/fobi_form_handlers.py","position":null,"original_position":39,"commit_id":"beff1f12cf93a40e0d620604193ba5e235f42843","original_commit_id":"07ec8005da7aa043f91166bf7b22fdea10b9da68","user":{"login":"beamalsky","id":1094243,"node_id":"MDQ6VXNlcjEwOTQyNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1094243?v=4","gravatar_id":"","url":"https://api.github.com/users/beamalsky","html_url":"https://github.com/beamalsky","followers_url":"https://api.github.com/users/beamalsky/followers","following_url":"https://api.github.com/users/beamalsky/following{/other_user}","gists_url":"https://api.github.com/users/beamalsky/gists{/gist_id}","starred_url":"https://api.github.com/users/beamalsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beamalsky/subscriptions","organizations_url":"https://api.github.com/users/beamalsky/orgs","repos_url":"https://api.github.com/users/beamalsky/repos","events_url":"https://api.github.com/users/beamalsky/events{/privacy}","received_events_url":"https://api.github.com/users/beamalsky/received_events","type":"User","site_admin":false},"body":"I see your reasoning! The only plugin data that `content_text` pass into the form is a `text` key, but that's the only element that has it. I've switched to checking for that!","created_at":"2019-04-09T16:47:47Z","updated_at":"2019-04-09T16:47:47Z","html_url":"https://github.com/datamade/just-spaces/pull/74#discussion_r273585098","pull_request_url":"https://api.github.com/repos/datamade/just-spaces/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/datamade/just-spaces/pulls/comments/273585098"},"html":{"href":"https://github.com/datamade/just-spaces/pull/74#discussion_r273585098"},"pull_request":{"href":"https://api.github.com/repos/datamade/just-spaces/pulls/74"}},"in_reply_to_id":273575437},"pull_request":{"url":"https://api.github.com/repos/datamade/just-spaces/pulls/74","id":268771763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4NzcxNzYz","html_url":"https://github.com/datamade/just-spaces/pull/74","diff_url":"https://github.com/datamade/just-spaces/pull/74.diff","patch_url":"https://github.com/datamade/just-spaces/pull/74.patch","issue_url":"https://api.github.com/repos/datamade/just-spaces/issues/74","number":74,"state":"open","locked":false,"title":"Bug fix for data handler name error (issue 73)","user":{"login":"beamalsky","id":1094243,"node_id":"MDQ6VXNlcjEwOTQyNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1094243?v=4","gravatar_id":"","url":"https://api.github.com/users/beamalsky","html_url":"https://github.com/beamalsky","followers_url":"https://api.github.com/users/beamalsky/followers","following_url":"https://api.github.com/users/beamalsky/following{/other_user}","gists_url":"https://api.github.com/users/beamalsky/gists{/gist_id}","starred_url":"https://api.github.com/users/beamalsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beamalsky/subscriptions","organizations_url":"https://api.github.com/users/beamalsky/orgs","repos_url":"https://api.github.com/users/beamalsky/repos","events_url":"https://api.github.com/users/beamalsky/events{/privacy}","received_events_url":"https://api.github.com/users/beamalsky/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nA fix for #73. This was simple! I hadn't realized that Fobi treats help text (`FormElementEntry with plugin_uid='context_text'`) as elements with no names, which needed to be handled in the data handler. I did that and added a test to make this easier to identify if it happens again. \r\n\r\nI also broke my tests into two separate files, which seems useful as they grow. The data handler test is giant but I'm not sure how to break it into smaller pieces without rerunning a bunch of code—@jeancochrane, I'd love to hear how you'd approach this. Are smaller tests worth the redundancy?\r\n\r\n## Testing Instructions\r\n\r\n * Run pytest!\r\n\r\nConnects #73 \r\n","created_at":"2019-04-09T14:45:04Z","updated_at":"2019-04-09T16:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5bb07c172e932e43e518e6634922f6fdd6aaacf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datamade/just-spaces/pulls/74/commits","review_comments_url":"https://api.github.com/repos/datamade/just-spaces/pulls/74/comments","review_comment_url":"https://api.github.com/repos/datamade/just-spaces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datamade/just-spaces/issues/74/comments","statuses_url":"https://api.github.com/repos/datamade/just-spaces/statuses/beff1f12cf93a40e0d620604193ba5e235f42843","head":{"label":"datamade:issue-73","ref":"issue-73","sha":"beff1f12cf93a40e0d620604193ba5e235f42843","user":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"repo":{"id":165309502,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUzMDk1MDI=","name":"just-spaces","full_name":"datamade/just-spaces","private":false,"owner":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datamade/just-spaces","description":"repository for the Just Spaces project","fork":false,"url":"https://api.github.com/repos/datamade/just-spaces","forks_url":"https://api.github.com/repos/datamade/just-spaces/forks","keys_url":"https://api.github.com/repos/datamade/just-spaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamade/just-spaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamade/just-spaces/teams","hooks_url":"https://api.github.com/repos/datamade/just-spaces/hooks","issue_events_url":"https://api.github.com/repos/datamade/just-spaces/issues/events{/number}","events_url":"https://api.github.com/repos/datamade/just-spaces/events","assignees_url":"https://api.github.com/repos/datamade/just-spaces/assignees{/user}","branches_url":"https://api.github.com/repos/datamade/just-spaces/branches{/branch}","tags_url":"https://api.github.com/repos/datamade/just-spaces/tags","blobs_url":"https://api.github.com/repos/datamade/just-spaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamade/just-spaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamade/just-spaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamade/just-spaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamade/just-spaces/statuses/{sha}","languages_url":"https://api.github.com/repos/datamade/just-spaces/languages","stargazers_url":"https://api.github.com/repos/datamade/just-spaces/stargazers","contributors_url":"https://api.github.com/repos/datamade/just-spaces/contributors","subscribers_url":"https://api.github.com/repos/datamade/just-spaces/subscribers","subscription_url":"https://api.github.com/repos/datamade/just-spaces/subscription","commits_url":"https://api.github.com/repos/datamade/just-spaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamade/just-spaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamade/just-spaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamade/just-spaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamade/just-spaces/contents/{+path}","compare_url":"https://api.github.com/repos/datamade/just-spaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamade/just-spaces/merges","archive_url":"https://api.github.com/repos/datamade/just-spaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamade/just-spaces/downloads","issues_url":"https://api.github.com/repos/datamade/just-spaces/issues{/number}","pulls_url":"https://api.github.com/repos/datamade/just-spaces/pulls{/number}","milestones_url":"https://api.github.com/repos/datamade/just-spaces/milestones{/number}","notifications_url":"https://api.github.com/repos/datamade/just-spaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamade/just-spaces/labels{/name}","releases_url":"https://api.github.com/repos/datamade/just-spaces/releases{/id}","deployments_url":"https://api.github.com/repos/datamade/just-spaces/deployments","created_at":"2019-01-11T21:03:55Z","updated_at":"2019-04-09T06:52:31Z","pushed_at":"2019-04-09T16:46:47Z","git_url":"git://github.com/datamade/just-spaces.git","ssh_url":"git@github.com:datamade/just-spaces.git","clone_url":"https://github.com/datamade/just-spaces.git","svn_url":"https://github.com/datamade/just-spaces","homepage":null,"size":648,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":21,"watchers":1,"default_branch":"master"}},"base":{"label":"datamade:surveys-submitted-detail","ref":"surveys-submitted-detail","sha":"cfa8968d34f1e4206a69f741c9dfcf821b1751e8","user":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"repo":{"id":165309502,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUzMDk1MDI=","name":"just-spaces","full_name":"datamade/just-spaces","private":false,"owner":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datamade/just-spaces","description":"repository for the Just Spaces project","fork":false,"url":"https://api.github.com/repos/datamade/just-spaces","forks_url":"https://api.github.com/repos/datamade/just-spaces/forks","keys_url":"https://api.github.com/repos/datamade/just-spaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamade/just-spaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamade/just-spaces/teams","hooks_url":"https://api.github.com/repos/datamade/just-spaces/hooks","issue_events_url":"https://api.github.com/repos/datamade/just-spaces/issues/events{/number}","events_url":"https://api.github.com/repos/datamade/just-spaces/events","assignees_url":"https://api.github.com/repos/datamade/just-spaces/assignees{/user}","branches_url":"https://api.github.com/repos/datamade/just-spaces/branches{/branch}","tags_url":"https://api.github.com/repos/datamade/just-spaces/tags","blobs_url":"https://api.github.com/repos/datamade/just-spaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamade/just-spaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamade/just-spaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamade/just-spaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamade/just-spaces/statuses/{sha}","languages_url":"https://api.github.com/repos/datamade/just-spaces/languages","stargazers_url":"https://api.github.com/repos/datamade/just-spaces/stargazers","contributors_url":"https://api.github.com/repos/datamade/just-spaces/contributors","subscribers_url":"https://api.github.com/repos/datamade/just-spaces/subscribers","subscription_url":"https://api.github.com/repos/datamade/just-spaces/subscription","commits_url":"https://api.github.com/repos/datamade/just-spaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamade/just-spaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamade/just-spaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamade/just-spaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamade/just-spaces/contents/{+path}","compare_url":"https://api.github.com/repos/datamade/just-spaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamade/just-spaces/merges","archive_url":"https://api.github.com/repos/datamade/just-spaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamade/just-spaces/downloads","issues_url":"https://api.github.com/repos/datamade/just-spaces/issues{/number}","pulls_url":"https://api.github.com/repos/datamade/just-spaces/pulls{/number}","milestones_url":"https://api.github.com/repos/datamade/just-spaces/milestones{/number}","notifications_url":"https://api.github.com/repos/datamade/just-spaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamade/just-spaces/labels{/name}","releases_url":"https://api.github.com/repos/datamade/just-spaces/releases{/id}","deployments_url":"https://api.github.com/repos/datamade/just-spaces/deployments","created_at":"2019-01-11T21:03:55Z","updated_at":"2019-04-09T06:52:31Z","pushed_at":"2019-04-09T16:46:47Z","git_url":"git://github.com/datamade/just-spaces.git","ssh_url":"git@github.com:datamade/just-spaces.git","clone_url":"https://github.com/datamade/just-spaces.git","svn_url":"https://github.com/datamade/just-spaces","homepage":null,"size":648,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":21,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datamade/just-spaces/pulls/74"},"html":{"href":"https://github.com/datamade/just-spaces/pull/74"},"issue":{"href":"https://api.github.com/repos/datamade/just-spaces/issues/74"},"comments":{"href":"https://api.github.com/repos/datamade/just-spaces/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/datamade/just-spaces/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/datamade/just-spaces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datamade/just-spaces/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/datamade/just-spaces/statuses/beff1f12cf93a40e0d620604193ba5e235f42843"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"beamalsky"}}