payload: {"push_id":3277570991,"size":25,"distinct_size":7,"ref":"refs/heads/181106-MakePhanMoreStrict","head":"d286e02c90bde17489ddc21b2a4460a897771ecd","before":"3beceaef370f720ba3030af54971fcaef442a2f0","commits":[{"sha":"e572cb87054ba9695857892917abc728fb6e636c","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Core: ConflictDetector] Add type declarations to function signatures (#4279)","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/e572cb87054ba9695857892917abc728fb6e636c"},{"sha":"2c72d5bcbc8170905d5e88ee886eb30025fb404b","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Testing] Add PhanTypeMismatchDefault rule to checks (#4265)\n\nFix the issues that were preventing PhanTypeMismatchDefault from being included in the phan rules.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/2c72d5bcbc8170905d5e88ee886eb30025fb404b"},{"sha":"18b052b536fb6bf10abb0f064a1a209fd2dad6e9","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Core] Add return types to Module class (#4234)\n\nThis adds return types to functions in the Module base class, except for isPublicModule(). Issue #4282 created for the latter.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/18b052b536fb6bf10abb0f064a1a209fd2dad6e9"},{"sha":"6f92f69ed52f0e9402890b775459d65516f11ae1","author":{"name":"David Blader","email":"3d1d8561607daaa49656a4fbbd5642fd81c6aa9b@gmail.com"},"message":"[Core: Candidate] Fix getFirstVisit method (#4075)\n\nUpdate query in Candidate getFirstVisit method to fix exception about using pselectRow on a query with multiple rows.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/6f92f69ed52f0e9402890b775459d65516f11ae1"},{"sha":"cfb46c75a053bed93119cd2e897f090bbf9ad50b","author":{"name":"cmadjar","email":"54278c12dc941dc62a9d42f322ab337b7aa93bd7@mcin.ca"},"message":"Rename candidate center id to registration center (#4078)\n\nUpdated the default schema and created a new patch for existing projects to rename candidate's CenterID to RegistrationCenterID.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/cfb46c75a053bed93119cd2e897f090bbf9ad50b"},{"sha":"51c73c1d73717f3ad509e2df78fb145b4c72e88c","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"Ignore htdocs/api in phan (#4283)\n\nThe htdocs/api directory is being converted to modules/api. There's no reason to analyze and fix the former which will shortly be removed, so this excluded the directory from analysis by phan.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/51c73c1d73717f3ad509e2df78fb145b4c72e88c"},{"sha":"71ca3c5288aefca87567d16bd67e57c74e2b93f9","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Core: MRIFile] Add type declarations to function signatures (#4278)","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/71ca3c5288aefca87567d16bd67e57c74e2b93f9"},{"sha":"c71b192605da6eba700b185144749e038d5c8297","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Imaging] Fix type errors in feedback pop-up/FeedbackMRI (#4285)\n\nFix type errors that were found on MRI Feedback popup after strong(er) typing was enabled.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/c71b192605da6eba700b185144749e038d5c8297"},{"sha":"353d5070b7a6fd6686edc9e78ae574cc0d6673d2","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Core] Add PhanUndeclaredTypeParameter rule to static analysis (#4274)\n\nAdd PhanUndeclaredTypeReturnType and PhanUndeclaredTypeParameter to the list of problems detected by phan under Travis.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/353d5070b7a6fd6686edc9e78ae574cc0d6673d2"},{"sha":"2a8d4689471dbe9fb3092f0960829b76c50b5d45","author":{"name":"Rida Abou-Haidar","email":"58e1424b9b513d92d36845826a2d7aaa804d329f@users.noreply.github.com"},"message":"[tools/Fix Candidate Age] Cleanup and bugfixes (#4141)\n\nMake sure to use the table name used by the instrument rather than the value in the test_names table.\r\nMove tool the the new directory structure.\r\nRefactor for readability.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/2a8d4689471dbe9fb3092f0960829b76c50b5d45"},{"sha":"f4812b9d297b077e933c20b6b824f1ae4c7a2e48","author":{"name":"Xavier Lecours","email":"92e69d357cf8539f0057990a56870b14f7004b55@mcin.ca"},"message":"[Core] Adding CandID Value Object (#4055)\n\nThis adds a CandID value object with unit test and a simple usage in the RestAPI.\r\n\r\nThe goal is to start using objects instead of array or scalar values to migrate towards a typed dependency injection pattern. This will facilitate unit tests and further developments.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/f4812b9d297b077e933c20b6b824f1ae4c7a2e48"},{"sha":"3a766b4a742eaa19cb8617e6312e38bbf1d40c05","author":{"name":"Liza Levitis","email":"3a4d388542a3fb1460f1d577659d227ef6e8d06e@mail.mcgill.ca"},"message":"[Modules] Add QC Module to LORIS (#4223)\n\nThis adds a QC Module to LORIS which combines the data_team_helper with imaging QC, in order to provide a single place for verifying the data integrity of a LORIS instance.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/3a766b4a742eaa19cb8617e6312e38bbf1d40c05"},{"sha":"04f92320b0e63d051f234ecc8bc72a3a9809c269","author":{"name":"Dave MacFarlane","email":"0458f94f48fa8917ec650c254640257a4748f4e2@gmail.com"},"message":"[phan] Add two rules that created no errors (#4291)\n\nThis enables the PhanRedefineClass and PhanRedefinedExtendedClass rules,\r\nwhich cause no errors but were still being ignored.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/04f92320b0e63d051f234ecc8bc72a3a9809c269"},{"sha":"8ff7ea46d2078f7ca7a5ef6c53e85c2465a020c5","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Testing] Add PhanTypeMismatchForeach rule to static analysis (#4266)\n\nAdd PhanTypeMismatchForeach rule to static analysis.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/8ff7ea46d2078f7ca7a5ef6c53e85c2465a020c5"},{"sha":"3a94dca32c019d040f23db989876d86b3a6c9f73","author":{"name":"Zaliqa","email":"1d910c7dd546eceb76cf11e2a8d4eeb54a7ad177@mcin.ca"},"message":"[Instrument_LINST] Fix XINValidate() return type error (#4280)\n\nFixes changes made in #4073 that now throws a return type error on major. XINValidate() shouldn't have a return type for now.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/3a94dca32c019d040f23db989876d86b3a6c9f73"},{"sha":"d562b22906cd570b7bd6545878dd7cc70ef5a7d5","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Instrument Manager] Add more specific permissions to instrument_manager (#4191)\n\nAdd instrument_manager_read and instrument_manager_write permissions to instrument manager module, in order to see what instruments are installed or to install a new one.\r\n\r\nPreviously, the superuser was required for both.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/d562b22906cd570b7bd6545878dd7cc70ef5a7d5"},{"sha":"fdac2c7e20c99f391fe1864a5d246fe641c9ec93","author":{"name":"John Saigle","email":"f797649377b60d6dcdbe95a35e09eef318cb5df3@users.noreply.github.com"},"message":"[Testing] Add PhanTypeVoidAssignment to static analysis (#4276)\n\nThis prevents variables being assigned to functions that are declared to return void.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/fdac2c7e20c99f391fe1864a5d246fe641c9ec93"},{"sha":"3ee9d0521e1a026a759245ea5aa0113843b408fc","author":{"name":"Dave MacFarlane","email":"0458f94f48fa8917ec650c254640257a4748f4e2@gmail.com"},"message":"[phan] Remove redeclaration of PHP internal getallheaders function (#4293)\n\nThis removes the intentional redeclaration of the PHP getallheaders\r\nfunction in SinglePointLogin.\r\n\r\nIt was previously required because getallheaders() only existed under\r\nApache. According to the PHP documentation (http://php.net/manual/en/function.getallheaders.php)\r\nit became available under the CLI server in PHP 5.5.7, so it should\r\nno longer be required for Travis or development purposes under\r\nsupported versions of PHP.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/3ee9d0521e1a026a759245ea5aa0113843b408fc"},{"sha":"bed06dc048b5bd70789aab48f8b5377351823f8e","author":{"name":"John Saigle","email":"2b97553b1f171383bc66d26abc13ad4e1175598e@gmail.com"},"message":"Make return types strict phan","distinct":true,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/bed06dc048b5bd70789aab48f8b5377351823f8e"},{"sha":"3f3b272f14ea9130f523bf8e0588b2dcbb47f7c9","author":{"name":"John Saigle","email":"2b97553b1f171383bc66d26abc13ad4e1175598e@gmail.com"},"message":"Fix new phan errors in api v0.0.3","distinct":true,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/3f3b272f14ea9130f523bf8e0588b2dcbb47f7c9"}]}
other: {"actor":{"display_login":"johnsaigle"}}