payload: {"action":"created","issue":{"url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/issues/18","repository_url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr","labels_url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/issues/18/comments","events_url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/issues/18/events","html_url":"https://github.com/matthijskooijman/arduino-dsmr/pull/18","id":376121011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDEwNjk4","number":18,"title":"Made verifying the checksum of a message optional","user":{"login":"fremouw","id":3299284,"node_id":"MDQ6VXNlcjMyOTkyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3299284?v=4","gravatar_id":"","url":"https://api.github.com/users/fremouw","html_url":"https://github.com/fremouw","followers_url":"https://api.github.com/users/fremouw/followers","following_url":"https://api.github.com/users/fremouw/following{/other_user}","gists_url":"https://api.github.com/users/fremouw/gists{/gist_id}","starred_url":"https://api.github.com/users/fremouw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fremouw/subscriptions","organizations_url":"https://api.github.com/users/fremouw/orgs","repos_url":"https://api.github.com/users/fremouw/repos","events_url":"https://api.github.com/users/fremouw/events{/privacy}","received_events_url":"https://api.github.com/users/fremouw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-31T19:15:02Z","updated_at":"2019-07-19T15:57:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/pulls/18","html_url":"https://github.com/matthijskooijman/arduino-dsmr/pull/18","diff_url":"https://github.com/matthijskooijman/arduino-dsmr/pull/18.diff","patch_url":"https://github.com/matthijskooijman/arduino-dsmr/pull/18.patch"},"body":"In the DSMR 3.0 spec there's no checksum value to verify a (P1) message, so a simple message could look like this,\r\n`/ISk5\\2ME382-1000\r\n\r\n1-0:1.8.1(000671.578*kWh)\r\n1-0:1.7.0(00.318*kW)\r\n!`\r\n\r\nI've mainly added an optional parameter to the parse function to not verify the checksum and added some if statements to not actually verify it. As it's optional it should not conflict with current code."},"comment":{"url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/issues/comments/513282634","html_url":"https://github.com/matthijskooijman/arduino-dsmr/pull/18#issuecomment-513282634","issue_url":"https://api.github.com/repos/matthijskooijman/arduino-dsmr/issues/18","id":513282634,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMzI4MjYzNA==","user":{"login":"mrWheel","id":5585427,"node_id":"MDQ6VXNlcjU1ODU0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5585427?v=4","gravatar_id":"","url":"https://api.github.com/users/mrWheel","html_url":"https://github.com/mrWheel","followers_url":"https://api.github.com/users/mrWheel/followers","following_url":"https://api.github.com/users/mrWheel/following{/other_user}","gists_url":"https://api.github.com/users/mrWheel/gists{/gist_id}","starred_url":"https://api.github.com/users/mrWheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrWheel/subscriptions","organizations_url":"https://api.github.com/users/mrWheel/orgs","repos_url":"https://api.github.com/users/mrWheel/repos","events_url":"https://api.github.com/users/mrWheel/events{/privacy}","received_events_url":"https://api.github.com/users/mrWheel/received_events","type":"User","site_admin":false},"created_at":"2019-07-19T15:57:59Z","updated_at":"2019-07-19T15:57:59Z","author_association":"NONE","body":"Matthijs,\r\nFor a builder of my DSMR-logger I also need a way to escape the CRC. \r\nIs there any plan (any time soon) you will merge this into the master branche?"}}
other: {"actor":{"display_login":"mrWheel"}}