payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/335720989","pull_request_review_id":302892969,"id":335720989,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTcyMDk4OQ==","diff_hunk":"@@ -34,6 +41,6 @@ public class KeyCreateOptions\n         /// <summary>\n         /// A dictionary of tags with specific metadata about the key.\n         /// </summary>\n-        public IDictionary<string, string> Tags { get; private set; } = new Dictionary<string, string>();\n+        public IDictionary<string, string> Tags { get; } = new Dictionary<string, string>();","path":"sdk/keyvault/Azure.Security.KeyVault.Keys/src/CreateKeyOptions.cs","position":31,"original_position":31,"commit_id":"d90e52f3c8ae89f00099b91ea770ce20ff04c15d","original_commit_id":"d90e52f3c8ae89f00099b91ea770ce20ff04c15d","user":{"login":"heaths","id":1532486,"node_id":"MDQ6VXNlcjE1MzI0ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1532486?v=4","gravatar_id":"","url":"https://api.github.com/users/heaths","html_url":"https://github.com/heaths","followers_url":"https://api.github.com/users/heaths/followers","following_url":"https://api.github.com/users/heaths/following{/other_user}","gists_url":"https://api.github.com/users/heaths/gists{/gist_id}","starred_url":"https://api.github.com/users/heaths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heaths/subscriptions","organizations_url":"https://api.github.com/users/heaths/orgs","repos_url":"https://api.github.com/users/heaths/repos","events_url":"https://api.github.com/users/heaths/events{/privacy}","received_events_url":"https://api.github.com/users/heaths/received_events","type":"User","site_admin":false},"body":"The `KeyRequestParameters` made a copy, and did check the `Count`. That said, even making a copy if empty doesn't make sense, though I'm not even sure why the code is making a copy now. Partial immutability in multi-threaded scenarios, perhaps?\r\n\r\nI also fixed `KeyOperations` similarly. Makes me wonder if we're not providing enough coverage to make sure we're not zero'ing out tags and/or ops. I'll open a bug.","created_at":"2019-10-16T21:37:48Z","updated_at":"2019-10-16T21:37:48Z","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/8131#discussion_r335720989","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/335720989"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/8131#discussion_r335720989"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131"}},"in_reply_to_id":335308802},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131","id":328516042,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NTE2MDQy","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/8131","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/8131.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/8131.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/8131","number":8131,"state":"open","locked":false,"title":"Refactor KeyVault Keys and Secrets from reviews","user":{"login":"heaths","id":1532486,"node_id":"MDQ6VXNlcjE1MzI0ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1532486?v=4","gravatar_id":"","url":"https://api.github.com/users/heaths","html_url":"https://github.com/heaths","followers_url":"https://api.github.com/users/heaths/followers","following_url":"https://api.github.com/users/heaths/following{/other_user}","gists_url":"https://api.github.com/users/heaths/gists{/gist_id}","starred_url":"https://api.github.com/users/heaths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heaths/subscriptions","organizations_url":"https://api.github.com/users/heaths/orgs","repos_url":"https://api.github.com/users/heaths/repos","events_url":"https://api.github.com/users/heaths/events{/privacy}","received_events_url":"https://api.github.com/users/heaths/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-16T00:13:42Z","updated_at":"2019-10-16T21:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e98c30e2b8fc9a50e0467f655a40301034647f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1178447860,"node_id":"MDU6TGFiZWwxMTc4NDQ3ODYw","url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels/Client","name":"Client","color":"ffeb77","default":false},{"id":186911491,"node_id":"MDU6TGFiZWwxODY5MTE0OTE=","url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels/KeyVault","name":"KeyVault","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/8131/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/d90e52f3c8ae89f00099b91ea770ce20ff04c15d","head":{"label":"heaths:post-review","ref":"post-review","sha":"d90e52f3c8ae89f00099b91ea770ce20ff04c15d","user":{"login":"heaths","id":1532486,"node_id":"MDQ6VXNlcjE1MzI0ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1532486?v=4","gravatar_id":"","url":"https://api.github.com/users/heaths","html_url":"https://github.com/heaths","followers_url":"https://api.github.com/users/heaths/followers","following_url":"https://api.github.com/users/heaths/following{/other_user}","gists_url":"https://api.github.com/users/heaths/gists{/gist_id}","starred_url":"https://api.github.com/users/heaths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heaths/subscriptions","organizations_url":"https://api.github.com/users/heaths/orgs","repos_url":"https://api.github.com/users/heaths/repos","events_url":"https://api.github.com/users/heaths/events{/privacy}","received_events_url":"https://api.github.com/users/heaths/received_events","type":"User","site_admin":false},"repo":{"id":204757090,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ3NTcwOTA=","name":"azure-sdk-for-net","full_name":"heaths/azure-sdk-for-net","private":false,"owner":{"login":"heaths","id":1532486,"node_id":"MDQ6VXNlcjE1MzI0ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1532486?v=4","gravatar_id":"","url":"https://api.github.com/users/heaths","html_url":"https://github.com/heaths","followers_url":"https://api.github.com/users/heaths/followers","following_url":"https://api.github.com/users/heaths/following{/other_user}","gists_url":"https://api.github.com/users/heaths/gists{/gist_id}","starred_url":"https://api.github.com/users/heaths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heaths/subscriptions","organizations_url":"https://api.github.com/users/heaths/orgs","repos_url":"https://api.github.com/users/heaths/repos","events_url":"https://api.github.com/users/heaths/events{/privacy}","received_events_url":"https://api.github.com/users/heaths/received_events","type":"User","site_admin":false},"html_url":"https://github.com/heaths/azure-sdk-for-net","description":"Microsoft Azure SDK for .NET","fork":true,"url":"https://api.github.com/repos/heaths/azure-sdk-for-net","forks_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/heaths/azure-sdk-for-net/deployments","created_at":"2019-08-27T17:41:28Z","updated_at":"2019-10-14T21:00:01Z","pushed_at":"2019-10-16T20:39:39Z","git_url":"git://github.com/heaths/azure-sdk-for-net.git","ssh_url":"git@github.com:heaths/azure-sdk-for-net.git","clone_url":"https://github.com/heaths/azure-sdk-for-net.git","svn_url":"https://github.com/heaths/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":703312,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"6e9f8303d4f9c2b5e88230b7efdcd384b9903aed","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4OTQ0","name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-net","description":"Microsoft Azure SDK for .NET","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2019-10-16T21:01:19Z","pushed_at":"2019-10-16T21:34:05Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"git@github.com:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":705339,"stargazers_count":1486,"watchers_count":1486,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1569,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":621,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1569,"open_issues":621,"watchers":1486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/8131"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/8131"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/8131/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/8131/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/d90e52f3c8ae89f00099b91ea770ce20ff04c15d"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"heaths"}}