payload: {"action":"created","issue":{"url":"https://api.github.com/repos/react-boilerplate/react-boilerplate/issues/2750","repository_url":"https://api.github.com/repos/react-boilerplate/react-boilerplate","labels_url":"https://api.github.com/repos/react-boilerplate/react-boilerplate/issues/2750/labels{/name}","comments_url":"https://api.github.com/repos/react-boilerplate/react-boilerplate/issues/2750/comments","events_url":"https://api.github.com/repos/react-boilerplate/react-boilerplate/issues/2750/events","html_url":"https://github.com/react-boilerplate/react-boilerplate/issues/2750","id":496166568,"node_id":"MDU6SXNzdWU0OTYxNjY1Njg=","number":2750,"title":"Offline behaviour discussion","user":{"login":"jchapelle","id":6162013,"node_id":"MDQ6VXNlcjYxNjIwMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/6162013?v=4","gravatar_id":"","url":"https://api.github.com/users/jchapelle","html_url":"https://github.com/jchapelle","followers_url":"https://api.github.com/users/jchapelle/followers","following_url":"https://api.github.com/users/jchapelle/following{/other_user}","gists_url":"https://api.github.com/users/jchapelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jchapelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchapelle/subscriptions","organizations_url":"https://api.github.com/users/jchapelle/orgs","repos_url":"https://api.github.com/users/jchapelle/repos","events_url":"https://api.github.com/users/jchapelle/events{/privacy}","received_events_url":"https://api.github.com/users/jchapelle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2019-09-20T06:14:53Z","updated_at":"2019-09-23T16:47:25Z","closed_at":null,"author_association":"NONE","body":"**Describe the solution you'd like**\r\nGuys, it seems the offline configuration of the boilerplate is not working as expected : \r\n1. Buggy app can be cached by service worker and served by your browser even if you deploy a new version (see [this](https://github.com/react-boilerplate/react-boilerplate/issues/2744) for more explanations)\r\n2. Version V of an app can be cached by service worker and served by your browser even if you deploy a new version V+1\r\n3. Lazy loading of module is not compatible with offline mode (if error are not handled properly or if all the scripts are not prefetched) - (see [this](https://github.com/react-boilerplate/react-boilerplate/issues/2745) for more explanations)\r\n\r\nCould you please describe the behaviour you would like ? From that point, I can implement a new version of sw or contact the backers of OfflinePlugin to find the proper configuration (which I already began to do in this [this](https://github.com/NekR/offline-plugin/issues/463), [this](https://github.com/NekR/offline-plugin/issues/464) and [this](https://github.com/NekR/offline-plugin/issues/465).\r\n\r\nHere is my personal feeling : \r\n1. I would like all script to be prefetched. This would allow the app to work properly in offline mode and usage of lazy load\r\n2. I would like an general error boundary to catch errors at the top level of the app. This is smoother than having a blank screen when we have rendering error (which occurs when a script is lazy loaded and we have no network connection).\r\n3. I would like the index.html file to not be cached by service worker. This would allow to load the last version of a deployed app, even if a previous has been cached by sw and sw are not deactivated\r\n4. Finally, I would like a mechanism to detect new deployment and reload the app as soon as a ew vresion has been deployed. This is a bit out of scope but I think this mechanism is very important with spa and CI/CD way of working"},"comment":{"url":"https://api.github.com/repos/react-boilerplate/react-boilerplate/issues/comments/534184808","html_url":"https://github.com/react-boilerplate/react-boilerplate/issues/2750#issuecomment-534184808","issue_url":"https://api.github.com/repos/react-boilerplate/react-boilerplate/issues/2750","id":534184808,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDE4NDgwOA==","user":{"login":"jeffyamada","id":507278,"node_id":"MDQ6VXNlcjUwNzI3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/507278?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffyamada","html_url":"https://github.com/jeffyamada","followers_url":"https://api.github.com/users/jeffyamada/followers","following_url":"https://api.github.com/users/jeffyamada/following{/other_user}","gists_url":"https://api.github.com/users/jeffyamada/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffyamada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffyamada/subscriptions","organizations_url":"https://api.github.com/users/jeffyamada/orgs","repos_url":"https://api.github.com/users/jeffyamada/repos","events_url":"https://api.github.com/users/jeffyamada/events{/privacy}","received_events_url":"https://api.github.com/users/jeffyamada/received_events","type":"User","site_admin":false},"created_at":"2019-09-23T16:47:25Z","updated_at":"2019-09-23T16:47:25Z","author_association":"NONE","body":"Yeah. That seems wise. I haven't had time to dig into this as deeply as I'd like, but oddly we've never had major issues with it in the past, nor really heard users complain that the site wasn't refreshing or updating etc. My hunch right now is that in the more recent versions or updates when we're deploying fresh versions of our RBP site it's not auto refreshing. Sorry if my understanding of all this sounds vague, I've spent more time tinkering and not enough pouring through release notes."}}
other: {"actor":{"display_login":"jeffyamada"}}