payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/281447680","pull_request_review_id":234290848,"id":281447680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTQ0NzY4MA==","diff_hunk":"@@ -0,0 +1,81 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.table.api;\n+\n+import org.apache.flink.configuration.Configuration;\n+import org.apache.flink.configuration.GlobalConfiguration;\n+import org.apache.flink.table.calcite.CalciteConfig;\n+import org.apache.flink.table.calcite.CalciteConfig$;\n+import org.apache.flink.util.Preconditions;\n+\n+/**\n+ * The {@link PlannerConfigImpl} holds parameters to configure the behavior of Blink planner.\n+ */\n+public class PlannerConfigImpl implements PlannerConfig {\n+\n+\t/**\n+\t * Defines the configuration of Calcite for Blink planner.\n+\t */\n+\tprivate CalciteConfig calciteConfig = CalciteConfig$.MODULE$.DEFAULT();\n+\n+\t/**\n+\t * Defines planner defined configuration for Blink planner.\n+\t */\n+\tprivate Configuration conf = GlobalConfiguration.loadConfiguration();\n+\n+\t/**\n+\t * Returns planner defined configuration for Blink planner.\n+\t */\n+\tpublic Configuration getConf() {\n+\t\treturn conf;\n+\t}\n+\n+\t/**\n+\t * Sets planner defined configuration for Blink planner.\n+\t */\n+\tpublic void setConf(Configuration conf) {\n+\t\tthis.conf = GlobalConfiguration.loadConfiguration();\n+\t\tthis.conf.addAll(conf);\n+\t}\n+\n+\t/**\n+\t * Returns the configuration of Calcite for Blink planner.\n+\t */\n+\tpublic CalciteConfig getCalciteConfig() {\n+\t\treturn calciteConfig;\n+\t}\n+\n+\tpublic void setCalciteConfig(CalciteConfig calciteConfig) {\n+\t\tthis.calciteConfig = Preconditions.checkNotNull(calciteConfig);\n+\t}\n+\n+\tpublic static PlannerConfigImpl getDefault() {\n+\t\treturn new PlannerConfigImpl();","path":"flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/PlannerConfigImpl.java","position":69,"original_position":69,"commit_id":"f0f50f9dcb91e9cead86d383ac197cf74d11805c","original_commit_id":"f0f50f9dcb91e9cead86d383ac197cf74d11805c","user":{"login":"KurtYoung","id":955396,"node_id":"MDQ6VXNlcjk1NTM5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/955396?v=4","gravatar_id":"","url":"https://api.github.com/users/KurtYoung","html_url":"https://github.com/KurtYoung","followers_url":"https://api.github.com/users/KurtYoung/followers","following_url":"https://api.github.com/users/KurtYoung/following{/other_user}","gists_url":"https://api.github.com/users/KurtYoung/gists{/gist_id}","starred_url":"https://api.github.com/users/KurtYoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurtYoung/subscriptions","organizations_url":"https://api.github.com/users/KurtYoung/orgs","repos_url":"https://api.github.com/users/KurtYoung/repos","events_url":"https://api.github.com/users/KurtYoung/events{/privacy}","received_events_url":"https://api.github.com/users/KurtYoung/received_events","type":"User","site_admin":false},"body":"I'm not sure if this is useful, and not sure what's the purpose of this API. Do you want to letting everyone reuse the same default instance? Or it's just another way to construct this class? ","created_at":"2019-05-07T03:18:00Z","updated_at":"2019-05-07T03:43:52Z","html_url":"https://github.com/apache/flink/pull/8294#discussion_r281447680","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/8294","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/281447680"},"html":{"href":"https://github.com/apache/flink/pull/8294#discussion_r281447680"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/8294"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/8294","id":274146040,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MTQ2MDQw","html_url":"https://github.com/apache/flink/pull/8294","diff_url":"https://github.com/apache/flink/pull/8294.diff","patch_url":"https://github.com/apache/flink/pull/8294.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/8294","number":8294,"state":"open","locked":false,"title":"[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.","user":{"login":"beyond1920","id":1525333,"node_id":"MDQ6VXNlcjE1MjUzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1525333?v=4","gravatar_id":"","url":"https://api.github.com/users/beyond1920","html_url":"https://github.com/beyond1920","followers_url":"https://api.github.com/users/beyond1920/followers","following_url":"https://api.github.com/users/beyond1920/following{/other_user}","gists_url":"https://api.github.com/users/beyond1920/gists{/gist_id}","starred_url":"https://api.github.com/users/beyond1920/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyond1920/subscriptions","organizations_url":"https://api.github.com/users/beyond1920/orgs","repos_url":"https://api.github.com/users/beyond1920/repos","events_url":"https://api.github.com/users/beyond1920/events{/privacy}","received_events_url":"https://api.github.com/users/beyond1920/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nSince TableConfig already moved to API module in [FLINK-11067](https://issues.apache.org/jira/browse/FLINK-11067), TableConfig in blink-planner-module should not exist anymore.  The pr aims to remove TableConfig in blink-planner module, use TableConfig in api module instead.\r\n\r\n## Brief change log\r\n  - Remove `TableConfig` in blink-planner module.\r\n  - Introduce `PlannerConfigImpl` in blink-planner module. `PlannerConfigImpl` implements interface `PlannerConfig`.  It represents specified `plannerConfig` for Blink planner.\r\n  - Move static methods in removed `TableConfig` to `ConfigurationUtils.`\r\n  - Rename `PlannerConfigOptions` to `OptimizerConfigOptions`since the word `planner` in original name is confused with the word in `PlannerConfigImpl`.\r\n\r\n## Verifying this change\r\nThis change is already covered by existing tests.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (no)\r\n","created_at":"2019-04-28T02:32:19Z","updated_at":"2019-05-07T03:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e691c3bbf5ae9d973128b1885a7fed8678eb783f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1289893384,"node_id":"MDU6TGFiZWwxMjg5ODkzMzg0","url":"https://api.github.com/repos/apache/flink/labels/component=TableSQL/API","name":"component=TableSQL/API","color":"175fb7","default":false},{"id":1244454690,"node_id":"MDU6TGFiZWwxMjQ0NDU0Njkw","url":"https://api.github.com/repos/apache/flink/labels/review=description?","name":"review=description?","color":"bcf5db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/8294/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/8294/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/8294/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/f0f50f9dcb91e9cead86d383ac197cf74d11805c","head":{"label":"beyond1920:tableConfig","ref":"tableConfig","sha":"f0f50f9dcb91e9cead86d383ac197cf74d11805c","user":{"login":"beyond1920","id":1525333,"node_id":"MDQ6VXNlcjE1MjUzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1525333?v=4","gravatar_id":"","url":"https://api.github.com/users/beyond1920","html_url":"https://github.com/beyond1920","followers_url":"https://api.github.com/users/beyond1920/followers","following_url":"https://api.github.com/users/beyond1920/following{/other_user}","gists_url":"https://api.github.com/users/beyond1920/gists{/gist_id}","starred_url":"https://api.github.com/users/beyond1920/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyond1920/subscriptions","organizations_url":"https://api.github.com/users/beyond1920/orgs","repos_url":"https://api.github.com/users/beyond1920/repos","events_url":"https://api.github.com/users/beyond1920/events{/privacy}","received_events_url":"https://api.github.com/users/beyond1920/received_events","type":"User","site_admin":false},"repo":{"id":65457753,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQ1Nzc1Mw==","name":"flink","full_name":"beyond1920/flink","private":false,"owner":{"login":"beyond1920","id":1525333,"node_id":"MDQ6VXNlcjE1MjUzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1525333?v=4","gravatar_id":"","url":"https://api.github.com/users/beyond1920","html_url":"https://github.com/beyond1920","followers_url":"https://api.github.com/users/beyond1920/followers","following_url":"https://api.github.com/users/beyond1920/following{/other_user}","gists_url":"https://api.github.com/users/beyond1920/gists{/gist_id}","starred_url":"https://api.github.com/users/beyond1920/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyond1920/subscriptions","organizations_url":"https://api.github.com/users/beyond1920/orgs","repos_url":"https://api.github.com/users/beyond1920/repos","events_url":"https://api.github.com/users/beyond1920/events{/privacy}","received_events_url":"https://api.github.com/users/beyond1920/received_events","type":"User","site_admin":false},"html_url":"https://github.com/beyond1920/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/beyond1920/flink","forks_url":"https://api.github.com/repos/beyond1920/flink/forks","keys_url":"https://api.github.com/repos/beyond1920/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beyond1920/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beyond1920/flink/teams","hooks_url":"https://api.github.com/repos/beyond1920/flink/hooks","issue_events_url":"https://api.github.com/repos/beyond1920/flink/issues/events{/number}","events_url":"https://api.github.com/repos/beyond1920/flink/events","assignees_url":"https://api.github.com/repos/beyond1920/flink/assignees{/user}","branches_url":"https://api.github.com/repos/beyond1920/flink/branches{/branch}","tags_url":"https://api.github.com/repos/beyond1920/flink/tags","blobs_url":"https://api.github.com/repos/beyond1920/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beyond1920/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beyond1920/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/beyond1920/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beyond1920/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/beyond1920/flink/languages","stargazers_url":"https://api.github.com/repos/beyond1920/flink/stargazers","contributors_url":"https://api.github.com/repos/beyond1920/flink/contributors","subscribers_url":"https://api.github.com/repos/beyond1920/flink/subscribers","subscription_url":"https://api.github.com/repos/beyond1920/flink/subscription","commits_url":"https://api.github.com/repos/beyond1920/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/beyond1920/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/beyond1920/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/beyond1920/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/beyond1920/flink/contents/{+path}","compare_url":"https://api.github.com/repos/beyond1920/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beyond1920/flink/merges","archive_url":"https://api.github.com/repos/beyond1920/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beyond1920/flink/downloads","issues_url":"https://api.github.com/repos/beyond1920/flink/issues{/number}","pulls_url":"https://api.github.com/repos/beyond1920/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/beyond1920/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/beyond1920/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beyond1920/flink/labels{/name}","releases_url":"https://api.github.com/repos/beyond1920/flink/releases{/id}","deployments_url":"https://api.github.com/repos/beyond1920/flink/deployments","created_at":"2016-08-11T09:39:16Z","updated_at":"2019-03-26T07:27:27Z","pushed_at":"2019-04-30T08:58:59Z","git_url":"git://github.com/beyond1920/flink.git","ssh_url":"git@github.com:beyond1920/flink.git","clone_url":"https://github.com/beyond1920/flink.git","svn_url":"https://github.com/beyond1920/flink","homepage":null,"size":173636,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"39d82368eca3891d27c85dd9bc56db2344ee73ba","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2019-05-07T02:48:08Z","pushed_at":"2019-05-07T02:14:50Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":237950,"stargazers_count":8574,"watchers_count":8574,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4513,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":424,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4513,"open_issues":424,"watchers":8574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/8294"},"html":{"href":"https://github.com/apache/flink/pull/8294"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/8294"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/8294/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/8294/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/8294/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/f0f50f9dcb91e9cead86d383ac197cf74d11805c"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"KurtYoung"}}