payload: {"action":"opened","number":1747,"pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/1747","id":290291717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwMjkxNzE3","html_url":"https://github.com/amethyst/amethyst/pull/1747","diff_url":"https://github.com/amethyst/amethyst/pull/1747.diff","patch_url":"https://github.com/amethyst/amethyst/pull/1747.patch","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/1747","number":1747,"state":"open","locked":false,"title":"[BREAKING] Removes Float newtype and reverts to f32 everywhere (And clippy while I'm here)","user":{"login":"jaynus","id":2880909,"node_id":"MDQ6VXNlcjI4ODA5MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2880909?v=4","gravatar_id":"","url":"https://api.github.com/users/jaynus","html_url":"https://github.com/jaynus","followers_url":"https://api.github.com/users/jaynus/followers","following_url":"https://api.github.com/users/jaynus/following{/other_user}","gists_url":"https://api.github.com/users/jaynus/gists{/gist_id}","starred_url":"https://api.github.com/users/jaynus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaynus/subscriptions","organizations_url":"https://api.github.com/users/jaynus/orgs","repos_url":"https://api.github.com/users/jaynus/repos","events_url":"https://api.github.com/users/jaynus/events{/privacy}","received_events_url":"https://api.github.com/users/jaynus/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nPLACEHOLDER\r\n\r\nThis also makes subcrates clippy passing for clippy::all lints. Because this pass already touches so much, I figured it was worth the effort\r\n\r\nFixes #1744 \r\n\r\n## Additions\r\n\r\n## Removals\r\n\r\n- Float newtype\r\n\r\n## Modifications\r\n\r\n- Changes `DisplayConfig::to_window_builder` to `DisplayConfig::into_window_builder`\r\n- Float -> f32 everywhere\r\n- Changes all f64 in amethyst_input to be f32, and downcasts the appropriate f64's from winit. This is uniformity across the engine, at the loss of some precision. \r\n\r\n## PR Checklist\r\n\r\nBy placing an x in the boxes I certify that I have:\r\n\r\n- [ ] Ran `cargo test --all` locally if this modified any rs files.\r\n- [ ] Ran `cargo +stable fmt --all` locally if this modified any rs files.\r\n- [ ] Updated the content of the book if this PR would make the book outdated.\r\n- [ ] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment.\r\n- [ ] Added unit tests for new APIs if any were added in this PR.\r\n- [ ] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.\r\n","created_at":"2019-06-20T16:34:55Z","updated_at":"2019-06-20T16:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/amethyst/amethyst/pulls/1747/commits","review_comments_url":"https://api.github.com/repos/amethyst/amethyst/pulls/1747/comments","review_comment_url":"https://api.github.com/repos/amethyst/amethyst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/1747/comments","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/f8454375bae8984264301d738aa9d49a2feee8a2","head":{"label":"amethyst:float_erg","ref":"float_erg","sha":"f8454375bae8984264301d738aa9d49a2feee8a2","user":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"repo":{"id":48364554,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM2NDU1NA==","name":"amethyst","full_name":"amethyst/amethyst","private":false,"owner":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/amethyst/amethyst","description":"Data-oriented and data-driven game engine written in Rust","fork":false,"url":"https://api.github.com/repos/amethyst/amethyst","forks_url":"https://api.github.com/repos/amethyst/amethyst/forks","keys_url":"https://api.github.com/repos/amethyst/amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amethyst/amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amethyst/amethyst/teams","hooks_url":"https://api.github.com/repos/amethyst/amethyst/hooks","issue_events_url":"https://api.github.com/repos/amethyst/amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/amethyst/amethyst/events","assignees_url":"https://api.github.com/repos/amethyst/amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/amethyst/amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/amethyst/amethyst/tags","blobs_url":"https://api.github.com/repos/amethyst/amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amethyst/amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amethyst/amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/amethyst/amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/amethyst/amethyst/languages","stargazers_url":"https://api.github.com/repos/amethyst/amethyst/stargazers","contributors_url":"https://api.github.com/repos/amethyst/amethyst/contributors","subscribers_url":"https://api.github.com/repos/amethyst/amethyst/subscribers","subscription_url":"https://api.github.com/repos/amethyst/amethyst/subscription","commits_url":"https://api.github.com/repos/amethyst/amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/amethyst/amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/amethyst/amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/amethyst/amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/amethyst/amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/amethyst/amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amethyst/amethyst/merges","archive_url":"https://api.github.com/repos/amethyst/amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amethyst/amethyst/downloads","issues_url":"https://api.github.com/repos/amethyst/amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/amethyst/amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/amethyst/amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/amethyst/amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amethyst/amethyst/labels{/name}","releases_url":"https://api.github.com/repos/amethyst/amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/amethyst/amethyst/deployments","created_at":"2015-12-21T09:59:29Z","updated_at":"2019-06-20T13:26:46Z","pushed_at":"2019-06-20T16:32:07Z","git_url":"git://github.com/amethyst/amethyst.git","ssh_url":"git@github.com:amethyst/amethyst.git","clone_url":"https://github.com/amethyst/amethyst.git","svn_url":"https://github.com/amethyst/amethyst","homepage":"https://amethyst.rs/","size":38355,"stargazers_count":3647,"watchers_count":3647,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":400,"open_issues":72,"watchers":3647,"default_branch":"master"}},"base":{"label":"amethyst:master","ref":"master","sha":"c16c15286d60c094dfff55968d459a7ba90a16e4","user":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"repo":{"id":48364554,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM2NDU1NA==","name":"amethyst","full_name":"amethyst/amethyst","private":false,"owner":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/amethyst/amethyst","description":"Data-oriented and data-driven game engine written in Rust","fork":false,"url":"https://api.github.com/repos/amethyst/amethyst","forks_url":"https://api.github.com/repos/amethyst/amethyst/forks","keys_url":"https://api.github.com/repos/amethyst/amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amethyst/amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amethyst/amethyst/teams","hooks_url":"https://api.github.com/repos/amethyst/amethyst/hooks","issue_events_url":"https://api.github.com/repos/amethyst/amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/amethyst/amethyst/events","assignees_url":"https://api.github.com/repos/amethyst/amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/amethyst/amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/amethyst/amethyst/tags","blobs_url":"https://api.github.com/repos/amethyst/amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amethyst/amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amethyst/amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/amethyst/amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/amethyst/amethyst/languages","stargazers_url":"https://api.github.com/repos/amethyst/amethyst/stargazers","contributors_url":"https://api.github.com/repos/amethyst/amethyst/contributors","subscribers_url":"https://api.github.com/repos/amethyst/amethyst/subscribers","subscription_url":"https://api.github.com/repos/amethyst/amethyst/subscription","commits_url":"https://api.github.com/repos/amethyst/amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/amethyst/amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/amethyst/amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/amethyst/amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/amethyst/amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/amethyst/amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amethyst/amethyst/merges","archive_url":"https://api.github.com/repos/amethyst/amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amethyst/amethyst/downloads","issues_url":"https://api.github.com/repos/amethyst/amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/amethyst/amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/amethyst/amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/amethyst/amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amethyst/amethyst/labels{/name}","releases_url":"https://api.github.com/repos/amethyst/amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/amethyst/amethyst/deployments","created_at":"2015-12-21T09:59:29Z","updated_at":"2019-06-20T13:26:46Z","pushed_at":"2019-06-20T16:32:07Z","git_url":"git://github.com/amethyst/amethyst.git","ssh_url":"git@github.com:amethyst/amethyst.git","clone_url":"https://github.com/amethyst/amethyst.git","svn_url":"https://github.com/amethyst/amethyst","homepage":"https://amethyst.rs/","size":38355,"stargazers_count":3647,"watchers_count":3647,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":400,"open_issues":72,"watchers":3647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/1747"},"html":{"href":"https://github.com/amethyst/amethyst/pull/1747"},"issue":{"href":"https://api.github.com/repos/amethyst/amethyst/issues/1747"},"comments":{"href":"https://api.github.com/repos/amethyst/amethyst/issues/1747/comments"},"review_comments":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/1747/comments"},"review_comment":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/1747/commits"},"statuses":{"href":"https://api.github.com/repos/amethyst/amethyst/statuses/f8454375bae8984264301d738aa9d49a2feee8a2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":427,"deletions":464,"changed_files":45}}
other: {"actor":{"display_login":"jaynus"}}