payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/280771246","pull_request_review_id":233465550,"id":280771246,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDc3MTI0Ng==","diff_hunk":"@@ -42,6 +42,11 @@ var udpOOBSize = func() int {\n type sessionUDPFactory struct {\n \t// A pool for UDP message buffers.\n \tudpPool sync.Pool\n+\n+\t// ipv4Enabled and ipv6Enabled are used when setting up the proxy sockets\n+\t// later, and determine if we bind to 127.0.0.1 and ::1, respectively.\n+\t// See sessionUDPFactory.SetSocketOptions\n+\tipv4Enabled, ipv6Enabled bool","path":"pkg/fqdn/dnsproxy/udp.go","position":8,"original_position":8,"commit_id":"566c3fcee40cad47ae28646fbaa404456863db5a","original_commit_id":"566c3fcee40cad47ae28646fbaa404456863db5a","user":{"login":"raybejjani","id":744312,"node_id":"MDQ6VXNlcjc0NDMxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/744312?v=4","gravatar_id":"","url":"https://api.github.com/users/raybejjani","html_url":"https://github.com/raybejjani","followers_url":"https://api.github.com/users/raybejjani/followers","following_url":"https://api.github.com/users/raybejjani/following{/other_user}","gists_url":"https://api.github.com/users/raybejjani/gists{/gist_id}","starred_url":"https://api.github.com/users/raybejjani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raybejjani/subscriptions","organizations_url":"https://api.github.com/users/raybejjani/orgs","repos_url":"https://api.github.com/users/raybejjani/repos","events_url":"https://api.github.com/users/raybejjani/events{/privacy}","received_events_url":"https://api.github.com/users/raybejjani/received_events","type":"User","site_admin":false},"body":"😊 yup... a few things were wrong :/","created_at":"2019-05-03T13:21:56Z","updated_at":"2019-05-03T13:21:56Z","html_url":"https://github.com/cilium/cilium/pull/7917#discussion_r280771246","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/7917","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/280771246"},"html":{"href":"https://github.com/cilium/cilium/pull/7917#discussion_r280771246"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/7917"}},"in_reply_to_id":280768801},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/7917","id":275703586,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NzAzNTg2","html_url":"https://github.com/cilium/cilium/pull/7917","diff_url":"https://github.com/cilium/cilium/pull/7917.diff","patch_url":"https://github.com/cilium/cilium/pull/7917.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/7917","number":7917,"state":"open","locked":false,"title":"dnsproxy: Do not bind to IPv4 or IPv6 when disabled","user":{"login":"raybejjani","id":744312,"node_id":"MDQ6VXNlcjc0NDMxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/744312?v=4","gravatar_id":"","url":"https://api.github.com/users/raybejjani","html_url":"https://github.com/raybejjani","followers_url":"https://api.github.com/users/raybejjani/followers","following_url":"https://api.github.com/users/raybejjani/following{/other_user}","gists_url":"https://api.github.com/users/raybejjani/gists{/gist_id}","starred_url":"https://api.github.com/users/raybejjani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raybejjani/subscriptions","organizations_url":"https://api.github.com/users/raybejjani/orgs","repos_url":"https://api.github.com/users/raybejjani/repos","events_url":"https://api.github.com/users/raybejjani/events{/privacy}","received_events_url":"https://api.github.com/users/raybejjani/received_events","type":"User","site_admin":false},"body":"It is common to boot with IPv6 disabled outright, and the IPv6 loopback\r\nat ::1 won't exist. We assumed it did and would fail to bind, eventually\r\ncausing a fatal in the proxy.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/7917)\n<!-- Reviewable:end -->\n","created_at":"2019-05-03T13:01:18Z","updated_at":"2019-05-03T13:21:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16f9486be52ba9b50dfea64b4c6adcc93329cb27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/7917/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/7917/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/7917/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/566c3fcee40cad47ae28646fbaa404456863db5a","head":{"label":"raybejjani:fqdn-ipv6-bind","ref":"fqdn-ipv6-bind","sha":"566c3fcee40cad47ae28646fbaa404456863db5a","user":{"login":"raybejjani","id":744312,"node_id":"MDQ6VXNlcjc0NDMxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/744312?v=4","gravatar_id":"","url":"https://api.github.com/users/raybejjani","html_url":"https://github.com/raybejjani","followers_url":"https://api.github.com/users/raybejjani/followers","following_url":"https://api.github.com/users/raybejjani/following{/other_user}","gists_url":"https://api.github.com/users/raybejjani/gists{/gist_id}","starred_url":"https://api.github.com/users/raybejjani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raybejjani/subscriptions","organizations_url":"https://api.github.com/users/raybejjani/orgs","repos_url":"https://api.github.com/users/raybejjani/repos","events_url":"https://api.github.com/users/raybejjani/events{/privacy}","received_events_url":"https://api.github.com/users/raybejjani/received_events","type":"User","site_admin":false},"repo":{"id":116163467,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjM0Njc=","name":"cilium","full_name":"raybejjani/cilium","private":false,"owner":{"login":"raybejjani","id":744312,"node_id":"MDQ6VXNlcjc0NDMxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/744312?v=4","gravatar_id":"","url":"https://api.github.com/users/raybejjani","html_url":"https://github.com/raybejjani","followers_url":"https://api.github.com/users/raybejjani/followers","following_url":"https://api.github.com/users/raybejjani/following{/other_user}","gists_url":"https://api.github.com/users/raybejjani/gists{/gist_id}","starred_url":"https://api.github.com/users/raybejjani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raybejjani/subscriptions","organizations_url":"https://api.github.com/users/raybejjani/orgs","repos_url":"https://api.github.com/users/raybejjani/repos","events_url":"https://api.github.com/users/raybejjani/events{/privacy}","received_events_url":"https://api.github.com/users/raybejjani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raybejjani/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":true,"url":"https://api.github.com/repos/raybejjani/cilium","forks_url":"https://api.github.com/repos/raybejjani/cilium/forks","keys_url":"https://api.github.com/repos/raybejjani/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raybejjani/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raybejjani/cilium/teams","hooks_url":"https://api.github.com/repos/raybejjani/cilium/hooks","issue_events_url":"https://api.github.com/repos/raybejjani/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/raybejjani/cilium/events","assignees_url":"https://api.github.com/repos/raybejjani/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/raybejjani/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/raybejjani/cilium/tags","blobs_url":"https://api.github.com/repos/raybejjani/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raybejjani/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raybejjani/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/raybejjani/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raybejjani/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/raybejjani/cilium/languages","stargazers_url":"https://api.github.com/repos/raybejjani/cilium/stargazers","contributors_url":"https://api.github.com/repos/raybejjani/cilium/contributors","subscribers_url":"https://api.github.com/repos/raybejjani/cilium/subscribers","subscription_url":"https://api.github.com/repos/raybejjani/cilium/subscription","commits_url":"https://api.github.com/repos/raybejjani/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/raybejjani/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/raybejjani/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/raybejjani/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/raybejjani/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/raybejjani/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raybejjani/cilium/merges","archive_url":"https://api.github.com/repos/raybejjani/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raybejjani/cilium/downloads","issues_url":"https://api.github.com/repos/raybejjani/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/raybejjani/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/raybejjani/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/raybejjani/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raybejjani/cilium/labels{/name}","releases_url":"https://api.github.com/repos/raybejjani/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/raybejjani/cilium/deployments","created_at":"2018-01-03T17:24:00Z","updated_at":"2018-01-03T17:24:04Z","pushed_at":"2019-05-03T13:00:49Z","git_url":"git://github.com/raybejjani/cilium.git","ssh_url":"git@github.com:raybejjani/cilium.git","clone_url":"https://github.com/raybejjani/cilium.git","svn_url":"https://github.com/raybejjani/cilium","homepage":"","size":74691,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"da0bd7f87397dd9c8f75ab3ac4cb677673d60a40","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"API Aware Networking and Security using BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2019-05-03T11:28:54Z","pushed_at":"2019-05-03T13:17:39Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":94153,"stargazers_count":3816,"watchers_count":3816,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":346,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":349,"open_issues":346,"watchers":3816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/7917"},"html":{"href":"https://github.com/cilium/cilium/pull/7917"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/7917"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/7917/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/7917/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/7917/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/566c3fcee40cad47ae28646fbaa404456863db5a"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"raybejjani"}}