payload: {"action":"created","issue":{"url":"https://api.github.com/repos/MarkBind/markbind/issues/674","repository_url":"https://api.github.com/repos/MarkBind/markbind","labels_url":"https://api.github.com/repos/MarkBind/markbind/issues/674/labels{/name}","comments_url":"https://api.github.com/repos/MarkBind/markbind/issues/674/comments","events_url":"https://api.github.com/repos/MarkBind/markbind/issues/674/events","html_url":"https://github.com/MarkBind/markbind/issues/674","id":407159300,"node_id":"MDU6SXNzdWU0MDcxNTkzMDA=","number":674,"title":"Page variables should only be overridden by request","user":{"login":"damithc","id":1673303,"node_id":"MDQ6VXNlcjE2NzMzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1673303?v=4","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false},"labels":[{"id":1207330970,"node_id":"MDU6TGFiZWwxMjA3MzMwOTcw","url":"https://api.github.com/repos/MarkBind/markbind/labels/a-Reuse","name":"a-Reuse","color":"c5def5","default":false},{"id":1171141832,"node_id":"MDU6TGFiZWwxMTcxMTQxODMy","url":"https://api.github.com/repos/MarkBind/markbind/labels/a-Syntax","name":"a-Syntax","color":"c5def5","default":false},{"id":568283422,"node_id":"MDU6TGFiZWw1NjgyODM0MjI=","url":"https://api.github.com/repos/MarkBind/markbind/labels/p.Medium","name":"p.Medium","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2019-02-06T10:05:19Z","updated_at":"2019-02-10T06:30:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"v1.17.2\r\n\r\nContext:\r\n`parent.md`:\r\n```html\r\n<variable name=\"title\">Parent page</variable>\r\n\r\nRefer the <include src=\"child.md#summary\" />\r\n```\r\n`child.md`:\r\n```html\r\n<variable name=\"title\">Child page</variable>\r\n\r\n<span id=\"summary\">\r\nsummary of page: {{ title }}\r\n</span>\r\n```\r\n\r\nCurrent: the parent.md renders `Refer the summary of page: Parent page`\r\nExpected: `Refer the summary of page: Child page`\r\n\r\nSuggested: override page variables only when specifically requested, as follows:\r\n```html\r\n<variable name=\"title\">Parent page</variable>\r\n\r\n<include src=\"child.md#summary\">\r\n  <span id=\"title\">{{ title }}</span>\r\n</include>\r\n```\r\n\r\nRationale: to avoid accidental overriding. We can expect variable names such as `title` to occur multiple times within an include chain. This problem tripped me up several times when doing #668"},"comment":{"url":"https://api.github.com/repos/MarkBind/markbind/issues/comments/462107859","html_url":"https://github.com/MarkBind/markbind/issues/674#issuecomment-462107859","issue_url":"https://api.github.com/repos/MarkBind/markbind/issues/674","id":462107859,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MjEwNzg1OQ==","user":{"login":"damithc","id":1673303,"node_id":"MDQ6VXNlcjE2NzMzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1673303?v=4","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false},"created_at":"2019-02-10T06:30:58Z","updated_at":"2019-02-10T06:30:58Z","author_association":"CONTRIBUTOR","body":"> If we really want that, then let's implement that as a plugin — like how it's planned for #492 in #495.\r\n\r\nSure, a plugin would be fine too."}}
other: {"actor":{"display_login":"damithc"}}