payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/354248197","pull_request_review_id":327474095,"id":354248197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDI0ODE5Nw==","diff_hunk":"@@ -1490,14 +1490,18 @@ end\n     @test @views typeof(df[!, 1:2]) <: SubDataFrame\n end\n \n-@testset \"broadcasting of df[:, col] = vector\" begin\n+@testset \"broadcasting of df[:, col] = value\" begin\n     df = DataFrame(ones(3, 4))\n     z = [\"a\", \"b\", \"c\"]\n     df[:, :z] .= z\n     @test df.z == z\n     @test df.z !== z\n     @test_throws ArgumentError df[:, 6] .= z\n     @test_throws MethodError df[:, 1] .= z\n+\n+    df = DataFrame(ones(3, 4))\n+    z = fill(\"abc\", 1, 1, 1)\n+    @test_throws DimensionMismatch df[:, :z] .= z","path":"test/broadcasting.jl","position":15,"original_position":16,"commit_id":"703b8836a9af3f66d3dc773e3f0da0d29077a2c4","original_commit_id":"703b8836a9af3f66d3dc773e3f0da0d29077a2c4","user":{"login":"nalimilan","id":1120448,"node_id":"MDQ6VXNlcjExMjA0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1120448?v=4","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"This still doesn't test scalars, right? :-)","created_at":"2019-12-05T11:14:32Z","updated_at":"2019-12-05T11:14:32Z","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1961#discussion_r354248197","pull_request_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/354248197"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1961#discussion_r354248197"},"pull_request":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961","id":320062843,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwMDYyODQz","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1961","diff_url":"https://github.com/JuliaData/DataFrames.jl/pull/1961.diff","patch_url":"https://github.com/JuliaData/DataFrames.jl/pull/1961.patch","issue_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1961","number":1961,"state":"open","locked":false,"title":"allow to create columns using : as row selector","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"body":"Allow `df[:, col] = vector` and `df[:, col] .= v` to create a column if `col` is not present in `df`. A fresh vector is always allocated.\r\n\r\nGiven the comments on Slack I am convinced we can add this without harm, but there is no rush (though personally I would prefer to settle this PR before 1.0, as I would prefer not to mess with `getindex`/`setindex!`/broadcasting assignment after 1.0 if possible).\r\n\r\nCC @oxinabox @nalimilan @pdeffebach ","created_at":"2019-09-22T16:52:44Z","updated_at":"2019-12-05T11:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9598ca349099b39243194f51cb8f2a5ed38b0345","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":9421644,"node_id":"MDU6TGFiZWw5NDIxNjQ0","url":"https://api.github.com/repos/JuliaData/DataFrames.jl/labels/decision","name":"decision","color":"ff7f00","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961/commits","review_comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961/comments","review_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1961/comments","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/703b8836a9af3f66d3dc773e3f0da0d29077a2c4","head":{"label":"bkamins:change_colon_setindex","ref":"change_colon_setindex","sha":"703b8836a9af3f66d3dc773e3f0da0d29077a2c4","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"repo":{"id":112845765,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI4NDU3NjU=","name":"DataFrames.jl","full_name":"bkamins/DataFrames.jl","private":false,"owner":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bkamins/DataFrames.jl","description":"Library for working with tabular data in Julia","fork":true,"url":"https://api.github.com/repos/bkamins/DataFrames.jl","forks_url":"https://api.github.com/repos/bkamins/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/bkamins/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkamins/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkamins/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/bkamins/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/bkamins/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/bkamins/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/bkamins/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/bkamins/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkamins/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/bkamins/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/bkamins/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/bkamins/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/bkamins/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/bkamins/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/bkamins/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkamins/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkamins/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/bkamins/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkamins/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/bkamins/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkamins/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/bkamins/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/bkamins/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/bkamins/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkamins/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/bkamins/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/bkamins/DataFrames.jl/deployments","created_at":"2017-12-02T13:50:44Z","updated_at":"2019-12-04T20:15:53Z","pushed_at":"2019-12-04T20:58:20Z","git_url":"git://github.com/bkamins/DataFrames.jl.git","ssh_url":"git@github.com:bkamins/DataFrames.jl.git","clone_url":"https://github.com/bkamins/DataFrames.jl.git","svn_url":"https://github.com/bkamins/DataFrames.jl","homepage":"","size":10770,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaData:master","ref":"master","sha":"8bec53dc9f86589d75f6959e51a6dd0c4a74af64","user":{"login":"JuliaData","id":20142970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQyOTcw","avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"repo":{"id":4992873,"node_id":"MDEwOlJlcG9zaXRvcnk0OTkyODcz","name":"DataFrames.jl","full_name":"JuliaData/DataFrames.jl","private":false,"owner":{"login":"JuliaData","id":20142970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQyOTcw","avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaData/DataFrames.jl","description":"In-memory tabular data in Julia","fork":false,"url":"https://api.github.com/repos/JuliaData/DataFrames.jl","forks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/deployments","created_at":"2012-07-11T18:00:09Z","updated_at":"2019-12-04T21:39:56Z","pushed_at":"2019-12-04T21:51:15Z","git_url":"git://github.com/JuliaData/DataFrames.jl.git","ssh_url":"git@github.com:JuliaData/DataFrames.jl.git","clone_url":"https://github.com/JuliaData/DataFrames.jl.git","svn_url":"https://github.com/JuliaData/DataFrames.jl","homepage":"http://juliadata.github.io/DataFrames.jl/stable/","size":11746,"stargazers_count":700,"watchers_count":700,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":253,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":79,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":253,"open_issues":79,"watchers":700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1961"},"issue":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1961"},"comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1961/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1961/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/703b8836a9af3f66d3dc773e3f0da0d29077a2c4"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"nalimilan"}}