payload: {"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14260","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14260/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14260/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14260/events","html_url":"https://github.com/civicrm/civicrm-core/pull/14260","id":444771327,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5MzU5OTU4","number":14260,"title":"[REF+test] clean up code for getting labels for merge screen, stdise","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2019-05-16T06:11:52Z","updated_at":"2019-05-18T05:18:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/14260","html_url":"https://github.com/civicrm/civicrm-core/pull/14260","diff_url":"https://github.com/civicrm/civicrm-core/pull/14260.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/14260.patch"},"body":"Overview\r\n----------------------------------------\r\nPrimarily a code clean up & test add this has the side effect of rendering labels for preferred language & the greeting IDs - which seems to me like a positive side effect\r\n\r\nBefore\r\n----------------------------------------\r\n![before](https://user-images.githubusercontent.com/336308/57830748-31f8bd80-7807-11e9-9844-5fe6d65d126f.jpg)\r\n\r\n\r\n\r\n\r\nAfter\r\n----------------------------------------\r\n![after](https://user-images.githubusercontent.com/336308/57830401-25279a00-7806-11e9-86b1-302d82e1d8f7.jpg)\r\n\r\n\r\nTechnical Details\r\n----------------------------------------\r\nThe whole getSpecialValues function was a convoluted way of\r\n1) getting labels for 2 fields - preferred communication method & communication style\r\n2) serializing the value for preferred communication method\r\n\r\nIt was deeply confusing & hence had to be cleaned up\r\n\r\nComments\r\n----------------------------------------\r\n\r\n@JKingsnorth "},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/493649492","html_url":"https://github.com/civicrm/civicrm-core/pull/14260#issuecomment-493649492","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14260","id":493649492,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MzY0OTQ5Mg==","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"created_at":"2019-05-18T05:18:39Z","updated_at":"2019-05-18T05:18:39Z","author_association":"CONTRIBUTOR","body":"test this please"}}
other: {"actor":{"display_login":"eileenmcnaughton"}}