payload: {"action":"created","comment":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/310325886","pull_request_review_id":270431162,"id":310325886,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDMyNTg4Ng==","diff_hunk":"@@ -35,22 +40,35 @@ contract ConditionalTransactionDelegateTarget {\n       \"Free Balance app instance is not finalized yet\"\n     );\n \n-    LibOutcome.CoinTransfer[][] memory outcome = abi.decode(\n+    FreeBalanceAppState memory freeBalanceAppState = abi.decode(\n       challengeRegistry.getOutcome(freeBalanceAppIdentityHash),\n       (FreeBalanceAppState)\n-    ).balances;\n+    );\n \n-    bytes memory payload = abi.encodeWithSignature(\n-      \"interpretOutcomeAndExecuteEffect(bytes,bytes)\",\n-      abi.encode(outcome),\n-      multiAssetMultiPartyCoinTransferInterpreterParams\n+    uint256[] memory limits = new uint256[](\n+      freeBalanceAppState.tokenAddresses.length\n     );\n \n+    for (uint256 i = 0; i < freeBalanceAppState.tokenAddresses.length; i++) {\n+      limits[i] = MAX_UINT256;","path":"packages/cf-funding-protocol-contracts/contracts/ConditionalTransactionDelegateTarget.sol","position":46,"original_position":46,"commit_id":"52fb835426edccedfd76f00cff0e97d4acb9bfde","original_commit_id":"e1437bb9c8e04712368752247d4dbfc612c6f83a","user":{"login":"cf19drofxots","id":38441757,"node_id":"MDQ6VXNlcjM4NDQxNzU3","avatar_url":"https://avatars0.githubusercontent.com/u/38441757?v=4","gravatar_id":"","url":"https://api.github.com/users/cf19drofxots","html_url":"https://github.com/cf19drofxots","followers_url":"https://api.github.com/users/cf19drofxots/followers","following_url":"https://api.github.com/users/cf19drofxots/following{/other_user}","gists_url":"https://api.github.com/users/cf19drofxots/gists{/gist_id}","starred_url":"https://api.github.com/users/cf19drofxots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cf19drofxots/subscriptions","organizations_url":"https://api.github.com/users/cf19drofxots/orgs","repos_url":"https://api.github.com/users/cf19drofxots/repos","events_url":"https://api.github.com/users/cf19drofxots/events{/privacy}","received_events_url":"https://api.github.com/users/cf19drofxots/received_events","type":"User","site_admin":false},"body":"If the limit is the _max_ allowed limit, how is relying on app state any less safe?\r\n\r\nIn either case, a comment around this code would be helpful to clarify this reasoning. Otherwise the setting the limit to this max without context is a bit strange.","created_at":"2019-08-02T23:37:27Z","updated_at":"2019-08-02T23:37:27Z","html_url":"https://github.com/counterfactual/monorepo/pull/2111#discussion_r310325886","pull_request_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/310325886"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/2111#discussion_r310325886"},"pull_request":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111"}},"in_reply_to_id":310324805},"pull_request":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111","id":303956108,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzOTU2MTA4","html_url":"https://github.com/counterfactual/monorepo/pull/2111","diff_url":"https://github.com/counterfactual/monorepo/pull/2111.diff","patch_url":"https://github.com/counterfactual/monorepo/pull/2111.patch","issue_url":"https://api.github.com/repos/counterfactual/monorepo/issues/2111","number":2111,"state":"open","locked":false,"title":"Ensure token balances are withdraw-able from free balance","user":{"login":"snario","id":1933029,"node_id":"MDQ6VXNlcjE5MzMwMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1933029?v=4","gravatar_id":"","url":"https://api.github.com/users/snario","html_url":"https://github.com/snario","followers_url":"https://api.github.com/users/snario/followers","following_url":"https://api.github.com/users/snario/following{/other_user}","gists_url":"https://api.github.com/users/snario/gists{/gist_id}","starred_url":"https://api.github.com/users/snario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snario/subscriptions","organizations_url":"https://api.github.com/users/snario/orgs","repos_url":"https://api.github.com/users/snario/repos","events_url":"https://api.github.com/users/snario/events{/privacy}","received_events_url":"https://api.github.com/users/snario/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-02T23:25:02Z","updated_at":"2019-08-02T23:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b53548deabbc550056d798fe0de9c225827c3f2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"IIIIllllIIIIllllIIIIllllIIIIllllIIIIll","id":130362,"node_id":"MDQ6VXNlcjEzMDM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/130362?v=4","gravatar_id":"","url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll","html_url":"https://github.com/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll","followers_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/followers","following_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/following{/other_user}","gists_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/subscriptions","organizations_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/orgs","repos_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/repos","events_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/events{/privacy}","received_events_url":"https://api.github.com/users/IIIIllllIIIIllllIIIIllllIIIIllllIIIIll/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111/commits","review_comments_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111/comments","review_comment_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/issues/2111/comments","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/52fb835426edccedfd76f00cff0e97d4acb9bfde","head":{"label":"counterfactual:liam/fbTken","ref":"liam/fbTken","sha":"52fb835426edccedfd76f00cff0e97d4acb9bfde","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2019-08-02T17:30:31Z","pushed_at":"2019-08-02T23:36:29Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":21570,"stargazers_count":176,"watchers_count":176,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":162,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":162,"watchers":176,"default_branch":"master"}},"base":{"label":"counterfactual:master","ref":"master","sha":"50283b3258a141b6eb1311c5fcf1b88f8e4736c6","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2019-08-02T17:30:31Z","pushed_at":"2019-08-02T23:36:29Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":21570,"stargazers_count":176,"watchers_count":176,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":162,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":162,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/2111"},"issue":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/2111"},"comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/2111/comments"},"review_comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111/comments"},"review_comment":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/2111/commits"},"statuses":{"href":"https://api.github.com/repos/counterfactual/monorepo/statuses/52fb835426edccedfd76f00cff0e97d4acb9bfde"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"cf19drofxots"}}