payload: {"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/63","id":301366264,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzY2MjY0","html_url":"https://github.com/OpenZeppelin/openzeppelin-test-helpers/pull/63","diff_url":"https://github.com/OpenZeppelin/openzeppelin-test-helpers/pull/63.diff","patch_url":"https://github.com/OpenZeppelin/openzeppelin-test-helpers/pull/63.patch","issue_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues/63","number":63,"state":"closed","locked":false,"title":"Accept web3 1.2.0 as valid version","user":{"login":"cgewecke","id":7332026,"node_id":"MDQ6VXNlcjczMzIwMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/7332026?v=4","gravatar_id":"","url":"https://api.github.com/users/cgewecke","html_url":"https://github.com/cgewecke","followers_url":"https://api.github.com/users/cgewecke/followers","following_url":"https://api.github.com/users/cgewecke/following{/other_user}","gists_url":"https://api.github.com/users/cgewecke/gists{/gist_id}","starred_url":"https://api.github.com/users/cgewecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgewecke/subscriptions","organizations_url":"https://api.github.com/users/cgewecke/orgs","repos_url":"https://api.github.com/users/cgewecke/repos","events_url":"https://api.github.com/users/cgewecke/events{/privacy}","received_events_url":"https://api.github.com/users/cgewecke/received_events","type":"User","site_admin":false},"body":"Hi, am seeing a handlful of CI failures today in projects that float their truffle version and use the zeppelin helpers. Their latest release (v5.0.29) upgrades to the new Web3 stable (v1.2.0) and triggers this error:\r\n```\r\nError: web3@1.2.0 detected, incompatible with requirement of web3@1.0.0-beta.37\r\n    at setWeb3 (/home/circleci/project/openzeppelin-solidity/node_modules/openzeppelin-test-helpers/src/configure-web3.js:18:11)\r\n    at defaultConfigure (/home/circleci/project/openzeppelin-solidity/node_modules/openzeppelin-test-helpers/configure.js:48:3)\r\n```\r\n**Examples**\r\n[gnosis-hg greenkeeper CI](https://travis-ci.org/gnosis/conditional-tokens-contracts/jobs/563745772#L1323)\r\n[solidity-coverage nightly CI](https://circleci.com/gh/sc-forks/solidity-coverage/824)\r\n\r\n**Additional context about `semver.satisfies`**\r\n```\r\nsemver.satisfies('2.0.0-alpha', '>=1.2.0')\r\n> false\r\nsemver.satisfies('2.0.0-alpha.1', '>=1.2.0')\r\n> false\r\nsemver.satisfies('1.2.1', '>=1.2.0')\r\n> true\r\nsemver.satisfies('2.0.0', '>=1.2.0')\r\n> true\r\n```\r\n\r\nAnother possibility is `1.0.0-beta.37 || 1.x` but there are some (wrongly) published versions below 1.2....\r\n\r\n```\r\nsemver.satisfies('1.2.1', '1.0.0-beta.37 || 1.x')\r\n> true\r\nsemver.satisfies('1.0.0-beta.36', '1.0.0-beta.37 || 1.x')\r\n> false\r\nsemver.satisfies('2.0.0-alpha', '1.0.0-beta.37 || 1.x')}\r\n> false\r\nsemver.satisfies('2.0.0-alpha.1', '1.0.0-beta.37 || 1.x')\r\n> false\r\nsemver.satisfies('2.0.0', '1.0.0-beta.37 || 1.x')\r\n> false\r\n```\r\n\r\nFixes #62 ","created_at":"2019-07-26T01:50:05Z","updated_at":"2019-07-26T17:37:47Z","closed_at":"2019-07-26T17:37:47Z","merged_at":"2019-07-26T17:37:47Z","merge_commit_sha":"40b1547de5554386062913e755f4887d8c10a21d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/63/commits","review_comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/63/comments","review_comment_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues/63/comments","statuses_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/statuses/95a5212a1e95a901795d445377a7902d5bf13f3d","head":{"label":"cgewecke:fix/semver-satisfies-web3-stable","ref":"fix/semver-satisfies-web3-stable","sha":"95a5212a1e95a901795d445377a7902d5bf13f3d","user":{"login":"cgewecke","id":7332026,"node_id":"MDQ6VXNlcjczMzIwMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/7332026?v=4","gravatar_id":"","url":"https://api.github.com/users/cgewecke","html_url":"https://github.com/cgewecke","followers_url":"https://api.github.com/users/cgewecke/followers","following_url":"https://api.github.com/users/cgewecke/following{/other_user}","gists_url":"https://api.github.com/users/cgewecke/gists{/gist_id}","starred_url":"https://api.github.com/users/cgewecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgewecke/subscriptions","organizations_url":"https://api.github.com/users/cgewecke/orgs","repos_url":"https://api.github.com/users/cgewecke/repos","events_url":"https://api.github.com/users/cgewecke/events{/privacy}","received_events_url":"https://api.github.com/users/cgewecke/received_events","type":"User","site_admin":false},"repo":{"id":198924960,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg5MjQ5NjA=","name":"openzeppelin-test-helpers","full_name":"cgewecke/openzeppelin-test-helpers","private":false,"owner":{"login":"cgewecke","id":7332026,"node_id":"MDQ6VXNlcjczMzIwMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/7332026?v=4","gravatar_id":"","url":"https://api.github.com/users/cgewecke","html_url":"https://github.com/cgewecke","followers_url":"https://api.github.com/users/cgewecke/followers","following_url":"https://api.github.com/users/cgewecke/following{/other_user}","gists_url":"https://api.github.com/users/cgewecke/gists{/gist_id}","starred_url":"https://api.github.com/users/cgewecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgewecke/subscriptions","organizations_url":"https://api.github.com/users/cgewecke/orgs","repos_url":"https://api.github.com/users/cgewecke/repos","events_url":"https://api.github.com/users/cgewecke/events{/privacy}","received_events_url":"https://api.github.com/users/cgewecke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cgewecke/openzeppelin-test-helpers","description":"JavaScript testing helpers for Ethereum smart contract development","fork":true,"url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers","forks_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/forks","keys_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/teams","hooks_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/hooks","issue_events_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/events","assignees_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/tags","blobs_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/languages","stargazers_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/stargazers","contributors_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/contributors","subscribers_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/subscribers","subscription_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/subscription","commits_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/merges","archive_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/downloads","issues_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/labels{/name}","releases_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/cgewecke/openzeppelin-test-helpers/deployments","created_at":"2019-07-26T01:30:25Z","updated_at":"2019-07-26T01:30:28Z","pushed_at":"2019-07-26T17:27:36Z","git_url":"git://github.com/cgewecke/openzeppelin-test-helpers.git","ssh_url":"git@github.com:cgewecke/openzeppelin-test-helpers.git","clone_url":"https://github.com/cgewecke/openzeppelin-test-helpers.git","svn_url":"https://github.com/cgewecke/openzeppelin-test-helpers","homepage":"","size":294,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenZeppelin:master","ref":"master","sha":"db687a0b561657b35ce462e92702e174e6d04ad9","user":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"repo":{"id":159831009,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk4MzEwMDk=","name":"openzeppelin-test-helpers","full_name":"OpenZeppelin/openzeppelin-test-helpers","private":false,"owner":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenZeppelin/openzeppelin-test-helpers","description":"JavaScript testing helpers for Ethereum smart contract development","fork":false,"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers","forks_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/forks","keys_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/teams","hooks_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/hooks","issue_events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/events","assignees_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/tags","blobs_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/languages","stargazers_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/stargazers","contributors_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/contributors","subscribers_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/subscribers","subscription_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/subscription","commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/merges","archive_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/downloads","issues_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/labels{/name}","releases_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/deployments","created_at":"2018-11-30T13:57:15Z","updated_at":"2019-07-26T13:09:54Z","pushed_at":"2019-07-26T17:37:47Z","git_url":"git://github.com/OpenZeppelin/openzeppelin-test-helpers.git","ssh_url":"git@github.com:OpenZeppelin/openzeppelin-test-helpers.git","clone_url":"https://github.com/OpenZeppelin/openzeppelin-test-helpers.git","svn_url":"https://github.com/OpenZeppelin/openzeppelin-test-helpers","homepage":"","size":287,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":12,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/63"},"html":{"href":"https://github.com/OpenZeppelin/openzeppelin-test-helpers/pull/63"},"issue":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues/63"},"comments":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-test-helpers/statuses/95a5212a1e95a901795d445377a7902d5bf13f3d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nventuro","id":2530770,"node_id":"MDQ6VXNlcjI1MzA3NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2530770?v=4","gravatar_id":"","url":"https://api.github.com/users/nventuro","html_url":"https://github.com/nventuro","followers_url":"https://api.github.com/users/nventuro/followers","following_url":"https://api.github.com/users/nventuro/following{/other_user}","gists_url":"https://api.github.com/users/nventuro/gists{/gist_id}","starred_url":"https://api.github.com/users/nventuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventuro/subscriptions","organizations_url":"https://api.github.com/users/nventuro/orgs","repos_url":"https://api.github.com/users/nventuro/repos","events_url":"https://api.github.com/users/nventuro/events{/privacy}","received_events_url":"https://api.github.com/users/nventuro/received_events","type":"User","site_admin":false},"comments":6,"review_comments":3,"maintainer_can_modify":false,"commits":8,"additions":77,"deletions":370,"changed_files":18}}
other: {"actor":{"display_login":"nventuro"}}