payload: {"action":"created","issue":{"url":"https://api.github.com/repos/RPTools/maptool/issues/353","repository_url":"https://api.github.com/repos/RPTools/maptool","labels_url":"https://api.github.com/repos/RPTools/maptool/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/RPTools/maptool/issues/353/comments","events_url":"https://api.github.com/repos/RPTools/maptool/issues/353/events","html_url":"https://github.com/RPTools/maptool/issues/353","id":423630900,"node_id":"MDU6SXNzdWU0MjM2MzA5MDA=","number":353,"title":"[BUG] MT 1.5.0 Macro dialog size persistance","user":{"login":"Tdue21","id":2953375,"node_id":"MDQ6VXNlcjI5NTMzNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2953375?v=4","gravatar_id":"","url":"https://api.github.com/users/Tdue21","html_url":"https://github.com/Tdue21","followers_url":"https://api.github.com/users/Tdue21/followers","following_url":"https://api.github.com/users/Tdue21/following{/other_user}","gists_url":"https://api.github.com/users/Tdue21/gists{/gist_id}","starred_url":"https://api.github.com/users/Tdue21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tdue21/subscriptions","organizations_url":"https://api.github.com/users/Tdue21/orgs","repos_url":"https://api.github.com/users/Tdue21/repos","events_url":"https://api.github.com/users/Tdue21/events{/privacy}","received_events_url":"https://api.github.com/users/Tdue21/received_events","type":"User","site_admin":false},"labels":[{"id":139944936,"node_id":"MDU6TGFiZWwxMzk5NDQ5MzY=","url":"https://api.github.com/repos/RPTools/maptool/labels/bug","name":"bug","color":"fc2929","default":true,"description":null},{"id":139944939,"node_id":"MDU6TGFiZWwxMzk5NDQ5Mzk=","url":"https://api.github.com/repos/RPTools/maptool/labels/up%20for%20grabs","name":"up for grabs","color":"ffdbb5","default":false,"description":"Minimal context and are well-suited for new contributors"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-03-21T09:15:31Z","updated_at":"2019-12-26T05:07:16Z","closed_at":null,"author_association":"NONE","body":"The macro dialog only persists it current size when clicking the X on the title bar. \r\nThis does not make any sense, in my opinion. \r\n\r\nThe standard behavior, as far as I know, is that a window or dialog should only persist current size on OK. "},"comment":{"url":"https://api.github.com/repos/RPTools/maptool/issues/comments/568971197","html_url":"https://github.com/RPTools/maptool/issues/353#issuecomment-568971197","issue_url":"https://api.github.com/repos/RPTools/maptool/issues/353","id":568971197,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODk3MTE5Nw==","user":{"login":"Phergus","id":34379254,"node_id":"MDQ6VXNlcjM0Mzc5MjU0","avatar_url":"https://avatars1.githubusercontent.com/u/34379254?v=4","gravatar_id":"","url":"https://api.github.com/users/Phergus","html_url":"https://github.com/Phergus","followers_url":"https://api.github.com/users/Phergus/followers","following_url":"https://api.github.com/users/Phergus/following{/other_user}","gists_url":"https://api.github.com/users/Phergus/gists{/gist_id}","starred_url":"https://api.github.com/users/Phergus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phergus/subscriptions","organizations_url":"https://api.github.com/users/Phergus/orgs","repos_url":"https://api.github.com/users/Phergus/repos","events_url":"https://api.github.com/users/Phergus/events{/privacy}","received_events_url":"https://api.github.com/users/Phergus/received_events","type":"User","site_admin":false},"created_at":"2019-12-26T05:07:15Z","updated_at":"2019-12-26T05:07:15Z","author_association":"CONTRIBUTOR","body":"@JamzTheMan  - Looking at this and I see that the MacroButtonDialog class uses the WindowPreferences class to handle saving/restoring of window position preferences.  The WindowPreferences class knows nothing about the why of the window closing and simply triggers off the window closing event.  As far as I can tell there is no way for the WindowPreferences class to know that an \"OK\" button was pressed without assuming knowledge of the MacroButtonDialog class.\r\n\r\nIf the MacroButtonDialog class kept a reference to the WindowPreferences class and the storePreferences() method was public or there was a public method to set a flag for \"saveOnClose\" then it could be handled but that clearly breaks the whole intent of the design of WindowPreferences.\r\n\r\nWindowPreferences only saves the prefs on the window closing event (Red X) and not the window closed events generated by the OK and Cancel buttons.  So adding the windowClosing() method to WindowPreferences with a storePreferences() call would save when the OK button was pressed but also when Cancel was pressed.\r\n\r\nHopefully I'm missing something simple here.\r\n"}}
other: {"actor":{"display_login":"Phergus"}}