payload: {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/291304012","pull_request_review_id":246727355,"id":291304012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTMwNDAxMg==","diff_hunk":"@@ -81,14 +82,20 @@ def validate(obj: Dict) -> Dict:\n \n def boolean(value: Any) -> bool:\n     \"\"\"Validate and coerce a boolean value.\"\"\"\n+    if value is None:\n+        return False","path":"homeassistant/helpers/config_validation.py","position":13,"original_position":13,"commit_id":"4eb567b0f5deccb4ccb84be76414796aa5094852","original_commit_id":"b07ebe4ebacc211705dff9bc07f18a73cb401186","user":{"login":"balloob","id":1444314,"node_id":"MDQ6VXNlcjE0NDQzMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"I suggest we remove it.","created_at":"2019-06-06T18:00:59Z","updated_at":"2019-06-06T18:00:59Z","html_url":"https://github.com/home-assistant/home-assistant/pull/24294#discussion_r291304012","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/291304012"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/24294#discussion_r291304012"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294"}},"in_reply_to_id":290313860},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294","id":284820471,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0ODIwNDcx","html_url":"https://github.com/home-assistant/home-assistant/pull/24294","diff_url":"https://github.com/home-assistant/home-assistant/pull/24294.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/24294.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/24294","number":24294,"state":"open","locked":false,"title":"Improve boolean validator","user":{"login":"Swamp-Ig","id":6317645,"node_id":"MDQ6VXNlcjYzMTc2NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/6317645?v=4","gravatar_id":"","url":"https://api.github.com/users/Swamp-Ig","html_url":"https://github.com/Swamp-Ig","followers_url":"https://api.github.com/users/Swamp-Ig/followers","following_url":"https://api.github.com/users/Swamp-Ig/following{/other_user}","gists_url":"https://api.github.com/users/Swamp-Ig/gists{/gist_id}","starred_url":"https://api.github.com/users/Swamp-Ig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swamp-Ig/subscriptions","organizations_url":"https://api.github.com/users/Swamp-Ig/orgs","repos_url":"https://api.github.com/users/Swamp-Ig/repos","events_url":"https://api.github.com/users/Swamp-Ig/events{/privacy}","received_events_url":"https://api.github.com/users/Swamp-Ig/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nImproved the boolean validator to make it more robust. Picked out the important bits of #23293 \r\n\r\nNo longer allows non-boolean, non-number, non-string, non None types through (invalid value). Strips out surrounding white space. It seemed odd that `\"  true\"` would be an invalid value as would `\"dog\"`, but `[56]` would not and would validate to True. \r\n\r\nThe core of the validator is unchanged in that strings are either explicitly true or false, or invalid, it's just more robust in the face of non-string types and whitespace.\r\n\r\nIt may be worth considering 'open' to be true and 'closed' to be false as well.\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n  - [x] There is no commented out code in this PR.\r\n  - [x] I have followed the [development checklist][dev-checklist]\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html\r\n[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html\r\n","created_at":"2019-06-04T05:28:45Z","updated_at":"2019-06-06T18:00:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2301ca46db2a68dd28d838efadd7d98ab745bb8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Core","id":2410391,"node_id":"MDQ6VGVhbTI0MTAzOTE=","slug":"core","description":"Developers with knowledge of the Home Assistant core","privacy":"closed","url":"https://api.github.com/teams/2410391","html_url":"https://github.com/orgs/home-assistant/teams/core","members_url":"https://api.github.com/teams/2410391/members{/member}","repositories_url":"https://api.github.com/teams/2410391/repos","permission":"pull"}],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":832964196,"node_id":"MDU6TGFiZWw4MzI5NjQxOTY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/small-pr","name":"small-pr","color":"e5bd7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/24294/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/4eb567b0f5deccb4ccb84be76414796aa5094852","head":{"label":"Swamp-Ig:improve-boolean-validator","ref":"improve-boolean-validator","sha":"4eb567b0f5deccb4ccb84be76414796aa5094852","user":{"login":"Swamp-Ig","id":6317645,"node_id":"MDQ6VXNlcjYzMTc2NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/6317645?v=4","gravatar_id":"","url":"https://api.github.com/users/Swamp-Ig","html_url":"https://github.com/Swamp-Ig","followers_url":"https://api.github.com/users/Swamp-Ig/followers","following_url":"https://api.github.com/users/Swamp-Ig/following{/other_user}","gists_url":"https://api.github.com/users/Swamp-Ig/gists{/gist_id}","starred_url":"https://api.github.com/users/Swamp-Ig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swamp-Ig/subscriptions","organizations_url":"https://api.github.com/users/Swamp-Ig/orgs","repos_url":"https://api.github.com/users/Swamp-Ig/repos","events_url":"https://api.github.com/users/Swamp-Ig/events{/privacy}","received_events_url":"https://api.github.com/users/Swamp-Ig/received_events","type":"User","site_admin":false},"repo":{"id":146139125,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYxMzkxMjU=","name":"home-assistant","full_name":"Swamp-Ig/home-assistant","private":false,"owner":{"login":"Swamp-Ig","id":6317645,"node_id":"MDQ6VXNlcjYzMTc2NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/6317645?v=4","gravatar_id":"","url":"https://api.github.com/users/Swamp-Ig","html_url":"https://github.com/Swamp-Ig","followers_url":"https://api.github.com/users/Swamp-Ig/followers","following_url":"https://api.github.com/users/Swamp-Ig/following{/other_user}","gists_url":"https://api.github.com/users/Swamp-Ig/gists{/gist_id}","starred_url":"https://api.github.com/users/Swamp-Ig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swamp-Ig/subscriptions","organizations_url":"https://api.github.com/users/Swamp-Ig/orgs","repos_url":"https://api.github.com/users/Swamp-Ig/repos","events_url":"https://api.github.com/users/Swamp-Ig/events{/privacy}","received_events_url":"https://api.github.com/users/Swamp-Ig/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Swamp-Ig/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/Swamp-Ig/home-assistant","forks_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/forks","keys_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/teams","hooks_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/events","assignees_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/tags","blobs_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/languages","stargazers_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/subscription","commits_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/merges","archive_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/downloads","issues_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/Swamp-Ig/home-assistant/deployments","created_at":"2018-08-26T00:23:50Z","updated_at":"2019-03-31T11:25:53Z","pushed_at":"2019-06-06T12:55:31Z","git_url":"git://github.com/Swamp-Ig/home-assistant.git","ssh_url":"git@github.com:Swamp-Ig/home-assistant.git","clone_url":"https://github.com/Swamp-Ig/home-assistant.git","svn_url":"https://github.com/Swamp-Ig/home-assistant","homepage":"https://home-assistant.io","size":112230,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"976bf3e979954d502c02fbd92cfb01455d6b08f2","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2019-06-06T17:47:38Z","pushed_at":"2019-06-06T17:48:39Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":112378,"stargazers_count":24084,"watchers_count":24084,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7003,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1244,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7003,"open_issues":1244,"watchers":24084,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/24294"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/24294"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/24294/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/24294/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/4eb567b0f5deccb4ccb84be76414796aa5094852"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"balloob"}}