payload: {"action":"closed","number":10357,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/10357","id":290141667,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwMTQxNjY3","html_url":"https://github.com/juju/juju/pull/10357","diff_url":"https://github.com/juju/juju/pull/10357.diff","patch_url":"https://github.com/juju/juju/pull/10357.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/10357","number":10357,"state":"closed","locked":false,"title":"2.6 Add Charm Config Defaults to Multi-Watcher and Model Cache","user":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nIn order to serve charm config settings from the cache, we need to store the charm defaults so that they can be combined with master settings and branch deltas.\r\n\r\nThis patch:\r\n- Adds `DefaultConfig` to the mult-watcher delta for charms. It is extracted from the charm doc so we can transport and store it as a map, rather than depending on the upstream type.\r\n- Adds `DefaultConfig` to the cached charm type and ensures it is populated by the cache worker.\r\n- Completes the work to ensure that non-model cached entities are always returned from the cache as copies.\r\n\r\n## QA steps\r\n\r\nUnit tests verify changes; forthcoming patches will flex this change with QA steps.\r\nRegressions can be checked with the same steps as for #10062\r\n\r\n## Documentation changes\r\n\r\nNone.\r\n\r\n## Bug reference\r\n\r\nN/A\r\n","created_at":"2019-06-20T09:55:43Z","updated_at":"2019-06-20T11:31:40Z","closed_at":"2019-06-20T11:31:39Z","merged_at":"2019-06-20T11:31:39Z","merge_commit_sha":"eb41545eeffb85e5ed896bc4bbed36796c5487fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/10357/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/10357/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/10357/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/a88ea1e858501949847fa2dd2f8d21f891958c16","head":{"label":"manadart:2.6-add-charm-config-defaults","ref":"2.6-add-charm-config-defaults","sha":"a88ea1e858501949847fa2dd2f8d21f891958c16","user":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"repo":{"id":113540853,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1NDA4NTM=","name":"juju","full_name":"manadart/juju","private":false,"owner":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manadart/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/manadart/juju","forks_url":"https://api.github.com/repos/manadart/juju/forks","keys_url":"https://api.github.com/repos/manadart/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manadart/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manadart/juju/teams","hooks_url":"https://api.github.com/repos/manadart/juju/hooks","issue_events_url":"https://api.github.com/repos/manadart/juju/issues/events{/number}","events_url":"https://api.github.com/repos/manadart/juju/events","assignees_url":"https://api.github.com/repos/manadart/juju/assignees{/user}","branches_url":"https://api.github.com/repos/manadart/juju/branches{/branch}","tags_url":"https://api.github.com/repos/manadart/juju/tags","blobs_url":"https://api.github.com/repos/manadart/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manadart/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manadart/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/manadart/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manadart/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/manadart/juju/languages","stargazers_url":"https://api.github.com/repos/manadart/juju/stargazers","contributors_url":"https://api.github.com/repos/manadart/juju/contributors","subscribers_url":"https://api.github.com/repos/manadart/juju/subscribers","subscription_url":"https://api.github.com/repos/manadart/juju/subscription","commits_url":"https://api.github.com/repos/manadart/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/manadart/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/manadart/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/manadart/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/manadart/juju/contents/{+path}","compare_url":"https://api.github.com/repos/manadart/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manadart/juju/merges","archive_url":"https://api.github.com/repos/manadart/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manadart/juju/downloads","issues_url":"https://api.github.com/repos/manadart/juju/issues{/number}","pulls_url":"https://api.github.com/repos/manadart/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/manadart/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/manadart/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manadart/juju/labels{/name}","releases_url":"https://api.github.com/repos/manadart/juju/releases{/id}","deployments_url":"https://api.github.com/repos/manadart/juju/deployments","created_at":"2017-12-08T06:38:11Z","updated_at":"2019-06-19T10:14:09Z","pushed_at":"2019-06-20T10:33:42Z","git_url":"git://github.com/manadart/juju.git","ssh_url":"git@github.com:manadart/juju.git","clone_url":"https://github.com/manadart/juju.git","svn_url":"https://github.com/manadart/juju","homepage":"juju.ubuntu.com","size":241994,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:2.6","ref":"2.6","sha":"426836ef7649e5c259efbca13f442f0cd334d41a","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","private":false,"owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2019-06-20T09:03:10Z","pushed_at":"2019-06-20T11:31:39Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":242064,"stargazers_count":1406,"watchers_count":1406,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":320,"open_issues":10,"watchers":1406,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/10357"},"html":{"href":"https://github.com/juju/juju/pull/10357"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/10357"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/10357/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/10357/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/10357/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/a88ea1e858501949847fa2dd2f8d21f891958c16"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jujubot","id":7779494,"node_id":"MDQ6VXNlcjc3Nzk0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7779494?v=4","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":4,"additions":113,"deletions":53,"changed_files":11}}
other: {"actor":{"display_login":"jujubot"}}