payload: {"action":"created","issue":{"url":"https://api.github.com/repos/libtom/libtommath/issues/437","repository_url":"https://api.github.com/repos/libtom/libtommath","labels_url":"https://api.github.com/repos/libtom/libtommath/issues/437/labels{/name}","comments_url":"https://api.github.com/repos/libtom/libtommath/issues/437/comments","events_url":"https://api.github.com/repos/libtom/libtommath/issues/437/events","html_url":"https://github.com/libtom/libtommath/pull/437","id":514460852,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0MDc0OTUw","number":437,"title":"Suffix renamings","user":{"login":"minad","id":50754,"node_id":"MDQ6VXNlcjUwNzU0","avatar_url":"https://avatars0.githubusercontent.com/u/50754?v=4","gravatar_id":"","url":"https://api.github.com/users/minad","html_url":"https://github.com/minad","followers_url":"https://api.github.com/users/minad/followers","following_url":"https://api.github.com/users/minad/following{/other_user}","gists_url":"https://api.github.com/users/minad/gists{/gist_id}","starred_url":"https://api.github.com/users/minad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minad/subscriptions","organizations_url":"https://api.github.com/users/minad/orgs","repos_url":"https://api.github.com/users/minad/repos","events_url":"https://api.github.com/users/minad/events{/privacy}","received_events_url":"https://api.github.com/users/minad/received_events","type":"User","site_admin":false},"labels":[{"id":1132664167,"node_id":"MDU6TGFiZWwxMTMyNjY0MTY3","url":"https://api.github.com/repos/libtom/libtommath/labels/feedback%20required","name":"feedback required","color":"c68b09","default":false},{"id":1603771182,"node_id":"MDU6TGFiZWwxNjAzNzcxMTgy","url":"https://api.github.com/repos/libtom/libtommath/labels/finished","name":"finished","color":"93f477","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-10-30T07:47:15Z","updated_at":"2019-10-30T10:03:35Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/libtom/libtommath/pulls/437","html_url":"https://github.com/libtom/libtommath/pull/437","diff_url":"https://github.com/libtom/libtommath/pull/437.diff","patch_url":"https://github.com/libtom/libtommath/pull/437.patch"},"body":"Moved out from #434.\r\n\r\n---\r\n\r\nRepeating what I wrote in #434:\r\n\r\nRenaming some mp_(root|expt|log)_u32 functions back to suffix less version. Using uint32_t for those functions was a mistake, I have to admit that now. In particular using a suffix is not a good idea, since this is a slight obstacle now to change the types :( These functions should either take/return bitcounts (int) or mp_digits. For example mp_log is defined in terms of count_bits, so this is the natural type to use. mp_root calls mp_mul_d, so mp_digit would be a good fit. For now I am using simply int.\r\n\r\n---\r\n\r\nWe still have to decide if we want a new suffix!\r\n\r\nFurthermore we might want to discuss renaming `mp_div_2d -> mp_rsh, mp_mul_2d -> mp_lsh` since the 2d suffix is weird. It would also be more consistent with `mp_signed_rsh`. Alternatively something like `mp_div_2expt` might make sense. But we can also keep things as is regarding these two functions.\r\n"},"comment":{"url":"https://api.github.com/repos/libtom/libtommath/issues/comments/547825396","html_url":"https://github.com/libtom/libtommath/pull/437#issuecomment-547825396","issue_url":"https://api.github.com/repos/libtom/libtommath/issues/437","id":547825396,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzgyNTM5Ng==","user":{"login":"minad","id":50754,"node_id":"MDQ6VXNlcjUwNzU0","avatar_url":"https://avatars0.githubusercontent.com/u/50754?v=4","gravatar_id":"","url":"https://api.github.com/users/minad","html_url":"https://github.com/minad","followers_url":"https://api.github.com/users/minad/followers","following_url":"https://api.github.com/users/minad/following{/other_user}","gists_url":"https://api.github.com/users/minad/gists{/gist_id}","starred_url":"https://api.github.com/users/minad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minad/subscriptions","organizations_url":"https://api.github.com/users/minad/orgs","repos_url":"https://api.github.com/users/minad/repos","events_url":"https://api.github.com/users/minad/events{/privacy}","received_events_url":"https://api.github.com/users/minad/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T10:03:35Z","updated_at":"2019-10-30T10:03:35Z","author_association":"COLLABORATOR","body":"@nijtmans I assume on 32/64 bit archs? Why 28 exactly? Is this some magic width in tcl due to unboxed integers in the language runtime?"}}
other: {"actor":{"display_login":"minad"}}