payload: {"action":"created","issue":{"url":"https://api.github.com/repos/visit-dav/visit/issues/3662","repository_url":"https://api.github.com/repos/visit-dav/visit","labels_url":"https://api.github.com/repos/visit-dav/visit/issues/3662/labels{/name}","comments_url":"https://api.github.com/repos/visit-dav/visit/issues/3662/comments","events_url":"https://api.github.com/repos/visit-dav/visit/issues/3662/events","html_url":"https://github.com/visit-dav/visit/pull/3662","id":465985044,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1OTE5NTQz","number":3662,"title":"check file before reading","user":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-07-09T21:06:52Z","updated_at":"2019-07-10T21:13:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/visit-dav/visit/pulls/3662","html_url":"https://github.com/visit-dav/visit/pull/3662","diff_url":"https://github.com/visit-dav/visit/pull/3662.diff","patch_url":"https://github.com/visit-dav/visit/pull/3662.patch"},"body":"### Description\r\nI'm adding in a simple file check to the mili reader. Rapidjson tends to hang when it tries to open a file that is not in json format. This check will prevent this hang. This is mostly a concern with people transitioning from the old mili format to the new one. \r\n\r\nI also changed the name of makemili to makemili_driver so that the name is consistent with the command line help that is displayed, and I've removed the old makemili code. makemili_driver now lives in visit/src/bin/. \r\n\r\n\r\n### How Has This Been Tested?\r\nI've re-run the mili tests, and everything passes. I've also tested trying to open a mili file that is not in the correct format, and it doesn't hang anymore. \r\n\r\n### Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] I have updated the release notes\r\n- [ ] I have made corresponding changes to the documentation\r\n- [x] I have added debugging support to my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [ ] I have added any new baselines to the repo\r\n- [ ] I have assigned reviewers (see [VisIt's PR procedures](https://visit-sphinx-github-user-manual.readthedocs.io/en/develop/dev_manual/pr_create.html#reviewers) for more information).\r\n"},"comment":{"url":"https://api.github.com/repos/visit-dav/visit/issues/comments/510231281","html_url":"https://github.com/visit-dav/visit/pull/3662#issuecomment-510231281","issue_url":"https://api.github.com/repos/visit-dav/visit/issues/3662","id":510231281,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMDIzMTI4MQ==","user":{"login":"markcmiller86","id":5720676,"node_id":"MDQ6VXNlcjU3MjA2NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5720676?v=4","gravatar_id":"","url":"https://api.github.com/users/markcmiller86","html_url":"https://github.com/markcmiller86","followers_url":"https://api.github.com/users/markcmiller86/followers","following_url":"https://api.github.com/users/markcmiller86/following{/other_user}","gists_url":"https://api.github.com/users/markcmiller86/gists{/gist_id}","starred_url":"https://api.github.com/users/markcmiller86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcmiller86/subscriptions","organizations_url":"https://api.github.com/users/markcmiller86/orgs","repos_url":"https://api.github.com/users/markcmiller86/repos","events_url":"https://api.github.com/users/markcmiller86/events{/privacy}","received_events_url":"https://api.github.com/users/markcmiller86/received_events","type":"User","site_admin":false},"created_at":"2019-07-10T21:13:34Z","updated_at":"2019-07-10T21:13:34Z","author_association":"CONTRIBUTOR","body":"@aowen87 have a look at examples of use of NonCompliantFileException to get your error message about running makemili_driver back to the screen. I think if you do business that way, it should work. Another option...look at use of avtWarningCallback::IssueWarning as well. Hope that helps."}}
other: {"actor":{"display_login":"markcmiller86"}}