payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments/259604725","pull_request_review_id":207136785,"id":259604725,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTYwNDcyNQ==","diff_hunk":"@@ -0,0 +1,60 @@\n+/*\n+ * Copyright (c) 2018 oxarbitrage, and contributors.","path":"tests/tests/group_order_api_tests.cpp","position":null,"original_position":2,"commit_id":"05d13ed61f3290c6358c8d224a69190365082773","original_commit_id":"906beb3b029208a1e82bce475698d1d10755a40f","user":{"login":"manikey123","id":22608398,"node_id":"MDQ6VXNlcjIyNjA4Mzk4","avatar_url":"https://avatars0.githubusercontent.com/u/22608398?v=4","gravatar_id":"","url":"https://api.github.com/users/manikey123","html_url":"https://github.com/manikey123","followers_url":"https://api.github.com/users/manikey123/followers","following_url":"https://api.github.com/users/manikey123/following{/other_user}","gists_url":"https://api.github.com/users/manikey123/gists{/gist_id}","starred_url":"https://api.github.com/users/manikey123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manikey123/subscriptions","organizations_url":"https://api.github.com/users/manikey123/orgs","repos_url":"https://api.github.com/users/manikey123/repos","events_url":"https://api.github.com/users/manikey123/events{/privacy}","received_events_url":"https://api.github.com/users/manikey123/received_events","type":"User","site_admin":false},"body":"80% of code is mine and I referenced oxarbitrage's code.\r\nIn such a case whose name should I put? ","created_at":"2019-02-24T05:53:39Z","updated_at":"2019-02-24T05:53:39Z","html_url":"https://github.com/bitshares/bitshares-core/pull/1513#discussion_r259604725","pull_request_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments/259604725"},"html":{"href":"https://github.com/bitshares/bitshares-core/pull/1513#discussion_r259604725"},"pull_request":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513"}},"in_reply_to_id":258450413},"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513","id":242160689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTYwNjg5","html_url":"https://github.com/bitshares/bitshares-core/pull/1513","diff_url":"https://github.com/bitshares/bitshares-core/pull/1513.diff","patch_url":"https://github.com/bitshares/bitshares-core/pull/1513.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1513","number":1513,"state":"open","locked":false,"title":"Fix #782: Change hard-coded limitations in API's to configurable","user":{"login":"manikey123","id":22608398,"node_id":"MDQ6VXNlcjIyNjA4Mzk4","avatar_url":"https://avatars0.githubusercontent.com/u/22608398?v=4","gravatar_id":"","url":"https://api.github.com/users/manikey123","html_url":"https://github.com/manikey123","followers_url":"https://api.github.com/users/manikey123/followers","following_url":"https://api.github.com/users/manikey123/following{/other_user}","gists_url":"https://api.github.com/users/manikey123/gists{/gist_id}","starred_url":"https://api.github.com/users/manikey123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manikey123/subscriptions","organizations_url":"https://api.github.com/users/manikey123/orgs","repos_url":"https://api.github.com/users/manikey123/repos","events_url":"https://api.github.com/users/manikey123/events{/privacy}","received_events_url":"https://api.github.com/users/manikey123/received_events","type":"User","site_admin":false},"body":"\r\nAdded the review comments in request https://github.com/bitshares/bitshares-core/pull/1478 and test case for the api validation\r\n\r\nThis is wrt issue #782 \r\nPart A (Completed): get_account_history_operations -made FC_ASSERT limit configurable\r\nand wrote the testcase for the same\r\n\r\nTestcase Scenarios (Completed for PartA) :\r\n1) created 1 account with higher return limits(200)\r\n2) created 2 account with higher  return limits(200)\r\n3) No asset_create op larger than id1 with higher return limits(200)\r\n4) Limited 1 returns 1 result\r\n5) alice has 1 op returns 1 result\r\n6) create a bunch of accounts and return set the limit to 125 and the max operation size to higher return limits(125)-- operation is limited by the max-operation-limit tickets: \r\nhttps://github.com/bitshares/bitshares-core/issues/1490\r\n\r\nPart B: get_account_history - Do you want me to proceed with Part2 for get_account_history to make its FC_ASSSERT configurable?\r\nTest cases already present\r\n1) get_account_history\r\n\r\nPart C: Below apis have FC_ASSERT should they be made configurable?\r\nCurrently test cases not present. If they need to be implemented would need to know the scenarios\r\n\r\n1) get_grouped_limit_orders\r\n2) get_asset_holders_count\r\n3) get_asset_holders\r\n4) get_account_history_by_operations\r\n5) get_relative_account_history\r\n6) get_fill_order_history\r\n\r\n\r\n","created_at":"2019-01-04T02:22:02Z","updated_at":"2019-02-24T05:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89e6c2a6f59188ed82f6fb735c277494f0752d09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/bitshares/bitshares-core/milestones/20","html_url":"https://github.com/bitshares/bitshares-core/milestone/20","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/milestones/20/labels","id":4072816,"node_id":"MDk6TWlsZXN0b25lNDA3MjgxNg==","number":20,"title":"Possible 201904 Feature Release","description":"This milestone is for tracking non-consensus changes which may be included in next consensus release.","creator":{"login":"abitmore","id":9946777,"node_id":"MDQ6VXNlcjk5NDY3Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":7,"state":"open","created_at":"2019-02-20T13:37:09Z","updated_at":"2019-02-20T21:35:31Z","due_on":"2019-04-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1513/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-core/statuses/05d13ed61f3290c6358c8d224a69190365082773","head":{"label":"manikey123:782_test_p1","ref":"782_test_p1","sha":"05d13ed61f3290c6358c8d224a69190365082773","user":{"login":"manikey123","id":22608398,"node_id":"MDQ6VXNlcjIyNjA4Mzk4","avatar_url":"https://avatars0.githubusercontent.com/u/22608398?v=4","gravatar_id":"","url":"https://api.github.com/users/manikey123","html_url":"https://github.com/manikey123","followers_url":"https://api.github.com/users/manikey123/followers","following_url":"https://api.github.com/users/manikey123/following{/other_user}","gists_url":"https://api.github.com/users/manikey123/gists{/gist_id}","starred_url":"https://api.github.com/users/manikey123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manikey123/subscriptions","organizations_url":"https://api.github.com/users/manikey123/orgs","repos_url":"https://api.github.com/users/manikey123/repos","events_url":"https://api.github.com/users/manikey123/events{/privacy}","received_events_url":"https://api.github.com/users/manikey123/received_events","type":"User","site_admin":false},"repo":{"id":160784167,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3ODQxNjc=","name":"bitshares-core","full_name":"manikey123/bitshares-core","private":false,"owner":{"login":"manikey123","id":22608398,"node_id":"MDQ6VXNlcjIyNjA4Mzk4","avatar_url":"https://avatars0.githubusercontent.com/u/22608398?v=4","gravatar_id":"","url":"https://api.github.com/users/manikey123","html_url":"https://github.com/manikey123","followers_url":"https://api.github.com/users/manikey123/followers","following_url":"https://api.github.com/users/manikey123/following{/other_user}","gists_url":"https://api.github.com/users/manikey123/gists{/gist_id}","starred_url":"https://api.github.com/users/manikey123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manikey123/subscriptions","organizations_url":"https://api.github.com/users/manikey123/orgs","repos_url":"https://api.github.com/users/manikey123/repos","events_url":"https://api.github.com/users/manikey123/events{/privacy}","received_events_url":"https://api.github.com/users/manikey123/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manikey123/bitshares-core","description":"BitShares Blockchain implementation and command-line interface","fork":true,"url":"https://api.github.com/repos/manikey123/bitshares-core","forks_url":"https://api.github.com/repos/manikey123/bitshares-core/forks","keys_url":"https://api.github.com/repos/manikey123/bitshares-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manikey123/bitshares-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manikey123/bitshares-core/teams","hooks_url":"https://api.github.com/repos/manikey123/bitshares-core/hooks","issue_events_url":"https://api.github.com/repos/manikey123/bitshares-core/issues/events{/number}","events_url":"https://api.github.com/repos/manikey123/bitshares-core/events","assignees_url":"https://api.github.com/repos/manikey123/bitshares-core/assignees{/user}","branches_url":"https://api.github.com/repos/manikey123/bitshares-core/branches{/branch}","tags_url":"https://api.github.com/repos/manikey123/bitshares-core/tags","blobs_url":"https://api.github.com/repos/manikey123/bitshares-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manikey123/bitshares-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manikey123/bitshares-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/manikey123/bitshares-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manikey123/bitshares-core/statuses/{sha}","languages_url":"https://api.github.com/repos/manikey123/bitshares-core/languages","stargazers_url":"https://api.github.com/repos/manikey123/bitshares-core/stargazers","contributors_url":"https://api.github.com/repos/manikey123/bitshares-core/contributors","subscribers_url":"https://api.github.com/repos/manikey123/bitshares-core/subscribers","subscription_url":"https://api.github.com/repos/manikey123/bitshares-core/subscription","commits_url":"https://api.github.com/repos/manikey123/bitshares-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/manikey123/bitshares-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/manikey123/bitshares-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/manikey123/bitshares-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/manikey123/bitshares-core/contents/{+path}","compare_url":"https://api.github.com/repos/manikey123/bitshares-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manikey123/bitshares-core/merges","archive_url":"https://api.github.com/repos/manikey123/bitshares-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manikey123/bitshares-core/downloads","issues_url":"https://api.github.com/repos/manikey123/bitshares-core/issues{/number}","pulls_url":"https://api.github.com/repos/manikey123/bitshares-core/pulls{/number}","milestones_url":"https://api.github.com/repos/manikey123/bitshares-core/milestones{/number}","notifications_url":"https://api.github.com/repos/manikey123/bitshares-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manikey123/bitshares-core/labels{/name}","releases_url":"https://api.github.com/repos/manikey123/bitshares-core/releases{/id}","deployments_url":"https://api.github.com/repos/manikey123/bitshares-core/deployments","created_at":"2018-12-07T06:56:50Z","updated_at":"2019-01-10T15:47:12Z","pushed_at":"2019-02-24T03:29:38Z","git_url":"git://github.com/manikey123/bitshares-core.git","ssh_url":"git@github.com:manikey123/bitshares-core.git","clone_url":"https://github.com/manikey123/bitshares-core.git","svn_url":"https://github.com/manikey123/bitshares-core","homepage":"https://bitshares.org/","size":22630,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitshares:develop","ref":"develop","sha":"bf60ddd00d6ffab67ee1b993084c342caed6c4d9","user":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123252,"node_id":"MDEwOlJlcG9zaXRvcnk0NDEyMzI1Mg==","name":"bitshares-core","full_name":"bitshares/bitshares-core","private":false,"owner":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitshares/bitshares-core","description":"BitShares Blockchain implementation and command-line interface","fork":false,"url":"https://api.github.com/repos/bitshares/bitshares-core","forks_url":"https://api.github.com/repos/bitshares/bitshares-core/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-core/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-core/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-core/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-core/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-core/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-core/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-core/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-core/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-core/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-core/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-core/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-core/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-core/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-core/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-core/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-core/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-core/deployments","created_at":"2015-10-12T17:36:04Z","updated_at":"2019-02-23T21:41:02Z","pushed_at":"2019-02-24T03:29:41Z","git_url":"git://github.com/bitshares/bitshares-core.git","ssh_url":"git@github.com:bitshares/bitshares-core.git","clone_url":"https://github.com/bitshares/bitshares-core.git","svn_url":"https://github.com/bitshares/bitshares-core","homepage":"https://bitshares.org/","size":23237,"stargazers_count":1002,"watchers_count":1002,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":517,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":517,"open_issues":254,"watchers":1002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513"},"html":{"href":"https://github.com/bitshares/bitshares-core/pull/1513"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-core/issues/1513"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-core/issues/1513/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1513/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-core/statuses/05d13ed61f3290c6358c8d224a69190365082773"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"manikey123"}}