payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/351805198","pull_request_review_id":324290317,"id":351805198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTgwNTE5OA==","diff_hunk":"@@ -170,6 +183,17 @@ class DecisionTree :\n                    typename std::remove_reference<WeightsType>::type>::value>*\n                     = 0);\n \n+  template<typename MatType, typename LabelsType, typename WeightsType>\n+  DecisionTree(const DecisionTree& other,\n+               MatType data,\n+               LabelsType labels,\n+               const size_t numClasses,\n+               WeightsType weights,\n+               const size_t minimumLeafSize = 10,\n+               const double minimumGainSplit = 1e-7,\n+               const std::enable_if_t<arma::is_arma_type<\n+                       typename std::remove_reference<WeightsType>::type>::value>*\n+               = 0);","path":"src/mlpack/methods/decision_tree/decision_tree.hpp","position":41,"original_position":41,"commit_id":"fc7e085974180c1fdb9edaa480508c93a8125f03","original_commit_id":"fc7e085974180c1fdb9edaa480508c93a8125f03","user":{"login":"KimSangYeon-DGU","id":26578203,"node_id":"MDQ6VXNlcjI2NTc4MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/26578203?v=4","gravatar_id":"","url":"https://api.github.com/users/KimSangYeon-DGU","html_url":"https://github.com/KimSangYeon-DGU","followers_url":"https://api.github.com/users/KimSangYeon-DGU/followers","following_url":"https://api.github.com/users/KimSangYeon-DGU/following{/other_user}","gists_url":"https://api.github.com/users/KimSangYeon-DGU/gists{/gist_id}","starred_url":"https://api.github.com/users/KimSangYeon-DGU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KimSangYeon-DGU/subscriptions","organizations_url":"https://api.github.com/users/KimSangYeon-DGU/orgs","repos_url":"https://api.github.com/users/KimSangYeon-DGU/repos","events_url":"https://api.github.com/users/KimSangYeon-DGU/events{/privacy}","received_events_url":"https://api.github.com/users/KimSangYeon-DGU/received_events","type":"User","site_admin":false},"body":"Please check the similar comment above.","created_at":"2019-11-28T14:21:20Z","updated_at":"2019-11-28T14:21:44Z","html_url":"https://github.com/mlpack/mlpack/pull/2099#discussion_r351805198","pull_request_url":"https://api.github.com/repos/mlpack/mlpack/pulls/2099","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/351805198"},"html":{"href":"https://github.com/mlpack/mlpack/pull/2099#discussion_r351805198"},"pull_request":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/2099"}}},"pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/2099","id":346433492,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2NDMzNDky","html_url":"https://github.com/mlpack/mlpack/pull/2099","diff_url":"https://github.com/mlpack/mlpack/pull/2099.diff","patch_url":"https://github.com/mlpack/mlpack/pull/2099.patch","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/2099","number":2099,"state":"open","locked":false,"title":"changing weak learner type of the Adaboost to DecisionTree::ID3DecisionStump","user":{"login":"himanshupathak21061998","id":37804981,"node_id":"MDQ6VXNlcjM3ODA0OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/37804981?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshupathak21061998","html_url":"https://github.com/himanshupathak21061998","followers_url":"https://api.github.com/users/himanshupathak21061998/followers","following_url":"https://api.github.com/users/himanshupathak21061998/following{/other_user}","gists_url":"https://api.github.com/users/himanshupathak21061998/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshupathak21061998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshupathak21061998/subscriptions","organizations_url":"https://api.github.com/users/himanshupathak21061998/orgs","repos_url":"https://api.github.com/users/himanshupathak21061998/repos","events_url":"https://api.github.com/users/himanshupathak21061998/events{/privacy}","received_events_url":"https://api.github.com/users/himanshupathak21061998/received_events","type":"User","site_admin":false},"body":"Resurrecting: #1842\r\nThanks, @rickllyxu for the previous work. @rcurtin can you please give a little explanation about `DecisionTree::Train()`. What I need to do with `WeakLearnerArgTypes`?","created_at":"2019-11-27T21:34:33Z","updated_at":"2019-11-28T14:21:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e00958c8ffe5df50c6b5bbcd17dcdeb94eb47d76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1200134486,"node_id":"MDU6TGFiZWwxMjAwMTM0NDg2","url":"https://api.github.com/repos/mlpack/mlpack/labels/s:%20needs%20review","name":"s: needs review","color":"ffff55","default":false,"description":""},{"id":1200136603,"node_id":"MDU6TGFiZWwxMjAwMTM2NjAz","url":"https://api.github.com/repos/mlpack/mlpack/labels/s:%20unanswered","name":"s: unanswered","color":"ffff55","default":false,"description":""},{"id":1200223274,"node_id":"MDU6TGFiZWwxMjAwMjIzMjc0","url":"https://api.github.com/repos/mlpack/mlpack/labels/s:%20unlabeled","name":"s: unlabeled","color":"ffff55","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/mlpack/mlpack/pulls/2099/commits","review_comments_url":"https://api.github.com/repos/mlpack/mlpack/pulls/2099/comments","review_comment_url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/2099/comments","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/fc7e085974180c1fdb9edaa480508c93a8125f03","head":{"label":"himanshupathak21061998:add-decisiontree","ref":"add-decisiontree","sha":"fc7e085974180c1fdb9edaa480508c93a8125f03","user":{"login":"himanshupathak21061998","id":37804981,"node_id":"MDQ6VXNlcjM3ODA0OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/37804981?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshupathak21061998","html_url":"https://github.com/himanshupathak21061998","followers_url":"https://api.github.com/users/himanshupathak21061998/followers","following_url":"https://api.github.com/users/himanshupathak21061998/following{/other_user}","gists_url":"https://api.github.com/users/himanshupathak21061998/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshupathak21061998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshupathak21061998/subscriptions","organizations_url":"https://api.github.com/users/himanshupathak21061998/orgs","repos_url":"https://api.github.com/users/himanshupathak21061998/repos","events_url":"https://api.github.com/users/himanshupathak21061998/events{/privacy}","received_events_url":"https://api.github.com/users/himanshupathak21061998/received_events","type":"User","site_admin":false},"repo":{"id":220837235,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA4MzcyMzU=","name":"mlpack","full_name":"himanshupathak21061998/mlpack","private":false,"owner":{"login":"himanshupathak21061998","id":37804981,"node_id":"MDQ6VXNlcjM3ODA0OTgx","avatar_url":"https://avatars3.githubusercontent.com/u/37804981?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshupathak21061998","html_url":"https://github.com/himanshupathak21061998","followers_url":"https://api.github.com/users/himanshupathak21061998/followers","following_url":"https://api.github.com/users/himanshupathak21061998/following{/other_user}","gists_url":"https://api.github.com/users/himanshupathak21061998/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshupathak21061998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshupathak21061998/subscriptions","organizations_url":"https://api.github.com/users/himanshupathak21061998/orgs","repos_url":"https://api.github.com/users/himanshupathak21061998/repos","events_url":"https://api.github.com/users/himanshupathak21061998/events{/privacy}","received_events_url":"https://api.github.com/users/himanshupathak21061998/received_events","type":"User","site_admin":false},"html_url":"https://github.com/himanshupathak21061998/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":true,"url":"https://api.github.com/repos/himanshupathak21061998/mlpack","forks_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/forks","keys_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/teams","hooks_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/hooks","issue_events_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/events","assignees_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/tags","blobs_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/languages","stargazers_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/stargazers","contributors_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/contributors","subscribers_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/subscribers","subscription_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/subscription","commits_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/merges","archive_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/downloads","issues_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/himanshupathak21061998/mlpack/deployments","created_at":"2019-11-10T19:11:32Z","updated_at":"2019-11-10T19:11:34Z","pushed_at":"2019-11-27T21:28:26Z","git_url":"git://github.com/himanshupathak21061998/mlpack.git","ssh_url":"git@github.com:himanshupathak21061998/mlpack.git","clone_url":"https://github.com/himanshupathak21061998/mlpack.git","svn_url":"https://github.com/himanshupathak21061998/mlpack","homepage":"https://www.mlpack.org/","size":250839,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlpack:master","ref":"master","sha":"c75a6455e46467dbdc56cd0cfbcb0a8dac509237","user":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"repo":{"id":28149409,"node_id":"MDEwOlJlcG9zaXRvcnkyODE0OTQwOQ==","name":"mlpack","full_name":"mlpack/mlpack","private":false,"owner":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mlpack/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":false,"url":"https://api.github.com/repos/mlpack/mlpack","forks_url":"https://api.github.com/repos/mlpack/mlpack/forks","keys_url":"https://api.github.com/repos/mlpack/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlpack/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlpack/mlpack/teams","hooks_url":"https://api.github.com/repos/mlpack/mlpack/hooks","issue_events_url":"https://api.github.com/repos/mlpack/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/mlpack/mlpack/events","assignees_url":"https://api.github.com/repos/mlpack/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/mlpack/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/mlpack/mlpack/tags","blobs_url":"https://api.github.com/repos/mlpack/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlpack/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlpack/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlpack/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mlpack/mlpack/languages","stargazers_url":"https://api.github.com/repos/mlpack/mlpack/stargazers","contributors_url":"https://api.github.com/repos/mlpack/mlpack/contributors","subscribers_url":"https://api.github.com/repos/mlpack/mlpack/subscribers","subscription_url":"https://api.github.com/repos/mlpack/mlpack/subscription","commits_url":"https://api.github.com/repos/mlpack/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlpack/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlpack/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlpack/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlpack/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/mlpack/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlpack/mlpack/merges","archive_url":"https://api.github.com/repos/mlpack/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlpack/mlpack/downloads","issues_url":"https://api.github.com/repos/mlpack/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/mlpack/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mlpack/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mlpack/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlpack/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/mlpack/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/mlpack/mlpack/deployments","created_at":"2014-12-17T18:16:59Z","updated_at":"2019-11-27T11:55:21Z","pushed_at":"2019-11-28T01:00:25Z","git_url":"git://github.com/mlpack/mlpack.git","ssh_url":"git@github.com:mlpack/mlpack.git","clone_url":"https://github.com/mlpack/mlpack.git","svn_url":"https://github.com/mlpack/mlpack","homepage":"https://www.mlpack.org/","size":250878,"stargazers_count":3016,"watchers_count":3016,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1100,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1100,"open_issues":112,"watchers":3016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/2099"},"html":{"href":"https://github.com/mlpack/mlpack/pull/2099"},"issue":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/2099"},"comments":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/2099/comments"},"review_comments":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/2099/comments"},"review_comment":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/2099/commits"},"statuses":{"href":"https://api.github.com/repos/mlpack/mlpack/statuses/fc7e085974180c1fdb9edaa480508c93a8125f03"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"KimSangYeon-DGU"}}