payload: {"action":"created","issue":{"url":"https://api.github.com/repos/apache/zookeeper/issues/1048","repository_url":"https://api.github.com/repos/apache/zookeeper","labels_url":"https://api.github.com/repos/apache/zookeeper/issues/1048/labels{/name}","comments_url":"https://api.github.com/repos/apache/zookeeper/issues/1048/comments","events_url":"https://api.github.com/repos/apache/zookeeper/issues/1048/events","html_url":"https://github.com/apache/zookeeper/pull/1048","id":478869479,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1ODk0MDU4","number":1048,"title":"ZOOKEEPER-3188: Improve resilience to network","user":{"login":"symat","id":18458499,"node_id":"MDQ6VXNlcjE4NDU4NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/18458499?v=4","gravatar_id":"","url":"https://api.github.com/users/symat","html_url":"https://github.com/symat","followers_url":"https://api.github.com/users/symat/followers","following_url":"https://api.github.com/users/symat/following{/other_user}","gists_url":"https://api.github.com/users/symat/gists{/gist_id}","starred_url":"https://api.github.com/users/symat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symat/subscriptions","organizations_url":"https://api.github.com/users/symat/orgs","repos_url":"https://api.github.com/users/symat/repos","events_url":"https://api.github.com/users/symat/events{/privacy}","received_events_url":"https://api.github.com/users/symat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-08-09T08:40:44Z","updated_at":"2019-08-26T08:19:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/1048","html_url":"https://github.com/apache/zookeeper/pull/1048","diff_url":"https://github.com/apache/zookeeper/pull/1048.diff","patch_url":"https://github.com/apache/zookeeper/pull/1048.patch"},"body":"This PR is the rebase of the [previous pull request](https://github.com/apache/zookeeper/pull/730), so all the kudos should go to the original authors...\r\n\r\nIn [ZOOKEEPER-3188](https://issues.apache.org/jira/browse/ZOOKEEPER-3188) we add ability to specify several addresses for quorum operations. Also added reconnection attempts if connection to leader lost.\r\n\r\nIn this PR I rebased the changes on the current master, resolving some minor conflicts with:\r\n- [ZOOKEEPER-3296](https://issues.apache.org/jira/browse/ZOOKEEPER-3296): Explicitly closing the sslsocket when it failed handshake to prevent issue where peers cannot join quorum\r\n- [ZOOKEEPER-3320](https://issues.apache.org/jira/browse/ZOOKEEPER-3320): Leader election port stop listen when hostname unresolvable for some time\r\n- [ZOOKEEPER-3385](https://issues.apache.org/jira/browse/ZOOKEEPER-3385): Add admin command to display leader\r\n- [ZOOKEEPER-3386](https://issues.apache.org/jira/browse/ZOOKEEPER-3386): Add admin command to display voting view\r\n- [ZOOKEEPER-3398](https://issues.apache.org/jira/browse/ZOOKEEPER-3398): Learner.connectToLeader() may take too long to time-out\r\n\r\nI still want to test the feature manually (e.g. using docker containers with multiple virtual networks / interfaces). The steps to the manual test could be recorded in the [google docs](https://docs.google.com/document/d/1iGVwxeHp57qogwfdodCh9b32P2_kOQaJZ2GDo7j36fI/edit?usp=sharing) as well. \r\n\r\nAlso I think we could add a few more unit tests where we are using multiple addresses. The current tests are using a single address only.\r\n\r\nAlso the Zookeeper documentation needs to be changed (e.g. by a follow-up Jira?) to promote the new feature and the new config format (possibly including also the admin command documentation in relation with [ZOOKEEPER-3386](https://issues.apache.org/jira/browse/ZOOKEEPER-3386) and [ZOOKEEPER-3461](https://issues.apache.org/jira/browse/ZOOKEEPER-3461))"},"comment":{"url":"https://api.github.com/repos/apache/zookeeper/issues/comments/524767482","html_url":"https://github.com/apache/zookeeper/pull/1048#issuecomment-524767482","issue_url":"https://api.github.com/repos/apache/zookeeper/issues/1048","id":524767482,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNDc2NzQ4Mg==","user":{"login":"symat","id":18458499,"node_id":"MDQ6VXNlcjE4NDU4NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/18458499?v=4","gravatar_id":"","url":"https://api.github.com/users/symat","html_url":"https://github.com/symat","followers_url":"https://api.github.com/users/symat/followers","following_url":"https://api.github.com/users/symat/following{/other_user}","gists_url":"https://api.github.com/users/symat/gists{/gist_id}","starred_url":"https://api.github.com/users/symat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symat/subscriptions","organizations_url":"https://api.github.com/users/symat/orgs","repos_url":"https://api.github.com/users/symat/repos","events_url":"https://api.github.com/users/symat/events{/privacy}","received_events_url":"https://api.github.com/users/symat/received_events","type":"User","site_admin":false},"created_at":"2019-08-26T08:19:56Z","updated_at":"2019-08-26T08:19:56Z","author_association":"CONTRIBUTOR","body":"I merged with master again, because of minor conflicts with ZOOKEEPER-3448: _Introduce MessageTracker to assist debug leader and leaner connectivity issues._\r\nI executed all unit tests and also did a manual test with docker before pushing the merge commit."}}
other: {"actor":{"display_login":"symat"}}