payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/334625595","pull_request_review_id":301492549,"id":334625595,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDYyNTU5NQ==","diff_hunk":"@@ -16,6 +18,11 @@ public AdhocPayload(string[] files)\n \n         public async Task<string> UploadAsync(IBlobContainer payloadContainer, Action<string> log)\n         {\n+            if (FindFileNameDuplicate(out var duplicateName))","path":"src/Microsoft.DotNet.Helix/JobSender/Payloads/AdhocPayload.cs","position":null,"original_position":13,"commit_id":"fb40e4932a0079b1ae8a4e7df193aa85e7072fb9","original_commit_id":"a59581d7b092b09a26327a9970f1b8c7255c8f57","user":{"login":"lukas-lansky","id":1655944,"node_id":"MDQ6VXNlcjE2NTU5NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1655944?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-lansky","html_url":"https://github.com/lukas-lansky","followers_url":"https://api.github.com/users/lukas-lansky/followers","following_url":"https://api.github.com/users/lukas-lansky/following{/other_user}","gists_url":"https://api.github.com/users/lukas-lansky/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-lansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-lansky/subscriptions","organizations_url":"https://api.github.com/users/lukas-lansky/orgs","repos_url":"https://api.github.com/users/lukas-lansky/repos","events_url":"https://api.github.com/users/lukas-lansky/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-lansky/received_events","type":"User","site_admin":false},"body":"Oh well, I noticed we are not using domain-specific exceptions in the codebase. :-) Moving to the constructor and removing the exception. Adding few simple tests.","created_at":"2019-10-14T19:15:26Z","updated_at":"2019-10-14T19:15:26Z","html_url":"https://github.com/dotnet/arcade/pull/4112#discussion_r334625595","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/4112","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/334625595"},"html":{"href":"https://github.com/dotnet/arcade/pull/4112#discussion_r334625595"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/4112"}},"in_reply_to_id":334387184},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/4112","id":327694161,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3Njk0MTYx","html_url":"https://github.com/dotnet/arcade/pull/4112","diff_url":"https://github.com/dotnet/arcade/pull/4112.diff","patch_url":"https://github.com/dotnet/arcade/pull/4112.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/4112","number":4112,"state":"open","locked":false,"title":"WithFiles shouldn't accept multiple files with the same paths","user":{"login":"lukas-lansky","id":1655944,"node_id":"MDQ6VXNlcjE2NTU5NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1655944?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-lansky","html_url":"https://github.com/lukas-lansky","followers_url":"https://api.github.com/users/lukas-lansky/followers","following_url":"https://api.github.com/users/lukas-lansky/following{/other_user}","gists_url":"https://api.github.com/users/lukas-lansky/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-lansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-lansky/subscriptions","organizations_url":"https://api.github.com/users/lukas-lansky/orgs","repos_url":"https://api.github.com/users/lukas-lansky/repos","events_url":"https://api.github.com/users/lukas-lansky/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-lansky/received_events","type":"User","site_admin":false},"body":"The ticket is pretty straightforward. I'm working on checking the amount of ZIPs in production that have the property we now forbid so that we can be reasonably sure we won't break the world.","created_at":"2019-10-14T08:35:09Z","updated_at":"2019-10-14T19:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa0076d141c49f599901d559cd01684fccfd6d5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MattGal","id":7862010,"node_id":"MDQ6VXNlcjc4NjIwMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7862010?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},{"login":"alexperovich","id":10565410,"node_id":"MDQ6VXNlcjEwNTY1NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/10565410?v=4","gravatar_id":"","url":"https://api.github.com/users/alexperovich","html_url":"https://github.com/alexperovich","followers_url":"https://api.github.com/users/alexperovich/followers","following_url":"https://api.github.com/users/alexperovich/following{/other_user}","gists_url":"https://api.github.com/users/alexperovich/gists{/gist_id}","starred_url":"https://api.github.com/users/alexperovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexperovich/subscriptions","organizations_url":"https://api.github.com/users/alexperovich/orgs","repos_url":"https://api.github.com/users/alexperovich/repos","events_url":"https://api.github.com/users/alexperovich/events{/privacy}","received_events_url":"https://api.github.com/users/alexperovich/received_events","type":"User","site_admin":false},{"login":"riarenas","id":23242101,"node_id":"MDQ6VXNlcjIzMjQyMTAx","avatar_url":"https://avatars2.githubusercontent.com/u/23242101?v=4","gravatar_id":"","url":"https://api.github.com/users/riarenas","html_url":"https://github.com/riarenas","followers_url":"https://api.github.com/users/riarenas/followers","following_url":"https://api.github.com/users/riarenas/following{/other_user}","gists_url":"https://api.github.com/users/riarenas/gists{/gist_id}","starred_url":"https://api.github.com/users/riarenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riarenas/subscriptions","organizations_url":"https://api.github.com/users/riarenas/orgs","repos_url":"https://api.github.com/users/riarenas/repos","events_url":"https://api.github.com/users/riarenas/events{/privacy}","received_events_url":"https://api.github.com/users/riarenas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/4112/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/4112/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/4112/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/fb40e4932a0079b1ae8a4e7df193aa85e7072fb9","head":{"label":"lukas-lansky:disallow-same-names-in-zip","ref":"disallow-same-names-in-zip","sha":"fb40e4932a0079b1ae8a4e7df193aa85e7072fb9","user":{"login":"lukas-lansky","id":1655944,"node_id":"MDQ6VXNlcjE2NTU5NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1655944?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-lansky","html_url":"https://github.com/lukas-lansky","followers_url":"https://api.github.com/users/lukas-lansky/followers","following_url":"https://api.github.com/users/lukas-lansky/following{/other_user}","gists_url":"https://api.github.com/users/lukas-lansky/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-lansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-lansky/subscriptions","organizations_url":"https://api.github.com/users/lukas-lansky/orgs","repos_url":"https://api.github.com/users/lukas-lansky/repos","events_url":"https://api.github.com/users/lukas-lansky/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-lansky/received_events","type":"User","site_admin":false},"repo":{"id":214213492,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQyMTM0OTI=","name":"arcade","full_name":"lukas-lansky/arcade","private":false,"owner":{"login":"lukas-lansky","id":1655944,"node_id":"MDQ6VXNlcjE2NTU5NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1655944?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-lansky","html_url":"https://github.com/lukas-lansky","followers_url":"https://api.github.com/users/lukas-lansky/followers","following_url":"https://api.github.com/users/lukas-lansky/following{/other_user}","gists_url":"https://api.github.com/users/lukas-lansky/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-lansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-lansky/subscriptions","organizations_url":"https://api.github.com/users/lukas-lansky/orgs","repos_url":"https://api.github.com/users/lukas-lansky/repos","events_url":"https://api.github.com/users/lukas-lansky/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-lansky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukas-lansky/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/lukas-lansky/arcade","forks_url":"https://api.github.com/repos/lukas-lansky/arcade/forks","keys_url":"https://api.github.com/repos/lukas-lansky/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukas-lansky/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukas-lansky/arcade/teams","hooks_url":"https://api.github.com/repos/lukas-lansky/arcade/hooks","issue_events_url":"https://api.github.com/repos/lukas-lansky/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/lukas-lansky/arcade/events","assignees_url":"https://api.github.com/repos/lukas-lansky/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/lukas-lansky/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/lukas-lansky/arcade/tags","blobs_url":"https://api.github.com/repos/lukas-lansky/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukas-lansky/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukas-lansky/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukas-lansky/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukas-lansky/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/lukas-lansky/arcade/languages","stargazers_url":"https://api.github.com/repos/lukas-lansky/arcade/stargazers","contributors_url":"https://api.github.com/repos/lukas-lansky/arcade/contributors","subscribers_url":"https://api.github.com/repos/lukas-lansky/arcade/subscribers","subscription_url":"https://api.github.com/repos/lukas-lansky/arcade/subscription","commits_url":"https://api.github.com/repos/lukas-lansky/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukas-lansky/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukas-lansky/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukas-lansky/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukas-lansky/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/lukas-lansky/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukas-lansky/arcade/merges","archive_url":"https://api.github.com/repos/lukas-lansky/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukas-lansky/arcade/downloads","issues_url":"https://api.github.com/repos/lukas-lansky/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/lukas-lansky/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/lukas-lansky/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/lukas-lansky/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukas-lansky/arcade/labels{/name}","releases_url":"https://api.github.com/repos/lukas-lansky/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/lukas-lansky/arcade/deployments","created_at":"2019-10-10T15:05:44Z","updated_at":"2019-10-10T15:05:45Z","pushed_at":"2019-10-14T19:13:29Z","git_url":"git://github.com/lukas-lansky/arcade.git","ssh_url":"git@github.com:lukas-lansky/arcade.git","clone_url":"https://github.com/lukas-lansky/arcade.git","svn_url":"https://github.com/lukas-lansky/arcade","homepage":"","size":16913,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"64a027b8d8b3a8e8e214bb00da02148335e3bd92","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2019-10-14T17:30:40Z","pushed_at":"2019-10-14T19:13:31Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"git@github.com:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":16926,"stargazers_count":269,"watchers_count":269,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":457,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":124,"open_issues":457,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/4112"},"html":{"href":"https://github.com/dotnet/arcade/pull/4112"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/4112"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/4112/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/4112/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/4112/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/fb40e4932a0079b1ae8a4e7df193aa85e7072fb9"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"lukas-lansky"}}