payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/280084173","pull_request_review_id":232585528,"id":280084173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDA4NDE3Mw==","diff_hunk":"@@ -1534,13 +1528,48 @@ namespace hp\n   void\n   DoFHandler<dim, spacedim>::set_fe(const hp::FECollection<dim, spacedim> &ff)\n   {\n+    Assert(\n+      tria != nullptr,\n+      ExcMessage(\n+        \"You need to set the Triangulation in the DoFHandler using initialize() or \"\n+        \"in the constructor before you can distribute DoFs.\"));\n+    Assert(tria->n_levels() > 0,\n+           ExcMessage(\"The Triangulation you are using is empty!\"));\n+    Assert(ff.size() > 0, ExcMessage(\"The hp::FECollection given is empty!\"));\n+\n     // don't create a new object if the one we have is already appropriate\n     if (fe_collection != ff)\n       fe_collection = hp::FECollection<dim, spacedim>(ff);\n \n+    // If an underlying shared::Tria allows artificial cells,\n+    // then save the current set of subdomain ids, and set\n+    // subdomain ids to the \"true\" owner of each cell. we later\n+    // restore these flags\n+    const parallel::shared::Triangulation<dim, spacedim> *shared_tria =\n+      (dynamic_cast<const parallel::shared::Triangulation<dim, spacedim> *>(\n+        &get_triangulation()));\n+    std::vector<types::subdomain_id> saved_subdomain_ids;\n+    if (shared_tria != nullptr && shared_tria->with_artificial_cells())","path":"source/hp/dof_handler.cc","position":67,"original_position":67,"commit_id":"effef67a476f2ff05af9f20f73043c0c21adca2c","original_commit_id":"effef67a476f2ff05af9f20f73043c0c21adca2c","user":{"login":"bangerth","id":7504421,"node_id":"MDQ6VXNlcjc1MDQ0MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7504421?v=4","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"and here","created_at":"2019-05-01T14:15:37Z","updated_at":"2019-05-01T14:23:25Z","html_url":"https://github.com/dealii/dealii/pull/7933#discussion_r280084173","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/7933","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/280084173"},"html":{"href":"https://github.com/dealii/dealii/pull/7933#discussion_r280084173"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7933"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/7933","id":271672200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNjcyMjAw","html_url":"https://github.com/dealii/dealii/pull/7933","diff_url":"https://github.com/dealii/dealii/pull/7933.diff","patch_url":"https://github.com/dealii/dealii/pull/7933.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/7933","number":7933,"state":"open","locked":false,"title":"True subdomains for CellWeights in GridTools::partition_triangulation().","user":{"login":"marcfehling","id":18285973,"node_id":"MDQ6VXNlcjE4Mjg1OTcz","avatar_url":"https://avatars0.githubusercontent.com/u/18285973?v=4","gravatar_id":"","url":"https://api.github.com/users/marcfehling","html_url":"https://github.com/marcfehling","followers_url":"https://api.github.com/users/marcfehling/followers","following_url":"https://api.github.com/users/marcfehling/following{/other_user}","gists_url":"https://api.github.com/users/marcfehling/gists{/gist_id}","starred_url":"https://api.github.com/users/marcfehling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcfehling/subscriptions","organizations_url":"https://api.github.com/users/marcfehling/orgs","repos_url":"https://api.github.com/users/marcfehling/repos","events_url":"https://api.github.com/users/marcfehling/events{/privacy}","received_events_url":"https://api.github.com/users/marcfehling/received_events","type":"User","site_admin":false},"body":"Woops: For tests in #7305, I did only consider `p::s::Triangulation` objects without artificial cells. These tests fail when taking into account artificial ones: For partitioning with individual cell weights, we have to make the `active_fe_index` information available on all cells. This is achieved by temporarily modifying the subdomains to become the 'true' ones.\r\n\r\nFurther, while transferring `active_fe_indices` during refinement and/or coarsening, we need to communicate all indices not before, but after the triangulation was changed. This will make sure that all `active_fe_indices` are available for partitioning during the `p::s::Triangulation::execute_coarsening_and_refinement()` call.\r\n\r\nHowever, if someone would like to directly partition the mesh via `GridTools::partition_triangulation()` we cannot make sure that all `active_fe_indices` have been broadcasted before. And I don't know how to check this via an assertion. Do you have an idea how to cope with that? Or shall we provide a note in the documentation instead?\r\n\r\nEDIT: Further, I enhanced the `hp::DoFHandler::set_fe()` function with assertions and the communiction of all `active_fe_indices`. `hp::DoFHandler::distribute_dofs()` now calls this function right in the beginning. Part of #3511.","created_at":"2019-04-18T12:39:44Z","updated_at":"2019-05-01T14:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b251d8c76aa394bfe55a213c914fb0c29250b447","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/7933/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/7933/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/7933/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/effef67a476f2ff05af9f20f73043c0c21adca2c","head":{"label":"marcfehling:weights-artificial","ref":"weights-artificial","sha":"effef67a476f2ff05af9f20f73043c0c21adca2c","user":{"login":"marcfehling","id":18285973,"node_id":"MDQ6VXNlcjE4Mjg1OTcz","avatar_url":"https://avatars0.githubusercontent.com/u/18285973?v=4","gravatar_id":"","url":"https://api.github.com/users/marcfehling","html_url":"https://github.com/marcfehling","followers_url":"https://api.github.com/users/marcfehling/followers","following_url":"https://api.github.com/users/marcfehling/following{/other_user}","gists_url":"https://api.github.com/users/marcfehling/gists{/gist_id}","starred_url":"https://api.github.com/users/marcfehling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcfehling/subscriptions","organizations_url":"https://api.github.com/users/marcfehling/orgs","repos_url":"https://api.github.com/users/marcfehling/repos","events_url":"https://api.github.com/users/marcfehling/events{/privacy}","received_events_url":"https://api.github.com/users/marcfehling/received_events","type":"User","site_admin":false},"repo":{"id":116528450,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY1Mjg0NTA=","name":"dealii","full_name":"marcfehling/dealii","private":false,"owner":{"login":"marcfehling","id":18285973,"node_id":"MDQ6VXNlcjE4Mjg1OTcz","avatar_url":"https://avatars0.githubusercontent.com/u/18285973?v=4","gravatar_id":"","url":"https://api.github.com/users/marcfehling","html_url":"https://github.com/marcfehling","followers_url":"https://api.github.com/users/marcfehling/followers","following_url":"https://api.github.com/users/marcfehling/following{/other_user}","gists_url":"https://api.github.com/users/marcfehling/gists{/gist_id}","starred_url":"https://api.github.com/users/marcfehling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcfehling/subscriptions","organizations_url":"https://api.github.com/users/marcfehling/orgs","repos_url":"https://api.github.com/users/marcfehling/repos","events_url":"https://api.github.com/users/marcfehling/events{/privacy}","received_events_url":"https://api.github.com/users/marcfehling/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marcfehling/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/marcfehling/dealii","forks_url":"https://api.github.com/repos/marcfehling/dealii/forks","keys_url":"https://api.github.com/repos/marcfehling/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcfehling/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcfehling/dealii/teams","hooks_url":"https://api.github.com/repos/marcfehling/dealii/hooks","issue_events_url":"https://api.github.com/repos/marcfehling/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/marcfehling/dealii/events","assignees_url":"https://api.github.com/repos/marcfehling/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/marcfehling/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/marcfehling/dealii/tags","blobs_url":"https://api.github.com/repos/marcfehling/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcfehling/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcfehling/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcfehling/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcfehling/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/marcfehling/dealii/languages","stargazers_url":"https://api.github.com/repos/marcfehling/dealii/stargazers","contributors_url":"https://api.github.com/repos/marcfehling/dealii/contributors","subscribers_url":"https://api.github.com/repos/marcfehling/dealii/subscribers","subscription_url":"https://api.github.com/repos/marcfehling/dealii/subscription","commits_url":"https://api.github.com/repos/marcfehling/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcfehling/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcfehling/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcfehling/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcfehling/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/marcfehling/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcfehling/dealii/merges","archive_url":"https://api.github.com/repos/marcfehling/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcfehling/dealii/downloads","issues_url":"https://api.github.com/repos/marcfehling/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/marcfehling/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/marcfehling/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/marcfehling/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcfehling/dealii/labels{/name}","releases_url":"https://api.github.com/repos/marcfehling/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/marcfehling/dealii/deployments","created_at":"2018-01-07T01:30:14Z","updated_at":"2019-04-17T20:00:52Z","pushed_at":"2019-04-20T10:34:47Z","git_url":"git://github.com/marcfehling/dealii.git","ssh_url":"git@github.com:marcfehling/dealii.git","clone_url":"https://github.com/marcfehling/dealii.git","svn_url":"https://github.com/marcfehling/dealii","homepage":"http://www.dealii.org/","size":213363,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"fd71ce317b43615aab60f499fc7336a4f2fda2cb","user":{"login":"dealii","id":7506070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MDYwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk0Mzk4MA==","name":"dealii","full_name":"dealii/dealii","private":false,"owner":{"login":"dealii","id":7506070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MDYwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2019-05-01T14:12:30Z","pushed_at":"2019-05-01T14:12:25Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"https://www.dealii.org/","size":213645,"stargazers_count":446,"watchers_count":446,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":350,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":349,"open_issues":350,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7933"},"html":{"href":"https://github.com/dealii/dealii/pull/7933"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/7933"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/7933/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7933/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7933/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/effef67a476f2ff05af9f20f73043c0c21adca2c"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"bangerth"}}