payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/266389156","pull_request_review_id":215534788,"id":266389156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjM4OTE1Ng==","diff_hunk":"@@ -5,13 +5,12 @@\n #include \"platform/constants.hpp\"\n #include \"platform/mwm_version.hpp\"\n \n-\n-void FeaturesVector::GetByIndex(uint32_t index, FeatureType & ft) const\n+std::unique_ptr<FeatureType> FeaturesVector::GetByIndex(uint32_t index) const\n {\n   uint32_t offset = 0, size = 0;\n   auto const ftOffset = m_table ? m_table->GetFeatureOffset(index) : index;\n   m_recordReader.ReadRecord(ftOffset, m_buffer, offset, size);\n-  ft.Deserialize(&m_loadInfo, &m_buffer[offset]);\n+  return make_unique<FeatureType>(&m_loadInfo, &m_buffer[offset]);","path":"indexer/features_vector.cpp","position":null,"original_position":12,"commit_id":"96a020a7e8beb8c49b604c98cd2a93080f2c930d","original_commit_id":"33fe959c27b6f2c19418eb50785256d7c38e99eb","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"body":"done","created_at":"2019-03-18T11:04:19Z","updated_at":"2019-03-18T11:04:19Z","html_url":"https://github.com/mapsme/omim/pull/10521#discussion_r266389156","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/10521","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/266389156"},"html":{"href":"https://github.com/mapsme/omim/pull/10521#discussion_r266389156"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/10521"}},"in_reply_to_id":266356215},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/10521","id":260344483,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMzQ0NDgz","html_url":"https://github.com/mapsme/omim/pull/10521","diff_url":"https://github.com/mapsme/omim/pull/10521.diff","patch_url":"https://github.com/mapsme/omim/pull/10521.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/10521","number":10521,"state":"open","locked":false,"title":"[indexer] Disallow copy and move of FeatureType, remove FeatureType::ParseEverything().","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-12T12:37:31Z","updated_at":"2019-03-18T11:04:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1ce0efaf062770d519f5484788cd7ee229e4ad5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/10521/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/10521/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/10521/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/96a020a7e8beb8c49b604c98cd2a93080f2c930d","head":{"label":"tatiana-yan:featuretype","ref":"featuretype","sha":"96a020a7e8beb8c49b604c98cd2a93080f2c930d","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE4MDA5MA==","name":"omim","full_name":"tatiana-yan/omim","private":false,"owner":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tatiana-yan/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-yan/omim","forks_url":"https://api.github.com/repos/tatiana-yan/omim/forks","keys_url":"https://api.github.com/repos/tatiana-yan/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-yan/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-yan/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-yan/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-yan/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-yan/omim/events","assignees_url":"https://api.github.com/repos/tatiana-yan/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-yan/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-yan/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-yan/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-yan/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-yan/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-yan/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-yan/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-yan/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-yan/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-yan/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-yan/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-yan/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-yan/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-yan/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-yan/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-yan/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-yan/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-yan/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-yan/omim/merges","archive_url":"https://api.github.com/repos/tatiana-yan/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-yan/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-yan/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-yan/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-yan/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-yan/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-yan/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-yan/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-yan/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2019-03-14T07:36:23Z","pushed_at":"2019-03-18T11:03:28Z","git_url":"git://github.com/tatiana-yan/omim.git","ssh_url":"git@github.com:tatiana-yan/omim.git","clone_url":"https://github.com/tatiana-yan/omim.git","svn_url":"https://github.com/tatiana-yan/omim","homepage":"","size":4254129,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"df74955d404c895c3b4f4cf0772f9e2f9d6557e9","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","private":false,"owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2019-03-18T10:47:32Z","pushed_at":"2019-03-18T11:04:01Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":4298415,"stargazers_count":2958,"watchers_count":2958,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":637,"mirror_url":null,"archived":false,"open_issues_count":782,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":637,"open_issues":782,"watchers":2958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/10521"},"html":{"href":"https://github.com/mapsme/omim/pull/10521"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/10521"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/10521/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/10521/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/10521/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/96a020a7e8beb8c49b604c98cd2a93080f2c930d"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"tatiana-yan"}}