payload: {"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/284165949","pull_request_review_id":237707050,"id":284165949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDE2NTk0OQ==","diff_hunk":"@@ -235,17 +235,18 @@ class view_take_until : public ranges::view_interface<view_take_until<urng_t, fu\n         //!\\brief Defaulted.\n         ~iterator_type_consume_input()                                                             = default;\n \n-        //!\\brief Constructor that delegates to the CRTP layer.\n-        iterator_type_consume_input(base_base_t it) noexcept(noexcept(base_t{it})) :\n-            base_t{std::move(it)}\n-        {}\n-\n         //!\\brief Constructor that delegates to the CRTP layer and initialises the callable.\n         iterator_type_consume_input(base_base_t it,\n                                     fun_ref_t _fun,\n                                     sentinel_type sen) noexcept(noexcept(base_t{it})) :\n             base_t{std::move(it)}, fun{_fun}, stored_end{std::move(sen)}\n-        {}\n+        {\n+            while (fun(**this))\n+            {\n+                at_end_gracefully = true;\n+                base_t::operator++();\n+            }\n+        }","path":"include/seqan3/range/view/take_until.hpp","position":18,"original_position":21,"commit_id":"7b978265c08a295cf6cffe5ead57bb5c34ddb162","original_commit_id":"99184c4cbfedb17aa275f55f28b0191be810d45d","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"body":"this is not completely correct because you skip the first character that evaluated to true and `at_end_gracefully` was not set :o ","created_at":"2019-05-15T09:29:23Z","updated_at":"2019-05-15T09:29:23Z","html_url":"https://github.com/seqan/seqan3/pull/972#discussion_r284165949","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/972","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/284165949"},"html":{"href":"https://github.com/seqan/seqan3/pull/972#discussion_r284165949"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/972"}},"in_reply_to_id":283876407},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/972","id":278665224,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4NjY1MjI0","html_url":"https://github.com/seqan/seqan3/pull/972","diff_url":"https://github.com/seqan/seqan3/pull/972.diff","patch_url":"https://github.com/seqan/seqan3/pull/972.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/972","number":972,"state":"open","locked":false,"title":"[FIX] make view::take consume also at the very beginning.","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"body":"Resolves #950","created_at":"2019-05-14T12:44:09Z","updated_at":"2019-05-15T09:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2c4c00d3fe4f3d20d91d049bb9f1e6bdf5ceead","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/972/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/972/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/972/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/7b978265c08a295cf6cffe5ead57bb5c34ddb162","head":{"label":"smehringer:fix_take_until","ref":"fix_take_until","sha":"7b978265c08a295cf6cffe5ead57bb5c34ddb162","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"repo":{"id":85708703,"node_id":"MDEwOlJlcG9zaXRvcnk4NTcwODcwMw==","name":"seqan3","full_name":"smehringer/seqan3","private":false,"owner":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smehringer/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/smehringer/seqan3","forks_url":"https://api.github.com/repos/smehringer/seqan3/forks","keys_url":"https://api.github.com/repos/smehringer/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smehringer/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smehringer/seqan3/teams","hooks_url":"https://api.github.com/repos/smehringer/seqan3/hooks","issue_events_url":"https://api.github.com/repos/smehringer/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/smehringer/seqan3/events","assignees_url":"https://api.github.com/repos/smehringer/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/smehringer/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/smehringer/seqan3/tags","blobs_url":"https://api.github.com/repos/smehringer/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smehringer/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smehringer/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/smehringer/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smehringer/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/smehringer/seqan3/languages","stargazers_url":"https://api.github.com/repos/smehringer/seqan3/stargazers","contributors_url":"https://api.github.com/repos/smehringer/seqan3/contributors","subscribers_url":"https://api.github.com/repos/smehringer/seqan3/subscribers","subscription_url":"https://api.github.com/repos/smehringer/seqan3/subscription","commits_url":"https://api.github.com/repos/smehringer/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/smehringer/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/smehringer/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/smehringer/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/smehringer/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/smehringer/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smehringer/seqan3/merges","archive_url":"https://api.github.com/repos/smehringer/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smehringer/seqan3/downloads","issues_url":"https://api.github.com/repos/smehringer/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/smehringer/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/smehringer/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/smehringer/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smehringer/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/smehringer/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/smehringer/seqan3/deployments","created_at":"2017-03-21T14:00:28Z","updated_at":"2019-05-14T07:34:38Z","pushed_at":"2019-05-15T09:07:03Z","git_url":"git://github.com/smehringer/seqan3.git","ssh_url":"git@github.com:smehringer/seqan3.git","clone_url":"https://github.com/smehringer/seqan3.git","svn_url":"https://github.com/smehringer/seqan3","homepage":"http://www.seqan.de","size":4864,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"76bba77ff4a9afbebcdcae602b772549fb4da757","user":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQxMDA3OA==","name":"seqan3","full_name":"seqan/seqan3","private":false,"owner":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2019-05-15T05:30:01Z","pushed_at":"2019-05-15T09:07:04Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":4794,"stargazers_count":53,"watchers_count":53,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":142,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":142,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/972"},"html":{"href":"https://github.com/seqan/seqan3/pull/972"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/972"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/972/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/972/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/972/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/7b978265c08a295cf6cffe5ead57bb5c34ddb162"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"smehringer"}}