payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/comments/283581708","pull_request_review_id":236972888,"id":283581708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzU4MTcwOA==","diff_hunk":"@@ -1152,7 +1153,8 @@ def max_proj(self, *dims: Axes) -> \"ImageStack\":\n         max_projection = self._data.max([dim.value for dim in dims])\n         max_projection = max_projection.expand_dims(tuple(dim.value for dim in dims))\n         max_projection = max_projection.transpose(*self.xarray.dims)\n-        max_proj_stack = self.from_numpy(max_projection.values)\n+        physical_coords = self.xarray.coords\n+        max_proj_stack = self.from_numpy(max_projection.values, coordinates=physical_coords)","path":"starfish/core/imagestack/imagestack.py","position":23,"original_position":23,"commit_id":"b6f2ecc3a685040a4bcd357b915271034f4d2196","original_commit_id":"b6f2ecc3a685040a4bcd357b915271034f4d2196","user":{"login":"ttung","id":280924,"node_id":"MDQ6VXNlcjI4MDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/280924?v=4","gravatar_id":"","url":"https://api.github.com/users/ttung","html_url":"https://github.com/ttung","followers_url":"https://api.github.com/users/ttung/followers","following_url":"https://api.github.com/users/ttung/following{/other_user}","gists_url":"https://api.github.com/users/ttung/gists{/gist_id}","starred_url":"https://api.github.com/users/ttung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttung/subscriptions","organizations_url":"https://api.github.com/users/ttung/orgs","repos_url":"https://api.github.com/users/ttung/repos","events_url":"https://api.github.com/users/ttung/events{/privacy}","received_events_url":"https://api.github.com/users/ttung/received_events","type":"User","site_admin":false},"body":"the coordinates passed in here should be shaped like the array passed in here.  the z averaging should happen here.","created_at":"2019-05-14T00:00:56Z","updated_at":"2019-05-14T00:01:52Z","html_url":"https://github.com/spacetx/starfish/pull/1291#discussion_r283581708","pull_request_url":"https://api.github.com/repos/spacetx/starfish/pulls/1291","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments/283581708"},"html":{"href":"https://github.com/spacetx/starfish/pull/1291#discussion_r283581708"},"pull_request":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/1291"}}},"pull_request":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/1291","id":274511582,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NTExNTgy","html_url":"https://github.com/spacetx/starfish/pull/1291","diff_url":"https://github.com/spacetx/starfish/pull/1291.diff","patch_url":"https://github.com/spacetx/starfish/pull/1291.patch","issue_url":"https://api.github.com/repos/spacetx/starfish/issues/1291","number":1291,"state":"open","locked":false,"title":"Fixing coordinate issues with max_proj","user":{"login":"shanaxel42","id":6810854,"node_id":"MDQ6VXNlcjY4MTA4NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6810854?v=4","gravatar_id":"","url":"https://api.github.com/users/shanaxel42","html_url":"https://github.com/shanaxel42","followers_url":"https://api.github.com/users/shanaxel42/followers","following_url":"https://api.github.com/users/shanaxel42/following{/other_user}","gists_url":"https://api.github.com/users/shanaxel42/gists{/gist_id}","starred_url":"https://api.github.com/users/shanaxel42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanaxel42/subscriptions","organizations_url":"https://api.github.com/users/shanaxel42/orgs","repos_url":"https://api.github.com/users/shanaxel42/repos","events_url":"https://api.github.com/users/shanaxel42/events{/privacy}","received_events_url":"https://api.github.com/users/shanaxel42/received_events","type":"User","site_admin":false},"body":"Fixes #1214","created_at":"2019-04-29T20:24:44Z","updated_at":"2019-05-14T00:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"195ef3185c8e9d15d7fa4cadeb850c0c72112d39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacetx/starfish/pulls/1291/commits","review_comments_url":"https://api.github.com/repos/spacetx/starfish/pulls/1291/comments","review_comment_url":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetx/starfish/issues/1291/comments","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/b6f2ecc3a685040a4bcd357b915271034f4d2196","head":{"label":"spacetx:saxelrod-fix-max-proj","ref":"saxelrod-fix-max-proj","sha":"b6f2ecc3a685040a4bcd357b915271034f4d2196","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"starfish: standardized pipelines for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2019-05-13T21:23:35Z","pushed_at":"2019-05-13T23:35:54Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"https://spacetx-starfish.readthedocs.io/en/latest/","size":72426,"stargazers_count":70,"watchers_count":70,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":169,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":169,"watchers":70,"default_branch":"master"}},"base":{"label":"spacetx:master","ref":"master","sha":"30c76807917d7b5614b46082af09200eea07c0b9","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"starfish: standardized pipelines for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2019-05-13T21:23:35Z","pushed_at":"2019-05-13T23:35:54Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"https://spacetx-starfish.readthedocs.io/en/latest/","size":72426,"stargazers_count":70,"watchers_count":70,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":169,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":169,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/1291"},"html":{"href":"https://github.com/spacetx/starfish/pull/1291"},"issue":{"href":"https://api.github.com/repos/spacetx/starfish/issues/1291"},"comments":{"href":"https://api.github.com/repos/spacetx/starfish/issues/1291/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/1291/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/1291/commits"},"statuses":{"href":"https://api.github.com/repos/spacetx/starfish/statuses/b6f2ecc3a685040a4bcd357b915271034f4d2196"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"ttung"}}