payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/comments/338633324","pull_request_review_id":306655453,"id":338633324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODYzMzMyNA==","diff_hunk":"@@ -2,16 +2,26 @@ import { by, browser, element } from 'protractor';\n \n import { Utils } from './pages/app.utils';\n \n-describe('Zonemaster test GR10 - [The preDelegatedDomainCheck view should have a shortcut to undelegated view and FAQ]', () => {\n+describe('Zonemaster test GR10 - [The undelegated view should have a text describing what undelegated means?]', () => {","path":"e2e/GR10.e2e-spec.ts","position":5,"original_position":5,"commit_id":"827b6ba552838f5707ee0fe219218a5341ed4bc6","original_commit_id":"827b6ba552838f5707ee0fe219218a5341ed4bc6","user":{"login":"matsduf","id":5430733,"node_id":"MDQ6VXNlcjU0MzA3MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5430733?v=4","gravatar_id":"","url":"https://api.github.com/users/matsduf","html_url":"https://github.com/matsduf","followers_url":"https://api.github.com/users/matsduf/followers","following_url":"https://api.github.com/users/matsduf/following{/other_user}","gists_url":"https://api.github.com/users/matsduf/gists{/gist_id}","starred_url":"https://api.github.com/users/matsduf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsduf/subscriptions","organizations_url":"https://api.github.com/users/matsduf/orgs","repos_url":"https://api.github.com/users/matsduf/repos","events_url":"https://api.github.com/users/matsduf/events{/privacy}","received_events_url":"https://api.github.com/users/matsduf/received_events","type":"User","site_admin":false},"body":"The document [undelegated-test] defines an undelegated test. Does that work?\r\n\r\n[undelegated-test]: https://github.com/zonemaster/zonemaster/blob/master/docs/specifications/test-types/undelegated-test.md","created_at":"2019-10-24T15:13:24Z","updated_at":"2019-10-24T15:13:24Z","html_url":"https://github.com/zonemaster/zonemaster-gui/pull/82#discussion_r338633324","pull_request_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/comments/338633324"},"html":{"href":"https://github.com/zonemaster/zonemaster-gui/pull/82#discussion_r338633324"},"pull_request":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82"}},"in_reply_to_id":338517021},"pull_request":{"url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82","id":331908597,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxOTA4NTk3","html_url":"https://github.com/zonemaster/zonemaster-gui/pull/82","diff_url":"https://github.com/zonemaster/zonemaster-gui/pull/82.diff","patch_url":"https://github.com/zonemaster/zonemaster-gui/pull/82.patch","issue_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues/82","number":82,"state":"open","locked":false,"title":"Automated testing with protractor and travis","user":{"login":"pamasse","id":28790708,"node_id":"MDQ6VXNlcjI4NzkwNzA4","avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"body":"Based on the old_zonemaster repo, i just translate some perl tests in protractor.\r\nProtractor is a JavaScript framework on top of Selenium which run a headless chrome/firefox and navigate (click, change page, use form ...) on a webapp to test it.\r\n\r\nI also add a .travis.yml to run tests before each PR.\r\nThe last two tests (predelegated and simple test) are end-2-end test and depends on zonemaster.net.\r\n\r\nRun a test take around 5min.\r\n\r\nfix #68 ","created_at":"2019-10-24T07:58:36Z","updated_at":"2019-10-24T15:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61add14e59e6363f9008caef4af9117ab3fd9787","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matsduf","id":5430733,"node_id":"MDQ6VXNlcjU0MzA3MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5430733?v=4","gravatar_id":"","url":"https://api.github.com/users/matsduf","html_url":"https://github.com/matsduf","followers_url":"https://api.github.com/users/matsduf/followers","following_url":"https://api.github.com/users/matsduf/following{/other_user}","gists_url":"https://api.github.com/users/matsduf/gists{/gist_id}","starred_url":"https://api.github.com/users/matsduf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsduf/subscriptions","organizations_url":"https://api.github.com/users/matsduf/orgs","repos_url":"https://api.github.com/users/matsduf/repos","events_url":"https://api.github.com/users/matsduf/events{/privacy}","received_events_url":"https://api.github.com/users/matsduf/received_events","type":"User","site_admin":false},{"login":"mtoma","id":5492426,"node_id":"MDQ6VXNlcjU0OTI0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5492426?v=4","gravatar_id":"","url":"https://api.github.com/users/mtoma","html_url":"https://github.com/mtoma","followers_url":"https://api.github.com/users/mtoma/followers","following_url":"https://api.github.com/users/mtoma/following{/other_user}","gists_url":"https://api.github.com/users/mtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/mtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtoma/subscriptions","organizations_url":"https://api.github.com/users/mtoma/orgs","repos_url":"https://api.github.com/users/mtoma/repos","events_url":"https://api.github.com/users/mtoma/events{/privacy}","received_events_url":"https://api.github.com/users/mtoma/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/zonemaster/zonemaster-gui/milestones/5","html_url":"https://github.com/zonemaster/zonemaster-gui/milestone/5","labels_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/milestones/5/labels","id":4136701,"node_id":"MDk6TWlsZXN0b25lNDEzNjcwMQ==","number":5,"title":"v2019.2","description":"First major release for 2019","creator":{"login":"sandoche2k","id":5484470,"node_id":"MDQ6VXNlcjU0ODQ0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5484470?v=4","gravatar_id":"","url":"https://api.github.com/users/sandoche2k","html_url":"https://github.com/sandoche2k","followers_url":"https://api.github.com/users/sandoche2k/followers","following_url":"https://api.github.com/users/sandoche2k/following{/other_user}","gists_url":"https://api.github.com/users/sandoche2k/gists{/gist_id}","starred_url":"https://api.github.com/users/sandoche2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandoche2k/subscriptions","organizations_url":"https://api.github.com/users/sandoche2k/orgs","repos_url":"https://api.github.com/users/sandoche2k/repos","events_url":"https://api.github.com/users/sandoche2k/events{/privacy}","received_events_url":"https://api.github.com/users/sandoche2k/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":22,"state":"open","created_at":"2019-03-13T11:16:35Z","updated_at":"2019-10-24T08:40:03Z","due_on":"2019-11-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82/commits","review_comments_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82/comments","review_comment_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues/82/comments","statuses_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/statuses/827b6ba552838f5707ee0fe219218a5341ed4bc6","head":{"label":"pamasse:fix-68-automated-testing-e2e","ref":"fix-68-automated-testing-e2e","sha":"827b6ba552838f5707ee0fe219218a5341ed4bc6","user":{"login":"pamasse","id":28790708,"node_id":"MDQ6VXNlcjI4NzkwNzA4","avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"repo":{"id":138559550,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1NTk1NTA=","name":"zonemaster-gui","full_name":"pamasse/zonemaster-gui","private":false,"owner":{"login":"pamasse","id":28790708,"node_id":"MDQ6VXNlcjI4NzkwNzA4","avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pamasse/zonemaster-gui","description":"The Zonemaster GUI - part of the Zonemaster project ","fork":true,"url":"https://api.github.com/repos/pamasse/zonemaster-gui","forks_url":"https://api.github.com/repos/pamasse/zonemaster-gui/forks","keys_url":"https://api.github.com/repos/pamasse/zonemaster-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pamasse/zonemaster-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pamasse/zonemaster-gui/teams","hooks_url":"https://api.github.com/repos/pamasse/zonemaster-gui/hooks","issue_events_url":"https://api.github.com/repos/pamasse/zonemaster-gui/issues/events{/number}","events_url":"https://api.github.com/repos/pamasse/zonemaster-gui/events","assignees_url":"https://api.github.com/repos/pamasse/zonemaster-gui/assignees{/user}","branches_url":"https://api.github.com/repos/pamasse/zonemaster-gui/branches{/branch}","tags_url":"https://api.github.com/repos/pamasse/zonemaster-gui/tags","blobs_url":"https://api.github.com/repos/pamasse/zonemaster-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pamasse/zonemaster-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pamasse/zonemaster-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/pamasse/zonemaster-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pamasse/zonemaster-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/pamasse/zonemaster-gui/languages","stargazers_url":"https://api.github.com/repos/pamasse/zonemaster-gui/stargazers","contributors_url":"https://api.github.com/repos/pamasse/zonemaster-gui/contributors","subscribers_url":"https://api.github.com/repos/pamasse/zonemaster-gui/subscribers","subscription_url":"https://api.github.com/repos/pamasse/zonemaster-gui/subscription","commits_url":"https://api.github.com/repos/pamasse/zonemaster-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/pamasse/zonemaster-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/pamasse/zonemaster-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/pamasse/zonemaster-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/pamasse/zonemaster-gui/contents/{+path}","compare_url":"https://api.github.com/repos/pamasse/zonemaster-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pamasse/zonemaster-gui/merges","archive_url":"https://api.github.com/repos/pamasse/zonemaster-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pamasse/zonemaster-gui/downloads","issues_url":"https://api.github.com/repos/pamasse/zonemaster-gui/issues{/number}","pulls_url":"https://api.github.com/repos/pamasse/zonemaster-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/pamasse/zonemaster-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/pamasse/zonemaster-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pamasse/zonemaster-gui/labels{/name}","releases_url":"https://api.github.com/repos/pamasse/zonemaster-gui/releases{/id}","deployments_url":"https://api.github.com/repos/pamasse/zonemaster-gui/deployments","created_at":"2018-06-25T07:36:26Z","updated_at":"2019-10-08T12:58:44Z","pushed_at":"2019-10-24T08:34:34Z","git_url":"git://github.com/pamasse/zonemaster-gui.git","ssh_url":"git@github.com:pamasse/zonemaster-gui.git","clone_url":"https://github.com/pamasse/zonemaster-gui.git","svn_url":"https://github.com/pamasse/zonemaster-gui","homepage":"","size":1231,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zonemaster:develop","ref":"develop","sha":"139e6e46f6e6cd19c61a5fc87140197d4cc9376c","user":{"login":"zonemaster","id":37844868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODQ0ODY4","avatar_url":"https://avatars2.githubusercontent.com/u/37844868?v=4","gravatar_id":"","url":"https://api.github.com/users/zonemaster","html_url":"https://github.com/zonemaster","followers_url":"https://api.github.com/users/zonemaster/followers","following_url":"https://api.github.com/users/zonemaster/following{/other_user}","gists_url":"https://api.github.com/users/zonemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/zonemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonemaster/subscriptions","organizations_url":"https://api.github.com/users/zonemaster/orgs","repos_url":"https://api.github.com/users/zonemaster/repos","events_url":"https://api.github.com/users/zonemaster/events{/privacy}","received_events_url":"https://api.github.com/users/zonemaster/received_events","type":"Organization","site_admin":false},"repo":{"id":138133182,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMzMxODI=","name":"zonemaster-gui","full_name":"zonemaster/zonemaster-gui","private":false,"owner":{"login":"zonemaster","id":37844868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODQ0ODY4","avatar_url":"https://avatars2.githubusercontent.com/u/37844868?v=4","gravatar_id":"","url":"https://api.github.com/users/zonemaster","html_url":"https://github.com/zonemaster","followers_url":"https://api.github.com/users/zonemaster/followers","following_url":"https://api.github.com/users/zonemaster/following{/other_user}","gists_url":"https://api.github.com/users/zonemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/zonemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonemaster/subscriptions","organizations_url":"https://api.github.com/users/zonemaster/orgs","repos_url":"https://api.github.com/users/zonemaster/repos","events_url":"https://api.github.com/users/zonemaster/events{/privacy}","received_events_url":"https://api.github.com/users/zonemaster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zonemaster/zonemaster-gui","description":"The Zonemaster GUI - part of the Zonemaster project ","fork":false,"url":"https://api.github.com/repos/zonemaster/zonemaster-gui","forks_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/forks","keys_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/teams","hooks_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/hooks","issue_events_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues/events{/number}","events_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/events","assignees_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/assignees{/user}","branches_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/branches{/branch}","tags_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/tags","blobs_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/languages","stargazers_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/stargazers","contributors_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/contributors","subscribers_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/subscribers","subscription_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/subscription","commits_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/contents/{+path}","compare_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/merges","archive_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/downloads","issues_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues{/number}","pulls_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/labels{/name}","releases_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/releases{/id}","deployments_url":"https://api.github.com/repos/zonemaster/zonemaster-gui/deployments","created_at":"2018-06-21T07:11:27Z","updated_at":"2019-05-24T09:34:53Z","pushed_at":"2019-10-24T08:34:35Z","git_url":"git://github.com/zonemaster/zonemaster-gui.git","ssh_url":"git@github.com:zonemaster/zonemaster-gui.git","clone_url":"https://github.com/zonemaster/zonemaster-gui.git","svn_url":"https://github.com/zonemaster/zonemaster-gui","homepage":"","size":583,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82"},"html":{"href":"https://github.com/zonemaster/zonemaster-gui/pull/82"},"issue":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues/82"},"comments":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/zonemaster/zonemaster-gui/statuses/827b6ba552838f5707ee0fe219218a5341ed4bc6"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"matsduf"}}