payload: {"action":"created","comment":{"url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/comments/357248162","pull_request_review_id":331365462,"id":357248162,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzI0ODE2Mg==","diff_hunk":"@@ -30,9 +30,12 @@ public LogEventMsgSet(AsyncLogEventInfo asyncLogEvent, ByteArray buffer, Message\n             currentMessage = 0;\n         }\n \n-        public LogEventMsgSet Build(Layout layout)\n+        public LogEventMsgSet Build(Layout layout, bool flushCompletion)\n         {\n-            logEntries = messageBuilder.BuildLogEntries(asyncLogEvent.LogEvent, layout);\n+            if (flushCompletion)\n+                logEntries = new string[0]; // Nothing to send\n+            else\n+                logEntries = messageBuilder.BuildLogEntries(asyncLogEvent.LogEvent, layout);","path":"src/NLog.Targets.Syslog/LogEventMsgSet.cs","position":11,"original_position":11,"commit_id":"f26a6505cda433beea0d98e673a925e9dda482e7","original_commit_id":"f26a6505cda433beea0d98e673a925e9dda482e7","user":{"login":"luigiberrettini","id":4513301,"node_id":"MDQ6VXNlcjQ1MTMzMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4513301?v=4","gravatar_id":"","url":"https://api.github.com/users/luigiberrettini","html_url":"https://github.com/luigiberrettini","followers_url":"https://api.github.com/users/luigiberrettini/followers","following_url":"https://api.github.com/users/luigiberrettini/following{/other_user}","gists_url":"https://api.github.com/users/luigiberrettini/gists{/gist_id}","starred_url":"https://api.github.com/users/luigiberrettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigiberrettini/subscriptions","organizations_url":"https://api.github.com/users/luigiberrettini/orgs","repos_url":"https://api.github.com/users/luigiberrettini/repos","events_url":"https://api.github.com/users/luigiberrettini/events{/privacy}","received_events_url":"https://api.github.com/users/luigiberrettini/received_events","type":"User","site_admin":false},"body":"The comment about the separate issue and PR is still valid","created_at":"2019-12-12T16:37:16Z","updated_at":"2019-12-12T16:37:17Z","html_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog/pull/200#discussion_r357248162","pull_request_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/comments/357248162"},"html":{"href":"https://github.com/luigiberrettini/NLog.Targets.Syslog/pull/200#discussion_r357248162"},"pull_request":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200"}},"in_reply_to_id":355435886},"pull_request":{"url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200","id":350406856,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwNDA2ODU2","html_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog/pull/200","diff_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog/pull/200.diff","patch_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog/pull/200.patch","issue_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues/200","number":200,"state":"open","locked":false,"title":"ByteArray - Optimize append by skipping char-array and byte-array allocations","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"body":"Writing string-objects directly into MemoryStream-buffer without temporary buffers.","created_at":"2019-12-08T12:22:52Z","updated_at":"2019-12-12T16:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7ab9934bb1b173ffaee660f84e601498828323c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200/commits","review_comments_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200/comments","review_comment_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues/200/comments","statuses_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/statuses/f26a6505cda433beea0d98e673a925e9dda482e7","head":{"label":"snakefoot:master","ref":"master","sha":"f26a6505cda433beea0d98e673a925e9dda482e7","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"repo":{"id":226555072,"node_id":"MDEwOlJlcG9zaXRvcnkyMjY1NTUwNzI=","name":"NLog.Targets.Syslog","full_name":"snakefoot/NLog.Targets.Syslog","private":false,"owner":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snakefoot/NLog.Targets.Syslog","description":"A Syslog server target for NLog","fork":true,"url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog","forks_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/forks","keys_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/teams","hooks_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/hooks","issue_events_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/issues/events{/number}","events_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/events","assignees_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/assignees{/user}","branches_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/branches{/branch}","tags_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/tags","blobs_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/statuses/{sha}","languages_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/languages","stargazers_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/stargazers","contributors_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/contributors","subscribers_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/subscribers","subscription_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/subscription","commits_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/contents/{+path}","compare_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/merges","archive_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/downloads","issues_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/issues{/number}","pulls_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/pulls{/number}","milestones_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/milestones{/number}","notifications_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/labels{/name}","releases_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/releases{/id}","deployments_url":"https://api.github.com/repos/snakefoot/NLog.Targets.Syslog/deployments","created_at":"2019-12-07T18:00:08Z","updated_at":"2019-12-08T21:16:34Z","pushed_at":"2019-12-08T21:16:32Z","git_url":"git://github.com/snakefoot/NLog.Targets.Syslog.git","ssh_url":"git@github.com:snakefoot/NLog.Targets.Syslog.git","clone_url":"https://github.com/snakefoot/NLog.Targets.Syslog.git","svn_url":"https://github.com/snakefoot/NLog.Targets.Syslog","homepage":"","size":5610,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luigiberrettini:master","ref":"master","sha":"b9df517e502cef466eab35d9f0e156a1ca0bd43a","user":{"login":"luigiberrettini","id":4513301,"node_id":"MDQ6VXNlcjQ1MTMzMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4513301?v=4","gravatar_id":"","url":"https://api.github.com/users/luigiberrettini","html_url":"https://github.com/luigiberrettini","followers_url":"https://api.github.com/users/luigiberrettini/followers","following_url":"https://api.github.com/users/luigiberrettini/following{/other_user}","gists_url":"https://api.github.com/users/luigiberrettini/gists{/gist_id}","starred_url":"https://api.github.com/users/luigiberrettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigiberrettini/subscriptions","organizations_url":"https://api.github.com/users/luigiberrettini/orgs","repos_url":"https://api.github.com/users/luigiberrettini/repos","events_url":"https://api.github.com/users/luigiberrettini/events{/privacy}","received_events_url":"https://api.github.com/users/luigiberrettini/received_events","type":"User","site_admin":false},"repo":{"id":717643,"node_id":"MDEwOlJlcG9zaXRvcnk3MTc2NDM=","name":"NLog.Targets.Syslog","full_name":"luigiberrettini/NLog.Targets.Syslog","private":false,"owner":{"login":"luigiberrettini","id":4513301,"node_id":"MDQ6VXNlcjQ1MTMzMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4513301?v=4","gravatar_id":"","url":"https://api.github.com/users/luigiberrettini","html_url":"https://github.com/luigiberrettini","followers_url":"https://api.github.com/users/luigiberrettini/followers","following_url":"https://api.github.com/users/luigiberrettini/following{/other_user}","gists_url":"https://api.github.com/users/luigiberrettini/gists{/gist_id}","starred_url":"https://api.github.com/users/luigiberrettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigiberrettini/subscriptions","organizations_url":"https://api.github.com/users/luigiberrettini/orgs","repos_url":"https://api.github.com/users/luigiberrettini/repos","events_url":"https://api.github.com/users/luigiberrettini/events{/privacy}","received_events_url":"https://api.github.com/users/luigiberrettini/received_events","type":"User","site_admin":false},"html_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog","description":"A Syslog server target for NLog","fork":false,"url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog","forks_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/forks","keys_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/teams","hooks_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/hooks","issue_events_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues/events{/number}","events_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/events","assignees_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/assignees{/user}","branches_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/branches{/branch}","tags_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/tags","blobs_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/statuses/{sha}","languages_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/languages","stargazers_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/stargazers","contributors_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/contributors","subscribers_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/subscribers","subscription_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/subscription","commits_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/contents/{+path}","compare_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/merges","archive_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/downloads","issues_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues{/number}","pulls_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls{/number}","milestones_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/milestones{/number}","notifications_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/labels{/name}","releases_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/releases{/id}","deployments_url":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/deployments","created_at":"2010-06-12T18:36:36Z","updated_at":"2019-12-09T06:03:27Z","pushed_at":"2019-12-08T21:16:34Z","git_url":"git://github.com/luigiberrettini/NLog.Targets.Syslog.git","ssh_url":"git@github.com:luigiberrettini/NLog.Targets.Syslog.git","clone_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog.git","svn_url":"https://github.com/luigiberrettini/NLog.Targets.Syslog","homepage":"","size":5600,"stargazers_count":51,"watchers_count":51,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":39,"open_issues":1,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200"},"html":{"href":"https://github.com/luigiberrettini/NLog.Targets.Syslog/pull/200"},"issue":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues/200"},"comments":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/luigiberrettini/NLog.Targets.Syslog/statuses/f26a6505cda433beea0d98e673a925e9dda482e7"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"luigiberrettini"}}