payload: {"action":"created","issue":{"url":"https://api.github.com/repos/paritytech/substrate/issues/2170","repository_url":"https://api.github.com/repos/paritytech/substrate","labels_url":"https://api.github.com/repos/paritytech/substrate/issues/2170/labels{/name}","comments_url":"https://api.github.com/repos/paritytech/substrate/issues/2170/comments","events_url":"https://api.github.com/repos/paritytech/substrate/issues/2170/events","html_url":"https://github.com/paritytech/substrate/pull/2170","id":428216293,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2NjM1NTgy","number":2170,"title":"Cache changes trie config in db storage","user":{"login":"svyatonik","id":985319,"node_id":"MDQ6VXNlcjk4NTMxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/985319?v=4","gravatar_id":"","url":"https://api.github.com/users/svyatonik","html_url":"https://github.com/svyatonik","followers_url":"https://api.github.com/users/svyatonik/followers","following_url":"https://api.github.com/users/svyatonik/following{/other_user}","gists_url":"https://api.github.com/users/svyatonik/gists{/gist_id}","starred_url":"https://api.github.com/users/svyatonik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svyatonik/subscriptions","organizations_url":"https://api.github.com/users/svyatonik/orgs","repos_url":"https://api.github.com/users/svyatonik/repos","events_url":"https://api.github.com/users/svyatonik/events{/privacy}","received_events_url":"https://api.github.com/users/svyatonik/received_events","type":"User","site_admin":false},"labels":[{"id":746560607,"node_id":"MDU6TGFiZWw3NDY1NjA2MDc=","url":"https://api.github.com/repos/paritytech/substrate/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false},{"id":746560621,"node_id":"MDU6TGFiZWw3NDY1NjA2MjE=","url":"https://api.github.com/repos/paritytech/substrate/labels/B0-patchthis","name":"B0-patchthis","color":"f4f5f9","default":false},{"id":746560668,"node_id":"MDU6TGFiZWw3NDY1NjA2Njg=","url":"https://api.github.com/repos/paritytech/substrate/labels/M4-core","name":"M4-core","color":"F5FCE6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-04-02T13:06:37Z","updated_at":"2019-04-03T10:23:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/paritytech/substrate/pulls/2170","html_url":"https://github.com/paritytech/substrate/pull/2170","diff_url":"https://github.com/paritytech/substrate/pull/2170.diff","patch_url":"https://github.com/paritytech/substrate/pull/2170.patch"},"body":"(it is used to prune changes tries on finalization)\r\n\r\nSo the config is still read in `note_finalized`, since it requires much less code than reading it in constructor + updating when genesis `BlockImportOperation` is committed (+ there's a lot of tests which are constructing blocks with invalid `state_root` => storage reads in constructor are failing). Instead it is cached && the cached version is used later."},"comment":{"url":"https://api.github.com/repos/paritytech/substrate/issues/comments/479430835","html_url":"https://github.com/paritytech/substrate/pull/2170#issuecomment-479430835","issue_url":"https://api.github.com/repos/paritytech/substrate/issues/2170","id":479430835,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3OTQzMDgzNQ==","user":{"login":"svyatonik","id":985319,"node_id":"MDQ6VXNlcjk4NTMxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/985319?v=4","gravatar_id":"","url":"https://api.github.com/users/svyatonik","html_url":"https://github.com/svyatonik","followers_url":"https://api.github.com/users/svyatonik/followers","following_url":"https://api.github.com/users/svyatonik/following{/other_user}","gists_url":"https://api.github.com/users/svyatonik/gists{/gist_id}","starred_url":"https://api.github.com/users/svyatonik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svyatonik/subscriptions","organizations_url":"https://api.github.com/users/svyatonik/orgs","repos_url":"https://api.github.com/users/svyatonik/repos","events_url":"https://api.github.com/users/svyatonik/events{/privacy}","received_events_url":"https://api.github.com/users/svyatonik/received_events","type":"User","site_admin":false},"created_at":"2019-04-03T10:23:55Z","updated_at":"2019-04-03T10:23:55Z","author_association":"CONTRIBUTOR","body":"While I'd agree that `Option<Option<_>>` isn't good enough for public interfaces, the fact that this field is private && its usage is localized by single function, makes me think that `Option<Option<_>>` is better that additional private enum."}}
other: {"actor":{"display_login":"svyatonik"}}