payload: {"action":"created","issue":{"url":"https://api.github.com/repos/OpenPLi/enigma2/issues/2400","repository_url":"https://api.github.com/repos/OpenPLi/enigma2","labels_url":"https://api.github.com/repos/OpenPLi/enigma2/issues/2400/labels{/name}","comments_url":"https://api.github.com/repos/OpenPLi/enigma2/issues/2400/comments","events_url":"https://api.github.com/repos/OpenPLi/enigma2/issues/2400/events","html_url":"https://github.com/OpenPLi/enigma2/pull/2400","id":543361412,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3NjQ0ODc3","number":2400,"title":"[Skin.py] more code refinements and enhancements","user":{"login":"IanSav","id":6904736,"node_id":"MDQ6VXNlcjY5MDQ3MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6904736?v=4","gravatar_id":"","url":"https://api.github.com/users/IanSav","html_url":"https://github.com/IanSav","followers_url":"https://api.github.com/users/IanSav/followers","following_url":"https://api.github.com/users/IanSav/following{/other_user}","gists_url":"https://api.github.com/users/IanSav/gists{/gist_id}","starred_url":"https://api.github.com/users/IanSav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanSav/subscriptions","organizations_url":"https://api.github.com/users/IanSav/orgs","repos_url":"https://api.github.com/users/IanSav/repos","events_url":"https://api.github.com/users/IanSav/events{/privacy}","received_events_url":"https://api.github.com/users/IanSav/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2019-12-29T11:21:06Z","updated_at":"2019-12-30T15:49:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenPLi/enigma2/pulls/2400","html_url":"https://github.com/OpenPLi/enigma2/pull/2400","diff_url":"https://github.com/OpenPLi/enigma2/pull/2400.diff","patch_url":"https://github.com/OpenPLi/enigma2/pull/2400.patch"},"body":"- [skin.py] Change skin load order\r\n  This change makes the skin load order match the description comment describing the skin load order.\r\n\r\n- [skin.py] Use more appropriate variable name\r\n  This change makes use of a consistent, reused and more appropriate variable name for processing the tags in skins.\r\n\r\n- [skin.py] Optimise and enhance skinLoad() method\r\n  - Extract the common code adding screens to domScreens into a single method. This eliminates a nest of \"if\" blocks.\r\n  - This change also enhances the skinLoad() method to allow skin include files to add core skin elements like fonts, colours parameters, etc.\r\n\r\n    **NOTE: If this enhanced skinLoad() feature is to be used the include files MUST be included such that the core elements are defined BEFORE they are used. That means that the order of the include files is important.**\r\n\r\n- [skin.py] Adopt Mike's/Milo's code suggestions\r\n"},"comment":{"url":"https://api.github.com/repos/OpenPLi/enigma2/issues/comments/569715338","html_url":"https://github.com/OpenPLi/enigma2/pull/2400#issuecomment-569715338","issue_url":"https://api.github.com/repos/OpenPLi/enigma2/issues/2400","id":569715338,"node_id":"MDEyOklzc3VlQ29tbWVudDU2OTcxNTMzOA==","user":{"login":"persianpros","id":1169869,"node_id":"MDQ6VXNlcjExNjk4Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1169869?v=4","gravatar_id":"","url":"https://api.github.com/users/persianpros","html_url":"https://github.com/persianpros","followers_url":"https://api.github.com/users/persianpros/followers","following_url":"https://api.github.com/users/persianpros/following{/other_user}","gists_url":"https://api.github.com/users/persianpros/gists{/gist_id}","starred_url":"https://api.github.com/users/persianpros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persianpros/subscriptions","organizations_url":"https://api.github.com/users/persianpros/orgs","repos_url":"https://api.github.com/users/persianpros/repos","events_url":"https://api.github.com/users/persianpros/events{/privacy}","received_events_url":"https://api.github.com/users/persianpros/received_events","type":"User","site_admin":false},"created_at":"2019-12-30T15:49:16Z","updated_at":"2019-12-30T15:49:16Z","author_association":"CONTRIBUTOR","body":"@IanSav \r\n\r\nPLi is using \"SkinSelector\" as a plugin while we (Vision) and ViX also ATV are using SkinSelector.py as a \"Screen\".\r\n\r\nThat's why our code is improved and we need to do it for PLi if they're ok with it.\r\n\r\nRegarding fonts almost all skins are ruining enigma2 standards which is:\r\n\r\n /usr/share/fonts/\r\n\r\nI just introduced \"enigma2-plugin-fonts\" today: https://github.com/OpenVisionE2/openvision-oe/commit/0394a79dd5b4d72f771801c27532a7d6aef3831a\r\n\r\nplus its repository: https://github.com/OpenVisionE2/enigma2-fonts\r\n\r\nYou're welcome to use our repo and even participate in it with making skins standard again, fonts should not load from any other path and they must be available for all.\r\n\r\nWhy should we add a font somewhere else and don't let other skins to use it? This is ridiculously stupid.\r\n\r\nAll skin recipes should RDEPENDS on the needed fonts not provide them.\r\n\r\nIf OE-A or anyone else wants access to our font repo just let me know."}}
other: {"actor":{"display_login":"persianpros"}}