payload: {"action":"created","issue":{"url":"https://api.github.com/repos/mitre/caldera/issues/1002","repository_url":"https://api.github.com/repos/mitre/caldera","labels_url":"https://api.github.com/repos/mitre/caldera/issues/1002/labels{/name}","comments_url":"https://api.github.com/repos/mitre/caldera/issues/1002/comments","events_url":"https://api.github.com/repos/mitre/caldera/issues/1002/events","html_url":"https://github.com/mitre/caldera/pull/1002","id":546496589,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwMTYzNzU2","number":1002,"title":"Virts 801 new sphinx docs","user":{"login":"unkempthenry","id":31480194,"node_id":"MDQ6VXNlcjMxNDgwMTk0","avatar_url":"https://avatars2.githubusercontent.com/u/31480194?v=4","gravatar_id":"","url":"https://api.github.com/users/unkempthenry","html_url":"https://github.com/unkempthenry","followers_url":"https://api.github.com/users/unkempthenry/followers","following_url":"https://api.github.com/users/unkempthenry/following{/other_user}","gists_url":"https://api.github.com/users/unkempthenry/gists{/gist_id}","starred_url":"https://api.github.com/users/unkempthenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unkempthenry/subscriptions","organizations_url":"https://api.github.com/users/unkempthenry/orgs","repos_url":"https://api.github.com/users/unkempthenry/repos","events_url":"https://api.github.com/users/unkempthenry/events{/privacy}","received_events_url":"https://api.github.com/users/unkempthenry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"privateducky","id":49954156,"node_id":"MDQ6VXNlcjQ5OTU0MTU2","avatar_url":"https://avatars2.githubusercontent.com/u/49954156?v=4","gravatar_id":"","url":"https://api.github.com/users/privateducky","html_url":"https://github.com/privateducky","followers_url":"https://api.github.com/users/privateducky/followers","following_url":"https://api.github.com/users/privateducky/following{/other_user}","gists_url":"https://api.github.com/users/privateducky/gists{/gist_id}","starred_url":"https://api.github.com/users/privateducky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privateducky/subscriptions","organizations_url":"https://api.github.com/users/privateducky/orgs","repos_url":"https://api.github.com/users/privateducky/repos","events_url":"https://api.github.com/users/privateducky/events{/privacy}","received_events_url":"https://api.github.com/users/privateducky/received_events","type":"User","site_admin":false},"assignees":[{"login":"privateducky","id":49954156,"node_id":"MDQ6VXNlcjQ5OTU0MTU2","avatar_url":"https://avatars2.githubusercontent.com/u/49954156?v=4","gravatar_id":"","url":"https://api.github.com/users/privateducky","html_url":"https://github.com/privateducky","followers_url":"https://api.github.com/users/privateducky/followers","following_url":"https://api.github.com/users/privateducky/following{/other_user}","gists_url":"https://api.github.com/users/privateducky/gists{/gist_id}","starred_url":"https://api.github.com/users/privateducky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privateducky/subscriptions","organizations_url":"https://api.github.com/users/privateducky/orgs","repos_url":"https://api.github.com/users/privateducky/repos","events_url":"https://api.github.com/users/privateducky/events{/privacy}","received_events_url":"https://api.github.com/users/privateducky/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2020-01-07T20:41:41Z","updated_at":"2020-01-12T03:32:09Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mitre/caldera/pulls/1002","html_url":"https://github.com/mitre/caldera/pull/1002","diff_url":"https://github.com/mitre/caldera/pull/1002.diff","patch_url":"https://github.com/mitre/caldera/pull/1002.patch"},"body":"Changes:\r\n* add `docs/` dir with config file to build Sphinx docs from docstrings on service classes\r\n* add `requirements_dev.txt` to track heavier weight dev dependencies like sphinx\r\n* correct some docstrings formatting"},"comment":{"url":"https://api.github.com/repos/mitre/caldera/issues/comments/573378485","html_url":"https://github.com/mitre/caldera/pull/1002#issuecomment-573378485","issue_url":"https://api.github.com/repos/mitre/caldera/issues/1002","id":573378485,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MzM3ODQ4NQ==","user":{"login":"privateducky","id":49954156,"node_id":"MDQ6VXNlcjQ5OTU0MTU2","avatar_url":"https://avatars2.githubusercontent.com/u/49954156?v=4","gravatar_id":"","url":"https://api.github.com/users/privateducky","html_url":"https://github.com/privateducky","followers_url":"https://api.github.com/users/privateducky/followers","following_url":"https://api.github.com/users/privateducky/following{/other_user}","gists_url":"https://api.github.com/users/privateducky/gists{/gist_id}","starred_url":"https://api.github.com/users/privateducky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privateducky/subscriptions","organizations_url":"https://api.github.com/users/privateducky/orgs","repos_url":"https://api.github.com/users/privateducky/repos","events_url":"https://api.github.com/users/privateducky/events{/privacy}","received_events_url":"https://api.github.com/users/privateducky/received_events","type":"User","site_admin":false},"created_at":"2020-01-12T03:32:09Z","updated_at":"2020-01-12T03:32:09Z","author_association":"COLLABORATOR","body":"@unkempthenry @wbooth this looks really good. a couple of things I'd like to see:\r\n\r\n1) toss the _dev requirements in the normal file. I get what you're shooting for - but I think we need a better strategy for pip install's in general (including plugins) before I want to start splitting them up. \r\n2) let's include the 'make html' instruction part of the auto-installer.sh script - or add as a check when the server starts each time - and remove from the README. \r\n3) I'd like these docs to be linked to from the 'Docs' tab on the home (chain.html) page. \r\n4) Not part of this ticket - but definitely connected - I want to convert our GitHub wiki into a doc just like this instead of hosting via the wiki. I think we may have issues as users have older versions of CALDERA than what our most updated GitHub wiki user docs state. So bundling them with the application seems to be the thing to do. Would there be an easy way to do that through this Sphinx setup? It appears yes, but want to see your thoughts. "}}
other: {"actor":{"display_login":"privateducky"}}