payload: {"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/35","id":330168692,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwMTY4Njky","html_url":"https://github.com/spaceplesiosaur/refactor-tractor/pull/35","diff_url":"https://github.com/spaceplesiosaur/refactor-tractor/pull/35.diff","patch_url":"https://github.com/spaceplesiosaur/refactor-tractor/pull/35.patch","issue_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/35","number":35,"state":"closed","locked":false,"title":"SCSS code review","user":{"login":"ckoga","id":45470456,"node_id":"MDQ6VXNlcjQ1NDcwNDU2","avatar_url":"https://avatars2.githubusercontent.com/u/45470456?v=4","gravatar_id":"","url":"https://api.github.com/users/ckoga","html_url":"https://github.com/ckoga","followers_url":"https://api.github.com/users/ckoga/followers","following_url":"https://api.github.com/users/ckoga/following{/other_user}","gists_url":"https://api.github.com/users/ckoga/gists{/gist_id}","starred_url":"https://api.github.com/users/ckoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckoga/subscriptions","organizations_url":"https://api.github.com/users/ckoga/orgs","repos_url":"https://api.github.com/users/ckoga/repos","events_url":"https://api.github.com/users/ckoga/events{/privacy}","received_events_url":"https://api.github.com/users/ckoga/received_events","type":"User","site_admin":false},"body":"Code review for file change CSS -> SCSS\r\n#### Take a look at the src/css/ directory I added an index.scss, and _variables.scss. I changed the styles.css -> styles.scss.  In the scripts.js file I changed the import file path to styles.scss to show style changes.  In the styles.scss file you'll see nested SASS styling for applicable elements, I might have missed some rules.  This is definitely a work in progress we can merge to get the files correct but it needs a lot more tweaking.  Side note we will probably get rid of one of the styling files since I changed the original to styles.scss I'm not sure which one at the moment.\r\n#### There are two different rules written for the column layout  ```line 64 in styles.scss``` .  Try both sets of rules while changing the size of the window.  grid-template-column is a lot more responsive but I am looking into making each article's height fit the content. \r\n#### went to <a href='https://css-tricks.com/auto-sizing-columns-css-grid-auto-fill-vs-auto-fit/'>css-tricks</a> to get some ideas on column layout and am currently working on rows so not all the cards are the same height.\r\n#### This code review is in order to look at issues [ 32, 9, 31 ]\r\n\r\n- [ ] @spaceplesiosaur \r\n- [ ] @MattTuring ","created_at":"2019-10-20T23:11:03Z","updated_at":"2019-10-21T21:27:54Z","closed_at":"2019-10-21T21:27:54Z","merged_at":"2019-10-21T21:27:54Z","merge_commit_sha":"19d1b65b11199ba522af8ff6568e4c2995096d90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/35/commits","review_comments_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/35/comments","review_comment_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/35/comments","statuses_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/statuses/00ae5387962307c3c28965a25328991d1045f1f5","head":{"label":"spaceplesiosaur:SCSS","ref":"SCSS","sha":"00ae5387962307c3c28965a25328991d1045f1f5","user":{"login":"spaceplesiosaur","id":24462031,"node_id":"MDQ6VXNlcjI0NDYyMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/24462031?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceplesiosaur","html_url":"https://github.com/spaceplesiosaur","followers_url":"https://api.github.com/users/spaceplesiosaur/followers","following_url":"https://api.github.com/users/spaceplesiosaur/following{/other_user}","gists_url":"https://api.github.com/users/spaceplesiosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceplesiosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceplesiosaur/subscriptions","organizations_url":"https://api.github.com/users/spaceplesiosaur/orgs","repos_url":"https://api.github.com/users/spaceplesiosaur/repos","events_url":"https://api.github.com/users/spaceplesiosaur/events{/privacy}","received_events_url":"https://api.github.com/users/spaceplesiosaur/received_events","type":"User","site_admin":false},"repo":{"id":215891278,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU4OTEyNzg=","name":"refactor-tractor","full_name":"spaceplesiosaur/refactor-tractor","private":false,"owner":{"login":"spaceplesiosaur","id":24462031,"node_id":"MDQ6VXNlcjI0NDYyMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/24462031?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceplesiosaur","html_url":"https://github.com/spaceplesiosaur","followers_url":"https://api.github.com/users/spaceplesiosaur/followers","following_url":"https://api.github.com/users/spaceplesiosaur/following{/other_user}","gists_url":"https://api.github.com/users/spaceplesiosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceplesiosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceplesiosaur/subscriptions","organizations_url":"https://api.github.com/users/spaceplesiosaur/orgs","repos_url":"https://api.github.com/users/spaceplesiosaur/repos","events_url":"https://api.github.com/users/spaceplesiosaur/events{/privacy}","received_events_url":"https://api.github.com/users/spaceplesiosaur/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spaceplesiosaur/refactor-tractor","description":null,"fork":false,"url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor","forks_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/forks","keys_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/teams","hooks_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/hooks","issue_events_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/events{/number}","events_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/events","assignees_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/assignees{/user}","branches_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/branches{/branch}","tags_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/tags","blobs_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/statuses/{sha}","languages_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/languages","stargazers_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/stargazers","contributors_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/contributors","subscribers_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/subscribers","subscription_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/subscription","commits_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/contents/{+path}","compare_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/merges","archive_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/downloads","issues_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues{/number}","pulls_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls{/number}","milestones_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/milestones{/number}","notifications_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/labels{/name}","releases_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/releases{/id}","deployments_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/deployments","created_at":"2019-10-17T21:47:59Z","updated_at":"2019-10-21T21:12:41Z","pushed_at":"2019-10-21T21:27:54Z","git_url":"git://github.com/spaceplesiosaur/refactor-tractor.git","ssh_url":"git@github.com:spaceplesiosaur/refactor-tractor.git","clone_url":"https://github.com/spaceplesiosaur/refactor-tractor.git","svn_url":"https://github.com/spaceplesiosaur/refactor-tractor","homepage":null,"size":3445,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":null,"forks":1,"open_issues":33,"watchers":1,"default_branch":"master"}},"base":{"label":"spaceplesiosaur:master","ref":"master","sha":"c7fb8f80efbbb266f6a414abb2405b0dbf419a9a","user":{"login":"spaceplesiosaur","id":24462031,"node_id":"MDQ6VXNlcjI0NDYyMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/24462031?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceplesiosaur","html_url":"https://github.com/spaceplesiosaur","followers_url":"https://api.github.com/users/spaceplesiosaur/followers","following_url":"https://api.github.com/users/spaceplesiosaur/following{/other_user}","gists_url":"https://api.github.com/users/spaceplesiosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceplesiosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceplesiosaur/subscriptions","organizations_url":"https://api.github.com/users/spaceplesiosaur/orgs","repos_url":"https://api.github.com/users/spaceplesiosaur/repos","events_url":"https://api.github.com/users/spaceplesiosaur/events{/privacy}","received_events_url":"https://api.github.com/users/spaceplesiosaur/received_events","type":"User","site_admin":false},"repo":{"id":215891278,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU4OTEyNzg=","name":"refactor-tractor","full_name":"spaceplesiosaur/refactor-tractor","private":false,"owner":{"login":"spaceplesiosaur","id":24462031,"node_id":"MDQ6VXNlcjI0NDYyMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/24462031?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceplesiosaur","html_url":"https://github.com/spaceplesiosaur","followers_url":"https://api.github.com/users/spaceplesiosaur/followers","following_url":"https://api.github.com/users/spaceplesiosaur/following{/other_user}","gists_url":"https://api.github.com/users/spaceplesiosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceplesiosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceplesiosaur/subscriptions","organizations_url":"https://api.github.com/users/spaceplesiosaur/orgs","repos_url":"https://api.github.com/users/spaceplesiosaur/repos","events_url":"https://api.github.com/users/spaceplesiosaur/events{/privacy}","received_events_url":"https://api.github.com/users/spaceplesiosaur/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spaceplesiosaur/refactor-tractor","description":null,"fork":false,"url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor","forks_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/forks","keys_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/teams","hooks_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/hooks","issue_events_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/events{/number}","events_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/events","assignees_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/assignees{/user}","branches_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/branches{/branch}","tags_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/tags","blobs_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/statuses/{sha}","languages_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/languages","stargazers_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/stargazers","contributors_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/contributors","subscribers_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/subscribers","subscription_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/subscription","commits_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/contents/{+path}","compare_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/merges","archive_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/downloads","issues_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues{/number}","pulls_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls{/number}","milestones_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/milestones{/number}","notifications_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/labels{/name}","releases_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/releases{/id}","deployments_url":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/deployments","created_at":"2019-10-17T21:47:59Z","updated_at":"2019-10-21T21:12:41Z","pushed_at":"2019-10-21T21:27:54Z","git_url":"git://github.com/spaceplesiosaur/refactor-tractor.git","ssh_url":"git@github.com:spaceplesiosaur/refactor-tractor.git","clone_url":"https://github.com/spaceplesiosaur/refactor-tractor.git","svn_url":"https://github.com/spaceplesiosaur/refactor-tractor","homepage":null,"size":3445,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":null,"forks":1,"open_issues":33,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/35"},"html":{"href":"https://github.com/spaceplesiosaur/refactor-tractor/pull/35"},"issue":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/35"},"comments":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/spaceplesiosaur/refactor-tractor/statuses/00ae5387962307c3c28965a25328991d1045f1f5"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"spaceplesiosaur","id":24462031,"node_id":"MDQ6VXNlcjI0NDYyMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/24462031?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceplesiosaur","html_url":"https://github.com/spaceplesiosaur","followers_url":"https://api.github.com/users/spaceplesiosaur/followers","following_url":"https://api.github.com/users/spaceplesiosaur/following{/other_user}","gists_url":"https://api.github.com/users/spaceplesiosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceplesiosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceplesiosaur/subscriptions","organizations_url":"https://api.github.com/users/spaceplesiosaur/orgs","repos_url":"https://api.github.com/users/spaceplesiosaur/repos","events_url":"https://api.github.com/users/spaceplesiosaur/events{/privacy}","received_events_url":"https://api.github.com/users/spaceplesiosaur/received_events","type":"User","site_admin":false},"comments":1,"review_comments":6,"maintainer_can_modify":false,"commits":12,"additions":205,"deletions":182,"changed_files":9}}
other: {"actor":{"display_login":"spaceplesiosaur"}}