payload: {"action":"created","comment":{"url":"https://api.github.com/repos/brewkit/components/pulls/comments/363977294","pull_request_review_id":339541598,"id":363977294,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mzk3NzI5NA==","diff_hunk":"@@ -0,0 +1,106 @@\n+.brew-Dialog {\n+    display: none;\n+    align-items: center;\n+    justify-content: center;\n+    overflow: hidden;\n+    position: fixed;\n+    top: 0;\n+    bottom: 0;\n+    left: 0;\n+    right: 0;\n+    z-index: 40;\n+\n+    .brew-Dialog {\n+\n+        &__background {\n+            background-color:  rgba(0, 33, 48, 0.9);\n+            position: absolute;\n+            left: 0;\n+            top: 0;\n+            bottom: 0;\n+            right: 0;\n+        }\n+\n+        &__content {\n+            z-index: 1;\n+            width: 100%;\n+            max-width: 530px;","path":"theme/cerveza/src/components/_Dialog.scss","position":null,"original_position":27,"commit_id":"074f773c9aadd161ec68b22fd068eb147ba6ae44","original_commit_id":"79f36a183798b1d744905a1e32843b2c19d061c4","user":{"login":"ItsEricWoodward","id":2585736,"node_id":"MDQ6VXNlcjI1ODU3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2585736?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsEricWoodward","html_url":"https://github.com/ItsEricWoodward","followers_url":"https://api.github.com/users/ItsEricWoodward/followers","following_url":"https://api.github.com/users/ItsEricWoodward/following{/other_user}","gists_url":"https://api.github.com/users/ItsEricWoodward/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsEricWoodward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsEricWoodward/subscriptions","organizations_url":"https://api.github.com/users/ItsEricWoodward/orgs","repos_url":"https://api.github.com/users/ItsEricWoodward/repos","events_url":"https://api.github.com/users/ItsEricWoodward/events{/privacy}","received_events_url":"https://api.github.com/users/ItsEricWoodward/received_events","type":"User","site_admin":false},"body":"@joshrcook I understand where you're coming from, but I think that we should plan on (or, at least, allow for) *everything* to change size when the font does - that's the \"responsive\" in responsive design. Doing so helps us minimize the work we need to do in the future (if they decide to put OvrC on a TV screen, for example) without it being a premature optimization (530px / base size of 16px = approx 33rem, so we can write it once as `size(normal) * 33` and not worry about it going forward).\r\n\r\nIncidentally, even if we don't make it a responsive width, I still feel that we shouldn't have explicit PX widths defined anywhere but in our variables (with a handful of exceptions, like 0px or 1px for borders, padding, etc). What I mean is, if this component is 530px, it's a pretty good bet that some other component will be the same size, and we should use the same variable for both so that we have consistency across components. That way, if someone decides tomorrow that everything 530px across should actually be 545px, we won't have to search for all of them and manually change them.\r\n\r\nI might even suggest combining this with responsive widths - instead of it being 33rem (`size(normal) * 33`), the modifier could also be defined as a variable (ex: `size(normal) * map-get($medium, boxes)` or somesuch), so when it gets changed to 545px (or `size(normal) * 34`), again, we'd only have to update the modifying variable.\r\n\r\nMaybe it would be best to wait for tomorrow's standup and discuss this further as a team?\r\n","created_at":"2020-01-07T22:13:29Z","updated_at":"2020-01-07T22:13:30Z","html_url":"https://github.com/brewkit/components/pull/33#discussion_r363977294","pull_request_url":"https://api.github.com/repos/brewkit/components/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/brewkit/components/pulls/comments/363977294"},"html":{"href":"https://github.com/brewkit/components/pull/33#discussion_r363977294"},"pull_request":{"href":"https://api.github.com/repos/brewkit/components/pulls/33"}},"in_reply_to_id":363433781},"pull_request":{"url":"https://api.github.com/repos/brewkit/components/pulls/33","id":359652598,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5NjUyNTk4","html_url":"https://github.com/brewkit/components/pull/33","diff_url":"https://github.com/brewkit/components/pull/33.diff","patch_url":"https://github.com/brewkit/components/pull/33.patch","issue_url":"https://api.github.com/repos/brewkit/components/issues/33","number":33,"state":"open","locked":false,"title":"Created Dialog component","user":{"login":"joshrcook","id":2475205,"node_id":"MDQ6VXNlcjI0NzUyMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2475205?v=4","gravatar_id":"","url":"https://api.github.com/users/joshrcook","html_url":"https://github.com/joshrcook","followers_url":"https://api.github.com/users/joshrcook/followers","following_url":"https://api.github.com/users/joshrcook/following{/other_user}","gists_url":"https://api.github.com/users/joshrcook/gists{/gist_id}","starred_url":"https://api.github.com/users/joshrcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshrcook/subscriptions","organizations_url":"https://api.github.com/users/joshrcook/orgs","repos_url":"https://api.github.com/users/joshrcook/repos","events_url":"https://api.github.com/users/joshrcook/events{/privacy}","received_events_url":"https://api.github.com/users/joshrcook/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n- Created the Dialog component\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.","created_at":"2020-01-06T18:14:21Z","updated_at":"2020-01-07T22:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5fc8ac855066b19acbd785fc3a8ce841e789205","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ItsEricWoodward","id":2585736,"node_id":"MDQ6VXNlcjI1ODU3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2585736?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsEricWoodward","html_url":"https://github.com/ItsEricWoodward","followers_url":"https://api.github.com/users/ItsEricWoodward/followers","following_url":"https://api.github.com/users/ItsEricWoodward/following{/other_user}","gists_url":"https://api.github.com/users/ItsEricWoodward/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsEricWoodward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsEricWoodward/subscriptions","organizations_url":"https://api.github.com/users/ItsEricWoodward/orgs","repos_url":"https://api.github.com/users/ItsEricWoodward/repos","events_url":"https://api.github.com/users/ItsEricWoodward/events{/privacy}","received_events_url":"https://api.github.com/users/ItsEricWoodward/received_events","type":"User","site_admin":false},{"login":"lawren","id":5522790,"node_id":"MDQ6VXNlcjU1MjI3OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5522790?v=4","gravatar_id":"","url":"https://api.github.com/users/lawren","html_url":"https://github.com/lawren","followers_url":"https://api.github.com/users/lawren/followers","following_url":"https://api.github.com/users/lawren/following{/other_user}","gists_url":"https://api.github.com/users/lawren/gists{/gist_id}","starred_url":"https://api.github.com/users/lawren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lawren/subscriptions","organizations_url":"https://api.github.com/users/lawren/orgs","repos_url":"https://api.github.com/users/lawren/repos","events_url":"https://api.github.com/users/lawren/events{/privacy}","received_events_url":"https://api.github.com/users/lawren/received_events","type":"User","site_admin":false},{"login":"emdrayallday","id":34116830,"node_id":"MDQ6VXNlcjM0MTE2ODMw","avatar_url":"https://avatars1.githubusercontent.com/u/34116830?v=4","gravatar_id":"","url":"https://api.github.com/users/emdrayallday","html_url":"https://github.com/emdrayallday","followers_url":"https://api.github.com/users/emdrayallday/followers","following_url":"https://api.github.com/users/emdrayallday/following{/other_user}","gists_url":"https://api.github.com/users/emdrayallday/gists{/gist_id}","starred_url":"https://api.github.com/users/emdrayallday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emdrayallday/subscriptions","organizations_url":"https://api.github.com/users/emdrayallday/orgs","repos_url":"https://api.github.com/users/emdrayallday/repos","events_url":"https://api.github.com/users/emdrayallday/events{/privacy}","received_events_url":"https://api.github.com/users/emdrayallday/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brewkit/components/pulls/33/commits","review_comments_url":"https://api.github.com/repos/brewkit/components/pulls/33/comments","review_comment_url":"https://api.github.com/repos/brewkit/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brewkit/components/issues/33/comments","statuses_url":"https://api.github.com/repos/brewkit/components/statuses/074f773c9aadd161ec68b22fd068eb147ba6ae44","head":{"label":"brewkit:components/Dialog","ref":"components/Dialog","sha":"074f773c9aadd161ec68b22fd068eb147ba6ae44","user":{"login":"brewkit","id":52972656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyOTcyNjU2","avatar_url":"https://avatars2.githubusercontent.com/u/52972656?v=4","gravatar_id":"","url":"https://api.github.com/users/brewkit","html_url":"https://github.com/brewkit","followers_url":"https://api.github.com/users/brewkit/followers","following_url":"https://api.github.com/users/brewkit/following{/other_user}","gists_url":"https://api.github.com/users/brewkit/gists{/gist_id}","starred_url":"https://api.github.com/users/brewkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brewkit/subscriptions","organizations_url":"https://api.github.com/users/brewkit/orgs","repos_url":"https://api.github.com/users/brewkit/repos","events_url":"https://api.github.com/users/brewkit/events{/privacy}","received_events_url":"https://api.github.com/users/brewkit/received_events","type":"Organization","site_admin":false},"repo":{"id":197233475,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyMzM0NzU=","name":"components","full_name":"brewkit/components","private":false,"owner":{"login":"brewkit","id":52972656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyOTcyNjU2","avatar_url":"https://avatars2.githubusercontent.com/u/52972656?v=4","gravatar_id":"","url":"https://api.github.com/users/brewkit","html_url":"https://github.com/brewkit","followers_url":"https://api.github.com/users/brewkit/followers","following_url":"https://api.github.com/users/brewkit/following{/other_user}","gists_url":"https://api.github.com/users/brewkit/gists{/gist_id}","starred_url":"https://api.github.com/users/brewkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brewkit/subscriptions","organizations_url":"https://api.github.com/users/brewkit/orgs","repos_url":"https://api.github.com/users/brewkit/repos","events_url":"https://api.github.com/users/brewkit/events{/privacy}","received_events_url":"https://api.github.com/users/brewkit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brewkit/components","description":"A highly-opinionated design system for creating beautiful, fully responsive UIs using React, SCSS, and TypeScript.","fork":false,"url":"https://api.github.com/repos/brewkit/components","forks_url":"https://api.github.com/repos/brewkit/components/forks","keys_url":"https://api.github.com/repos/brewkit/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brewkit/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brewkit/components/teams","hooks_url":"https://api.github.com/repos/brewkit/components/hooks","issue_events_url":"https://api.github.com/repos/brewkit/components/issues/events{/number}","events_url":"https://api.github.com/repos/brewkit/components/events","assignees_url":"https://api.github.com/repos/brewkit/components/assignees{/user}","branches_url":"https://api.github.com/repos/brewkit/components/branches{/branch}","tags_url":"https://api.github.com/repos/brewkit/components/tags","blobs_url":"https://api.github.com/repos/brewkit/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brewkit/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brewkit/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/brewkit/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brewkit/components/statuses/{sha}","languages_url":"https://api.github.com/repos/brewkit/components/languages","stargazers_url":"https://api.github.com/repos/brewkit/components/stargazers","contributors_url":"https://api.github.com/repos/brewkit/components/contributors","subscribers_url":"https://api.github.com/repos/brewkit/components/subscribers","subscription_url":"https://api.github.com/repos/brewkit/components/subscription","commits_url":"https://api.github.com/repos/brewkit/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/brewkit/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/brewkit/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/brewkit/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/brewkit/components/contents/{+path}","compare_url":"https://api.github.com/repos/brewkit/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brewkit/components/merges","archive_url":"https://api.github.com/repos/brewkit/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brewkit/components/downloads","issues_url":"https://api.github.com/repos/brewkit/components/issues{/number}","pulls_url":"https://api.github.com/repos/brewkit/components/pulls{/number}","milestones_url":"https://api.github.com/repos/brewkit/components/milestones{/number}","notifications_url":"https://api.github.com/repos/brewkit/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brewkit/components/labels{/name}","releases_url":"https://api.github.com/repos/brewkit/components/releases{/id}","deployments_url":"https://api.github.com/repos/brewkit/components/deployments","created_at":"2019-07-16T16:53:27Z","updated_at":"2020-01-06T19:46:33Z","pushed_at":"2020-01-07T17:58:50Z","git_url":"git://github.com/brewkit/components.git","ssh_url":"git@github.com:brewkit/components.git","clone_url":"https://github.com/brewkit/components.git","svn_url":"https://github.com/brewkit/components","homepage":"","size":2759,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"brewkit:master","ref":"master","sha":"dde902f6b81124eda84963eca993bd9455212b85","user":{"login":"brewkit","id":52972656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyOTcyNjU2","avatar_url":"https://avatars2.githubusercontent.com/u/52972656?v=4","gravatar_id":"","url":"https://api.github.com/users/brewkit","html_url":"https://github.com/brewkit","followers_url":"https://api.github.com/users/brewkit/followers","following_url":"https://api.github.com/users/brewkit/following{/other_user}","gists_url":"https://api.github.com/users/brewkit/gists{/gist_id}","starred_url":"https://api.github.com/users/brewkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brewkit/subscriptions","organizations_url":"https://api.github.com/users/brewkit/orgs","repos_url":"https://api.github.com/users/brewkit/repos","events_url":"https://api.github.com/users/brewkit/events{/privacy}","received_events_url":"https://api.github.com/users/brewkit/received_events","type":"Organization","site_admin":false},"repo":{"id":197233475,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyMzM0NzU=","name":"components","full_name":"brewkit/components","private":false,"owner":{"login":"brewkit","id":52972656,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyOTcyNjU2","avatar_url":"https://avatars2.githubusercontent.com/u/52972656?v=4","gravatar_id":"","url":"https://api.github.com/users/brewkit","html_url":"https://github.com/brewkit","followers_url":"https://api.github.com/users/brewkit/followers","following_url":"https://api.github.com/users/brewkit/following{/other_user}","gists_url":"https://api.github.com/users/brewkit/gists{/gist_id}","starred_url":"https://api.github.com/users/brewkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brewkit/subscriptions","organizations_url":"https://api.github.com/users/brewkit/orgs","repos_url":"https://api.github.com/users/brewkit/repos","events_url":"https://api.github.com/users/brewkit/events{/privacy}","received_events_url":"https://api.github.com/users/brewkit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brewkit/components","description":"A highly-opinionated design system for creating beautiful, fully responsive UIs using React, SCSS, and TypeScript.","fork":false,"url":"https://api.github.com/repos/brewkit/components","forks_url":"https://api.github.com/repos/brewkit/components/forks","keys_url":"https://api.github.com/repos/brewkit/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brewkit/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brewkit/components/teams","hooks_url":"https://api.github.com/repos/brewkit/components/hooks","issue_events_url":"https://api.github.com/repos/brewkit/components/issues/events{/number}","events_url":"https://api.github.com/repos/brewkit/components/events","assignees_url":"https://api.github.com/repos/brewkit/components/assignees{/user}","branches_url":"https://api.github.com/repos/brewkit/components/branches{/branch}","tags_url":"https://api.github.com/repos/brewkit/components/tags","blobs_url":"https://api.github.com/repos/brewkit/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brewkit/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brewkit/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/brewkit/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brewkit/components/statuses/{sha}","languages_url":"https://api.github.com/repos/brewkit/components/languages","stargazers_url":"https://api.github.com/repos/brewkit/components/stargazers","contributors_url":"https://api.github.com/repos/brewkit/components/contributors","subscribers_url":"https://api.github.com/repos/brewkit/components/subscribers","subscription_url":"https://api.github.com/repos/brewkit/components/subscription","commits_url":"https://api.github.com/repos/brewkit/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/brewkit/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/brewkit/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/brewkit/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/brewkit/components/contents/{+path}","compare_url":"https://api.github.com/repos/brewkit/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brewkit/components/merges","archive_url":"https://api.github.com/repos/brewkit/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brewkit/components/downloads","issues_url":"https://api.github.com/repos/brewkit/components/issues{/number}","pulls_url":"https://api.github.com/repos/brewkit/components/pulls{/number}","milestones_url":"https://api.github.com/repos/brewkit/components/milestones{/number}","notifications_url":"https://api.github.com/repos/brewkit/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brewkit/components/labels{/name}","releases_url":"https://api.github.com/repos/brewkit/components/releases{/id}","deployments_url":"https://api.github.com/repos/brewkit/components/deployments","created_at":"2019-07-16T16:53:27Z","updated_at":"2020-01-06T19:46:33Z","pushed_at":"2020-01-07T17:58:50Z","git_url":"git://github.com/brewkit/components.git","ssh_url":"git@github.com:brewkit/components.git","clone_url":"https://github.com/brewkit/components.git","svn_url":"https://github.com/brewkit/components","homepage":"","size":2759,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brewkit/components/pulls/33"},"html":{"href":"https://github.com/brewkit/components/pull/33"},"issue":{"href":"https://api.github.com/repos/brewkit/components/issues/33"},"comments":{"href":"https://api.github.com/repos/brewkit/components/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/brewkit/components/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/brewkit/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brewkit/components/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/brewkit/components/statuses/074f773c9aadd161ec68b22fd068eb147ba6ae44"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"ItsEricWoodward"}}