payload: {"push_id":3665798497,"size":6,"distinct_size":6,"ref":"refs/heads/remove-unused-bad-word-add","head":"94678d32136cc5a0c90dbef441962be9dd0da53d","before":"cb2c3d34a387f117b838db1718ed0ae24492ea60","commits":[{"sha":"221e555c5a08dd1c1fc71aed1299daaabc685d11","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Remove empty lobby-db-dao project (#4848)\n\n* Remove empty lobby-db-dao project\r\n\r\nProject was originally a placeholder, as-is the impetus and momentum have waned. For now the project is being removed to avoid having a quarter-done feature that will likely add to confusion until it is otherwise completed.\r\n\r\n* Remove lobby-db-dao project reference\r\n\r\n* Remove placeholder lobby-engine sub-project","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/221e555c5a08dd1c1fc71aed1299daaabc685d11"},{"sha":"fe6356b1d6bfbeeb9bf5019f5c3f3cfcf62d00d4","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Add ansible http_server role (#4852)\n\nAdds a role based on the lobby role to install and run http_server.\r\nThis update also cleans up the lobby role of unused properties\r\nthat are exclusive to http_server now.\r\n\r\nNote: not well tested, there may be some issues in this config, for now\r\nthis lays down the obvious boiler plater in preparation for a more serious\r\neffort to ensure that http server is deployed and working on at least\r\nprerelease.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/fe6356b1d6bfbeeb9bf5019f5c3f3cfcf62d00d4"},{"sha":"01bdfc8a1f362fd81b77aed6b76daf6af66404a0","author":{"name":"Dan Van Atta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Deployable, tested HTTP Server & Finish Error Upload Feature (#4851)\n\n* Deployable, tested HTTP Server & Finish Error Upload Feature\r\n\r\n- Fix up gradle config for http-server to create a launchable artifact.\r\n- Add an integration test for drop wizard http server, fires up the http server and verifies http client code can connect.\r\n- Add database support to http server (per drop wizard recommendation, using JDBI framework)\r\n- Add rate limiting for error report upload. Except for http server deployment, this completes the error report upload feature. For server side rate limiting we add a simple history table and update it on the server side when error reports are submitted. Of note, whenever we add to the history table we'll also purge any records older than two days to prevent the table from growing. An initial rate limit of 5 error reports per day has been configured.\r\n- Update headed-client to have a 'fail-early' check if upload limit has been reached. If so we'll show a dialog explaining this to the user instead of showing the upload-error-report form. To enable this a new GET endpoint was added: '/can-submit-error-report'\r\n- Set a default value for 'github API token' to be 'test'. This is used as a magic value to trigger a stubbed response when creating github issues. To safeguard against using a stub in production, a 'prod' flag is added which will crash the application if we are configured to use a stub response.\r\n\r\n* Add a production only check to verify environment variables are set\r\n\r\n* Add a comment on slfj4 exclusion\r\n\r\n* Fix testCompile syntax in gradle\r\n\r\n* Add javadoc and fix checkstyle\r\n\r\n* Use static imports in test\r\n\r\n* Revert to using testCompile + group in config, looks like it is needed to get the dropwizard-testing dependency downloaded correctly\r\n\r\n* Fix failing test\r\n\r\nTest fails due to UK constraint error. This is because we have\r\nan explicit insert into a table and then when trying to insert\r\nusing the sequence, we have a collision. This was not a problem\r\nin local testing as the sequence had advanced past the value '1',\r\nbut on a fresh DB instance we encounter this problem.\r\n\r\n* Further update ID values to not collide with sequence\r\n\r\n* Use short-hand dependency syntax\r\n\r\n* Use slightly simpler \"Instant.now()\" over \"Clock.systemUtc().instant()\"","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/01bdfc8a1f362fd81b77aed6b76daf6af66404a0"},{"sha":"c6c28dd377342b49d8eeb7bdd098ecb6816a3ced","author":{"name":"Ron","email":"3a9f5728ad246f6b8d54c63f1ffb936cd8e7747c@gmail.com"},"message":"Refactor MustFightBattle (#4833)\n\n* Refactor FireAa to a separate class file\r\n\r\n* Refactor playing sounds to separate utility class\r\n\r\n* Small cleanup of Fire class\r\n\r\n* Refactor MustFightBattle and related classes\r\n\r\n* Add private constructor\r\n\r\n* Refactor sounds out of FireAa\r\n\r\n* Refactor and reorder methods\r\n\r\n* Further refactoring and reordering\r\n\r\n* More refactoring and reordering\r\n\r\n* Fix whitespace checkstyle violation","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/c6c28dd377342b49d8eeb7bdd098ecb6816a3ced"},{"sha":"ee21df5d7779a148662dc6990f160c5759798345","author":{"name":"Ron","email":"3a9f5728ad246f6b8d54c63f1ffb936cd8e7747c@gmail.com"},"message":"Make hover over unit tooltip the same as everywhere else (#4853)","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/ee21df5d7779a148662dc6990f160c5759798345"},{"sha":"94678d32136cc5a0c90dbef441962be9dd0da53d","author":{"name":"DanVanAtta","email":"bf856454d265638f7442eee7a3b10d4bb93482fb@gmail.com"},"message":"Remove unused BadWordController#add method\n\nBad words are added directly to DB (for better or worse), the method to add a bad word\nis currently only used in test code.\n\nNote: we introduce a test gap to verify that usernames do not contain 'bad words'. For now this is intentional as DB tests are in progress of being updated to use database-rider. With further work in the DB area with luck we'll fix this testing gap soon enough.","distinct":true,"url":"https://api.github.com/repos/DanVanAtta/triplea/commits/94678d32136cc5a0c90dbef441962be9dd0da53d"}]}
other: {"actor":{"display_login":"DanVanAtta"}}