payload: {"action":"created","comment":{"url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/comments/257630134","pull_request_review_id":204707388,"id":257630134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzYzMDEzNA==","diff_hunk":"@@ -476,7 +476,20 @@ namespace ledger {\n                 self->logger()->debug(\"Finish erasing data of WalletPool : {}\",name);\n                 return Future<api::ErrorCode>::successful(api::ErrorCode::FUTURE_WAS_SUCCESSFULL);\n             });\n+        }\n \n+        Future<api::ErrorCode> WalletPool::changePassword(","path":"core/src/wallet/pool/WalletPool.cpp","position":6,"original_position":6,"commit_id":"207b121eaf5ca8f7dbc68e3db32cb72db2763d59","original_commit_id":"207b121eaf5ca8f7dbc68e3db32cb72db2763d59","user":{"login":"pollastri-pierre","id":2566080,"node_id":"MDQ6VXNlcjI1NjYwODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2566080?v=4","gravatar_id":"","url":"https://api.github.com/users/pollastri-pierre","html_url":"https://github.com/pollastri-pierre","followers_url":"https://api.github.com/users/pollastri-pierre/followers","following_url":"https://api.github.com/users/pollastri-pierre/following{/other_user}","gists_url":"https://api.github.com/users/pollastri-pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pollastri-pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pollastri-pierre/subscriptions","organizations_url":"https://api.github.com/users/pollastri-pierre/orgs","repos_url":"https://api.github.com/users/pollastri-pierre/repos","events_url":"https://api.github.com/users/pollastri-pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pollastri-pierre/received_events","type":"User","site_admin":false},"body":"It's kind of weird to have a future which should return an error code as a success, why don't you use ledger::core::Unit type ?","created_at":"2019-02-18T10:09:04Z","updated_at":"2019-02-18T10:10:52Z","html_url":"https://github.com/LedgerHQ/lib-ledger-core/pull/149#discussion_r257630134","pull_request_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/comments/257630134"},"html":{"href":"https://github.com/LedgerHQ/lib-ledger-core/pull/149#discussion_r257630134"},"pull_request":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149","id":253851694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzODUxNjk0","html_url":"https://github.com/LedgerHQ/lib-ledger-core/pull/149","diff_url":"https://github.com/LedgerHQ/lib-ledger-core/pull/149.diff","patch_url":"https://github.com/LedgerHQ/lib-ledger-core/pull/149.patch","issue_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues/149","number":149,"state":"open","locked":false,"title":"Move password change implementation from the API interface to the WalletPool implementation.","user":{"login":"phaazon","id":506592,"node_id":"MDQ6VXNlcjUwNjU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/506592?v=4","gravatar_id":"","url":"https://api.github.com/users/phaazon","html_url":"https://github.com/phaazon","followers_url":"https://api.github.com/users/phaazon/followers","following_url":"https://api.github.com/users/phaazon/following{/other_user}","gists_url":"https://api.github.com/users/phaazon/gists{/gist_id}","starred_url":"https://api.github.com/users/phaazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phaazon/subscriptions","organizations_url":"https://api.github.com/users/phaazon/orgs","repos_url":"https://api.github.com/users/phaazon/repos","events_url":"https://api.github.com/users/phaazon/events{/privacy}","received_events_url":"https://api.github.com/users/phaazon/received_events","type":"User","site_admin":false},"body":"Also, support preferences backend password change.","created_at":"2019-02-18T10:01:22Z","updated_at":"2019-02-18T10:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21eb773e16a3ec8baee79bec9271c62514ff72cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1203474440,"node_id":"MDU6TGFiZWwxMjAzNDc0NDQw","url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/labels/easy","name":"easy","color":"fca4f3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149/commits","review_comments_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149/comments","review_comment_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues/149/comments","statuses_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/statuses/207b121eaf5ca8f7dbc68e3db32cb72db2763d59","head":{"label":"phaazon:feature/walletpool-preferences-encryption","ref":"feature/walletpool-preferences-encryption","sha":"207b121eaf5ca8f7dbc68e3db32cb72db2763d59","user":{"login":"phaazon","id":506592,"node_id":"MDQ6VXNlcjUwNjU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/506592?v=4","gravatar_id":"","url":"https://api.github.com/users/phaazon","html_url":"https://github.com/phaazon","followers_url":"https://api.github.com/users/phaazon/followers","following_url":"https://api.github.com/users/phaazon/following{/other_user}","gists_url":"https://api.github.com/users/phaazon/gists{/gist_id}","starred_url":"https://api.github.com/users/phaazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phaazon/subscriptions","organizations_url":"https://api.github.com/users/phaazon/orgs","repos_url":"https://api.github.com/users/phaazon/repos","events_url":"https://api.github.com/users/phaazon/events{/privacy}","received_events_url":"https://api.github.com/users/phaazon/received_events","type":"User","site_admin":false},"repo":{"id":160204931,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMDQ5MzE=","name":"lib-ledger-core","full_name":"phaazon/lib-ledger-core","private":false,"owner":{"login":"phaazon","id":506592,"node_id":"MDQ6VXNlcjUwNjU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/506592?v=4","gravatar_id":"","url":"https://api.github.com/users/phaazon","html_url":"https://github.com/phaazon","followers_url":"https://api.github.com/users/phaazon/followers","following_url":"https://api.github.com/users/phaazon/following{/other_user}","gists_url":"https://api.github.com/users/phaazon/gists{/gist_id}","starred_url":"https://api.github.com/users/phaazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phaazon/subscriptions","organizations_url":"https://api.github.com/users/phaazon/orgs","repos_url":"https://api.github.com/users/phaazon/repos","events_url":"https://api.github.com/users/phaazon/events{/privacy}","received_events_url":"https://api.github.com/users/phaazon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phaazon/lib-ledger-core","description":null,"fork":true,"url":"https://api.github.com/repos/phaazon/lib-ledger-core","forks_url":"https://api.github.com/repos/phaazon/lib-ledger-core/forks","keys_url":"https://api.github.com/repos/phaazon/lib-ledger-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phaazon/lib-ledger-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phaazon/lib-ledger-core/teams","hooks_url":"https://api.github.com/repos/phaazon/lib-ledger-core/hooks","issue_events_url":"https://api.github.com/repos/phaazon/lib-ledger-core/issues/events{/number}","events_url":"https://api.github.com/repos/phaazon/lib-ledger-core/events","assignees_url":"https://api.github.com/repos/phaazon/lib-ledger-core/assignees{/user}","branches_url":"https://api.github.com/repos/phaazon/lib-ledger-core/branches{/branch}","tags_url":"https://api.github.com/repos/phaazon/lib-ledger-core/tags","blobs_url":"https://api.github.com/repos/phaazon/lib-ledger-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phaazon/lib-ledger-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phaazon/lib-ledger-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phaazon/lib-ledger-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phaazon/lib-ledger-core/statuses/{sha}","languages_url":"https://api.github.com/repos/phaazon/lib-ledger-core/languages","stargazers_url":"https://api.github.com/repos/phaazon/lib-ledger-core/stargazers","contributors_url":"https://api.github.com/repos/phaazon/lib-ledger-core/contributors","subscribers_url":"https://api.github.com/repos/phaazon/lib-ledger-core/subscribers","subscription_url":"https://api.github.com/repos/phaazon/lib-ledger-core/subscription","commits_url":"https://api.github.com/repos/phaazon/lib-ledger-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phaazon/lib-ledger-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phaazon/lib-ledger-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phaazon/lib-ledger-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phaazon/lib-ledger-core/contents/{+path}","compare_url":"https://api.github.com/repos/phaazon/lib-ledger-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phaazon/lib-ledger-core/merges","archive_url":"https://api.github.com/repos/phaazon/lib-ledger-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phaazon/lib-ledger-core/downloads","issues_url":"https://api.github.com/repos/phaazon/lib-ledger-core/issues{/number}","pulls_url":"https://api.github.com/repos/phaazon/lib-ledger-core/pulls{/number}","milestones_url":"https://api.github.com/repos/phaazon/lib-ledger-core/milestones{/number}","notifications_url":"https://api.github.com/repos/phaazon/lib-ledger-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phaazon/lib-ledger-core/labels{/name}","releases_url":"https://api.github.com/repos/phaazon/lib-ledger-core/releases{/id}","deployments_url":"https://api.github.com/repos/phaazon/lib-ledger-core/deployments","created_at":"2018-12-03T14:36:09Z","updated_at":"2018-12-03T14:37:02Z","pushed_at":"2019-02-18T10:03:38Z","git_url":"git://github.com/phaazon/lib-ledger-core.git","ssh_url":"git@github.com:phaazon/lib-ledger-core.git","clone_url":"https://github.com/phaazon/lib-ledger-core.git","svn_url":"https://github.com/phaazon/lib-ledger-core","homepage":null,"size":72668,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LedgerHQ:develop","ref":"develop","sha":"1f2995947d7a0c608fcbf37bba20f4cf18f4e3ae","user":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":68716694,"node_id":"MDEwOlJlcG9zaXRvcnk2ODcxNjY5NA==","name":"lib-ledger-core","full_name":"LedgerHQ/lib-ledger-core","private":false,"owner":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LedgerHQ/lib-ledger-core","description":null,"fork":false,"url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core","forks_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/forks","keys_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/events","assignees_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/merges","archive_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/deployments","created_at":"2016-09-20T13:51:06Z","updated_at":"2019-01-29T11:32:10Z","pushed_at":"2019-02-18T10:03:39Z","git_url":"git://github.com/LedgerHQ/lib-ledger-core.git","ssh_url":"git@github.com:LedgerHQ/lib-ledger-core.git","clone_url":"https://github.com/LedgerHQ/lib-ledger-core.git","svn_url":"https://github.com/LedgerHQ/lib-ledger-core","homepage":null,"size":73002,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":20,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149"},"html":{"href":"https://github.com/LedgerHQ/lib-ledger-core/pull/149"},"issue":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues/149"},"comments":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/LedgerHQ/lib-ledger-core/statuses/207b121eaf5ca8f7dbc68e3db32cb72db2763d59"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"pollastri-pierre"}}