payload: {"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/comments/304224000","pull_request_review_id":262806870,"id":304224000,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDIyNDAwMA==","diff_hunk":"@@ -140,6 +140,7 @@ def is_whitespace(char):\n                 break\n             start_offset += min(length, self._document_stride)\n \n+        #\n         for (doc_span_index, doc_span) in enumerate(doc_spans):","path":"pretrained_bert/dataset_reader.py","position":null,"original_position":18,"commit_id":"184ae69c5589ac745027fd7e23aa6a3626d785de","original_commit_id":"aea4cf7f59891a2aeff660c42f06b6944ae4e424","user":{"login":"pengshuang","id":11802795,"node_id":"MDQ6VXNlcjExODAyNzk1","avatar_url":"https://avatars0.githubusercontent.com/u/11802795?v=4","gravatar_id":"","url":"https://api.github.com/users/pengshuang","html_url":"https://github.com/pengshuang","followers_url":"https://api.github.com/users/pengshuang/followers","following_url":"https://api.github.com/users/pengshuang/following{/other_user}","gists_url":"https://api.github.com/users/pengshuang/gists{/gist_id}","starred_url":"https://api.github.com/users/pengshuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengshuang/subscriptions","organizations_url":"https://api.github.com/users/pengshuang/orgs","repos_url":"https://api.github.com/users/pengshuang/repos","events_url":"https://api.github.com/users/pengshuang/events{/privacy}","received_events_url":"https://api.github.com/users/pengshuang/received_events","type":"User","site_admin":false},"body":"I have removed unused loop logic to make the code clear. Feel free to contact me if you have any suggestions.","created_at":"2019-07-17T05:25:18Z","updated_at":"2019-07-17T05:25:18Z","html_url":"https://github.com/allenai/allennlp-bert-qa-wrapper/pull/19#discussion_r304224000","pull_request_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/comments/304224000"},"html":{"href":"https://github.com/allenai/allennlp-bert-qa-wrapper/pull/19#discussion_r304224000"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19"}},"in_reply_to_id":304004187},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19","id":297889495,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3ODg5NDk1","html_url":"https://github.com/allenai/allennlp-bert-qa-wrapper/pull/19","diff_url":"https://github.com/allenai/allennlp-bert-qa-wrapper/pull/19.diff","patch_url":"https://github.com/allenai/allennlp-bert-qa-wrapper/pull/19.patch","issue_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues/19","number":19,"state":"open","locked":false,"title":"Add some code comment and remove unused loop for dataset_reader","user":{"login":"pengshuang","id":11802795,"node_id":"MDQ6VXNlcjExODAyNzk1","avatar_url":"https://avatars0.githubusercontent.com/u/11802795?v=4","gravatar_id":"","url":"https://api.github.com/users/pengshuang","html_url":"https://github.com/pengshuang","followers_url":"https://api.github.com/users/pengshuang/followers","following_url":"https://api.github.com/users/pengshuang/following{/other_user}","gists_url":"https://api.github.com/users/pengshuang/gists{/gist_id}","starred_url":"https://api.github.com/users/pengshuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengshuang/subscriptions","organizations_url":"https://api.github.com/users/pengshuang/orgs","repos_url":"https://api.github.com/users/pengshuang/repos","events_url":"https://api.github.com/users/pengshuang/events{/privacy}","received_events_url":"https://api.github.com/users/pengshuang/received_events","type":"User","site_admin":false},"body":"See the closed issue https://github.com/allenai/allennlp-bert-qa-wrapper/issues/18\r\n1. I updated some code comments in case that someone may be misunderstood.\r\n2. I removed unused loop logic to make the code clear.","created_at":"2019-07-16T06:13:53Z","updated_at":"2019-07-17T05:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a8756989023fe25e4e7bd37b271e3f9de02ed41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues/19/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/statuses/184ae69c5589ac745027fd7e23aa6a3626d785de","head":{"label":"pengshuang:predictor-update","ref":"predictor-update","sha":"184ae69c5589ac745027fd7e23aa6a3626d785de","user":{"login":"pengshuang","id":11802795,"node_id":"MDQ6VXNlcjExODAyNzk1","avatar_url":"https://avatars0.githubusercontent.com/u/11802795?v=4","gravatar_id":"","url":"https://api.github.com/users/pengshuang","html_url":"https://github.com/pengshuang","followers_url":"https://api.github.com/users/pengshuang/followers","following_url":"https://api.github.com/users/pengshuang/following{/other_user}","gists_url":"https://api.github.com/users/pengshuang/gists{/gist_id}","starred_url":"https://api.github.com/users/pengshuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengshuang/subscriptions","organizations_url":"https://api.github.com/users/pengshuang/orgs","repos_url":"https://api.github.com/users/pengshuang/repos","events_url":"https://api.github.com/users/pengshuang/events{/privacy}","received_events_url":"https://api.github.com/users/pengshuang/received_events","type":"User","site_admin":false},"repo":{"id":196111334,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYxMTEzMzQ=","name":"allennlp-bert-qa-wrapper","full_name":"pengshuang/allennlp-bert-qa-wrapper","private":false,"owner":{"login":"pengshuang","id":11802795,"node_id":"MDQ6VXNlcjExODAyNzk1","avatar_url":"https://avatars0.githubusercontent.com/u/11802795?v=4","gravatar_id":"","url":"https://api.github.com/users/pengshuang","html_url":"https://github.com/pengshuang","followers_url":"https://api.github.com/users/pengshuang/followers","following_url":"https://api.github.com/users/pengshuang/following{/other_user}","gists_url":"https://api.github.com/users/pengshuang/gists{/gist_id}","starred_url":"https://api.github.com/users/pengshuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengshuang/subscriptions","organizations_url":"https://api.github.com/users/pengshuang/orgs","repos_url":"https://api.github.com/users/pengshuang/repos","events_url":"https://api.github.com/users/pengshuang/events{/privacy}","received_events_url":"https://api.github.com/users/pengshuang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pengshuang/allennlp-bert-qa-wrapper","description":null,"fork":true,"url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper","forks_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/forks","keys_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/teams","hooks_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/hooks","issue_events_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/events","assignees_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/tags","blobs_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/languages","stargazers_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/stargazers","contributors_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/contributors","subscribers_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/subscribers","subscription_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/subscription","commits_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/merges","archive_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/downloads","issues_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/pengshuang/allennlp-bert-qa-wrapper/deployments","created_at":"2019-07-10T01:52:57Z","updated_at":"2019-07-10T01:52:59Z","pushed_at":"2019-07-17T05:20:14Z","git_url":"git://github.com/pengshuang/allennlp-bert-qa-wrapper.git","ssh_url":"git@github.com:pengshuang/allennlp-bert-qa-wrapper.git","clone_url":"https://github.com/pengshuang/allennlp-bert-qa-wrapper.git","svn_url":"https://github.com/pengshuang/allennlp-bert-qa-wrapper","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"9a116416f14f04f4460992cdd5c3344b21f99bfd","user":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":175078410,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUwNzg0MTA=","name":"allennlp-bert-qa-wrapper","full_name":"allenai/allennlp-bert-qa-wrapper","private":false,"owner":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/allenai/allennlp-bert-qa-wrapper","description":null,"fork":false,"url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper","forks_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/forks","keys_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/events","assignees_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/merges","archive_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/deployments","created_at":"2019-03-11T20:25:12Z","updated_at":"2019-07-12T10:49:07Z","pushed_at":"2019-07-17T05:20:15Z","git_url":"git://github.com/allenai/allennlp-bert-qa-wrapper.git","ssh_url":"git@github.com:allenai/allennlp-bert-qa-wrapper.git","clone_url":"https://github.com/allenai/allennlp-bert-qa-wrapper.git","svn_url":"https://github.com/allenai/allennlp-bert-qa-wrapper","homepage":null,"size":41,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":7,"open_issues":3,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19"},"html":{"href":"https://github.com/allenai/allennlp-bert-qa-wrapper/pull/19"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues/19"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp-bert-qa-wrapper/statuses/184ae69c5589ac745027fd7e23aa6a3626d785de"}},"author_association":"NONE"}}
other: {"actor":{"display_login":"pengshuang"}}