payload: {"action":"created","comment":{"url":"https://api.github.com/repos/insolar/insolar/pulls/comments/268714889","pull_request_review_id":218420447,"id":268714889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODcxNDg4OQ==","diff_hunk":"@@ -52,20 +52,60 @@ package storage\n \n import (\n \t\"context\"\n+\t\"github.com/insolar/insolar/network/node\"\n+\t\"sync\"\n \n \t\"github.com/insolar/insolar/insolar\"\n-\t\"github.com/insolar/insolar/network\"\n )\n \n-// SnapshotAccessor provides methods for accessing Snapshot.\n //go:generate minimock -i github.com/insolar/insolar/network/storage.SnapshotAccessor -o ../../testutils/network -s _mock.go\n+\n+// SnapshotAccessor provides methods for accessing Snapshot.\n type SnapshotAccessor interface {\n-\tForPulseNumber(context.Context, insolar.PulseNumber) (network.Snapshot, error)\n-\tLatest(ctx context.Context) (network.Snapshot, error)\n+\tForPulseNumber(context.Context, insolar.PulseNumber) (*node.Snapshot, error)\n+\tLatest(ctx context.Context) (node.Snapshot, error)\n }\n \n-// SnapshotAppender provides method for appending Snapshot to storage.\n //go:generate minimock -i github.com/insolar/insolar/network/storage.SnapshotAppender -o ../../testutils/network -s _mock.go\n+\n+// SnapshotAppender provides method for appending Snapshot to storage.\n type SnapshotAppender interface {\n-\tAppend(ctx context.Context, pulse insolar.PulseNumber, snapshot network.Snapshot) error\n+\tAppend(ctx context.Context, pulse insolar.PulseNumber, snapshot *node.Snapshot) error\n+}\n+\n+// NewSnapshotStorage constructor creates PulseStorage\n+func NewSnapshotStorage() *SnapshotStorage {\n+\treturn &SnapshotStorage{}\n+}\n+\n+type SnapshotStorage struct {\n+\tDB   DB `inject:\"\"`\n+\tlock sync.RWMutex\n+}\n+\n+func (s *SnapshotStorage) Append(ctx context.Context, pulse insolar.PulseNumber, snapshot *node.Snapshot) error {\n+\tpanic(\"implement me\")\n+\n+\ts.lock.RLock()","path":"network/storage/snapshot.go","position":44,"original_position":44,"commit_id":"42f837d268f8455443bfc0a57717ac1e1ea72ef4","original_commit_id":"42f837d268f8455443bfc0a57717ac1e1ea72ef4","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"unreachable code (from `govet`)","created_at":"2019-03-25T15:53:12Z","updated_at":"2019-03-25T15:53:12Z","html_url":"https://github.com/insolar/insolar/pull/1478#discussion_r268714889","pull_request_url":"https://api.github.com/repos/insolar/insolar/pulls/1478","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/insolar/insolar/pulls/comments/268714889"},"html":{"href":"https://github.com/insolar/insolar/pull/1478#discussion_r268714889"},"pull_request":{"href":"https://api.github.com/repos/insolar/insolar/pulls/1478"}}},"pull_request":{"url":"https://api.github.com/repos/insolar/insolar/pulls/1478","id":264091281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0MDkxMjgx","html_url":"https://github.com/insolar/insolar/pull/1478","diff_url":"https://github.com/insolar/insolar/pull/1478.diff","patch_url":"https://github.com/insolar/insolar/pull/1478.patch","issue_url":"https://api.github.com/repos/insolar/insolar/issues/1478","number":1478,"state":"open","locked":false,"title":"Ins 1918 network generic storage","user":{"login":"AndreyBronin","id":983761,"node_id":"MDQ6VXNlcjk4Mzc2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/983761?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreyBronin","html_url":"https://github.com/AndreyBronin","followers_url":"https://api.github.com/users/AndreyBronin/followers","following_url":"https://api.github.com/users/AndreyBronin/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBronin/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBronin/subscriptions","organizations_url":"https://api.github.com/users/AndreyBronin/orgs","repos_url":"https://api.github.com/users/AndreyBronin/repos","events_url":"https://api.github.com/users/AndreyBronin/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBronin/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n","created_at":"2019-03-25T12:00:59Z","updated_at":"2019-03-25T15:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccf781c7902f6536d8b9b4b300d76389e7d16d8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/insolar/insolar/pulls/1478/commits","review_comments_url":"https://api.github.com/repos/insolar/insolar/pulls/1478/comments","review_comment_url":"https://api.github.com/repos/insolar/insolar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/insolar/insolar/issues/1478/comments","statuses_url":"https://api.github.com/repos/insolar/insolar/statuses/42f837d268f8455443bfc0a57717ac1e1ea72ef4","head":{"label":"insolar:INS-1918-network-generic-storage","ref":"INS-1918-network-generic-storage","sha":"42f837d268f8455443bfc0a57717ac1e1ea72ef4","user":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"repo":{"id":139829328,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4MjkzMjg=","name":"insolar","full_name":"insolar/insolar","private":false,"owner":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/insolar/insolar","description":"Enterprise-ready blockchain platform","fork":false,"url":"https://api.github.com/repos/insolar/insolar","forks_url":"https://api.github.com/repos/insolar/insolar/forks","keys_url":"https://api.github.com/repos/insolar/insolar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/insolar/insolar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/insolar/insolar/teams","hooks_url":"https://api.github.com/repos/insolar/insolar/hooks","issue_events_url":"https://api.github.com/repos/insolar/insolar/issues/events{/number}","events_url":"https://api.github.com/repos/insolar/insolar/events","assignees_url":"https://api.github.com/repos/insolar/insolar/assignees{/user}","branches_url":"https://api.github.com/repos/insolar/insolar/branches{/branch}","tags_url":"https://api.github.com/repos/insolar/insolar/tags","blobs_url":"https://api.github.com/repos/insolar/insolar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/insolar/insolar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/insolar/insolar/git/refs{/sha}","trees_url":"https://api.github.com/repos/insolar/insolar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/insolar/insolar/statuses/{sha}","languages_url":"https://api.github.com/repos/insolar/insolar/languages","stargazers_url":"https://api.github.com/repos/insolar/insolar/stargazers","contributors_url":"https://api.github.com/repos/insolar/insolar/contributors","subscribers_url":"https://api.github.com/repos/insolar/insolar/subscribers","subscription_url":"https://api.github.com/repos/insolar/insolar/subscription","commits_url":"https://api.github.com/repos/insolar/insolar/commits{/sha}","git_commits_url":"https://api.github.com/repos/insolar/insolar/git/commits{/sha}","comments_url":"https://api.github.com/repos/insolar/insolar/comments{/number}","issue_comment_url":"https://api.github.com/repos/insolar/insolar/issues/comments{/number}","contents_url":"https://api.github.com/repos/insolar/insolar/contents/{+path}","compare_url":"https://api.github.com/repos/insolar/insolar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/insolar/insolar/merges","archive_url":"https://api.github.com/repos/insolar/insolar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/insolar/insolar/downloads","issues_url":"https://api.github.com/repos/insolar/insolar/issues{/number}","pulls_url":"https://api.github.com/repos/insolar/insolar/pulls{/number}","milestones_url":"https://api.github.com/repos/insolar/insolar/milestones{/number}","notifications_url":"https://api.github.com/repos/insolar/insolar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/insolar/insolar/labels{/name}","releases_url":"https://api.github.com/repos/insolar/insolar/releases{/id}","deployments_url":"https://api.github.com/repos/insolar/insolar/deployments","created_at":"2018-07-05T09:49:28Z","updated_at":"2019-03-25T15:15:05Z","pushed_at":"2019-03-25T15:51:56Z","git_url":"git://github.com/insolar/insolar.git","ssh_url":"git@github.com:insolar/insolar.git","clone_url":"https://github.com/insolar/insolar.git","svn_url":"https://github.com/insolar/insolar","homepage":"https://insolar.io","size":52777,"stargazers_count":87,"watchers_count":87,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":19,"watchers":87,"default_branch":"master"}},"base":{"label":"insolar:master","ref":"master","sha":"2f70627a406fc79e939e5ad2d2481bb56d4e7771","user":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"repo":{"id":139829328,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4MjkzMjg=","name":"insolar","full_name":"insolar/insolar","private":false,"owner":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/insolar/insolar","description":"Enterprise-ready blockchain platform","fork":false,"url":"https://api.github.com/repos/insolar/insolar","forks_url":"https://api.github.com/repos/insolar/insolar/forks","keys_url":"https://api.github.com/repos/insolar/insolar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/insolar/insolar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/insolar/insolar/teams","hooks_url":"https://api.github.com/repos/insolar/insolar/hooks","issue_events_url":"https://api.github.com/repos/insolar/insolar/issues/events{/number}","events_url":"https://api.github.com/repos/insolar/insolar/events","assignees_url":"https://api.github.com/repos/insolar/insolar/assignees{/user}","branches_url":"https://api.github.com/repos/insolar/insolar/branches{/branch}","tags_url":"https://api.github.com/repos/insolar/insolar/tags","blobs_url":"https://api.github.com/repos/insolar/insolar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/insolar/insolar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/insolar/insolar/git/refs{/sha}","trees_url":"https://api.github.com/repos/insolar/insolar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/insolar/insolar/statuses/{sha}","languages_url":"https://api.github.com/repos/insolar/insolar/languages","stargazers_url":"https://api.github.com/repos/insolar/insolar/stargazers","contributors_url":"https://api.github.com/repos/insolar/insolar/contributors","subscribers_url":"https://api.github.com/repos/insolar/insolar/subscribers","subscription_url":"https://api.github.com/repos/insolar/insolar/subscription","commits_url":"https://api.github.com/repos/insolar/insolar/commits{/sha}","git_commits_url":"https://api.github.com/repos/insolar/insolar/git/commits{/sha}","comments_url":"https://api.github.com/repos/insolar/insolar/comments{/number}","issue_comment_url":"https://api.github.com/repos/insolar/insolar/issues/comments{/number}","contents_url":"https://api.github.com/repos/insolar/insolar/contents/{+path}","compare_url":"https://api.github.com/repos/insolar/insolar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/insolar/insolar/merges","archive_url":"https://api.github.com/repos/insolar/insolar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/insolar/insolar/downloads","issues_url":"https://api.github.com/repos/insolar/insolar/issues{/number}","pulls_url":"https://api.github.com/repos/insolar/insolar/pulls{/number}","milestones_url":"https://api.github.com/repos/insolar/insolar/milestones{/number}","notifications_url":"https://api.github.com/repos/insolar/insolar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/insolar/insolar/labels{/name}","releases_url":"https://api.github.com/repos/insolar/insolar/releases{/id}","deployments_url":"https://api.github.com/repos/insolar/insolar/deployments","created_at":"2018-07-05T09:49:28Z","updated_at":"2019-03-25T15:15:05Z","pushed_at":"2019-03-25T15:51:56Z","git_url":"git://github.com/insolar/insolar.git","ssh_url":"git@github.com:insolar/insolar.git","clone_url":"https://github.com/insolar/insolar.git","svn_url":"https://github.com/insolar/insolar","homepage":"https://insolar.io","size":52777,"stargazers_count":87,"watchers_count":87,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":19,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/insolar/insolar/pulls/1478"},"html":{"href":"https://github.com/insolar/insolar/pull/1478"},"issue":{"href":"https://api.github.com/repos/insolar/insolar/issues/1478"},"comments":{"href":"https://api.github.com/repos/insolar/insolar/issues/1478/comments"},"review_comments":{"href":"https://api.github.com/repos/insolar/insolar/pulls/1478/comments"},"review_comment":{"href":"https://api.github.com/repos/insolar/insolar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/insolar/insolar/pulls/1478/commits"},"statuses":{"href":"https://api.github.com/repos/insolar/insolar/statuses/42f837d268f8455443bfc0a57717ac1e1ea72ef4"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"golangcibot"}}