payload: {"action":"created","issue":{"url":"https://api.github.com/repos/lyft/amundsen/issues/50","repository_url":"https://api.github.com/repos/lyft/amundsen","labels_url":"https://api.github.com/repos/lyft/amundsen/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/lyft/amundsen/issues/50/comments","events_url":"https://api.github.com/repos/lyft/amundsen/issues/50/events","html_url":"https://github.com/lyft/amundsen/issues/50","id":477104541,"node_id":"MDU6SXNzdWU0NzcxMDQ1NDE=","number":50,"title":"Frontend configurations to be set using API","user":{"login":"verdan","id":25360476,"node_id":"MDQ6VXNlcjI1MzYwNDc2","avatar_url":"https://avatars3.githubusercontent.com/u/25360476?v=4","gravatar_id":"","url":"https://api.github.com/users/verdan","html_url":"https://github.com/verdan","followers_url":"https://api.github.com/users/verdan/followers","following_url":"https://api.github.com/users/verdan/following{/other_user}","gists_url":"https://api.github.com/users/verdan/gists{/gist_id}","starred_url":"https://api.github.com/users/verdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verdan/subscriptions","organizations_url":"https://api.github.com/users/verdan/orgs","repos_url":"https://api.github.com/users/verdan/repos","events_url":"https://api.github.com/users/verdan/events{/privacy}","received_events_url":"https://api.github.com/users/verdan/received_events","type":"User","site_admin":false},"labels":[{"id":1485951861,"node_id":"MDU6TGFiZWwxNDg1OTUxODYx","url":"https://api.github.com/repos/lyft/amundsen/labels/amundsenfrontendlibrary","name":"amundsenfrontendlibrary","color":"ed3b82","default":false},{"id":1502998643,"node_id":"MDU6TGFiZWwxNTAyOTk4NjQz","url":"https://api.github.com/repos/lyft/amundsen/labels/keep%20fresh","name":"keep fresh","color":"fcefba","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-05-21T22:36:29Z","updated_at":"2019-11-01T23:21:46Z","closed_at":null,"author_association":"NONE","body":"In order to support all the customizations of the frontend i.e., the logo path etc (mentioned [here](https://github.com/lyft/amundsenfrontendlibrary/blob/master/amundsen_application/static/js/config/config-default.ts)) when installed using a pip package (already compiled), we need to pass those configs from backend and store them in React's store and use them instead of hardcoding them on frontend .js file. \r\n\r\n@ttannis @danwom FYI. "},"comment":{"url":"https://api.github.com/repos/lyft/amundsen/issues/comments/548981868","html_url":"https://github.com/lyft/amundsen/issues/50#issuecomment-548981868","issue_url":"https://api.github.com/repos/lyft/amundsen/issues/50","id":548981868,"node_id":"MDEyOklzc3VlQ29tbWVudDU0ODk4MTg2OA==","user":{"login":"danwom","id":4338702,"node_id":"MDQ6VXNlcjQzMzg3MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4338702?v=4","gravatar_id":"","url":"https://api.github.com/users/danwom","html_url":"https://github.com/danwom","followers_url":"https://api.github.com/users/danwom/followers","following_url":"https://api.github.com/users/danwom/following{/other_user}","gists_url":"https://api.github.com/users/danwom/gists{/gist_id}","starred_url":"https://api.github.com/users/danwom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwom/subscriptions","organizations_url":"https://api.github.com/users/danwom/orgs","repos_url":"https://api.github.com/users/danwom/repos","events_url":"https://api.github.com/users/danwom/events{/privacy}","received_events_url":"https://api.github.com/users/danwom/received_events","type":"User","site_admin":false},"created_at":"2019-11-01T23:21:46Z","updated_at":"2019-11-01T23:21:46Z","author_association":"CONTRIBUTOR","body":"Customizing the frontend currently requires a rebuild and redeploy. \r\n\r\nI can see the use case for a config API, but even that will have great limitations. For example you wouldn't be able to customize any of the colors, fonts, or images. Additionally some of our configs are set as JavaScript functions (generating the Explore SQL link for example), so you can't simply serve some JSON from an API. Though, I would like to move those function configs to the Python layer.\r\n\r\nThere is some non-trivial work to refactor the app to use a config API. There are some downsides such as additional latency (can't render anything until configs are fetched), and an external dependency (if the config server breaks, amundsenfrontend breaks)."}}
other: {"actor":{"display_login":"danwom"}}