payload: {"action":"created","issue":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/issues/331","repository_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox","labels_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/issues/331/comments","events_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/issues/331/events","html_url":"https://github.com/EddyVerbruggen/nativescript-mapbox/pull/331","id":508179051,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MDIzNjcz","number":331,"title":"The mother of all pull requests.","user":{"login":"Yermo","id":854565,"node_id":"MDQ6VXNlcjg1NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/854565?v=4","gravatar_id":"","url":"https://api.github.com/users/Yermo","html_url":"https://github.com/Yermo","followers_url":"https://api.github.com/users/Yermo/followers","following_url":"https://api.github.com/users/Yermo/following{/other_user}","gists_url":"https://api.github.com/users/Yermo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yermo/subscriptions","organizations_url":"https://api.github.com/users/Yermo/orgs","repos_url":"https://api.github.com/users/Yermo/repos","events_url":"https://api.github.com/users/Yermo/events{/privacy}","received_events_url":"https://api.github.com/users/Yermo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2019-10-17T01:22:30Z","updated_at":"2019-11-04T12:51:35Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/pulls/331","html_url":"https://github.com/EddyVerbruggen/nativescript-mapbox/pull/331","diff_url":"https://github.com/EddyVerbruggen/nativescript-mapbox/pull/331.diff","patch_url":"https://github.com/EddyVerbruggen/nativescript-mapbox/pull/331.patch"},"body":"I think I'm at a good stopping point where we can discuss how to merge this in. \r\n\r\n- I've added an angular demo \r\n- reworked all the plugin files adding comments\r\n- bumped the Android SDK to 8.4.0 and the iOS SDK to 5.1.1 and made supporting changes\r\n- updates for NativeScript 6.\r\n- BREAKING CHANGE: added addLayer()/removeLayer() that conforms to a subset of the Mapbox web-gl-js API. \r\n- BREAKING CHANGE: added addSource()/removeSource() that conforms to the Mapbox web-gl-js API.\r\n- added support for GeoJSON sources for lines and circles. \r\n- added addLinePoint() method to extend a line dynamically\r\n- added clickable layer support to lines and circles (still needs some work as it's a hack)\r\n- fixed the Android crash. I /think/ it was due to the lifecycle events not being properly handled but I am not 100% sure. I am currently not able to get either demo to crash on Android.\r\n- added a customizable location marker for iOS that matches the one available on Android.\r\n- added a central config file for the demos where the user can specify their access token.\r\n- updated the docs\r\n- updated the changelog\r\n- added a contributors file\r\n- and there's probably stuff I'm forgetting.\r\n\r\nThere's still a huge amount of work to do,but I have to focus on some other work for the next few weeks so I thought I'd send the pull request because I think maybe this better than what's currently live. \r\n\r\nI propose calling it 5.0.0-alpha.1\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/issues/comments/549339176","html_url":"https://github.com/EddyVerbruggen/nativescript-mapbox/pull/331#issuecomment-549339176","issue_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-mapbox/issues/331","id":549339176,"node_id":"MDEyOklzc3VlQ29tbWVudDU0OTMzOTE3Ng==","user":{"login":"keerl","id":24727492,"node_id":"MDQ6VXNlcjI0NzI3NDky","avatar_url":"https://avatars0.githubusercontent.com/u/24727492?v=4","gravatar_id":"","url":"https://api.github.com/users/keerl","html_url":"https://github.com/keerl","followers_url":"https://api.github.com/users/keerl/followers","following_url":"https://api.github.com/users/keerl/following{/other_user}","gists_url":"https://api.github.com/users/keerl/gists{/gist_id}","starred_url":"https://api.github.com/users/keerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keerl/subscriptions","organizations_url":"https://api.github.com/users/keerl/orgs","repos_url":"https://api.github.com/users/keerl/repos","events_url":"https://api.github.com/users/keerl/events{/privacy}","received_events_url":"https://api.github.com/users/keerl/received_events","type":"User","site_admin":false},"created_at":"2019-11-04T12:51:35Z","updated_at":"2019-11-04T12:51:35Z","author_association":"NONE","body":"> @keerl for your setOnMapClickListener problem. As you can see in the docs you need to add `return true` at the end of the callback.\r\n> \r\n> ```\r\n> this.mapbox.setOnMapClickListener( point => {\r\n>         console.log(`>> Map clicked: ${JSON.stringify(point)}`);\r\n>         return true;\r\n>       });\r\n> ```\r\n\r\nD'oh! I should have looked at the new docs more carefully... Thanks @stoanarrr "}}
other: {"actor":{"display_login":"keerl"}}