payload: {"action":"opened","issue":{"url":"https://api.github.com/repos/howyi/conv/issues/41","repository_url":"https://api.github.com/repos/howyi/conv","labels_url":"https://api.github.com/repos/howyi/conv/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/howyi/conv/issues/41/comments","events_url":"https://api.github.com/repos/howyi/conv/issues/41/events","html_url":"https://github.com/howyi/conv/issues/41","id":423186484,"node_id":"MDU6SXNzdWU0MjMxODY0ODQ=","number":41,"title":"不正なDDLを","user":{"login":"hgsk","id":544085,"node_id":"MDQ6VXNlcjU0NDA4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/544085?v=4","gravatar_id":"","url":"https://api.github.com/users/hgsk","html_url":"https://github.com/hgsk","followers_url":"https://api.github.com/users/hgsk/followers","following_url":"https://api.github.com/users/hgsk/following{/other_user}","gists_url":"https://api.github.com/users/hgsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hgsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgsk/subscriptions","organizations_url":"https://api.github.com/users/hgsk/orgs","repos_url":"https://api.github.com/users/hgsk/repos","events_url":"https://api.github.com/users/hgsk/events{/privacy}","received_events_url":"https://api.github.com/users/hgsk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-20T10:52:54Z","updated_at":"2019-03-20T10:52:54Z","closed_at":null,"author_association":"NONE","body":"PDOが実行できない不正なDDLを渡した際に問題となる箇所を把握したいと考えています。\r\n\r\n\r\n下記の箇所で例外を送出、ないし、警告を出力してはどうでしょうか。\r\n\r\nなんらかの例外が出ていれば使う側でcatchできるため、例外の方が望ましいと考えていますが、影響範囲は確認できていません。\r\n\r\n下記のコードです。\r\n\r\nhttps://github.com/howyi/conv/blob/master/src/DatabaseStructureFactory.php#L134\r\n\r\n```\r\n正常時\r\n\r\n>>> $this->pdo->exec($this->query);\r\n=> 0\r\n\r\n異常時\r\n>>> $this->pdo->exec($this->query);\r\n=> false\r\n```\r\n\r\n対応策として、PDOのオプションを渡すか、戻り値を見て例外を送出する手段が考えられます。\r\n\r\nhttp://php.net/manual/en/pdo.query.php#65543\r\n\r\n後ほどPRを出しますのでご検討いただけますでしょうか。"}}
other: {"actor":{"display_login":"hgsk"}}