payload: {"action":"created","comment":{"url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/comments/307962535","pull_request_review_id":267465883,"id":307962535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzk2MjUzNQ==","diff_hunk":"@@ -298,3 +336,19 @@ where\n \n     Ok(embeddings)\n }\n+\n+struct Skips<'a>(HashSet<&'a str>);\n+\n+impl<'a> FromPyObject<'a> for Skips<'a> {","path":"src/embeddings.rs","position":137,"original_position":134,"commit_id":"dc7a3a84280029a634834a18f7246a2c582e4647","original_commit_id":"55094bcc2af68ab1d3abcac7e70549c83505a3c0","user":{"login":"sebpuetz","id":30175181,"node_id":"MDQ6VXNlcjMwMTc1MTgx","avatar_url":"https://avatars2.githubusercontent.com/u/30175181?v=4","gravatar_id":"","url":"https://api.github.com/users/sebpuetz","html_url":"https://github.com/sebpuetz","followers_url":"https://api.github.com/users/sebpuetz/followers","following_url":"https://api.github.com/users/sebpuetz/following{/other_user}","gists_url":"https://api.github.com/users/sebpuetz/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpuetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpuetz/subscriptions","organizations_url":"https://api.github.com/users/sebpuetz/orgs","repos_url":"https://api.github.com/users/sebpuetz/repos","events_url":"https://api.github.com/users/sebpuetz/events{/privacy}","received_events_url":"https://api.github.com/users/sebpuetz/received_events","type":"User","site_admin":false},"body":"I opened an issue at https://github.com/PyO3/pyo3/issues/557","created_at":"2019-07-27T11:28:53Z","updated_at":"2019-07-27T11:28:53Z","html_url":"https://github.com/finalfusion/finalfusion-python/pull/45#discussion_r307962535","pull_request_url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/comments/307962535"},"html":{"href":"https://github.com/finalfusion/finalfusion-python/pull/45#discussion_r307962535"},"pull_request":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45"}},"in_reply_to_id":307960901},"pull_request":{"url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45","id":301747639,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNzQ3NjM5","html_url":"https://github.com/finalfusion/finalfusion-python/pull/45","diff_url":"https://github.com/finalfusion/finalfusion-python/pull/45.diff","patch_url":"https://github.com/finalfusion/finalfusion-python/pull/45.patch","issue_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/45","number":45,"state":"open","locked":false,"title":"Add embedding similarity queries.","user":{"login":"sebpuetz","id":30175181,"node_id":"MDQ6VXNlcjMwMTc1MTgx","avatar_url":"https://avatars2.githubusercontent.com/u/30175181?v=4","gravatar_id":"","url":"https://api.github.com/users/sebpuetz","html_url":"https://github.com/sebpuetz","followers_url":"https://api.github.com/users/sebpuetz/followers","following_url":"https://api.github.com/users/sebpuetz/following{/other_user}","gists_url":"https://api.github.com/users/sebpuetz/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpuetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpuetz/subscriptions","organizations_url":"https://api.github.com/users/sebpuetz/orgs","repos_url":"https://api.github.com/users/sebpuetz/repos","events_url":"https://api.github.com/users/sebpuetz/events{/privacy}","received_events_url":"https://api.github.com/users/sebpuetz/received_events","type":"User","site_admin":false},"body":"Add a method to perform similarity queries based on an input embedding rather than words.\r\n\r\n________\r\n\r\nThe argument for the words to skip had to be wrapped in two `Option`s, otherwise the proc macro paniced, the behaviour in Python is the desired one anyways.\r\n\r\nI factored out a method to return the results for `analogy`, `word_similarity` and `embedding_similarity` since the code was identical for all of them.\r\n","created_at":"2019-07-27T09:43:30Z","updated_at":"2019-07-27T11:28:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49f159410090f5e5ceaf5be8d4ef0a353db49f64","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45/commits","review_comments_url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45/comments","review_comment_url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/45/comments","statuses_url":"https://api.github.com/repos/finalfusion/finalfusion-python/statuses/dc7a3a84280029a634834a18f7246a2c582e4647","head":{"label":"finalfusion:embedding-similarity","ref":"embedding-similarity","sha":"dc7a3a84280029a634834a18f7246a2c582e4647","user":{"login":"finalfusion","id":48718464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzE4NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/48718464?v=4","gravatar_id":"","url":"https://api.github.com/users/finalfusion","html_url":"https://github.com/finalfusion","followers_url":"https://api.github.com/users/finalfusion/followers","following_url":"https://api.github.com/users/finalfusion/following{/other_user}","gists_url":"https://api.github.com/users/finalfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/finalfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finalfusion/subscriptions","organizations_url":"https://api.github.com/users/finalfusion/orgs","repos_url":"https://api.github.com/users/finalfusion/repos","events_url":"https://api.github.com/users/finalfusion/events{/privacy}","received_events_url":"https://api.github.com/users/finalfusion/received_events","type":"Organization","site_admin":false},"repo":{"id":149509818,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1MDk4MTg=","name":"finalfusion-python","full_name":"finalfusion/finalfusion-python","private":false,"owner":{"login":"finalfusion","id":48718464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzE4NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/48718464?v=4","gravatar_id":"","url":"https://api.github.com/users/finalfusion","html_url":"https://github.com/finalfusion","followers_url":"https://api.github.com/users/finalfusion/followers","following_url":"https://api.github.com/users/finalfusion/following{/other_user}","gists_url":"https://api.github.com/users/finalfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/finalfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finalfusion/subscriptions","organizations_url":"https://api.github.com/users/finalfusion/orgs","repos_url":"https://api.github.com/users/finalfusion/repos","events_url":"https://api.github.com/users/finalfusion/events{/privacy}","received_events_url":"https://api.github.com/users/finalfusion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/finalfusion/finalfusion-python","description":"Finalfusion embeddings in Python","fork":false,"url":"https://api.github.com/repos/finalfusion/finalfusion-python","forks_url":"https://api.github.com/repos/finalfusion/finalfusion-python/forks","keys_url":"https://api.github.com/repos/finalfusion/finalfusion-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finalfusion/finalfusion-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finalfusion/finalfusion-python/teams","hooks_url":"https://api.github.com/repos/finalfusion/finalfusion-python/hooks","issue_events_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/events{/number}","events_url":"https://api.github.com/repos/finalfusion/finalfusion-python/events","assignees_url":"https://api.github.com/repos/finalfusion/finalfusion-python/assignees{/user}","branches_url":"https://api.github.com/repos/finalfusion/finalfusion-python/branches{/branch}","tags_url":"https://api.github.com/repos/finalfusion/finalfusion-python/tags","blobs_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finalfusion/finalfusion-python/statuses/{sha}","languages_url":"https://api.github.com/repos/finalfusion/finalfusion-python/languages","stargazers_url":"https://api.github.com/repos/finalfusion/finalfusion-python/stargazers","contributors_url":"https://api.github.com/repos/finalfusion/finalfusion-python/contributors","subscribers_url":"https://api.github.com/repos/finalfusion/finalfusion-python/subscribers","subscription_url":"https://api.github.com/repos/finalfusion/finalfusion-python/subscription","commits_url":"https://api.github.com/repos/finalfusion/finalfusion-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/finalfusion/finalfusion-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/finalfusion/finalfusion-python/contents/{+path}","compare_url":"https://api.github.com/repos/finalfusion/finalfusion-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finalfusion/finalfusion-python/merges","archive_url":"https://api.github.com/repos/finalfusion/finalfusion-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finalfusion/finalfusion-python/downloads","issues_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues{/number}","pulls_url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls{/number}","milestones_url":"https://api.github.com/repos/finalfusion/finalfusion-python/milestones{/number}","notifications_url":"https://api.github.com/repos/finalfusion/finalfusion-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finalfusion/finalfusion-python/labels{/name}","releases_url":"https://api.github.com/repos/finalfusion/finalfusion-python/releases{/id}","deployments_url":"https://api.github.com/repos/finalfusion/finalfusion-python/deployments","created_at":"2018-09-19T20:42:00Z","updated_at":"2019-07-26T15:01:30Z","pushed_at":"2019-07-27T11:02:57Z","git_url":"git://github.com/finalfusion/finalfusion-python.git","ssh_url":"git@github.com:finalfusion/finalfusion-python.git","clone_url":"https://github.com/finalfusion/finalfusion-python.git","svn_url":"https://github.com/finalfusion/finalfusion-python","homepage":"https://finalfusion.github.io/","size":93,"stargazers_count":5,"watchers_count":5,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"finalfusion:master","ref":"master","sha":"11980ac446de48cc88ecaed30dfadd31d952ee64","user":{"login":"finalfusion","id":48718464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzE4NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/48718464?v=4","gravatar_id":"","url":"https://api.github.com/users/finalfusion","html_url":"https://github.com/finalfusion","followers_url":"https://api.github.com/users/finalfusion/followers","following_url":"https://api.github.com/users/finalfusion/following{/other_user}","gists_url":"https://api.github.com/users/finalfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/finalfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finalfusion/subscriptions","organizations_url":"https://api.github.com/users/finalfusion/orgs","repos_url":"https://api.github.com/users/finalfusion/repos","events_url":"https://api.github.com/users/finalfusion/events{/privacy}","received_events_url":"https://api.github.com/users/finalfusion/received_events","type":"Organization","site_admin":false},"repo":{"id":149509818,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1MDk4MTg=","name":"finalfusion-python","full_name":"finalfusion/finalfusion-python","private":false,"owner":{"login":"finalfusion","id":48718464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzE4NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/48718464?v=4","gravatar_id":"","url":"https://api.github.com/users/finalfusion","html_url":"https://github.com/finalfusion","followers_url":"https://api.github.com/users/finalfusion/followers","following_url":"https://api.github.com/users/finalfusion/following{/other_user}","gists_url":"https://api.github.com/users/finalfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/finalfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finalfusion/subscriptions","organizations_url":"https://api.github.com/users/finalfusion/orgs","repos_url":"https://api.github.com/users/finalfusion/repos","events_url":"https://api.github.com/users/finalfusion/events{/privacy}","received_events_url":"https://api.github.com/users/finalfusion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/finalfusion/finalfusion-python","description":"Finalfusion embeddings in Python","fork":false,"url":"https://api.github.com/repos/finalfusion/finalfusion-python","forks_url":"https://api.github.com/repos/finalfusion/finalfusion-python/forks","keys_url":"https://api.github.com/repos/finalfusion/finalfusion-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finalfusion/finalfusion-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finalfusion/finalfusion-python/teams","hooks_url":"https://api.github.com/repos/finalfusion/finalfusion-python/hooks","issue_events_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/events{/number}","events_url":"https://api.github.com/repos/finalfusion/finalfusion-python/events","assignees_url":"https://api.github.com/repos/finalfusion/finalfusion-python/assignees{/user}","branches_url":"https://api.github.com/repos/finalfusion/finalfusion-python/branches{/branch}","tags_url":"https://api.github.com/repos/finalfusion/finalfusion-python/tags","blobs_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finalfusion/finalfusion-python/statuses/{sha}","languages_url":"https://api.github.com/repos/finalfusion/finalfusion-python/languages","stargazers_url":"https://api.github.com/repos/finalfusion/finalfusion-python/stargazers","contributors_url":"https://api.github.com/repos/finalfusion/finalfusion-python/contributors","subscribers_url":"https://api.github.com/repos/finalfusion/finalfusion-python/subscribers","subscription_url":"https://api.github.com/repos/finalfusion/finalfusion-python/subscription","commits_url":"https://api.github.com/repos/finalfusion/finalfusion-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/finalfusion/finalfusion-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/finalfusion/finalfusion-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/finalfusion/finalfusion-python/contents/{+path}","compare_url":"https://api.github.com/repos/finalfusion/finalfusion-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finalfusion/finalfusion-python/merges","archive_url":"https://api.github.com/repos/finalfusion/finalfusion-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finalfusion/finalfusion-python/downloads","issues_url":"https://api.github.com/repos/finalfusion/finalfusion-python/issues{/number}","pulls_url":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls{/number}","milestones_url":"https://api.github.com/repos/finalfusion/finalfusion-python/milestones{/number}","notifications_url":"https://api.github.com/repos/finalfusion/finalfusion-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finalfusion/finalfusion-python/labels{/name}","releases_url":"https://api.github.com/repos/finalfusion/finalfusion-python/releases{/id}","deployments_url":"https://api.github.com/repos/finalfusion/finalfusion-python/deployments","created_at":"2018-09-19T20:42:00Z","updated_at":"2019-07-26T15:01:30Z","pushed_at":"2019-07-27T11:02:57Z","git_url":"git://github.com/finalfusion/finalfusion-python.git","ssh_url":"git@github.com:finalfusion/finalfusion-python.git","clone_url":"https://github.com/finalfusion/finalfusion-python.git","svn_url":"https://github.com/finalfusion/finalfusion-python","homepage":"https://finalfusion.github.io/","size":93,"stargazers_count":5,"watchers_count":5,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45"},"html":{"href":"https://github.com/finalfusion/finalfusion-python/pull/45"},"issue":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/45"},"comments":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/finalfusion/finalfusion-python/statuses/dc7a3a84280029a634834a18f7246a2c582e4647"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"sebpuetz"}}