payload: {"action":"reopened","number":1237,"pull_request":{"url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/1237","id":326386422,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2Mzg2NDIy","html_url":"https://github.com/microsoft/ApplicationInsights-dotnet/pull/1237","diff_url":"https://github.com/microsoft/ApplicationInsights-dotnet/pull/1237.diff","patch_url":"https://github.com/microsoft/ApplicationInsights-dotnet/pull/1237.patch","issue_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/1237","number":1237,"state":"open","locked":false,"title":"fix Transmission Tests","user":{"login":"TimothyMothra","id":28785781,"node_id":"MDQ6VXNlcjI4Nzg1Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/28785781?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyMothra","html_url":"https://github.com/TimothyMothra","followers_url":"https://api.github.com/users/TimothyMothra/followers","following_url":"https://api.github.com/users/TimothyMothra/following{/other_user}","gists_url":"https://api.github.com/users/TimothyMothra/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyMothra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyMothra/subscriptions","organizations_url":"https://api.github.com/users/TimothyMothra/orgs","repos_url":"https://api.github.com/users/TimothyMothra/repos","events_url":"https://api.github.com/users/TimothyMothra/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyMothra/received_events","type":"User","site_admin":false},"body":"**SetsEndpointAddressPropertyToSpecifiedValue**.\r\n\r\nThis test has failed 44 times in the last 30 days, but the code is literally verifying that the constructor sets a public property!!!!????\r\n\r\nThis test failed two days ago:\r\n_“Error calling Test Cleanup method for test class Microsoft.ApplicationInsights.Channel.TransmissionTest+Constructor: System.Net.Http.HttpRequestException: Error while copying content to a stream. ---> System.IO.IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. ---> System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote host”_\r\n\r\nThis is suspicious because this test doesn’t invoke any network operations.\r\nTaking a closer look, this test class inherits some base classes. Reading the comments these seem to only exist to support testing Async operations in .Net 3.5 !!!!\r\nSoooo….. I’m going to remove some of these complicated test dependencies.\r\n\r\n\r\n**Changes**\r\n- I removed the dependency on the subclasses. This test is literally only testing the constructor. All this extra stuff is not needed.\r\n- I replaced the test Uri with localhost. The Uri class does some non-trivial validation so only creating one should reduce some of the work. Also, IF for some reason this tries to make an outbound test, it should only ping the local host and fail fast.\r\n- I removed the dependenc8y on the AssertEx utility class. This is unnecessary, the MSTest framework is more than capable of catching expected exceptions.","created_at":"2019-10-09T18:24:57Z","updated_at":"2019-10-09T20:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12bab259ddc76efcb767cd32ead71cb631654ff3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cijothomas","id":5232798,"node_id":"MDQ6VXNlcjUyMzI3OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5232798?v=4","gravatar_id":"","url":"https://api.github.com/users/cijothomas","html_url":"https://github.com/cijothomas","followers_url":"https://api.github.com/users/cijothomas/followers","following_url":"https://api.github.com/users/cijothomas/following{/other_user}","gists_url":"https://api.github.com/users/cijothomas/gists{/gist_id}","starred_url":"https://api.github.com/users/cijothomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cijothomas/subscriptions","organizations_url":"https://api.github.com/users/cijothomas/orgs","repos_url":"https://api.github.com/users/cijothomas/repos","events_url":"https://api.github.com/users/cijothomas/events{/privacy}","received_events_url":"https://api.github.com/users/cijothomas/received_events","type":"User","site_admin":false},{"login":"Dmitry-Matveev","id":12158043,"node_id":"MDQ6VXNlcjEyMTU4MDQz","avatar_url":"https://avatars0.githubusercontent.com/u/12158043?v=4","gravatar_id":"","url":"https://api.github.com/users/Dmitry-Matveev","html_url":"https://github.com/Dmitry-Matveev","followers_url":"https://api.github.com/users/Dmitry-Matveev/followers","following_url":"https://api.github.com/users/Dmitry-Matveev/following{/other_user}","gists_url":"https://api.github.com/users/Dmitry-Matveev/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitry-Matveev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitry-Matveev/subscriptions","organizations_url":"https://api.github.com/users/Dmitry-Matveev/orgs","repos_url":"https://api.github.com/users/Dmitry-Matveev/repos","events_url":"https://api.github.com/users/Dmitry-Matveev/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitry-Matveev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/1237/commits","review_comments_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/1237/comments","review_comment_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/1237/comments","statuses_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/statuses/90b8d704b416741c15c92d63c1ee440c1c559cab","head":{"label":"microsoft:tilee/fix_TransmissionTests","ref":"tilee/fix_TransmissionTests","sha":"90b8d704b416741c15c92d63c1ee440c1c559cab","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37284654,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI4NDY1NA==","name":"ApplicationInsights-dotnet","full_name":"microsoft/ApplicationInsights-dotnet","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/ApplicationInsights-dotnet","description":"ApplicationInsights-dotnet","fork":false,"url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet","forks_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/forks","keys_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/teams","hooks_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/hooks","issue_events_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/events","assignees_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/tags","blobs_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/languages","stargazers_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/stargazers","contributors_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/contributors","subscribers_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/subscribers","subscription_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/subscription","commits_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/merges","archive_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/downloads","issues_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/deployments","created_at":"2015-06-11T20:34:21Z","updated_at":"2019-10-09T00:26:54Z","pushed_at":"2019-10-09T18:24:57Z","git_url":"git://github.com/microsoft/ApplicationInsights-dotnet.git","ssh_url":"git@github.com:microsoft/ApplicationInsights-dotnet.git","clone_url":"https://github.com/microsoft/ApplicationInsights-dotnet.git","svn_url":"https://github.com/microsoft/ApplicationInsights-dotnet","homepage":null,"size":15407,"stargazers_count":238,"watchers_count":238,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":149,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":131,"open_issues":149,"watchers":238,"default_branch":"develop"}},"base":{"label":"microsoft:develop","ref":"develop","sha":"b3d0c6d642cccb1437f45ac31d498c27f005ed8e","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37284654,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI4NDY1NA==","name":"ApplicationInsights-dotnet","full_name":"microsoft/ApplicationInsights-dotnet","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/ApplicationInsights-dotnet","description":"ApplicationInsights-dotnet","fork":false,"url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet","forks_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/forks","keys_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/teams","hooks_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/hooks","issue_events_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/events","assignees_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/tags","blobs_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/languages","stargazers_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/stargazers","contributors_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/contributors","subscribers_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/subscribers","subscription_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/subscription","commits_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/merges","archive_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/downloads","issues_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/deployments","created_at":"2015-06-11T20:34:21Z","updated_at":"2019-10-09T00:26:54Z","pushed_at":"2019-10-09T18:24:57Z","git_url":"git://github.com/microsoft/ApplicationInsights-dotnet.git","ssh_url":"git@github.com:microsoft/ApplicationInsights-dotnet.git","clone_url":"https://github.com/microsoft/ApplicationInsights-dotnet.git","svn_url":"https://github.com/microsoft/ApplicationInsights-dotnet","homepage":null,"size":15407,"stargazers_count":238,"watchers_count":238,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":149,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":131,"open_issues":149,"watchers":238,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/1237"},"html":{"href":"https://github.com/microsoft/ApplicationInsights-dotnet/pull/1237"},"issue":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/1237"},"comments":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/issues/1237/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/1237/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/pulls/1237/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/ApplicationInsights-dotnet/statuses/90b8d704b416741c15c92d63c1ee440c1c559cab"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":21,"changed_files":1}}
other: {"actor":{"display_login":"TimothyMothra"}}