payload: {"action":"created","comment":{"url":"https://api.github.com/repos/getredash/redash/pulls/comments/272843437","pull_request_review_id":223592698,"id":272843437,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Mjg0MzQzNw==","diff_hunk":"@@ -0,0 +1,11 @@\n+import qs from 'qs';\n+\n+const parse = queryString => qs.parse(queryString, { allowDots: true, ignoreQueryPrefix: true });\n+const onlyParameters = ([k]) => k.startsWith('p_');\n+const removePrefix = ([k, v]) => [k.slice(2), v];\n+const toObject = (obj, [k, v]) => Object.assign(obj, { [k]: v });\n+\n+export default () => Object.entries(parse(location.search))","path":"client/app/services/query-string.js","position":8,"original_position":8,"commit_id":"f708e167a4e71a4ad54987363aa3ebd9c36c062f","original_commit_id":"fb54b82bba0a21725d45ffcf8fa648c76f7461a1","user":{"login":"rauchy","id":289488,"node_id":"MDQ6VXNlcjI4OTQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/289488?v=4","gravatar_id":"","url":"https://api.github.com/users/rauchy","html_url":"https://github.com/rauchy","followers_url":"https://api.github.com/users/rauchy/followers","following_url":"https://api.github.com/users/rauchy/following{/other_user}","gists_url":"https://api.github.com/users/rauchy/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchy/subscriptions","organizations_url":"https://api.github.com/users/rauchy/orgs","repos_url":"https://api.github.com/users/rauchy/repos","events_url":"https://api.github.com/users/rauchy/events{/privacy}","received_events_url":"https://api.github.com/users/rauchy/received_events","type":"User","site_admin":false},"body":"I think that most of the (non-lib) code in the project is Redash specific but we don't explicitly add \"Redash\" to function and class names, so I tend to disagree.","created_at":"2019-04-07T17:23:11Z","updated_at":"2019-04-07T17:23:11Z","html_url":"https://github.com/getredash/redash/pull/3681#discussion_r272843437","pull_request_url":"https://api.github.com/repos/getredash/redash/pulls/3681","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/getredash/redash/pulls/comments/272843437"},"html":{"href":"https://github.com/getredash/redash/pull/3681#discussion_r272843437"},"pull_request":{"href":"https://api.github.com/repos/getredash/redash/pulls/3681"}},"in_reply_to_id":272836908},"pull_request":{"url":"https://api.github.com/repos/getredash/redash/pulls/3681","id":268029966,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MDI5OTY2","html_url":"https://github.com/getredash/redash/pull/3681","diff_url":"https://github.com/getredash/redash/pull/3681.diff","patch_url":"https://github.com/getredash/redash/pull/3681.patch","issue_url":"https://api.github.com/repos/getredash/redash/issues/3681","number":3681,"state":"open","locked":false,"title":"Fix: support date ranges for parameterized embeds","user":{"login":"rauchy","id":289488,"node_id":"MDQ6VXNlcjI4OTQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/289488?v=4","gravatar_id":"","url":"https://api.github.com/users/rauchy","html_url":"https://github.com/rauchy","followers_url":"https://api.github.com/users/rauchy/followers","following_url":"https://api.github.com/users/rauchy/following{/other_user}","gists_url":"https://api.github.com/users/rauchy/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchy/subscriptions","organizations_url":"https://api.github.com/users/rauchy/orgs","repos_url":"https://api.github.com/users/rauchy/repos","events_url":"https://api.github.com/users/rauchy/events{/privacy}","received_events_url":"https://api.github.com/users/rauchy/received_events","type":"User","site_admin":false},"body":"## What type of PR is this? (check all applicable)\r\n<!-- Please leave only what's applicable -->\r\n\r\n- [ ] Refactor\r\n- [ ] Feature\r\n- [x] Bug Fix\r\n- [ ] New Query Runner (Data Source)\r\n- [ ] New Alert Destination\r\n- [ ] Other\r\n\r\n## Description\r\nParsing of date ranges was unhandled in #3495, and is now fixed here, though I guess we should really toss this piece of code and consolidate.\r\n\r\n## Related Tickets & Documents\r\nReported by @HenroRitchie [here](https://github.com/getredash/redash/pull/3495#issuecomment-480208986), thanks!\r\n\r\n## Mobile & Desktop Screenshots/Recordings (if there are UI changes)\r\n","created_at":"2019-04-06T11:29:45Z","updated_at":"2019-04-07T17:23:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3abceb5e81bf16d29cab0d4c459e505b47ef94a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arikfr","id":71468,"node_id":"MDQ6VXNlcjcxNDY4","avatar_url":"https://avatars2.githubusercontent.com/u/71468?v=4","gravatar_id":"","url":"https://api.github.com/users/arikfr","html_url":"https://github.com/arikfr","followers_url":"https://api.github.com/users/arikfr/followers","following_url":"https://api.github.com/users/arikfr/following{/other_user}","gists_url":"https://api.github.com/users/arikfr/gists{/gist_id}","starred_url":"https://api.github.com/users/arikfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arikfr/subscriptions","organizations_url":"https://api.github.com/users/arikfr/orgs","repos_url":"https://api.github.com/users/arikfr/repos","events_url":"https://api.github.com/users/arikfr/events{/privacy}","received_events_url":"https://api.github.com/users/arikfr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getredash/redash/pulls/3681/commits","review_comments_url":"https://api.github.com/repos/getredash/redash/pulls/3681/comments","review_comment_url":"https://api.github.com/repos/getredash/redash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getredash/redash/issues/3681/comments","statuses_url":"https://api.github.com/repos/getredash/redash/statuses/f708e167a4e71a4ad54987363aa3ebd9c36c062f","head":{"label":"getredash:fix-support-date-ranges-for-parameterized-embeds","ref":"fix-support-date-ranges-for-parameterized-embeds","sha":"f708e167a4e71a4ad54987363aa3ebd9c36c062f","user":{"login":"getredash","id":10746780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQ2Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/10746780?v=4","gravatar_id":"","url":"https://api.github.com/users/getredash","html_url":"https://github.com/getredash","followers_url":"https://api.github.com/users/getredash/followers","following_url":"https://api.github.com/users/getredash/following{/other_user}","gists_url":"https://api.github.com/users/getredash/gists{/gist_id}","starred_url":"https://api.github.com/users/getredash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getredash/subscriptions","organizations_url":"https://api.github.com/users/getredash/orgs","repos_url":"https://api.github.com/users/getredash/repos","events_url":"https://api.github.com/users/getredash/events{/privacy}","received_events_url":"https://api.github.com/users/getredash/received_events","type":"Organization","site_admin":false},"repo":{"id":13926404,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyNjQwNA==","name":"redash","full_name":"getredash/redash","private":false,"owner":{"login":"getredash","id":10746780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQ2Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/10746780?v=4","gravatar_id":"","url":"https://api.github.com/users/getredash","html_url":"https://github.com/getredash","followers_url":"https://api.github.com/users/getredash/followers","following_url":"https://api.github.com/users/getredash/following{/other_user}","gists_url":"https://api.github.com/users/getredash/gists{/gist_id}","starred_url":"https://api.github.com/users/getredash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getredash/subscriptions","organizations_url":"https://api.github.com/users/getredash/orgs","repos_url":"https://api.github.com/users/getredash/repos","events_url":"https://api.github.com/users/getredash/events{/privacy}","received_events_url":"https://api.github.com/users/getredash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getredash/redash","description":"Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data.","fork":false,"url":"https://api.github.com/repos/getredash/redash","forks_url":"https://api.github.com/repos/getredash/redash/forks","keys_url":"https://api.github.com/repos/getredash/redash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getredash/redash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getredash/redash/teams","hooks_url":"https://api.github.com/repos/getredash/redash/hooks","issue_events_url":"https://api.github.com/repos/getredash/redash/issues/events{/number}","events_url":"https://api.github.com/repos/getredash/redash/events","assignees_url":"https://api.github.com/repos/getredash/redash/assignees{/user}","branches_url":"https://api.github.com/repos/getredash/redash/branches{/branch}","tags_url":"https://api.github.com/repos/getredash/redash/tags","blobs_url":"https://api.github.com/repos/getredash/redash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getredash/redash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getredash/redash/git/refs{/sha}","trees_url":"https://api.github.com/repos/getredash/redash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getredash/redash/statuses/{sha}","languages_url":"https://api.github.com/repos/getredash/redash/languages","stargazers_url":"https://api.github.com/repos/getredash/redash/stargazers","contributors_url":"https://api.github.com/repos/getredash/redash/contributors","subscribers_url":"https://api.github.com/repos/getredash/redash/subscribers","subscription_url":"https://api.github.com/repos/getredash/redash/subscription","commits_url":"https://api.github.com/repos/getredash/redash/commits{/sha}","git_commits_url":"https://api.github.com/repos/getredash/redash/git/commits{/sha}","comments_url":"https://api.github.com/repos/getredash/redash/comments{/number}","issue_comment_url":"https://api.github.com/repos/getredash/redash/issues/comments{/number}","contents_url":"https://api.github.com/repos/getredash/redash/contents/{+path}","compare_url":"https://api.github.com/repos/getredash/redash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getredash/redash/merges","archive_url":"https://api.github.com/repos/getredash/redash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getredash/redash/downloads","issues_url":"https://api.github.com/repos/getredash/redash/issues{/number}","pulls_url":"https://api.github.com/repos/getredash/redash/pulls{/number}","milestones_url":"https://api.github.com/repos/getredash/redash/milestones{/number}","notifications_url":"https://api.github.com/repos/getredash/redash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getredash/redash/labels{/name}","releases_url":"https://api.github.com/repos/getredash/redash/releases{/id}","deployments_url":"https://api.github.com/repos/getredash/redash/deployments","created_at":"2013-10-28T13:19:39Z","updated_at":"2019-04-07T15:12:18Z","pushed_at":"2019-04-07T17:07:08Z","git_url":"git://github.com/getredash/redash.git","ssh_url":"git@github.com:getredash/redash.git","clone_url":"https://github.com/getredash/redash.git","svn_url":"https://github.com/getredash/redash","homepage":"http://redash.io/","size":14644,"stargazers_count":12212,"watchers_count":12212,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1986,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":451,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1986,"open_issues":451,"watchers":12212,"default_branch":"master"}},"base":{"label":"getredash:master","ref":"master","sha":"8f4288583eba90e0e97888cc9d8813d89a96a4cb","user":{"login":"getredash","id":10746780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQ2Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/10746780?v=4","gravatar_id":"","url":"https://api.github.com/users/getredash","html_url":"https://github.com/getredash","followers_url":"https://api.github.com/users/getredash/followers","following_url":"https://api.github.com/users/getredash/following{/other_user}","gists_url":"https://api.github.com/users/getredash/gists{/gist_id}","starred_url":"https://api.github.com/users/getredash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getredash/subscriptions","organizations_url":"https://api.github.com/users/getredash/orgs","repos_url":"https://api.github.com/users/getredash/repos","events_url":"https://api.github.com/users/getredash/events{/privacy}","received_events_url":"https://api.github.com/users/getredash/received_events","type":"Organization","site_admin":false},"repo":{"id":13926404,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyNjQwNA==","name":"redash","full_name":"getredash/redash","private":false,"owner":{"login":"getredash","id":10746780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQ2Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/10746780?v=4","gravatar_id":"","url":"https://api.github.com/users/getredash","html_url":"https://github.com/getredash","followers_url":"https://api.github.com/users/getredash/followers","following_url":"https://api.github.com/users/getredash/following{/other_user}","gists_url":"https://api.github.com/users/getredash/gists{/gist_id}","starred_url":"https://api.github.com/users/getredash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getredash/subscriptions","organizations_url":"https://api.github.com/users/getredash/orgs","repos_url":"https://api.github.com/users/getredash/repos","events_url":"https://api.github.com/users/getredash/events{/privacy}","received_events_url":"https://api.github.com/users/getredash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getredash/redash","description":"Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data.","fork":false,"url":"https://api.github.com/repos/getredash/redash","forks_url":"https://api.github.com/repos/getredash/redash/forks","keys_url":"https://api.github.com/repos/getredash/redash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getredash/redash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getredash/redash/teams","hooks_url":"https://api.github.com/repos/getredash/redash/hooks","issue_events_url":"https://api.github.com/repos/getredash/redash/issues/events{/number}","events_url":"https://api.github.com/repos/getredash/redash/events","assignees_url":"https://api.github.com/repos/getredash/redash/assignees{/user}","branches_url":"https://api.github.com/repos/getredash/redash/branches{/branch}","tags_url":"https://api.github.com/repos/getredash/redash/tags","blobs_url":"https://api.github.com/repos/getredash/redash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getredash/redash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getredash/redash/git/refs{/sha}","trees_url":"https://api.github.com/repos/getredash/redash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getredash/redash/statuses/{sha}","languages_url":"https://api.github.com/repos/getredash/redash/languages","stargazers_url":"https://api.github.com/repos/getredash/redash/stargazers","contributors_url":"https://api.github.com/repos/getredash/redash/contributors","subscribers_url":"https://api.github.com/repos/getredash/redash/subscribers","subscription_url":"https://api.github.com/repos/getredash/redash/subscription","commits_url":"https://api.github.com/repos/getredash/redash/commits{/sha}","git_commits_url":"https://api.github.com/repos/getredash/redash/git/commits{/sha}","comments_url":"https://api.github.com/repos/getredash/redash/comments{/number}","issue_comment_url":"https://api.github.com/repos/getredash/redash/issues/comments{/number}","contents_url":"https://api.github.com/repos/getredash/redash/contents/{+path}","compare_url":"https://api.github.com/repos/getredash/redash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getredash/redash/merges","archive_url":"https://api.github.com/repos/getredash/redash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getredash/redash/downloads","issues_url":"https://api.github.com/repos/getredash/redash/issues{/number}","pulls_url":"https://api.github.com/repos/getredash/redash/pulls{/number}","milestones_url":"https://api.github.com/repos/getredash/redash/milestones{/number}","notifications_url":"https://api.github.com/repos/getredash/redash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getredash/redash/labels{/name}","releases_url":"https://api.github.com/repos/getredash/redash/releases{/id}","deployments_url":"https://api.github.com/repos/getredash/redash/deployments","created_at":"2013-10-28T13:19:39Z","updated_at":"2019-04-07T15:12:18Z","pushed_at":"2019-04-07T17:07:08Z","git_url":"git://github.com/getredash/redash.git","ssh_url":"git@github.com:getredash/redash.git","clone_url":"https://github.com/getredash/redash.git","svn_url":"https://github.com/getredash/redash","homepage":"http://redash.io/","size":14644,"stargazers_count":12212,"watchers_count":12212,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1986,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":451,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1986,"open_issues":451,"watchers":12212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getredash/redash/pulls/3681"},"html":{"href":"https://github.com/getredash/redash/pull/3681"},"issue":{"href":"https://api.github.com/repos/getredash/redash/issues/3681"},"comments":{"href":"https://api.github.com/repos/getredash/redash/issues/3681/comments"},"review_comments":{"href":"https://api.github.com/repos/getredash/redash/pulls/3681/comments"},"review_comment":{"href":"https://api.github.com/repos/getredash/redash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getredash/redash/pulls/3681/commits"},"statuses":{"href":"https://api.github.com/repos/getredash/redash/statuses/f708e167a4e71a4ad54987363aa3ebd9c36c062f"}},"author_association":"CONTRIBUTOR"}}
other: {"actor":{"display_login":"rauchy"}}