payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/comments/352404845","pull_request_review_id":324998533,"id":352404845,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjQwNDg0NQ==","diff_hunk":"@@ -1,55 +1,56 @@\n #include <motors_weg_cvw300/Driver.hpp>\n+#include <base/Angle.hpp>\n \n using namespace std;\n using namespace base;\n using namespace motors_weg_cvw300;\n \n Driver::Driver(int address)\n     : m_address(address) {\n+    // default of 7ms is too low for the weg controller at 57600\n+    setInterframeDelay(base::Time::fromMilliseconds(14));","path":"src/Driver.cpp","position":11,"original_position":11,"commit_id":"e2bd581949c55dcdd0706be9de58866320dc0fef","original_commit_id":"e2bd581949c55dcdd0706be9de58866320dc0fef","user":{"login":"g-arjones","id":17409636,"node_id":"MDQ6VXNlcjE3NDA5NjM2","avatar_url":"https://avatars1.githubusercontent.com/u/17409636?v=4","gravatar_id":"","url":"https://api.github.com/users/g-arjones","html_url":"https://github.com/g-arjones","followers_url":"https://api.github.com/users/g-arjones/followers","following_url":"https://api.github.com/users/g-arjones/following{/other_user}","gists_url":"https://api.github.com/users/g-arjones/gists{/gist_id}","starred_url":"https://api.github.com/users/g-arjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-arjones/subscriptions","organizations_url":"https://api.github.com/users/g-arjones/orgs","repos_url":"https://api.github.com/users/g-arjones/repos","events_url":"https://api.github.com/users/g-arjones/events{/privacy}","received_events_url":"https://api.github.com/users/g-arjones/received_events","type":"User","site_admin":false},"body":"Maybe make this a parameter?","created_at":"2019-12-02T03:07:06Z","updated_at":"2019-12-02T03:14:57Z","html_url":"https://github.com/tidewise/drivers-motors_weg_cvw300/pull/3#discussion_r352404845","pull_request_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/comments/352404845"},"html":{"href":"https://github.com/tidewise/drivers-motors_weg_cvw300/pull/3#discussion_r352404845"},"pull_request":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3","id":347129585,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MTI5NTg1","html_url":"https://github.com/tidewise/drivers-motors_weg_cvw300/pull/3","diff_url":"https://github.com/tidewise/drivers-motors_weg_cvw300/pull/3.diff","patch_url":"https://github.com/tidewise/drivers-motors_weg_cvw300/pull/3.patch","issue_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/3","number":3,"state":"open","locked":false,"title":"successful at reading state","user":{"login":"doudou","id":292,"node_id":"MDQ6VXNlcjI5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/292?v=4","gravatar_id":"","url":"https://api.github.com/users/doudou","html_url":"https://github.com/doudou","followers_url":"https://api.github.com/users/doudou/followers","following_url":"https://api.github.com/users/doudou/following{/other_user}","gists_url":"https://api.github.com/users/doudou/gists{/gist_id}","starred_url":"https://api.github.com/users/doudou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doudou/subscriptions","organizations_url":"https://api.github.com/users/doudou/orgs","repos_url":"https://api.github.com/users/doudou/repos","events_url":"https://api.github.com/users/doudou/events{/privacy}","received_events_url":"https://api.github.com/users/doudou/received_events","type":"User","site_admin":false},"body":"At this stage, we can read the controller state and get meaningful values","created_at":"2019-11-29T17:57:30Z","updated_at":"2019-12-02T03:14:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0d572f2b4a72338ddc958764355eccc9436ea12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3/commits","review_comments_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3/comments","review_comment_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/3/comments","statuses_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/statuses/e2bd581949c55dcdd0706be9de58866320dc0fef","head":{"label":"tidewise:debug_state_reading","ref":"debug_state_reading","sha":"e2bd581949c55dcdd0706be9de58866320dc0fef","user":{"login":"tidewise","id":48922016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTIyMDE2","avatar_url":"https://avatars2.githubusercontent.com/u/48922016?v=4","gravatar_id":"","url":"https://api.github.com/users/tidewise","html_url":"https://github.com/tidewise","followers_url":"https://api.github.com/users/tidewise/followers","following_url":"https://api.github.com/users/tidewise/following{/other_user}","gists_url":"https://api.github.com/users/tidewise/gists{/gist_id}","starred_url":"https://api.github.com/users/tidewise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidewise/subscriptions","organizations_url":"https://api.github.com/users/tidewise/orgs","repos_url":"https://api.github.com/users/tidewise/repos","events_url":"https://api.github.com/users/tidewise/events{/privacy}","received_events_url":"https://api.github.com/users/tidewise/received_events","type":"Organization","site_admin":false},"repo":{"id":208301759,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgzMDE3NTk=","name":"drivers-motors_weg_cvw300","full_name":"tidewise/drivers-motors_weg_cvw300","private":false,"owner":{"login":"tidewise","id":48922016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTIyMDE2","avatar_url":"https://avatars2.githubusercontent.com/u/48922016?v=4","gravatar_id":"","url":"https://api.github.com/users/tidewise","html_url":"https://github.com/tidewise","followers_url":"https://api.github.com/users/tidewise/followers","following_url":"https://api.github.com/users/tidewise/following{/other_user}","gists_url":"https://api.github.com/users/tidewise/gists{/gist_id}","starred_url":"https://api.github.com/users/tidewise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidewise/subscriptions","organizations_url":"https://api.github.com/users/tidewise/orgs","repos_url":"https://api.github.com/users/tidewise/repos","events_url":"https://api.github.com/users/tidewise/events{/privacy}","received_events_url":"https://api.github.com/users/tidewise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tidewise/drivers-motors_weg_cvw300","description":"Driver library for the WEG CVW300 motor controller","fork":false,"url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300","forks_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/forks","keys_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/teams","hooks_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/hooks","issue_events_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/events{/number}","events_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/events","assignees_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/assignees{/user}","branches_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/branches{/branch}","tags_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/tags","blobs_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/statuses/{sha}","languages_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/languages","stargazers_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/stargazers","contributors_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/contributors","subscribers_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/subscribers","subscription_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/subscription","commits_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/contents/{+path}","compare_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/merges","archive_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/downloads","issues_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues{/number}","pulls_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls{/number}","milestones_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/milestones{/number}","notifications_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/labels{/name}","releases_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/releases{/id}","deployments_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/deployments","created_at":"2019-09-13T16:16:52Z","updated_at":"2019-10-28T17:55:50Z","pushed_at":"2019-11-29T18:06:33Z","git_url":"git://github.com/tidewise/drivers-motors_weg_cvw300.git","ssh_url":"git@github.com:tidewise/drivers-motors_weg_cvw300.git","clone_url":"https://github.com/tidewise/drivers-motors_weg_cvw300.git","svn_url":"https://github.com/tidewise/drivers-motors_weg_cvw300","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tidewise:master","ref":"master","sha":"063eb37ec0861b666bdfbcc7466287ab6acb1dc1","user":{"login":"tidewise","id":48922016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTIyMDE2","avatar_url":"https://avatars2.githubusercontent.com/u/48922016?v=4","gravatar_id":"","url":"https://api.github.com/users/tidewise","html_url":"https://github.com/tidewise","followers_url":"https://api.github.com/users/tidewise/followers","following_url":"https://api.github.com/users/tidewise/following{/other_user}","gists_url":"https://api.github.com/users/tidewise/gists{/gist_id}","starred_url":"https://api.github.com/users/tidewise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidewise/subscriptions","organizations_url":"https://api.github.com/users/tidewise/orgs","repos_url":"https://api.github.com/users/tidewise/repos","events_url":"https://api.github.com/users/tidewise/events{/privacy}","received_events_url":"https://api.github.com/users/tidewise/received_events","type":"Organization","site_admin":false},"repo":{"id":208301759,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgzMDE3NTk=","name":"drivers-motors_weg_cvw300","full_name":"tidewise/drivers-motors_weg_cvw300","private":false,"owner":{"login":"tidewise","id":48922016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTIyMDE2","avatar_url":"https://avatars2.githubusercontent.com/u/48922016?v=4","gravatar_id":"","url":"https://api.github.com/users/tidewise","html_url":"https://github.com/tidewise","followers_url":"https://api.github.com/users/tidewise/followers","following_url":"https://api.github.com/users/tidewise/following{/other_user}","gists_url":"https://api.github.com/users/tidewise/gists{/gist_id}","starred_url":"https://api.github.com/users/tidewise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidewise/subscriptions","organizations_url":"https://api.github.com/users/tidewise/orgs","repos_url":"https://api.github.com/users/tidewise/repos","events_url":"https://api.github.com/users/tidewise/events{/privacy}","received_events_url":"https://api.github.com/users/tidewise/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tidewise/drivers-motors_weg_cvw300","description":"Driver library for the WEG CVW300 motor controller","fork":false,"url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300","forks_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/forks","keys_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/teams","hooks_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/hooks","issue_events_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/events{/number}","events_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/events","assignees_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/assignees{/user}","branches_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/branches{/branch}","tags_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/tags","blobs_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/statuses/{sha}","languages_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/languages","stargazers_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/stargazers","contributors_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/contributors","subscribers_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/subscribers","subscription_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/subscription","commits_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/contents/{+path}","compare_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/merges","archive_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/downloads","issues_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues{/number}","pulls_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls{/number}","milestones_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/milestones{/number}","notifications_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/labels{/name}","releases_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/releases{/id}","deployments_url":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/deployments","created_at":"2019-09-13T16:16:52Z","updated_at":"2019-10-28T17:55:50Z","pushed_at":"2019-11-29T18:06:33Z","git_url":"git://github.com/tidewise/drivers-motors_weg_cvw300.git","ssh_url":"git@github.com:tidewise/drivers-motors_weg_cvw300.git","clone_url":"https://github.com/tidewise/drivers-motors_weg_cvw300.git","svn_url":"https://github.com/tidewise/drivers-motors_weg_cvw300","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3"},"html":{"href":"https://github.com/tidewise/drivers-motors_weg_cvw300/pull/3"},"issue":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/3"},"comments":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/tidewise/drivers-motors_weg_cvw300/statuses/e2bd581949c55dcdd0706be9de58866320dc0fef"}},"author_association":"COLLABORATOR"}}
other: {"actor":{"display_login":"g-arjones"}}