payload: {"action":"created","issue":{"url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/issues/12","repository_url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe","labels_url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/issues/12/comments","events_url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/issues/12/events","html_url":"https://github.com/Materials-Consortia/OPTiMaDe/issues/12","id":332165908,"node_id":"MDU6SXNzdWUzMzIxNjU5MDg=","number":12,"title":"conflicting definitions of content of \"entries\"","user":{"login":"ltalirz","id":1053245,"node_id":"MDQ6VXNlcjEwNTMyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1053245?v=4","gravatar_id":"","url":"https://api.github.com/users/ltalirz","html_url":"https://github.com/ltalirz","followers_url":"https://api.github.com/users/ltalirz/followers","following_url":"https://api.github.com/users/ltalirz/following{/other_user}","gists_url":"https://api.github.com/users/ltalirz/gists{/gist_id}","starred_url":"https://api.github.com/users/ltalirz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltalirz/subscriptions","organizations_url":"https://api.github.com/users/ltalirz/orgs","repos_url":"https://api.github.com/users/ltalirz/repos","events_url":"https://api.github.com/users/ltalirz/events{/privacy}","received_events_url":"https://api.github.com/users/ltalirz/received_events","type":"User","site_admin":false},"labels":[{"id":964567881,"node_id":"MDU6TGFiZWw5NjQ1Njc4ODE=","url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/labels/event/workshop-2018","name":"event/workshop-2018","color":"000000","default":false},{"id":798783779,"node_id":"MDU6TGFiZWw3OTg3ODM3Nzk=","url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/labels/type/bug","name":"type/bug","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":{"login":"ltalirz","id":1053245,"node_id":"MDQ6VXNlcjEwNTMyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1053245?v=4","gravatar_id":"","url":"https://api.github.com/users/ltalirz","html_url":"https://github.com/ltalirz","followers_url":"https://api.github.com/users/ltalirz/followers","following_url":"https://api.github.com/users/ltalirz/following{/other_user}","gists_url":"https://api.github.com/users/ltalirz/gists{/gist_id}","starred_url":"https://api.github.com/users/ltalirz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltalirz/subscriptions","organizations_url":"https://api.github.com/users/ltalirz/orgs","repos_url":"https://api.github.com/users/ltalirz/repos","events_url":"https://api.github.com/users/ltalirz/events{/privacy}","received_events_url":"https://api.github.com/users/ltalirz/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltalirz","id":1053245,"node_id":"MDQ6VXNlcjEwNTMyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1053245?v=4","gravatar_id":"","url":"https://api.github.com/users/ltalirz","html_url":"https://github.com/ltalirz","followers_url":"https://api.github.com/users/ltalirz/followers","following_url":"https://api.github.com/users/ltalirz/following{/other_user}","gists_url":"https://api.github.com/users/ltalirz/gists{/gist_id}","starred_url":"https://api.github.com/users/ltalirz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltalirz/subscriptions","organizations_url":"https://api.github.com/users/ltalirz/orgs","repos_url":"https://api.github.com/users/ltalirz/repos","events_url":"https://api.github.com/users/ltalirz/events{/privacy}","received_events_url":"https://api.github.com/users/ltalirz/received_events","type":"User","site_admin":false},{"login":"coreyoses","id":10884329,"node_id":"MDQ6VXNlcjEwODg0MzI5","avatar_url":"https://avatars2.githubusercontent.com/u/10884329?v=4","gravatar_id":"","url":"https://api.github.com/users/coreyoses","html_url":"https://github.com/coreyoses","followers_url":"https://api.github.com/users/coreyoses/followers","following_url":"https://api.github.com/users/coreyoses/following{/other_user}","gists_url":"https://api.github.com/users/coreyoses/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyoses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyoses/subscriptions","organizations_url":"https://api.github.com/users/coreyoses/orgs","repos_url":"https://api.github.com/users/coreyoses/repos","events_url":"https://api.github.com/users/coreyoses/events{/privacy}","received_events_url":"https://api.github.com/users/coreyoses/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/milestones/1","html_url":"https://github.com/Materials-Consortia/OPTiMaDe/milestone/1","labels_url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/milestones/1/labels","id":3424509,"node_id":"MDk6TWlsZXN0b25lMzQyNDUwOQ==","number":1,"title":"1.0 release","description":"Add issues to this milestone if we agree they are needed before we can release the 1.0 specification (typically bug fixes and needed changes only).","creator":{"login":"giovannipizzi","id":16132028,"node_id":"MDQ6VXNlcjE2MTMyMDI4","avatar_url":"https://avatars0.githubusercontent.com/u/16132028?v=4","gravatar_id":"","url":"https://api.github.com/users/giovannipizzi","html_url":"https://github.com/giovannipizzi","followers_url":"https://api.github.com/users/giovannipizzi/followers","following_url":"https://api.github.com/users/giovannipizzi/following{/other_user}","gists_url":"https://api.github.com/users/giovannipizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/giovannipizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giovannipizzi/subscriptions","organizations_url":"https://api.github.com/users/giovannipizzi/orgs","repos_url":"https://api.github.com/users/giovannipizzi/repos","events_url":"https://api.github.com/users/giovannipizzi/events{/privacy}","received_events_url":"https://api.github.com/users/giovannipizzi/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":9,"state":"open","created_at":"2018-06-14T10:26:47Z","updated_at":"2019-06-12T06:47:10Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-06-13T21:11:42Z","updated_at":"2019-06-12T12:34:11Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There are currently two, conflicting definitions of the basic content of an \"entry\"\r\n * [Section 4.1.2](https://github.com/Materials-Consortia/OPTiMaDe/blob/v0.9.5/optimade.md#412-json-api-response-schema) describing the case of multiple entries\r\n * [Section 6.1](https://github.com/Materials-Consortia/OPTiMaDe/blob/v0.9.5/optimade.md#61-properties-used-by-multiple-entry-types) describing properties used by multiple entry types\r\n\r\nFirst of all, having two definitions seems unnecessary, since [4.2.2](https://github.com/Materials-Consortia/OPTiMaDe/blob/v0.9.5/optimade.md#422-response-schema) states: \r\n> The response for a 'single entry' endpoint is the same as for 'entry listing' endpoint responses, except that the value of the \"data\" key MUST have only one entry.\r\n\r\nSecond, one needs to decide for one of the two, in particular\r\n * `local_id` vs `id`\r\n * ~~`last_modified` vs `modification_date`~~\r\n * `immutable_id` vs nothing\r\n\r\nI'm not sure whether this decision has already been made at some point and just hasn't found its way into the spec yet, could someone please comment on that?\r\n\r\n~~Let me just reiterate that `modification_date` is a standard field in JSON schema as already pointed out in #1~~\r\n**Edit**: Issue #1 has been fixed in PR #77, keeping only `last_modified`."},"comment":{"url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/issues/comments/501252773","html_url":"https://github.com/Materials-Consortia/OPTiMaDe/issues/12#issuecomment-501252773","issue_url":"https://api.github.com/repos/Materials-Consortia/OPTiMaDe/issues/12","id":501252773,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMTI1Mjc3Mw==","user":{"login":"merkys","id":10404021,"node_id":"MDQ6VXNlcjEwNDA0MDIx","avatar_url":"https://avatars0.githubusercontent.com/u/10404021?v=4","gravatar_id":"","url":"https://api.github.com/users/merkys","html_url":"https://github.com/merkys","followers_url":"https://api.github.com/users/merkys/followers","following_url":"https://api.github.com/users/merkys/following{/other_user}","gists_url":"https://api.github.com/users/merkys/gists{/gist_id}","starred_url":"https://api.github.com/users/merkys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merkys/subscriptions","organizations_url":"https://api.github.com/users/merkys/orgs","repos_url":"https://api.github.com/users/merkys/repos","events_url":"https://api.github.com/users/merkys/events{/privacy}","received_events_url":"https://api.github.com/users/merkys/received_events","type":"User","site_admin":false},"created_at":"2019-06-12T12:34:11Z","updated_at":"2019-06-12T12:34:11Z","author_association":"CONTRIBUTOR","body":"> * `immutable_id` vs nothing\r\n\r\n@ltalirz I feel that `immutable_id` must stay in the spec as an optional field. It's use is comparable to a permalink. Providers who can't serve it can just skip the field."}}
other: {"actor":{"display_login":"merkys"}}