payload: {"action":"created","issue":{"url":"https://api.github.com/repos/syslog-ng/syslog-ng/issues/3060","repository_url":"https://api.github.com/repos/syslog-ng/syslog-ng","labels_url":"https://api.github.com/repos/syslog-ng/syslog-ng/issues/3060/labels{/name}","comments_url":"https://api.github.com/repos/syslog-ng/syslog-ng/issues/3060/comments","events_url":"https://api.github.com/repos/syslog-ng/syslog-ng/issues/3060/events","html_url":"https://github.com/syslog-ng/syslog-ng/pull/3060","id":546171355,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5ODk4Mjg4","number":3060,"title":"cmake: compile with openssl from nonstandard location","user":{"login":"furiel","id":11007226,"node_id":"MDQ6VXNlcjExMDA3MjI2","avatar_url":"https://avatars0.githubusercontent.com/u/11007226?v=4","gravatar_id":"","url":"https://api.github.com/users/furiel","html_url":"https://github.com/furiel","followers_url":"https://api.github.com/users/furiel/followers","following_url":"https://api.github.com/users/furiel/following{/other_user}","gists_url":"https://api.github.com/users/furiel/gists{/gist_id}","starred_url":"https://api.github.com/users/furiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furiel/subscriptions","organizations_url":"https://api.github.com/users/furiel/orgs","repos_url":"https://api.github.com/users/furiel/repos","events_url":"https://api.github.com/users/furiel/events{/privacy}","received_events_url":"https://api.github.com/users/furiel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2020-01-07T09:22:57Z","updated_at":"2020-01-07T09:49:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/syslog-ng/syslog-ng/pulls/3060","html_url":"https://github.com/syslog-ng/syslog-ng/pull/3060","diff_url":"https://github.com/syslog-ng/syslog-ng/pull/3060.diff","patch_url":"https://github.com/syslog-ng/syslog-ng/pull/3060.patch"},"body":"While experimenting with openssl 1.1.1, I noticed the compilation with cmake does not work. I compiled openssl with nonstandard location, and used PKG_CONFIG_PATH. I received the following error:\r\n\r\n```\r\ntests/loggen/libloggen_helper.a(loggen_helper.c.o): In function `open_ssl_connection':\r\n/home/furiel/workspace/test-syslogng/syslog-ng/tests/loggen/loggen_helper.c:256: undefined reference to `SSLv23_client_method'\r\n```\r\n\r\nThe problem was that we only used the detected openssl so only during linking: (`target_link_libraries`: `OpenSSL:SSL`). The include directories of the detected openssl were not added (`include_directories`).\r\nThe reason is: in openssl1.1.1, `SSLv23_client_method` became a define for `TLS_client_method`. So if you do not use the correct include file, loggen_helper will look for `SSLv23_client_method` symbol, which is not available in 1.1.1. If the correct include is used, loggen_helper will look for `TLS_client_method` due to the rename in define, and everything works as expected.\r\n\r\nThere were other cases where `include_directories` for openssl was missing. Those occurrences are also fixed.\r\n\r\nThe second part of the of the PR is an improvement in loggen: the `loggen_helper` module was created but was not used by `loggen` target. The source files were just added originally. From now, `loggen` will link to `loggen_helper`."},"comment":{"url":"https://api.github.com/repos/syslog-ng/syslog-ng/issues/comments/571514064","html_url":"https://github.com/syslog-ng/syslog-ng/pull/3060#issuecomment-571514064","issue_url":"https://api.github.com/repos/syslog-ng/syslog-ng/issues/3060","id":571514064,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MTUxNDA2NA==","user":{"login":"kira-syslogng","id":25661985,"node_id":"MDQ6VXNlcjI1NjYxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/25661985?v=4","gravatar_id":"","url":"https://api.github.com/users/kira-syslogng","html_url":"https://github.com/kira-syslogng","followers_url":"https://api.github.com/users/kira-syslogng/followers","following_url":"https://api.github.com/users/kira-syslogng/following{/other_user}","gists_url":"https://api.github.com/users/kira-syslogng/gists{/gist_id}","starred_url":"https://api.github.com/users/kira-syslogng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kira-syslogng/subscriptions","organizations_url":"https://api.github.com/users/kira-syslogng/orgs","repos_url":"https://api.github.com/users/kira-syslogng/repos","events_url":"https://api.github.com/users/kira-syslogng/events{/privacy}","received_events_url":"https://api.github.com/users/kira-syslogng/received_events","type":"User","site_admin":false},"created_at":"2020-01-07T09:49:10Z","updated_at":"2020-01-07T09:49:10Z","author_association":"CONTRIBUTOR","body":"Build SUCCESS\n"}}
other: {"actor":{"display_login":"kira-syslogng"}}