payload: {"action":"created","issue":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/1419","repository_url":"https://api.github.com/repos/firecracker-microvm/firecracker","labels_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/1419/labels{/name}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/1419/comments","events_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/1419/events","html_url":"https://github.com/firecracker-microvm/firecracker/pull/1419","id":527319208,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0NjE5ODg4","number":1419,"title":"Rust 1.39 Update + Spring Cleaning","user":{"login":"dhrgit","id":40801693,"node_id":"MDQ6VXNlcjQwODAxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/40801693?v=4","gravatar_id":"","url":"https://api.github.com/users/dhrgit","html_url":"https://github.com/dhrgit","followers_url":"https://api.github.com/users/dhrgit/followers","following_url":"https://api.github.com/users/dhrgit/following{/other_user}","gists_url":"https://api.github.com/users/dhrgit/gists{/gist_id}","starred_url":"https://api.github.com/users/dhrgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhrgit/subscriptions","organizations_url":"https://api.github.com/users/dhrgit/orgs","repos_url":"https://api.github.com/users/dhrgit/repos","events_url":"https://api.github.com/users/dhrgit/events{/privacy}","received_events_url":"https://api.github.com/users/dhrgit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dhrgit","id":40801693,"node_id":"MDQ6VXNlcjQwODAxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/40801693?v=4","gravatar_id":"","url":"https://api.github.com/users/dhrgit","html_url":"https://github.com/dhrgit","followers_url":"https://api.github.com/users/dhrgit/followers","following_url":"https://api.github.com/users/dhrgit/following{/other_user}","gists_url":"https://api.github.com/users/dhrgit/gists{/gist_id}","starred_url":"https://api.github.com/users/dhrgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhrgit/subscriptions","organizations_url":"https://api.github.com/users/dhrgit/orgs","repos_url":"https://api.github.com/users/dhrgit/repos","events_url":"https://api.github.com/users/dhrgit/events{/privacy}","received_events_url":"https://api.github.com/users/dhrgit/received_events","type":"User","site_admin":false},"assignees":[{"login":"dhrgit","id":40801693,"node_id":"MDQ6VXNlcjQwODAxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/40801693?v=4","gravatar_id":"","url":"https://api.github.com/users/dhrgit","html_url":"https://github.com/dhrgit","followers_url":"https://api.github.com/users/dhrgit/followers","following_url":"https://api.github.com/users/dhrgit/following{/other_user}","gists_url":"https://api.github.com/users/dhrgit/gists{/gist_id}","starred_url":"https://api.github.com/users/dhrgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhrgit/subscriptions","organizations_url":"https://api.github.com/users/dhrgit/orgs","repos_url":"https://api.github.com/users/dhrgit/repos","events_url":"https://api.github.com/users/dhrgit/events{/privacy}","received_events_url":"https://api.github.com/users/dhrgit/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2019-11-22T17:21:23Z","updated_at":"2019-11-25T10:42:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/1419","html_url":"https://github.com/firecracker-microvm/firecracker/pull/1419","diff_url":"https://github.com/firecracker-microvm/firecracker/pull/1419.diff","patch_url":"https://github.com/firecracker-microvm/firecracker/pull/1419.patch"},"body":"## Reason for This PR\r\n\r\nTidy is good, tidy is love.\r\n\r\n## Description of Changes\r\n\r\n- workspace: all sources are now placed in their respective crates, under `/src/<crate>`;\r\n- workspace: unified the jailer source under a single bin crate `/src/jailer`; removed jailer dependency from the firecracker crate;\r\n- workspace: configured the build artifacts dir via `.cargo/config`;\r\n- devctr: removed env variable used to override the cargo build dir; updated to Rust toolchain 1.39;\r\n- clippy: added safety doc comments;\r\n- vsock: switched to using zeroed memory for the TX buffer, instead of `mem::uninitialized`, since the latter is both unsafe and deprecated by Rust 1.39;\r\n- also fixed up some whitespace errors.\r\n\r\n## License Acceptance\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under\r\nthe terms of the Apache 2.0 license.\r\n\r\n## PR Checklist\r\n\r\n`[Author TODO: Meet these criteria. Where there are two options, keep one.]`  \r\n`[Reviewer TODO: Verify that these criteria are met. Request changes if not]`\r\n\r\n- [ ] All commits in this PR are signed (`git commit -s`).\r\n- [ ] Either this PR is linked to an issue, or, the reason for this PR is\r\n      clearly provided. \r\n- [ ] The description of changes is clear and encompassing.\r\n- [ ] Either no docs need to be updated as part of this PR, or, the required\r\n      doc changes are included in this PR. Docs in scope are all `*.md` files\r\n      located either in the repository root, or in the `docs/` directory.\r\n- [ ] Either no code has been touched, or, code-level documentation for touched\r\n      code is included in this PR.\r\n- [ ] Either no API changes are included in this PR, or, the API changes are\r\n      reflected in `firecracker/swagger.yaml`.\r\n- [ ] Either the changes in this PR have no user impact, or, the changes in\r\n      this PR have user impact and have been added to the `CHANGELOG.md` file.\r\n- [ ] Either no new `unsafe` code has been added, or, the newly added `unsafe`\r\n      code is unavoidable and properly documented.\r\n"},"comment":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/comments/558097408","html_url":"https://github.com/firecracker-microvm/firecracker/pull/1419#issuecomment-558097408","issue_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/1419","id":558097408,"node_id":"MDEyOklzc3VlQ29tbWVudDU1ODA5NzQwOA==","user":{"login":"acatangiu","id":31917973,"node_id":"MDQ6VXNlcjMxOTE3OTcz","avatar_url":"https://avatars3.githubusercontent.com/u/31917973?v=4","gravatar_id":"","url":"https://api.github.com/users/acatangiu","html_url":"https://github.com/acatangiu","followers_url":"https://api.github.com/users/acatangiu/followers","following_url":"https://api.github.com/users/acatangiu/following{/other_user}","gists_url":"https://api.github.com/users/acatangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/acatangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acatangiu/subscriptions","organizations_url":"https://api.github.com/users/acatangiu/orgs","repos_url":"https://api.github.com/users/acatangiu/repos","events_url":"https://api.github.com/users/acatangiu/events{/privacy}","received_events_url":"https://api.github.com/users/acatangiu/received_events","type":"User","site_admin":false},"created_at":"2019-11-25T10:42:38Z","updated_at":"2019-11-25T10:42:38Z","author_association":"CONTRIBUTOR","body":"Makes sense. I thought we enable some `Cargo` magic as well (that we were previously missing)."}}
other: {"actor":{"display_login":"acatangiu"}}