payload: {"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/356895990","pull_request_review_id":330918383,"id":356895990,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Njg5NTk5MA==","diff_hunk":"@@ -0,0 +1,18 @@\n+syntax = \"proto3\";\n+\n+package envoy.protobuf;\n+\n+option java_outer_classname = \"DescriptorProto\";\n+option java_multiple_files = true;\n+option java_package = \"io.envoyproxy.envoy.protobuf\";\n+\n+import \"google/protobuf/descriptor.proto\";\n+\n+extend google.protobuf.FieldOptions {\n+  // This option indicates that a field contains personally-identifying or otherwise sensitive data,\n+  // such as a private key or a password. It is used by `MessageUtil::redact` to determine which\n+  // fields need to be sanitized. Please note that this has no effect on standard Protobuf functions\n+  // such as `TextFormat::PrintToString`; you must explicitly call `MessageUtil::redact` wherever","path":"api/envoy/protobuf/descriptor.proto","position":15,"original_position":15,"commit_id":"4948c4bde0bd9664a52ce2f09d05355b40ef3599","original_commit_id":"4948c4bde0bd9664a52ce2f09d05355b40ef3599","user":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"body":"Let's chat about that tomorrow; I'm not sure how big a hammer we want to use, if any.","created_at":"2019-12-11T23:49:30Z","updated_at":"2019-12-11T23:49:30Z","html_url":"https://github.com/envoyproxy/envoy/pull/9315#discussion_r356895990","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/356895990"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/9315#discussion_r356895990"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315"}},"in_reply_to_id":356890221},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315","id":352020899,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMDIwODk5","html_url":"https://github.com/envoyproxy/envoy/pull/9315","diff_url":"https://github.com/envoyproxy/envoy/pull/9315.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/9315.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/9315","number":9315,"state":"open","locked":false,"title":"api: add 'redacted' option for protobuf messages, and redact SSL certs","user":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"body":"Add 'redacted' option for protobuf messages, and a MessageUtil::redact() function to clear messages with this option. Apply this to SSL certs in the admin config_dump.\r\n\r\nRisk Level: low\r\nTesting: forthcoming\r\nDocs Changes: TBD. It might be worth mentioning this behavior in the docs, not sure...\r\nRelease Notes: n/a\r\n\r\nSigned-off-by: Dan Rosen <mergeconflict@google.com>\r\n","created_at":"2019-12-11T17:05:04Z","updated_at":"2019-12-11T23:49:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87ffc3d4c0431fba07e05a045d3150d1aa4a3563","assignee":{"login":"jmarantz","id":1942589,"node_id":"MDQ6VXNlcjE5NDI1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmarantz","id":1942589,"node_id":"MDQ6VXNlcjE5NDI1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1614715540,"node_id":"MDU6TGFiZWwxNjE0NzE1NTQw","url":"https://api.github.com/repos/envoyproxy/envoy/labels/api","name":"api","color":"ededed","default":false,"description":null},{"id":1115137091,"node_id":"MDU6TGFiZWwxMTE1MTM3MDkx","url":"https://api.github.com/repos/envoyproxy/envoy/labels/waiting","name":"waiting","color":"ededed","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/9315/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/4948c4bde0bd9664a52ce2f09d05355b40ef3599","head":{"label":"mergeconflict:redacted_protobuf","ref":"redacted_protobuf","sha":"4948c4bde0bd9664a52ce2f09d05355b40ef3599","user":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"repo":{"id":161085763,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEwODU3NjM=","name":"envoy","full_name":"mergeconflict/envoy","private":false,"owner":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mergeconflict/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/mergeconflict/envoy","forks_url":"https://api.github.com/repos/mergeconflict/envoy/forks","keys_url":"https://api.github.com/repos/mergeconflict/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mergeconflict/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mergeconflict/envoy/teams","hooks_url":"https://api.github.com/repos/mergeconflict/envoy/hooks","issue_events_url":"https://api.github.com/repos/mergeconflict/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/mergeconflict/envoy/events","assignees_url":"https://api.github.com/repos/mergeconflict/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/mergeconflict/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/mergeconflict/envoy/tags","blobs_url":"https://api.github.com/repos/mergeconflict/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mergeconflict/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mergeconflict/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mergeconflict/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mergeconflict/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/mergeconflict/envoy/languages","stargazers_url":"https://api.github.com/repos/mergeconflict/envoy/stargazers","contributors_url":"https://api.github.com/repos/mergeconflict/envoy/contributors","subscribers_url":"https://api.github.com/repos/mergeconflict/envoy/subscribers","subscription_url":"https://api.github.com/repos/mergeconflict/envoy/subscription","commits_url":"https://api.github.com/repos/mergeconflict/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mergeconflict/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mergeconflict/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mergeconflict/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mergeconflict/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/mergeconflict/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mergeconflict/envoy/merges","archive_url":"https://api.github.com/repos/mergeconflict/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mergeconflict/envoy/downloads","issues_url":"https://api.github.com/repos/mergeconflict/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/mergeconflict/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/mergeconflict/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/mergeconflict/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mergeconflict/envoy/labels{/name}","releases_url":"https://api.github.com/repos/mergeconflict/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/mergeconflict/envoy/deployments","created_at":"2018-12-09T22:06:35Z","updated_at":"2019-12-11T16:28:40Z","pushed_at":"2019-12-11T23:07:24Z","git_url":"git://github.com/mergeconflict/envoy.git","ssh_url":"git@github.com:mergeconflict/envoy.git","clone_url":"https://github.com/mergeconflict/envoy.git","svn_url":"https://github.com/mergeconflict/envoy","homepage":"https://www.envoyproxy.io","size":46783,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"a10bd61e9cd505bafa58f91ec783a8224e5d94ba","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"Cloud-native high-performance edge/middle/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2019-12-11T23:21:48Z","pushed_at":"2019-12-11T23:48:22Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":46555,"stargazers_count":11738,"watchers_count":11738,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1927,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":639,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1927,"open_issues":639,"watchers":11738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/9315"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/9315"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/9315/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/9315/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/4948c4bde0bd9664a52ce2f09d05355b40ef3599"}},"author_association":"MEMBER"}}
other: {"actor":{"display_login":"mergeconflict"}}